Timeline
Feb 20, 2010:
- 10:44 PM Changeset in webkit [55061] by
-
- 13 edits in branches/safari-532-branch
<rdar://problem/7540432> Disable sandboxed iframes for branch
Reviewed by Dan Bernstein.
- Configurations/FeatureDefines.xcconfig:
WebCore:
- Configurations/FeatureDefines.xcconfig:
- WebCore.pri:
WebKit/chromium:
- features.gypi:
WebKit/mac:
- Configurations/FeatureDefines.xcconfig:
WebKitLibraries:
- win/tools/vsprops/FeatureDefines.vsprops:
WebKitTools:
- Scripts/build-webkit:
- 10:20 PM Changeset in webkit [55060] by
-
- 17 edits in branches/safari-532-branch
.: Merged from trunk:
2010-02-20 Maciej Stachowiak <mjs@apple.com>
Reviewed by David Levin.
Add an ENABLE flag for sandboxed iframes to make it possible to disable it in releases
https://bugs.webkit.org/show_bug.cgi?id=35147
- configure.ac:
JavaScriptCore: Merged from trunk:
2010-02-20 Maciej Stachowiak <mjs@apple.com>
Reviewed by David Levin.
Add an ENABLE flag for sandboxed iframes to make it possible to disable it in releases
https://bugs.webkit.org/show_bug.cgi?id=35147
- Configurations/FeatureDefines.xcconfig:
WebCore: Merged from trunk:
2010-02-20 Maciej Stachowiak <mjs@apple.com>
Reviewed by David Levin.
Add an ENABLE flag for sandboxed iframes to make it possible to disable it in releases
https://bugs.webkit.org/show_bug.cgi?id=35147
I made ENABLE(SANDBOX) only control the sandbox attribute itself;
I did not ifdef the infrastructure to make sandboxing
switchable. This is because the likely concerns about sandboxing
are not stability of the infrastructure code, but rather the fact
that the security model exposed to authors is still evolving.
- Configurations/FeatureDefines.xcconfig:
- GNUmakefile.am:
- WebCore.pri:
- html/HTMLIFrameElement.cpp:
(WebCore::HTMLIFrameElement::parseMappedAttribute):
WebKit/chromium: Merged from trunk:
2010-02-20 Maciej Stachowiak <mjs@apple.com>
Reviewed by David Levin.
Add an ENABLE flag for sandboxed iframes to make it possible to disable it in releases
https://bugs.webkit.org/show_bug.cgi?id=35147
- features.gypi:
WebKit/mac: Merged from trunk:
2010-02-20 Maciej Stachowiak <mjs@apple.com>
Reviewed by David Levin.
Add an ENABLE flag for sandboxed iframes to make it possible to disable it in releases
https://bugs.webkit.org/show_bug.cgi?id=35147
- Configurations/FeatureDefines.xcconfig:
WebKitLibraries: Merged from trunk:
2010-02-20 Maciej Stachowiak <mjs@apple.
Reviewed by David Levin.
Add an ENABLE flag for sandboxed iframes to make it possible to disable it in releases
https://bugs.webkit.org/show_bug.cgi?id=35147
- win/tools/vsprops/FeatureDefines.vsprops:
WebKitTools: Merged from trunk:
2010-02-20 Maciej Stachowiak <mjs@apple.com>
Reviewed by David Levin.
Add an ENABLE flag for sandboxed iframes to make it possible to disable it in releases
https://bugs.webkit.org/show_bug.cgi?id=35147
- Scripts/build-webkit: Handle new flag.
- 10:01 PM Changeset in webkit [55059] by
-
- 2 edits in trunk/WebCore
Reviewed by Maciej Stachowiak.
https://bugs.webkit.org/show_bug.cgi?id=35202
<rdar://problem/4856597> Calling Java method which accepts Object always passes a null argument
- bridge/jni/jsc/JNIUtilityPrivate.cpp: (JSC::Bindings::convertValueToJValue): Add cases for other JS types.
- 9:22 PM Changeset in webkit [55058] by
-
- 3 edits in trunk/WebCore
2010-02-20 Laszlo Gombos <Laszlo Gombos>
Reviewed by Darin Adler.
Fix compiler warning "suggest parentheses around"
https://bugs.webkit.org/show_bug.cgi?id=35197
No new tests as there is no new functionality.
- html/DateComponents.cpp: (WebCore::beforeGregorianStartDate):
- plugins/PluginDatabase.cpp: (WebCore::PluginDatabase::findPlugin):
- 12:44 PM Changeset in webkit [55057] by
-
- 2 edits1 move in trunk/WebKitTools
Moved simplejson into webkitpy/thirdparty directory.
Reviewed by Adam Barth.
https://bugs.webkit.org/show_bug.cgi?id=35196
- Scripts/run-chromium-webkit-tests:
- Added webkitpy/thirdparty to the script's search path.
- Scripts/webkitpy/thirdparty/simplejson: Copied from WebKitTools/simplejson.
- Copied simplejson directory.
- simplejson: Removed.
- simplejson/LICENSE.txt: Removed.
- simplejson/README.txt: Removed.
- simplejson/init.py: Removed.
- simplejson/_speedups.c: Removed.
- simplejson/decoder.py: Removed.
- simplejson/encoder.py: Removed.
- simplejson/jsonfilter.py: Removed.
- simplejson/scanner.py: Removed.
- 12:24 PM Changeset in webkit [55056] by
-
- 4 edits in trunk
2010-02-20 Noam Rosenthal <noam.rosenthal@nokia.com>
Reviewed by Laszlo Gombos.
[Qt] ENABLE_3D_RENDERING should be optional
https://bugs.webkit.org/show_bug.cgi?id=35100
- WebKit.pri: ENABLE_3D_RENDERING moved to a proper feature test
2010-02-20 Noam Rosenthal <noam.rosenthal@nokia.com>
Reviewed by Laszlo Gombos.
[Qt] ENABLE_3D_RENDERING should be optional
https://bugs.webkit.org/show_bug.cgi?id=35100
No new tests: this is a build fix.
- WebCore.pri: ENABLE_3D_RENDERING is now a proper feature test
- 11:36 AM Changeset in webkit [55055] by
-
- 6 edits1 move in trunk/WebKitTools
2010-02-20 Chris Jerdonek <Chris Jerdonek>
Reviewed by Adam Barth.
Moved BeautifulSoup to webkitpy/thirdparty directory.
- Scripts/webkitpy/BeautifulSoup.py: Removed.
- Moved to webkitpy/thirdparty.
- Scripts/webkitpy/bugzilla.py:
- Updated import statement.
- Scripts/webkitpy/bugzilla_unittest.py:
- Updated import statement.
- Scripts/webkitpy/buildbot.py:
- Updated import statement.
- Scripts/webkitpy/buildbot_unittest.py:
- Updated import statement.
- Scripts/webkitpy/statusserver.py:
- Updated import statement.
- Scripts/webkitpy/thirdparty/BeautifulSoup.py: Copied from WebKitTools/Scripts/webkitpy/BeautifulSoup.py.
- 10:22 AM Changeset in webkit [55054] by
-
- 3 edits in trunk/WebCore
Reviewed by Maciej Stachowiak.
https://bugs.webkit.org/show_bug.cgi?id=23742
Applet methods can not return arrays to JS
- bridge/jni/jsc/JNIBridgeJSC.cpp: (JavaArray::JavaArray): Don't accidentally zero out m_rootObject (that's how PassRefPtr works). Without m_rootObject, we crash quickly.
- bridge/jni/jsc/JavaInstanceJSC.cpp: (JavaInstance::invokeMethod): Do handle returned arrays. Also, added an ifdef around code that's only needed on Tiger, and removed a comment saying it can be removed when "new" plugin ships. I doubt that anyone can remember what "new" could refer to back then.
- 9:42 AM Changeset in webkit [55053] by
-
- 2 edits1 move2 adds in trunk/WebKitTools
2010-02-20 Chris Jerdonek <Chris Jerdonek>
Reviewed by Adam Barth.
Created a directory for third-party Python code, and moved
autoinstall.py into it.
- Scripts/webkitpy/init.py:
- Updated "import autoinstall" statement.
- Scripts/webkitpy/autoinstall.py: Removed.
- Moved to thirdparty/autoinstall.py.
- Scripts/webkitpy/thirdparty: Added.
- Scripts/webkitpy/thirdparty/init.py: Added.
- Scripts/webkitpy/thirdparty/autoinstall.py: Copied from WebKitTools/Scripts/webkitpy/autoinstall.py.
- 7:40 AM Changeset in webkit [55052] by
-
- 3 edits in trunk/WebCore
2010-02-20 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: re-creating view in ResourcesPanel confuses ScriptsPanel's visibleView logic.
- inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel.prototype.recreateViewForResourceIfNeeded):
- inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype.show): (WebInspector.ScriptsPanel.prototype.viewRecreated):
- 7:23 AM Changeset in webkit [55051] by
-
- 3 edits in trunk/WebCore
2010-02-20 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: need to highlight the evaluated expression used for popovers.
- inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype._mouseMove): (WebInspector.SourceFrame.prototype._hidePopup): (WebInspector.SourceFrame.prototype._mouseHover): (WebInspector.SourceFrame.prototype._showPopup.showObjectPopup): (WebInspector.SourceFrame.prototype._showPopup):
- inspector/front-end/inspector.css:
- 6:29 AM Changeset in webkit [55050] by
-
- 8 edits in trunk
Roll out 55047, since it causes regressions in layout and API tests.
- 6:29 AM Changeset in webkit [55049] by
-
- 2 edits in trunk/WebKitTools
Unreviewed, obvious fix for the python failure in our new buildbot step:
http://build.webkit.org/builders/GTK Linux 32-bit Release/builds/9075/steps/API tests/logs/err.text
- 6:13 AM Changeset in webkit [55048] by
-
- 2 edits in trunk/WebKit/gtk
2010-02-20 Gustavo Noronha Silva <Gustavo Noronha Silva>
Unreviewed. Trivial fix - unnecessary variable got added by
mistake.
- WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::dispatchDidReceiveResponse):
- 4:35 AM Changeset in webkit [55047] by
-
- 8 edits in trunk
WebCore
2010-02-19 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Reviewed by Xan Lopez.
[Soup] loses information related to message flags when converting from/to Resource{Request,Response}
https://bugs.webkit.org/show_bug.cgi?id=35093
Store message flags in WebCore objects, and set them on the
SoupMessage, when creating one from them.
No behaviour change.
- platform/network/soup/ResourceHandleSoup.cpp: (WebCore::fillResponseFromMessage):
- platform/network/soup/ResourceRequest.h: (WebCore::ResourceRequest::soupMessageFlags): (WebCore::ResourceRequest::setSoupMessageFlags):
- platform/network/soup/ResourceRequestSoup.cpp: (WebCore::ResourceRequest::toSoupMessage): (WebCore::ResourceRequest::updateFromSoupMessage):
- platform/network/soup/ResourceResponse.h: (WebCore::ResourceResponse::soupMessageFlags): (WebCore::ResourceResponse::setSoupMessageFlags):
- platform/network/soup/ResourceResponseSoup.cpp: (WebCore::ResourceResponse::toSoupMessage): (WebCore::ResourceResponse::updateFromSoupMessage):
WebKit/gtk
2010-02-18 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Reviewed by Xan Lopez.
[Soup] loses information related to message flags when converting from/to Resource{Request,Response}
https://bugs.webkit.org/show_bug.cgi?id=35093
Update the flags that are stored in the request, when the response
is received.
- WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::dispatchDidReceiveResponse):
- 4:25 AM Changeset in webkit [55046] by
-
- 3 edits in trunk/WebCore
2010-02-19 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Reviewed by Xan Lopez.
[Soup] loses information related to message flags when converting from/to Resource{Request,Response}
https://bugs.webkit.org/show_bug.cgi?id=35093
Refactor updating of ResourceResponse objects from soup message
objects, to avoid code duplication.
No behaviour change.
- platform/network/soup/ResourceHandleSoup.cpp: (WebCore::fillResponseFromMessage):
- platform/network/soup/ResourceResponseSoup.cpp: (WebCore::ResourceResponse::updateFromSoupMessage):
- 1:33 AM Changeset in webkit [55045] by
-
- 2 edits in trunk/WebCore
Reviewed by Maciej Stachowiak.
https://bugs.webkit.org/show_bug.cgi?id=35190
Don't use system malloc in Java bindings
- bridge/jni/jsc/JavaInstanceJSC.cpp: (JavaInstance::invokeMethod): Switched to WTF::Vector.
- 12:24 AM Changeset in webkit [55044] by
-
- 2 edits in trunk/WebCore
Reviewed by Maciej Stachowiak.
https://bugs.webkit.org/show_bug.cgi?id=9761
LiveConnect string conversion fails for java.lang.Object
Can't test Java in DRT (I wonder why).
- bridge/jni/jsc/JNIUtilityPrivate.cpp: (JSC::Bindings::convertValueToJValue): Added the necessary conversion. Also, removed CONVERT_NULL_TO_EMPTY_STRING dead code.
Feb 19, 2010:
- 7:06 PM Changeset in webkit [55043] by
-
- 17 edits in trunk
2010-02-19 Maciej Stachowiak <mjs@apple.com>
Reviewed by David Levin.
Add an ENABLE flag for sandboxed iframes to make it possible to disable it in releases
https://bugs.webkit.org/show_bug.cgi?id=35147
- Configurations/FeatureDefines.xcconfig:
2010-02-19 Maciej Stachowiak <mjs@apple.com>
Reviewed by David Levin.
Add an ENABLE flag for sandboxed iframes to make it possible to disable it in releases
https://bugs.webkit.org/show_bug.cgi?id=35147
- win/tools/vsprops/FeatureDefines.vsprops:
2010-02-19 Maciej Stachowiak <mjs@apple.com>
Reviewed by David Levin.
Add an ENABLE flag for sandboxed iframes to make it possible to disable it in releases
https://bugs.webkit.org/show_bug.cgi?id=35147
- features.gypi:
2010-02-19 Maciej Stachowiak <mjs@apple.com>
Reviewed by David Levin.
Add an ENABLE flag for sandboxed iframes to make it possible to disable it in releases
https://bugs.webkit.org/show_bug.cgi?id=35147
- Configurations/FeatureDefines.xcconfig:
2010-02-19 Maciej Stachowiak <mjs@apple.com>
Reviewed by David Levin.
Add an ENABLE flag for sandboxed iframes to make it possible to disable it in releases
https://bugs.webkit.org/show_bug.cgi?id=35147
I made ENABLE(SANDBOX) only control the sandbox attribute itself;
I did not ifdef the infrastructure to make sandboxing
switchable. This is because the likely concerns about sandboxing
are not stability of the infrastructure code, but rather the fact
that the security model exposed to authors is still evolving.
- Configurations/FeatureDefines.xcconfig:
- GNUmakefile.am:
- WebCore.pri:
- html/HTMLIFrameElement.cpp: (WebCore::HTMLIFrameElement::parseMappedAttribute):
2010-02-19 Maciej Stachowiak <mjs@apple.com>
Reviewed by David Levin.
Add an ENABLE flag for sandboxed iframes to make it possible to disable it in releases
https://bugs.webkit.org/show_bug.cgi?id=35147
- configure.ac:
2010-02-19 Maciej Stachowiak <mjs@apple.com>
Reviewed by David Levin.
Add an ENABLE flag for sandboxed iframes to make it possible to disable it in releases
https://bugs.webkit.org/show_bug.cgi?id=35147
- Scripts/build-webkit: Handle new flag.
- 6:08 PM Changeset in webkit [55042] by
-
- 3 edits in trunk/WebKitTools
2010-02-19 Leandro Pereira <leandro@profusion.mobi>
Reviewed by Shinichiro Hamaji.
[style-queue] should not complain about identifier names with underscores under WebKit/efl/ewk/
https://bugs.webkit.org/show_bug.cgi?id=35091
White list unix_hacker_style names in WebKit/efl/ewk because these
are used in the EFL API.
- Scripts/webkitpy/style/checker.py:
- Filter out readability/naming on WebKit/efl/ewk.
- 5:23 PM Changeset in webkit [55041] by
-
- 7 edits in trunk
Reviewed by Maciej Stachowiak.
https://bugs.webkit.org/show_bug.cgi?id=35132
<rdar://problem/7664353> Mouse cursor sometimes flickers over Flash content (35132)
WebCore:
- page/EventHandler.cpp: (WebCore::EventHandler::handleMouseMoveEvent): Don't set mouse pointer when above a plug-in or applet to prevent flicker.
WebKit:
- Plugins/WebNetscapePluginEventHandlerCarbon.mm: (WebNetscapePluginEventHandlerCarbon::mouseMoved): Send adjustCursor events on every mouse move. This matches Firefox, and is actually required for plug-ins to manipulate cursor wihout resorting to techniques such as fast firing timers.
- Plugins/WebNetscapePluginView.mm: (-[WebNetscapePluginView handleMouseEntered:]): Some plug-ins handle mouse cursor internally, but those that don't just need to get an arrow cursor (matching Firefox). This means that e.g. a plugin inside <A> won't get a finger mouse pointer.
- Plugins/WebHostedNetscapePluginView.mm: (-[WebNetscapePluginView handleMouseEntered:]): (-[WebNetscapePluginView handleMouseExited:]): Implement this behavior here, too. Also, out of process code didn't reset mouse pointer on mouse exit, which it needed to do.
- WebView/WebHTMLView.mm: (needsCursorRectsSupportAtPoint): (setCursor): (resetCursorRects): Make sure that the same workaround we have for Web content also applies to Netscape plug-ins, as AppKit would reset the mouse pointer to arrow if given a chance. (+[WebHTMLViewPrivate initialize]): Renamed setCursorIMP on Leopard and higher to prevent confusion - the method we override is completely different. (-[WebHTMLView hitTest:]): Added a FIXME about a likely bug.
- 4:51 PM Changeset in webkit [55040] by
-
- 2 edits in trunk/LayoutTests
2010-02-19 Eric Seidel <eric@webkit.org>
Reviewed by Dimitri Glazkov.
fast/forms/search-event-delay.html failed on Snow Leopard Debug Bot
https://bugs.webkit.org/show_bug.cgi?id=33543
- platform/mac-snowleopard/Skipped:
- This test prints times and expects 0.1s precision even on Debug bots. That can't work. Skipping the test to make the bots green until this can be made non-flakey or until we have a layout test system which allows "failure" expectations.
- 4:45 PM Changeset in webkit [55039] by
-
- 2 edits in trunk/WebCore
Fix regression in calculating an animated image's start time.
https://bugs.webkit.org/show_bug.cgi?id=35115
Reviewed by Adam Barth.
- platform/graphics/BitmapImage.cpp:
(WebCore::BitmapImage::startAnimation):
- 4:44 PM Changeset in webkit [55038] by
-
- 2 edits in trunk/LayoutTests
2010-02-19 Eric Seidel <eric@webkit.org>
Reviewed by Dimitri Glazkov.
editing/pasteboard/4641033.html timed out on Tiger Bot
https://bugs.webkit.org/show_bug.cgi?id=33310
- platform/mac-tiger/Skipped:
- 4:41 PM Changeset in webkit [55037] by
-
- 4 edits in trunk/WebKit/chromium
2010-02-19 James Hawkins <jhawkins@chromium.org>
Reviewed by Darin Fisher.
[Chromium] Call WebViewClient::didAcceptAutoFillSuggestion when the
user selects a suggestion from the AutoFill suggestions popup.
- public/WebViewClient.h: (WebKit::WebViewClient::didAcceptAutoFillSuggestion):
- src/AutoFillPopupMenuClient.cpp: (WebKit::AutoFillPopupMenuClient::valueChanged):
- src/AutoFillPopupMenuClient.h:
- 3:44 PM Changeset in webkit [55036] by
-
- 13 edits in trunk/WebCore
Reviewed by Geoffrey Garen.
https://bugs.webkit.org/show_bug.cgi?id=35178
LiveConnect code uses hand-rolled fprintf logging
Changed to use LOG, LOG_ERROR and ASSERT.
- platform/Logging.cpp: (WebCore::getChannelFromName):
- platform/Logging.h:
- platform/mac/LoggingMac.mm: (WebCore::InitializeLoggingChannelsIfNecessary):
- platform/win/LoggingWin.cpp: (WebCore::InitializeLoggingChannelsIfNecessary): TextConversion channel was (almost) unused, renamed to LiveConnect.
- platform/text/gtk/TextCodecGtk.cpp: (WebCore::TextCodecGtk::registerEncodingNames): The only use of this channel was in platform specific code, commandeered it for cross-platform needs.
- bridge/jni/JNIBridge.cpp:
- bridge/jni/JNIUtility.cpp: (JSC::Bindings::getJavaVM): (JSC::Bindings::getJNIEnv): (JSC::Bindings::getJNIField):
- bridge/jni/JNIUtility.h: (JSC::Bindings::callJNIMethodV): (JSC::Bindings::callJNIStaticMethod):
- bridge/jni/jni_jsobject.mm: (completedJavaScriptAccess): (dispatchToJavaScriptThread): (performJavaScriptAccess): (JavaJSObject::invoke): (JavaJSObject::call): (JavaJSObject::eval): (JavaJSObject::getMember): (JavaJSObject::setMember): (JavaJSObject::removeMember): (JavaJSObject::getSlot): (JavaJSObject::setSlot): (JavaJSObject::toString): (JavaJSObject::createNative):
- bridge/jni/jsc/JNIBridgeJSC.cpp: (JavaField::valueFromInstance): (JavaField::setValueToInstance):
- bridge/jni/jsc/JavaClassJSC.cpp: (JavaClass::JavaClass):
- bridge/jni/jsc/JavaInstanceJSC.cpp: (JavaInstance::invokeMethod): (JObjectWrapper::JObjectWrapper): (JObjectWrapper::~JObjectWrapper):
- 3:36 PM Changeset in webkit [55035] by
-
- 5 edits in trunk/JavaScriptCore
JSString::getIndex() calls value() to resolve the string value (is a rope)
to a UString, then passes the result to jsSingleCharacterSubstring without
checking for an exception. In case of out-of-memory the returned UString
is null(), which may result in an out-of-buounds substring being created.
This is bad.
Reviewed by Oliver Hunt.
Simple fix is to be able to get an index from a rope without resolving to
UString. This may be a useful optimization in some test cases.
The same bug exists in some other methods is JSString, these can be fixed
by changing them to call getIndex().
- runtime/JSString.cpp:
(JSC::JSString::resolveRope):
(JSC::JSString::getStringPropertyDescriptor):
- runtime/JSString.h:
(JSC::jsSingleCharacterSubstring):
(JSC::JSString::getIndex):
(JSC::jsSingleCharacterString):
(JSC::JSString::getStringPropertySlot):
- runtime/UStringImpl.cpp:
(JSC::singleCharacterSubstring):
- runtime/UStringImpl.h:
(JSC::UStringImpl::singleCharacterSubstring):
- 3:07 PM Changeset in webkit [55034] by
-
- 5 edits1 move in trunk/WebKitTools
2010-02-19 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Split out "prepare-rollout" from "rollout" and make --complete-rollout default
https://bugs.webkit.org/show_bug.cgi?id=33745
- Scripts/webkitpy/commands/download.py:
- Add a new AbstractRolloutPrepCommand to share code between PrepareRollout and Rollout
- Add PrepareRollout
- Scripts/webkitpy/commands/download_unittest.py: Test PrepareRollout, remove CompleteRollout tests.
- Scripts/webkitpy/steps/init.py: include ReopenBugAfterRollout step.
- Scripts/webkitpy/steps/completerollout.py: Removed.
- Scripts/webkitpy/steps/options.py: remove complete_rollout
- Scripts/webkitpy/steps/reopenbugafterrollout.py: Added.
- 3:06 PM Changeset in webkit [55033] by
-
- 2 edits in trunk/WebCore
2010-02-19 Dirk Schulze <krit@webkit.org>
Reviewed by Nikolas Zimmermann.
RenderSVGResourceMasker causes an Assert on Wind builds during DRT
https://bugs.webkit.org/show_bug.cgi?id=35182
We remove the Assert for now and return earlier, if the HashMap of the Masker
does not contain the RenderObject. The RenderObject is an identifiert to get
a already calculated mask.
A race condition during parsing can cause the invalidation call, before the mask
got calculated (only during DRT on Win build bots).
The real bug will be fixed with: https://bugs.webkit.org/show_bug.cgi?id=35181
- rendering/RenderSVGResourceMasker.cpp: (WebCore::RenderSVGResourceMasker::invalidateClient):
- 2:50 PM Changeset in webkit [55032] by
-
- 2 edits in trunk/WebKit/chromium
2010-02-19 James Hawkins <jhawkins@chromium.org>
Reviewed by Eric Seidel.
[Chromium] Use the m_suggestionsPopupClient pointer to refer to the
popup client, as the Autocomplete popup might not be the current
popup.
- src/WebViewImpl.cpp: (WebKit::WebViewImpl::autocompleteHandleKeyEvent): (WebKit::WebViewImpl::refreshSuggestionsPopup):
- 2:34 PM Changeset in webkit [55031] by
-
- 4 edits in trunk/WebKit/chromium
2010-02-19 James Hawkins <jhawkins@chromium.org>
Reviewed by Eric Seidel.
[Chromium] Rename EditorClientImpl::onAutofillSuggestionAccepted to
onAutocompleteSuggestionAccepted to better match the purpose of the
function.
- src/EditorClientImpl.cpp: (WebKit::EditorClientImpl::onAutocompleteSuggestionAccepted):
- src/EditorClientImpl.h:
- src/SuggestionsPopupMenuClient.cpp: (WebKit::SuggestionsPopupMenuClient::valueChanged):
- 2:10 PM Changeset in webkit [55030] by
-
- 5 edits in trunk/WebKit/mac
2010-02-19 Simon Fraser <Simon Fraser>
Reviewed by Dan Bernstein.
<rdar://problem/7535894> Page contents missing from snapshot on Newsweek.com article
Followup to avoid capturing compositing layers twice in snapshots. Add private
methods to WebView to specify whether drawing the WebView into an image will
include flattened compositing layers (the default behavior) or not.
- WebView/WebFrame.mm: (-[WebFrame _drawRect:contentsOnly:]): Consult the WebView flag to see if we want flattening.
- WebView/WebViewPrivate.h: New methods.
- WebView/WebView.mm: Ditto. (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]): (-[WebView _setIncludesFlattenedCompositingLayersWhenDrawingToBitmap:]): (-[WebView _includesFlattenedCompositingLayersWhenDrawingToBitmap]):
- WebView/WebViewData.h: New member variable.
- 1:44 PM Changeset in webkit [55029] by
-
- 11 edits in trunk
WebCore: Make Pasteboard::writeImage() safe against NULL cachedImages, and clean
up some code.
https://bugs.webkit.org/show_bug.cgi?id=35136
Reviewed by Darin Fisher.
- loader/ImageLoader.cpp:
(WebCore::ImageLoader::updateRenderer): Shorten some code.
- page/DragController.cpp:
(WebCore::getImage): Shorten some code.
- platform/chromium/PasteboardChromium.cpp:
(WebCore::Pasteboard::writeImage): NULL-check cachedImage().
- platform/gtk/PasteboardGtk.cpp:
(WebCore::Pasteboard::writeImage): NULL-check cachedImage().
- platform/mac/PasteboardMac.mm:
(WebCore::Pasteboard::writeImage): NULL-check cachedImage().
- platform/qt/PasteboardQt.cpp:
(WebCore::Pasteboard::writeImage): NULL-check cachedImage().
- platform/win/PasteboardWin.cpp:
(WebCore::Pasteboard::writeImage): NULL-check cachedImage().
WebKit/chromium: Add an isImageBlocked bool to the WebContextMenuData struct.
https://bugs.webkit.org/show_bug.cgi?id=35136
Reviewed by Darin Fisher.
This lets us properly enable/disable the "Copy Image" context menu entry
(and, in the future, maybe add a "Load Image" function).
- public/WebContextMenuData.h:
- src/ContextMenuClientImpl.cpp:
(WebKit::ContextMenuClientImpl::getCustomMenuFromDefaultItems):
- 1:30 PM Changeset in webkit [55028] by
-
- 2 edits in trunk/WebCore
Rubberstamped by Noam Rosenthal, who wrote the original code.
Make mouse wheel scrolling work when using the GraphicsLayer.
- platform/graphics/qt/GraphicsLayerQt.cpp:
(WebCore::GraphicsLayerQtImpl::GraphicsLayerQtImpl):
- 1:08 PM Changeset in webkit [55027] by
-
- 7 edits1 add in trunk/JavaScriptCore
2010-02-19 Oliver Hunt <oliver@apple.com>
RS = Gavin Barraclough.
Split the 32/64 version of JITPropertyAccess into a separate file.
- GNUmakefile.am:
- JavaScriptCore.gypi:
- JavaScriptCore.pri:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
- JavaScriptCore.xcodeproj/project.pbxproj:
- jit/JITPropertyAccess.cpp:
- jit/JITPropertyAccess32_64.cpp: Added. (JSC::JIT::emit_op_put_by_index): (JSC::JIT::emit_op_put_getter): (JSC::JIT::emit_op_put_setter): (JSC::JIT::emit_op_del_by_id): (JSC::JIT::emit_op_method_check): (JSC::JIT::emitSlow_op_method_check): (JSC::JIT::emit_op_get_by_val): (JSC::JIT::emitSlow_op_get_by_val): (JSC::JIT::emit_op_put_by_val): (JSC::JIT::emitSlow_op_put_by_val): (JSC::JIT::emit_op_get_by_id): (JSC::JIT::emitSlow_op_get_by_id): (JSC::JIT::emit_op_put_by_id): (JSC::JIT::emitSlow_op_put_by_id): (JSC::JIT::compileGetByIdHotPath): (JSC::JIT::compileGetByIdSlowCase): (JSC::JIT::compilePutDirectOffset): (JSC::JIT::compileGetDirectOffset): (JSC::JIT::testPrototype): (JSC::JIT::privateCompilePutByIdTransition): (JSC::JIT::patchGetByIdSelf): (JSC::JIT::patchMethodCallProto): (JSC::JIT::patchPutByIdReplace): (JSC::JIT::privateCompilePatchGetArrayLength): (JSC::JIT::privateCompileGetByIdProto): (JSC::JIT::privateCompileGetByIdSelfList): (JSC::JIT::privateCompileGetByIdProtoList): (JSC::JIT::privateCompileGetByIdChainList): (JSC::JIT::privateCompileGetByIdChain): (JSC::JIT::emit_op_get_by_pname): (JSC::JIT::emitSlow_op_get_by_pname):
- 12:30 PM Changeset in webkit [55026] by
-
- 1 edit in trunk/WebKitTools/BuildSlaveSupport/build.webkit.org-config/config.json
2010-02-19 William Siegrist <wsiegrist@apple.com>
Add GTK Linux 64-bit Release bot. Rename GTK Linux Release to GTK Linux 32-bit Release.
- 11:47 AM Changeset in webkit [55025] by
-
- 4 edits in trunk/WebKitTools
2010-02-19 Jesus Sanchez-Palencia <jesus.palencia@openbossa.org>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Need a final integration between QtLauncher and QGVLauncher
https://bugs.webkit.org/show_bug.cgi?id=35161
Add animated flip support to QtLauncher when running on QGraphicsView mode.
- QtLauncher/main.cpp: (LauncherWindow::initializeView): (LauncherWindow::setupUI):
- QtLauncher/webview.cpp: (WebViewGraphicsBased::WebViewGraphicsBased): (WebViewGraphicsBased::animatedFlip): (WebViewGraphicsBased::animatedYFlip):
- QtLauncher/webview.h: (WebViewGraphicsBased::setYRotation): (WebViewGraphicsBased::yRotation):
- 11:30 AM Changeset in webkit [55024] by
-
- 2 edits1 move in trunk/JavaScriptCore
2010-02-19 Patrick Gansterer <paroga@paroga.com>
Reviewed by Laszlo Gombos.
Added additional parameter to create_rvct_stubs
for setting the regularexpression prefix.
Renamed it because it now works for other platforms too.
https://bugs.webkit.org/show_bug.cgi?id=34951
- DerivedSources.pro:
- create_jit_stubs: Copied from JavaScriptCore/create_rvct_stubs.
- create_rvct_stubs: Removed.
- 11:22 AM Changeset in webkit [55023] by
-
- 2 edits in trunk/WebCore
2010-02-19 Nate Chapin <Nate Chapin>
Reviewed by Dimitri Glazkov.
[V8] Fix Worker crash regression in r54972
- bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::instantiateV8Object): Properly unwrap global objects when inside a WorkerContext.
- 11:09 AM Changeset in webkit [55022] by
-
- 3 edits in trunk/WebCore
Not reviewed. Reverts r55020 which causes crashes in Chromium LayoutTests
- 10:59 AM Changeset in webkit [55021] by
-
- 5 edits in trunk
Reviewed by Dan Bernstein.
https://bugs.webkit.org/show_bug.cgi?id=35165
plugins/set-status.html fails on Windows bot
- Plugins/Hosted/NetscapePluginInstanceProxy.mm: (WebKit::NetscapePluginInstanceProxy::status):
- Plugins/WebNetscapePluginView.mm: (-[WebNetscapePluginView status:]): Match Windows port behavior (and also Firefox one, in a way) - pass null status messages as empty ones to chrome.
- 9:13 AM Changeset in webkit [55020] by
-
- 3 edits in trunk/WebCore
2010-02-19 Steve Block <steveblock@google.com>
Reviewed by David Levin.
Sets default values of V8 runtime enabler flags to match behavior with JSC
https://bugs.webkit.org/show_bug.cgi?id=35095
No new tests, modifies a Chromium feature only.
- bindings/generic/RuntimeEnabledFeatures.cpp: Modified. Sets appcache and geolocation flag defaults to 'on'
- storage/Database.cpp: Modified. Sets database flag default to 'on'.
- 9:13 AM Changeset in webkit [55019] by
-
- 5 edits20 adds in trunk
[Qt] Implement textZoomIn() and textZoomOut() in DRT's EventSender, add results
for passing new tests and unskip the passing ones from the Skipped list.
https://bugs.webkit.org/show_bug.cgi?id=35159
Reviewed by Kenneth Rohde Christiansen.
WebKitTools:
- DumpRenderTree/qt/EventSenderQt.cpp:
(EventSender::textZoomIn):
(EventSender::textZoomOut):
- DumpRenderTree/qt/EventSenderQt.h:
LayoutTests:
- platform/qt/Skipped: unskip passing tests
- platform/qt/svg/custom/text-zoom-expected.txt: Added.
- platform/qt/svg/zoom: Added.
- platform/qt/svg/zoom/page: Added.
- platform/qt/svg/zoom/page/absolute-sized-document-no-scrollbars-expected.txt: Added.
- platform/qt/svg/zoom/page/absolute-sized-document-scrollbars-expected.txt: Added.
- platform/qt/svg/zoom/page/relative-sized-document-scrollbars-expected.txt: Added.
- platform/qt/svg/zoom/page/zoom-foreignObject-expected.txt: Added.
- platform/qt/svg/zoom/page/zoom-hixie-mixed-008-expected.txt: Added.
- platform/qt/svg/zoom/page/zoom-hixie-mixed-009-expected.txt: Added.
- platform/qt/svg/zoom/page/zoom-hixie-rendering-model-004-expected.txt: Added.
- platform/qt/svg/zoom/page/zoom-svg-float-border-padding-expected.txt: Added.
- platform/qt/svg/zoom/text: Added.
- platform/qt/svg/zoom/text/absolute-sized-document-no-scrollbars-expected.txt: Added.
- platform/qt/svg/zoom/text/absolute-sized-document-scrollbars-expected.txt: Added.
- platform/qt/svg/zoom/text/relative-sized-document-scrollbars-expected.txt: Added.
- platform/qt/svg/zoom/text/zoom-foreignObject-expected.txt: Added.
- platform/qt/svg/zoom/text/zoom-hixie-mixed-008-expected.txt: Added.
- platform/qt/svg/zoom/text/zoom-hixie-mixed-009-expected.txt: Added.
- platform/qt/svg/zoom/text/zoom-hixie-rendering-model-004-expected.txt: Added.
- platform/qt/svg/zoom/text/zoom-svg-float-border-padding-expected.txt: Added.
- 8:57 AM Changeset in webkit [55018] by
-
- 2 edits in trunk/WebKit/chromium
2010-02-19 Marcus Bulach <bulach@chromium.org>
Reviewed by Jeremy Orlow.
Fixes GeolocationServiceBridgeImpl::stopUpdating (it can be called multiple times).
- src/GeolocationServiceBridgeChromium.cpp: (WebKit::GeolocationServiceBridgeImpl::stopUpdating):
- 8:50 AM Changeset in webkit [55017] by
-
- 2 edits in trunk/LayoutTests
2010-02-19 Philippe Normand <pnormand@igalia.com>
Rubber-stamped by Gustavo Noronha Silva.
[GTK] fast/forms/restore-selection-after-layout.html fails on 32bits Debug build
https://bugs.webkit.org/show_bug.cgi?id=35158
- platform/gtk/Skipped: Skip failing test
- 7:16 AM Changeset in webkit [55016] by
-
- 9 edits2 adds in trunk
2010-02-19 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Pavel Feldman.
WebInspector: Elements panel: Correctly show empty elements' ending tags
for XML and HTML documents.
https://bugs.webkit.org/show_bug.cgi?id=26315
- inspector/console-dirxml-expected.txt:
- inspector/console-format-collections-expected.txt:
- inspector/console-format-expected.txt:
- inspector/elements-panel-limited-children-expected.txt:
- inspector/elements-panel-structure-expected.txt: Re-baselined due to closing tags and ellipses between opening and closing tags
- inspector/elements-panel-xhtml-structure-expected.txt: Added.
- inspector/elements-panel-xhtml-structure.xhtml: Added.
2010-02-19 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Pavel Feldman.
WebInspector: Elements panel: Correctly show empty elements' ending tags
for XML and HTML documents.
https://bugs.webkit.org/show_bug.cgi?id=26315
Test: inspector/elements-panel-xhtml-structure.xhtml
- inspector/InspectorController.cpp: (WebCore::InspectorController::populateScriptObjects):
- inspector/front-end/ElementsTreeOutline.js: (WebInspector.ElementsTreeOutline.prototype.set rootDOMNode): (WebInspector.ElementsTreeOutline.prototype.get isXMLMimeType): (WebInspector.ElementsTreeOutline.prototype._contextMenuEventFired): (WebInspector.ElementsTreeElement.prototype.onexpand): (WebInspector.ElementsTreeElement.prototype.oncollapse): (WebInspector.ElementsTreeElement.prototype.updateTitle.callback): (WebInspector.ElementsTreeElement.prototype.updateTitle): (WebInspector.ElementsTreeElement.prototype._nodeTitleInfo):
- 6:52 AM Changeset in webkit [55015] by
-
- 1 edit in trunk/LayoutTests/ChangeLog
Unreviewed Changelog typo fix.
- 6:45 AM Changeset in webkit [55014] by
-
- 2 edits in trunk/LayoutTests
Rubber-stamped by Kenneth Rohde Christiansen.
[Qt] plugins/set-status.html introduced in r5993 fails skipping it until fix.
https://bugs.webkit.org/show_bug.cgi?id=35144
- platform/qt/Skipped:
- 6:34 AM Changeset in webkit [55013] by
-
- 3 edits in trunk/WebKitTools
2010-02-19 Laszlo Gombos <Laszlo Gombos>
Reviewed by Eric Seidel.
[Qt] Clean-up the handling of HTML5 persistent data for LayoutTests
https://bugs.webkit.org/show_bug.cgi?id=35004
DumpRenderTreeQt.cpp calls QWebSettings::enablePersistentStorage which sets up
and enables all HTML5 persistent data. All the other calls for setting the
persistent path or enabling the persistent feature are redundant.
- DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::WebPage::WebPage): No need to enable AppCache again.
- DumpRenderTree/qt/main.cpp: (main): No need to setup and enable HTML5 LocalStorage again.
- 5:13 AM Changeset in webkit [55012] by
-
- 5 edits in trunk
2010-02-19 Diego Gonzalez <diego.gonzalez@openbossa.org>
Reviewed by Kenneth Rohde Christiansen.
Send the context menu event from contextClick() of EventSender
and do not show context menu in DRT.
LayoutTests:
fast/events/contextmenu-scrolled-page-with-frame.html
[Qt] DRT: Send context menu event from EventSender
https://bugs.webkit.org/show_bug.cgi?id=35131
- platform/qt/Skipped:
2010-02-19 Diego Gonzalez <diego.gonzalez@openbossa.org>
Reviewed by Kenneth Rohde Christiansen.
Send the context menu event from contextClick() of EventSender
and do not show context menu in DRT.
LayoutTests:
fast/events/contextmenu-scrolled-page-with-frame.html
[Qt] DRT: Send context menu event from EventSender
https://bugs.webkit.org/show_bug.cgi?id=35131
- DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::DumpRenderTree::DumpRenderTree):
- DumpRenderTree/qt/EventSenderQt.cpp: (EventSender::contextClick):
- 5:01 AM Changeset in webkit [55011] by
-
- 5 edits in trunk
2010-02-19 Pavel Feldman <pfeldman@chromium.org>
Not reviewed. Chromium build fix: reverting r54997 and r54998.
This is a two-sided change that should be coordinated.
- bindings/v8/custom/V8LocationCustom.cpp: (WebCore::V8Location::protocolAccessorSetter):
- platform/KURLGoogle.cpp: (WebCore::KURL::setProtocol): (WebCore::KURL::isHierarchical):
- 4:41 AM Changeset in webkit [55010] by
-
- 2 edits2 copies in trunk/LayoutTests
[Qt] editing tests fails after r54980
https://bugs.webkit.org/show_bug.cgi?id=35145
Reviewed by Kenneth Rohde Christiansen.
After r54980 two tests fail, skip them until fix.
Another two tests pass, they have same results as Win port.
- platform/qt/Skipped:
- editing/selection/extend-selection.html skipped.
- editing/selection/extend-after-mouse-selection.html skipped.
- platform/qt/editing/selection/click-in-margins-inside-editable-div-expected.txt: Copied from LayoutTests/platform/win/editing/selection/click-in-margins-inside-editable-div-expected.txt.
- platform/qt/editing/selection/click-in-padding-with-multiple-line-boxes-expected.txt: Copied from LayoutTests/platform/win/editing/selection/click-in-padding-with-multiple-line-boxes-expected.txt.
- 4:40 AM Changeset in webkit [55009] by
-
- 2 edits in trunk/WebKit/chromium
2010-02-19 Pavel Feldman <pfeldman@chromium.org>
Not reviewed. Chromium tests fix: update devtools code to match new
web inspector object proxy format.
- src/js/DebuggerAgent.js: (devtools.DebuggerAgent.prototype.formatCallFrame_): (devtools.DebuggerAgent.formatObjectProxy_):
- 4:06 AM Changeset in webkit [55008] by
-
- 2 edits in trunk/LayoutTests
2010-02-19 Philippe Normand <pnormand@igalia.com>
Rubber-stamped by Xan Lopez.
[GTK] plugins/set-status.html fails
https://bugs.webkit.org/show_bug.cgi?id=35144
- platform/gtk/Skipped: Skip failing test.
- 1:18 AM Changeset in webkit [55007] by
-
- 1 edit1 add in trunk/LayoutTests
2010-02-19 Philippe Normand <pnormand@igalia.com>
Rubber-stamped by Xan Lopez.
Adding a GTK layout test result for a new test
added in r54980.
- platform/gtk/editing/selection/extend-after-mouse-selection-expected.txt: Added.
- 1:18 AM Changeset in webkit [55006] by
-
- 1 edit1 add in trunk/LayoutTests
2010-02-19 Philippe Normand <pnormand@igalia.com>
Rubber-stamped by Xan Lopez.
Adding a GTK layout test result for a new test
added in r54982.
- platform/gtk/fast/repaint/selection-gap-overflow-scroll-2-expected.txt: Added.
- 12:30 AM Changeset in webkit [55005] by
-
- 2 edits1 add in trunk/WebCore
2010-02-17 Philippe Normand <pnormand@igalia.com>
Reviewed by Eric Seidel.
[GTK] RTP/RTSP streams playback support
https://bugs.webkit.org/show_bug.cgi?id=33662
Added live pipelines support in updateStates().
- manual-tests/video-rtsp.html: Added.
- platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivate::seek): (WebCore::MediaPlayerPrivate::updateStates):
