⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Feb 24, 2010:

11:30 PM Changeset in webkit [55226] by eric@webkit.org
  • 5 edits in trunk

2010-02-24 Sam Kerner <​skerner@chromium.org>

Reviewed by Darin Fisher.

Expose WebFrame::setCanHaveScrollbars(). This allows a view
which is being resized to not need scroll bars to ensure that
they are not drawn.

Existing function setAllowsScrolling() was renamed
setCanHaveScrollbars(), to be consistant with change 37159:
​http://trac.webkit.org/changeset/37159

​https://bugs.webkit.org/show_bug.cgi?id=35257

  • WebKit/chromium/public/WebFrame.h:
  • WebKit/chromium/src/ChromeClientImpl.cpp:
  • WebKit/chromium/src/WebFrameImpl.cpp:
  • WebKit/chromium/src/WebFrameImpl.h:
11:14 PM Changeset in webkit [55225] by eric@webkit.org
  • 4 edits in trunk/WebCore

2010-02-24 Nicholas Young <​nicholas.young@nokia.com>

Reviewed by Eric Carlson.

Add mediaPlayerOwningDocument() to MediaPlayerClient.
​https://bugs.webkit.org/show_bug.cgi?id=35374

No new tests. These are interface changes only.

  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::mediaPlayerOwningDocument): Implementation for media element.
  • html/HTMLMediaElement.h:
  • platform/graphics/MediaPlayer.h: (WebCore::MediaPlayerClient::mediaPlayerOwningDocument): New virtual method.
10:56 PM Changeset in webkit [55224] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-02-24 Andreas Kling <​andreas.kling@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

Optimized Font::normalizeSpaces() by caching the String::characters()
instead of repeatedly calling operator[]

​https://bugs.webkit.org/show_bug.cgi?id=35336

  • platform/graphics/Font.cpp: (WebCore::Font::normalizeSpaces):
10:32 PM Changeset in webkit [55223] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-02-24 Jungshik Shin <​jshin@chromium.org>

Reviewed by David Levin.

[Chromium] Traditional Chinese Chrome on Windows should use PMingLiu instead of Simsun for Han characters
​https://bugs.webkit.org/show_bug.cgi?id=35319

No visible change in the layout test.

  • platform/graphics/chromium/FontUtilsChromiumWin.cpp: (WebCore::):
10:28 PM Changeset in webkit [55222] by Martin Robinson
  • 4 edits in trunk/WebKit/gtk

2010-02-24 Krzysztof Kotlenga <​pocek@users.sf.net>

Reviewed by Gustavo Noronha Silva.

[Gtk] Creation of a WebkitWebView widget is very slow
​https://bugs.webkit.org/show_bug.cgi?id=30032

  • WebCoreSupport/EditorClientGtk.cpp: (WebKit::EditorClient::ignoreWordInSpellDocument): Change 'langs' to 'dicts' to reflect the fact that the list just holds Enchant dictionaries now. (WebKit::EditorClient::learnWord): Ditto. (WebKit::EditorClient::checkSpellingOfString): Ditto. (WebKit::EditorClient::getGuessesForWord): Ditto.
  • webkit/webkitprivate.h: Remove the now unused SpellLanguage struct.
  • webkit/webkitwebsettings.cpp: Change function call to reflect new webkit_web_settings_get_enchant_dicts name. (get_enchant_broker): Add this method which returns the enchant broker singleton. (free_spell_checking_language): The list contents have changed, so change the way each element is freed. (webkit_web_settings_finalize): Change to reflect 'spell_checking_languages_list' to 'enchant_dicts' member name change. (webkit_web_settings_set_property): Use the broker singleton here instead of making a new one for each language. The Enchant dictionary is now the list payload. (webkit_web_settings_copy): More name-change updates. (webkit_web_settings_get_enchant_dicts): Ditto.
10:15 PM Changeset in webkit [55221] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-02-24 Anthony Ricaud <​rik@webkit.org>

Reviewed by Pavel Feldman.

Web Inspector: Reduce the timer to show the eval popover
​https://bugs.webkit.org/show_bug.cgi?id=35344

  • inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype._mouseMove):
9:40 PM Changeset in webkit [55220] by eric@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

2010-02-24 Chris Evans <​cevans@chromium.org>

Reviewed by Darin Adler.

Add test for SVG that used to cause crash.
It has been fixed on trunk for a while, thanks to the <use> rewrite,
but we want to make sure we do not regress.

  • svg/dom/use-transform.svg: Added.
  • svg/dom/use-transform-expected.txt: Added.
9:24 PM Changeset in webkit [55219] by eric@webkit.org
  • 3 edits
    1 add in trunk

2010-02-24 Jay Campan <​jcampan@google.com>

Reviewed by David Levin.

Don't show the autofill popup when the input text is disabled or read only.

Test: manual-tests/chromium/no-autofill-on-readonly.html

​https://bugs.webkit.org/show_bug.cgi?id=35129

  • src/EditorClientImpl.cpp: (WebKit::EditorClientImpl::autofill):
  • manual-tests/chromium/no-autofill-on-readonly.html: Added.

2010-02-24 Jay Campan <​jcampan@google.com>

Reviewed by David Levin.

Don't show the autofill popup when the input text is disabled or read only.

​https://bugs.webkit.org/show_bug.cgi?id=35129

  • src/EditorClientImpl.cpp: (WebKit::EditorClientImpl::autofill):
9:07 PM Changeset in webkit [55218] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2010-02-24 Jesus Sanchez-Palencia <​jesus.palencia@openbossa.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] QtLauncher has a border when running on QGraphicsView mode
​https://bugs.webkit.org/show_bug.cgi?id=35352

Fix 2-pixels frame on each border of QtLauncher when running on QGraphicsView mode.

  • QtLauncher/webview.cpp: (WebViewGraphicsBased::WebViewGraphicsBased):
8:43 PM Changeset in webkit [55217] by eric@webkit.org
  • 8 edits in trunk/WebCore

2010-02-24 Dominic Mazzoni <​dmazzoni@chromium.org>

Reviewed by Jeremy Orlow.

Wraps includes of SVG headers so that it's possible to
compile the V8 bindings with SVG disabled, e.g. 'enable_svg=0'.
​https://bugs.webkit.org/show_bug.cgi?id=35345

No new tests.

  • bindings/v8/V8DOMWrapper.cpp:
  • bindings/v8/V8Proxy.cpp:
  • bindings/v8/custom/V8CSSValueCustom.cpp:
  • bindings/v8/custom/V8DocumentCustom.cpp:
  • bindings/v8/custom/V8ElementCustom.cpp:
  • bindings/v8/custom/V8EventCustom.cpp:
  • bindings/v8/custom/V8SVGElementCustom.cpp:
8:15 PM Changeset in webkit [55216] by mjs@apple.com
  • 3 edits in trunk/WebCore

Unreviewed build fix.

Fix gtk build.

Include JSC headers as runtime/ instead of JavaScriptCore/

  • bindings/js/JSDOMWrapper.h:
  • bindings/js/ScriptWrappable.h:
8:07 PM Changeset in webkit [55215] by mjs@apple.com
  • 12 edits
    2 adds in trunk/WebCore

2010-02-24 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Oliver Hunt.

Cache JavaScript wrappers inline in DOM nodes
​https://bugs.webkit.org/show_bug.cgi?id=35226

<rdar://problem/7664202>


7.4% speedup on Dromaeo DOM Core tests.
2.3% speedup on Hixie DOM Core tests.

This fixes the following things from the last attempt:

  • Now builds in both debug and release and passes all tests
  • Properly use a WeakGCPtr, not just a raw pointer, in ScriptWrappable
  • Properly look in the appropriate per-document or per-world map
  • Added an assert that would have caught any of the problems I found
  • Handle clearing the inline cache properly in all cases


  • bindings/js/JSDOMBinding.cpp: (WebCore::cacheDOMObjectWrapper): Adjust for name changes. (WebCore::forgetDOMNode): Clear wrapper pointer. (WebCore::cacheDOMNodeWrapper): Cache inline too if caching for normal world.
  • bindings/js/JSDOMBinding.h: (WebCore::Document::getWrapperCache): Inlined. (WebCore::domObjectWrapperMapFor): Renamed to start with lowercase. Moved to header to inline.
  • bindings/js/JSDOMWrapper.h: Added. (WebCore::DOMObject::DOMObject): Factored this out of JSDOMBinding.h to avoid include cycle. I think the class should be renamed, I picked a forward-looking header name because we already have a DOMObject.h
  • bindings/js/JSNodeCustom.cpp: (WebCore::createWrapperInline): Renamed version of original createWrapper. (WebCore::createWrapper): Call createWrapperInline. Out-of-line version. (WebCore::toJSNewlyCreated): Call createWrapperInline instead of createWrapper.
  • bindings/js/JSNodeCustom.h: Added. (WebCore::getCachedDOMNodeWrapper): Moved from JSDOMBinding.cpp and moved here, so it could inline everywhere without creating an include cycle. Consider inline cache. (WebCore::toJS): Moved to header to inline.
  • bindings/js/ScriptWrappable.h: (WebCore::ScriptWrappable::ScriptWrappable): Implement this in the obvious way for JavaScriptCore. (Using a WeakGCPtr). (WebCore::ScriptWrappable::wrapper): (WebCore::ScriptWrappable::setWrapper): (WebCore::ScriptWrappable::clearWrapper):
  • bindings/scripts/CodeGeneratorJS.pm: Include CustomHeader heaaders in the header, not just the impl file, so they can add inlining.
  • dom/Node.idl: Add CustomHeader directive.


Add new files to build.

  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
7:51 PM Changeset in webkit [55214] by eric@webkit.org
  • 3 edits in trunk/WebCore

2010-02-24 Jochen Eisinger <​jochen@chromium.org>

Reviewed by Jeremy Orlow.

Expose Database object of currently active task on the database thread
​https://bugs.webkit.org/show_bug.cgi?id=35341

  • storage/DatabaseThread.cpp: (WebCore::DatabaseThread::DatabaseThread): (WebCore::DatabaseThread::databaseThread):
  • storage/DatabaseThread.h: (WebCore::DatabaseThread::getDatabaseOfCurrentTask):
7:34 PM Changeset in webkit [55213] by eric@webkit.org
  • 4 edits in trunk/WebCore

2010-02-24 Nicholas Young <​nicholas.young@nokia.com>

Reviewed by Eric Carlson.

supportsMuting() should be an internal interface between MediaPlayer and MediaPlayerPrivate.
​https://bugs.webkit.org/show_bug.cgi?id=35327

No new tests. Refactoring Only.

  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::setMuted): Do not check supportsMuting() (WebCore::HTMLMediaElement::updateVolume): Set volume and muted
  • platform/graphics/MediaPlayer.cpp: (WebCore::MediaPlayer::setVolume): Check supportsMuting() (WebCore::MediaPlayer::setMuted): Check supportsMuting()
  • platform/graphics/MediaPlayer.h: Remove supportsMuting()
6:46 PM Changeset in webkit [55212] by mitz@apple.com
  • 2 edits in trunk/LayoutTests

Rubber-stamped by Anders Carlsson.

Keep this test’s behavior the same after r55203.

  • fast/dom/script-tests/prototype-inheritance-2.js: Explicitly set the inner document’s body

display property to “none”. Before r55203, this happened as a side effect of parsing the
<frameset> tag.

5:09 PM Changeset in webkit [55211] by mrowe@apple.com
  • 4 edits in trunk

Versioning.

5:07 PM Changeset in webkit [55210] by dpranke@chromium.org
  • 5 edits
    1 copy in trunk/WebKitTools

2010-02-23 Dirk Pranke <​dpranke@chromium.org>

Reviewed by David Levin.

When the run-chromium-webkit-tests code was landed and the code was
refactored into the 'port' package, I accidentally broke using
http_server.py or websocket_server.py as command-line scripts
(the constructors needed a port object they weren't getting). This
change fixes them so that --server start|stop actually works.

As a part of this, the two files need to be able to call port.get(),
but doing that is awkward from a file inside the package, so I moved
get() into factory.py and imported that into init.py so that
http_server.py and websocket_server.py can just import factory.

​https://bugs.webkit.org/show_bug.cgi?id=35316

  • Scripts/webkitpy/layout_tests/port/init.py:
  • Scripts/webkitpy/layout_tests/port/factory.py:
  • Scripts/webkitpy/layout_tests/port/http_server.py:
  • Scripts/webkitpy/layout_tests/port/websocket_server.py:
5:06 PM Changeset in webkit [55209] by mrowe@apple.com
  • 1 copy in tags/Safari-533.1

New tag.

4:58 PM Changeset in webkit [55208] by dpranke@chromium.org
  • 4 edits in trunk/WebKitTools

2010-02-24 Dirk Pranke <​dpranke@chromium.org>

Reviewed by David Levin.

Fix the function signature for check_sys_deps on the mac port, and
fix the ordering of port_obj.check_sys_deps() and
port_obj.start_helper() (helper needs to be started before we check
the system configuration).

​http://bugs.webkit.org/show_bug.cgi?id=35367

  • Scripts/webkitpy/layout_tests/port/mac.py:
  • Scripts/webkitpy/layout_tests/port/test.py:
  • Scripts/webkitpy/layout_tests/run_chromium_webkit_tests.py:
4:24 PM Changeset in webkit [55207] by pkasting@chromium.org
  • 31 edits in trunk

[Chromium API] Disambiguate allowJavaScript from didNotAllowScript
​https://bugs.webkit.org/show_bug.cgi?id=35205

Patch by Adam Barth <​abarth@webkit.org> on 2010-02-24
Reviewed by Darin Fisher.

WebCore:

For clients that want to show a user interface element when JavaScript
was blocked on a page, we need to disambiguate between querying the
client for whether JavaScript is enabled from actually failing to
execute some script.

This patch adds a new FrameLoaderClient callback for when WebCore would
like to execute JavaScript but fails to because JavaScript is disabled.

This patch also touches every client of canExecuteScripts so they can
indicate whether we should make this callback. I was hoping there was
a better choke point, but my first two attempts were wrong in subtle
ways. pkasting points out that this will be easy to screw up in the
future, so it's better to make all the clients be explicit.

  • WebCore.PluginHostProcess.exp:
  • bindings/ScriptControllerBase.cpp:

(WebCore::ScriptController::canExecuteScripts):
(WebCore::ScriptController::executeScript):

  • bindings/js/JSEventListener.cpp:

(WebCore::JSEventListener::handleEvent):

  • bindings/js/JSLazyEventListener.cpp:

(WebCore::JSLazyEventListener::initializeJSFunction):

  • bindings/js/ScheduledAction.cpp:

(WebCore::ScheduledAction::execute):

  • bindings/js/ScriptController.cpp:

(WebCore::ScriptController::bindingRootObject):
(WebCore::ScriptController::windowScriptNPObject):
(WebCore::ScriptController::jsObjectForPluginElement):
(WebCore::ScriptController::executeScriptInWorld):

  • bindings/js/ScriptController.h:

(WebCore::):

  • bindings/js/ScriptControllerMac.mm:

(WebCore::ScriptController::windowScriptObject):

  • bindings/js/ScriptDebugServer.cpp:

(WebCore::ScriptDebugServer::setJavaScriptPaused):

  • bindings/js/ScriptEventListener.cpp:

(WebCore::createAttributeEventListener):

  • bindings/js/ScriptState.cpp:

(WebCore::scriptStateFromNode):

  • bindings/v8/ScriptController.cpp:

(WebCore::ScriptController::windowScriptNPObject):
(WebCore::ScriptController::createScriptObjectForPluginElement):

  • bindings/v8/ScriptController.h:

(WebCore::):

  • bindings/v8/ScriptEventListener.cpp:

(WebCore::createAttributeEventListener):

  • bindings/v8/V8Proxy.cpp:

(WebCore::V8Proxy::retrieve):

  • dom/ScriptElement.cpp:

(WebCore::ScriptElementData::evaluateScript):

  • dom/XMLTokenizerLibxml2.cpp:

(WebCore::XMLTokenizer::startElementNs):

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::controls):

  • html/HTMLTokenizer.cpp:

(WebCore::HTMLTokenizer::parseTag):
(WebCore::HTMLTokenizer::processToken):

  • inspector/InspectorController.cpp:

(WebCore::canPassNodeToJavaScript):

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::isProcessingUserGesture):
(WebCore::FrameLoader::open):
(WebCore::FrameLoader::dispatchDidClearWindowObjectsInAllWorlds):
(WebCore::FrameLoader::dispatchDidClearWindowObjectInWorld):

  • loader/FrameLoaderClient.h:

(WebCore::FrameLoaderClient::didNotAllowScript):

WebKit/chromium:

Plumb didNotAllowScript through Chromium's WebKit API.

  • public/WebFrameClient.h:

(WebKit::WebFrameClient::didNotAllowScript):

  • src/DebuggerAgentImpl.cpp:

(WebKit::DebuggerAgentImpl::createUtilityContext):

  • src/FrameLoaderClientImpl.cpp:

(WebKit::FrameLoaderClientImpl::didNotAllowScript):

  • src/FrameLoaderClientImpl.h:
  • src/WebFrameImpl.cpp:

(WebKit::WebFrameImpl::bindToWindowObject):

WebKit/mac:

Make these two callsites explicit about not running script immediately.

  • Plugins/Hosted/NetscapePluginInstanceProxy.mm:

(WebKit::NetscapePluginInstanceProxy::getWindowNPObject):
(WebKit::NetscapePluginInstanceProxy::demarshalValueFromArray):

4:17 PM Changeset in webkit [55206] by pkasting@chromium.org
  • 6 edits in trunk/WebCore

Add call to FrameLoaderClient::allowPlugins everywhere arePluginsEnabled is called
​https://bugs.webkit.org/show_bug.cgi?id=34997

Patch by Adam Barth <​abarth@webkit.org> on 2010-02-24
Reviewed by Darin Fisher.

If we want to let the FrameLoaderClient override arePluginsEnabled,
then we need to call out to the FrameLoaderClient every time we read
the setting.

We don't have testing infrustructure for these changes, which is lame.
I'm supposed to fix that in Bug 33991.

  • dom/DOMImplementation.cpp:

(WebCore::DOMImplementation::createDocument):

  • loader/MainResourceLoader.cpp:

(WebCore::MainResourceLoader::substituteMIMETypeFromPluginDatabase):

  • loader/PluginDocument.cpp:

(WebCore::PluginTokenizer::writeRawData):

  • page/Page.cpp:

(WebCore::Page::pluginData):

  • plugins/MimeType.cpp:

(WebCore::MimeType::enabledPlugin):

3:19 PM CommitQueue edited by rik@webkit.org
commiters.py is now in webkitpy (diff)
3:17 PM Changeset in webkit [55205] by jamesr@google.com
  • 2 edits
    2 adds in trunk/WebCore

2010-02-24 James Robinson <​jamesr@chromium.org>

Reviewed by Dmitry Titov.

Do not fire focus events while a modal dialog is up.
​https://bugs.webkit.org/show_bug.cgi?id=33962

Modifies the FocusController to check the frame's page's defersLoading() flag before firing blur/focus events.
This flag is set while a modal dialog (like a window.alert or window.confirm) is up. Firing the events causes
assertion failures, since when the dialog is dismissed the PageGroupLoadDeferrer assumes that no script has run.

Manual tests only as DumpRenderTree does not support modal dialogs

  • manual-tests/modal-dialog-blur-selfclose.html: Added.
  • manual-tests/modal-dialog-blur.html: Added.
  • page/FocusController.cpp: (WebCore::dispatchEventsOnWindowAndFocusedNode):
2:58 PM Changeset in webkit [55204] by jamesr@google.com
  • 2 edits in trunk/WebKitTools

2010-02-24 James Robinson <​jamesr@chromium.org>

Reviewed by Eric Seidel.

Provide default username parameter to SVN.commit_with_message().

  • Scripts/webkitpy/scm.py:
2:48 PM Changeset in webkit [55203] by mitz@apple.com
  • 3 edits
    3 adds in trunk

<rdar://problem/7018611> innerHTML applies meta/link/title tags from a detached html element

Reviewed by Anders Carlsson.

WebCore:

Test: fast/parser/fragment-parser.html

Ensure that fragment parsing has no side effects on the fragment’s owner
document.

  • html/HTMLParser.cpp:

(WebCore::HTMLParser::insertNode): Don’t call
dispatchDocumentElementAvailable() for fragments.
(WebCore::HTMLParser::handleError): Don’t copy attributes to the owner
document’s <html> and <body> elements when a redundant <html> or <body>
is encountered while parsing a fragment.
(WebCore::HTMLParser::framesetCreateErrorCheck): Don’t change the owner
document’s <body> element’s style when parsing a fragment.
(WebCore::HTMLParser::createHead): Don’t attach the new <head> to the
ownder document of a fragment.

LayoutTests:

  • fast/parser/fragment-parser-expected.txt: Added.
  • fast/parser/fragment-parser.html: Added.
  • fast/parser/script-tests/fragment-parser.js: Added.
2:31 PM Changeset in webkit [55202] by dpranke@chromium.org
  • 2 edits in trunk/WebKitTools

squash for checkin

2:09 PM Changeset in webkit [55201] by levin@chromium.org
  • 7 edits
    2 adds in trunk/WebCore

Need to create a CanvasSurface base class for HTMLCanvasElement.
​https://bugs.webkit.org/show_bug.cgi?id=35322

Reviewed by Darin Adler.

This is an initial step in making the OffscreenCanvas object.

No new functionality so no new tests.

  • GNUmakefile.am: Added CanvasSurface to the build.
  • WebCore.gypi: ditto
  • WebCore.pro: ditto
  • WebCore.vcproj/WebCore.vcproj: ditto
  • WebCore.xcodeproj/project.pbxproj: ditto
  • dom/CanvasSurface.cpp: Added.
  • dom/CanvasSurface.h: Added.
  • html/HTMLCanvasElement.h: Made HTMLCanvasElement inherit from CanvasSurface.
1:58 PM Changeset in webkit [55200] by ap@apple.com
  • 2 edits in trunk/WebKitTools

Reviewed by Dan Bernstein.

​https://bugs.webkit.org/show_bug.cgi?id=35357
Two editing tests fail after DumpRenderTree run loop changes

AppKit decided that it wanted to group all editing commands for some reason (and thus undo
reverted them all at once).

  • DumpRenderTree/mac/DumpRenderTree.mm: (dump): Reverted the change that made DumpRenderTree use -[NSApplication run]. (runTest): Ditto. (-[DumpRenderTreeApplication isRunning]): Override isRunning with a function that always returns YES. This is another way to make the Java plug-in work.
1:52 PM Changeset in webkit [55199] by pkasting@chromium.org
  • 2 edits in trunk/WebCore

Fix regression in calculating an animated image's start time.
​https://bugs.webkit.org/show_bug.cgi?id=35115

Reviewed by Adam Barth.

  • platform/graphics/BitmapImage.cpp:

(WebCore::BitmapImage::startAnimation):

1:20 PM Changeset in webkit [55198] by oliver@apple.com
  • 6 edits in trunk

2010-02-24 Oliver Hunt <​oliver@apple.com>

Reviewed by Geoffrey Garen.

[REGRESSION in r55185] EXC_BAD_ACCESS on opening inspector.
​https://bugs.webkit.org/show_bug.cgi?id=35335

compileGetDirectOffset modifies the contents of the object register
when the object is not using the inline storage array. As the object
register contains our 'this' pointer we can't allow it to be clobbered.
The fix is simply to copy the register into a separate scratch register
when we're loading off an object that doesn't use inline storage.

  • jit/JITPropertyAccess.cpp: (JSC::JIT::privateCompileGetByIdSelfList):
  • jit/JITPropertyAccess32_64.cpp: (JSC::JIT::privateCompileGetByIdSelfList):

2010-02-24 Oliver Hunt <​oliver@apple.com>

Reviewed by Geoffrey Garen.

[REGRESSION in r55185] EXC_BAD_ACCESS on opening inspector.
​https://bugs.webkit.org/show_bug.cgi?id=35335

Add tests for caching getter lookup on large objects (eg. those not
using the inline storage array).

  • fast/js/pic/cached-getter-setter-expected.txt:
  • fast/js/pic/cached-getter-setter.html:
1:15 PM Changeset in webkit [55197] by xan@webkit.org
  • 2 edits in trunk/LayoutTests

2010-02-24 Xan Lopez <​xlopez@igalia.com>

Reviewed by Gustavo Noronha.

Unskip 3 passing cookies tests.

  • platform/gtk/Skipped:
12:51 PM Changeset in webkit [55196] by mitz@apple.com
  • 3 edits
    4 adds in trunk

<rdar://problem/7682827> Text with :first-letter lingers after being removed

Reviewed by Simon Fraser.

WebCore:

Test: fast/css/first-letter-set-text.html

  • rendering/RenderTextFragment.cpp:

(WebCore::RenderTextFragment::setTextInternal): Set this back as the
text node’s renderer, as removing the first letter has resets the node’s
renderer.

LayoutTests:

  • fast/css/first-letter-set-text-expected.checksum: Added.
  • fast/css/first-letter-set-text-expected.png: Added.
  • fast/css/first-letter-set-text-expected.txt: Added.
  • fast/css/first-letter-set-text.html: Added.
11:31 AM Changeset in webkit [55195] by Philippe Normand
  • 2 edits in trunk/LayoutTests

2010-02-24 Philippe Normand <​pnormand@igalia.com>

Rubber-stamped by Xan Lopez.

[GTK] DRT implement execCommand()
​https://bugs.webkit.org/show_bug.cgi?id=35351

Skip test that fails in GTK+.

  • platform/gtk/Skipped:
10:15 AM Changeset in webkit [55194] by Philippe Normand
  • 1 edit
    1 add in trunk/LayoutTests

2010-02-24 Philippe Normand <​pnormand@igalia.com>

Rubber-stamped by Xan Lopez.

Adding a GTK layout test result for a new test
added in r55159.

  • platform/gtk/fast/repaint/repaint-during-scroll-expected.txt: Added.
8:20 AM Changeset in webkit [55193] by ariya@webkit.org
  • 2 edits in trunk/WebCore

2010-02-24 Ariya Hidayat <​ariya.hidayat@gmail.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Faster cut-off for rectangle fill without shadow.
​https://bugs.webkit.org/show_bug.cgi?id=35337

  • platform/graphics/qt/GraphicsContextQt.cpp:
7:39 AM QtWebKitTableOfFeatures46 edited by Henry Haverinen
(diff)
7:05 AM Changeset in webkit [55192] by vestbo@webkit.org
  • 3 edits
    1 delete in trunk

[Qt] Remove QGVLauncher

Patch by Jesus Sanchez-Palencia <​jesus.palencia@openbossa.org> on 2010-02-19
Reviewed by Kenneth Rohde Christiansen.

​https://bugs.webkit.org/show_bug.cgi?id=35292

6:04 AM Changeset in webkit [55191] by xan@webkit.org
  • 2 edits in trunk

2010-02-24 Xan Lopez <​xlopez@igalia.com>

Reviewed by Gustavo Noronha.

Enable SharedWorkers by default, since that's been the default for
a long time in our build-webkit configuration.

  • configure.ac:
6:01 AM Changeset in webkit [55190] by jocelyn.turcotte@nokia.com
  • 2 edits in trunk/WebCore

[Qt] Corrects build break of QtLauncher on Windows.
The VERSION variable was not set anymore while building in trunk.

Reviewed by nobody, build fix.

  • WebCore.pro:
5:46 AM Changeset in webkit [55189] by xan@webkit.org
  • 2 edits in trunk/WebCore

2010-02-24 Xan Lopez <​xlopez@igalia.com>

Reviewed by Gustavo Noronha.

Get rid of an extra call to
setNPWindowIfNeeded. updatePluginWidget already calls this for us
if needed.

  • plugins/gtk/PluginViewGtk.cpp: (WebCore::PluginView::platformStart):
5:43 AM Changeset in webkit [55188] by Adam Roben
  • 2 edits in trunk/WebKitTools

2010-02-23 Adam Roben <Adam Roben>

Make commit-log-editor find just-added ChangeLog files

Fixes <​http://webkit.org/b/35294> commit-log-editor doesn't find
just-added ChangeLog files

Reviewed by Dave Levin.

  • Scripts/commit-log-editor: (top level): Modified the regular expression that's used to find modified ChangeLog files to also look for just-added ChangeLog files.
5:21 AM Changeset in webkit [55187] by apavlov@chromium.org
  • 6 edits in trunk/WebCore

2010-02-24 Alexander Pavlov <​apavlov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Activate/Deactivate breaks does not look consistent with rest of the toolbar.

Fix style and add the new images to the related file sets.
​https://bugs.webkit.org/show_bug.cgi?id=35307

  • WebCore.gypi:
  • inspector/front-end/Images/deactivateBreakpointsButtonGlyph.png:
  • inspector/front-end/Images/deactivateBreakpointsDisabledButtonGlyph.png:
  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/inspector.css:
4:44 AM Changeset in webkit [55186] by xan@webkit.org
  • 2 edits in trunk/WebCore

2010-02-24 Xan Lopez <​xlopez@igalia.com>

Reviewed by Gustavo Noronha.

Try to sanitize a bit the geometry management of plugins.

Stop doing contradictory things in updatePluginWidget (we were at
the same time pretending the geometry setting was delayed until
::paint and setting the geometry not once but twice) and just set
it any time the windowRect or clipRect for the plugin has changed.

This is closer to what the Mac port does, and fixes instances of
the plugins not being drawn until the window is resized or
scrolled. Other than that all manual and layout tests seems to
still work.

  • plugins/gtk/PluginViewGtk.cpp: (WebCore::PluginView::updatePluginWidget): (WebCore::PluginView::setNPWindowIfNeeded):
4:20 AM BuildingQtOnWindows edited by jocelyn.turcotte@nokia.com
(diff)
4:17 AM BuildingQtOnWindows edited by jocelyn.turcotte@nokia.com
(diff)
1:02 AM Changeset in webkit [55185] by oliver@apple.com
  • 7 edits in trunk/JavaScriptCore

2010-02-24 Oliver Hunt <​oliver@apple.com>

Reviewed by Gavin Barraclough.

Speed up getter performance in the jit
​https://bugs.webkit.org/show_bug.cgi?id=35332

Implement getter lookup caching in the interpreter.
The getter stubs are generated through basically the
same code paths as the normal get_by_id caching.
Instead of simply loading a property and returning,
we load the getter slot, and pass the getter, base value
and return address to a shared stub used for getter
dispatch.

  • jit/JIT.h: (JSC::JIT::compileGetByIdProto): (JSC::JIT::compileGetByIdSelfList): (JSC::JIT::compileGetByIdProtoList): (JSC::JIT::compileGetByIdChainList): (JSC::JIT::compileGetByIdChain):
  • jit/JITPropertyAccess.cpp: (JSC::JIT::privateCompileGetByIdProto): (JSC::JIT::privateCompileGetByIdSelfList): (JSC::JIT::privateCompileGetByIdProtoList): (JSC::JIT::privateCompileGetByIdChainList): (JSC::JIT::privateCompileGetByIdChain):
  • jit/JITPropertyAccess32_64.cpp: (JSC::JIT::privateCompileGetByIdProto): (JSC::JIT::privateCompileGetByIdSelfList): (JSC::JIT::privateCompileGetByIdProtoList): (JSC::JIT::privateCompileGetByIdChainList): (JSC::JIT::privateCompileGetByIdChain):
  • jit/JITStubs.cpp: (JSC::JITThunks::tryCacheGetByID): (JSC::DEFINE_STUB_FUNCTION):
  • jit/JITStubs.h: (JSC::):
  • runtime/GetterSetter.h:
12:51 AM Changeset in webkit [55184] by hamaji@chromium.org
  • 3 edits in trunk/WebKitTools

2010-02-24 Shinichiro Hamaji <​hamaji@chromium.org>

Reviewed by Darin Adler.

check-webkit-style false positive for WebCore forwarding header
​https://bugs.webkit.org/show_bug.cgi?id=34604

  • Scripts/webkitpy/style/checker.py:
  • Scripts/webkitpy/style/checker_unittest.py:

Feb 23, 2010:

11:40 PM Changeset in webkit [55183] by Csaba Osztrogonác
  • 2 edits
    1 add in trunk/LayoutTests

Rubber-stamped by Simon Hausmann.

[Qt] editing/execCommand/delete-image-in-anchor.html skipped
because of missing layoutTestController.execCommand()

Qt specific expected file added for editing/execCommand/insert-list-xml.xhtml
introduced in r55167, because of different font types.

  • platform/qt/Skipped: editing/execCommand/delete-image-in-anchor.html skipped.
  • platform/qt/editing/execCommand/insert-list-xml-expected.txt: Added.
11:14 PM Changeset in webkit [55182] by oliver@apple.com
  • 3 edits in trunk/WebCore

2010-02-23 Geoff Garen <​ggaren@apple.com>

Reviewed by Oliver Hunt.

Simplify animation lifetime handling. Previously we manually
determined whether our base element was safe when we unregistered
our listener, now we simply ensure that the base element itself
registers and unregisters the animation listener.

  • svg/animation/SVGSMILElement.cpp: (WebCore::ConditionEventListener::create): (WebCore::ConditionEventListener::disconnectAnimation): (WebCore::ConditionEventListener::ConditionEventListener): (WebCore::ConditionEventListener::operator==): (WebCore::ConditionEventListener::handleEvent): (WebCore::SVGSMILElement::eventBaseFor): (WebCore::SVGSMILElement::connectConditions): (WebCore::SVGSMILElement::disconnectConditions):
  • svg/animation/SVGSMILElement.h:
8:27 PM Changeset in webkit [55181] by oliver@apple.com
  • 5 edits in trunk

2010-02-23 Oliver Hunt <​oliver@apple.com>

Reviewed by Maciej Stachowiak.

Web Inspector: Regression: r55027+: Inspector broken
​https://bugs.webkit.org/show_bug.cgi?id=35253

op_get_by_id_getter_chain was not passing the correct this parameter.
The bug was caused by incorrect use of baseCell instead of baseValue,
baseValue contains the original object for the lookup (and hence the
correct this object), baseCell is clobbered as part of walking the
prototype chain.

  • interpreter/Interpreter.cpp: (JSC::Interpreter::privateExecute):

2010-02-23 Oliver Hunt <​oliver@apple.com>

Reviewed by Maciej Stachowiak.

Web Inspector: Regression: r55027+: Inspector broken
​https://bugs.webkit.org/show_bug.cgi?id=35253

Add thorough testing of getter access to hit the various
possible caching scenarios.

  • fast/js/pic/cached-getter-setter-expected.txt:
  • fast/js/pic/cached-getter-setter.html:
7:43 PM Google Summer of Code 2010 edited by pkasting@google.com
(diff)
6:05 PM Changeset in webkit [55180] by dimich@chromium.org
  • 3 edits in trunk/WebCore

Chromium: Use V8::TerminateExecution to actually terminate workers.
​https://bugs.webkit.org/show_bug.cgi?id=35137

Reviewed by David Levin.

Test: existing fast/workers/stress-js-execution.html which is currently failing
on Mac and Linux bots for Chromium.

  • bindings/v8/WorkerContextExecutionProxy.cpp:

(WebCore::WorkerContextExecutionProxy::evaluate):

  • bindings/v8/WorkerScriptController.cpp:

(WebCore::WorkerScriptController::forbidExecution):

5:53 PM Changeset in webkit [55179] by enrica@apple.com
  • 3 edits
    2 adds in trunk

REGRESSION: WebKit crashes when deleting images on blogger.com (34957)
<rdar://problem/7651935>
​https://bugs.webkit.org/show_bug.cgi?id=34957

Reviewed by Simon Fraser.

WebCore:

Fixing a regression introduced with revision 53085. Anchor elements should not be considered
in editable content when calculating the position in the parent before the node.

Test: editing/execCommand/delete-image-in-anchor.html

  • dom/Position.cpp:

(WebCore::Position::getInlineBoxAndOffset):

LayoutTests:

  • editing/execCommand/delete-image-in-anchor-expected.txt: Added.
  • editing/execCommand/delete-image-in-anchor.html: Added.
5:46 PM Changeset in webkit [55178] by tony@chromium.org
  • 3 edits
    2 adds in trunk

2010-02-23 Tony Chang <​tony@chromium.org>

Reviewed by Eric Seidel.

​https://bugs.webkit.org/show_bug.cgi?id=34634
Pasting a list into the middle of another list item should split the target
list item into two separate list items. This matches the behavior in other
browsers.

  • editing/pasteboard/paste-list-004-expected.txt: Added.
  • editing/pasteboard/paste-list-004.html: Added.

2010-02-23 Tony Chang <​tony@chromium.org>

Reviewed by Eric Seidel.

​https://bugs.webkit.org/show_bug.cgi?id=34634
Pasting a list into the middle of another list item should split the target
list item into two separate list items. This matches the behavior in other
browsers.

Test: editing/pasteboard/paste-list-004.html

  • editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::insertAsListItems):
5:22 PM Changeset in webkit [55177] by ap@apple.com
  • 7 edits
    7 adds
    4 deletes in trunk

Reviewed by Mark Rowe.

​https://bugs.webkit.org/show_bug.cgi?id=22602
Enable Java in DumpRenderTree (on Mac)

LayoutTests:

  • fast/dom/java-applet-calls-expected.txt: Removed.
  • fast/dom/java-applet-calls.html: Removed.
  • fast/dom/resources/TestApplet.class: Removed.
  • fast/dom/resources/TestApplet.java: Removed. This test was added in a failing form, even though it never worked. The new tests cover everything it was meant to cover.
  • java/SharedApplet.java: Added. This class will have methods for simple tests, but it's also possible to just add new source files.
  • java/Makefile: Added. Compile all .java files in the directory.
  • java: Added.
  • java/argument-to-object-type-expected.txt: Added.
  • java/argument-to-object-type.html: Added.
  • java/array-return-expected.txt: Added.
  • java/array-return.html: Added. Added tests for recently fixed bugs.
  • platform/gtk/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped: Java tests only work on Mac currently.

WebKitTools:

  • DumpRenderTree/mac/DumpRenderTree.mm: (exitApplicationRunLoop): (dump): (runTest): DumpRenderTree now runs an NSApplication, not just an event loop. This way, the Java plug-in can start without freezing.
  • Scripts/run-webkit-tests: Compile java sources in LayputTests/java.
4:56 PM Changeset in webkit [55176] by oliver@apple.com
  • 1 edit
    1 add in trunk/LayoutTests

2010-02-23 Oliver Hunt <​oliver@apple.com>

Add expected result

  • svg/custom/animate-use-crash-expected.txt: Added.
4:49 PM Changeset in webkit [55175] by oliver@apple.com
  • 1 edit
    1 add in trunk/LayoutTests

2010-02-23 Oliver Hunt <​oliver@apple.com>

Reviewed by Maciej Stachowiak.

Add a testcase for an old bug to ensure it doesn't return.

  • svg/custom/animate-use-crash.xhtml: Added.
3:34 PM Google Summer of Code 2010 edited by jeremy@chromium.org
(diff)
3:01 PM Google Summer of Code 2010 created by jeremy@chromium.org
GSoC 2010 page - in case we want to participate
2:59 PM Changeset in webkit [55174] by eric@webkit.org
  • 3 edits in trunk

2010-02-23 James Choi <​jchoi42@pha.jhu.edu>

Add Solaris definitions
​https://bugs.webkit.org/show_bug.cgi?id=35214

  • WebKit/chromium/src/WebViewImpl.cpp
  • WebKit/chromium/src/WebFrameImpl.cpp
2:43 PM Changeset in webkit [55173] by eric@webkit.org
  • 4 edits
    2 adds in trunk

2010-02-23 Arno Renevier <​arno@renevier.net>

Reviewed by Gustavo Noronha Silva.

[Gtk]: testwebview does not work when called with absolute path
​https://bugs.webkit.org/show_bug.cgi?id=34940

When testwebview is called as absolute path, chdir to executable
directory before searching resource files.

  • GNUmakefile.am:
2:39 PM Changeset in webkit [55172] by beidson@apple.com
  • 12 edits in trunk

Regression (r55107) - WebInspector docking is busted.
​https://bugs.webkit.org/show_bug.cgi?id=35274

Reviewed by Tim Hatcher and Pavel Feldman.

WebCore:

  • inspector/InspectorController.cpp:

(WebCore::InspectorController::canAttachWindow): Use the minimum height for this calculation,

not the preferred height.

(WebCore::InspectorController::attachWindow): attachWindow() shouldn't decide the policy, as it is

often called partway through the show or dock procedure after some of the initial conditions have
changed. Let the front-end itself and the InspectorClient's make the policy decision at the start
of the show/dock operation.

  • inspector/InspectorFrontendHost.cpp:

(WebCore::InspectorFrontendHost::canAttachWindow):

  • inspector/InspectorFrontendHost.h:
  • inspector/InspectorFrontendHost.idl:
  • inspector/front-end/inspector.js:

(WebInspector.toggleAttach): Before attaching, ask the front-end-host if attaching is allowed.

WebKit/mac:

  • WebCoreSupport/WebInspectorClient.mm:

(-[WebInspectorWindowController showWindow:]): Swap the order of the "should attach?" check

to get the expected behavior.

WebKit/win:

  • WebCoreSupport/WebInspectorClient.cpp:

(WebInspectorClient::showWindowWithoutNotifications): Swap the order of the "should attach?" check

to get the expected behavior.

LayoutTests:

  • inspector/timeline-event-dispatch.html: Actually click in the right place now that the inspector isn't docked anymore.
2:17 PM Changeset in webkit [55171] by eric@webkit.org
  • 3 edits in trunk/WebKit/chromium

2010-02-23 James Hawkins <​jhawkins@chromium.org>

Reviewed by Darin Fisher.

[Chromium] Implement WebDocument::getElementsByTagName.

​https://bugs.webkit.org/show_bug.cgi?id=35272

  • public/WebDocument.h:
  • src/WebDocument.cpp: (WebKit::WebDocument::getElementsByTagName):
2:03 PM Changeset in webkit [55170] by jberlin@webkit.org
  • 2 edits in trunk/WebKitSite

2010-02-23 Jessie Berlin <​jberlin@webkit.org>

Reviewed by Eric Seidel and Adam Roben.

Debugging WebKit on Windows should mention WebKit.sln as an alternative to running debug-safari.
​https://bugs.webkit.org/show_bug.cgi?id=35098

  • building/debug.html: Add instructions on how to build and run WebKit from within Visual Studio.
2:01 PM Changeset in webkit [55169] by mrowe@apple.com
  • 2 edits in trunk/WebCore

<​http://webkit.org/b/35287> ImageSourceCG::frameIsCompleteAtIndex returns false for all frames until image has completed loading

Reviewed by Geoff Garen.

CGImageSourceGetStatusAtIndex claims that all frames of a multi-frame image are incomplete when we've not yet received the
complete data for an image that is using an incremental data source (<rdar://problem/7679174>). We work around this by
special-casing all frames except the last in an image and treating them as complete if they are present and reported as
being incomplete. We do this on the assumption that loading new data can only modify the existing last frame or append new
frames. The last frame is only treated as being complete if the image source reports it as such. This ensures that it is
truly the last frame of the image rather than just the last that we currently have data for.

  • platform/graphics/cg/ImageSourceCG.cpp:

(WebCore::ImageSource::frameIsCompleteAtIndex):

1:31 PM Changeset in webkit [55168] by kov@webkit.org
  • 2 edits in trunk/WebKit/gtk/po

2010-02-23 Mario Blättermann <​mariobl@freenet.de>

Reviewed by Gustavo Noronha.

German translation update.

  • de.po:
1:31 PM Changeset in webkit [55167] by enrica@apple.com
  • 6 edits
    2 adds in trunk

WebCore: Crash in createContextualFragment when inserting a list in a non HTML document.
<rdar://problem/7666670>
​https://bugs.webkit.org/show_bug.cgi?id=35305

Reviewed by Darin Adler.

createFragmentFromMarkup did not handle correctly the case where documentElement is
not an HTMLElement. The static cast to HTMLElement was causing createContextualFragment to
crash.

Test: editing/execCommand/insert-list-xml.xhtml

  • dom/Element.cpp:

(WebCore::Element::createContextualFragment): Added.

  • dom/Element.h: Added createContextualFragment virtual function.
  • editing/markup.cpp:

(WebCore::createFragmentFromMarkup): Removed static cast to HTMLElement.

  • html/HTMLElement.cpp:

(WebCore::HTMLElement::createContextualFragment): Modified to perform only checks
that are specific for an HTMLElement object. The rest of the logic has been moved to the
corresponding method in the Element class.

LayoutTests: Crash in createContextualFragment when inserting a list in a non HTML document.
<rdar://problem/7666670>
​https://bugs.webkit.org/show_bug.cgi?id=35305

Reviewed by Darin Adler.

  • editing/execCommand/insert-list-xml-expected.txt: Added.
  • editing/execCommand/insert-list-xml.xhtml: Added.
1:25 PM Changeset in webkit [55166] by kov@webkit.org
  • 2 edits in trunk/WebKit/gtk/po

2010-02-23 Daniel Nylander <​po@danielnylander.se>

Reviewed by Gustavo Noronha.

Swedish translation update.

  • sv.po:
1:20 PM Changeset in webkit [55165] by kov@webkit.org
  • 1 edit
    1 add in trunk/WebKit/gtk/po

2010-02-23 Ankit Patel <​ankit@redhat.com>

Reviewed by Gustavo Noronha.

Gujarati translation.

  • gu.po: Added.
1:13 PM Changeset in webkit [55164] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2010-02-23 Jesus Sanchez-Palencia <​jesus.palencia@openbossa.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Need a final integration between QtLauncher and QGVLauncher
​https://bugs.webkit.org/show_bug.cgi?id=35292

WebKit coding style fixes.

  • QtLauncher/main.cpp: (LauncherWindow::resetZoom):
12:39 PM Changeset in webkit [55163] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2010-02-23 Jesus Sanchez-Palencia <​jesus.palencia@openbossa.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Need a final integration between QtLauncher and QGVLauncher
​https://bugs.webkit.org/show_bug.cgi?id=35292

Add cloneWindow feature to QtLauncher, when running on QGraphicsView mode.

  • QtLauncher/main.cpp: (LauncherWindow::LauncherWindow): (LauncherWindow::~LauncherWindow): (LauncherWindow::init): (LauncherWindow::cloneWindow): (LauncherWindow::setupUI):
12:07 PM Changeset in webkit [55162] by sfalken@apple.com
  • 2 edits in trunk/WebCore

2010-02-23 Steve Falkenburg <​sfalken@apple.com>

Reviewed by Adam Roben.

WebCore should stop throwing away the CGImageSourceRef on Windows to improve GIF performance
​https://bugs.webkit.org/show_bug.cgi?id=35309

  • platform/graphics/cg/ImageSourceCG.cpp: (WebCore::ImageSource::clear):
10:15 AM Changeset in webkit [55161] by dpranke@chromium.org
  • 2 edits in trunk/WebKitTools

fix check_wdiff_install

10:07 AM Changeset in webkit [55160] by kov@webkit.org
  • 2 edits in trunk/JavaScriptCore

2010-02-23 Gustavo Noronha Silva <Gustavo Noronha Silva>

Rubber-stamped by Dimitri Glazkov.

Chromium build fix.

9:54 AM Changeset in webkit [55159] by mitz@apple.com
  • 3 edits
    4 adds in trunk

WebKit/mac: <rdar://problem/7611158> Incomplete repaint of YouTube timeline thumb while scrolling
​https://bugs.webkit.org/show_bug.cgi?id=34381

Reviewed by Simon Fraser.

Test: fast/repaint/repaint-during-scroll.html

NSClipView offsets any rects marked as needing display during scrolling
by the scroll offset. Compensate for this when -setNeedsDisplay: is called
during scrolling.

  • WebView/WebHTMLView.mm:

(-[WebHTMLView _frameOrBoundsChanged]): Set inScrollPositionChanged to YES
around to call to FrameView::scrollPositionChanged().
(-[WebHTMLView setNeedsDisplayInRect:]): When called beneath
scrollPositionChanged(), adjust the rect by the inverse of the scroll offset.

LayoutTests: Rubber-stamped by Simon Fraser.

<rdar://problem/7611158> Incomplete repaint of YouTube timeline thumb while scrolling
​https://bugs.webkit.org/show_bug.cgi?id=34381

  • fast/repaint/repaint-during-scroll.html: Added.
  • platform/mac/fast/repaint/repaint-during-scroll-expected.checksum: Added.
  • platform/mac/fast/repaint/repaint-during-scroll-expected.png: Added.
  • platform/mac/fast/repaint/repaint-during-scroll-expected.txt: Added.
9:52 AM Changeset in webkit [55158] by kov@webkit.org
  • 10 edits in trunk

2010-02-23 Leandro Pereira <​leandro@profusion.mobi>

Reviewed by Gustavo Noronha Silva.

Changes references of GOwnPtr to reflect their new place.
​http://webkit.org/b/35084

9:41 AM Changeset in webkit [55157] by beidson@apple.com
  • 9 edits
    5 adds in trunk

HTTP 307 after a 303 after a POST re-sends POST data from the original request.
<rdar://problem/7390251> and ​https://bugs.webkit.org/show_bug.cgi?id=31410

Reviewed by Alexey Proskuryakov.

WebCore:

Test: http/tests/loading/307-after-303-after-post.html

Remember the last HTTP method send out during a redirect chain for a resource handle:

  • platform/network/ResourceHandle.cpp:

(WebCore::ResourceHandle::lastHTTPMethod):

  • platform/network/ResourceHandle.h:
  • platform/network/ResourceHandleInternal.h:

(WebCore::ResourceHandleInternal::ResourceHandleInternal):

Refer to the last HTTP method used instead of the original method:

  • platform/network/cf/ResourceHandleCFNet.cpp:

(WebCore::willSendRequest):
(WebCore::ResourceHandle::willSendRequest):

  • platform/network/mac/ResourceHandleMac.mm:

(WebCore::ResourceHandle::willSendRequest):
(-[WebCoreResourceHandleAsDelegate connection:willSendRequest:redirectResponse:]):

LayoutTests:

  • http/tests/loading/307-after-303-after-post.html: Added.
  • http/tests/loading/resources/303-to-307-target.php: Added.
  • http/tests/loading/resources/307-post-output-target.php: Added.
  • http/tests/loading/resources/post-to-303-target.php: Added.
  • platform/gtk/Skipped:
  • platform/qt/Skipped:
9:27 AM Changeset in webkit [55156] by dbates@webkit.org
  • 2 edits in trunk/WebCore

2010-02-23 Crystal Zhang <​haizhang@rim.com>

Unreviewed build fix.

Fix build error when enable plugin proxy: 'toRenderEmbeddedObject' identifier not found.
As RenderEmbeddedObject inherits RenderPartObject and 'toRenderEmbeddedObject' belongs
to former one.

  • html/HTMLMediaElement.cpp:
8:53 AM Changeset in webkit [55155] by eric@webkit.org
  • 3 edits in trunk/WebCore

2010-02-23 Evan Martin <​evan@chromium.org>

Reviewed by Jeremy Orlow.

[chromium] fix previous SVG-disabling patch
​https://bugs.webkit.org/show_bug.cgi?id=35298

  • WebCore.gypi: rename variable
  • WebCore.gyp/WebCore.gyp: actually use the variable
8:32 AM Changeset in webkit [55154] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-02-23 Michael Lotz <​mmlr@mlotz.ch>

Reviewed by David Levin.

[Haiku] Fix conversion from BString to String
​https://bugs.webkit.org/show_bug.cgi?id=35082

The previous patch to this file was broken (sorry). First of all,
the conversion from UTF8 was accidentally removed. Second, for
empty strings, we need to point the implementation at StringImpl::empty().

Covered by existing tests.

  • platform/text/haiku/StringHaiku.cpp: (WebCore::String::String):
8:00 AM Changeset in webkit [55153] by vestbo@webkit.org
  • 2 edits in trunk/WebCore

[Qt] Prevent the media backend from handling non-audio or -video mime types

Reviewed by Eric Carlson.

  • platform/graphics/qt/MediaPlayerPrivateQt.cpp:
7:46 AM Changeset in webkit [55152] by evan@chromium.org
  • 5 edits in trunk/WebCore

2010-02-23 Evan Martin <​evan@chromium.org>

Reviewed by Jeremy Orlow.

[chromium] Allow building without SVG
​https://bugs.webkit.org/show_bug.cgi?id=31522

  • WebCore.gyp/WebCore.gyp, WebCore.gypi: test enable_svg flag.
  • bindings/v8/custom/V8SVGDocumentCustom.cpp, bindings/v8/custom/V8SVGPathSegCustom.cpp: test ENABLE(SVG).
7:28 AM Changeset in webkit [55151] by eric@webkit.org
  • 3 edits in trunk/WebKitTools

2010-02-23 Leandro Pereira <​leandro@profusion.mobi>

Reviewed by NOBODY.

Fix false positives for 'delete *pointer' statements.
​http://webkit.org/b/35235

  • WebKitTools/Scripts/webkitpy/style/processors/cpp.py:
7:21 AM Changeset in webkit [55150] by kov@webkit.org
  • 7 edits in trunk

2010-02-23 Leandro Pereira <​leandro@profusion.mobi>

Reviewed by Gustavo Noronha Silva.

Fixes references to GOwnPtr and GRefPtr so the GTK+ port builds
again.
​http://webkit.org/b/35084

6:35 AM Companies and Organizations that have contributed to WebKit edited by skyul@company100.net
(diff)
6:21 AM Changeset in webkit [55149] by eric@webkit.org
  • 2 edits
    4 moves
    1 add in trunk/JavaScriptCore

2010-02-23 Leandro Pereira <​leandro@profusion.mobi>

Reviewed by Kenneth Rohde Christiansen.

Adding the EFL implementation of JavaScriptCore.
See ​https://bugs.webkit.org/show_bug.cgi?id=35084 for details.

  • GNUmakefile.am: Updated to reflect the new location of GOwnPtr and

GRefPtr.

  • wtf/efl/MainThreadEfl.cpp: Added.
  • wtf/gobject/GOwnPtr.cpp: Moved from wtf/gtk.
  • wtf/gobject/GOwnPtr.h: Moved from wtf/gtk.
  • wtf/gobject/GRefPtr.cpp: Moved from wtf/gtk.
  • wtf/gobject/GRefPtr.h: Moved from wtf/gtk.
6:17 AM Changeset in webkit [55148] by ariya@webkit.org
  • 2 edits in trunk/WebCore

2010-02-23 Ariya Hidayat <​ariya.hidayat@gmail.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Faster cut-off for rectangle drawing without shadow.
​https://bugs.webkit.org/show_bug.cgi?id=35267

  • platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::drawRect):
6:05 AM Changeset in webkit [55147] by eric@webkit.org
  • 7 edits in trunk

2010-02-23 Steve Block <​steveblock@google.com>

Reviewed by Jeremy Orlow.

Removes redundant Settings::setGeolocationEnabled and Settings::geolocationEnabled
​https://bugs.webkit.org/show_bug.cgi?id=35242

No new tests, removing dead code only.

  • page/Settings.cpp:
  • page/Settings.h:

2010-02-23 Steve Block <​steveblock@google.com>

Reviewed by Jeremy Orlow.

Removes redundant Settings::setGeolocationEnabled and Settings::geolocationEnabled
​https://bugs.webkit.org/show_bug.cgi?id=35242

This removes Chromium's WebSettings::setGeolocationEnabled

  • public/WebSettings.h:
  • src/WebSettingsImpl.cpp:
  • src/WebSettingsImpl.h:
5:12 AM Changeset in webkit [55146] by eric@webkit.org
  • 8 edits in trunk

2010-02-23 Ben Murdoch <​benm@google.com>

Reviewed by Eric Seidel.

pageX/Y co-ordinates of TouchEvent should be 0,0
​https://bugs.webkit.org/show_bug.cgi?id=35239

Update layout tests to reflect the WebCore changes in this bug.

  • fast/events/touch/basic-multi-touch-events-expected.txt: Updated.
  • fast/events/touch/basic-single-touch-events-expected.txt: Updated.
  • fast/events/touch/script-tests/basic-multi-touch-events.js: (verifyTouchEvent): Add checking of TouchEvent.pageX/Y
  • fast/events/touch/script-tests/basic-single-touch-events.js: (verifyTouchEvent): ditto.

2010-02-23 Ben Murdoch <​benm@google.com>

Reviewed by Eric Seidel.

pageX/Y co-ordinates of TouchEvent should be 0,0
​https://bugs.webkit.org/show_bug.cgi?id=35239

The co-ordinates attached to a touch event are not used for tracking touch motion, rather the co-ordinates attached to Touches within the touch event should be used. Set the co-ordinates on the event itself to 0 to avoid confusion and match observed iPhone behavior.

  • page/EventHandler.cpp: (WebCore::EventHandler::handleTouchEvent): Set the pageX/Y and screenX/Y co-ordinates attached to the touch event to 0,0 to match observed behavior on the iPhone.
  • page/EventHandler.h: Remove now unused members m_firstTouchScreenPos and m_firstTouchPagePos.
4:53 AM Changeset in webkit [55145] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-02-23 Stephan Aßmus <​superstippi@gmx.de>

Reviewed by Eric Seidel.

[Haiku] Various improvements to EventHandlerHaiku.
​https://bugs.webkit.org/show_bug.cgi?id=34685

Covered by existing tests.

Fix the build by not including PlatformScrollBar.h.

  • page/haiku/EventHandlerHaiku.cpp: (WebCore::isKeyboardOptionTab):

Use the correct keycode for tab keys.

(WebCore::EventHandler::focusDocumentView):

Use proper locking. In any case, Haiku doesn't append platform
widgets to WebCore widgets. But if it did, this implementation
would be correct.

(WebCore::EventHandler::passWidgetMouseDownEventToWidget):

Implemented.

(WebCore::EventHandler::eventActivatedView):

Removed notImplemented() and added note.

(WebCore::EventHandler::passMousePressEventToSubframe):

Implemented.

(WebCore::EventHandler::passMouseMoveEventToSubframe):

Implemented.

(WebCore::EventHandler::passMouseReleaseEventToSubframe):

Implemented.

(WebCore::EventHandler::accessKeyModifiers):

Added note.

4:43 AM Changeset in webkit [55144] by hamaji@chromium.org
  • 7 edits in trunk

2010-02-23 Shinichiro Hamaji <​hamaji@chromium.org>

Reviewed by Eric Seidel.

[Gtk] Implement layoutTestController.numberOfPages
​https://bugs.webkit.org/show_bug.cgi?id=35228

  • platform/gtk/Skipped:

2010-02-23 Shinichiro Hamaji <​hamaji@chromium.org>

Reviewed by Eric Seidel.

[Gtk] Implement layoutTestController.numberOfPages
​https://bugs.webkit.org/show_bug.cgi?id=35228

  • webkit/webkitprivate.h:
  • webkit/webkitwebframe.cpp: (webkit_web_frame_number_of_pages):

2010-02-23 Shinichiro Hamaji <​hamaji@chromium.org>

Reviewed by Eric Seidel.

[Gtk] Implement layoutTestController.numberOfPages
​https://bugs.webkit.org/show_bug.cgi?id=35228

  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::numberOfPages):
4:27 AM Changeset in webkit [55143] by tony@chromium.org
  • 3 edits
    2 deletes in trunk

2010-02-23 Tony Chang <​tony@chromium.org>

Not reviewed.
Revert r55135 because the layout test is failing on all the bots.
​https://bugs.webkit.org/show_bug.cgi?id=34634

  • editing/pasteboard/paste-list-004-expected.txt: Removed.
  • editing/pasteboard/paste-list-004.html: Removed.

2010-02-23 Tony Chang <​tony@chromium.org>

Not reviewed.
Revert r55135 because the layout test is failing on all the bots.
​https://bugs.webkit.org/show_bug.cgi?id=34634

  • editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::insertAsListItems):
4:07 AM Changeset in webkit [55142] by steveblock@google.com
  • 7 edits
    2 adds in trunk/WebCore

Adds cache to store Geolocation positions between browser sessions.
​https://bugs.webkit.org/show_bug.cgi?id=34084

Reviewed by Ariya Hidayat.

This is required to fully implement the Geolocation maximumAge property.
See Bug 30676.

No new tests, will add tests for maximumAge once complete.

  • Android.mk: Modified. Added GeolocationPositionCache.cpp
  • GNUmakefile.am: Modified. Added GeolocationPositionCache.[cpp|h]
  • WebCore.gypi: Modified. Added GeolocationPositionCache.[cpp|h]
  • WebCore.pro: Modified. Added GeolocationPositionCache.[cpp|h]
  • WebCore.vcproj/WebCore.vcproj: Modified. Added GeolocationPositionCache.[cpp|h]
  • WebCore.xcodeproj/project.pbxproj: Modified. Added GeolocationPositionCache.[cpp|h]
  • page/GeolocationPositionCache.cpp: Added.

(WebCore::GeolocationPositionCache::GeolocationPositionCache):
(WebCore::GeolocationPositionCache::~GeolocationPositionCache):
(WebCore::GeolocationPositionCache::setCachedPosition):
(WebCore::GeolocationPositionCache::cachedPosition):
(WebCore::GeolocationPositionCache::setDatabasePath):
(WebCore::GeolocationPositionCache::readFromDB):
(WebCore::GeolocationPositionCache::writeToDB):

  • page/GeolocationPositionCache.h: Added.
4:04 AM Changeset in webkit [55141] by eric@webkit.org
  • 3 edits
    2 adds in trunk

2010-02-23 Yuta Kitamura <​yutak@chromium.org>

Reviewed by Dan Bernstein.

Fix alignment of vertical-align: text-bottom inside an inline-block.

This patch is based on a fix provided by Takahito Hirano.

display: inline-block + vertical-align: text-bottom causes misalignment.
​https://bugs.webkit.org/show_bug.cgi?id=30846

  • fast/inline-block/inline-block-vertical-align-2.html: Added.
  • fast/inline-block/inline-block-vertical-align-2-expected.txt: Added.

2010-02-23 Yuta Kitamura <​yutak@chromium.org>

Reviewed by Dan Bernstein.

Fix alignment of vertical-align: text-bottom inside an inline-block.

This patch is based on a fix provided by Takahito Hirano.

display: inline-block + vertical-align: text-bottom causes misalignment.
​https://bugs.webkit.org/show_bug.cgi?id=30846

Test: fast/inline-block/inline-block-vertical-align-2.html

  • rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelObject::verticalPosition): Fixed vpos calculation. We cannot cut corners for inline blocks, since they may have their own text metrics.
3:43 AM Changeset in webkit [55140] by steveblock@google.com
  • 3 edits in trunk/WebCore

Sets default values of V8 runtime enabler flags to match behavior with JSC
​https://bugs.webkit.org/show_bug.cgi?id=35095

3:25 AM Changeset in webkit [55139] by eric@webkit.org
  • 2 edits in trunk/WebKit/gtk

2010-02-23 José Millán Soto <​jmillan@igalia.com>

Reviewed by Xan Lopez.

[Gtk] Server message not shown on http authentication
​https://bugs.webkit.org/show_bug.cgi?id=34219

  • webkit/webkitsoupauthdialog.c: (show_auth_dialog): Server message is displayed, messageLabel and message variables were renamed to avoid confusion.
3:09 AM Changeset in webkit [55138] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-02-23 Stephan Aßmus <​superstippi@gmx.de>

Reviewed by Eric Seidel.

[Haiku] Fix various issues in keyboard event generation.
​https://bugs.webkit.org/show_bug.cgi?id=34685

Covered by existing tests.

Fixed backspace keycode.
Fixed using the appropriate fields from the Haiku event for mapping
to the VK_* codes and added mapping a great deal more codes.
Added extraction of modifier key flags.
Completed implementation of disambiguateKeyDownEvent()
Implemented currentCapsLockState().

  • platform/haiku/PlatformKeyboardEventHaiku.cpp: (WebCore::keyIdentifierForHaikuKeyCode): (WebCore::windowsKeyCodeForKeyEvent): (WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent): (WebCore::PlatformKeyboardEvent::disambiguateKeyDownEvent): (WebCore::PlatformKeyboardEvent::currentCapsLockState):
2:53 AM Changeset in webkit [55137] by eric@webkit.org
  • 4 edits in trunk/WebKit/chromium

2010-02-23 Dmitriy Belenko <​dbelenko@google.com>

Reviewed by Darin Fisher.

Chromium: Need to be able to get the bounds of selection
rectangle(s)
​https://bugs.webkit.org/show_bug.cgi?id=34915

This change will enable about 30 test cases to pass in Chromium.
All of these test cases are related to selection rect boundaries.
This change will enable the test cases to retrieve the selection
rect boundary rectangle for the current selection.

  • public/WebFrame.h:
  • src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::selectionBoundsRect):
  • src/WebFrameImpl.h:
2:35 AM Changeset in webkit [55136] by steveblock@google.com
  • 20 edits in trunk

Adds Client::cancelGeolocationPermissionRequestForFrame and ChromeClient::cancelGeolocationPermissionRequestForFrame
​https://bugs.webkit.org/show_bug.cgi?id=34962

These methods are required so that a Geolocation object can cancel an
asynchronous permission request. This allows the chrome client to cancel
any UI it is showing for the permission request.

2:19 AM Changeset in webkit [55135] by eric@webkit.org
  • 3 edits
    2 adds in trunk

2010-02-23 Tony Chang <​tony@chromium.org>

Reviewed by Eric Seidel.

​https://bugs.webkit.org/show_bug.cgi?id=34634
Pasting a list into the middle of another list item should split the target
list item into two separate list items. This matches the behavior in other
browsers.

  • editing/pasteboard/paste-list-004-expected.txt: Added.
  • editing/pasteboard/paste-list-004.html: Added.

2010-02-23 Tony Chang <​tony@chromium.org>

Reviewed by Eric Seidel.

​https://bugs.webkit.org/show_bug.cgi?id=34634
Pasting a list into the middle of another list item should split the target
list item into two separate list items. This matches the behavior in other
browsers.

Test: editing/pasteboard/paste-list-004.html

  • editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::insertAsListItems):
2:03 AM Changeset in webkit [55134] by eric@webkit.org
  • 3 edits in trunk/WebKitTools

2010-02-23 Laszlo Gombos <Laszlo Gombos>

Reviewed by Kenneth Rohde Christiansen.

[Qt] QtLauncher should not use internal JavaScriptCore and WebCore interfaces
​https://bugs.webkit.org/show_bug.cgi?id=35248

  • QtLauncher/QtLauncher.pro:
  • QtLauncher/utils.h:
1:55 AM Changeset in webkit [55133] by jocelyn.turcotte@nokia.com
  • 2 edits in trunk/WebCore

[Qt] Correct build problems while building QtWebKit inside Qt.
​https://bugs.webkit.org/show_bug.cgi?id=34975

Reviewed by Laszlo Gombos.

  • WebCore.pro: Change the condition !standalone_package to !QTDIR_build
1:47 AM Changeset in webkit [55132] by eric@webkit.org
  • 5 edits in trunk/WebCore

2010-02-23 Noam Rosenthal <​noam.rosenthal@nokia.com>

Reviewed by Ariya Hidayat.

[Qt] Connect video with accelerated compositing
​https://bugs.webkit.org/show_bug.cgi?id=35276

MediaControlPrivate and GraphicsLayer are patched together via
a shared PlatformLayer (QGraphicsItem). This patch makes sure that the
QGraphicsVideoItem from MediaControl becomes part of the scene
associsated with GraphicsLayer

Test: ​http://double.co.nz/video_test/test1.html with AC turned on

  • platform/graphics/qt/GraphicsLayerQt.cpp: (WebCore::GraphicsLayerQtImpl::): mediaLayer member (WebCore::GraphicsLayerQtImpl::opaqueArea): video is opaque (WebCore::GraphicsLayerQtImpl::paint): don't paint video (WebCore::GraphicsLayerQtImpl::flushChanges): flush mediaLayer (WebCore::GraphicsLayerQt::setContentsToMedia): notify
  • platform/graphics/qt/GraphicsLayerQt.h: reimp setContentsToMedia
  • platform/graphics/qt/MediaPlayerPrivateQt.cpp: (WebCore::MediaPlayerPrivate::MediaPlayerPrivate): m_compositing (WebCore::MediaPlayerPrivate::paint): don't paint if compositing (WebCore::MediaPlayerPrivate::acceleratedRenderingStateChanged): reimp from MediaPlayerPrivateInterface to support AC (WebCore::MediaPlayerPrivate::platformLayer): ditto
  • platform/graphics/qt/MediaPlayerPrivateQt.h: (WebCore::MediaPlayerPrivate::supportsAcceleratedRendering): ditto
1:31 AM Changeset in webkit [55131] by eric@webkit.org
  • 3 edits in trunk/WebKitTools

2010-02-23 Daniel Bates <​dbates@rim.com>

Reviewed by Eric Seidel.

​https://bugs.webkit.org/show_bug.cgi?id=34439

Prompts a person for their SVN username if not already cached (by Subversion).

Currently, webkit-patch is unable to commit to the SVN repo. unless the
WebKit SVN username is already cached (from of a prior commit by hand)
because "svn commit" (called by webkit-patch) defaults to using the system
login name unless the username is already cached or specified on the
command line.

  • Scripts/webkitpy/scm.py: Added methods SVN.has_authorization_for_realm and modified SVN.commit_with_message to call it. Added optional username parameter to method SVN.commit_with_message.
  • Scripts/webkitpy/scm_unittest.py: Added unit test methods: SVNTest.test_commit_with_username, SVNTest.test_has_authorization_for_realm, and SVNTest.test_not_have_authorization_for_realm.
1:14 AM Changeset in webkit [55130] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-02-23 Stephan Aßmus <​superstippi@gmx.de>

Reviewed by Eric Seidel.

Fix various issues in PlatformWheelEventHaiku.
​https://bugs.webkit.org/show_bug.cgi?id=34685

Covered by existing tests.

Fixed coding style violations.
Synced extracting the correct coordinates with Haiku WebKit implementation.
Added extracting modifier key flags.

  • platform/haiku/PlatformWheelEventHaiku.cpp: (WebCore::PlatformWheelEvent::PlatformWheelEvent):
1:02 AM Changeset in webkit [55129] by xan@webkit.org
  • 2 edits in trunk/WebKit/gtk

2010-02-23 Xan Lopez <​xlopez@igalia.com>

Reviewed by Gustavo Noronha.

Do not do unnecessary work during size_allocate.

FrameView::resize will already queue a layout, so there's no need
to force one ourselves. On top of that, the layout function
already adjusts the view size when needed, so there's no need to
do that manually either. No change in the layout tests or unit
tests after this.

  • webkit/webkitwebview.cpp: (webkit_web_view_size_allocate):
12:58 AM Changeset in webkit [55128] by eric@webkit.org
  • 4 edits in trunk/WebCore

2010-02-23 Laszlo Gombos <Laszlo Gombos>

Reviewed by Eric Seidel.

Build fix for PluginView
​https://bugs.webkit.org/show_bug.cgi?id=35230

No new tests, build fix only.

  • plugins/PluginView.cpp:
  • plugins/PluginView.h:
  • plugins/PluginViewNone.cpp:
12:42 AM Changeset in webkit [55127] by eric@webkit.org
  • 2 edits in trunk

2010-02-23 Diego Escalante Urrelo <​descalante@igalia.com>

Reviewed by Eric Seidel.

[gtk] missing libsoup-2.4 package in gir generation
​https://bugs.webkit.org/show_bug.cgi?id=35199

Include libsoup-2.4 package in gobject introspection .gir generation.

  • GNUmakefile.am:
12:26 AM Changeset in webkit [55126] by eric@webkit.org
  • 1 edit
    1 add in trunk/WebCore

2010-02-23 Kwang Yul Seo <​skyul@company100.net>

Reviewed by Eric Seidel.

[BREWMP] Port ScriptController::createScriptInstanceForWidget
​https://bugs.webkit.org/show_bug.cgi?id=34413

  • bindings/js/ScriptControllerBrew.cpp: Added. (WebCore::ScriptController::createScriptInstanceForWidget):
12:19 AM Changeset in webkit [55125] by Philippe Normand
  • 3 edits in trunk/LayoutTests

2010-02-18 Philippe Normand <​pnormand@igalia.com>

Reviewed by Eric Seidel.

media/video-display-aspect-ratio.html fails
​https://bugs.webkit.org/show_bug.cgi?id=34933

Original patch by Eric Carlson.

  • media/content/test-par-16-9.mp4: Change the width of the video track from 426.666 to 426.
  • platform/mac-leopard/Skipped: Unskip the test, it should pass now.
12:09 AM Changeset in webkit [55124] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-02-23 José Millán Soto <​jmillan@igalia.com>

Reviewed by Eric Seidel.

[Gtk] Webkit crashes when using orca
​https://bugs.webkit.org/show_bug.cgi?id=35169

Made webkit_accessible_text_get_caret_offset check if end selection
node is null.

  • accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (webkit_accessible_text_get_caret_offset):
Note: See TracTimeline for information about the timeline view.