Timeline
Feb 26, 2010:
- 11:01 PM Changeset in webkit [55347] by
-
- 13 edits in trunk
2010-02-26 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: reload inspected page on Cmd+R / Ctrl+R / F5 key event in inspector.
Drive-by fix for couple of minor front-end problems.
- inspector/InspectorBackend.cpp: (WebCore::InspectorBackend::reloadPage):
- inspector/InspectorBackend.h:
- inspector/InspectorBackend.idl:
- inspector/InspectorController.cpp: (WebCore::InspectorController::didFinishLoading): (WebCore::InspectorController::didFailLoading):
- inspector/front-end/InspectorBackendStub.js: (.WebInspector.InspectorBackendStub.prototype.reloadPage):
- inspector/front-end/InspectorFrontendHostStub.js: (.WebInspector.InspectorFrontendHostStub.prototype.copyText): (.WebInspector.InspectorFrontendHostStub.prototype.canAttachWindow):
- inspector/front-end/TextViewer.js: (WebInspector.TextViewer.prototype._paintLine):
- inspector/front-end/inspector.js: (WebInspector.documentKeyDown): (WebInspector.toggleAttach):
WebKit/chromium
- src/WebDevToolsFrontendImpl.cpp: (WebKit::WebDevToolsFrontendImpl::WebDevToolsFrontendImpl): (WebKit::WebDevToolsFrontendImpl::jsCanAttachWindow):
- src/WebDevToolsFrontendImpl.h:
- src/js/InspectorControllerImpl.js: (devtools.InspectorBackendImpl): (devtools.InspectorBackendImpl.prototype.toggleNodeSearch):
- 10:22 PM Changeset in webkit [55346] by
-
- 2 edits in trunk/WebKit/chromium
2010-02-26 James Hawkins <jhawkins@chromium.org>
Reviewed by Darin Fisher.
[Chromium] Verify that the Nodes being enumerated are HTML elements.
- src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::forms):
- 10:06 PM Changeset in webkit [55345] by
-
- 1 edit5 adds in trunk/WebCore
2010-02-26 Leandro Pereira <leandro@profusion.mobi>
Reviewed by NOBODY.
Add EFL port files to platform/efl.
http://webkit.org/b/35087
- platform/efl/ScrollbarEfl.cpp: Added.
- platform/efl/EventLoopEfl.cpp: Added.
- platform/efl/PlatformKeyboardEventEfl.cpp: Added.
- platform/efl/DragImageEfl.cpp: Added.
- platform/efl/PlatformMouseEventEfl.cpp: Added.
- 9:49 PM Changeset in webkit [55344] by
-
- 1 edit3 adds in trunk/WebCore
2010-02-26 Leandro Pereira <leandro@profusion.mobi>
Reviewed by NOBODY.
Add EFL port files to platform/efl.
http://webkit.org/b/35087
- platform/efl/CursorEfl.cpp: Added.
- platform/efl/LocalizedStringsEfl.cpp: Added.
- platform/efl/SearchPopupMenuEfl.cpp: Added.
- 9:32 PM Changeset in webkit [55343] by
-
- 1 edit5 adds in trunk/WebCore
2010-02-26 Leandro Pereira <leandro@profusion.mobi>
Reviewed by NOBODY.
Add EFL port files to page/efl.
http://webkit.org/b/35087
- WebCore/page/efl/DragControllerEfl.cpp: Added.
- WebCore/page/efl/FrameEfl.cpp: Added.
- WebCore/page/efl/AccessibilityObjectEfl.cpp: Added.
- WebCore/page/efl/EventHandlerEfl.cpp: Added.
- 9:16 PM Changeset in webkit [55342] by
-
- 1 edit6 adds in trunk/WebCore
2010-02-26 Leandro Pereira <leandro@profusion.mobi>
Reviewed by NOBODY.
Add EFL port files to platform/efl.
http://webkit.org/b/35087
- WebCore/platform/efl/LoggingEfl.cpp: Added.
- WebCore/platform/efl/ScrollbarThemeEfl.cpp: Added.
- WebCore/platform/efl/TemporaryLinkStubs.cpp: Added.
- WebCore/platform/efl/ScrollViewEfl.cpp: Added.
- WebCore/platform/efl/SharedBufferEfl.cpp: Added.
- WebCore/platform/efl/DragDataEfl.cpp: Added.
- 8:59 PM Changeset in webkit [55341] by
-
- 3 edits in trunk/WebKitTools
2010-02-26 Dirk Pranke <dpranke@chromium.org>
Reviewed by Adam Barth.
Change the default port for new-run-webkit-tests when running on
a Mac from 'chromium-mac' to 'mac'. Add a '--chromium' switch to
pick up the default platform-specific version of chromium instead.
- Scripts/webkitpy/layout_tests/port/factory.py:
- Scripts/webkitpy/layout_tests/run_webkit_tests.py:
- 8:42 PM Changeset in webkit [55340] by
-
- 1 edit1 add in trunk/WebCore
2010-02-26 Leandro Pereira <leandro@profusion.mobi>
Reviewed by NOBODY.
Add EFL port files to platform/efl.
http://webkit.org/b/35087
- WebCore/platform/efl/RenderThemeEfl.cpp: Added.
- 7:53 PM Changeset in webkit [55339] by
-
- 2 edits in trunk/WebKitTools
010-02-26 Dirk Pranke <dpranke@chromium.org>
Unreviewed, build fix
third time's the charm getting this path right?
- pywebsocket/mod_pywebsocket/standalone.py:
- 7:53 PM Changeset in webkit [55338] by
-
- 1 edit5 adds in trunk/WebCore
2010-02-26 Leandro Pereira <leandro@profusion.mobi>
Reviewed by NOBODY.
Add EFL port files to platform/efl.
http://webkit.org/b/35087
- WebCore/platform/efl/PlatformWheelEventEfl.cpp: Added.
- WebCore/platform/efl/FileChooserEfl.cpp: Added.
- WebCore/platform/efl/ContextMenuEfl.cpp: Added.
- WebCore/platform/efl/PlatformScreenEfl.cpp: Added.
- WebCore/platform/efl/WidgetEfl.cpp: Added.
- 7:42 PM Changeset in webkit [55337] by
-
- 2 edits in trunk/WebKitTools
Unreviewed, build fix.
- pywebsocket/mod_pywebsocket/standalone.py:
- 7:27 PM Changeset in webkit [55336] by
-
- 1 edit1 move1 add in trunk/WebKitTools
Moving the script to the right location.
Reviewed by NOBODY (OOPS!).
- pywebsocket/mod_pywebsocket: Added.
- pywebsocket/mod_pywebsocket/standalone.py: Copied from WebKitTools/pywebsocket/standalone.py.
- pywebsocket/standalone.py: Removed.
- 7:20 PM Changeset in webkit [55335] by
-
- 7 edits in trunk
2010-02-26 Adam Barth <abarth@webkit.org>
Reviewed by Darin Fisher.
Expose an API for ports to add schemes to the mixed content whitelist
https://bugs.webkit.org/show_bug.cgi?id=35438
Add a notion of a "secure" scheme that doesn't trigger mixed content
warnings. Let folks register new secure schemes in the same way they
can register "local" schemes.
- loader/FrameLoader.cpp: (WebCore::FrameLoader::isMixedContent):
- page/SecurityOrigin.cpp: (WebCore::secureSchemes): (WebCore::SecurityOrigin::registerURLSchemeAsSecure): (WebCore::SecurityOrigin::shouldTreatURLSchemeAsSecure):
- page/SecurityOrigin.h:
2010-02-26 Adam Barth <abarth@webkit.org>
Reviewed by Darin Fisher.
Expose an API for ports to add schemes to the mixed content whitelist
https://bugs.webkit.org/show_bug.cgi?id=35438
Expose registerURLSchemeAsSecure via the WebKit API.
- public/WebSecurityPolicy.h:
- src/WebSecurityPolicy.cpp: (WebKit::WebSecurityPolicy::registerURLSchemeAsSecure):
- 6:59 PM Changeset in webkit [55334] by
-
- 2 edits in trunk/WebCore
2010-02-26 Noam Rosenthal <noam.rosenthal@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] GraphicsLayerQt: artifacts and wrong transformOrigin
This was due to wrong way of applying cache-mode and transformation
on a graphics-item with HTML. Cache-mode should be updated
when the content type updates, even if it was the same cache-mode
Test URL attached to the bug now works correctly.
- platform/graphics/qt/GraphicsLayerQt.cpp: (WebCore::GraphicsLayerQtImpl::computeTransform): (WebCore::GraphicsLayerQtImpl::flushChanges):
- 6:51 PM Changeset in webkit [55333] by
-
- 2 edits in trunk/WebKitTools
Unreviewed, fixing the license.
- pywebsocket/standalone.py:
- 6:43 PM Changeset in webkit [55332] by
-
- 3 edits in trunk/WebCore
2010-02-26 Luiz Agostini <luiz.agostini@openbossa.org>
Reviewed by Kenneth Rohde Christiansen.
Qt/Mac: Revert null timer removal (r51105)
https://bugs.webkit.org/show_bug.cgi?id=35396
r51105 removed the null timer event of the carbon event model. This however
breaks the flash of many sites.
Applying patch suggested by Girish Ramakrishnan in bug comment #1.
- plugins/PluginView.h:
- plugins/mac/PluginViewMac.cpp: (WebCore::PluginView::platformStart): (WebCore::PluginView::handleMouseEvent): (WebCore::PluginView::nullEventTimerFired): (WebCore::PluginView::mousePosForPlugin):
- 6:25 PM Changeset in webkit [55331] by
-
- 2 edits in trunk/WebCore
2010-02-26 Noam Rosenthal <noam.rosenthal@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Compile error with 3d-canvas
Replaced a direct gl call with a getProcAddress call
https://bugs.webkit.org/show_bug.cgi?id=35448
No new tests.
- platform/graphics/qt/GraphicsContext3DQt.cpp: (WebCore::GraphicsContext3D::blendColor):
- 6:08 PM Changeset in webkit [55330] by
-
- 1 edit1 add in trunk/WebCore
2010-02-26 Kwang Yul Seo <skyul@company100.net>
Reviewed by Kenneth Rohde Christiansen.
[BREWMP] Port EventHandler
https://bugs.webkit.org/show_bug.cgi?id=34796
Add platform-specific code required to implement EventHandler.
- page/brew/EventHandlerBrew.cpp: Added. (WebCore::EventHandler::tabsToAllControls): (WebCore::EventHandler::focusDocumentView): (WebCore::EventHandler::passWidgetMouseDownEventToWidget): (WebCore::EventHandler::passMouseDownEventToWidget): (WebCore::EventHandler::eventActivatedView): (WebCore::EventHandler::passSubframeEventToSubframe): (WebCore::EventHandler::passWheelEventToWidget): (WebCore::EventHandler::passMousePressEventToSubframe): (WebCore::EventHandler::passMouseMoveEventToSubframe): (WebCore::EventHandler::passMouseReleaseEventToSubframe): (WebCore::EventHandler::accessKeyModifiers):
- 5:51 PM Changeset in webkit [55329] by
-
- 1 edit2 adds in trunk/WebKitTools
Adding pywebsocket/standalone.py back to fix the Chromium webkit
canaries. Once all layout tests pass, we can get in the patch that
moves this directorty to WebKitTools/Scripts, update all Chromium
scripts, and revert this patch.
Reviewed by Adam Barth.
https://bugs.webkit.org/show_bug.cgi?id=35464
- pywebsocket: Added.
- pywebsocket/standalone.py: Added.
- 5:51 PM Changeset in webkit [55328] by
-
- 1 edit8 adds in trunk/WebCore
2010-02-26 Leandro Pereira <leandro@profusion.mobi>
Reviewed by NOBODY.
Add EFL port files to platform/efl.
http://webkit.org/b/35087
- WebCore/platform/efl/ClipboardEfl.cpp: Added.
- WebCore/platform/efl/PopupMenuEfl.cpp: Added.
- WebCore/platform/efl/SharedTimerEfl.cpp: Added.
- WebCore/platform/efl/RenderThemeEfl.h: Added.
- WebCore/platform/efl/Language.cpp: Added.
- WebCore/platform/efl/CookieJarEfl.cpp: Added.
- WebCore/platform/efl/MIMETypeRegistryEfl.cpp: Added.
- 5:34 PM Changeset in webkit [55327] by
-
- 2 edits in trunk
2010-02-26 Arno Renevier <arno@renevier.net>
Reviewed by Gustavo Noronha Silva.
[Gtk] ignore WebKit/gtk/docs/GNUmakefile.in in .gitignore
https://bugs.webkit.org/show_bug.cgi?id=35424
- .gitignore:
- 5:17 PM Changeset in webkit [55326] by
-
- 2 edits in trunk/WebCore
2010-02-26 Robert Kroeger <rjkroege@chromium.org>
Reviewed by Nate Chapin
To fire each event handler registered on an SVG node once per
event, Chromium needs an implementation of wasCreatedFromMarkup
added to V8LazyEventListener.h that matches the one in
WebKit/WebCore/bindings/js/JSLazyEventListener.h.
This patch adds such a matching implementation of wasCreatedFromMarkup
to V8LazyEventListener.h.
- bindings/v8/V8LazyEventListener.h: (WebCore::V8LazyEventListener::wasCreatedFromMarkup):
- 5:00 PM Changeset in webkit [55325] by
-
- 3 edits in trunk/WebCore
2010-02-26 Arno Renevier <arno@renevier.net>
Reviewed by Gustavo Noronha Silva.
[Gtk] use geoclue_position_get_position_async to get geolocation position.
https://bugs.webkit.org/show_bug.cgi?id=35355
No new tests, behaviour depends on system.
- platform/gtk/GeolocationServiceGtk.cpp: (WebCore::GeolocationServiceGtk::startUpdating): (WebCore::GeolocationServiceGtk::get_position):
- platform/gtk/GeolocationServiceGtk.h:
- 4:44 PM Changeset in webkit [55324] by
-
- 6 edits in trunk/WebKit/mac
https://bugs.webkit.org/show_bug.cgi?id=35449
Add ability to hide WebFrame scrollbars and to allow scrollbars to overlap with content.
Patch by Jing Jin <jjin@apple.com> on 2010-02-26
Reviewed by Timothy Hatcher.
- WebView/WebDynamicScrollBarsView.h:
- WebView/WebDynamicScrollBarsView.mm:
(-[WebDynamicScrollBarsView setAllowScrollersToOverlapContent:]): Allows scrollbars to
overlap with the document and re-layouts the document.
(-[WebDynamicScrollBarsView setAlwaysHideHorizontalScroller:]): Hides the horizontal scrollbar.
(-[WebDynamicScrollBarsView setAlwaysHideVerticalScroller:]): Hides the vertical scrollbar.
(-[WebDynamicScrollBarsView contentViewFrame]): Calculates the appropriate frame based
on allowScrollersToOverlapContent.
(-[WebDynamicScrollBarsView tile]): If allowScrollersToOverlapContent is YES, set the
contentView's frame so it overlaps with the scrollbar.
(-[WebDynamicScrollBarsView updateScrollers]): Take into account hideHorizontalScroller
and hideVerticalScroller.
(-[WebDynamicScrollBarsView reflectScrolledClipView:]): set drawsBackground to NO when
scrollbars are overlapping with content, so we don't get trails during scrollbar draw updates.
- WebView/WebDynamicScrollBarsViewInternal.h:
- WebView/WebFrame.h:
- WebView/WebFrame.mm:
(-[WebFrame setAllowScrollersToOverlapContent:]): Hook for [WebDynamicScrollBarsView setAllowScrollersToOverlapContent:]
(-[WebFrame setAlwaysHideHorizontalScroller:]): Hook for [WebDynamicScrollBarsView setAlwaysHideHorizontalScroller:]
(-[WebFrame setAlwaysHideVerticalScroller:]): Hook for [WebDynamicScrollBarsView setAlwaysHideVerticalScroller:]
- 4:32 PM Changeset in webkit [55323] by
-
- 2 edits in trunk/WebCore
2010-02-26 Yaar Schnitman <yaar@chromium.org>
Chromium Win build fix.
- WebCore.gyp/WebCore.gyp: Added missing file to action input.
- 4:19 PM Changeset in webkit [55322] by
-
- 12 edits1 delete in trunk/JavaScriptCore
Rubber Stamped by Geoff Garen.
Remove wrec. All builds should have switched to yarr by now.
- Android.mk:
- GNUmakefile.am:
- JavaScriptCore.gypi:
- JavaScriptCore.pri:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreCommon.vsprops:
- JavaScriptCore.vcproj/jsc/jscCommon.vsprops:
- JavaScriptCore.xcodeproj/project.pbxproj:
- runtime/RegExp.cpp:
(JSC::RegExp::match):
- runtime/RegExp.h:
- wrec: Removed.
- wrec/CharacterClass.cpp: Removed.
- wrec/CharacterClass.h: Removed.
- wrec/CharacterClassConstructor.cpp: Removed.
- wrec/CharacterClassConstructor.h: Removed.
- wrec/Escapes.h: Removed.
- wrec/Quantifier.h: Removed.
- wrec/WREC.cpp: Removed.
- wrec/WREC.h: Removed.
- wrec/WRECFunctors.cpp: Removed.
- wrec/WRECFunctors.h: Removed.
- wrec/WRECGenerator.cpp: Removed.
- wrec/WRECGenerator.h: Removed.
- wrec/WRECParser.cpp: Removed.
- wrec/WRECParser.h: Removed.
- wscript:
- 3:47 PM Changeset in webkit [55321] by
-
- 2 edits in trunk/WebKit/chromium
2010-02-26 Brett Wilson <brettw@chromium.org>
Fix chromium build. This test's expectation became obsolete with
recent changes to KURL which my previous change brings Chromium's
port in compliance with.
- tests/KURLTest.cpp: (ComponentCase::TEST):
- 3:26 PM Changeset in webkit [55320] by
-
- 2 edits in trunk/WebKit/chromium
2010-02-26 Yaar Schnitman <yaar@chromium.org>
Chromium build fix.
- features.gypi: Added missing new variable enable_svg.
- 3:18 PM Changeset in webkit [55319] by
-
- 3 edits in trunk/WebCore
2010-02-12 Brett Wilson <brettw@chromium.org>
Reviewed by Adam Barth.
Update the Google-URL version of KURL and the V8 bindings to the new
behavior of KURL.IsStandard.
This is covered by fast/dom/Window/invalid-protocol.html
- bindings/v8/custom/V8LocationCustom.cpp: (WebCore::V8Location::protocolAccessorSetter):
- platform/KURLGoogle.cpp: (WebCore::KURL::setProtocol): (WebCore::KURL::isHierarchical):
- 3:13 PM Changeset in webkit [55318] by
-
- 4 edits1 add in trunk
2010-02-25 Yaar Schnitman <yaar@chromium.org>
Reviewed by Dimitri Glazkov.
[V8] Auto-generate and split DerivedSourcesAllInOne.cpp
https://bugs.webkit.org/show_bug.cgi?id=33048
- WebCore.gyp/WebCore.gyp:
- WebCore.gyp/scripts/action_derivedsourcesallinone.py: Added.
- bindings/v8/DerivedSourcesAllInOne.cpp: Removed.
- 2:53 PM Changeset in webkit [55317] by
-
- 2 edits in trunk/WebCore
- bridge/qt/qt_pixmapruntime.cpp:
(JSC::Bindings::QtPixmapInstance::invokeMethod):
Reviewed by NOBODY (Build fix following r55312).
- 2:39 PM Changeset in webkit [55316] by
-
- 8 edits in trunk
WebKit/gtk
2009-12-04 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Reviewed by Xan Lopez.
[GTK] Needs proper reporting of frame loader callbacks, in DRT
https://bugs.webkit.org/show_bug.cgi?id=32170
Add new signal to report when the document load is finished for a
frame.
- WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::dispatchDidFinishDocumentLoad):
- webkit/webkitwebview.cpp: (webkit_web_view_class_init):
WebKitTools
2010-02-26 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Reviewed by Xan Lopez.
[GTK] Needs proper reporting of frame loader callbacks, in DRT
https://bugs.webkit.org/show_bug.cgi?id=32170
Fix reporting of unload handlers, so that it is emitted where
needed, not after it.
- DumpRenderTree/gtk/DumpRenderTree.cpp: (webViewLoadFinished): (webViewDocumentLoadFinished): (createWebView):
LayoutTests
2010-02-26 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Reviewed by Xan Lopez.
[GTK] Needs proper reporting of frame loader callbacks, in DRT
https://bugs.webkit.org/show_bug.cgi?id=32170
Unskip tests that now pass.
- LayoutTests/platform/gtk/http/tests/loading/redirect-with-no-location-crash-expected.txt: rebaselined.
- platform/gtk/Skipped:
- 2:30 PM Changeset in webkit [55315] by
-
- 4 edits2 adds in trunk
Reviewed by Anders Carlsson.
https://bugs.webkit.org/show_bug.cgi?id=35450
Crash when a Java array property accessor raises an exception
Test: java/inaccessible-class.html. Adding with a FAIL result, because this doesn't raise
an exception in Firefox. I don't know what the formally correct behavior is, but it's good
to avoid crashing.
- bridge/jni/jsc/JNIBridgeJSC.cpp: (JavaField::valueFromInstance): Check if the result is null before interpreting it as an object or array.
- 2:27 PM Changeset in webkit [55314] by
-
- 3 edits in trunk/WebCore
2010-02-26 Dirk Schulze <krit@webkit.org>
Reviewed by Nikolas Zimmermann.
Extend AffineTransform to mapQuad
https://bugs.webkit.org/show_bug.cgi?id=35444
This makes mapQuad available for AffineTransform. So that platforms
can make use of it after the switch from TransformationMatrix to
AffineTransform in GraphicsContext.
- platform/graphics/transforms/AffineTransform.cpp: (WebCore::AffineTransform::mapRect): mapRect already did the calculation for mapQuad but gave back the
boundingBox of the resulting FloatQuad.
(WebCore::AffineTransform::mapQuad):
- platform/graphics/transforms/AffineTransform.h:
- 2:26 PM Changeset in webkit [55313] by
-
- 2 edits in trunk/WebCore
Arrow keys do not scroll source view in Resources pane or Scripts pane.
<rdar://problem/7594367> and https://bugs.webkit.org/show_bug.cgi?id=34356
Reviewed by Pavel Feldman.
Handle vertical scrolling in the Text Viewer:
- inspector/front-end/TextViewer.js:
(WebInspector.TextViewer): Listen for the keydown event.
(WebInspector.TextViewer.prototype._handleKeyDown): If the event has no modifiers and refers
to an arrow key, scroll. The horizontal values were ripped from the default "pixels per scroll line"
value in ScrollBar.h.
- 2:21 PM Changeset in webkit [55312] by
-
- 24 edits1 add in trunk
Bug 35401 - Fix handling of errors in handling calls over bridge,
where base object bridge-type does not match method bridge-type.
Reviewed by Alexey Proskuryakov.
The code assumes users will only attempt to invoke a Java method
on a Java base object, etc.
Add language specific subclasses of RuntimeMethod, and pass the
RuntimeMethod into invokeMethod, so we can typecheck before
casting. Throw an exception on type mismatch.
WebCore:
- WebCore.base.exp:
- WebCore.xcodeproj/project.pbxproj:
- bridge/c/c_instance.cpp:
(JSC::Bindings::CRuntimeMethod::CRuntimeMethod):new class to distinguish this type of RuntimeMethod.
(JSC::Bindings::CInstance::getMethod): create an appropriate sublclass of RuntimeMethod.
(JSC::Bindings::CInstance::invokeMethod): dynamically check the type of the RuntimeMethod.
- bridge/c/c_instance.h:
- bridge/jni/jsc/JavaInstanceJSC.cpp:
(JavaRuntimeMethod::JavaRuntimeMethod): new class to distinguish this type of RuntimeMethod.
(JavaInstance::getMethod): create an appropriate sublclass of RuntimeMethod.
(JavaInstance::invokeMethod): dynamically check the type of the RuntimeMethod.
- bridge/jni/jsc/JavaInstanceJSC.h:
- bridge/jsc/BridgeJSC.h:
- bridge/objc/objc_instance.h:
- bridge/objc/objc_instance.mm:
(ObjcRuntimeMethod::ObjcRuntimeMethod): new class to distinguish this type of RuntimeMethod.
(ObjcInstance::getMethod): create an appropriate sublclass of RuntimeMethod.
(ObjcInstance::invokeMethod): dynamically check the type of the RuntimeMethod.
(ObjcInstance::invokeObjcMethod): new method, takes an ObjcMethod* as an argument so that we don't need to dynamically determine the type.
- bridge/objc/objc_runtime.mm:
(JSC::Bindings::callObjCFallbackObject): use new invokeObjcMethod method.
- bridge/runtime_method.cpp:
(JSC::callRuntimeMethod): pass RuntimeMethod as argument to invokeMethod, rather than its MethodList.
- bridge/runtime_object.cpp:
(JSC::RuntimeObject::methodGetter): use new getMethod method.
WebKit/mac:
- Plugins/Hosted/ProxyInstance.h:
- Plugins/Hosted/ProxyInstance.mm:
(WebKit::PluginRuntimeMethod::PluginRuntimeMethod): new class to distinguish this type of RuntimeMethod.
(WebKit::ProxyInstance::getMethod): create an appropriate sublclass of RuntimeMethod.
(WebKit::ProxyInstance::invokeMethod): dynamically check the type of the RuntimeMethod.
LayoutTests:
- java/java-and-plugins.html: Add tests for passing mismatched this objects to methdods.
- 2:17 PM Changeset in webkit [55311] by
-
- 5 edits in trunk
2010-02-26 Oliver Hunt <oliver@apple.com>
Reviewed by Geoff Garen.
Make the lookup table generator include an explicit cast to expected
type of the function. We do this because otherwise the blind intptr_t
cast that is subsequently applied allows incorrectly typed functions
to be inserted into the table, where they will only fail at runtime.
This change makes such errors produce a compile time failure.
- 2:07 PM Changeset in webkit [55310] by
-
- 4 edits1 copy13 adds in trunk
2010-02-26 Alex Milowski <alex@milowski.com>
Reviewed by Kenneth Rohde Christiansen.
Basic tests for munder, munderover, and mover elements.
- mathml/presentation/over.xhtml: Added.
- mathml/presentation/under.xhtml: Added.
- mathml/presentation/underover.xhtml: Added.
- platform/mac/mathml/presentation/over-expected.checksum: Added.
- platform/mac/mathml/presentation/over-expected.png: Added.
- platform/mac/mathml/presentation/over-expected.txt: Added.
- platform/mac/mathml/presentation/under-expected.checksum: Added.
- platform/mac/mathml/presentation/under-expected.png: Added.
- platform/mac/mathml/presentation/under-expected.txt: Added.
- platform/mac/mathml/presentation/underover-expected.checksum: Added.
- platform/mac/mathml/presentation/underover-expected.png: Added.
- platform/mac/mathml/presentation/underover-expected.txt: Added.
2010-02-26 Alex Milowski <alex@milowski.com>
Reviewed by Kenneth Rohde Christiansen.
Added basic support for the munder, munderover, and mover elements.
Tests: mathml/presentation/over.xhtml
mathml/presentation/under.xhtml
mathml/presentation/underover.xhtml
- WebCore.xcodeproj/project.pbxproj:
- mathml/MathMLInlineContainerElement.cpp: (WebCore::MathMLInlineContainerElement::createRenderer):
- mathml/RenderMathMLUnderOver.cpp: Added. (WebCore::RenderMathMLUnderOver::RenderMathMLUnderOver): (WebCore::RenderMathMLUnderOver::addChild): (WebCore::getOffsetHeight): (WebCore::RenderMathMLUnderOver::stretchToHeight): (WebCore::RenderMathMLUnderOver::layout): (WebCore::RenderMathMLUnderOver::baselinePosition): (WebCore::RenderMathMLUnderOver::nonOperatorHeight):
- mathml/RenderMathMLUnderOver.h: Added. (WebCore::RenderMathMLUnderOver::hasBase): (WebCore::RenderMathMLUnderOver::):
- 1:48 PM Changeset in webkit [55309] by
-
- 3 edits in trunk
[Gtk] Make DRT EventSender::keyDown to consider 'hardware_keycode' field when synthesizing an event.
https://bugs.webkit.org/show_bug.cgi?id=35432
Patch by Antonio Gomes <tonikitoo@webkit.org>
Reviewed by Gustavo Noronha.
When a directional key-press event (arrow keys, End, Home, PageUp,
PageDown, etc) is synthesized by DRT's EventSender and it targets
an editor (e.g. <input type=text>, <textare>, etc), event is processed
by WebCore::EventHandler. On the other hand, if event target is not
an editor, event is bubbled up to Gtk+ for processing. In such cases,
if 'hardware_keycode' is not provided at event synthesize time
its processing fails (at some point in gtk_bindings_activate_event),
and no scroll action is performed.
Unskip fast/events/node-event-anchor-lock.html
- DumpRenderTree/win/EventSender.cpp:
(keyDownCallback):
- platform/gtk/Skipped:
- 1:43 PM Changeset in webkit [55308] by
-
- 2 edits in trunk/WebCore
2010-02-24 Stephen White <senorblanco@chromium.org>
Reviewed by Darin Adler.
This CL implements a simple ad-hoc parser for CSS rgb() values.
If it fails, it returns false and the normal lex/yacc parser will
be invoked.
Covered by fast/canvas/canvas-bg.html, fast/canvas/canvas-bg-zoom.html,
and many more.
- css/CSSParser.cpp: (WebCore::parseInt): (WebCore::CSSParser::parseColor):
- 1:40 PM Changeset in webkit [55307] by
-
- 2 edits in trunk/WebKit/chromium
2010-02-26 Darin Fisher <darin@chromium.org>
Fix mac warning (that gets treated as an error in the chromium build).
- src/ChromiumBridge.cpp: (WebCore::ChromiumBridge::cookiesEnabled):
- 1:33 PM Changeset in webkit [55306] by
-
- 2 edits in trunk/WebCore
2010-02-26 Jarkko Sakkinen <jarkko.sakkinen@tieto.com>
Reviewed by Kenneth Rohde Christiansen.
https://bugs.webkit.org/show_bug.cgi?id=35419
3D canvas did not update when WTF_USE_ACCELERATED_COMPOSITING
was enabled but not from run-time settings. Added run-time
check that compositing is enabled.
- html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::markContextChanged):
- 1:24 PM Changeset in webkit [55305] by
-
- 2 edits in trunk/WebKit/gtk
2010-02-26 Antonio Gomes <tonikitoo@webkit.org>
Complementary commit of r55300. Missing "notify::" to signal name.
- tests/testwebview.c: (test_webkit_web_view_grab_focus):
- 1:16 PM Changeset in webkit [55304] by
-
- 2 edits in trunk/WebCore
2010-02-26 Jarkko Sakkinen <jarkko.sakkinen@tieto.com>
Reviewed by Kenneth Rohde Christiansen.
Compilation failed because functions glSampleCoverage, glBlendEquation
and glActiveTexture were not available.
https://bugs.webkit.org/show_bug.cgi?id=35423
- platform/graphics/qt/GraphicsContext3DQt.cpp: (WebCore::GraphicsContext3DInternal::GraphicsContext3DInternal): (WebCore::GraphicsContext3D::activeTexture): (WebCore::GraphicsContext3D::blendEquation): (WebCore::GraphicsContext3D::sampleCoverage):
- 12:59 PM Changeset in webkit [55303] by
-
- 2 edits in trunk/WebCore
2010-02-26 Jarkko Sakkinen <jarkko.sakkinen@tieto.com>
Reviewed by Kenneth Rohde Christiansen.
https://bugs.webkit.org/show_bug.cgi?id=35380
Fixed compilation error when WTF_USE_ACCELERATED_COMPOSITING=0
- css/MediaQueryEvaluator.cpp: (WebCore::transform_3dMediaFeatureEval):
- 12:42 PM Changeset in webkit [55302] by
-
- 2 edits in trunk/WebCore
2010-02-26 Nicholas Young <nicholas.young@nokia.com>
Reviewed by Tor Arne Vestbø.
[Qt] Incorrect painting after a size changed.
https://bugs.webkit.org/show_bug.cgi?id=35412
No new tests. Bug fix in backend.
- platform/graphics/qt/MediaPlayerPrivateQt.cpp: (WebCore::MediaPlayerPrivate::paint): Provide the source rectangle, rather than inferring it.
- 12:41 PM Changeset in webkit [55301] by
-
- 2 edits in trunk/LayoutTests
2010-02-26 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Rebaseline of platform-specific results for test.
SVGResourceClipper needs to be moved to RenderSVGResourceClipper
https://bugs.webkit.org/show_bug.cgi?id=35421
- platform/gtk/svg/custom/use-on-clip-path-with-transformation-expected.txt:
- 12:32 PM Changeset in webkit [55300] by
-
- 3 edits in trunk/WebKit/gtk
[GTK] Make webkit_web_view_grab_focus to active focus controller.
https://bugs.webkit.org/show_bug.cgi?id=35402
Reviewed by Xan Lopez.
Patch by Antonio Gomes <tonikitoo@webkit.org>
When programatically setting focus to an element in an inner document,
calling "hasFocus()" from this document returns FALSE, because
document's FocusController is not activated. It does not happen
if |document| is the main document.
Making webkit_web_view_grab_focus to actually activate the FocusController,
fixes the issue.
- tests/testwebview.c:
(server_callback):
(test_webkit_web_view_grab_focus):
- webkit/webkitwebview.cpp:
(webkit_web_view_grab_focus):
- 12:24 PM Changeset in webkit [55299] by
-
- 2 edits in trunk/WebCore
2010-02-26 Nicholas Young <nicholas.young@nokia.com>
Reviewed by Tor Arne Vestbø.
[Qt] Incorrect handling of MIME types in Media Player
https://bugs.webkit.org/show_bug.cgi?id=35413
No new tests. Bug fix in backend.
- platform/graphics/qt/MediaPlayerPrivateQt.cpp: (WebCore::MediaPlayerPrivate::supportsType): Corrected logic.
- 12:20 PM Changeset in webkit [55298] by
-
- 2 edits in trunk/WebKit/gtk
Unreviewed.
Reverted last patch (r55295), it causes problems with the frames.
- WebCoreSupport/ChromeClientGtk.cpp:
- 12:08 PM Changeset in webkit [55297] by
-
- 3 edits in trunk/WebCore
2010-02-26 Joanmarie Diggs <joanmarie.diggs@gmail.com>
Reviewed by Xan Lopez.
https://bugs.webkit.org/show_bug.cgi?id=35418
[Gtk] Every table, including layout tables, should be exposed as a table
This patch exposes layout tables as tables. (Addressing the problematic table
hierarchy remains to be done.)
- accessibility/gtk/AccessibilityObjectAtk.cpp: (AccessibilityObject::accessibilityPlatformIncludesObject):
- accessibility/AccessibilityRenderObject.cpp: (AccessibilityRenderObject::determineAccessibilityRole):
- 11:50 AM Changeset in webkit [55296] by
-
- 2 edits in trunk/JavaScriptCore
2010-02-26 Janne Koskinen <janne.p.koskinen@digia.com>
Reviewed by Simon Hausmann.
[Qt] Symbian specific getCPUTime implemetation
https://bugs.webkit.org/show_bug.cgi?id=34742
Default implementation doesn't work on Symbian devices.
This change adds a proper implementation by
asking thread execution time from the current thread.
- runtime/TimeoutChecker.cpp: (JSC::getCPUTime):
- 10:54 AM Changeset in webkit [55295] by
-
- 2 edits in trunk/WebKit/gtk
[GTK] Some region checks in scroll are not required
https://bugs.webkit.org/show_bug.cgi?id=35142
Reviewed by Xan Lopez.
Removes some of the operations checking the moved and invalidated
regions when scrolling, it is done already in
gdk_window_move_region.
- WebCoreSupport/ChromeClientGtk.cpp:
- 10:51 AM Changeset in webkit [55294] by
-
- 2 edits in trunk/WebKitSite
Rubber-stamped by Adele Peterson.
Update Security Group Members list.
- security/security-group-members.html:
- 10:47 AM Changeset in webkit [55293] by
-
- 2 edits in trunk/LayoutTests
2010-02-26 Dirk Schulze <krit@webkit.org>
Unreviewed LayoutTest fix.
SVGResourceClipper needs to be moved to RenderSVGResourceClipper
https://bugs.webkit.org/show_bug.cgi?id=35421
This corrects a result of a new clip test for SVG.
- platform/mac/svg/custom/use-on-clip-path-with-transformation-expected.txt:
- 10:37 AM Changeset in webkit [55292] by
-
- 2 edits in trunk/WebKitTools
2010-02-26 Dimitri Glazkov <Dimitri Glazkov>
Reviewed by David Levin.
new-webkit-run-tests: Extraneous parenthesis in websocket_server.py
https://bugs.webkit.org/show_bug.cgi?id=35436
- Scripts/webkitpy/layout_tests/port/websocket_server.py: Removed extra paren.
- 10:13 AM Changeset in webkit [55291] by
-
- 2 edits in trunk/LayoutTests
Unreviewed trivial fix.
[Qt] Update platform specific expected file after r55289.
- platform/qt/svg/css/clippath-with-shadow-expected.txt:
- 10:09 AM Changeset in webkit [55290] by
-
- 3 edits in trunk/WebCore
2010-02-26 Adam Barth <abarth@webkit.org>
Reviewed by Darin Adler.
XSSAuditor is super super super slow
https://bugs.webkit.org/show_bug.cgi?id=35373
In this patch, we separate the decoding cache for the page's URL and
form data. Previously, we used the same cache for both, which caused
us miss the cache every time when the page had form data (because the
cache only stored one entry). When the form data is large, we were
wasting a lot of time canonicalizing.
- page/XSSAuditor.cpp: (WebCore::XSSAuditor::findInRequest):
- page/XSSAuditor.h:
- 10:02 AM Changeset in webkit [55289] by
-
- 43 edits2 adds2 deletes in trunk
2010-02-26 Dirk Schulze <krit@webkit.org>
Reviewed by Nikolas Zimmermann.
SVGResourceClipper needs to be moved to RenderSVGResourceClipper
https://bugs.webkit.org/show_bug.cgi?id=35421
Move SVGResourceClipper to RenderSVGResourceClipper. This follows the changes
of Masker and helps to clean up the SVG code. Code snippets from SVGClipPathElement
and SVGResourceClipper got combined in RenderSVGResourceClipper. DRT results are
more readable for clipPath's now. It's possible to see the unit type of clipper, as
well as it's childs instead of just one path.
- Android.mk:
- GNUmakefile.am:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- rendering/RenderSVGResource.h: (WebCore::):
- rendering/RenderSVGResourceClipper.cpp: Added. (WebCore::RenderSVGResourceClipper::RenderSVGResourceClipper): (WebCore::RenderSVGResourceClipper::~RenderSVGResourceClipper): (WebCore::RenderSVGResourceClipper::invalidateClients): (WebCore::RenderSVGResourceClipper::invalidateClient): (WebCore::RenderSVGResourceClipper::applyResource): (WebCore::RenderSVGResourceClipper::resourceBoundingBox):
- rendering/RenderSVGResourceClipper.h: Added. (WebCore::RenderSVGResourceClipper::renderName): (WebCore::RenderSVGResourceClipper::resourceType): (WebCore::RenderSVGResourceClipper::clipPathUnits):
- rendering/SVGRenderSupport.cpp: (WebCore::SVGRenderBase::prepareToRenderSVGContent): (WebCore::SVGRenderBase::clipperBoundingBoxForRenderer): (WebCore::SVGRenderBase::deregisterFromResources):
- rendering/SVGRenderTreeAsText.cpp: (WebCore::operator<<): (WebCore::writeStyle): (WebCore::writeSVGResource): (WebCore::writeResources):
- svg/SVGClipPathElement.cpp: (WebCore::SVGClipPathElement::svgAttributeChanged): (WebCore::SVGClipPathElement::childrenChanged): (WebCore::SVGClipPathElement::createRenderer):
- svg/SVGClipPathElement.h: (WebCore::SVGClipPathElement::isValid):
- svg/SVGStyledElement.cpp: (WebCore::SVGStyledElement::invalidateResources):
- svg/graphics/SVGResource.h: (WebCore::): (WebCore::SVGResource::isPaintServer): (WebCore::SVGResource::isFilter): (WebCore::SVGResource::isMarker):
- svg/graphics/SVGResourceClipper.cpp: Removed.
- svg/graphics/SVGResourceClipper.h: Removed.
2010-02-26 Dirk Schulze <krit@webkit.org>
Reviewed by Nikolas Zimmermann.
SVGResourceClipper needs to be moved to RenderSVGResourceClipper
https://bugs.webkit.org/show_bug.cgi?id=35421
Update results after the move of SVGResourceClipper. Results are better
readable and more sensible now.
- platform/mac/svg/W3C-SVG-1.1/masking-intro-01-f-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/masking-path-01-b-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/masking-path-02-b-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/masking-path-04-b-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/masking-path-05-f-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/painting-marker-02-f-expected.txt:
- platform/mac/svg/batik/text/textEffect2-expected.txt:
- platform/mac/svg/batik/text/textProperties-expected.txt:
- platform/mac/svg/css/clippath-with-shadow-expected.txt:
- platform/mac/svg/custom/clip-path-child-changes-expected.txt:
- platform/mac/svg/custom/clip-path-display-none-child-expected.txt:
- platform/mac/svg/custom/clip-path-href-changes-expected.txt:
- platform/mac/svg/custom/clip-path-referencing-use-expected.txt:
- platform/mac/svg/custom/clip-path-referencing-use2-expected.txt:
- platform/mac/svg/custom/clip-path-units-changes-expected.txt:
- platform/mac/svg/custom/clip-path-with-transform-expected.txt:
- platform/mac/svg/custom/empty-clip-path-expected.txt:
- platform/mac/svg/custom/focus-ring-expected.txt:
- platform/mac/svg/custom/image-with-transform-clip-filter-expected.txt:
- platform/mac/svg/custom/invalid-css-expected.txt:
- platform/mac/svg/custom/js-late-clipPath-and-object-creation-expected.txt:
- platform/mac/svg/custom/js-late-clipPath-creation-expected.txt:
- platform/mac/svg/custom/recursive-clippath-expected.txt:
- platform/mac/svg/custom/resource-invalidate-on-target-update-expected.txt:
- platform/mac/svg/custom/text-clip-expected.txt:
- platform/mac/svg/custom/visibility-override-clip-expected.txt:
- platform/mac/svg/filters/filter-clip-expected.txt:
- svg/custom/use-clipped-transform-expected.txt:
- 8:53 AM Changeset in webkit [55288] by
-
- 2 edits in trunk/WebKit/qt
2010-02-26 Diego Gonzalez <diego.gonzalez@openbossa.org>
Reviewed by Simon Hausmann.
Fix documentation of QWebSettings::setUserStyleSheetUrl method
The base 64 data in the exemple shows a not valid code.
REGRESSION: QWebSettings::setUserStyleSheetUrl is not working with a data URL (Base64)
https://bugs.webkit.org/show_bug.cgi?id=34802
- Api/qwebsettings.cpp:
- 8:52 AM Changeset in webkit [55287] by
-
- 6 edits in trunk
The element that a touchevent is dispatched to isn't always right
https://bugs.webkit.org/show_bug.cgi?id=35431
Reviewed by Kenneth Rohde Christiansen.
WebCore:
The element that touch events are dispatched on is not always the
correct one, as the cached m_touchEventTarget member is only updated
when the first element of the PlatformTouchEvent touch list is in the
TouchPressed state.
This patch changes this behavior to dispatch the event to the target
of the touch that caused the event to be generated and eliminates the
m_touchEventTarget in favour of using the touch target hashmap. It also
simplifies the way in which the touchTargets list is generated as we
no longer have m_touchEventTarget (which was used previously to build
the list). The new behavior matches the observed behavior of the
iPhone and Android.
- page/EventHandler.cpp:
(WebCore::assembleTargetTouches): Added. new function to build the
targetTouches list. Filters a list of touches (passed) about
another given touch.
(WebCore::EventHandler::handleTouchEvent): Remove the
m_touchEventTarget member, and simplify the generation of the
TouchLists that are bundled with the TouchEVent object. Dispatch
the event to the target of the touch that caused the event to be
fired.
- page/EventHandler.h: Remove m_touchEventTarget.
LayoutTests:
- fast/events/touch/basic-single-touch-events-expected.txt: Updated
the targetTouches list expections.
- fast/events/touch/script-tests/basic-single-touch-events.js: ditto.
(verifyTouch):
- 8:51 AM Changeset in webkit [55286] by
-
- 4 edits1 move1 add in trunk/WebKitTools
Moved pywebsocket into the webkitpy/thirdparty directory and added
an associated README.webkit file to the pywebsocket directory.
This makes pywebsocket more consistent with the other third-party
Python code in our repository.
Reviewed by David Levin.
https://bugs.webkit.org/show_bug.cgi?id=35198
- Scripts/run-webkit-tests:
- Updated paths to pywebsocket.
- Scripts/run-webkit-websocketserver:
- Updated paths to pywebsocket.
- Scripts/webkitpy/layout_tests/port/websocket_server.py:
- Updated paths to pywebsocket.
- Scripts/webkitpy/thirdparty/pywebsocket: Copied from WebKitTools/pywebsocket.
- Scripts/webkitpy/thirdparty/pywebsocket/README.webkit: Added.
- Added a file containing information about the contents of the pywebsocket directory. This will make it easier to understand where the third-party code came from and what local changes have been made.
- pywebsocket: Removed.
- pywebsocket/COPYING: Removed.
- pywebsocket/MANIFEST.in: Removed.
- pywebsocket/README: Removed.
- pywebsocket/example: Removed.
- pywebsocket/example/echo_client.py: Removed.
- pywebsocket/example/echo_wsh.py: Removed.
- pywebsocket/mod_pywebsocket: Removed.
- pywebsocket/mod_pywebsocket/init.py: Removed.
- pywebsocket/mod_pywebsocket/dispatch.py: Removed.
- pywebsocket/mod_pywebsocket/handshake.py: Removed.
- pywebsocket/mod_pywebsocket/headerparserhandler.py: Removed.
- pywebsocket/mod_pywebsocket/memorizingfile.py: Removed.
- pywebsocket/mod_pywebsocket/msgutil.py: Removed.
- pywebsocket/mod_pywebsocket/standalone.py: Removed.
- pywebsocket/mod_pywebsocket/util.py: Removed.
- pywebsocket/setup.py: Removed.
- pywebsocket/test: Removed.
- pywebsocket/test/config.py: Removed.
- pywebsocket/test/mock.py: Removed.
- pywebsocket/test/run_all.py: Removed.
- pywebsocket/test/test_dispatch.py: Removed.
- pywebsocket/test/test_handshake.py: Removed.
- pywebsocket/test/test_memorizingfile.py: Removed.
- pywebsocket/test/test_mock.py: Removed.
- pywebsocket/test/test_msgutil.py: Removed.
- pywebsocket/test/test_util.py: Removed.
- pywebsocket/test/testdata: Removed.
- pywebsocket/test/testdata/handlers: Removed.
- pywebsocket/test/testdata/handlers/blank_wsh.py: Removed.
- pywebsocket/test/testdata/handlers/origin_check_wsh.py: Removed.
- pywebsocket/test/testdata/handlers/sub: Removed.
- pywebsocket/test/testdata/handlers/sub/exception_in_transfer_wsh.py: Removed.
- pywebsocket/test/testdata/handlers/sub/no_wsh_at_the_end.py: Removed.
- pywebsocket/test/testdata/handlers/sub/non_callable_wsh.py: Removed.
- pywebsocket/test/testdata/handlers/sub/plain_wsh.py: Removed.
- pywebsocket/test/testdata/handlers/sub/wrong_handshake_sig_wsh.py: Removed.
- pywebsocket/test/testdata/handlers/sub/wrong_transfer_sig_wsh.py: Removed.
- 8:36 AM Changeset in webkit [55285] by
-
- 3 edits2 adds in trunk
2010-02-26 Dirk Pranke <dpranke@chromium.org>
Reviewed by Darin Fisher.
Fix the handling of updates to #hash fragments to check for differences
post-canonicalization rather than comparing pre- to post-. Chromium
had a bug where we would set the #hash on an about:blank URL and generate
an onload event because we thought the URL (not just the fragment) was
changing.
- fast/loader/about-blank-hash-change-expected.txt: Added.
- fast/loader/about-blank-hash-change.html: Added.
2010-02-26 Dirk Pranke <dpranke@chromium.org>
Reviewed by Darin Fisher.
Fix the handling of updates to #hash fragments to check for differences
post-canonicalization rather than comparing pre- to post-. Chromium
had a bug where we would set the #hash on an about:blank URL and generate
an onload event because we thought the URL (not just the fragment) was
changing.
Test: fast/loader/about-blank-hash-change.html
- bindings/v8/custom/V8LocationCustom.cpp: (WebCore::V8Location::hashAccessorSetter):
- 8:19 AM Changeset in webkit [55284] by
-
- 2 edits in trunk/WebKitTools
2010-02-26 Chris Jerdonek <Chris Jerdonek>
Reviewed by Eric Seidel.
Changed the diff_parser module to log to a module-specific
logging.logger rather than the root logger.
- Scripts/webkitpy/diff_parser.py:
- 7:48 AM Changeset in webkit [55283] by
-
- 5 edits2 adds in trunk
2010-02-26 Zhenyao Mo <zmo@google.com>
Reviewed by David Levin.
texImage2D and texSubImage2D taking ImageData ignore flipY and premultiplyAlpha
https://bugs.webkit.org/show_bug.cgi?id=34459
- fast/canvas/webgl/tex-image-and-sub-image-2d-with-image-data-expected.txt: Added.
- fast/canvas/webgl/tex-image-and-sub-image-2d-with-image-data.html: Added.
2010-02-26 Zhenyao Mo <zmo@google.com>
Reviewed by David Levin.
texImage2D and texSubImage2D taking ImageData ignore flipY and premultiplyAlpha
https://bugs.webkit.org/show_bug.cgi?id=34459
Test: fast/canvas/webgl/tex-image-and-sub-image-2d-with-image-data.html
- html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::texImage2D): Apply flipY and premultiplyAlpha to the texture data. (WebCore::WebGLRenderingContext::texSubImage2D): Ditto.
- platform/graphics/GraphicsContext3D.cpp: (WebCore::GraphicsContext3D::extractImageData): Extract data from ImageData, applying flipY and premultiplyAlpha.
- platform/graphics/GraphicsContext3D.h: Add function extractImageData declaration.
- 7:30 AM Changeset in webkit [55282] by
-
- 11 edits in trunk
2010-02-26 Zhenyao Mo <zmo@google.com>
Reviewed by David Levin.
Set viewport to canvas size upon context creation
https://bugs.webkit.org/show_bug.cgi?id=35057
- fast/canvas/webgl/bug-32888.html: Remove the gl.viewport call since it's done when WebGLRenderingContext is created.
- fast/canvas/webgl/gl-get-calls-expected.txt: The read-back viewport size should match the canvas size instead of (0, 0, 0, 0).
- fast/canvas/webgl/gl-get-calls.html: Remove the gl.viewport call since it's done when WebGLRenderingContext is created.
- fast/canvas/webgl/tex-image-and-sub-image-2d-with-image.html: Ditto.
- fast/canvas/webgl/tex-sub-image-2d.html: Ditto.
- fast/canvas/webgl/texImage2DImageDataTest.html: Ditto.
- fast/canvas/webgl/triangle.html: Ditto.
- fast/canvas/webgl/viewport-unchanged-upon-resize.html: Ditto.
2010-02-26 Zhenyao Mo <zmo@google.com>
Reviewed by David Levin.
Set viewport to canvas size upon context creation
https://bugs.webkit.org/show_bug.cgi?id=35057
Covered by existing tests, in particular fast/canvas/webgl/gl-get-calls.html
- html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::WebGLRenderingContext): Set the viewport size to match the canvas size.
- 6:56 AM Changeset in webkit [55281] by
-
- 2 edits1 add in trunk/LayoutTests
[Qt] fast/multicol/client-rects.html fails in QtLauncher
https://bugs.webkit.org/show_bug.cgi?id=34959
Reviewed by Kenneth Rohde Christiansen.
- platform/qt/fast: Added.
- platform/qt/fast/multicol: Added.
- platform/qt/fast/multicol/client-rects-expected.txt: Platform specific expected file added.
- platform/qt/Skipped: fast/multicol/client-rects.html unskipped.
- 6:49 AM Changeset in webkit [55280] by
-
- 6 edits in trunk
[Qt] LayoutTestController.numberOfPages() should have default parameters
https://bugs.webkit.org/show_bug.cgi?id=35428
Reviewed by Kenneth Rohde Christiansen.
WebKitTools:
- DumpRenderTree/qt/DumpRenderTreeQt.cpp: maxViewWidth and maxViewHeight moved to
LayoutTestController to converge to platform independent implementation.
(WebCore::DumpRenderTree::DumpRenderTree):
(WebCore::DumpRenderTree::open):
- DumpRenderTree/qt/LayoutTestControllerQt.cpp: Initialization of maxViewWidth and maxViewHeight added.
- DumpRenderTree/qt/LayoutTestControllerQt.h:
- Default parameters for LayoutTestController.numberOfPages() added.
- maxViewWidth and maxViewHeight members added.
LayoutTests:
- platform/qt/Skipped: printing/css2.1 tests unskipped.
- 4:07 AM Changeset in webkit [55279] by
-
- 2 edits in trunk/LayoutTests
2010-02-26 Philippe Normand <pnormand@igalia.com>
Rubber-stamped by Xan Lopez.
[GTK] plugins/setProperty.html fails on 64bit Release
https://bugs.webkit.org/show_bug.cgi?id=35425
- platform/gtk/Skipped: Skipping another crasher related to bug 35425.
- 4:04 AM Changeset in webkit [55278] by
-
- 2 edits in trunk/WebCore
2010-02-26 Pavel Feldman <pfeldman@chromium.org>
Not reviewed: touch InspectorController to force front-end deployment.
- inspector/InspectorController.cpp:
- 3:26 AM Changeset in webkit [55277] by
-
- 20 edits in trunk
2010-02-26 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Pavel Feldman.
WebInspector: While the current timeline view in DevTools provides a great overview of
things happening, we should make it easier to locate the cause of an event,
e.g., link to JS where relevant.
Caller info support for all kind of Timeline events and new Function Call event will be added.
JSC can be patched the same way as it will be done for V8.
- bindings/js/ScriptCallStack.cpp: (WebCore::ScriptCallStack::callLocation):
- bindings/js/ScriptCallStack.h:
- bindings/v8/ScriptCallStack.cpp: (WebCore::ScriptCallStack::create): (WebCore::ScriptCallStack::callLocation):
- bindings/v8/ScriptCallStack.h:
- bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::callFunction):
- inspector/InspectorTimelineAgent.cpp: (WebCore::InspectorTimelineAgent::InspectorTimelineAgent): (WebCore::InspectorTimelineAgent::~InspectorTimelineAgent): (WebCore::InspectorTimelineAgent::willCallFunction): (WebCore::InspectorTimelineAgent::didCallFunction): (WebCore::InspectorTimelineAgent::pushCurrentRecord):
- inspector/InspectorTimelineAgent.h: (WebCore::): (WebCore::InspectorTimelineAgent::instanceCount):
- inspector/TimelineRecordFactory.cpp: (WebCore::TimelineRecordFactory::createGenericRecord): (WebCore::TimelineRecordFactory::createFunctionCallData):
- inspector/TimelineRecordFactory.h:
- inspector/front-end/Popover.js: (WebInspector.Popover.prototype.hideWhenClicked): (WebInspector.Popover.prototype._positionElement):
- inspector/front-end/TimelineAgent.js:
- inspector/front-end/TimelinePanel.js: (WebInspector.TimelinePanel): (WebInspector.TimelinePanel.prototype._innerAddRecordToTimeline): (WebInspector.TimelinePanel.prototype._formatRecord): (WebInspector.TimelinePanel.prototype._getRecordDetails): (WebInspector.TimelinePanel.prototype.reset): (WebInspector.TimelinePanel.prototype._closeRecordDetails): (WebInspector.TimelinePanel.prototype._onScroll): (WebInspector.TimelinePanel.prototype._refresh): (WebInspector.TimelinePanel.prototype._refreshRecords): (WebInspector.TimelineRecordListRow): (WebInspector.TimelineRecordListRow.prototype.update): (WebInspector.TimelineRecordListRow.prototype._createCell): (WebInspector.TimelineRecordListRow.prototype._createRow): (WebInspector.TimelineRecordListRow.prototype._createLinkRow): (WebInspector.TimelineRecordListRow.prototype._generateBubbleContent): (WebInspector.TimelineRecordListRow.prototype._onClick):
- inspector/front-end/WebKit.qrc:
- inspector/front-end/inspector.js: (WebInspector.linkifyResourceAsNode):
- 3:04 AM Changeset in webkit [55276] by
-
- 2 edits in trunk/LayoutTests
2010-02-26 Shinichiro Hamaji <hamaji@chromium.org>
Unreviewed. Skip failing tests.
Refine LayoutTests/printing/css2.1 with numberOfPages
https://bugs.webkit.org/show_bug.cgi?id=35334
- platform/qt/Skipped:
- 2:40 AM Changeset in webkit [55275] by
-
- 19 edits1 copy1 add in trunk/LayoutTests
2010-02-26 Shinichiro Hamaji <hamaji@chromium.org>
Reviewed by Eric Seidel.
Refine LayoutTests/printing/css2.1 with numberOfPages
https://bugs.webkit.org/show_bug.cgi?id=35334
Small refinements were done in paged-media-test-utils.js.
Note that WebKit doesn't pass page-break-after-003 for now.
- printing/css2.1/README.txt:
- printing/css2.1/page-break-after-000-expected.txt:
- printing/css2.1/page-break-after-000.html:
- printing/css2.1/page-break-after-001-expected.txt:
- printing/css2.1/page-break-after-001.html:
- printing/css2.1/page-break-after-002-expected.txt:
- printing/css2.1/page-break-after-002.html:
- printing/css2.1/page-break-after-003-expected.txt: Added.
- printing/css2.1/page-break-after-003.html: Added.
- printing/css2.1/page-break-after-004-expected.txt:
- printing/css2.1/page-break-after-004.html:
- printing/css2.1/page-break-before-000-expected.txt:
- printing/css2.1/page-break-before-000.html:
- printing/css2.1/page-break-before-001-expected.txt:
- printing/css2.1/page-break-before-001.html:
- printing/css2.1/page-break-before-002-expected.txt:
- printing/css2.1/page-break-before-002.html:
- printing/css2.1/page-break-inside-000-expected.txt:
- printing/css2.1/page-break-inside-000.html:
- printing/resources/paged-media-test-utils.js: (appendResult): (pageNumberForElementShouldBe): (numberOfPagesShouldBe): (runPrintingTest):
- 2:05 AM Changeset in webkit [55274] by
-
- 2 edits in trunk/LayoutTests
2010-02-26 Philippe Normand <pnormand@igalia.com>
Rubber-stamped by Xan Lopez.
[GTK] plugins/setProperty.html fails on 64bit Release
https://bugs.webkit.org/show_bug.cgi?id=35425
- platform/gtk/Skipped: Skipping crasher.
- 1:56 AM Changeset in webkit [55273] by
-
- 7 edits in trunk
2010-02-26 Jamey Hicks <jamey.hicks@nokia.com>
Reviewed by Laszlo Gombos.
[Qt] added QWebSettings::setInspectorUrl() and QWebSettings::inspectorUrl()
Enables the use of alternate Web Inspector frontends by changing
the location of the frontend.
This is required so that the Web Inspector may be run from an
external process or an external tool such as Eclipse or Aptana may
be used instead of the in-process Web Inspector UI.
- Api/qwebsettings.cpp: (QWebSettings::QWebSettings): (QWebSettings::setInspectorUrl): (QWebSettings::inspectorUrl):
- Api/qwebsettings.h:
- WebCoreSupport/InspectorClientQt.cpp: (WebCore::InspectorClientQt::createPage):
2010-02-26 Jamey Hicks <jamey.hicks@nokia.com>
Reviewed by Laszlo Gombos.
[Qt] added QWebSettings::setInspectorUrl() and QWebSettings::inspectorUrl()
Enables the use of alternate Web Inspector frontends by changing
the location of the frontend. The location is specified by providing
-inspector-url url
as an argument to QtLauncher.
This is required so that the Web Inspector may be run from an
external process or an external tool such as Eclipse or Aptana may
be used instead of the in-process Web Inspector UI.
- QtLauncher/main.cpp: (LauncherWindow::init): (LauncherApplication::handleUserOptions):
- 1:28 AM BuildingQtOnSymbian edited by
- (diff)
- 1:08 AM Changeset in webkit [55272] by
-
- 1 edit3 adds in trunk/LayoutTests
2010-02-26 Philippe Normand <pnormand@igalia.com>
Rubber-stamped by Xan Lopez.
Adding two GTK layout test results for a new tests
added in r55259 and r55260.
- platform/gtk/svg/custom/use-on-clip-path-with-transformation-expected.txt: Copied from LayoutTests/platform/mac/svg/custom/use-on-clip-path-with-transformation-expected.txt.
- platform/gtk/svg/filters/filter-on-tspan-expected.txt: Added.
- 12:39 AM Changeset in webkit [55271] by
-
- 20 edits6 adds2 deletes in trunk
Unreviewed. Roll-out r55263 because it broke fast/forms/textarea-type-spaces-pretty-diff.html.
https://bugs.webkit.org/show_bug.cgi?id=30946
WebCore:
- editing/CompositeEditCommand.cpp:
(WebCore::isWhitespace):
(WebCore::CompositeEditCommand::rebalanceWhitespaceAt):
- editing/InsertTextCommand.cpp:
(WebCore::InsertTextCommand::input):
- editing/InsertTextCommand.h:
- editing/htmlediting.cpp:
- editing/htmlediting.h:
LayoutTests:
- editing/execCommand/5142012-3-expected.txt:
- editing/inserting/rebalance-whitespace-1-expected.txt: Removed.
- editing/inserting/rebalance-whitespace-1.html: Removed.
- editing/pasteboard/5521237-expected.txt:
- platform/mac/editing/execCommand/5482023-expected.checksum:
- platform/mac/editing/execCommand/5482023-expected.png: Added.
- platform/mac/editing/execCommand/5482023-expected.txt:
- platform/mac/editing/execCommand/remove-formatting-2-expected.checksum:
- platform/mac/editing/execCommand/remove-formatting-2-expected.png: Added.
- platform/mac/editing/execCommand/remove-formatting-expected.checksum:
- platform/mac/editing/execCommand/remove-formatting-expected.png: Added.
- platform/mac/editing/execCommand/remove-formatting-expected.txt:
- platform/mac/editing/inserting/editable-html-element-expected.checksum:
- platform/mac/editing/inserting/editable-html-element-expected.png: Added.
- platform/mac/editing/inserting/editable-html-element-expected.txt:
- platform/mac/editing/pasteboard/4989774-expected.checksum:
- platform/mac/editing/pasteboard/4989774-expected.png: Added.
- platform/mac/editing/pasteboard/4989774-expected.txt:
- platform/mac/editing/selection/4983858-expected.checksum:
- platform/mac/editing/selection/4983858-expected.png: Added.
- platform/mac/editing/selection/4983858-expected.txt:
Feb 25, 2010:
- 11:40 PM Changeset in webkit [55270] by
-
- 2 edits in trunk/WebCore
<rdar://problem/7688455> REGRESSION(r55205): Crash inside dispatchEventsOnWindowAndFocusedNode when clicking link from bookmarks view
Reviewed by Brady Eidson.
Null-check the document's page to avoid dereferencing a null page.
No regression test is added as this appears to be dependent on an interaction with Safari's bookmarks view that is
not testable from within DumpRenderTree.
- page/FocusController.cpp:
(WebCore::dispatchEventsOnWindowAndFocusedNode):
- 10:49 PM Changeset in webkit [55269] by
-
- 4 edits in trunk/WebKit/chromium
2010-02-25 Darin Fisher <darin@chromium.org>
Reviewed by David Levin.
Remove deprecated cookie methods.
https://bugs.webkit.org/show_bug.cgi?id=35420
- public/WebFrameClient.h:
- public/WebKitClient.h:
- src/ChromiumBridge.cpp: (WebCore::ChromiumBridge::setCookies): (WebCore::ChromiumBridge::cookies): (WebCore::ChromiumBridge::cookieRequestHeaderFieldValue): (WebCore::ChromiumBridge::rawCookies): (WebCore::ChromiumBridge::deleteCookie): (WebCore::ChromiumBridge::cookiesEnabled):
- 8:56 PM QtWebKitMediaElementSupport edited by
- Added information about QtMultimedia Integration (diff)
- 5:32 PM Changeset in webkit [55268] by
-
- 4 edits1 add in trunk/WebKitTools
2010-02-25 Dirk Pranke <dpranke@chromium.org>
Reviewed by Eric Seidel.
Add a 'passing' port implementation to new-run-webkit-tests that
acts as a wrapper around an existing implementation but stubs out
the actual test invocations (instead, the expected results are echoed
back to the harness). This is useful for coverage and perf testing
of the harness (especially perf testing as it essentially provides
a lower bound on how fast the harness can run).
Also added a --nostart-helper flag to new-run-webkit-tests so that
you can skip starting the layout_test_helper and actually run the
harness even if you don't have a build of that port.
Also fix a bug in the 'test' port implementation to actually
create the results directory under /tmp instead of /.
- Scripts/webkitpy/layout_tests/port/factory.py: Modified.
- Scripts/webkitpy/layout_tests/port/passing.py: Added.
- Scripts/webkitpy/layout_tests/port/test.py: Added.
- Scripts/webkitpy/layout_tests/run_webkit_tests.py: Modified.
- 5:14 PM Changeset in webkit [55267] by
-
- 2 edits in trunk/WebKitTools
2010-02-25 Eric Seidel <eric@webkit.org>
Fix typo in my last change. No review.
Rename run-chromium-webkit-tests to new-run-webkit-tests to stop confusion
https://bugs.webkit.org/show_bug.cgi?id=35408
- Scripts/new-run-webkit-tests:
- 5:06 PM Changeset in webkit [55266] by
-
- 3 edits in trunk/WebCore
2010-02-25 Oliver Hunt <oliver@apple.com>
Reviewed by Simon Fraser.
Multiple repaints on apple.com
https://bugs.webkit.org/show_bug.cgi?id=35409
apple.com was triggering the fast scaling path for background images due to
repeated repaints as more content came in. This occured due to a two problems
in the logic to detect scaling. The first is that the main context is flipped
on mac so fails the identity or translation check. We work around this by adding
an function that allows the scaling for a flipped CTM. The other problem was that
we were looking at the destination rect size instead of the destination tile size
when deciding if the size we were drawn at would cause scaling.
- platform/graphics/transforms/AffineTransform.h: (WebCore::AffineTransform::isIdentityOrTranslationOrFlipped):
- rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelScaleObserver::shouldPaintBackgroundAtLowQuality): (WebCore::RenderBoxModelObject::paintFillLayerExtended):
- 4:55 PM Changeset in webkit [55265] by
-
- 1 edit2 adds in trunk/LayoutTests
2010-02-25 Dirk Pranke <dpranke@chromium.org>
Reviewed by Eric Seidel.
Test whether or not we preserve the hash fragments for "about:blank"
URLs. (Note that currently WebKit passes this but Chromium doesn't).
- fast/loader/about-blank-hash-kept-expected.txt: Added.
- fast/loader/about-blank-hash-kept.html: Added.
- 4:49 PM Changeset in webkit [55264] by
-
- 1 edit2 moves in trunk/WebKitTools
2010-02-25 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Rename run-chromium-webkit-tests to new-run-webkit-tests to stop confusion
https://bugs.webkit.org/show_bug.cgi?id=35408
- Scripts/new-run-webkit-tests: Added.
- Scripts/run-chromium-webkit-tests: Removed.
- Scripts/webkitpy/layout_tests/run_webkit_tests.py: Renamed from WebKitTools/Scripts/webkitpy/layout_tests/run_chromium_webkit_tests.py.
- 4:43 PM Changeset in webkit [55263] by
-
- 20 edits2 adds6 deletes in trunk
Extra layout on keypress after a space (problem with rebalanceWhitespaceAt in InsertTextCommand).
https://bugs.webkit.org/show_bug.cgi?id=30946
<rdar://problem/7639184>
Reviewed by Adele Peterson.
WebCore:
Do text insertion and whitespace rebalancing around the insertion in one step so that there's only one layout.
This patch was originally made by Justin Garcia.
Test: editing/inserting/rebalance-whitespace-1.html
- editing/CompositeEditCommand.cpp:
(WebCore::CompositeEditCommand::rebalanceWhitespaceAt): No behavior changes here,
just pushed the code that determined the extent of whitespace surrounding a position
to its own helper function.
- editing/InsertTextCommand.cpp:
(WebCore::InsertTextCommand::insertTextIntoNodeAndRebalanceWhitespace): Added. Find
whitespace surrounding the insertion position, add the text to insert, rebalance that entire
string, then insert it into the document.
(WebCore::InsertTextCommand::input):
- editing/InsertTextCommand.h:
- editing/htmlediting.cpp:
(WebCore::isWhitespace): Moved from CompositeEditCommand.cpp.
(WebCore::extentOfWhitespaceForRebalancingAt): Moved code from rebalanceWhitespaceAt into this helper
function. Obtains the offset of the start and end of whitespace around a particular position.
- editing/htmlediting.h:
LayoutTests:
There are now regular spaces where nbsps were used unnecessarily before. Also,
multi-character insertions now have their whitespace rebalanced, and this is
reflected in a few tests.
- editing/execCommand/5142012-3-expected.txt:
- editing/inserting/rebalance-whitespace-1-expected.txt: Added.
- editing/inserting/rebalance-whitespace-1.html: Added.
- editing/pasteboard/5521237-expected.txt:
- platform/mac/editing/execCommand/5482023-expected.checksum:
- platform/mac/editing/execCommand/5482023-expected.png: Removed.
- platform/mac/editing/execCommand/5482023-expected.txt:
- platform/mac/editing/execCommand/remove-formatting-2-expected.checksum:
- platform/mac/editing/execCommand/remove-formatting-2-expected.png: Removed.
- platform/mac/editing/execCommand/remove-formatting-expected.checksum:
- platform/mac/editing/execCommand/remove-formatting-expected.png: Removed.
- platform/mac/editing/execCommand/remove-formatting-expected.txt:
- platform/mac/editing/inserting/editable-html-element-expected.checksum:
- platform/mac/editing/inserting/editable-html-element-expected.png: Removed.
- platform/mac/editing/inserting/editable-html-element-expected.txt:
- platform/mac/editing/pasteboard/4989774-expected.checksum:
- platform/mac/editing/pasteboard/4989774-expected.png: Removed.
- platform/mac/editing/pasteboard/4989774-expected.txt:
- platform/mac/editing/selection/4983858-expected.checksum:
- platform/mac/editing/selection/4983858-expected.png: Removed.
- platform/mac/editing/selection/4983858-expected.txt:
- 4:22 PM Changeset in webkit [55262] by
-
- 10 edits2 adds in trunk
Reviewed by Anders Carlsson.
https://bugs.webkit.org/show_bug.cgi?id=35406
<rdar://problem/6945502> Make generic array methods work with JavaArray
Test: java/array-sort.html
Made RuntimeArray inherit from JSArray, keeping the promise given in ClassInfo.
- bridge/runtime_array.cpp: (JSC::RuntimeArray::RuntimeArray): (JSC::RuntimeArray::~RuntimeArray):
- bridge/runtime_array.h: (JSC::RuntimeArray::classInfo): (JSC::RuntimeArray::getConcreteArray):
- 3:21 PM Changeset in webkit [55261] by
-
- 2 edits in trunk/WebCore
Fixed a regression introduced in r44243, which made the assertion in checkListItems()
ineffective.
Reviewed by Alexey Proskuryakov.
- dom/SelectElement.cpp:
(WebCore::SelectElementData::checkListItems): Copy the items vector before recomputing it,
then assert that the newly-computed vector is equal to the copy.
- 3:04 PM Changeset in webkit [55260] by
-
- 8 edits4 adds in trunk
2010-02-25 Dirk Schulze <krit@webkit.org>
Reviewed by Nikolas Zimmermann.
SVG's tspan is no member of SVGRenderBase, this can cause crashes on filters
https://bugs.webkit.org/show_bug.cgi?id=35354
This makes the base class RenderSVGInline of RenderSVGTSpan and RenderSVGInlineText
dependent on SVGBaseRenderer.
The SVG spec want as to use the object bounding box of the text root as the bounding box
for text-childs. So we search for the text root and use it's bounding box, stroke rect and
repaint rect for further calculations.
Test: svg/filters/filter-on-tspan.svg
- rendering/RenderSVGInline.cpp: (WebCore::RenderSVGInline::objectBoundingBox): Find the text root and give back it's bounding box. (WebCore::RenderSVGInline::strokeBoundingBox): same for stroke rect (WebCore::RenderSVGInline::repaintRectInLocalCoordinates): same for repaint rect
- rendering/RenderSVGInline.h: (WebCore::RenderSVGInline::toSVGRenderBase): RenderSVGInline is part of SVGRenderBase now.
- rendering/RenderSVGTSpan.h: (WebCore::RenderSVGTSpan::renderName): Removed bounding box code. Was just a hack for filters and maskers.
- rendering/SVGRenderSupport.cpp: (WebCore::findTextRootObject): Search for the text root.
- rendering/SVGRenderSupport.h:
- svg/graphics/SVGPaintServerGradient.cpp: moved findTextRootObject to SVGRenderSupport
2010-02-25 Dirk Schulze <krit@webkit.org>
Reviewed by Nikolas Zimmermann.
SVG's tspan is no member of SVGRenderBase, this can cause crashes on filters
https://bugs.webkit.org/show_bug.cgi?id=35354
Check if filters work for tspan according to the SVG Spec. The test shouldn't
throw an assert now and a green rect should be visible.
- platform/mac/svg/filters/filter-on-tspan-expected.checksum: Added.
- platform/mac/svg/filters/filter-on-tspan-expected.png: Added.
- platform/mac/svg/filters/filter-on-tspan-expected.txt: Added.
- svg/filters/filter-on-tspan.svg: Added.
- 3:02 PM Changeset in webkit [55259] by
-
- 4 edits4 adds in trunk
2010-02-25 Dirk Schulze <krit@webkit.org>
Reviewed by Nikolas Zimmermann.
Use-element doesn't transform clipPath
https://bugs.webkit.org/show_bug.cgi?id=35375
If the use element is a child of clipPath, any settings on x, y or transform does not
transform the clipPath it references.
The use-element just misses this transformation in toClipPath.
Test: svg/custom/use-on-clip-path-with-transformation.svg
- platform/graphics/cairo/PathCairo.cpp: Gtk port translated the path to the wrong direction. (WebCore::Path::translate):
- svg/SVGUseElement.cpp: (WebCore::SVGUseElement::toClipPath):
2010-02-25 Dirk Schulze <krit@webkit.org>
Reviewed by Nikolas Zimmermann.
Use-element doesn't transform clipPath
https://bugs.webkit.org/show_bug.cgi?id=35375
Check if the clipPath gets transformed on setting a transform or translation for use.
- platform/mac/svg/custom/use-on-clip-path-with-transformation-expected.checksum: Added.
- platform/mac/svg/custom/use-on-clip-path-with-transformation-expected.png: Added.
- platform/mac/svg/custom/use-on-clip-path-with-transformation-expected.txt: Added.
- svg/custom/use-on-clip-path-with-transformation.svg: Added.
- 2:52 PM Changeset in webkit [55258] by
-
- 2 edits in trunk/JavaScriptCore
2010-02-25 Oliver Hunt <oliver@apple.com>
Reviewed by Geoff Garen.
JSC crashes like crazy in the JSPropertyNameIterator destructor
Add back null check of m_cachedStructure. Curse last minute changes.
- runtime/JSPropertyNameIterator.cpp: (JSC::JSPropertyNameIterator::~JSPropertyNameIterator):
- 2:30 PM Changeset in webkit [55257] by
-
- 7 edits in trunk
File.type support.
https://bugs.webkit.org/show_bug.cgi?id=35361
Reviewed by Dmitry Titov.
WebCore:
Test: LayoutTests/editing/pasteboard/file-input-files-access.html
- html/File.cpp:
(WebCore::File::File):
- html/File.h:
(WebCore::File::type):
- html/File.idl:
LayoutTests:
Update the layout test to test File.type.
- editing/pasteboard/file-input-files-access-expected.txt:
- editing/pasteboard/script-tests/file-input-files-access.js:
(fileListShouldBe):
(runTest):
- 2:15 PM Changeset in webkit [55256] by
-
- 7 edits in trunk
2010-02-25 Oliver Hunt <oliver@apple.com>
Reviewed by Maciej Stachowiak.
Race condition in JSPropertyNameIterator and Structure destruction
https://bugs.webkit.org/show_bug.cgi?id=35398
JSPropertyNameIterator and Structure have a cyclic dependency that they
manage by clearing the appropriate reference in each other during their
destruction. However if the Structure is destroyed while the
JSPropertyNameIterator is dead but not yet finalized the Structures
WeakGCPtr will return null, and so prevent Structure from clearing
the m_cachedStructure pointer of the iterator. When the iterator is
then finalised the m_cachedStructure is invalid, and the attempt to
clear the structures back reference fails.
To fix this we simply make JSPropertyNameIterator keep the Structure
alive, using the weak pointer to break the ref cycle.
- runtime/JSPropertyNameIterator.cpp: (JSC::JSPropertyNameIterator::~JSPropertyNameIterator): The iterator now keeps m_cachedStructure alive itself, so no longer needs to check for it being cleared
- runtime/JSPropertyNameIterator.h: (JSC::JSPropertyNameIterator::setCachedStructure): Add an assertion to ensure correct usage (JSC::JSPropertyNameIterator::cachedStructure): Add .get()
- runtime/Structure.cpp: (JSC::Structure::~Structure): Add an assertion that our iterator isn't already dead, and remove the now unnecessary attempt to clear the ref in the iterator
- runtime/WeakGCPtr.h: (JSC::WeakGCPtr::hasDeadObject): An assert-only function to allow us to assert correct behaviour in the Structure destructor
2010-02-25 Oliver Hunt <oliver@apple.com>
Reviewed by Maciej Stachowiak.
Race condition in JSPropertyNameIterator and Structure destruction
https://bugs.webkit.org/show_bug.cgi?id=35398
Add test to ensure that this race condition doesn't occur.
- fast/js/script-tests/for-in-cached.js: (cacheClearing):
- 2:14 PM Changeset in webkit [55255] by
-
- 2 edits in trunk/WebCore
2010-02-25 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Pavel Feldman.
Javascript console should not attempt to scroll to end of console if console is not visible
- inspector/front-end/ConsoleView.js: (WebInspector.ConsoleView.prototype._scheduleScrollIntoView.scrollIntoView): (WebInspector.ConsoleView.prototype._scheduleScrollIntoView): (WebInspector.ConsoleView.prototype.addMessage):
- 1:56 PM Changeset in webkit [55254] by
-
- 2 edits2 adds in trunk/WebKit/chromium
2010-02-25 James Hawkins <jhawkins@chromium.org>
Reviewed by Darin Fisher.
[Chromium] Implement WebLabelElement.
- WebKit.gyp:
- public/WebLabelElement.h: Added.
- src/WebLabelElement.cpp: Added.
- 1:04 PM Changeset in webkit [55253] by
-
- 3 edits in trunk/WebCore
Qt and Gtk build fixes.
- GNUmakefile.am:
- WebCore.pro: Added CRuntimeObject.{c,cpp}.
- 1:00 PM Changeset in webkit [55252] by
-
- 2 edits in trunk/WebCore
Windows build fix.
- WebCore.vcproj/WebCore.vcproj: Added CRuntimeObject.{c,cpp}.
- 12:56 PM Changeset in webkit [55251] by
-
- 2 edits in trunk/LayoutTests
Tiger build fix.
- java/Makefile: I can't get $(or ...) work on Tiger, so changed to use a single condition.
- 12:23 PM Changeset in webkit [55250] by
-
- 33 edits10 adds in trunk
Reviewed by Geoffrey Garen.
https://bugs.webkit.org/show_bug.cgi?id=35394
<rdar://problem/7685262> Make passing objects between Java and plug-ins work
- WebCore.PluginHostProcess.exp: WebKit now subclasses RuntimeObject, so it needed more exports.
- bridge/runtime_object.cpp: (JSC::Bindings::callRuntimeObject): (JSC::Bindings::callRuntimeConstructor): Assert that a runtime object is passed as function.
- bridge/runtime_object.h: Moved RuntimeObject into Bindings namespace, matching other related classes.
- bridge/jni/jni_jsobject.mm: (JavaJSObject::toString): Pass rootObject to convertValueToJValue(). It's not needed when constructing a string, but this function now takes it for the sake of Object. (JavaJSObject::convertValueToJObject): Check that object class is JavaRuntimeObject, not just RuntimeObject.
- bridge/jni/jsc/JNIBridgeJSC.cpp: (JavaField::setValueToInstance): Pass rootObject to convertValueToJValue(). (JavaArray::setValueAt): Ditto.
- bridge/jni/jsc/JNIUtilityPrivate.h: convertValueToJValue() now takes a RootObject argument, because one is needed to gcProtect an object ghtat is wrapped into JSObject.
- bridge/jni/jsc/JNIUtilityPrivate.cpp: (JSC::Bindings::convertValueToJValue): Convert JavaScript objects to Java JSObject ones. This was already happening in other code paths, which we should change to use common code.
- bridge/jni/jsc/JavaInstanceJSC.cpp: (JavaInstance::newRuntimeObject): Create an appropriate RuntimeObject subclass, which is JavaRuntimeObject for Java. (JavaInstance::invokeMethod): Unwrap returned JavaObjects that contain JS objects.
- WebCore.xcodeproj/project.pbxproj:
- bindings/objc/WebScriptObject.mm: (+[WebScriptObject _convertValueToObjcValue:originRootObject:rootObject:]):
- bridge/c/CRuntimeObject.cpp: Added. (JSC::Bindings::CRuntimeObject::CRuntimeObject): (JSC::Bindings::CRuntimeObject::~CRuntimeObject): (JSC::Bindings::CRuntimeObject::getInternalCInstance):
- bridge/c/CRuntimeObject.h: Added. (JSC::Bindings::CRuntimeObject::classInfo):
- bridge/c/c_instance.cpp: (JSC::Bindings::CInstance::newRuntimeObject):
- bridge/c/c_instance.h:
- bridge/c/c_utility.cpp: (JSC::Bindings::convertValueToNPVariant):
- bridge/jni/jsc/JavaInstanceJSC.h:
- bridge/jni/jsc/JavaRuntimeObject.cpp: Added. (JSC::Bindings::): (JSC::Bindings::JavaRuntimeObject::JavaRuntimeObject): (JSC::Bindings::JavaRuntimeObject::~JavaRuntimeObject): (JSC::Bindings::JavaRuntimeObject::getInternalJavaInstance):
- bridge/jni/jsc/JavaRuntimeObject.h: Added. (JSC::Bindings::JavaRuntimeObject::classInfo):
- bridge/jsc/BridgeJSC.h:
- bridge/objc/ObjCRuntimeObject.h: Added. (JSC::Bindings::ObjCRuntimeObject::classInfo):
- bridge/objc/ObjCRuntimeObject.mm: Added. (JSC::Bindings::): (JSC::Bindings::ObjCRuntimeObject::ObjCRuntimeObject): (JSC::Bindings::ObjCRuntimeObject::~ObjCRuntimeObject): (JSC::Bindings::ObjCRuntimeObject::getInternalObjCInstance):
- bridge/objc/objc_instance.h:
- bridge/objc/objc_instance.mm: (ObjcInstance::newRuntimeObject):
- bridge/objc/objc_runtime.mm: (JSC::Bindings::callObjCFallbackObject):
- bridge/runtime_root.h: Added RuntimeObject subclasses for each instance type, and use them for type casting.
- 10:57 AM Changeset in webkit [55249] by
-
- 20 edits in trunk
2010-02-25 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Rubber-stamped by Xan Lopez.
Adopt the same string as the one that is expected by
fast/parser/fragment-parser.html for the description used by the
<isindex> element.
- platform/gtk/LocalizedStringsGtk.cpp: (WebCore::searchableIndexIntroduction):
- 10:46 AM Changeset in webkit [55248] by
-
- 12 edits in trunk
2010-02-25 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: evaluate-on-hover does not work on HTML files.
- inspector/front-end/SourceCSSTokenizer.re2js:
- inspector/front-end/SourceHTMLTokenizer.js: (WebInspector.SourceHTMLTokenizer): (WebInspector.SourceHTMLTokenizer.prototype.set line): (WebInspector.SourceHTMLTokenizer.prototype._isExpectingAttribute): (WebInspector.SourceHTMLTokenizer.prototype._isExpectingAttributeValue): (WebInspector.SourceHTMLTokenizer.prototype._setExpectingAttribute): (WebInspector.SourceHTMLTokenizer.prototype._setExpectingAttributeValue): (WebInspector.SourceHTMLTokenizer.prototype._attrValueTokenType): (WebInspector.SourceHTMLTokenizer.prototype.nextToken):
- inspector/front-end/SourceHTMLTokenizer.re2js:
- inspector/front-end/SourceJavaScriptTokenizer.js: (WebInspector.SourceJavaScriptTokenizer):
- inspector/front-end/SourceJavaScriptTokenizer.re2js:
- inspector/front-end/SourceTokenizer.js: (WebInspector.SourceTokenizer.prototype.set condition): (WebInspector.SourceTokenizer.prototype.get condition): (WebInspector.SourceTokenizer.prototype.get subTokenizer): (WebInspector.SourceTokenizer.prototype.getLexCondition): (WebInspector.SourceTokenizer.prototype.setLexCondition):
- inspector/front-end/TextEditorHighlighter.js: (WebInspector.TextEditorHighlighter): (WebInspector.TextEditorHighlighter.prototype.set mimeType): (WebInspector.TextEditorHighlighter.prototype.highlight): (WebInspector.TextEditorHighlighter.prototype._highlightInChunks): (WebInspector.TextEditorHighlighter.prototype._highlightLines): (WebInspector.TextEditorHighlighter.prototype._highlightLine):
- inspector/front-end/TextViewer.js: (WebInspector.TextViewer.prototype._paintLine):
- 10:27 AM Changeset in webkit [55247] by
-
- 5 edits in trunk/JavaScriptCore
Make the context that was passed to the ThreadFunction accessible.
https://bugs.webkit.org/show_bug.cgi?id=35379
Patch by Jochen Eisinger <jochen@chromium.org> on 2010-02-25
Reviewed by Jeremy Orlow.
When a database is opened, right now you
don't have any context from where it is opened. The problem is that
the actual calls that open a database go through the sqlite3 vfs
layer, so there's no easy way to pass this function down to to
platform/sql/chromium/SQLFileSystemChromium*.cpp
This patch will allow you to get from anywhere within webkit a pointer
to the Thread object that actually created the thread you're currently
on (in case of the database, this can be either a thread forked of
from the main thread or from a worker thread), and query the object
for context information.
- wtf/Threading.h:
- wtf/ThreadingNone.cpp:
(WTF::threadContext):
- wtf/ThreadingPthreads.cpp:
(WTF::):
(WTF::identifierByPthreadHandle):
(WTF::establishIdentifierForPthreadHandle):
(WTF::pthreadHandleForIdentifier):
(WTF::contextForIdentifier):
(WTF::createThreadInternal):
(WTF::currentThread):
(WTF::threadContext):
- wtf/ThreadingWin.cpp:
(WTF::):
(WTF::threadMap):
(WTF::storeThreadHandleByIdentifier):
(WTF::threadHandleForIdentifier):
(WTF::contextForIdentifier):
(WTF::createThreadInternal):
(WTF::threadContext):
- 10:20 AM Changeset in webkit [55246] by
-
- 5 edits in trunk/JavaScriptCore
Reverting to re-submit with better change log.
- wtf/Threading.h:
- wtf/ThreadingNone.cpp:
(WTF::isMainThread):
- wtf/ThreadingPthreads.cpp:
(WTF::identifierByPthreadHandle):
(WTF::establishIdentifierForPthreadHandle):
(WTF::pthreadHandleForIdentifier):
(WTF::createThreadInternal):
(WTF::currentThread):
- wtf/ThreadingWin.cpp:
(WTF::threadMap):
(WTF::storeThreadHandleByIdentifier):
(WTF::threadHandleForIdentifier):
(WTF::createThreadInternal):
- 10:18 AM Changeset in webkit [55245] by
-
- 3 edits in trunk/WebKit/gtk
2010-02-25 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Reviewed by Xan Lopez.
[Gtk] crashed when destroying
https://bugs.webkit.org/show_bug.cgi?id=31271
NULL-check the page before relaying the focus out event, since
this might happen when destroying the widget without destroying
its parent, and we currently crash.
- tests/testwebview.c: (delayed_destroy): (test_webkit_web_view_destroy): (main):
- webkit/webkitwebview.cpp: (webkit_web_view_focus_in_event):
- 10:16 AM Changeset in webkit [55244] by
-
- 2 edits in trunk/WebCore
2010-02-25 Xan Lopez <xlopez@igalia.com>
Reviewed by Gustavo Noronha.
Simple style cleanups.
- plugins/gtk/PluginViewGtk.cpp: (WebCore::plugRemovedCallback): (WebCore::plugAddedCallback): (WebCore::PluginView::platformStart):
- 10:16 AM Changeset in webkit [55243] by
-
- 3 edits in trunk/WebKitTools
2010-02-25 Adam Barth <abarth@webkit.org>
Reviewed by David Levin.
EWS leaks memory slowly
https://bugs.webkit.org/show_bug.cgi?id=35395
The EWS bots leak memory very slowly. If you run them for about a
month, each one will take up around 1 GB of virutal memory. If you run
several of them on one machine, you'll eventually exhaust all available
memory and grind the bots to a halt.
This patch introduces a --exit-after-iteration option to the queues so
that we run them for a finite amount of time. Once they exit and
restart, they'll reclaim the leaked memory. I'm not sure how many
iterations I'll end up running them for. I'll need to sort that out
operationally, but my initial guess is around 1000.
- Scripts/webkitpy/commands/queues.py:
- Scripts/webkitpy/commands/queues_unittest.py:
- 10:13 AM Changeset in webkit [55242] by
-
- 2 edits in trunk/WebCore
2010-02-25 Andreas Kling <andreas.kling@nokia.com>
Reviewed by Darin Adler.
Optimize decoding of Latin-1 text by exploiting the fact that most of it will
be ASCII-only data.
- platform/text/TextCodecLatin1.cpp: (WebCore::TextCodecLatin1::decode):
- 9:55 AM Changeset in webkit [55241] by
-
- 6 edits in trunk
2010-02-25 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Dimitri Glazkov.
Web Inspector: make script lines count calculation lazy.
- inspector/front-end/Script.js: (WebInspector.Script): (WebInspector.Script.prototype.get linesCount):
- inspector/front-end/ScriptsPanel.js:
- inspector/front-end/SourceView.js: (WebInspector.SourceView.prototype._addBreakpoint):
- 9:20 AM Changeset in webkit [55240] by
-
- 5 edits in trunk/WebCore
Change hardcoded gcc paths to be Solaris friendly
https://bugs.webkit.org/show_bug.cgi?id=35213
Patch by James Choi <jchoi42@pha.jhu.edu> on 2010-02-25
Reviewed by David Levin.
- bindings/scripts/CodeGeneratorObjC.pm:
- bindings/scripts/IDLParser.pm:
- css/make-css-file-arrays.pl:
- dom/make_names.pl:
- 9:13 AM Changeset in webkit [55239] by
-
- 2 edits in trunk/WebKit/chromium
2010-02-24 Darin Fisher <darin@chromium.org>
Reviewed by David Levin.
Add a missing WebString.h include.
https://bugs.webkit.org/show_bug.cgi?id=35360
This is required since some of the methods have implementations that
return a WebString.
- public/WebCookieJar.h:
- 9:04 AM Changeset in webkit [55238] by
-
- 2 edits in trunk/WebCore
2010-02-25 Xan Lopez <xlopez@igalia.com>
Reviewed by Gustavo Noronha.
Workaround Java plugins not drawing themselves properly on first
expose by doing a late size-allocate after 'plug-added' has been
emitted on the embedding GtkSocket. It's unclear to me if this is
a bug in our side or theirs, but this should be pretty safe and
fixes the annoyance while we investigate it further.
- plugins/gtk/PluginViewGtk.cpp: (WebCore::plugAddedCallback): (WebCore::PluginView::platformStart):
- 8:05 AM Changeset in webkit [55237] by
-
- 3 edits in trunk/WebCore
Add missing include guards
Reviewed by Tor Arne Vestbø.
- loader/CrossOriginPreflightResultCache.h:
- loader/MainResourceLoader.h:
- 8:04 AM Changeset in webkit [55236] by
-
- 2 edits in trunk/WebCore
[Qt] Restrict the optimization flags for Symbian to release builds.
Reviewed by Tor Arne Vestbø.
- WebCore.pro:
- 7:06 AM Changeset in webkit [55235] by
-
- 9 edits1 add in trunk
2010-02-25 Jarkko Sakkinen <jarkko.sakkinen@tieto.com>
Reviewed by Kenneth Rohde Christiansen.
Qt WebGL support
Adds GraphicsContext3D QtWebKit implementation.
https://bugs.webkit.org/show_bug.cgi?id=35153
- WebCore.pri:
- WebCore.pro:
- platform/graphics/GraphicsContext3D.h:
- platform/graphics/qt/GraphicsContext3DQt.cpp: Added. (WebCore::GraphicsContext3DInternal::isValid): (WebCore::GraphicsContext3DInternal::GraphicsContext3DInternal): (WebCore::GraphicsContext3DInternal::~GraphicsContext3DInternal): (WebCore::GraphicsContext3DInternal::getProcAddress): (WebCore::GraphicsContext3D::create): (WebCore::GraphicsContext3D::GraphicsContext3D): (WebCore::GraphicsContext3D::~GraphicsContext3D): (WebCore::GraphicsContext3D::platformGraphicsContext3D): (WebCore::GraphicsContext3D::platformTexture): (WebCore::GraphicsContext3D::makeContextCurrent): (WebCore::GraphicsContext3D::beginPaint): (WebCore::GraphicsContext3D::endPaint): (WebCore::GraphicsContext3D::reshape): (WebCore::GraphicsContext3D::activeTexture): (WebCore::GraphicsContext3D::attachShader): (WebCore::GraphicsContext3D::bindAttribLocation): (WebCore::GraphicsContext3D::bindBuffer): (WebCore::GraphicsContext3D::bindFramebuffer): (WebCore::GraphicsContext3D::bindRenderbuffer): (WebCore::GraphicsContext3D::bindTexture): (WebCore::GraphicsContext3D::blendColor): (WebCore::GraphicsContext3D::blendEquation): (WebCore::GraphicsContext3D::blendEquationSeparate): (WebCore::GraphicsContext3D::blendFunc): (WebCore::GraphicsContext3D::blendFuncSeparate): (WebCore::GraphicsContext3D::bufferData): (WebCore::GraphicsContext3D::bufferSubData): (WebCore::GraphicsContext3D::checkFramebufferStatus): (WebCore::GraphicsContext3D::clearColor): (WebCore::GraphicsContext3D::clear): (WebCore::GraphicsContext3D::clearDepth): (WebCore::GraphicsContext3D::clearStencil): (WebCore::GraphicsContext3D::colorMask): (WebCore::GraphicsContext3D::compileShader): (WebCore::GraphicsContext3D::copyTexImage2D): (WebCore::GraphicsContext3D::copyTexSubImage2D): (WebCore::GraphicsContext3D::cullFace): (WebCore::GraphicsContext3D::depthFunc): (WebCore::GraphicsContext3D::depthMask): (WebCore::GraphicsContext3D::depthRange): (WebCore::GraphicsContext3D::detachShader): (WebCore::GraphicsContext3D::disable): (WebCore::GraphicsContext3D::disableVertexAttribArray): (WebCore::GraphicsContext3D::drawArrays): (WebCore::GraphicsContext3D::drawElements): (WebCore::GraphicsContext3D::enable): (WebCore::GraphicsContext3D::enableVertexAttribArray): (WebCore::GraphicsContext3D::finish): (WebCore::GraphicsContext3D::flush): (WebCore::GraphicsContext3D::framebufferRenderbuffer): (WebCore::GraphicsContext3D::framebufferTexture2D): (WebCore::GraphicsContext3D::frontFace): (WebCore::GraphicsContext3D::generateMipmap): (WebCore::GraphicsContext3D::getActiveAttrib): (WebCore::GraphicsContext3D::getActiveUniform): (WebCore::GraphicsContext3D::getAttribLocation): (WebCore::GraphicsContext3D::getContextAttributes): (WebCore::GraphicsContext3D::getError): (WebCore::GraphicsContext3D::getString): (WebCore::GraphicsContext3D::hint): (WebCore::GraphicsContext3D::isBuffer): (WebCore::GraphicsContext3D::isEnabled): (WebCore::GraphicsContext3D::isFramebuffer): (WebCore::GraphicsContext3D::isProgram): (WebCore::GraphicsContext3D::isRenderbuffer): (WebCore::GraphicsContext3D::isShader): (WebCore::GraphicsContext3D::isTexture): (WebCore::GraphicsContext3D::lineWidth): (WebCore::GraphicsContext3D::linkProgram): (WebCore::GraphicsContext3D::pixelStorei): (WebCore::GraphicsContext3D::polygonOffset): (WebCore::GraphicsContext3D::readPixels): (WebCore::GraphicsContext3D::releaseShaderCompiler): (WebCore::GraphicsContext3D::renderbufferStorage): (WebCore::GraphicsContext3D::sampleCoverage): (WebCore::GraphicsContext3D::scissor): (WebCore::GraphicsContext3D::shaderSource): (WebCore::GraphicsContext3D::stencilFunc): (WebCore::GraphicsContext3D::stencilFuncSeparate): (WebCore::GraphicsContext3D::stencilMask): (WebCore::GraphicsContext3D::stencilMaskSeparate): (WebCore::GraphicsContext3D::stencilOp): (WebCore::GraphicsContext3D::stencilOpSeparate): (WebCore::GraphicsContext3D::texParameterf): (WebCore::GraphicsContext3D::texParameteri): (WebCore::GraphicsContext3D::uniform1f): (WebCore::GraphicsContext3D::uniform1fv): (WebCore::GraphicsContext3D::uniform2f): (WebCore::GraphicsContext3D::uniform2fv): (WebCore::GraphicsContext3D::uniform3f): (WebCore::GraphicsContext3D::uniform3fv): (WebCore::GraphicsContext3D::uniform4f): (WebCore::GraphicsContext3D::uniform4fv): (WebCore::GraphicsContext3D::uniform1i): (WebCore::GraphicsContext3D::uniform1iv): (WebCore::GraphicsContext3D::uniform2i): (WebCore::GraphicsContext3D::uniform2iv): (WebCore::GraphicsContext3D::uniform3i): (WebCore::GraphicsContext3D::uniform3iv): (WebCore::GraphicsContext3D::uniform4i): (WebCore::GraphicsContext3D::uniform4iv): (WebCore::GraphicsContext3D::uniformMatrix2fv): (WebCore::GraphicsContext3D::uniformMatrix3fv): (WebCore::GraphicsContext3D::uniformMatrix4fv): (WebCore::GraphicsContext3D::useProgram): (WebCore::GraphicsContext3D::validateProgram): (WebCore::GraphicsContext3D::vertexAttrib1f): (WebCore::GraphicsContext3D::vertexAttrib1fv): (WebCore::GraphicsContext3D::vertexAttrib2f): (WebCore::GraphicsContext3D::vertexAttrib2fv): (WebCore::GraphicsContext3D::vertexAttrib3f): (WebCore::GraphicsContext3D::vertexAttrib3fv): (WebCore::GraphicsContext3D::vertexAttrib4f): (WebCore::GraphicsContext3D::vertexAttrib4fv): (WebCore::GraphicsContext3D::vertexAttribPointer): (WebCore::GraphicsContext3D::viewport): (WebCore::GraphicsContext3D::getBooleanv): (WebCore::GraphicsContext3D::getBufferParameteriv): (WebCore::GraphicsContext3D::getFloatv): (WebCore::GraphicsContext3D::getFramebufferAttachmentParameteriv): (WebCore::GraphicsContext3D::getIntegerv): (WebCore::GraphicsContext3D::getProgramiv): (WebCore::GraphicsContext3D::getProgramInfoLog): (WebCore::GraphicsContext3D::getRenderbufferParameteriv): (WebCore::GraphicsContext3D::getShaderiv): (WebCore::GraphicsContext3D::getShaderInfoLog): (WebCore::GraphicsContext3D::getShaderSource): (WebCore::GraphicsContext3D::getTexParameterfv): (WebCore::GraphicsContext3D::getTexParameteriv): (WebCore::GraphicsContext3D::getUniformfv): (WebCore::GraphicsContext3D::getUniformiv): (WebCore::GraphicsContext3D::getUniformLocation): (WebCore::GraphicsContext3D::getVertexAttribfv): (WebCore::GraphicsContext3D::getVertexAttribiv): (WebCore::GraphicsContext3D::getVertexAttribOffset): (WebCore::GraphicsContext3D::texImage2D): (WebCore::GraphicsContext3D::texSubImage2D): (WebCore::GraphicsContext3D::createBuffer): (WebCore::GraphicsContext3D::createFramebuffer): (WebCore::GraphicsContext3D::createProgram): (WebCore::GraphicsContext3D::createRenderbuffer): (WebCore::GraphicsContext3D::createShader): (WebCore::GraphicsContext3D::createTexture): (WebCore::GraphicsContext3D::deleteBuffer): (WebCore::GraphicsContext3D::deleteFramebuffer): (WebCore::GraphicsContext3D::deleteProgram): (WebCore::GraphicsContext3D::deleteRenderbuffer): (WebCore::GraphicsContext3D::deleteShader): (WebCore::GraphicsContext3D::deleteTexture): (WebCore::GraphicsContext3D::sizeInBytes): (WebCore::GraphicsContext3D::synthesizeGLError): (WebCore::GraphicsContext3D::getImageData):
2010-02-25 Jarkko Sakkinen <jarkko.sakkinen@tieto.com>
Reviewed by Kenneth Rohde Christiansen.
Qt WebGL support
Adds enabling and disabling of WebGL support to QWebSettings.
https://bugs.webkit.org/show_bug.cgi?id=35153
- Api/qwebsettings.cpp: (QWebSettingsPrivate::apply): (QWebSettings::QWebSettings):
- Api/qwebsettings.h:
2010-02-25 Jarkko Sakkinen <jarkko.sakkinen@tieto.com>
Reviewed by Kenneth Rohde Christiansen.
Qt WebGL support
Adds toggling of WebGL support to QtLauncher.
https://bugs.webkit.org/show_bug.cgi?id=35153
- QtLauncher/main.cpp: (LauncherWindow::toggleWebGL): (LauncherWindow::setupUI):
- 6:52 AM BuildingQtOnSymbian edited by
- (diff)
- 6:50 AM BuildingQtOnSymbian edited by
- (diff)
- 6:49 AM Changeset in webkit [55234] by
-
- 5 edits in trunk/JavaScriptCore
2010-02-25 Jochen Eisinger <jochen@chromium.org>
Reviewed by Jeremy Orlow.
Make the context that was passed to the ThreadFunction accessible.
https://bugs.webkit.org/show_bug.cgi?id=35379
- wtf/Threading.h:
- wtf/ThreadingNone.cpp: (WTF::threadContext):
- wtf/ThreadingPthreads.cpp: (WTF::): (WTF::identifierByPthreadHandle): (WTF::establishIdentifierForPthreadHandle): (WTF::pthreadHandleForIdentifier): (WTF::contextForIdentifier): (WTF::createThreadInternal): (WTF::currentThread): (WTF::threadContext):
- wtf/ThreadingWin.cpp: (WTF::): (WTF::threadMap): (WTF::storeThreadHandleByIdentifier): (WTF::threadHandleForIdentifier): (WTF::contextForIdentifier): (WTF::createThreadInternal): (WTF::threadContext):
- 6:34 AM Changeset in webkit [55233] by
-
- 4 edits2 moves in trunk/WebCore
2010-02-25 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: Swap images for activate and deactivate breakpoints.
- WebCore.gypi:
- inspector/front-end/Images/breakpointsActivateButtonGlyph.png: Renamed from WebCore/inspector/front-end/Images/deactivateBreakpointsButtonGlyph.png.
- inspector/front-end/Images/breakpointsDeactivateButtonGlyph.png: Renamed from WebCore/inspector/front-end/Images/deactivateBreakpointsDisabledButtonGlyph.png.
- inspector/front-end/WebKit.qrc:
- inspector/front-end/inspector.css:
- 6:19 AM Changeset in webkit [55232] by
-
- 2 edits in trunk/WebCore
2010-02-25 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Reviewed by Xan Lopez.
Go back on symlink resolution if we are loading the flash plugin,
and the path contains /netscape/, following what Chromium does.
Thanks to Evan Martin for the help on this!
- plugins/gtk/PluginPackageGtk.cpp: (WebCore::PluginPackage::load):
- 5:45 AM Changeset in webkit [55231] by
-
- 8 edits in trunk/WebCore
2010-02-23 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: Scripts panel shows blank source when stopping on a breakpoint on refresh.
- inspector/front-end/Panel.js: (WebInspector.Panel.prototype.canShowSourceLine): (WebInspector.Panel.prototype.showSourceLine):
- inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel.prototype.canShowSourceLine): (WebInspector.ResourcesPanel.prototype.showSourceLine):
- inspector/front-end/Script.js: (WebInspector.Script):
- inspector/front-end/ScriptView.js: (WebInspector.ScriptView.prototype.setupSourceFrameIfNeeded):
- inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype.show): (WebInspector.ScriptsPanel.prototype.get searchableViews): (WebInspector.ScriptsPanel.prototype.addScript): (WebInspector.ScriptsPanel.prototype._resourceLoadingFinished): (WebInspector.ScriptsPanel.prototype.addBreakpoint): (WebInspector.ScriptsPanel.prototype.removeBreakpoint): (WebInspector.ScriptsPanel.prototype.reset): (WebInspector.ScriptsPanel.prototype.canShowSourceLine): (WebInspector.ScriptsPanel.prototype.showSourceLine): (WebInspector.ScriptsPanel.prototype._scriptOrResourceForURLAndLine): (WebInspector.ScriptsPanel.prototype.showView): (WebInspector.ScriptsPanel.prototype._sourceFrameForScriptOrResource): (WebInspector.ScriptsPanel.prototype._showScriptOrResource): (WebInspector.ScriptsPanel.prototype._addScriptToFilesMenu.optionCompare): (WebInspector.ScriptsPanel.prototype._addScriptToFilesMenu):
- inspector/front-end/SourceView.js: (WebInspector.SourceView.prototype._addBreakpoint):
- inspector/front-end/inspector.js: (WebInspector.documentClick.followLink): (WebInspector.documentClick): (WebInspector._choosePanelToShowSourceLine): (WebInspector.canShowSourceLine): (WebInspector.showSourceLine):
- 5:24 AM Changeset in webkit [55230] by
-
- 10 edits3 adds in trunk
2010-02-25 Ben Murdoch <benm@google.com>
Reviewed by Kenneth Rohde Christiansen.
The target element of a Touch should be the target where that touch originated, not where it is now.
https://bugs.webkit.org/show_bug.cgi?id=34585
- fast/events/touch/basic-single-touch-events-expected.txt: Update expected target element.
- fast/events/touch/script-tests/basic-single-touch-events.js: ditto.
- fast/events/touch/script-tests/touch-target.js: Added.
- fast/events/touch/touch-target-expected.txt: Added.
- fast/events/touch/touch-target.html: Added.
2010-02-25 Ben Murdoch <benm@google.com>
Reviewed by Kenneth Rohde Christiansen.
The target element of a Touch should be the target where that touch originated, not where it is now.
https://bugs.webkit.org/show_bug.cgi?id=34585
Currently the target of a touch is set to the resulting node of the hit test where the touch currently
is. This does not match the behavior of iPhone or Android. This patch uses a hashmap on the EventHandler
to keep track of the target element when a touch is first started. This target is then used as the target
for subsequent touches with the same id. This matches observed behavior on iPhone and Android.
Tests:
fast/events/touch/touch-target.html: Added.
fast/events/touch/basic-single-touch-events.html: Updated.
- page/EventHandler.cpp: (WebCore::EventHandler::handleTouchEvent): Store the originating target element of a touch in a hashmap
so that we can reuse that target for future events caused by that touch. This matches observed behavior
on iPhone and Android.
- page/EventHandler.h: Add hashmap as a member.
- platform/PlatformTouchPoint.h: (WebCore::PlatformTouchPoint::id): Store the touch point id as unsigned.
- platform/qt/PlatformTouchPointQt.cpp: (WebCore::PlatformTouchPoint::PlatformTouchPoint): Cast platform touch id from signed to unsigned. Qt API
docs state that it will always be >= 0.
2010-02-25 Ben Murdoch <benm@google.com>
Reviewed by Kenneth Rohde Christiansen.
The target element of a Touch should be the target where that touch originated, not where it is now.
https://bugs.webkit.org/show_bug.cgi?id=34585
- DumpRenderTree/qt/EventSenderQt.cpp: (EventSender::addTouchPoint): Fix a bug where touch points were not being given unique ids.
- 4:49 AM Changeset in webkit [55229] by
-
- 2 edits in trunk/LayoutTests
2010-02-25 Xan Lopez <xlopez@igalia.com>
Reviewed by Gustavo Noronha.
Unskip a bunch of (AFAICT) non-flakey HTTP tests that we currently
pass.
- platform/gtk/Skipped:
- 3:48 AM Changeset in webkit [55228] by
-
- 2 edits in trunk/WebCore
Add a convenient center() method to IntRect
https://bugs.webkit.org/show_bug.cgi?id=35346
Reviewed by Simon Fraser.
Patch by Antonio Gomes <tonikitoo@webkit.org>
As it is a convenience method, and implemention is
based on FloatRect's one, patch does not provide a
layout test.
- platform/graphics/IntRect.h:
(WebCore::IntRect::center):
- 3:24 AM Changeset in webkit [55227] by
-
- 11 edits1 add in trunk/WebCore
2010-02-25 Andrey Kosyakov <caseq@chromium.org>
Reviewed by Pavel Feldman.
Fake workers implementation that simulates workers using iframe and timer,
needed to support workers debugging. Also, a facility to inject scripts into
inspected page upon load.
https://bugs.webkit.org/show_bug.cgi?id=35148
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- inspector/InspectorBackend.cpp: (WebCore::InspectorBackend::addScriptToEvaluateOnLoad): (WebCore::InspectorBackend::removeAllScriptsToEvaluateOnLoad):
- inspector/InspectorBackend.h:
- inspector/InspectorBackend.idl:
- inspector/InspectorController.cpp: (WebCore::InspectorController::didCommitLoad): (WebCore::InspectorController::addScriptToEvaluateOnLoad): (WebCore::InspectorController::removeAllScriptsToEvaluateOnLoad):
- inspector/InspectorController.h:
- inspector/front-end/InjectedFakeWorker.js: Added. (InjectedFakeWorker.Worker): (InjectedFakeWorker.FakeWorker): (InjectedFakeWorker.FakeWorker.prototype.postMessage): (InjectedFakeWorker.FakeWorker.prototype.terminate): (InjectedFakeWorker.FakeWorker.prototype._onmessageWrapper): (InjectedFakeWorker.FakeWorker.prototype._dispatchMessage): (InjectedFakeWorker.FakeWorker.prototype._handleException): (InjectedFakeWorker.FakeWorker.prototype._buildWorker): (InjectedFakeWorker.FakeWorker.prototype._setupWorkerContext.handler): (InjectedFakeWorker.FakeWorker.prototype._setupWorkerContext): (InjectedFakeWorker.FakeWorker.prototype._importScripts): (InjectedFakeWorker.FakeWorker.prototype._loadScript): (InjectedFakeWorker.URL): (InjectedFakeWorker.URL.prototype.urlRegEx.split): (InjectedFakeWorker.URL.prototype.mockLocation): (InjectedFakeWorker.URL.prototype.completeWith): (InjectedFakeWorker.URL.prototype.sameOrigin): (InjectedFakeWorker.DOMCoreException.formatError): (InjectedFakeWorker.DOMCoreException): (InjectedFakeWorker.noop):
- inspector/front-end/InspectorBackendStub.js: (.WebInspector.InspectorBackendStub.prototype.setInjectedScriptSource): (.WebInspector.InspectorBackendStub.prototype.addScriptToEvaluateOnLoad): (.WebInspector.InspectorBackendStub.prototype.removeAllScriptsToEvaluateOnLoad):
- inspector/front-end/WebKit.qrc:
- inspector/front-end/inspector.html:
- 2:04 AM BuildingQtOnWindows edited by
- (diff)
