⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Feb 28, 2010:

9:14 PM Changeset in webkit [55360] by Chris Jerdonek
  • 3 edits in trunk/WebKitTools

Exempted WebKitTools/Scripts/webkitpy/thirdparty from all
style checks except for the whitespace/carriage_return check
and the pep8 tab and trailing white space checks.

Reviewed by Shinichiro Hamaji.

https://bugs.webkit.org/show_bug.cgi?id=35497

  • Scripts/webkitpy/style/checker.py:
    • Adjusted the _PATH_RULES_SPECIFIER configuration as necessary.
    • Added enough pep8 categories to _all_categories() for the unit tests to pass.
  • Scripts/webkitpy/style/checker_unittest.py:
    • Updated the test_path_rules_specifier() unit test.
12:04 PM Changeset in webkit [55359] by ap@apple.com
  • 2 edits in trunk/WebCore

Reviewed by Dan Bernstein.

https://bugs.webkit.org/show_bug.cgi?id=35496
<rdar://problem/7663444> Opening newsweek.com and youtube.com has become very slow in debug builds

  • css/CSSStyleSelector.cpp: (WebCore::CSSRuleSet::getIDRules): (WebCore::CSSRuleSet::getClassRules): (WebCore::CSSRuleSet::getTagRules): Removed consistency checks, as they affect performance too much in this case.
4:57 AM Changeset in webkit [55358] by robert@webkit.org
  • 7 edits
    2 adds in trunk

[Qt] Support private browsing mode in plugins

Add support for NPNVprivateModeBool property in plugins.

See also: https://developer.mozilla.org/En/Supporting_private_browsing_in_plugins

The NPNVprivateModeBool property is supported as scriptable property privateBrowsingEnabled
in the test WebKit plugin. The Mac platform also supports a cachedPrivateBrowsingEnabled
property implemented in the test plugin. This allows the Layout test plugins/private-browsing-mode.html
to retrieve the previous value of NPNVprivateModeBool in the test plugin. Due to the platform-specific
overhead required to support this bespoke property it is not implemented as part of this patch, instead
a new test, plugins/private-browsing-mode-2.html, is added to ensure that setting and resetting privateBrowsingEnabled works as expected.

http://bugs.webkit.org/show_bug.cgi?id=33180

Feb 27, 2010:

11:09 PM Changeset in webkit [55357] by Joseph Pecoraro
  • 2 edits in trunk/WebCore

2010-02-27 Joseph Pecoraro <Joseph Pecoraro>

Reviewed by Timothy Hatcher.

Web Inspector shouldn't show a white color box for "-webkit-line-break: after-white-space"
https://bugs.webkit.org/show_bug.cgi?id=33478

  • inspector/front-end/StylesSidebarPane.js:
2:45 PM Changeset in webkit [55356] by xan@webkit.org
  • 2 edits in trunk/LayoutTests

2010-02-27 Xan Lopez <xlopez@igalia.com>

Rubber-stamped by Gustavo Noronha.

Unskip test that we seem to pass now.

  • platform/gtk/Skipped:
2:26 PM Changeset in webkit [55355] by xan@webkit.org
  • 2 edits
    2 adds in trunk/LayoutTests

2010-02-27 Xan Lopez <xlopez@igalia.com>

Reviewed by Gustavo Noronha.

Add platform results for plugin test and unskip it. The filename
of our test plugin is not the same than the one expected in the
default result file.

  • platform/gtk/Skipped:
  • platform/gtk/plugins/plugin-javascript-access-expected.txt: Added.
12:46 PM ApplicationsGtk edited by peterbloomfield@bellsouth.net
(diff)
12:16 PM ApplicationsGtk edited by peterbloomfield@bellsouth.net
info about the WebKit option in the Balsa email client (diff)
9:47 AM Changeset in webkit [55354] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] Skip new test introduced in r55353 because of missing drag&drop support.

  • platform/qt/Skipped: fast/css/user-drag-none.html skipped.
4:39 AM Changeset in webkit [55353] by mitz@apple.com
  • 5 edits
    2 adds in trunk

<rdar://problem/7696607> Links do not respect -webkit-user-drag: none
https://bugs.webkit.org/show_bug.cgi?id=35475

Reviewed by Maciej Stachowiak.

WebCore:

Test: fast/css/user-drag-none.html

  • page/DragController.cpp:

(WebCore::DragController::mayStartDragAtEventLocation): Added a node
parameter. The image drag check is done against the node, rather than
than against the hit test result. This prevents a non-draggable image
with an auto-draggable ancestor from being dragged alone. The link drag
check now ignores links that are -webkit-user-drag: none.

  • page/DragController.h:
  • page/EventHandler.cpp:

(WebCore::EventHandler::shouldDragAutoNode): Pass the current node
to mayStartDragAtEventLocation().

LayoutTests:

  • fast/css/user-drag-none-expected.txt: Added.
  • fast/css/user-drag-none.html: Added.
2:48 AM Changeset in webkit [55352] by pfeldman@chromium.org
  • 2 edits in trunk/WebCore

2010-02-27 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: REGRESSION: hangs when scrolling in Resource pane.

https://bugs.webkit.org/show_bug.cgi?id=35216

  • inspector/front-end/TextEditorHighlighter.js: (WebInspector.TextEditorHighlighter): (WebInspector.TextEditorHighlighter.prototype.highlight): (WebInspector.TextEditorHighlighter.prototype._highlightInChunks): (WebInspector.TextEditorHighlighter.prototype._highlightLines):
12:57 AM Changeset in webkit [55351] by xan@webkit.org
  • 4 edits in trunk

WebCore:

2010-02-27 Xan Lopez <xlopez@igalia.com>

Reviewed by Gustavo Noronha.

Abort XEmbed plugin initialization if our parent is not anchored
in a widget hierarchy. This can happen when the browser window is
destroyed while the plugin is being loaded, and will lead to a
crash.

  • plugins/gtk/PluginViewGtk.cpp: (WebCore::PluginView::platformStart):

LayoutTests:

2010-02-27 Xan Lopez <xlopez@igalia.com>

Reviewed by Gustavo Noronha.

We now pass this test, unskip.

  • platform/gtk/Skipped:
12:24 AM Changeset in webkit [55350] by Chris Jerdonek
  • 5 edits
    3 adds in trunk/WebKitTools

Added Python style checking to check-webkit-style using
the third-party pep8 module (via autoinstall).

Reviewed by David Levin.

https://bugs.webkit.org/show_bug.cgi?id=33639

  • Scripts/webkitpy/style/checker.py:
    • Added PYTHON to FileType.
    • Updated ProcessorDispatcher to return a PythonProcessor for *.py files.
  • Scripts/webkitpy/style/checker_unittest.py:
    • Updated the ProcessorDispatcher unit tests for *.py files.
  • Scripts/webkitpy/style/processors/python.py: Added.
    • Added PythonProcessor class.
  • Scripts/webkitpy/style/processors/python_unittest.py: Added.
    • Added PythonProcessor unit tests.
  • Scripts/webkitpy/style/processors/python_unittest_input.py: Added.
    • Added a sample Python file to test the PythonProcessor.process() code path (since pep8 accepts a file path).
  • Scripts/webkitpy/style/unittests.py:
    • Updated the style unit test file to import python_unittest.py.
  • Scripts/webkitpy/style_references.py:
    • Adjusted style references to import pep8.
12:10 AM Changeset in webkit [55349] by eric@webkit.org
  • 4 edits in trunk/WebKit/mac

2010-02-27 Jing Jin <jjin@apple.com>

Reviewed by Timothy Hatcher.

Move implementation of Bug 35449 into WebFramePrivate.

  • WebView/WebFrame.h:
  • WebView/WebFrame.mm: (-[WebFrame setAllowScrollersToOverlapContent:]): (-[WebFrame setAlwaysHideHorizontalScroller:]): (-[WebFrame setAlwaysHideVerticalScroller:]):
  • WebView/WebFramePrivate.h:
12:04 AM Changeset in webkit [55348] by Chris Jerdonek
  • 6 edits
    3 adds
    1 delete in trunk/WebKitTools

Rewrote autoinstall.py to support unzipping *.zip files after
download, unzipping and extracting *.tar.gz files after download,
and copying installed files to a destination directory.

Reviewed by David Levin.

https://bugs.webkit.org/show_bug.cgi?id=35163

These changes will allow us to autoinstall pep8.py from the web
and to put our third-party autoinstalled code in an explicit
directory like webkitpy/thirdparty/autoinstalled. They should
also speed up imports from autoinstalled *.zip packages slightly
since *.pyc files cannot be generated when importing from
zipped packages.

  • Scripts/webkitpy/init.py:
    • Updated the autoinstall lines to use the new autoinstall methods.
    • Added pep8.py to the list of auto-installed packages.
  • Scripts/webkitpy/bugzilla.py:
    • Updated mechanize import path.
  • Scripts/webkitpy/init/init.py: Copied from WebKitTools/QueueStatusServer/filters/init.py.
  • Scripts/webkitpy/init/autoinstall.py: Added.
    • Added AutoInstaller class.
    • Added sample testing usage to main.
  • Scripts/webkitpy/networktransaction.py:
    • Updated mechanize import path.
  • Scripts/webkitpy/networktransaction_unittest.py:
    • Updated mechanize import path.
  • Scripts/webkitpy/statusserver.py:
    • Updated mechanize import path.
  • Scripts/webkitpy/thirdparty/autoinstall.py: Removed.
    • Replaced with rewritten autoinstall in init/autoinstall.py.
Note: See TracTimeline for information about the timeline view.