Timeline
Mar 1, 2010:
- 8:14 PM Changeset in webkit [55399] by
-
- 4 edits in trunk/WebKit/win
Remove Windows line endings from some files.
Rubber-stamped by Alice Liu.
- Interfaces/IWebEmbeddedView.idl:
- WebCoreSupport/EmbeddedWidget.cpp:
(EmbeddedWidget::create):
(EmbeddedWidget::~EmbeddedWidget):
(EmbeddedWidget::createWindow):
(EmbeddedWidget::invalidateRect):
(EmbeddedWidget::setFrameRect):
(EmbeddedWidget::frameRectsChanged):
(EmbeddedWidget::setFocus):
(EmbeddedWidget::show):
(EmbeddedWidget::hide):
(EmbeddedWidget::windowClipRect):
(EmbeddedWidget::setParent):
(EmbeddedWidget::attachToWindow):
(EmbeddedWidget::detachFromWindow):
(EmbeddedWidget::didReceiveResponse):
(EmbeddedWidget::didReceiveData):
(EmbeddedWidget::didFinishLoading):
(EmbeddedWidget::didFail):
- WebCoreSupport/EmbeddedWidget.h:
(EmbeddedWidget::EmbeddedWidget):
- 8:14 PM Changeset in webkit [55398] by
-
- 2 edits in trunk/WebKit/win
Some WebKit DOMNode API is unimplemented.
https://bugs.webkit.org/show_bug.cgi?id=35554
Reviewed by Alice Liu.
- DOMCoreClasses.cpp:
(DOMNode::nextSibling):
Create a DOMNode to wrap m_node's next sibling, and assign it to the
out param 'result'.
(DOMNode::insertBefore):
Query for the DOMNode for newChild, and return early if we fail. Query
refChild for DOMNode. Call insertBefore(), passing the newChild's
WebCore node and refChild's WebCore node (if refChild is non-null). If
we successfully insert the child, fill the result out param with
newChild, ref it, and return S_OK. Otherwise, return E_FAIL.
(DOMNode::removeChild):
Query oldChild for DOMNode. If we fail, return E_FAIL. Call
removeChild(), passing the node's WebCore node. If this fails, return
E_FAIL. Otherwise, fill the result out param with oldChild, ref it, and
return S_OK.
- 8:08 PM Changeset in webkit [55397] by
-
- 7 edits in trunk
2010-03-01 Oliver Hunt <oliver@apple.com>
Reviewed by Gavin Barraclough.
PropertySlot::getValue(ExecState, unsigned) unnecessarily converts index to an Identifier
https://bugs.webkit.org/show_bug.cgi?id=35561
Fix this by defining a separate property getter function for index getters. This allows
us to pass an unsigned number without the conversion to an Identifier. We then update
setCustomIndex to take this new getter type.
- runtime/PropertySlot.h: (JSC::PropertySlot::getValue): (JSC::PropertySlot::setCustom): (JSC::PropertySlot::setCustomIndex):
2010-03-01 Oliver Hunt <oliver@apple.com>
Reviewed by Gavin Barraclough.
PropertySlot::getValue(ExecState, unsigned) unnecessarily converts index to an Identifier
https://bugs.webkit.org/show_bug.cgi?id=35561
Update bindings generation and the few manual indexing getters we have to use
the new PropertySlot API.
- bindings/js/JSDOMWindowCustom.cpp: (WebCore::indexGetter):
- bindings/scripts/CodeGeneratorJS.pm:
- bridge/runtime_array.cpp: (JSC::RuntimeArray::indexGetter):
- bridge/runtime_array.h:
- 6:24 PM Changeset in webkit [55396] by
-
- 1 edit3 adds in trunk/LayoutTests
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=26520
Accessing a DOM node from a parent window in a child iframe moves the prototype to the child
iframe and resets it in the parent window
Adding a test for a bug that no longer occurs in ToT.
- fast/dom/cross-frame-node-prototype-expected.txt: Added.
- fast/dom/cross-frame-node-prototype.html: Added.
- fast/dom/resources/cross-frame-node-prototype-iframe.html: Added.
- 5:58 PM Changeset in webkit [55395] by
-
- 2 edits in trunk/WebKitTools
Fixing broken DRT on Leopard/Tiger. Second try.
AX: changes to WAI-ARIA grid aren't perceived correctly by VoiceOver
https://bugs.webkit.org/show_bug.cgi?id=35514
- DumpRenderTree/mac/AccessibilityUIElementMac.mm:
- 5:50 PM Changeset in webkit [55394] by
-
- 2 edits in trunk/WebKitTools
Fixing broken DRT on Leopard/Tiger.
AX: changes to WAI-ARIA grid aren't perceived correctly by VoiceOver
https://bugs.webkit.org/show_bug.cgi?id=35514
- DumpRenderTree/mac/AccessibilityUIElementMac.mm:
- 5:40 PM Changeset in webkit [55393] by
-
- 3 edits in trunk/LayoutTests
2010-03-01 Gustavo Noronha Silva <Gustavo Noronha Silva>
Rebaseline the two editing tests we stopped skipping - we failed
to take the new caret position result into account while
unskipping these.
- platform/gtk/editing/selection/5109817-expected.txt:
- platform/gtk/editing/selection/5354455-2-expected.txt:
- 5:35 PM Changeset in webkit [55392] by
-
- 4 edits in trunk
WebKitTools
2010-03-01 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Reviewed by Eric Seidel.
[GTK] plugins/setProperty.html fails on 64bit Release
https://bugs.webkit.org/show_bug.cgi?id=35425
Check invoke's return code before releasing the variant, since
there's a chance it won't be properly initialized, leading to
memory corruption, in some cases.
- DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: (testCallback): (testEnumerate): (testDocumentOpen): (testWindowOpen): (handleCallback):
LayoutTests
2010-03-01 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Reviewed by Eric Seidel.
[GTK] plugins/setProperty.html fails on 64bit Release
https://bugs.webkit.org/show_bug.cgi?id=35425
Unskip the tests that failed as a consequence of the memory
corruption.
- platform/gtk/Skipped:
- 5:29 PM Changeset in webkit [55391] by
-
- 2 edits in trunk/WebKitTools
2010-03-01 Dirk Pranke <dpranke@chromium.org>
Reviewed by nobody. Build bustage :(
Fix stupid typo that I committed even after David Levin pointed
it out to me :(
- Scripts/webkitpy/layout_tests/port/mac.py:
- 5:19 PM Changeset in webkit [55390] by
-
- 13 edits2 adds in trunk
AX: changes to WAI-ARIA grid aren't perceived correctly by VoiceOver
https://bugs.webkit.org/show_bug.cgi?id=35514
Reviewed by Darin Adler.
WebCore:
When a table's DOM is changed and an AX Table is not asked first for its children,
it would return wrong information. A table needs to make sure children are up to date in
all methods that can be called from the outside.
Test: platform/mac/accessibility/stale-table-rows.html
- accessibility/AccessibilityARIAGrid.cpp:
(WebCore::AccessibilityARIAGrid::cellForColumnAndRow):
- accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::clearChildren):
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::clearChildren):
(WebCore::AccessibilityRenderObject::updateChildrenIfNecessary):
(WebCore::AccessibilityRenderObject::children):
- accessibility/AccessibilityRenderObject.h:
(WebCore::AccessibilityRenderObject::needsToUpdateChildren):
(WebCore::AccessibilityRenderObject::setNeedsToUpdateChildren):
- accessibility/AccessibilityTable.cpp:
(WebCore::AccessibilityTable::clearChildren):
(WebCore::AccessibilityTable::columns):
(WebCore::AccessibilityTable::rows):
(WebCore::AccessibilityTable::rowHeaders):
(WebCore::AccessibilityTable::columnHeaders):
(WebCore::AccessibilityTable::cells):
(WebCore::AccessibilityTable::columnCount):
(WebCore::AccessibilityTable::rowCount):
(WebCore::AccessibilityTable::cellForColumnAndRow):
WebKitTools:
Add rowCount, columnCount for tables.
- DumpRenderTree/AccessibilityUIElement.cpp:
(rowCountCallback):
(columnCountCallback):
(AccessibilityUIElement::getJSClass):
- DumpRenderTree/AccessibilityUIElement.h:
- DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
(AccessibilityUIElement::rowCount):
(AccessibilityUIElement::columnCount):
- DumpRenderTree/mac/AccessibilityUIElementMac.mm:
(AccessibilityUIElement::rowCount):
(AccessibilityUIElement::columnCount):
- DumpRenderTree/win/AccessibilityUIElementWin.cpp:
(AccessibilityUIElement::rowCount):
(AccessibilityUIElement::columnCount):
LayoutTests:
- platform/mac/accessibility/stale-table-rows-expected.txt: Added.
- platform/mac/accessibility/stale-table-rows.html: Added.
- 5:12 PM Changeset in webkit [55389] by
-
- 4 edits in trunk
2010-03-01 José Millán Soto <jmillan@igalia.com>
Reviewed by Gustavo Noronha Silva.
[GTK] Right click does not activate text entry
https://bugs.webkit.org/show_bug.cgi?id=29177
Stop skipping some tests which where failing because of right click
not being correct handled.
- platform/gtk/Skipped:
2010-03-01 José Millán Soto <jmillan@igalia.com>
Reviewed by Gustavo Noronha Silva.
[GTK] Right click does not activate text entry
https://bugs.webkit.org/show_bug.cgi?id=29177
Makes the frame handle the mouse click event before sending the
context menu event.
- webkit/webkitwebview.cpp: (PopupMenuPositionFunc): Function created to make the popup menu appear in the correct position, especially when invoked from the keyboard. (webkit_web_view_forward_context_menu_event): Mouse click event is sent to frame before creating context menu, PopupMenuPositionFunc used to determine the position where the menu should appear. (webkit_web_view_popup_menu_handler): Improved focused node position detection. Event button set to right button.
- 5:07 PM Changeset in webkit [55388] by
-
- 3 edits in trunk/WebKitTools
2010-03-01 Dirk Pranke <dpranke@chromium.org>
Reviewed by Eric Seidel.
Work around a bug in Python's subprocess.Popen() that keeps us from
cleaning up DumpRenderTree / test_shell properly when we finish the
tests in new-run-webkit-tests.
- Scripts/webkitpy/layout_tests/port/chromium.py:
- Scripts/webkitpy/layout_tests/port/mac.py:
- 4:56 PM Changeset in webkit [55387] by
-
- 26 edits1 add in trunk
2010-03-01 Jakob Petsovits <jpetsovits@rim.com>
Reviewed by Adam Barth.
Convert the zoom mode (page vs. text-only) into a proper enum.
https://bugs.webkit.org/show_bug.cgi?id=35347
- GNUmakefile.am:
- WebCore.base.exp: Substituted symbols ZN7WebCore5Frame13setZoomFactorEfNS_8ZoomModeE and ZN7WebCore8Settings11setZoomModeENS_8ZoomModeE for ZN7WebCore5Frame13setZoomFactorEfb and ZN7WebCore8Settings16setZoomsTextOnlyEb, respectively.
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- page/Frame.cpp: (WebCore::Frame::zoomMode): (WebCore::Frame::shouldApplyTextZoom): (WebCore::Frame::shouldApplyPageZoom): (WebCore::Frame::setZoomFactor):
- page/Frame.h:
- page/Settings.cpp: (WebCore::Settings::Settings): (WebCore::Settings::setZoomMode):
- page/Settings.h: (WebCore::Settings::zoomMode):
- page/ZoomMode.h: Added. (WebCore::):
- svg/SVGSVGElement.cpp: (WebCore::SVGSVGElement::setCurrentScale):
2010-03-01 Jakob Petsovits <jpetsovits@rim.com>
Reviewed by Adam Barth.
Adapt to the new ZoomMode enum.
https://bugs.webkit.org/show_bug.cgi?id=35347
- src/WebViewImpl.cpp: (WebKit::WebViewImpl::setZoomLevel):
2010-03-01 Jakob Petsovits <jpetsovits@rim.com>
Reviewed by Adam Barth.
Adapt to the new ZoomMode enum.
https://bugs.webkit.org/show_bug.cgi?id=35347
- webkit/webkitwebview.cpp: (DNDContentsRequest::webkit_web_view_apply_zoom_level):
2010-03-01 Jakob Petsovits <jpetsovits@rim.com>
Reviewed by Adam Barth.
Adapt to the new ZoomMode enum.
https://bugs.webkit.org/show_bug.cgi?id=35347
- WebView/WebView.mm: (-[WebView _preferencesChangedNotification:]): (-[WebView _setZoomMultiplier:isTextOnly:]): (-[WebView _realZoomMultiplierIsTextOnly]):
2010-03-01 Jakob Petsovits <jpetsovits@rim.com>
Reviewed by Adam Barth.
Adapt to the new ZoomMode enum.
https://bugs.webkit.org/show_bug.cgi?id=35347
- Api/qwebframe.cpp: (QWebFrame::setTextSizeMultiplier): (QWebFrame::setZoomFactor):
- Api/qwebsettings.cpp: (QWebSettingsPrivate::apply):
2010-03-01 Jakob Petsovits <jpetsovits@rim.com>
Reviewed by Adam Barth.
Adapt to the new ZoomMode enum.
https://bugs.webkit.org/show_bug.cgi?id=35347
- WebFrame.cpp: (WebFrame::setTextSizeMultiplier):
- WebView.cpp: (WebView::setZoomMultiplier): (WebView::zoomMultiplier): (WebView::canMakeTextLarger): (WebView::makeTextLarger): (WebView::canMakeTextSmaller): (WebView::makeTextSmaller): (WebView::notifyPreferencesChanged):
2010-03-01 Jakob Petsovits <jpetsovits@rim.com>
Reviewed by Adam Barth.
Adapt to the new ZoomMode enum.
https://bugs.webkit.org/show_bug.cgi?id=35347
- WebFrame.cpp: (wxWebFrame::IncreaseTextSize): (wxWebFrame::DecreaseTextSize): (wxWebFrame::ResetTextSize):
- 4:22 PM Changeset in webkit [55386] by
-
- 9 edits1 copy5 adds in trunk
2010-03-01 Alex Milowski <alex@milowski.com>
Reviewed by Kenneth Rohde Christiansen.
Added test for basic msubsup support.
- mathml/presentation/subsup.xhtml: Added.
- platform/mac/mathml/presentation/subsup-expected.checksum: Added.
- platform/mac/mathml/presentation/subsup-expected.png: Added.
- platform/mac/mathml/presentation/subsup-expected.txt: Added.
2010-03-01 Alex Milowski <alex@milowski.com>
Reviewed by Kenneth Rohde Christiansen.
Added support for the msubsup element that also handles the msup and msub elements.
Test: mathml/presentation/subsup.xhtml
- WebCore.xcodeproj/project.pbxproj:
- mathml/MathMLInlineContainerElement.cpp: (WebCore::MathMLInlineContainerElement::createRenderer):
- mathml/RenderMathMLSubSup.cpp: Added. (WebCore::RenderMathMLSubSup::RenderMathMLSubSup): (WebCore::RenderMathMLSubSup::addChild): (WebCore::RenderMathMLSubSup::stretchToHeight): (WebCore::RenderMathMLSubSup::nonOperatorHeight): (WebCore::RenderMathMLSubSup::layout): (WebCore::RenderMathMLSubSup::baselinePosition):
- mathml/RenderMathMLSubSup.h: Added. (WebCore::RenderMathMLSubSup::hasBase): (WebCore::RenderMathMLSubSup::):
- 4:18 PM Changeset in webkit [55385] by
-
- 4 edits in trunk/WebKit/win
<rdar://problem/7703368> IWebUIDelegatePrivate::embeddedViewWithArguments
is passed wrong arguments
Reviewed by Adam Roben.
- Interfaces/IWebUIDelegatePrivate.idl:
Update copyright strings. Added a new key for the plug-in source URL.
- Interfaces/WebKit.idl:
Update copyright strings.
- WebCoreSupport/WebFrameLoaderClient.cpp:
(WebFrameLoaderClient::createPlugin):
Pass the URL of the plug-in as the source URL. Pass the document's
base URI for the base URL.
- 4:05 PM Changeset in webkit [55384] by
-
- 2 edits in trunk/WebKitTools
2010-03-01 Arno Renevier <arno@renevier.net>
Reviewed by Xan Lopez.
webkit-build could pass unknown arguments to autogen.sh
https://bugs.webkit.org/show_bug.cgi?id=35454
- Scripts/build-webkit:
- 3:49 PM Changeset in webkit [55383] by
-
- 2 edits in trunk/WebCore
2010-03-01 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: use dejavu sans mono 11px on linux.
- inspector/front-end/inspector.css:
- 3:17 PM Changeset in webkit [55382] by
-
- 2 edits in trunk/WebKitTools
2010-03-01 Dirk Pranke <dpranke@chromium.org>
Rubber-stamped by Dimitri Glazkov.
Fix breakage from r55372.
- Scripts/webkitpy/layout_tests/port/chromium.py:
- 2:51 PM Changeset in webkit [55381] by
-
- 11 edits in trunk
2010-03-01 Thatcher Ulrich <tulrich@google.com>
Reviewed by Darin Fisher.
Fix chromium iframe shims. Add another test case to the
iframes-shims test. After r53637, the plugin widget doesn't get
moved every paint. This used to hide the bug that if an iframe
gets added, the plugin's cutout rectangles don't get updated until
a layout happens.
https://bugs.webkit.org/show_bug.cgi?id=35184
- plugins/iframe-shims.html: test case that adds an iframe shim dynamically
2010-03-01 Thatcher Ulrich <tulrich@google.com>
Reviewed by Darin Fisher.
Fix chromium iframe shims. Add another test case to the
iframes-shims test. After r53637, the plugin widget doesn't get
moved every paint. This used to hide the bug that if an iframe
gets added, the plugin's cutout rectangles don't get updated until
a layout happens.
https://bugs.webkit.org/show_bug.cgi?id=35184
- platform/Widget.h: (WebCore::Widget::widgetPositionsUpdated): new virtual method
widgetPositionsUpdated() to notify widgets when other widgets on
the page have been repositioned.
- rendering/RenderView.cpp: (WebCore::RenderView::updateWidgetPositions): call widgetPositionsUpdated() on the widgets
- rendering/RenderWidget.cpp: (WebCore::RenderWidget::widgetPositionsUpdated): call widgetPositionsUpdated() on the widget
- rendering/RenderWidget.h:
2010-03-01 Thatcher Ulrich <tulrich@google.com>
Reviewed by Darin Fisher.
Fix chromium iframe shims. Add another test case to the
iframes-shims test. After r53637, the plugin widget doesn't get
moved every paint. This used to hide the bug that if an iframe
gets added, the plugin's cutout rectangles don't get updated until
a layout happens.
https://bugs.webkit.org/show_bug.cgi?id=35184
- src/WebPluginContainerImpl.cpp: (WebKit::WebPluginContainerImpl::widgetPositionsUpdated): do reportGeometry() to ensure that
the plugin is aware of the positions of cutouts on the page (for iframe shim behavior).
- src/WebPluginContainerImpl.h:
- 2:27 PM Changeset in webkit [55380] by
-
- 3 edits in trunk/WebKitTools
2010-03-01 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
EWS can hang for five hours when compile output is too big
https://bugs.webkit.org/show_bug.cgi?id=35545
- Scripts/webkitpy/commands/queues.py: Limit uploads to 1MB instead of 5MB. AppEngine seems to not like 5MB uploads. I'm not sure what the limit is. Let's try 1MB for a while and see how it goes.
- Scripts/webkitpy/networktransaction.py: Tune the default parameters to our exponential backoff. I'm not sure why I picked five hours as the retry limit. That seems way too large.
- 2:14 PM Changeset in webkit [55379] by
-
- 5 edits in trunk
Bug 35537 - put_by_id does will incorrectly cache writes where a specific value exists,
where at the point of caching the same value is being written.
Reviewed by Oliver Hunt.
When performing a put_by_id that is replacing a property already present on the object,
there are three interesting cases regarding the state of the specific value:
(1) No specific value set - nothing to do, leave the structure in it's current state,
can cache.
(2) A specific value was set, the new put is not of a specified value (i.e. function),
or is of a different specific value - in these cases we need to perform a despecifying
transition to clear the specific value in the structure, but having done so this is a
normal property so as such we can again cache normally.
(3) A specific value was set, and we are overwriting with the same value - in these cases
leave the structure unchanged, but since a specific value is set we cannot cache this
put (we would need the JIT to dynamically check the value being written matched).
Unfortunately, the current behaviour does not match this. the checks for a specific value
being present & the value matching are combined in such a way that in case (2), above we
will unnecessarily prevent the transition being cached, but in case (3) we will incorrectly
fail to prevent caching.
The bug exposes itself if multiple puts of the same specific value are performed to a
property, and erroneously the put is allowed to be cached by the JIT. Method checks may be
generated caching calls of this structure. Subsequent puts performed from JIT code may
write different values without triggering a despecify transition, and as such cached method
checks will continue to pass, despite the value having changed.
- runtime/JSObject.h:
(JSC::JSObject::putDirectInternal):
LayoutTests:
Add test case.
- fast/js/method-check-expected.txt:
- fast/js/script-tests/method-check.js:
(addOne):
(addOneHundred):
(totalizer.makeCall):
- 2:07 PM Changeset in webkit [55378] by
-
- 2 edits in trunk/WebKit/gtk
2010-03-01 Kalle Vahlman <zuh@iki.fi>
Reviewed by Gustavo Noronha Silva.
Queue a resize when either of the content dimensions change
https://bugs.webkit.org/show_bug.cgi?id=35489
The check for size changes only queued a resize if both of the content
dimensions change, leaving the widget size out-of-sync if eg. only the
width changes.
- WebCoreSupport/ChromeClientGtk.cpp:
- 1:51 PM Changeset in webkit [55377] by
-
- 2 edits in trunk/WebCore
2010-03-01 Fridrich Strba <fridrich.strba@bluewin.ch>
Reviewed by Holger Freyther.
Dist some mathml related files
- GNUmakefile.am:
- 1:20 PM Changeset in webkit [55376] by
-
- 43 edits2 adds in trunk
2010-03-01 Kenneth Russell <kbr@google.com>
Reviewed by Oliver Hunt.
Integer overflow in WebGL arrays
https://bugs.webkit.org/show_bug.cgi?id=35241
Test: fast/canvas/webgl/webgl-array-invalid-ranges.html
- bindings/js/JSWebGLArrayBufferConstructor.cpp: (WebCore::constructCanvasArrayBuffer):
- bindings/js/JSWebGLArrayBufferConstructor.h: (WebCore::construct):
- bindings/js/JSWebGLArrayHelper.h: (WebCore::setWebGLArrayFromArray):
- bindings/js/JSWebGLByteArrayConstructor.cpp: (WebCore::constructCanvasByteArray):
- bindings/js/JSWebGLFloatArrayConstructor.cpp: (WebCore::constructCanvasFloatArray):
- bindings/js/JSWebGLIntArrayConstructor.cpp: (WebCore::constructCanvasIntArray):
- bindings/js/JSWebGLShortArrayConstructor.cpp: (WebCore::constructCanvasShortArray):
- bindings/js/JSWebGLUnsignedByteArrayConstructor.cpp: (WebCore::constructCanvasUnsignedByteArray):
- bindings/js/JSWebGLUnsignedIntArrayConstructor.cpp: (WebCore::constructCanvasUnsignedIntArray):
- bindings/js/JSWebGLUnsignedShortArrayConstructor.cpp: (WebCore::constructCanvasUnsignedShortArray):
- bindings/v8/V8Binding.cpp: (WebCore::toUInt32):
- bindings/v8/V8Binding.h: (WebCore::toUInt32):
- bindings/v8/custom/V8WebGLArrayBufferCustom.cpp: (WebCore::V8WebGLArrayBuffer::constructorCallback):
- bindings/v8/custom/V8WebGLArrayCustom.h: (WebCore::constructWebGLArray): (WebCore::getWebGLArrayElement): (WebCore::setWebGLArrayFromArray): (WebCore::setWebGLArray):
- bindings/v8/custom/V8WebGLByteArrayCustom.cpp: (WebCore::V8WebGLByteArray::constructorCallback):
- bindings/v8/custom/V8WebGLFloatArrayCustom.cpp: (WebCore::V8WebGLFloatArray::constructorCallback):
- bindings/v8/custom/V8WebGLIntArrayCustom.cpp: (WebCore::V8WebGLIntArray::constructorCallback):
- bindings/v8/custom/V8WebGLShortArrayCustom.cpp: (WebCore::V8WebGLShortArray::constructorCallback):
- bindings/v8/custom/V8WebGLUnsignedByteArrayCustom.cpp: (WebCore::V8WebGLUnsignedByteArray::constructorCallback):
- bindings/v8/custom/V8WebGLUnsignedIntArrayCustom.cpp: (WebCore::V8WebGLUnsignedIntArray::constructorCallback):
- bindings/v8/custom/V8WebGLUnsignedShortArrayCustom.cpp: (WebCore::V8WebGLUnsignedShortArray::constructorCallback):
- html/canvas/WebGLArray.cpp: (WebCore::WebGLArray::setImpl):
- html/canvas/WebGLArray.h: (WebCore::WebGLArray::verifySubRange): (WebCore::WebGLArray::clampOffsetAndNumElements):
- html/canvas/WebGLArrayBuffer.cpp: (WebCore::WebGLArrayBuffer::create): (WebCore::WebGLArrayBuffer::WebGLArrayBuffer): (WebCore::WebGLArrayBuffer::tryAllocate):
- html/canvas/WebGLArrayBuffer.h:
- html/canvas/WebGLByteArray.cpp: (WebCore::WebGLByteArray::create): (WebCore::WebGLByteArray::WebGLByteArray): (WebCore::WebGLByteArray::slice):
- html/canvas/WebGLByteArray.h:
- html/canvas/WebGLFloatArray.cpp: (WebCore::WebGLFloatArray::create): (WebCore::WebGLFloatArray::WebGLFloatArray): (WebCore::WebGLFloatArray::slice):
- html/canvas/WebGLFloatArray.h:
- html/canvas/WebGLIntArray.cpp: (WebCore::WebGLIntArray::create): (WebCore::WebGLIntArray::WebGLIntArray): (WebCore::WebGLIntArray::slice):
- html/canvas/WebGLIntArray.h:
- html/canvas/WebGLShortArray.cpp: (WebCore::WebGLShortArray::create): (WebCore::WebGLShortArray::WebGLShortArray): (WebCore::WebGLShortArray::slice):
- html/canvas/WebGLShortArray.h:
- html/canvas/WebGLUnsignedByteArray.cpp: (WebCore::WebGLUnsignedByteArray::create): (WebCore::WebGLUnsignedByteArray::WebGLUnsignedByteArray): (WebCore::WebGLUnsignedByteArray::slice):
- html/canvas/WebGLUnsignedByteArray.h:
- html/canvas/WebGLUnsignedIntArray.cpp: (WebCore::WebGLUnsignedIntArray::create): (WebCore::WebGLUnsignedIntArray::WebGLUnsignedIntArray): (WebCore::WebGLUnsignedIntArray::slice):
- html/canvas/WebGLUnsignedIntArray.h:
- html/canvas/WebGLUnsignedShortArray.cpp: (WebCore::WebGLUnsignedShortArray::create): (WebCore::WebGLUnsignedShortArray::WebGLUnsignedShortArray): (WebCore::WebGLUnsignedShortArray::slice):
- html/canvas/WebGLUnsignedShortArray.h:
2010-03-01 Kenneth Russell <kbr@google.com>
Reviewed by Oliver Hunt.
Integer overflow in WebGL arrays
https://bugs.webkit.org/show_bug.cgi?id=35241
- fast/canvas/webgl/array-unit-tests-expected.txt:
- fast/canvas/webgl/array-unit-tests.html:
- fast/canvas/webgl/webgl-array-invalid-ranges-expected.txt: Added.
- fast/canvas/webgl/webgl-array-invalid-ranges.html: Added.
- 1:10 PM Changeset in webkit [55375] by
-
- 14 edits2 adds in trunk
REGRESSION: Telling a WebView to go to its current WebHistoryItem is broken.
<rdar://problem/7699371> and https://bugs.webkit.org/show_bug.cgi?id=35532
Reviewed by Sam Weinig.
WebCore:
Test: fast/loader/api-test-go-to-current-back-forward-item.html
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::loadItem): If the current item is the same as the target item, don't
consider this to be a same document navigation.
- page/Page.cpp:
(WebCore::Page::goToItem): Hard code the "going to the same item as the current item" relationship
as a precondition for stopping all loaders, as that will be a new document load.
WebKitTools:
- DumpRenderTree/LayoutTestController.cpp:
(apiTestGoToCurrentBackForwardItemCallback):
(LayoutTestController::staticFunctions):
- DumpRenderTree/LayoutTestController.h:
- DumpRenderTree/mac/LayoutTestControllerMac.mm:
(LayoutTestController::apiTestGoToCurrentBackForwardItem):
Stubs for now:
- DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
(LayoutTestController::apiTestGoToCurrentBackForwardItem):
- DumpRenderTree/win/LayoutTestControllerWin.cpp:
(LayoutTestController::apiTestGoToCurrentBackForwardItem):
- DumpRenderTree/wx/LayoutTestControllerWx.cpp:
(LayoutTestController::apiTestGoToCurrentBackForwardItem):
LayoutTests:
- fast/loader/api-test-go-to-current-back-forward-item-expected.txt: Added.
- fast/loader/api-test-go-to-current-back-forward-item.html: Added.
- platform/gtk/Skipped:
- platform/qt/Skipped:
- platform/win/Skipped:
- 1:04 PM Changeset in webkit [55374] by
-
- 2 edits in trunk/WebCore
2010-03-01 Robert Hogan <robert@webkit.org>
Reviewed by nobody, build fix.
Fix --minimal build. Add ENABLE(DATABASE) as compile time condition
for building file GeolocationPositionCache.cpp.
- page/GeolocationPositionCache.cpp:
- 12:41 PM Changeset in webkit [55373] by
-
- 12 edits in trunk/WebKitTools
2010-03-01 Dirk Pranke <dpranke@chromium.org>
Reviewed by David Levin.
General cleanup of error handling in new-run-webkit-tests.
Add Port.check_build() call that is separate from Port.check_sys_deps()
(and add a --nocheck-build flag to skip). This breaks a circular
dependency where you would start the layout test helper before
checking sys deps, but checking sys deps was the thing that told
you if your binaries where there.
Also, made Port.check_sys_deps(), start_helper() and stop_helper()
optional by providing default implementations in the base class
rather than requiring ports to implement the routines regardless
of whether or not they were needed.
Lastly, tweak a bunch of log messages to be cleaner, including
changing messages in thirdparty/autoinstall.py to be silent at
the default log level.
- Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
- Scripts/webkitpy/layout_tests/port/base.py:
- Scripts/webkitpy/layout_tests/port/chromium.py:
- Scripts/webkitpy/layout_tests/port/chromium_linux.py:
- Scripts/webkitpy/layout_tests/port/chromium_mac.py:
- Scripts/webkitpy/layout_tests/port/chromium_win.py:
- Scripts/webkitpy/layout_tests/port/mac.py:
- Scripts/webkitpy/layout_tests/port/passing.py:
- Scripts/webkitpy/layout_tests/port/test.py:
- Scripts/webkitpy/layout_tests/run_webkit_tests.py:
- Scripts/webkitpy/thirdparty/autoinstall.py
- 11:36 AM Changeset in webkit [55372] by
-
- 5 edits in trunk/WebKitTools
2010-03-01 Dirk Pranke <dpranke@chromium.org>
Reviewed by David Levin.
new-chromium-webkit-tests --platform=mac-leopard diffs are backwards
https://bugs.webkit.org/show_bug.cgi?id=35265
Some parts of the code passed arguments as
"actual, expected" and some passed as "expected, actual".
As you might imagine, this lead to great confusion and wrongness.
Standardize on "expected, actual" as that's the order which is
passed to the underlying diff tool.
Based on a patch by Eric Siedel <eric@webkit.org>.
- Scripts/webkitpy/layout_tests/port/base.py:
- Scripts/webkitpy/layout_tests/port/chromium.py:
- Scripts/webkitpy/layout_tests/port/test.py:
- Scripts/webkitpy/layout_tests/test_types/image_diff.py
- 11:01 AM UsingGitWithWebKit edited by
- (diff)
- 9:41 AM Changeset in webkit [55371] by
-
- 6 edits4 adds in trunk/WebCore
2010-03-01 Jakob Petsovits <jpetsovits@rim.com>
Reviewed by Dirk Schulze.
[OpenVG] Implement support for paths
https://bugs.webkit.org/show_bug.cgi?id=34366
Adds an implementation of the Path class -
*almost* complete, but not quite because OpenVG
does not provide access to the points in a VGPath
unless one keeps track of all the points by
themselves, which we decided not to do.
Also hooked up to PainterOpenVG and GraphicsContext.
Further introduced is SharedResourceOpenVG, which is
intended as base class for paths and other OpenVG
resources (images, fonts) that WebKit creates as
long-lived objects. We are at a slight disadvantage
here as WebKit doesn't have the concept of resources
belonging to a specific (hardware graphics) context,
which is the reason why EGLDisplayOpenVG had to
provide a current display singleton; this class is
what actually requires that functionality.
Path::addArcTo() uses code by Yong Li <yoli@rim.com>.
- platform/graphics/Path.cpp:
- platform/graphics/Path.h:
- platform/graphics/openvg/GraphicsContextOpenVG.cpp: (WebCore::GraphicsContext::fillPath): (WebCore::GraphicsContext::strokePath): (WebCore::GraphicsContext::drawPath): (WebCore::GraphicsContext::beginPath): (WebCore::GraphicsContext::addPath):
- platform/graphics/openvg/PainterOpenVG.cpp: (WebCore::PainterOpenVG::PainterOpenVG): (WebCore::PainterOpenVG::~PainterOpenVG): (WebCore::PainterOpenVG::transformPath): (WebCore::PainterOpenVG::beginPath): (WebCore::PainterOpenVG::addPath): (WebCore::PainterOpenVG::currentPath): (WebCore::PainterOpenVG::drawPath):
- platform/graphics/openvg/PainterOpenVG.h:
- platform/graphics/openvg/PathOpenVG.cpp: Added. (WebCore::PlatformPathOpenVG::PlatformPathOpenVG): (WebCore::PlatformPathOpenVG::operator=): (WebCore::PlatformPathOpenVG::~PlatformPathOpenVG): (WebCore::PlatformPathOpenVG::clear): (WebCore::PlatformPathOpenVG::createPath): (WebCore::Path::Path): (WebCore::Path::~Path): (WebCore::Path::operator=): (WebCore::Path::contains): (WebCore::Path::strokeContains): (WebCore::Path::translate): (WebCore::Path::boundingRect): (WebCore::Path::strokeBoundingRect): (WebCore::Path::moveTo): (WebCore::Path::addLineTo): (WebCore::Path::addQuadCurveTo): (WebCore::Path::addBezierCurveTo): (WebCore::Path::addArcTo): (WebCore::Path::closeSubpath): (WebCore::Path::addArc): (WebCore::Path::addRect): (WebCore::Path::addEllipse): (WebCore::Path::clear): (WebCore::Path::isEmpty): (WebCore::Path::hasCurrentPoint): (WebCore::Path::debugString): (WebCore::Path::apply): (WebCore::Path::transform): (WebCore::Path::length): (WebCore::Path::pointAtLength): (WebCore::Path::normalAngleAtLength):
- platform/graphics/openvg/PlatformPathOpenVG.h: Added. (WebCore::PlatformPathOpenVG::vgPath):
- platform/graphics/openvg/SharedResourceOpenVG.cpp: Added. (WebCore::SharedResourceOpenVG::makeSharedContextCurrent): (WebCore::SharedResourceOpenVG::makeCompatibleContextCurrent):
- platform/graphics/openvg/SharedResourceOpenVG.h: Added.
- 8:18 AM Changeset in webkit [55370] by
-
- 2 edits in trunk/WebCore
2010-03-01 Pavel Feldman <pfeldman@chromium.org>
Not reviewed, bring English.lproj/locallizedStrings.js back to binary (UTF) mode.
- English.lproj/localizedStrings.js:
- 7:51 AM Changeset in webkit [55369] by
-
- 7 edits in trunk/WebCore
2010-03-01 Jakob Petsovits <jpetsovits@rim.com>
Reviewed by Nikolas Zimmermann.
[OpenVG] Convert from TransformationMatrix to AffineTransform.
https://bugs.webkit.org/show_bug.cgi?id=35445
Dirk Schulze previously introduced AffineTransform as
replacement for most TransformationMatrix occurrences
in GraphicsContext & Co., but did not update the OpenVG
graphics backend as there's no publicly available way
to build it. This commit now takes care of that.
- platform/graphics/openvg/GraphicsContextOpenVG.cpp: (WebCore::GraphicsContext::getCTM): (WebCore::GraphicsContext::roundToDevicePixels): (WebCore::GraphicsContext::origin): (WebCore::GraphicsContext::concatCTM):
- platform/graphics/openvg/PainterOpenVG.cpp: (WebCore::isNonRotatedAffineTransformation): (WebCore::PlatformPainterState::PlatformPainterState): (WebCore::PlatformPainterState::applyState): (WebCore::PlatformPainterState::applyTransformation): (WebCore::PainterOpenVG::transformation): (WebCore::PainterOpenVG::concatTransformation): (WebCore::PainterOpenVG::setTransformation): (WebCore::PainterOpenVG::scale): (WebCore::PainterOpenVG::rotate): (WebCore::PainterOpenVG::translate): (WebCore::PainterOpenVG::intersectClipRect):
- platform/graphics/openvg/PainterOpenVG.h:
- platform/graphics/openvg/VGUtils.cpp: (WebCore::VGMatrix::VGMatrix): (WebCore::VGMatrix::operator AffineTransform): (WebCore::VGMatrix::operator TransformationMatrix): (WebCore::AffineTransform::operator VGMatrix):
- platform/graphics/openvg/VGUtils.h:
- platform/graphics/transforms/AffineTransform.h:
- 7:34 AM Changeset in webkit [55368] by
-
- 2 edits in trunk/WebCore
[Qt] Fix segfault when drawing NPAPI plugins on Mac
Reviewed by Simon Hausmann.
Don't try to get a contexctRef for a null-pixmap. If the pixmap
size is 0,0 the private pixmap data has not yet been initialized.
- 7:34 AM Changeset in webkit [55367] by
-
- 5 edits in trunk
Fix the Qt build on Mac OS X/Cocoa 64-bit
Add missing implementation file to resolve JSC symbols.
Use the proper event/drawing-model guards instead of global 64-bit
guard for the NPAPI plugin implementation (view and package).
- 6:34 AM QtWebKitTableOfFeatures20 edited by
- (diff)
- 6:06 AM QtWebKitTableOfFeatures20 edited by
- (diff)
- 6:00 AM QtWebKitTableOfFeatures20 edited by
- (diff)
- 5:58 AM QtWebKitTableOfFeatures20 edited by
- (diff)
- 5:48 AM QtWebKitTableOfFeatures20 edited by
- (diff)
- 5:46 AM QtWebKitTableOfFeatures20 edited by
- (diff)
- 5:42 AM QtWebKitTableOfFeatures46 edited by
- (diff)
- 5:41 AM QtWebKitTableOfFeatures20 created by
- 5:41 AM QtWebKitFeatures20 edited by
- (diff)
- 5:40 AM QtWebKitFeatures20 created by
- 5:38 AM QtWebKit edited by
- (diff)
- 4:54 AM Changeset in webkit [55366] by
-
- 1 edit in trunk/WebCore/ChangeLog
Fix ChangeLog entries not showing the reviewer due to the ChangeLogs
having been made manually without the (OOPS!!!) part.
Rubberstamped by Gustavo Noronha
- 2:17 AM Changeset in webkit [55365] by
-
- 2 edits in trunk/LayoutTests
2010-02-27 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: callerScriptName and callerScriptLine should be obfuscated for timeline tests.
https://bugs.webkit.org/show_bug.cgi?id=35478
- ../../LayoutTests/inspector/timeline-test.js:
- 2:12 AM Changeset in webkit [55364] by
-
- 6 edits in trunk
2010-02-27 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: disable breakpoint upon Shift-click.
- inspector/front-end/ConsoleView.js: (WebInspector.ConsoleView.prototype._format):
- inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype._mouseDown): (WebInspector.SourceFrame.prototype._mouseMove):
- inspector/front-end/textViewer.css: Chromium: remove DevTools part that has been upstreamed.
- src/js/DevTools.js:
- 2:07 AM Changeset in webkit [55363] by
-
- 6 edits1 add2 deletes in trunk/WebKitTools
Unreviewed.
Rolling out: http://trac.webkit.org/changeset/55348
https://bugs.webkit.org/show_bug.cgi?id=35163
Rolling out since the changes to autoinstall do not work
with Python 2.4. In particular, ZipFile.extractall() was
added in Python 2.6.
- Scripts/webkitpy/init.py:
- Scripts/webkitpy/bugzilla.py:
- Scripts/webkitpy/init/init.py: Removed.
- Scripts/webkitpy/init/autoinstall.py: Removed.
- Scripts/webkitpy/networktransaction.py:
- Scripts/webkitpy/networktransaction_unittest.py:
- Scripts/webkitpy/statusserver.py:
- Scripts/webkitpy/thirdparty/autoinstall.py: Added.
- 1:44 AM Changeset in webkit [55362] by
-
- 1 edit in trunk/WebKitTools/ChangeLog
Unreviewed.
Fixing up ChangeLog after: http://trac.webkit.org/changeset/55361
Restoring deleted ChangeLog entry, and added new ChangeLog entry
for r55361.
- 1:19 AM Changeset in webkit [55361] by
-
- 5 edits3 deletes in trunk/WebKitTools
Unreviewed. Rolling out r55350: http://trac.webkit.org/changeset/55350
https://bugs.webkit.org/show_bug.cgi?id=33639
Need to roll out because this patch (pep8) depends on the newly rewritten
autoinstall.py (r55348), which is breaking for people with Python 2.4:
https://bugs.webkit.org/show_bug.cgi?id=35163#c21
That also needs to be rolled out and will be rolled out next.
Feb 28, 2010:
- 9:14 PM Changeset in webkit [55360] by
-
- 3 edits in trunk/WebKitTools
Exempted WebKitTools/Scripts/webkitpy/thirdparty from all
style checks except for the whitespace/carriage_return check
and the pep8 tab and trailing white space checks.
Reviewed by Shinichiro Hamaji.
https://bugs.webkit.org/show_bug.cgi?id=35497
- Scripts/webkitpy/style/checker.py:
- Adjusted the _PATH_RULES_SPECIFIER configuration as necessary.
- Added enough pep8 categories to _all_categories() for the unit tests to pass.
- Scripts/webkitpy/style/checker_unittest.py:
- Updated the test_path_rules_specifier() unit test.
- 12:04 PM Changeset in webkit [55359] by
-
- 2 edits in trunk/WebCore
Reviewed by Dan Bernstein.
https://bugs.webkit.org/show_bug.cgi?id=35496
<rdar://problem/7663444> Opening newsweek.com and youtube.com has become very slow in debug builds
- css/CSSStyleSelector.cpp: (WebCore::CSSRuleSet::getIDRules): (WebCore::CSSRuleSet::getClassRules): (WebCore::CSSRuleSet::getTagRules): Removed consistency checks, as they affect performance too much in this case.
- 4:57 AM Changeset in webkit [55358] by
-
- 7 edits2 adds in trunk
[Qt] Support private browsing mode in plugins
Add support for NPNVprivateModeBool property in plugins.
See also: https://developer.mozilla.org/En/Supporting_private_browsing_in_plugins
The NPNVprivateModeBool property is supported as scriptable property privateBrowsingEnabled
in the test WebKit plugin. The Mac platform also supports a cachedPrivateBrowsingEnabled
property implemented in the test plugin. This allows the Layout test plugins/private-browsing-mode.html
to retrieve the previous value of NPNVprivateModeBool in the test plugin. Due to the platform-specific
overhead required to support this bespoke property it is not implemented as part of this patch, instead
a new test, plugins/private-browsing-mode-2.html, is added to ensure that setting and resetting privateBrowsingEnabled works as expected.
