Timeline
Mar 3, 2010:
- 11:18 PM Changeset in webkit [55506] by
-
- 1 edit in trunk/WebKit/win/Interfaces/WebKit.idl
Touch WebKit.idl to force a rebuild of Interfaces
- 10:10 PM Changeset in webkit [55505] by
-
- 9 edits2 adds in trunk/WebCore
2010-03-03 Yuta Kitamura <yutak@chromium.org>
Reviewed by Alexey Proskuryakov.
Add a new class that stores information about Web Socket handshake request.
Instances of this class contain the necessary information to send a Web Socket
handshake request. In the future, this class will provide request information
to the Web Inspector.
WebSocketHandshake needs to provide request information
https://bugs.webkit.org/show_bug.cgi?id=34784
No new tests, since the current tests will suffice (LayoutTests/websocket/*).
- GNUmakefile.am:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- websockets/WebSocketChannel.cpp:
- websockets/WebSocketHandshake.cpp: (WebCore::WebSocketHandshake::clientHandshakeMessage): (WebCore::WebSocketHandshake::clientHandshakeRequest):
- websockets/WebSocketHandshake.h:
- websockets/WebSocketHandshakeRequest.cpp: Added. (WebCore::WebSocketHandshakeRequest::WebSocketHandshakeRequest): (WebCore::WebSocketHandshakeRequest::~WebSocketHandshakeRequest): (WebCore::WebSocketHandshakeRequest::addExtraHeaderField): (WebCore::WebSocketHandshakeRequest::headerFields): (WebCore::WebSocketHandshakeRequest::host):
- websockets/WebSocketHandshakeRequest.h: Added.
- 9:19 PM Changeset in webkit [55504] by
-
- 2 edits in trunk/WebCore
2010-03-03 Laszlo Gombos <Laszlo Gombos>
Reviewed by Kenneth Rohde Christiansen.
Build fix after r55452.
No new tests, this is a build fix.
- page/Settings.cpp: (WebCore::Settings::setDatabasesEnabled):
- 9:17 PM Changeset in webkit [55503] by
-
- 5 edits in trunk/WebKit/win
Add a way to get an iframe's content frame
Reviewed by Jon Honeycutt.
- DOMCoreClasses.cpp:
(DOMElement::createInstance):
Added case for DOMHTMLIFrameElement
- DOMHTMLClasses.cpp:
Adding the few DOMHTMLIFrameElement functions definitions that have
distinct implementations (all others just call parent implementation)
(DOMHTMLIFrameElement::QueryInterface):
(DOMHTMLIFrameElement::contentFrame):
- DOMHTMLClasses.h:
Most of these function declarations have definitions that just call the parent implementation
(DOMHTMLIFrameElement::DOMHTMLIFrameElement):
(DOMHTMLIFrameElement::AddRef):
(DOMHTMLIFrameElement::Release):
(DOMHTMLIFrameElement::throwException):
(DOMHTMLIFrameElement::callWebScriptMethod):
(DOMHTMLIFrameElement::evaluateWebScript):
(DOMHTMLIFrameElement::removeWebScriptKey):
(DOMHTMLIFrameElement::stringRepresentation):
(DOMHTMLIFrameElement::webScriptValueAtIndex):
(DOMHTMLIFrameElement::setWebScriptValueAtIndex):
(DOMHTMLIFrameElement::setException):
(DOMHTMLIFrameElement::nodeName):
(DOMHTMLIFrameElement::nodeValue):
(DOMHTMLIFrameElement::setNodeValue):
(DOMHTMLIFrameElement::nodeType):
(DOMHTMLIFrameElement::parentNode):
(DOMHTMLIFrameElement::childNodes):
(DOMHTMLIFrameElement::firstChild):
(DOMHTMLIFrameElement::lastChild):
(DOMHTMLIFrameElement::previousSibling):
(DOMHTMLIFrameElement::nextSibling):
(DOMHTMLIFrameElement::attributes):
(DOMHTMLIFrameElement::ownerDocument):
(DOMHTMLIFrameElement::insertBefore):
(DOMHTMLIFrameElement::replaceChild):
(DOMHTMLIFrameElement::removeChild):
(DOMHTMLIFrameElement::appendChild):
(DOMHTMLIFrameElement::hasChildNodes):
(DOMHTMLIFrameElement::cloneNode):
(DOMHTMLIFrameElement::normalize):
(DOMHTMLIFrameElement::isSupported):
(DOMHTMLIFrameElement::namespaceURI):
(DOMHTMLIFrameElement::prefix):
(DOMHTMLIFrameElement::setPrefix):
(DOMHTMLIFrameElement::localName):
(DOMHTMLIFrameElement::hasAttributes):
(DOMHTMLIFrameElement::isSameNode):
(DOMHTMLIFrameElement::isEqualNode):
(DOMHTMLIFrameElement::textContent):
(DOMHTMLIFrameElement::setTextContent):
(DOMHTMLIFrameElement::tagName):
(DOMHTMLIFrameElement::getAttribute):
(DOMHTMLIFrameElement::setAttribute):
(DOMHTMLIFrameElement::removeAttribute):
(DOMHTMLIFrameElement::getAttributeNode):
(DOMHTMLIFrameElement::setAttributeNode):
(DOMHTMLIFrameElement::removeAttributeNode):
(DOMHTMLIFrameElement::getElementsByTagName):
(DOMHTMLIFrameElement::getAttributeNS):
(DOMHTMLIFrameElement::setAttributeNS):
(DOMHTMLIFrameElement::removeAttributeNS):
(DOMHTMLIFrameElement::getAttributeNodeNS):
(DOMHTMLIFrameElement::setAttributeNodeNS):
(DOMHTMLIFrameElement::getElementsByTagNameNS):
(DOMHTMLIFrameElement::hasAttribute):
(DOMHTMLIFrameElement::hasAttributeNS):
(DOMHTMLIFrameElement::focus):
(DOMHTMLIFrameElement::blur):
(DOMHTMLIFrameElement::idName):
(DOMHTMLIFrameElement::setIdName):
(DOMHTMLIFrameElement::title):
(DOMHTMLIFrameElement::setTitle):
(DOMHTMLIFrameElement::lang):
(DOMHTMLIFrameElement::setLang):
(DOMHTMLIFrameElement::dir):
(DOMHTMLIFrameElement::setDir):
(DOMHTMLIFrameElement::className):
(DOMHTMLIFrameElement::setClassName):
(DOMHTMLIFrameElement::innerHTML):
(DOMHTMLIFrameElement::setInnerHTML):
(DOMHTMLIFrameElement::innerText):
(DOMHTMLIFrameElement::setInnerText):
- Interfaces/DOMHTML.idl:
Added IDOMHTMLIFrameElement interface
- 9:02 PM Changeset in webkit [55502] by
-
- 3 edits in trunk/JavaScriptCore
2010-03-03 Jedrzej Nowacki <jedrzej.nowacki@nokia.com>
Reviewed by Simon Hausmann.
QScriptValue::isObject fix.
Fix broken internal state evaluation from JSValue to JSNative / JSObject.
New function was introduced which should take care about promoting
JSValue state inside QScriptValuePrivate. It should be used instead of a
direct JSC C API call.
The bug exposed a weakness in autotest suite, as the QScriptValuePrivate
is based on state machine with lazy state evaluation, there is a possibility
that serial sequencial calls to the same public const function could return
different results. The patch fix the issue.
[Qt] Sometimes QScriptValue::isObject returns an incorrect value
https://bugs.webkit.org/show_bug.cgi?id=35387
- qt/api/qscriptvalue_p.h: (QScriptValuePrivate::isBool): (QScriptValuePrivate::isNumber): (QScriptValuePrivate::isNull): (QScriptValuePrivate::isString): (QScriptValuePrivate::isUndefined): (QScriptValuePrivate::isError): (QScriptValuePrivate::isObject): (QScriptValuePrivate::isFunction): (QScriptValuePrivate::call): (QScriptValuePrivate::refineJSValue):
- qt/tests/qscriptvalue/tst_qscriptvalue_generated.cpp: (tst_QScriptValue::initScriptValues): (tst_QScriptValue::isValid_makeData): (tst_QScriptValue::isValid_test): (tst_QScriptValue::isBool_makeData): (tst_QScriptValue::isBool_test): (tst_QScriptValue::isBoolean_makeData): (tst_QScriptValue::isBoolean_test): (tst_QScriptValue::isNumber_makeData): (tst_QScriptValue::isNumber_test): (tst_QScriptValue::isFunction_test): (tst_QScriptValue::isNull_makeData): (tst_QScriptValue::isNull_test): (tst_QScriptValue::isString_makeData): (tst_QScriptValue::isString_test): (tst_QScriptValue::isUndefined_makeData): (tst_QScriptValue::isUndefined_test): (tst_QScriptValue::isObject_makeData): (tst_QScriptValue::isObject_test): (tst_QScriptValue::toString_makeData): (tst_QScriptValue::toString_test): (tst_QScriptValue::toNumber_makeData): (tst_QScriptValue::toNumber_test): (tst_QScriptValue::toBool_makeData): (tst_QScriptValue::toBool_test): (tst_QScriptValue::toBoolean_makeData): (tst_QScriptValue::toBoolean_test): (tst_QScriptValue::toInteger_makeData): (tst_QScriptValue::toInteger_test): (tst_QScriptValue::toInt32_makeData): (tst_QScriptValue::toInt32_test): (tst_QScriptValue::toUInt32_makeData): (tst_QScriptValue::toUInt32_test): (tst_QScriptValue::toUInt16_makeData): (tst_QScriptValue::toUInt16_test):
- 8:45 PM Changeset in webkit [55501] by
-
- 4 edits in trunk
2010-03-03 Diego Gonzalez <diego.gonzalez@openbossa.org>
Reviewed by Kenneth Rohde Christiansen.
Make keyIdentifierForQtKeyCode return the unicode backspace value on Qt PlatformKeyboardEvent
LayoutTests:
fast/events/key-events-in-input-text.html
fast/events/special-key-events-in-input-text.html
[Qt] Return the unicode backspace value in keyIdentifierForQtKeyCode on Qt PlatformKeyboardEvent
https://bugs.webkit.org/show_bug.cgi?id=35694
- platform/qt/Skipped:
2010-03-03 Diego Gonzalez <diego.gonzalez@openbossa.org>
Reviewed by Kenneth Rohde Christiansen.
Make keyIdentifierForQtKeyCode return the unicode backspace value on Qt PlatformKeyboardEvent
LayoutTests:
fast/events/key-events-in-input-text.html
fast/events/special-key-events-in-input-text.html
[Qt] Return the unicode backspace value in keyIdentifierForQtKeyCode on Qt PlatformKeyboardEvent
https://bugs.webkit.org/show_bug.cgi?id=35694
- platform/qt/PlatformKeyboardEventQt.cpp: (WebCore::keyIdentifierForQtKeyCode):
- 7:57 PM Changeset in webkit [55500] by
-
- 6 edits2 adds in trunk/JavaScriptCore
2010-03-03 Chao-ying Fu <fu@mips.com>
Reviewed by Gavin Barraclough.
MIPS JIT Supports
https://bugs.webkit.org/show_bug.cgi?id=30144
The following changes enable MIPS YARR and YARR_JIT.
- assembler/AbstractMacroAssembler.h: (JSC::AbstractMacroAssembler::Imm32::Imm32):
- assembler/MIPSAssembler.h: Added. (JSC::MIPSRegisters::): (JSC::MIPSAssembler::MIPSAssembler): (JSC::MIPSAssembler::): (JSC::MIPSAssembler::JmpSrc::JmpSrc): (JSC::MIPSAssembler::JmpDst::JmpDst): (JSC::MIPSAssembler::JmpDst::isUsed): (JSC::MIPSAssembler::JmpDst::used): (JSC::MIPSAssembler::emitInst): (JSC::MIPSAssembler::nop): (JSC::MIPSAssembler::loadDelayNop): (JSC::MIPSAssembler::copDelayNop): (JSC::MIPSAssembler::move): (JSC::MIPSAssembler::li): (JSC::MIPSAssembler::lui): (JSC::MIPSAssembler::addiu): (JSC::MIPSAssembler::addu): (JSC::MIPSAssembler::subu): (JSC::MIPSAssembler::mult): (JSC::MIPSAssembler::mfhi): (JSC::MIPSAssembler::mflo): (JSC::MIPSAssembler::mul): (JSC::MIPSAssembler::andInsn): (JSC::MIPSAssembler::andi): (JSC::MIPSAssembler::nor): (JSC::MIPSAssembler::orInsn): (JSC::MIPSAssembler::ori): (JSC::MIPSAssembler::xorInsn): (JSC::MIPSAssembler::xori): (JSC::MIPSAssembler::slt): (JSC::MIPSAssembler::sltu): (JSC::MIPSAssembler::sltiu): (JSC::MIPSAssembler::sll): (JSC::MIPSAssembler::sllv): (JSC::MIPSAssembler::sra): (JSC::MIPSAssembler::srav): (JSC::MIPSAssembler::lw): (JSC::MIPSAssembler::lwl): (JSC::MIPSAssembler::lwr): (JSC::MIPSAssembler::lhu): (JSC::MIPSAssembler::sw): (JSC::MIPSAssembler::jr): (JSC::MIPSAssembler::jalr): (JSC::MIPSAssembler::jal): (JSC::MIPSAssembler::bkpt): (JSC::MIPSAssembler::bgez): (JSC::MIPSAssembler::bltz): (JSC::MIPSAssembler::beq): (JSC::MIPSAssembler::bne): (JSC::MIPSAssembler::bc1t): (JSC::MIPSAssembler::bc1f): (JSC::MIPSAssembler::newJmpSrc): (JSC::MIPSAssembler::appendJump): (JSC::MIPSAssembler::addd): (JSC::MIPSAssembler::subd): (JSC::MIPSAssembler::muld): (JSC::MIPSAssembler::lwc1): (JSC::MIPSAssembler::ldc1): (JSC::MIPSAssembler::swc1): (JSC::MIPSAssembler::sdc1): (JSC::MIPSAssembler::mtc1): (JSC::MIPSAssembler::mfc1): (JSC::MIPSAssembler::truncwd): (JSC::MIPSAssembler::cvtdw): (JSC::MIPSAssembler::ceqd): (JSC::MIPSAssembler::cngtd): (JSC::MIPSAssembler::cnged): (JSC::MIPSAssembler::cltd): (JSC::MIPSAssembler::cled): (JSC::MIPSAssembler::cueqd): (JSC::MIPSAssembler::coled): (JSC::MIPSAssembler::coltd): (JSC::MIPSAssembler::culed): (JSC::MIPSAssembler::cultd): (JSC::MIPSAssembler::label): (JSC::MIPSAssembler::align): (JSC::MIPSAssembler::getRelocatedAddress): (JSC::MIPSAssembler::getDifferenceBetweenLabels): (JSC::MIPSAssembler::size): (JSC::MIPSAssembler::executableCopy): (JSC::MIPSAssembler::getCallReturnOffset): (JSC::MIPSAssembler::linkJump): (JSC::MIPSAssembler::linkCall): (JSC::MIPSAssembler::linkPointer): (JSC::MIPSAssembler::relinkJump): (JSC::MIPSAssembler::relinkCall): (JSC::MIPSAssembler::repatchInt32): (JSC::MIPSAssembler::repatchPointer): (JSC::MIPSAssembler::repatchLoadPtrToLEA): (JSC::MIPSAssembler::relocateJumps): (JSC::MIPSAssembler::linkWithOffset): (JSC::MIPSAssembler::linkCallInternal):
- assembler/MacroAssembler.h:
- assembler/MacroAssemblerMIPS.h: Added. (JSC::MacroAssemblerMIPS::MacroAssemblerMIPS): (JSC::MacroAssemblerMIPS::): (JSC::MacroAssemblerMIPS::add32): (JSC::MacroAssemblerMIPS::and32): (JSC::MacroAssemblerMIPS::lshift32): (JSC::MacroAssemblerMIPS::mul32): (JSC::MacroAssemblerMIPS::not32): (JSC::MacroAssemblerMIPS::or32): (JSC::MacroAssemblerMIPS::rshift32): (JSC::MacroAssemblerMIPS::sub32): (JSC::MacroAssemblerMIPS::xor32): (JSC::MacroAssemblerMIPS::load32): (JSC::MacroAssemblerMIPS::load32WithUnalignedHalfWords): (JSC::MacroAssemblerMIPS::load32WithAddressOffsetPatch): (JSC::MacroAssemblerMIPS::loadPtrWithPatchToLEA): (JSC::MacroAssemblerMIPS::loadPtrWithAddressOffsetPatch): (JSC::MacroAssemblerMIPS::load16): (JSC::MacroAssemblerMIPS::store32WithAddressOffsetPatch): (JSC::MacroAssemblerMIPS::store32): (JSC::MacroAssemblerMIPS::supportsFloatingPoint): (JSC::MacroAssemblerMIPS::supportsFloatingPointTruncate): (JSC::MacroAssemblerMIPS::pop): (JSC::MacroAssemblerMIPS::push): (JSC::MacroAssemblerMIPS::move): (JSC::MacroAssemblerMIPS::swap): (JSC::MacroAssemblerMIPS::signExtend32ToPtr): (JSC::MacroAssemblerMIPS::zeroExtend32ToPtr): (JSC::MacroAssemblerMIPS::branch32): (JSC::MacroAssemblerMIPS::branch32WithUnalignedHalfWords): (JSC::MacroAssemblerMIPS::branch16): (JSC::MacroAssemblerMIPS::branchTest32): (JSC::MacroAssemblerMIPS::jump): (JSC::MacroAssemblerMIPS::branchAdd32): (JSC::MacroAssemblerMIPS::branchMul32): (JSC::MacroAssemblerMIPS::branchSub32): (JSC::MacroAssemblerMIPS::breakpoint): (JSC::MacroAssemblerMIPS::nearCall): (JSC::MacroAssemblerMIPS::call): (JSC::MacroAssemblerMIPS::ret): (JSC::MacroAssemblerMIPS::set32): (JSC::MacroAssemblerMIPS::setTest32): (JSC::MacroAssemblerMIPS::moveWithPatch): (JSC::MacroAssemblerMIPS::branchPtrWithPatch): (JSC::MacroAssemblerMIPS::storePtrWithPatch): (JSC::MacroAssemblerMIPS::tailRecursiveCall): (JSC::MacroAssemblerMIPS::makeTailRecursiveCall): (JSC::MacroAssemblerMIPS::loadDouble): (JSC::MacroAssemblerMIPS::storeDouble): (JSC::MacroAssemblerMIPS::addDouble): (JSC::MacroAssemblerMIPS::subDouble): (JSC::MacroAssemblerMIPS::mulDouble): (JSC::MacroAssemblerMIPS::convertInt32ToDouble): (JSC::MacroAssemblerMIPS::insertRelaxationWords): (JSC::MacroAssemblerMIPS::branchTrue): (JSC::MacroAssemblerMIPS::branchFalse): (JSC::MacroAssemblerMIPS::branchEqual): (JSC::MacroAssemblerMIPS::branchNotEqual): (JSC::MacroAssemblerMIPS::branchDouble): (JSC::MacroAssemblerMIPS::branchTruncateDoubleToInt32): (JSC::MacroAssemblerMIPS::linkCall): (JSC::MacroAssemblerMIPS::repatchCall):
- jit/ExecutableAllocator.h: (JSC::ExecutableAllocator::cacheFlush):
- wtf/Platform.h:
- yarr/RegexJIT.cpp: (JSC::Yarr::RegexGenerator::generateEnter): (JSC::Yarr::RegexGenerator::generateReturn):
- 7:31 PM Changeset in webkit [55499] by
-
- 3 edits2 adds in trunk
2010-03-03 Chad Faragher <wyck@chromium.org>
Reviewed by Darin Adler.
Changed the double-click framework code to pass adjusted page
coordinates for zoomed pages. Added a new test to expose
mistreatment of mouse click coordinates during a double-click.
- fast/events/zoom-dblclick-expected.txt: Added.
- fast/events/zoom-dblclick.html: Added.
2010-03-03 Chad Faragher <wyck@chromium.org>
Reviewed by Darin Adler.
Changed the double-click framework code to pass adjusted page
coordinates for zoomed pages. Added a new test to expose
mistreatment of mouse click coordinates during a double-click.
Test: fast/events/zoom-dblclick.html
- dom/Node.cpp: (WebCore::Node::dispatchMouseEvent):
- 7:13 PM Changeset in webkit [55498] by
-
- 2 edits in trunk/WebKitTools
2010-03-03 Jesus Sanchez-Palencia <jesus.palencia@openbossa.org>
Reviewed by Simon Hausmann.
Add a missing 'm_' to class variables names.
[Qt] QtLauncher is not respecting class variable names
https://bugs.webkit.org/show_bug.cgi?id=35542
- QtLauncher/main.cpp: (LauncherWindow::LauncherWindow): (LauncherWindow::init): (LauncherWindow::sendTouchEvent): (LauncherWindow::eventFilter): (LauncherWindow::zoomIn): (LauncherWindow::zoomOut): (LauncherWindow::resetZoom): (LauncherWindow::setEditable): (LauncherWindow::setTouchMocking): (LauncherWindow::initializeView): (LauncherWindow::createChrome):
- 7:00 PM Changeset in webkit [55497] by
-
- 1 edit in tags/Safari-533.1.1/JavaScriptCore/ChangeLog
Remove extraneous ChangeLog entries.
- 6:56 PM Changeset in webkit [55496] by
-
- 4 edits in tags/Safari-533.1.1/JavaScriptCore
Merged r55495.
- 6:52 PM Changeset in webkit [55495] by
-
- 3 edits in trunk/JavaScriptCore
Windows build fix.
- JavaScriptCore.vcproj/jsc/jsc.vcproj:
- JavaScriptCore.vcproj/jsc/jscCommon.vsprops:
- 6:42 PM Changeset in webkit [55494] by
-
- 3 edits in tags/Safari-533.1.1/JavaScriptCore
Merge r55492.
- 6:35 PM Changeset in webkit [55493] by
-
- 1 copy in tags/Safari-533.1.1
New tag.
- 6:33 PM Changeset in webkit [55492] by
-
- 2 edits in trunk/JavaScriptCore
Windows build fix.
- JavaScriptCore.vcproj/jsc/jsc.vcproj:
- 5:23 PM Changeset in webkit [55491] by
-
- 2 edits in trunk/WebCore
No review, rolling out r55474.
The patch broke fast/frames/sandboxed-iframe-storage.html
Last one (I hope).
- WebCore.xcodeproj/project.pbxproj:
- 5:20 PM Changeset in webkit [55490] by
-
- 3 edits in trunk/LayoutTests
Making database-lock-after-reload.html a bit more robust and
cleaning up some style issues.
Reviewed by Dimitri Glazkov.
- storage/database-lock-after-reload.html:
- storage/resources/database-lock-after-reload-2.html:
- 5:14 PM Changeset in webkit [55489] by
-
- 2 edits in trunk/WebKitTools
Rubber-stamped by Mark Rowe.
Exclude leaks in Java that build bot complains about.
- Scripts/run-webkit-tests:
- 5:09 PM Changeset in webkit [55488] by
-
- 2 edits9 deletes in trunk
No review, rolling out r55474.
The patch broke fast/frames/sandboxed-iframe-storage.html
Unfortunately, (the webkit-patch rollout and) I missed these in r55485.
WebCore:
- bindings/js/JSDatabaseCallback.cpp: Removed.
- bindings/js/JSDatabaseCallback.h: Removed.
- bindings/v8/custom/V8DatabaseCallback.cpp: Removed.
- bindings/v8/custom/V8DatabaseCallback.h: Removed.
- storage/DatabaseCallback.h: Removed.
LayoutTests:
- storage/open-database-creation-callback-expected.txt: Removed.
- storage/open-database-creation-callback-isolated-world-expected.txt: Removed.
- storage/open-database-creation-callback-isolated-world.html: Removed.
- storage/open-database-creation-callback.html: Removed.
- 5:01 PM Changeset in webkit [55487] by
-
- 2 edits in trunk/WebCore
Fix a bug that could lead to a crash. Some parts of
SQLTransaction::checkAndHandleClosedDatabase() should only be run
when that method is invoked on the DB thread.
Reviewed by Dimitri Glazkov.
We cannot test this fix with a test, because the crash happens
only when all of the following conditions are met:
- A database is closing.
- A transaction on that database is in progress.
- The transaction is in a state where a statement/transaction
success/error callback needs to be invoked (so there's a task for
this transaction pending on the main thread).
- The DB thread finished processing all its tasks and called
SQLTransactionCoordinator::shutdown() before the main thread go to
that task.
The closest thing we have to a test is running
LayoutTests/storage/database-lock-after-reload.html 1000 times in
a row. Without the patch, the probability of a crash happening in
one of the runs is very high. With the patch, the test should
reliably run 1000 times in a row without a single crash.
https://bugs.webkit.org/show_bug.cgi?id=35624
- storage/SQLTransaction.cpp:
(WebCore::SQLTransaction::checkAndHandleClosedDatabase):
- 4:47 PM Changeset in webkit [55486] by
-
- 3 edits in trunk/WebCore
2010-03-03 Darin Fisher <darin@chromium.org>
Reviewed by Mark Rowe.
Page should not care about Chromium plug-in implementation details
https://bugs.webkit.org/show_bug.cgi?id=35623
- WebCore.gypi: Compile PluginViewNone.cpp
- page/Page.cpp: (WebCore::Page::privateBrowsingStateChanged): Remove conditional compilation for PLATFORM(CHROMIUM).
- 4:38 PM Changeset in webkit [55485] by
-
- 17 edits in trunk/WebCore
2010-03-03 David Levin <levin@chromium.org>
No review, rolling out r55474.
http://trac.webkit.org/changeset/55480
The patch broke fast/frames/sandboxed-iframe-storage.html
- Android.jscbindings.mk:
- Android.v8bindings.mk:
- GNUmakefile.am:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- bindings/js/JSDOMWindowCustom.cpp:
- bindings/v8/custom/V8DOMWindowCustom.cpp:
- dom/Document.cpp: (WebCore::Document::postTask):
- page/DOMWindow.cpp: (WebCore::DOMWindow::openDatabase):
- page/DOMWindow.h:
- page/DOMWindow.idl:
- storage/Database.cpp: (WebCore::Database::openDatabase): (WebCore::Database::Database): (WebCore::Database::performOpenAndVerify):
- storage/Database.h:
- workers/WorkerContext.cpp: (WebCore::WorkerContext::openDatabase):
- workers/WorkerContext.h:
- 4:36 PM Changeset in webkit [55484] by
-
- 3 edits in trunk/WebCore
2010-03-03 David Levin <levin@chromium.org>
No review, rolling out r55480.
http://trac.webkit.org/changeset/55480
The patch broke fast/frames/sandboxed-iframe-storage.html
- storage/Database.cpp:
- storage/Database.h:
- 4:22 PM Changeset in webkit [55483] by
-
- 5 edits in trunk
Add virtual memory tags for TCMalloc and WebCore's purgeable buffers.
Reviewed by Geoff Garen.
- wtf/TCSystemAlloc.cpp:
(TryMmap): Use the VM tag.
- wtf/VMTags.h: Make use of VM_MEMORY_TCMALLOC and VM_MEMORY_WEBCORE_PURGEABLE_BUFFERS.
WebCore:
- platform/mac/PurgeableBufferMac.cpp:
(WebCore::PurgeableBuffer::create): Use the VM tag.
- 4:20 PM Changeset in webkit [55482] by
-
- 3 edits1 delete in trunk/LayoutTests
Not reviewed.
Try better to fix Java tests on Tiger bot.
- platform/mac-tiger/Skipped:
- platform/mac-tiger/java/lc3/JavaArray/ToString-001-expected.txt: Removed. This test gets different resultson each run when it fails, so it needs to be disabled on Tiger.
- platform/mac-tiger/java/lc3/JavaObject/JavaObjectToString-001-expected.txt: Added a newline I didn't get when copying actual results from buildbot.
- 4:05 PM Changeset in webkit [55481] by
-
- 3 edits in trunk/WebKitTools
Additional change to separate Accelerated Compositing test from 3D Rendering test
https://bugs.webkit.org/show_bug.cgi?id=35610
- 3:03 PM Changeset in webkit [55480] by
-
- 3 edits in trunk/WebCore
Move #include "DatabaseCallback.h" from Database.h to
Database.cpp.
Reviewed by nobody, build fix.
- storage/Database.cpp:
- storage/Database.h:
- 2:55 PM Changeset in webkit [55479] by
-
- 2 edits in trunk/LayoutTests
[Qt] Skip new test introduced in r55474, because of
missing layoutTestController.evaluateScriptInIsolatedWorld()
- platform/qt/Skipped: storage/open-database-creation-callback-isolated-world.html skipped.
- 2:24 PM Changeset in webkit [55478] by
-
- 2 edits in trunk/WebCore
Fixed Mac build.
- WebCore.xcodeproj/project.pbxproj: Marked a couple of headers "private" so they can
be used in the WebKit project.
- 2:22 PM Changeset in webkit [55477] by
-
- 188 edits1 add in trunk/LayoutTests
Rubber-stamped by Dan Bernstein.
https://bugs.webkit.org/show_bug.cgi?id=35700
Some of the newly added Java tests fail randomly on buildbot
- fast/js/resources/js-test-post-async.js: Added a version that calls notifyDone(). I first wanted to add a notifyDone() call to js-test-post.js, but it turns out that multiple tests dump results after "TEST COMPLETE", and we need to get bots back to green fast.
- java/lc3: (Many files). Don't load two scripts dynamically, WebKit has issues with order of execution in this case.
- 2:06 PM Changeset in webkit [55476] by
-
- 2 edits in trunk/JavaScriptCore
Rubber stamped by Adam Roben.
Fix bogus xcopy that was polluting source tree at build time.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreCommon.vsprops:
- 2:05 PM Changeset in webkit [55475] by
-
- 2 edits in trunk/WebCore
Reviewed by Adele Peterson.
https://bugs.webkit.org/show_bug.cgi?id=35044
Crash in XML tokenizer reloading zoom-coords-viewattr-01-b.svg
I'm often getting a crash even when opening the test for the first time in Safari, but it
doesn't seem to crash in DumpRenderTree. Still, I can't think of a stronger way to test for
this condition, so no new regression test.
- dom/XMLTokenizer.cpp: (WebCore::XMLTokenizer::end): Be prepared that parsing remaining input will pause parsing.
- 1:48 PM Changeset in webkit [55474] by
-
- 19 edits9 adds in trunk
WebCore: Adding support for the optional creation callback that could be
passed to openDatabase().
Reviewed by Adam Barth.
Test: storage/open-database-creation-callback.html
https://bugs.webkit.org/show_bug.cgi?id=34726
- Android.jscbindings.mk
- Android.v8bindings.mk
- GNUmakefile.am:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/JSDOMWindowCustom.cpp:
(WebCore::JSDOMWindow::openDatabase):
- bindings/js/JSDatabaseCallback.cpp: Added.
(WebCore::JSDatabaseCallback::JSDatabaseCallback):
(WebCore::JSDatabaseCallback::~JSDatabaseCallback):
(WebCore::JSDatabaseCallback::handleEvent):
- bindings/js/JSDatabaseCallback.h: Added.
(WebCore::JSDatabaseCallback::create):
- bindings/v8/custom/V8DOMWindowCustom.cpp:
(WebCore::V8DOMWindow::openDatabaseCallback):
- bindings/v8/custom/V8DatabaseCallback.cpp: Added.
(WebCore::V8DatabaseCallback::V8DatabaseCallback):
(WebCore::V8DatabaseCallback::~V8DatabaseCallback):
(WebCore::V8DatabaseCallback::handleEvent):
- bindings/v8/custom/V8DatabaseCallback.h: Added.
(WebCore::V8DatabaseCallback::create):
- page/DOMWindow.cpp:
(WebCore::DOMWindow::openDatabase):
- page/DOMWindow.h:
- page/DOMWindow.idl:
- storage/Database.cpp:
(WebCore::DatabaseCreationCallbackTask::create):
(WebCore::DatabaseCreationCallbackTask::performTask):
(WebCore::DatabaseCreationCallbackTask::DatabaseCreationCallbackTask):
(WebCore::Database::openDatabase):
(WebCore::Database::Database):
(WebCore::Database::performOpenAndVerify):
(WebCore::Database::performCreationCallback):
- storage/Database.h:
(WebCore::Database::isNew):
- storage/DatabaseCallback.h: Added.
(WebCore::DatabaseCallback::~DatabaseCallback):
- workers/WorkerContext.cpp:
(WebCore::WorkerContext::openDatabase):
- workers/WorkerContext.h:
LayoutTests: Adding a test to test the creation callback passed to
openDatabase() and another one to make sure it is executed in the
correct world.
Reviewed by Adam Barth.
https://bugs.webkit.org/show_bug.cgi?id=34726
- storage/open-database-creation-callback-expected.txt: Added.
- storage/open-database-creation-callback.html: Added.
- storage/open-database-creation-callback-isolated-world-expected.txt: Added.
- storage/open-database-creation-callback-isolated-world.html: Added.
- 1:33 PM Changeset in webkit [55473] by
-
- 1 edit in trunk/WebKit/win/Interfaces/WebKit.idl
Useless change to kick the Windows build into recompiling the idl files
- 1:25 PM Changeset in webkit [55472] by
-
- 1 edit in trunk/WebKit/win/Interfaces/WebKit.idl
Touch WebKit.idl to force a rebuild
- 12:45 PM Changeset in webkit [55471] by
-
- 1 edit6 adds in trunk/LayoutTests
Not reviewed.
Two newly added Java tests fail on Tiger build bot.
Just land actual results as expected. I don't even know which behavior is more correct.
- platform/mac-tiger/java: Added.
- platform/mac-tiger/java/lc3: Added.
- platform/mac-tiger/java/lc3/JavaArray: Added.
- platform/mac-tiger/java/lc3/JavaArray/ToString-001-expected.txt: Added.
- platform/mac-tiger/java/lc3/JavaObject: Added.
- platform/mac-tiger/java/lc3/JavaObject/JavaObjectToString-001-expected.txt: Added.
- 11:34 AM Changeset in webkit [55470] by
-
- 2 edits in trunk/WebKit/mac
Reviewed by Timothy Hatcher.
https://bugs.webkit.org/show_bug.cgi?id=35692
<rdar://problem/7703622> Crash when calling abort() on an XHR while in a windowless WebView
- Panels/WebAuthenticationPanel.m: (-[WebAuthenticationPanel runAsModalDialogWithChallenge:]): Retain the challenge, just like it's done for sheet.
- 11:15 AM Changeset in webkit [55469] by
-
- 2 edits696 adds in trunk/LayoutTests
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=35617
Import Mozilla LiveConnect 3 test suite
- java/lc3/sources: Added (many files). Sources for Mozilla test applet.
- java/jstests.jar: Added in compiled form, since it's unlikely that we'll ever need to modify the above sources.
- java/lc3.java: Added. (lc3): This is a small wrapper around jstests.jar. The latter only adds some classes, but WebKit needs an actual applet to call into Java. (lc3.createQAObject): Instantiate a class defined in jstests.jar by name. (lc3.stringToByteArray): A helper to make a byte array out of string. Tests originally relied on window.java package interface to do this, but it's not available in WebKit. We need more functions like this to work around other uses of window.java, but this is one I wrote for now.
- java/Makefile: Link test applets to Mozilla's jstests.jar. This is not needed for tests other than ones imported here, but it's also harmless, and I don't know how to write good makefiles.
- java/lc3: Added (many files). Tests were heavily reworked to run to completion, but PASS/FAIL results should not be generally relied upon. All html wrappers are identical.
- 11:05 AM Changeset in webkit [55468] by
-
- 3 edits in trunk/LayoutTests
2010-03-03 Eric Carlson <eric.carlson@apple.com>
Unreviewed, build fix.
Update expected results for fast/js/custom-constructors-expected.txt
- 10:51 AM Changeset in webkit [55467] by
-
- 7 edits in trunk
Enable LayoutTests/compositing for Windows when compositing is available
https://bugs.webkit.org/show_bug.cgi?id=35610
- 10:20 AM Changeset in webkit [55466] by
-
- 10 edits in trunk/WebCore
2010-03-03 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: resources panel only shows uncompressed resource size.
https://bugs.webkit.org/show_bug.cgi?id=35403
- English.lproj/localizedStrings.js:
- inspector/InspectorResource.cpp: (WebCore::InspectorResource::updateScriptObject):
- inspector/front-end/AbstractTimelinePanel.js: (WebInspector.AbstractTimelinePanel.prototype.refresh):
- inspector/front-end/AuditRules.js: (WebInspector.AuditRules.GzipRule.prototype.doRun): (WebInspector.AuditRules.GzipRule.prototype._shouldCompress):
- inspector/front-end/ImageView.js: (WebInspector.ImageView):
- inspector/front-end/Resource.js: (WebInspector.Resource.prototype.get resourceSize): (WebInspector.Resource.prototype.set resourceSize): (WebInspector.Resource.prototype.get transferSize): (WebInspector.Resource.CompareBySize): (WebInspector.Resource.CompareByTransferSize):
- inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel.prototype.populateSidebar): (WebInspector.ResourceTimeCalculator.prototype.computeBarGraphLabels): (WebInspector.ResourceTransferSizeCalculator.prototype.computeBarGraphLabels): (WebInspector.ResourceTransferSizeCalculator.prototype.computeBarGraphPercentages): (WebInspector.ResourceTransferSizeCalculator.prototype._value): (WebInspector.ResourceTransferSizeCalculator.prototype._networkBytes): (WebInspector.ResourceSidebarTreeElement.CompareByDescendingTransferSize): (WebInspector.ResourceGraph.prototype.refreshLabelPositions): (WebInspector.ResourceGraph.prototype.refresh):
- inspector/front-end/inspector.css:
- inspector/front-end/inspector.js: (WebInspector.updateResource):
- 9:42 AM Changeset in webkit [55465] by
-
- 2 edits in trunk/WebCore
Build fix.
- dom/ContainerNode.cpp:
(WebCore::ContainerNode::removeChildren):
- 9:24 AM Changeset in webkit [55464] by
-
- 11 edits in trunk
2010-03-03 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: Get rid of synchronous debuggerEnabled, profilerEnabled calls.
- inspector/InspectorBackend.cpp:
- inspector/InspectorBackend.h:
- inspector/InspectorBackend.idl:
- inspector/front-end/BreakpointsSidebarPane.js: (WebInspector.BreakpointsSidebarPane.prototype.addBreakpoint): (WebInspector.BreakpointsSidebarPane.prototype.removeBreakpoint): (WebInspector.BreakpointsSidebarPane.prototype._breakpointEnableChanged):
- inspector/front-end/ProfilesPanel.js: (WebInspector.ProfilesPanel): (WebInspector.ProfilesPanel.prototype.profilerWasEnabled): (WebInspector.ProfilesPanel.prototype.profilerWasDisabled): (WebInspector.ProfilesPanel.prototype._updateInterface): (WebInspector.ProfilesPanel.prototype._enableProfiling): (WebInspector.ProfilesPanel.prototype._toggleProfiling):
- inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel): (WebInspector.ScriptsPanel.prototype.debuggerWasEnabled): (WebInspector.ScriptsPanel.prototype.debuggerWasDisabled): (WebInspector.ScriptsPanel.prototype.reset): (WebInspector.ScriptsPanel.prototype.canShowSourceLine): (WebInspector.ScriptsPanel.prototype._updateDebuggerButtons): (WebInspector.ScriptsPanel.prototype._enableDebugging): (WebInspector.ScriptsPanel.prototype._toggleDebugging):
- 9:19 AM Changeset in webkit [55463] by
-
- 12 edits4 adds4 deletes in trunk
2010-03-03 Eric Carlson <eric.carlson@apple.com>
Reviewed by Adele Peterson.
Replace 'autobuffer' attribute with 'preload' to align with spec revision 4811.
https://bugs.webkit.org/show_bug.cgi?id=35385
rdar://problem/7689602
Tests: media/audio-constructor-preload.html
media/video-dom-preload.html
- html/HTMLAttributeNames.in: Remove autobuffer, add preload
- html/HTMLAudioElement.cpp: (WebCore::HTMLAudioElement::createForJSConstructor): set preload to 'auto' instead of
autobuffer to true.
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::HTMLMediaElement): Initialize m_preload. (WebCore::HTMLMediaElement::parseMappedAttribute): Deal with 'preload' attribute. (WebCore::HTMLMediaElement::loadResource): Call setPreload() on the newly created MediaPlayer,
before calling load() so it can pass the setting through to the media engine.
(WebCore::HTMLMediaElement::preload): New.
(WebCore::HTMLMediaElement::setPreload): Ditto
- html/HTMLMediaElement.h:
- html/HTMLMediaElement.idl:
- platform/graphics/MediaPlayer.cpp: (WebCore::MediaPlayer::MediaPlayer): Initialize m_preload. (WebCore::MediaPlayer::load): Pass m_preload to newly created media engine. (WebCore::MediaPlayer::preload): New, return m_preload. (WebCore::MediaPlayer::setPreload): New, set m_preload.
- platform/graphics/MediaPlayer.h: (WebCore::MediaPlayer::):
- platform/graphics/MediaPlayerPrivate.h: (WebCore::MediaPlayerPrivateInterface::setPreload):
- platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivate::setPreload): Renamed from setAutoplay, fix logic for preload.
- platform/graphics/gtk/MediaPlayerPrivateGStreamer.h:
2010-03-03 Eric Carlson <eric.carlson@apple.com>
Reviewed by Adele Peterson.
Replace 'autobuffer' attribute with 'preload' to align with spec revision 4811.
https://bugs.webkit.org/show_bug.cgi?id=35385
rdar://problem/7689602
- media/audio-constructor-autobuffer-expected.txt: Removed.
- media/audio-constructor-autobuffer.html: Removed.
- media/audio-constructor-preload-expected.txt: Added.
- media/audio-constructor-preload.html: Added.
- media/video-dom-autobuffer-expected.txt: Removed.
- media/video-dom-autobuffer.html: Removed.
- media/video-dom-preload-expected.txt: Added.
- media/video-dom-preload.html: Added.
- 7:21 AM QtWebKitBugs edited by
- (diff)
- 7:02 AM Changeset in webkit [55462] by
-
- 3 edits2 adds in trunk
<rdar://problem/7682756> Assertion failure when replacing the contents of a <select>
Reviewed by Sam Weinig.
WebCore:
Test: fast/dom/remove-children-notification-order.html
- dom/ContainerNode.cpp:
(WebCore::ContainerNode::removeChildren): Changed to call childrenChanged()
before calling removedFromDocument() on each removed child, which matches
the order removeChild() does things, and avoids the assertion. This required
temporarily storing the removed children in a vector.
Also added comments about other discrepancies between this function and
removeChild().
LayoutTests:
- fast/dom/remove-children-notification-order-expected.txt: Added.
- fast/dom/remove-children-notification-order.html: Added.
- 6:48 AM Changeset in webkit [55461] by
-
- 2 edits in trunk/WebCore
2010-03-03 Adam Barth <abarth@webkit.org>
Reviewed by Darin Adler.
Document cookieURL and firstPartyForCookies
https://bugs.webkit.org/show_bug.cgi?id=35613
Some folks asked what the cookieURL and the firstPartyForCookies were
on IRC. This patch documents these properties in the code so folks
don't have to ask on IRC anymore.
- dom/Document.h:
- 6:42 AM Changeset in webkit [55460] by
-
- 4 edits in trunk/WebKitTools
2010-03-03 Jesus Sanchez-Palencia <jesus.palencia@openbossa.org>
Reviewed by Simon Hausmann.
Refactor QtLauncher so it respects command line arguments
and inherits settings when you clone or create a new window.
Implemented with help of Kenneth Rohde Christiansen.
[Qt] QtLauncher must be refactored to fix command line arguments usage
https://bugs.webkit.org/show_bug.cgi?id=35536
- QtLauncher/main.cpp: (LauncherWindow::LauncherWindow): (LauncherWindow::init): (LauncherWindow::isGraphicsBased): (applySetting): (LauncherWindow::applyPrefs): (LauncherWindow::initializeView): (LauncherWindow::newWindow): (LauncherWindow::cloneWindow): (LauncherWindow::createChrome): (main):
- QtLauncher/webview.cpp: (WebViewGraphicsBased::WebViewGraphicsBased): (WebViewGraphicsBased::setFrameRateMeasurementEnabled):
- QtLauncher/webview.h: (WebViewGraphicsBased::itemCacheMode): (WebViewGraphicsBased::frameRateMeasurementEnabled):
- 6:40 AM Google Summer of Code 2010 edited by
- (diff)
- 6:00 AM Google Summer of Code 2010 edited by
- (diff)
- 5:30 AM Changeset in webkit [55459] by
-
- 2 edits in trunk/WebCore
2010-03-03 Arno Renevier <arno@renevier.net>
Reviewed by Gustavo Noronha Silva.
[Gtk]: assertion triggered when geolocation getCurrentPosition without an option argument.
https://bugs.webkit.org/show_bug.cgi?id=35666
- platform/gtk/GeolocationServiceGtk.cpp: (WebCore::GeolocationServiceGtk::startUpdating):
- 5:17 AM Changeset in webkit [55458] by
-
- 2 edits in trunk/LayoutTests
2010-03-03 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
[GTK] build slaves need working geoclue service
https://bugs.webkit.org/show_bug.cgi?id=35674
Skip tests we're not really able to run for the time being.
- platform/gtk/Skipped:
- 4:44 AM Changeset in webkit [55457] by
-
- 6 edits in trunk
2010-03-03 Fridrich Strba <fridrich.strba@bluewin.ch>
Reviewed by Xan Lopez.
Miscellaneous little fixes for the windows build of webkit-gtk
https://bugs.webkit.org/show_bug.cgi?id=35640
- GNUmakefile.am: On Windows with GCC, presence of declspec(dllexport) on some symbols disables the autoexport/autoimport feature for all others. Using regex here assures that all symbols that need to be exported in the dll are actually exported.
2010-03-03 Fridrich Strba <fridrich.strba@bluewin.ch>
Reviewed by Xan Lopez.
Miscellaneous little fixes for the windows build of webkit-gtk
https://bugs.webkit.org/show_bug.cgi?id=35640
- GNUmakefile.am: dist two new files concerning mathml support.
2010-03-03 Fridrich Strba <fridrich.strba@bluewin.ch>
Reviewed by Xan Lopez.
Miscellaneous little fixes for the windows build of webkit-gtk
https://bugs.webkit.org/show_bug.cgi?id=35640
- webkit/webkitdownload.cpp: Windows headers define ERROR which breaks the build. Undef ERROR if it is defined.
- 4:09 AM Changeset in webkit [55456] by
-
- 2 edits in trunk/WebCore
2010-03-03 Xan Lopez <xlopez@igalia.com>
Unreviewed distcheck fix.
Add new file to the build.
- GNUmakefile.am:
- 4:02 AM Changeset in webkit [55455] by
-
- 3 edits1 add in trunk/WebCore
Make IntPoint usable as a hash key
Reviewed by Oliver Hunt.
https://bugs.webkit.org/show_bug.cgi?id=35586
- WebCore.pro:
- WebCore.xcodeproj/project.pbxproj:
- platform/graphics/IntPointHash.h: Added.
(WTF::IntPointHash::hash):
(WTF::IntPointHash::equal):
(WTF::):
- 12:24 AM Changeset in webkit [55454] by
-
- 2 edits in trunk/WebKit/gtk
2010-03-03 Philippe Normand <pnormand@igalia.com>
Unreviewed, build fix after r55452.
- webkit/webkitwebview.cpp: (DNDContentsRequest::webkit_web_view_settings_notify): added missing braces.
- 12:07 AM Changeset in webkit [55453] by
-
- 3 edits in trunk/JavaScriptCore
2010-03-02 Fridrich Strba <fridrich.strba@bluewin.ch>
Reviewed by Oliver Hunt.
Allow building smoothly on win32 and win64 using GCC
https://bugs.webkit.org/show_bug.cgi?id=35607
- jit/JITStubs.h:
- runtime/Collector.cpp: (JSC::Heap::allocateBlock): (JSC::Heap::freeBlockPtr): (JSC::currentThreadStackBase):
Mar 2, 2010:
- 11:43 PM Changeset in webkit [55452] by
-
- 11 edits in trunk
2010-03-02 Eric Uhrhane <ericu@chromium.org>
Reviewed by David Levin.
Move database enable bit fully out of settings
This is stage one of a three-stage commit [webkit, then chromium, then
webkit again]. In this change I'm adding calls to
Database::setIsAvailable inside Settings::setDatabaseEnabled and
anywhere else that called it, and switching webkit fully over to using
that flag [added in a previous checkin]. Phase two will remove
Chromium's use of Settings for the Database, and phase three will remove
the Setting for the Database enable entirely, leaving only
Database::isAvailable/setIsAvailable.
No new tests; tested by existing storage tests.
- WebCore.base.exp: Export Database::setIsAvailable
- WebCore.xcodeproj/project.pbxproj: Export needed headers as Private
- page/DOMWindow.cpp: Read isAvailable, not Settings::isDatabaseEnabled (WebCore::DOMWindow::openDatabase):
- page/Settings.cpp: Add a call to Database::setIsAvailable. (WebCore::Settings::setDatabasesEnabled):
2010-03-02 Eric Uhrhane <ericu@chromium.org>
Reviewed by David Levin.
Move database enable bit fully out of settings
This is stage one of a three-stage commit [webkit, then chromium, then
webkit again]. In this change I'm adding calls to
Database::setIsAvailable inside Settings::setDatabaseEnabled and
anywhere else that called it, and switching webkit fully over to using
that flag [added in a previous checkin]. Phase two will remove
Chromium's use of Settings for the Database, and phase three will remove
the Setting for the Database enable entirely, leaving only
Database::isAvailable/setIsAvailable.
No new tests; tested by existing storage tests.
- webkit/webkitwebview.cpp: Add calls to Database::setIsAvailable (DNDContentsRequest::webkit_web_view_update_settings): (DNDContentsRequest::webkit_web_view_settings_notify):
2010-03-02 Eric Uhrhane <ericu@chromium.org>
Reviewed by David Levin.
Move database enable bit fully out of settings
This is stage one of a three-stage commit [webkit, then chromium, then
webkit again]. In this change I'm adding calls to
Database::setIsAvailable inside Settings::setDatabaseEnabled and
anywhere else that called it, and switching webkit fully over to using
that flag [added in a previous checkin]. Phase two will remove
Chromium's use of Settings for the Database, and phase three will remove
the Setting for the Database enable entirely, leaving only
Database::isAvailable/setIsAvailable.
No new tests; tested by existing storage tests.
- WebView/WebView.mm: Added a call to Database::setIsAvailable. (-[WebView _preferencesChangedNotification:]):
2010-03-02 Eric Uhrhane <ericu@chromium.org>
Reviewed by David Levin.
Move database enable bit fully out of settings
This is stage one of a three-stage commit [webkit, then chromium, then
webkit again]. In this change I'm adding calls to
Database::setIsAvailable inside Settings::setDatabaseEnabled and
anywhere else that called it, and switching webkit fully over to using
that flag [added in a previous checkin]. Phase two will remove
Chromium's use of Settings for the Database, and phase three will remove
the Setting for the Database enable entirely, leaving only
Database::isAvailable/setIsAvailable.
No new tests; tested by existing storage tests.
- Api/qwebsettings.cpp: (QWebSettingsPrivate::apply): Add a call to Database::setIsAvailable
- 11:22 PM Changeset in webkit [55451] by
-
- 5 edits in trunk
2010-03-02 Tony Chang <tony@chromium.org>
Reviewed by Darin Fisher.
add a flag to WebURLResponse so we can identify multipart content
https://bugs.webkit.org/show_bug.cgi?id=35628
- platform/network/chromium/ResourceResponse.h: (WebCore::ResourceResponse::ResourceResponse): (WebCore::ResourceResponse::isMultipartPayload): (WebCore::ResourceResponse::setIsMultipartPayload):
2010-03-02 Tony Chang <tony@chromium.org>
Reviewed by Darin Fisher.
add a flag to WebURLResponse so we can identify multipart content
https://bugs.webkit.org/show_bug.cgi?id=35628
- public/WebURLResponse.h:
- src/WebURLResponse.cpp: (WebKit::WebURLResponse::isMultipartPayload): (WebKit::WebURLResponse::setIsMultipartPayload):
- 10:46 PM Changeset in webkit [55450] by
-
- 3 edits2 deletes in trunk
2010-03-02 Tony Chang <tony@chromium.org>
Not reviewed, test fix.
Revert r55447 because the new layout test is crashing consistently
on Leopard Intel Debug (tests).
https://bugs.webkit.org/show_bug.cgi?id=35261
- svg/custom/tiling-regular-hexagonal-crash-expected.txt: Removed.
- svg/custom/tiling-regular-hexagonal-crash.svg: Removed.
2010-03-02 Tony Chang <tony@chromium.org>
Not reviewed, test fix.
Revert r55447 because the new layout test is crashing consistently
on Leopard Intel Debug (tests).
https://bugs.webkit.org/show_bug.cgi?id=35261
- platform/graphics/skia/ImageSkia.cpp: (WebCore::BitmapImageSingleFrameSkia::create):
- 7:16 PM Changeset in webkit [55449] by
-
- 14 edits in trunk
2010-03-02 Adam Barth <abarth@webkit.org>
Reviewed by Darin Fisher.
Google Analytics triggers "blocked plugin" UI
https://bugs.webkit.org/show_bug.cgi?id=35565
Just like for running script, we need to distinguish between querying
whether plug-ins are enabled and actually blocking a page from
instantiating a plugin. We need to issue different callbacks to the
FrameLoaderClient so that the client can inform us that plug-ins are
disabled in some cases without showing the "plug-in blocked" UI.
- dom/DOMImplementation.cpp: (WebCore::DOMImplementation::createDocument):
- loader/FrameLoader.cpp: (WebCore::FrameLoader::requestObject): (WebCore::FrameLoader::allowPlugins):
- loader/FrameLoader.h: (WebCore::):
- loader/FrameLoaderClient.h: (WebCore::FrameLoaderClient::didNotAllowPlugins):
- loader/MainResourceLoader.cpp: (WebCore::MainResourceLoader::substituteMIMETypeFromPluginDatabase):
- loader/PluginDocument.cpp: (WebCore::PluginTokenizer::writeRawData):
- page/Page.cpp: (WebCore::Page::pluginData):
- plugins/MimeType.cpp: (WebCore::MimeType::enabledPlugin):
2010-03-02 Adam Barth <abarth@webkit.org>
Reviewed by Darin Fisher.
Google Analytics triggers "blocked plugin" UI
https://bugs.webkit.org/show_bug.cgi?id=35565
Plumb didNotAllowPlugins to the client.
- public/WebFrameClient.h: (WebKit::WebFrameClient::didNotAllowPlugins):
- src/FrameLoaderClientImpl.cpp: (WebKit::FrameLoaderClientImpl::didNotAllowPlugins):
- src/FrameLoaderClientImpl.h:
- 6:53 PM Changeset in webkit [55448] by
-
- 2 edits in trunk/WebCore
2010-03-02 Andreas Kling <andreas.kling@nokia.com>
Reviewed by Simon Hausmann.
[Qt] Support the HTTP OPTIONS verb (needed for preflight requests)
- platform/network/qt/QNetworkReplyHandler.cpp: (WebCore::QNetworkReplyHandler::QNetworkReplyHandler): (WebCore::QNetworkReplyHandler::start):
- 6:37 PM Changeset in webkit [55447] by
-
- 3 edits2 adds in trunk
2010-03-02 Evan Stade <estade@chromium.org>
Reviewed by David Levin.
https://bugs.webkit.org/show_bug.cgi?id=35261
[skia] crash when attempting to render certain SVGs with Skia
This test passes if it doesn't crash.
- svg/custom/tiling-regular-hexagonal-crash-expected.txt: Added.
- svg/custom/tiling-regular-hexagonal-crash.svg: Added.
2010-03-02 Evan Stade <estade@chromium.org>
Reviewed by David Levin.
https://bugs.webkit.org/show_bug.cgi?id=35261
[skia] crash when attempting to render certain SVGs
This fixes the crash, but the SVG still doesn't render properly.
Test: svg/custom/tiling-regular-hexagonal-crash.svg
- platform/graphics/skia/ImageSkia.cpp: (WebCore::BitmapImageSingleFrameSkia::create): don't return 0 when the copy fails; instead return a blank bitmap. The caller doesn't check for 0 before dereferencing.
- 6:20 PM Changeset in webkit [55446] by
-
- 2 edits in trunk/WebCore
2010-03-02 Arno Renevier <arno@renevier.net>
Reviewed by Gustavo Noronha Silva.
[Gtk] use geoclue providers with don't provide update
https://bugs.webkit.org/show_bug.cgi?id=35191
No new tests, behaviour depends on system.
- platform/gtk/GeolocationServiceGtk.cpp: (WebCore::GeolocationServiceGtk::startUpdating):
- 5:43 PM Changeset in webkit [55445] by
-
- 2 edits in trunk/WebCore
2010-03-02 John Abd-El-Malek <jam@chromium.org>
Reviewed by Darin Adler.
Remove unnecessary check.
https://bugs.webkit.org/show_bug.cgi?id=35513
- platform/ScrollView.cpp: (WebCore::ScrollView::updateScrollbars):
- 5:27 PM Changeset in webkit [55444] by
-
- 16 edits2 adds in trunk
2010-03-02 Arno Renevier <arno@renevier.net>
Reviewed by Gustavo Noronha Silva.
[Gtk] implements ChromeClient::requestGeolocationPermissionForFrame
https://bugs.webkit.org/show_bug.cgi?id=35210
- GNUmakefile.am:
2010-03-02 Arno Renevier <arno@renevier.net>
Reviewed by Gustavo Noronha Silva.
[Gtk] implements ChromeClient::requestGeolocationPermissionForFrame
https://bugs.webkit.org/show_bug.cgi?id=35210
- platform/gtk/Skipped:
2010-03-02 Arno Renevier <arno@renevier.net>
Reviewed by Gustavo Noronha Silva.
[Gtk] implements ChromeClient::requestGeolocationPermissionForFrame
https://bugs.webkit.org/show_bug.cgi?id=35210
- WebCoreSupport/ChromeClientGtk.cpp:
- WebCoreSupport/ChromeClientGtk.h:
- docs/webkitgtk-sections.txt:
- webkit/webkit.h:
- webkit/webkitdefines.h:
- webkit/webkitgeolocationpolicydecision.cpp: Added. (webkit_geolocation_policy_decision_class_init): (webkit_geolocation_policy_decision_init): (webkit_geolocation_policy_decision_new): (webkit_geolocation_policy_allow): (webkit_geolocation_policy_deny):
- webkit/webkitgeolocationpolicydecision.h: Added.
- webkit/webkitprivate.h:
- webkit/webkitwebview.cpp: (DNDContentsRequest::webkit_web_view_class_init):
- webkitmarshal.list:
2010-03-02 Arno Renevier <arno@renevier.net>
Reviewed by Gustavo Noronha Silva.
[Gtk] implements ChromeClient::requestGeolocationPermissionForFrame
https://bugs.webkit.org/show_bug.cgi?id=35210
- DumpRenderTree/gtk/DumpRenderTree.cpp: (geolocationPolicyDecisionRequested): (createWebView):
- 4:59 PM Changeset in webkit [55443] by
-
- 2 edits in trunk/WebCore
2010-03-02 Darin Fisher <darin@chromium.org>
Fix chromium build bustage.
- page/Page.cpp: (WebCore::Page::privateBrowsingStateChanged): PluginView methods may not be called in the Chromium port.
- 4:48 PM Changeset in webkit [55442] by
-
- 5 edits in trunk
WebCore: Fix for <rdar://problem/7485289> WebKit crashes on systems that
don't support CoreAnimation
Reviewed by Darin Adler and Adam Roben.
WKCACFLayerRenderer::acceleratedCompositingAvailable() now creates
a dummy HWND so that it can step through the whole setHostWindow()
and createRenderer() process. createRenderer() also calls a new
function, hardwareCapabilitiesIndicateCoreAnimationSupport() which
can only be called once we have a d3dDevice.
setHostWindow() and createRenderer() now both return bools that
indicate whether or not they have succeeded.
- platform/graphics/win/WKCACFLayerRenderer.cpp:
(WebCore::hardwareCapabilitiesIndicateCoreAnimationSupport):
(WebCore::CoreAnimationTesterWindowWndProc):
(WebCore::WKCACFLayerRenderer::acceleratedCompositingAvailable):
(WebCore::WKCACFLayerRenderer::shared):
(WebCore::WKCACFLayerRenderer::createRenderer):
- platform/graphics/win/WKCACFLayerRenderer.h:
(WebCore::WKCACFLayerRenderer::setHostWindow):
WebKit/win: Tiny WebKit portion of fix for <rdar://problem/7485289> WebKit
crashes on systems that don't support CoreAnimation
Reviewed by Darin Adler and Adam Roben.
setHostWindow() no longer calls createRenderer(), so now that has
to be called manually.
- WebView.cpp:
(WebView::setAcceleratedCompositing):
- 4:43 PM Changeset in webkit [55441] by
-
- 3 edits in trunk/WebCore
ScriptDebugServer shouldn't care that Mac does not use PluginView for plug-ins.
Rubber-stamped by Jon Honeycutt.
- bindings/js/ScriptDebugServer.cpp:
- plugins/PluginViewNone.cpp:
(WebCore::PluginView::setJavaScriptPaused): Add an empty implementation of setJavaScriptPaused.
- 4:36 PM Changeset in webkit [55440] by
-
- 3 edits in trunk/WebCore
Clean up the build fix r55437 by adding an empty implementation of privateBrowsingStateChanged in PluginViewNone.cpp
Rubber-stamped by Jon Honeycutt.
- page/Page.cpp:
- plugins/PluginViewNone.cpp:
(WebCore::PluginView::privateBrowsingStateChanged):
- 4:16 PM Changeset in webkit [55439] by
-
- 1 edit1 delete in trunk/WebKitTools
2010-03-02 Dirk Pranke <dpranke@chromium.org>
Reviewed by David Levin.
Revert r55339 - the Chromium codebase downstream had a temporary
need for WebKitTools/pywebsocket to still exist after Chris Jerdonek
had moved it (scripts still referenced the old location). Those
scripts have been updated to the new location, so it should be safe
to delete this now.
- pywebsocket/mod_pywebsocket/standalone.py: Removed.
- 4:09 PM Changeset in webkit [55438] by
-
- 2 edits in trunk/WebKitExamplePlugins
NPWindow is now null in the Cocoa event model.
Reviewed by Kevin Decker.
- NetscapeInputMethodPlugin/main.m:
(handleDraw):
(NPP_HandleEvent):
- 3:39 PM Changeset in webkit [55437] by
-
- 2 edits in trunk/WebCore
Fix the Mac build.
- page/Page.cpp:
(WebCore::Page::privateBrowsingStateChanged): Mac doesn't use WebCore's PluginView class
for plug-ins, so provide an empty implementation of privateBrowsingStateChanged for Mac.
- 3:33 PM Changeset in webkit [55436] by
-
- 8 edits2 adds in trunk
WebCore: Add the capability to create and dispatch a WheelEvent in JavaScript.
Ensure the event's default handler is triggered in the same way as it is
during a PlatformWheelEvent.
Patch by Andy Estes <aestes@apple.com> on 2010-03-02
Reviewed by Maciej Stachowiak.
https://bugs.webkit.org/show_bug.cgi?id=35566
Test: fast/events/wheelevent-in-scrolling-div.html
- dom/Node.cpp: Ensure that the default behavior (scrolling) occurs for
wheel events originating both from the platform and from
JavaScript/ObjC.
(WebCore::Node::dispatchWheelEvent): Instantiate new WheelEvent with
the graunularity of the PlatformWheelEvent.
(WebCore::Node::defaultEventHandler): Add support for mousewheel events.
- dom/WheelEvent.cpp: Add three new member variables: m_deltaX, m_deltaY
and m_granularity. m_deltaX and m_deltaY differ from m_wheelDeltaX and
m_wheelDeltaY, which are the number of wheel ticks multiplied by 120 for
IE compatibility.
(WebCore::WheelEvent::WheelEvent): Initialize new member variables.
(WebCore::WheelEvent::initWheelEvent): Same.
(WebCore::WheelEvent::initWebKitWheelEvent): Same.
- dom/WheelEvent.h: See WheelEvent.cpp.
(WebCore::WheelEvent::): Add Granularity enum (Pixel, Line, Page).
(WebCore::WheelEvent::create): Add new arguments.
(WebCore::WheelEvent::deltaX): Amount of scroll in x direction.
(WebCore::WheelEvent::deltaY): Amount of scroll in y direction.
(WebCore::WheelEvent::granularity): Units of deltaX and deltaY.
- dom/WheelEvent.idl: Add initWebKitWheelEvent() to JavaScript. This is
the same as the initWheelEvent ObjC method. As the DOM Level 3 Events
specification is still a working draft and subject to change, prefix
'WebKit' to the method signature to indicate experimental support.
- page/EventHandler.cpp: Move the scroll handling from
handleWheelEvent() to defaultWheelEventHandler(), which is executed on
both PlatformWheelEvents and JavaScript WheelEvents.
(WebCore::scrollNode): Renamed from scrollAndAcceptEvent(). Remove
the PlatformWheelEvent from the argument list and instead return a
boolean indicating if the scroll event was accepted.
(WebCore::EventHandler::handleWheelEvent): Move scrolling code from here
(WebCore::EventHandler::defaultWheelEventHandler): ...to here.
- page/EventHandler.h: Add function signature.
LayoutTests: Add a test for the patch to https://bugs.webkit.org/show_bug.cgi?id=35566.
These can be run manually or from DRT.
Patch by Andy Estes <aestes@apple.com> on 2010-03-02
Reviewed by Maciej Stachowiak.
- fast/events/wheelevent-in-scrolling-div-expected.txt: Added.
- fast/events/wheelevent-in-scrolling-div.html: Added.
- 3:32 PM Changeset in webkit [55435] by
-
- 2 edits in trunk/WebKitTools
2010-03-02 Dirk Pranke <dpranke@chromium.org>
Reviewed by Dimitri Glazkov.
new-run-webkit-tests on chromium-linux tests to see if
layout_test_helper exists, but we don't use layout_test_helper on
linux. The test derefences a None object, and we crash. This fixes
that.
- Scripts/webkitpy/layout_tests/port/chromium.py:
2010-03-02 Dirk Pranke <dpranke@chromium.org>
Reviewed by Dimitri Glazkov.
r55388 (bug 35553) worked around a bug in Python's subprocess.Popen()
that was causing DRT to hang on exit in new-run-webkit-tests.
Unfortunately, that workaround doesn't work on chromium-win
(and the script fails completely). The good news is that the check
isn't actually necessary, and so this change makes it conditional.
- Scripts/webkitpy/layout_tests/port/chromium.py:
- 3:29 PM Changeset in webkit [55434] by
-
- 2 edits in trunk/WebKitTools
2010-03-02 Dirk Pranke <dpranke@chromium.org>
Reviewed by Dimitri Glazkov.
r55388 (bug 35553) worked around a bug in Python's subprocess.Popen()
that was causing DRT to hang on exit in new-run-webkit-tests.
Unfortunately, that workaround doesn't work on chromium-win
(and the script fails completely). The good news is that the check
isn't actually necessary, and so this change makes it conditional.
- Scripts/webkitpy/layout_tests/port/chromium.py:
- 3:13 PM Changeset in webkit [55433] by
-
- 11 edits in trunk
Bug 35576: WebKit should tell plug-in instances when private browsing state changes
<http://webkit.org/b/35576>
Reviewed by Darin Adler.
WebCore:
Notify plug-in instances when the private browsing state changes to match the behavior of the
Mac plug-in code.
- page/Page.cpp:
(WebCore::Page::privateBrowsingStateChanged): Walk the frame tree and notify each PluginView that
the private browsing state has changed.
- page/Page.h:
- page/Settings.cpp:
(WebCore::Settings::setPrivateBrowsingEnabled): Notify the page that the private browsing state
has changed.
- plugins/PluginView.cpp:
(WebCore::PluginView::privateBrowsingStateChanged): Notify the plug-in instance of the new private
browsing state.
- plugins/PluginView.h:
WebKitTools:
TestNetscapePlugin is another bit of plug-in code where copy-paste was heavily used
when porting. Update the Windows and UNIX implementations of NPP_New and NPP_SetValue
to provide the expected behavior related to NPNVprivateModeBool. Hopefully this code
duplication can be cleaned up in the future.
- DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
(webkit_test_plugin_new_instance):
(webkit_test_plugin_set_value):
- DumpRenderTree/win/TestNetscapePlugin/main.cpp:
(NPP_New):
(NPP_SetValue):
LayoutTests:
- platform/win/Skipped: Remove plugins/private-browsing-mode.html now that it passes.
- 3:13 PM Changeset in webkit [55432] by
-
- 11 edits in trunk
Bug 30348: Implement private mode for plug-ins on Windows
<http://webkit.org/b/30348> / <rdar://problem/7562261>
Reviewed by Oliver Hunt.
WebCore:
Rework PluginView::getValue and PluginView::getValueStatic to remove the amount of code that
was duplicated across platforms. getValue and getValueStatic now call in to platform-specific
variants that indicate whether they handled the query. If the query is not handled by the
platform-specific variants then the cross-platform handler has a chance to handle it.
- plugins/PluginView.cpp:
(WebCore::PluginView::getValueStatic): Give the platform-specific variant a chance to handle the
variable lookup. If it does not handle it, return an error.
(WebCore::PluginView::getValue): Give the platform-specific variant and platform-specific static
variant a chance to handle the variable lookup. If they do not handle it, apply the cross-platform
handler. At the moment the cross-platform code handles NPNVWindowNPObject, NPNVPluginElementNPObject,
and NPNVprivateModeBool as they have an identical implementation across ports.
- plugins/PluginView.h:
- plugins/PluginViewNone.cpp:
(WebCore::PluginView::platformGetValue): PluginViewNone does not handle any lookups.
(WebCore::PluginView::platformGetValueStatic): Ditto.
- plugins/gtk/PluginViewGtk.cpp:
(WebCore::PluginView::platformGetValueStatic):
(WebCore::PluginView::platformGetValue):
platform-independent implementation.
- plugins/mac/PluginViewMac.cpp:
(WebCore::PluginView::platformGetValueStatic):
(WebCore::PluginView::platformGetValue):
- plugins/qt/PluginViewQt.cpp:
(WebCore::PluginView::platformGetValueStatic):
(WebCore::PluginView::platformGetValue): Fix a bug noticed while updating this code.
The Qt implementation of the handler for NPNVToolkit was relying on case fall-through
to have some values handled by the static handler. When NPNVprivateModeBool was added
it was placed before the default case, interferring with this fall-through. It now
explicitly indicates in this situation that it was not handled.
- plugins/symbian/PluginViewSymbian.cpp:
(WebCore::PluginView::platformGetValueStatic):
(WebCore::PluginView::platformGetValue):
- plugins/win/PluginViewWin.cpp:
(WebCore::PluginView::platformGetValueStatic):
(WebCore::PluginView::platformGetValue):
LayoutTests:
- platform/win/Skipped: Remove plugins/private-browsing-mode-2.html now that it passes.
- 2:27 PM Changeset in webkit [55431] by
-
- 3 edits in trunk/WebCore
Make the default constructor available to all platforms.
Reviewed by Sam Weinig.
- platform/PlatformKeyboardEvent.h:
(WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent):
- platform/mac/KeyEventMac.mm:
- 2:24 PM Changeset in webkit [55430] by
-
- 2 edits in trunk/LayoutTests
Reviewed by Adam Roben.
https://bugs.webkit.org/show_bug.cgi?id=35600
shouldBe() fails when comparing an array to null.
- fast/js/resources/js-test-pre.js: (areArraysEqual): This function is expected to be called with weird arguments, as it's used with array-like objects like WebGLByteArray. Made it resilient against exceptions raised when dealing with those.
- 2:21 PM Changeset in webkit [55429] by
-
- 8 edits in trunk
2010-03-02 Jeremy Orlow <jorlow@chromium.org>
Reviewed by David Levin.
Revert database thread changes that are no longer required
https://bugs.webkit.org/show_bug.cgi?id=35519
Jochen Eisinger created 55214 and 55247 to track which database
owns which thread. Dmitry suggested that this could also
be done via TLS, though. After exploring the options, Jochen
chose to go the TLS route, so these patches are no longer needed.
- wtf/Threading.h:
- wtf/ThreadingNone.cpp: (WTF::isMainThread):
- wtf/ThreadingPthreads.cpp: (WTF::identifierByPthreadHandle): (WTF::establishIdentifierForPthreadHandle): (WTF::pthreadHandleForIdentifier): (WTF::createThreadInternal): (WTF::currentThread):
- wtf/ThreadingWin.cpp: (WTF::threadMap): (WTF::storeThreadHandleByIdentifier): (WTF::threadHandleForIdentifier): (WTF::createThreadInternal):
2010-03-02 Jeremy Orlow <jorlow@chromium.org>
Reviewed by David Levin.
Revert database thread changes that are no longer required
https://bugs.webkit.org/show_bug.cgi?id=35519
Jochen Eisinger created 55214 and 55247 to track which database
owns which thread. Dmitry suggested that this could also
be done via TLS, though. After exploring the options, Jochen
chose to go the TLS route, so these patches are no longer needed.
- storage/DatabaseThread.cpp: (WebCore::DatabaseThread::DatabaseThread): (WebCore::DatabaseThread::databaseThread):
- storage/DatabaseThread.h: (WebCore::DatabaseThread::getThreadID):
- 1:46 PM Changeset in webkit [55428] by
-
- 5 edits in trunk
Followup for REGRESSION(r51097) - Unable to log in to statefarm.com
<rdar://problem/7672667> and https://bugs.webkit.org/show_bug.cgi?id=35556
Reviewed by Sam Weinig.
WebCore:
- dom/ScriptElement.cpp:
(WebCore::ScriptElementData::shouldExecuteAsJavaScript): To more perfectly match Gecko's rule,
strip whitespace from the attribute values before comparing to window/onload/onload().
LayoutTests:
- fast/loader/for-window-event-onload-scripts-expected.txt:
- fast/loader/for-window-event-onload-scripts.html:
- 1:39 PM Changeset in webkit [55427] by
-
- 6 edits in trunk/JavaScriptCore
2010-03-02 Jedrzej Nowacki <jedrzej.nowacki@nokia.com>
Reviewed by Simon Hausmann.
Fix QScriptValue::toString().
More ECMA Script compliance, especially for values as NaN, Inifinite
and really big/small numbers.
[Qt] QScriptValue::toString() returns incorrect values
https://bugs.webkit.org/show_bug.cgi?id=34850
- qt/api/qscriptconverter_p.h: (QScriptConverter::toString):
- qt/api/qscriptvalue_p.h: (QScriptValuePrivate::toString):
- qt/tests/qscriptvalue/tst_qscriptvalue.cpp:
- qt/tests/qscriptvalue/tst_qscriptvalue.h:
- qt/tests/qscriptvalue/tst_qscriptvalue_generated.cpp: (tst_QScriptValue::toString_initData): (tst_QScriptValue::toString_makeData): (tst_QScriptValue::toString_test):
- 1:20 PM Changeset in webkit [55426] by
-
- 7 edits1 copy5 adds in trunk/JavaScriptCore
2010-03-02 Jedrzej Nowacki <jedrzej.nowacki@nokia.com>
Reviewed by Simon Hausmann.
Introduce a new class; QScriptString.
The QScriptString class should act as a handle to "interned"
strings in a QScriptEngine.
[Qt] QtScript should provide QScriptString
https://bugs.webkit.org/show_bug.cgi?id=34843
- qt/api/QtScript.pro:
- qt/api/qscriptengine.cpp: (QScriptEngine::toStringHandle):
- qt/api/qscriptengine.h:
- qt/api/qscriptengine_p.h: (QScriptEnginePrivate::toStringHandle):
- qt/api/qscriptstring.cpp: Added. (QScriptString::QScriptString): (QScriptString::~QScriptString): (QScriptString::operator=): (QScriptString::isValid): (QScriptString::operator==): (QScriptString::operator!=): (QScriptString::toArrayIndex): (QScriptString::toString): (QScriptString::operator QString): (qHash):
- qt/api/qscriptstring.h: Added.
- qt/api/qscriptstring_p.h: Added. (QScriptStringPrivate::QScriptStringPrivate): (QScriptStringPrivate::~QScriptStringPrivate): (QScriptStringPrivate::get): (QScriptStringPrivate::isValid): (QScriptStringPrivate::operator==): (QScriptStringPrivate::operator!=): (QScriptStringPrivate::toArrayIndex): (QScriptStringPrivate::toString): (QScriptStringPrivate::id):
- qt/tests/qscriptstring/qscriptstring.pro: Added.
- qt/tests/qscriptstring/tst_qscriptstring.cpp: Added. (tst_QScriptString::tst_QScriptString): (tst_QScriptString::~tst_QScriptString): (tst_QScriptString::test): (tst_QScriptString::hash): (tst_QScriptString::toArrayIndex_data): (tst_QScriptString::toArrayIndex):
- qt/tests/tests.pro:
- 1:15 PM Changeset in webkit [55425] by
-
- 13 edits2 adds in trunk
aria-label isn't respected on option elements
https://bugs.webkit.org/show_bug.cgi?id=35400
Reviewed by Beth Dakin.
WebCore:
When aria-label is used on an <option> element, it can take three forms.
An option in a multi-select list, a popup button and the menu that is displayed
from the popup button. This patches the three requisite locations so that if
aria-label is used, the correct accessibility text is returned.
Test: platform/mac/accessibility/option-with-arialabel.html
- accessibility/AccessibilityListBoxOption.cpp:
(WebCore::AccessibilityListBoxOption::stringValue):
- accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::getAttribute):
- accessibility/AccessibilityObject.h:
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::getAttribute):
(WebCore::AccessibilityRenderObject::stringValue):
- platform/PopupMenuClient.h:
- platform/mac/PopupMenuMac.mm:
(WebCore::PopupMenu::populate):
- rendering/RenderMenuList.cpp:
(WebCore::RenderMenuList::itemAccessibilityText):
- rendering/RenderMenuList.h:
- rendering/RenderTextControlSingleLine.h:
(WebCore::RenderTextControlSingleLine::itemAccessibilityText):
WebKit/chromium:
- src/SuggestionsPopupMenuClient.h:
(WebKit::SuggestionsPopupMenuClient::itemAccessibilityText):
LayoutTests:
- platform/mac/accessibility/option-with-arialabel-expected.txt: Added.
- platform/mac/accessibility/option-with-arialabel.html: Added.
- 1:11 PM QtWebKitBugs edited by
- (diff)
- 1:08 PM QtWebKitBugs edited by
- title size adjustment (diff)
- 1:04 PM QtWebKit edited by
- link to the QtWebKitBugs page instead (diff)
- 1:01 PM QtWebKitContrib edited by
- Move bugs information to QtWebKitBugs (diff)
- 1:01 PM QtWebKitBugs created by
- 12:48 PM Changeset in webkit [55424] by
-
- 6 edits2 adds in trunk
2010-03-02 Mads Ager <ager@chromium.org>
Reviewed by Adam Barth.
[V8] V8 should be notified of context disposals
https://bugs.webkit.org/show_bug.cgi?id=35526
Notify V8 of context disposals to allow it to clean up memory from those
contexts when idle. When disposing a context, start a timer that will
give V8 an idle notification after a while to force cleanup. Use a timer
to avoid performing an idle notification in the middle of navigation where
we know we are not idle.
- WebCore.gypi:
- bindings/v8/V8DOMWindowShell.cpp: (WebCore::V8DOMWindowShell::disposeContextHandles):
- bindings/v8/V8GCForContextDispose.cpp: Added. (WebCore::V8GCForContextDispose::V8GCForContextDispose): (WebCore::V8GCForContextDispose::notifyContextDisposed): (WebCore::V8GCForContextDispose::notifyIdleSooner): (WebCore::V8GCForContextDispose::instance): (WebCore::V8GCForContextDispose::pseudoIdleTimerFired):
- bindings/v8/V8GCForContextDispose.h: Added.
- bindings/v8/custom/V8DOMWindowCustom.cpp: (WebCore::WindowSetTimeoutImpl):
2010-03-02 Mads Ager <ager@chromium.org>
Reviewed by Adam Barth.
[V8] V8 should be notified of context disposals
https://bugs.webkit.org/show_bug.cgi?id=35526
Update V8 DEPS in order to get V8 API changes needed for context
disposal notifications.
- DEPS:
- 12:31 PM Changeset in webkit [55423] by
-
- 5 edits18 deletes in trunk/LayoutTests
2010-03-02 Kent Tamura <tkent@chromium.org>
Reviewed by Shinichiro Hamaji.
Merge ValidityState-stepMismatch-{number,range,unsupported}.html and
input-step-{number,range,unsupported}.html to other tests
https://bugs.webkit.org/show_bug.cgi?id=35435
- Merge ValidityState-stepMismatch-{number,range,unsupported}.html to ValidityState-stepMismatch.html
- Merge input-step--{number,range,unsupported}.html to input-step.html
- fast/forms/ValidityState-stepMismatch-expected.txt:
- fast/forms/ValidityState-stepMismatch-number-expected.txt: Removed.
- fast/forms/ValidityState-stepMismatch-number.html: Removed.
- fast/forms/ValidityState-stepMismatch-range-expected.txt: Removed.
- fast/forms/ValidityState-stepMismatch-range.html: Removed.
- fast/forms/ValidityState-stepMismatch-unsupported-expected.txt: Removed.
- fast/forms/ValidityState-stepMismatch-unsupported.html: Removed.
- fast/forms/input-step-number-expected.txt: Removed.
- fast/forms/input-step-number.html: Removed.
- fast/forms/input-step-range-expected.txt: Removed.
- fast/forms/input-step-range.html: Removed.
- fast/forms/input-step-unsupported-expected.txt: Removed.
- fast/forms/input-step-unsupported.html: Removed.
- fast/forms/input-stepup-stepdown-expected.txt:
- fast/forms/script-tests/ValidityState-stepMismatch-number.js: Removed.
- fast/forms/script-tests/ValidityState-stepMismatch-range.js: Removed.
- fast/forms/script-tests/ValidityState-stepMismatch-unsupported.js: Removed.
- fast/forms/script-tests/ValidityState-stepMismatch.js:
- fast/forms/script-tests/input-step-number.js: Removed.
- fast/forms/script-tests/input-step-range.js: Removed.
- fast/forms/script-tests/input-step-unsupported.js: Removed.
- fast/forms/script-tests/input-stepup-stepdown.js:
- 12:18 PM Changeset in webkit [55422] by
-
- 3 edits in trunk/WebCore
2010-03-02 Pavel Feldman <pfeldman@chromium.org>
Not reviewed: adding missing image files to WebKit.qrc and gypi.
- WebCore.gypi:
- inspector/front-end/WebKit.qrc:
- 12:15 PM Changeset in webkit [55421] by
-
- 2 edits in trunk/WebCore
2010-03-02 Kim Grönholm <kim.gronholm@nomovok.com>
Reviewed by Simon Hausmann.
[Qt] GraphicsLayer: Video element with 3d transform crashes when AC is enabled.
https://bugs.webkit.org/show_bug.cgi?id=35516
No new tests.
- platform/graphics/qt/GraphicsLayerQt.cpp: (WebCore::GraphicsLayerQt::setContentsToMedia):
- 11:50 AM Changeset in webkit [55420] by
-
- 2 edits in trunk/WebCore
2010-03-02 Fridrich Strba <fridrich.strba@bluewin.ch>
Reviewed by Xan Lopez.
Use unsigned instead of uint which does not exist on windows
https://bugs.webkit.org/show_bug.cgi?id=35546
- platform/graphics/gtk/ImageGtk.cpp: (WebCore::getCairoSurfacePixel): (WebCore::getGdkPixbufPixel):
- 11:33 AM Changeset in webkit [55419] by
-
- 7 edits in trunk
2010-03-02 Kenneth Russell <kbr@google.com>
Reviewed by Darin Fisher.
Add EnabledAtRuntime attribute to WebGLArray constructors
https://bugs.webkit.org/show_bug.cgi?id=35558
New functionality verified manually in Chromium; not possible to
write layout test. Ran WebGL tests in WebKit as well.
- bindings/generic/RuntimeEnabledFeatures.cpp:
- bindings/generic/RuntimeEnabledFeatures.h: (WebCore::RuntimeEnabledFeatures::setWebGLEnabled): (WebCore::RuntimeEnabledFeatures::webGLRenderingContextEnabled): (WebCore::RuntimeEnabledFeatures::webGLArrayBufferEnabled): (WebCore::RuntimeEnabledFeatures::webGLByteArrayEnabled): (WebCore::RuntimeEnabledFeatures::webGLUnsignedByteArrayEnabled): (WebCore::RuntimeEnabledFeatures::webGLShortArrayEnabled): (WebCore::RuntimeEnabledFeatures::webGLUnsignedShortArrayEnabled): (WebCore::RuntimeEnabledFeatures::webGLIntArrayEnabled): (WebCore::RuntimeEnabledFeatures::webGLUnsignedIntArrayEnabled): (WebCore::RuntimeEnabledFeatures::webGLFloatArrayEnabled):
- page/DOMWindow.idl:
2010-03-02 Kenneth Russell <kbr@google.com>
Reviewed by Darin Fisher.
Add EnabledAtRuntime attribute to WebGLArray constructors
https://bugs.webkit.org/show_bug.cgi?id=35558
- public/WebRuntimeFeatures.h:
- src/WebRuntimeFeatures.cpp: (WebKit::WebRuntimeFeatures::enableWebGL): (WebKit::WebRuntimeFeatures::isWebGLEnabled):
- 11:12 AM Changeset in webkit [55418] by
-
- 2 edits in trunk
Ignore compiled Java test cases in .gitignore.
https://bugs.webkit.org/show_bug.cgi?id=35559
Reviewed by Alexey Proskuryakov.
- .gitignore:
- 11:10 AM Changeset in webkit [55417] by
-
- 2 edits in trunk/WebCore
2010-03-02 Nate Chapin <Nate Chapin>
Reviewed by Dimitri Glazkov.
[V8] Fail gracefully if NPN_GetProperty tries to retrieve a property that doesn't exist.
Required for passing LayoutTests/plugins/netscape-plugin-property-access-exception.html on Chromium.
- bindings/v8/NPV8Object.cpp: (_NPN_GetProperty): If the result is empty, don't try to convert it to an NPVariant and return false.
- 10:59 AM Changeset in webkit [55416] by
-
- 2 edits in trunk/WebCore
[V8] DOMCoreException should be visible as DOMException
https://bugs.webkit.org/show_bug.cgi?id=35552
Reviewed by Nate Chapin.
Fix V8 code generator to use the correct visible name.
- bindings/scripts/CodeGeneratorV8.pm:
- 10:34 AM Changeset in webkit [55415] by
-
- 2 edits in trunk/WebKitTools
2010-03-02 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Reviewed by Alexey Proskuryakov.
Test plugin still has issues with releasing objects, and variants
https://bugs.webkit.org/show_bug.cgi?id=35587
Fix the conditions for releasing the variants after calling
invoke, and avoid having a number of objects leak.
- DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: (testDocumentOpen): (testWindowOpen):
- 10:33 AM Changeset in webkit [55414] by
-
- 9 edits2 adds in trunk
REGRESSION(r51097) - Unable to log in to statefarm.com
<rdar://problem/7672667> and https://bugs.webkit.org/show_bug.cgi?id=35556
Reviewed by Sam Weinig.
WebCore:
Test: fast/loader/for-window-event-onload-scripts.html
Match Gecko's rules for executing "for/event" scripts:
-If there's only a 'for' attribute, execute it.
-If there's only an 'event' attribute, execute it.
-If there's a 'for=window' and 'event=onload', execute it.
-If there's a 'for=window' and 'event=onload()', execute it.
-If there's any other combination of both 'for' and 'event', don't execute it.
- dom/ScriptElement.cpp:
(WebCore::ScriptElementData::shouldExecuteAsJavaScript):
- dom/ScriptElement.h:
- html/HTMLScriptElement.cpp:
(WebCore::HTMLScriptElement::eventAttributeValue):
- html/HTMLScriptElement.h:
- svg/SVGScriptElement.cpp:
(WebCore::SVGScriptElement::eventAttributeValue):
- svg/SVGScriptElement.h:
Add the event attribute name:
- html/HTMLAttributeNames.in:
LayoutTests:
- fast/loader/for-window-event-onload-scripts-expected.txt: Added.
- fast/loader/for-window-event-onload-scripts.html: Added.
- 10:19 AM Changeset in webkit [55413] by
-
- 3 edits in trunk/WebKit/chromium
2010-03-02 James Hawkins <jhawkins@chromium.org>
Reviewed by Darin Fisher.
[Chromium] Implement WebNode::equals and add inline operators for ==
and !=.
- public/WebNode.h: (WebKit::operator==): (WebKit::operator!=):
- src/WebNode.cpp: (WebKit::WebNode::equals):
- 9:52 AM Changeset in webkit [55412] by
-
- 2 edits1 add in trunk/WebCore
2010-03-02 Simon Fraser <Simon Fraser>
Reviewed by Dan Bernstein.
https://bugs.webkit.org/show_bug.cgi?id=35555
QuickTime plugin content can spill outside the <object> tag
Set -masksToBounds on the layer that is handed to us by plug-ins, to ensure that sublayers
of that layer don't spill outside the <object> contents rect.
Manual test because it relies on QuickTime, and pixel results depend on movie loading timing.
- manual-tests/plugins/object-clipping.html: Added.
- platform/graphics/mac/GraphicsLayerCA.mm: (WebCore::GraphicsLayerCA::setupContentsLayer):
- 9:25 AM Changeset in webkit [55411] by
-
- 4 edits in trunk/WebKitTools
Refactored the StyleChecker class's file-processing method
_process_file(). This will make it easier to add new
file-processing capabilities to check-webkit-style.
Reviewed by Shinichiro Hamaji.
https://bugs.webkit.org/show_bug.cgi?id=35490
- Scripts/webkitpy/style/checker.py:
- Added a _read_lines() method to the StyleChecker class that extracts the lines from a file.
- Replaced part of _process_file() with a call to the new _read_lines() method.
- Replaced another part of _process_file() with a call to the new CarriageReturnProcessor.process() method.
- Scripts/webkitpy/style/processors/common.py:
- Replaced the check_no_carriage_return() function with a new CarriageReturnProcessor class.
- Scripts/webkitpy/style/processors/common_unittest.py:
- Renamed the CarriageReturnTest class to CarriageReturnProcessorTest and updated it as necessary.
- 9:25 AM Changeset in webkit [55410] by
-
- 3 edits in trunk/LayoutTests
Fixing layout test problems. No review.
AX: changes to WAI-ARIA grid aren't perceived correctly by VoiceOver
https://bugs.webkit.org/show_bug.cgi?id=35514
AXTable tests crash on Leopard/Tiger because tables don't exist. This test needs to be skipped
on those playtforms.
- platform/mac-leopard/Skipped:
- platform/mac-tiger/Skipped:
- 9:11 AM QtWebKit edited by
- (diff)
- 8:48 AM Changeset in webkit [55409] by
-
- 5 edits2 adds in trunk/WebKitTools
2010-03-02 Chris Jerdonek <Chris Jerdonek>
Reviewed by Shinichiro Hamaji.
Started using the logging module in check-webkit-style.
This provides more options for debugging and a more flexible,
uniform way to report messages to the end-user.
Also included classes in a central location to facilitate
the unit testing of logging code (setUp and tearDown of unit
test logging configurations, etc).
- Scripts/check-webkit-style:
- Added a call to configure_logging() in the beginning of main().
- Replaced two calls to sys.stderr.write() with appropriate logging calls.
- Scripts/webkitpy/init/init.py: Copied from WebKitTools/QueueStatusServer/filters/init.py.
- Scripts/webkitpy/init/logtesting.py: Added.
- Added a UnitTestLogStream class to capture log output during unit tests.
- Added a UnitTestLog class that provides convenience methods for unit-testing logging code.
- Scripts/webkitpy/style/checker.py:
- Added a configure_logging() method.
- Added a _LevelLoggingFilter class to filter out log messages above a certain logging level.
- Removed the _stderr_write() method from the StyleChecker class and replaced its use with appropriate logging calls.
- Scripts/webkitpy/style/checker_unittest.py:
- Added a ConfigureLoggingTest class to unit test the configure_logging() method.
- Updated the StyleCheckerCheckFileTest class as necessary.
- Scripts/webkitpy/style_references.py:
- Added references to logtesting.UnitTestLog and logtesting.UnitTestLogStream.
- 8:22 AM Changeset in webkit [55408] by
-
- 10 edits in trunk
Expose SecurityOrigin::registerURLSchemeAsSecure as WebKit SPI
Fixes <http://webkit.org/b/35580> <rdar://problem/7706407>
Reviewed by Tim Hatcher.
WebCore:
Export SecurityOrigin::registerURLSchemeAsSecure
- WebCore.base.exp: Added symbol, sorted file.
WebKit/mac:
Add -[WebView _registerURLSchemeAsSecure:]
- WebView/WebView.mm:
(+[WebView _registerURLSchemeAsSecure:]):
- WebView/WebViewPrivate.h:
Added. Calls through to SecurityOrigin::registerURLSchemeAsSecure.
WebKit/win:
Add IWebViewPrivate::registerURLSchemeAsSecure
- Interfaces/WebKit.idl: Touched to force a build.
- Interfaces/IWebViewPrivate.idl:
- WebView.cpp:
(WebView::registerURLSchemeAsSecure):
- WebView.h:
Added. Calls through to SecurityOrigin::registerURLSchemeAsSecure.
- 8:15 AM QtWebKit edited by
- (diff)
- 8:14 AM QtWebKit edited by
- (diff)
- 8:10 AM QtWebKitContrib edited by
- (diff)
- 8:09 AM QtWebKitContrib edited by
- (diff)
- 6:52 AM QtWebKitContrib edited by
- (diff)
- 6:50 AM QtWebKitContrib edited by
- (diff)
- 6:44 AM QtWebKitContrib edited by
- (diff)
- 6:37 AM Changeset in webkit [55407] by
-
- 4 edits5 adds in trunk/WebCore
2010-03-02 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: render breakpoints as border images instead of canvas.
- inspector/front-end/Images/breakpointBorder.png: Added.
- inspector/front-end/Images/breakpointConditionalBorder.png: Added.
- inspector/front-end/Images/breakpointConditionalCounterBorder.png: Added.
- inspector/front-end/Images/breakpointCounterBorder.png: Added.
- inspector/front-end/Images/programCounterBorder.png: Added.
- inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype._updateExecutionLine): (WebInspector.SourceFrame.prototype._addBreakpointToSource): (WebInspector.SourceFrame.prototype.resize):
- inspector/front-end/TextViewer.js: (WebInspector.TextChunk):
- inspector/front-end/textViewer.css:
- 6:09 AM CommitterTips edited by
- Added section about unreviewed commits. (diff)
- 6:06 AM CommitterTips edited by
- Added section about rolling out. (diff)
- 2:16 AM Changeset in webkit [55406] by
-
- 2 edits in trunk/WebCore
[Qt] Special case Font::floatWidthForComplexText for single space
https://bugs.webkit.org/show_bug.cgi?id=33876
For a single space we can go through the QFontMetric::width routine
instead of converting the WebCore::String to a QString and then
going through the QTextLine.
- platform/graphics/qt/FontQt.cpp:
(WebCore::Font::floatWidthForComplexText):
- 1:59 AM Changeset in webkit [55405] by
-
- 4 edits in trunk
[Gtk] Support private browsing mode in plugins.
https://bugs.webkit.org/show_bug.cgi?id=35500
Integrate the PluginViewQt.cpp changes from
r55358 into Gtk+ and unskip the test.
- plugins/gtk/PluginViewGtk.cpp:
(WebCore::PluginView::getValue):
- platform/gtk/Skipped:
- 1:12 AM Changeset in webkit [55404] by
-
- 3 edits in trunk/WebCore
2010-03-02 Oliver Hunt <oliver@apple.com>
Reviewed by NOBODY (Build fix).
Update Qt bridge to new named getter signature
- bridge/qt/qt_runtime.cpp: (JSC::Bindings::QtRuntimeMetaMethod::lengthGetter): (JSC::Bindings::QtRuntimeMetaMethod::connectGetter): (JSC::Bindings::QtRuntimeMetaMethod::disconnectGetter): (JSC::Bindings::QtRuntimeConnectionMethod::lengthGetter):
- bridge/qt/qt_runtime.h:
- 1:01 AM PythonGuidelines created by
- Created Python page.
- 12:32 AM Changeset in webkit [55403] by
-
- 2 edits in trunk/JavaScriptCore
2010-03-02 Oliver Hunt <oliver@apple.com>
Reviewed by NOBODY (Build fix).
Export function on windows.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
- 12:31 AM WikiStart edited by
- Added link to Python Guidelines page. (diff)
- 12:30 AM Changeset in webkit [55402] by
-
- 2 edits8 moves1 add in trunk/WebCore
2010-03-01 Philippe Normand <pnormand@igalia.com>
Reviewed by Gustavo Noronha.
[GTK] Move gstreamer-related source files to platform/graphics/gstreamer
https://bugs.webkit.org/show_bug.cgi?id=35518
Moved GStreamer-related files to platform/graphics/gstreamer so
other ports could benefit from this media player implementation.
- GNUmakefile.am:
- platform/graphics/gstreamer/DataSourceGStreamer.cpp: Renamed from WebCore/platform/graphics/gtk/DataSourceGStreamer.cpp. (_do_init): (webkit_data_src_base_init): (webkit_data_src_class_init): (webkit_data_src_reset): (webkit_data_src_init): (webkit_data_src_finalize): (webkit_data_src_change_state): (webkit_data_src_uri_get_type): (webkit_data_src_uri_get_protocols): (webkit_data_src_uri_get_uri): (webkit_data_src_uri_set_uri): (webkit_data_src_uri_handler_init):
- platform/graphics/gstreamer/DataSourceGStreamer.h: Renamed from WebCore/platform/graphics/gtk/DataSourceGStreamer.h.
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: Renamed from WebCore/platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp. (WebCore::greatestCommonDivisor): (WebCore::mediaPlayerPrivateMessageCallback): (WebCore::mediaPlayerPrivateSourceChangedCallback): (WebCore::mediaPlayerPrivateVolumeChangedCallback): (WebCore::notifyVolumeIdleCallback): (WebCore::mediaPlayerPrivateMuteChangedCallback): (WebCore::notifyMuteIdleCallback): (WebCore::bufferingTimeoutCallback): (WebCore::playbackPosition): (WebCore::mediaPlayerPrivateRepaintCallback): (WebCore::MediaPlayerPrivate::create): (WebCore::MediaPlayerPrivate::registerMediaEngine): (WebCore::doGstInit): (WebCore::MediaPlayerPrivate::isAvailable): (WebCore::MediaPlayerPrivate::MediaPlayerPrivate): (WebCore::MediaPlayerPrivate::~MediaPlayerPrivate): (WebCore::MediaPlayerPrivate::load): (WebCore::MediaPlayerPrivate::changePipelineState): (WebCore::MediaPlayerPrivate::play): (WebCore::MediaPlayerPrivate::pause): (WebCore::MediaPlayerPrivate::duration): (WebCore::MediaPlayerPrivate::currentTime): (WebCore::MediaPlayerPrivate::seek): (WebCore::MediaPlayerPrivate::startEndPointTimerIfNeeded): (WebCore::MediaPlayerPrivate::cancelSeek): (WebCore::MediaPlayerPrivate::endPointTimerFired): (WebCore::MediaPlayerPrivate::paused): (WebCore::MediaPlayerPrivate::seeking): (WebCore::MediaPlayerPrivate::naturalSize): (WebCore::MediaPlayerPrivate::hasVideo): (WebCore::MediaPlayerPrivate::hasAudio): (WebCore::MediaPlayerPrivate::setVolume): (WebCore::MediaPlayerPrivate::volumeChangedCallback): (WebCore::MediaPlayerPrivate::volumeChanged): (WebCore::MediaPlayerPrivate::setRate): (WebCore::MediaPlayerPrivate::networkState): (WebCore::MediaPlayerPrivate::readyState): (WebCore::MediaPlayerPrivate::buffered): (WebCore::MediaPlayerPrivate::processBufferingStats): (WebCore::MediaPlayerPrivate::queryBufferingStats): (WebCore::MediaPlayerPrivate::maxTimeSeekable): (WebCore::MediaPlayerPrivate::maxTimeLoaded): (WebCore::MediaPlayerPrivate::bytesLoaded): (WebCore::MediaPlayerPrivate::totalBytes): (WebCore::MediaPlayerPrivate::cancelLoad): (WebCore::MediaPlayerPrivate::updateStates): (WebCore::MediaPlayerPrivate::mediaLocationChanged): (WebCore::MediaPlayerPrivate::loadNextLocation): (WebCore::MediaPlayerPrivate::loadStateChanged): (WebCore::MediaPlayerPrivate::sizeChanged): (WebCore::MediaPlayerPrivate::timeChanged): (WebCore::MediaPlayerPrivate::didEnd): (WebCore::MediaPlayerPrivate::durationChanged): (WebCore::MediaPlayerPrivate::supportsMuting): (WebCore::MediaPlayerPrivate::setMuted): (WebCore::MediaPlayerPrivate::muteChangedCallback): (WebCore::MediaPlayerPrivate::muteChanged): (WebCore::MediaPlayerPrivate::loadingFailed): (WebCore::MediaPlayerPrivate::setSize): (WebCore::MediaPlayerPrivate::setVisible): (WebCore::MediaPlayerPrivate::repaint): (WebCore::MediaPlayerPrivate::paint): (WebCore::mimeTypeCache): (WebCore::MediaPlayerPrivate::getSupportedTypes): (WebCore::MediaPlayerPrivate::supportsType): (WebCore::MediaPlayerPrivate::hasSingleSecurityOrigin): (WebCore::MediaPlayerPrivate::supportsFullscreen): (WebCore::MediaPlayerPrivate::setAutobuffer): (WebCore::MediaPlayerPrivate::createGSTPlayBin):
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h: Renamed from WebCore/platform/graphics/gtk/MediaPlayerPrivateGStreamer.h. (WebCore::MediaPlayerPrivate::pipelineReset):
- platform/graphics/gstreamer/VideoSinkGStreamer.cpp: Renamed from WebCore/platform/graphics/gtk/VideoSinkGStreamer.cpp. (webkit_video_sink_base_init): (webkit_video_sink_init): (webkit_video_sink_timeout_func): (webkit_video_sink_render): (webkit_video_sink_dispose): (unlock_buffer_mutex): (webkit_video_sink_unlock): (webkit_video_sink_unlock_stop): (webkit_video_sink_stop): (webkit_video_sink_start): (marshal_VOIDMINIOBJECT): (webkit_video_sink_class_init): (webkit_video_sink_new):
- platform/graphics/gstreamer/VideoSinkGStreamer.h: Renamed from WebCore/platform/graphics/gtk/VideoSinkGStreamer.h.
- platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp: Renamed from WebCore/platform/graphics/gtk/WebKitWebSourceGStreamer.cpp. (doInit): (webkit_web_src_base_init): (webkit_web_src_class_init): (webkit_web_src_init): (webKitWebSrcFinalize): (webKitWebSrcSetProperty): (webKitWebSrcGetProperty): (webKitWebSrcStop): (webKitWebSrcStart): (webKitWebSrcChangeState): (webKitWebSrcUriGetType): (webKitWebSrcGetProtocols): (webKitWebSrcGetUri): (webKitWebSrcSetUri): (webKitWebSrcUriHandlerInit): (webKitWebSrcNeedDataMainCb): (webKitWebSrcNeedDataCb): (webKitWebSrcEnoughDataMainCb): (webKitWebSrcEnoughDataCb): (webKitWebSrcSeekMainCb): (webKitWebSrcSeekDataCb): (webKitWebSrcSetFrame): (StreamingClient::StreamingClient): (StreamingClient::~StreamingClient): (StreamingClient::willSendRequest): (StreamingClient::didReceiveResponse): (StreamingClient::didReceiveData): (StreamingClient::didFinishLoading): (StreamingClient::didFail): (StreamingClient::wasBlocked): (StreamingClient::cannotShowURL):
- platform/graphics/gstreamer/WebKitWebSourceGStreamer.h: Renamed from WebCore/platform/graphics/gtk/WebKitWebSourceGStreamer.h.
- 12:20 AM Changeset in webkit [55401] by
-
- 45 edits in trunk
2010-03-01 Oliver Hunt <oliver@apple.com>
Reviewed by Maciej Stachowiak.
Refactor named getter function signature to be in line with indexing getter signature
https://bugs.webkit.org/show_bug.cgi?id=35563
This removes the PropertySlot argument from getter functions, and makes them directly
pass the slot base. This makes the semantics for the functions match that of the
indexing getters.
On the down side, this means that we can no longer simply use a proxy function for
JS getters, so we now add another marker value to indicate that a getter is present
and branch accordingly.
Against all rationality sunspider reports this as a perf win, but i suspect it's just noise.
- API/JSCallbackObject.h:
- API/JSCallbackObjectFunctions.h: (JSC::::staticValueGetter): (JSC::::staticFunctionGetter): (JSC::::callbackGetter):
- JavaScriptCore.exp:
- runtime/JSActivation.cpp: (JSC::JSActivation::argumentsGetter):
- runtime/JSActivation.h:
- runtime/JSFunction.cpp: (JSC::JSFunction::argumentsGetter): (JSC::JSFunction::callerGetter): (JSC::JSFunction::lengthGetter):
- runtime/JSFunction.h:
- runtime/NumberConstructor.cpp: (JSC::numberConstructorNaNValue): (JSC::numberConstructorNegInfinity): (JSC::numberConstructorPosInfinity): (JSC::numberConstructorMaxValue): (JSC::numberConstructorMinValue):
- runtime/PropertySlot.cpp: (JSC::PropertySlot::functionGetter):
- runtime/PropertySlot.h: (JSC::PropertySlot::getValue): (JSC::PropertySlot::setGetterSlot): (JSC::PropertySlot::setCacheableGetterSlot):
- runtime/RegExpConstructor.cpp: (JSC::regExpConstructorDollar1): (JSC::regExpConstructorDollar2): (JSC::regExpConstructorDollar3): (JSC::regExpConstructorDollar4): (JSC::regExpConstructorDollar5): (JSC::regExpConstructorDollar6): (JSC::regExpConstructorDollar7): (JSC::regExpConstructorDollar8): (JSC::regExpConstructorDollar9): (JSC::regExpConstructorInput): (JSC::regExpConstructorMultiline): (JSC::regExpConstructorLastMatch): (JSC::regExpConstructorLastParen): (JSC::regExpConstructorLeftContext): (JSC::regExpConstructorRightContext):
- runtime/RegExpObject.cpp: (JSC::regExpObjectGlobal): (JSC::regExpObjectIgnoreCase): (JSC::regExpObjectMultiline): (JSC::regExpObjectSource): (JSC::regExpObjectLastIndex):
2010-03-01 Oliver Hunt <oliver@apple.com>
Reviewed by Maciej Stachowiak.
Refactor named getter function signature to be in line with indexing getter signature
https://bugs.webkit.org/show_bug.cgi?id=35563
Fix method signature and update code as appropriate
- UserObjectImp.cpp: (UserObjectImp::userObjectGetter):
- UserObjectImp.h:
2010-03-01 Oliver Hunt <oliver@apple.com>
Reviewed by Maciej Stachowiak.
Refactor named getter function signature to be in line with indexing getter signature
https://bugs.webkit.org/show_bug.cgi?id=35563
Fix up WebCore to use the new named getter function signature, update the
codegenerator to the new calling convention, and fix the custom bindings.
- bindings/js/JSCSSStyleDeclarationCustom.cpp: (WebCore::JSCSSStyleDeclaration::nameGetter):
- bindings/js/JSDOMBinding.cpp: (WebCore::objectToStringFunctionGetter):
- bindings/js/JSDOMBinding.h:
- bindings/js/JSDOMWindowCustom.cpp: (WebCore::nonCachingStaticFunctionGetter): (WebCore::childFrameGetter): (WebCore::namedItemGetter):
- bindings/js/JSDataGridColumnListCustom.cpp: (WebCore::JSDataGridColumnList::nameGetter):
- bindings/js/JSHTMLAllCollectionCustom.cpp: (WebCore::JSHTMLAllCollection::nameGetter):
- bindings/js/JSHTMLCollectionCustom.cpp: (WebCore::JSHTMLCollection::nameGetter):
- bindings/js/JSHTMLDocumentCustom.cpp: (WebCore::JSHTMLDocument::nameGetter):
- bindings/js/JSHTMLFormElementCustom.cpp: (WebCore::JSHTMLFormElement::nameGetter):
- bindings/js/JSHTMLFrameSetElementCustom.cpp: (WebCore::JSHTMLFrameSetElement::nameGetter):
- bindings/js/JSHistoryCustom.cpp: (WebCore::nonCachingStaticBackFunctionGetter): (WebCore::nonCachingStaticForwardFunctionGetter): (WebCore::nonCachingStaticGoFunctionGetter):
- bindings/js/JSLocationCustom.cpp: (WebCore::nonCachingStaticReplaceFunctionGetter): (WebCore::nonCachingStaticReloadFunctionGetter): (WebCore::nonCachingStaticAssignFunctionGetter):
- bindings/js/JSMimeTypeArrayCustom.cpp: (WebCore::JSMimeTypeArray::nameGetter):
- bindings/js/JSNamedNodeMapCustom.cpp: (WebCore::JSNamedNodeMap::nameGetter):
- bindings/js/JSNodeListCustom.cpp: (WebCore::JSNodeList::nameGetter):
- bindings/js/JSPluginArrayCustom.cpp: (WebCore::JSPluginArray::nameGetter):
- bindings/js/JSPluginCustom.cpp: (WebCore::JSPlugin::nameGetter):
- bindings/js/JSPluginElementFunctions.cpp: (WebCore::runtimeObjectPropertyGetter):
- bindings/js/JSPluginElementFunctions.h:
- bindings/js/JSStorageCustom.cpp: (WebCore::JSStorage::nameGetter):
- bindings/js/JSStyleSheetListCustom.cpp: (WebCore::JSStyleSheetList::nameGetter):
- bindings/scripts/CodeGeneratorJS.pm:
- bridge/runtime_array.cpp: (JSC::RuntimeArray::lengthGetter):
- bridge/runtime_array.h:
- bridge/runtime_method.cpp: (JSC::RuntimeMethod::lengthGetter):
- bridge/runtime_method.h:
- bridge/runtime_object.cpp: (JSC::Bindings::RuntimeObject::fallbackObjectGetter): (JSC::Bindings::RuntimeObject::fieldGetter): (JSC::Bindings::RuntimeObject::methodGetter):
- bridge/runtime_object.h:
- 12:10 AM Changeset in webkit [55400] by
-
- 2 edits in trunk/WebKit/qt
Symbian build fix.
[Qt] Updated the def file with one new export, to fix
QtLauncher linkage.
- symbian/eabi/QtWebKitu.def:
