Timeline
Mar 4, 2010:
- 10:09 PM Changeset in webkit [55572] by
-
- 6 edits in trunk
2010-03-04 Garret Kelly <gdk@chromium.org>
Reviewed by Darin Fisher.
Changing private members from PlatformTouchEvent and PlatformTouchPoint
to be protected, so that Chromium's PlatformTouchEventBuilder and
PlatformTouchPointBuilder can access them. Exercised by the
fast/events/touch tests.
https://bugs.webkit.org/show_bug.cgi?id=35760
- platform/PlatformTouchEvent.h: (WebCore::PlatformTouchEvent::~PlatformTouchEvent):
- platform/PlatformTouchPoint.h: (WebCore::PlatformTouchPoint::~PlatformTouchPoint):
2010-03-04 Garret Kelly <gdk@chromium.org>
Reviewed by Darin Fisher.
Adding PlatformTouchEventBuilder and PlatformTouchPointBuilder for
converting Chromium WebTouchEvent and WebTouchPoint types to
corresponding WebCore types.
https://bugs.webkit.org/show_bug.cgi?id=35760
- src/WebInputEventConversion.cpp: (WebKit::toPlatformTouchEventType): (WebKit::toPlatformTouchPointState): (WebKit::PlatformTouchPointBuilder::PlatformTouchPointBuilder): (WebKit::PlatformTouchEventBuilder::PlatformTouchEventBuilder):
- src/WebInputEventConversion.h:
- 9:52 PM Changeset in webkit [55571] by
-
- 2 edits in trunk/WebKit/chromium
2010-03-04 John Gregg <johnnyg@google.com>
Reviewed by Darin Fisher.
[chromium] WebDocument:applicationID() crashes on <meta> tag with no http-equiv attribute
https://bugs.webkit.org/show_bug.cgi?id=35771
- src/WebDocument.cpp: (WebKit::WebDocument::applicationID): check for presence of http-equiv attribute before lower()ing it.
- 9:50 PM Changeset in webkit [55570] by
-
- 5 edits3 adds in trunk
WebSocket crash bug when reloading the page while the WebSocket is busy
https://bugs.webkit.org/show_bug.cgi?id=35732
Reviewed by Alexey Proskuryakov.
WebCore:
- websockets/WebSocketChannel.cpp:
(WebCore::WebSocketChannel::disconnect): clear m_context from WebSocketChannel and WebSocketHandshake.
(WebCore::WebSocketChannel::didOpen): check m_context
(WebCore::WebSocketChannel::didClose): clear m_context
(WebCore::WebSocketChannel::didReceiveData): check m_context, and check m_client early before appending to buffer
- websockets/WebSocketHandshake.cpp:
(WebCore::WebSocketHandshake::clearScriptExecutionContext): Added.
- websockets/WebSocketHandshake.h:
LayoutTests:
- websocket/tests/reload-crash-expected.txt: Added.
- websocket/tests/reload-crash.html: Added.
- websocket/tests/resoures/reload-crash-iframe.html: Added.
- 9:35 PM Changeset in webkit [55569] by
-
- 6 edits2 adds in trunk
2010-03-04 MORITA Hajime <morrita@google.com>
Reviewed by Alexey Proskuryakov.
Refactoring: XMLHTTPRequest.open() should have all overloaded implementations
https://bugs.webkit.org/show_bug.cgi?id=35630
- http/tests/xmlhttprequest/open-async-overload-expected.txt: Added.
- http/tests/xmlhttprequest/open-async-overload.html: Added.
2010-03-04 MORITA Hajime <morrita@google.com>
Reviewed by Alexey Proskuryakov.
Refactoring: XMLHTTPRequest.open() should have all overloaded implementations
https://bugs.webkit.org/show_bug.cgi?id=35630
Test: http/tests/xmlhttprequest/open-async-overload.html
- bindings/js/JSXMLHttpRequestCustom.cpp: (WebCore::JSXMLHttpRequest::open):
- bindings/v8/custom/V8XMLHttpRequestCustom.cpp: (WebCore::V8XMLHttpRequest::openCallback):
- xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::open):
- xml/XMLHttpRequest.h:
- 9:18 PM Changeset in webkit [55568] by
-
- 3 edits in trunk/WebCore
2010-03-04 James Robinson <jamesr@google.com>
Reviewed by Eric Seidel.
Styles do not have to be synchronously rematched after every event dispatch
- bindings/js/JSEventListener.cpp: (WebCore::JSEventListener::handleEvent):
- bindings/v8/V8AbstractEventListener.cpp: (WebCore::V8AbstractEventListener::handleEvent):
- 9:01 PM Changeset in webkit [55567] by
-
- 2 edits in trunk/WebCore
2010-03-04 Luiz Agostini <luiz.agostini@openbossa.org>
Reviewed by Kenneth Rohde Christiansen.
maemo spelled as mameo in WebCore.pro
https://bugs.webkit.org/show_bug.cgi?id=35765
Spelling corrected.
- WebCore.pro:
- 8:34 PM Changeset in webkit [55566] by
-
- 3 edits2 adds in trunk
2010-03-04 Tony Chang <tony@chromium.org>
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=18819
Pressing option+page{down,up} should move the cursor and scroll in
content editable areas. On other platforms, pressing page{down,up}
should move the cursor and scroll in content editable areas.
- editing/input/option-page-up-down-expected.txt: Added.
- editing/input/option-page-up-down.html: Added.
2010-03-04 Tony Chang <tony@chromium.org>
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=18819
Pressing option+page{down,up} should move the cursor and scroll in
content editable areas. On other platforms, pressing page{down,up}
should move the cursor and scroll in content editable areas.
Test: editing/input/option-page-up-down.html
- editing/EditorCommand.cpp: (WebCore::verticalScrollDistance):
- 7:42 PM Changeset in webkit [55565] by
-
- 2 edits in trunk/WebKitTools
Find the framework relative to TARGET_BUILD_DIR as that has a more obvious value during production builds.
Rubber-stamped by Alice Liu.
- Scripts/check-for-webkit-framework-include-consistency:
- 5:33 PM Changeset in webkit [55564] by
-
- 18 edits2 adds in trunk
2010-03-03 Oliver Hunt <oliver@apple.com>
Reviewed by Gavin Barraclough.
Allow static property getters to interact with JSCs caching
https://bugs.webkit.org/show_bug.cgi?id=35716
Add new opcodes for handling cached lookup of static value getters.
More or less the same as with JS getters, all that changes is that
instead of calling through a JSFunction we always know that we have
a C function to call.
For the patching routines in the JIT we now need to pass a few
new parameters to allow us to pass enough information to the stub
function to allow us to call the C function correctly. Logically
this shouldn't actually be necessary as all of these functions ignore
the identifier, but removing the ident parameter would require
somewhat involved changes to the way we implement getOwnPropertySlot,
etc.
- bytecode/CodeBlock.cpp: (JSC::CodeBlock::dump): (JSC::CodeBlock::derefStructures): (JSC::CodeBlock::refStructures):
- bytecode/Instruction.h: (JSC::Instruction::Instruction): (JSC::Instruction::):
- bytecode/Opcode.h:
- interpreter/Interpreter.cpp: (JSC::Interpreter::tryCacheGetByID): (JSC::Interpreter::privateExecute):
- jit/JIT.cpp: (JSC::JIT::privateCompileMainPass):
- jit/JIT.h: (JSC::JIT::compileGetByIdProto): (JSC::JIT::compileGetByIdSelfList): (JSC::JIT::compileGetByIdProtoList): (JSC::JIT::compileGetByIdChainList): (JSC::JIT::compileGetByIdChain):
- jit/JITPropertyAccess.cpp: (JSC::JIT::privateCompileGetByIdProto): (JSC::JIT::privateCompileGetByIdSelfList): (JSC::JIT::privateCompileGetByIdProtoList): (JSC::JIT::privateCompileGetByIdChainList): (JSC::JIT::privateCompileGetByIdChain):
- jit/JITPropertyAccess32_64.cpp: (JSC::JIT::privateCompileGetByIdProto): (JSC::JIT::privateCompileGetByIdSelfList): (JSC::JIT::privateCompileGetByIdProtoList): (JSC::JIT::privateCompileGetByIdChainList): (JSC::JIT::privateCompileGetByIdChain):
- jit/JITStubs.cpp: (JSC::JITThunks::tryCacheGetByID): (JSC::DEFINE_STUB_FUNCTION):
- jit/JITStubs.h: (JSC::):
- runtime/JSFunction.cpp: (JSC::JSFunction::getOwnPropertySlot):
- runtime/Lookup.h: (JSC::getStaticPropertySlot): (JSC::getStaticValueSlot):
- runtime/PropertySlot.h: (JSC::PropertySlot::): (JSC::PropertySlot::PropertySlot): (JSC::PropertySlot::cachedPropertyType): (JSC::PropertySlot::isCacheable): (JSC::PropertySlot::isCacheableValue): (JSC::PropertySlot::setValueSlot): (JSC::PropertySlot::setCacheableCustom): (JSC::PropertySlot::setGetterSlot): (JSC::PropertySlot::setCacheableGetterSlot): (JSC::PropertySlot::clearOffset): (JSC::PropertySlot::customGetter):
2010-03-03 Oliver Hunt <oliver@apple.com>
Reviewed by Gavin Barraclough.
Allow static property getters to interact with JSCs caching
https://bugs.webkit.org/show_bug.cgi?id=35716
Add tests to ensure nothing horrifying happens to static property
getters if they're in a path where we end up caching lookups.
- fast/js/pic/cached-named-property-getter-expected.txt: Added.
- fast/js/pic/cached-named-property-getter.html: Added.
2010-03-03 Oliver Hunt <oliver@apple.com>
Reviewed by Gavin Barraclough.
Allow static property getters to interact with JSCs caching
https://bugs.webkit.org/show_bug.cgi?id=35716
Update the obviously safe getters to allow caching
Test: fast/js/pic/cached-named-property-getter.html
- bridge/runtime_array.cpp: (JSC::RuntimeArray::getOwnPropertySlot):
- bridge/runtime_method.cpp: (JSC::RuntimeMethod::getOwnPropertySlot):
- 4:50 PM Changeset in webkit [55563] by
-
- 1 edit5 adds in trunk/WebKitTools
2010-03-04 Kent Tamura <tkent@chromium.org>
Reviewed by Dimitri Glazkov.
[DRT/Chromium] Add CppVariant and CppBoundClass
https://bugs.webkit.org/show_bug.cgi?id=35634
Add CppVariant and CppBoundClass classes, which are going to be
used by DumpRenderTree Chromium port. These files are based on:
- src/webkit/glue/cpp_variant.{cc,h} and
- src/webkit/glue/cpp_bound_class.{cc,h} of Chromium rev.40492.
- DumpRenderTree/chromium/CppBoundClass.cpp: Added.
- DumpRenderTree/chromium/CppBoundClass.h: Added.
- DumpRenderTree/chromium/CppVariant.cpp: Added.
- DumpRenderTree/chromium/CppVariant.h: Added.
- 4:29 PM Changeset in webkit [55562] by
-
- 2 edits in trunk/WebKitTools
Build fix for older versions of Ruby.
- Scripts/check-for-webkit-framework-include-consistency:
- 4:23 PM Changeset in webkit [55561] by
-
- 3 edits1 add in trunk
Add a script to verify that WebKit framework headers are internally consistent.
Reviewed by Sam Weinig.
WebKit:
- WebKit.xcodeproj/project.pbxproj: Run the script during the build and fail with
an error should the consistency check fail.
WebKitTools:
This script detects the following problematic situations:
- An exported WebKit header that includes a header from WebCore.
- An exported WebKit header that includes a header that does not exist in the WebKit framework.
- A public WebKit header that includes a private WebKit header.
- Scripts/check-for-webkit-framework-include-consistency: Added.
- 4:23 PM Changeset in webkit [55560] by
-
- 4 edits in trunk
<rdar://problem/7717249> DOMSVG.h includes a non-existent DOMSVGFEMorphologyElement.h
Reviewed by Sam Weinig.
WebCore:
- WebCore.xcodeproj/project.pbxproj: Copy DOMSVGFEMorphologyElement.h and DOMSVGFEMorphologyElementInternal.h
in to the framework wrapper.
WebKit/mac:
- MigrateHeaders.make: Migrate DOMSVGFEMorphologyElement.h and DOMSVGFEMorphologyElementInternal.h.
- 4:23 PM Changeset in webkit [55559] by
-
- 2 edits in trunk/WebKit/mac
Use a framework-style include to pull in WebInspector.h for consistency
with other parts of WebKit.
Reviewed by Sam Weinig.
- WebInspector/WebInspectorPrivate.h:
- 3:34 PM Changeset in webkit [55558] by
-
- 2 edits in trunk/WebKitTools
Making sure that the correct path is set before invoking
DumpRenderTree on cygwin.
Reviewed by Adam Roben.
https://bugs.webkit.org/show_bug.cgi?id=35768
- Scripts/run-webkit-tests:
- 3:29 PM Changeset in webkit [55557] by
-
- 3 edits18 adds in trunk
2010-03-04 James Robinson <jamesr@chromium.org>
Reviewed by Dimitri Glazkov.
Handles setting HTMLSelectElement.length with mutation handlers present
https://bugs.webkit.org/show_bug.cgi?id=33983
When setting an HTMLSelectElement's length attribute, option elements have to be added or removed to the select
as appropriate. This is a little tricky with mutation events since they might add, remove, or reorder elements
while option elements are being added or deleted.
Tests: fast/forms/select-set-length-optgroup.html
fast/forms/select-set-length-with-mutation-remove.html
fast/forms/select-set-length-with-mutation-reorder.html
fast/forms/select-set-length-with-mutation-reparent.html
fast/forms/select-set-length-with-mutation.html
fast/forms/select-set-length.html
- html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::setLength):
2010-03-04 James Robinson <jamesr@chromium.org>
Reviewed by Dimitri Glazkov.
Tests for setting an select's options.length attribute.
https://bugs.webkit.org/show_bug.cgi?id=33983
- fast/forms/script-tests/select-set-length-optgroup.js: Added.
- fast/forms/script-tests/select-set-length-with-mutation-remove.js: Added. (gc): (onRemove):
- fast/forms/script-tests/select-set-length-with-mutation-reorder.js: Added. (onRemove):
- fast/forms/script-tests/select-set-length-with-mutation-reparent.js: Added. (onRemove):
- fast/forms/script-tests/select-set-length-with-mutation.js: Added. (sel):
- fast/forms/script-tests/select-set-length.js: Added.
- fast/forms/select-set-length-expected.txt: Added.
- fast/forms/select-set-length-optgroup-expected.txt: Added.
- fast/forms/select-set-length-optgroup.html: Added.
- fast/forms/select-set-length-with-mutation-expected.txt: Added.
- fast/forms/select-set-length-with-mutation-remove-expected.txt: Added.
- fast/forms/select-set-length-with-mutation-remove.html: Added.
- fast/forms/select-set-length-with-mutation-reorder-expected.txt: Added.
- fast/forms/select-set-length-with-mutation-reorder.html: Added.
- fast/forms/select-set-length-with-mutation-reparent-expected.txt: Added.
- fast/forms/select-set-length-with-mutation-reparent.html: Added.
- fast/forms/select-set-length-with-mutation.html: Added.
- fast/forms/select-set-length.html: Added.
- 3:21 PM Changeset in webkit [55556] by
-
- 3 edits in trunk/WebCore
[Qt] Unreviewed buildfix after r55542 on Windows.
- WebCore.pro:
- plugins/win/PluginDatabaseWin.cpp removed.
- platform/win/WebCoreInstanceHandle.cpp added.
- platform/win/WebCoreInstanceHandle.cpp: Remove explicit qualification in namespace declaration to make gcc happy.
- 3:01 PM Changeset in webkit [55555] by
-
- 3 edits2 adds in trunk
2010-03-04 Nate Chapin <Nate Chapin>
Reviewed by Kenneth Rohde Christiansen.
Fix the case where we do a same document navigation, scroll,
then repeat the same document navigation. Currently, the second
navigation does nothing.
Test: fast/loader/repeat-same-document-navigation.html
- loader/FrameLoader.cpp: (WebCore::FrameLoader::loadInSameDocument): Call scrollToFragment() whether or not the hash changed.
- 2:44 PM QtWebKitBugs edited by
- (diff)
- 2:31 PM Changeset in webkit [55554] by
-
- 6 edits in trunk
2010-03-04 Simon Fraser <Simon Fraser>
Build fix.
const long long cMaxDistance = numeric_limits<long long>::max() created global
initializers at the call sites, so replace with an inline function.
- page/FocusController.cpp: (WebCore::updateFocusCandidateIfCloser):
- page/SpatialNavigation.cpp: (WebCore::distanceInDirection):
- page/SpatialNavigation.h: (WebCore::maxDistance): (WebCore::FocusCandidate::FocusCandidate):
- 2:29 PM QtWebKitBugs edited by
- Repeat reporting link. Fill out the crashes part (diff)
- 2:15 PM Changeset in webkit [55553] by
-
- 2 edits in trunk/WebKitTools
2010-03-04 Simon Fraser <Simon Fraser>
Build fix: add exceptions to the check-for-global-initializers script
for FocusController and SpatialNavigation, and improve the script
to actually print out the globals found.
- Scripts/check-for-global-initializers:
- 1:52 PM Changeset in webkit [55552] by
-
- 2 edits in trunk/WebCore
Unreviewed attempt to fix Windows build.
- page/SpatialNavigation.cpp:
(WebCore::spatialDistance):
- 1:40 PM Changeset in webkit [55551] by
-
- 2 edits in trunk/WebKitTools
2010-03-04 Dirk Pranke <dpranke@chromium.org>
Reviewed by Dimitri Glazkov.
Fix dangling reference to "port" instead of "self._port_obj" that
was preventing the http_server from starting on Windows.
- Scripts/webkitpy/layout_tests/port/http_server.py:
- 1:35 PM Changeset in webkit [55550] by
-
- 2 edits in trunk/WebCore
2010-03-04 Simon Fraser <Simon Fraser>
Build fix.
Delcare updateFocusCandidateIfCloser static to avoid warning.
- page/FocusController.cpp: (WebCore::updateFocusCandidateIfCloser):
- 1:11 PM Changeset in webkit [55549] by
-
- 7 edits in trunk
2010-03-04 Darin Fisher <darin@chromium.org>
Reviewed by Dmitry Titov.
[chromium] make history.{push,replace}State enabled at runtime
https://bugs.webkit.org/show_bug.cgi?id=35753
- bindings/generic/RuntimeEnabledFeatures.cpp:
- bindings/generic/RuntimeEnabledFeatures.h: (WebCore::RuntimeEnabledFeatures::setPushStateEnabled): (WebCore::RuntimeEnabledFeatures::pushStateEnabled): (WebCore::RuntimeEnabledFeatures::replaceStateEnabled):
- page/History.idl:
- 1:09 PM Changeset in webkit [55548] by
-
- 2 edits in trunk/WebCore
Unreviewed attempt to (again) fix Mac build.
- page/SpatialNavigation.cpp:
(WebCore::spatialDistance):
- 1:03 PM Changeset in webkit [55547] by
-
- 1 edit in trunk/WebCore/ChangeLog
Fix typos
- 1:02 PM Changeset in webkit [55546] by
-
- 3 edits2 adds in trunk
WebCore: Based on a pacth from Nick Jong.
Reviewed by Simon Fraser.
Improve selection in multi-column blocks when hitting points above or
below a column rect.
Test: fast/multicol/hit-test-above-or-below.html
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::adjustPointToColumnContents): If the point lies
within the horizontal range for a column, constrain it to the column (if
it is above) or the next column (if it is below).
LayoutTests: Added test for hit-testing points above or below the column rect.
Reviewed by Simon Fraser.
- fast/multicol/hit-test-above-or-below-expected.txt: Added.
- fast/multicol/hit-test-above-or-below.html: Added.
- 12:57 PM Changeset in webkit [55545] by
-
- 2 edits in trunk/WebCore
Attempt to fix Mac build.
Reviewed by Simon Frase.
- page/SpatialNavigation.cpp:
- 12:20 PM Changeset in webkit [55544] by
-
- 2 edits in trunk/WebCore
Add SpatialNavigation header and cpp to Mac XCode project file
Reviewed by Kenneth Christiansen.
Patch by Jesus Palencia <jesus.palencia@openbossa.org>
- WebCore.xcodeproj/project.pbxproj:
- 12:19 PM Changeset in webkit [55543] by
-
- 13 edits2 adds in trunk/WebCore
Extend keyboard navigation to allow directional navigation
https://bugs.webkit.org/show_bug.cgi?id=18662
Reviewed by Simon Fraser, Eric Seidel and Darin Adler.
Patch by Antonio Gomes <tonikitoo@webkit.org>
Based on the initial work of Marco Barisione <marco.barisione@collabora.co.uk>
This patch implements the core logic of the 'Spatial Navigation' feature [1].
It improves the accessibility support of WebCore by extending the basic keyboard
navigation currently available (based on Tab forward and backward) with the
addition of a two-dimensional directional navigation by using Left, Right, Up and
Down arrow keys to move to the "nearest" element in the corresponding direction.
Highlights:
- Feature is turned off by default in Settings. Port specific APIs need to be added for toggling it on/off.
- Only elements viewed in the current viewport can have focus move to it. If the "nearest" is not in viewport dimensions, then a scroll-in-direction action is performed.
- The layout tests added run on Qt's DRT only for now (skipped for Mac, Win and Gtk).
Known issues (to be covered in follow-up bugs):
- Add port specific hooks to each DRT to enable/disable Spatial Navigation.
- Support for spatial navigation through form elements (<input>, <select>, etc) is be added.
- Make navigation keys customizable. It currently works with arrows keys only (up, down, right and left).
- Make it support modifiers (Alt, Ctrl and Shift).
[1] http://en.wikipedia.org/wiki/Spatial_navigation
- Android.mk:
- GNUmakefile.am:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- page/EventHandler.cpp:
(WebCore::EventHandler::defaultKeyboardEventHandler):
(WebCore::EventHandler::focusDirectionForKey):
(WebCore::EventHandler::defaultArrowEventHandler):
- page/EventHandler.h:
- page/FocusController.cpp:
(WebCore::FocusController::advanceFocus):
(WebCore::FocusController::advanceFocusInDocumentOrder):
(WebCore::FocusController::advanceFocusDirectionally):
(WebCore::updateFocusCandidateIfCloser):
(WebCore::FocusController::findFocusableNodeInDirection):
(WebCore::FocusController::deepFindFocusableNodeInDirection):
- page/FocusController.h:
- page/FocusDirection.h:
(WebCore::):
- page/Settings.cpp:
(WebCore::Settings::Settings):
(WebCore::Settings::setSpatialNavigationEnabled):
- page/Settings.h:
(WebCore::Settings::isSpatialNavigationEnabled):
- page/SpatialNavigation.cpp: Added.
(WebCore::distanceInDirection):
(WebCore::renderRectRelativeToRootDocument):
(WebCore::alignmentForRects):
(WebCore::isHorizontalMove):
(WebCore::areRectsFullyAligned):
(WebCore::areRectsPartiallyAligned):
(WebCore::spatialDistance):
(WebCore::isRectInDirection):
(WebCore::hasOffscreenRect):
(WebCore::scrollInDirection):
(WebCore::isInRootDocument):
(WebCore::deflateIfOverlapped):
- page/SpatialNavigation.h: Added.
(WebCore::):
(WebCore::FocusCandidate::FocusCandidate):
- 12:08 PM Changeset in webkit [55542] by
-
- 10 edits2 adds1 delete in trunk
WebCore: This fixes the layering violation I committed yesterday by moving
Page::instanceHandle into its own file just in the WebCore
namespace.
Reviewed by Anders Carlsson.
Added WebCoreInstanceHandle.h + .cpp and removed PageWin.cpp
- WebCore.vcproj/WebCore.vcproj:
- page/win/PageWin.cpp: Removed.
Remove all instance handle code from Page.
- page/Page.h:
New files.
- platform/win/WebCoreInstanceHandle.cpp: Added.
- platform/win/WebCoreInstanceHandle.h: Added.
(WebCore::setInstanceHandle):
(WebCore::instanceHandle):
Switch to WebCore::instanceHandle() instead of
Page::instanceHandle() and include the new header.
- platform/graphics/win/WKCACFLayerRenderer.cpp:
(WebCore::WKCACFLayerRenderer::acceleratedCompositingAvailable):
- platform/win/PasteboardWin.cpp:
(WebCore::Pasteboard::Pasteboard):
- platform/win/PopupMenuWin.cpp:
(WebCore::PopupMenu::show):
(WebCore::PopupMenu::registerClass):
- platform/win/SharedTimerWin.cpp:
(WebCore::initializeOffScreenTimerWindow):
- plugins/win/PluginViewWin.cpp:
(WebCore::registerPluginView):
(WebCore::PluginView::platformStart):
WebKit/win: WebCore::Page::setInstanceHandle() is now just
WebCore::setInstanceHandle()
Reviewed by Anders Carlsson.
- WebKitDLL.cpp:
(DllMain):
- 11:30 AM Changeset in webkit [55541] by
-
- 6 edits in trunk
2010-03-04 Diego Gonzalez <diego.gonzalez@openbossa.org>
Reviewed by Simon Hausmann.
Make Qt DumpRenderTree EventSender able to send double click events
LayoutTests:
fast/events/dblclick-addEventListener.html
[Qt] DRT: Send double click event from EventSender
https://bugs.webkit.org/show_bug.cgi?id=35255
- platform/qt/Skipped:
2010-03-04 Diego Gonzalez <diego.gonzalez@openbossa.org>
Reviewed by Simon Hausmann.
Make Qt DumpRenderTree EventSender able to send double click events
LayoutTests:
fast/events/dblclick-addEventListener.html
[Qt] DRT: Send double click event from EventSender
https://bugs.webkit.org/show_bug.cgi?id=35255
- DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
- DumpRenderTree/qt/EventSenderQt.cpp: (EventSender::EventSender): (EventSender::mouseDown):
- DumpRenderTree/qt/EventSenderQt.h: (EventSender::resetClickCount):
- 11:15 AM Changeset in webkit [55540] by
-
- 2 edits in trunk/WebCore
[Gtk] Unreviewed build fix.
Patch by Antonio Gomes <tonikitoo@webkit.org>
'glib_file_name' renamed to 'gligFileName'.
- platform/graphics/gtk/ImageGtk.cpp:
(WebCore::Image::loadPlatformResource):
- 11:12 AM Changeset in webkit [55539] by
-
- 2 edits in trunk/WebKit/qt
2010-03-04 Simon Hausmann <simon.hausmann@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] qwebelement.h does not include QtCore headers correctly
https://bugs.webkit.org/show_bug.cgi?id=35748
The header files of QtCore must be included as QtCore/foo.h.
- Api/qwebelement.h:
- 11:03 AM Changeset in webkit [55538] by
-
- 2 edits in trunk/WebKit/chromium
2010-03-04 Pavel Feldman <pfeldman@chromium.org>
Not reviewed: chromium tests fix.
- src/js/Tests.js:
- 10:56 AM Changeset in webkit [55537] by
-
- 15 edits in trunk
2010-03-04 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: Remove two last synchronous calls from front-end to InspectorBackend.
- inspector/InspectorBackend.cpp: (WebCore::InspectorBackend::enableSearchingForNode): (WebCore::InspectorBackend::disableSearchingForNode): (WebCore::InspectorBackend::setPauseOnExceptionsState):
- inspector/InspectorBackend.h:
- inspector/InspectorBackend.idl:
- inspector/InspectorController.cpp: (WebCore::InspectorController::setWindowVisible): (WebCore::InspectorContorller::setSearchingForNode): (WebCore::InspectorController::populateScriptObjects):
- inspector/InspectorController.h:
- inspector/InspectorFrontend.cpp: (WebCore::InspectorFrontend::searchingForNodeWasEnabled): (WebCore::InspectorFrontend::searchingForNodeWasDisabled): (WebCore::InspectorFrontend::updatePauseOnExceptionsState):
- inspector/InspectorFrontend.h:
- inspector/front-end/ElementsPanel.js: (WebInspector.ElementsPanel): (WebInspector.ElementsPanel.prototype.get statusBarItems): (WebInspector.ElementsPanel.prototype.hide): (WebInspector.ElementsPanel.prototype.reset): (WebInspector.ElementsPanel.prototype.searchingForNodeWasEnabled): (WebInspector.ElementsPanel.prototype.searchingForNodeWasDisabled): (WebInspector.ElementsPanel.prototype._nodeSearchButtonClicked):
- inspector/front-end/InspectorBackendStub.js: (.WebInspector.InspectorBackendStub.prototype.enableSearchingForNode): (.WebInspector.InspectorBackendStub.prototype.disableSearchingForNode): (.WebInspector.InspectorBackendStub.prototype.setPauseOnExceptionsState):
- inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel): (WebInspector.ScriptsPanel.prototype.get statusBarItems): (WebInspector.ScriptsPanel.prototype.updatePauseOnExceptionsState): (WebInspector.ScriptsPanel.prototype._updateDebuggerButtons): (WebInspector.ScriptsPanel.prototype._togglePauseOnExceptions):
- inspector/front-end/inspector.js: (WebInspector.searchingForNodeWasEnabled): (WebInspector.searchingForNodeWasDisabled): (WebInspector.updatePauseOnExceptionsState): WebKit/chromium:
- src/js/InspectorControllerImpl.js: (devtools.InspectorBackendImpl):
- 10:48 AM Changeset in webkit [55536] by
-
- 3 edits in trunk/WebCore
2010-03-04 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: Clicking on an error should take me to the error
- inspector/front-end/ResourceView.js: (WebInspector.ResourceView): (WebInspector.ResourceView.prototype._selectTab): (WebInspector.ResourceView.prototype.selectContentTab):
- inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel.prototype.showResource):
- 10:46 AM Changeset in webkit [55535] by
-
- 12 edits in trunk
2010-03-04 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: Remove sync access to resourceTrackingEnabled.
- inspector/InspectorBackend.cpp:
- inspector/InspectorBackend.h:
- inspector/InspectorBackend.idl:
- inspector/InspectorController.cpp: (WebCore::InspectorController::populateScriptObjects):
- inspector/front-end/AuditsPanel.js: (WebInspector.AuditsPanel.prototype._reloadResources): (WebInspector.AuditsPanel.prototype.show):
- inspector/front-end/InspectorBackendStub.js: (.WebInspector.InspectorBackendStub): (.WebInspector.InspectorBackendStub.prototype.enableResourceTracking): (.WebInspector.InspectorBackendStub.prototype.disableResourceTracking): (.WebInspector.InspectorBackendStub.prototype.enableDebugger): (.WebInspector.InspectorBackendStub.prototype.disableDebugger): (.WebInspector.InspectorBackendStub.prototype.enableProfiler): (.WebInspector.InspectorBackendStub.prototype.disableProfiler):
- inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel): (WebInspector.ResourcesPanel.prototype.get resourceTrackingEnabled): (WebInspector.ResourcesPanel.prototype.get visibleView): (WebInspector.ResourcesPanel.prototype.resourceTrackingWasEnabled): (WebInspector.ResourcesPanel.prototype.resourceTrackingWasDisabled): (WebInspector.ResourcesPanel.prototype.reset): (WebInspector.ResourcesPanel.prototype.showResource): (WebInspector.ResourcesPanel.prototype._enableResourceTracking): (WebInspector.ResourcesPanel.prototype._toggleResourceTracking):
- 10:43 AM Changeset in webkit [55534] by
-
- 1 edit in trunk/LayoutTests/fast/dom/Window/slow-unload-handler-expected.txt
Update test expectations from my recent checkin
- 10:43 AM Changeset in webkit [55533] by
-
- 5 edits in trunk/LayoutTests
Committed by Chang Shu: commit manually for bug 35687.
- 10:17 AM Changeset in webkit [55532] by
-
- 3 edits2 adds in trunk
2010-03-04 Antoine Quint <ml@graougraou.com>
Reviewed by Darin Adler.
DOM insertion mutation events should dispatch after a node is attached to the render tree
https://bugs.webkit.org/show_bug.cgi?id=35590
- fast/events/domnodeinsertedintodocument-dispatched-post-rendering-expected.txt: Added.
- fast/events/domnodeinsertedintodocument-dispatched-post-rendering.html: Added.
2010-03-04 Antoine Quint <ml@graougraou.com>
Reviewed by Darin Adler.
DOM insertion mutation events should dispatch after a node is attached to the render tree
https://bugs.webkit.org/show_bug.cgi?id=35590
Test: fast/events/domnodeinsertedintodocument-dispatched-post-rendering.html
Split off the internal-to-WebCore node insertion notification code from the DOM mutation
event dispatching, originally in dispatchChildInsertionEvents(), to a new static function
called notifyChildInserted(). This allows us to dispatch the mutation events at a later
time upon insertion of a child into to the tree, specifically _after_ attachment to the render
tree.
- dom/ContainerNode.cpp: (WebCore::ContainerNode::insertBefore): (WebCore::ContainerNode::replaceChild): (WebCore::ContainerNode::appendChild): (WebCore::notifyChildInserted): (WebCore::dispatchChildInsertionEvents):
- 10:00 AM Changeset in webkit [55531] by
-
- 2 edits in trunk/WebCore
2010-03-04 Fridrich Strba <fridrich.strba@bluewin.ch>
Reviewed by Holger Freyther.
Make paths relocatable on runtime on Windows
https://bugs.webkit.org/show_bug.cgi?id=32711
- platform/graphics/gtk/ImageGtk.cpp: (get_webkit_datadir): (WebCore::Image::loadPlatformResource):
- 9:35 AM Changeset in webkit [55530] by
-
- 5 edits in trunk/WebCore
2010-03-04 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: Popup for Timeline panel will work in a tooltip mode
- inspector/front-end/Popover.js: (WebInspector.Popover): (WebInspector.Popover.prototype.show): (WebInspector.Popover.prototype.hide): (WebInspector.Popover.prototype._positionElement): (WebInspector.PopoverHelper): (WebInspector.PopoverHelper.prototype._mouseDown): (WebInspector.PopoverHelper.prototype._mouseMove.doHide): (WebInspector.PopoverHelper.prototype._mouseMove): (WebInspector.PopoverHelper.prototype._resetHoverTimer): (WebInspector.PopoverHelper.prototype.hidePopup): (WebInspector.PopoverHelper.prototype._mouseHover): (WebInspector.PopoverHelper.prototype._killHidePopupTimer):
- inspector/front-end/TimelineOverviewPane.js: (WebInspector.TimelineOverviewPane.prototype.reset):
- inspector/front-end/TimelinePanel.js: (WebInspector.TimelinePanel): (WebInspector.TimelinePanel.prototype.get _recordStyles): (WebInspector.TimelinePanel.prototype._innerAddRecordToTimeline): (WebInspector.TimelinePanel.prototype._scheduleRefresh): (WebInspector.TimelinePanel.prototype._refreshRecords): (WebInspector.TimelinePanel.prototype._adjustScrollPosition): (WebInspector.TimelinePanel.prototype._getPopoverAnchor): (WebInspector.TimelinePanel.prototype._showPopover): (WebInspector.TimelinePanel.prototype._closeRecordDetails): (WebInspector.TimelineRecordListRow): (WebInspector.TimelineRecordListRow.prototype.update): (WebInspector.TimelineRecordGraphRow): (WebInspector.TimelineRecordGraphRow.prototype._onClick): (WebInspector.TimelinePanel.FormattedRecord): (WebInspector.TimelinePanel.FormattedRecord.prototype._createCell): (WebInspector.TimelinePanel.FormattedRecord.prototype._createRow): (WebInspector.TimelinePanel.FormattedRecord.prototype._createLinkRow): (WebInspector.TimelinePanel.FormattedRecord.prototype._generatePopupContent): (WebInspector.TimelinePanel.FormattedRecord.prototype._getRecordDetails):
- inspector/front-end/inspector.css:
- 9:25 AM Changeset in webkit [55529] by
-
- 2 edits in trunk/WebKit/mac
REGRESSION (31281): -[WebArchive initWithCoder:] leaks
<rdar://problem/7702420> and https://bugs.webkit.org/show_bug.cgi?id=35534
Reviewed by Geoff Garen.
- WebView/WebArchive.mm:
(-[WebArchive initWithCoder:]): Don't retain objects we don't own.
- 9:18 AM Changeset in webkit [55528] by
-
- 2 edits in trunk/WebCore
2010-03-04 Laszlo Gombos <Laszlo Gombos>
Unreviewed build fix.
Build fix after r55464.
No new tests, no new functionality.
- inspector/InspectorController.cpp: (WebCore::InspectorController::populateScriptObjects):
- 8:14 AM Changeset in webkit [55527] by
-
- 2 edits in trunk/LayoutTests
Unreviewed.
[Qt] storage/open-database-creation-callback-isolated-world.html was removed
from tree by r55488, so it should be removed from Qt Skipped list too.
- platform/qt/Skipped: storage/open-database-creation-callback-isolated-world.html removed.
- 7:41 AM Changeset in webkit [55526] by
-
- 1 edit7 adds in trunk/WebCore
2010-03-04 Leandro Pereira <leandro@profusion.mobi>
Reviewed by Kenneth Rohde Christiansen.
Add EFL port files to platform/graphics/efl.
http://webkit.org/b/35539
- platform/graphics/efl/FloatRectEfl.cpp: Added.
- platform/graphics/efl/FontEfl.cpp: Added.
- platform/graphics/efl/IconEfl.cpp: Added.
- platform/graphics/efl/ImageEfl.cpp: Added.
- platform/graphics/efl/IntPointEfl.cpp: Added.
- platform/graphics/efl/IntRectEfl.cpp: Added.
- 7:25 AM Changeset in webkit [55525] by
-
- 1 edit2 adds in trunk/WebCore
2010-03-04 Leandro Pereira <leandro@profusion.mobi>
Reviewed by Kenneth Rohde Christiansen.
Add EFL port files to platform/text/efl.
http://webkit.org/b/35740
- platform/text/efl/TextBreakIteratorInternalICUEfl.cpp: Added.
- 7:03 AM Changeset in webkit [55524] by
-
- 4 edits in trunk
2010-03-04 Fridrich Strba <fridrich.strba@bluewin.ch>
Reviewed by Holger Freyther.
https://bugs.webkit.org/show_bug.cgi?id=35726
Remove orphaned #ifdef WTF_USE_GLIB_ICU_UNICODE_HYBRID
Removing orphaned #if USE.
- GNUmakefile.am:
2010-03-04 Fridrich Strba <fridrich.strba@bluewin.ch>
Reviewed by Holger Freyther.
https://bugs.webkit.org/show_bug.cgi?id=35726
Remove orphaned #ifdef WTF_USE_GLIB_ICU_UNICODE_HYBRID
Removing orphaned #if USE.
- platform/ThreadGlobalData.h:
- 6:24 AM Changeset in webkit [55523] by
-
- 3 edits in trunk/WebCore
Trottle sync requests sent to the LocalStorage background thread
https://bugs.webkit.org/show_bug.cgi?id=34943
Reviewed by Darin Fisher.
Currently, once a second LocalStorage takes all keys/values which have
been changed and sends them to a background thread to sync. The problem
is that this background thread can get overwhelmed and stop being
responsive. This means that if any other page tries to start using
LocalStorage (and thus initiates the initial import) that'll block on
all the previous syncs completing.
To mitigate this, I'm adding code so that we never schedule another
sync task when another is still running. In order to keep the sync
tasks from growing exponentially when they do take longer than the
storage sync interval, I've also added a basic rate limiter. No effort
is made to ensure fairness/ordering of what gets synced nor is there
any way for this rate to be changed because most normal uses of
LocalStorage really shouldn't be hitting these types of limits anyway.
The only behavioral change that's observible in JavaScript is time based
and thus it's not practical to make new tests that aren't racy. The
existing layout tests cover LocalStorage pretty well, though.
- storage/StorageAreaSync.cpp:
(WebCore::StorageAreaSync::StorageAreaSync):
(WebCore::StorageAreaSync::scheduleFinalSync):
(WebCore::StorageAreaSync::syncTimerFired):
(WebCore::StorageAreaSync::performSync):
- storage/StorageAreaSync.h:
- 6:00 AM Changeset in webkit [55522] by
-
- 27 edits2 copies1 add in trunk
2010-03-04 Andrey Kosyakov <caseq@chromium.org>
Reviewed by Pavel Feldman.
Added support for worker instrumentation in inspector
(display list of active workers, allow debugging of workers
by injecting fake JS implementation)
- English.lproj/localizedStrings.js:
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- bindings/js/JSInjectedScriptHostCustom.cpp: (WebCore::InjectedScriptHost::createInjectedScript): (WebCore::InjectedScriptHost::injectedScriptFor):
- bindings/v8/custom/V8InjectedScriptHostCustom.cpp: (WebCore::InjectedScriptHost::createInjectedScript): (WebCore::InjectedScriptHost::injectedScriptFor):
- dom/Document.cpp: (WebCore::Document::inspectorController):
- dom/Document.h:
- dom/ScriptExecutionContext.h: (WebCore::ScriptExecutionContext::inspectorController):
- inspector/InjectedScriptHost.cpp: (WebCore::InjectedScriptHost::InjectedScriptHost): (WebCore::InjectedScriptHost::injectScript): (WebCore::InjectedScriptHost::nextWorkerId): (WebCore::InjectedScriptHost::didCreateWorker): (WebCore::InjectedScriptHost::willDestroyWorker):
- inspector/InjectedScriptHost.h:
- inspector/InjectedScriptHost.idl:
- inspector/InspectorController.cpp: (WebCore::InspectorController::populateScriptObjects): (WebCore::InspectorController::resetScriptObjects): (WebCore::InspectorController::didCommitLoad): (WebCore::InspectorController::didCreateWorker): (WebCore::InspectorController::willDestroyWorker):
- inspector/InspectorController.h:
- inspector/InspectorFrontend.cpp: (WebCore::InspectorFrontend::didCreateWorker): (WebCore::InspectorFrontend::willDestroyWorker):
- inspector/InspectorFrontend.h:
- inspector/InspectorWorkerResource.h: Added. (WebCore::InspectorWorkerResource::create): (WebCore::InspectorWorkerResource::id): (WebCore::InspectorWorkerResource::url): (WebCore::InspectorWorkerResource::isSharedWorker): (WebCore::InspectorWorkerResource::InspectorWorkerResource):
- inspector/front-end/Checkbox.js: Added. (WebInspector.Checkbox.callbackWrapper): (WebInspector.Checkbox): (WebInspector.Checkbox.prototype.checked):
- inspector/front-end/InjectedFakeWorker.js: (InjectedFakeWorker.FakeWorker): (InjectedFakeWorker.FakeWorker.prototype.terminate): (InjectedFakeWorker.FakeWorker.prototype._handleException): (InjectedFakeWorker.FakeWorker.prototype._importScripts): (InjectedFakeWorker.FakeWorker.prototype._loadScript): (InjectedFakeWorker.FakeWorker.prototype._expandURLAndCheckOrigin):
- inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel): (WebInspector.ScriptsPanel.prototype.debuggerWasEnabled): (WebInspector.ScriptsPanel.prototype.debuggerWasDisabled): (WebInspector.ScriptsPanel.prototype.reset):
- inspector/front-end/WebKit.qrc:
- inspector/front-end/WorkersSidebarPane.js: Added. (WebInspector.WorkersSidebarPane): (WebInspector.WorkersSidebarPane.prototype.addWorker): (WebInspector.WorkersSidebarPane.prototype.removeWorker): (WebInspector.WorkersSidebarPane.prototype.setInstrumentation): (WebInspector.WorkersSidebarPane.prototype.reset): (WebInspector.WorkersSidebarPane.prototype._onTriggerInstrument): (WebInspector.Worker): (WebInspector.didCreateWorker): (WebInspector.willDestroyWorker):
- inspector/front-end/inspector.css:
- inspector/front-end/inspector.html:
- workers/AbstractWorker.cpp: (WebCore::AbstractWorker::AbstractWorker): (WebCore::AbstractWorker::~AbstractWorker): (WebCore::AbstractWorker::onDestroyWorker): (WebCore::AbstractWorker::contextDestroyed):
- workers/AbstractWorker.h: (WebCore::AbstractWorker::id):
- workers/SharedWorker.cpp: (WebCore::SharedWorker::SharedWorker):
- workers/Worker.cpp: (WebCore::Worker::Worker):
- 5:58 AM Changeset in webkit [55521] by
-
- 2 edits in trunk/JavaScriptCore
2010-03-04 Shinichiro Hamaji <hamaji@chromium.org>
Unreviewed. Remove a non-ASCII character introduced in the following bug.
put_by_id does will incorrectly cache writes where a specific value exists, where at the point of caching the same value is being written.
https://bugs.webkit.org/show_bug.cgi?id=35537
- runtime/JSObject.h: (JSC::JSObject::putDirectInternal):
- 5:39 AM Changeset in webkit [55520] by
-
- 27 edits in trunk
[Qt] Make the OUTPUT_DIR variable in qmake projects independent of build-webkit's logic.
Reviewed by Tor Arne Vestbø.
This also allows shadow builds relying only on qmake to work properly.
.:
- WebKit.pri:
- jsc.pro:
- qt/api/QtScript.pro:
- qt/tests/qscriptengine/qscriptengine.pro:
- qt/tests/qscriptvalue/qscriptvalue.pro:
- qt/tests/tests.pri:
WebCore:
- WebCore.pro:
WebKit\qt:
- tests/benchmarks/loading/loading.pro:
- tests/benchmarks/painting/painting.pro:
- tests/hybridPixmap/hybridPixmap.pro:
- tests/qgraphicswebview/qgraphicswebview.pro:
- tests/qwebelement/qwebelement.pro:
- tests/qwebframe/qwebframe.pro:
- tests/qwebhistory/qwebhistory.pro:
- tests/qwebhistoryinterface/qwebhistoryinterface.pro:
- tests/qwebinspector/qwebinspector.pro:
- tests/qwebpage/qwebpage.pro:
- tests/qwebplugindatabase/qwebplugindatabase.pro:
WebKitTools:
- DumpRenderTree/qt/DumpRenderTree.pro:
- DumpRenderTree/qt/ImageDiff.pro:
- DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
- QtLauncher/QtLauncher.pro:
- 5:17 AM QtWebKitBugs edited by
- (diff)
- 4:46 AM Changeset in webkit [55519] by
-
- 2 edits in trunk/WebKitTools
Enable to use built-product-archive on Qt platform.
Patch by Gabor Rapcsanyi <rgabor@inf.u-szeged.hu> on 2010-03-04
Reviewed by Kenneth Rohde Christiansen.
- BuildSlaveSupport/built-product-archive:
- 4:29 AM Changeset in webkit [55518] by
-
- 2 edits in trunk/WebCore
[Qt] Avoid calling QFont::detach too often from FontQt
https://bugs.webkit.org/show_bug.cgi?id=35569
The letter- and wordspacing is inside the WebCore::Font class,
our QFont is located in the WebCore::FontPlatformData. Everytime
we need to use a QFont inside WebCore::Font we are calling the
font method which gets the QFont from the WebCore::FontPlatformData
and is applying the letter- and wordspacing. Internally this
will attempt to detach the QFont...
Avoid calling setLetterSpacing and setWordSpacing on QFont if
the WebCore::Font has the default applied.
- platform/graphics/qt/FontQt.cpp:
(WebCore::Font::font):
- 4:21 AM Changeset in webkit [55517] by
-
- 4 edits in trunk/WebCore
2010-03-04 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: Nothing happens on navigation to resource via a link if resource tracking is disabled
https://bugs.webkit.org/show_bug.cgi?id=35574
- English.lproj/localizedStrings.js:
- inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel.prototype.canShowSourceLine): (WebInspector.ResourcesPanel.prototype._toggleResourceTracking):
- inspector/front-end/inspector.js: (WebInspector.documentMouseOver): (WebInspector.documentMouseOut): (WebInspector.hideBadLinkPopupIfNecessary): (WebInspector.documentClick.followLink): (WebInspector.documentClick): (WebInspector.showBadLinkPopup.popupOverOut): (WebInspector.showBadLinkPopup): (WebInspector.addMainEventListeners):
- 3:04 AM Changeset in webkit [55516] by
-
- 2 edits in trunk/LayoutTests
Rubber-stamped by Kenneth Rohde Christiansen.
[Qt] DRT is failing on new test introduced in r55499
Skipping it until fix.
https://bugs.webkit.org/show_bug.cgi?id=35729
- platform/qt/Skipped: fast/events/zoom-dblclick.html skipped
- 2:45 AM Changeset in webkit [55515] by
-
- 2 edits in trunk/WebKit/qt
[Qt] Fix generation of forwaring headers
Reviewed by Kenneth Rohde Christiansen.
The dependencies were a bit wrong, so we ended up not generating
forwarding headers for qwebkitversion.h and qwebkitglobal.h
The forwardning headers are now the only targets depending on the
real headers. All other targets either depend on the generated
class headers, or the forwarding headers.
- Api/DerivedSources.pro:
- 1:41 AM Changeset in webkit [55514] by
-
- 5 edits in trunk
2010-03-04 Vangelis Kokkevis <vangelis@chromium.org>
Reviewed by Oliver Hunt.
Update existing test to check that getUniformLocation() returns
null if the uniform requested is not found.
https://bugs.webkit.org/show_bug.cgi?id=34669
- fast/canvas/webgl/script-tests/uniform-location.js:
- fast/canvas/webgl/uniform-location-expected.txt:
2010-03-04 Vangelis Kokkevis <vangelis@chromium.org>
Reviewed by Oliver Hunt.
getUniformLocation() now returns null if uniform requested
is not found.
https://bugs.webkit.org/show_bug.cgi?id=34669
Test:LayoutTests/fast/canvas/webgl/uniform-location.html
(added missing test)
- html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::getUniformLocation):
- 1:24 AM Changeset in webkit [55513] by
-
- 4 edits in trunk
2010-03-04 John Abd-El-Malek <jam@chromium.org>
Reviewed by Adam Barth.
Fix incorrect setup of DateExtension.
https://bugs.webkit.org/show_bug.cgi?id=35710
- fast/dom/Window/resources/slow_unload_handler1.html:
2010-03-04 John Abd-El-Malek <jam@chromium.org>
Reviewed by Adam Barth.
Fix incorrect setup of DateExtension.
https://bugs.webkit.org/show_bug.cgi?id=35710
- bindings/v8/DateExtension.cpp: (WebCore::DateExtension::setAllowSleep):
- 1:13 AM Changeset in webkit [55512] by
-
- 2 edits in trunk/WebKit/chromium
2010-03-04 Darin Fisher <darin@chromium.org>
Reviewed by Pavel Feldman.
Fix failing DevToolsSanityTest.TestResourceContentLength
https://bugs.webkit.org/show_bug.cgi?id=35725
http://trac.webkit.org/changeset/55466 missed one more spot
where contentLength needed to be renamed resourceSize.
- src/js/Tests.js:
- 12:57 AM Changeset in webkit [55511] by
-
- 4 edits10 adds in trunk
2010-03-04 Oliver Hunt <oliver@apple.com>
Reviewed by Maciej Stachowiak.
https://bugs.webkit.org/show_bug.cgi?id=35603
SVG incorrectly allows nested <use> elements in a <use> shadow tree
Simplify the handling of invalid or missing use-targets by cloning them
to empty <g> elements rather than just allowing the <use> element to
be copied into the shadow tree, as this violates a number of assumptions
in the shadow tree handling code.
Tests: svg/custom/use-nested-disallowed-target.svg
svg/custom/use-nested-missing-target-added.svg
svg/custom/use-nested-missing-target-removed.svg
svg/custom/use-nested-missing-target.svg
svg/custom/use-nested-notarget.svg
- svg/SVGUseElement.cpp: (WebCore::SVGUseElement::buildPendingResource): (WebCore::SVGUseElement::buildShadowAndInstanceTree): (WebCore::SVGUseElement::expandUseElementsInShadowTree):
2010-03-04 Oliver Hunt <oliver@apple.com>
Reviewed by Maciej Stachowiak.
https://bugs.webkit.org/show_bug.cgi?id=35603
SVG incorrectly allows nested <use> elements in a <use> shadow tree
Add test cases for various combinations of <use> and targets that aren't present.
- platform/mac/svg/custom/use-empty-reference-expected.txt: Added.
- svg/custom/use-nested-disallowed-target-expected.txt: Added.
- svg/custom/use-nested-disallowed-target.svg: Added.
- svg/custom/use-nested-missing-target-added-expected.txt: Added.
- svg/custom/use-nested-missing-target-added.svg: Added.
- svg/custom/use-nested-missing-target-expected.txt: Added.
- svg/custom/use-nested-missing-target-removed-expected.txt: Added.
- svg/custom/use-nested-missing-target-removed.svg: Added.
- svg/custom/use-nested-missing-target.svg: Added.
- svg/custom/use-nested-notarget-expected.txt: Added.
- svg/custom/use-nested-notarget.svg: Added.
- 12:51 AM Changeset in webkit [55510] by
-
- 2 edits7 moves in trunk/WebCore
2010-03-04 Leandro Pereira <leandro@profusion.mobi>
Reviewed by Gustavo Noronha Silva.
Move Cairo-related font code from platform/graphics/gtk to
platform/graphics/cairo, so other ports may use them.
http://webkit.org/b/35539
- GNUmakefile.am:
- platform/graphics/cairo/FontCacheCairo.cpp: Copied from WebCore/platform/graphics/gtk/FontCacheGtk.cpp.
- platform/graphics/cairo/FontCustomPlatformData.cpp: Copied from WebCore/platform/graphics/gtk/FontCustomPlatformData.cpp.
- platform/graphics/cairo/FontCustomPlatformData.h: Copied from WebCore/platform/graphics/gtk/FontCustomPlatformData.h.
- platform/graphics/cairo/FontPlatformData.h: Copied from WebCore/platform/graphics/gtk/FontPlatformData.h.
- platform/graphics/cairo/FontPlatformDataCairo.cpp: Copied from WebCore/platform/graphics/gtk/FontPlatformDataGtk.cpp.
- platform/graphics/cairo/GlyphPageTreeNodeCairo.cpp: Copied from WebCore/platform/graphics/gtk/GlyphPageTreeNodeGtk.cpp.
- platform/graphics/cairo/SimpleFontDataCairo.cpp: Copied from WebCore/platform/graphics/gtk/SimpleFontDataGtk.cpp.
- platform/graphics/gtk/FontCacheGtk.cpp: Removed.
- platform/graphics/gtk/FontCustomPlatformData.cpp: Removed.
- platform/graphics/gtk/FontCustomPlatformData.h: Removed.
- platform/graphics/gtk/FontPlatformData.h: Removed.
- platform/graphics/gtk/FontPlatformDataGtk.cpp: Removed.
- platform/graphics/gtk/GlyphPageTreeNodeGtk.cpp: Removed.
- platform/graphics/gtk/SimpleFontDataGtk.cpp: Removed.
- 12:34 AM Changeset in webkit [55509] by
-
- 4 edits2 adds in trunk
2010-03-04 Evan Stade <estade@chromium.org>
Reviewed by David Levin.
https://bugs.webkit.org/show_bug.cgi?id=35261
[skia] crash when attempting to render certain SVGs with Skia
This test passes if it doesn't crash.
- platform/mac/Skipped: Skip the test on Mac, where it crashes.
- svg/custom/tiling-regular-hexagonal-crash-expected.txt: Added.
- svg/custom/tiling-regular-hexagonal-crash.svg: Added.
2010-03-04 Evan Stade <estade@chromium.org>
Reviewed by David Levin.
https://bugs.webkit.org/show_bug.cgi?id=35261
[skia] crash when attempting to render certain SVGs
This fixes the crash, but the SVG still doesn't render properly.
Test: svg/custom/tiling-regular-hexagonal-crash.svg
- platform/graphics/skia/ImageSkia.cpp: (WebCore::BitmapImageSingleFrameSkia::create): don't return 0 when the copy fails; instead return a blank bitmap. The caller doesn't check for 0 before dereferencing.
- 12:03 AM Changeset in webkit [55508] by
-
- 2 edits in trunk/WebCore
2010-03-04 Tony Chang <tony@chromium.org>
Reviewed by Darin Fisher.
Initialize m_isMultipartPayload in other ResourceResponse ctor.
In r55451 (bug 35628) I added an extra bool, but only initialized
it in one constructor.
https://bugs.webkit.org/show_bug.cgi?id=35719
- platform/network/chromium/ResourceResponse.h: (WebCore::ResourceResponse::ResourceResponse):
- 12:01 AM Changeset in webkit [55507] by
-
- 2 edits1 add in trunk/WebKit/chromium
2010-03-03 Garret Kelly <gdk@chromium.org>
Reviewed by Darin Fisher.
Adding touch event type and point type. Tested against the try bots.
https://bugs.webkit.org/show_bug.cgi?id=35691
- public/WebInputEvent.h: (WebKit::WebInputEvent::): (WebKit::WebInputEvent::isTouchEventType): (WebKit::WebTouchEvent::WebTouchEvent):
- public/WebTouchPoint.h: Added. (WebKit::WebTouchPoint::WebTouchPoint): (WebKit::WebTouchPoint::):
Mar 3, 2010:
- 11:18 PM Changeset in webkit [55506] by
-
- 1 edit in trunk/WebKit/win/Interfaces/WebKit.idl
Touch WebKit.idl to force a rebuild of Interfaces
- 10:10 PM Changeset in webkit [55505] by
-
- 9 edits2 adds in trunk/WebCore
2010-03-03 Yuta Kitamura <yutak@chromium.org>
Reviewed by Alexey Proskuryakov.
Add a new class that stores information about Web Socket handshake request.
Instances of this class contain the necessary information to send a Web Socket
handshake request. In the future, this class will provide request information
to the Web Inspector.
WebSocketHandshake needs to provide request information
https://bugs.webkit.org/show_bug.cgi?id=34784
No new tests, since the current tests will suffice (LayoutTests/websocket/*).
- GNUmakefile.am:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- websockets/WebSocketChannel.cpp:
- websockets/WebSocketHandshake.cpp: (WebCore::WebSocketHandshake::clientHandshakeMessage): (WebCore::WebSocketHandshake::clientHandshakeRequest):
- websockets/WebSocketHandshake.h:
- websockets/WebSocketHandshakeRequest.cpp: Added. (WebCore::WebSocketHandshakeRequest::WebSocketHandshakeRequest): (WebCore::WebSocketHandshakeRequest::~WebSocketHandshakeRequest): (WebCore::WebSocketHandshakeRequest::addExtraHeaderField): (WebCore::WebSocketHandshakeRequest::headerFields): (WebCore::WebSocketHandshakeRequest::host):
- websockets/WebSocketHandshakeRequest.h: Added.
- 9:19 PM Changeset in webkit [55504] by
-
- 2 edits in trunk/WebCore
2010-03-03 Laszlo Gombos <Laszlo Gombos>
Reviewed by Kenneth Rohde Christiansen.
Build fix after r55452.
No new tests, this is a build fix.
- page/Settings.cpp: (WebCore::Settings::setDatabasesEnabled):
- 9:17 PM Changeset in webkit [55503] by
-
- 5 edits in trunk/WebKit/win
Add a way to get an iframe's content frame
Reviewed by Jon Honeycutt.
- DOMCoreClasses.cpp:
(DOMElement::createInstance):
Added case for DOMHTMLIFrameElement
- DOMHTMLClasses.cpp:
Adding the few DOMHTMLIFrameElement functions definitions that have
distinct implementations (all others just call parent implementation)
(DOMHTMLIFrameElement::QueryInterface):
(DOMHTMLIFrameElement::contentFrame):
- DOMHTMLClasses.h:
Most of these function declarations have definitions that just call the parent implementation
(DOMHTMLIFrameElement::DOMHTMLIFrameElement):
(DOMHTMLIFrameElement::AddRef):
(DOMHTMLIFrameElement::Release):
(DOMHTMLIFrameElement::throwException):
(DOMHTMLIFrameElement::callWebScriptMethod):
(DOMHTMLIFrameElement::evaluateWebScript):
(DOMHTMLIFrameElement::removeWebScriptKey):
(DOMHTMLIFrameElement::stringRepresentation):
(DOMHTMLIFrameElement::webScriptValueAtIndex):
(DOMHTMLIFrameElement::setWebScriptValueAtIndex):
(DOMHTMLIFrameElement::setException):
(DOMHTMLIFrameElement::nodeName):
(DOMHTMLIFrameElement::nodeValue):
(DOMHTMLIFrameElement::setNodeValue):
(DOMHTMLIFrameElement::nodeType):
(DOMHTMLIFrameElement::parentNode):
(DOMHTMLIFrameElement::childNodes):
(DOMHTMLIFrameElement::firstChild):
(DOMHTMLIFrameElement::lastChild):
(DOMHTMLIFrameElement::previousSibling):
(DOMHTMLIFrameElement::nextSibling):
(DOMHTMLIFrameElement::attributes):
(DOMHTMLIFrameElement::ownerDocument):
(DOMHTMLIFrameElement::insertBefore):
(DOMHTMLIFrameElement::replaceChild):
(DOMHTMLIFrameElement::removeChild):
(DOMHTMLIFrameElement::appendChild):
(DOMHTMLIFrameElement::hasChildNodes):
(DOMHTMLIFrameElement::cloneNode):
(DOMHTMLIFrameElement::normalize):
(DOMHTMLIFrameElement::isSupported):
(DOMHTMLIFrameElement::namespaceURI):
(DOMHTMLIFrameElement::prefix):
(DOMHTMLIFrameElement::setPrefix):
(DOMHTMLIFrameElement::localName):
(DOMHTMLIFrameElement::hasAttributes):
(DOMHTMLIFrameElement::isSameNode):
(DOMHTMLIFrameElement::isEqualNode):
(DOMHTMLIFrameElement::textContent):
(DOMHTMLIFrameElement::setTextContent):
(DOMHTMLIFrameElement::tagName):
(DOMHTMLIFrameElement::getAttribute):
(DOMHTMLIFrameElement::setAttribute):
(DOMHTMLIFrameElement::removeAttribute):
(DOMHTMLIFrameElement::getAttributeNode):
(DOMHTMLIFrameElement::setAttributeNode):
(DOMHTMLIFrameElement::removeAttributeNode):
(DOMHTMLIFrameElement::getElementsByTagName):
(DOMHTMLIFrameElement::getAttributeNS):
(DOMHTMLIFrameElement::setAttributeNS):
(DOMHTMLIFrameElement::removeAttributeNS):
(DOMHTMLIFrameElement::getAttributeNodeNS):
(DOMHTMLIFrameElement::setAttributeNodeNS):
(DOMHTMLIFrameElement::getElementsByTagNameNS):
(DOMHTMLIFrameElement::hasAttribute):
(DOMHTMLIFrameElement::hasAttributeNS):
(DOMHTMLIFrameElement::focus):
(DOMHTMLIFrameElement::blur):
(DOMHTMLIFrameElement::idName):
(DOMHTMLIFrameElement::setIdName):
(DOMHTMLIFrameElement::title):
(DOMHTMLIFrameElement::setTitle):
(DOMHTMLIFrameElement::lang):
(DOMHTMLIFrameElement::setLang):
(DOMHTMLIFrameElement::dir):
(DOMHTMLIFrameElement::setDir):
(DOMHTMLIFrameElement::className):
(DOMHTMLIFrameElement::setClassName):
(DOMHTMLIFrameElement::innerHTML):
(DOMHTMLIFrameElement::setInnerHTML):
(DOMHTMLIFrameElement::innerText):
(DOMHTMLIFrameElement::setInnerText):
- Interfaces/DOMHTML.idl:
Added IDOMHTMLIFrameElement interface
- 9:02 PM Changeset in webkit [55502] by
-
- 3 edits in trunk/JavaScriptCore
2010-03-03 Jedrzej Nowacki <jedrzej.nowacki@nokia.com>
Reviewed by Simon Hausmann.
QScriptValue::isObject fix.
Fix broken internal state evaluation from JSValue to JSNative / JSObject.
New function was introduced which should take care about promoting
JSValue state inside QScriptValuePrivate. It should be used instead of a
direct JSC C API call.
The bug exposed a weakness in autotest suite, as the QScriptValuePrivate
is based on state machine with lazy state evaluation, there is a possibility
that serial sequencial calls to the same public const function could return
different results. The patch fix the issue.
[Qt] Sometimes QScriptValue::isObject returns an incorrect value
https://bugs.webkit.org/show_bug.cgi?id=35387
- qt/api/qscriptvalue_p.h: (QScriptValuePrivate::isBool): (QScriptValuePrivate::isNumber): (QScriptValuePrivate::isNull): (QScriptValuePrivate::isString): (QScriptValuePrivate::isUndefined): (QScriptValuePrivate::isError): (QScriptValuePrivate::isObject): (QScriptValuePrivate::isFunction): (QScriptValuePrivate::call): (QScriptValuePrivate::refineJSValue):
- qt/tests/qscriptvalue/tst_qscriptvalue_generated.cpp: (tst_QScriptValue::initScriptValues): (tst_QScriptValue::isValid_makeData): (tst_QScriptValue::isValid_test): (tst_QScriptValue::isBool_makeData): (tst_QScriptValue::isBool_test): (tst_QScriptValue::isBoolean_makeData): (tst_QScriptValue::isBoolean_test): (tst_QScriptValue::isNumber_makeData): (tst_QScriptValue::isNumber_test): (tst_QScriptValue::isFunction_test): (tst_QScriptValue::isNull_makeData): (tst_QScriptValue::isNull_test): (tst_QScriptValue::isString_makeData): (tst_QScriptValue::isString_test): (tst_QScriptValue::isUndefined_makeData): (tst_QScriptValue::isUndefined_test): (tst_QScriptValue::isObject_makeData): (tst_QScriptValue::isObject_test): (tst_QScriptValue::toString_makeData): (tst_QScriptValue::toString_test): (tst_QScriptValue::toNumber_makeData): (tst_QScriptValue::toNumber_test): (tst_QScriptValue::toBool_makeData): (tst_QScriptValue::toBool_test): (tst_QScriptValue::toBoolean_makeData): (tst_QScriptValue::toBoolean_test): (tst_QScriptValue::toInteger_makeData): (tst_QScriptValue::toInteger_test): (tst_QScriptValue::toInt32_makeData): (tst_QScriptValue::toInt32_test): (tst_QScriptValue::toUInt32_makeData): (tst_QScriptValue::toUInt32_test): (tst_QScriptValue::toUInt16_makeData): (tst_QScriptValue::toUInt16_test):
- 8:45 PM Changeset in webkit [55501] by
-
- 4 edits in trunk
2010-03-03 Diego Gonzalez <diego.gonzalez@openbossa.org>
Reviewed by Kenneth Rohde Christiansen.
Make keyIdentifierForQtKeyCode return the unicode backspace value on Qt PlatformKeyboardEvent
LayoutTests:
fast/events/key-events-in-input-text.html
fast/events/special-key-events-in-input-text.html
[Qt] Return the unicode backspace value in keyIdentifierForQtKeyCode on Qt PlatformKeyboardEvent
https://bugs.webkit.org/show_bug.cgi?id=35694
- platform/qt/Skipped:
2010-03-03 Diego Gonzalez <diego.gonzalez@openbossa.org>
Reviewed by Kenneth Rohde Christiansen.
Make keyIdentifierForQtKeyCode return the unicode backspace value on Qt PlatformKeyboardEvent
LayoutTests:
fast/events/key-events-in-input-text.html
fast/events/special-key-events-in-input-text.html
[Qt] Return the unicode backspace value in keyIdentifierForQtKeyCode on Qt PlatformKeyboardEvent
https://bugs.webkit.org/show_bug.cgi?id=35694
- platform/qt/PlatformKeyboardEventQt.cpp: (WebCore::keyIdentifierForQtKeyCode):
- 7:57 PM Changeset in webkit [55500] by
-
- 6 edits2 adds in trunk/JavaScriptCore
2010-03-03 Chao-ying Fu <fu@mips.com>
Reviewed by Gavin Barraclough.
MIPS JIT Supports
https://bugs.webkit.org/show_bug.cgi?id=30144
The following changes enable MIPS YARR and YARR_JIT.
- assembler/AbstractMacroAssembler.h: (JSC::AbstractMacroAssembler::Imm32::Imm32):
- assembler/MIPSAssembler.h: Added. (JSC::MIPSRegisters::): (JSC::MIPSAssembler::MIPSAssembler): (JSC::MIPSAssembler::): (JSC::MIPSAssembler::JmpSrc::JmpSrc): (JSC::MIPSAssembler::JmpDst::JmpDst): (JSC::MIPSAssembler::JmpDst::isUsed): (JSC::MIPSAssembler::JmpDst::used): (JSC::MIPSAssembler::emitInst): (JSC::MIPSAssembler::nop): (JSC::MIPSAssembler::loadDelayNop): (JSC::MIPSAssembler::copDelayNop): (JSC::MIPSAssembler::move): (JSC::MIPSAssembler::li): (JSC::MIPSAssembler::lui): (JSC::MIPSAssembler::addiu): (JSC::MIPSAssembler::addu): (JSC::MIPSAssembler::subu): (JSC::MIPSAssembler::mult): (JSC::MIPSAssembler::mfhi): (JSC::MIPSAssembler::mflo): (JSC::MIPSAssembler::mul): (JSC::MIPSAssembler::andInsn): (JSC::MIPSAssembler::andi): (JSC::MIPSAssembler::nor): (JSC::MIPSAssembler::orInsn): (JSC::MIPSAssembler::ori): (JSC::MIPSAssembler::xorInsn): (JSC::MIPSAssembler::xori): (JSC::MIPSAssembler::slt): (JSC::MIPSAssembler::sltu): (JSC::MIPSAssembler::sltiu): (JSC::MIPSAssembler::sll): (JSC::MIPSAssembler::sllv): (JSC::MIPSAssembler::sra): (JSC::MIPSAssembler::srav): (JSC::MIPSAssembler::lw): (JSC::MIPSAssembler::lwl): (JSC::MIPSAssembler::lwr): (JSC::MIPSAssembler::lhu): (JSC::MIPSAssembler::sw): (JSC::MIPSAssembler::jr): (JSC::MIPSAssembler::jalr): (JSC::MIPSAssembler::jal): (JSC::MIPSAssembler::bkpt): (JSC::MIPSAssembler::bgez): (JSC::MIPSAssembler::bltz): (JSC::MIPSAssembler::beq): (JSC::MIPSAssembler::bne): (JSC::MIPSAssembler::bc1t): (JSC::MIPSAssembler::bc1f): (JSC::MIPSAssembler::newJmpSrc): (JSC::MIPSAssembler::appendJump): (JSC::MIPSAssembler::addd): (JSC::MIPSAssembler::subd): (JSC::MIPSAssembler::muld): (JSC::MIPSAssembler::lwc1): (JSC::MIPSAssembler::ldc1): (JSC::MIPSAssembler::swc1): (JSC::MIPSAssembler::sdc1): (JSC::MIPSAssembler::mtc1): (JSC::MIPSAssembler::mfc1): (JSC::MIPSAssembler::truncwd): (JSC::MIPSAssembler::cvtdw): (JSC::MIPSAssembler::ceqd): (JSC::MIPSAssembler::cngtd): (JSC::MIPSAssembler::cnged): (JSC::MIPSAssembler::cltd): (JSC::MIPSAssembler::cled): (JSC::MIPSAssembler::cueqd): (JSC::MIPSAssembler::coled): (JSC::MIPSAssembler::coltd): (JSC::MIPSAssembler::culed): (JSC::MIPSAssembler::cultd): (JSC::MIPSAssembler::label): (JSC::MIPSAssembler::align): (JSC::MIPSAssembler::getRelocatedAddress): (JSC::MIPSAssembler::getDifferenceBetweenLabels): (JSC::MIPSAssembler::size): (JSC::MIPSAssembler::executableCopy): (JSC::MIPSAssembler::getCallReturnOffset): (JSC::MIPSAssembler::linkJump): (JSC::MIPSAssembler::linkCall): (JSC::MIPSAssembler::linkPointer): (JSC::MIPSAssembler::relinkJump): (JSC::MIPSAssembler::relinkCall): (JSC::MIPSAssembler::repatchInt32): (JSC::MIPSAssembler::repatchPointer): (JSC::MIPSAssembler::repatchLoadPtrToLEA): (JSC::MIPSAssembler::relocateJumps): (JSC::MIPSAssembler::linkWithOffset): (JSC::MIPSAssembler::linkCallInternal):
- assembler/MacroAssembler.h:
- assembler/MacroAssemblerMIPS.h: Added. (JSC::MacroAssemblerMIPS::MacroAssemblerMIPS): (JSC::MacroAssemblerMIPS::): (JSC::MacroAssemblerMIPS::add32): (JSC::MacroAssemblerMIPS::and32): (JSC::MacroAssemblerMIPS::lshift32): (JSC::MacroAssemblerMIPS::mul32): (JSC::MacroAssemblerMIPS::not32): (JSC::MacroAssemblerMIPS::or32): (JSC::MacroAssemblerMIPS::rshift32): (JSC::MacroAssemblerMIPS::sub32): (JSC::MacroAssemblerMIPS::xor32): (JSC::MacroAssemblerMIPS::load32): (JSC::MacroAssemblerMIPS::load32WithUnalignedHalfWords): (JSC::MacroAssemblerMIPS::load32WithAddressOffsetPatch): (JSC::MacroAssemblerMIPS::loadPtrWithPatchToLEA): (JSC::MacroAssemblerMIPS::loadPtrWithAddressOffsetPatch): (JSC::MacroAssemblerMIPS::load16): (JSC::MacroAssemblerMIPS::store32WithAddressOffsetPatch): (JSC::MacroAssemblerMIPS::store32): (JSC::MacroAssemblerMIPS::supportsFloatingPoint): (JSC::MacroAssemblerMIPS::supportsFloatingPointTruncate): (JSC::MacroAssemblerMIPS::pop): (JSC::MacroAssemblerMIPS::push): (JSC::MacroAssemblerMIPS::move): (JSC::MacroAssemblerMIPS::swap): (JSC::MacroAssemblerMIPS::signExtend32ToPtr): (JSC::MacroAssemblerMIPS::zeroExtend32ToPtr): (JSC::MacroAssemblerMIPS::branch32): (JSC::MacroAssemblerMIPS::branch32WithUnalignedHalfWords): (JSC::MacroAssemblerMIPS::branch16): (JSC::MacroAssemblerMIPS::branchTest32): (JSC::MacroAssemblerMIPS::jump): (JSC::MacroAssemblerMIPS::branchAdd32): (JSC::MacroAssemblerMIPS::branchMul32): (JSC::MacroAssemblerMIPS::branchSub32): (JSC::MacroAssemblerMIPS::breakpoint): (JSC::MacroAssemblerMIPS::nearCall): (JSC::MacroAssemblerMIPS::call): (JSC::MacroAssemblerMIPS::ret): (JSC::MacroAssemblerMIPS::set32): (JSC::MacroAssemblerMIPS::setTest32): (JSC::MacroAssemblerMIPS::moveWithPatch): (JSC::MacroAssemblerMIPS::branchPtrWithPatch): (JSC::MacroAssemblerMIPS::storePtrWithPatch): (JSC::MacroAssemblerMIPS::tailRecursiveCall): (JSC::MacroAssemblerMIPS::makeTailRecursiveCall): (JSC::MacroAssemblerMIPS::loadDouble): (JSC::MacroAssemblerMIPS::storeDouble): (JSC::MacroAssemblerMIPS::addDouble): (JSC::MacroAssemblerMIPS::subDouble): (JSC::MacroAssemblerMIPS::mulDouble): (JSC::MacroAssemblerMIPS::convertInt32ToDouble): (JSC::MacroAssemblerMIPS::insertRelaxationWords): (JSC::MacroAssemblerMIPS::branchTrue): (JSC::MacroAssemblerMIPS::branchFalse): (JSC::MacroAssemblerMIPS::branchEqual): (JSC::MacroAssemblerMIPS::branchNotEqual): (JSC::MacroAssemblerMIPS::branchDouble): (JSC::MacroAssemblerMIPS::branchTruncateDoubleToInt32): (JSC::MacroAssemblerMIPS::linkCall): (JSC::MacroAssemblerMIPS::repatchCall):
- jit/ExecutableAllocator.h: (JSC::ExecutableAllocator::cacheFlush):
- wtf/Platform.h:
- yarr/RegexJIT.cpp: (JSC::Yarr::RegexGenerator::generateEnter): (JSC::Yarr::RegexGenerator::generateReturn):
- 7:31 PM Changeset in webkit [55499] by
-
- 3 edits2 adds in trunk
2010-03-03 Chad Faragher <wyck@chromium.org>
Reviewed by Darin Adler.
Changed the double-click framework code to pass adjusted page
coordinates for zoomed pages. Added a new test to expose
mistreatment of mouse click coordinates during a double-click.
- fast/events/zoom-dblclick-expected.txt: Added.
- fast/events/zoom-dblclick.html: Added.
2010-03-03 Chad Faragher <wyck@chromium.org>
Reviewed by Darin Adler.
Changed the double-click framework code to pass adjusted page
coordinates for zoomed pages. Added a new test to expose
mistreatment of mouse click coordinates during a double-click.
Test: fast/events/zoom-dblclick.html
- dom/Node.cpp: (WebCore::Node::dispatchMouseEvent):
- 7:13 PM Changeset in webkit [55498] by
-
- 2 edits in trunk/WebKitTools
2010-03-03 Jesus Sanchez-Palencia <jesus.palencia@openbossa.org>
Reviewed by Simon Hausmann.
Add a missing 'm_' to class variables names.
[Qt] QtLauncher is not respecting class variable names
https://bugs.webkit.org/show_bug.cgi?id=35542
- QtLauncher/main.cpp: (LauncherWindow::LauncherWindow): (LauncherWindow::init): (LauncherWindow::sendTouchEvent): (LauncherWindow::eventFilter): (LauncherWindow::zoomIn): (LauncherWindow::zoomOut): (LauncherWindow::resetZoom): (LauncherWindow::setEditable): (LauncherWindow::setTouchMocking): (LauncherWindow::initializeView): (LauncherWindow::createChrome):
- 7:00 PM Changeset in webkit [55497] by
-
- 1 edit in tags/Safari-533.1.1/JavaScriptCore/ChangeLog
Remove extraneous ChangeLog entries.
- 6:56 PM Changeset in webkit [55496] by
-
- 4 edits in tags/Safari-533.1.1/JavaScriptCore
Merged r55495.
- 6:52 PM Changeset in webkit [55495] by
-
- 3 edits in trunk/JavaScriptCore
Windows build fix.
- JavaScriptCore.vcproj/jsc/jsc.vcproj:
- JavaScriptCore.vcproj/jsc/jscCommon.vsprops:
- 6:42 PM Changeset in webkit [55494] by
-
- 3 edits in tags/Safari-533.1.1/JavaScriptCore
Merge r55492.
- 6:35 PM Changeset in webkit [55493] by
-
- 1 copy in tags/Safari-533.1.1
New tag.
- 6:33 PM Changeset in webkit [55492] by
-
- 2 edits in trunk/JavaScriptCore
Windows build fix.
- JavaScriptCore.vcproj/jsc/jsc.vcproj:
- 5:23 PM Changeset in webkit [55491] by
-
- 2 edits in trunk/WebCore
No review, rolling out r55474.
The patch broke fast/frames/sandboxed-iframe-storage.html
Last one (I hope).
- WebCore.xcodeproj/project.pbxproj:
- 5:20 PM Changeset in webkit [55490] by
-
- 3 edits in trunk/LayoutTests
Making database-lock-after-reload.html a bit more robust and
cleaning up some style issues.
Reviewed by Dimitri Glazkov.
- storage/database-lock-after-reload.html:
- storage/resources/database-lock-after-reload-2.html:
- 5:14 PM Changeset in webkit [55489] by
-
- 2 edits in trunk/WebKitTools
Rubber-stamped by Mark Rowe.
Exclude leaks in Java that build bot complains about.
- Scripts/run-webkit-tests:
- 5:09 PM Changeset in webkit [55488] by
-
- 2 edits9 deletes in trunk
No review, rolling out r55474.
The patch broke fast/frames/sandboxed-iframe-storage.html
Unfortunately, (the webkit-patch rollout and) I missed these in r55485.
WebCore:
- bindings/js/JSDatabaseCallback.cpp: Removed.
- bindings/js/JSDatabaseCallback.h: Removed.
- bindings/v8/custom/V8DatabaseCallback.cpp: Removed.
- bindings/v8/custom/V8DatabaseCallback.h: Removed.
- storage/DatabaseCallback.h: Removed.
LayoutTests:
- storage/open-database-creation-callback-expected.txt: Removed.
- storage/open-database-creation-callback-isolated-world-expected.txt: Removed.
- storage/open-database-creation-callback-isolated-world.html: Removed.
- storage/open-database-creation-callback.html: Removed.
- 5:01 PM Changeset in webkit [55487] by
-
- 2 edits in trunk/WebCore
Fix a bug that could lead to a crash. Some parts of
SQLTransaction::checkAndHandleClosedDatabase() should only be run
when that method is invoked on the DB thread.
Reviewed by Dimitri Glazkov.
We cannot test this fix with a test, because the crash happens
only when all of the following conditions are met:
- A database is closing.
- A transaction on that database is in progress.
- The transaction is in a state where a statement/transaction
success/error callback needs to be invoked (so there's a task for
this transaction pending on the main thread).
- The DB thread finished processing all its tasks and called
SQLTransactionCoordinator::shutdown() before the main thread go to
that task.
The closest thing we have to a test is running
LayoutTests/storage/database-lock-after-reload.html 1000 times in
a row. Without the patch, the probability of a crash happening in
one of the runs is very high. With the patch, the test should
reliably run 1000 times in a row without a single crash.
https://bugs.webkit.org/show_bug.cgi?id=35624
- storage/SQLTransaction.cpp:
(WebCore::SQLTransaction::checkAndHandleClosedDatabase):
- 4:47 PM Changeset in webkit [55486] by
-
- 3 edits in trunk/WebCore
2010-03-03 Darin Fisher <darin@chromium.org>
Reviewed by Mark Rowe.
Page should not care about Chromium plug-in implementation details
https://bugs.webkit.org/show_bug.cgi?id=35623
- WebCore.gypi: Compile PluginViewNone.cpp
- page/Page.cpp: (WebCore::Page::privateBrowsingStateChanged): Remove conditional compilation for PLATFORM(CHROMIUM).
- 4:38 PM Changeset in webkit [55485] by
-
- 17 edits in trunk/WebCore
2010-03-03 David Levin <levin@chromium.org>
No review, rolling out r55474.
http://trac.webkit.org/changeset/55480
The patch broke fast/frames/sandboxed-iframe-storage.html
- Android.jscbindings.mk:
- Android.v8bindings.mk:
- GNUmakefile.am:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- bindings/js/JSDOMWindowCustom.cpp:
- bindings/v8/custom/V8DOMWindowCustom.cpp:
- dom/Document.cpp: (WebCore::Document::postTask):
- page/DOMWindow.cpp: (WebCore::DOMWindow::openDatabase):
- page/DOMWindow.h:
- page/DOMWindow.idl:
- storage/Database.cpp: (WebCore::Database::openDatabase): (WebCore::Database::Database): (WebCore::Database::performOpenAndVerify):
- storage/Database.h:
- workers/WorkerContext.cpp: (WebCore::WorkerContext::openDatabase):
- workers/WorkerContext.h:
- 4:36 PM Changeset in webkit [55484] by
-
- 3 edits in trunk/WebCore
2010-03-03 David Levin <levin@chromium.org>
No review, rolling out r55480.
http://trac.webkit.org/changeset/55480
The patch broke fast/frames/sandboxed-iframe-storage.html
- storage/Database.cpp:
- storage/Database.h:
- 4:22 PM Changeset in webkit [55483] by
-
- 5 edits in trunk
Add virtual memory tags for TCMalloc and WebCore's purgeable buffers.
Reviewed by Geoff Garen.
- wtf/TCSystemAlloc.cpp:
(TryMmap): Use the VM tag.
- wtf/VMTags.h: Make use of VM_MEMORY_TCMALLOC and VM_MEMORY_WEBCORE_PURGEABLE_BUFFERS.
WebCore:
- platform/mac/PurgeableBufferMac.cpp:
(WebCore::PurgeableBuffer::create): Use the VM tag.
- 4:20 PM Changeset in webkit [55482] by
-
- 3 edits1 delete in trunk/LayoutTests
Not reviewed.
Try better to fix Java tests on Tiger bot.
- platform/mac-tiger/Skipped:
- platform/mac-tiger/java/lc3/JavaArray/ToString-001-expected.txt: Removed. This test gets different resultson each run when it fails, so it needs to be disabled on Tiger.
- platform/mac-tiger/java/lc3/JavaObject/JavaObjectToString-001-expected.txt: Added a newline I didn't get when copying actual results from buildbot.
- 4:05 PM Changeset in webkit [55481] by
-
- 3 edits in trunk/WebKitTools
Additional change to separate Accelerated Compositing test from 3D Rendering test
https://bugs.webkit.org/show_bug.cgi?id=35610
- 3:03 PM Changeset in webkit [55480] by
-
- 3 edits in trunk/WebCore
Move #include "DatabaseCallback.h" from Database.h to
Database.cpp.
Reviewed by nobody, build fix.
- storage/Database.cpp:
- storage/Database.h:
- 2:55 PM Changeset in webkit [55479] by
-
- 2 edits in trunk/LayoutTests
[Qt] Skip new test introduced in r55474, because of
missing layoutTestController.evaluateScriptInIsolatedWorld()
- platform/qt/Skipped: storage/open-database-creation-callback-isolated-world.html skipped.
- 2:24 PM Changeset in webkit [55478] by
-
- 2 edits in trunk/WebCore
Fixed Mac build.
- WebCore.xcodeproj/project.pbxproj: Marked a couple of headers "private" so they can
be used in the WebKit project.
- 2:22 PM Changeset in webkit [55477] by
-
- 188 edits1 add in trunk/LayoutTests
Rubber-stamped by Dan Bernstein.
https://bugs.webkit.org/show_bug.cgi?id=35700
Some of the newly added Java tests fail randomly on buildbot
- fast/js/resources/js-test-post-async.js: Added a version that calls notifyDone(). I first wanted to add a notifyDone() call to js-test-post.js, but it turns out that multiple tests dump results after "TEST COMPLETE", and we need to get bots back to green fast.
- java/lc3: (Many files). Don't load two scripts dynamically, WebKit has issues with order of execution in this case.
- 2:06 PM Changeset in webkit [55476] by
-
- 2 edits in trunk/JavaScriptCore
Rubber stamped by Adam Roben.
Fix bogus xcopy that was polluting source tree at build time.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreCommon.vsprops:
- 2:05 PM Changeset in webkit [55475] by
-
- 2 edits in trunk/WebCore
Reviewed by Adele Peterson.
https://bugs.webkit.org/show_bug.cgi?id=35044
Crash in XML tokenizer reloading zoom-coords-viewattr-01-b.svg
I'm often getting a crash even when opening the test for the first time in Safari, but it
doesn't seem to crash in DumpRenderTree. Still, I can't think of a stronger way to test for
this condition, so no new regression test.
- dom/XMLTokenizer.cpp: (WebCore::XMLTokenizer::end): Be prepared that parsing remaining input will pause parsing.
- 1:48 PM Changeset in webkit [55474] by
-
- 19 edits9 adds in trunk
WebCore: Adding support for the optional creation callback that could be
passed to openDatabase().
Reviewed by Adam Barth.
Test: storage/open-database-creation-callback.html
https://bugs.webkit.org/show_bug.cgi?id=34726
- Android.jscbindings.mk
- Android.v8bindings.mk
- GNUmakefile.am:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/JSDOMWindowCustom.cpp:
(WebCore::JSDOMWindow::openDatabase):
- bindings/js/JSDatabaseCallback.cpp: Added.
(WebCore::JSDatabaseCallback::JSDatabaseCallback):
(WebCore::JSDatabaseCallback::~JSDatabaseCallback):
(WebCore::JSDatabaseCallback::handleEvent):
- bindings/js/JSDatabaseCallback.h: Added.
(WebCore::JSDatabaseCallback::create):
- bindings/v8/custom/V8DOMWindowCustom.cpp:
(WebCore::V8DOMWindow::openDatabaseCallback):
- bindings/v8/custom/V8DatabaseCallback.cpp: Added.
(WebCore::V8DatabaseCallback::V8DatabaseCallback):
(WebCore::V8DatabaseCallback::~V8DatabaseCallback):
(WebCore::V8DatabaseCallback::handleEvent):
- bindings/v8/custom/V8DatabaseCallback.h: Added.
(WebCore::V8DatabaseCallback::create):
- page/DOMWindow.cpp:
(WebCore::DOMWindow::openDatabase):
- page/DOMWindow.h:
- page/DOMWindow.idl:
- storage/Database.cpp:
(WebCore::DatabaseCreationCallbackTask::create):
(WebCore::DatabaseCreationCallbackTask::performTask):
(WebCore::DatabaseCreationCallbackTask::DatabaseCreationCallbackTask):
(WebCore::Database::openDatabase):
(WebCore::Database::Database):
(WebCore::Database::performOpenAndVerify):
(WebCore::Database::performCreationCallback):
- storage/Database.h:
(WebCore::Database::isNew):
- storage/DatabaseCallback.h: Added.
(WebCore::DatabaseCallback::~DatabaseCallback):
- workers/WorkerContext.cpp:
(WebCore::WorkerContext::openDatabase):
- workers/WorkerContext.h:
LayoutTests: Adding a test to test the creation callback passed to
openDatabase() and another one to make sure it is executed in the
correct world.
Reviewed by Adam Barth.
https://bugs.webkit.org/show_bug.cgi?id=34726
- storage/open-database-creation-callback-expected.txt: Added.
- storage/open-database-creation-callback.html: Added.
- storage/open-database-creation-callback-isolated-world-expected.txt: Added.
- storage/open-database-creation-callback-isolated-world.html: Added.
- 1:33 PM Changeset in webkit [55473] by
-
- 1 edit in trunk/WebKit/win/Interfaces/WebKit.idl
Useless change to kick the Windows build into recompiling the idl files
- 1:25 PM Changeset in webkit [55472] by
-
- 1 edit in trunk/WebKit/win/Interfaces/WebKit.idl
Touch WebKit.idl to force a rebuild
- 12:45 PM Changeset in webkit [55471] by
-
- 1 edit6 adds in trunk/LayoutTests
Not reviewed.
Two newly added Java tests fail on Tiger build bot.
Just land actual results as expected. I don't even know which behavior is more correct.
- platform/mac-tiger/java: Added.
- platform/mac-tiger/java/lc3: Added.
- platform/mac-tiger/java/lc3/JavaArray: Added.
- platform/mac-tiger/java/lc3/JavaArray/ToString-001-expected.txt: Added.
- platform/mac-tiger/java/lc3/JavaObject: Added.
- platform/mac-tiger/java/lc3/JavaObject/JavaObjectToString-001-expected.txt: Added.
- 11:34 AM Changeset in webkit [55470] by
-
- 2 edits in trunk/WebKit/mac
Reviewed by Timothy Hatcher.
https://bugs.webkit.org/show_bug.cgi?id=35692
<rdar://problem/7703622> Crash when calling abort() on an XHR while in a windowless WebView
- Panels/WebAuthenticationPanel.m: (-[WebAuthenticationPanel runAsModalDialogWithChallenge:]): Retain the challenge, just like it's done for sheet.
- 11:15 AM Changeset in webkit [55469] by
-
- 2 edits696 adds in trunk/LayoutTests
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=35617
Import Mozilla LiveConnect 3 test suite
- java/lc3/sources: Added (many files). Sources for Mozilla test applet.
- java/jstests.jar: Added in compiled form, since it's unlikely that we'll ever need to modify the above sources.
- java/lc3.java: Added. (lc3): This is a small wrapper around jstests.jar. The latter only adds some classes, but WebKit needs an actual applet to call into Java. (lc3.createQAObject): Instantiate a class defined in jstests.jar by name. (lc3.stringToByteArray): A helper to make a byte array out of string. Tests originally relied on window.java package interface to do this, but it's not available in WebKit. We need more functions like this to work around other uses of window.java, but this is one I wrote for now.
- java/Makefile: Link test applets to Mozilla's jstests.jar. This is not needed for tests other than ones imported here, but it's also harmless, and I don't know how to write good makefiles.
- java/lc3: Added (many files). Tests were heavily reworked to run to completion, but PASS/FAIL results should not be generally relied upon. All html wrappers are identical.
- 11:05 AM Changeset in webkit [55468] by
-
- 3 edits in trunk/LayoutTests
2010-03-03 Eric Carlson <eric.carlson@apple.com>
Unreviewed, build fix.
Update expected results for fast/js/custom-constructors-expected.txt
- 10:51 AM Changeset in webkit [55467] by
-
- 7 edits in trunk
Enable LayoutTests/compositing for Windows when compositing is available
https://bugs.webkit.org/show_bug.cgi?id=35610
- 10:20 AM Changeset in webkit [55466] by
-
- 10 edits in trunk/WebCore
2010-03-03 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: resources panel only shows uncompressed resource size.
https://bugs.webkit.org/show_bug.cgi?id=35403
- English.lproj/localizedStrings.js:
- inspector/InspectorResource.cpp: (WebCore::InspectorResource::updateScriptObject):
- inspector/front-end/AbstractTimelinePanel.js: (WebInspector.AbstractTimelinePanel.prototype.refresh):
- inspector/front-end/AuditRules.js: (WebInspector.AuditRules.GzipRule.prototype.doRun): (WebInspector.AuditRules.GzipRule.prototype._shouldCompress):
- inspector/front-end/ImageView.js: (WebInspector.ImageView):
- inspector/front-end/Resource.js: (WebInspector.Resource.prototype.get resourceSize): (WebInspector.Resource.prototype.set resourceSize): (WebInspector.Resource.prototype.get transferSize): (WebInspector.Resource.CompareBySize): (WebInspector.Resource.CompareByTransferSize):
- inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel.prototype.populateSidebar): (WebInspector.ResourceTimeCalculator.prototype.computeBarGraphLabels): (WebInspector.ResourceTransferSizeCalculator.prototype.computeBarGraphLabels): (WebInspector.ResourceTransferSizeCalculator.prototype.computeBarGraphPercentages): (WebInspector.ResourceTransferSizeCalculator.prototype._value): (WebInspector.ResourceTransferSizeCalculator.prototype._networkBytes): (WebInspector.ResourceSidebarTreeElement.CompareByDescendingTransferSize): (WebInspector.ResourceGraph.prototype.refreshLabelPositions): (WebInspector.ResourceGraph.prototype.refresh):
- inspector/front-end/inspector.css:
- inspector/front-end/inspector.js: (WebInspector.updateResource):
- 9:42 AM Changeset in webkit [55465] by
-
- 2 edits in trunk/WebCore
Build fix.
- dom/ContainerNode.cpp:
(WebCore::ContainerNode::removeChildren):
- 9:24 AM Changeset in webkit [55464] by
-
- 11 edits in trunk
2010-03-03 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: Get rid of synchronous debuggerEnabled, profilerEnabled calls.
- inspector/InspectorBackend.cpp:
- inspector/InspectorBackend.h:
- inspector/InspectorBackend.idl:
- inspector/front-end/BreakpointsSidebarPane.js: (WebInspector.BreakpointsSidebarPane.prototype.addBreakpoint): (WebInspector.BreakpointsSidebarPane.prototype.removeBreakpoint): (WebInspector.BreakpointsSidebarPane.prototype._breakpointEnableChanged):
- inspector/front-end/ProfilesPanel.js: (WebInspector.ProfilesPanel): (WebInspector.ProfilesPanel.prototype.profilerWasEnabled): (WebInspector.ProfilesPanel.prototype.profilerWasDisabled): (WebInspector.ProfilesPanel.prototype._updateInterface): (WebInspector.ProfilesPanel.prototype._enableProfiling): (WebInspector.ProfilesPanel.prototype._toggleProfiling):
- inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel): (WebInspector.ScriptsPanel.prototype.debuggerWasEnabled): (WebInspector.ScriptsPanel.prototype.debuggerWasDisabled): (WebInspector.ScriptsPanel.prototype.reset): (WebInspector.ScriptsPanel.prototype.canShowSourceLine): (WebInspector.ScriptsPanel.prototype._updateDebuggerButtons): (WebInspector.ScriptsPanel.prototype._enableDebugging): (WebInspector.ScriptsPanel.prototype._toggleDebugging):
- 9:19 AM Changeset in webkit [55463] by
-
- 12 edits4 adds4 deletes in trunk
2010-03-03 Eric Carlson <eric.carlson@apple.com>
Reviewed by Adele Peterson.
Replace 'autobuffer' attribute with 'preload' to align with spec revision 4811.
https://bugs.webkit.org/show_bug.cgi?id=35385
rdar://problem/7689602
Tests: media/audio-constructor-preload.html
media/video-dom-preload.html
- html/HTMLAttributeNames.in: Remove autobuffer, add preload
- html/HTMLAudioElement.cpp: (WebCore::HTMLAudioElement::createForJSConstructor): set preload to 'auto' instead of
autobuffer to true.
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::HTMLMediaElement): Initialize m_preload. (WebCore::HTMLMediaElement::parseMappedAttribute): Deal with 'preload' attribute. (WebCore::HTMLMediaElement::loadResource): Call setPreload() on the newly created MediaPlayer,
before calling load() so it can pass the setting through to the media engine.
(WebCore::HTMLMediaElement::preload): New.
(WebCore::HTMLMediaElement::setPreload): Ditto
- html/HTMLMediaElement.h:
- html/HTMLMediaElement.idl:
- platform/graphics/MediaPlayer.cpp: (WebCore::MediaPlayer::MediaPlayer): Initialize m_preload. (WebCore::MediaPlayer::load): Pass m_preload to newly created media engine. (WebCore::MediaPlayer::preload): New, return m_preload. (WebCore::MediaPlayer::setPreload): New, set m_preload.
- platform/graphics/MediaPlayer.h: (WebCore::MediaPlayer::):
- platform/graphics/MediaPlayerPrivate.h: (WebCore::MediaPlayerPrivateInterface::setPreload):
- platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivate::setPreload): Renamed from setAutoplay, fix logic for preload.
- platform/graphics/gtk/MediaPlayerPrivateGStreamer.h:
2010-03-03 Eric Carlson <eric.carlson@apple.com>
Reviewed by Adele Peterson.
Replace 'autobuffer' attribute with 'preload' to align with spec revision 4811.
https://bugs.webkit.org/show_bug.cgi?id=35385
rdar://problem/7689602
- media/audio-constructor-autobuffer-expected.txt: Removed.
- media/audio-constructor-autobuffer.html: Removed.
- media/audio-constructor-preload-expected.txt: Added.
- media/audio-constructor-preload.html: Added.
- media/video-dom-autobuffer-expected.txt: Removed.
- media/video-dom-autobuffer.html: Removed.
- media/video-dom-preload-expected.txt: Added.
- media/video-dom-preload.html: Added.
- 7:21 AM QtWebKitBugs edited by
- (diff)
- 7:02 AM Changeset in webkit [55462] by
-
- 3 edits2 adds in trunk
<rdar://problem/7682756> Assertion failure when replacing the contents of a <select>
Reviewed by Sam Weinig.
WebCore:
Test: fast/dom/remove-children-notification-order.html
- dom/ContainerNode.cpp:
(WebCore::ContainerNode::removeChildren): Changed to call childrenChanged()
before calling removedFromDocument() on each removed child, which matches
the order removeChild() does things, and avoids the assertion. This required
temporarily storing the removed children in a vector.
Also added comments about other discrepancies between this function and
removeChild().
LayoutTests:
- fast/dom/remove-children-notification-order-expected.txt: Added.
- fast/dom/remove-children-notification-order.html: Added.
- 6:48 AM Changeset in webkit [55461] by
-
- 2 edits in trunk/WebCore
2010-03-03 Adam Barth <abarth@webkit.org>
Reviewed by Darin Adler.
Document cookieURL and firstPartyForCookies
https://bugs.webkit.org/show_bug.cgi?id=35613
Some folks asked what the cookieURL and the firstPartyForCookies were
on IRC. This patch documents these properties in the code so folks
don't have to ask on IRC anymore.
- dom/Document.h:
- 6:42 AM Changeset in webkit [55460] by
-
- 4 edits in trunk/WebKitTools
2010-03-03 Jesus Sanchez-Palencia <jesus.palencia@openbossa.org>
Reviewed by Simon Hausmann.
Refactor QtLauncher so it respects command line arguments
and inherits settings when you clone or create a new window.
Implemented with help of Kenneth Rohde Christiansen.
[Qt] QtLauncher must be refactored to fix command line arguments usage
https://bugs.webkit.org/show_bug.cgi?id=35536
- QtLauncher/main.cpp: (LauncherWindow::LauncherWindow): (LauncherWindow::init): (LauncherWindow::isGraphicsBased): (applySetting): (LauncherWindow::applyPrefs): (LauncherWindow::initializeView): (LauncherWindow::newWindow): (LauncherWindow::cloneWindow): (LauncherWindow::createChrome): (main):
- QtLauncher/webview.cpp: (WebViewGraphicsBased::WebViewGraphicsBased): (WebViewGraphicsBased::setFrameRateMeasurementEnabled):
- QtLauncher/webview.h: (WebViewGraphicsBased::itemCacheMode): (WebViewGraphicsBased::frameRateMeasurementEnabled):
- 6:40 AM Google Summer of Code 2010 edited by
- (diff)
- 6:00 AM Google Summer of Code 2010 edited by
- (diff)
- 5:30 AM Changeset in webkit [55459] by
-
- 2 edits in trunk/WebCore
2010-03-03 Arno Renevier <arno@renevier.net>
Reviewed by Gustavo Noronha Silva.
[Gtk]: assertion triggered when geolocation getCurrentPosition without an option argument.
https://bugs.webkit.org/show_bug.cgi?id=35666
- platform/gtk/GeolocationServiceGtk.cpp: (WebCore::GeolocationServiceGtk::startUpdating):
- 5:17 AM Changeset in webkit [55458] by
-
- 2 edits in trunk/LayoutTests
2010-03-03 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
[GTK] build slaves need working geoclue service
https://bugs.webkit.org/show_bug.cgi?id=35674
Skip tests we're not really able to run for the time being.
- platform/gtk/Skipped:
- 4:44 AM Changeset in webkit [55457] by
-
- 6 edits in trunk
2010-03-03 Fridrich Strba <fridrich.strba@bluewin.ch>
Reviewed by Xan Lopez.
Miscellaneous little fixes for the windows build of webkit-gtk
https://bugs.webkit.org/show_bug.cgi?id=35640
- GNUmakefile.am: On Windows with GCC, presence of declspec(dllexport) on some symbols disables the autoexport/autoimport feature for all others. Using regex here assures that all symbols that need to be exported in the dll are actually exported.
2010-03-03 Fridrich Strba <fridrich.strba@bluewin.ch>
Reviewed by Xan Lopez.
Miscellaneous little fixes for the windows build of webkit-gtk
https://bugs.webkit.org/show_bug.cgi?id=35640
- GNUmakefile.am: dist two new files concerning mathml support.
2010-03-03 Fridrich Strba <fridrich.strba@bluewin.ch>
Reviewed by Xan Lopez.
Miscellaneous little fixes for the windows build of webkit-gtk
https://bugs.webkit.org/show_bug.cgi?id=35640
- webkit/webkitdownload.cpp: Windows headers define ERROR which breaks the build. Undef ERROR if it is defined.
- 4:09 AM Changeset in webkit [55456] by
-
- 2 edits in trunk/WebCore
2010-03-03 Xan Lopez <xlopez@igalia.com>
Unreviewed distcheck fix.
Add new file to the build.
- GNUmakefile.am:
- 4:02 AM Changeset in webkit [55455] by
-
- 3 edits1 add in trunk/WebCore
Make IntPoint usable as a hash key
Reviewed by Oliver Hunt.
https://bugs.webkit.org/show_bug.cgi?id=35586
- WebCore.pro:
- WebCore.xcodeproj/project.pbxproj:
- platform/graphics/IntPointHash.h: Added.
(WTF::IntPointHash::hash):
(WTF::IntPointHash::equal):
(WTF::):
- 12:24 AM Changeset in webkit [55454] by
-
- 2 edits in trunk/WebKit/gtk
2010-03-03 Philippe Normand <pnormand@igalia.com>
Unreviewed, build fix after r55452.
- webkit/webkitwebview.cpp: (DNDContentsRequest::webkit_web_view_settings_notify): added missing braces.
- 12:07 AM Changeset in webkit [55453] by
-
- 3 edits in trunk/JavaScriptCore
2010-03-02 Fridrich Strba <fridrich.strba@bluewin.ch>
Reviewed by Oliver Hunt.
Allow building smoothly on win32 and win64 using GCC
https://bugs.webkit.org/show_bug.cgi?id=35607
- jit/JITStubs.h:
- runtime/Collector.cpp: (JSC::Heap::allocateBlock): (JSC::Heap::freeBlockPtr): (JSC::currentThreadStackBase):
