Context Navigation

css/html.css: Add hgroup as a block element.
editing/htmlediting.cpp: (WebCore::validBlockTag): Add hgroupTag.
html/HTMLElement.cpp: (WebCore::createTagPriorityMap): Returns 5 for hgroupTag. (WebCore::blockTagList): Add hgroupTag.
html/HTMLParser.cpp: (WebCore::HTMLParser::getNode): Add hgroupTag.
html/HTMLTagNames.in: Add hgroup.

9:34 PM Changeset in webkit [55709] by dumi@chromium.org

2 edits in trunk/WebKitTools

Unreviewed, Chromium build fix.

Reverting r55689.

Scripts/webkitpy/layout_tests/run_webkit_tests.py:

9:15 PM Changeset in webkit [55708] by ggaren@apple.com

2 edits in trunk/JavaScriptCore

Windows build fix: 'P' is not a type. Luckily, 'void' is.

wtf/FastMalloc.cpp:

(WTF::fastCheckConsistency):

9:10 PM Changeset in webkit [55707] by ggaren@apple.com

2 edits in trunk/JavaScriptCore

Windows build fix: export a new symbol.

JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:

8:57 PM Changeset in webkit [55706] by ggaren@apple.com

5 edits in trunk/JavaScriptCore

Switching malloc implementations requires a world rebuild
https://bugs.webkit.org/show_bug.cgi?id=35899

Reviewed by Maciej Stachowiak.

wtf/FastMalloc.cpp:

(WTF::fastCheckConsistency):
(WTF::TCMallocStats::fastCheckConsistency):

wtf/FastMalloc.h:
wtf/ValueCheck.h:

(WTF::): Moved pointer checking into a helper function in FastMalloc.cpp,
so you can switch malloc implementations without rebuilding the world.

8:32 PM Changeset in webkit [55705] by tony@chromium.org

4 edits
2 adds in trunk

2010-03-08 Tony Chang <tony@chromium.org>

Reviewed by Adam Barth.

https://bugs.webkit.org/show_bug.cgi?id=32131
Work around a crash when inserting an ordered list. This was caused
by incorrect logic when trying to restore a range from a location.
We compute the offset using TextIterator, but were sometimes using
VisiblePosition::next() to iterate instead.

editing/execCommand/insert-ordered-list-expected.txt: Added.
editing/execCommand/insert-ordered-list.html: Added.

2010-03-08 Tony Chang <tony@chromium.org>

Reviewed by Adam Barth.

https://bugs.webkit.org/show_bug.cgi?id=32131
Crash when inserting an ordered list.

Test: editing/execCommand/insert-ordered-list.html

editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::moveParagraphs):
editing/TextIterator.cpp: (WebCore::TextIterator::rangeFromLocationAndLength):

8:21 PM Changeset in webkit [55704] by ukai@chromium.org

2 edits in trunk/WebKitTools

2010-03-08 Fumitoshi Ukai <ukai@chromium.org>

Reviewed by Adam Barth.

Fix webkit-patch post and land to work well with security bug
https://bugs.webkit.org/show_bug.cgi?id=35733

Bugzilla requires authentication to access security bug page,
so call authenticate() if it failed to fetch bug page.

Scripts/webkitpy/bugzilla.py:

5:47 PM Changeset in webkit [55703] by Simon Fraser

2 edits in trunk/WebKit/mac

2010-03-08 Simon Fraser <Simon Fraser>

Reviewed by Mark Rowe.

Move the new method to the end of the MIG definitions file, to avoid breaking
compatibility between WebKit and older versions of WebKitPluginHost.

Plugins/Hosted/WebKitPluginHost.defs:

5:33 PM Changeset in webkit [55702] by Simon Fraser

8 edits in trunk/WebKit/mac

2010-03-08 Simon Fraser <Simon Fraser>

Reviewed by Kevin Decker.

<rdar://problem/7714340> Need to grab image snapshot of Core Animation plugins

Allow plug-ins using the Core Animation drawing model to be captured when doing a flattening paint,
by sending them a drawRect event as if they were software-painting.

Plugins/Hosted/NetscapePluginInstanceProxy.h:
Plugins/Hosted/NetscapePluginInstanceProxy.mm: (WebKit::NetscapePluginInstanceProxy::snapshot): New snapshot() method that calls over to the plugin host, and then draws the image that comes back.

Plugins/Hosted/WebHostedNetscapePluginView.mm: (-[WebHostedNetscapePluginView drawRect:]): If we don't have a software renderer, but we're doing a flattening paint, then call the snapshot method.

Plugins/Hosted/WebKitPluginHost.defs: Added snapshot method.

Plugins/WebBaseNetscapePluginView.h:
Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView inFlatteningPaint]): New utility method that asks the FrameView whether the current paint behavior is flattening.

Plugins/WebNetscapePluginView.mm: (-[WebNetscapePluginView drawRect:]): If the plug-in is using CA but this is a flattening paint, go ahead and send a drawRect event to the plug-in.

5:14 PM Changeset in webkit [55701] by Darin Adler

3 edits
1 add in trunk

WebCore: Added a test for crash when you quit inside an unload handler.
rdar://problem/6958347

Reviewed by Dan Bernstein.

manual-tests/quit-inside-unload.html: Added.

WebKit/mac: Fix crash when you quit inside an unload handler.
rdar://problem/6958347

Reviewed by Dan Bernstein.

Test: manual-tests/quit-inside-unload.html

WebView/WebView.mm:

(-[WebView _closeWithFastTeardown]): Removed code to set
_private->closed since _close now does this earlier, before
calling this method.
(-[WebView _close]): Moved code to set _private->closed to the
top of this method.
(-[WebView setHostWindow:]): Rewrote the code that forbade
setting the host window after closing so that it only forbids
non-nil host windows. That way, the code to clear away the host
window can run safely after setting _private->closed, yet client
code cannot set a new host window after closing.

5:08 PM Changeset in webkit [55700] by Darin Adler

2 edits in trunk/WebKit/mac

Roll out a file I checked in by accident.

WebView/WebView.mm: Back to previous version.

5:06 PM Changeset in webkit [55699] by Darin Adler

4 edits
2 adds in trunk

2010-03-08 Darin Adler <Darin Adler>

Reviewed by Jon Honeycutt.

Don't auto-play <audio> and <video> elements loaded in background tabs
https://bugs.webkit.org/show_bug.cgi?id=35886
rdar://problem/7117745

manual-tests/video-in-non-frontmost-tab.html: Added.
manual-tests/resources/video-tab.html: Added.

html/HTMLMediaElement.h: Added MediaCanStartListener as a base class, and added the mediaCanStart function as well as a boolean, m_isWaitingUntilMediaCanStart.

html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::HTMLMediaElement): Initialize m_isWaitingUntilMediaCanStart. (WebCore::HTMLMediaElement::~HTMLMediaElement): Call removeMediaCanStartListener if m_isWaitingUntilMediaCanStart is true. (WebCore::HTMLMediaElement::loadInternal): Set m_isWaitingUntilMediaCanStart and call addMediaCanStartListener if canStartMedia is false. (WebCore::HTMLMediaElement::mediaCanStart): Clear m_isWaitingUntilMediaCanStart and call loadInternal.

5:00 PM Changeset in webkit [55698] by cmarrin@apple.com

1 edit in trunk/LayoutTests/platform/mac-leopard/Skipped

Fixed path in mac-leopard Skipped file. Was animation, now animations

4:56 PM Changeset in webkit [55697] by cmarrin@apple.com

2 edits in trunk

This turns back on HW comp on Leopard (which I turned off in http://trac.webkit.org/changeset/55696) if you have WebGL turned on. I've added the failing tests to the Skipped file instead

4:39 PM Changeset in webkit [55696] by cmarrin@apple.com

1 edit in trunk/WebKit/mac/WebView/WebView.mm

Backed out the half of http://trac.webkit.org/changeset/55690 that turned on HW accel for Leopard which was causing LayoutTests to fail

4:38 PM Changeset in webkit [55695] by ap@apple.com

2 edits in trunk/WebKit/chromium

Chromium build fix.

Updated for the removal of "mightDownloadFromHandle".

4:35 PM Changeset in webkit [55694] by Csaba Osztrogonác

2 edits in trunk/WebKit/gtk

[GTK] Unreviewed buildfix after r55688.

webkit/webkitdownload.cpp:

(webkit_download_start):

4:30 PM Changeset in webkit [55693] by Csaba Osztrogonác

2 edits in trunk/WebCore

[GTK] Unreviewed buildfix after r55688.

platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:

(webKitWebSrcStart):

4:26 PM Changeset in webkit [55692] by Csaba Osztrogonác

2 edits in trunk/WebCore

[GTK] Unreviewed buildfix after r55688.

platform/network/soup/ResourceHandleSoup.cpp:

(WebCore::):

4:19 PM Changeset in webkit [55691] by Csaba Osztrogonác

2 edits in trunk/WebCore

[Qt] Unreviewed buildfix after r55688.

platform/network/qt/ResourceHandleQt.cpp:

(WebCore::ResourceHandle::loadResourceSynchronously):

4:11 PM Changeset in webkit [55690] by cmarrin@apple.com

1 edit in trunk/LayoutTests/platform/mac-leopard/Skipped

Added animation/fill-mode-transform.html to Skipped list for Leopard until https://bugs.webkit.org/show_bug.cgi?id=35714 is fixed

3:56 PM Changeset in webkit [55689] by dpranke@chromium.org

2 edits in trunk/WebKitTools

2010-03-04 Dirk Pranke <dpranke@chromium.org>

Reviewed by Dimitry Glazkov.

Fix --clobber-old-results in new-run-webkit-tests.

https://bugs.webkit.org/show_bug.cgi?id=35778

Scripts/webkitpy/layout_tests/run_webkit_tests.py:

3:52 PM Changeset in webkit [55688] by ap@apple.com

8 edits in trunk/WebCore

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=35879
Eliminate m_mightDownloadFromHandle

It was only used on Mac, and unnecessarily complicated the code.

No change in behavior, thus no test.

loader/MainResourceLoader.cpp: (WebCore::MainResourceLoader::loadNow):
loader/ResourceLoader.cpp: (WebCore::ResourceLoader::load):
loader/appcache/ApplicationCacheGroup.cpp: (WebCore::ApplicationCacheGroup::createResourceHandle):
platform/network/ResourceHandle.cpp: (WebCore::ResourceHandle::ResourceHandle): (WebCore::ResourceHandle::create):
platform/network/ResourceHandle.h:
platform/network/ResourceHandleInternal.h: (WebCore::ResourceHandleInternal::ResourceHandleInternal):
platform/network/mac/ResourceHandleMac.mm: (WebCore::ResourceHandle::start):

3:44 PM Changeset in webkit [55687] by pkasting@chromium.org

10 edits in trunk/WebCore

Clean up usage of m_failed in open-source image decoders, part 1.
https://bugs.webkit.org/show_bug.cgi?id=35411

Reviewed by Adam Barth.

Makes setFailed() virtual so subclasses can override it (none do yet) to
do automatic cleanup on failure; makes it return a bool for easy
tailcalling; makes failed() the only way to access m_failed so
subclasses are assured setFailed() won't be bypassed. Plus one or two
other tiny cleanup bits.

Overriding setFailed() is coming in a subsequent patch because it can be
hairy and needs close review.

No functional change, so no tests.

platform/graphics/qt/ImageDecoderQt.cpp:

(WebCore::ImageDecoderQt::setData):
(WebCore::ImageDecoderQt::frameBufferAtIndex):
(WebCore::ImageDecoderQt::internalDecodeSize):
(WebCore::ImageDecoderQt::internalReadImage):
(WebCore::ImageDecoderQt::internalHandleCurrentImage):
(WebCore::ImageDecoderQt::forceLoadEverything):
(WebCore::ImageDecoderQt::clearPointers):

platform/graphics/qt/ImageDecoderQt.h:
platform/image-decoders/ImageDecoder.h:

(WebCore::ImageDecoder::ImageDecoder):
(WebCore::ImageDecoder::setData):
(WebCore::ImageDecoder::setSize):
(WebCore::ImageDecoder::setFailed):
(WebCore::ImageDecoder::failed):

platform/image-decoders/bmp/BMPImageDecoder.cpp:

(WebCore::BMPImageDecoder::isSizeAvailable):
(WebCore::BMPImageDecoder::frameBufferAtIndex):
(WebCore::BMPImageDecoder::processFileHeader):

platform/image-decoders/gif/GIFImageDecoder.cpp:

(WebCore::GIFImageDecoder::setData):
(WebCore::GIFImageDecoder::isSizeAvailable):
(WebCore::GIFImageDecoder::frameBufferAtIndex):
(WebCore::GIFImageDecoder::decode):
(WebCore::GIFImageDecoder::initFrameBuffer):

platform/image-decoders/ico/ICOImageDecoder.cpp:

(WebCore::ICOImageDecoder::decodeAtIndex):
(WebCore::ICOImageDecoder::processDirectory):
(WebCore::ICOImageDecoder::processDirectoryEntries):

platform/image-decoders/jpeg/JPEGImageDecoder.cpp:

(WebCore::JPEGImageReader::decode):
(WebCore::JPEGImageDecoder::setData):
(WebCore::JPEGImageDecoder::isSizeAvailable):
(WebCore::JPEGImageDecoder::frameBufferAtIndex):
(WebCore::JPEGImageDecoder::outputScanlines):
(WebCore::JPEGImageDecoder::decode):

platform/image-decoders/png/PNGImageDecoder.cpp:

(WebCore::decodingFailed):
(WebCore::PNGImageReader::decode):
(WebCore::PNGImageDecoder::setData):
(WebCore::PNGImageDecoder::isSizeAvailable):
(WebCore::PNGImageDecoder::frameBufferAtIndex):
(WebCore::PNGImageDecoder::headerAvailable):
(WebCore::PNGImageDecoder::rowAvailable):
(WebCore::PNGImageDecoder::decode):

platform/image-decoders/png/PNGImageDecoder.h:

3:14 PM Changeset in webkit [55686] by Dimitri Glazkov

7 edits
2 adds in trunk

[Chromium] Reset multiple form submission protection on mouse events.
https://bugs.webkit.org/show_bug.cgi?id=35128

Reviewed by Darin Fisher.

WebKit/chromium:

src/WebViewImpl.cpp:

(WebKit::WebViewImpl::mouseDown):

LayoutTests:

fast/forms/multiple-form-submission-protection-mouse-expected.txt: Copied from LayoutTests/editing/execCommand/copy-without-selection-expected.txt.
fast/forms/multiple-form-submission-protection-mouse.html: Added.

2:54 PM Changeset in webkit [55685] by cmarrin@apple.com

4 edits in trunk

When WebGL is enabled, enable hardware compositing bypassing check for CoreVideo bug fix
https://bugs.webkit.org/show_bug.cgi?id=35759

2:54 PM PythonGuidelines edited by Chris Jerdonek

Added preliminary instructions on how to install new versions of … (diff)

2:45 PM Changeset in webkit [55684] by oliver@apple.com

6 edits in trunk/JavaScriptCore

2010-03-07 Oliver Hunt <oliver@apple.com>

Reviewed by Darin Adler.

TypeInfo is unnecessarily large
https://bugs.webkit.org/show_bug.cgi?id=35850

Reduce the size of the type and flags members to a single
byte each, reducing the size of Structure by 8 bytes.

assembler/MacroAssemblerX86Common.h: (JSC::MacroAssemblerX86Common::branch8): (JSC::MacroAssemblerX86Common::branchTest8): (JSC::MacroAssemblerX86Common::setTest8): Add single byte branches, and correct setTest8 to do a single byte read from memory, and actually store the result
assembler/X86Assembler.h: (JSC::X86Assembler::): (JSC::X86Assembler::cmpb_im): (JSC::X86Assembler::testb_im):
jit/JITCall.cpp: (JSC::JIT::emit_op_construct_verify):
jit/JITOpcodes.cpp: (JSC::JIT::emit_op_instanceof): (JSC::JIT::emit_op_jeq_null): (JSC::JIT::emit_op_jneq_null): (JSC::JIT::emit_op_get_pnames): (JSC::JIT::emit_op_convert_this): (JSC::JIT::emit_op_construct_verify): (JSC::JIT::emit_op_to_jsnumber): (JSC::JIT::emit_op_eq_null): (JSC::JIT::emit_op_neq_null):
runtime/JSTypeInfo.h: (JSC::TypeInfo::TypeInfo): (JSC::TypeInfo::type):

2:38 PM Changeset in webkit [55683] by darin@chromium.org

3 edits in trunk/WebKit/chromium

2010-03-08 Michael Nordman <Michael Nordman>

Reviewed by Darin Fisher.

Quick fix for a chromium unit test failures around r55675 (repaint refactoring).
This change restores the tests for empty rects that were deleted.

https://bugs.webkit.org/show_bug.cgi?id=35878

src/ChromeClientImpl.cpp: (WebKit::ChromeClientImpl::invalidateContentsAndWindow):
src/WebPopupMenuImpl.cpp: (WebKit::WebPopupMenuImpl::invalidateContentsAndWindow):

2:16 PM Changeset in webkit [55682] by Darin Adler

5 edits in trunk/WebCore

2010-03-08 Darin Adler <Darin Adler>

Reviewed by Jon Honeycutt.

https://bugs.webkit.org/show_bug.cgi?id=35876

Fix minor style issues in HTMLMediaElement and classes derived from it.
Made many public members private and protected.

html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::screenRect): Got rid of a stray "const" and retstructured the function to use early return and get rid of a local.

html/HTMLMediaElement.h: Made lots of members private and some protected. Also use private inheritance instead of public. Removed some unneeded includes.

html/HTMLVideoElement.cpp: (WebCore::HTMLVideoElement::parseMappedAttribute): Use player() instead of m_player; HTMLMediaElement data members are now private, not protected. (WebCore::HTMLVideoElement::supportsFullscreen): Ditto. (WebCore::HTMLVideoElement::videoWidth): Ditto. (WebCore::HTMLVideoElement::videoHeight): Ditto. (WebCore::HTMLVideoElement::hasAvailableVideoFrame): Ditto. (WebCore::HTMLVideoElement::webkitEnterFullScreen): Use isFullscreen() instead of m_isFullscreen; same reason. (WebCore::HTMLVideoElement::webkitExitFullScreen): Ditto. (WebCore::HTMLVideoElement::webkitDisplayingFullscreen): Ditto.

html/HTMLVideoElement.h: Removed an unneeded include. Made many public functions private. Got rid of unused paint function, which was replaced with paintCurrentFrameInContext a while back.

2:07 PM Changeset in webkit [55681] by jam@chromium.org

1 edit in trunk/WebKit/chromium/public/WebPluginContainer.h

take out temporary define

1:06 PM Changeset in webkit [55680] by eric@webkit.org

10 edits in trunk

2010-03-08 Joanmarie Diggs <joanmarie.diggs@gmail.com>

Reviewed by Xan Lopez.

https://bugs.webkit.org/show_bug.cgi?id=30895
[Gtk] The accessible hierarchy of tables is significantly incorrect for Atk

platform/gtk/accessibility/table-hierarchy.html:
platform/gtk/accessibility/table-hierarchy-expected.txt:

2010-03-08 Joanmarie Diggs <joanmarie.diggs@gmail.com>

Reviewed by Xan Lopez.

https://bugs.webkit.org/show_bug.cgi?id=30895
[Gtk] The accessible hierarchy of tables is significantly incorrect for Atk

Gives platforms the ability to exclude parts of an AccessibilityTable
from the accessible hierarchy.

accessibility/gtk/AccessibilityObjectAtk.cpp: (AccessibilityObject::accessibilityPlatformIncludesObject):
accessibility/AccessibilityRenderObject.cpp: (AccessibilityRenderObject::determineAccessibilityRole):
accessibility/AccessibilityTable.cpp: (AccessibilityTable::addChildren):
accessibility/AccessibilityTableColumn.h: (accessibilityIsIgnored):
accessibility/AccessibilityTableHeaderContainer.h: (accessibilityIsIgnored):
accessibility/AccessibilityTableRow.cpp: (accessibilityIsIgnored):

12:31 PM Changeset in webkit [55679] by barraclough@apple.com

5 edits in trunk/JavaScriptCore

Reverting 55035, this caused a regression.
(https://bugs.webkit.org/show_bug.cgi?id=35843)

Reviewed by NOBODY (reverting regression).

runtime/JSString.cpp:

(JSC::JSString::resolveRope):
(JSC::JSString::getStringPropertyDescriptor):

runtime/JSString.h:

(JSC::jsSingleCharacterSubstring):
(JSC::JSString::getIndex):
(JSC::JSString::getStringPropertySlot):

runtime/UStringImpl.cpp:
runtime/UStringImpl.h:

12:22 PM Changeset in webkit [55678] by beidson@apple.com

2 edits in trunk/WebKitTools

Followup to https://bugs.webkit.org/show_bug.cgi?id=35532

Reviewed by NOBODY (but suggested by Steve Falkenburg and fixing a boneheaded mistake on my part last week)

DumpRenderTree/win/LayoutTestControllerWin.cpp:

(LayoutTestController::apiTestGoToCurrentBackForwardItem): Can't pass in a null BOOL to WebKit APIs.

12:21 PM Changeset in webkit [55677] by treat@webkit.org

2 edits in trunk/WebKit/win

Unreviewed build fix for Windows.

Patch by Adam Treat <atreat@rim.com> on 2010-03-08

WebCoreSupport/WebChromeClient.cpp:

(WebChromeClient::invalidateContents):

12:03 PM Changeset in webkit [55676] by jianli@chromium.org

3 edits in trunk/WebCore

No review. Fix build break on Tiger intel release.

html/Blob.cpp:
html/Blob.h:

11:43 AM Changeset in webkit [55675] by treat@webkit.org

33 edits in trunk

WebCore: Refactor the HostWindow methods for repaint, scroll, invalidate and blit
of backingstore and window by eliminating the three bools that currently
exist as params of the repaint method.
https://bugs.webkit.org/show_bug.cgi?id=34214

Patch by Adam Treat <atreat@rim.com> on 2010-03-02
Reviewed by Dave Hyatt.

I've added extra methods to provide the hosts with more semantic
information of what is being requested thus eliminating the need for
these bools.

No tests as this change should not introduce any behavior changes in any
of the ports.

https://bugs.webkit.org/show_bug.cgi?id=34214

loader/EmptyClients.h:

(WebCore::EmptyChromeClient::invalidateContents):
(WebCore::EmptyChromeClient::invalidateWindow):
(WebCore::EmptyChromeClient::invalidateContentsAndWindow):
(WebCore::EmptyChromeClient::invalidateContentsForSlowScroll):

page/Chrome.cpp:

(WebCore::Chrome::invalidateContents):
(WebCore::Chrome::invalidateWindow):
(WebCore::Chrome::invalidateContentsAndWindow):
(WebCore::Chrome::invalidateContentsForSlowScroll):

page/Chrome.h:
page/ChromeClient.h:
page/FrameView.cpp:

(WebCore::FrameView::invalidateRect):

platform/HostWindow.h:
platform/ScrollView.cpp:

(WebCore::ScrollView::scrollContents):
(WebCore::ScrollView::wheelEvent):

WebKit/chromium: Adapt the chromium port to the refactoring of repaint methods.

Patch by Adam Treat <atreat@rim.com> on 2010-03-02
Reviewed by Dave Hyatt.

https://bugs.webkit.org/show_bug.cgi?id=34214

src/ChromeClientImpl.cpp:

(WebKit::ChromeClientImpl::invalidateContents):
(WebKit::ChromeClientImpl::invalidateWindow):
(WebKit::ChromeClientImpl::invalidateContentsAndWindow):
(WebKit::ChromeClient::invalidateContentsForSlowScroll):

src/ChromeClientImpl.h:

WebKit/gtk: Adapt the gtk port to the refactoring of repaint methods.

Patch by Adam Treat <atreat@rim.com> on 2010-03-02
Reviewed by Dave Hyatt.

https://bugs.webkit.org/show_bug.cgi?id=34214

WebCoreSupport/ChromeClientGtk.cpp:
WebCoreSupport/ChromeClientGtk.h:

WebKit/haiku: Adapt the haiku port to the refactoring of repaint methods.

Patch by Adam Treat <atreat@rim.com> on 2010-03-02
Reviewed by Dave Hyatt.

https://bugs.webkit.org/show_bug.cgi?id=34214

WebCoreSupport/ChromeClientHaiku.cpp:

(WebCore::ChromeClientHaiku::invalidateContents):
(WebCore::ChromeClientHaiku::invalidateWindow):
(WebCore::ChromeClientHaiku::invalidateContentsAndWindow):
(WebCore::ChromeClient::invalidateContentsForSlowScroll):

WebCoreSupport/ChromeClientHaiku.h:

WebKit/mac: Adapt the mac port to the refactoring of repaint methods.

Patch by Adam Treat <atreat@rim.com> on 2010-03-02
Reviewed by Dave Hyatt.

https://bugs.webkit.org/show_bug.cgi?id=34214

WebCoreSupport/WebChromeClient.h:
WebCoreSupport/WebChromeClient.mm:

(WebChromeClient::invalidateContents):
(WebChromeClient::invalidateWindow):
(WebChromeClient::invalidateContentsAndWindow):
(WebChromeClient::invalidateContentsForSlowScroll):

WebKit/qt: Adapt the qt port to the refactoring of repaint methods.

Patch by Adam Treat <atreat@rim.com> on 2010-03-02
Reviewed by Dave Hyatt.

https://bugs.webkit.org/show_bug.cgi?id=34214

WebCoreSupport/ChromeClientQt.cpp:

(WebCore::ChromeClientQt::invalidateContents):
(WebCore::ChromeClientQt::invalidateWindow):
(WebCore::ChromeClientQt::invalidateContentsAndWindow):
(WebCore::ChromeClientQt::invalidateContentsForSlowScroll):

WebCoreSupport/ChromeClientQt.h:

WebKit/win: Adapt the win port to the refactoring of repaint methods.

Patch by Adam Treat <atreat@rim.com> on 2010-03-02
Reviewed by Dave Hyatt.

https://bugs.webkit.org/show_bug.cgi?id=34214

WebCoreSupport/WebChromeClient.cpp:

(WebChromeClient::invalidateContents):
(WebChromeClient::invalidateWindow):
(WebChromeClient::invalidateContentsAndWindow):
(WebChromeClient::invalidateContentsForSlowScroll):

WebCoreSupport/WebChromeClient.h:

WebKit/wx: Adapt the wx port to the refactoring of repaint methods.

Patch by Adam Treat <atreat@rim.com> on 2010-03-02
Reviewed by Dave Hyatt.

https://bugs.webkit.org/show_bug.cgi?id=34214

WebKitSupport/ChromeClientWx.cpp:

(WebCore::ChromeClientWx::invalidateContents):
(WebCore::ChromeClientWx::invalidateWindow):
(WebCore::ChromeClientWx::invalidateContentsForSlowScroll):
(WebCore::ChromeClientWx::invalidateContentsAndWindow):

WebKitSupport/ChromeClientWx.h:

11:40 AM Changeset in webkit [55674] by eric@webkit.org

3 edits
2 adds in trunk

2010-03-08 Adam Barth <abarth@webkit.org>

Reviewed by Nate Chapin.

[V8] Block popups from inline script
https://bugs.webkit.org/show_bug.cgi?id=35474

Test that we block popups generated from <script>window.open(...)</script>.

http/tests/security/popup-blocked-from-window-open-expected.txt: Added.
http/tests/security/popup-blocked-from-window-open.html: Added.

2010-03-08 Adam Barth <abarth@webkit.org>

Reviewed by Nate Chapin.

[V8] Block popups from inline script
https://bugs.webkit.org/show_bug.cgi?id=35474

Apparently, we're supposed to look at the sourceURL to figure out
whether we're running a script tag or a hyperlink. This logic is
copied from the JSC version.

Test: http/tests/security/popup-blocked-from-window-open.html

bindings/v8/ScriptController.cpp: (WebCore::ScriptController::processingUserGesture): (WebCore::ScriptController::evaluate):

11:22 AM Changeset in webkit [55673] by eric@webkit.org

10 edits
2 adds in trunk

2010-03-08 Stuart Morgan <stuartmorgan@chromium.org>

Reviewed by Darin Adler.

Added a new USE definition for secure text mode on the Mac.
https://bugs.webkit.org/show_bug.cgi?id=31265

wtf/Platform.h:

2010-03-08 Stuart Morgan <stuartmorgan@chromium.org>

Reviewed by Darin Adler.

Move the details of secure text mode into WebCore/platform.
Move the higher-level logic for secure text mode from Frame
to SelectionController.

https://bugs.webkit.org/show_bug.cgi?id=31265

No new tests: no functional changes.

WebCore.gypi:
WebCore.xcodeproj/project.pbxproj:
dom/Document.cpp: (WebCore::Document::setUseSecureKeyboardEntryWhenActive):
editing/SelectionController.cpp: (WebCore::SelectionController::focusedOrActiveStateChanged): (WebCore::SelectionController::updateSecureKeyboardEntryIfActive): (WebCore::SelectionController::setUseSecureKeyboardEntry):
editing/SelectionController.h:
page/Frame.cpp: (WebCore::Frame::setDocument):
page/Frame.h:
platform/SecureTextInput.cpp: Added. (WebCore::enableSecureTextInput): (WebCore::disableSecureTextInput):
platform/SecureTextInput.h: Added. (WebCore::enableSecureTextInput): (WebCore::disableSecureTextInput):

10:49 AM Changeset in webkit [55672] by beidson@apple.com

6 edits
4 adds in trunk

Relax the 3rd party cookie policy in cases where it won't add a new tracking vector.
<rdar://problem/7163012> and https://bugs.webkit.org/show_bug.cgi?id=35824

Reviewed by Anders Carlsson.

WebCore:

Test: http/tests/cookies/third-party-cookie-relaxing.html

If the 3rd-party domain in question already has a cookie set, allow changes
by setting the first party url of the request to be the url of the request itself:

platform/network/cf/ResourceHandleCFNet.cpp:

(WebCore::makeFinalRequest):

Ditto:

platform/network/mac/ResourceHandleMac.mm:

(WebCore::ResourceHandle::start):
(WebCore::ResourceHandle::loadResourceSynchronously):

I've filed <rdar://problem/7728508> to track changing the policy in our networking layer.

LayoutTests:

http/tests/cookies/resources/cookie-utility.php: Added.
http/tests/cookies/resources/third-party-cookie-relaxing-iframe.html: Added.
http/tests/cookies/third-party-cookie-relaxing-expected.txt: Added.
http/tests/cookies/third-party-cookie-relaxing.html: Added.

platform/gtk/Skipped:
platform/qt/Skipped:

10:32 AM Changeset in webkit [55671] by Chris Jerdonek

2 edits in trunk/WebKitTools

Unreviewed.

Fixed incorrect import statement in validate-committer-lists:
webkitpy.BeautifulSoup -> webkitpy.thirdparty.BeautifulSoup.

Scripts/validate-committer-lists:

10:13 AM Changeset in webkit [55670] by jianli@chromium.org

33 edits
2 copies
4 adds in trunk

.: Blob.slice support.
https://bugs.webkit.org/show_bug.cgi?id=32993

Reviewed by Dmitry Titov.

Add ENABLE_BLOB_SLICE feature define.

configure.ac:

JavaScriptCore: Blob.slice support.
https://bugs.webkit.org/show_bug.cgi?id=32993

Reviewed by Dmitry Titov.

Add ENABLE_BLOB_SLICE feature define.
Also fix a problem that JSValue.toInteger is not exposed on Windows.

Configurations/FeatureDefines.xcconfig:
JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:

WebCore: Blob.slice support.
https://bugs.webkit.org/show_bug.cgi?id=32993

Reviewed by Dmitry Titov.

The following semantic is adopted per the discussions on public-webapps:
1) File.slice() does a synchronous IO to capture the current size and

modification time and cache them in the resulting Blob.

2) Subsequent Blob operations, like Blob.slice and Blob.size simply

use the cached values.

3) When the underlying file data are accessed, like in XHR.send(), the

UA will check the cached modification time against the current
modification time to determine if the file has been changed or not.
An error or exception will be thrown if needed.

Also add ENABLE_BLOB_SLICE feature define.

Test: http/tests/local/send-sliced-dragged-file.html

Configurations/FeatureDefines.xcconfig:
GNUmakefile.am:
WebCore.pri:
html/Blob.cpp:

(WebCore::Blob::Blob):
(WebCore::Blob::size):
(WebCore::Blob::slice):

html/Blob.h:

(WebCore::Blob::start):
(WebCore::Blob::length):
(WebCore::Blob::modificationTime):

html/Blob.idl:
platform/network/FormData.cpp:

(WebCore::FormData::deepCopy):
(WebCore::FormData::appendFile):
(WebCore::FormData::appendFileRange):

platform/network/FormData.h:

(WebCore::FormDataElement::FormDataElement):
(WebCore::operator==):

platform/network/mac/FormDataStreamMac.mm:

(WebCore::advanceCurrentStream):
(WebCore::openNextStream):
(WebCore::formCreate):
(WebCore::formOpen):
(WebCore::formRead):
(WebCore::setHTTPBody):

xml/XMLHttpRequest.cpp:

(WebCore::XMLHttpRequest::send):

WebKit/chromium: Blob.slice support.
https://bugs.webkit.org/show_bug.cgi?id=32993

Reviewed by Dmitry Titov.

Add ENABLE_BLOB_SLICE feature define.

features.gypi:

WebKit/mac: Blob.slice support.
https://bugs.webkit.org/show_bug.cgi?id=32993

Reviewed by Dmitry Titov.

Add ENABLE_BLOB_SLICE feature define.

Configurations/FeatureDefines.xcconfig:

WebKitLibraries: Blob.slice support.
https://bugs.webkit.org/show_bug.cgi?id=32993

Reviewed by Dmitry Titov.

Add ENABLE_BLOB_SLICE feature define.

win/tools/vsprops/FeatureDefines.vsprops:
win/tools/vsprops/FeatureDefinesCairo.vsprops:

WebKitTools: Blob.slice support.
https://bugs.webkit.org/show_bug.cgi?id=32993

Reviewed by Dmitry Titov.

Add ENABLE_BLOB_SLICE feature define and flag for build-webkit. It is
currently only turned on for Mac.

Scripts/build-webkit:

LayoutTests: Blob.slice support.
https://bugs.webkit.org/show_bug.cgi?id=32993

Reviewed by Dmitry Titov.

Add a new layout test to test slicing and sending a file. In addition,
two new scripts are introduced to create and touch the temp file.

Move some code from send-dragged-file.js to a new file
setup-file-input-element-for-drag.js so that it can be used by both
send-dragged-file.js and send-sliced-dragged-file.js to setup the input
element for the file dragging.

Since the Blob.slice is only enabled for Mac, we disable the new test
for all other platforms.

fast/dom/Window/window-properties.html:
http/tests/local/resources/file-for-drag-to-send.txt:
http/tests/local/resources/send-dragged-file.js:
http/tests/local/resources/send-sliced-dragged-file.js: Added.
http/tests/local/resources/setup-file-input-element-for-drag.js: Added.
http/tests/local/send-dragged-file.html:
http/tests/local/send-sliced-dragged-file-expected.txt: Added.
http/tests/local/send-sliced-dragged-file.html: Added.
http/tests/resources/touch-temp-file.php: Added.
http/tests/resources/write-temp-file.php: Added.
platform/gtk/Skipped:
platform/qt/Skipped:
platform/win/Skipped:

9:54 AM Changeset in webkit [55669] by dbates@webkit.org

4 edits
4 adds in trunk

2010-03-08 Daniel Bates <dbates@rim.com>

Reviewed by Simon Fraser.

https://bugs.webkit.org/show_bug.cgi?id=34819

Fixes an issue where we repaint the caret rectangle even if the associated
selection is not in a content editable element. This is extraneous since the
caret is only visible when the selection is in a content editable element.
Hence, we should only repaint the caret rectangle when the associated selection
is in a content editable element.

Note, we always paint the caret when caret browsing is enabled.

Test: fast/repaint/no-caret-repaint-in-non-content-editable-element.html

editing/SelectionController.cpp: (WebCore::SelectionController::recomputeCaretRect): Modified to call method SelectionController::shouldRepaintCaret. (WebCore::SelectionController::shouldRepaintCaret): Added. (WebCore::SelectionController::invalidateCaretRect): Modified to call method SelectionController::shouldRepaintCaret.
editing/SelectionController.h:

2010-03-08 Daniel Bates <dbates@rim.com>

Reviewed by Simon Fraser.

https://bugs.webkit.org/show_bug.cgi?id=34819

Tests that we do not repaint the caret rectangle when the associated selection is
not in a content editable element.

fast/repaint/no-caret-repaint-in-non-content-editable-element.html: Added.
platform/mac/fast/repaint/no-caret-repaint-in-non-content-editable-element-expected.checksum: Added.
platform/mac/fast/repaint/no-caret-repaint-in-non-content-editable-element-expected.png: Added.
platform/mac/fast/repaint/no-caret-repaint-in-non-content-editable-element-expected.txt: Added.

9:36 AM Changeset in webkit [55668] by eric.carlson@apple.com

3 edits in trunk/WebCore

2010-03-08 Eric Carlson <eric.carlson@apple.com>

Reviewed by Darin Adler.

YouTube HTML5 video never starts playing on Windows
https://bugs.webkit.org/show_bug.cgi?id=33954

platform/graphics/win/MediaPlayerPrivateQuickTimeWin.cpp: (WebCore::MediaPlayerPrivate::rfc2616DateStringFromTime): New, create an rfc 2616 formatted string for an absolute time value. (WebCore::addCookieParam): New, add a cookie param and value to a string builder. (WebCore::MediaPlayerPrivate::setUpCookiesForQuickTime): Copy cookies for the movie to

be loaded from CFNetwork into WinINet so they are available when QuickTime tries to
download the movie.

(WebCore::MediaPlayerPrivate::load): Call setupCookiesForQuickTime.

platform/graphics/win/MediaPlayerPrivateQuickTimeWin.h:

9:26 AM Changeset in webkit [55667] by dbates@webkit.org

2 edits in trunk/WebKit/win

2010-03-08 Daniel Bates <dbates@rim.com>

Unreviewed, build fix.

Attempt to fix the Windows builds by applying the corresponding change
made in bug #35763 <https://bugs.webkit.org/show_bug.cgi?id=35763>.

WebView.cpp: Removed call to settings->setDatabasesEnabled since this setting no longer exists following changeset 55666 <http://trac.webkit.org/changeset/55666>. (WebView::notifyPreferencesChanged):

8:41 AM Changeset in webkit [55666] by eric@webkit.org

14 edits in trunk

2010-03-08 Eric Uhrhane <ericu@chromium.org>

Reviewed by David Levin.

Remove the now-redundant Settings fields for the Database
https://bugs.webkit.org/show_bug.cgi?id=35763

No new tests; this code isn't called.

WebCore.base.exp:
page/Settings.cpp: (WebCore::Settings::Settings):
page/Settings.h:

2010-03-08 Eric Uhrhane <ericu@chromium.org>

Reviewed by David Levin.

Remove the now-redundant Settings fields for the Database
https://bugs.webkit.org/show_bug.cgi?id=35763

No new tests; this code isn't called.

public/WebSettings.h:
src/WebSettingsImpl.cpp:
src/WebSettingsImpl.h:

2010-03-08 Eric Uhrhane <ericu@chromium.org>

Reviewed by David Levin.

Remove the now-redundant Settings fields for the Database
https://bugs.webkit.org/show_bug.cgi?id=35763

No new tests; this code isn't called.

webkit/webkitwebview.cpp: Remove the calls into Settings. (DNDContentsRequest::webkit_web_view_update_settings): (DNDContentsRequest::webkit_web_view_settings_notify):

2010-03-08 Eric Uhrhane <ericu@chromium.org>

Reviewed by David Levin.

Remove the now-redundant Settings fields for the Database
https://bugs.webkit.org/show_bug.cgi?id=35763

No new tests; this code isn't called.

WebView/WebView.mm: Remove the call into Settings. (-[WebView _preferencesChangedNotification:]):

2010-03-08 Eric Uhrhane <ericu@chromium.org>

Reviewed by David Levin.

Remove the now-redundant Settings fields for the Database
https://bugs.webkit.org/show_bug.cgi?id=35763

No new tests; this code isn't called.

Api/qwebsettings.cpp: (QWebSettingsPrivate::apply): Remove the call into Settings.

7:57 AM Changeset in webkit [55665] by eric@webkit.org

2 edits in trunk/WebKit/qt

2010-03-08 Simon Hausmann <simon.hausmann@nokia.com>

Reviewed by Laszlo Gombos.

[Qt] Binary incompatibility between Qt 4.6's WebKit and trunk in QWebSettings
https://bugs.webkit.org/show_bug.cgi?id=35858

Moved the enum value added in r54873 to the end of the enum, to preserve
binary compatibility. DnsPrefetchEnabled was in the last release and needs
to remain after LocalContentCanAccessRemoteUrls.

Api/qwebsettings.h:

7:41 AM Changeset in webkit [55664] by eric@webkit.org

2 edits
3 adds in trunk/LayoutTests

2010-03-08 Shu Chang <Chang.Shu@nokia.com>

Reviewed by Holger Freyther.

[Qt] Added expected results and remove the test from Skipped.
https://bugs.webkit.org/show_bug.cgi?id=35810

platform/qt/Skipped:
platform/qt/fast/canvas/canvas-incremental-repaint-2-expected.checksum: Added.
platform/qt/fast/canvas/canvas-incremental-repaint-2-expected.png: Added.
platform/qt/fast/canvas/canvas-incremental-repaint-2-expected.txt: Added.

7:07 AM Changeset in webkit [55663] by kov@webkit.org

4 edits in trunk

2010-03-08 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

No review, rolling out r55662.
http://trac.webkit.org/changeset/55662
https://bugs.webkit.org/show_bug.cgi?id=35863

Need to be coordinated with bots setup

http/conf/apache2-debian-httpd.conf:

2010-03-08 Gustavo Noronha Silva <Gustavo Noronha Silva>

No review, rolling out r55662.
http://trac.webkit.org/changeset/55662
https://bugs.webkit.org/show_bug.cgi?id=35863

Need to be coordinated with bots setup

Scripts/run-webkit-tests:

6:23 AM Changeset in webkit [55662] by kov@webkit.org

4 edits in trunk

LayoutTests

2010-03-08 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Reviewed by Holger Freyther.

[GTK] Tests fail when running with ipv6 addresses available, on Debian systems
https://bugs.webkit.org/show_bug.cgi?id=35863

Also listen for SSL requests on the ipv6 address.

http/conf/apache2-debian-httpd.conf:

WebKitTools

2010-03-08 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Reviewed by Holger Freyther.

[GTK] Tests fail when running with ipv6 addresses available, on Debian systems
https://bugs.webkit.org/show_bug.cgi?id=35863

If running on a Debian-based system, also listen on the ipv6 address.

Scripts/run-webkit-tests:

6:08 AM QtWebKitBugs edited by jocelyn.turcotte@nokia.com

(diff)

5:21 AM Changeset in webkit [55661] by kov@webkit.org

2 edits in trunk/LayoutTests

2010-03-08 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

[GTK] DRT needs to support synthesizing double clicks
https://bugs.webkit.org/show_bug.cgi?id=35862

Skip test that needs a new feature in DRT.

platform/gtk/Skipped:

5:16 AM Changeset in webkit [55660] by kov@webkit.org

3 edits in trunk/LayoutTests

2010-03-08 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Unreviewed. Rebaseline two tests that had their expected results
changed.

platform/gtk/inspector/timeline-network-resource-expected.txt:
platform/gtk/svg/css/getComputedStyle-basic-expected.txt:

4:19 AM Changeset in webkit [55659] by jorlow@chromium.org

5 edits in trunk/WebKit/chromium

2010-03-08 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Darin Fisher.

Pass the WebFrame into WebStorageArea::setItem so we can figure out the routing ID
https://bugs.webkit.org/show_bug.cgi?id=35758

This is necessary since setItem is sometimes blocked and the embedder might need
to display some piece of UI associated with such an event.

public/WebStorageArea.h: (WebKit::WebStorageArea::setItem):
src/StorageAreaProxy.cpp: (WebCore::StorageAreaProxy::setItem):
src/WebStorageAreaImpl.cpp: (WebKit::WebStorageAreaImpl::setItem):
src/WebStorageAreaImpl.h:

3:39 AM QtWebKitBugs edited by vestbo@webkit.org

(diff)

3:23 AM QtWebKitBugs edited by vestbo@webkit.org

(diff)

3:19 AM QtWebKitBugs edited by vestbo@webkit.org

(diff)

3:17 AM QtWebKitBugs edited by vestbo@webkit.org

(diff)

2:07 AM QtWebKitBackportingFixes edited by Simon Hausmann

(diff)

2:06 AM QtWebKitRelease20 created by Simon Hausmann

2:06 AM QtWebKit edited by Simon Hausmann

(diff)

2:04 AM QtWebKitBackportingFixes edited by Simon Hausmann

(diff)

1:57 AM QtWebKit edited by Simon Hausmann

(diff)

12:16 AM Changeset in webkit [55658] by zecke@webkit.org

2 edits in trunk/WebKitTools

[iexploder] Automatically update htmltags.in and htmlattrs.in too

https://bugs.webkit.org/show_bug.cgi?id=33755

Change the update-iexploder-cssproperites script to update
the htmlattrs.in and htmltags.in of WebKitTools/iExploder/htdocs
automatically as well.

Change the reading and writing code to work with parameters
and extend the method that is parsing the .in files to handle
the HTMLTagNames.in and the HTMLAttributeNames.in files.

Remove custom code to determine the revision of files with a
utility of VCUtils.pm to determine the revision of the directory
these files are located in. This will also work with git checkout.

Scripts/update-iexploder-cssproperties:

12:13 AM Changeset in webkit [55657] by Philippe Normand

3 edits in trunk/WebCore

2010-03-04 Philippe Normand <pnormand@igalia.com>

Reviewed by Eric Seidel.

[GStreamer] replace g_idle_add / g_timeout_add calls with Timers in the gstreamer player
https://bugs.webkit.org/show_bug.cgi?id=35735

Replaced g_idle_add calls with Timers immediately started once
only. The g_timeout_add was replaced by a periodic Timer.

platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivate::MediaPlayerPrivate): (WebCore::MediaPlayerPrivate::~MediaPlayerPrivate): (WebCore::MediaPlayerPrivate::volumeChangedTimerFired): (WebCore::MediaPlayerPrivate::volumeChanged): (WebCore::MediaPlayerPrivate::processBufferingStats): (WebCore::MediaPlayerPrivate::fillTimerFired): (WebCore::MediaPlayerPrivate::maxTimeLoaded): (WebCore::MediaPlayerPrivate::updateStates): (WebCore::MediaPlayerPrivate::muteChangedTimerFired): (WebCore::MediaPlayerPrivate::muteChanged):
platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:

Mar 7, 2010:

10:55 PM Changeset in webkit [55656] by hamaji@chromium.org

3 edits in trunk/WebKitTools

2010-03-07 Shinichiro Hamaji <hamaji@chromium.org>

Reviewed by Eric Seidel.

check-webkit-style: false positive for empty loop
https://bugs.webkit.org/show_bug.cgi?id=35717

Scripts/webkitpy/style/processors/cpp.py:
Scripts/webkitpy/style/processors/cpp_unittest.py:

9:02 PM Changeset in webkit [55655] by tkent@chromium.org

1 edit
4 adds in trunk/WebKitTools

2010-03-07 Kent Tamura <tkent@chromium.org>

Reviewed by Dimitri Glazkov.

[DRT/Chromium] Add AccessibilityController and AccessibilityUIElement
https://bugs.webkit.org/show_bug.cgi?id=35774

Add AccessibilityController and AccessibilityUIElement classes,
which are going to be used by DumpRenderTree Chromium port. These
files are based on:

src/webkit/tools/test_shell/accessibility_controller.{cc,h} and
src/webkit/tools/test_shell/accessibility_ui_element.{cc,h} of Chromium rev.40492.

DumpRenderTree/chromium/AccessibilityController.cpp: Added.
DumpRenderTree/chromium/AccessibilityController.h: Added.
DumpRenderTree/chromium/AccessibilityUIElement.cpp: Added.
DumpRenderTree/chromium/AccessibilityUIElement.h: Added.

7:56 PM Changeset in webkit [55654] by levin@chromium.org

2 edits in trunk/WebCore

Chromium Linux build fix.

platform/graphics/chromium/FontPlatformDataLinux.h: Add "class String" since a debug

only method returns a String.

7:06 PM Changeset in webkit [55653] by mrowe@apple.com

4 edits in trunk

Chromium build fix.

WebCore:

platform/chromium/ClipboardChromium.cpp: Include Image.h since we're using WebCore::Image.

WebKit/chromium:

src/ChromiumBridge.cpp: Include SharedBuffer.h since WebCore::SharedBuffer is being used.

7:02 PM Changeset in webkit [55652] by mrowe@apple.com

2 edits in trunk/WebKit/win

Windows build fix.

WebKitPrefix.h: Include CoreFoundation/CoreFoundation.h from the Windows prefix header

since some WebCore headers rely on the types declared within being available via the prefix
header.

6:57 PM Changeset in webkit [55651] by mrowe@apple.com

2 edits in trunk/WebCore

Gtk build fix.

platform/network/soup/ResourceHandleSoup.cpp: Include SharedBuffer.h since we're using WebCore::SharedBuffer.

6:51 PM Changeset in webkit [55650] by mrowe@apple.com

2 edits in trunk/WebCore

Gtk build fix.

platform/graphics/gtk/ImageGtk.cpp: Include SharedBuffer.h since we're using WebCore::SharedBuffer.

6:38 PM Changeset in webkit [55649] by mrowe@apple.com

2 edits in trunk/WebCore

Fix builds where USE_CG_SHADING is set.

platform/graphics/cg/GradientCG.cpp: Include wtf/RetainPtr.h since WTF::RetainPtr is used when USE_CG_SHADING is set.

6:33 PM Changeset in webkit [55648] by mrowe@apple.com

4 edits in trunk/WebCore

Windows build fix. Add some required includes.

platform/graphics/win/ImageCGWin.cpp:
platform/network/cf/ResourceHandleCFNet.cpp:
platform/win/ClipboardWin.cpp:

6:29 PM Changeset in webkit [55647] by mrowe@apple.com

2 edits in trunk/WebCore

Gtk build fix.

platform/graphics/GraphicsContext.h: Include wtf/PassOwnPtr.h since some platforms use WTF::PassOwnPtr in this header.

6:27 PM Changeset in webkit [55646] by mrowe@apple.com

2 edits in trunk/WebCore

Qt build fix.

platform/network/qt/ResourceHandleQt.cpp: Include SharedBuffer.h since we're using WebCore::SharedBuffer.

6:23 PM Changeset in webkit [55645] by mrowe@apple.com

2 edits in trunk/WebKit/chromium

Chromium build fix.

src/ResourceHandle.cpp: Include SharedBuffer.h since WebCore::SharedBuffer is being used.

6:18 PM Changeset in webkit [55644] by mrowe@apple.com

2 edits in trunk/WebCore

Gtk build fix.

platform/gtk/ClipboardGtk.cpp: Include Imageh since we're using WebCore::Image.

6:17 PM Changeset in webkit [55643] by mrowe@apple.com

19 edits in trunk

Remove unnecessary includes from header files, adding them to the handful of implementation files that need them.

Rubber-stamped by Cameron Zwarich.

WebCore:

loader/CachedCSSStyleSheet.cpp:
loader/CachedFont.cpp:
loader/CachedImage.cpp:
loader/CachedResource.cpp:
loader/CachedResource.h:
loader/CachedScript.cpp:
loader/CachedXSLStyleSheet.cpp:
loader/icon/IconFetcher.cpp:
loader/loader.cpp:
page/Page.cpp:
platform/graphics/Image.cpp:
platform/graphics/Image.h:
platform/graphics/cg/GraphicsContextPlatformPrivateCG.h:
platform/graphics/cg/PDFDocumentImage.cpp:
platform/graphics/cg/PathCG.cpp:
platform/graphics/mac/ImageMac.mm:

WebKit/mac:

Misc/WebIconDatabase.mm:

6:05 PM Changeset in webkit [55642] by mrowe@apple.com

2 edits in trunk/WebCore

Chromium build fix.

platform/chromium/ChromiumDataObject.h: Include SharedBuffer.h since the inline constructor of this

class means that the pointed-to type of the RefPtr member must be available.

6:05 PM Changeset in webkit [55641] by mrowe@apple.com

2 edits in trunk/WebCore

Qt build fix.

platform/network/qt/DnsPrefetchHelper.cpp: Include PlatformString.h since we're using WebCore::String.

5:53 PM Changeset in webkit [55640] by tkent@chromium.org

3 edits
3 adds
2 deletes in trunk

2010-03-07 Kent Tamura <tkent@chromium.org>

Reviewed by Eric Seidel.

Fix a bug that validity.valueMissing for a radio button with required
in a form element always returns true.
https://bugs.webkit.org/show_bug.cgi?id=35472

Add tests for radio buttons in a form element, and merge an existing
radio button test to ValidityState-valueMissing-radio.html.

fast/forms/ValidityState-valueMissing-007-expected.txt: Removed.
fast/forms/ValidityState-valueMissing-007.html: Removed.
fast/forms/ValidityState-valueMissing-radio-expected.txt: Added.
fast/forms/ValidityState-valueMissing-radio.html: Added.
fast/forms/script-tests/ValidityState-valueMissing-radio.js: Added.

2010-03-07 Kent Tamura <tkent@chromium.org>

Reviewed by Eric Seidel.

Fix a bug that validity.valueMissing for a radio button with required
in a form element always returns true.
https://bugs.webkit.org/show_bug.cgi?id=35472

Test: fast/forms/ValidityState-valueMissing-radio.html

html/HTMLInputElement.cpp: (WebCore::checkedRadioButtons): Move the location to be used by valueMissing(). (WebCore::HTMLInputElement::valueMissing): Use checkedRadioButtons() instead of document()->checkedRadioButtons().

5:52 PM Changeset in webkit [55639] by mrowe@apple.com

12 edits in trunk

Remove unnecessary includes from header files, adding them to the handful of implementation files that need them.

Rubber-stamped by Cameron Zwarich.

WebCore:

bindings/objc/DOM.mm:
loader/CachedImage.h:
loader/EmptyClients.h:
platform/graphics/GlyphPageTreeNode.cpp:
platform/text/CString.h:
platform/text/String.cpp:
platform/text/mac/TextCodecMac.cpp:
svg/graphics/SVGResourceFilter.h:
svg/graphics/filters/SVGFEImage.h:

WebKit/mac:

Misc/WebNSPasteboardExtras.mm:

5:52 PM Changeset in webkit [55638] by mrowe@apple.com

2 edits in trunk/WebCore

Completely remove two files that were deleted in r55635 from the Xcode project.

WebCore.xcodeproj/project.pbxproj:

5:26 PM Changeset in webkit [55637] by weinig@apple.com

7 edits in trunk

Remove inconsistent "Too few arguments" handling for window.atob() and window.btoa()
https://bugs.webkit.org/show_bug.cgi?id=35848

Reviewed by Dan Bernstein.

WebCore:

Take the opportunity to fully autogenerate window.atob() and window.btoa().

bindings/js/JSDOMWindowCustom.cpp:
page/DOMWindow.cpp:

(WebCore::DOMWindow::btoa):
(WebCore::DOMWindow::atob):

page/DOMWindow.idl:

LayoutTests:

fast/dom/Window/atob-btoa-expected.txt:
fast/dom/Window/atob-btoa.html:

5:02 PM PythonGuidelines edited by Chris Jerdonek

Minor updates. Added a FIXME to include upgrade instructions. (diff)

10:15 AM Changeset in webkit [55636] by mitz@apple.com

4 edits
2 adds in trunk

<rdar://problem/7722008> Column breaking ignores floats
https://bugs.webkit.org/show_bug.cgi?id=35837

Reviewed by Simon Fraser.

WebCore:

Test: fast/multicol/float-truncation.html

Introduce an earlier column-break if otherwise a float that could fit
inside a single column will be split between columns.

It is still possible for floats to be needlessly broken if initially
they fit in the column, but normal flow truncation then shortens the
column.

rendering/RenderBlock.cpp:

(WebCore::RenderBlock::visibleTopOfHighestFloatExtendingBelow): Added.
Returns the visible top of the highest descendant float that visibly
extends below the given y offset, ignoring floats that are taller than
the given maximum height.
(WebCore::RenderBlock::layoutColumns): If the initial column height
would cause a float to be split, truncate above the float.

rendering/RenderBlock.h:

LayoutTests:

fast/multicol/float-truncation-expected.txt: Added.
fast/multicol/float-truncation.html: Added.

8:59 AM Changeset in webkit [55635] by dimich@chromium.org

24 edits
9 deletes in trunk

Not reviewed. Revert of r55593 which caused a regression of worker-cloneports.html.

REGRESSION(55593?): fast/workers/worker-cloneport.html is timing out on Leopard
https://bugs.webkit.org/show_bug.cgi?id=35819

WebCore:

Android.jscbindings.mk:
Android.v8bindings.mk:
GNUmakefile.am:
WebCore.gypi:
WebCore.pro:
WebCore.vcproj/WebCore.vcproj:
WebCore.xcodeproj/project.pbxproj:
bindings/js/JSDOMWindowCustom.cpp:
bindings/js/JSDatabaseCallback.cpp: Removed.
bindings/js/JSDatabaseCallback.h: Removed.
bindings/v8/custom/V8DOMWindowCustom.cpp:
bindings/v8/custom/V8DatabaseCallback.cpp: Removed.
bindings/v8/custom/V8DatabaseCallback.h: Removed.
dom/Document.cpp:

(WebCore::Document::postTask):

page/DOMWindow.cpp:

(WebCore::DOMWindow::openDatabase):

page/DOMWindow.h:
page/DOMWindow.idl:
storage/Database.cpp:

(WebCore::Database::openDatabase):
(WebCore::Database::Database):
(WebCore::Database::performOpenAndVerify):

storage/Database.h:
storage/DatabaseCallback.h: Removed.
workers/WorkerContext.cpp:

(WebCore::WorkerContext::openDatabase):

workers/WorkerContext.h:

LayoutTests:

fast/frames/resources/sandboxed-iframe-storage-allowed.html:
fast/frames/resources/sandboxed-iframe-storage-disallowed.html:
fast/frames/sandboxed-iframe-storage-expected.txt:
storage/open-database-creation-callback-expected.txt: Removed.
storage/open-database-creation-callback-isolated-world-expected.txt: Removed.
storage/open-database-creation-callback-isolated-world.html: Removed.
storage/open-database-creation-callback.html: Removed.
platform/qt/Skipped:
platform/mac-leopard/Skipped: Enable the temporarily disabled test back.

12:16 AM Changeset in webkit [55634] by eric@webkit.org

2 edits in trunk/JavaScriptCore

2010-03-07 Jedrzej Nowacki <jedrzej.nowacki@nokia.com>

Reviewed by Simon Hausmann.

Small performance fix in the QScriptConverter::toString().

The QByteArray was replaced by the QVarLengthArray which doesn't
have to allocate any memory on heap.

[Qt] QScriptConverter::toString() should use QVarLengthArray instead of QByteArray
https://bugs.webkit.org/show_bug.cgi?id=35577

qt/api/qscriptconverter_p.h: (QScriptConverter::toString):

Note: See TracTimeline for information about the timeline view.

Download in other formats:

RSS Feed