⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Mar 11, 2010:

11:24 PM Changeset in webkit [55891] by eric@webkit.org
  • 4 edits in trunk/WebCore

2010-03-11 Simon Hausmann <simon.hausmann@nokia.com>

Reviewed by Laszlo Gombos.

[Qt] Enable network state notifier when compiling against Qt 4.7
https://bugs.webkit.org/show_bug.cgi?id=35983

  • WebCore.pri:
  • platform/network/qt/NetworkStateNotifierPrivate.h:
  • platform/network/qt/NetworkStateNotifierQt.cpp:
11:07 PM Changeset in webkit [55890] by eric@webkit.org
  • 8 edits in trunk/WebCore

2010-03-11 Benjamin Poulain <benjamin.poulain@nokia.com>

Reviewed by Adam Treat.

Do not render the full frame when there is some elements with fixed positioning
https://bugs.webkit.org/show_bug.cgi?id=33150

The frame view take into acount the list of fixed object when scrolling
the view. If the number of object is lower than a certain threshold, the pixel
are blitted, and the invalidated area updated.

  • page/FrameView.cpp: (WebCore::FrameView::FrameView): (WebCore::FrameView::useSlowRepaints): (WebCore::FrameView::useSlowRepaintsIfNotOverlapped): (WebCore::FrameView::addFixedObject): (WebCore::FrameView::removeFixedObject): (WebCore::FrameView::scrollContentsFastPath):
  • page/FrameView.h:
  • platform/ScrollView.cpp: (WebCore::ScrollView::scrollContents): (WebCore::ScrollView::scrollContentsFastPath):
  • platform/ScrollView.h:
  • rendering/RenderBlock.h: (WebCore::RenderBlock::positionedObjects):
  • rendering/RenderBox.cpp: (WebCore::RenderBox::styleWillChange):
  • rendering/RenderObject.cpp: (WebCore::RenderObject::styleWillChange):
10:46 PM Changeset in webkit [55889] by eric@webkit.org
  • 2 edits in trunk/JavaScriptCore

2010-03-11 Kent Hansen <kent.hansen@nokia.com>

Reviewed by Simon Hausmann.

Mac OS X: Use deployment target to determine whether memory tagging should be enabled
https://bugs.webkit.org/show_bug.cgi?id=34888

Use TARGETING_TIGER rather than BUILDING_ON_TIGER to determine the tags.

  • wtf/VMTags.h:
10:11 PM Changeset in webkit [55888] by eric@webkit.org
  • 12 edits in trunk

2010-03-11 Aaron Boodman <aa@chromium.org>

Kill WebDocument::applicationID() (part 1).

Modify interface to WebCore::NotificationPresenter::checkPermission()
and remove implementation of WebDocument::applicationID(). Breaking
API changes will be in a subsequent change.
https://bugs.webkit.org/show_bug.cgi?id=35846

  • notifications/Notification.cpp: (WebCore::Notification::Notification):
  • notifications/NotificationCenter.cpp: (WebCore::NotificationCenter::checkPermission):
  • notifications/NotificationPresenter.h:

2010-03-11 Aaron Boodman <aa@chromium.org>

Kill WebDocument::applicationID() (part 1).

Modify interface to WebCore::NotificationPresenter::checkPermission()
and remove implementation of WebDocument::applicationID(). Breaking
API changes will be in a subsequent change.
https://bugs.webkit.org/show_bug.cgi?id=35846

  • public/WebNotificationPresenter.h:
  • src/NotificationPresenterImpl.cpp: (WebKit::NotificationPresenterImpl::checkPermission):
  • src/NotificationPresenterImpl.h:
  • src/WebDocument.cpp: (WebKit::WebDocument::applicationID):

2010-03-11 Aaron Boodman <aa@chromium.org>

Kill WebDocument::applicationID() (part 1).

Modify interface to WebCore::NotificationPresenter::checkPermission()
and remove implementation of WebDocument::applicationID(). Breaking
API changes will be in a subsequent change.
https://bugs.webkit.org/show_bug.cgi?id=35846

  • WebCoreSupport/WebDesktopNotificationsDelegate.cpp: (WebDesktopNotificationsDelegate::checkPermission):
  • WebCoreSupport/WebDesktopNotificationsDelegate.h:
9:41 PM Changeset in webkit [55887] by eric@webkit.org
  • 2 edits in trunk/JavaScriptCore

2010-03-11 Jedrzej Nowacki <jedrzej.nowacki@nokia.com>

Reviewed by Simon Hausmann.

The JSNative state was renamed to JSPrimitive. The new name better
coresponds to the ECMAScript standard.

Enum QScriptValuePrivate::States was renamed to State to obey Qt
coding style rules ("States" name suggests that a state could
mixed together with an other state using bitwise logic operators.

[Qt] QScriptValuePrivate::States has naming issues
https://bugs.webkit.org/show_bug.cgi?id=35968

  • qt/api/qscriptvalue_p.h: (QScriptValuePrivate::): (QScriptValuePrivate::QScriptValuePrivate): (QScriptValuePrivate::isBool): (QScriptValuePrivate::isNumber): (QScriptValuePrivate::isNull): (QScriptValuePrivate::isString): (QScriptValuePrivate::isUndefined): (QScriptValuePrivate::toString): (QScriptValuePrivate::toNumber): (QScriptValuePrivate::toBool): (QScriptValuePrivate::assignEngine): (QScriptValuePrivate::refinedJSValue):
9:24 PM Changeset in webkit [55886] by eric@webkit.org
  • 3 edits in trunk/LayoutTests

2010-03-11 Shu Chang <Chang.Shu@nokia.com>

Reviewed by David Levin.

[Qt] Rebaseline the test and remove it from Skipped.
https://bugs.webkit.org/show_bug.cgi?id=35969

  • platform/qt/Skipped:
  • platform/qt/fast/canvas/canvas-resize-reset-expected.txt:
8:39 PM Changeset in webkit [55885] by barraclough@apple.com
  • 2 edits in trunk/JavaScriptCore

Add export.

Reviewed by NOBODY (Windows build fix).

8:36 PM Changeset in webkit [55884] by ukai@chromium.org
  • 2 edits in trunk/WebKitTools

2010-03-11 Fumitoshi Ukai <ukai@chromium.org>

Unreviewed.

Fix typo in websocket_server.py

  • Scripts/webkitpy/layout_tests/port/websocket_server.py:
8:07 PM Changeset in webkit [55883] by barraclough@apple.com
  • 2 edits in trunk/JavaScriptCore

Add export.

Reviewed by NOBODY (Windows build fix).

7:51 PM Changeset in webkit [55882] by dimich@chromium.org
  • 9 edits in trunk/WebCore

[v8] Remove obsolete code for delayed dereferencing of DOM objects for single-heap, multithread v8 usage.
https://bugs.webkit.org/show_bug.cgi?id=36043

Reviewed by David Levin.

No new tests, no changes in functionality.

  • bindings/v8/DOMData.cpp:

(WebCore::DOMData::DOMData):

  • bindings/v8/DOMData.h:

(WebCore::DOMData::handleWeakObject):

  • bindings/v8/DOMDataStore.cpp:
  • bindings/v8/DOMDataStore.h:

(WebCore::DOMDataStore::domObjectMap):
(WebCore::DOMDataStore::activeDomObjectMap):
(WebCore::DOMDataStore::domSvgElementInstanceMap):
(WebCore::DOMDataStore::domSvgObjectWithContextMap):

  • bindings/v8/ScopedDOMDataStore.cpp:

(WebCore::ScopedDOMDataStore::ScopedDOMDataStore):

  • bindings/v8/StaticDOMDataStore.cpp:

(WebCore::StaticDOMDataStore::StaticDOMDataStore):

  • bindings/v8/StaticDOMDataStore.h:
  • bindings/v8/V8DOMMap.cpp:

(WebCore::removeAllDOMObjectsInCurrentThread):

7:25 PM Changeset in webkit [55881] by barraclough@apple.com
  • 4 edits in trunk

Rubber stamped by Oliver Hunt.

Remove nonsense comments used in development & commited in error.

JavaScriptCore:

  • runtime/UStringImpl.h:

WebCore:

  • platform/text/StringImpl.h:
7:22 PM Changeset in webkit [55880] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2010-03-11 Garret Kelly <gdk@chromium.org>

Reviewed by Darin Adler.

Fixing minor typo in the commit queue status page.
https://bugs.webkit.org/show_bug.cgi?id=35979

  • Scripts/webkitpy/commands/queues.py:
7:20 PM Changeset in webkit [55879] by barraclough@apple.com
  • 2 edits in trunk/JavaScriptCore

Remove export.

Reviewed by NOBODY (Windows build fix).

7:14 PM Changeset in webkit [55878] by barraclough@apple.com
  • 8 edits in trunk

https://bugs.webkit.org/show_bug.cgi?id=36041
Remove unnecessary differences in common code between WebCore::StringImpl & JSC::UStringImpl

Reviewed by Oliver Hunt.

Much of the code in WebCore::StringImpl and JSC::UStringImpl is now very similar,
but has trivial and unnecessary formatting differences, such as the exact wording
of comments, missing ASSERTs, functions implemented in the .h vs .cpp etc.

JavaScriptCore:

  • runtime/Identifier.cpp:

(JSC::Identifier::add): UStringImpl::empty() now automatically hashes, uas per WebCore strings.
(JSC::Identifier::addSlowCase): UStringImpl::empty() now automatically hashes, uas per WebCore strings.

  • runtime/UStringImpl.cpp:

(JSC::UStringImpl::~UStringImpl): Only call bufferOwnership() once, add missing ASSERTs.
(JSC::UStringImpl::createUninitialized): Move from .h, not commonly called, no need to inline.
(JSC::UStringImpl::create): Move from .h, not commonly called, no need to inline.
(JSC::UStringImpl::sharedBuffer): Rewritten to more closely match WebCore implementation, remove need for separate baseSharedBuffer() method.

  • runtime/UStringImpl.h:

(JSC::UStringImpl::UStringImpl): Automatically hash static strings, ASSERT m_data & m_length are non-null/non-zero in non-static strings.
(JSC::UStringImpl::setHash): Add missing ASSERT.
(JSC::UStringImpl::create): Moved to .cpp / added missing check for empty string creation.
(JSC::UStringImpl::adopt): Vector.size() returns size_t, not unsigned.
(JSC::UStringImpl::cost): Renamed m_bufferSubstring -> m_substringBuffer
(JSC::UStringImpl::hash): Reordered in file.
(JSC::UStringImpl::existingHash): Reordered in file.
(JSC::UStringImpl::computeHash): Reordered in file, renamed parameter.
(JSC::UStringImpl::checkConsistency): rewrote ASSERT.
(JSC::UStringImpl::bufferOwnership): Return type should be BufferOwnership.
(JSC::UStringImpl::): Moved friends to head of class.

WebCore:

  • platform/text/StringImpl.cpp:

(WebCore::StringImpl::empty): Reordered in file, made empty()->characters() return a non-null value to match JSC.
(WebCore::StringImpl::createUninitialized): Added overflow check.
(WebCore::StringImpl::create): Reordered in file.
(WebCore::StringImpl::sharedBuffer): Reordered in file.

  • platform/text/StringImpl.h:

(WebCore::StringImpl::): Remove ThreadGlobalData as friend, move SharableUChar & SharedUChar to WebCore namespace.
(WebCore::StringImpl::StringImpl): Made static constructor method (used to create empty string) take arguments, to match JSC & prevent accidental use.
(WebCore::StringImpl::setHash): Added missing ASSERT.
(WebCore::StringImpl::adopt): Make adpot work with Vectors with a non-zero inline capacity.
(WebCore::StringImpl::characters): Mark as const to match JSC.
(WebCore::StringImpl::hash): Use !m_hash instead of m_hash == 0.
(WebCore::StringImpl::computeHash): Remove redundant 'inline'.

7:04 PM Changeset in webkit [55877] by eric@webkit.org
  • 2 edits in trunk/WebKit/chromium

2010-03-11 Stuart Morgan <stuartmorgan@chromium.org>

Reviewed by Darin Fisher.

Fix the screen coordinate conversion of Chromium Mac mouse events for
multiple-moniter setups. Also changes the global coordinate values
to be computed from the event, rather than the instantaneous mouse
location, and reduces code duplication for location conversion.

Dual-sided patch with http://codereview.chromium.org/751002

https://bugs.webkit.org/show_bug.cgi?id=35950

  • src/mac/WebInputEventFactory.mm: (WebKit::setWebEventLocationFromEventInView): (WebKit::WebInputEventFactory::mouseEvent): (WebKit::WebInputEventFactory::mouseWheelEvent):
6:47 PM Changeset in webkit [55876] by eric@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

2010-03-11 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Darin Adler.

Applying h1 format to text node after HR tag fails to include first letter of text node.
https://bugs.webkit.org/show_bug.cgi?id=30148

This patch adds a test case to the above bug, which has been fixed by
http://trac.webkit.org/changeset/55705.

  • editing/style/heading-text-after-hr-expected.txt: Added.
  • editing/style/heading-text-after-hr.html: Added.
6:37 PM Changeset in webkit [55875] by ukai@chromium.org
  • 2 edits in trunk/WebKitTools

2010-03-11 Fumitoshi Ukai <ukai@chromium.org>

Unreviewed.

Fix for WebSocket layout test runner on chromium/win port.

  • Scripts/webkitpy/layout_tests/port/websocket_server.py: register_cygwin and set CYGWIN_PATH
6:20 PM Changeset in webkit [55874] by eric@webkit.org
  • 1 edit
    2 adds in trunk/WebKit

2010-03-11 Leandro Pereira <leandro@profusion.mobi>

Reviewed by Gustavo Noronha Silva.

Add EFL port files to efl/WebCoreSupport.
http://webkit.org/b/35917

  • efl/WebCoreSupport/InspectorClientEfl.h: Added.
  • efl/WebCoreSupport/InspectorClientEfl.cpp: Added.
6:15 PM Changeset in webkit [55873] by jianli@chromium.org
  • 4 edits
    3 adds in trunk/LayoutTests

Add more test cases for Blob.slice.
https://bugs.webkit.org/show_bug.cgi?id=36038

Reviewed by Dmitry Titov.

  • http/tests/local/resources/abe.png: Copied from LayoutTests/editing/resources/abe.png.
  • http/tests/local/resources/empty.txt: Copied from LayoutTests/http/tests/appcache/resources/empty.txt.
  • http/tests/local/resources/send-sliced-dragged-file.js:
  • http/tests/local/send-sliced-dragged-file-expected.txt:
  • http/tests/resources/post-and-verify.cgi: Added.
  • http/tests/resources/write-temp-file.php:
6:03 PM Changeset in webkit [55872] by eric@webkit.org
  • 1 edit
    2 adds in trunk/WebKit

2010-03-11 Leandro Pereira <leandro@profusion.mobi>

Reviewed by Gustavo Noronha Silva.

Add EFL port files to efl/WebCoreSupport.
http://webkit.org/b/35914

  • efl/WebCoreSupport/DragClientEfl.h: Added.
  • efl/WebCoreSupport/DragClientEfl.cpp: Added.
5:53 PM Changeset in webkit [55871] by mrowe@apple.com
  • 10 edits in trunk

<rdar://problem/7745082> Make it possible to build WebKit for older Mac OS X versions from the current Mac OS X version

Reviewed by David Kilzer.

Default to using the appropriate SDK if the target Mac OS X version is not the current Mac OS X version.

JavaScriptCore:

  • Configurations/Base.xcconfig:

JavaScriptGlue:

  • Configurations/Base.xcconfig:

WebCore:

  • Configurations/Base.xcconfig:

WebKit/mac:

  • Configurations/Base.xcconfig:

WebKitTools:

  • DumpRenderTree/mac/Configurations/Base.xcconfig:
5:37 PM Changeset in webkit [55870] by eric@webkit.org
  • 4 edits
    4 adds in trunk

2010-03-11 Jungshik Shin <jshin@chromium.org>

[Chromium]: Plane 2 characters are rendered "blank"

(not even empty boxes) on Windows even when there are fonts to
cover them.

https://bugs.webkit.org/show_bug.cgi?id=35605

Test:LayoutTests/fast/text/international/plane2.html

  • platform/graphics/chromium/FontCacheChromiumWin.cpp: (WebCore::LookupAltName): Add two ExtB fonts to the array (namePairs) that are used for Plane 2 character rendering. (WebCore::FontCache::getFontDataForCharacters): Add two more fonts to the fallback font list
  • platform/graphics/chromium/FontUtilsChromiumWin.cpp: (WebCore::getFallbackFamily): Fix the fallback font lookup to cover Plane 2 (CJK ExtB).
5:20 PM Changeset in webkit [55869] by eric@webkit.org
  • 1 edit
    1 add in trunk/WebCore

2010-03-11 Leandro Pereira <leandro@profusion.mobi>

Reviewed by Holger Freyther.

Add EFL port files to platform/efl.
http://webkit.org/b/35889

  • platform/efl/SystemTimeEfl.cpp: Added.
4:50 PM Changeset in webkit [55868] by victorw@chromium.org
  • 2 edits in trunk/WebKitTools

2010-03-11 Victor Wang <victorw@chromium.org>

Reviewed by Dimitri Glazkov.

rebaseline_chromium_webkit_tests can generate new baselines for
all platforms so it needs to know two ports in order to work correctly:
the port that the script is running on and the port that it generates
new baselines for. Update rebaselining tool to handle both port correctly.

https://bugs.webkit.org/show_bug.cgi?id=36032

  • Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
4:44 PM Changeset in webkit [55867] by mrowe@apple.com
  • 26 edits in trunk

<rdar://problem/7745082> Make it possible to build WebKit for older Mac OS X versions from the current Mac OS X version

Reviewed by Tim Hatcher.

Introduce TARGET_MAC_OS_X_VERSION_MAJOR to represent the Mac OS X version that is being targeted. It defaults to the
current Mac OS X version unless otherwise specified.

Key off TARGET_MAC_OS_X_VERSION_MAJOR where we'd previously been keying off MAC_OS_X_VERSION_MAJOR.

Explicitly map from the target Mac OS X version to the preferred compiler since Xcode's default compiler choice
may not be usable when targetting a different Mac OS X version.

Key off TARGET_GCC_VERSION rather than MAC_OS_X_VERSION_MAJOR in locations where we'd previously been keying off
MAC_OS_X_VERSION_MAJOR but the decision is really related to the compiler version being used.

JavaScriptCore:

  • Configurations/Base.xcconfig:
  • Configurations/DebugRelease.xcconfig:
  • Configurations/FeatureDefines.xcconfig:
  • Configurations/JavaScriptCore.xcconfig:
  • Configurations/Version.xcconfig:

JavaScriptGlue:

  • Configurations/Base.xcconfig:
  • Configurations/DebugRelease.xcconfig:
  • Configurations/Version.xcconfig:
  • JavaScriptGlue.xcodeproj/project.pbxproj:

WebCore:

  • Configurations/Base.xcconfig:
  • Configurations/DebugRelease.xcconfig:
  • Configurations/FeatureDefines.xcconfig:
  • Configurations/Version.xcconfig:
  • Configurations/WebCore.xcconfig:

WebKit/mac:

  • Configurations/Base.xcconfig:
  • Configurations/DebugRelease.xcconfig:
  • Configurations/FeatureDefines.xcconfig:
  • Configurations/Version.xcconfig:

WebKitTools:

  • DumpRenderTree/mac/Configurations/Base.xcconfig:
  • DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
  • DumpRenderTree/mac/DumpRenderTree.mm: Wrap the include of mach-o/getsect.h in 'extern "C"' as some versions of the

header in older SDKs do not do this inside the header.

4:40 PM Changeset in webkit [55866] by darin@chromium.org
  • 14 edits in trunk/WebKit/chromium

2010-03-10 Darin Fisher <darin@chromium.org>

Reviewed by Jeremy Orlow.

Use WebPrivatePtr for WebNode
https://bugs.webkit.org/show_bug.cgi?id=36005

  • public/WebElement.h:
  • public/WebFormElement.h:
  • public/WebInputElement.h:
  • public/WebLabelElement.h:
  • public/WebNode.h: (WebKit::WebNode::WebNode): (WebKit::WebNode::isNull): (WebKit::WebNode::unwrap): (WebKit::WebNode::constUnwrap):
  • public/WebPrivatePtr.h: (WebKit::WebPrivatePtr::assign):
  • src/WebDocument.cpp: (WebKit::WebDocument::WebDocument): (WebKit::WebDocument::operator=): (WebKit::WebDocument::operator PassRefPtr<Document>):
  • src/WebElement.cpp: (WebKit::WebElement::hasTagName): (WebKit::WebElement::WebElement): (WebKit::WebElement::operator=): (WebKit::WebElement::operator PassRefPtr<Element>):
  • src/WebFormElement.cpp: (WebKit::WebFormElement::WebFormElement): (WebKit::WebFormElement::operator=): (WebKit::WebFormElement::operator PassRefPtr<HTMLFormElement>):
  • src/WebInputElement.cpp: (WebKit::WebInputElement::WebInputElement): (WebKit::WebInputElement::operator=): (WebKit::WebInputElement::operator PassRefPtr<HTMLInputElement>):
  • src/WebLabelElement.cpp: (WebKit::WebLabelElement::correspondingControl): (WebKit::WebLabelElement::operator=): (WebKit::WebLabelElement::operator PassRefPtr<HTMLLabelElement>):
  • src/WebNode.cpp: (WebKit::WebNode::reset): (WebKit::WebNode::assign): (WebKit::WebNode::equals): (WebKit::WebNode::parentNode): (WebKit::WebNode::createMarkup): (WebKit::WebNode::addEventListener): (WebKit::WebNode::removeEventListener): (WebKit::WebNode::simulateClick): (WebKit::WebNode::WebNode): (WebKit::WebNode::operator=): (WebKit::WebNode::operator PassRefPtr<Node>):
4:27 PM Changeset in webkit [55865] by jianli@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed. Added the test that time out on Tiger bot to mac-tiger/Skipped.

  • platform/mac-tiger/Skipped:
4:09 PM Changeset in webkit [55864] by andersca@apple.com
  • 27 edits in trunk

Remove invalidateContents, it isn't used and it never makes sense to only invalidate the contents.

Reviewed by David Hyatt.

WebCore:

  • loader/EmptyClients.h:
  • page/Chrome.cpp:
  • page/Chrome.h:
  • page/ChromeClient.h:
  • platform/HostWindow.h:

WebKit/chromium:

  • src/ChromeClientImpl.cpp:
  • src/ChromeClientImpl.h:

WebKit/gtk:

  • WebCoreSupport/ChromeClientGtk.cpp:
  • WebCoreSupport/ChromeClientGtk.h:

WebKit/haiku:

  • WebCoreSupport/ChromeClientHaiku.cpp:
  • WebCoreSupport/ChromeClientHaiku.h:

WebKit/mac:

  • WebCoreSupport/WebChromeClient.h:
  • WebCoreSupport/WebChromeClient.mm:

WebKit/qt:

  • WebCoreSupport/ChromeClientQt.cpp:
  • WebCoreSupport/ChromeClientQt.h:

WebKit/win:

  • WebCoreSupport/WebChromeClient.cpp:
  • WebCoreSupport/WebChromeClient.h:

WebKit/wx:

  • WebKitSupport/ChromeClientWx.cpp:
  • WebKitSupport/ChromeClientWx.h:
4:03 PM Changeset in webkit [55863] by Simon Fraser
  • 3 edits in trunk/LayoutTests

2010-03-11 Simon Fraser <Simon Fraser>

No review.

Need to turn on WebGL explicitly for these tests for Leopard.

  • compositing/webgl/webgl-background-color.html:
  • compositing/webgl/webgl-reflection.html:
4:03 PM Changeset in webkit [55862] by Nate Chapin
  • 9 edits
    1 delete in trunk/WebCore

2010-03-11 Nate Chapin <Nate Chapin>

Reviewed by Dimitri Glazkov.

[V8] Remove DOMObjectsInclude.h and update headers accordingly.

https://bugs.webkit.org/show_bug.cgi?id=36036

  • WebCore.gypi:
  • bindings/v8/DOMData.h:
  • bindings/v8/DOMDataStore.h:
  • bindings/v8/DOMObjectsInclude.h: Removed.
  • bindings/v8/V8DOMMap.cpp:
  • bindings/v8/V8DOMWindowShell.cpp:
  • bindings/v8/V8DOMWrapper.cpp:
  • bindings/v8/V8GCController.cpp:
  • bindings/v8/V8Proxy.cpp:
4:02 PM Changeset in webkit [55861] by ap@apple.com
  • 7 edits
    2 adds in trunk

Reviewed by Geoff Garen.

https://bugs.webkit.org/show_bug.cgi?id=35965
<rdar://problem/7742771> Crash when passing an object returned from plug-in back to the plug-in

Test: plugins/round-trip-npobject.html

  • Plugins/Hosted/NetscapePluginInstanceProxy.mm: (WebKit::NetscapePluginInstanceProxy::retainLocalObject): Corrected the check - there is now a separate ProxyRuntimeObject class for proxy pbjects. (WebKit::NetscapePluginInstanceProxy::releaseLocalObject): Ditto.
  • Plugins/Hosted/ProxyInstance.mm: (WebKit::ProxyInstance::invoke): Check if m_instanceProxy is still non-zero. The plug-in could have crashed while we were waiting for response. (WebKit::ProxyInstance::setFieldValue): Ditto.
3:57 PM Changeset in webkit [55860] by Simon Fraser
  • 2 edits in trunk/WebCore

2010-03-11 Simon Fraser <Simon Fraser>

Reviewed by Mark Rowe.

Remove duplicate entries revealed after sorting.

  • WebCore.xcodeproj/project.pbxproj:
3:35 PM Changeset in webkit [55859] by Simon Fraser
  • 6 edits in trunk

2010-03-11 Simon Fraser <Simon Fraser>

Reviewed by Mark Rowe.

Sort the project files, also fixing some bogus spaces in the WebCore project.

3:14 PM Changeset in webkit [55858] by dimich@chromium.org
  • 6 edits in trunk/LayoutTests

Make appcache layouttests top-frame-*.html more robust for async checking event
https://bugs.webkit.org/show_bug.cgi?id=32047

Reviewed by Alexey Proskuryakov.

Modified the tests to watch for all termination conditions, eliminating the hardcoded
assumed order of the events from separate async event sources.
Also added check for "noupdate" event.

  • http/tests/appcache/top-frame-2.html: Modified to be consistent with the other 2 tests.
  • http/tests/appcache/top-frame-3-expected.txt:
  • http/tests/appcache/top-frame-3.html: Used logic similar to top-frame-2.html to avoid assumption of the events order.
  • http/tests/appcache/top-frame-4-expected.txt:
  • http/tests/appcache/top-frame-4.html: Ditto.
3:13 PM Changeset in webkit [55857] by Simon Fraser
  • 2 edits in trunk/WebKitTools

2010-03-11 Simon Fraser <Simon Fraser>

Reviewed by Oliver Hunt.

https://bugs.webkit.org/show_bug.cgi?id=35905
REGRESSION(55699?): media/video-no-autoplay.html times out on Leopard Commit Bot

Make sure we reset the WebGL preference, so that WebGL doesn't get left
on after being enabled via layoutTestController.overridePreference(),
which in turn causes accelerated compositing to be enabled on Leopard
when we don't want it to be.

  • DumpRenderTree/mac/DumpRenderTree.mm: (resetDefaultsToConsistentValues):
2:42 PM Changeset in webkit [55856] by Nate Chapin
  • 2 edits in trunk/WebCore

2010-03-11 Nate Chapin <Nate Chapin>

Reviewed by Dimitri Glazkov.

Fix style issues and improve comments from
http://trac.webkit.org/changeset/55853.

https://bugs.webkit.org/show_bug.cgi?id=36029

  • platform/animation/TimingFunction.h: (WebCore::TimingFunction::TimingFunction):
2:24 PM Changeset in webkit [55855] by Chris Fleizach
  • 16 edits in trunk/WebCore

accessibilityIsIgnoredBase() needs to respect when platform says include
https://bugs.webkit.org/show_bug.cgi?id=36025

Reviewed by Beth Dakin.

Changed accessibilityIsIgnoredBase() to return a policy instead of a yes/no
answer. This allows the platform to make a yes decision on an element.

  • accessibility/AccessibilityList.cpp:

(WebCore::AccessibilityList::accessibilityIsIgnored):

  • accessibility/AccessibilityListBox.cpp:

(WebCore::AccessibilityListBox::accessibilityIsIgnored):

  • accessibility/AccessibilityObject.h:

(WebCore::):
(WebCore::AccessibilityObject::accessibilityIgnoreAttachment):
(WebCore::AccessibilityObject::accessibilityPlatformIncludesObject):

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::accessibilityIsIgnoredBase):
(WebCore::AccessibilityRenderObject::accessibilityIsIgnored):

  • accessibility/AccessibilityRenderObject.h:
  • accessibility/AccessibilitySlider.cpp:

(WebCore::AccessibilitySlider::accessibilityIsIgnored):

  • accessibility/AccessibilityTable.cpp:

(WebCore::AccessibilityTable::accessibilityIsIgnored):

  • accessibility/AccessibilityTableCell.cpp:

(WebCore::AccessibilityTableCell::accessibilityIsIgnored):

  • accessibility/AccessibilityTableRow.cpp:

(WebCore::AccessibilityTableRow::accessibilityIsIgnored):

  • accessibility/chromium/AccessibilityObjectChromium.cpp:

(WebCore::AccessibilityObject::accessibilityPlatformIncludesObject):

  • accessibility/gtk/AccessibilityObjectAtk.cpp:

(WebCore::AccessibilityObject::accessibilityPlatformIncludesObject):

  • accessibility/mac/AccessibilityObjectMac.mm:

(WebCore::AccessibilityObject::accessibilityPlatformIncludesObject):

  • accessibility/qt/AccessibilityObjectQt.cpp:

(WebCore::AccessibilityObject::accessibilityPlatformIncludesObject):

  • accessibility/win/AccessibilityObjectWin.cpp:

(WebCore::AccessibilityObject::accessibilityPlatformIncludesObject):

  • accessibility/wx/AccessibilityObjectWx.cpp:

(WebCore::AccessibilityObject::accessibilityPlatformIncludesObject):

1:39 PM Changeset in webkit [55854] by kbr@google.com
  • 3 edits in trunk/WebCore

2010-03-11 Kenneth Russell <kbr@google.com>

Reviewed by Dimitri Glazkov.

Fix build breakage with ENABLE_3D_CANVAS=0
https://bugs.webkit.org/show_bug.cgi?id=35995

No new tests; verified in Chromium that WebGL is disabled in
ENABLE_3D_CANVAS=0 builds.

  • bindings/v8/custom/V8DocumentCustom.cpp:
  • bindings/v8/custom/V8HTMLCanvasElementCustom.cpp:
12:24 PM Changeset in webkit [55853] by Nate Chapin
  • 2 edits in trunk/WebCore

2010-03-11 Nate Chapin <Nate Chapin>

Unreviewed, Chromium mac build fix.

Add an explicit copy constructor to TimingFunction.
http://trac.webkit.org/changeset/55835 trigged an inlining
bug in gcc that the copy constructor resolves.

  • platform/animation/TimingFunction.h: (WebCore::TimingFunction::TimingFunction):
12:18 PM Changeset in webkit [55852] by Martin Robinson
  • 3 edits
    1 add
    4 deletes in trunk/LayoutTests

2010-03-11 Martin Robinson <Martin Robinson>

Reviewed by Adam Barth

Convert editing/selection/5136696.html to dumpAsText
https://bugs.webkit.org/show_bug.cgi?id=34306

  • editing/selection/5136696-expected.txt: Added.
  • editing/selection/5136696.html: Use dumpAsText now.
  • platform/gtk/Skipped: Unskip this test in GTK+ now that it has expected result.
  • platform/mac/editing/selection/5136696-expected.checksum: Removed.
  • platform/mac/editing/selection/5136696-expected.png: Removed.
  • platform/mac/editing/selection/5136696-expected.txt: Removed.
  • platform/qt/editing/selection/5136696-expected.txt: Removed.
  • platform/win/editing/selection/5136696-expected.txt: Removed.
12:01 PM Changeset in webkit [55851] by Adam Roben
  • 2 edits in trunk

Teach git about ObjC files

Fixes <http://webkit.org/b/36015>.

Reviewed by Tim Hatcher.

  • .gitattributes: Set the diff attribute for .m and .mm files, and .h

files in Mac-specific directories. This can be used to generate
more-readable diffs of ObjC files.

11:56 AM Changeset in webkit [55850] by dpranke@chromium.org
  • 4 edits in trunk/WebKitTools

2010-03-10 Dirk Pranke <dpranke@chromium.org>

Reviewed by Dimitri Glazkov.

rebaseline_chromium_webkit_tests doesn't handle other plaforms
correctly (e.g., if you run on the Mac platform and try to
rebaseline the WIN results, the result gets written into
platform/mac instead of platform/chromium-win). Also, this script
doesn't work on non-Chromium ports, so we need to fix that at some
point.

https://bugs.webkit.org/show_bug.cgi?id=35982

  • Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
11:28 AM Changeset in webkit [55849] by Chris Fleizach
  • 2 edits in trunk/WebCore

Fixing GTK. No review.

support lang attribute on <option> elements
https://bugs.webkit.org/show_bug.cgi?id=36021

We don't need to cast to AccessibilityRenderObject to get language().

  • accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:

(webkit_accessible_document_get_locale):

11:19 AM Changeset in webkit [55848] by Chris Fleizach
  • 8 edits
    2 adds in trunk

support lang attribute on <option> elements
https://bugs.webkit.org/show_bug.cgi?id=36021

Reviewed by Darin Adler.

WebCore:

Allow non AccessibilityRenderObject classes to access the lang
attribute by moving the useful code into AccessibilityObject.

Test: platform/mac/accessibility/option-with-lang.html

  • accessibility/AccessibilityListBoxOption.cpp:

(WebCore::AccessibilityListBoxOption::language):

  • accessibility/AccessibilityListBoxOption.h:
  • accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::language):

  • accessibility/AccessibilityObject.h:
  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::language):

  • accessibility/AccessibilityRenderObject.h:

LayoutTests:

  • platform/mac/accessibility/option-with-lang-expected.txt: Added.
  • platform/mac/accessibility/option-with-lang.html: Added.
10:48 AM Changeset in webkit [55847] by tonikitoo@webkit.org
  • 4 edits in trunk

[Qt] Access key modifier should be Ctrl+Alt for Darwin derived OS and Alt for the others
https://bugs.webkit.org/show_bug.cgi?id=35993

Patch by Diego Gonzalez <diego.gonzalez@openbossa.org> on 2010-03-11
Reviewed by Simon Hausmann.

WebCore:

  • page/qt/EventHandlerQt.cpp:

(WebCore::EventHandler::accessKeyModifiers):

LayoutTests:

  • platform/qt/Skipped:
10:38 AM Changeset in webkit [55846] by brettw@chromium.org
  • 3 edits in trunk

010-03-08 Brett Wilson <brettw@chromium.org>

Reviewed by Adam Barth.

Remove the deprecated argument to url_util::IsStandard in preparation
for deleting that version of the function. Pull the latest googleurl
with the new version for the Chromium builder.

  • platform/KURLGoogle.cpp: (WebCore::KURL::isHierarchical):
9:02 AM BuildingQtOnSymbian edited by siddharth.mathur@nokia.com
(diff)
9:00 AM BuildingQtOnSymbian edited by siddharth.mathur@nokia.com
running on HW issues (diff)
8:03 AM Changeset in webkit [55845] by Simon Hausmann
  • 2 edits in trunk/WebCore

[Qt] Make it possible to do builds with separate debug info in packages

Reviewed by Tor Arne Vestbø.

  • WebCore.pro:
8:03 AM Changeset in webkit [55844] by Simon Hausmann
  • 2 edits in trunk/WebCore

[Qt] Avoid double-buffering with Qt image decoders

Reviewed by Tor Arne Vestbø.

Pass QIODevice::Unbuffered when opening the QBuffer that
wraps the image data, to hint to Qt that no extra buffering
is needed.

  • platform/graphics/qt/ImageDecoderQt.cpp:

(WebCore::ImageDecoderQt::setData):

7:25 AM Changeset in webkit [55843] by benm@google.com
  • 4 edits in trunk/WebCore

[Android] The platform touch events on Android are missing support
for key modifiers.
https://bugs.webkit.org/show_bug.cgi?id=35521

Reviewed by Jeremy Orlow.

Add support in PlatformToucHEventAndroid for the platform supplying
key modifiers with touch events.

Fixes Android so it now passes basic-single-touch-events.html.

  • page/EventHandler.cpp:

(WebCore::EventHandler::handleTouchEvent): Fix two compiler warnings.

  • platform/PlatformTouchEvent.h:

(WebCore::PlatformTouchEvent::PlatformTouchEvent): Add support for

key modifiers on Android.

  • platform/android/PlatformTouchEventAndroid.cpp:

(WebCore::PlatformTouchEvent::PlatformTouchEvent): ditto.

6:40 AM Changeset in webkit [55842] by Chris Fleizach
  • 2 edits in trunk/LayoutTests

Unreviewed.

VoiceOver can navigate to hidden content in widget (WAI-ARIA)
https://bugs.webkit.org/show_bug.cgi?id=35986

Wrong files were placed in skipped lists.

  • platform/gtk/Skipped:
3:38 AM Changeset in webkit [55841] by steveblock@google.com
  • 5 edits
    3 adds in trunk

2010-03-10 Steve Block <steveblock@google.com>

Reviewed by Jeremy Orlow.

Implements Geolocation maximumAge property
https://bugs.webkit.org/show_bug.cgi?id=30676

Test: fast/dom/Geolocation/maximum-age.html

  • WebCore.xcodeproj/project.pbxproj: Modified. Adds GeolocationPositionCache.h to Private headers
  • page/Geolocation.cpp: Modified. (WebCore::Geolocation::GeoNotifier::setUseCachedPosition): Added. (WebCore::Geolocation::GeoNotifier::runSuccessCallback): Added. (WebCore::Geolocation::GeoNotifier::timerFired): Modified. Added logic to handle using a cached position (WebCore::Geolocation::Watchers::contains): Added. Required to determine if a notifier is a watch request (WebCore::Geolocation::startRequest): Modified. Added logic to check for a cached position (WebCore::Geolocation::requestUsesCachedPosition): Added. Callback to Geolocation object when notifier uses a cached position (WebCore::Geolocation::makeCachedPositionCallbacks): Added. (WebCore::Geolocation::haveSuitableCachedPosition): Added. (WebCore::Geolocation::setIsAllowed): Modified. (WebCore::Geolocation::positionChanged): Modified. Make callbacks using cached position where appropriate (WebCore::Geolocation::geolocationServiceErrorOccurred): Modified. Make callbacks using cached position where appropriate
  • page/Geolocation.h: Modified.

2010-03-10 Steve Block <steveblock@google.com>

Reviewed by Jeremy Orlow.

Implements Geolocation maximumAge property
https://bugs.webkit.org/show_bug.cgi?id=30676

  • fast/dom/Geolocation/resources/maximum-age.js: Added. Checks that a cached position is used only when it should be.
  • fast/dom/Geolocation/maximum-age.html: Added. HTML wraper for above test.
  • fast/dom/Geolocation/maximum-age-expected.txt: Added. Expected result for above test.
2:57 AM Changeset in webkit [55840] by Philippe Normand
  • 2 edits in trunk/LayoutTests

2010-03-11 Philippe Normand <pnormand@igalia.com>

Unreviewed.

Unskip the fixed test that was (accidently?) re-skipped in r54205.

  • platform/gtk/Skipped:
2:25 AM Changeset in webkit [55839] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] storage/open-database-creation-callback-isolated-world.html was introduced in r55823,
but layoutTestController.evaluateScriptInIsolatedWorld() is unimplemented now.

  • platform/qt/Skipped: storage/open-database-creation-callback-isolated-world.html skipped.
2:16 AM Changeset in webkit [55838] by Csaba Osztrogonác
  • 2 edits in trunk/WebCore

Unreviewed buildfix after r55823. (To fix Qt --minimal build.)
I have déjà vu, I'm sure that I did it before. (r55598)

  • bindings/js/JSDOMWindowCustom.cpp: Missing #if ENABLE(DATABASE) guard added.
1:43 AM Changeset in webkit [55837] by Csaba Osztrogonác
  • 3 edits in trunk/WebCore

[Qt] Unreviewed buildfix after r55833.

Rename all instances of data() to characters()

  • bridge/qt/qt_class.cpp:

(JSC::Bindings::QtClass::fieldNamed):

  • bridge/qt/qt_runtime.cpp:

(JSC::Bindings::convertValueToQVariant):

1:29 AM Changeset in webkit [55836] by zoltan@webkit.org
  • 2 edits in trunk/WebCore

2010-03-11 Zoltan Horvath <zoltan@webkit.org>

Reviewed by Simon Hausmann.

Allow custom memory allocation control for RenderLayerBacking class
https://bugs.webkit.org/show_bug.cgi?id=35857

Inherits the following class from Noncopyable because it is
instantiated by 'new' and no need to be copyable:

class name - instantiated at: WebCore/'location'
RenderLayerBacking - rendering/RenderLayer.cpp:3047

  • rendering/RenderLayerBacking.h:
12:41 AM Changeset in webkit [55835] by zoltan@webkit.org
  • 2 edits in trunk/WebCore

2010-03-11 Zoltan Horvath <zoltan@webkit.org>

Reviewed by Simon Hausmann.

Allow custom memory allocation control for TimingFunction struct
https://bugs.webkit.org/show_bug.cgi?id=35855

Inherits the following struct from FastAllocBase because it is
instantiated by 'new':

class name - instantiated at: WebCore/'location'
TimingFuction - platform/graphics/GraphicsLayer.h:89

  • platform/animation/TimingFunction.h:

Mar 10, 2010:

11:53 PM Changeset in webkit [55834] by loki@webkit.org
  • 3 edits in trunk/JavaScriptCore

Buildfix for Thumb-2 after r55684. Add branch8 and branchTest8 functions.
https://bugs.webkit.org/show_bug.cgi?id=35892

Reviewed by Gavin Barraclough.

  • assembler/ARMv7Assembler.h:

(JSC::ARMv7Assembler::):
(JSC::ARMv7Assembler::ldrb):

  • assembler/MacroAssemblerARMv7.h:

(JSC::MacroAssemblerARMv7::load8):
(JSC::MacroAssemblerARMv7::branch8):
(JSC::MacroAssemblerARMv7::branchTest8):
(JSC::MacroAssemblerARMv7::setTest8):

11:19 PM Changeset in webkit [55833] by barraclough@apple.com
  • 15 edits in trunk

Rubber stamped by Oliver Hunt.

Rename JSC::UStringImpl::data() to characters(), to match WebCore::StringImpl.

JavaScriptCore:

  • API/JSClassRef.cpp:

(OpaqueJSClassContextData::OpaqueJSClassContextData):

  • bytecompiler/BytecodeGenerator.cpp:

(JSC::keyForCharacterSwitch):

  • bytecompiler/NodesCodegen.cpp:

(JSC::processClauseList):

  • interpreter/Interpreter.cpp:

(JSC::Interpreter::privateExecute):

  • jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):

  • runtime/ArrayPrototype.cpp:

(JSC::arrayProtoFuncToString):

  • runtime/Identifier.cpp:

(JSC::Identifier::equal):
(JSC::Identifier::addSlowCase):

  • runtime/JSString.cpp:

(JSC::JSString::resolveRope):

  • runtime/UString.cpp:

(JSC::UString::toStrictUInt32):
(JSC::equal):

  • runtime/UString.h:

(JSC::UString::data):

  • runtime/UStringImpl.h:

(JSC::UStringImpl::characters):
(JSC::UStringImpl::hash):
(JSC::UStringImpl::setHash):

WebCore:

  • bridge/jni/jsc/JavaStringJSC.h:

(JSC::Bindings::JavaStringImpl::uchars):

  • platform/text/AtomicString.cpp:

(WebCore::AtomicString::add):
(WebCore::AtomicString::find):

11:07 PM Changeset in webkit [55832] by barraclough@apple.com
  • 2 edits in trunk/WebCore

Fix for r55825, threadsafeCopy no longer needs to special-case for
empty strings (in fact, doing so results in leaks).

Reviewed by Mark Rowe.

  • platform/text/StringImpl.cpp:

(WebCore::StringImpl::threadsafeCopy):

9:30 PM Changeset in webkit [55831] by Chris Fleizach
  • 3 edits in trunk/LayoutTests

Unreviewed.

VoiceOver can navigate to hidden content in widget (WAI-ARIA)
https://bugs.webkit.org/show_bug.cgi?id=35986

Wrong files were placed in skipped lists.

  • platform/gtk/Skipped:
  • platform/win/Skipped:
9:06 PM Changeset in webkit [55830] by Chris Fleizach
  • 3 edits in trunk/LayoutTests

Unreviewed.

VoiceOver can navigate to hidden content in widget (WAI-ARIA)
https://bugs.webkit.org/show_bug.cgi?id=35986

Skip this test since it uses tables and lists, which are not
supported on Tiger/Leopard.

  • platform/mac-leopard/Skipped:
  • platform/mac-tiger/Skipped:
8:09 PM Changeset in webkit [55829] by dbates@webkit.org
  • 2 edits in trunk/WebKitTools

2010-03-10 Daniel Bates <dbates@rim.com>

Reviewed by Simon Hausmann.

https://bugs.webkit.org/show_bug.cgi?id=35840

Updates the subroutine builtDylibPathForName() so that it adds the "d" suffix to
the QtWebKit library name on Windows. This change makes run-launcher work again
under Windows. Moreover, this change corresponds to the change made in change-
set 53924 <http://trac.webkit.org/changeset/53924>.

  • Scripts/webkitdirs.pm:
8:05 PM Changeset in webkit [55828] by bweinstein@apple.com
  • 1 edit in trunk/JavaScriptCore/JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def

Windows build fix - add an missing symbol to be exported

7:23 PM Changeset in webkit [55827] by chang.shu@nokia.com
  • 6 edits in trunk

2010-03-10 Chang Shu <chang.shu@nokia.com>

Reviewed by Darin Adler.

While calculating alpha channel, convert the floating point value to
an integer in [0, 256) with equal distribution.
https://bugs.webkit.org/show_bug.cgi?id=22150

  • css/CSSParser.cpp: (WebCore::CSSParser::parseColorParameters):

2010-03-10 Chang Shu <chang.shu@nokia.com>

Reviewed by Darin Adler.

While calculating alpha channel, convert the floating point value to
an integer in [0, 256) with equal distribution.
Updated test results based on this new behavior.
https://bugs.webkit.org/show_bug.cgi?id=22150

  • fast/canvas/canvas-alphaImageData-behavior-expected.txt:
  • fast/canvas/canvas-alphaImageData-behavior.js:
  • platform/qt/Skipped:
6:38 PM Changeset in webkit [55826] by abarth@webkit.org
  • 1 edit
    2 deletes in trunk/LayoutTests

2010-03-10 Adam Barth <abarth@webkit.org>

Unreviewed.

http/tests/security/xss-DENIED-window-open-javascript-url.html timed out on Windows Debug Bot
https://bugs.webkit.org/show_bug.cgi?id=33349

Remove another test that has the same problem. We need to find a way
to relaibly test what happens when you mix JavaScript URLs and
window.open.

  • http/tests/security/xss-DENIED-window-open-javascript-url-leading-format-char-expected.txt: Removed.
  • http/tests/security/xss-DENIED-window-open-javascript-url-leading-format-char.html: Removed.
6:36 PM Changeset in webkit [55825] by barraclough@apple.com
  • 13 edits in trunk

https://bugs.webkit.org/show_bug.cgi?id=35991
Would be faster to not use a thread specific to implement StringImpl::empty()

Reviewed by Darin Adler, Geoffrey Garen, Maciej Stachowiak.

JavaScriptCore:

Change JSC::UStringImpl's implementation of empty() match to match StringImpl's new implementation
(use a static defined within the empty() method), and change the interface to match too (return
a pointer not a reference).

~0% performance impact (possible minor progression from moving empty() from .h to .cpp).

(JSC::Identifier::add):
(JSC::Identifier::addSlowCase):

  • runtime/PropertyNameArray.cpp:

(JSC::PropertyNameArray::add):

  • runtime/UString.cpp:

(JSC::initializeUString):
(JSC::UString::UString):

  • runtime/UStringImpl.cpp:

(JSC::UStringImpl::empty):
(JSC::UStringImpl::create):

  • runtime/UStringImpl.h:

(JSC::UStringImpl::adopt):
(JSC::UStringImpl::createUninitialized):
(JSC::UStringImpl::tryCreateUninitialized):

WebCore:

Copy JavaScriptCore in making 'static' strings threadsafe, make the empty string a static,
shared by all threads.

~2% progression on Dromaeo DOM core & JS lib tests.

  • platform/ThreadGlobalData.cpp:

(WebCore::ThreadGlobalData::ThreadGlobalData):
(WebCore::ThreadGlobalData::~ThreadGlobalData):

  • platform/ThreadGlobalData.h:

(WebCore::ThreadGlobalData::eventNames):

  • platform/text/StringImpl.cpp:

(WebCore::StringImpl::StringImpl):
(WebCore::StringImpl::empty):

  • platform/text/StringImpl.h:

(WebCore::StringImpl::deref):
(WebCore::StringImpl::hasOneRef):

6:19 PM Changeset in webkit [55824] by Simon Fraser
  • 5 edits in trunk/WebKit/mac

2010-03-10 Simon Fraser <Simon Fraser>

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=35975
<rdar://problem/7739922> Flash 10.1b crashes when generating snapshots

Do a version check before sending a drawRect event to a Flash plugin,
since 10.1.d51 has a bug that crashes when called this way.

  • Plugins/Hosted/WebHostedNetscapePluginView.mm: (-[WebHostedNetscapePluginView drawRect:]):
  • Plugins/WebBaseNetscapePluginView.h:
  • Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView supportsSnapshotting]):
  • Plugins/WebNetscapePluginView.mm: (-[WebNetscapePluginView drawRect:]):
6:18 PM Changeset in webkit [55823] by dumi@chromium.org
  • 21 edits
    9 adds in trunk

WebCore: Adding support for the optional creation callback that could be
passed to openDatabase().

Reviewed by Adam Barth.

Tests: storage/open-database-creation-callback.html

storage/open-database-creation-callback-isolated-world.html

https://bugs.webkit.org/show_bug.cgi?id=34726

  • Android.jscbindings.mk
  • Android.v8bindings.mk
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSDOMWindowCustom.cpp:

(WebCore::JSDOMWindow::openDatabase):

  • bindings/js/JSDatabaseCallback.cpp: Added.

(WebCore::JSDatabaseCallback::JSDatabaseCallback):
(WebCore::JSDatabaseCallback::~JSDatabaseCallback):
(WebCore::JSDatabaseCallback::handleEvent):

  • bindings/js/JSDatabaseCallback.h: Added.

(WebCore::JSDatabaseCallback::create):

  • bindings/v8/custom/V8DOMWindowCustom.cpp:

(WebCore::V8DOMWindow::openDatabaseCallback):

  • bindings/v8/custom/V8DatabaseCallback.cpp: Added.

(WebCore::V8DatabaseCallback::V8DatabaseCallback):
(WebCore::V8DatabaseCallback::~V8DatabaseCallback):
(WebCore::V8DatabaseCallback::handleEvent):

  • bindings/v8/custom/V8DatabaseCallback.h: Added.

(WebCore::V8DatabaseCallback::create):

  • page/DOMWindow.cpp:

(WebCore::DOMWindow::openDatabase):

  • page/DOMWindow.h:
  • page/DOMWindow.idl:
  • storage/Database.cpp:

(WebCore::DatabaseCreationCallbackTask::create):
(WebCore::DatabaseCreationCallbackTask::performTask):
(WebCore::DatabaseCreationCallbackTask::DatabaseCreationCallbackTask):
(WebCore::Database::openDatabase):
(WebCore::Database::Database):
(WebCore::Database::performOpenAndVerify):
(WebCore::Database::performCreationCallback):

  • storage/Database.h:

(WebCore::Database::isNew):

  • storage/DatabaseCallback.h: Added.

(WebCore::DatabaseCallback::~DatabaseCallback):

  • workers/WorkerContext.cpp:

(WebCore::WorkerContext::openDatabase):

  • workers/WorkerContext.h:

LayoutTests: Adding a test to test the creation callback passed to
openDatabase() and another one to make sure it is executed in the
correct world.

Reviewed by Adam Barth.

Also, fixing fast/frames/sandboxed-iframe-storage.html: calling
openDatabase() without at least 4 parameters should always fail,
because the database name, version, description and estimated size
are not optional according to the spec.

https://bugs.webkit.org/show_bug.cgi?id=34726

  • fast/frames/resources/sandboxed-iframe-storage-allowed.html:
  • fast/frames/resources/sandboxed-iframe-storage-disallowed.html:
  • fast/frames/sandboxed-iframe-storage-expected.txt:
  • platform/qt/Skipped:
  • storage/open-database-creation-callback-expected.txt: Added.
  • storage/open-database-creation-callback.html: Added.
  • storage/open-database-creation-callback-isolated-world-expected.txt: Added.
  • storage/open-database-creation-callback-isolated-world.html: Added.
6:07 PM Changeset in webkit [55822] by abarth@webkit.org
  • 3 edits
    2 adds in trunk

2010-03-10 Justin Schuh <jschuh@chromium.org>

Reviewed by Adam Barth.

Make Chrome consistently handle leading format characters in URLs

https://bugs.webkit.org/show_bug.cgi?id=35948

  • http/tests/security/xss-DENIED-window-open-javascript-url-leading-format-char-expected.txt: Added.
  • http/tests/security/xss-DENIED-window-open-javascript-url-leading-format-char.html: Added.

2010-03-10 Justin Schuh <jschuh@chromium.org>

Reviewed by Adam Barth.

Make Chrome consistently handle leading format characters in URLs

https://bugs.webkit.org/show_bug.cgi?id=35948

Test: http/tests/security/xss-DENIED-window-open-javascript-url-leading-format-char.html

  • platform/KURLGoogle.cpp:
5:19 PM Changeset in webkit [55821] by jianli@chromium.org
  • 14 edits
    2 adds in trunk/WebCore

Implementing DOMFormData class.
https://bugs.webkit.org/show_bug.cgi?id=35707

Reviewed by Dmitry Titov.

This patch only addresses the implementation of DOMFormData class and
moves the FormData construction logic from HTMLFormElement::createFormData
to FormData::create() so that it can be used by both HTMLFormElement
and XMLHttpRequest.

The DOMFormData IDL interface will be exposed in another patch and the
test will be added then.

  • Android.mk:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • html/DOMFormData.cpp: Added.
  • html/DOMFormData.h: Added.
  • html/FormDataList.h:

(WebCore::FormDataList::encoding):

  • html/HTMLFormElement.cpp:

(WebCore::HTMLFormElement::createFormData):
(WebCore::HTMLFormElement::submit):

  • html/HTMLFormElement.h:
  • platform/network/FormData.cpp:

(WebCore::FormData::create):
(WebCore::FormData::createMultiPart):
(WebCore::FormData::appendDOMFormData):

  • platform/network/FormData.h:

(WebCore::FormData::boundary):

  • xml/XMLHttpRequest.cpp:

(WebCore::XMLHttpRequest::send):

  • xml/XMLHttpRequest.h:
4:59 PM Changeset in webkit [55820] by darin@chromium.org
  • 4 edits
    3 adds in trunk/WebKit/chromium

2010-03-10 Darin Fisher <darin@chromium.org>

Reviewed by Jeremy Orlow.

Add API wrapper for WebCore::SerializedScriptValue
https://bugs.webkit.org/show_bug.cgi?id=35988

WebSerializedScriptValue is a wrapper around SerializedScriptValue.

WebPrivatePtr is used to simplify wrapping reference counted WebCore
types. This class is used to cleanup WebHistoryItem, and will be used
to clean up other classes in the WebKit API in a follow-up patch.

  • WebKit.gyp:
  • public/WebHistoryItem.h:
  • public/WebPrivatePtr.h: Added.
  • public/WebSerializedScriptValue.h: Added.
  • src/WebHistoryItem.cpp:
  • src/WebSerializedScriptValue.cpp: Added.
4:43 PM Changeset in webkit [55819] by Chris Fleizach
  • 3 edits in trunk/LayoutTests

Skipping test on GTK and WIN. No Review.

VoiceOver can navigate to hidden content in widget (WAI-ARIA)
https://bugs.webkit.org/show_bug.cgi?id=35986

Thought this test might pass on the other platforms, but no.

  • platform/gtk/Skipped:
  • platform/win/Skipped:
4:36 PM Changeset in webkit [55818] by Chris Fleizach
  • 18 edits
    2 adds in trunk

VoiceOver can navigate to hidden content in widget (WAI-ARIA)
https://bugs.webkit.org/show_bug.cgi?id=35986

Reviewed by Beth Dakin.

WebCore:

Elements that are subclassers of AXRenderObject have not been respecting
aria-hidden and other cases that would make them ignored. This applies
to tables, rows, cells, select boxes, sliders, and lists. Select boxes
also need to make sure their option elements respect aria-hidden as well.

Test: accessibility/aria-hidden-with-elements.html

  • accessibility/AccessibilityList.cpp:

(WebCore::AccessibilityList::accessibilityIsIgnored):

  • accessibility/AccessibilityListBox.cpp:

(WebCore::AccessibilityListBox::addChildren):
(WebCore::AccessibilityListBox::accessibilityIsIgnored):
(WebCore::AccessibilityListBox::doAccessibilityHitTest):

  • accessibility/AccessibilityListBox.h:
  • accessibility/AccessibilityListBoxOption.cpp:

(WebCore::AccessibilityListBoxOption::accessibilityIsIgnored):

  • accessibility/AccessibilityListBoxOption.h:
  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::accessibilityIsIgnoredCommon):
(WebCore::AccessibilityRenderObject::accessibilityIsIgnored):
(WebCore::AccessibilityRenderObject::doAccessibilityHitTest):

  • accessibility/AccessibilityRenderObject.h:
  • accessibility/AccessibilitySlider.cpp:

(WebCore::AccessibilitySlider::accessibilityIsIgnored):

  • accessibility/AccessibilitySlider.h:

(WebCore::AccessibilitySlider::roleValue):
(WebCore::AccessibilitySliderThumb::roleValue):
(WebCore::AccessibilitySliderThumb::accessibilityIsIgnored):

  • accessibility/AccessibilityTable.cpp:

(WebCore::AccessibilityTable::accessibilityIsIgnored):

  • accessibility/AccessibilityTableCell.cpp:

(WebCore::AccessibilityTableCell::accessibilityIsIgnored):

  • accessibility/AccessibilityTableColumn.cpp:

(WebCore::AccessibilityTableColumn::accessibilityIsIgnored):

  • accessibility/AccessibilityTableColumn.h:

(WebCore::AccessibilityTableColumn::roleValue):

  • accessibility/AccessibilityTableHeaderContainer.cpp:

(WebCore::AccessibilityTableHeaderContainer::accessibilityIsIgnored):

  • accessibility/AccessibilityTableHeaderContainer.h:
  • accessibility/AccessibilityTableRow.cpp:

(WebCore::AccessibilityTableRow::accessibilityIsIgnored):

LayoutTests:

  • accessibility/aria-hidden-with-elements-expected.txt: Added.
  • accessibility/aria-hidden-with-elements.html: Added.
4:14 PM Changeset in webkit [55817] by dimich@chromium.org
  • 2 edits in trunk/JavaScriptCore

Not reviewed, fixing Snow Leopard build.

  • wtf/mac/MainThreadMac.mm: Forgot 'static' for a new local function.

(WTF::postTimer):

4:08 PM Changeset in webkit [55816] by dimich@chromium.org
  • 7 edits in trunk

Make Document::postTask to use a single queue of tasks, to fire them in order
https://bugs.webkit.org/show_bug.cgi?id=35943

Reviewed by Darin Adler.

JavaScriptCore:

The patch uses CFRunLoopTimer to schedule execution of tasks instead of performSelectorOnMainThread which apparently can starve other event sources.
The timer is used when the schedule request is coming on the main thread itself. This happens when the task is posted on the main thread or
when too many tasks are posted and the queue does 'stop and re-schedule' to make sure run loop has a chance to execute other events.

  • wtf/mac/MainThreadMac.mm:

(WTF::timerFired):
(WTF::postTimer):
(WTF::scheduleDispatchFunctionsOnMainThread): Use timer posted to the current RunLoop if scheduling the task execution while on the main thread.

WebCore:

Test: existing worker-cloneport.html which was broken by initial patch in http://trac.webkit.org/changeset/55593.
Additional test which indirectly verifies the order of execution will come as part of https://bugs.webkit.org/show_bug.cgi?id=34726

  • dom/Document.cpp:

(WebCore::Document::postTask): Always use the same task queue, independent of what thread is posting the task.

LayoutTests:

Updated the test since the order of events coming from independent task sources has changed.
This is a behavior change, but is consistent with the spec (which specifically says these events may be fired
in any order) and the last version of FF (3.5.8) which was completing the test successfully.

  • http/tests/appcache/top-frame-2-expected.txt:
  • http/tests/appcache/top-frame-2.html:
3:40 PM Changeset in webkit [55815] by ggaren@apple.com
  • 2 edits in trunk/JavaScriptCore

Windows build fix: added new symbol.

3:28 PM Changeset in webkit [55814] by darin@chromium.org
  • 10 edits in trunk

2010-03-10 Sanjeev Radhakrishnan <sanjeevr@chromium.org>

Reviewed by Darin Fisher.

Allow a plugin to participate in the browser's print workflow.
https://bugs.webkit.org/show_bug.cgi?id=35550

  • loader/PluginDocument.cpp:
  • loader/PluginDocument.h:
3:27 PM Changeset in webkit [55813] by ggaren@apple.com
  • 2 edits in trunk/JavaScriptCore

Windows build fix: removed old symbol.

3:19 PM Changeset in webkit [55812] by eric@webkit.org
  • 1 edit
    4 adds in trunk/WebKit

2010-03-10 Leandro Pereira <leandro@profusion.mobi>

Reviewed by Holger Freyther.

Add EFL port files to efl/WebCoreSupport.
http://webkit.org/b/35913

  • efl/WebCoreSupport/ChromeClientEfl.cpp: Added.
  • efl/WebCoreSupport/ChromeClientEfl.h: Added.
3:11 PM Changeset in webkit [55811] by ggaren@apple.com
  • 5 edits in trunk/JavaScriptCore

Refactored fastCheckConsistency to match some review comments:

  • renamed fastCheckConsistency to fastMallocSize, and changed ValueCheck to ASSERT that a pointer's fastMallocSize is not 0.
  • implemented a version of fastMallocSize for tcmalloc.


Reviewed by Alexey Proskuryakov, Darin Adler, and Sam Weinig.

Also moved some pre-existing code around to avoid a problem related to
mismatched #define/#undef of malloc/free in this source file.

(WTF::fastMallocSize): Renamed. Fixed indentation.

(WTF::TCMalloc_PageHeap::scavenge): Removed an incorrect ASSERT that
got in the way of testing the tcmalloc implementation. (More information
on why this ASSERT is incorrect is in <rdar://problem/7165917>.)

(WTF::TCMallocStats::fastMallocSize): Implemented for tcmalloc.

  • wtf/FastMalloc.h: Updated for rename.
  • wtf/ValueCheck.h:

(WTF::): Moved the ASSERT that used to be in fastCheckConsistency here.

3:00 PM Changeset in webkit [55810] by jam@chromium.org
  • 2 edits in trunk/WebKit/chromium

2010-03-10 John Abd-El-Malek <jam@chromium.org>

Reviewed by Nate Chapin.

[chromium]: Fix regression in mouse capture on Mac/Linux
https://bugs.webkit.org/show_bug.cgi?id=35987

  • src/WebViewImpl.cpp:
2:44 PM Changeset in webkit [55809] by eric@webkit.org
  • 2 edits in trunk/WebKit/win

2010-03-10 Eric Uhrhane <ericu@chromium.org>

Reviewed by David Levin.

The build fix for my patch on bug #35763 wasn't quite right--it removed
the call entirely, instead of replacing it with the new API. This adds
the call to Database::setIsAvailable.

https://bugs.webkit.org/show_bug.cgi?id=35763

2:26 PM Changeset in webkit [55808] by eric@webkit.org
  • 5 edits in trunk/WebKit/chromium

2010-03-10 Evan Stade <estade@chromium.org>

Reviewed by David Levin.

[chromium] add functionality to activate the focused node in a WebView
https://bugs.webkit.org/show_bug.cgi?id=35407

  • public/WebDocument.h:
  • public/WebNode.h:
  • src/WebDocument.cpp: (WebKit::WebDocument::focusedNode): Added
  • src/WebNode.cpp: (WebKit::WebNode::simulateClick): Added
2:19 PM Changeset in webkit [55807] by Adam Roben
  • 2 edits in trunk/WebKitTools

Roll out the prepare-ChangeLog part of r55870

This change wasn't needed (prepare-ChangeLog calls svn-create-patch
when it's asked to print out diffs for the user) and was screwing up
its ability to find changed function names.

  • Scripts/prepare-ChangeLog:

(diffCommand): Change the options we pass to svn-diff back to their
pre-r55870 form.

2:09 PM Changeset in webkit [55806] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-03-10 Ilya Tikhonovsky <loislo@loislo-macbookpro.local>

Reviewed by Pavel Feldman.

Sidebar resize element height was adjusted.
Display name for Function Call details was adjusted.

https://bugs.webkit.org/show_bug.cgi?id=35939

  • inspector/front-end/TimelinePanel.js: (WebInspector.TimelinePanel.prototype._refreshRecords): (WebInspector.TimelinePanel.FormattedRecord.prototype._getRecordDetails):
1:59 PM Changeset in webkit [55805] by jam@chromium.org
  • 5 edits in trunk/WebKit/chromium

2010-03-10 John Abd-El-Malek <jam@chromium.org>

Reviewed by Darin Fisher.

https://bugs.webkit.org/show_bug.cgi?id=35952
Propagate mouse wheel events to Pepper plugins.

  • src/WebInputEventConversion.cpp: (WebKit::WebMouseWheelEventBuilder::WebMouseWheelEventBuilder):
  • src/WebInputEventConversion.h:
  • src/WebPluginContainerImpl.cpp: (WebKit::WebPluginContainerImpl::handleEvent): (WebKit::WebPluginContainerImpl::handleMouseEvent): (WebKit::WebPluginContainerImpl::handleWheelEvent): (WebKit::WebPluginContainerImpl::handleKeyboardEvent):
  • src/WebPluginContainerImpl.h:
1:58 PM Changeset in webkit [55804] by tonikitoo@webkit.org
  • 2 edits in trunk/LayoutTests

2010-03-10 Antonio Gomes <tonikitoo@webkit.org>

The test was introduced in r55796, it has been failing in Gtk bots since then.

Filed bug https://bugs.webkit.org/show_bug.cgi?id=35984.

  • platform/gtk/Skipped: fast/events/spatial-navigation/snav-iframe-with-offscreen-focusable-element.html skipped until fix.
1:55 PM Changeset in webkit [55803] by robert@webkit.org
  • 9 edits in trunk

2010-03-10 Robert Hogan <robert@webkit.org>

Reviewed by Simon Hausmann.

[Qt] Add Support for WebKitEnableCaretBrowsing to Qt DRT

Unskip test fast/events/multiline-link-arrow-navigation.html

https://bugs.webkit.org/show_bug.cgi?id=35593

  • platform/qt/Skipped:

2010-03-10 Robert Hogan <robert@webkit.org>

Reviewed by Simon Hausmann.

[Qt] Add Support for WebKitEnableCaretBrowsing to Qt DRT

Unskip test fast/events/multiline-link-arrow-navigation.html

https://bugs.webkit.org/show_bug.cgi?id=35593

  • DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::WebPage::resetSettings):
  • DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::overridePreference): (LayoutTestController::setCaretBrowsingEnabled):
  • DumpRenderTree/qt/LayoutTestControllerQt.h:

2010-03-10 Robert Hogan <robert@webkit.org>

Reviewed by Simon Hausmann.

[Qt] Add Support for WebKitEnableCaretBrowsing to Qt DRT

Unskip test fast/events/multiline-link-arrow-navigation.html
Fix typo (superfluous space) in QWebSettings docs.

https://bugs.webkit.org/show_bug.cgi?id=35593

  • Api/qwebpage.cpp: (qt_drt_enableCaretBrowsing):
  • Api/qwebsettings.cpp: (QWebSettingsPrivate::apply): fix typo in docs
1:52 PM Changeset in webkit [55802] by eric@webkit.org
  • 3 edits in trunk/WebCore

2010-03-10 Charles Wei <charles.wei@torchmobile.com.cn>

Reviewed by George Staikos.

Fix https://bugs.webkig.org/show_bug.cgi?id=35207
When XHTMLMP is enabled, all xhtml documents fail to render for webkit portings wich use libxml2 tokenizer.

No new tests as all the xhtml test cases in LayoutTests/dom/xhtml fails without this fix when XHTMLMP is enabled.

  • dom/Document.cpp: (WebCore::Document::isXHTMLMPDocument):
  • dom/XMLTokenizerLibxml2.cpp: (WebCore::XMLTokenizer::internalSubset): (WebCore::externalSubsetHandler):
1:34 PM Changeset in webkit [55801] by beidson@apple.com
  • 5 edits
    1 add in trunk/LayoutTests

https://bugs.webkit.org/show_bug.cgi?id=35977

Reviewed by Sam Weinig.

Turns out the previous attempt to clear/reset cookies wasn't working because of the way
the URLs for the .js and its .cgi were being resolved.

So this is a better way to make the cookies consistent both before and after these tests.

If this fails to make cookie-related tests reliable, then we might have to bite the bullet
and give DRT itself the ability to forcibly remove cookies via API methods.

This would be bulletproof and could be automatic if a test declares itself "cookie sensitive"
but we'd lose the ability to reliably run these tests in the browser. :(

  • http/tests/cookies/resources/resetCookies.js: Added.
  • http/tests/cookies/resources/third-party-cookie-relaxing-iframe.html:
  • http/tests/cookies/third-party-cookie-relaxing.html:
  • http/tests/plugins/resources/third-party-cookie-accept-policy-iframe.html:
  • http/tests/plugins/third-party-cookie-accept-policy.html:
1:34 PM Changeset in webkit [55800] by eric@webkit.org
  • 6 edits in trunk

2010-03-10 Garret Kelly <gdk@chromium.org>

Reviewed by Darin Fisher.

Adding all of the touch-related sources into Chromium's WebCore build.
https://bugs.webkit.org/show_bug.cgi?id=35874

Patch tested against the try bots, but the feature is exercised in the
fast/events/touch tests.

  • WebCore.gypi:

2010-03-10 Garret Kelly <gdk@chromium.org>

Reviewed by Darin Fisher.

Add support for converting WebTouchEvents to PlatformTouchEvents and
routing them into the EventHandler for the frame in which they
originate.
https://bugs.webkit.org/show_bug.cgi?id=35874

  • src/ChromeClientImpl.h: (WebKit::ChromeClientImpl::needTouchEvents):
  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::touchEvent): Handle incoming WebTouchEvents, converting them to PlatformTouchEvents and sending them to the EventHandler. (WebKit::WebViewImpl::handleInputEvent): Now routes WebTouchEvents to the touchEvent handler.
  • src/WebViewImpl.h:
12:37 PM Changeset in webkit [55799] by pfeldman@chromium.org
  • 6 edits in trunk/WebCore

2010-03-10 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: now that audits panel is added, add it to the
enums (for storing last active, etc.).

https://bugs.webkit.org/show_bug.cgi?id=35980

  • inspector/InspectorController.cpp: (WebCore::InspectorController::setWindowVisible): (WebCore::InspectorController::specialPanelForJSName):
  • inspector/InspectorController.h: (WebCore::InspectorController::):
  • inspector/InspectorFrontend.cpp: (WebCore::InspectorFrontend::showPanel):
  • inspector/front-end/inspector.js: (WebInspector.showAuditsPanel):
12:34 PM QtWebKitBugs edited by jocelyn.turcotte@nokia.com
(diff)
12:33 PM Changeset in webkit [55798] by Nate Chapin
  • 49 edits
    1 delete in trunk

2010-03-10 Nate Chapin <Nate Chapin>

Reviewed by Dimitri Glazkov.

[V8] Instead of describing the type of a wrapped v8 object
with an enum value, use a pointer to struct with more complete
information.

https://bugs.webkit.org/show_bug.cgi?id=35941

Refactoring only, so new tests.

  • bindings/scripts/CodeGeneratorV8.pm:
  • bindings/v8/DOMData.cpp:
  • bindings/v8/DOMData.h:
  • bindings/v8/NPV8Object.cpp:
  • bindings/v8/V8Collection.h:
  • bindings/v8/V8DOMWindowShell.cpp:
  • bindings/v8/V8DOMWindowShell.h:
  • bindings/v8/V8DOMWrapper.cpp:
  • bindings/v8/V8DOMWrapper.h:
  • bindings/v8/V8GCController.cpp:
  • bindings/v8/V8Helpers.cpp:
  • bindings/v8/V8Helpers.h:
  • bindings/v8/V8Index.cpp: Removed.
  • bindings/v8/V8Index.h:
  • bindings/v8/V8NPObject.cpp:
  • bindings/v8/V8Proxy.cpp:
  • bindings/v8/V8Proxy.h:
  • bindings/v8/WorkerContextExecutionProxy.cpp:
  • bindings/v8/custom/V8DOMWindowCustom.cpp:
  • bindings/v8/custom/V8HTMLAudioElementConstructor.cpp:
  • bindings/v8/custom/V8HTMLAudioElementConstructor.h:
  • bindings/v8/custom/V8HTMLImageElementConstructor.cpp:
  • bindings/v8/custom/V8HTMLImageElementConstructor.h:
  • bindings/v8/custom/V8HTMLOptionElementConstructor.cpp:
  • bindings/v8/custom/V8HTMLOptionElementConstructor.h:
  • bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
  • bindings/v8/custom/V8MessageChannelConstructor.cpp:
  • bindings/v8/custom/V8SharedWorkerCustom.cpp:
  • bindings/v8/custom/V8WebGLArrayBufferCustom.cpp:
  • bindings/v8/custom/V8WebGLArrayCustom.h:
  • bindings/v8/custom/V8WebGLByteArrayCustom.cpp:
  • bindings/v8/custom/V8WebGLFloatArrayCustom.cpp:
  • bindings/v8/custom/V8WebGLIntArrayCustom.cpp:
  • bindings/v8/custom/V8WebGLShortArrayCustom.cpp:
  • bindings/v8/custom/V8WebGLUnsignedByteArrayCustom.cpp:
  • bindings/v8/custom/V8WebGLUnsignedIntArrayCustom.cpp:
  • bindings/v8/custom/V8WebGLUnsignedShortArrayCustom.cpp:
  • bindings/v8/custom/V8WebKitCSSMatrixConstructor.cpp:
  • bindings/v8/custom/V8WebKitPointConstructor.cpp:
  • bindings/v8/custom/V8WebSocketCustom.cpp:
  • bindings/v8/custom/V8WorkerCustom.cpp:
  • bindings/v8/custom/V8XMLHttpRequestConstructor.cpp:
  • bindings/v8/custom/V8XSLTProcessorCustom.cpp:
12:18 PM Changeset in webkit [55797] by tonikitoo@webkit.org
  • 1 edit
    3 adds in trunk/WebCore

Extend keyboard navigation to allow directional navigation (Manual tests)
https://bugs.webkit.org/show_bug.cgi?id=18662

Reviewed by Dave Hyatt.
Patch by Antonio Gomes <tonikitoo@webkit.org>

Adds a manual tests for the Spatial Navigation feature comprasing varios
Html focusable elements (e.g. <a>, <table>, <iframe>) and much of the logic
provided by the feature.

  • manual-tests/spatial-navigation/links.html: Added.
  • manual-tests/spatial-navigation/spatial-navigation-test-cases.html: Added.
12:13 PM Changeset in webkit [55796] by tonikitoo@webkit.org
  • 1 edit
    10 adds in trunk/LayoutTests

Extend keyboard navigation to allow directional navigation (LayoutTests - part V)
https://bugs.webkit.org/show_bug.cgi?id=18662

Reviewed by Dave Hyatt.
Patch by Antonio Gomes <tonikitoo@webkit.org>

This patch adds three LayoutTests that ensure the correctness of Spatial Navigation algorithm
in the following iframe related traversals:

1) All focusable elements in a <iframe> should be accessible.
2) Focusable elements in an <iframe> should be accessible even when

current focused element is in another <iframe> in the same page.

  • fast/events/spatial-navigation/snav-iframe-no-focusable-content.html: Added.
  • fast/events/spatial-navigation/snav-iframe-no-scrollable-content.html: Added.
  • fast/events/spatial-navigation/snav-iframe-with-offscreen-focusable-element.html: Added.
12:10 PM Changeset in webkit [55795] by tonikitoo@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

Extend keyboard navigation to allow directional navigation (LayoutTests - part IV)
https://bugs.webkit.org/show_bug.cgi?id=18662

Reviewed by Dave Hyatt.
Patch by Antonio Gomes <tonikitoo@webkit.org>

This patch adds a LayoutTest that ensures that:

1) There is no unit overflow in the Spatial Navigation algorithm while

calculating the best node candidate to move focus to. To test that this
page positions some elements 10000000 pixels far from each other (distance
that can considered large enough for most of the Web Pages on the
Internet).

2) A best focusable candidate only gets focused if it is visible in the

current Viewport. Scroll-in-direction is performed otherwise.

  • fast/events/spatial-navigation/snav-unit-overflow-and-scroll-in-direction.html: Added.
12:08 PM Changeset in webkit [55794] by tonikitoo@webkit.org
  • 1 edit
    4 adds in trunk/LayoutTests

Extend keyboard navigation to allow directional navigation (LayoutTests - part III)
https://bugs.webkit.org/show_bug.cgi?id=18662

Reviewed by Dave Hyatt.
Patch by Antonio Gomes <tonikitoo@webkit.org>

This patch adds two LayoutTests to ensure the correctness of the "Fully aligned"
precedence logic implemented by Spatial Navigation algorithm, either vertically or
horizontally: targets whose middle falls between the top and bottom of the current
focused element are preferably to move focus to, even if it is not the shortest distance.

  • fast/events/spatial-navigation/snav-fully-aligned-vertically.html: Added.
  • fast/events/spatial-navigation/snav-fully-aligned-horizontally.html: Added.
12:06 PM Changeset in webkit [55793] by eric@webkit.org
  • 1 edit
    2 adds in trunk/WebCore

2010-03-10 Leandro Pereira <leandro@profusion.mobi>

Reviewed by Kenneth Rohde Christiansen.

Add EFL port files to platform/efl.
http://webkit.org/b/35890

  • platform/efl/ScrollbarEfl.h: Added.
  • platform/efl/ScrollbarThemeEfl.h: Added.
11:47 AM Changeset in webkit [55792] by eric@webkit.org
  • 2 edits in trunk/WebKit/chromium

2010-03-10 Garret Kelly <gdk@chromium.org>

Reviewed by Darin Fisher.

Fixing build warning caused by using 0 instead of NULL as the sentiel
in a varargs call.
https://bugs.webkit.org/show_bug.cgi?id=35898

  • src/gtk/WebInputEventFactory.cpp:
11:26 AM Changeset in webkit [55791] by robert@webkit.org
  • 2 edits in trunk/WebKitTools

2010-03-10 Robert Hogan <robert@webkit.org>

Reviewed by Holger Freyther.

QtLauncher: Fix typo in conditional statement in

WebViewGraphicsBased::setFrameRateMeasurementEnabled.

'=' should be '=='!

https://bugs.webkit.org/show_bug.cgi?id=35877

  • QtLauncher/webview.cpp: (WebViewGraphicsBased::setFrameRateMeasurementEnabled):
11:17 AM Changeset in webkit [55790] by pfeldman@chromium.org
  • 5 edits
    1 add in trunk/WebCore

2010-03-10 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: Audits panel needs an icon.
Landing icon attached by Timothy. Enabling panel!

https://bugs.webkit.org/show_bug.cgi?id=35945

  • WebCore.gypi:
  • inspector/front-end/Images/auditsIcon.png: Added.
  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/inspector.css:
10:59 AM Changeset in webkit [55789] by kov@webkit.org
  • 3 edits in trunk/WebCore

2010-03-10 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Roll-out r55657, as Xan noticed a bad degradation in playing
youtube HTML5 videos with it, that is fixed with it
reverted. Looks like we'll need to work a bit more on this.

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivate::MediaPlayerPrivate): (WebCore::MediaPlayerPrivate::~MediaPlayerPrivate): (WebCore::MediaPlayerPrivate::volumeChangedTimerFired): (WebCore::MediaPlayerPrivate::volumeChanged): (WebCore::MediaPlayerPrivate::processBufferingStats): (WebCore::MediaPlayerPrivate::fillTimerFired): (WebCore::MediaPlayerPrivate::maxTimeLoaded): (WebCore::MediaPlayerPrivate::updateStates): (WebCore::MediaPlayerPrivate::muteChangedTimerFired): (WebCore::MediaPlayerPrivate::muteChanged):
  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:
10:41 AM Changeset in webkit [55788] by kov@webkit.org
  • 2 edits in trunk/WebCore

2010-03-10 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Rubber-stamped by Xan Lopez.

Fix ready state when buffering under PLAYING. We should not go
back to HaveNothing in that case.

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivate::updateStates):
10:38 AM Changeset in webkit [55787] by adachan@apple.com
  • 2 edits in trunk/WebCore

Reviewed by Adam Roben.

https://bugs.webkit.org/show_bug.cgi?id=35976

Retrieve any dwItemData that's set on the context menu item in contextMenuItemByIdOrPosition().

  • platform/win/ContextMenuWin.cpp:
10:31 AM Changeset in webkit [55786] by Chris Jerdonek
  • 5 edits in trunk/WebKitTools

Refactored and cleaned up the code for unit-testing logging.

Reviewed by Shinichiro Hamaji.

https://bugs.webkit.org/show_bug.cgi?id=35845

  • Scripts/webkitpy/init/logtesting.py:
    • Added more information to the module docstring.
    • Added an assertMessages() method to the UnitTestLogStream class. This simplifies the calling code.
    • Renamed the UnitTestLog class to LogTesting, and reformulated it as follows:
      • Moved the logging configuration code from the init method to a new static setUp() method.
      • Documented the init method to be private.
      • Improved the code so that the root logger does not have its logging level changed. Instead we set the handler's level. This makes the unit testing more unintrusive.
      • Updated the assertMessages() method to call the UnitTestLogStream class's assertMessages() method.
      • More fully documented the class.
  • Scripts/webkitpy/style/checker.py:
    • Added a logger parameter to the configure_logging() method. This allows us to prevent test messages from being sent to the root logger during unit testing, which may be rendering to the screen, etc.
    • Simplified the code by removing the _LevelLoggingFilter class.
    • Replaced the _LevelLoggingFilter class with a one-line lambda expression in configure_logging().
  • Scripts/webkitpy/style/checker_unittest.py:
    • Changed relative imports to absolute to comply more with PEP8.
    • In the ConfigureLoggingTest class:
      • Changed the setUp() method to prevent test messages from being propagated to the root logger.
      • Changed the _log() method to a data attribute.
      • Updated to accommodate changes to logtesting.py.
  • Scripts/webkitpy/style_references.py:
    • Updated an import statement.
9:36 AM WikiStart edited by evan@chromium.org
add a gdb section (diff)
9:35 AM Changeset in webkit [55785] by evan@chromium.org
  • 1 edit
    2 adds in trunk/WebKitTools

2010-03-10 Evan Martin <evan@chromium.org>

Reviewed by Darin Adler.

Python code for GDB 7 to support native printing of some WebCore types.

  • gdb/webcore.py: Added.
9:06 AM Changeset in webkit [55784] by jorlow@chromium.org
  • 8 edits
    8 adds in trunk

2010-03-10 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Darin Fisher.

Add IndexedDatabase class and hook it up.
https://bugs.webkit.org/show_bug.cgi?id=35927

This change is mostly just adding the plumbing necessary for
the IndexedDatabaseRequest and IndexedDatabaseSync (not written
yet).

This code is non-functional, so no tests (yet).

  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:
  • platform/chromium/ChromiumBridge.h:
  • storage/IndexedDatabase.cpp: Added. (WebCore::IndexedDatabase::get):
  • storage/IndexedDatabase.h: Added. (WebCore::IndexedDatabase::~IndexedDatabase):
  • storage/IndexedDatabaseImpl.cpp: Added. (WebCore::IndexedDatabaseImpl::get): (WebCore::IndexedDatabaseImpl::IndexedDatabaseImpl): (WebCore::IndexedDatabaseImpl::~IndexedDatabaseImpl): (WebCore::IndexedDatabaseImpl::open):
  • storage/IndexedDatabaseImpl.h: Added.
  • storage/chromium/IndexedDatabase.cpp: Added. (WebCore::IndexedDatabase::get):
  • WebKit.gyp:
  • public/WebIndexedDatabase.h: Added. (WebKit::WebIndexedDatabase::~WebIndexedDatabase):
  • public/WebKitClient.h: (WebKit::WebKitClient::getIndexedDatabase):
  • src/ChromiumBridge.cpp: (WebCore::ChromiumBridge::getIndexedDatabase):
  • src/IndexedDatabaseProxy.cpp: Added. (WebCore::IndexedDatabaseProxy::create): (WebCore::IndexedDatabaseProxy::IndexedDatabaseProxy): (WebCore::IndexedDatabaseProxy::~IndexedDatabaseProxy): (WebCore::IndexedDatabaseProxy::open):
  • src/IndexedDatabaseProxy.h: Added.
8:56 AM Changeset in webkit [55783] by Dimitri Glazkov
  • 3 edits
    2 adds in trunk

Add one more parent check during node removal.
https://bugs.webkit.org/show_bug.cgi?id=35818

Reviewed by Sam Weinig.

WebCore:

Test: fast/dom/Node/mutation-blur.html

  • dom/ContainerNode.cpp:

(WebCore::ContainerNode::removeChild): Added check.

LayoutTests:

  • fast/dom/Node/mutation-blur-expected.txt: Added.
  • fast/dom/Node/mutation-blur.html: Added.
8:50 AM Changeset in webkit [55782] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] fast/multicol/hit-test-above-or-below.html fails
https://bugs.webkit.org/show_bug.cgi?id=35973

The test was introduced in r55546, it has been failing since then.

  • platform/qt/Skipped: fast/multicol/hit-test-above-or-below.html skipped until fix.
8:34 AM Changeset in webkit [55781] by pfeldman@chromium.org
  • 2 edits in trunk/WebCore

2010-03-10 Pavel Feldman <pfeldman@chromium.org>

Not reviewed: added missing quote to localized strings.

  • English.lproj/localizedStrings.js:
7:47 AM Changeset in webkit [55780] by Adam Roben
  • 3 edits in trunk/WebKitTools

Make svn-create-patch and prepare-ChangeLog show better section headings for ObjC files

This makes the text at the end of each "@@" line in a diff actually
show the ObjC method or interface that contains the change, rather
than whatever the most-recently-defined C function was.

Fixes <http://webkit.org/b/35970>.

Reviewed by John Sullivan.

  • Scripts/svn-create-patch: Pass -F'[-+@]' to diff so that it will

treat any lines starting with -, +, or @ as section heading lines.
This works well for ObjC files, and shouldn't affect other types of
files.

  • Scripts/prepare-ChangeLog: Changed the options passed to diff to

match those used in svn-create-patch.

7:38 AM Changeset in webkit [55779] by jorlow@chromium.org
  • 1 edit
    3 adds in trunk/WebCore

Commit files that were supposed to go in with the last checkin.

7:34 AM Changeset in webkit [55778] by jorlow@chromium.org
  • 7 edits in trunk/WebCore

Baby steps towards IndexedDB: Start implementing callbacks.
https://bugs.webkit.org/show_bug.cgi?id=35911

Reviewed by Dimitry Glazkov.

This patch adds some infastructure for IndexedDB callbacks in V8.
It also adds a stub of IDBDatabaseRequest. In the near future,
I'll gut the event based implementation code, flesh out IDBReqest
further, and start plumbing IndexedDatabaseRequest.

Code is not testible because it doesn't work (yet).

  • WebCore.gypi:
  • bindings/v8/DOMObjectsInclude.h:
  • bindings/v8/V8Index.cpp:
  • bindings/v8/V8Index.h:
  • bindings/v8/custom/V8CustomIDBCallback.h: Added.

(WebCore::V8CustomIDBCallback::create):
(WebCore::V8CustomIDBCallback::~V8CustomIDBCallback):
(WebCore::V8CustomIDBCallback::handleEvent):
(WebCore::V8CustomIDBCallback::V8CustomIDBCallback):

  • bindings/v8/custom/V8IndexedDatabaseRequestCustom.cpp:

(WebCore::V8IndexedDatabaseRequest::openCallback):

  • storage/IDBDatabaseRequest.h: Added.

(WebCore::IDBDatabaseRequest::request):

  • storage/IDBDatabaseRequest.idl: Added.
  • storage/IndexedDatabaseRequest.idl:
7:17 AM Changeset in webkit [55777] by kov@webkit.org
  • 1 edit
    1 add in trunk/WebKit/gtk/po

2010-03-10 Priit Laes <plaes@plaes.org>

Reviewed by Gustavo Noronha.

Estonian translation.

  • et.po: Added.
5:23 AM Changeset in webkit [55776] by sullivan@apple.com
  • 4 edits in trunk/WebKit

<rdar://problem/7735387> input type other than text won't work with autofill
<https://bugs.webkit.org/show_bug.cgi?id=35963>

Reviewed by Tim Hatcher.

WebKit/mac:

  • WebView/WebHTMLRepresentation.mm:

(-[WebHTMLRepresentation elementDoesAutoComplete:]):
Return true for any text field that's not a password, rather than only
for TEXT type.

WebKit/win:

  • WebFrame.cpp:

(WebFrame::elementDoesAutoComplete):
Return true for any text field that's not a password, rather than only
for TEXT type.

4:44 AM BuildingQtOnWindows edited by jocelyn.turcotte@nokia.com
(diff)
4:10 AM Changeset in webkit [55775] by Simon Hausmann
  • 2 edits in trunk/WebKitTools

Link QtLauncher against the WebKit library using a relative rpath.

Reviewed by Tor Arne Vestbø.

This makes the launcher and the lib relocatable.

  • QtLauncher/QtLauncher.pro:
2:46 AM Changeset in webkit [55774] by zecke@webkit.org
  • 2 edits
    3 adds in trunk/WebCore

[Qt] Non animated gifs are animated in QtWebKit

https://bugs.webkit.org/show_bug.cgi?id=35955

Properly map Qt animated and non-animated values to WebCore's
understanding of animated and non-animated images. Currently
we can not map anything to the cAnimationLoopNone value.

  • manual-tests/qt/qt-anim.gif: Added.
  • manual-tests/qt/qt-gif-test.html: Added.
  • manual-tests/qt/qt-noanim.gif: Added.
  • platform/graphics/qt/ImageDecoderQt.cpp:

(WebCore::ImageDecoderQt::repetitionCount):

2:44 AM Changeset in webkit [55773] by zecke@webkit.org
  • 3 edits
    2 adds in trunk

[CAIRO] DoS on iexploder test with high text stroke width.

https://bugs.webkit.org/show_bug.cgi?id=33759

Specifying a big text stroke width can make WebKitGTK+ spend
a very long time in the cairo library for stroking the path of
the text. The best way to prevent this from happening right now
is to not stroke paths with a certain width. Samuel proposed to
not stroke with a width that is twice the width of the text. The
reason to use twice the text width is that even one stroke of
any charachter to be drawn would cover the full width.

Test: fast/text/text-stroke-width-cairo-dos.html

WebCore:

  • platform/graphics/cairo/FontCairo.cpp:

(WebCore::Font::drawGlyphs):

Add a test case with the -webkit-text-stroke-width attribute
set to a high value to illustrate the issue.

  • fast/text/text-stroke-width-cairo-dos-expected.txt: Added.
  • fast/text/text-stroke-width-cairo-dos.html: Added.
1:41 AM Changeset in webkit [55772] by zecke@webkit.org
  • 4 edits in trunk/WebKitTools

[iExploder] Add new CSS Properties and HTML Attributes

The update-iexploder-cssproperties script was used to update
the various input files. The autobuffer HTML Attribute was removed
from WebKit and I manually added it back to the htmlattrs.in like
we have done it for other attributes in the past.

1:22 AM Changeset in webkit [55771] by pfeldman@chromium.org
  • 28 edits
    1 copy
    2 adds in trunk

2010-03-10 Andrey Kosyakov <caseq@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: display list of active workers & support debugging
with fake workers.
https://bugs.webkit.org/show_bug.cgi?id=35568

  • English.lproj/localizedStrings.js:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • bindings/js/JSInjectedScriptHostCustom.cpp: (WebCore::InjectedScriptHost::createInjectedScript): (WebCore::InjectedScriptHost::injectedScriptFor):
  • bindings/v8/custom/V8InjectedScriptHostCustom.cpp: (WebCore::InjectedScriptHost::createInjectedScript): (WebCore::InjectedScriptHost::injectedScriptFor):
  • dom/Document.cpp: (WebCore::Document::inspectorController):
  • dom/Document.h:
  • dom/ScriptExecutionContext.h: (WebCore::ScriptExecutionContext::inspectorController):
  • inspector/InjectedScriptHost.cpp: (WebCore::InjectedScriptHost::InjectedScriptHost): (WebCore::InjectedScriptHost::injectScript): (WebCore::InjectedScriptHost::nextWorkerId): (WebCore::InjectedScriptHost::didCreateWorker): (WebCore::InjectedScriptHost::willDestroyWorker):
  • inspector/InjectedScriptHost.h:
  • inspector/InjectedScriptHost.idl:
  • inspector/InspectorController.cpp: (WebCore::InspectorController::populateScriptObjects): (WebCore::InspectorController::resetScriptObjects): (WebCore::InspectorController::didCommitLoad): (WebCore::InspectorController::didCreateWorker): (WebCore::InspectorController::willDestroyWorker):
  • inspector/InspectorController.h:
  • inspector/InspectorFrontend.cpp: (WebCore::InspectorFrontend::didCreateWorker): (WebCore::InspectorFrontend::willDestroyWorker):
  • inspector/InspectorFrontend.h:
  • inspector/InspectorWorkerResource.h: Added. (WebCore::InspectorWorkerResource::create): (WebCore::InspectorWorkerResource::id): (WebCore::InspectorWorkerResource::url): (WebCore::InspectorWorkerResource::isSharedWorker): (WebCore::InspectorWorkerResource::InspectorWorkerResource):
  • inspector/front-end/Checkbox.js: Added. (WebInspector.Checkbox.callbackWrapper): (WebInspector.Checkbox): (WebInspector.Checkbox.prototype.checked):
  • inspector/front-end/InjectedFakeWorker.js: (InjectedFakeWorker.FakeWorker): (InjectedFakeWorker.FakeWorker.prototype.terminate): (InjectedFakeWorker.FakeWorker.prototype._handleException): (InjectedFakeWorker.FakeWorker.prototype._importScripts): (InjectedFakeWorker.FakeWorker.prototype._loadScript): (InjectedFakeWorker.FakeWorker.prototype._expandURLAndCheckOrigin):
  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel): (WebInspector.ScriptsPanel.prototype.debuggerWasEnabled): (WebInspector.ScriptsPanel.prototype.debuggerWasDisabled): (WebInspector.ScriptsPanel.prototype.reset):
  • inspector/front-end/StylesSidebarPane.js: (WebInspector.StylePropertiesSection.showInheritedToggleFunction): (WebInspector.StylePropertiesSection):
  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/WorkersSidebarPane.js: Added. (WebInspector.WorkersSidebarPane): (WebInspector.WorkersSidebarPane.prototype.addWorker): (WebInspector.WorkersSidebarPane.prototype.removeWorker): (WebInspector.WorkersSidebarPane.prototype.setInstrumentation): (WebInspector.WorkersSidebarPane.prototype.reset): (WebInspector.WorkersSidebarPane.prototype._onTriggerInstrument): (WebInspector.Worker): (WebInspector.didCreateWorker): (WebInspector.willDestroyWorker):
  • inspector/front-end/inspector.css:
  • inspector/front-end/inspector.html:
  • workers/AbstractWorker.cpp: (WebCore::AbstractWorker::AbstractWorker): (WebCore::AbstractWorker::~AbstractWorker): (WebCore::AbstractWorker::onDestroyWorker): (WebCore::AbstractWorker::contextDestroyed):
  • workers/AbstractWorker.h: (WebCore::AbstractWorker::id):
  • workers/SharedWorker.cpp: (WebCore::SharedWorker::SharedWorker):
  • workers/Worker.cpp: (WebCore::Worker::Worker):

WebKit/chromium:

  • src/js/InspectorControllerImpl.js: (devtools.InspectorBackendImpl):
1:02 AM Changeset in webkit [55770] by zoltan@webkit.org
  • 3 edits in trunk/JavaScriptCore

2010-03-10 Kevin Ollivier <kevino@theolliviers.com>

Reviewed by Eric Seidel.

Make global new/delete operators configurable for all ports and disable it
for the wx port for now.

  • wtf/FastMalloc.h:
  • wtf/Platform.h:
12:41 AM Changeset in webkit [55769] by tony@chromium.org
  • 1 edit
    1 add in trunk/WebKit/chromium

2010-03-10 Tony Chang <tony@chromium.org>

Reviewed by Darin Fisher.

https://bugs.webkit.org/show_bug.cgi?id=35956
Create a grd file upstream for resources that chromium uses
that are pulled directly from the upstream repository.

  • WebKit.grd: Added.
12:06 AM Changeset in webkit [55768] by Philippe Normand
  • 2 edits in trunk/WebKit/gtk

2010-03-09 Philippe Normand <pnormand@igalia.com>

Reviewed by Gustavo Noronha Silva.

[GTK] testkeyevents doesn't stop if input event injection fails
https://bugs.webkit.org/show_bug.cgi?id=35922

  • tests/testkeyevents.c: (load_status_cb): Added a safeguard to exit from the test if the input event injection failed.
Note: See TracTimeline for information about the timeline view.