Context Navigation

← Previous Period
Next Period →

Timeline

Mar 12, 2010:

11:57 PM Changeset in webkit [55950] by eric@webkit.org

3 edits
2 adds in trunk/LayoutTests

2010-03-12 Shu Chang <chang.shu@nokia.com>

Reviewed by David Levin.

[Qt] Rebaseline the test and remove it from Skipped.
https://bugs.webkit.org/show_bug.cgi?id=36057

platform/qt/Skipped:
platform/qt/fast/canvas/canvas-size-change-after-layout-expected.checksum: Added.
platform/qt/fast/canvas/canvas-size-change-after-layout-expected.png: Added.
platform/qt/fast/canvas/canvas-size-change-after-layout-expected.txt:

11:07 PM Changeset in webkit [55949] by krit@webkit.org

19 edits in trunk

2010-03-12 Dirk Schulze <krit@webkit.org>

Reviewed by Nikolas Zimmermann.

SVG Glyphs - transform path not context
https://bugs.webkit.org/show_bug.cgi?id=36070

SVGFont should transform the path of a glyph, not the context. Modifying
the context causes wrong gradient transformations. This bug doesn't
influence CG because we generally fill or stroke texts with a mask image.
All other platforms provide a direct way to make the drawings.

svg/SVGFont.cpp: (WebCore::Font::drawTextUsingSVGFont):

2010-03-12 Dirk Schulze <krit@webkit.org>

Reviewed by Nikolas Zimmermann.

SVG Glyphs - transform path not context
https://bugs.webkit.org/show_bug.cgi?id=36070

Some tests don't look pixel perfect after the SVGFont changes (difference of 0.1%).
They just need an update.
Tests for the changes on other platforms than CG are

svg/batik/text/textEffect.svg
svg/batik/text/textEffect3.svg
svg/W3C-SVG-1.1/pservers-grad-08-b.svg

platform/mac-leopard/svg/custom/svg-fonts-in-html-expected.checksum:
platform/mac-leopard/svg/custom/svg-fonts-in-html-expected.png:
platform/mac/svg/W3C-SVG-1.1/animate-elem-03-t-expected.checksum:
platform/mac/svg/W3C-SVG-1.1/animate-elem-03-t-expected.png:
platform/mac/svg/W3C-SVG-1.1/animate-elem-36-t-expected.checksum:
platform/mac/svg/W3C-SVG-1.1/animate-elem-36-t-expected.png:
platform/mac/svg/W3C-SVG-1.1/animate-elem-40-t-expected.checksum:
platform/mac/svg/W3C-SVG-1.1/animate-elem-40-t-expected.png:
platform/mac/svg/W3C-SVG-1.1/pservers-grad-08-b-expected.checksum:
platform/mac/svg/W3C-SVG-1.1/pservers-grad-08-b-expected.png:
platform/mac/svg/batik/text/textEffect-expected.checksum:
platform/mac/svg/batik/text/textEffect-expected.png:
platform/mac/svg/batik/text/textEffect3-expected.checksum:
platform/mac/svg/batik/text/textEffect3-expected.png:
platform/mac/svg/text/selection-doubleclick-expected.png:
platform/mac/svg/text/selection-tripleclick-expected.png:

6:10 PM Changeset in webkit [55948] by barraclough@apple.com

2 edits in trunk/JavaScriptCore

JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:

Reviewed by NOBODY (build fix).

5:56 PM Changeset in webkit [55947] by enrica@apple.com

2 edits in trunk/WebKit/win

Fixed broken build on Windows.
Added contditional compilation for accelerated compositing.

WebView.cpp:

(WebView::deleteBackingStore):
(WebView::addToDirtyRegion):
(WebView::updateBackingStore):

5:39 PM Changeset in webkit [55946] by Beth Dakin

14 edits in trunk

Fix for https://bugs.webkit.org/show_bug.cgi?id=34942 Fullscreen
API naming is inconsistent
-and corresponding-
<rdar://problem/7729165>

Reviewed by Simon Fraser.

WebCore:

This patch changes all occurrences of "fullScreen" to the more
popular "fullscreen." webkitEnterFullScreen and
webkitExitFullScreen have been maintained for now for backwards
compatibility.

html/HTMLVideoElement.cpp:

(WebCore::HTMLVideoElement::webkitEnterFullscreen):
(WebCore::HTMLVideoElement::webkitExitFullscreen):

html/HTMLVideoElement.h:

(WebCore::HTMLVideoElement::webkitEnterFullScreen):
(WebCore::HTMLVideoElement::webkitExitFullScreen):

html/HTMLVideoElement.idl:
platform/graphics/mac/MediaPlayerProxy.h:

WebKit/mac:

This patch changes all occurrences of "fullScreen" to the more
popular "fullscreen."

Plugins/Hosted/NetscapePluginHostProxy.h:

(WebKit::NetscapePluginHostProxy::isFullscreenWindowShowing):

Plugins/Hosted/NetscapePluginHostProxy.mm:

(WebKit::NetscapePluginHostProxy::NetscapePluginHostProxy):
(WebKit::NetscapePluginHostProxy::didEnterFullscreen):
(WebKit::NetscapePluginHostProxy::didExitFullscreen):
(WebKit::NetscapePluginHostProxy::setFullscreenWindowIsShowing):
(WKPCSetFullscreenWindowIsShowing):

Plugins/Hosted/WebKitPluginClient.defs:
Plugins/WebNetscapePluginView.mm:

(-[WebNetscapePluginView _workaroundSilverlightFullscreenBug:]):
(-[WebNetscapePluginView _createPlugin]):
(-[WebNetscapePluginView _destroyPlugin]):

WebView/WebVideoFullscreenHUDWindowController.mm:

(-[WebVideoFullscreenHUDWindowController windowDidLoad]):

WebKit/win:

This patch changes all occurrences of "fullScreen" to the more
popular "fullscreen."

FullscreenVideoController.cpp:

(FullscreenVideoController::onMouseDown):
(FullscreenVideoController::onMouseMove):
(FullscreenVideoController::onMouseUp):

FullscreenVideoController.h:

(FullscreenVideoController::fullscreenToHUDCoordinates):

5:02 PM Changeset in webkit [55945] by jamesr@google.com

2 edits in trunk/WebCore

2010-03-12 James Robinson <jamesr@chromium.org>

Reviewed by Adam Barth.

Add virtual destructor to DOMWrapperWorld
https://bugs.webkit.org/show_bug.cgi?id=36077

DOMWrapperWorld is RefCounted<DOMWrapperWorld>. IsolatedWorld
inherits from DOMWrapperWorld and has member variables
with destructors, so DOMWrapperWorld needs to have a declared virtual
d'tor to ensure that its derived class's destructors are called.

No new tests, no change in behavior

bindings/v8/DOMWrapperWorld.h: (WebCore::DOMWrapperWorld::~DOMWrapperWorld):

4:46 PM Changeset in webkit [55944] by barraclough@apple.com

2 edits in trunk/JavaScriptCore

JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:

Reviewed by NOBODY (build fix).

3:49 PM Changeset in webkit [55943] by barraclough@apple.com

10 edits in trunk

Bug 36075 - Clean up screwyness re static string impls & Identifiers.

Reviewed by Oliver Hunt.

JavaScriptCore:

API/JSClassRef.cpp:

(OpaqueJSClass::~OpaqueJSClass): Classname may be null/empty, and these are an identifer. This is okay, since the null/empty strings are shared across all threads.

JavaScriptCore.exp:
runtime/Identifier.cpp:

(JSC::Identifier::add): No need to explicitly hash null reps, this is done in the ststic UStringImpl constructor.
(JSC::Identifier::addSlowCase): UStringImpl::empty() handled & checkCurrentIdentifierTable now called in the header.
(JSC::Identifier::checkCurrentIdentifierTable): Replaces checkSameIdentifierTable (this no longer checked the rep since the identifierTable pointer was removed from UString::Rep long ago).

runtime/Identifier.h:

(JSC::Identifier::add): Replace call to checkSameIdentifierTable with call to checkCurrentIdentifierTable at head of function.

runtime/UStringImpl.cpp:

(JSC::UStringImpl::~UStringImpl): Remove call to checkConsistency - this function no longer checks anything interesting.

runtime/UStringImpl.h:

(JSC::UStringOrRopeImpl::UStringOrRopeImpl): Set s_refCountFlagIsIdentifier in static constructor.
(JSC::UStringImpl::UStringImpl): remove calls to checkConsistency (see above), add new ASSERT to substring constructor.
(JSC::UStringImpl::setHash): ASSERT not static (static strings set the hash in their constructor, should not reach this code path).
(JSC::UStringImpl::create): Add missing ASSERT.
(JSC::UStringImpl::setIsIdentifier): ASSERT !isStatic() (static strings hash set in constructor).

WebCore:

platform/text/StringImpl.cpp:

(WebCore::StringImpl::~StringImpl): Add ASSERT
(WebCore::StringImpl::sharedBuffer): Add ASSERT

platform/text/StringImpl.h:

(WebCore::StringImpl::setHash): Add ASSERT
(WebCore::StringImpl::isStatic): added.

3:17 PM Changeset in webkit [55942] by Beth Dakin

2 edits in trunk/WebKit/win

Fix for https://bugs.webkit.org/show_bug.cgi?id=33739 Fullscreen
video HUD stays on top when switching to another window (e.g. via
Alt-Tab)
-and corresponding-
<rdar://problem/7547574>

Reviewed by Adam Roben.

The HUD was always on top because it had the WS_EX_TOPMOST style.
So I removed the style and made m_videoWindow the owner of
m_hudWindow. This keeps m_hudWindow on top only when m_videoWindow
is the focused window.

FullscreenVideoController.cpp:

(FullscreenVideoController::exitFullscreen): ASSERT that movie()->exitFullscreen() also destroyed the hud.
(FullscreenVideoController::createHUDWindow):

3:11 PM Changeset in webkit [55941] by enrica@apple.com

6 edits
10 adds
1 delete in trunk

Content of 3D tests appears at the bottom right corner sometimes.
<rdar://problem/7556244>
<https://bugs.webkit.org/show_bug.cgi?id=36027>

Reviewed by Simon Fraser.

WebCore:

There were two problems to solve here:

the incorrect anchoring of the rootChildLayer that was causing the composited content to be positioned incorrectly
the failure to paint the non composited content into the backing store when animating composited content.

The first problem has been solved by leaving the original anchor point for the
rootChildLayer and splitting the tasks of clipping and scrolling using two separate layers.
The second problem has been solved leveraging the knowledge that WebView has of the dirty region
of the backing store to pass this information to the layer renderer. This allows the renderer to force
a paint into the backing store before moving to the compositing.

Tests: compositing/geometry/horizontal-scroll-composited.html

compositing/geometry/vertical-scroll-composited.html

manual-tests/win/horizontal-scroll-composited.html: Removed. This is now a layout test.
manual-tests/win/milliondollar.html: Added.
platform/graphics/win/WKCACFLayerRenderer.cpp:

(WebCore::WKCACFLayerRenderer::WKCACFLayerRenderer): Added initialization of dirty flag.
(WebCore::WKCACFLayerRenderer::setScrollFrame):
(WebCore::WKCACFLayerRenderer::updateScrollFrame): Updated to resize and position the clip and scroll layers.
(WebCore::WKCACFLayerRenderer::setRootChildLayer):
(WebCore::WKCACFLayerRenderer::createRenderer): Added new layer hierarchy.
(WebCore::WKCACFLayerRenderer::destroyRenderer): Remove clip layer on destroy.
(WebCore::WKCACFLayerRenderer::resize):
(WebCore::WKCACFLayerRenderer::paint): Forcing paint massage to trigger paint into the backing store.

platform/graphics/win/WKCACFLayerRenderer.h:

(WebCore::WKCACFLayerRenderer::setBackingStoreDirty): Added.

WebKit/win:

See detailed comments in WebCore/ChangeLog.

WebView.cpp:

(WebView::deleteBackingStore): Reset the dirty flag when deleting the backing store.
(WebView::addToDirtyRegion): Set the dirty flag when adding dirty rectangles to the
backing store dirty region.
(WebView::updateBackingStore): Reset the dirty flag after painting into the backing store.
(WebView::setAcceleratedCompositing): Removed unnecessary call to updateRootLayerContents.
(WebView::updateRootLayerContents): Changed the way we pass parameters to setScrollFrame.
We are passing width and height of the view content together with the offset for the scrolling.
It was confusing to pass it all as a rectangle, when it is not a rectangle.

LayoutTests:

compositing/geometry/horizontal-scroll-composited.html: Added.
compositing/geometry/vertical-scroll-composited.html: Added.
compositing/resources/apple.jpg: Added.
platform/mac/compositing/geometry/horizontal-scroll-composited-expected.checksum: Added.
platform/mac/compositing/geometry/horizontal-scroll-composited-expected.png: Added.
platform/mac/compositing/geometry/horizontal-scroll-composited-expected.txt: Added.
platform/mac/compositing/geometry/vertical-scroll-composited-expected.checksum: Added.
platform/mac/compositing/geometry/vertical-scroll-composited-expected.png: Added.
platform/mac/compositing/geometry/vertical-scroll-composited-expected.txt: Added.

2:58 PM Changeset in webkit [55940] by dpranke@chromium.org

2 edits in trunk/WebKitTools

2010-03-12 Dirk Pranke <dpranke@chromium.org>

Reviewed by Dimitri Glazkov.

Fix typo in websocket_server (path_from_base instead of
path_from_chromium_base).

https://bugs.webkit.org/show_bug.cgi?id=36074

Scripts/webkitpy/layout_tests/port/websocket_server.py:

2:49 PM Changeset in webkit [55939] by robert@webkit.org

2 edits in trunk/WebCore

2010-03-12 Robert Hogan <robert@webkit.org>

Not reviewed, build fix.

Revert http://trac.webkit.org/projects/webkit/changeset/55374 which broke
the !ENABLE(DATABASE) build on all platforms when attempting to fix the
--minimal build on Qt.

Support for SQLite now seems to be non-negotiable for the Qt build but making
it mandatory requires review, so re-break --minimal Qt build for now.

Qt build issue now tracked at https://bugs.webkit.org/show_bug.cgi?id=36073

page/GeolocationPositionCache.cpp:

2:43 PM Changeset in webkit [55938] by dpranke@chromium.org

5 edits in trunk/WebKitTools

2010-03-12 Dirk Pranke <dpranke@chromium.org>

Reviewed by Adam Barth.

new-run-webkit-tests --new-baseline doesn't work at all.

It attempts to call a method that isn't defined. To fix it, I
removed the unnecessary and unnecessarily confusing 'platform'
argument to the test_type constructor and use the Port object that
is passed in instead, since we are only ever generating a baseline
from the port that is currently executing.

https://bugs.webkit.org/show_bug.cgi?id=36046

Scripts/webkitpy/layout_tests/port/mac.py:
Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
Scripts/webkitpy/layout_tests/run_webkit_tests.py:
Scripts/webkitpy/layout_tests/test_types/test_type_base.py:

2:42 PM Changeset in webkit [55937] by dpranke@chromium.org

2 edits in trunk/WebKitTools

2010-03-12 Dirk Pranke <dpranke@chromium.org>

Reviewed by Adam Barth.

Fix new-run-webkit-tests --run-singly

This script option is currently broken - the script attempts to
dereference methods and variables that don't exist, which causes
the Chromium Linux valgrind bot to be quite unhappy. This has been
broken since r54449 when I renamed Port.start_test_driver to
Port.start_driver.

https://bugs.webkit.org/show_bug.cgi?id=36042

Scripts/webkitpy/layout_tests/layout_package/test_shell_thread.py:

2:31 PM Changeset in webkit [55936] by krit@webkit.org

2 edits in trunk/LayoutTests

2010-03-12 Dirk Schulze <krit@webkit.org>

Unreviewed LayoutTest update.

Result was not updated with r55930.

platform/mac/svg/custom/dominant-baseline-hanging-expected.txt:

1:23 PM Changeset in webkit [55935] by mitz@apple.com

2 edits in trunk/WebCore

<rdar://problem/7709115> REGRESSION: toolbar is missing at http://www.glom.org/
https://bugs.webkit.org/show_bug.cgi?id=35507

Reviewed by Alexey Proskuryakov.

css/CSSImportRule.cpp:

(WebCore::CSSImportRule::setCSSStyleSheet): Extend the change made in
<http://trac.webkit.org/changeset/48818> to detect the two variants of
KHTMLFixes.css in @import rules as well as in <link> elements.

1:16 PM Changeset in webkit [55934] by barraclough@apple.com

2 edits in trunk/WebCore

Bug 36052 - [Qt] REGRESSION(55878) 63 test cases crash

Reviewed by Geoff Garen.

r55878 changed UStringImpl::empty()->characters() to be non-null,
so TextBreakIteratorQt.cpp now should check the length of strings
(previously was assuming all strings with a non-null data pointer
had a length of at least 1).

platform/text/qt/TextBreakIteratorQt.cpp:

(WebCore::wordBreakIterator):
(WebCore::characterBreakIterator):
(WebCore::lineBreakIterator):
(WebCore::sentenceBreakIterator):

1:15 PM Changeset in webkit [55933] by abarth@webkit.org

2 edits in trunk/WebKit/chromium

2010-03-12 Garret Kelly <gdk@chromium.org>

Unreiviewed.

Fix Chromium Mac build. Last patch did not apply properly.
(Garret assures me this patch will actually work.)

src/WebInputEventConversion.cpp: (WebKit::toPlatformTouchEventType): (WebKit::toPlatformTouchPointState):

12:48 PM Changeset in webkit [55932] by abarth@webkit.org

2 edits in trunk/WebKit/chromium

2010-03-12 Garret Kelly <gdk@chromium.org>

Unreviewed.

Fix Chromium Mac build. This time, with actual fixing goodness.

src/WebInputEventConversion.cpp: (WebKit::toPlatformTouchEventType): (WebKit::toPlatformTouchPointState):

12:47 PM Changeset in webkit [55931] by beidson@apple.com

4 edits in trunk/WebKit/mac

Expose WebPDFView's underlying PDFDocument.

Patch by Andy Estes <aestes@apple.com> on 2010-03-12
Reviewed by Brady Eidson.

https://bugs.webkit.org/show_bug.cgi?id=36045

WebView/WebDocumentPrivate.h: Create a new protocol called

WebDocumentPDF.

WebView/WebPDFView.h: Have WebPDFView implement said protocol.
WebView/WebPDFView.mm:

(-[WebPDFView PDFDocument]): Expose WebPDFView's underlying
PDFDocument by implementing -(PDFDocument*)PDFDocument from
WebDocumentPDF.

12:43 PM Changeset in webkit [55930] by krit@webkit.org

5 edits
4 adds in trunk

2010-03-12 Dirk Schulze <krit@webkit.org>

Reviewed by Nikolas Zimmermann.

SVG fallback color doesn't work for bogus gradients.
https://bugs.webkit.org/show_bug.cgi?id=35479

Use a given fallback color on ignored gradients if present. Gradients
must be ignored, if one dimension of the objects boundingBox is zero.

Test: svg/custom/gradient-with-1d-boundingbox.svg

svg/graphics/SVGPaintServer.cpp: (WebCore::SVGPaintServer::strokePaintServer):
svg/graphics/SVGPaintServerGradient.cpp: (WebCore::SVGPaintServerGradient::setup):

2010-03-12 Dirk Schulze <krit@webkit.org>

Reviewed by Nikolas Zimmermann.

SVG fallback color doesn't work for bogus gradients.
https://bugs.webkit.org/show_bug.cgi?id=35479

We now use a fallback color on ignored gradients for one dimensional objects,
either a given fallback color or black as default.
This causes a change of one LayoutTest, because it was done manually in the
gradient PaintServer, without respecting a given fallback color.

platform/mac/svg/W3C-SVG-1.1/pservers-grad-17-b-expected.txt:
platform/mac/svg/custom/gradient-with-1d-boundingbox-expected.checksum: Added.
platform/mac/svg/custom/gradient-with-1d-boundingbox-expected.png: Added.
platform/mac/svg/custom/gradient-with-1d-boundingbox-expected.txt: Added.
svg/custom/gradient-with-1d-boundingbox.svg: Added.

12:36 PM Changeset in webkit [55929] by abarth@webkit.org

2 edits in trunk/WebKit/chromium

2010-03-12 Garret Kelly <gdk@chromium.org>

Unreviewed.

Fix Chromium Mac build.

src/WebInputEventConversion.cpp: (WebKit::toPlatformTouchEventType): (WebKit::toPlatformTouchPointState):

12:29 PM Changeset in webkit [55928] by hyatt@apple.com

16 edits
1 delete in trunk/WebCore

https://bugs.webkit.org/show_bug.cgi?id=36069

Reviewed by Dan Bernstein.

Eliminate InlineRunBox.

WebCore.xcodeproj/project.pbxproj:
rendering/InlineFlowBox.cpp:

(WebCore::InlineFlowBox::adjustPosition):
(WebCore::InlineFlowBox::paintFillLayer):
(WebCore::InlineFlowBox::paintBoxDecorations):
(WebCore::InlineFlowBox::paintMask):

rendering/InlineFlowBox.h:

(WebCore::InlineFlowBox::InlineFlowBox):
(WebCore::InlineFlowBox::prevLineBox):
(WebCore::InlineFlowBox::nextLineBox):
(WebCore::InlineFlowBox::setNextLineBox):
(WebCore::InlineFlowBox::setPreviousLineBox):

rendering/InlineRunBox.h: Removed.
rendering/InlineTextBox.h:

(WebCore::InlineTextBox::InlineTextBox):
(WebCore::InlineTextBox::prevTextBox):
(WebCore::InlineTextBox::nextTextBox):
(WebCore::InlineTextBox::setNextTextBox):
(WebCore::InlineTextBox::setPreviousTextBox):

rendering/RenderBlock.cpp:

(WebCore::RenderBlock::destroy):
(WebCore::RenderBlock::rightmostPosition):
(WebCore::RenderBlock::leftmostPosition):

rendering/RenderInline.cpp:

(WebCore::RenderInline::destroy):
(WebCore::RenderInline::absoluteRects):
(WebCore::RenderInline::absoluteQuads):
(WebCore::RenderInline::linesBoundingBox):
(WebCore::RenderInline::linesVisibleOverflowBoundingBox):
(WebCore::RenderInline::addFocusRingRects):
(WebCore::RenderInline::paintOutline):

rendering/RenderLayer.cpp:

(WebCore::RenderLayer::localBoundingBox):

rendering/RenderLineBoxList.cpp:

(WebCore::RenderLineBoxList::deleteLineBoxTree):
(WebCore::RenderLineBoxList::extractLineBox):
(WebCore::RenderLineBoxList::attachLineBox):
(WebCore::RenderLineBoxList::removeLineBox):
(WebCore::RenderLineBoxList::deleteLineBoxes):
(WebCore::RenderLineBoxList::dirtyLineBoxes):
(WebCore::RenderLineBoxList::paint):
(WebCore::RenderLineBoxList::hitTest):
(WebCore::RenderLineBoxList::dirtyLinesFromChangedChild):
(WebCore::RenderLineBoxList::checkConsistency):

rendering/RenderSVGInline.cpp:

(WebCore::RenderSVGInline::absoluteRects):
(WebCore::RenderSVGInline::absoluteQuads):

rendering/RenderSVGText.cpp:

(WebCore::RenderSVGText::absoluteRects):
(WebCore::RenderSVGText::absoluteQuads):
(WebCore::RenderSVGText::objectBoundingBox):

rendering/RenderText.cpp:

(WebCore::RenderText::extractTextBox):
(WebCore::RenderText::attachTextBox):
(WebCore::RenderText::removeTextBox):
(WebCore::RenderText::createInlineTextBox):
(WebCore::RenderText::positionLineBox):

rendering/RootInlineBox.h:

(WebCore::RootInlineBox::nextRootBox):
(WebCore::RootInlineBox::prevRootBox):

12:11 PM Changeset in webkit [55927] by kov@webkit.org

3 edits in trunk/WebCore

2010-03-12 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Reviewed by Eric Carlson.

media/video-preload.html fails
https://bugs.webkit.org/show_bug.cgi?id=35793

Only effectively load, and start buffering when playing, or when
the preload attribute is set.

Test: media/video-preload.html

platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivate::MediaPlayerPrivate): (WebCore::MediaPlayerPrivate::load): (WebCore::MediaPlayerPrivate::commitLoad): (WebCore::MediaPlayerPrivate::prepareToPlay): (WebCore::MediaPlayerPrivate::setPreload):
platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:

12:06 PM Changeset in webkit [55926] by dimich@chromium.org

30 edits
7 deletes in trunk

Not reviewed, build fix.

Reverts 55920 and 55921. Landing for Jian Li.

WebCore:

Android.derived.jscbindings.mk:
Android.derived.v8bindings.mk:
DerivedSources.cpp:
DerivedSources.make:
GNUmakefile.am:
WebCore.gypi:
WebCore.pri:
WebCore.vcproj/WebCore.vcproj:
WebCore.xcodeproj/project.pbxproj:
bindings/js/JSDOMFormDataCustom.cpp: Removed.
bindings/js/JSXMLHttpRequestCustom.cpp:

(WebCore::JSXMLHttpRequest::send):

bindings/scripts/CodeGeneratorJS.pm:
bindings/v8/V8Index.h:
bindings/v8/custom/V8DOMFormDataCustom.cpp: Removed.
bindings/v8/custom/V8XMLHttpRequestCustom.cpp:

(WebCore::V8XMLHttpRequest::sendCallback):

html/DOMFormData.idl: Removed.
page/DOMWindow.idl:

LayoutTests:

fast/dom/Window/window-properties-expected.txt:
fast/dom/Window/window-property-descriptors-expected.txt:
fast/dom/constructed-objects-prototypes-expected.txt:
fast/dom/prototype-inheritance-2-expected.txt:
fast/dom/prototype-inheritance-expected.txt:
fast/js/global-constructors-expected.txt:
http/tests/local/resources/send-form-data.js: Removed.
http/tests/local/send-form-data-expected.txt: Removed.
http/tests/local/send-form-data.html: Removed.
http/tests/xmlhttprequest/resources/multipart-post-echo.php: Removed.
platform/gtk/Skipped:
platform/gtk/fast/dom/Window/window-properties-expected.txt:
platform/qt/Skipped:
platform/qt/fast/dom/Window/window-properties-expected.txt:
platform/qt/fast/dom/Window/window-property-descriptors-expected.txt:
platform/qt/fast/dom/prototype-inheritance-expected.txt:
platform/qt/fast/js/global-constructors-expected.txt:
platform/win/Skipped:

12:03 PM Changeset in webkit [55925] by kov@webkit.org

2 edits in trunk/WebKitTools

2010-03-12 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Fix critical being printed to stderr on every test. This is
because the jar is only being created when soup hits the HTTP
path. We should reconsider the time of its creation.

DumpRenderTree/gtk/DumpRenderTree.cpp: (resetDefaultsToConsistentValues):

11:57 AM Changeset in webkit [55924] by tonikitoo@webkit.org

2 edits in trunk/LayoutTests

Make the timeout in 'snav-unit-overflow-and-scroll-in-direction.html' 10x shorter (from 500ms to 50ms)

Rubber-stamped by Kenneth Christiansen.
Patch by Antonio Gomes <tonikitoo@webkit.org>

fast/events/spatial-navigation/snav-unit-overflow-and-scroll-in-direction.html:

11:45 AM Changeset in webkit [55923] by jpetsovits@rim.com

3 edits in trunk/WebCore

2010-03-12 Jakob Petsovits <jpetsovits@rim.com>

Reviewed by Dirk Schulze.

[OpenVG] Add support for drawing text to PainterOpenVG
https://bugs.webkit.org/show_bug.cgi?id=35581

Doesn't come with any actual font classes, as OpenVG
by itself doesn't provide any access to platform fonts
but just the means to draw glyphs that have been loaded
manually before.

platform/graphics/openvg/PainterOpenVG.cpp: (WebCore::PlatformPainterState::PlatformPainterState): (WebCore::PlatformPainterState::copyPaintState): (WebCore::PainterOpenVG::textDrawingMode): (WebCore::PainterOpenVG::setTextDrawingMode): (WebCore::PainterOpenVG::drawText):
platform/graphics/openvg/PainterOpenVG.h:

11:25 AM Changeset in webkit [55922] by jpetsovits@rim.com

6 edits in trunk/WebCore

2010-03-12 Jakob Petsovits <jpetsovits@rim.com>

Reviewed by Dirk Schulze.

[OpenVG] Use masks to implement non-rectilinear clipping
https://bugs.webkit.org/show_bug.cgi?id=35544

Requires some additional context switching logic to
make sure the right context is current when dealing
with the mask, because we don't store it by ourselves.

Initial version of this code was written by
Eli Fidler <efidler@rim.com>, I did a couple of
bug fixes and efficiency improvements since then.

platform/graphics/openvg/GraphicsContextOpenVG.cpp: (WebCore::GraphicsContext::clipPath): (WebCore::GraphicsContext::clip): (WebCore::GraphicsContext::clipOut): (WebCore::GraphicsContext::clipOutEllipseInRect): (WebCore::GraphicsContext::addInnerRoundedRectClip):
platform/graphics/openvg/PainterOpenVG.cpp: (WebCore::PlatformPainterState::PlatformPainterState): (WebCore::PlatformPainterState::~PlatformPainterState): (WebCore::PlatformPainterState::maskingEnabled): (WebCore::PlatformPainterState::applyState): (WebCore::PlatformPainterState::saveMaskIfNecessary): (WebCore::PainterOpenVG::intersectClipRect): (WebCore::PainterOpenVG::clipPath): (WebCore::PainterOpenVG::save):
platform/graphics/openvg/PainterOpenVG.h: (WebCore::PainterOpenVG::):
platform/graphics/openvg/SurfaceOpenVG.cpp: (WebCore::SurfaceOpenVG::makeCurrent): (WebCore::SurfaceOpenVG::makeCompatibleCurrent):
platform/graphics/openvg/SurfaceOpenVG.h: (WebCore::SurfaceOpenVG::):

11:17 AM Changeset in webkit [55921] by jianli@chromium.org

4 edits
1 add in trunk/WebCore

[v8] Add V8 bindings for DOMFormData.
https://bugs.webkit.org/show_bug.cgi?id=36026

Reviewed by Nate Chapin.

Test: http/tests/local/send-form-data.html

WebCore.gypi:
bindings/v8/V8Index.h:
bindings/v8/custom/V8DOMFormDataCustom.cpp: Added.

(WebCore::V8DOMFormData::appendCallback):

bindings/v8/custom/V8XMLHttpRequestCustom.cpp:

(WebCore::V8XMLHttpRequest::sendCallback):

11:17 AM Changeset in webkit [55920] by jianli@chromium.org

27 edits
6 adds in trunk

WebCore: Add DOMFormData.idl to expose FormData interface.
https://bugs.webkit.org/show_bug.cgi?id=36024

Reviewed by Sam Weinig.

The implementation is based on XMLHttpRequest 2 spec:
http://dev.w3.org/2006/webapi/XMLHttpRequest-2/#formdata

Test: http/tests/local/send-form-data.html

Android.derived.jscbindings.mk:
Android.derived.v8bindings.mk:
DerivedSources.cpp:
DerivedSources.make:
GNUmakefile.am:
WebCore.pri:
WebCore.vcproj/WebCore.vcproj:
WebCore.xcodeproj/project.pbxproj:
bindings/js/JSDOMFormDataCustom.cpp: Added.
bindings/js/JSXMLHttpRequestCustom.cpp:

(WebCore::JSXMLHttpRequest::send):

bindings/scripts/CodeGeneratorJS.pm:
html/DOMFormData.idl: Added.
page/DOMWindow.idl:

LayoutTests: Add DOMFormData.idl to expose FormData interface
https://bugs.webkit.org/show_bug.cgi?id=36024

Reviewed by Sam Weinig.

Add a layout test to test sending FormData via XMLHttpRequest. Also
changed all test results that are affected by exposing FormData.

fast/dom/Window/window-properties-expected.txt:
fast/dom/Window/window-property-descriptors-expected.txt:
fast/dom/constructed-objects-prototypes-expected.txt:
fast/dom/prototype-inheritance-2-expected.txt:
fast/dom/prototype-inheritance-expected.txt:
fast/js/global-constructors-expected.txt:
http/tests/local/resources/send-form-data.js: Added.
http/tests/local/send-form-data-expected.txt: Added.
http/tests/local/send-form-data.html: Added.
http/tests/xmlhttprequest/resources/multipart-post-echo.php: Added.
platform/gtk/Skipped:
platform/gtk/fast/dom/Window/window-properties-expected.txt:
platform/qt/Skipped:
platform/qt/fast/dom/Window/window-properties-expected.txt:
platform/qt/fast/dom/Window/window-property-descriptors-expected.txt:
platform/qt/fast/dom/prototype-inheritance-expected.txt:
platform/qt/fast/js/global-constructors-expected.txt:
platform/win/Skipped:

11:11 AM Changeset in webkit [55919] by jpetsovits@rim.com

5 edits in trunk/WebCore

2010-03-12 Jakob Petsovits <jpetsovits@rim.com>

Reviewed by Dirk Schulze.

[OpenVG] Add a SurfaceOpenVG constructor for EGL client buffer surfaces
https://bugs.webkit.org/show_bug.cgi?id=35538

SurfaceOpenVG can now not only encapsulate pbuffer
and window surfaces but also VGImage-based ones.

platform/graphics/openvg/EGLDisplayOpenVG.cpp: (WebCore::EGLDisplayOpenVG::createPbufferFromClientBuffer):
platform/graphics/openvg/EGLDisplayOpenVG.h:
platform/graphics/openvg/SurfaceOpenVG.cpp: (WebCore::SurfaceOpenVG::SurfaceOpenVG):
platform/graphics/openvg/SurfaceOpenVG.h:

11:06 AM Changeset in webkit [55918] by Adam Roben

2 edits in trunk/WebKitTools

Teach prepare-ChangeLog to find modified selectors in CSS files

Reviewed by Tim Hatcher.

Fixes <http://webkit.org/b/36064> prepare-ChangeLog should extract
modified selectors from CSS files

Scripts/prepare-ChangeLog:

(get_function_line_ranges): Call get_selector_line_ranges_for_css for
.css files.
(get_selector_line_ranges_for_css): Added. Finds selectors and their
line ranges and returns them.

11:03 AM Changeset in webkit [55917] by eric@webkit.org

3 edits
2 adds in trunk

2010-03-12 Alpha Lam <hclam@chromium.org>

Reviewed by Eric Carlson.

HTMLMediaElement crash when it is used after resource loading is canceled.
https://bugs.webkit.org/show_bug.cgi?id=35992

Adding a test to access the duration property of a video element after
resource loading was canceled.

http/tests/media/video-cancel-load-expected.txt: Added.
http/tests/media/video-cancel-load.html: Added.

2010-03-12 Alpha Lam <hclam@chromium.org>

Reviewed by Eric Carlson.

Fix a crash when resource loading of media element is canceled.
https://bugs.webkit.org/show_bug.cgi?id=35992

Use of HTMLMediaElement::duration() after resource loading was canceled
will cause a crash. This is because HTMLMediaElement::m_player is used
when NULL.
Test: http/tests/media/video-cancel-load.html

html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::duration): Avoid calling to m_player when it is null. (WebCore::HTMLMediaElement::userCancelledLoad): Set m_readyState to HAVE_NOTHING.

10:45 AM Changeset in webkit [55916] by eric@webkit.org

2 edits in trunk/WebKit/chromium

2010-03-12 Garret Kelly <gdk@chromium.org>

Reviewed by Eric Seidel.

Enable touch events in Chromium features gypi file.
https://bugs.webkit.org/show_bug.cgi?id=35994

features.gypi:

10:36 AM Changeset in webkit [55915] by kov@webkit.org

9 edits in trunk/WebKit/gtk

2010-03-12 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Rubber-stamped by Kenneth Rohde Christiansen.

Misc documentation fixes. Fixes (almost) all warnings emitted by
the documentation build process. Only the broken references to JSC
objects remain.

webkit/webkitsecurityorigin.cpp:
webkit/webkitwebbackforwardlist.cpp:
webkit/webkitwebdatasource.cpp:
webkit/webkitwebframe.cpp:
webkit/webkitwebhistoryitem.cpp:
webkit/webkitwebinspector.cpp: (webkit_web_inspector_class_init):
webkit/webkitwebsettings.cpp: (webkit_web_settings_class_init):
webkit/webkitwebview.cpp: (DNDContentsRequest::webkit_web_view_class_init):

10:28 AM Changeset in webkit [55914] by mitz@apple.com

2 edits in trunk/WebCore

<rdar://problem/7725534> CSSPrimitiveValue::parserValue() returns deleted memory
https://bugs.webkit.org/show_bug.cgi?id=20069

Reviewed by Darin Adler.

No test added, since with the CSS variables feature disabled, the pointer
to the freed memory is never dereferenced.

css/CSSPrimitiveValue.cpp:

(WebCore::valueOrPropertyName): Changed to return a const AtomicString& from
a static table.
(WebCore::CSSPrimitiveValue::parserValue): Updated for the above change.

10:18 AM Changeset in webkit [55913] by ojan@chromium.org

38 edits
4 copies
7 adds in trunk/LayoutTests

2010-03-05 Ojan Vafai <ojan@chromium.org>

Reviewed by David Levin.

Tests for smartdelete should only occur after double-click
https://bugs.webkit.org/show_bug.cgi?id=35314

Fixes the tests to make selections using the mouse in order
to force smart-delete. It also adds/modifies tests to have them correctly
identify cases where we are smart-deleting, but shouldn't be.

Fixing to smart-delete only on mouse-based selections will be a followup patch.

editing/deleting/5390681-2.html:
editing/deleting/non-smart-delete.html: Added.
editing/deleting/smart-delete-001.html:
editing/deleting/smart-delete-002.html:
editing/deleting/smart-delete-003.html:
editing/deleting/smart-delete-004.html:
editing/editing.js: (doubleClick): (doubleClickAtSelectionStart):
editing/pasteboard/4944770-2.html:
editing/pasteboard/drag-drop-modifies-page.html:
editing/pasteboard/smart-drag-drop.html: Added.
editing/pasteboard/smart-paste-001.html:
editing/pasteboard/smart-paste-002.html:
editing/pasteboard/smart-paste-003.html:
editing/pasteboard/smart-paste-004.html:
editing/pasteboard/smart-paste-005.html:
editing/pasteboard/smart-paste-007.html:
editing/pasteboard/smart-paste-008.html:
editing/selection/delete-word-granularity-text-control-expected.txt: Added.
editing/selection/delete-word-granularity-text-control.html: Added.
editing/selection/script-tests/delete-word-granularity-text-control.js: Added.
editing/style/style-boundary-005.html:
platform/mac/editing/deleting/non-smart-delete-expected.checksum: Added.
platform/mac/editing/deleting/non-smart-delete-expected.png: Added.
platform/mac/editing/deleting/non-smart-delete-expected.txt: Added.
platform/mac/editing/deleting/smart-delete-001-expected.txt:
platform/mac/editing/deleting/smart-delete-002-expected.txt:
platform/mac/editing/deleting/smart-delete-003-expected.txt:
platform/mac/editing/deleting/smart-delete-004-expected.txt:
platform/mac/editing/pasteboard/drag-drop-modifies-page-expected.checksum:
platform/mac/editing/pasteboard/drag-drop-modifies-page-expected.png:
platform/mac/editing/pasteboard/drag-drop-modifies-page-expected.txt:
platform/mac/editing/pasteboard/smart-drag-drop-expected.checksum: Added.
platform/mac/editing/pasteboard/smart-drag-drop-expected.png: Added.
platform/mac/editing/pasteboard/smart-drag-drop-expected.txt: Added.
platform/mac/editing/pasteboard/smart-paste-001-expected.txt:
platform/mac/editing/pasteboard/smart-paste-002-expected.txt:
platform/mac/editing/pasteboard/smart-paste-003-expected.txt:
platform/mac/editing/pasteboard/smart-paste-004-expected.txt:
platform/mac/editing/pasteboard/smart-paste-005-expected.txt:
platform/mac/editing/pasteboard/smart-paste-007-expected.txt:
platform/mac/editing/pasteboard/smart-paste-008-expected.txt:
platform/mac/editing/style/style-boundary-005-expected.checksum:
platform/mac/editing/style/style-boundary-005-expected.png:
platform/mac/editing/style/style-boundary-005-expected.txt:

10:14 AM Changeset in webkit [55912] by darin@chromium.org

2 edits in trunk/WebKit/chromium

2010-03-12 Darin Fisher <darin@chromium.org>

Fix Chromium build bustage.

Wrap usage of WebPrivatePtr from WebNode.h in a #if
WEBKIT_IMPLEMENTATION guard.

public/WebNode.h:

10:03 AM Changeset in webkit [55911] by mitz@apple.com

2 edits in trunk/WebCore

Build fix.

platform/chromium/PlatformKeyboardEventChromium.cpp:

9:54 AM Changeset in webkit [55910] by ap@apple.com

1 edit in trunk/WebKitTools/ChangeLog

Fixing an embarrassing typo in ChangeLog.

9:06 AM Changeset in webkit [55909] by mitz@apple.com

16 edits
2 adds in trunk

<rdar://problem/7694674> Hover states not updated when overflow section scrolls under stationary mouse pointer
https://bugs.webkit.org/show_bug.cgi?id=35949

Reviewed by Darin Adler.

WebCore:

Test: fast/events/overflow-scroll-fake-mouse-move.html

Soon after an overflow section scrolls under the mouse pointer, dispatch
a fake mouse move event. This is similar to how frame scrolling is handled
in WebKit, and has the effect of updating hover state, dispatching DOM mouse
events, and updating the tool tip.

page/EventHandler.cpp:

(WebCore::EventHandler::EventHandler): Initialize m_fakeMouseMoveEventTimer.
(WebCore::EventHandler::~EventHandler): Assert that the timer is not active.
(WebCore::EventHandler::clear): Stop the timer.
(WebCore::EventHandler::handleMousePressEvent): Cancel pending fake mouse
move events.
(WebCore::EventHandler::handleMouseMoveEvent): Ditto.
(WebCore::EventHandler::dispatchFakeMouseMoveEventSoonInQuad): If the mouse
is in the passed-in quad, ensure that a fake mouse move event is scheduled
to fire soon.
(WebCore::EventHandler::cancelFakeMouseMoveEvent): Does what the name says.
(WebCore::EventHandler::fakeMouseMoveEventTimerFired): Constructs a
PlatformMouseEvent with the current mouse location, modifier key state and
time stamp and calls mouseMoved().

page/EventHandler.h:
platform/PlatformKeyboardEvent.h: Declared getCurrentModifierState().
platform/android/KeyEventAndroid.cpp:

(WebCore::PlatformKeyboardEvent::getCurrentModifierState): Stubbed out.

platform/brew/PlatformKeyboardEventBrew.cpp:

(WebCore::PlatformKeyboardEvent::getCurrentModifierState): Ditto.

platform/chromium/PlatformKeyboardEventChromium.cpp:

(WebCore::PlatformKeyboardEvent::getCurrentModifierState): Added.

platform/efl/PlatformKeyboardEventEfl.cpp:

(WebCore::PlatformKeyboardEvent::getCurrentModifierState): Stubbed out.

platform/gtk/KeyEventGtk.cpp:

(WebCore::PlatformKeyboardEvent::getCurrentModifierState): Ditto.

platform/haiku/PlatformKeyboardEventHaiku.cpp:

(WebCore::PlatformKeyboardEvent::getCurrentModifierState): Added.

platform/mac/KeyEventMac.mm:

(WebCore::PlatformKeyboardEvent::getCurrentModifierState): Ditto.

platform/qt/PlatformKeyboardEventQt.cpp:

(WebCore::PlatformKeyboardEvent::getCurrentModifierState): Stubbed out.

platform/win/KeyEventWin.cpp:

(WebCore::PlatformKeyboardEvent::getCurrentModifierState): Added.

platform/wx/KeyboardEventWx.cpp:

(WebCore::PlatformKeyboardEvent::getCurrentModifierState): Ditto.

rendering/RenderLayer.cpp:

(WebCore::RenderLayer::scrollToOffset): Call
EventHandler::dispatchFakeMouseMoveEventSoonInQuad(). Moved things around
a little to avoid computing the repaint rect twice.

LayoutTests:

fast/events/overflow-scroll-fake-mouse-move-expected.txt: Added.
fast/events/overflow-scroll-fake-mouse-move.html: Added.
fast/events/touch/basic-multi-touch-events.html:
fast/events/touch/basic-single-touch-events.html:

9:03 AM Changeset in webkit [55908] by eric@webkit.org

2 edits in trunk/WebKit/chromium

2010-03-12 Nicolas Weber <thakis@chromium.org>

Reviewed by David Levin.

[Chromium] Cmd-clicking submit buttons should submit in new tab
https://bugs.webkit.org/show_bug.cgi?id=36023

Take modifiers into account when clicking form buttons. E.g.
cmd-clicking a submit button will submit in a new background tab,
cmd-shift-clicking in a new foreground tab, shift-clicking in a new
window. (On windows/linux, it's ctrl instead of cmd.)

src/FrameLoaderClientImpl.cpp: (WebKit::FrameLoaderClientImpl::actionSpecifiesNavigationPolicy):

8:56 AM Changeset in webkit [55907] by Csaba Osztrogonác

2 edits in trunk/LayoutTests

2010-03-12 Csaba Osztrogonác <Csaba Osztrogonác>

[Qt] css1/box_properties/acid_test.html failed in release mode (32 bit).
But it passes in debug mode (32 and 64 bit) and in release mode (64 bit).

https://bugs.webkit.org/show_bug.cgi?id=33834

platform/qt/Skipped: css1/box_properties/acid_test.html skipped again.

8:36 AM Changeset in webkit [55906] by eric@webkit.org

2 edits in trunk/WebKit/chromium

2010-03-12 Kavita Kanetkar <kkanetkar@chromium.org>

Reviewed by Darin Fisher.

[chromium] Fix memory leak in WebImageDecoder API
https://bugs.webkit.org/show_bug.cgi?id=35946

src/WebImageDecoder.cpp: (WebKit::WebImageDecoder::setData): (WebKit::WebImageDecoder::getFrameAtIndex):

8:15 AM Changeset in webkit [55905] by kov@webkit.org

3 edits in trunk/WebKitTools

Build fix (for EWS). Make sure the new code builds on older soup.

Thanks to Dan Winship.

8:05 AM Changeset in webkit [55904] by kov@webkit.org

6 edits in trunk

2010-03-12 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Reviewed by Eric Carlson.

[GTK] DRT does not handle cookie policy setting
https://bugs.webkit.org/show_bug.cgi?id=36056

Implement cookie accept policy setting for GTK+'s LayoutTestController.

DumpRenderTree/gtk/DumpRenderTree.cpp: (resetDefaultsToConsistentValues):
DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::setAlwaysAcceptCookies):

LayoutTests

2010-03-12 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Reviewed by Eric Carlson.

[GTK] DRT does not handle cookie policy setting
https://bugs.webkit.org/show_bug.cgi?id=36056

Fix tests to request that the cookie acceptance policy always allows cookies.

http/tests/media/video-cookie.html:
http/tests/media/video-referer.html:

8:02 AM Changeset in webkit [55903] by eric@webkit.org

2 edits in trunk/WebKitTools

2010-03-12 Adam Langley <agl@chromium.org>

Reviewed by Dimitri Glazkov.

[chromium]: update Linux layout test scripts for RedHat like systems.

(Tested on Fedora 12.)

https://bugs.webkit.org/show_bug.cgi?id=35867

Scripts/webkitpy/layout_tests/port/chromium_linux.py:

7:53 AM Changeset in webkit [55902] by Csaba Osztrogonác

2 edits in trunk/LayoutTests

[Qt] Now css1/box_properties/acid_test.html passes, so we can unskip it.
original bug: https://bugs.webkit.org/show_bug.cgi?id=33834

platform/qt/Skipped: css1/box_properties/acid_test.html unskipped.

7:45 AM Changeset in webkit [55901] by eric@webkit.org

2 edits in trunk/WebKit/mac

2010-03-12 Andy Estes <aestes@apple.com>

Reviewed by Brady Eidson.

Remove an unused method.

https://bugs.webkit.org/show_bug.cgi?id=35940

Plugins/WebPluginController.mm: removed - (void)showURL:(NSURL *) inFrame:(NSString *)

7:28 AM Changeset in webkit [55900] by eric@webkit.org

2 edits in trunk/JavaScriptCore

2010-03-12 Peter Varga <pvarga@inf.u-szeged.hu>

Reviewed by David Levin.

Two functions tryConsumeCharacter() and tryConsumeCharacterClass() are
removed from yarr/RegexInterpreter.cpp because they are never called.

yarr/RegexInterpreter.cpp:

7:16 AM Changeset in webkit [55899] by Csaba Osztrogonác

2 edits in trunk/LayoutTests

[Qt] DRT failing on test introduced in r55499
https://bugs.webkit.org/show_bug.cgi?id=35729

Now fast/events/zoom-dblclick.html passes, so we can unskip it.

platform/qt/Skipped: fast/events/zoom-dblclick.html unskipped.

7:12 AM Changeset in webkit [55898] by Adam Roben

2 edits in trunk/WebKitTools

Make svn-create-patch's diffs of ObjC header files more readable

Fixes <http://webkit.org/b/36055>.

Reviewed by John Sullivan.

Scripts/svn-create-patch:

(diffOptionsForFile): Added. Returns the options that should be passed
to diff for the given file. All the options are the same for all
files, except for the option to specify which lines should be used as
hunk headers.
(generateDiff): Use diffOptionsForFile to get the options to pass to
diff.
(hunkHeaderLineRegExForFile): Added. Returns the regular expression
that should be used by diff to identify lines that should be included
after the "@@" in the hunk header lines of the diff. For ObjC[++]
source files, we use any lines starting with -, +, or
@implementation/@interface/@protocol. For ObjC[++] header files (which
we assume to be any .h files in a mac/ or objc/ directory), we use any
lines starting with @implementation/@interface/@protocol.

7:10 AM Changeset in webkit [55897] by eric@webkit.org

5 edits in trunk

2010-03-12 Scott Byer <scottbyer@chromium.org>

Reviewed by David Levin.

Popup font size needs to be exposed to clients.
https://bugs.webkit.org/show_bug.cgi?id=35990

Add function to expose the popup menu font size, add a field to
WebPopupMenuInfo that receives that information to convey that to
the web view client's createPopupMenu() call.

WebCore/platform/chromium/PopupMenuChromium.cpp:
WebCore/platform/chromium/PopupMenuChromium.h:
WebKit/chromium/public/WebPopupMenuInfo.h:
WebKit/chromium/src/ChromeClientImpl.cpp:

6:53 AM Changeset in webkit [55896] by eric@webkit.org

2 edits in trunk/WebCore

2010-03-12 Kent Hansen <kent.hansen@nokia.com>

Reviewed by Darin Adler.

Webkit doesn't build with workers on and database off
https://bugs.webkit.org/show_bug.cgi?id=35997

Added missing ENABLE(DATABASE) guards.

workers/WorkerThread.cpp: (WebCore::WorkerThreadShutdownStartTask::performTask):

6:25 AM Changeset in webkit [55895] by kov@webkit.org

2 edits in trunk/LayoutTests

2010-03-12 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

[GTK] Fails fast/dom/Geolocation/maximum-age.htm
https://bugs.webkit.org/show_bug.cgi?id=36053

Skip new failing test.

platform/gtk/Skipped:

6:25 AM Changeset in webkit [55894] by kov@webkit.org

4 edits in trunk

2010-03-12 Dan Winship <danw@gnome.org>

Reviewed by Gustavo Noronha.

Make the defaultCookieJar use a no-third-party policy. Most
applications set their own cookie jar, but DumpRenderTree doesn't,
so it was failing the new third-party-cookie test.

platform/network/soup/CookieJarSoup.cpp: (WebCore::defaultCookieJar):

LayoutTests

2010-03-12 Dan Winship <danw@gnome.org>

Reviewed by Gustavo Noronha.

Revert previous; the test passes now.

platform/gtk/Skipped:

6:06 AM Changeset in webkit [55893] by eric@webkit.org

8 edits
4 adds in trunk

2010-03-12 Jochen Eisinger <jochen@chromium.org>

Reviewed by Jeremy Orlow.

Test for referrer information being stripped when the header is removed in willSendRequest
https://bugs.webkit.org/show_bug.cgi?id=35920

http/tests/security/no-referrer-expected.txt: Added.
http/tests/security/no-referrer.html: Added.
http/tests/security/resources/no-referrer-frame.php: Added.
http/tests/security/resources/no-referrer.php: Added.
platform/gtk/Skipped:
platform/qt/Skipped:

2010-03-12 Jochen Eisinger <jochen@chromium.org>

Reviewed by Jeremy Orlow.

Introduce setWillSendRequestClearHeader to LayoutTestController to selectively remove headers in willSendRequest. Used in http/tests/security/no-referrer.html
https://bugs.webkit.org/show_bug.cgi?id=35920

DumpRenderTree/LayoutTestController.cpp: (setWillSendRequestClearHeaderCallback): (LayoutTestController::staticFunctions):
DumpRenderTree/LayoutTestController.h: (LayoutTestController::willSendRequestClearHeaders): (LayoutTestController::setWillSendRequestClearHeader):
DumpRenderTree/mac/ResourceLoadDelegate.mm: (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
DumpRenderTree/win/ResourceLoadDelegate.cpp: (ResourceLoadDelegate::willSendRequest):

5:44 AM Changeset in webkit [55892] by Nikolas Zimmermann

5 edits in trunk/LayoutTests

2010-03-12 Nikolas Zimmermann <nzimmermann@rim.com>

Rubber-stamped by Dirk Schulze.

Update two tests, whose pixel hash fail with --tolerance 0. No visible differences.

platform/mac/svg/custom/dominant-baseline-hanging-expected.checksum:
platform/mac/svg/custom/dominant-baseline-hanging-expected.png:
platform/mac/svg/custom/gradient-stop-corner-cases-expected.checksum:
platform/mac/svg/custom/gradient-stop-corner-cases-expected.png:

Mar 11, 2010:

11:24 PM Changeset in webkit [55891] by eric@webkit.org

4 edits in trunk/WebCore

2010-03-11 Simon Hausmann <simon.hausmann@nokia.com>

Reviewed by Laszlo Gombos.

[Qt] Enable network state notifier when compiling against Qt 4.7
https://bugs.webkit.org/show_bug.cgi?id=35983

WebCore.pri:
platform/network/qt/NetworkStateNotifierPrivate.h:
platform/network/qt/NetworkStateNotifierQt.cpp:

11:07 PM Changeset in webkit [55890] by eric@webkit.org

8 edits in trunk/WebCore

2010-03-11 Benjamin Poulain <benjamin.poulain@nokia.com>

Reviewed by Adam Treat.

Do not render the full frame when there is some elements with fixed positioning
https://bugs.webkit.org/show_bug.cgi?id=33150

The frame view take into acount the list of fixed object when scrolling
the view. If the number of object is lower than a certain threshold, the pixel
are blitted, and the invalidated area updated.

page/FrameView.cpp: (WebCore::FrameView::FrameView): (WebCore::FrameView::useSlowRepaints): (WebCore::FrameView::useSlowRepaintsIfNotOverlapped): (WebCore::FrameView::addFixedObject): (WebCore::FrameView::removeFixedObject): (WebCore::FrameView::scrollContentsFastPath):
page/FrameView.h:
platform/ScrollView.cpp: (WebCore::ScrollView::scrollContents): (WebCore::ScrollView::scrollContentsFastPath):
platform/ScrollView.h:
rendering/RenderBlock.h: (WebCore::RenderBlock::positionedObjects):
rendering/RenderBox.cpp: (WebCore::RenderBox::styleWillChange):
rendering/RenderObject.cpp: (WebCore::RenderObject::styleWillChange):

10:46 PM Changeset in webkit [55889] by eric@webkit.org

2 edits in trunk/JavaScriptCore

2010-03-11 Kent Hansen <kent.hansen@nokia.com>

Reviewed by Simon Hausmann.

Mac OS X: Use deployment target to determine whether memory tagging should be enabled
https://bugs.webkit.org/show_bug.cgi?id=34888

Use TARGETING_TIGER rather than BUILDING_ON_TIGER to determine the tags.

wtf/VMTags.h:

10:11 PM Changeset in webkit [55888] by eric@webkit.org

12 edits in trunk

2010-03-11 Aaron Boodman <aa@chromium.org>

Kill WebDocument::applicationID() (part 1).

Modify interface to WebCore::NotificationPresenter::checkPermission()
and remove implementation of WebDocument::applicationID(). Breaking
API changes will be in a subsequent change.
https://bugs.webkit.org/show_bug.cgi?id=35846

notifications/Notification.cpp: (WebCore::Notification::Notification):
notifications/NotificationCenter.cpp: (WebCore::NotificationCenter::checkPermission):
notifications/NotificationPresenter.h:

2010-03-11 Aaron Boodman <aa@chromium.org>

Kill WebDocument::applicationID() (part 1).

Modify interface to WebCore::NotificationPresenter::checkPermission()
and remove implementation of WebDocument::applicationID(). Breaking
API changes will be in a subsequent change.
https://bugs.webkit.org/show_bug.cgi?id=35846

public/WebNotificationPresenter.h:
src/NotificationPresenterImpl.cpp: (WebKit::NotificationPresenterImpl::checkPermission):
src/NotificationPresenterImpl.h:
src/WebDocument.cpp: (WebKit::WebDocument::applicationID):

2010-03-11 Aaron Boodman <aa@chromium.org>

Kill WebDocument::applicationID() (part 1).

Modify interface to WebCore::NotificationPresenter::checkPermission()
and remove implementation of WebDocument::applicationID(). Breaking
API changes will be in a subsequent change.
https://bugs.webkit.org/show_bug.cgi?id=35846

WebCoreSupport/WebDesktopNotificationsDelegate.cpp: (WebDesktopNotificationsDelegate::checkPermission):
WebCoreSupport/WebDesktopNotificationsDelegate.h:

9:41 PM Changeset in webkit [55887] by eric@webkit.org

2 edits in trunk/JavaScriptCore

2010-03-11 Jedrzej Nowacki <jedrzej.nowacki@nokia.com>

Reviewed by Simon Hausmann.

The JSNative state was renamed to JSPrimitive. The new name better
coresponds to the ECMAScript standard.

Enum QScriptValuePrivate::States was renamed to State to obey Qt
coding style rules ("States" name suggests that a state could
mixed together with an other state using bitwise logic operators.

[Qt] QScriptValuePrivate::States has naming issues
https://bugs.webkit.org/show_bug.cgi?id=35968

qt/api/qscriptvalue_p.h: (QScriptValuePrivate::): (QScriptValuePrivate::QScriptValuePrivate): (QScriptValuePrivate::isBool): (QScriptValuePrivate::isNumber): (QScriptValuePrivate::isNull): (QScriptValuePrivate::isString): (QScriptValuePrivate::isUndefined): (QScriptValuePrivate::toString): (QScriptValuePrivate::toNumber): (QScriptValuePrivate::toBool): (QScriptValuePrivate::assignEngine): (QScriptValuePrivate::refinedJSValue):

9:24 PM Changeset in webkit [55886] by eric@webkit.org

3 edits in trunk/LayoutTests

2010-03-11 Shu Chang <Chang.Shu@nokia.com>

Reviewed by David Levin.

[Qt] Rebaseline the test and remove it from Skipped.
https://bugs.webkit.org/show_bug.cgi?id=35969

platform/qt/Skipped:
platform/qt/fast/canvas/canvas-resize-reset-expected.txt:

8:39 PM Changeset in webkit [55885] by barraclough@apple.com

2 edits in trunk/JavaScriptCore

Add export.

Reviewed by NOBODY (Windows build fix).

JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:

8:36 PM Changeset in webkit [55884] by ukai@chromium.org

2 edits in trunk/WebKitTools

2010-03-11 Fumitoshi Ukai <ukai@chromium.org>

Unreviewed.

Fix typo in websocket_server.py

Scripts/webkitpy/layout_tests/port/websocket_server.py:

8:07 PM Changeset in webkit [55883] by barraclough@apple.com

2 edits in trunk/JavaScriptCore

Add export.

Reviewed by NOBODY (Windows build fix).

JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:

7:51 PM Changeset in webkit [55882] by dimich@chromium.org

9 edits in trunk/WebCore

[v8] Remove obsolete code for delayed dereferencing of DOM objects for single-heap, multithread v8 usage.
https://bugs.webkit.org/show_bug.cgi?id=36043

Reviewed by David Levin.

No new tests, no changes in functionality.

bindings/v8/DOMData.cpp:

(WebCore::DOMData::DOMData):

bindings/v8/DOMData.h:

(WebCore::DOMData::handleWeakObject):

bindings/v8/DOMDataStore.cpp:
bindings/v8/DOMDataStore.h:

(WebCore::DOMDataStore::domObjectMap):
(WebCore::DOMDataStore::activeDomObjectMap):
(WebCore::DOMDataStore::domSvgElementInstanceMap):
(WebCore::DOMDataStore::domSvgObjectWithContextMap):

bindings/v8/ScopedDOMDataStore.cpp:

(WebCore::ScopedDOMDataStore::ScopedDOMDataStore):

bindings/v8/StaticDOMDataStore.cpp:

(WebCore::StaticDOMDataStore::StaticDOMDataStore):

bindings/v8/StaticDOMDataStore.h:
bindings/v8/V8DOMMap.cpp:

(WebCore::removeAllDOMObjectsInCurrentThread):

7:25 PM Changeset in webkit [55881] by barraclough@apple.com

4 edits in trunk

Rubber stamped by Oliver Hunt.

Remove nonsense comments used in development & commited in error.

JavaScriptCore:

runtime/UStringImpl.h:

WebCore:

platform/text/StringImpl.h:

7:22 PM Changeset in webkit [55880] by eric@webkit.org

2 edits in trunk/WebKitTools

2010-03-11 Garret Kelly <gdk@chromium.org>

Reviewed by Darin Adler.

Fixing minor typo in the commit queue status page.
https://bugs.webkit.org/show_bug.cgi?id=35979

Scripts/webkitpy/commands/queues.py:

7:20 PM Changeset in webkit [55879] by barraclough@apple.com

2 edits in trunk/JavaScriptCore

Remove export.

Reviewed by NOBODY (Windows build fix).

JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:

7:14 PM Changeset in webkit [55878] by barraclough@apple.com

8 edits in trunk

https://bugs.webkit.org/show_bug.cgi?id=36041
Remove unnecessary differences in common code between WebCore::StringImpl & JSC::UStringImpl

Reviewed by Oliver Hunt.

Much of the code in WebCore::StringImpl and JSC::UStringImpl is now very similar,
but has trivial and unnecessary formatting differences, such as the exact wording
of comments, missing ASSERTs, functions implemented in the .h vs .cpp etc.

JavaScriptCore:

runtime/Identifier.cpp:

(JSC::Identifier::add): UStringImpl::empty() now automatically hashes, uas per WebCore strings.
(JSC::Identifier::addSlowCase): UStringImpl::empty() now automatically hashes, uas per WebCore strings.

runtime/UStringImpl.cpp:

(JSC::UStringImpl::~UStringImpl): Only call bufferOwnership() once, add missing ASSERTs.
(JSC::UStringImpl::createUninitialized): Move from .h, not commonly called, no need to inline.
(JSC::UStringImpl::create): Move from .h, not commonly called, no need to inline.
(JSC::UStringImpl::sharedBuffer): Rewritten to more closely match WebCore implementation, remove need for separate baseSharedBuffer() method.

runtime/UStringImpl.h:

(JSC::UStringImpl::UStringImpl): Automatically hash static strings, ASSERT m_data & m_length are non-null/non-zero in non-static strings.
(JSC::UStringImpl::setHash): Add missing ASSERT.
(JSC::UStringImpl::create): Moved to .cpp / added missing check for empty string creation.
(JSC::UStringImpl::adopt): Vector.size() returns size_t, not unsigned.
(JSC::UStringImpl::cost): Renamed m_bufferSubstring -> m_substringBuffer
(JSC::UStringImpl::hash): Reordered in file.
(JSC::UStringImpl::existingHash): Reordered in file.
(JSC::UStringImpl::computeHash): Reordered in file, renamed parameter.
(JSC::UStringImpl::checkConsistency): rewrote ASSERT.
(JSC::UStringImpl::bufferOwnership): Return type should be BufferOwnership.
(JSC::UStringImpl::): Moved friends to head of class.

WebCore:

platform/text/StringImpl.cpp:

(WebCore::StringImpl::empty): Reordered in file, made empty()->characters() return a non-null value to match JSC.
(WebCore::StringImpl::createUninitialized): Added overflow check.
(WebCore::StringImpl::create): Reordered in file.
(WebCore::StringImpl::sharedBuffer): Reordered in file.

platform/text/StringImpl.h:

(WebCore::StringImpl::): Remove ThreadGlobalData as friend, move SharableUChar & SharedUChar to WebCore namespace.
(WebCore::StringImpl::StringImpl): Made static constructor method (used to create empty string) take arguments, to match JSC & prevent accidental use.
(WebCore::StringImpl::setHash): Added missing ASSERT.
(WebCore::StringImpl::adopt): Make adpot work with Vectors with a non-zero inline capacity.
(WebCore::StringImpl::characters): Mark as const to match JSC.
(WebCore::StringImpl::hash): Use !m_hash instead of m_hash == 0.
(WebCore::StringImpl::computeHash): Remove redundant 'inline'.

7:04 PM Changeset in webkit [55877] by eric@webkit.org

2 edits in trunk/WebKit/chromium

2010-03-11 Stuart Morgan <stuartmorgan@chromium.org>

Reviewed by Darin Fisher.

Fix the screen coordinate conversion of Chromium Mac mouse events for
multiple-moniter setups. Also changes the global coordinate values
to be computed from the event, rather than the instantaneous mouse
location, and reduces code duplication for location conversion.

Dual-sided patch with http://codereview.chromium.org/751002

https://bugs.webkit.org/show_bug.cgi?id=35950

src/mac/WebInputEventFactory.mm: (WebKit::setWebEventLocationFromEventInView): (WebKit::WebInputEventFactory::mouseEvent): (WebKit::WebInputEventFactory::mouseWheelEvent):

6:47 PM Changeset in webkit [55876] by eric@webkit.org

1 edit
2 adds in trunk/LayoutTests

2010-03-11 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Darin Adler.

Applying h1 format to text node after HR tag fails to include first letter of text node.
https://bugs.webkit.org/show_bug.cgi?id=30148

This patch adds a test case to the above bug, which has been fixed by
http://trac.webkit.org/changeset/55705.

editing/style/heading-text-after-hr-expected.txt: Added.
editing/style/heading-text-after-hr.html: Added.

6:37 PM Changeset in webkit [55875] by ukai@chromium.org

2 edits in trunk/WebKitTools

2010-03-11 Fumitoshi Ukai <ukai@chromium.org>

Unreviewed.

Fix for WebSocket layout test runner on chromium/win port.

Scripts/webkitpy/layout_tests/port/websocket_server.py: register_cygwin and set CYGWIN_PATH

6:20 PM Changeset in webkit [55874] by eric@webkit.org

1 edit
2 adds in trunk/WebKit

2010-03-11 Leandro Pereira <leandro@profusion.mobi>

Reviewed by Gustavo Noronha Silva.

Add EFL port files to efl/WebCoreSupport.
http://webkit.org/b/35917

efl/WebCoreSupport/InspectorClientEfl.h: Added.
efl/WebCoreSupport/InspectorClientEfl.cpp: Added.

6:15 PM Changeset in webkit [55873] by jianli@chromium.org

4 edits
3 adds in trunk/LayoutTests

Add more test cases for Blob.slice.
https://bugs.webkit.org/show_bug.cgi?id=36038

Reviewed by Dmitry Titov.

http/tests/local/resources/abe.png: Copied from LayoutTests/editing/resources/abe.png.
http/tests/local/resources/empty.txt: Copied from LayoutTests/http/tests/appcache/resources/empty.txt.
http/tests/local/resources/send-sliced-dragged-file.js:
http/tests/local/send-sliced-dragged-file-expected.txt:
http/tests/resources/post-and-verify.cgi: Added.
http/tests/resources/write-temp-file.php:

6:03 PM Changeset in webkit [55872] by eric@webkit.org

1 edit
2 adds in trunk/WebKit

2010-03-11 Leandro Pereira <leandro@profusion.mobi>

Reviewed by Gustavo Noronha Silva.

Add EFL port files to efl/WebCoreSupport.
http://webkit.org/b/35914

efl/WebCoreSupport/DragClientEfl.h: Added.
efl/WebCoreSupport/DragClientEfl.cpp: Added.

5:53 PM Changeset in webkit [55871] by mrowe@apple.com

10 edits in trunk

<rdar://problem/7745082> Make it possible to build WebKit for older Mac OS X versions from the current Mac OS X version

Reviewed by David Kilzer.

Default to using the appropriate SDK if the target Mac OS X version is not the current Mac OS X version.

JavaScriptCore:

Configurations/Base.xcconfig:

JavaScriptGlue:

Configurations/Base.xcconfig:

WebCore:

Configurations/Base.xcconfig:

WebKit/mac:

Configurations/Base.xcconfig:

WebKitTools:

DumpRenderTree/mac/Configurations/Base.xcconfig:

5:37 PM Changeset in webkit [55870] by eric@webkit.org

4 edits
4 adds in trunk

2010-03-11 Jungshik Shin <jshin@chromium.org>

[Chromium]: Plane 2 characters are rendered "blank"

(not even empty boxes) on Windows even when there are fonts to
cover them.

https://bugs.webkit.org/show_bug.cgi?id=35605

Test:LayoutTests/fast/text/international/plane2.html

platform/graphics/chromium/FontCacheChromiumWin.cpp: (WebCore::LookupAltName): Add two ExtB fonts to the array (namePairs) that are used for Plane 2 character rendering. (WebCore::FontCache::getFontDataForCharacters): Add two more fonts to the fallback font list
platform/graphics/chromium/FontUtilsChromiumWin.cpp: (WebCore::getFallbackFamily): Fix the fallback font lookup to cover Plane 2 (CJK ExtB).

5:20 PM Changeset in webkit [55869] by eric@webkit.org

1 edit
1 add in trunk/WebCore

2010-03-11 Leandro Pereira <leandro@profusion.mobi>

Reviewed by Holger Freyther.

Add EFL port files to platform/efl.
http://webkit.org/b/35889

platform/efl/SystemTimeEfl.cpp: Added.

4:50 PM Changeset in webkit [55868] by victorw@chromium.org

2 edits in trunk/WebKitTools

2010-03-11 Victor Wang <victorw@chromium.org>

Reviewed by Dimitri Glazkov.

rebaseline_chromium_webkit_tests can generate new baselines for
all platforms so it needs to know two ports in order to work correctly:
the port that the script is running on and the port that it generates
new baselines for. Update rebaselining tool to handle both port correctly.

https://bugs.webkit.org/show_bug.cgi?id=36032

Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:

4:44 PM Changeset in webkit [55867] by mrowe@apple.com

26 edits in trunk

<rdar://problem/7745082> Make it possible to build WebKit for older Mac OS X versions from the current Mac OS X version

Reviewed by Tim Hatcher.

Introduce TARGET_MAC_OS_X_VERSION_MAJOR to represent the Mac OS X version that is being targeted. It defaults to the
current Mac OS X version unless otherwise specified.

Key off TARGET_MAC_OS_X_VERSION_MAJOR where we'd previously been keying off MAC_OS_X_VERSION_MAJOR.

Explicitly map from the target Mac OS X version to the preferred compiler since Xcode's default compiler choice
may not be usable when targetting a different Mac OS X version.

Key off TARGET_GCC_VERSION rather than MAC_OS_X_VERSION_MAJOR in locations where we'd previously been keying off
MAC_OS_X_VERSION_MAJOR but the decision is really related to the compiler version being used.

JavaScriptCore:

Configurations/Base.xcconfig:
Configurations/DebugRelease.xcconfig:
Configurations/FeatureDefines.xcconfig:
Configurations/JavaScriptCore.xcconfig:
Configurations/Version.xcconfig:

JavaScriptGlue:

Configurations/Base.xcconfig:
Configurations/DebugRelease.xcconfig:
Configurations/Version.xcconfig:
JavaScriptGlue.xcodeproj/project.pbxproj:

WebCore:

Configurations/Base.xcconfig:
Configurations/DebugRelease.xcconfig:
Configurations/FeatureDefines.xcconfig:
Configurations/Version.xcconfig:
Configurations/WebCore.xcconfig:

WebKit/mac:

Configurations/Base.xcconfig:
Configurations/DebugRelease.xcconfig:
Configurations/FeatureDefines.xcconfig:
Configurations/Version.xcconfig:

WebKitTools:

DumpRenderTree/mac/Configurations/Base.xcconfig:
DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
DumpRenderTree/mac/DumpRenderTree.mm: Wrap the include of mach-o/getsect.h in 'extern "C"' as some versions of the

header in older SDKs do not do this inside the header.

4:40 PM Changeset in webkit [55866] by darin@chromium.org

14 edits in trunk/WebKit/chromium

2010-03-10 Darin Fisher <darin@chromium.org>

Reviewed by Jeremy Orlow.

Use WebPrivatePtr for WebNode
https://bugs.webkit.org/show_bug.cgi?id=36005

public/WebElement.h:
public/WebFormElement.h:
public/WebInputElement.h:
public/WebLabelElement.h:
public/WebNode.h: (WebKit::WebNode::WebNode): (WebKit::WebNode::isNull): (WebKit::WebNode::unwrap): (WebKit::WebNode::constUnwrap):
public/WebPrivatePtr.h: (WebKit::WebPrivatePtr::assign):
src/WebDocument.cpp: (WebKit::WebDocument::WebDocument): (WebKit::WebDocument::operator=): (WebKit::WebDocument::operator PassRefPtr<Document>):
src/WebElement.cpp: (WebKit::WebElement::hasTagName): (WebKit::WebElement::WebElement): (WebKit::WebElement::operator=): (WebKit::WebElement::operator PassRefPtr<Element>):
src/WebFormElement.cpp: (WebKit::WebFormElement::WebFormElement): (WebKit::WebFormElement::operator=): (WebKit::WebFormElement::operator PassRefPtr<HTMLFormElement>):
src/WebInputElement.cpp: (WebKit::WebInputElement::WebInputElement): (WebKit::WebInputElement::operator=): (WebKit::WebInputElement::operator PassRefPtr<HTMLInputElement>):
src/WebLabelElement.cpp: (WebKit::WebLabelElement::correspondingControl): (WebKit::WebLabelElement::operator=): (WebKit::WebLabelElement::operator PassRefPtr<HTMLLabelElement>):
src/WebNode.cpp: (WebKit::WebNode::reset): (WebKit::WebNode::assign): (WebKit::WebNode::equals): (WebKit::WebNode::parentNode): (WebKit::WebNode::createMarkup): (WebKit::WebNode::addEventListener): (WebKit::WebNode::removeEventListener): (WebKit::WebNode::simulateClick): (WebKit::WebNode::WebNode): (WebKit::WebNode::operator=): (WebKit::WebNode::operator PassRefPtr<Node>):

4:27 PM Changeset in webkit [55865] by jianli@chromium.org

2 edits in trunk/LayoutTests

Unreviewed. Added the test that time out on Tiger bot to mac-tiger/Skipped.

platform/mac-tiger/Skipped:

4:09 PM Changeset in webkit [55864] by andersca@apple.com

27 edits in trunk

Remove invalidateContents, it isn't used and it never makes sense to only invalidate the contents.

Reviewed by David Hyatt.

WebCore:

loader/EmptyClients.h:
page/Chrome.cpp:
page/Chrome.h:
page/ChromeClient.h:
platform/HostWindow.h:

WebKit/chromium:

src/ChromeClientImpl.cpp:
src/ChromeClientImpl.h:

WebKit/gtk:

WebCoreSupport/ChromeClientGtk.cpp:
WebCoreSupport/ChromeClientGtk.h:

WebKit/haiku:

WebCoreSupport/ChromeClientHaiku.cpp:
WebCoreSupport/ChromeClientHaiku.h:

WebKit/mac:

WebCoreSupport/WebChromeClient.h:
WebCoreSupport/WebChromeClient.mm:

WebKit/qt:

WebCoreSupport/ChromeClientQt.cpp:
WebCoreSupport/ChromeClientQt.h:

WebKit/win:

WebCoreSupport/WebChromeClient.cpp:
WebCoreSupport/WebChromeClient.h:

WebKit/wx:

WebKitSupport/ChromeClientWx.cpp:
WebKitSupport/ChromeClientWx.h:

4:03 PM Changeset in webkit [55863] by Simon Fraser

3 edits in trunk/LayoutTests

2010-03-11 Simon Fraser <Simon Fraser>

No review.

Need to turn on WebGL explicitly for these tests for Leopard.

compositing/webgl/webgl-background-color.html:
compositing/webgl/webgl-reflection.html:

4:03 PM Changeset in webkit [55862] by Nate Chapin

9 edits
1 delete in trunk/WebCore

2010-03-11 Nate Chapin <Nate Chapin>

Reviewed by Dimitri Glazkov.

[V8] Remove DOMObjectsInclude.h and update headers accordingly.

https://bugs.webkit.org/show_bug.cgi?id=36036

WebCore.gypi:
bindings/v8/DOMData.h:
bindings/v8/DOMDataStore.h:
bindings/v8/DOMObjectsInclude.h: Removed.
bindings/v8/V8DOMMap.cpp:
bindings/v8/V8DOMWindowShell.cpp:
bindings/v8/V8DOMWrapper.cpp:
bindings/v8/V8GCController.cpp:
bindings/v8/V8Proxy.cpp:

4:02 PM Changeset in webkit [55861] by ap@apple.com

7 edits
2 adds in trunk

Reviewed by Geoff Garen.

https://bugs.webkit.org/show_bug.cgi?id=35965
<rdar://problem/7742771> Crash when passing an object returned from plug-in back to the plug-in

Test: plugins/round-trip-npobject.html

Plugins/Hosted/NetscapePluginInstanceProxy.mm: (WebKit::NetscapePluginInstanceProxy::retainLocalObject): Corrected the check - there is now a separate ProxyRuntimeObject class for proxy pbjects. (WebKit::NetscapePluginInstanceProxy::releaseLocalObject): Ditto.

Plugins/Hosted/ProxyInstance.mm: (WebKit::ProxyInstance::invoke): Check if m_instanceProxy is still non-zero. The plug-in could have crashed while we were waiting for response. (WebKit::ProxyInstance::setFieldValue): Ditto.

3:57 PM Changeset in webkit [55860] by Simon Fraser

2 edits in trunk/WebCore

2010-03-11 Simon Fraser <Simon Fraser>

Reviewed by Mark Rowe.

Remove duplicate entries revealed after sorting.

WebCore.xcodeproj/project.pbxproj:

3:35 PM Changeset in webkit [55859] by Simon Fraser

6 edits in trunk

2010-03-11 Simon Fraser <Simon Fraser>

Reviewed by Mark Rowe.

Sort the project files, also fixing some bogus spaces in the WebCore project.

3:14 PM Changeset in webkit [55858] by dimich@chromium.org

6 edits in trunk/LayoutTests

Make appcache layouttests top-frame-*.html more robust for async checking event
https://bugs.webkit.org/show_bug.cgi?id=32047

Reviewed by Alexey Proskuryakov.

Modified the tests to watch for all termination conditions, eliminating the hardcoded
assumed order of the events from separate async event sources.
Also added check for "noupdate" event.

http/tests/appcache/top-frame-2.html: Modified to be consistent with the other 2 tests.
http/tests/appcache/top-frame-3-expected.txt:
http/tests/appcache/top-frame-3.html: Used logic similar to top-frame-2.html to avoid assumption of the events order.
http/tests/appcache/top-frame-4-expected.txt:
http/tests/appcache/top-frame-4.html: Ditto.

3:13 PM Changeset in webkit [55857] by Simon Fraser

2 edits in trunk/WebKitTools

2010-03-11 Simon Fraser <Simon Fraser>

Reviewed by Oliver Hunt.

https://bugs.webkit.org/show_bug.cgi?id=35905
REGRESSION(55699?): media/video-no-autoplay.html times out on Leopard Commit Bot

Make sure we reset the WebGL preference, so that WebGL doesn't get left
on after being enabled via layoutTestController.overridePreference(),
which in turn causes accelerated compositing to be enabled on Leopard
when we don't want it to be.

DumpRenderTree/mac/DumpRenderTree.mm: (resetDefaultsToConsistentValues):

2:42 PM Changeset in webkit [55856] by Nate Chapin

2 edits in trunk/WebCore

2010-03-11 Nate Chapin <Nate Chapin>

Reviewed by Dimitri Glazkov.

Fix style issues and improve comments from
http://trac.webkit.org/changeset/55853.

https://bugs.webkit.org/show_bug.cgi?id=36029

platform/animation/TimingFunction.h: (WebCore::TimingFunction::TimingFunction):

2:24 PM Changeset in webkit [55855] by Chris Fleizach

16 edits in trunk/WebCore

accessibilityIsIgnoredBase() needs to respect when platform says include
https://bugs.webkit.org/show_bug.cgi?id=36025

Reviewed by Beth Dakin.

Changed accessibilityIsIgnoredBase() to return a policy instead of a yes/no
answer. This allows the platform to make a yes decision on an element.

accessibility/AccessibilityList.cpp:

(WebCore::AccessibilityList::accessibilityIsIgnored):

accessibility/AccessibilityListBox.cpp:

(WebCore::AccessibilityListBox::accessibilityIsIgnored):

accessibility/AccessibilityObject.h:

(WebCore::):
(WebCore::AccessibilityObject::accessibilityIgnoreAttachment):
(WebCore::AccessibilityObject::accessibilityPlatformIncludesObject):

accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::accessibilityIsIgnoredBase):
(WebCore::AccessibilityRenderObject::accessibilityIsIgnored):

accessibility/AccessibilityRenderObject.h:
accessibility/AccessibilitySlider.cpp:

(WebCore::AccessibilitySlider::accessibilityIsIgnored):

accessibility/AccessibilityTable.cpp:

(WebCore::AccessibilityTable::accessibilityIsIgnored):

accessibility/AccessibilityTableCell.cpp:

(WebCore::AccessibilityTableCell::accessibilityIsIgnored):

accessibility/AccessibilityTableRow.cpp:

(WebCore::AccessibilityTableRow::accessibilityIsIgnored):

accessibility/chromium/AccessibilityObjectChromium.cpp: