⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Mar 13, 2010:

4:23 PM Changeset in webkit [55972] by Chris Jerdonek
  • 2 edits
    1 copy
    2 adds in trunk/WebKitTools

The webkit-patch script now displays a warning if run using
a version of Python less than 2.5. This will help users
understand why webkit-patch is erroring out if they are
using Python 2.4, for example.

Reviewed by Adam Barth.

​https://bugs.webkit.org/show_bug.cgi?id=31533

  • Scripts/webkit-patch:
    • Moved most of the file contents to webkitpy/patch/patcher.py so the Python version can be checked before interpreting any code that can cause the script to error out.
    • Added a configure_logging() method to enable any version warnings to show up.
    • Added a main() method with calls to configure_logging(), check_version(), and the main webkit patch method.
  • Scripts/webkitpy/patch/init.py: Copied from WebKitTools/QueueStatusServer/filters/init.py.
    • This file is required to make a folder a package.
  • Scripts/webkitpy/patch/patcher.py: Added.
    • Moved code from Scripts/webkit-patch.
3:48 PM Changeset in webkit [55971] by Chris Jerdonek
  • 4 edits in trunk/WebKitTools

Changed test-webkitpy so that messages logged as a side-effect
of unit-testing code do not get displayed to the screen. These
messages clutter up the unit test results if not filtered out.

Reviewed by Adam Barth.

​https://bugs.webkit.org/show_bug.cgi?id=35835

  • Scripts/test-webkitpy:
    • Adjusted the configure_logging() method to filter out any log messages from webkitpy.
    • Also added an INFO message stating that most console logging is getting suppressed.
  • Scripts/webkitpy/init/versioning.py:
    • Added a log parameter to the check_version() method.
  • Scripts/webkitpy/init/versioning_unittest.py:
    • Qualified a call to check_version() with the parameter names.
2:36 PM Changeset in webkit [55970] by Chris Jerdonek
  • 3 edits
    1 copy
    3 adds in trunk/WebKitTools

The test-webkitpy script now warns the user if the script is
being run using a Python version different from the minimum
version the webkitpy package was meant to support.

Reviewed by Adam Barth.

​https://bugs.webkit.org/show_bug.cgi?id=35788

Warning developers if their Python version is too low will help
them understand why test-webkitpy is failing. Secondly, warning
developers if their Python version is higher than the minimum will
help them understand that their changes may not be okay for the
minimum supported version, even if test-webkitpy is passing.

  • Scripts/test-webkitpy:
    • Moved the "from ..._unittest import *" lines to the new file Scripts/webkitpy/unittests.py. This will allow the version-check warning to be displayed even if an error occurs while interpreting (i.e. importing) the unit test code.
    • Added configure_logging() to configur logging for test-webkitpy.
    • Added an init() method to configure logging and check the current Python version.
  • Scripts/webkitpy/init/unittests.py: Added.
    • Added a file to import all unit test modules in the webkitpy.init package.
  • Scripts/webkitpy/init/versioning.py: Added.
    • Added a _MINIMUM_SUPPORTED_PYTHON_VERSION variable and set it equal to 2.5.
    • Added a compare_version() method to compare the current Python version against a target version.
    • Added a check_version() method to check the current Python version against the current minimum supported version, and to log a warning message if the check fails.
  • Scripts/webkitpy/init/versioning_unittest.py: Added.
    • Added unit tests for the functions in versioning.py.
  • Scripts/webkitpy/style/unittests.py:
    • Fixed/updated a code comment.
  • Scripts/webkitpy/unittests.py: Added.
    • Moved the "from ..._unittest import *" lines from test-webkitpy.
2:10 PM Changeset in webkit [55969] by Chris Jerdonek
  • 6 edits
    1 copy
    1 add in trunk/WebKitTools

Moved all code in webkitpy/init.py to another location.

Reviewed by Adam Barth.

​https://bugs.webkit.org/show_bug.cgi?id=35828

Keeping webkitpy/init.py free of non-trivial code allows
calling code to import initialization code from webkitpy
before any errors or log messages occur due to code in
init.py. Such initialization code can include things like
version checking code and logging configuration code. This
also lets us move the autoinstall initialization code to a
location where it only executes if it is needed -- something
we have done in this patch.

  • Scripts/webkitpy/init.py:
    • Moved all executable code to the following location: webkitpy/thirdparty/autoinstalled/init.py
    • Added a code comment to keep this file free of non-trivial code.
  • Scripts/webkitpy/bugzilla.py:
    • Updated mechanize import statement.
  • Scripts/webkitpy/networktransaction.py:
    • Updated mechanize import statement.
  • Scripts/webkitpy/networktransaction_unittest.py:
    • Updated mechanize import statement.
  • Scripts/webkitpy/statusserver.py:
    • Updated mechanize import statement.
  • Scripts/webkitpy/thirdparty/autoinstalled/init.py: Added.
    • Copied the code from webkitpy/init.py and updated it as necessary.
1:28 PM Changeset in webkit [55968] by Chris Jerdonek
  • 16 edits
    1 move
    2 adds in trunk/WebKitTools

Moved webkitpy/mock.py into webkitpy/thirdparty since it is
third-party code.

Reviewed by Adam Barth.

​https://bugs.webkit.org/show_bug.cgi?id=35499

Updated the import statement in all of the below except where noted.

  • Scripts/webkitpy/bugzilla_unittest.py:
  • Scripts/webkitpy/commands/commandtest.py:
  • Scripts/webkitpy/commands/download_unittest.py:
  • Scripts/webkitpy/commands/early_warning_system_unittest.py:
  • Scripts/webkitpy/commands/queries_unittest.py:
  • Scripts/webkitpy/commands/queues_unittest.py:
  • Scripts/webkitpy/commands/queuestest.py:
  • Scripts/webkitpy/commands/upload.py:
  • Scripts/webkitpy/commands/upload_unittest.py:
  • Scripts/webkitpy/commands_references.py: Added.
    • Added a file containing an absolute import of Mock so that the imports in the commands folder can import from this file (similar to style_references.py). This helps limit the number of affected files in future refactorings.
  • Scripts/webkitpy/credentials_unittest.py:
  • Scripts/webkitpy/mock.py: Removed.
    • Moved to Scripts/webkitpy/thirdparty.
  • Scripts/webkitpy/mock_bugzillatool.py:
  • Scripts/webkitpy/patchcollection_unittest.py:
  • Scripts/webkitpy/steps/closebugforlanddiff_unittest.py:
  • Scripts/webkitpy/steps/steps_unittest.py:
  • Scripts/webkitpy/steps/updatechangelogswithreview_unittests.py:
  • Scripts/webkitpy/steps_references.py: Added.
    • Added a file containing an absolute import of Mock so that the imports in the steps folder can import from this file (similar to style_references.py). This helps limit the number of affected files in future refactorings.
  • Scripts/webkitpy/thirdparty/mock.py: Copied from WebKitTools/Scripts/webkitpy/mock.py.
    • Also eliminated trailing white space and carriage returns.
11:28 AM Changeset in webkit [55967] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-03-13 Kim Grönholm <​kim.gronholm@nomovok.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] GraphicsLayer: Opacity change from zero to non-zero doesn't always have effect with AC
​https://bugs.webkit.org/show_bug.cgi?id=36034

  • platform/graphics/qt/GraphicsLayerQt.cpp: (WebCore::OpacityAnimationQt::applyFrame):
10:54 AM Changeset in webkit [55966] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-03-13 Kim Grönholm <​kim.gronholm@nomovok.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] GraphicsLayer: Opacity transitions end with begin value
​https://bugs.webkit.org/show_bug.cgi?id=36019

  • platform/graphics/qt/GraphicsLayerQt.cpp: (WebCore::AnimationQt::updateCurrentTime):
10:35 AM Changeset in webkit [55965] by eric@webkit.org
  • 1 edit
    2 adds in trunk/WebKit

2010-03-13 Leandro Pereira <​leandro@profusion.mobi>

Reviewed by Kenneth Rohde Christiansen.

Add EFL port files to efl/ewk.
​http://webkit.org/b/35925

  • efl/ewk/ewk_history.cpp: Added.
  • efl/ewk/ewk_history.h: Added.
10:17 AM Changeset in webkit [55964] by eric@webkit.org
  • 1 edit
    2 adds in trunk/WebKit

2010-03-13 Leandro Pereira <​leandro@profusion.mobi>

Reviewed by Kenneth Rohde Christiansen.

Add EFL port files to efl/ewk.
​http://webkit.org/b/35928

  • efl/ewk/ewk_main.cpp: Added.
  • efl/ewk/ewk_main.h: Added.
10:12 AM Changeset in webkit [55963] by Csaba Osztrogonác
  • 2 edits in trunk/WebKit/qt

[Qt] Enable accelerated compositing by default
​https://bugs.webkit.org/show_bug.cgi?id=35866

Unreviewed. Roll-out r55955, because it broke 3 tests:

  • animations/fill-mode-transform.html
  • animations/play-state.html
  • animations/simultaneous-start-left.html
  • Api/qwebsettings.cpp:

(QWebSettings::QWebSettings):

7:25 AM QtWebKitJournal edited by Simon Hausmann
(diff)
5:43 AM Changeset in webkit [55962] by krit@webkit.org
  • 3 edits in trunk/WebCore

2010-03-13 Dirk Schulze <​krit@webkit.org>

No review, rolling out r55927.
​http://trac.webkit.org/changeset/55927
​https://bugs.webkit.org/show_bug.cgi?id=35793

Breaks Gtk build bots.

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivate::MediaPlayerPrivate): (WebCore::MediaPlayerPrivate::load): (WebCore::MediaPlayerPrivate::setPreload):
  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:
2:59 AM Changeset in webkit [55961] by robert@webkit.org
  • 2 edits in trunk/WebKitTools

2010-03-12 Robert Hogan <​robert@webkit.org>

Reviewed by Adam Barth.

Amend incorrect typo patch for QtLauncher.

​https://bugs.webkit.org/show_bug.cgi?id=35877

  • QtLauncher/webview.cpp: (WebViewGraphicsBased::setFrameRateMeasurementEnabled):
2:44 AM Changeset in webkit [55960] by eric@webkit.org
  • 1 edit
    19 adds in trunk/WebKitTools

2010-03-13 Victor Wang <​victorw@chromium.org>

Add appengine app to host and serve webkit layout test results.

The app allows you post test result files (json) and serve them up.
Chromium flakiness dashboard will first use this app to host results.json
and expectations.json, but the files hosted by this app are not limited
to chromium results or json files. It can be used to host other files if needed.

​https://bugs.webkit.org/show_bug.cgi?id=35944

  • TestResultServer: Added.
  • TestResultServer/app.yaml: Added.
  • TestResultServer/handlers: Added.
  • TestResultServer/handlers/init.py: Added.
  • TestResultServer/handlers/menu.py: Added.
  • TestResultServer/handlers/testfilehandler.py: Added.
  • TestResultServer/index.yaml: Added.
  • TestResultServer/main.py: Added.
  • TestResultServer/model: Added.
  • TestResultServer/model/init.py: Added.
  • TestResultServer/model/testfile.py: Added.
  • TestResultServer/stylesheets: Added.
  • TestResultServer/stylesheets/form.css: Added.
  • TestResultServer/stylesheets/menu.css: Added.
  • TestResultServer/stylesheets/testfile.css: Added.
  • TestResultServer/templates: Added.
  • TestResultServer/templates/menu.html: Added.
  • TestResultServer/templates/showfilelist.html: Added.
  • TestResultServer/templates/uploadform.html: Added.
2:28 AM Changeset in webkit [55959] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2010-03-13 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by David Levin.

new-run-webkit-tests fails with --debug option.
​https://bugs.webkit.org/show_bug.cgi?id=36067

  • Scripts/webkitpy/layout_tests/port/mac.py:
2:11 AM Changeset in webkit [55958] by eric@webkit.org
  • 1 edit
    2 adds in trunk/WebKit

2010-03-13 Leandro Pereira <​leandro@profusion.mobi>

Reviewed by Kenneth Rohde Christiansen.

Add EFL port files to efl/ewk.
​http://webkit.org/b/35924

  • efl/ewk/ewk_frame.cpp: Added.
  • efl/ewk/ewk_frame.h: Added.
1:54 AM Changeset in webkit [55957] by eric@webkit.org
  • 1 edit
    1 add in trunk/WebKit

2010-03-13 Leandro Pereira <​leandro@profusion.mobi>

Reviewed by Kenneth Rohde Christiansen.

Add EFL port files to efl/ewk.
​http://webkit.org/b/35936

  • efl/ewk/ewk_view_single.c: Added.
1:38 AM Changeset in webkit [55956] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2010-03-13 Jesus Sanchez-Palencia <​jesus.palencia@openbossa.org>

Reviewed by Kenneth Rohde Christiansen.

Add "Show FPS" menu option to QtLauncher.

[Qt] QtLauncher need a menu option to show/hide FPS
​https://bugs.webkit.org/show_bug.cgi?id=35794

  • QtLauncher/main.cpp: (LauncherWindow::showFPS): (LauncherWindow::createChrome):
1:21 AM Changeset in webkit [55955] by eric@webkit.org
  • 2 edits in trunk/WebKit/qt

2010-03-13 Simon Hausmann <​simon.hausmann@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Enable accelerated compositing by default
​https://bugs.webkit.org/show_bug.cgi?id=35866

  • Api/qwebsettings.cpp: (QWebSettings::QWebSettings):
1:04 AM Changeset in webkit [55954] by eric@webkit.org
  • 1 edit
    2 adds in trunk/WebKit

2010-03-13 Leandro Pereira <​leandro@profusion.mobi>

Reviewed by Kenneth Rohde Christiansen.

Add EFL port files to efl/ewk.
​http://webkit.org/b/35929

  • efl/ewk/ewk_util.cpp: Added.
  • efl/ewk/ewk_util.h: Added.
12:47 AM Changeset in webkit [55953] by eric@webkit.org
  • 1 edit
    5 adds in trunk/WebKit

2010-03-13 Leandro Pereira <​leandro@profusion.mobi>

Reviewed by Kenneth Rohde Christiansen.

Add EFL port files to efl/ewk.
​http://webkit.org/b/35934

  • efl/ewk/EWebKit.h: Added.
  • efl/ewk/ewk_eapi.h: Added.
  • efl/ewk/ewk_logging.h: Added.
  • efl/ewk/ewk_private.h: Added.
12:31 AM Changeset in webkit [55952] by eric@webkit.org
  • 3 edits in trunk/WebKit/chromium

2010-03-13 Eric Roman <​eroman@chromium.org>

Reviewed by Adam Barth.

Add a firstPartyForCookies() property to WebDocument.
​https://bugs.webkit.org/show_bug.cgi?id=35592

  • public/WebDocument.h:
  • src/WebDocument.cpp: (WebKit::WebDocument::firstPartyForCookies):
12:14 AM Changeset in webkit [55951] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2010-03-13 Jesus Sanchez-Palencia <​jesus.palencia@openbossa.org>

Reviewed by Kenneth Rohde Christiansen.

Add a "Toggle FullScreen" option to QtLauncher Menu.

[Qt] QtLauncher needs an option to toggle FullScreen Mode
​https://bugs.webkit.org/show_bug.cgi?id=35755

  • QtLauncher/main.cpp: (LauncherWindow::init): (LauncherWindow::eventFilter): (LauncherWindow::initializeView): (LauncherWindow::toggleFullScreenMode): (LauncherWindow::createChrome):

Mar 12, 2010:

11:57 PM Changeset in webkit [55950] by eric@webkit.org
  • 3 edits
    2 adds in trunk/LayoutTests

2010-03-12 Shu Chang <​chang.shu@nokia.com>

Reviewed by David Levin.

[Qt] Rebaseline the test and remove it from Skipped.
​https://bugs.webkit.org/show_bug.cgi?id=36057

  • platform/qt/Skipped:
  • platform/qt/fast/canvas/canvas-size-change-after-layout-expected.checksum: Added.
  • platform/qt/fast/canvas/canvas-size-change-after-layout-expected.png: Added.
  • platform/qt/fast/canvas/canvas-size-change-after-layout-expected.txt:
11:07 PM Changeset in webkit [55949] by krit@webkit.org
  • 19 edits in trunk

2010-03-12 Dirk Schulze <​krit@webkit.org>

Reviewed by Nikolas Zimmermann.

SVG Glyphs - transform path not context
​https://bugs.webkit.org/show_bug.cgi?id=36070

SVGFont should transform the path of a glyph, not the context. Modifying
the context causes wrong gradient transformations. This bug doesn't
influence CG because we generally fill or stroke texts with a mask image.
All other platforms provide a direct way to make the drawings.

  • svg/SVGFont.cpp: (WebCore::Font::drawTextUsingSVGFont):

2010-03-12 Dirk Schulze <​krit@webkit.org>

Reviewed by Nikolas Zimmermann.

SVG Glyphs - transform path not context
​https://bugs.webkit.org/show_bug.cgi?id=36070

Some tests don't look pixel perfect after the SVGFont changes (difference of 0.1%).
They just need an update.
Tests for the changes on other platforms than CG are

  • svg/batik/text/textEffect.svg
  • svg/batik/text/textEffect3.svg
  • svg/W3C-SVG-1.1/pservers-grad-08-b.svg
  • platform/mac-leopard/svg/custom/svg-fonts-in-html-expected.checksum:
  • platform/mac-leopard/svg/custom/svg-fonts-in-html-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-03-t-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-03-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-36-t-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-36-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-40-t-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-40-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/pservers-grad-08-b-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/pservers-grad-08-b-expected.png:
  • platform/mac/svg/batik/text/textEffect-expected.checksum:
  • platform/mac/svg/batik/text/textEffect-expected.png:
  • platform/mac/svg/batik/text/textEffect3-expected.checksum:
  • platform/mac/svg/batik/text/textEffect3-expected.png:
  • platform/mac/svg/text/selection-doubleclick-expected.png:
  • platform/mac/svg/text/selection-tripleclick-expected.png:
6:10 PM Changeset in webkit [55948] by barraclough@apple.com
  • 2 edits in trunk/JavaScriptCore

Reviewed by NOBODY (build fix).

5:56 PM Changeset in webkit [55947] by enrica@apple.com
  • 2 edits in trunk/WebKit/win

Fixed broken build on Windows.
Added contditional compilation for accelerated compositing.

  • WebView.cpp:

(WebView::deleteBackingStore):
(WebView::addToDirtyRegion):
(WebView::updateBackingStore):

5:39 PM Changeset in webkit [55946] by Beth Dakin
  • 14 edits in trunk

Fix for ​https://bugs.webkit.org/show_bug.cgi?id=34942 Fullscreen
API naming is inconsistent
-and corresponding-
<rdar://problem/7729165>

Reviewed by Simon Fraser.

WebCore:

This patch changes all occurrences of "fullScreen" to the more
popular "fullscreen." webkitEnterFullScreen and
webkitExitFullScreen have been maintained for now for backwards
compatibility.

  • html/HTMLVideoElement.cpp:

(WebCore::HTMLVideoElement::webkitEnterFullscreen):
(WebCore::HTMLVideoElement::webkitExitFullscreen):

  • html/HTMLVideoElement.h:

(WebCore::HTMLVideoElement::webkitEnterFullScreen):
(WebCore::HTMLVideoElement::webkitExitFullScreen):

  • html/HTMLVideoElement.idl:
  • platform/graphics/mac/MediaPlayerProxy.h:

WebKit/mac:

This patch changes all occurrences of "fullScreen" to the more
popular "fullscreen."

  • Plugins/Hosted/NetscapePluginHostProxy.h:

(WebKit::NetscapePluginHostProxy::isFullscreenWindowShowing):

  • Plugins/Hosted/NetscapePluginHostProxy.mm:

(WebKit::NetscapePluginHostProxy::NetscapePluginHostProxy):
(WebKit::NetscapePluginHostProxy::didEnterFullscreen):
(WebKit::NetscapePluginHostProxy::didExitFullscreen):
(WebKit::NetscapePluginHostProxy::setFullscreenWindowIsShowing):
(WKPCSetFullscreenWindowIsShowing):

  • Plugins/Hosted/WebKitPluginClient.defs:
  • Plugins/WebNetscapePluginView.mm:

(-[WebNetscapePluginView _workaroundSilverlightFullscreenBug:]):
(-[WebNetscapePluginView _createPlugin]):
(-[WebNetscapePluginView _destroyPlugin]):

  • WebView/WebVideoFullscreenHUDWindowController.mm:

(-[WebVideoFullscreenHUDWindowController windowDidLoad]):

WebKit/win:

This patch changes all occurrences of "fullScreen" to the more
popular "fullscreen."

  • FullscreenVideoController.cpp:

(FullscreenVideoController::onMouseDown):
(FullscreenVideoController::onMouseMove):
(FullscreenVideoController::onMouseUp):

  • FullscreenVideoController.h:

(FullscreenVideoController::fullscreenToHUDCoordinates):

5:02 PM Changeset in webkit [55945] by jamesr@google.com
  • 2 edits in trunk/WebCore

2010-03-12 James Robinson <​jamesr@chromium.org>

Reviewed by Adam Barth.

Add virtual destructor to DOMWrapperWorld
​https://bugs.webkit.org/show_bug.cgi?id=36077

DOMWrapperWorld is RefCounted<DOMWrapperWorld>. IsolatedWorld
inherits from DOMWrapperWorld and has member variables
with destructors, so DOMWrapperWorld needs to have a declared virtual
d'tor to ensure that its derived class's destructors are called.

No new tests, no change in behavior

  • bindings/v8/DOMWrapperWorld.h: (WebCore::DOMWrapperWorld::~DOMWrapperWorld):
4:46 PM Changeset in webkit [55944] by barraclough@apple.com
  • 2 edits in trunk/JavaScriptCore

Reviewed by NOBODY (build fix).

3:49 PM Changeset in webkit [55943] by barraclough@apple.com
  • 10 edits in trunk

Bug 36075 - Clean up screwyness re static string impls & Identifiers.

Reviewed by Oliver Hunt.

JavaScriptCore:

  • API/JSClassRef.cpp:

(OpaqueJSClass::~OpaqueJSClass): Classname may be null/empty, and these are an identifer. This is okay, since the null/empty strings are shared across all threads.

(JSC::Identifier::add): No need to explicitly hash null reps, this is done in the ststic UStringImpl constructor.
(JSC::Identifier::addSlowCase): UStringImpl::empty() handled & checkCurrentIdentifierTable now called in the header.
(JSC::Identifier::checkCurrentIdentifierTable): Replaces checkSameIdentifierTable (this no longer checked the rep since the identifierTable pointer was removed from UString::Rep long ago).

  • runtime/Identifier.h:

(JSC::Identifier::add): Replace call to checkSameIdentifierTable with call to checkCurrentIdentifierTable at head of function.

  • runtime/UStringImpl.cpp:

(JSC::UStringImpl::~UStringImpl): Remove call to checkConsistency - this function no longer checks anything interesting.

  • runtime/UStringImpl.h:

(JSC::UStringOrRopeImpl::UStringOrRopeImpl): Set s_refCountFlagIsIdentifier in static constructor.
(JSC::UStringImpl::UStringImpl): remove calls to checkConsistency (see above), add new ASSERT to substring constructor.
(JSC::UStringImpl::setHash): ASSERT not static (static strings set the hash in their constructor, should not reach this code path).
(JSC::UStringImpl::create): Add missing ASSERT.
(JSC::UStringImpl::setIsIdentifier): ASSERT !isStatic() (static strings hash set in constructor).

WebCore:

  • platform/text/StringImpl.cpp:

(WebCore::StringImpl::~StringImpl): Add ASSERT
(WebCore::StringImpl::sharedBuffer): Add ASSERT

  • platform/text/StringImpl.h:

(WebCore::StringImpl::setHash): Add ASSERT
(WebCore::StringImpl::isStatic): added.

3:17 PM Changeset in webkit [55942] by Beth Dakin
  • 2 edits in trunk/WebKit/win

Fix for ​https://bugs.webkit.org/show_bug.cgi?id=33739 Fullscreen
video HUD stays on top when switching to another window (e.g. via
Alt-Tab)
-and corresponding-
<rdar://problem/7547574>

Reviewed by Adam Roben.

The HUD was always on top because it had the WS_EX_TOPMOST style.
So I removed the style and made m_videoWindow the owner of
m_hudWindow. This keeps m_hudWindow on top only when m_videoWindow
is the focused window.

  • FullscreenVideoController.cpp:

(FullscreenVideoController::exitFullscreen): ASSERT that movie()->exitFullscreen() also destroyed the hud.
(FullscreenVideoController::createHUDWindow):

3:11 PM Changeset in webkit [55941] by enrica@apple.com
  • 6 edits
    10 adds
    1 delete in trunk

Content of 3D tests appears at the bottom right corner sometimes.
<rdar://problem/7556244>
<​https://bugs.webkit.org/show_bug.cgi?id=36027>

Reviewed by Simon Fraser.

WebCore:

There were two problems to solve here:

  • the incorrect anchoring of the rootChildLayer that was causing the composited content to be positioned incorrectly
  • the failure to paint the non composited content into the backing store when animating composited content.


The first problem has been solved by leaving the original anchor point for the
rootChildLayer and splitting the tasks of clipping and scrolling using two separate layers.
The second problem has been solved leveraging the knowledge that WebView has of the dirty region
of the backing store to pass this information to the layer renderer. This allows the renderer to force
a paint into the backing store before moving to the compositing.

Tests: compositing/geometry/horizontal-scroll-composited.html

compositing/geometry/vertical-scroll-composited.html

  • manual-tests/win/horizontal-scroll-composited.html: Removed. This is now a layout test.
  • manual-tests/win/milliondollar.html: Added.
  • platform/graphics/win/WKCACFLayerRenderer.cpp:

(WebCore::WKCACFLayerRenderer::WKCACFLayerRenderer): Added initialization of dirty flag.
(WebCore::WKCACFLayerRenderer::setScrollFrame):
(WebCore::WKCACFLayerRenderer::updateScrollFrame): Updated to resize and position the clip and scroll layers.
(WebCore::WKCACFLayerRenderer::setRootChildLayer):
(WebCore::WKCACFLayerRenderer::createRenderer): Added new layer hierarchy.
(WebCore::WKCACFLayerRenderer::destroyRenderer): Remove clip layer on destroy.
(WebCore::WKCACFLayerRenderer::resize):
(WebCore::WKCACFLayerRenderer::paint): Forcing paint massage to trigger paint into the backing store.

  • platform/graphics/win/WKCACFLayerRenderer.h:

(WebCore::WKCACFLayerRenderer::setBackingStoreDirty): Added.

WebKit/win:

See detailed comments in WebCore/ChangeLog.

  • WebView.cpp:

(WebView::deleteBackingStore): Reset the dirty flag when deleting the backing store.
(WebView::addToDirtyRegion): Set the dirty flag when adding dirty rectangles to the
backing store dirty region.
(WebView::updateBackingStore): Reset the dirty flag after painting into the backing store.
(WebView::setAcceleratedCompositing): Removed unnecessary call to updateRootLayerContents.
(WebView::updateRootLayerContents): Changed the way we pass parameters to setScrollFrame.
We are passing width and height of the view content together with the offset for the scrolling.
It was confusing to pass it all as a rectangle, when it is not a rectangle.

LayoutTests:

  • compositing/geometry/horizontal-scroll-composited.html: Added.
  • compositing/geometry/vertical-scroll-composited.html: Added.
  • compositing/resources/apple.jpg: Added.
  • platform/mac/compositing/geometry/horizontal-scroll-composited-expected.checksum: Added.
  • platform/mac/compositing/geometry/horizontal-scroll-composited-expected.png: Added.
  • platform/mac/compositing/geometry/horizontal-scroll-composited-expected.txt: Added.
  • platform/mac/compositing/geometry/vertical-scroll-composited-expected.checksum: Added.
  • platform/mac/compositing/geometry/vertical-scroll-composited-expected.png: Added.
  • platform/mac/compositing/geometry/vertical-scroll-composited-expected.txt: Added.
2:58 PM Changeset in webkit [55940] by dpranke@chromium.org
  • 2 edits in trunk/WebKitTools

2010-03-12 Dirk Pranke <​dpranke@chromium.org>

Reviewed by Dimitri Glazkov.

Fix typo in websocket_server (path_from_base instead of
path_from_chromium_base).

​https://bugs.webkit.org/show_bug.cgi?id=36074

  • Scripts/webkitpy/layout_tests/port/websocket_server.py:
2:49 PM Changeset in webkit [55939] by robert@webkit.org
  • 2 edits in trunk/WebCore

2010-03-12 Robert Hogan <​robert@webkit.org>

Not reviewed, build fix.

Revert ​http://trac.webkit.org/projects/webkit/changeset/55374 which broke
the !ENABLE(DATABASE) build on all platforms when attempting to fix the
--minimal build on Qt.

Support for SQLite now seems to be non-negotiable for the Qt build but making
it mandatory requires review, so re-break --minimal Qt build for now.

Qt build issue now tracked at ​https://bugs.webkit.org/show_bug.cgi?id=36073

  • page/GeolocationPositionCache.cpp:
2:43 PM Changeset in webkit [55938] by dpranke@chromium.org
  • 5 edits in trunk/WebKitTools

2010-03-12 Dirk Pranke <​dpranke@chromium.org>

Reviewed by Adam Barth.

new-run-webkit-tests --new-baseline doesn't work at all.

It attempts to call a method that isn't defined. To fix it, I
removed the unnecessary and unnecessarily confusing 'platform'
argument to the test_type constructor and use the Port object that
is passed in instead, since we are only ever generating a baseline
from the port that is currently executing.

​https://bugs.webkit.org/show_bug.cgi?id=36046

  • Scripts/webkitpy/layout_tests/port/mac.py:
  • Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
  • Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
2:42 PM Changeset in webkit [55937] by dpranke@chromium.org
  • 2 edits in trunk/WebKitTools

2010-03-12 Dirk Pranke <​dpranke@chromium.org>

Reviewed by Adam Barth.

Fix new-run-webkit-tests --run-singly

This script option is currently broken - the script attempts to
dereference methods and variables that don't exist, which causes
the Chromium Linux valgrind bot to be quite unhappy. This has been
broken since r54449 when I renamed Port.start_test_driver to
Port.start_driver.

​https://bugs.webkit.org/show_bug.cgi?id=36042

  • Scripts/webkitpy/layout_tests/layout_package/test_shell_thread.py:
2:31 PM Changeset in webkit [55936] by krit@webkit.org
  • 2 edits in trunk/LayoutTests

2010-03-12 Dirk Schulze <​krit@webkit.org>

Unreviewed LayoutTest update.

Result was not updated with r55930.

  • platform/mac/svg/custom/dominant-baseline-hanging-expected.txt:
1:23 PM Changeset in webkit [55935] by mitz@apple.com
  • 2 edits in trunk/WebCore

<rdar://problem/7709115> REGRESSION: toolbar is missing at ​http://www.glom.org/
​https://bugs.webkit.org/show_bug.cgi?id=35507

Reviewed by Alexey Proskuryakov.

  • css/CSSImportRule.cpp:

(WebCore::CSSImportRule::setCSSStyleSheet): Extend the change made in
<​http://trac.webkit.org/changeset/48818> to detect the two variants of
KHTMLFixes.css in @import rules as well as in <link> elements.

1:16 PM Changeset in webkit [55934] by barraclough@apple.com
  • 2 edits in trunk/WebCore

Bug 36052 - [Qt] REGRESSION(55878) 63 test cases crash

Reviewed by Geoff Garen.

r55878 changed UStringImpl::empty()->characters() to be non-null,
so TextBreakIteratorQt.cpp now should check the length of strings
(previously was assuming all strings with a non-null data pointer
had a length of at least 1).

  • platform/text/qt/TextBreakIteratorQt.cpp:

(WebCore::wordBreakIterator):
(WebCore::characterBreakIterator):
(WebCore::lineBreakIterator):
(WebCore::sentenceBreakIterator):

1:15 PM Changeset in webkit [55933] by abarth@webkit.org
  • 2 edits in trunk/WebKit/chromium

2010-03-12 Garret Kelly <​gdk@chromium.org>

Unreiviewed.

Fix Chromium Mac build. Last patch did not apply properly.
(Garret assures me this patch will actually work.)

  • src/WebInputEventConversion.cpp: (WebKit::toPlatformTouchEventType): (WebKit::toPlatformTouchPointState):
12:48 PM Changeset in webkit [55932] by abarth@webkit.org
  • 2 edits in trunk/WebKit/chromium

2010-03-12 Garret Kelly <​gdk@chromium.org>

Unreviewed.

Fix Chromium Mac build. This time, with actual fixing goodness.

  • src/WebInputEventConversion.cpp: (WebKit::toPlatformTouchEventType): (WebKit::toPlatformTouchPointState):
12:47 PM Changeset in webkit [55931] by beidson@apple.com
  • 4 edits in trunk/WebKit/mac

Expose WebPDFView's underlying PDFDocument.

Patch by Andy Estes <​aestes@apple.com> on 2010-03-12
Reviewed by Brady Eidson.

​https://bugs.webkit.org/show_bug.cgi?id=36045

  • WebView/WebDocumentPrivate.h: Create a new protocol called

WebDocumentPDF.

  • WebView/WebPDFView.h: Have WebPDFView implement said protocol.
  • WebView/WebPDFView.mm:

(-[WebPDFView PDFDocument]): Expose WebPDFView's underlying
PDFDocument by implementing -(PDFDocument*)PDFDocument from
WebDocumentPDF.

12:43 PM Changeset in webkit [55930] by krit@webkit.org
  • 5 edits
    4 adds in trunk

2010-03-12 Dirk Schulze <​krit@webkit.org>

Reviewed by Nikolas Zimmermann.

SVG fallback color doesn't work for bogus gradients.
​https://bugs.webkit.org/show_bug.cgi?id=35479

Use a given fallback color on ignored gradients if present. Gradients
must be ignored, if one dimension of the objects boundingBox is zero.

Test: svg/custom/gradient-with-1d-boundingbox.svg

  • svg/graphics/SVGPaintServer.cpp: (WebCore::SVGPaintServer::strokePaintServer):
  • svg/graphics/SVGPaintServerGradient.cpp: (WebCore::SVGPaintServerGradient::setup):

2010-03-12 Dirk Schulze <​krit@webkit.org>

Reviewed by Nikolas Zimmermann.

SVG fallback color doesn't work for bogus gradients.
​https://bugs.webkit.org/show_bug.cgi?id=35479

We now use a fallback color on ignored gradients for one dimensional objects,
either a given fallback color or black as default.
This causes a change of one LayoutTest, because it was done manually in the
gradient PaintServer, without respecting a given fallback color.

  • platform/mac/svg/W3C-SVG-1.1/pservers-grad-17-b-expected.txt:
  • platform/mac/svg/custom/gradient-with-1d-boundingbox-expected.checksum: Added.
  • platform/mac/svg/custom/gradient-with-1d-boundingbox-expected.png: Added.
  • platform/mac/svg/custom/gradient-with-1d-boundingbox-expected.txt: Added.
  • svg/custom/gradient-with-1d-boundingbox.svg: Added.
12:36 PM Changeset in webkit [55929] by abarth@webkit.org
  • 2 edits in trunk/WebKit/chromium

2010-03-12 Garret Kelly <​gdk@chromium.org>

Unreviewed.

Fix Chromium Mac build.

  • src/WebInputEventConversion.cpp: (WebKit::toPlatformTouchEventType): (WebKit::toPlatformTouchPointState):
12:29 PM Changeset in webkit [55928] by hyatt@apple.com
  • 16 edits
    1 delete in trunk/WebCore

​https://bugs.webkit.org/show_bug.cgi?id=36069

Reviewed by Dan Bernstein.

Eliminate InlineRunBox.

  • WebCore.xcodeproj/project.pbxproj:
  • rendering/InlineFlowBox.cpp:

(WebCore::InlineFlowBox::adjustPosition):
(WebCore::InlineFlowBox::paintFillLayer):
(WebCore::InlineFlowBox::paintBoxDecorations):
(WebCore::InlineFlowBox::paintMask):

  • rendering/InlineFlowBox.h:

(WebCore::InlineFlowBox::InlineFlowBox):
(WebCore::InlineFlowBox::prevLineBox):
(WebCore::InlineFlowBox::nextLineBox):
(WebCore::InlineFlowBox::setNextLineBox):
(WebCore::InlineFlowBox::setPreviousLineBox):

  • rendering/InlineRunBox.h: Removed.
  • rendering/InlineTextBox.h:

(WebCore::InlineTextBox::InlineTextBox):
(WebCore::InlineTextBox::prevTextBox):
(WebCore::InlineTextBox::nextTextBox):
(WebCore::InlineTextBox::setNextTextBox):
(WebCore::InlineTextBox::setPreviousTextBox):

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::destroy):
(WebCore::RenderBlock::rightmostPosition):
(WebCore::RenderBlock::leftmostPosition):

  • rendering/RenderInline.cpp:

(WebCore::RenderInline::destroy):
(WebCore::RenderInline::absoluteRects):
(WebCore::RenderInline::absoluteQuads):
(WebCore::RenderInline::linesBoundingBox):
(WebCore::RenderInline::linesVisibleOverflowBoundingBox):
(WebCore::RenderInline::addFocusRingRects):
(WebCore::RenderInline::paintOutline):

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::localBoundingBox):

  • rendering/RenderLineBoxList.cpp:

(WebCore::RenderLineBoxList::deleteLineBoxTree):
(WebCore::RenderLineBoxList::extractLineBox):
(WebCore::RenderLineBoxList::attachLineBox):
(WebCore::RenderLineBoxList::removeLineBox):
(WebCore::RenderLineBoxList::deleteLineBoxes):
(WebCore::RenderLineBoxList::dirtyLineBoxes):
(WebCore::RenderLineBoxList::paint):
(WebCore::RenderLineBoxList::hitTest):
(WebCore::RenderLineBoxList::dirtyLinesFromChangedChild):
(WebCore::RenderLineBoxList::checkConsistency):

  • rendering/RenderSVGInline.cpp:

(WebCore::RenderSVGInline::absoluteRects):
(WebCore::RenderSVGInline::absoluteQuads):

  • rendering/RenderSVGText.cpp:

(WebCore::RenderSVGText::absoluteRects):
(WebCore::RenderSVGText::absoluteQuads):
(WebCore::RenderSVGText::objectBoundingBox):

  • rendering/RenderText.cpp:

(WebCore::RenderText::extractTextBox):
(WebCore::RenderText::attachTextBox):
(WebCore::RenderText::removeTextBox):
(WebCore::RenderText::createInlineTextBox):
(WebCore::RenderText::positionLineBox):

  • rendering/RootInlineBox.h:

(WebCore::RootInlineBox::nextRootBox):
(WebCore::RootInlineBox::prevRootBox):

12:11 PM Changeset in webkit [55927] by kov@webkit.org
  • 3 edits in trunk/WebCore

2010-03-12 Gustavo Noronha Silva <​gustavo.noronha@collabora.co.uk>

Reviewed by Eric Carlson.

media/video-preload.html fails
​https://bugs.webkit.org/show_bug.cgi?id=35793

Only effectively load, and start buffering when playing, or when
the preload attribute is set.

Test: media/video-preload.html

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivate::MediaPlayerPrivate): (WebCore::MediaPlayerPrivate::load): (WebCore::MediaPlayerPrivate::commitLoad): (WebCore::MediaPlayerPrivate::prepareToPlay): (WebCore::MediaPlayerPrivate::setPreload):
  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:
12:06 PM Changeset in webkit [55926] by dimich@chromium.org
  • 30 edits
    7 deletes in trunk

Not reviewed, build fix.

Reverts 55920 and 55921. Landing for Jian Li.

WebCore:

  • Android.derived.jscbindings.mk:
  • Android.derived.v8bindings.mk:
  • DerivedSources.cpp:
  • DerivedSources.make:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pri:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSDOMFormDataCustom.cpp: Removed.
  • bindings/js/JSXMLHttpRequestCustom.cpp:

(WebCore::JSXMLHttpRequest::send):

  • bindings/scripts/CodeGeneratorJS.pm:
  • bindings/v8/V8Index.h:
  • bindings/v8/custom/V8DOMFormDataCustom.cpp: Removed.
  • bindings/v8/custom/V8XMLHttpRequestCustom.cpp:

(WebCore::V8XMLHttpRequest::sendCallback):

  • html/DOMFormData.idl: Removed.
  • page/DOMWindow.idl:

LayoutTests:

  • fast/dom/Window/window-properties-expected.txt:
  • fast/dom/Window/window-property-descriptors-expected.txt:
  • fast/dom/constructed-objects-prototypes-expected.txt:
  • fast/dom/prototype-inheritance-2-expected.txt:
  • fast/dom/prototype-inheritance-expected.txt:
  • fast/js/global-constructors-expected.txt:
  • http/tests/local/resources/send-form-data.js: Removed.
  • http/tests/local/send-form-data-expected.txt: Removed.
  • http/tests/local/send-form-data.html: Removed.
  • http/tests/xmlhttprequest/resources/multipart-post-echo.php: Removed.
  • platform/gtk/Skipped:
  • platform/gtk/fast/dom/Window/window-properties-expected.txt:
  • platform/qt/Skipped:
  • platform/qt/fast/dom/Window/window-properties-expected.txt:
  • platform/qt/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/qt/fast/dom/prototype-inheritance-expected.txt:
  • platform/qt/fast/js/global-constructors-expected.txt:
  • platform/win/Skipped:
12:03 PM Changeset in webkit [55925] by kov@webkit.org
  • 2 edits in trunk/WebKitTools

2010-03-12 Gustavo Noronha Silva <​gustavo.noronha@collabora.co.uk>

Fix critical being printed to stderr on every test. This is
because the jar is only being created when soup hits the HTTP
path. We should reconsider the time of its creation.

  • DumpRenderTree/gtk/DumpRenderTree.cpp: (resetDefaultsToConsistentValues):
11:57 AM Changeset in webkit [55924] by tonikitoo@webkit.org
  • 2 edits in trunk/LayoutTests

Make the timeout in 'snav-unit-overflow-and-scroll-in-direction.html' 10x shorter (from 500ms to 50ms)

Rubber-stamped by Kenneth Christiansen.
Patch by Antonio Gomes <​tonikitoo@webkit.org>

  • fast/events/spatial-navigation/snav-unit-overflow-and-scroll-in-direction.html:
11:45 AM Changeset in webkit [55923] by jpetsovits@rim.com
  • 3 edits in trunk/WebCore

2010-03-12 Jakob Petsovits <​jpetsovits@rim.com>

Reviewed by Dirk Schulze.

[OpenVG] Add support for drawing text to PainterOpenVG
​https://bugs.webkit.org/show_bug.cgi?id=35581

Doesn't come with any actual font classes, as OpenVG
by itself doesn't provide any access to platform fonts
but just the means to draw glyphs that have been loaded
manually before.

  • platform/graphics/openvg/PainterOpenVG.cpp: (WebCore::PlatformPainterState::PlatformPainterState): (WebCore::PlatformPainterState::copyPaintState): (WebCore::PainterOpenVG::textDrawingMode): (WebCore::PainterOpenVG::setTextDrawingMode): (WebCore::PainterOpenVG::drawText):
  • platform/graphics/openvg/PainterOpenVG.h:
11:25 AM Changeset in webkit [55922] by jpetsovits@rim.com
  • 6 edits in trunk/WebCore

2010-03-12 Jakob Petsovits <​jpetsovits@rim.com>

Reviewed by Dirk Schulze.

[OpenVG] Use masks to implement non-rectilinear clipping
​https://bugs.webkit.org/show_bug.cgi?id=35544

Requires some additional context switching logic to
make sure the right context is current when dealing
with the mask, because we don't store it by ourselves.

Initial version of this code was written by
Eli Fidler <​efidler@rim.com>, I did a couple of
bug fixes and efficiency improvements since then.

  • platform/graphics/openvg/GraphicsContextOpenVG.cpp: (WebCore::GraphicsContext::clipPath): (WebCore::GraphicsContext::clip): (WebCore::GraphicsContext::clipOut): (WebCore::GraphicsContext::clipOutEllipseInRect): (WebCore::GraphicsContext::addInnerRoundedRectClip):
  • platform/graphics/openvg/PainterOpenVG.cpp: (WebCore::PlatformPainterState::PlatformPainterState): (WebCore::PlatformPainterState::~PlatformPainterState): (WebCore::PlatformPainterState::maskingEnabled): (WebCore::PlatformPainterState::applyState): (WebCore::PlatformPainterState::saveMaskIfNecessary): (WebCore::PainterOpenVG::intersectClipRect): (WebCore::PainterOpenVG::clipPath): (WebCore::PainterOpenVG::save):
  • platform/graphics/openvg/PainterOpenVG.h: (WebCore::PainterOpenVG::):
  • platform/graphics/openvg/SurfaceOpenVG.cpp: (WebCore::SurfaceOpenVG::makeCurrent): (WebCore::SurfaceOpenVG::makeCompatibleCurrent):
  • platform/graphics/openvg/SurfaceOpenVG.h: (WebCore::SurfaceOpenVG::):
11:17 AM Changeset in webkit [55921] by jianli@chromium.org
  • 4 edits
    1 add in trunk/WebCore

[v8] Add V8 bindings for DOMFormData.
​https://bugs.webkit.org/show_bug.cgi?id=36026

Reviewed by Nate Chapin.

Test: http/tests/local/send-form-data.html

  • WebCore.gypi:
  • bindings/v8/V8Index.h:
  • bindings/v8/custom/V8DOMFormDataCustom.cpp: Added.

(WebCore::V8DOMFormData::appendCallback):

  • bindings/v8/custom/V8XMLHttpRequestCustom.cpp:

(WebCore::V8XMLHttpRequest::sendCallback):

11:17 AM Changeset in webkit [55920] by jianli@chromium.org
  • 27 edits
    6 adds in trunk

WebCore: Add DOMFormData.idl to expose FormData interface.
​https://bugs.webkit.org/show_bug.cgi?id=36024

Reviewed by Sam Weinig.

The implementation is based on XMLHttpRequest 2 spec:
​http://dev.w3.org/2006/webapi/XMLHttpRequest-2/#formdata

Test: http/tests/local/send-form-data.html

  • Android.derived.jscbindings.mk:
  • Android.derived.v8bindings.mk:
  • DerivedSources.cpp:
  • DerivedSources.make:
  • GNUmakefile.am:
  • WebCore.pri:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSDOMFormDataCustom.cpp: Added.
  • bindings/js/JSXMLHttpRequestCustom.cpp:

(WebCore::JSXMLHttpRequest::send):

  • bindings/scripts/CodeGeneratorJS.pm:
  • html/DOMFormData.idl: Added.
  • page/DOMWindow.idl:

LayoutTests: Add DOMFormData.idl to expose FormData interface
​https://bugs.webkit.org/show_bug.cgi?id=36024

Reviewed by Sam Weinig.

Add a layout test to test sending FormData via XMLHttpRequest. Also
changed all test results that are affected by exposing FormData.

  • fast/dom/Window/window-properties-expected.txt:
  • fast/dom/Window/window-property-descriptors-expected.txt:
  • fast/dom/constructed-objects-prototypes-expected.txt:
  • fast/dom/prototype-inheritance-2-expected.txt:
  • fast/dom/prototype-inheritance-expected.txt:
  • fast/js/global-constructors-expected.txt:
  • http/tests/local/resources/send-form-data.js: Added.
  • http/tests/local/send-form-data-expected.txt: Added.
  • http/tests/local/send-form-data.html: Added.
  • http/tests/xmlhttprequest/resources/multipart-post-echo.php: Added.
  • platform/gtk/Skipped:
  • platform/gtk/fast/dom/Window/window-properties-expected.txt:
  • platform/qt/Skipped:
  • platform/qt/fast/dom/Window/window-properties-expected.txt:
  • platform/qt/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/qt/fast/dom/prototype-inheritance-expected.txt:
  • platform/qt/fast/js/global-constructors-expected.txt:
  • platform/win/Skipped:
11:11 AM Changeset in webkit [55919] by jpetsovits@rim.com
  • 5 edits in trunk/WebCore

2010-03-12 Jakob Petsovits <​jpetsovits@rim.com>

Reviewed by Dirk Schulze.

[OpenVG] Add a SurfaceOpenVG constructor for EGL client buffer surfaces
​https://bugs.webkit.org/show_bug.cgi?id=35538

SurfaceOpenVG can now not only encapsulate pbuffer
and window surfaces but also VGImage-based ones.

  • platform/graphics/openvg/EGLDisplayOpenVG.cpp: (WebCore::EGLDisplayOpenVG::createPbufferFromClientBuffer):
  • platform/graphics/openvg/EGLDisplayOpenVG.h:
  • platform/graphics/openvg/SurfaceOpenVG.cpp: (WebCore::SurfaceOpenVG::SurfaceOpenVG):
  • platform/graphics/openvg/SurfaceOpenVG.h:
11:06 AM Changeset in webkit [55918] by Adam Roben
  • 2 edits in trunk/WebKitTools

Teach prepare-ChangeLog to find modified selectors in CSS files

Reviewed by Tim Hatcher.

Fixes <​http://webkit.org/b/36064> prepare-ChangeLog should extract
modified selectors from CSS files

  • Scripts/prepare-ChangeLog:

(get_function_line_ranges): Call get_selector_line_ranges_for_css for
.css files.
(get_selector_line_ranges_for_css): Added. Finds selectors and their
line ranges and returns them.

11:03 AM Changeset in webkit [55917] by eric@webkit.org
  • 3 edits
    2 adds in trunk

2010-03-12 Alpha Lam <​hclam@chromium.org>

Reviewed by Eric Carlson.

HTMLMediaElement crash when it is used after resource loading is canceled.
​https://bugs.webkit.org/show_bug.cgi?id=35992

Adding a test to access the duration property of a video element after
resource loading was canceled.

  • http/tests/media/video-cancel-load-expected.txt: Added.
  • http/tests/media/video-cancel-load.html: Added.

2010-03-12 Alpha Lam <​hclam@chromium.org>

Reviewed by Eric Carlson.

Fix a crash when resource loading of media element is canceled.
​https://bugs.webkit.org/show_bug.cgi?id=35992

Use of HTMLMediaElement::duration() after resource loading was canceled
will cause a crash. This is because HTMLMediaElement::m_player is used
when NULL.
Test: http/tests/media/video-cancel-load.html

  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::duration): Avoid calling to m_player when it is null. (WebCore::HTMLMediaElement::userCancelledLoad): Set m_readyState to HAVE_NOTHING.
10:45 AM Changeset in webkit [55916] by eric@webkit.org
  • 2 edits in trunk/WebKit/chromium

2010-03-12 Garret Kelly <​gdk@chromium.org>

Reviewed by Eric Seidel.

Enable touch events in Chromium features gypi file.
​https://bugs.webkit.org/show_bug.cgi?id=35994

  • features.gypi:
10:36 AM Changeset in webkit [55915] by kov@webkit.org
  • 9 edits in trunk/WebKit/gtk

2010-03-12 Gustavo Noronha Silva <​gustavo.noronha@collabora.co.uk>

Rubber-stamped by Kenneth Rohde Christiansen.

Misc documentation fixes. Fixes (almost) all warnings emitted by
the documentation build process. Only the broken references to JSC
objects remain.

  • webkit/webkitsecurityorigin.cpp:
  • webkit/webkitwebbackforwardlist.cpp:
  • webkit/webkitwebdatasource.cpp:
  • webkit/webkitwebframe.cpp:
  • webkit/webkitwebhistoryitem.cpp:
  • webkit/webkitwebinspector.cpp: (webkit_web_inspector_class_init):
  • webkit/webkitwebsettings.cpp: (webkit_web_settings_class_init):
  • webkit/webkitwebview.cpp: (DNDContentsRequest::webkit_web_view_class_init):
10:28 AM Changeset in webkit [55914] by mitz@apple.com
  • 2 edits in trunk/WebCore

<rdar://problem/7725534> CSSPrimitiveValue::parserValue() returns deleted memory
​https://bugs.webkit.org/show_bug.cgi?id=20069

Reviewed by Darin Adler.

No test added, since with the CSS variables feature disabled, the pointer
to the freed memory is never dereferenced.

  • css/CSSPrimitiveValue.cpp:

(WebCore::valueOrPropertyName): Changed to return a const AtomicString& from
a static table.
(WebCore::CSSPrimitiveValue::parserValue): Updated for the above change.

10:18 AM Changeset in webkit [55913] by ojan@chromium.org
  • 38 edits
    4 copies
    7 adds in trunk/LayoutTests

2010-03-05 Ojan Vafai <​ojan@chromium.org>

Reviewed by David Levin.

Tests for smartdelete should only occur after double-click
​https://bugs.webkit.org/show_bug.cgi?id=35314

Fixes the tests to make selections using the mouse in order
to force smart-delete. It also adds/modifies tests to have them correctly
identify cases where we are smart-deleting, but shouldn't be.

Fixing to smart-delete only on mouse-based selections will be a followup patch.

  • editing/deleting/5390681-2.html:
  • editing/deleting/non-smart-delete.html: Added.
  • editing/deleting/smart-delete-001.html:
  • editing/deleting/smart-delete-002.html:
  • editing/deleting/smart-delete-003.html:
  • editing/deleting/smart-delete-004.html:
  • editing/editing.js: (doubleClick): (doubleClickAtSelectionStart):
  • editing/pasteboard/4944770-2.html:
  • editing/pasteboard/drag-drop-modifies-page.html:
  • editing/pasteboard/smart-drag-drop.html: Added.
  • editing/pasteboard/smart-paste-001.html:
  • editing/pasteboard/smart-paste-002.html:
  • editing/pasteboard/smart-paste-003.html:
  • editing/pasteboard/smart-paste-004.html:
  • editing/pasteboard/smart-paste-005.html:
  • editing/pasteboard/smart-paste-007.html:
  • editing/pasteboard/smart-paste-008.html:
  • editing/selection/delete-word-granularity-text-control-expected.txt: Added.
  • editing/selection/delete-word-granularity-text-control.html: Added.
  • editing/selection/script-tests/delete-word-granularity-text-control.js: Added.
  • editing/style/style-boundary-005.html:
  • platform/mac/editing/deleting/non-smart-delete-expected.checksum: Added.
  • platform/mac/editing/deleting/non-smart-delete-expected.png: Added.
  • platform/mac/editing/deleting/non-smart-delete-expected.txt: Added.
  • platform/mac/editing/deleting/smart-delete-001-expected.txt:
  • platform/mac/editing/deleting/smart-delete-002-expected.txt:
  • platform/mac/editing/deleting/smart-delete-003-expected.txt:
  • platform/mac/editing/deleting/smart-delete-004-expected.txt:
  • platform/mac/editing/pasteboard/drag-drop-modifies-page-expected.checksum:
  • platform/mac/editing/pasteboard/drag-drop-modifies-page-expected.png:
  • platform/mac/editing/pasteboard/drag-drop-modifies-page-expected.txt:
  • platform/mac/editing/pasteboard/smart-drag-drop-expected.checksum: Added.
  • platform/mac/editing/pasteboard/smart-drag-drop-expected.png: Added.
  • platform/mac/editing/pasteboard/smart-drag-drop-expected.txt: Added.
  • platform/mac/editing/pasteboard/smart-paste-001-expected.txt:
  • platform/mac/editing/pasteboard/smart-paste-002-expected.txt:
  • platform/mac/editing/pasteboard/smart-paste-003-expected.txt:
  • platform/mac/editing/pasteboard/smart-paste-004-expected.txt:
  • platform/mac/editing/pasteboard/smart-paste-005-expected.txt:
  • platform/mac/editing/pasteboard/smart-paste-007-expected.txt:
  • platform/mac/editing/pasteboard/smart-paste-008-expected.txt:
  • platform/mac/editing/style/style-boundary-005-expected.checksum:
  • platform/mac/editing/style/style-boundary-005-expected.png:
  • platform/mac/editing/style/style-boundary-005-expected.txt:
10:14 AM Changeset in webkit [55912] by darin@chromium.org
  • 2 edits in trunk/WebKit/chromium

2010-03-12 Darin Fisher <​darin@chromium.org>

Fix Chromium build bustage.

Wrap usage of WebPrivatePtr from WebNode.h in a #if
WEBKIT_IMPLEMENTATION guard.

  • public/WebNode.h:
10:03 AM Changeset in webkit [55911] by mitz@apple.com
  • 2 edits in trunk/WebCore

Build fix.

  • platform/chromium/PlatformKeyboardEventChromium.cpp:
9:54 AM Changeset in webkit [55910] by ap@apple.com
  • 1 edit in trunk/WebKitTools/ChangeLog

Fixing an embarrassing typo in ChangeLog.

9:06 AM Changeset in webkit [55909] by mitz@apple.com
  • 16 edits
    2 adds in trunk

<rdar://problem/7694674> Hover states not updated when overflow section scrolls under stationary mouse pointer
​https://bugs.webkit.org/show_bug.cgi?id=35949

Reviewed by Darin Adler.

WebCore:

Test: fast/events/overflow-scroll-fake-mouse-move.html

Soon after an overflow section scrolls under the mouse pointer, dispatch
a fake mouse move event. This is similar to how frame scrolling is handled
in WebKit, and has the effect of updating hover state, dispatching DOM mouse
events, and updating the tool tip.

  • page/EventHandler.cpp:

(WebCore::EventHandler::EventHandler): Initialize m_fakeMouseMoveEventTimer.
(WebCore::EventHandler::~EventHandler): Assert that the timer is not active.
(WebCore::EventHandler::clear): Stop the timer.
(WebCore::EventHandler::handleMousePressEvent): Cancel pending fake mouse
move events.
(WebCore::EventHandler::handleMouseMoveEvent): Ditto.
(WebCore::EventHandler::dispatchFakeMouseMoveEventSoonInQuad): If the mouse
is in the passed-in quad, ensure that a fake mouse move event is scheduled
to fire soon.
(WebCore::EventHandler::cancelFakeMouseMoveEvent): Does what the name says.
(WebCore::EventHandler::fakeMouseMoveEventTimerFired): Constructs a
PlatformMouseEvent with the current mouse location, modifier key state and
time stamp and calls mouseMoved().

  • page/EventHandler.h:
  • platform/PlatformKeyboardEvent.h: Declared getCurrentModifierState().
  • platform/android/KeyEventAndroid.cpp:

(WebCore::PlatformKeyboardEvent::getCurrentModifierState): Stubbed out.

  • platform/brew/PlatformKeyboardEventBrew.cpp:

(WebCore::PlatformKeyboardEvent::getCurrentModifierState): Ditto.

  • platform/chromium/PlatformKeyboardEventChromium.cpp:

(WebCore::PlatformKeyboardEvent::getCurrentModifierState): Added.

  • platform/efl/PlatformKeyboardEventEfl.cpp:

(WebCore::PlatformKeyboardEvent::getCurrentModifierState): Stubbed out.

  • platform/gtk/KeyEventGtk.cpp:

(WebCore::PlatformKeyboardEvent::getCurrentModifierState): Ditto.

  • platform/haiku/PlatformKeyboardEventHaiku.cpp:

(WebCore::PlatformKeyboardEvent::getCurrentModifierState): Added.

  • platform/mac/KeyEventMac.mm:

(WebCore::PlatformKeyboardEvent::getCurrentModifierState): Ditto.

  • platform/qt/PlatformKeyboardEventQt.cpp:

(WebCore::PlatformKeyboardEvent::getCurrentModifierState): Stubbed out.

  • platform/win/KeyEventWin.cpp:

(WebCore::PlatformKeyboardEvent::getCurrentModifierState): Added.

  • platform/wx/KeyboardEventWx.cpp:

(WebCore::PlatformKeyboardEvent::getCurrentModifierState): Ditto.

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::scrollToOffset): Call
EventHandler::dispatchFakeMouseMoveEventSoonInQuad(). Moved things around
a little to avoid computing the repaint rect twice.

LayoutTests:

  • fast/events/overflow-scroll-fake-mouse-move-expected.txt: Added.
  • fast/events/overflow-scroll-fake-mouse-move.html: Added.
  • fast/events/touch/basic-multi-touch-events.html:
  • fast/events/touch/basic-single-touch-events.html:
9:03 AM Changeset in webkit [55908] by eric@webkit.org
  • 2 edits in trunk/WebKit/chromium

2010-03-12 Nicolas Weber <​thakis@chromium.org>

Reviewed by David Levin.

[Chromium] Cmd-clicking submit buttons should submit in new tab
​https://bugs.webkit.org/show_bug.cgi?id=36023

Take modifiers into account when clicking form buttons. E.g.
cmd-clicking a submit button will submit in a new background tab,
cmd-shift-clicking in a new foreground tab, shift-clicking in a new
window. (On windows/linux, it's ctrl instead of cmd.)

  • src/FrameLoaderClientImpl.cpp: (WebKit::FrameLoaderClientImpl::actionSpecifiesNavigationPolicy):
8:56 AM Changeset in webkit [55907] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

2010-03-12 Csaba Osztrogonác <Csaba Osztrogonác>

[Qt] css1/box_properties/acid_test.html failed in release mode (32 bit).
But it passes in debug mode (32 and 64 bit) and in release mode (64 bit).

​https://bugs.webkit.org/show_bug.cgi?id=33834

  • platform/qt/Skipped: css1/box_properties/acid_test.html skipped again.
8:36 AM Changeset in webkit [55906] by eric@webkit.org
  • 2 edits in trunk/WebKit/chromium

2010-03-12 Kavita Kanetkar <​kkanetkar@chromium.org>

Reviewed by Darin Fisher.

[chromium] Fix memory leak in WebImageDecoder API
​https://bugs.webkit.org/show_bug.cgi?id=35946

  • src/WebImageDecoder.cpp: (WebKit::WebImageDecoder::setData): (WebKit::WebImageDecoder::getFrameAtIndex):
8:15 AM Changeset in webkit [55905] by kov@webkit.org
  • 3 edits in trunk/WebKitTools

Build fix (for EWS). Make sure the new code builds on older soup.

Thanks to Dan Winship.

8:05 AM Changeset in webkit [55904] by kov@webkit.org
  • 6 edits in trunk

2010-03-12 Gustavo Noronha Silva <​gustavo.noronha@collabora.co.uk>

Reviewed by Eric Carlson.

[GTK] DRT does not handle cookie policy setting
​https://bugs.webkit.org/show_bug.cgi?id=36056

Implement cookie accept policy setting for GTK+'s LayoutTestController.

  • DumpRenderTree/gtk/DumpRenderTree.cpp: (resetDefaultsToConsistentValues):
  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::setAlwaysAcceptCookies):

LayoutTests

2010-03-12 Gustavo Noronha Silva <​gustavo.noronha@collabora.co.uk>

Reviewed by Eric Carlson.

[GTK] DRT does not handle cookie policy setting
​https://bugs.webkit.org/show_bug.cgi?id=36056

Fix tests to request that the cookie acceptance policy always allows cookies.

  • http/tests/media/video-cookie.html:
  • http/tests/media/video-referer.html:
8:02 AM Changeset in webkit [55903] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2010-03-12 Adam Langley <​agl@chromium.org>

Reviewed by Dimitri Glazkov.

[chromium]: update Linux layout test scripts for RedHat like systems.

(Tested on Fedora 12.)

​https://bugs.webkit.org/show_bug.cgi?id=35867

  • Scripts/webkitpy/layout_tests/port/chromium_linux.py:
7:53 AM Changeset in webkit [55902] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] Now css1/box_properties/acid_test.html passes, so we can unskip it.
original bug: ​https://bugs.webkit.org/show_bug.cgi?id=33834

  • platform/qt/Skipped: css1/box_properties/acid_test.html unskipped.
7:45 AM Changeset in webkit [55901] by eric@webkit.org
  • 2 edits in trunk/WebKit/mac

2010-03-12 Andy Estes <​aestes@apple.com>

Reviewed by Brady Eidson.

Remove an unused method.

​https://bugs.webkit.org/show_bug.cgi?id=35940

  • Plugins/WebPluginController.mm: removed - (void)showURL:(NSURL *) inFrame:(NSString *)
7:28 AM Changeset in webkit [55900] by eric@webkit.org
  • 2 edits in trunk/JavaScriptCore

2010-03-12 Peter Varga <​pvarga@inf.u-szeged.hu>

Reviewed by David Levin.

Two functions tryConsumeCharacter() and tryConsumeCharacterClass() are
removed from yarr/RegexInterpreter.cpp because they are never called.

  • yarr/RegexInterpreter.cpp:
7:16 AM Changeset in webkit [55899] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] DRT failing on test introduced in r55499
​https://bugs.webkit.org/show_bug.cgi?id=35729

Now fast/events/zoom-dblclick.html passes, so we can unskip it.

  • platform/qt/Skipped: fast/events/zoom-dblclick.html unskipped.
7:12 AM Changeset in webkit [55898] by Adam Roben
  • 2 edits in trunk/WebKitTools

Make svn-create-patch's diffs of ObjC header files more readable

Fixes <​http://webkit.org/b/36055>.

Reviewed by John Sullivan.

  • Scripts/svn-create-patch:

(diffOptionsForFile): Added. Returns the options that should be passed
to diff for the given file. All the options are the same for all
files, except for the option to specify which lines should be used as
hunk headers.
(generateDiff): Use diffOptionsForFile to get the options to pass to
diff.
(hunkHeaderLineRegExForFile): Added. Returns the regular expression
that should be used by diff to identify lines that should be included
after the "@@" in the hunk header lines of the diff. For ObjC[++]
source files, we use any lines starting with -, +, or
@implementation/@interface/@protocol. For ObjC[++] header files (which
we assume to be any .h files in a mac/ or objc/ directory), we use any
lines starting with @implementation/@interface/@protocol.

7:10 AM Changeset in webkit [55897] by eric@webkit.org
  • 5 edits in trunk

2010-03-12 Scott Byer <​scottbyer@chromium.org>

Reviewed by David Levin.

Popup font size needs to be exposed to clients.
​https://bugs.webkit.org/show_bug.cgi?id=35990

Add function to expose the popup menu font size, add a field to
WebPopupMenuInfo that receives that information to convey that to
the web view client's createPopupMenu() call.

  • WebCore/platform/chromium/PopupMenuChromium.cpp:
  • WebCore/platform/chromium/PopupMenuChromium.h:
  • WebKit/chromium/public/WebPopupMenuInfo.h:
  • WebKit/chromium/src/ChromeClientImpl.cpp:
6:53 AM Changeset in webkit [55896] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-03-12 Kent Hansen <​kent.hansen@nokia.com>

Reviewed by Darin Adler.

Webkit doesn't build with workers on and database off
​https://bugs.webkit.org/show_bug.cgi?id=35997

Added missing ENABLE(DATABASE) guards.

  • workers/WorkerThread.cpp: (WebCore::WorkerThreadShutdownStartTask::performTask):
6:25 AM Changeset in webkit [55895] by kov@webkit.org
  • 2 edits in trunk/LayoutTests

2010-03-12 Gustavo Noronha Silva <​gustavo.noronha@collabora.co.uk>

[GTK] Fails fast/dom/Geolocation/maximum-age.htm
​https://bugs.webkit.org/show_bug.cgi?id=36053

Skip new failing test.

  • platform/gtk/Skipped:
6:25 AM Changeset in webkit [55894] by kov@webkit.org
  • 4 edits in trunk

2010-03-12 Dan Winship <​danw@gnome.org>

Reviewed by Gustavo Noronha.

Make the defaultCookieJar use a no-third-party policy. Most
applications set their own cookie jar, but DumpRenderTree doesn't,
so it was failing the new third-party-cookie test.

  • platform/network/soup/CookieJarSoup.cpp: (WebCore::defaultCookieJar):

LayoutTests

2010-03-12 Dan Winship <​danw@gnome.org>

Reviewed by Gustavo Noronha.

Revert previous; the test passes now.

  • platform/gtk/Skipped:
6:06 AM Changeset in webkit [55893] by eric@webkit.org
  • 8 edits
    4 adds in trunk

2010-03-12 Jochen Eisinger <​jochen@chromium.org>

Reviewed by Jeremy Orlow.

Test for referrer information being stripped when the header is removed in willSendRequest
​https://bugs.webkit.org/show_bug.cgi?id=35920

  • http/tests/security/no-referrer-expected.txt: Added.
  • http/tests/security/no-referrer.html: Added.
  • http/tests/security/resources/no-referrer-frame.php: Added.
  • http/tests/security/resources/no-referrer.php: Added.
  • platform/gtk/Skipped:
  • platform/qt/Skipped:

2010-03-12 Jochen Eisinger <​jochen@chromium.org>

Reviewed by Jeremy Orlow.

Introduce setWillSendRequestClearHeader to LayoutTestController to selectively remove headers in willSendRequest. Used in http/tests/security/no-referrer.html
​https://bugs.webkit.org/show_bug.cgi?id=35920

  • DumpRenderTree/LayoutTestController.cpp: (setWillSendRequestClearHeaderCallback): (LayoutTestController::staticFunctions):
  • DumpRenderTree/LayoutTestController.h: (LayoutTestController::willSendRequestClearHeaders): (LayoutTestController::setWillSendRequestClearHeader):
  • DumpRenderTree/mac/ResourceLoadDelegate.mm: (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
  • DumpRenderTree/win/ResourceLoadDelegate.cpp: (ResourceLoadDelegate::willSendRequest):
5:44 AM Changeset in webkit [55892] by Nikolas Zimmermann
  • 5 edits in trunk/LayoutTests

2010-03-12 Nikolas Zimmermann <​nzimmermann@rim.com>

Rubber-stamped by Dirk Schulze.

Update two tests, whose pixel hash fail with --tolerance 0. No visible differences.

  • platform/mac/svg/custom/dominant-baseline-hanging-expected.checksum:
  • platform/mac/svg/custom/dominant-baseline-hanging-expected.png:
  • platform/mac/svg/custom/gradient-stop-corner-cases-expected.checksum:
  • platform/mac/svg/custom/gradient-stop-corner-cases-expected.png:
Note: See TracTimeline for information about the timeline view.