Context Navigation

dom/OptionElement.h:
dom/SelectElement.cpp: (WebCore::SelectElement::appendFormData): If a selected option is disabled, skip it. Remove code for non-selected menulist because of compatibility with other browsers.

10:55 PM Changeset in webkit [56040] by abarth@webkit.org

7 edits in trunk/WebKitTools

2010-03-15 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Let commit-queue land rollout patches even when the tree is red
https://bugs.webkit.org/show_bug.cgi?id=36155

Now the commit-queue will land patches whose name begins with "ROLLOUT "
even if the tree is red. The patches still go through the usual build
and test process, but they can be landed while the tree is on fire.

Scripts/webkitpy/bugzilla.py:
Scripts/webkitpy/commands/queues.py:
Scripts/webkitpy/commands/queues_unittest.py:
Scripts/webkitpy/commands/queuestest.py:
Scripts/webkitpy/mock_bugzillatool.py:

10:50 PM Changeset in webkit [56039] by eric@webkit.org

1 edit
1 add in trunk/WebCore

2010-03-15 Leandro Pereira <leandro@profusion.mobi>

Reviewed by Holger Freyther.

Add EFL port files to platform/efl.
http://webkit.org/b/35884

platform/efl/FileSystemEfl.cpp: Added.

10:33 PM Changeset in webkit [56038] by eric@webkit.org

1 edit
1 add in trunk/WebCore

2010-03-15 Leandro Pereira <leandro@profusion.mobi>

Reviewed by Holger Freyther.

Add EFL port files to platform/efl.
http://webkit.org/b/35882

platform/efl/ContextMenuItemEfl.cpp: Added.

10:32 PM Changeset in webkit [56037] by mjs@apple.com

2 edits in trunk/WebKitSite

Tweak canvas perf demo.

demos/canvas-perf/canvas.html:

10:15 PM Changeset in webkit [56036] by eric@webkit.org

4 edits in trunk

2010-03-15 Joanmarie Diggs <joanmarie.diggs@gmail.com>

Reviewed by Holger Freyther.

https://bugs.webkit.org/show_bug.cgi?id=35502
[Gtk] Objects of ATK_ROLE_TABLE should not implement AtkText

Simple change to stop tables from implementing AtkText.

accessibility/gtk/AccessibilityObjectAtk.cpp: (getInterfaceMaskFromObject):

2010-03-15 Joanmarie Diggs <joanmarie.diggs@gmail.com>

Reviewed by Holger Freyther.

https://bugs.webkit.org/show_bug.cgi?id=35502
[Gtk] Objects of ATK_ROLE_TABLE should not implement AtkText

New test to be sure we do not accidentally implement AtkText for tables

tests/testatk.c (testWebkitAtkGetTextInTable): (main):

9:58 PM Changeset in webkit [56035] by eric@webkit.org

6 edits in trunk

2010-03-15 Adam Bergkvist <adam.bergkvist@ericsson.com>

Reviewed by Adam Barth.

According to the updated specification, a data field should always
result in a newline character being appended to the data buffer
regardless if the data buffer contains any data or not. However, upon
event dispatch, the last newline will be removed. This differs from an
older version of the specification where a newline character was
appended before the data value only if the buffer already contained
data. As a result, EventSource now supports receiving events with empty
data or newline characters only. Updated test accordingly.
https://bugs.webkit.org/show_bug.cgi?id=33210

http/tests/eventsource/eventsource-parse-event-stream-expected.txt:
http/tests/eventsource/eventsource-parse-event-stream.html:
http/tests/eventsource/resources/event-stream.php:

2010-03-15 Adam Bergkvist <adam.bergkvist@ericsson.com>

Reviewed by Adam Barth.

According to the updated specification, a data field should always
result in a newline character being appended to the data buffer
regardless if the data buffer contains any data or not. However, upon
event dispatch, the last newline will be removed. This differs from an
older version of the specification where a newline character was
appended before the data value only if the buffer already contained
data. As a result, EventSource now supports receiving events with empty
data or newline characters only.
https://bugs.webkit.org/show_bug.cgi?id=33210

page/EventSource.cpp: (WebCore::EventSource::parseEventStreamLine):

9:43 PM Changeset in webkit [56034] by abarth@webkit.org

4 edits
1 add in trunk/WebKitTools

2010-03-15 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Add webkit-patch post-rollout to upload rollouts to bugs.webkit.org for easy committing
https://bugs.webkit.org/show_bug.cgi?id=36154

This new command is a mashup of prepare-rollout and post. This command
will be used by an experimental bot to post rollouts of patches that
break things to bugs.webkit.org where they can be landed with the
greatest of ease.

Scripts/webkitpy/commands/download.py:
Scripts/webkitpy/commands/download_unittest.py:
Scripts/webkitpy/steps/init.py:
Scripts/webkitpy/steps/postdiffforrevert.py: Added.

9:41 PM Changeset in webkit [56033] by eric@webkit.org

3 edits
2 adds in trunk

2010-03-15 Valters Svabe <vsvabe@gmail.com>

Reviewed by Darin Adler.

:after selector displays in wrong place with nested div
https://bugs.webkit.org/show_bug.cgi?id=32288

fast/css-generated-content/block-after-expected.txt: Added.
fast/css-generated-content/block-after.html: Added.

2010-03-15 Valters Svabe <vsvabe@gmail.com>

Reviewed by Darin Adler.

:after selector displays in wrong place with nested div
https://bugs.webkit.org/show_bug.cgi?id=32288

Make sure we don't append things after :after-generated content, if
it's inside an anonymous block.

Test: fast/css-generated-content/block-after.html

rendering/RenderBlock.cpp: (WebCore::RenderBlock::addChild):

9:15 PM Changeset in webkit [56032] by abarth@webkit.org

2 edits in trunk/WebKitTools

2010-03-15 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

webkit-patch rollout should error out on conflicts
https://bugs.webkit.org/show_bug.cgi?id=36151

Instead of blindingly plowing ahead, we now throw an exception if there
are conflicts after applying a reverse diff.

Scripts/webkitpy/scm.py:

9:07 PM Changeset in webkit [56031] by eric@webkit.org

1 edit
1 add in trunk/JavaScriptCore

2010-03-15 Kwang Yul Seo <skyul@company100.net>

Reviewed by Eric Seidel.

[BREWMP] Add a function to create a BREW instance without local variable declarations.
https://bugs.webkit.org/show_bug.cgi?id=34705

Add a template function to create a BREW instance in one line.

wtf/brew/ShellBrew.h: Added. (WTF::createInstance):

8:27 PM Changeset in webkit [56030] by darin@chromium.org

2 edits in trunk/WebKit/chromium

2010-03-15 Darin Fisher <darin@chromium.org>

Fix build bustage. We also need to pull down "third_party/tcmalloc"

DEPS:

7:36 PM Changeset in webkit [56029] by ggaren@apple.com

2 edits in trunk/JavaScriptCore

Not reviewed.

Removed a now-incorrect comment I forgot to remove in my last check-in.

wtf/FastMalloc.cpp:

(WTF::TCMalloc_PageHeap::scavenge):

7:21 PM Changeset in webkit [56028] by ggaren@apple.com

2 edits in trunk/JavaScriptCore

Fixed a portion of:
<rdar://problem/7165917> | https://bugs.webkit.org/show_bug.cgi?id=28676
Safari 4 does not release memory back to the operating system fast enough (28676)

Reviewed by Sam Weinig.

Every few seconds, release a percentage of the minimum unused page count
during that time period.

SunSpider reports no change, command-line or in-browser, Mac or Windows.

wtf/FastMalloc.cpp:

(WTF::TCMalloc_PageHeap::init):
(WTF::TCMalloc_PageHeap::signalScavenger):
(WTF::TCMalloc_PageHeap::initializeScavenger): Renamed shouldContinueScavenging
to shouldScavenge, since scavenging is no longer something that we interrupt.

(WTF::TCMalloc_PageHeap::scavenge): The new scavenging algorithm. Fixes
a bug where the old code would release only one item from each size class
per scavenge, potentially leaving large numbers of large-sized objects
unreleased for a long time.

(WTF::TCMalloc_PageHeap::shouldScavenge):
(WTF::TCMalloc_PageHeap::New):
(WTF::TCMalloc_PageHeap::AllocLarge):
(WTF::TCMalloc_PageHeap::Delete):
(WTF::TCMalloc_PageHeap::GrowHeap):
(WTF::TCMalloc_PageHeap::scavengerThread):
(WTF::TCMalloc_PageHeap::periodicScavenge): Updated to track the minimum
value of free_committed_pages_ during a given scavenge period.

5:06 PM Changeset in webkit [56027] by darin@chromium.org

2 edits in trunk/WebKit/chromium

2010-03-15 Darin Fisher <darin@chromium.org>

Fix build bustage. We also need to pull down "gfx"

DEPS:

4:54 PM Changeset in webkit [56026] by Chris Fleizach

4 edits in trunk

WebKitTools: Unreviewed layout test fix.

VO not able to perform a VO-spacebar on facebook links
https://bugs.webkit.org/show_bug.cgi?id=36132

GTK needs to implement press for this test to work.

DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:

(AccessibilityUIElement::press):

LayoutTests: Unreviewed.

VO not able to perform a VO-spacebar on facebook links
https://bugs.webkit.org/show_bug.cgi?id=36132

GTK needs to implement press in DRT before this test can work.

platform/gtk/Skipped:

4:28 PM Changeset in webkit [56025] by Chris Fleizach

4 edits in trunk

Unreviewed layout test fix.

WebKitTools:

VO not able to perform a VO-spacebar on facebook links
https://bugs.webkit.org/show_bug.cgi?id=36132

Windows needs to implement press in DRT.

DumpRenderTree/win/AccessibilityUIElementWin.cpp:

(AccessibilityUIElement::press):

LayoutTests:

VO not able to perform a VO-spacebar on facebook links
https://bugs.webkit.org/show_bug.cgi?id=36132

This test must be skipped until https://bugs.webkit.org/show_bug.cgi?id=36145 is done.

platform/win/Skipped:

4:28 PM Changeset in webkit [56024] by darin@chromium.org

5 edits in trunk/WebKit/chromium

2010-03-15 Darin Fisher <darin@chromium.org>

Reviewed by David Levin.

https://bugs.webkit.org/show_bug.cgi?id=36131
Update include paths for chromium Rect, Point, and Size types.

Update DEPS to pull latest chromium code that reflects the
new location of these headers.

DEPS:
public/WebPoint.h:
public/WebRect.h:
public/WebSize.h:

4:20 PM Changeset in webkit [56023] by eric@webkit.org

1 edit
1 add in trunk/WebCore

2010-03-15 Leandro Pereira <leandro@profusion.mobi>

Reviewed by Eric Seidel.

Add EFL port files to platform/efl.
http://webkit.org/b/35885

platform/efl/KURLEfl.cpp: Added.

4:06 PM Changeset in webkit [56022] by Chris Fleizach

3 edits in trunk/WebKitTools

Unreviewed. Fix break of layout tests on win and gtk.

VO not able to perform a VO-spacebar on facebook links
https://bugs.webkit.org/show_bug.cgi?id=36132

Attempting to implement press action for windows and gtk.

DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:

(AccessibilityUIElement::press):

DumpRenderTree/win/AccessibilityUIElementWin.cpp:

(AccessibilityUIElement::press):

3:59 PM Changeset in webkit [56021] by barraclough@apple.com

3 edits in trunk/JavaScriptCore

https://bugs.webkit.org/show_bug.cgi?id=35843
Re-land reverted fix to JSString::getIndex()

Reviewed by Sam Weinig.

Calling getIndex() on a JSString in rope form may result in a JSException being thrown
if there is insuficient memory so value(exec) returns UString() with length zero,
which will be passed to jsSingleCharacterSubstring.
Add a slow case function to trap the error & return a safe null value, until the
exception is handled.

runtime/JSString.cpp:

(JSC::JSString::getIndexSlowCase):
(JSC::JSString::getStringPropertyDescriptor):

runtime/JSString.h:

(JSC::jsSingleCharacterSubstring):
(JSC::JSString::getIndex):
(JSC::jsSingleCharacterString):
(JSC::JSString::getStringPropertySlot):

3:38 PM Changeset in webkit [56020] by Chris Fleizach

6 edits in trunk/WebKitTools

VO not able to perform a VO-spacebar on facebook links
https://bugs.webkit.org/show_bug.cgi?id=36132

Reviewed by Beth Dakin.

DumpRenderTree/AccessibilityUIElement.cpp:

(pressCallback):
(AccessibilityUIElement::getJSClass):

DumpRenderTree/AccessibilityUIElement.h:
DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:

(AccessibilityUIElement::press):

DumpRenderTree/mac/AccessibilityUIElementMac.mm:

(AccessibilityUIElement::press):

DumpRenderTree/win/AccessibilityUIElementWin.cpp:

(AccessibilityUIElement::press):

3:07 PM Changeset in webkit [56019] by Chris Fleizach

3 edits
2 adds in trunk

VO not able to perform a VO-spacebar on facebook links
https://bugs.webkit.org/show_bug.cgi?id=36132

Reviewed by Beth Dakin.

WebCore:

When a label element is used as a click event handler, and it doesn't have any
corresponding control, it should handle the action itself.

Test: accessibility/label-element-press.html

html/HTMLLabelElement.cpp:

(WebCore::HTMLLabelElement::accessKeyAction):

LayoutTests:

accessibility/label-element-press-expected.txt: Added.
accessibility/label-element-press.html: Added.

2:56 PM Changeset in webkit [56018] by cwzwarich@webkit.org

2 edits in trunk/WebCore

2010-03-15 Cameron Zwarich <zwarich@apple.com>

Reviewed by Geoff Garen.

Bug 36135 - GCController::garbageCollectNow() crashes when called from garbage collection
<https://bugs.webkit.org/show_bug.cgi?id=36135>
<rdar://problem/7752552>

bindings/js/GCController.cpp:

(WebCore::GCController::garbageCollectNow): Fail silently if garbage collection is
active rather than hitting the CRASH() reentrancy guard.

2:47 PM Changeset in webkit [56017] by Simon Fraser

2 edits in trunk/WebCore

2010-03-15 Simon Fraser <Simon Fraser>

Reviewed by Dan Bernstein.

Drop out of compositing mode when no elements need to composite
https://bugs.webkit.org/show_bug.cgi?id=36134

When no more elements on the page need to be composited, drop out of compositing
mode altogether, including removing the layer-backed view that hosts the layers.

rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::updateCompositingLayers): If the list of child layers to attach at the root is empty, we have no composited layers, and can drop out of compositing mode by calling willMoveOffscreen().

(WebCore::RenderLayerCompositor::computeCompositingRequirements): In several places,
use willBeComposited rather than calling needsToBeComposited(), because it avoids
recomputing state that we know already (but assert that we're getting it right).
When we're assessing the root layer in post-order, see if we have any child layers that
are compositing, and also whether the root itself needs to composite. If neither are
true, then we can drop out of compositing mode.

(WebCore::RenderLayerCompositor::needsToBeComposited):
(WebCore::RenderLayerCompositor::requiresCompositingLayer): Move the
"inCompositingMode() && layer->isRootLayer()" test out of requiresCompositingLayer()
and into needsToBeComposited() so that we can call requiresCompositingLayer() separately
on the root layer above.

2:33 PM Changeset in webkit [56016] by eric@webkit.org

1 edit
1 add in trunk/WebCore

2010-03-15 Leandro Pereira <leandro@profusion.mobi>

Reviewed by Kenneth Rohde Christiansen.

Add EFL port files to platform/efl.
http://webkit.org/b/35888

platform/efl/SoundEfl.cpp: Added.

2:21 PM Changeset in webkit [56015] by kenneth@webkit.org

2 edits in trunk/JavaScriptCore

Add a long long version of abs() for MSVC.

Reviewed by Adam Roben.

wtf/MathExtras.h:

(abs):

2:02 PM Changeset in webkit [56014] by mrowe@apple.com

2 edits in trunk/WebKitTools

Add a new build slave to replace the existing SnowLeopard Leaks build slave which
appears to be suffering a slow and painful death at the hands of its graphics hardware.

BuildSlaveSupport/build.webkit.org-config/config.json:

2:01 PM Changeset in webkit [56013] by Simon Fraser

19 edits
2 adds in trunk/LayoutTests

2010-03-15 Simon Fraser <Simon Fraser>

Rubber-stamped by Dan Bernstein.

Update some pixel results for composting tests; some were incorrect, and others had minor
pixel differences.

platform/mac/compositing/color-matching/image-color-matching-expected.checksum:
platform/mac/compositing/color-matching/image-color-matching-expected.png:
platform/mac/compositing/direct-image-compositing-expected.checksum:
platform/mac/compositing/direct-image-compositing-expected.png:
platform/mac/compositing/overflow/overflow-scroll-expected.checksum:
platform/mac/compositing/overflow/overflow-scroll-expected.png:
platform/mac/compositing/reflections/animation-inside-reflection-expected.checksum:
platform/mac/compositing/reflections/animation-inside-reflection-expected.png:
platform/mac/compositing/reflections/load-video-in-reflection-expected.checksum:
platform/mac/compositing/reflections/load-video-in-reflection-expected.png:
platform/mac/compositing/reflections/nested-reflection-animated-expected.checksum:
platform/mac/compositing/reflections/nested-reflection-animated-expected.png:
platform/mac/compositing/reflections/nested-reflection-transition-expected.checksum:
platform/mac/compositing/reflections/nested-reflection-transition-expected.png:
platform/mac/compositing/reflections/reflection-on-composited-expected.checksum:
platform/mac/compositing/reflections/reflection-on-composited-expected.png:
platform/mac/compositing/repaint/become-overlay-composited-layer-expected.checksum: Added.
platform/mac/compositing/repaint/become-overlay-composited-layer-expected.png: Added.
platform/mac/compositing/repaint/layer-repaint-rects-expected.checksum:
platform/mac/compositing/repaint/layer-repaint-rects-expected.png:

1:31 PM Changeset in webkit [56012] by enrica@apple.com

18 edits
4 adds in trunk

WebCore: For continuous scrolling devices on the Mac (trackpads and Mighty/Magic
Mice), set the number of wheel ticks equal to the atomic increment of
the device: a pixel. This ensures that any scrolling action will
generate at least one wheel tick, regardless of the speed/length of
the gesture.

Reviewed by John Sullivan.

https://bugs.webkit.org/show_bug.cgi?id=29601
<rdar://problem/7453254>

Tests: fast/events/continuous-platform-wheelevent-in-scrolling-div.html

fast/events/platform-wheelevent-in-scrolling-div.html

platform/mac/WebCoreSystemInterface.h: Modify method signature.
platform/mac/WebCoreSystemInterface.mm: Ditto.
platform/mac/WheelEventMac.mm:

(WebCore::PlatformWheelEvent::PlatformWheelEvent): Call into
WebKitSystemInterface to determine both wheelTicksX/Y and deltaX/Y.
WKSI will query the event system for number of wheel ticks and
pixels/lines scrolled based on the device type.

WebKit/mac: Updated call to WKGetWheelEventDeltas() to match new method signature.

Reviewed by John Sullivan.

https://bugs.webkit.org/show_bug.cgi?id=29601
<rdar://problem/7453254>

WebView/WebDynamicScrollBarsView.mm:

(-[WebDynamicScrollBarsView scrollWheel:]):

WebKitLibraries: Added two new output arguments to WKGetWheelEventDeltas() to return
the number of scroll wheel ticks in the x and y directions.

Reviewed by John Sullivan.

https://bugs.webkit.org/show_bug.cgi?id=29601.
<rdar://problem/7453254>

WebKitSystemInterface.h:
libWebKitSystemInterfaceLeopard.a:
libWebKitSystemInterfaceSnowLeopard.a:
libWebKitSystemInterfaceTiger.a:

LayoutTests: These tests verify that scrollwheel events (both continuous and
non-continuous) generate the expected pixel deltas in scrollable
regions, and also generate DOM mousewheel events with expected
wheelDelta values.

Reviewed by John Sullivan.

https://bugs.webkit.org/show_bug.cgi?id=29601
<rdar://problem/7453254>

fast/events/continuous-platform-wheelevent-in-scrolling-div-expected.txt: Added.
fast/events/continuous-platform-wheelevent-in-scrolling-div.html: Added.
fast/events/platform-wheelevent-in-scrolling-div-expected.txt: Added.
fast/events/platform-wheelevent-in-scrolling-div.html: Added.
fast/events/wheelevent-in-scrolling-div-expected.txt: Rebased

expected results due to change in test output formatting.

fast/events/wheelevent-in-scrolling-div.html: Modified to use common

js logging and assertion functions.

platform/gtk/Skipped: DRT support needed by tests not yet implemented

in GTK port. See https://bugs.webkit.org/show_bug.cgi?id=36003.

platform/mac-tiger/Skipped: DRT support needed by tests not possible

to implement in Tiger.

platform/qt/Skipped: DRT support for tests not yet implemented in Qt

port. See https://bugs.webkit.org/show_bug.cgi?id=36004.

platform/win/Skipped: DRT support for tests not yet implemented in

Windows port. See https://bugs.webkit.org/show_bug.cgi?id=36002.

1:30 PM Changeset in webkit [56011] by eric@webkit.org

3 edits in trunk/WebKit/chromium

2010-03-15 Marcus Bulach <bulach@chromium.org>

Reviewed by Jeremy Orlow.

Send the frame URL on GeolocationServiceBridgeImpl::startUpdating.
https://bugs.webkit.org/show_bug.cgi?id=36012

public/GeolocationServiceBridgeChromium.h:
src/GeolocationServiceBridgeChromium.cpp: (WebKit::GeolocationServiceBridgeImpl::startUpdating):

1:18 PM Changeset in webkit [56010] by Philippe Normand

3 edits in trunk/WebCore

2010-03-15 Philippe Normand <pnormand@igalia.com>

Reviewed by Gustavo Noronha Silva.

[GStreamer] duration query optimizations
https://bugs.webkit.org/show_bug.cgi?id=36116

Don't reattempt duration queries that previously failed and cache
media duration only if it's known.

platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivate::MediaPlayerPrivate): (WebCore::MediaPlayerPrivate::duration): (WebCore::MediaPlayerPrivate::updateStates): (WebCore::MediaPlayerPrivate::durationChanged):
platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:

1:11 PM Changeset in webkit [56009] by Philippe Normand

3 edits in trunk/WebCore

2010-03-15 Philippe Normand <pnormand@igalia.com>

Reviewed by Gustavo Noronha Silva.

[GStreamer] updateStates called for all elements posting a state-change
https://bugs.webkit.org/show_bug.cgi?id=36115

platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: (WebCore::mediaPlayerPrivateMessageCallback): Update player state only for state-change messages coming from playbin2 directly.
platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h: (WebCore::MediaPlayerPrivate::pipeline): public accessor for the playbin element.

1:10 PM Changeset in webkit [56008] by sullivan@apple.com

5 edits in trunk/WebKit/mac

-[WebFrame setAlwaysHideHorizontal/VerticalScroller:] prevents keyboard scrolling
<https://bugs.webkit.org/show_bug.cgi?id=36125>

Reviewed by Adam Roben.

WebView/WebDynamicScrollBarsView.h:

Added instance variables horizontalScrollingAllowedButScrollerHidden and
verticalScrollingAllowedButScrollerHidden. Renamed instance variables
hideHorizontal/VerticalScroller to alwaysHideHorizontal/VerticalScroller for clarity.
Declared methods -horizontalScrollingAllowed and -verticalScrollingAllowed.
Added comments.

WebView/WebDynamicScrollBarsView.mm:

(-[WebDynamicScrollBarsView setAlwaysHideHorizontalScroller:]):
Updated for instance variable renaming.
(-[WebDynamicScrollBarsView setAlwaysHideVerticalScroller:]):
Ditto.
(-[WebDynamicScrollBarsView horizontalScrollingAllowed]):
New method, returns YES if the scroller is showing or the only reason that the scroller
is not showing is that setAlwaysHideHorizontalScrolling has been called.
(-[WebDynamicScrollBarsView verticalScrollingAllowed]):
New method, returns YES if the scroller is showing or the only reason that the scroller
is not showing is that setAlwaysHideVerticalScrolling has been called.
(-[WebDynamicScrollBarsView updateScrollers]):
Updated for instance variable renamings. Now updates horizontalScrollingAllowedButScrollerHidden
and verticalScrollingAllowedButScrollerHidden. Now takes the always-hidden state into account
in the early-return code path, to avoid taking it into account twice in the regular code path.

WebView/WebFrameView.mm:

(-[WebFrameView _scrollToBeginningOfDocument]):
Use _isScrollable instead of _hasScrollBars.
(-[WebFrameView _scrollToEndOfDocument]):
Ditto.
(-[WebFrameView scrollToBeginningOfDocument:]):
Use _largestScrollableChild instead of _largestChildWithScrollBars.
(-[WebFrameView scrollToEndOfDocument:]):
Ditto.
(-[WebFrameView _pageVertically:]):
Use _isScrollable and _largestScrollableChild instead of _hasScrollBars
and _largestChildWithScrollBars.
(-[WebFrameView _pageHorizontally:]):
Ditto.
(-[WebFrameView _scrollLineVertically:]):
Ditto.
(-[WebFrameView _scrollLineHorizontally:]):
Ditto.
(-[WebFrameView keyDown:]):
Use _largestScrollableChild instead of _largestChildWithScrollBars.
(-[WebFrameView _isScrollable]):
New method, calls -[WebDynamicScrollBarsView horizontalScrollingAllowed] and
-[WebDynamicScrollBarsView verticalScrollingAllowed]
(-[WebFrameView _largestScrollableChild]):
New method, like _largestChildWithScrollBars but uses _isScrollable.
(-[WebFrameView _hasScrollBars]):
Added a comment that this is no longer used by Safari, and can thus probably be
deleted once we no longer want to support it for nightly build compatibility with
old versions of Safari.
(-[WebFrameView _largestChildWithScrollBars]):
Ditto.

WebView/WebFrameViewPrivate.h:

Declared -_isScrollable and -_largestScrollableChild. Added comments to
_hasScrollBars and _largestChildWithScrollBars saying that they are no longer
used by Safari, and can thus probably be deleted once we no longer want to
support them for nightly build compatibility with old versions of Safari.

1:08 PM Changeset in webkit [56007] by pkasting@chromium.org

10 edits in trunk/WebCore

Clean up more bits of the open-source image decoders. In addition to
simplifying things somewhat, this makes all the decoders the same in
terms of how they construct "image reader" subclasses and init scale
data.

Reviewed by Adam Barth.

https://bugs.webkit.org/show_bug.cgi?id=36040

No functional change, so no tests.

platform/image-decoders/ImageDecoder.h: Reorder a few declarations to try and group/order members slightly better.

(WebCore::ImageDecoder::ImageDecoder):

platform/image-decoders/gif/GIFImageDecoder.cpp: Move reader construction into decode(). Prep scale data in setSize(). Remove useless comment.

(WebCore::GIFImageDecoder::setData):
(WebCore::GIFImageDecoder::setSize):
(WebCore::GIFImageDecoder::frameBufferAtIndex):
(WebCore::GIFImageDecoder::decode):

platform/image-decoders/gif/GIFImageDecoder.h: Prep scale data in setSize().
platform/image-decoders/gif/GIFImageReader.cpp: Prep scale data in setSize().

(GIFImageReader::read):

platform/image-decoders/ico/ICOImageDecoder.cpp: Shorten code.

(WebCore::ICOImageDecoder::setSize):

platform/image-decoders/jpeg/JPEGImageDecoder.cpp: Fix style. Move reader construction into decode().

(WebCore::JPEGImageReader::close):
(WebCore::JPEGImageReader::skipBytes):
(WebCore::JPEGImageDecoder::decode):

platform/image-decoders/jpeg/JPEGImageDecoder.h: Move reader construction into decode().

(WebCore::JPEGImageDecoder::filenameExtension):

platform/image-decoders/png/PNGImageDecoder.cpp: Move reader construction into decode(). Track completion on decoder, not reader. Prep scale data in setSize(). Remove useless comment.

(WebCore::PNGImageReader::PNGImageReader):
(WebCore::PNGImageReader::close):
(WebCore::PNGImageReader::decode):
(WebCore::PNGImageDecoder::setSize):
(WebCore::PNGImageDecoder::frameBufferAtIndex):
(WebCore::PNGImageDecoder::headerAvailable):
(WebCore::PNGImageDecoder::pngComplete):
(WebCore::PNGImageDecoder::decode):

platform/image-decoders/png/PNGImageDecoder.h: Move reader construction into decode(). Track completion on decoder, not reader. Prep scale data in setSize().

(WebCore::PNGImageDecoder::filenameExtension):
(WebCore::PNGImageDecoder::isComplete):

1:00 PM Changeset in webkit [56006] by Philippe Normand

2 edits in trunk/WebCore

2010-03-15 Philippe Normand <pnormand@igalia.com>

Reviewed by Gustavo Noronha Silva.

[GTK] video playback position query flood when mouse over the video element
https://bugs.webkit.org/show_bug.cgi?id=35333

Don't trigger a position query only to know which play/pause
button to display.

platform/gtk/RenderThemeGtk.cpp: (WebCore::RenderThemeGtk::paintMediaPlayButton):

12:57 PM Changeset in webkit [56005] by dpranke@chromium.org

2 edits in trunk/WebKitTools

2010-03-15 Dirk Pranke <dpranke@chromium.org>

Reviewed by Alexey Proskuryakov.

Fix a minor case where we'd deference a null pointer if we tried
to run new-run-webkit-tests on an unsupported platform (e.g.
Cygwin's python version).

https://bugs.webkit.org/show_bug.cgi?id=36076

Scripts/webkitpy/layout_tests/port/factory.py:

10:27 AM Changeset in webkit [56004] by jianli@chromium.org

5 edits
1 add in trunk/WebCore

[v8] Add V8 bindings for DOMFormData.
https://bugs.webkit.org/show_bug.cgi?id=36026

Reviewed by Nate Chapin.

Test: http/tests/local/send-form-data.html

Android.v8bindings.mk:
WebCore.gypi:
bindings/v8/V8Index.h:
bindings/v8/custom/V8DOMFormDataCustom.cpp: Added.
bindings/v8/custom/V8XMLHttpRequestCustom.cpp:

(WebCore::V8XMLHttpRequest::sendCallback):

10:27 AM Changeset in webkit [56003] by jianli@chromium.org

29 edits
6 adds in trunk

WebCore: Add DOMFormData.idl to expose FormData interface.
https://bugs.webkit.org/show_bug.cgi?id=36024

Reviewed by Sam Weinig.

The implementation is based on XMLHttpRequest 2 spec:
http://dev.w3.org/2006/webapi/XMLHttpRequest-2/#formdata

Test: http/tests/local/send-form-data.html

Android.derived.jscbindings.mk:
Android.derived.v8bindings.mk:
Android.jscbindings.mk:
DerivedSources.cpp:
DerivedSources.make:
GNUmakefile.am:
WebCore.pri:
WebCore.vcproj/WebCore.vcproj:
WebCore.xcodeproj/project.pbxproj:
bindings/js/JSDOMFormDataCustom.cpp: Added.
bindings/js/JSXMLHttpRequestCustom.cpp:

(WebCore::JSXMLHttpRequest::send):

bindings/scripts/CodeGeneratorJS.pm:
html/DOMFormData.idl: Added.
page/DOMWindow.idl:

LayoutTests: Add DOMFormData.idl to expose FormData interface
https://bugs.webkit.org/show_bug.cgi?id=36024

Reviewed by Sam Weinig.

Add a layout test to test sending FormData via XMLHttpRequest. Also
changed all test results that are affected by exposing FormData.

fast/dom/Window/window-properties-expected.txt:
fast/dom/Window/window-property-descriptors-expected.txt:
fast/dom/constructed-objects-prototypes-expected.txt:
fast/dom/prototype-inheritance-2-expected.txt:
fast/dom/prototype-inheritance-expected.txt:
fast/js/global-constructors-expected.txt:
http/tests/local/resources/send-form-data.js: Added.
http/tests/local/send-form-data-expected.txt: Added.
http/tests/local/send-form-data.html: Added.
http/tests/xmlhttprequest/resources/multipart-post-echo.php: Added.
platform/gtk/Skipped:
platform/gtk/fast/dom/Window/window-properties-expected.txt:
platform/qt/Skipped:
platform/qt/fast/dom/Window/window-properties-expected.txt:
platform/qt/fast/dom/Window/window-property-descriptors-expected.txt:
platform/qt/fast/dom/prototype-inheritance-expected.txt:
platform/qt/fast/js/global-constructors-expected.txt:
platform/win/Skipped:

10:14 AM Changeset in webkit [56002] by eric@webkit.org

14 edits in trunk

2010-03-15 Patrik Persson <patrik.j.persson@ericsson.com>

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=32369

Revised test of storage/databases in sandboxed iframes.

Verify that SECURITY_ERR is raised on access to
window.localStorage or window.openDatabase(). Also verify that
window.sessionStorage is now allowed in sandboxed iframes.

WebKit would previously return null references in these cases. The
new behavior is in accordance with HTML5:

http://dev.w3.org/html5/webstorage/ (sections 4.2 and 4.3)
http://dev.w3.org/html5/webdatabase/ (section 4.1)
http://www.mail-archive.com/whatwg@lists.whatwg.org/msg19786.html

fast/frames/resources/sandboxed-iframe-storage-disallowed.html: expect exceptions, not null
fast/frames/sandboxed-iframe-storage-expected.txt: expect exceptions, not null

2010-03-15 Patrik Persson <patrik.j.persson@ericsson.com>

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=32369

Revise iframe sandbox behavior to match the updated HTML5 spec.

Enables window.sessionStorage in sandboxed iframes.

Raises SECURITY_ERR exceptions when window.localStorage or window.openDatabase() is blocked by iframe sandboxing.

Note: window.sessionStorage does not raise exceptions.

WebKit would previously return null references in these cases. The
new behavior is in accordance with HTML5:

http://dev.w3.org/html5/webstorage/ (sections 4.2 and 4.3)
http://dev.w3.org/html5/webdatabase/ (section 4.1)
http://www.mail-archive.com/whatwg@lists.whatwg.org/msg19786.html

inspector/InspectorController.cpp: (WebCore::InspectorController::selectDOMStorage): exception handling
inspector/InspectorDOMStorageResource.cpp: (WebCore::InspectorDOMStorageResource::handleEvent): exception handling
page/DOMWindow.cpp: (WebCore::DOMWindow::sessionStorage): re-enabled in iframe sandbox (WebCore::DOMWindow::localStorage): raise exception rather than return null (WebCore::DOMWindow::openDatabase): raise exception rather than return null
page/DOMWindow.h: added exceptions to interface
page/DOMWindow.idl: added exceptions to interface
page/SecurityOrigin.h: (WebCore::SecurityOrigin::canAccessLocalStorage): renamed function to reflect its purpose
storage/StorageEventDispatcher.cpp: (WebCore::StorageEventDispatcher::dispatch): exception handling

2010-03-15 Patrik Persson <patrik.j.persson@ericsson.com>

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=32369

Revise iframe sandbox behavior to match the updated HTML5 spec.

Enables window.sessionStorage in sandboxed iframes.

Raises SECURITY_ERR exceptions when window.localStorage or window.openDatabase() is blocked by iframe sandboxing.

Note: window.sessionStorage does not raise exceptions.

WebKit would previously return null references in these cases. The
new behavior is in accordance with HTML5:

http://dev.w3.org/html5/webstorage/ (sections 4.2 and 4.3)
http://dev.w3.org/html5/webdatabase/ (section 4.1)
http://www.mail-archive.com/whatwg@lists.whatwg.org/msg19786.html

src/StorageAreaProxy.cpp: (WebCore::StorageAreaProxy::storageEvent): exception handling
src/StorageEventDispatcherImpl.cpp: (WebCore::StorageEventDispatcherImpl::dispatchStorageEvent): exception handling

9:41 AM Changeset in webkit [56001] by Darin Adler

3 edits in trunk/WebKitTools

Tell Subversion about more directories that expect to have .pyc files.

Scripts/webkitpy/layout_tests: Added property svn:ignore.
Scripts/webkitpy/layout_tests/port: Added property svn:ignore.

9:33 AM Changeset in webkit [56000] by eric@webkit.org

2 edits in trunk/JavaScriptCore

2010-03-15 Gabor Loki <loki@webkit.org>

Reviewed by Gavin Barraclough.

Combine ctiTrampolines on ARM and Thumb-2
https://bugs.webkit.org/show_bug.cgi?id=36014

jit/JITStubs.cpp: (JSC::JITThunks::JITThunks):

9:22 AM Changeset in webkit [55999] by apavlov@chromium.org

9 edits
1 add in trunk/WebCore

2010-03-15 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: Implement a progress indicator in the Audits panel
when resources are reloading
https://bugs.webkit.org/show_bug.cgi?id=35971

English.lproj/localizedStrings.js:
GNUmakefile.am:
WebCore.gypi:
inspector/front-end/AuditLauncherView.js: (WebInspector.AuditLauncherView.prototype.updateResourceTrackingState): (WebInspector.AuditLauncherView.prototype.get totalResources): (WebInspector.AuditLauncherView.prototype.set totalResources): (WebInspector.AuditLauncherView.prototype.get loadedResources): (WebInspector.AuditLauncherView.prototype.set loadedResources): (WebInspector.AuditLauncherView.prototype._resetResourceCount): (WebInspector.AuditLauncherView.prototype.resourceStarted): (WebInspector.AuditLauncherView.prototype.resourceFinished): (WebInspector.AuditLauncherView.prototype.reset): (WebInspector.AuditLauncherView.prototype._setAuditRunning): (WebInspector.AuditLauncherView.prototype._launchButtonClicked): (WebInspector.AuditLauncherView.prototype._createCategoryElement): (WebInspector.AuditLauncherView.prototype._createLauncherUI): (WebInspector.AuditLauncherView.prototype._updateResourceProgress): (WebInspector.AuditLauncherView.prototype._updateButton):
inspector/front-end/AuditsPanel.js: (WebInspector.AuditsPanel.prototype.resourceStarted): (WebInspector.AuditsPanel.prototype.resourceFinished): (WebInspector.AuditsPanel.prototype.reset):
inspector/front-end/Images/spinner.gif: Added.
inspector/front-end/WebKit.qrc:
inspector/front-end/audits.css: (.audit-launcher-view .resource-progress > img):
inspector/front-end/inspector.js: (WebInspector.updateResource):

8:55 AM QtWebKitBackportingFixes edited by Laszlo Gombos

(diff)

8:54 AM Changeset in webkit [55998] by eric@webkit.org

4 edits in trunk

2010-03-15 Tony Chang <tony@chromium.org>

Reviewed by Darin Adler.

option-pageup/down should move cursor on chromium mac
https://bugs.webkit.org/show_bug.cgi?id=36108

Remove waitUntilDone/notifyDone from the layout test, it's not needed
and causes timeouts on failure.

editing/input/option-page-up-down.html:

2010-03-15 Tony Chang <tony@chromium.org>

Reviewed by Darin Adler.

option-pageup/down should move cursor on chromium mac
https://bugs.webkit.org/show_bug.cgi?id=36108

src/EditorClientImpl.cpp: (WebKit::):

8:40 AM Changeset in webkit [55997] by sullivan@apple.com

5 edits in trunk/WebKit/mac

Method name and parameter name mistakes from recent SPI addition
<https://bugs.webkit.org/show_bug.cgi?id=36119>

Reviewed by Dan Bernstein.

WebView/WebDynamicScrollBarsView.h:

Renamed instance variable and method name from "setAllowXXX" to "setAllowsXXX".

WebView/WebDynamicScrollBarsView.mm:

(-[WebDynamicScrollBarsView setAllowsScrollersToOverlapContent:]):
Updated for renamed instance variable and method.
(-[WebDynamicScrollBarsView setAlwaysHideHorizontalScroller:]):
Changed parameter name from shouldBeVisible to shouldBeHidden.
(-[WebDynamicScrollBarsView setAlwaysHideVerticalScroller:]):
Ditto.
(-[WebDynamicScrollBarsView contentViewFrame]):
Updated for renamed instance variable.
(-[WebDynamicScrollBarsView tile]):
Ditto.
(-[WebDynamicScrollBarsView reflectScrolledClipView:]):
Ditto.

WebView/WebFrame.mm:

(-[WebFrame setAllowsScrollersToOverlapContent:]):
Renamed method from setAllowXXX, and updated for same change in WebDynamicScrollBarsView.

WebView/WebFramePrivate.h:

Renamed method name from "setAllowXXX" to "setAllowsXXX".

8:34 AM Changeset in webkit [55996] by Philippe Normand

3 edits in trunk/WebCore

2010-03-15 Philippe Normand <pnormand@igalia.com>

Reviewed by Gustavo Noronha Silva.

[GStreamer] replace g_idle_add / g_timeout_add calls with Timers in the gstreamer player
https://bugs.webkit.org/show_bug.cgi?id=35735

Replaced g_idle_add calls with Timers immediately started once
only. The g_timeout_add was replaced by a periodic Timer.

platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivate::MediaPlayerPrivate): (WebCore::MediaPlayerPrivate::~MediaPlayerPrivate): (WebCore::MediaPlayerPrivate::volumeChangedTimerFired): (WebCore::MediaPlayerPrivate::volumeChanged): (WebCore::MediaPlayerPrivate::processBufferingStats): (WebCore::MediaPlayerPrivate::fillTimerFired): (WebCore::MediaPlayerPrivate::maxTimeLoaded): (WebCore::MediaPlayerPrivate::updateStates): (WebCore::MediaPlayerPrivate::muteChangedTimerFired): (WebCore::MediaPlayerPrivate::muteChanged):
platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:

8:20 AM Changeset in webkit [55995] by kov@webkit.org

5 edits in trunk

2010-03-12 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Reviewed by Eric Carlson.

media/video-preload.html fails
https://bugs.webkit.org/show_bug.cgi?id=35793

Only effectively load, and start buffering when playing, or when
the preload attribute is set.

Test: media/video-preload.html

platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivate::MediaPlayerPrivate): (WebCore::MediaPlayerPrivate::load): (WebCore::MediaPlayerPrivate::commitLoad): (WebCore::MediaPlayerPrivate::prepareToPlay): (WebCore::MediaPlayerPrivate::setPreload):
platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:

7:46 AM Changeset in webkit [55994] by Laszlo Gombos

2 edits in trunk/WebKit/qt

2010-03-15 Laszlo Gombos <Laszlo Gombos>

Unreviewed.

[Qt] Build fix if TILED_BACKING_STORE is disabled.

Api/qwebframe.cpp: (QWebFramePrivate::renderContentsLayerAbsoluteCoords):

7:34 AM Changeset in webkit [55993] by eric@webkit.org

5 edits
2 adds in trunk

2010-03-15 Shu Chang <Chang.Shu@nokia.com>

Reviewed by Holger Freyther.

[Qt] Change and add expected results after the fix and also remove the test from Skipped.
https://bugs.webkit.org/show_bug.cgi?id=36060

platform/qt/Skipped:
platform/qt/fast/canvas/fillrect-gradient-zero-stops-expected.checksum: Added.
platform/qt/fast/canvas/fillrect-gradient-zero-stops-expected.png: Added.
platform/qt/fast/canvas/fillrect-gradient-zero-stops-expected.txt:

2010-03-15 Shu Chang <Chang.Shu@nokia.com>

Reviewed by Holger Freyther.

[Qt] The behavior of QGradient with no stops is defined differently from HTML5 spec,
where the latter requires the gradient to be transparent black. Explicitly added a
transparent black color stop to match the HTML5 behavior.
https://bugs.webkit.org/show_bug.cgi?id=36060

platform/graphics/qt/GradientQt.cpp: (WebCore::Gradient::platformGradient):

7:13 AM Changeset in webkit [55992] by tonikitoo@webkit.org

2 edits in trunk/WebCore

Some minor code clean ups in SpatialNavigation.cpp

Rubber-stamped by Holger Freyther.
Patch by Antonio Gomes <tonikitoo@webkit.org>

page/SpatialNavigation.cpp:

(WebCore::distanceInDirection):
(WebCore::deflateIfOverlapped):

6:02 AM Changeset in webkit [55991] by pfeldman@chromium.org

2 edits in trunk/WebCore

2010-03-13 Ilya Tikhonovsky <loislo@chromium.org>

Reviewed by Timothy Hatcher.

WebInspector: Position of GraphBar elements is calculating more carefully
and they fully visible at the bottom of Timeline panel.

http://bugs.webkit.org/show_bug.cgi?id=35966

inspector/front-end/TimelinePanel.js: (WebInspector.TimelineRecordGraphRow.prototype.update):

2:10 AM Changeset in webkit [55990] by eric@webkit.org

6 edits in trunk

2010-03-15 MORITA Hajime <morrita@google.com>

Reviewed by Alexey Proskuryakov.

Selection.modify extends too far with 'lineboundary'.
https://bugs.webkit.org/show_bug.cgi?id=33413

editing/selection/extend-selection-expected.txt:
platform/win/editing/selection/extend-selection-expected.txt: Updated result to correct expectation that described the wrong behaviour for the selection expansion with 'lineboundary' granularity.

2010-03-15 MORITA Hajime <morrita@google.com>

Reviewed by Alexey Proskuryakov.

Selection.modify extends too far with 'lineboundary'.
https://bugs.webkit.org/show_bug.cgi?id=33413

Selection.modify() with 'lineboundary' granularity implies just
"Go to the end of the line", unlike selection expansion with
other type of granularities. This change handled LineGranularity
as special case, to look-up end of line with UPSTREAM affinity.
Doing this prevents look-up algorithm to go next line.

Test: editing/selection/extend-selection-expected.txt

dom/Position.cpp: (WebCore::Position::getInlineBoxAndOffset): Handled an edge case for node look-up with UPSTREAM.
editing/SelectionController.cpp: (WebCore::SelectionController::modifyExtendingForward): Added UPSTREAM tweak for the case for LineGranularity.

1:34 AM Changeset in webkit [55989] by Philippe Normand

2 edits in trunk/WebKit/gtk

2010-03-09 Philippe Normand <pnormand@igalia.com>

Reviewed by Holger Freyther.

[GTK] GTK_WIDGET_IS_SENSITIVE is deprecated in GTK+ 2.20
https://bugs.webkit.org/show_bug.cgi?id=35909

webkit/webkitwebview.cpp: GTK_WIDGET_IS_SENSITIVE has been deprecated in gtk 2.20. Use gtk_widget_is_sensitive when available.

1:33 AM Changeset in webkit [55988] by yuzo@google.com

6 edits
5 adds in trunk

2010-03-14 Yuzo Fujishima <yuzo@google.com>

Reviewed by Shinichiro Hamaji.

Always call PrintContext.end() from PrintContext::pageNumberForElement().

Without this change, WebKit remains in printing mode after determining the page number if the specified element is found.

https://bugs.webkit.org/show_bug.cgi?id=36049

platform/gtk/Skipped:
platform/mac/printing/return-from-printing-mode-expected.checksum: Added.
platform/mac/printing/return-from-printing-mode-expected.png: Added.
platform/mac/printing/return-from-printing-mode-expected.txt: Added.
platform/qt/Skipped:
platform/win/Skipped:
printing/return-from-printing-mode.html: Added.

2010-03-14 Yuzo Fujishima <yuzo@google.com>

Reviewed by Shinichiro Hamaji.

Always call PrintContext.end() from PrintContext::pageNumberForElement().

Without this change, WebKit remains in printing mode after determining the page number if the specified element is found.

https://bugs.webkit.org/show_bug.cgi?id=36049

Test: printing/return-from-printing-mode.html

page/PrintContext.cpp: (WebCore::PrintContext::pageNumberForElement):

1:19 AM Changeset in webkit [55987] by Philippe Normand

2 edits in trunk/WebCore

2010-03-11 Philippe Normand <pnormand@igalia.com>

Reviewed by Gustavo Noronha Silva.

[GStreamer] progressTimer never stopped after EOS
https://bugs.webkit.org/show_bug.cgi?id=36007

Mark the pipeline as paused only if playback hasn't ended
yet. When didEnd() is triggered, the pipeline is paused (but
paused() still returns false) and a timeupdate event is fired,
those 2 conditions allow the HTMLMediaElement to stop the
progressTimer (in updatePlayerState, via mediaPlayerTimeChanged).

platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivate::updateStates):

12:28 AM Changeset in webkit [55986] by eric@webkit.org

1 edit
5 adds in trunk/WebKitTools

2010-03-15 Adam Barth <abarth@webkit.org>

Reviewed by Darin Adler.

Operational scripts from running the EWS
https://bugs.webkit.org/show_bug.cgi?id=36097

These are the scripts I use to manage the EWS on EC2. If someone other
than me wants to run the EWS, these scripts might be helpful.

EWSTools/boot.sh: Added.
EWSTools/create-webkit-git: Added.
EWSTools/screen-config: Added.
EWSTools/start-queue.sh: Added.

12:04 AM Changeset in webkit [55985] by Darin Adler

2 edits in trunk/WebKit/mac

2010-03-14 Darin Adler <Darin Adler>

Reviewed by Mark Rowe.

Remove unneeded dependency on non-string identifier for an NSTableColumn
https://bugs.webkit.org/show_bug.cgi?id=36106

WebView/WebTextCompletionController.mm: (-[WebTextCompletionController _buildUI]): Use init instead of initWithIdentifier: because the table has only one column and that column does not need an identifier.

Mar 14, 2010:

1:51 AM QtWebKitJournal edited by Simon Hausmann: (diff)

Mar 13, 2010:

11:19 PM Changeset in webkit [55984] by mjs@apple.com

1 edit
3 adds in trunk/WebKitSite

Added canvas perf demo for whatwg.

demos/canvas-perf: Added.
demos/canvas-perf/canvas.html: Added.
demos/canvas-perf/kraken.jpg: Added.

11:16 PM Changeset in webkit [55983] by abarth@webkit.org

3 edits in trunk/WebKitTools

2010-03-14 Adam Barth <abarth@webkit.org>

Unreviewed.

Fix the webkit-patch bots. Turns out they need the path of the main
script to run properly.

Scripts/webkit-patch:
Scripts/webkitpy/patch/patcher.py:

10:58 PM Changeset in webkit [55982] by Darin Adler

5 edits in trunk/WebKitTools

Tell Subversion about more directories that expect to have .pyc files.

Scripts/webkitpy/init: Added property svn:ignore.
Scripts/webkitpy/patch: Added property svn:ignore.
Scripts/webkitpy/thirdparty: Added property svn:ignore.
Scripts/webkitpy/thirdparty/autoinstalled: Added property svn:ignore.

6:28 PM Changeset in webkit [55981] by eric@webkit.org

5 edits in trunk

2010-03-14 Chang Shu <chang.shu@nokia.com>

Reviewed by Simon Hausmann.

[Qt] [Symbian] Added block for ENABLE_SYMBIAN_DIALOG_PROVIDERS
on Symbian platform.
https://bugs.webkit.org/show_bug.cgi?id=35919

WebCore.pro:

2010-03-14 Chang Shu <chang.shu@nokia.com>

Reviewed by Simon Hausmann.

[Qt] [Symbian] Use Symbian native dialog providers for combo pupups.
https://bugs.webkit.org/show_bug.cgi?id=35919

WebCoreSupport/QtFallbackWebPopup.cpp: (WebCore::QtFallbackWebPopup::show): (WebCore::ResetAndDestroy): (WebCore::QtFallbackWebPopup::showS60BrowserDialog):
WebCoreSupport/QtFallbackWebPopup.h:

6:00 PM Changeset in webkit [55980] by yael.aharon@nokia.com

28 edits
16 adds in trunk

Support for HTMLProgressElement
https://bugs.webkit.org/show_bug.cgi?id=35937

Reviewed by Darin Adler.

WebCore:

Added support for HTMLProgressElement.
This implementation is enabled only for Qt, because only RenderThemeQt
was modified to actually draw the progress element.
The labels attribute of the progress element will be implemented in a
separate patch.

Tests: fast/dom/HTMLProgressElement/progress-element.html

fast/dom/HTMLProgressElement/set-progress-properties.html

DerivedSources.cpp:
DerivedSources.make:
GNUmakefile.am:
WebCore.gypi:
WebCore.pri:
WebCore.pro:
WebCore.vcproj/WebCore.vcproj:
WebCore.xcodeproj/project.pbxproj:
css/CSSPrimitiveValueMappings.h:

(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):

css/CSSSelector.cpp:

(WebCore::CSSSelector::extractPseudoType):

css/CSSValueKeywords.in:
css/html.css:
html/HTMLElement.cpp:

(WebCore::inlineTagList):

html/HTMLElementsAllInOne.cpp:
html/HTMLFormControlElement.cpp:
html/HTMLFormControlElement.h:
html/HTMLProgressElement.cpp: Added.
html/HTMLProgressElement.h: Added.
html/HTMLProgressElement.idl: Added.
html/HTMLTagNames.in:
page/DOMWindow.idl:
platform/ThemeTypes.h:
platform/qt/RenderThemeQt.cpp:
platform/qt/RenderThemeQt.h:
rendering/RenderObject.h:
rendering/RenderProgress.cpp: Added.
rendering/RenderProgress.h: Added.
rendering/RenderTheme.cpp:
rendering/RenderTheme.h:

LayoutTests:

fast/dom/HTMLProgressElement: Added.
fast/dom/HTMLProgressElement/progress-element.html: Added.
fast/dom/HTMLProgressElement/script-tests: Added.
fast/dom/HTMLProgressElement/script-tests/TEMPLATE.html: Added.
fast/dom/HTMLProgressElement/script-tests/set-progress-properties.js: Added.
fast/dom/HTMLProgressElement/set-progress-properties.html: Added.
platform/gtk/Skipped:
platform/mac/Skipped:
platform/qt/fast/dom/HTMLProgressElement: Added.
platform/qt/fast/dom/HTMLProgressElement/progress-element-expected.checksum: Added.
platform/qt/fast/dom/HTMLProgressElement/progress-element-expected.png: Added.
platform/qt/fast/dom/HTMLProgressElement/progress-element-expected.txt: Added.
platform/qt/fast/dom/HTMLProgressElement/set-progress-properties-expected.txt: Added.

5:53 PM Changeset in webkit [55979] by Antti Koivisto

5 edits in trunk/WebKitTools

https://bugs.webkit.org/show_bug.cgi?id=35146
Support tiled backing store

Reviewed by Simon Hausmann.

QtLauncher support and build flag in build-webkit.

QtLauncher/main.cpp:

(LauncherWindow::applyPrefs):
(LauncherWindow::toggleTiledBackingStore):
(LauncherWindow::toggleResizesToContents):
(LauncherWindow::createChrome):
(LauncherApplication::handleUserOptions):

QtLauncher/webview.cpp:

(WebViewGraphicsBased::WebViewGraphicsBased):
(WebViewGraphicsBased::setResizesToContents):
(WebViewGraphicsBased::resizeEvent):

QtLauncher/webview.h:
Scripts/build-webkit:

5:51 PM Changeset in webkit [55978] by Antti Koivisto

6 edits in trunk/WebKit/qt

https://bugs.webkit.org/show_bug.cgi?id=35146
Support tiled backing store

Reviewed by Simon Hausmann.

Implements a basic tiled backing store mechanism. Tiles are created and
deleted on demand. The page content is cached to the tiles. Tile content
is kept in sync with the document. Since the backing store covers area
larger than the currently visible viewport, the document can be scrolled
quickly without having to enter rendering tree painting.

The tile management code is platform independent. This patch has simple QPixmap
based tile implementation for Qt.

The feature is behind ENABLE_TILED_BACKING_STORE flag.

Api/qgraphicswebview.cpp:

(QGraphicsWebViewPrivate::visibleRect):
(QGraphicsWebView::paint):

Api/qwebframe.cpp:

(QWebFramePrivate::renderContentsLayerAbsoluteCoords):

Api/qwebframe.h:
Api/qwebsettings.cpp:

(QWebSettingsPrivate::apply):

Api/qwebsettings.h:

5:01 PM Changeset in webkit [55977] by oliver@apple.com

7 edits in trunk

2010-03-14 Oliver Hunt <oliver@apple.com>

Reviewed by Darin Adler.

REGRESSION(r53287): drop event is not fired if dataTransfer.dropEffect is not explicitly set
https://bugs.webkit.org/show_bug.cgi?id=36095

Correct this test to cover the somewhat bizarre "correct" handling
of undefined dropEffect

fast/events/drag-and-drop-expected.txt:
fast/events/drag-and-drop.html:

2010-03-14 Oliver Hunt <oliver@apple.com>

Reviewed by Darin Adler.

REGRESSION(r53287): drop event is not fired if dataTransfer.dropEffect is not explicitly set
https://bugs.webkit.org/show_bug.cgi?id=36095

The issue here is that while dropEffect is meant to be initialized
to "none", the behaviour of the drag is differs between dragEffect
not being set and dragEffect being explicitly set to "none"

This patch corrects this behaviour by making Clipboard distinguish
between the initial "none" value of dropEffect and an explicit "none".
This alone is insufficient for correct behaviour, we also need to
resurrect the removed defaultOperationForDrag function, but we now
use the function only when dragEffect is uninitialized. There are a
few tweaks to the behaviour of the defaultOperationForDrag as well
to ensure exactly the same set of outcomes for all cases that we
may hit it.

dom/Clipboard.cpp: (WebCore::Clipboard::Clipboard): (WebCore::dragOpFromIEOp): (WebCore::Clipboard::destinationOperation):
dom/Clipboard.h: (WebCore::Clipboard::dropEffect): (WebCore::Clipboard::dropEffectIsUninitialized):
page/DragController.cpp: (WebCore::defaultOperationForDrag): (WebCore::DragController::tryDHTMLDrag):

4:40 PM Changeset in webkit [55976] by Antti Koivisto

8 edits
5 adds in trunk/WebCore

https://bugs.webkit.org/show_bug.cgi?id=35146
Support tiled backing store

Reviewed by Simon Hausmann.

WebCore.pri:
WebCore.pro:
page/Frame.cpp:

(WebCore::Frame::Frame):
(WebCore::Frame::setTiledBackingStoreEnabled):
(WebCore::Frame::tiledBackingStorePaintBegin):
(WebCore::Frame::tiledBackingStorePaint):
(WebCore::Frame::tiledBackingStorePaintEnd):
(WebCore::Frame::tiledBackingStoreContentsRect):

page/Frame.h:

(WebCore::Frame::tiledBackingStore):

page/FrameView.cpp:

(WebCore::FrameView::repaintContentRectangle):
(WebCore::FrameView::doDeferredRepaints):

page/Settings.cpp:

(WebCore::Settings::Settings):
(WebCore::Settings::setTiledBackingStoreEnabled):

page/Settings.h:

(WebCore::Settings::tiledBackingStoreEnabled):

platform/graphics/Tile.h: Added.

(WebCore::Tile::create):
(WebCore::Tile::coordinate):
(WebCore::Tile::rect):

platform/graphics/TiledBackingStore.cpp: Added.

(WebCore::TiledBackingStore::TiledBackingStore):
(WebCore::TiledBackingStore::~TiledBackingStore):
(WebCore::TiledBackingStore::invalidate):
(WebCore::TiledBackingStore::updateTileBuffers):
(WebCore::TiledBackingStore::paint):
(WebCore::TiledBackingStore::viewportChanged):
(WebCore::TiledBackingStore::setContentsScale):
(WebCore::TiledBackingStore::tileDistance):
(WebCore::TiledBackingStore::createTiles):
(WebCore::TiledBackingStore::dropOverhangingTiles):
(WebCore::TiledBackingStore::dropTilesOutsideRect):
(WebCore::TiledBackingStore::tileAt):
(WebCore::TiledBackingStore::setTile):
(WebCore::TiledBackingStore::removeTile):
(WebCore::TiledBackingStore::mapToContents):
(WebCore::TiledBackingStore::mapFromContents):
(WebCore::TiledBackingStore::contentsRect):
(WebCore::TiledBackingStore::tileRectForCoordinate):
(WebCore::TiledBackingStore::tileCoordinateForPoint):
(WebCore::TiledBackingStore::startTileBufferUpdateTimer):
(WebCore::TiledBackingStore::tileBufferUpdateTimerFired):
(WebCore::TiledBackingStore::startTileCreationTimer):
(WebCore::TiledBackingStore::tileCreationTimerFired):
(WebCore::TiledBackingStore::setContentsFrozen):

platform/graphics/TiledBackingStore.h: Added.

(WebCore::TiledBackingStore::contentsScale):
(WebCore::TiledBackingStore::contentsFrozen):

platform/graphics/TiledBackingStoreClient.h: Added.
platform/graphics/qt/TileQt.cpp: Added.

(WebCore::checkeredPixmap):
(WebCore::Tile::Tile):
(WebCore::Tile::~Tile):
(WebCore::Tile::isDirty):
(WebCore::Tile::isReadyToPaint):
(WebCore::Tile::invalidate):
(WebCore::Tile::updateBackBuffer):
(WebCore::Tile::swapBackBufferToFront):
(WebCore::Tile::paint):
(WebCore::Tile::paintCheckerPattern):

2:44 PM Changeset in webkit [55975] by mitz@apple.com

16 edits
2 deletes in trunk

WebCore: WebCore part of removing support for legacy versions of Core Graphics

Reviewed by Darin Adler.

WebCore.vcproj/WebCore.vcproj: Removed FontDatabase.{cpp,h}
platform/graphics/win/FontCGWin.cpp:

(WebCore::Font::drawGlyphs): Removed call to wkCanCreateCGFontWithLOGFONT(),
as it is now always true.

platform/graphics/win/FontCacheWin.cpp:

(WebCore::FontCache::createFontPlatformData): Ditto.

platform/graphics/win/FontCustomPlatformData.cpp:

(WebCore::FontCustomPlatformData::~FontCustomPlatformData): Updated for
the removal of m_cgFont.
(WebCore::FontCustomPlatformData::fontPlatformData): Removed call to
wkCanCreateCGFontWithLOGFONT(), as it is now always true.
(WebCore::createFontCustomPlatformData): Ditto. Also updated for change to
the FontCustomPlatformData constructor.

platform/graphics/win/FontCustomPlatformData.h: Removed m_cgFont member.

(WebCore::FontCustomPlatformData::FontCustomPlatformData): Removed cgFont
parameter.

platform/graphics/win/FontDatabase.cpp: Removed.
platform/graphics/win/FontDatabase.h: Removed.
platform/graphics/win/FontPlatformDataCGWin.cpp:

(WebCore::FontPlatformData::platformDataInit): Removed call to
wkCanCreateCGFontWithLOGFONT(), as it is now always true.

platform/win/TemporaryLinkStubs.cpp:

(WebCore::populateFontDatabase): Removed stub.

WebKit/win: WebKit part of removing support for legacy versions of Core Graphics

Reviewed by Darin Adler.

WebKitClassFactory.cpp:

(WebKitClassFactory::WebKitClassFactory): Removed call to populateFontDatabase().

WebKitGraphics.cpp:

(makeFont): Ditto.

WebTextRenderer.cpp:

(WebTextRenderer::registerPrivateFont): Removed call to wkAddFontsAtPath().

WebKitLibraries: WebKitSystemInterface part of removing support for legacy versions of Core Graphics

Reviewed by Darin Adler.

win/include/WebKitSystemInterface/WebKitSystemInterface.h: Removed

wkCanCreateCGFontWithLOGFONT(), wkSetFontPlatformInfo(), wkAddFontsInDirectory(),
wkAddFontsAtPath(), wkAddFontsFromRegistry(), wkAddFontsFromPlist(), and
wkCreateFontsPlist().

win/lib/WebKitSystemInterface.lib: Updated.
win/lib/WebKitSystemInterface_debug.lib: Updated.

8:43 AM Changeset in webkit [55974] by jberlin@webkit.org

2 edits in trunk/WebCore

"event.ctrlKey" is always false when dragging an element with "ctrl" key down
https://bugs.webkit.org/show_bug.cgi?id=17113

Reviewed by Sam Weinig.

No new tests.

page/DragController.cpp:

(WebCore::createMouseEvent):
Use the current state of the shift, ctrl, alt, and meta keys when creating the drag mouse event.

5:58 AM Changeset in webkit [55973] by tonikitoo@webkit.org

3 edits in trunk/WebCore

2010-03-13 Antonio Gomes <tonikitoo@webkit.org>

Not reviewed identation fix.

manual-tests/spatial-navigation/spatial-navigation-test-cases.html:

Note: See TracTimeline for information about the timeline view.

Download in other formats:

RSS Feed