Context Navigation

The StillImage class implements WebCore::Image by wrapping a native
BBitmap. It will be needed to implement WebCore::ImageBuffer. This
solution is just like it's done in the Qt port.

platform/graphics/haiku/StillImageHaiku.cpp: Added. (WebCore::StillImage::StillImage): (WebCore::StillImage::destroyDecodedData): (WebCore::StillImage::decodedSize): (WebCore::StillImage::size): (WebCore::StillImage::nativeImageForCurrentFrame): (WebCore::StillImage::draw):
platform/graphics/haiku/StillImageHaiku.h: Added. (WebCore::StillImage::create):

9:06 PM Changeset in webkit [56148] by zecke@webkit.org

3 edits in trunk/WebCore

[Gtk+] Avoid making a copy of the HTTPHeaderMap.

ResourceRequest::httpHeaderFields() is returning a const
reference but we are storing it as a simple value. This
means that we run either the copy constructor or the assignment
operator and make a copy of the RefPtrs.

This extra copy can be avoided easily by storing
const reference.

platform/network/soup/ResourceRequestSoup.cpp:

(WebCore::ResourceRequest::toSoupMessage):

platform/network/soup/ResourceResponseSoup.cpp:

(WebCore::ResourceResponseSoup::toSoupMessage):

8:58 PM Changeset in webkit [56147] by eric@webkit.org

1 edit
56 adds in trunk/WebKit

2010-03-17 Leandro Pereira <leandro@profusion.mobi>

Reviewed by Kenneth Rohde Christiansen.

Add default theme files to efl/DefaultTheme.
http://webkit.org/b/36240

efl/DefaultTheme/widget/radio/img_radio_on.png: Added.
efl/DefaultTheme/radio/img_radio_off_hover.png: Added.
efl/DefaultTheme/radio/img_radio_on_hover.png: Added.
efl/DefaultTheme/radio/img_radio_off.png: Added.
efl/DefaultTheme/radio/img_radio_off_focus.png: Added.
efl/DefaultTheme/radio/img_radio_on_focus.png: Added.
efl/DefaultTheme/combo/combo_normal.png: Added.
efl/DefaultTheme/combo/combo_focus_button.png: Added.
efl/DefaultTheme/combo/combo_hover_button.png: Added.
efl/DefaultTheme/combo/combo_hover.png: Added.
efl/DefaultTheme/combo/combo_focus.png: Added.
efl/DefaultTheme/combo/combo_press_button.png: Added.
efl/DefaultTheme/combo/combo_normal_button.png: Added.
efl/DefaultTheme/combo/combo_press.png: Added.
efl/DefaultTheme/combo/icon.png: Added.
efl/DefaultTheme/file/file_normal.png: Added.
efl/DefaultTheme/file/file_press.png: Added.
efl/DefaultTheme/file/file_hover.png: Added.
efl/DefaultTheme/file/file_focus.png: Added.
efl/DefaultTheme/search/cancel/cancel_normal_button.png: Added.
efl/DefaultTheme/search/cancel/cancel_normal_button2.png: Added.
efl/DefaultTheme/search/decoration/decoration_normal_button.png: Added.
efl/DefaultTheme/search/field/field_focused.png: Added.
efl/DefaultTheme/search/field/field_normal.png: Added.
efl/DefaultTheme/search/field/field_hovered.png: Added.
efl/DefaultTheme/entry/img_normal.png: Added.
efl/DefaultTheme/entry/img_hovered.png: Added.
efl/DefaultTheme/entry/img_focused.png: Added.
efl/DefaultTheme/check/img_check_off_hover.png: Added.
efl/DefaultTheme/check/img_check_on.png: Added.
efl/DefaultTheme/check/img_check_off_focus.png: Added.
efl/DefaultTheme/check/img_check_on_focus.png: Added.
efl/DefaultTheme/check/img_check_off.png: Added.
efl/DefaultTheme/check/img_check_on_hover.png: Added.
efl/DefaultTheme/scrollbar/scrollbar_knob_h.png: Added.
efl/DefaultTheme/scrollbar/scrollbar_knob_v.png: Added.
efl/DefaultTheme/scrollbar/scrollbar_hilight.png: Added.
efl/DefaultTheme/scrollbar/scrollbar_v.png: Added.
efl/DefaultTheme/scrollbar/scrollbar_h.png: Added.
efl/DefaultTheme/button/img_button_normal.png: Added.
efl/DefaultTheme/button/img_button_focus.png: Added.
efl/DefaultTheme/button/img_button_hover.png: Added.
efl/DefaultTheme/button/img_button_press.png: Added.

8:41 PM Changeset in webkit [56146] by eric@webkit.org

2 edits in trunk/WebKitTools

2010-03-17 Jesus Sanchez-Palencia <jesus.palencia@openbossa.org>

Reviewed by Kenneth Rohde Christiansen.

Accelerated Compositing is now default on QtWebKit so the option
in QtLauncher must be true as default.

[Qt] QtLauncher's Accelerated Compositing option must be true as default
https://bugs.webkit.org/show_bug.cgi?id=36234

QtLauncher/main.cpp: (LauncherWindow::applyPrefs): (LauncherWindow::toggleAcceleratedCompositing): (LauncherApplication::handleUserOptions):

8:24 PM Changeset in webkit [56145] by eric@webkit.org

2 edits in trunk/WebKitTools

2010-03-17 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Commit queue should ignore (probably red) builders when landing rollouts
https://bugs.webkit.org/show_bug.cgi?id=36169

When landing a rollout, the builders are probably red, so we need to
ignore them in the subprocess too. Also, we might as well update the
working copy because we haven't validated anything about the current
revision prior to trying to land.

This change is testable, but it requires changing the mock executive to
log its arguments. That will generate a lot of expectation changes, so
I'd like to do that in a separate patch.

Scripts/webkitpy/commands/queues.py:

8:07 PM Changeset in webkit [56144] by eric@webkit.org

2 edits in trunk/WebKit/chromium

2010-03-17 Garret Kelly <gdk@chromium.org>

Reviewed by Darin Fisher.

PlatformTouchEventBuilder should not be resizing the touch point
array before appending touch points to it.
https://bugs.webkit.org/show_bug.cgi?id=36231

src/WebInputEventConversion.cpp: (WebKit::PlatformTouchEventBuilder::PlatformTouchEventBuilder):

7:51 PM Changeset in webkit [56143] by eric@webkit.org

2 edits in trunk/WebCore

2010-03-17 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: When switching resources in the Resources panel, the Content tab is always selected
https://bugs.webkit.org/show_bug.cgi?id=36222

inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel.prototype.showResource):

7:25 PM Changeset in webkit [56142] by oliver@apple.com

5 edits in trunk

2010-03-17 Oliver Hunt <oliver@apple.com>

Reviewed by Gavin Barraclough.

undefined, NaN, and Infinity should be ReadOnly
https://bugs.webkit.org/show_bug.cgi?id=36263

Simply add the ReadOnly flag to these properties.

runtime/JSGlobalObject.cpp: (JSC::JSGlobalObject::reset):

2010-03-17 Oliver Hunt <oliver@apple.com>

Reviewed by Gavin Barraclough.

undefined, NaN, and Infinity should be ReadOnly
https://bugs.webkit.org/show_bug.cgi?id=36263

Add tests for the attributes of undefined, NaN and Infinity on the
global object

fast/js/getOwnPropertyDescriptor-expected.txt:
fast/js/resources/getOwnPropertyDescriptor.js:

7:16 PM Changeset in webkit [56141] by eric@webkit.org

3 edits in trunk/WebKit/qt

2010-03-17 Antti Koivisto <koivisto@iki.fi>

Reviewed by Tor Arne Vestbø.

Fix Qt build with tiled backing store disabled.

Api/qwebframe.cpp:
Api/qwebframe_p.h:

6:59 PM Changeset in webkit [56140] by eric@webkit.org

6 edits in trunk

2010-03-17 Chang Shu <chang.shu@nokia.com>

Reviewed by Laszlo Gombos.

https://bugs.webkit.org/show_bug.cgi?id=36139
[Qt] Unskip the test that now passes.

platform/qt/Skipped:

2010-03-17 Chang Shu <chang.shu@nokia.com>

Reviewed by Laszlo Gombos.

https://bugs.webkit.org/show_bug.cgi?id=36139
[Qt] Clean up cache while setting cache quota. This behavior matches other platforms,
such as mac and gtk.

Api/qwebsettings.cpp:

(QWebSettings::setOfflineWebApplicationCacheQuota):

2010-03-17 Chang Shu <chang.shu@nokia.com>

Reviewed by Laszlo Gombos.

https://bugs.webkit.org/show_bug.cgi?id=36139
[Qt] Clean up cache each time DumpRenderTree starts. This behavior
matches other platforms, such as mac and gtk.

DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::DumpRenderTree::DumpRenderTree):

6:32 PM Changeset in webkit [56139] by beidson@apple.com

3 edits in trunk/WebCore

databaseIdentifiers are not filtered for slashes
<rdar://problem/7708789> and https://bugs.webkit.org/show_bug.cgi?id=36243

Reviewed by Darin Adler.

In addition to filtering for '/' and '\', to remove the directory vulnerability
on all platforms, it seems worth it to also escape other characters that are
obviously dangerous or illegal to have in a filename (mostly inspired by the
Windows illegal-character list).

No new tests - It's unclear how a test could possibly work into our testing
infrastructure.

page/SecurityOrigin.cpp:

(WebCore::): Added a 128-bool table "needsEscaping" that has a true/false answer

for lower-ASCII.

(WebCore::SecurityOrigin::SecurityOrigin):
(WebCore::SecurityOrigin::createFromDatabaseIdentifier): "Unescape" the host

component using the KURL utility.

(WebCore::shouldEscapeUChar): If the char is lower-ASCII, look it up in the

needsEscaping table. Otherwise, let it pass.

(WebCore::encodedHost): Modeled after KURL's host escaping method, but targeted

for the escaping considerations for the host component. We don't use the KURL
version because this one is "different" enough because it operates on UTF16 and
has its own "is bad character?" decider.

(WebCore::SecurityOrigin::databaseIdentifier): Create the escaped host if needed,

and use it instead of the unescaped host.

page/SecurityOrigin.h:

6:17 PM Changeset in webkit [56138] by abarth@webkit.org

2 edits in trunk/WebKitTools

2010-03-17 Adam Barth <abarth@webkit.org>

Unreviewed.

Turns out this needs to be a string.

Scripts/webkitpy/bugzilla.py:

6:09 PM Changeset in webkit [56137] by eric@webkit.org

12 edits in trunk/WebKitTools

2010-03-17 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Add more infrastructure for sheriff-bot, including making what-broke more awesome
https://bugs.webkit.org/show_bug.cgi?id=36254

Scripts/webkitpy/bugzilla.py:
- Made the various URL methods return None when passed None.
Scripts/webkitpy/bugzilla_unittest.py:
- Test that the url methods work as expected.
Scripts/webkitpy/buildbot.py:
- Add a static Build.build_url so that its possible to generate a build url without a Build object.
- Give users a URL in _fetch_xmlrpc_build_dictionary error message.
Scripts/webkitpy/changelogs.py:
- Add a new ChangeLogEntry class to encapsulate entry-parsing logic.
- Add is_path_to_changelog to greatly simplify SCM.modified_changelogs code.
- Make ChangeLog.parse_latest_entry_from_file a public method.
Scripts/webkitpy/changelogs_unittest.py:
- Add tests for new ChangeLog entry parsing.
Scripts/webkitpy/commands/queries.py:
- Make "what-broke" not print "ok" builders, only failing ones.
- Print much more information on failing builders, including links and authorship/reviewer information.
Scripts/webkitpy/commands/queues_unittest.py:
- Use a fake_checkout path since fixing the cwd (as part of fixing scm_unittests.py) was breaking tests.
Scripts/webkitpy/mock_bugzillatool.py:
- Move MockSCM away from using os.getcwd() as that was fragile (and wrong).
Scripts/webkitpy/patch/patcher.py:
- Remove code which was broken now that this file has moved.
- Code was also redundant now that SCM.find_checkout_root() exists.
Scripts/webkitpy/scm.py:
- Greatly simplify modified_changelogs now that I understand list comprehensions.
- Expect ChangeLogEntry objects instead of raw strings.
- Add changed_files_for_revision, committer_email_for_revision and contents_at_revision
- Add commit_with_message argument to all sites since someone half-added it before. :(
- Get rid of copy/paste code using _status_regexp()
Scripts/webkitpy/scm_unittest.py:
- Fix these tests!
- Add new tests for new scm code.
- Fix spelling of "awsome" to "awesome".

5:37 PM Changeset in webkit [56136] by eric@webkit.org

1 edit
4 adds in trunk/LayoutTests

2010-03-17 Drew Wilson <atwilson@chromium.org>

Reviewed by David Levin.

Add tests for "load shared worker in iframe" case.
https://bugs.webkit.org/show_bug.cgi?id=36203

Makes sure that creating a worker simultaneously in a document and in
a child iframe works (you end up with a single instance).

fast/workers/resources/shared-worker-count-connections.js: Added.
fast/workers/resources/shared-worker-iframe.html: Added.
fast/workers/shared-worker-in-iframe-expected.txt: Added.
fast/workers/shared-worker-in-iframe.html: Added.

5:10 PM Changeset in webkit [56135] by Darin Adler

2 edits in trunk/JavaScriptCore

Speed up Math.round a little by removing unneeded special case
https://bugs.webkit.org/show_bug.cgi?id=36107

Reviewed by Oliver Hunt.

Test: fast/js/math.html

runtime/MathObject.cpp:

(JSC::mathProtoFuncRound): This function had a special case for numbers
between -0.5 and -0.0 to return -0.0. But the algorithm in the function
already yields -0.0 for those cases, so the extra checking and branching
is unneeded.

4:40 PM Changeset in webkit [56134] by eric@webkit.org

2 edits
3 adds in trunk/LayoutTests

2010-03-17 Shu Chang <Chang.Shu@nokia.com>

Reviewed by Eric Seidel.

[Qt] Rebaseline the test and remove it from Skipped.
https://bugs.webkit.org/show_bug.cgi?id=36059

platform/qt/Skipped:
platform/qt/fast/canvas/canvas-text-baseline-expected.checksum: Added.
platform/qt/fast/canvas/canvas-text-baseline-expected.png: Added.
platform/qt/fast/canvas/canvas-text-baseline-expected.txt: Added.

4:39 PM Changeset in webkit [56133] by abarth@webkit.org

5 edits in trunk/WebKitTools

2010-03-17 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Change post-rollout to create-rollout and have it make a new bug
instead of posting the rollout to the old bug.
https://bugs.webkit.org/show_bug.cgi?id=36250

The new bug blocks the old bug instead of adding more complexity to the
old bug. One tricky question is whether to create the bug if we're
unable to create a rollout patch. In this patch, we do create the bug,
but we might revist this question in the future.

Scripts/webkitpy/bugzilla.py:
Scripts/webkitpy/commands/download.py:
Scripts/webkitpy/commands/download_unittest.py:
Scripts/webkitpy/steps/createbug.py:

4:18 PM Changeset in webkit [56132] by dbates@webkit.org

2 edits in trunk/WebKitTools

2010-03-17 Daniel Bates <dbates@rim.com>

Rubber-stamped by David Levin.

Add myself to the list of reviewers.

Scripts/webkitpy/committers.py:

4:01 PM WebKit Team edited by dbates@webkit.org

Moved my entry from Committer to Reviewer. (diff)

3:38 PM Changeset in webkit [56131] by dimich@chromium.org

5 edits
3 adds in trunk

[v8] Avoid reentry into v8 after TerminateExecution() on a worker thread.
https://bugs.webkit.org/show_bug.cgi?id=36239

Reviewed by Dimitri Glazkov.

WebCore:

Test: fast/workers/termination-with-port-messages.html

bindings/v8/V8Proxy.h:

(WebCore::throwError): Avoid throwing if v8 execution is terminated anyways.

bindings/v8/WorkerScriptController.h:

(WebCore::WorkerScriptController::proxy): Return V8 proxy as 0 if execution is terminating. Callers to check for 0 before invoking v8.

bindings/v8/custom/V8WorkerContextCustom.cpp:

(WebCore::SetTimeoutOrInterval): Bail out if v8 proxy is 0.
(WebCore::toV8): Ditto

LayoutTests:

fast/workers/resources/termination-with-port-messages.js: Added.

(echo):
(onmessage):

fast/workers/termination-with-port-messages-expected.txt: Added.
fast/workers/termination-with-port-messages.html: Added.

3:23 PM Changeset in webkit [56130] by eric@webkit.org

1 edit
2 adds in trunk/WebKit

2010-03-17 Leandro Pereira <leandro@profusion.mobi>

Reviewed by Kenneth Rohde Christiansen.

Add EFL example browser to efl/EWebLauncher.
http://webkit.org/b/36176

efl/EWebLauncher/main.c: Added.

2:58 PM Changeset in webkit [56129] by dimich@chromium.org

2 edits in trunk/WebKit/chromium

[chromium] Roll Chromium builder's DEPS to current revs.
https://bugs.webkit.org/show_bug.cgi?id=36241

Reviewed by Dimitri Glazkov.

DEPS:

2:47 PM Changeset in webkit [56128] by eric@webkit.org

11 edits
1 delete in trunk/WebCore

2010-03-17 José Millán Soto <jmillan@igalia.com>

Reviewed by Adam Barth.

Change the way of prefetching DNS to allow prefetching function to use full URL
https://bugs.webkit.org/show_bug.cgi?id=35589

Creates a new function, ResourceHandle::prepareForURL, whose default implementation
calls prefetchDNS with the host of the given URL as the parameter.
Soup implementation of ResourceHandle::prepareForURL executes soup_session_prepare_for_uri.
Soup implementation of prefetchDNS is removed.
Changed various prefetchDNS calls to ResourceHandle::prepareForURL calls.

GNUmakefile.am:
html/HTMLAnchorElement.cpp: (WebCore::HTMLAnchorElement::parseMappedAttribute):
html/HTMLLinkElement.cpp: (WebCore::HTMLLinkElement::process):
page/Chrome.cpp: (WebCore::Chrome::mouseDidMoveOverElement):
platform/network/DNS.h:
platform/network/ResourceHandle.cpp: (WebCore::ResourceHandle::prepareForURL):
platform/network/ResourceHandle.h:
platform/network/chromium/DNSChromium.cpp: (WebCore::ResourceHandle::prepareForURL):
platform/network/soup/DNSSoup.cpp: Removed.
platform/network/soup/ResourceHandleSoup.cpp: (WebCore::ResourceHandle::prepareForURL):
wml/WMLAElement.cpp: (WebCore::WMLAElement::parseMappedAttribute):

2:11 PM Changeset in webkit [56127] by kbr@google.com

15 edits
2 deletes in trunk

2010-03-17 Kenneth Russell <kbr@google.com>

Reviewed by Darin Fisher.

Revert WebGL context attributes changes 33416 / r56074 and 36200 / r56093
https://bugs.webkit.org/show_bug.cgi?id=36233

The patch for bug 33416, which added multisampling support to the
WebGL back buffer, uncovered some OpenGL driver bugs on the build
bots which need further investigation to determine the appropriate
workaround. Reverting this change, the minor build fix in 36189,
and the skipping of the affected tests in bug 36200.

Built and tested WebKit and Chromium and ran all WebGL layout
tests in both.

src/GraphicsContext3D.cpp: (WebCore::GraphicsContext3DInternal::GraphicsContext3DInternal): (WebCore::GraphicsContext3DInternal::~GraphicsContext3DInternal): (WebCore::GraphicsContext3DInternal::reshape): (WebCore::GraphicsContext3DInternal::beginPaint): (WebCore::GraphicsContext3DInternal::bindFramebuffer): (WebCore::GraphicsContext3D::readPixels):

2010-03-17 Kenneth Russell <kbr@google.com>

Reviewed by Darin Fisher.

Revert WebGL context attributes changes 33416 / r56074 and 36200 / r56093
https://bugs.webkit.org/show_bug.cgi?id=36233

The patch for bug 33416, which added multisampling support to the
WebGL back buffer, uncovered some OpenGL driver bugs on the build
bots which need further investigation to determine the appropriate
workaround. Reverting this change, the minor build fix in 36189,
and the skipping of the affected tests in bug 36200.

Built and tested WebKit and Chromium and ran all WebGL layout
tests in both.

bindings/v8/custom/V8HTMLCanvasElementCustom.cpp: (WebCore::V8HTMLCanvasElement::getContextCallback):
platform/graphics/GraphicsContext3D.h:
platform/graphics/mac/Canvas3DLayer.h:
platform/graphics/mac/Canvas3DLayer.mm: (-[Canvas3DLayer drawInCGLContext:pixelFormat:forLayerTime:displayTime:]):
platform/graphics/mac/GraphicsContext3DMac.cpp: (WebCore::GraphicsContext3D::GraphicsContext3D): (WebCore::GraphicsContext3D::~GraphicsContext3D): (WebCore::GraphicsContext3D::reshape): (WebCore::GraphicsContext3D::bindFramebuffer): (WebCore::GraphicsContext3D::readPixels):
platform/graphics/mac/GraphicsLayerCA.mm: (WebCore::GraphicsLayerCA::setContentsToGraphicsContext3D):

2010-03-17 Kenneth Russell <kbr@google.com>

Reviewed by Darin Fisher.

Revert WebGL context attributes changes 33416 / r56074 and 36200 / r56093
https://bugs.webkit.org/show_bug.cgi?id=36233

The patch for bug 33416, which added multisampling support to the
WebGL back buffer, uncovered some OpenGL driver bugs on the build
bots which need further investigation to determine the appropriate
workaround. Reverting this change, the minor build fix in 36189,
and the skipping of the affected tests in bug 36200.

Built and tested WebKit and Chromium and ran all WebGL layout
tests in both.

fast/canvas/webgl/context-attributes-alpha-depth-stencil-antialias-expected.txt: Removed.
fast/canvas/webgl/context-attributes-alpha-depth-stencil-antialias.html: Removed.
fast/canvas/webgl/context-attributes-expected.txt:
fast/canvas/webgl/context-attributes.html:
fast/canvas/webgl/gl-get-calls-expected.txt:
fast/canvas/webgl/gl-get-calls.html:
platform/mac/Skipped:

2:02 PM Changeset in webkit [56126] by yael.aharon@nokia.com

8 edits in trunk/WebCore

Optimize painting for HTMLProgressElement
https://bugs.webkit.org/show_bug.cgi?id=36113
Cache the progress bar's position, so it is not required to recalculate
it for each repaint.
Call repaintRectangle() when the position changes.

Reviewed by Darin Adler.

No new tests, as no new functionality introduced.

html/HTMLProgressElement.cpp:
platform/qt/RenderThemeQt.cpp:
platform/qt/RenderThemeQt.h:
rendering/RenderProgress.cpp:
rendering/RenderProgress.h:
rendering/RenderTheme.cpp:
rendering/RenderTheme.h:

1:52 PM Changeset in webkit [56125] by abarth@webkit.org

3 edits
9 adds in trunk/WebKitTools

2010-03-17 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Add a way for the bots to send messages to IRC
https://bugs.webkit.org/show_bug.cgi?id=36235

We'll use these classes to notify #webkit about bad SVN revisions.
This patch just has some skeleton code for us to play with.

Scripts/webkitpy/irc/init.py: Added.
Scripts/webkitpy/irc/ircbot.py: Added.

A bot that knows how to talk to IRC.

Scripts/webkitpy/irc/ircproxy.py: Added.

We need to run the bot on its own thread because the irclib needs
its own mainloop. This class provides an abstraction of the
threading.

Scripts/webkitpy/irc/messagepump.py: Added.
Scripts/webkitpy/irc/messagepump_unittest.py: Added.
Scripts/webkitpy/irc/threadedmessagequeue.py: Added.

A thread-safe message queue for sending messages from the main
thread to the IRC thread.

Scripts/webkitpy/irc/threadedmessagequeue_unittest.py: Added.
Scripts/webkitpy/irc/unittests.py: Added.
Scripts/webkitpy/thirdparty/autoinstalled/init.py:

Autoinstall irclib

Scripts/webkitpy/unittests.py:

11:47 AM Changeset in webkit [56124] by kov@webkit.org

2 edits in trunk/JavaScriptCore

2010-03-17 Mike Homey <glandium@debian.org>

Reviewed by Gustavo Noronha.

Build fix for SPARC. Fix missing macro value.

wtf/Platform.h:

11:44 AM Changeset in webkit [56123] by victorw@chromium.org

2 edits in trunk/WebKitTools

2010-03-17 Victor Wang <victorw@chromium.org>

Reviewed by Dimitri Glazkov.

Fix image_diff syntax in webkitpy/port/base.py.
The syntax is wrong if diff_filename is specified.

https://bugs.webkit.org/show_bug.cgi?id=36230

Scripts/webkitpy/layout_tests/port/base.py:

11:22 AM Changeset in webkit [56122] by ap@apple.com

2 edits in trunk/LayoutTests

platform/gtk/Skipped: Also, resize-from-plugin.html got skipped twice tonight, removing one of the lines.

11:15 AM Changeset in webkit [56121] by bweinstein@apple.com

1 edit in trunk/WebKit/win/Interfaces/WebKit.idl

Touch WebKit.idl to fix the build

11:11 AM Changeset in webkit [56120] by tonikitoo@webkit.org

2 edits in trunk/WebCore

Mac Buildfix: Using ASSERT_UNUSED instead of ASSERT.

Reviewed by Simon fraser.
Patch by Antonio Gomes <tonikitoo@webkit.org>

dom/SelectElement.cpp:

(WebCore::SelectElement::listBoxDefaultEventHandler):

11:02 AM Changeset in webkit [56119] by ap@apple.com

2 edits in trunk/LayoutTests

platform/gtk/Skipped: Updated to reference a newly filed bug.

11:00 AM Changeset in webkit [56118] by enrica@apple.com

8 edits in trunk

Missing support for showing compositing layers borders and repaint count on Windows.
<rdar://problem/7760736>
<https://bugs.webkit.org/show_bug.cgi?id=36197>

Reviewed by Darin Adler.

WebCore:

platform/graphics/win/GraphicsLayerCACF.cpp:

(WebCore::WebLayer::drawInContext): Modified to use the correct font on Windows.

WebKit/win:

Interfaces/IWebPreferencesPrivate.idl:
WebPreferenceKeysPrivate.h:
WebPreferences.cpp:

(WebPreferences::initializeDefaultSettings):
(WebPreferences::showDebugBorders):
(WebPreferences::setShowDebugBorders):
(WebPreferences::showRepaintCounter):
(WebPreferences::setShowRepaintCounter):

WebPreferences.h:
WebView.cpp:

(WebView::notifyPreferencesChanged):

10:37 AM Changeset in webkit [56117] by tonikitoo@webkit.org

2 edits in trunk/WebKitTools

2010-03-16 Diego Gonzalez <diego.gonzalez@openbossa.org>

Reviewed by Kenneth Christiansen.

Provide to QtLauncher a way to change the ViewportUpdateMode
when it's in graphics based mode.

[Qt] Make QtLaucher able to select the ViewportUpdateMode
https://bugs.webkit.org/show_bug.cgi?id=36175

QtLauncher/main.cpp: (LauncherWindow::selectViewportUpdateMode): (LauncherWindow::createChrome):

10:25 AM Changeset in webkit [56116] by tonikitoo@webkit.org

3 edits in trunk/WebCore

Multiselect Popup - SelectElement refactoring. https://bugs.webkit.org/show_bug.cgi?id=36124

Reviewed by Antti Koivisto.

As it is today it is not possible to the menulists popups to tell SelectElement
that more then one option is selected. If you select one the other ones
selected state will turn off.

For <select multiple> I needed to extend the API used by menulist popups. This
is the first step. Just refactoring SelectElement without any behavior change.
Separating code that will be reused in future patches.

dom/SelectElement.cpp:

(WebCore::SelectElement::updateSelectedState):
(WebCore::SelectElement::listBoxDefaultEventHandler):

dom/SelectElement.h:

10:09 AM Changeset in webkit [56115] by Nate Chapin

1 edit
1 copy
1 delete in trunk/WebCore

2010-03-17 Nate Chapin <Nate Chapin>

Unreviewed, Chromium build fix.

Delete the correct file this time.

bindings/v8/custom/V8XMLHttpRequestCustom.cpp: Copied from WebCore/bindings/v8/custom/V8XMLHttpRequestCustom.cpp.
bindings/v8/custom/V8XMLHttpRequestUploadCustom.cpp: Removed.

9:51 AM Changeset in webkit [56114] by Nate Chapin

14 edits
1 delete in trunk/WebCore

2010-03-17 Nate Chapin <Nate Chapin>

Reviewed by Dimitri Glazkov.

[V8] Remove custom bindings callbacks that aren't in use.
(The relevant .idl doesn't mark them as V8Custom or Custom).

https://bugs.webkit.org/show_bug.cgi?id=33066

Android.v8bindings.mk:
WebCore.gypi:
bindings/scripts/CodeGeneratorV8.pm:
bindings/v8/custom/V8DOMWindowCustom.cpp:
bindings/v8/custom/V8WebGLArrayCustom.h:
bindings/v8/custom/V8WebGLByteArrayCustom.cpp:
bindings/v8/custom/V8WebGLFloatArrayCustom.cpp:
bindings/v8/custom/V8WebGLIntArrayCustom.cpp:
bindings/v8/custom/V8WebGLShortArrayCustom.cpp:
bindings/v8/custom/V8WebGLUnsignedByteArrayCustom.cpp:
bindings/v8/custom/V8WebGLUnsignedIntArrayCustom.cpp:
bindings/v8/custom/V8WebGLUnsignedShortArrayCustom.cpp:
bindings/v8/custom/V8XMLHttpRequestCustom.cpp:
bindings/v8/custom/V8XMLHttpRequestUploadCustom.cpp: Removed.

9:11 AM Changeset in webkit [56113] by zoltan@webkit.org

2 edits in trunk/WebKitTools

2010-03-17 Zoltan Horvath <zoltan@webkit.org>

Reviewed by Darin Adler.

Ambiguous error message when building for unspecified platform
https://bugs.webkit.org/show_bug.cgi?id=30203

Add an extra line information to the error message.

Scripts/webkitdirs.pm:

8:24 AM Changeset in webkit [56112] by steveblock@google.com

3 edits in trunk/WebCore

2010-03-17 Steve Block <steveblock@google.com>

Reviewed by Dimitri Glazkov.

Adds ENABLE(WORKERS) guards to V8 bindings
https://bugs.webkit.org/show_bug.cgi?id=36221

Build fix only, no new tests.

bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::instantiateV8Object):
bindings/v8/V8Proxy.cpp: (WebCore::toV8Context):

7:57 AM ImprovingLifeOnWindows edited by dbates@webkit.org

Rolled out changeset 56044 as to broke the Windows Debug (test) bot. … (diff)

7:40 AM Changeset in webkit [56111] by pfeldman@chromium.org

2 edits in trunk/LayoutTests

2010-03-17 Pavel Feldman <pfeldman@chromium.org>

Not reviewed: update mimetype expectations in inspector tests.

inspector/timeline-network-resource-expected.txt:

7:30 AM Changeset in webkit [56110] by pfeldman@chromium.org

3 edits
1 delete in trunk

2010-03-17 Pavel Feldman <pfeldman@chromium.org>

Not reviewed: GTK tests fix - removed custom expectation that was
added with no good reason.

inspector/timeline-test.js:
platform/gtk/inspector/timeline-network-resource-expected.txt: Removed.

7:20 AM Changeset in webkit [56109] by yurys@chromium.org

2 edits in trunk/WebCore

2010-03-17 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Remove unused reference to InspectorController from InspectorFrontend.

https://bugs.webkit.org/show_bug.cgi?id=36218

inspector/InspectorFrontend.h:

7:08 AM Changeset in webkit [56108] by pfeldman@chromium.org

14 edits in trunk

2010-03-17 Ilya Tikhonovsky <loislo@chromium.org>

Reviewed by Pavel Feldman.

WebInspector: Timeline improvements - next iteration.

The top level records should be collapsed.
Virtually linked events should be nested in Timeline like Send Request and
corresponding Received Responce, Timer Install and Timer Fire etc.
It should be possible to see Main Resource request.

https://bugs.webkit.org/show_bug.cgi?id=36122

inspector/InspectorController.cpp: (WebCore::InspectorController::resetScriptObjects): (WebCore::InspectorController::didReceiveResponse):
inspector/InspectorTimelineAgent.cpp: (WebCore::InspectorTimelineAgent::willReceiveResourceResponse): (WebCore::InspectorTimelineAgent::didReceiveResourceResponse):
inspector/InspectorTimelineAgent.h:
inspector/front-end/TimelinePanel.js: (WebInspector.TimelinePanel): (WebInspector.TimelinePanel.prototype._createStatusbarButtons): (WebInspector.TimelinePanel.prototype.addRecordToTimeline): (WebInspector.TimelinePanel.prototype._findParentRecord): (WebInspector.TimelinePanel.prototype._innerAddRecordToTimeline): (WebInspector.TimelinePanel.prototype.resize): (WebInspector.TimelinePanel.prototype._createTopLevelRecord): (WebInspector.TimelinePanel.prototype.reset): (WebInspector.TimelinePanel.prototype._clean): (WebInspector.TimelinePanel.prototype._refresh): (WebInspector.TimelinePanel.prototype._refreshRecords): (WebInspector.TimelinePanel.prototype._addToRecordsWindow): (WebInspector.TimelineCalculator.prototype.computeBarGraphPercentages): (WebInspector.TimelineCalculator.prototype.updateBoundaries): (WebInspector.TimelineRecordGraphRow): (WebInspector.TimelineRecordGraphRow.prototype.update): (WebInspector.TimelinePanel.FormattedRecord): (WebInspector.TimelinePanel.FormattedRecord.prototype.get children): (WebInspector.TimelinePanel.FormattedRecord.prototype._generatePopupContent):
inspector/front-end/inspector.css:
loader/ResourceLoader.cpp: (WebCore::ResourceLoader::didReceiveResponse):

6:51 AM Changeset in webkit [56107] by apavlov@chromium.org

11 edits in trunk/WebCore

2010-03-17 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Reimplement style-related audits using native API
https://bugs.webkit.org/show_bug.cgi?id=36172

inspector/InspectorBackend.cpp: (WebCore::InspectorBackend::getAllStyles):
inspector/InspectorBackend.h:
inspector/InspectorBackend.idl:
inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::getAllStyles): (WebCore::InspectorDOMAgent::getMatchedCSSRules): (WebCore::InspectorDOMAgent::buildObjectForStyleSheet): (WebCore::InspectorDOMAgent::buildObjectForRule):
inspector/InspectorDOMAgent.h:
inspector/InspectorFrontend.cpp: (WebCore::InspectorFrontend::didGetAllStyles):
inspector/InspectorFrontend.h:
inspector/front-end/AuditRules.js: (WebInspector.AuditRules.evaluateInTargetWindow): (WebInspector.AuditRules.UnusedCssRule.prototype.doRun.evalCallback.selectorsCallback): (WebInspector.AuditRules.UnusedCssRule.prototype.doRun.evalCallback.routine): (WebInspector.AuditRules.UnusedCssRule.prototype.doRun.evalCallback): (WebInspector.AuditRules.UnusedCssRule.prototype.doRun.routine): (WebInspector.AuditRules.UnusedCssRule.prototype.doRun): (WebInspector.AuditRules.ImageDimensionsRule.prototype.doRun): (WebInspector.AuditRules.CssInHeadRule.prototype.doRun): (WebInspector.AuditRules.StylesScriptsOrderRule.prototype.doRun):
inspector/front-end/DOMAgent.js:
inspector/front-end/InjectedScript.js: (injectedScriptConstructor):

5:47 AM Changeset in webkit [56106] by Csaba Osztrogonác

4 edits in trunk

WebKit/qt: [Qt] Enable accelerated compositing by default
https://bugs.webkit.org/show_bug.cgi?id=35866

Reviewed by Kenneth Rohde Christiansen.

Api/qwebsettings.cpp:

(QWebSettings::QWebSettings):

LayoutTests: [Qt] GraphicsLayer: fix test regressions
https://bugs.webkit.org/show_bug.cgi?id=36191

Reviewed by Kenneth Rohde Christiansen.

Enabling accelerated compositing (AC) by default make 3 tests fail.
AC is more important now than these tests, so they are skipped until
fix and AC is enabled.

platform/qt/Skipped:
- animations/fill-mode-transform.html skipped
- animations/play-state.html skipped
- animations/simultaneous-start-left.html skipped

5:10 AM Changeset in webkit [56105] by steveblock@google.com

6 edits in trunk/WebCore

2010-03-17 Steve Block <steveblock@google.com>

Reviewed by Jeremy Orlow.

Replace instances of bzero in WebCore/bridge common code with memset
https://bugs.webkit.org/show_bug.cgi?id=36214

Syntax change only, no new tests.

bridge/jni/JNIUtility.cpp: (JSC::Bindings::getJNIField):
bridge/jni/jsc/JNIBridgeJSC.cpp: (JavaField::dispatchValueFromInstance):
bridge/jni/jsc/JNIUtilityPrivate.cpp: (JSC::Bindings::convertValueToJValue):
bridge/jni/v8/JNIUtilityPrivate.cpp: (JSC::Bindings::convertNPVariantToJValue):
bridge/jni/v8/JavaNPObjectV8.cpp: (JSC::Bindings::AllocJavaNPObject):

3:59 AM Changeset in webkit [56104] by yurys@chromium.org

5 edits in trunk/WebCore

2010-03-17 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Mark inspector resources as changed so that they are reloaded on the next frontend connection.

Split resetScriptObjects into code specific for page navigation and insepctor frontend disconnection.

https://bugs.webkit.org/show_bug.cgi?id=36183

WebCore.xcodeproj/project.pbxproj: Added InspectorWorkerResource.h to the project file.
inspector/InspectorController.cpp: (WebCore::InspectorController::disconnectFrontend): (WebCore::InspectorController::unbindAllResources): (WebCore::InspectorController::didCommitLoad):
inspector/InspectorController.h:
inspector/InspectorResource.cpp: (WebCore::InspectorResource::releaseScriptObject):

2:57 AM Changeset in webkit [56103] by pfeldman@chromium.org

2 edits in trunk/WebCore

2010-03-17 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: Capture main resource load events in timeline panel.

https://bugs.webkit.org/show_bug.cgi?id=36188

inspector/front-end/TimelinePanel.js: (WebInspector.TimelinePanel.prototype._createStatusbarButtons):

1:05 AM Changeset in webkit [56102] by mjs@apple.com

3 edits in trunk/LayoutTests

Disable new plugin tests from r56079 on Gtk and Qt, since they are failing.

platform/gtk/Skipped:
platform/qt/Skipped:

12:51 AM Changeset in webkit [56101] by xan@webkit.org

2 edits in trunk/LayoutTests

2010-03-17 Xan Lopez <xlopez@igalia.com>

Skip a couple of failing tests in the bots.

platform/gtk/Skipped:

12:39 AM Changeset in webkit [56100] by zoltan@webkit.org

2 edits in trunk/WebCore

2010-03-17 Zoltan Horvath <zoltan@webkit.org>

Reviewed by Eric Seidel.

Allow custom memory allocation control for AtomicString class
https://bugs.webkit.org/show_bug.cgi?id=35907

Inherits the following class from FastAllocBase because it is
instantiated by 'new':

class name - instantiated at: WebCore/'location'
AtomicString - WebCore/html/HTMLTableElement.cpp:525

platform/text/AtomicString.h:

Mar 16, 2010:

11:50 PM Changeset in webkit [56099] by abarth@webkit.org

2 edits in trunk/WebKitTools

2010-03-16 Adam Barth <abarth@webkit.org>

No review, rolling out r56044.
http://trac.webkit.org/changeset/56044
https://bugs.webkit.org/show_bug.cgi?id=36048

This patch broke Windows Debug (Tests)

Scripts/webkitdirs.pm:

8:35 PM QtWebKitBackportingFixes edited by Laszlo Gombos

(diff)

6:53 PM Changeset in webkit [56098] by jhawkins@chromium.org

2 edits in trunk/WebKit/chromium

2010-03-16 James Hawkins <jhawkins@chromium.org>

Reviewed by David Levin.

[Chromium] Size the WebVector of forms after determining how many
forms are valid and will be returned.

https://bugs.webkit.org/show_bug.cgi?id=36204

No new tests, as this is only triggered by Chromium's use of the
WebFormElement API.

src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::forms):

6:05 PM Changeset in webkit [56097] by jam@chromium.org

4 edits in trunk/LayoutTests/platform

update skipped test locations since I moved my test before commit

5:31 PM Changeset in webkit [56096] by jam@chromium.org

13 edits
3 adds in trunk

2010-03-16 John Abd-El-Malek <jam@chromium.org>

Reviewed by Darin Fisher.

Give keyboard focus to PluginDocuments by default
https://bugs.webkit.org/show_bug.cgi?id=36147

Test: http/tests/plugins/plugin-document-has-focus.html

loader/PluginDocument.cpp: (WebCore::PluginDocument::pluginNode):
loader/PluginDocument.h:
page/EventHandler.cpp: (WebCore::eventTargetNodeForDocument):

2010-03-16 John Abd-El-Malek <jam@chromium.org>

Reviewed by Darin Fisher.

Give keyboard focus to PluginDocuments by default
https://bugs.webkit.org/show_bug.cgi?id=36147

http/tests/plugins/plugin-document-has-focus-expected.txt: Added.
http/tests/plugins/plugin-document-has-focus.html: Added.
http/tests/plugins/resources/plugin-document-has-focus.pl: Added.
platform/gtk/Skipped:
platform/mac/Skipped:
platform/qt/Skipped:
platform/win/Skipped:

2010-03-16 John Abd-El-Malek <jam@chromium.org>

Reviewed by Darin Fisher.

Give keyboard focus to PluginDocuments by default
https://bugs.webkit.org/show_bug.cgi?id=36147

DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: (pluginAllocate):
DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h:
DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp: (NPP_New): (NPP_SetWindow): (handleEventCarbon): (handleEventCocoa):

5:23 PM Changeset in webkit [56095] by mitz@apple.com

3 edits in trunk/WebKitLibraries

Fix incorrect glyph advances when using the Core Graphics (non-GDI) glyph look.

Reviewed by Sam Weinig.

win/lib/WebKitSystemInterface.lib:
win/lib/WebKitSystemInterface_debug.lib:

5:10 PM Changeset in webkit [56094] by Chris Fleizach

5 edits
2 adds in trunk

REGRESSION (r53857): Crash when tabbing to <map>
https://bugs.webkit.org/show_bug.cgi?id=36017

Reviewed by Darin Adler.

WebCore:

Test: fast/events/imagemap-norender-crash.html

html/HTMLMapElement.cpp:

(WebCore::HTMLMapElement::imageElement):

LayoutTests:

Also fix the path to js-test-post.js in tab-imagemap.html.

fast/events/imagemap-norender-crash-expected.txt: Added.
fast/events/imagemap-norender-crash.html: Added.
fast/events/tab-imagemap-expected.txt:
fast/events/tab-imagemap.html:

4:39 PM Changeset in webkit [56093] by kbr@google.com

2 edits in trunk/LayoutTests

2010-03-16 Kenneth Russell <kbr@google.com>

Reviewed by Eric Seidel.

Temporarily disable WebGL layout tests failing due to multisampling
https://bugs.webkit.org/show_bug.cgi?id=36200

platform/mac/Skipped:

4:14 PM Changeset in webkit [56092] by barraclough@apple.com

2 edits in trunk/JavaScriptCore

Bug 36083 - REGRESSION (r55772-r55834): Crash in JavaScriptCore RegExp code on PowerPC

Reviewed by Oliver Hunt, Darin Adler.

The problem is a bug in our port of PCRE - that a read may take place from the first character in an
empty string. For the time being, revert to using a valid pointer in the data segment rather than
an invalid non-null pointer into the zero-page for the empty string's data pointer. A better fix for
this will be to remove PCRE.

runtime/UStringImpl.cpp:

(JSC::UStringImpl::empty):

4:05 PM Changeset in webkit [56091] by weinig@apple.com

2 edits in trunk/WebKitTools

Fix run-webkit-httpd on Windows.

Reviewed by Mark Rowe.

Scripts/webkitperl/httpd.pm:

3:33 PM Changeset in webkit [56090] by ap@apple.com

2 edits in trunk/WebKitTools

Tiger build fix.

DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: (pluginGetProperty): Added more type casts to shut down warnings.

3:30 PM Changeset in webkit [56089] by ojan@chromium.org

7 edits in trunk/LayoutTests

2010-03-15 Ojan Vafai <ojan@chromium.org>

Reviewed by Alexey Proskuryakov.

fix webkit win test failures for smart delete
https://bugs.webkit.org/show_bug.cgi?id=36141

Works around https://bugs.webkit.org/show_bug.cgi?id=36140.

editing/deleting/smart-delete-004.html:
editing/pasteboard/smart-paste-002.html:
editing/pasteboard/smart-paste-005.html:
editing/pasteboard/smart-paste-007.html:
platform/mac/editing/pasteboard/smart-paste-002-expected.txt:
platform/mac/editing/pasteboard/smart-paste-005-expected.txt:

3:26 PM Changeset in webkit [56088] by bfulgham@webkit.org

3 edits in trunk/WebCore

Build fix. No Review.

Correct missing includes in cURL network backend introduced
by recent changes in WebKit.

platform/network/curl/ResourceHandleCurl.cpp: Add missing includes for SharedBuffer and PassRefPtr.

(WebCore::ResourceHandle::loadResourceSynchronously): Correct

constructor signature for ResourceHandle to match @r55688.

platform/network/curl/ResourceHandleManager.cpp: Add missing include for RetainPtr.

3:18 PM ImprovingLifeOnWindows edited by dbates@webkit.org

Support for detecting the presence of the Windows Platform SDK was … (diff)

3:10 PM QtWebKitGraphics edited by noam.rosenthal@nokia.com

(diff)

2:26 PM Changeset in webkit [56087] by kov@webkit.org

1 copy in releases/WebKitGTK/webkit-1.1.90

Tagging 1.1.90.

2:26 PM Changeset in webkit [56086] by ap@apple.com

4 edits in trunk/WebKitTools

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=36184
YouTube video resizing doesn't work with OOP plug-ins

Added a resizeTo() method, which calls resizePlugin() in JS with the same arguments,
and a lastSetWindowArguments property, which returns a string describing the last NPWindow
passed to NPN_SetWindow.

DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: (pluginGetProperty): (testResizeTo): (pluginInvoke):
DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h:
DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp: (NPP_SetWindow):

2:07 PM Changeset in webkit [56085] by Darin Adler

12 edits in trunk/JavaScriptCore

Rolled out r56081 since it broke the Windows build.

1:58 PM Changeset in webkit [56084] by kbr@google.com

2 edits in trunk/WebKit/chromium

2010-03-16 Kenneth Russell <kbr@google.com>

Reviewed by Darin Fisher.

Build breakage from 33416
https://bugs.webkit.org/show_bug.cgi?id=36189

No new tests. Built release Chromium.

src/GraphicsContext3D.cpp: (WebCore::GraphicsContext3DInternal::reshape):

1:49 PM Changeset in webkit [56083] by xan@webkit.org

2 edits in trunk

2010-03-16 Xan Lopez <xlopez@igalia.com>

Rubber-stamped by Gustavo Noronha.

Update library version for 1.1.90 release.

configure.ac:

1:46 PM Changeset in webkit [56082] by xan@webkit.org

4 edits in trunk

2010-03-16 Xan Lopez <xlopez@igalia.com>

Reviewed by Gustavo Noronha.

Bump version for 1.1.90 release.

configure.ac:

WebKit/gtk:

2010-03-16 Xan Lopez <xlopez@igalia.com>

Reviewed by Gustavo Noronha.

Update for 1.1.90 release.

NEWS:

1:46 PM Changeset in webkit [56081] by Darin Adler

12 edits in trunk/JavaScriptCore

Added arrayLength function and used it instead of hand-written code.

Reviewed by Sam Weinig.

JavaScriptCore.xcodeproj/project.pbxproj:

Removed PtrAndFlags.h. The file was removed long ago.

interpreter/Interpreter.cpp:

(JSC::Interpreter::privateExecute): Use arrayLength.

runtime/Collector.h:

(JSC::CollectorBitmap::count): Remove WTF:: prefix from use
of bitCount. In WTF we inject things into the global namespace
and this is no exception.

runtime/DatePrototype.cpp:

(JSC::formatLocaleDate): Use arrayLength.

runtime/JSFunction.h:

(JSC::JSFunction::nativeFunction): Remove WTF:: prefix as above.
(JSC::JSFunction::scopeChain): Ditto.
(JSC::JSFunction::setScopeChain): Ditto.
(JSC::JSFunction::setNativeFunction): Ditto.

runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::reset): Use arrayLength.

runtime/JSImmediate.h:

(JSC::reinterpretDoubleToIntptr): Remove WTF:: prefix as above.
(JSC::reinterpretIntptrToDouble): Ditto.

runtime/JSONObject.cpp:

(JSC::Stringifier::appendQuotedString): Use arrayLength.
(JSC::Stringifier::toJSON): Ditto.
(JSC::Stringifier::appendStringifiedValue): Ditto.

runtime/SmallStrings.cpp:

(JSC::SmallStrings::SmallStrings): Ditto.

runtime/UString.cpp:

(JSC::UString::from): Use arrayLength.

wtf/StdLibExtras.h:

(WTF::bitwise_cast): Marked this inline!
(WTF::arrayLength): Added function template (actually written by Sam).
Added using declarations for public things in WTF namespace defined
in this file.

1:44 PM Changeset in webkit [56080] by kov@webkit.org

2 edits in trunk/WebKit/gtk

2010-03-16 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Fix one too many empty lines in documentation of
window-obejct-cleared signal, which caused the documentation to be
rendered funny. Thanks to Martin Robinson for noticing.

webkit/webkitwebview.cpp:

1:40 PM Changeset in webkit [56079] by ap@apple.com

5 edits
3 adds in trunk

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=36184
YouTube video resizing doesn't work with OOP plug-ins

Test: plugins/resize-from-plugin.html

We were calling _WKPHResizePluginInstance synchronously or asynchronously, depending on
whether the size has changed. But sync and async messages are not necessarily delivered in
order - plug-in host listens only to the former while waiting for a response to a message it
sent (a call to invoke() in this case).

Plugins/Hosted/NetscapePluginInstanceProxy.h:
Plugins/Hosted/NetscapePluginInstanceProxy.mm: (WebKit::NetscapePluginInstanceProxy::resize):
Plugins/Hosted/WebHostedNetscapePluginView.mm: (-[WebHostedNetscapePluginView updateAndSetWindow]):

1:31 PM Changeset in webkit [56078] by kov@webkit.org

2 edits in trunk/WebKit/gtk

2010-03-16 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Unreviewed. Add missing symbol to GeoLocation documentation
section.

docs/webkitgtk-sections.txt:

12:35 PM Changeset in webkit [56077] by kov@webkit.org

1 edit
1 add in trunk/WebKit/gtk/po

2010-03-16 Matej Urbančič <mateju@svn.gnome.org>

Reviewed by Gustavo Noronha.

Slovenian translation.

sl.po: Added.

12:14 PM Changeset in webkit [56076] by kov@webkit.org

1 edit
1 add in trunk/WebKit/gtk/po

2010-03-16 António Lima <amrlima@gmail.com>

Reviewed by Gustavo Noronha.

Translation for pt (Portuguese)
https://bugs.webkit.org/show_bug.cgi?id=36148

pt.po: Added.

11:56 AM Changeset in webkit [56075] by eric@webkit.org

1 edit
2 adds in trunk/WebKit

2010-03-16 Leandro Pereira <leandro@profusion.mobi>

Reviewed by Kenneth Rohde Christiansen.

Add EFL port files to efl/WebCoreSupport.
http://webkit.org/b/35916

efl/WebCoreSupport/ContextMenuClientEfl.cpp: Added.
efl/WebCoreSupport/ContextMenuClientEfl.h: Added.

11:53 AM Changeset in webkit [56074] by kbr@google.com

14 edits
2 adds in trunk

2010-03-16 Zhenyao Mo <zmo@google.com>

Reviewed by Darin Fisher.

Hook up WebGLContextAttributes to OpenGL context creation code
https://bugs.webkit.org/show_bug.cgi?id=33416

Test: fast/canvas/webgl/context-attributes-alpha-depth-stencil-antialias.html

src/GraphicsContext3D.cpp: Hook up WebGLContextAttributes to OpenGL context creation code for Windows.

2010-03-16 Zhenyao Mo <zmo@google.com>

Reviewed by Darin Fisher.

Hook up WebGLContextAttributes to OpenGL context creation code
https://bugs.webkit.org/show_bug.cgi?id=33416

Test: fast/canvas/webgl/context-attributes-alpha-depth-stencil-antialias.html

bindings/v8/custom/V8HTMLCanvasElementCustom.cpp: Fix an index bug.
platform/graphics/GraphicsContext3D.h: Add members/functions for multisampling/stencil buffer purpose.
platform/graphics/mac/Canvas3DLayer.h: Add GraphicsContext3D as a member of Canvas3DLayer.
platform/graphics/mac/Canvas3DLayer.mm: Add multisampling support.
platform/graphics/mac/GraphicsContext3DMac.cpp: Hook up WebGLContextAttributes to OpenGL context creation code for Mac.
platform/graphics/mac/GraphicsLayerCA.mm: Adjust to modified Canvas3DLayer init call.

2010-03-16 Zhenyao Mo <zmo@google.com>

Reviewed by Darin Fisher.

Hook up WebGLContextAttributes to OpenGL context creation code
https://bugs.webkit.org/show_bug.cgi?id=33416

fast/canvas/webgl/context-attributes-alpha-depth-stencil-antialias-expected.txt: Added.
fast/canvas/webgl/context-attributes-alpha-depth-stencil-antialias.html: Added.
fast/canvas/webgl/context-attributes-expected.txt: WebGL context attributes behavior changed with this fix.
fast/canvas/webgl/context-attributes.html: Ditto.
fast/canvas/webgl/gl-get-calls-expected.txt: Stencil buffer is enabled, thus Stencil Bits is no longer 0.
fast/canvas/webgl/gl-get-calls.html: Ditto.

11:18 AM Changeset in webkit [56073] by eric@webkit.org

7 edits in trunk

2010-03-16 Joanmarie Diggs <joanmarie.diggs@gmail.com>

Reviewed by Xan Lopez.

Added layout tests to get the number of rows and columns.

https://bugs.webkit.org/show_bug.cgi?id=35504
[Gtk] Evaluate and fix AtkTable for layout tables

platform/gtk/accessibility/table-hierarchy.html:
platform/gtk/accessibility/table-hierarchy-expected.txt:

2010-03-16 Joanmarie Diggs <joanmarie.diggs@gmail.com>

Reviewed by Xan Lopez.

https://bugs.webkit.org/show_bug.cgi?id=35504
[Gtk] Evaluate and fix AtkTable for layout tables

Causes "layout tables" to be exposed as AccessibilityTables for Gtk.

accessibility/AccessibilityTable.cpp: (AccessibilityTable::isTableExposableThroughAccessibility):

2010-03-16 Joanmarie Diggs <joanmarie.diggs@gmail.com>

Reviewed by Xan Lopez.

https://bugs.webkit.org/show_bug.cgi?id=35504
[Gtk] Evaluate and fix AtkTable for layout tables

Implements rowCount and columnCount for Gtk in DRT.

DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp: (AccessibilityUIElement::rowCount): (AccessibilityUIElement::columnCount):

10:41 AM Changeset in webkit [56072] by Martin Robinson

5 edits in trunk/WebKit/gtk

2010-03-16 Martin Robinson <Martin Robinson>

Reviewed by Xan Lopez.

can't input korean into lower all input box except adress input box in webkit gtk launcher
https://bugs.webkit.org/show_bug.cgi?id=32290

Make the GTK+ EditorClient properly handle different types of input module
behavior such as commit and preedit signals that happen outside of key event
filtering and multiple times in a row. Filter keyup events as well as keydown
events and call gtk_im_context_focus_{in/out} when the WebView focus changes.

Added tests for this behavior to the GTK+ unit tests.

WebCoreSupport/EditorClientGtk.cpp: (WebKit::imContextCommitted): Handle this signal properly when it happens outside of key event filtering. (WebKit::imContextPreeditChanged): Immediately update the preedit state and do not reject empty preedits, so that cancellation works properly. (WebKit::EditorClient::updatePendingComposition): Add this method, which handles the situation where a commit signal happens when there is still a pending commit. (WebKit::EditorClient::shouldBeginEditing): Clear pending composition state before editing starts. (WebKit::EditorClient::shouldEndEditing): Clear pending composition state before editing ends. (WebKit::EditorClient::handleKeyboardEvent): No longer special case preedits which happen during key event filtering. When confirming a pending composition use insertText instead of confirmComposition. (WebKit::EditorClient::handleInputMethodKeydown):
WebCoreSupport/EditorClientGtk.h: Make pendingComposition a member, so that multiple WebViews do not share state. (WebKit::EditorClient::webView): Added. (WebKit::EditorClient::treatContextCommitAsKeyEvent): Added. (WebKit::EditorClient::clearPendingComposition): Added.
tests/testkeyevents.c: (test_keypress_events_load_status_cb): (map_event_cb): (setup_keyevent_test): (test_keypress_events): (element_text_equal_to): (test_ime_load_status_cb): (test_ime): (main):
webkit/webkitwebview.cpp: (webkit_web_view_key_release_event): (webkit_web_view_focus_in_event):

10:33 AM Changeset in webkit [56071] by kov@webkit.org

2 edits in trunk/WebCore

Unreviewed. Build fix for distcheck.

10:26 AM Changeset in webkit [56070] by darin@chromium.org

9 edits in trunk

2010-03-15 Darin Fisher <darin@chromium.org>

Reviewed by Adam Barth.

https://bugs.webkit.org/show_bug.cgi?id=36152
[chromium] Add support for history.pushState and history.replaceState

This is covered by the existing tests in fast/loader/stateobjects

9:58 AM Changeset in webkit [56069] by Adam Roben

2 edits in trunk/WebCore

Fix linker warnings when building WebCore on Windows

Rubber-stamped by Steve Falkenburg.

WebCore.vcproj/WebCore.vcproj: Exclude JSDOMFormData.cpp from the

build, since it's already included in DerivedSources.cpp. Also let VS
sort this file as it saw fit.

9:53 AM QtWebKitGraphics edited by noam.rosenthal@nokia.com

(diff)

9:49 AM Changeset in webkit [56068] by Antti Koivisto

6 edits in trunk

WebCore: https://bugs.webkit.org/show_bug.cgi?id=36121
[Qt] Make WebKit scrollbars work with tiling

Reviewed by Simon Hausmann.

Translate coordinates correctly.

page/Frame.cpp:

(WebCore::Frame::tiledBackingStorePaintEnd):

WebKit/qt: https://bugs.webkit.org/show_bug.cgi?id=36121
[Qt] Make WebKit scrollbars work with tiling

Reviewed by Simon Hausmann.

Use the scrollbar overlay (implemented for accelerated compositing) when in tiled mode.
Make overlay compile unconditionally, enable on demand. This removes bunch of unneeded ifdefs.
Update the scroll position to the backing store as needed.
Renamed some methods.

Api/qgraphicswebview.cpp:

(QGraphicsWebViewPrivate::):
(QGraphicsWebViewPrivate::createOrDeleteOverlay):
(QGraphicsWebViewPrivate::setRootGraphicsLayer):
(QGraphicsWebViewPrivate::updateCompositingScrollPosition):
(QGraphicsWebViewPrivate::scroll):
(QGraphicsWebViewPrivate::update):
(QGraphicsWebViewPrivate::graphicsItemVisibleRect):
(QGraphicsWebView::paint):
(QGraphicsWebView::setPage):
(QGraphicsWebView::updateGeometry):
(QGraphicsWebView::setGeometry):

Api/qwebframe.cpp:

(QWebFramePrivate::renderFromTiledBackingStore):

Api/qwebframe_p.h:

9:21 AM Changeset in webkit [56067] by pfeldman@chromium.org

2 edits in trunk/LayoutTests

2010-03-16 Pavel Feldman <pfeldman@chromium.org>

Not reviewed: inspector http test fix that migrates it to the new inspector api.

http/tests/inspector/inspect-iframe-from-different-domain.html:

9:19 AM Changeset in webkit [56066] by zoltan@webkit.org

2 edits in trunk/JavaScriptCore

2010-03-16 Zoltan Horvath <zoltan@webkit.org>

Reviewed by Darin Adler.

Remove extra <new> include and add guards to operator new/delete definitions
https://bugs.webkit.org/show_bug.cgi?id=35967

Remove extra <new> header include from FastAlloc.cpp since it is included in
FastAlloc.h. Add ENABLE(GLOBAL_FASTMALLOC_NEW) macro guard to operator
new/delete/new []/delete [] definitions.

wtf/FastMalloc.cpp:

9:18 AM Changeset in webkit [56065] by jwieczorek@webkit.org

2 edits in trunk/WebCore

2010-03-16 Jakub Wieczorek <jwieczorek@webkit.org>

Reviewed by Eric Seidel.

[Qt] MediaPlayerPrivate: Initialize m_mediaPlayerControl to 0 to
avoid crashes when no media services can be found.

https://bugs.webkit.org/show_bug.cgi?id=36142

platform/graphics/qt/MediaPlayerPrivateQt.cpp: (WebCore::MediaPlayerPrivate::MediaPlayerPrivate):

9:09 AM Changeset in webkit [56064] by abarth@webkit.org

2 edits in trunk/WebCore

2010-03-16 Adam Barth <abarth@webkit.org>

Unreviewed.

noscript tag should render when @sandbox disables JavaScript
https://bugs.webkit.org/show_bug.cgi?id=36092

Add missing "!" in plugin code. Should fix plugins/embed-inside-object
on Gtk and Qt.

plugins/PluginView.cpp: (WebCore::PluginView::load):

9:00 AM Changeset in webkit [56063] by Nate Chapin

2 edits
1 delete in trunk/WebCore

2010-03-16 Nate Chapin <Nate Chapin>

Reviewed by Dimitri Glazkov.

[V8] Delete DerivedSourcesAllInOne.cpp.

https://bugs.webkit.org/show_bug.cgi?id=33048

Android.v8bindings.mk:
bindings/v8/DerivedSourcesAllInOne.cpp: Removed.

8:39 AM Changeset in webkit [56062] by Simon Hausmann

2 edits in trunk/JavaScriptCore

Roll out r55889, as it breaks the Qt port on Leopard

2010-03-11 Kent Hansen <kent.hansen@nokia.com>

Reviewed by Simon Hausmann.

Mac OS X: Use deployment target to determine whether memory tagging should be enabled
https://bugs.webkit.org/show_bug.cgi?id=34888

Use TARGETING_TIGER rather than BUILDING_ON_TIGER to determine the tags.

7:35 AM Changeset in webkit [56061] by kov@webkit.org

2 edits in trunk/WebCore

2010-03-16 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Revert r56006 as it caused functional issues. We will work on a
testcase, and rework the fix, and land when we have this a bit
more testable.

platform/gtk/RenderThemeGtk.cpp: (WebCore::RenderThemeGtk::paintMediaPlayButton):

7:19 AM Changeset in webkit [56060] by robert@webkit.org

2 edits in trunk/WebKit/qt

2010-03-15 Robert Hogan <robert@webkit.org>

Reviewed by Simon Hausmann.

[Qt] Fix crash in QWebView::setPage()

tst_qwebpage was crashing on setPage(0)

https://bugs.webkit.org/show_bug.cgi?id=36137

Api/qwebview.cpp: (QWebView::setPage):

6:58 AM Changeset in webkit [56059] by pfeldman@chromium.org

5 edits in trunk/WebCore

2010-03-16 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: Errors when inspecting styles of non-renderable elements in XHTML.

https://bugs.webkit.org/show_bug.cgi?id=35025

inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::getStyles):
inspector/front-end/DOMAgent.js: (WebInspector.DOMNode.prototype._addAttribute): (WebInspector.DOMWindow.prototype.Object):
inspector/front-end/MetricsSidebarPane.js:
inspector/front-end/StylesSidebarPane.js: (WebInspector.StylesSidebarPane.prototype.update.callback): (WebInspector.StylesSidebarPane.prototype.update): (WebInspector.StylesSidebarPane.prototype._update):

6:37 AM Changeset in webkit [56058] by yurys@chromium.org

2 edits in trunk/WebKit/chromium

2010-03-16 Yury Semikhatsky <yurys@chromium.org>

Unreviewed.

Fix Chromium Mac build: remove unused code.

src/WebDevToolsAgentImpl.cpp: (WebKit::WebDevToolsAgentImpl::createInspectorFrontendProxy):

6:32 AM Changeset in webkit [56057] by tonikitoo@webkit.org

6 edits in trunk

Spatial Navigation: Add a scrollIntoView call when focusing an element.
https://bugs.webkit.org/show_bug.cgi?id=36020

Reviewed by Simon Fraser.
Patch by Antonio Gomes <tonikitoo@webkit.org>

WebCore:

When focusing an element in Spatial Navigation logic, it is desired to make
this element visible in the current viewport. For that to happen, there
could be a call to Element's scrollIntoView method at focusing time. However
for visual aspects, it is preferable to scroll to an inflated rect of |element|
in order to consider the focus outline width.
As Element's scrollIntoView method does not provide this flexibility, patch adds
a custom scrollIntoView method to SpatialNavigation.h .

page/FocusController.cpp:

(WebCore::FocusController::advanceFocusDirectionally):

page/SpatialNavigation.cpp:

(WebCore::scrollIntoView):

page/SpatialNavigation.h:

LayoutTests:

platform/gtk/Skipped: Unskip snav-iframe-with-offscreen-element.html

5:10 AM Changeset in webkit [56056] by kov@webkit.org

2 edits in trunk/LayoutTests

2010-03-16 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

[GStreamer] media/video-played-collapse.html
https://bugs.webkit.org/show_bug.cgi?id=36165

Skip apparently unreliable test. It used to fail locally and pass
on the bots, but the situation is inversed now. We need to
investigate this properly.

platform/gtk/Skipped:

4:57 AM Changeset in webkit [56055] by kov@webkit.org

3 edits in trunk/WebCore

2010-03-10 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Reviewed by Eric Seidel.

[GTK] Position queries are lagging
https://bugs.webkit.org/show_bug.cgi?id=34372

Normalize timeout priorities through the GStreamer media player as
a whole. This should help avoid that any of them is starved.

platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivate::volumeChanged): (WebCore::MediaPlayerPrivate::processBufferingStats): (WebCore::MediaPlayerPrivate::muteChanged):
platform/graphics/gstreamer/VideoSinkGStreamer.cpp: (webkit_video_sink_render):
platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp: (webKitWebSrcNeedDataCb): (webKitWebSrcEnoughDataCb): (webKitWebSrcSeekDataCb):

4:45 AM Changeset in webkit [56054] by kov@webkit.org

2 edits in trunk/WebCore

2010-03-10 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Reviewed by Eric Seidel.

[GTK] Position queries are lagging
https://bugs.webkit.org/show_bug.cgi?id=34372

Use default priority also for parsing data: URIs.

platform/network/soup/ResourceHandleSoup.cpp: (WebCore::startData):

4:44 AM Changeset in webkit [56053] by kov@webkit.org

2 edits in trunk/WebCore

2010-03-10 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Reviewed by Eric Seidel.

[GTK] Position queries are lagging
https://bugs.webkit.org/show_bug.cgi?id=34372

Normalize SharedTimers priorities to always be
G_PRIORITY_DEFAULT. As it is currently, timers that should happen
immediately (0 miliseconds delay) end up delayed by a lot of time
due to glib starving lower priority sources.

platform/gtk/SharedTimerGtk.cpp: (WebCore::setSharedTimerFireTime):

4:44 AM QtWebKitBugs edited by jocelyn.turcotte@nokia.com

Make the new bug link easier to spot on the page (diff)

4:36 AM QtWebKitBugs edited by jocelyn.turcotte@nokia.com

(diff)

4:35 AM QtWebKitBugs edited by jocelyn.turcotte@nokia.com

(diff)

4:11 AM Changeset in webkit [56052] by xan@webkit.org

4 edits in trunk

2010-03-16 Xan Lopez <xlopez@igalia.com>

Reviewed by Gustavo Noronha.

Add support for Fast Mobile Scrolling in the build system.

configure.ac:

WebCore:

2010-03-16 Xan Lopez <xlopez@igalia.com>

Reviewed by Gustavo Noronha.

Add support for Fast Mobile Scrolling in the build system.

GNUmakefile.am:

3:59 AM Changeset in webkit [56051] by yurys@chromium.org

62 edits
2 copies
1 add in trunk

2010-03-11 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Introduce InspectorFrontendClient that provides InspectorFrontend with an interface to the embedder. InspectorClient now serves as a delegate for InspectorController and does not contain methods for managing inspector frontend window. That allows to create remote InspectorFrontendHost.

Introduce InspectorFrontendClient that would provide InspectorFrontend with an interface to the embedder
https://bugs.webkit.org/show_bug.cgi?id=35036

GNUmakefile.am:
WebCore.Inspector.exp:
WebCore.base.exp:
WebCore.gypi:
WebCore.order:
WebCore.pro:
WebCore.xcodeproj/project.pbxproj:
inspector/ConsoleMessage.cpp: (WebCore::ConsoleMessage::addToFrontend):
inspector/ConsoleMessage.h:
inspector/InspectorClient.h:
inspector/InspectorController.cpp: (WebCore::InspectorController::InspectorController): (WebCore::InspectorController::~InspectorController): (WebCore::InspectorController::inspectedPageDestroyed): (WebCore::InspectorController::windowVisible): (WebCore::InspectorController::frontendReady): (WebCore::InspectorController::willCloseFrontend): (WebCore::InspectorController::addConsoleMessage): (WebCore::InspectorController::setInspectorFrontendClient): (WebCore::InspectorController::inspectedWindowScriptObjectCleared): (WebCore::InspectorController::setFrontend): (WebCore::InspectorController::show): (WebCore::InspectorController::close): (WebCore::InspectorController::releaseDOMAgent): (WebCore::InspectorController::populateScriptObjects): (WebCore::InspectorController::didCommitLoad): (WebCore::InspectorController::getProfile): (WebCore::InspectorController::enableDebugger):
inspector/InspectorController.h: (WebCore::InspectorController::hasInspectorFrontendClient):
inspector/InspectorFrontend.cpp: (WebCore::InspectorFrontend::InspectorFrontend): (WebCore::InspectorFrontend::~InspectorFrontend): (WebCore::InspectorFrontend::addConsoleMessage): (WebCore::InspectorFrontend::bringToFront): (WebCore::InspectorFrontend::inspectedURLChanged):
inspector/InspectorFrontend.h:
inspector/InspectorFrontendClient.h: Added. (WebCore::InspectorFrontendClient::~InspectorFrontendClient):
inspector/InspectorFrontendClientLocal.cpp: Added. (WebCore::FrontendMenuProvider::create): (WebCore::FrontendMenuProvider::disconnect): (WebCore::FrontendMenuProvider::FrontendMenuProvider): (WebCore::FrontendMenuProvider::~FrontendMenuProvider): (WebCore::FrontendMenuProvider::populateContextMenu): (WebCore::FrontendMenuProvider::contextMenuItemSelected): (WebCore::FrontendMenuProvider::contextMenuCleared): (WebCore::InspectorFrontendClientLocal::InspectorFrontendClientLocal): (WebCore::InspectorFrontendClientLocal::~InspectorFrontendClientLocal): (WebCore::InspectorFrontendClientLocal::windowObjectCleared): (WebCore::InspectorFrontendClientLocal::frontendLoaded): (WebCore::InspectorFrontendClientLocal::canAttachWindow): (WebCore::InspectorFrontendClientLocal::changeAttachedWindowHeight): (WebCore::InspectorFrontendClientLocal::moveWindowBy): (WebCore::InspectorFrontendClientLocal::showContextMenu): (WebCore::InspectorFrontendClientLocal::setAttachedWindow): (WebCore::InspectorFrontendClientLocal::restoreAttachedWindowHeight): (WebCore::InspectorFrontendClientLocal::constrainedAttachedWindowHeight):
inspector/InspectorFrontendClientLocal.h: Added.
inspector/InspectorFrontendHost.cpp: (WebCore::InspectorFrontendHost::InspectorFrontendHost): (WebCore::InspectorFrontendHost::~InspectorFrontendHost): (WebCore::InspectorFrontendHost::loaded): (WebCore::InspectorFrontendHost::attach): (WebCore::InspectorFrontendHost::detach): (WebCore::InspectorFrontendHost::closeWindow): (WebCore::InspectorFrontendHost::bringToFront): (WebCore::InspectorFrontendHost::inspectedURLChanged): (WebCore::InspectorFrontendHost::canAttachWindow): (WebCore::InspectorFrontendHost::setAttachedWindowHeight): (WebCore::InspectorFrontendHost::moveWindowBy): (WebCore::InspectorFrontendHost::showContextMenu):
inspector/InspectorFrontendHost.h: (WebCore::InspectorFrontendHost::create):
inspector/InspectorFrontendHost.idl:
inspector/front-end/InspectorFrontendHostStub.js: (.WebInspector.InspectorFrontendHostStub.prototype.bringToFront): (.WebInspector.InspectorFrontendHostStub.prototype.inspectedURLChanged):
inspector/front-end/inspector.js: (WebInspector.loaded): (WebInspector.close): (WebInspector.bringToFront): (WebInspector.inspectedURLChanged):
loader/EmptyClients.h: (WebCore::EmptyInspectorClient::openInspectorFrontend):
loader/FrameLoader.cpp: (WebCore::FrameLoader::dispatchDidClearWindowObjectInWorld):
page/Page.cpp: (WebCore::Page::Page): (WebCore::Page::~Page):
page/Page.h:
platform/ContextMenu.cpp: (WebCore::ContextMenu::populate): (WebCore::ContextMenu::addInspectElementItem):

2010-03-16 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Introduce InspectorFrontendClient that provides InspectorFrontend with an interface to the embedder. InspectorClient now serves as a delegate for InspectorController and does not contain methods for managing inspector frontend window. That allows to create remote InspectorFrontendHost.

Introduce InspectorFrontendClient that would provide InspectorFrontend with an interface to the embedder
https://bugs.webkit.org/show_bug.cgi?id=35036

WebCoreSupport/WebInspectorClient.h:
WebCoreSupport/WebInspectorClient.mm: (WebInspectorClient::WebInspectorClient): (WebInspectorClient::inspectorDestroyed): (WebInspectorClient::openInspectorFrontend): (WebInspectorClient::highlight): (WebInspectorClient::hideHighlight): (WebInspectorFrontendClient::WebInspectorFrontendClient): (WebInspectorFrontendClient::frontendLoaded): (WebInspectorFrontendClient::localizedStringsURL): (WebInspectorFrontendClient::hiddenPanels): (WebInspectorFrontendClient::bringToFront): (WebInspectorFrontendClient::closeWindow): (WebInspectorFrontendClient::attachWindow): (WebInspectorFrontendClient::detachWindow): (WebInspectorFrontendClient::setAttachedWindowHeight): (WebInspectorFrontendClient::inspectedURLChanged): (WebInspectorFrontendClient::updateWindowTitle): (-[WebInspectorWindowController dealloc]): (-[WebInspectorWindowController windowShouldClose:]): (-[WebInspectorWindowController close]): (-[WebInspectorWindowController showWindow:]): (-[WebInspectorWindowController attach]): (-[WebInspectorWindowController detach]): (-[WebInspectorWindowController attached]): (-[WebInspectorWindowController setFrontendClient:]): (-[WebInspectorWindowController destroyInspectorView]): (-[WebNodeHighlighter initWithInspectedWebView:]): (-[WebNodeHighlighter dealloc]): (-[WebNodeHighlighter highlightNode:]): (-[WebNodeHighlighter hideHighlight]): (-[WebNodeHighlighter didAttachWebNodeHighlight:]): (-[WebNodeHighlighter willDetachWebNodeHighlight:]):
WebInspector/WebInspector.mm: (-attach:): (-detach:):

2010-03-16 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Introduce InspectorFrontendClient that provides InspectorFrontend with an interface to the embedder. InspectorClient now serves as a delegate for InspectorController and does not contain methods for managing inspector frontend window. That allows to create remote InspectorFrontendHost.

Introduce InspectorFrontendClient that would provide InspectorFrontend with an interface to the embedder
https://bugs.webkit.org/show_bug.cgi?id=35036

WebCoreSupport/WebInspectorClient.cpp: (WebInspectorClient::WebInspectorClient): (WebInspectorClient::~WebInspectorClient): (WebInspectorClient::openInspectorFrontend): (WebInspectorClient::highlight): (WebInspectorClient::hideHighlight): (WebInspectorClient::updateHighlight): (WebInspectorFrontendClient::WebInspectorFrontendClient): (WebInspectorFrontendClient::~WebInspectorFrontendClient): (WebInspectorFrontendClient::frontendLoaded): (WebInspectorFrontendClient::localizedStringsURL): (WebInspectorFrontendClient::hiddenPanels): (WebInspectorFrontendClient::bringToFront): (WebInspectorFrontendClient::closeWindow): (WebInspectorFrontendClient::attachWindow): (WebInspectorFrontendClient::detachWindow): (WebInspectorFrontendClient::setAttachedWindowHeight): (WebInspectorFrontendClient::inspectedURLChanged): (WebInspectorFrontendClient::closeWindowWithoutNotifications): (WebInspectorFrontendClient::showWindowWithoutNotifications): (WebInspectorFrontendClient::destroyInspectorView): (WebInspectorFrontendClient::updateWindowTitle): (WebInspectorFrontendClient::onGetMinMaxInfo): (WebInspectorFrontendClient::onSize): (WebInspectorFrontendClient::onClose): (WebInspectorFrontendClient::onSetFocus): (WebInspectorFrontendClient::onWebViewWindowPosChanging): (WebInspectorWndProc): (WebInspectorFrontendClient::windowReceivedMessage):
WebCoreSupport/WebInspectorClient.h: (WebInspectorClient::frontendClosing):
WebInspector.cpp: (WebInspector::attach): (WebInspector::detach):

2010-03-16 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Introduce InspectorFrontendClient that provides InspectorFrontend with an interface to the embedder. InspectorClient now serves as a delegate for InspectorController and does not contain methods for managing inspector frontend window. That allows to create remote InspectorFrontendHost.

Introduce InspectorFrontendClient that would provide InspectorFrontend with an interface to the embedder
https://bugs.webkit.org/show_bug.cgi?id=35036

Api/qwebinspector.cpp: (QWebInspector::hideEvent): (QWebInspector::closeEvent):
Api/qwebinspector.h:
Api/qwebpage.h:
WebCoreSupport/InspectorClientQt.cpp: (WebCore::InspectorClientQt::openInspectorFrontend): (WebCore::InspectorFrontendClientQt::InspectorFrontendClientQt): (WebCore::InspectorFrontendClientQt::frontendLoaded): (WebCore::InspectorFrontendClientQt::localizedStringsURL): (WebCore::InspectorFrontendClientQt::hiddenPanels): (WebCore::InspectorFrontendClientQt::bringToFront): (WebCore::InspectorFrontendClientQt::closeWindow): (WebCore::InspectorFrontendClientQt::attachWindow): (WebCore::InspectorFrontendClientQt::detachWindow): (WebCore::InspectorFrontendClientQt::setAttachedWindowHeight): (WebCore::InspectorFrontendClientQt::inspectedURLChanged): (WebCore::InspectorFrontendClientQt::updateWindowTitle):
WebCoreSupport/InspectorClientQt.h:

2010-03-16 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Introduce InspectorFrontendClient that provides InspectorFrontend with an interface to the embedder. InspectorClient now serves as a delegate for InspectorController and does not contain methods for managing inspector frontend window. That allows to create remote InspectorFrontendHost.

Introduce InspectorFrontendClient that would provide InspectorFrontend with an interface to the embedder
https://bugs.webkit.org/show_bug.cgi?id=35036

WebCoreSupport/InspectorClientGtk.cpp: (WebKit::notifyWebViewDestroyed): (WebKit::InspectorClient::InspectorClient): (WebKit::InspectorClient::inspectorDestroyed): (WebKit::InspectorClient::openInspectorFrontend): (WebKit::InspectorClient::highlight): (WebKit::InspectorClient::hideHighlight): (WebKit::InspectorClient::populateSetting): (WebKit::InspectorClient::storeSetting): (WebKit::InspectorFrontendClient::InspectorFrontendClient): (WebKit::InspectorFrontendClient::~InspectorFrontendClient): (WebKit::InspectorFrontendClient::destroyInspectorWindow): (WebKit::InspectorFrontendClient::localizedStringsURL): (WebKit::InspectorFrontendClient::hiddenPanels): (WebKit::InspectorFrontendClient::bringToFront): (WebKit::InspectorFrontendClient::closeWindow): (WebKit::InspectorFrontendClient::attachWindow): (WebKit::InspectorFrontendClient::detachWindow): (WebKit::InspectorFrontendClient::setAttachedWindowHeight): (WebKit::InspectorFrontendClient::inspectedURLChanged):
WebCoreSupport/InspectorClientGtk.h:

2010-03-16 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Introduce InspectorFrontendClient that provides InspectorFrontend with an interface to the embedder. InspectorClient now serves as a delegate for InspectorController and does not contain methods for managing inspector frontend window. That allows to create remote InspectorFrontendHost.

Introduce InspectorFrontendClient that would provide InspectorFrontend with an interface to the embedder
https://bugs.webkit.org/show_bug.cgi?id=35036

src/InspectorClientImpl.cpp: (WebKit::InspectorClientImpl::openInspectorFrontend):
src/InspectorClientImpl.h:
src/WebDevToolsAgentImpl.cpp: (WebKit::WebDevToolsAgentImpl::attach): (WebKit::WebDevToolsAgentImpl::didCommitProvisionalLoad): (WebKit::WebDevToolsAgentImpl::createInspectorFrontendProxy): (WebKit::WebDevToolsAgentImpl::setInspectorFrontendProxyToInspectorController):
src/WebDevToolsAgentImpl.h:
src/WebDevToolsFrontendImpl.cpp: (WebKit::WebDevToolsFrontendImpl::WebDevToolsFrontendImpl): (WebKit::WebDevToolsFrontendImpl::jsBringToFront): (WebKit::WebDevToolsFrontendImpl::jsInspectedURLChanged):
src/WebDevToolsFrontendImpl.h:
src/js/InjectDispatch.js: (close):

3:17 AM Changeset in webkit [56050] by pfeldman@chromium.org

2 edits in trunk/WebKit/chromium

2010-03-16 Pavel Feldman <pfeldman@chromium.org>

Not reviewed: chromium tests fix.

src/js/InspectorControllerImpl.js: (devtools.InspectorBackendImpl):

2:32 AM Changeset in webkit [56049] by pfeldman@chromium.org

19 edits in trunk

2010-03-16 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: migrate to native styles inspector in
order to inspect styles from foreighn domains.

https://bugs.webkit.org/show_bug.cgi?id=36117

inspector/InspectorBackend.cpp: (WebCore::InspectorBackend::getStyles): (WebCore::InspectorBackend::getInlineStyle): (WebCore::InspectorBackend::getComputedStyle): (WebCore::InspectorBackend::applyStyleText): (WebCore::InspectorBackend::setStyleText): (WebCore::InspectorBackend::setStyleProperty): (WebCore::InspectorBackend::toggleStyleEnabled): (WebCore::InspectorBackend::setRuleSelector): (WebCore::InspectorBackend::addRule):
inspector/InspectorBackend.h:
inspector/InspectorBackend.idl:
inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::InspectorDOMAgent): (WebCore::InspectorDOMAgent::getStyles): (WebCore::InspectorDOMAgent::getInlineStyle): (WebCore::InspectorDOMAgent::getComputedStyle): (WebCore::InspectorDOMAgent::getMatchedCSSRules): (WebCore::InspectorDOMAgent::getAttributeStyles): (WebCore::InspectorDOMAgent::applyStyleText): (WebCore::InspectorDOMAgent::setStyleText): (WebCore::InspectorDOMAgent::setStyleProperty): (WebCore::InspectorDOMAgent::toggleStyleEnabled): (WebCore::InspectorDOMAgent::setRuleSelector): (WebCore::InspectorDOMAgent::addRule): (WebCore::InspectorDOMAgent::bindStyle): (WebCore::InspectorDOMAgent::bindRule): (WebCore::InspectorDOMAgent::buildObjectForStyle): (WebCore::InspectorDOMAgent::populateObjectWithStyleProperties): (WebCore::InspectorDOMAgent::buildObjectForRule): (WebCore::InspectorDOMAgent::uniqueStyleProperties): (WebCore::InspectorDOMAgent::longhandProperties): (WebCore::InspectorDOMAgent::shorthandPriority): (WebCore::InspectorDOMAgent::ruleAffectsNode): (WebCore::InspectorDOMAgent::toArray):
inspector/InspectorDOMAgent.h:
inspector/InspectorFrontend.cpp: (WebCore::InspectorFrontend::didGetEventListenersForNode): (WebCore::InspectorFrontend::didGetStyles): (WebCore::InspectorFrontend::didGetComputedStyle): (WebCore::InspectorFrontend::didGetInlineStyle): (WebCore::InspectorFrontend::didApplyStyleText): (WebCore::InspectorFrontend::didSetStyleText): (WebCore::InspectorFrontend::didSetStyleProperty): (WebCore::InspectorFrontend::didToggleStyleEnabled): (WebCore::InspectorFrontend::didSetRuleSelector): (WebCore::InspectorFrontend::didAddRule):
inspector/InspectorFrontend.h:
inspector/front-end/DOMAgent.js: (WebInspector.CSSStyleDeclaration):
inspector/front-end/ElementsTreeOutline.js:
inspector/front-end/InjectedScript.js:
inspector/front-end/MetricsSidebarPane.js: (WebInspector.MetricsSidebarPane.prototype.update): (WebInspector.MetricsSidebarPane.prototype.editingCommitted):
inspector/front-end/StylesSidebarPane.js: (WebInspector.StylesSidebarPane.prototype.update): (WebInspector.StylePropertiesSection.prototype.editingSelectorCommitted.callback): (WebInspector.StylePropertiesSection.prototype.editingSelectorCommitted): (WebInspector.BlankStylePropertiesSection.prototype.editingSelectorCommitted.callback): (WebInspector.BlankStylePropertiesSection.prototype.editingSelectorCommitted): (WebInspector.StylePropertyTreeElement.prototype): (WebInspector.StylePropertyTreeElement.prototype.):

1:53 AM Changeset in webkit [56048] by Simon Hausmann

2 edits in trunk

Add WebKitTools/TestResultServer/index.yaml to gitattributes to ignore for crlf conversion.

.gitattributes:

12:39 AM Changeset in webkit [56047] by hamaji@chromium.org

4 edits in trunk/WebCore

2010-03-16 Shinichiro Hamaji <hamaji@chromium.org>

Reviewed by Darin Adler.

RenderText::m_text should be a String, not RefPtr<StringImpl>
https://bugs.webkit.org/show_bug.cgi?id=36010

Refactoring only, so no new tests.

platform/text/PlatformString.h: (WebCore::String::makeLower): (WebCore::String::makeUpper): (WebCore::String::makeSecure): (WebCore::String::makeCapitalized): (WebCore::String::containsOnlyASCII):
rendering/RenderText.cpp: (WebCore::RenderText::RenderText): (WebCore::RenderText::widthFromCache): (WebCore::RenderText::trimmedPrefWidths): (WebCore::RenderText::containsOnlyWhitespace): (WebCore::RenderText::setTextInternal): (WebCore::RenderText::setText): (WebCore::RenderText::previousOffset): (WebCore::RenderText::previousOffsetForBackwardDeletion): (WebCore::RenderText::nextOffset):
rendering/RenderText.h: (WebCore::RenderText::text): (WebCore::RenderText::characters): (WebCore::RenderText::textLength):

12:27 AM Changeset in webkit [56046] by eric@webkit.org

8 edits
2 adds in trunk

2010-03-16 Adam Barth <abarth@webkit.org>

Reviewed by Darin Adler.

noscript tag should render when @sandbox disables JavaScript
https://bugs.webkit.org/show_bug.cgi?id=36092

Test that the noscript element renders when @sandbox disables
JavaScript.

fast/frames/sandboxed-iframe-noscript-expected.txt: Added.
fast/frames/sandboxed-iframe-noscript.html: Added.

2010-03-16 Adam Barth <abarth@webkit.org>

Reviewed by Darin Adler.

noscript tag should render when @sandbox disables JavaScript
https://bugs.webkit.org/show_bug.cgi?id=36092

Instead of talking to Settings directly to figure out if JavaScript is
enabled in a frame, we need to talk to the ScriptController. The
ScriptController is better at answering that question because it knows
about @sandbox.

Test: fast/frames/sandboxed-iframe-noscript.html

dom/Document.cpp: (WebCore::Document::Document):
html/HTMLCanvasElement.cpp: (WebCore::HTMLCanvasElement::createRenderer):
html/HTMLElement.cpp: (WebCore::HTMLElement::rendererIsNeeded):
html/HTMLParser.cpp: (WebCore::HTMLParser::noscriptCreateErrorCheck): (WebCore::HTMLParser::isInline):
plugins/PluginView.cpp: (WebCore::PluginView::load):

12:11 AM Changeset in webkit [56045] by eric@webkit.org

4 edits in trunk/WebKitTools

2010-03-15 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Add "what-broke" command for debugging when the tree broke
https://bugs.webkit.org/show_bug.cgi?id=36157

This is another step towards automated sheriffing of the webkit tree.
With this logic our scripts are able to determine what revision broke the
tree. Buildbot should do this for us, but unfortunately buildbot doesn't
expose this kind of aggregate information.

Scripts/webkitpy/buildbot.py:
- Add new Builder and Build classes (which will eventually replace the custom dictionaries previously used).
- Split out more network logic into _fetch methods which will eventually be their own class for mocking.
- Use XMLRPC to communicate with the buildbot master instead of scraping build pages.
Scripts/webkitpy/buildbot_unittest.py:
- Test the newly added buildbot classes.
Scripts/webkitpy/commands/queries.py:
- Add an experimental what-broke command.

12:08 AM Changeset in webkit [56044] by eric@webkit.org

2 edits in trunk/WebKitTools

2010-03-15 Daniel Bates <dbates@rim.com>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=36048

Detect if the Windows Platform SDK is missing when building with
Visual C++ Express Edition and inform the user to download it.

Scripts/webkitdirs.pm:

Note: See TracTimeline for information about the timeline view.

Download in other formats:

RSS Feed