Timeline
Mar 18, 2010:
- 11:58 PM Changeset in webkit [56218] by
-
- 2 edits in trunk/WebKitTools
2010-03-18 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Add a StatusServer front end to the SVNRevision table on QueueStatusServer
https://bugs.webkit.org/show_bug.cgi?id=36344
No test because Browser was too hard to mock. :( I couldn't figure
out how to make Mock be a dictionary as well as an object.
- Scripts/webkitpy/statusserver.py:
- 11:46 PM Changeset in webkit [56217] by
-
- 4 edits in trunk/WebKit/gtk
2010-03-18 Philip Chimento <philip.chimento@gmail.com>
Reviewed by Oliver Hunt.
Setting the GObject WebKitWebView property 'window-features' to NULL
causes a crash.
https://bugs.webkit.org/show_bug.cgi?id=36144
- tests/testwebview.c: Add unit test for this bug.
- webkit/webkitwebview.cpp: Don't allow the 'window-features' property to be set to NULL.
- webkit/webkitwebwindowfeatures.cpp: (webkit_web_window_features_equal): Don't examine the members of either web_window_features argument if either is NULL, just return that they are not equal. Additionally, if they are the same object, return that they are equal.
- 11:46 PM Changeset in webkit [56216] by
-
- 3 edits2 adds in trunk/WebKitTools
2010-03-18 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Split out CommitInfo class and add unit tests
https://bugs.webkit.org/show_bug.cgi?id=36343
Move more logic out of "what-broke" into a shared CommitInfo
class so that it can be used by other commands and unit tested.
- Scripts/webkitpy/commands/queries.py:
- Scripts/webkitpy/commitinfo.py: Added.
- Scripts/webkitpy/commitinfo_unittest.py: Added.
- Scripts/webkitpy/unittests.py:
- 11:29 PM Changeset in webkit [56215] by
-
- 2 edits in trunk/JavaScriptCore
2010-03-18 Tom Callaway <tcallawa@redhat.com>
Reviewed by Darin Adler.
Bug 35429: Fix compile on SPARC64
https://bugs.webkit.org/show_bug.cgi?id=35429
- wtf/Platform.h: Set WTF_USE_JSVALUE64 for SPARC64
- 11:24 PM Changeset in webkit [56214] by
-
- 3 edits2 adds in trunk
WebCore: Fix a minor crash with mismatched array sizes in SVG animation
elements.
Patch by Chris Evans <cevans@chromium.org> on 2010-03-18
Reviewed by Nikolas Zimmermann.
https://bugs.webkit.org/show_bug.cgi?id=35606
Test: svg/animations/keypoints-mismatch.svg
- svg/SVGAnimationElement.cpp:
(WebCore::SVGAnimationElement::startedActiveInterval):
Globally apply validations relevant to all animation types.
LayoutTests: Add test for minor SVG animation crashers.
See https://bugs.webkit.org/show_bug.cgi?id=35606
Patch by Chris Evans <cevans@chromium.org> on 2010-03-18
Reviewed by Nikolas Zimmermann.
- svg/animations/keypoints-mismatch.svg: Added.
- svg/animations/keypoints-mismatch-expected.txt: Added.
- 11:03 PM Changeset in webkit [56213] by
-
- 2 edits2 adds in trunk/LayoutTests
2010-03-18 Ojan Vafai <ojan@chromium.org>
Reviewed by Eric Seidel.
add new results for failing win/linux test after http://trac.webkit.org/changeset/56175
https://bugs.webkit.org/show_bug.cgi?id=36329
Missed this test in r56175 since it does a drag on win/linux, but not a mac.
The new results correctly do the smart-drag behavior of doing a smart-delete
on drag regardless of whether the selection granularity is word granularity.
- platform/win/editing/selection/drag-text-delay-expected.checksum: Added.
- platform/win/editing/selection/drag-text-delay-expected.png: Added.
- platform/win/editing/selection/drag-text-delay-expected.txt:
- 10:46 PM Changeset in webkit [56212] by
-
- 10 edits6 adds in trunk
2010-03-18 Vangelis Kokkevis <vangelis@chromium.org>
Reviewed by Adam Barth.
Implement software composited graphics layers in Chromium using the Skia library.
https://bugs.webkit.org/show_bug.cgi?id=35557
This is an initial step in the implementation. Layer compositing is functioning
but not optimized in any way. Subsesquent check-ins will be necessary to fine tune
it.
Test: No new exposed functionality so no new tests.
- WebCore.gypi: Added new source files to the chromium build
- platform/graphics/GraphicsLayer.h: Added necessary typedef's and forward declarations for Chromium.
- platform/graphics/skia/GraphicsLayerSkia.cpp: Added.
- platform/graphics/skia/GraphicsLayerSkia.h: Added. Declaration and implementation of the platform-specific GraphicsLayer class.
- platform/graphics/skia/LayerRendererSkia.cpp: Added.
- platform/graphics/skia/LayerRendererSkia.h: Added. Declaration and implementation of the Skia-based software compositor.
- platform/graphics/skia/LayerSkia.cpp: Added.
- platform/graphics/skia/LayerSkia.h: Added. Declaration and implementation of a compositable layer that uses a Skia canvas for backing store.
2010-03-18 Vangelis Kokkevis <vangelis@chromium.org>
Reviewed by Adam Barth.
Adding support for the ACCELERATED_COMPOSITING render path to Chromium.
https://bugs.webkit.org/show_bug.cgi?id=35557
Currently compositing of layers is performed via s/w compositor which relies on Skia. This is an initial check-in
and it's only been tested on Windows. Compiling the code requires seting "use_accelerated_compositing=1"
to GYP_DEFINES. The update of layer contents and compositing is fairly inefficient but this will be fixed in
subsequent check-ins.
- src/ChromeClientImpl.cpp: (WebKit::ChromeClientImpl::attachRootGraphicsLayer): (WebKit::ChromeClientImpl::scheduleCompositingLayerSync):
- src/ChromeClientImpl.h: (WebKit::ChromeClientImpl::setNeedsOneShotDrawingSynchronization): Added methods required by the RenderLayerCompositor
- src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::paintWithContext): (WebKit::WebFrameImpl::paint):
- src/WebFrameImpl.h: Split WebFrameImpl::paint() into two methods to make it possible to call the paint routine with an existing GraphicsContext, which is necessary for painting the root layer into its own backing surface.
- src/WebViewImpl.cpp: (WebKit::WebViewImpl::WebViewImpl): (WebKit::WebViewImpl::paint): Modified method to handle the accelerated compositing path. Now, when doing accelerated compositing, paint() results in repainting the contents of the root layer and then doing a composite operation. (WebKit::WebViewImpl::setRootGraphicsLayer): (WebKit::WebViewImpl::setAcceleratedCompositing): (WebKit::WebViewImpl::updateRootLayerContents): (WebKit::WebViewImpl::setRootLayerNeedsDisplay):
- src/WebViewImpl.h: (WebKit::WebViewImpl::isAcceleratedCompositing):
- 10:32 PM Changeset in webkit [56211] by
-
- 5 edits in trunk
2010-03-18 Laszlo Gombos <Laszlo Gombos>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Fix LayoutTests/http/tests/appcache/max-size.html
https://bugs.webkit.org/show_bug.cgi?id=36207
- platform/qt/Skipped:
2010-03-18 Laszlo Gombos <Laszlo Gombos>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Fix LayoutTests/http/tests/appcache/max-size.html
https://bugs.webkit.org/show_bug.cgi?id=36207
Implement setAppCacheMaximumSize() for Qt.
- DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::setAppCacheMaximumSize):
- DumpRenderTree/qt/LayoutTestControllerQt.h:
- 10:13 PM Changeset in webkit [56210] by
-
- 6 edits4 copies1 add in trunk/WebKitTools
2010-03-18 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
QueueStatusServer should be able to log broken bots
https://bugs.webkit.org/show_bug.cgi?id=36341
We need to add a new table to the QueueStatusServer to store persistent
information for the SheriffBot. The new table will keep track of which
bots each SVN revision broke.
- QueueStatusServer/handlers/init.py:
- QueueStatusServer/handlers/svnrevision.py: Added.
- QueueStatusServer/handlers/updatebase.py: Added.
- QueueStatusServer/handlers/updatestatus.py:
- QueueStatusServer/handlers/updatesvnrevision.py: Added.
- QueueStatusServer/index.yaml:
- QueueStatusServer/main.py:
- QueueStatusServer/model/init.py:
- QueueStatusServer/model/svnrevision.py: Added.
- QueueStatusServer/templates/updatesvnrevision.html: Added.
- 10:11 PM Changeset in webkit [56209] by
-
- 15 edits2 adds in trunk
2010-03-18 Kenneth Rohde Christiansen <kenneth@webkit.org>
Reviewed by Darin Adler.
Add a new test for testing whether the media type is restores
properly after printing a page (changing media type to 'print').
Add expected result and skip the test for platform that do not
implement setMediaType().
- fast/media/print-restores-previous-mediatype-expected.txt: Added.
- fast/media/print-restores-previous-mediatype.html: Added.
- platform/gtk/Skipped:
- platform/mac/Skipped:
- platform/win/Skipped:
2010-03-18 Kenneth Rohde Christiansen <kenneth@webkit.org>
Reviewed by Darin Adler.
Make setPrinting() with printing=false, restore the previous
media type in use.
Test: fast/media/print-restores-previous-mediatype.html
- page/Frame.cpp: (WebCore::Frame::setPrinting):
- page/FrameView.cpp: (WebCore::FrameView::adjustMediaTypeForPrinting):
- page/FrameView.h:
2010-03-18 Kenneth Rohde Christiansen <kenneth@webkit.org>
Reviewed by Darin Adler.
Make it possible for the Qt DRT to set the media type from
the LayoutTestController.
- Api/qwebframe.cpp: (qt_drt_setMediaType):
2010-03-18 Kenneth Rohde Christiansen <kenneth@webkit.org>
Reviewed by Darin Adler.
Add a new method to the Qt LayoutTestController for
changing media type and make the DRT support dry-run printing.
- DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::DumpRenderTree::DumpRenderTree): (WebCore::DumpRenderTree::dryRunPrint):
- DumpRenderTree/qt/DumpRenderTreeQt.h:
- DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::setMediaType):
- DumpRenderTree/qt/LayoutTestControllerQt.h:
- 9:51 PM Changeset in webkit [56208] by
-
- 5 edits in trunk/WebKit/qt
2010-03-18 Joe Ligman <joseph.ligman@nokia.com>
Reviewed by Simon Hausmann.
[Qt] New API scrollRecursively has several problems.
https://bugs.webkit.org/show_bug.cgi?id=35873
Remove scrollRecursively from the Qt 4.7 API
Update the internal API to accept a hit test position
for nested scrolling
- Api/qwebframe.cpp: (webframe_scrollOverflow): (qtwebkit_webframe_scrollRecursively):
- Api/qwebframe.h:
- Api/qwebframe_p.h:
- tests/qwebframe/tst_qwebframe.cpp:
- 8:58 PM Changeset in webkit [56207] by
-
- 5 edits in trunk/LayoutTests
Update test results after r56182. "background-color: rgba(0, 0, 0, 0)" is now reported as "background-color: transparent".
Rubber-stamped by Samuel Weinig.
- fast/css/getComputedStyle/computed-style-expected.txt:
- platform/mac/fast/css/getComputedStyle/computed-style-expected.txt:
- platform/qt/fast/css/getComputedStyle/computed-style-expected.txt:
- platform/win/fast/css/getComputedStyle/computed-style-expected.txt:
- 6:33 PM Changeset in webkit [56206] by
-
- 2 edits in trunk/WebCore
<http://webkit.org/b/36338> Remove unused RenderReplaced::adjustOverflowForBoxShadowAndReflect() declaration
Rubber-stamped by Darin Adler.
This declaration should have been removed in r47440.
- rendering/RenderReplaced.h:
(WebCore::RenderReplaced::adjustOverflowForBoxShadowAndReflect): Removed.
- 6:05 PM Changeset in webkit [56205] by
-
- 4 edits2 adds in trunk
Dragging a PDF image triggers assertion in DragController::startDrag()
https://bugs.webkit.org/show_bug.cgi?id=36247
Reviewed by Dmitry Titov.
WebCore:
Test: fast/images/drag-pdf-as-image.html
- platform/graphics/cg/PDFDocumentImage.cpp:
(WebCore::PDFDocumentImage::filenameExtension):
- platform/graphics/cg/PDFDocumentImage.h:
LayoutTests:
- fast/images/drag-pdf-as-image-expected.txt: Added.
- fast/images/drag-pdf-as-image.html: Added.
- 5:21 PM Changeset in webkit [56204] by
-
- 2 edits in trunk/WebCore
2010-03-18 Simon Fraser <Simon Fraser>
Reviewed by Dan Bernstein.
Avoid taking a reference to a String owned by a temporary AtomicString.
- css/CSSSelector.cpp: (WebCore::CSSSelector::RareData::parseNth):
- 5:17 PM Changeset in webkit [56203] by
-
- 2 edits in trunk/LayoutTests/fast
Land new expected results.
- 4:23 PM Changeset in webkit [56202] by
-
- 1 edit1 add in trunk/LayoutTests
Add missing file from r56186.
- fast/dynamic/float-remove-above-line-2-expected.txt: Added.
- 4:03 PM Changeset in webkit [56201] by
-
- 6 edits in trunk/WebKit/chromium
Chromium interface change to support Blob.slice.
https://bugs.webkit.org/show_bug.cgi?id=35318
Reviewed by Darin Fisher.
- features.gypi:
- public/WebHTTPBody.h:
- public/WebKitClient.h:
(WebKit::WebKitClient::getFileModificationTime):
- src/ChromiumBridge.cpp:
(WebCore::ChromiumBridge::getFileModificationTime):
- src/WebHTTPBody.cpp:
(WebKit::WebHTTPBody::elementAt):
(WebKit::WebHTTPBody::appendFile):
(WebKit::WebHTTPBody::appendFileRange):
- 4:00 PM Changeset in webkit [56200] by
-
- 4 edits in trunk/WebCore
Fixed parenting issues with HW layers on Windows
https://bugs.webkit.org/show_bug.cgi?id=32449
- 3:45 PM Changeset in webkit [56199] by
-
- 4 edits in trunk/WebKitTools
2010-03-18 Dirk Pranke <dpranke@chromium.org>
Reviewed by Dimitri Glazkov.
Add upstream LayoutTests/platform/chromium* directories to the
baseline search path for new-run-webkit-tests in preparation for
upstreaming all of the Chromium baselines. Note that this does
not actually create the directories themselves, but that's okay.
- Scripts/webkitpy/layout_tests/port/chromium_linux.py:
- Scripts/webkitpy/layout_tests/port/chromium_mac.py:
- Scripts/webkitpy/layout_tests/port/chromium_win.py:
- 3:42 PM Changeset in webkit [56198] by
-
- 3 edits2 adds in trunk
Reviewed by Anders Carlsson.
https://bugs.webkit.org/show_bug.cgi?id=36327
Test that a plug-in can override Node methods of its element
- plugins/override-node-method-expected.txt: Added.
- plugins/override-node-method.html: Added.
- 3:42 PM Changeset in webkit [56197] by
-
- 2 edits in trunk/WebCore
Unreviewed, build fix.
[Chromium] Change the order of mac/ and cg/ include dirs to fix compile break
due to http://trac.webkit.org/changeset/56192,
- WebCore.gyp/WebCore.gyp: Changed the order.
- 2:51 PM Changeset in webkit [56196] by
-
- 2 edits in trunk/WebCore
2010-03-18 Simon Fraser <Simon Fraser>
No review.
Fix brace style after r56170.
- css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector):
- 2:39 PM Changeset in webkit [56195] by
-
- 5 edits2 adds in trunk
https://bugs.webkit.org/show_bug.cgi?id=36325
Reviewed by Oliver Hunt.
Add support for stopImmediatePropagation from DOM Level 3 Events.
Added fast/events/stop-immediate-propagation.html.
- dom/Event.cpp:
(WebCore::Event::Event):
- dom/Event.h:
(WebCore::Event::timeStamp):
(WebCore::Event::stopPropagation):
(WebCore::Event::stopImmediatePropagation):
(WebCore::Event::propagationStopped):
(WebCore::Event::immediatePropagationStopped):
- dom/Event.idl:
- dom/EventTarget.cpp:
(WebCore::EventTarget::fireEventListeners):
- 2:26 PM Changeset in webkit [56194] by
-
- 2 edits in trunk/WebCore
Unreviewed, build fix.
Return frame accessor back to Geolocation, it's used in GeolocationServiceChromium.
The accessor was removed in http://trac.webkit.org/changeset/56188.
- page/Geolocation.h:
(WebCore::Geolocation::frame): Added back.
- 2:21 PM Changeset in webkit [56193] by
-
- 4 edits1 add in trunk/WebKitTools
2010-03-17 Dirk Pranke <dpranke@chromium.org>
Reviewed by Dimitri Glazkov.
Add the concept of an "overrides" file for expectations so that we
can store test_expectations both upstream and downstream for a port
that runs both in webkit.org and in a separate repository (like
Chromium). Also add some unit tests for the expectations module.
- Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
- Scripts/webkitpy/layout_tests/layout_package/test_expectations_test.py: Added.
- Scripts/webkitpy/layout_tests/port/base.py:
- Scripts/webkitpy/layout_tests/run_webkit_tests.py:
- 2:20 PM Changeset in webkit [56192] by
-
- 5 edits1 move1 add in trunk/WebCore
Help reduce build problems due to font declarations.
https://bugs.webkit.org/show_bug.cgi?id=36190
Reviewed by Adam Roben.
Functions unchanged, no new tests.
- WebCore.vcproj/WebCore.vcproj: Add new file, and show movement of FontPlatformData.h to cg/ directory.
- platform/graphics/cairo/FontPlatformData.h: Merge in WinCairo-specific declarations. Correct constructor declaration to use type float for font size.
(WebCore::FontPlatformData::FontPlatformData):
(WebCore::FontPlatformData::hfont):
(WebCore::FontPlatformData::useGDI):
(WebCore::FontPlatformData::fontFace):
(WebCore::FontPlatformData::setSize):
(WebCore::FontPlatformData::hash):
(WebCore::FontPlatformData::isHashTableDeletedValue):
- platform/graphics/cairo/FontPlatformDataCairo.cpp:
(WebCore::FontPlatformData::FontPlatformData): Correct
constructor to accept type float for font size.
- platform/graphics/cg/FontPlatformData.h: Copied from WebCore/platform/graphics/win/FontPlatformData.h.
(WebCore::FontPlatformData::FontPlatformData):
(WebCore::FontPlatformData::hfont):
(WebCore::FontPlatformData::cgFont):
(WebCore::FontPlatformData::operator==):
- platform/graphics/win/FontPlatformData.h: Removed.
- platform/graphics/win/FontPlatformDataCairoWin.cpp:
(WebCore::FontPlatformData::operator==): Move implementation
here (previously in header) to match other cairo-based ports.
- platform/graphics/win/RefCountedHFONT.h: Added. This was extracted from win/FontPlatformData.h, and is now shared by the cg/FontPlatformData.h and cairo/FontPlatformData.h
(WebCore::RefCountedHFONT::create):
(WebCore::RefCountedHFONT::createDeleted):
(WebCore::RefCountedHFONT::~RefCountedHFONT):
(WebCore::RefCountedHFONT::hfont):
(WebCore::RefCountedHFONT::hash):
(WebCore::RefCountedHFONT::RefCountedHFONT):
- 2:14 PM Changeset in webkit [56191] by
-
- 3 edits2 adds in trunk
2010-03-18 Simon Fraser <Simon Fraser>
Reviewed by Dave Hyatt.
https://bugs.webkit.org/show_bug.cgi?id=36274
CSS3 :nth-child selector 'odd' keyword case sensitivity test fails
The tests for "odd", "even" etc. for nth-child selectors should be case insensitive.
Test: fast/css/nth-child-odd-case-insensitive.html
- css/CSSSelector.cpp: (WebCore::CSSSelector::RareData::parseNth):
- 2:10 PM Changeset in webkit [56190] by
-
- 2 edits2 adds in trunk
https://bugs.webkit.org/show_bug.cgi?id=36265
Reviewed by Oliver Hunt.
Add support for event.defaultPrevented from DOM level 3.
Added fast/events/defaultprevented.html
- dom/Event.idl:
- 1:51 PM Changeset in webkit [56189] by
-
- 7 edits in trunk/JavaScriptCore
2010-03-18 Oliver Hunt <oliver@apple.com>
Reviewed by Sam Weinig.
Add API to directly expose JSON parsing
https://bugs.webkit.org/show_bug.cgi?id=34887
Add API to expose JSON parsing directly, and add tests to testapi
- API/JSValueRef.cpp: (JSValueMakeFromJSONString): (JSValueCreateJSONString):
- API/tests/testapi.c: (main):
- JavaScriptCore.exp:
- runtime/JSONObject.cpp: (JSC::JSONStringify):
- runtime/JSONObject.h:
- 1:42 PM Changeset in webkit [56188] by
-
- 5 edits in trunk/WebCore
Remove Geolocation.lastPosition, no longer in the spec.
https://bugs.webkit.org/show_bug.cgi?id=36255
rdar://problem/7746357
Reviewed by Kenneth Rohde Christiansen.
- WebCore.base.exp: Updated since Geolocation's destructor is now non-virtual.
- page/Geolocation.cpp:
(WebCore::Geolocation::lastPosition): Add an assertion; it's only legal to
call this if access to the location is allowed.
- page/Geolocation.h: Removed unneeded includes. Made destructor non-virtual,
although it will still be virtual if any of the base classes have a virtual
destructor. Made lastPosition, isAllowed, and isDenied functions private.
Removed unused suspend, resume, setShouldClearCache, shouldClearCache,
and frame functions.
- page/Geolocation.idl: Removed lastPosition read-only attribute. No longer in
the Geolocation specification.
- 1:37 PM Changeset in webkit [56187] by
-
- 3 edits2 adds in trunk
https://bugs.webkit.org/show_bug.cgi?id=36275
Reviewed by Simon Fraser.
Make sure :not does not allow pseudo-elements inside it. (Hooray for another pointless
restriction on :not.)
Added fast/css/invalid-not-with-pseudo-element.html
- css/CSSGrammar.y:
- css/CSSSelector.h:
(WebCore::CSSSelector::matchesPseudoElement):
- 1:33 PM Changeset in webkit [56186] by
-
- 6 edits1 copy in trunk
WebCore: <rdar://problem/7761400> Rework the fix for
https://bugs.webkit.org/show_bug.cgi?id=18722
Reviewed by Darin Adler.
Test: fast/dynamic/float-remove-above-line-2.html
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::removeFloatingObject): Treat 0- and less-than-0-height floats
as having a height of 1 so that they intersect with the line they originate on.
(WebCore::RenderBlock::clearFloats): Use numeric_limits.
- rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::layoutInlineChildren): Removed the intersection checks here,
so that a float is always included in the float list of the line it originates on, even
if it does not intersect that line. This ensures that every float is accounted for, which
is necessary during incremental layout when adding floats from clean lines.
LayoutTests: Additional test for <rdar://problem/7761400>
Reviewed by Darin Adler.
- fast/dynamic/float-remove-above-line-2.html: Copied from LayoutTests/fast/dynamic/float-remove-above-line.html.
- fast/dynamic/float-remove-above-line-expected.txt: Updated.
- fast/dynamic/float-remove-above-line.html: Fixed inconsequential typo in end tag.
- 1:29 PM Changeset in webkit [56185] by
-
- 1 add in trunk/LayoutTests/fast/css/invalid-import-rule-insertion-expected.txt
Add expected results.
- 1:19 PM Changeset in webkit [56184] by
-
- 6 edits in trunk
2010-03-18 Antti Koivisto <koivisto@iki.fi>
Reviewed by Kenneth Rohde Christiansen.
https://bugs.webkit.org/show_bug.cgi?id=36102
[Qt] Scaling control API for tiled backing store
Commit the new scale synchronously after unfreeze to avoid ugliness.
- platform/graphics/TiledBackingStore.cpp: (WebCore::TiledBackingStore::TiledBackingStore): (WebCore::TiledBackingStore::setContentsScale): (WebCore::TiledBackingStore::commitScaleChange): (WebCore::TiledBackingStore::setContentsFrozen):
- platform/graphics/TiledBackingStore.h:
2010-03-18 Antti Koivisto <koivisto@iki.fi>
Reviewed by Kenneth Rohde Christiansen.
https://bugs.webkit.org/show_bug.cgi?id=36102
[Qt] Scaling control API for tiled backing store
The scale is set by passing the QGraphicsWebView scale to the backing store. The
only new API is the tiledBackingStoreFrozen property which allows disabling
all updates (for example during zoom animation).
- Api/qgraphicswebview.cpp: (QGraphicsWebViewPrivate::_q_scaleChanged): (QGraphicsWebViewPrivate::updateTiledBackingStoreScale): (QGraphicsWebView::QGraphicsWebView): (QGraphicsWebView::isTiledBackingStoreFrozen): (QGraphicsWebView::setTiledBackingStoreFrozen):
- Api/qgraphicswebview.h:
- Api/qwebframe.cpp:
- Api/qwebframe_p.h:
- 1:18 PM QtWebKitRelease20 edited by
- (diff)
- 1:07 PM Changeset in webkit [56183] by
-
- 3 edits in trunk/WebKitTools
2010-03-18 Jesus Sanchez-Palencia <jesus.palencia@openbossa.org>
Reviewed by Kenneth Rohde Christiansen.
Add an overlay QGraphicsTextItem to QtLauncher so we can display FPS info
on the launcher and not on the terminal anymore.
[Qt] QtLauncher's FPS info should be displayed on an overlay text item
https://bugs.webkit.org/show_bug.cgi?id=36244
- QtLauncher/webview.cpp: (WebViewGraphicsBased::WebViewGraphicsBased): (WebViewGraphicsBased::setFrameRateMeasurementEnabled): (WebViewGraphicsBased::updateFrameRate):
- QtLauncher/webview.h:
- 12:50 PM Changeset in webkit [56182] by
-
- 8 edits1 add in trunk
https://bugs.webkit.org/show_bug.cgi?id=36281
Reviewed by Simon Fraser.
Make sure an exception is raised if an @import rule is inserted in the wrong place.
Also make sure (so that this particular test case passes) that rgba(0, 0, 0, 0) is dumped
as transparent by getComputedStyle, since it most commonly occurs in background-color and
that default makes more sense than dumping rgba values.
Added fast/css/invalid-import-insertion.html
- css/CSSPrimitiveValue.cpp:
(WebCore::CSSPrimitiveValue::createColor):
- css/CSSStyleSheet.cpp:
(WebCore::CSSStyleSheet::insertRule):
- 12:49 PM Changeset in webkit [56181] by
-
- 8 edits2 adds in trunk/WebKitTools
2010-03-18 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
First cut at SheriffBot
https://bugs.webkit.org/show_bug.cgi?id=36253
This patch contains a first attempt at writing a sheriff bot.
Currently, we're missing the logic that actually finds the SVN revision
numbers to complain about, but once we have that, we'll have the rest
of the infrustructure to ping IRC and to file bugs.
There's a lot to fill in for the SheriffBot, but this patch give us the
framework in which to do it.
This patch required a bit of refactoring of AbstractQueue because
SheriffBot is the first bot that doesn't process patches (it processes
SVN revisions). Accordingly, I've factored out AbstractPatchQueue to
hold the parts of AbstractQueue that are specific to dealing with
patches. Some of the choices here might not be obvious yet, but we can
tweak them as our needs become clearer.
- Scripts/webkitpy/commands/queues.py:
- Scripts/webkitpy/commands/queues_unittest.py:
- Scripts/webkitpy/commands/sheriffbot.py: Added.
- Scripts/webkitpy/commands/sheriffbot_unittest.py: Added.
- Scripts/webkitpy/mock_bugzillatool.py:
Added a MockIRC object to the mock tool.
- Scripts/webkitpy/multicommandtool.py:
Added a finalize method so the tool can disconnect from IRC
cleanly instead of just droping the socket.
- Scripts/webkitpy/multicommandtool_unittest.py:
- Scripts/webkitpy/patch/patcher.py:
Added support for talking to IRC.
- Scripts/webkitpy/unittests.py:
We should add a commands/unittests.py file at some point to make
the commands module more self-contained.
- 12:32 PM Changeset in webkit [56180] by
-
- 5 edits in trunk/WebCore
2010-03-18 Luiz Agostini <luiz.agostini@openbossa.org>
Reviewed by Kenneth Rohde Christiansen.
Multiselect Popup - Listbox click simulation
https://bugs.webkit.org/show_bug.cgi?id=36177
Listbox popups will need to notify the corresponding select elements that a
selection change happened. The current HTMLSelectElement interface does not
allow multiple selections.
The new method listBoxSelectItem will be used for that. I have refactored part
of the mouse handling code in bug 36124 and I am now reusing it here for
<select multiple> popups. All the other cases will handled as they were before to be
sure that no side effects will show up.
- dom/SelectElement.cpp: (WebCore::SelectElement::updateListBoxSelection): (WebCore::SelectElement::listBoxOnChange):
- dom/SelectElement.h:
- html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::listBoxPopupClick):
- html/HTMLSelectElement.h:
- 12:14 PM Changeset in webkit [56179] by
-
- 3 edits in trunk/WebKitTools
2010-03-18 Antti Koivisto <koivisto@iki.fi>
Reviewed by Kenneth Rohde Christiansen.
https://bugs.webkit.org/show_bug.cgi?id=36102
[Qt] Scaling control API for tiled backing store
Add animated smooth zooming to Qt launcher when in tiled mode.
- QtLauncher/main.cpp: (LauncherWindow::LauncherWindow): (LauncherWindow::zoomAnimationFinished): (LauncherWindow::applyZoom): (LauncherWindow::zoomIn): (LauncherWindow::zoomOut):
- QtLauncher/webview.h: (WebViewGraphicsBased::graphicsWebView):
- 11:56 AM Changeset in webkit [56178] by
-
- 4 edits in trunk/WebKitTools
2010-03-18 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Support using IRC accounts with a password
https://bugs.webkit.org/show_bug.cgi?id=36287
Add a global option to specify an IRC password so we can use the
sheriffbot account (which needs a password).
- Scripts/webkitpy/irc/ircbot.py:
- Scripts/webkitpy/irc/ircproxy.py:
- Scripts/webkitpy/patch/patcher.py:
- 11:37 AM Changeset in webkit [56177] by
-
- 1 edit2 copies in trunk/LayoutTests
Not reviewed.
https://bugs.webkit.org/show_bug.cgi?id=36210
plugins/resize-from-plugin.html fails on some platforms
Landing new results for Qt and Gtk, taken from buildbot.
Gtk results are a pass, although the difference in clip rect may indicate some issue to look into.
Qt results are a failure.
- platform/gtk/plugins/resize-from-plugin-expected.txt: Copied from LayoutTests/plugins/resize-from-plugin-expected.txt.
- platform/qt/plugins/resize-from-plugin-expected.txt: Copied from LayoutTests/plugins/resize-from-plugin-expected.txt.
- 11:33 AM Changeset in webkit [56176] by
-
- 2 edits in trunk/WebKitTools
2010-03-18 Eric Seidel <eric@webkit.org>
Just fixing missing parenthesis typo, no review.
- Scripts/webkitpy/commands/queries.py: '%' has higher precedence than 'or', use parentheses.
- 11:23 AM Changeset in webkit [56175] by
-
- 37 edits in trunk
2010-03-12 Ojan Vafai <ojan@chromium.org>
Reviewed by David Levin.
smartdelete should only occur after double-click
https://bugs.webkit.org/show_bug.cgi?id=35314
- editing/deleting/non-smart-delete.html:
- editing/pasteboard/drag-drop-modifies-page.html:
- editing/pasteboard/page-zoom-expected.txt: Space is removed because we used to incorrectly smartpaste here. New behavior matches NSTextView.
- editing/style/apply-through-end-of-document-expected.txt: The change here is that selectall + smartpaste doesn't put a BR, but selectall + normal-paste does. Not sure if that's a bug or not, but it's not a side effect of this change.
- editing/style/style-boundary-005.html:
- platform/mac/editing/deleting/non-smart-delete-expected.checksum:
- platform/mac/editing/deleting/non-smart-delete-expected.png:
- platform/mac/editing/deleting/non-smart-delete-expected.txt:
- platform/mac/editing/execCommand/paste-1-expected.txt:
- platform/mac/editing/execCommand/paste-2-expected.txt:
- platform/mac/editing/pasteboard/drag-drop-modifies-page-expected.checksum:
- platform/mac/editing/pasteboard/drag-drop-modifies-page-expected.png:
- platform/mac/editing/pasteboard/drag-drop-modifies-page-expected.txt:
- platform/mac/editing/selection/expanding-selections-expected.txt:
- platform/mac/editing/selection/expanding-selections2-expected.txt:
- platform/mac/editing/selection/triple-click-in-pre-expected.txt: The above three results change because granularity is no longer part of the seleciton, so changes in granularity don't fire selection change notifications.
- platform/mac/editing/style/style-boundary-005-expected.checksum:
- platform/mac/editing/style/style-boundary-005-expected.png:
- platform/mac/editing/style/style-boundary-005-expected.txt:
2010-03-12 Ojan Vafai <ojan@chromium.org>
Reviewed by David Levin.
smartdelete should only occur after double-click
https://bugs.webkit.org/show_bug.cgi?id=35314
- Consolidate all notions of selection-granularity into SelectionController.
- Now only mouse-based selections store a selection-granularity. This matches NSTextView.
New tests were added in http://trac.webkit.org/changeset/55913.
- WebCore.base.exp:
- editing/MoveSelectionCommand.cpp: (WebCore::MoveSelectionCommand::MoveSelectionCommand): (WebCore::MoveSelectionCommand::doApply):
- editing/MoveSelectionCommand.h: (WebCore::MoveSelectionCommand::create):
- editing/SelectionController.cpp: (WebCore::SelectionController::SelectionController): (WebCore::SelectionController::setSelection): (WebCore::SelectionController::modify): (WebCore::SelectionController::clear):
- editing/SelectionController.h: (WebCore::SelectionController::setSelection): (WebCore::SelectionController::granularity):
- editing/VisibleSelection.cpp: (WebCore::VisibleSelection::VisibleSelection): (WebCore::VisibleSelection::expandUsingGranularity): (WebCore::VisibleSelection::setStartAndEndFromBaseAndExtentRespectingGranularity): (WebCore::VisibleSelection::validate):
- editing/VisibleSelection.h: (WebCore::operator==):
- loader/FrameLoader.cpp: (WebCore::FrameLoader::clear):
- page/DOMSelection.cpp: (WebCore::DOMSelection::extend):
- page/DragController.cpp: (WebCore::DragController::concludeEditDrag):
- page/EventHandler.cpp: (WebCore::EventHandler::selectClosestWordFromMouseEvent): (WebCore::EventHandler::selectClosestWordOrLinkFromMouseEvent): (WebCore::EventHandler::handleMousePressEventTripleClick): (WebCore::EventHandler::handleMousePressEventSingleClick): (WebCore::EventHandler::updateSelectionForMouseDrag):
- page/Frame.cpp: (WebCore::Frame::Frame): (WebCore::Frame::selectionGranularity):
- page/Frame.h:
- rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::setSelectionRange):
2010-03-12 Ojan Vafai <ojan@chromium.org>
Reviewed by David Levin.
smartdelete should only occur after double-click
https://bugs.webkit.org/show_bug.cgi?id=35314
- src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::selectWordAroundPosition):
- 11:22 AM Changeset in webkit [56174] by
-
- 4 edits2 adds in trunk
2010-03-18 Simon Fraser <Simon Fraser>
Reviewed by Dave Hyatt.
https://bugs.webkit.org/show_bug.cgi?id=36273
CSS3 :indeterminate and input type=radio test fails
The :indeterminate pseudo-class should apply to both radio buttons and checkboxes.
- html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::setIndeterminate): Use allowsIndeterminate() to determine if the input supports the indeterminate state. (WebCore::HTMLInputElement::preDispatchEventHandler): Use allowsIndeterminate() to determine whether to handle the indeterminate state. (WebCore::HTMLInputElement::postDispatchEventHandler): Ditto.
- html/HTMLInputElement.h: (WebCore::HTMLInputElement::allowsIndeterminate): New utility method, returns true for radio buttons and checkboxes.
- 11:11 AM Changeset in webkit [56173] by
-
- 4 edits in trunk/WebCore
Unreviewed, build fix.
[V8] Turn npObjectTypeInfo into a function, make everyone happy.
- bindings/v8/NPV8Object.cpp:
(WebCore::npObjectTypeInfo): Added new function.
(npCreateV8ScriptObject):
- bindings/v8/NPV8Object.h: Turned npObjectTypeInfo into function.
- bindings/v8/V8NPObject.cpp: Replaced references to function
- 11:06 AM Changeset in webkit [56172] by
-
- 6 edits1 copy in trunk
Reviewed by Adam Roben and Anders Carlsson.
https://bugs.webkit.org/show_bug.cgi?id=36210
plugins/resize-from-plugin.html fails on some platforms
WebKitTools:
Turns out that most platforms don't use "cross-platform" main.cpp. Copied code added for
the test to their versions of the file.
- DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp: (webkit_test_plugin_set_window):
- DumpRenderTree/win/TestNetscapePlugin/main.cpp: (NPP_SetWindow):
LayoutTests:
- platform/win/plugins/resize-from-plugin-expected.txt: Copied from LayoutTests/plugins/resize-from-plugin-expected.txt. Windows results are different, probably because windowed plug-ins just get the whole window as clip rect.
- platform/gtk/Skipped:
- platform/qt/Skipped: Unskipped the tests to see how they work with TestNetscapePlugin fixes from this patch.
- 11:03 AM Changeset in webkit [56171] by
-
- 2 edits3 adds in trunk
https://bugs.webkit.org/show_bug.cgi?id=36283
Reviewed by Simon Fraser.
The wrong constants were being used for the code that attempted to compact the background-repeat shorthand to
a single value.
Added fast/backgrounds/background-repeat-computed-style.html
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::fillRepeatToCSSValue):
- 10:57 AM Changeset in webkit [56170] by
-
- 3 edits1 move1 add1 delete in trunk
2010-03-18 Simon Fraser <Simon Fraser>
Reviewed by Dave Hyatt.
https://bugs.webkit.org/show_bug.cgi?id=36271
CSS3 :enabled on an input type=hidden element fails
The CSS3 selectors spec now makes it clear that hidden inputs should respect
the :enabled and :disabled pseudo-classes.
Test: fast/forms/hidden-input-enabled.html
- css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector): Remove checks for hidden inputs.
- 10:13 AM Changeset in webkit [56169] by
-
- 3 edits4 adds in trunk
WebCore: Intro text at Star Wars demo is clipped.
<rdar://problem/7560979>
https://bugs.webkit.org/show_bug.cgi?id=33909
Reviewed by Simon Fraser.
Test: compositing/repaint/layer-repaint.html
We are flipping the coordinates for drawing, therefore
we must flip them also when we invalidate the rectangles.
- platform/graphics/win/GraphicsLayerCACF.cpp:
(WebCore::WebLayer::setNeedsDisplay):
LayoutTests: Intro text at Star Wars demo is clipped.
<rdar://problem/7560979>
https://bugs.webkit.org/show_bug.cgi?id=33909
Reviewed by Simon Fraser.
We are flipping the coordinates for drawing, therefore
we must flip them also when we invalidate the rectangles.
- compositing/repaint/layer-repaint.html: Added.
- platform/mac/compositing/repaint/layer-repaint-expected.checksum: Added.
- platform/mac/compositing/repaint/layer-repaint-expected.png: Added.
- platform/mac/compositing/repaint/layer-repaint-expected.txt: Added.
- 9:59 AM Changeset in webkit [56168] by
-
- 4 edits in trunk
2010-03-18 Nate Chapin <Nate Chapin>
Unreviewed, Chromium build fix.
Missed a #include in V8Collection.h.
- bindings/v8/V8Collection.h:
- 9:50 AM Changeset in webkit [56167] by
-
- 2 edits2 adds in trunk
Fix for https://bugs.webkit.org/show_bug.cgi?id=36284.
Reviewed by Simon Fraser.
Make sure the CSS parser properly rejects negative border widths.
Added fast/borders/negative-border-width.html
- css/CSSParser.cpp:
(WebCore::CSSParser::parseValue):
- 9:38 AM Changeset in webkit [56166] by
-
- 44 edits1 add1 delete in trunk
2010-03-18 Nate Chapin <Nate Chapin>
Reviewed by Dimitri Glazkov.
[V8] Remove V8Index.h and all references to V8ClassIndex.
- WebCore.gypi:
- bindings/scripts/CodeGeneratorV8.pm:
- bindings/v8/NPV8Object.cpp:
- bindings/v8/NPV8Object.h:
- bindings/v8/V8Collection.h:
- bindings/v8/V8DOMWindowShell.cpp:
- bindings/v8/V8DOMWindowShell.h:
- bindings/v8/V8DOMWrapper.cpp:
- bindings/v8/V8DOMWrapper.h:
- bindings/v8/V8GCController.cpp:
- bindings/v8/V8Helpers.cpp:
- bindings/v8/V8Index.h: Removed.
- bindings/v8/V8IsolatedContext.h:
- bindings/v8/V8NPObject.cpp:
- bindings/v8/V8Proxy.cpp:
- bindings/v8/V8Proxy.h:
- bindings/v8/V8SVGPODTypeWrapper.h:
- bindings/v8/WorkerContextExecutionProxy.cpp:
- bindings/v8/WorkerContextExecutionProxy.h:
- bindings/v8/WrapperTypeInfo.h: Move WrapperTypeInfo struct into its own file from V8Index.h.
- bindings/v8/custom/V8CanvasRenderingContext2DCustom.cpp:
- bindings/v8/custom/V8DOMWindowCustom.cpp:
- bindings/v8/custom/V8EventSourceConstructor.cpp:
- bindings/v8/custom/V8HTMLAudioElementConstructor.cpp:
- bindings/v8/custom/V8HTMLAudioElementConstructor.h:
- bindings/v8/custom/V8HTMLImageElementConstructor.cpp:
- bindings/v8/custom/V8HTMLImageElementConstructor.h:
- bindings/v8/custom/V8HTMLOptionElementConstructor.cpp:
- bindings/v8/custom/V8HTMLOptionElementConstructor.h:
- bindings/v8/custom/V8HistoryCustom.cpp:
- bindings/v8/custom/V8LocationCustom.cpp:
- bindings/v8/custom/V8WebGLArrayCustom.h:
- bindings/v8/custom/V8WebGLByteArrayCustom.cpp:
- bindings/v8/custom/V8WebGLFloatArrayCustom.cpp:
- bindings/v8/custom/V8WebGLIntArrayCustom.cpp:
- bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:
- bindings/v8/custom/V8WebGLShortArrayCustom.cpp:
- bindings/v8/custom/V8WebGLUnsignedByteArrayCustom.cpp:
- bindings/v8/custom/V8WebGLUnsignedIntArrayCustom.cpp:
- bindings/v8/custom/V8WebGLUnsignedShortArrayCustom.cpp:
- bindings/v8/custom/V8WebKitPointConstructor.cpp:
- 9:20 AM Changeset in webkit [56165] by
-
- 3 edits in trunk/WebCore
2010-03-18 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Preserve console history between debugging sessions.
- inspector/front-end/ConsoleView.js: (WebInspector.ConsoleView.prototype._settingsLoaded): (WebInspector.ConsoleView.prototype._enterKeyPressed.printResult): (WebInspector.ConsoleView.prototype._enterKeyPressed):
- inspector/front-end/Settings.js: (WebInspector.Settings.prototype._load):
- 9:12 AM Changeset in webkit [56164] by
-
- 1 edit in trunk/WebCore/ChangeLog
Added reviewer name for r56155
- 8:58 AM Changeset in webkit [56163] by
-
- 4 edits in trunk
2010-03-18 Kim Grönholm <kim.gronholm@nomovok.com>
Reviewed by Simon Hausmann.
[Qt] GraphicsLayer: Pausing and resuming of animations don't work as expected
https://bugs.webkit.org/show_bug.cgi?id=36219
The play-state layout test now works, and can be removed from the skip list.
- platform/qt/Skipped: animations/play-state.html is removed from the skipped list
2010-03-18 Kim Grönholm <kim.gronholm@nomovok.com>
Reviewed by Simon Hausmann.
[Qt] GraphicsLayer: Pausing and resuming of animations don't work as expected
https://bugs.webkit.org/show_bug.cgi?id=36219
addAnimation and pauseAnimation were handling animation state changes in
the wrong way.
Apparently WebCore calls addAnimation for resuming, so we have to make
sure to resume an existing animation if that happens. Also, timeOffset
is now used for synchronization of the Qt animation clock with the
WebCore clock, as opposed to using it as a delay timer.
Both those fixes were necessary to get the layout test to work.
LayoutTests/animations/play-state.html now passed on Qt.
- platform/graphics/qt/GraphicsLayerQt.cpp: (WebCore::AnimationQtBase::AnimationQtBase): (WebCore::TransformAnimationQt::updateState): (WebCore::GraphicsLayerQt::addAnimation): (WebCore::GraphicsLayerQt::pauseAnimation):
- 8:41 AM Changeset in webkit [56162] by
-
- 3 edits2 adds in trunk
2010-03-18 Adam Langley <agl@chromium.org>
Reviewed by David Levin.
[chromium] Fix inverted logic in per-strike renderer patch.
I screwed up in r55089 and got one of the conditions backwards. Thanks
to Roman Tsisyk for pointing it out.
- platform/chromium/fast/text/chromium-linux-fontconfig-renderstyle.html: Added.
2010-03-18 Adam Langley <agl@chromium.org>
Reviewed by David Levin.
[chromium] Fix inverted logic in per-strike renderer patch.
I screwed up in r55089 and got one of the conditions backwards. Thanks
to Roman Tsisyk for pointing it out.
Test: platform/chromium/fast/text/chromium-linux-fontconfig-renderstyle.html
- platform/graphics/chromium/FontPlatformDataLinux.cpp: (WebCore::FontPlatformData::querySystemForRenderStyle):
- 8:23 AM Changeset in webkit [56161] by
-
- 7 edits in trunk/WebCore
2010-03-18 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: Show inherited styles for a selected DOM element
- English.lproj/localizedStrings.js:
- inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::getStyles): (WebCore::InspectorDOMAgent::populateObjectWithStyleProperties):
- inspector/front-end/DOMAgent.js: (WebInspector.CSSStyleDeclaration):
- inspector/front-end/StylesSidebarPane.js: (WebInspector.StylesSidebarPane.prototype._update): (WebInspector.StylesSidebarPane.prototype._containsInherited): (WebInspector.StylePropertiesSection): (WebInspector.StylePropertiesSection.prototype.isPropertyInherited): (WebInspector.StylePropertiesSection.prototype.onpopulate):
- 7:59 AM Changeset in webkit [56160] by
-
- 3 edits in trunk/WebKitTools
2010-03-18 Leandro Pereira <leandro@profusion.mobi>
Reviewed by Kenneth Rohde Christiansen.
Add support to run-launcher to open the EFL example browser.
http://webkit.org/b/36181
- Scripts/webkitdirs.pm:
- Scripts/run-launcher:
- 7:49 AM Changeset in webkit [56159] by
-
- 2 edits in trunk/WebCore
Spatial Navigation: Add isNull and document convenience methods to FocusCandidate
https://bugs.webkit.org/show_bug.cgi?id=36167
Reviewed by Gustavo Noronha.
Patch by Antonio Gomes <tonikitoo@webkit.org>
It turns out that Spatial Navigation related code (in FocusController.cpp for
instance) can be simplified and look better if FocusCandidate class offer some
convinience method. This patch introduces a couple of them (isNull and a Document
getter).
A followup refactoring patch will be making use of these helper methods.
- page/SpatialNavigation.h:
(WebCore::FocusCandidate::FocusCandidate): Added a "Node*" parameter
to FocusCandidate's constructor.
(WebCore::FocusCandidate::isNull): In the Spatial Navigation logic, a NULL
FocusCandidate object is one that does not hold a valid reference to a "Node*".
(WebCore::FocusCandidate::document): This method returns a pointer for the FocusCandidate
node's document, if |node| is a valid pointer.
- 7:42 AM Changeset in webkit [56158] by
-
- 2 edits in trunk/WebCore
2010-03-18 Noam Rosenthal <noam.rosenthal@nokia.com>
Reviewed by Antti Koivisto.
[Qt] [Performance] GraphicsLayerQt updates the scene too often
https://bugs.webkit.org/show_bug.cgi?id=36158
This fix makes sure that flushChanges is only called when necessary,
by calling the notifySync function asynchronously, which makes sure flushChanges() is called
after the WebCore compositor has made all its changes.
This has shown a visual improvement on several test-cases.
- Makefile:
- platform/graphics/qt/GraphicsLayerQt.cpp: (WebCore::GraphicsLayerQtImpl::): (WebCore::GraphicsLayerQtImpl::notifySyncRequired): (WebCore::GraphicsLayerQtImpl::notifyChange): (WebCore::GraphicsLayerQtImpl::flushChanges): (WebCore::GraphicsLayerQt::setMaskLayer): (WebCore::GraphicsLayerQt::setPosition): (WebCore::GraphicsLayerQt::setAnchorPoint): (WebCore::GraphicsLayerQt::setSize): (WebCore::GraphicsLayerQt::setTransform): (WebCore::GraphicsLayerQt::setChildrenTransform): (WebCore::GraphicsLayerQt::setPreserves3D): (WebCore::GraphicsLayerQt::setMasksToBounds): (WebCore::GraphicsLayerQt::setDrawsContent): (WebCore::GraphicsLayerQt::setBackgroundColor): (WebCore::GraphicsLayerQt::clearBackgroundColor): (WebCore::GraphicsLayerQt::setContentsOpaque): (WebCore::GraphicsLayerQt::setBackfaceVisibility): (WebCore::GraphicsLayerQt::setOpacity): (WebCore::GraphicsLayerQt::setContentsRect):
- 6:31 AM Changeset in webkit [56157] by
-
- 4 edits in trunk
2010-03-18 Sergio Villar Senin <svillar@igalia.com>
Reviewed by Xan Lopez.
[GTK] Failing tests http/tests/misc/image-blocked-src-change.html
& http/tests/misc/image-blocked-src-no-change.html
https://bugs.webkit.org/show_bug.cgi?id=36227
Removed tests from the list of Skipped:
http/tests/misc/image-blocked-src-no-change.html
http/tests/misc/image-blocked-src-change.html
http/tests/security/local-CSS-from-remote.html
http/tests/security/local-video-poster-from-remote.html
http/tests/security/frame-loading-via-document-write.html
http/tests/security/local-iFrame-from-remote.html
http/tests/security/local-video-src-from-remote.html
http/tests/security/local-image-from-remote.html
http/tests/security/local-JavaScript-from-remote.html
- platform/gtk/Skipped:
2010-03-18 Sergio Villar Senin <svillar@igalia.com>
Reviewed by Xan Lopez.
[GTK] Failing tests http/tests/misc/image-blocked-src-change.html
& http/tests/misc/image-blocked-src-no-change.html
https://bugs.webkit.org/show_bug.cgi?id=36227
- DumpRenderTree/gtk/DumpRenderTree.cpp: (webViewConsoleMessage): print only the file name instead of the whole URI when printing messages with local URI's
- 5:47 AM Changeset in webkit [56156] by
-
- 4 edits in trunk/WebKitTools
2010-03-18 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Teach what-broke how to look up reviewer and author Committer objects by name
https://bugs.webkit.org/show_bug.cgi?id=36264
- Scripts/webkitpy/commands/queries.py:
- Add committer_by_name lookups for both reviewer and author
- Improve printing in the cases where lookups fail.
- Scripts/webkitpy/committers.py:
- Add committer_by_name
- Scripts/webkitpy/committers_unittest.py:
- Test committer_by_name
- 5:30 AM Changeset in webkit [56155] by
-
- 3 edits in trunk/WebCore
2010-03-18 Stephen White <senorblanco@chromium.org>
Parsing of rgb() colors in HTML canvas is still fairly slow.
findNamedColor() was showing up as hot, so this patch attempts to
avoid calling it by putting the rgb() check ahead of the named
colors. It also removes a call to Color::Color() from
CanvasStyle, which was doing a redundant check for the hex
color and named colors, which CSSParser already does. Finally, it
changes the ad-hoc parser to check for negative values, and clamps them
at zero. This avoids the lex/yacc path for rgb() colors with
negative color components.
Covered by fast/canvas/set-colors.html.
- css/CSSParser.cpp: (WebCore::parseInt): (WebCore::CSSParser::parseColor):
- html/canvas/CanvasStyle.cpp: (WebCore::CanvasStyle::applyFillColor):
- 5:13 AM Changeset in webkit [56154] by
-
- 2 edits in trunk/LayoutTests
2010-03-18 Chang Shu <chang.shu@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Unskip the tests that pass after the fix for bug 36139.
http/tests/appcache/foreign-iframe-main.html
http/tests/appcache/manifest-with-empty-file.html
http/tests/appcache/resource-redirect.html
- platform/qt/Skipped:
- 4:56 AM Changeset in webkit [56153] by
-
- 1 edit2 adds in trunk/WebKit
2010-03-18 Leandro Pereira <leandro@profusion.mobi>
Reviewed by Kenneth Rohde Christiansen.
Add EFL port files to efl/ewk.
http://webkit.org/b/35931
- efl/ewk/ewk_settings.cpp: Added.
- efl/ewk/ewk_settings.h: Added.
- 1:55 AM Changeset in webkit [56152] by
-
- 2 edits in trunk/WebCore
<http://webkit.org/b/36246> Node::removeAllEventListenersSlowCase is declared but not used
Reviewed by Sam Weinig.
- dom/Node.h:
(WebCore::Node::removeAllEventListenersSlowCase): Removed
declaration. Implementation was removed in r48701.
Mar 17, 2010:
- 10:37 PM Changeset in webkit [56151] by
-
- 5 edits in trunk/WebKitTools
2010-03-17 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
create-rollout should actually fill out the description
https://bugs.webkit.org/show_bug.cgi?id=36261
- Scripts/webkitpy/commands/download.py:
The % operator was applied to the wrong string.
- Scripts/webkitpy/commands/download_unittest.py:
- Scripts/webkitpy/commands/upload_unittest.py:
- Scripts/webkitpy/mock_bugzillatool.py:
Add support for seeing what we actually do with create_bug.
- 10:02 PM Changeset in webkit [56150] by
-
- 2 edits in trunk/JavaScriptCore
Update WebKit availability macros for release after 4.0.
Reviewed by Darin Adler and Mark Rowe.
- API/WebKitAvailability.h:
- 9:56 PM Changeset in webkit [56149] by
-
- 1 edit2 adds in trunk/WebCore
2010-03-17 Stephan Aßmus <superstippi@gmx.de>
Reviewed by Oliver Hunt.
[Haiku] Implement ImageBuffer support
https://bugs.webkit.org/show_bug.cgi?id=35288
Covered by existing tests.
The StillImage class implements WebCore::Image by wrapping a native
BBitmap. It will be needed to implement WebCore::ImageBuffer. This
solution is just like it's done in the Qt port.
- platform/graphics/haiku/StillImageHaiku.cpp: Added. (WebCore::StillImage::StillImage): (WebCore::StillImage::destroyDecodedData): (WebCore::StillImage::decodedSize): (WebCore::StillImage::size): (WebCore::StillImage::nativeImageForCurrentFrame): (WebCore::StillImage::draw):
- platform/graphics/haiku/StillImageHaiku.h: Added. (WebCore::StillImage::create):
- 9:06 PM Changeset in webkit [56148] by
-
- 3 edits in trunk/WebCore
[Gtk+] Avoid making a copy of the HTTPHeaderMap.
ResourceRequest::httpHeaderFields() is returning a const
reference but we are storing it as a simple value. This
means that we run either the copy constructor or the assignment
operator and make a copy of the RefPtrs.
This extra copy can be avoided easily by storing
const reference.
- platform/network/soup/ResourceRequestSoup.cpp:
(WebCore::ResourceRequest::toSoupMessage):
- platform/network/soup/ResourceResponseSoup.cpp:
(WebCore::ResourceResponseSoup::toSoupMessage):
- 8:58 PM Changeset in webkit [56147] by
-
- 1 edit56 adds in trunk/WebKit
2010-03-17 Leandro Pereira <leandro@profusion.mobi>
Reviewed by Kenneth Rohde Christiansen.
Add default theme files to efl/DefaultTheme.
http://webkit.org/b/36240
- efl/DefaultTheme/widget/radio/img_radio_on.png: Added.
- efl/DefaultTheme/radio/img_radio_off_hover.png: Added.
- efl/DefaultTheme/radio/img_radio_on_hover.png: Added.
- efl/DefaultTheme/radio/img_radio_off.png: Added.
- efl/DefaultTheme/radio/img_radio_off_focus.png: Added.
- efl/DefaultTheme/radio/img_radio_on_focus.png: Added.
- efl/DefaultTheme/combo/combo_normal.png: Added.
- efl/DefaultTheme/combo/combo_focus_button.png: Added.
- efl/DefaultTheme/combo/combo_hover_button.png: Added.
- efl/DefaultTheme/combo/combo_hover.png: Added.
- efl/DefaultTheme/combo/combo_focus.png: Added.
- efl/DefaultTheme/combo/combo_press_button.png: Added.
- efl/DefaultTheme/combo/combo_normal_button.png: Added.
- efl/DefaultTheme/combo/combo_press.png: Added.
- efl/DefaultTheme/combo/icon.png: Added.
- efl/DefaultTheme/file/file_normal.png: Added.
- efl/DefaultTheme/file/file_press.png: Added.
- efl/DefaultTheme/file/file_hover.png: Added.
- efl/DefaultTheme/file/file_focus.png: Added.
- efl/DefaultTheme/search/cancel/cancel_normal_button.png: Added.
- efl/DefaultTheme/search/cancel/cancel_normal_button2.png: Added.
- efl/DefaultTheme/search/decoration/decoration_normal_button.png: Added.
- efl/DefaultTheme/search/field/field_focused.png: Added.
- efl/DefaultTheme/search/field/field_normal.png: Added.
- efl/DefaultTheme/search/field/field_hovered.png: Added.
- efl/DefaultTheme/entry/img_normal.png: Added.
- efl/DefaultTheme/entry/img_hovered.png: Added.
- efl/DefaultTheme/entry/img_focused.png: Added.
- efl/DefaultTheme/check/img_check_off_hover.png: Added.
- efl/DefaultTheme/check/img_check_on.png: Added.
- efl/DefaultTheme/check/img_check_off_focus.png: Added.
- efl/DefaultTheme/check/img_check_on_focus.png: Added.
- efl/DefaultTheme/check/img_check_off.png: Added.
- efl/DefaultTheme/check/img_check_on_hover.png: Added.
- efl/DefaultTheme/scrollbar/scrollbar_knob_h.png: Added.
- efl/DefaultTheme/scrollbar/scrollbar_knob_v.png: Added.
- efl/DefaultTheme/scrollbar/scrollbar_hilight.png: Added.
- efl/DefaultTheme/scrollbar/scrollbar_v.png: Added.
- efl/DefaultTheme/scrollbar/scrollbar_h.png: Added.
- efl/DefaultTheme/button/img_button_normal.png: Added.
- efl/DefaultTheme/button/img_button_focus.png: Added.
- efl/DefaultTheme/button/img_button_hover.png: Added.
- efl/DefaultTheme/button/img_button_press.png: Added.
- 8:41 PM Changeset in webkit [56146] by
-
- 2 edits in trunk/WebKitTools
2010-03-17 Jesus Sanchez-Palencia <jesus.palencia@openbossa.org>
Reviewed by Kenneth Rohde Christiansen.
Accelerated Compositing is now default on QtWebKit so the option
in QtLauncher must be true as default.
[Qt] QtLauncher's Accelerated Compositing option must be true as default
https://bugs.webkit.org/show_bug.cgi?id=36234
- QtLauncher/main.cpp: (LauncherWindow::applyPrefs): (LauncherWindow::toggleAcceleratedCompositing): (LauncherApplication::handleUserOptions):
- 8:24 PM Changeset in webkit [56145] by
-
- 2 edits in trunk/WebKitTools
2010-03-17 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Commit queue should ignore (probably red) builders when landing rollouts
https://bugs.webkit.org/show_bug.cgi?id=36169
When landing a rollout, the builders are probably red, so we need to
ignore them in the subprocess too. Also, we might as well update the
working copy because we haven't validated anything about the current
revision prior to trying to land.
This change is testable, but it requires changing the mock executive to
log its arguments. That will generate a lot of expectation changes, so
I'd like to do that in a separate patch.
- Scripts/webkitpy/commands/queues.py:
- 8:07 PM Changeset in webkit [56144] by
-
- 2 edits in trunk/WebKit/chromium
2010-03-17 Garret Kelly <gdk@chromium.org>
Reviewed by Darin Fisher.
PlatformTouchEventBuilder should not be resizing the touch point
array before appending touch points to it.
https://bugs.webkit.org/show_bug.cgi?id=36231
- src/WebInputEventConversion.cpp: (WebKit::PlatformTouchEventBuilder::PlatformTouchEventBuilder):
- 7:51 PM Changeset in webkit [56143] by
-
- 2 edits in trunk/WebCore
2010-03-17 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: When switching resources in the Resources panel, the Content tab is always selected
https://bugs.webkit.org/show_bug.cgi?id=36222
- inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel.prototype.showResource):
- 7:25 PM Changeset in webkit [56142] by
-
- 5 edits in trunk
2010-03-17 Oliver Hunt <oliver@apple.com>
Reviewed by Gavin Barraclough.
undefined, NaN, and Infinity should be ReadOnly
https://bugs.webkit.org/show_bug.cgi?id=36263
Simply add the ReadOnly flag to these properties.
- runtime/JSGlobalObject.cpp: (JSC::JSGlobalObject::reset):
2010-03-17 Oliver Hunt <oliver@apple.com>
Reviewed by Gavin Barraclough.
undefined, NaN, and Infinity should be ReadOnly
https://bugs.webkit.org/show_bug.cgi?id=36263
Add tests for the attributes of undefined, NaN and Infinity on the
global object
- fast/js/getOwnPropertyDescriptor-expected.txt:
- fast/js/resources/getOwnPropertyDescriptor.js:
- 7:16 PM Changeset in webkit [56141] by
-
- 3 edits in trunk/WebKit/qt
2010-03-17 Antti Koivisto <koivisto@iki.fi>
Reviewed by Tor Arne Vestbø.
Fix Qt build with tiled backing store disabled.
- Api/qwebframe.cpp:
- Api/qwebframe_p.h:
- 6:59 PM Changeset in webkit [56140] by
-
- 6 edits in trunk
2010-03-17 Chang Shu <chang.shu@nokia.com>
Reviewed by Laszlo Gombos.
https://bugs.webkit.org/show_bug.cgi?id=36139
[Qt] Unskip the test that now passes.
platform/qt/Skipped:
2010-03-17 Chang Shu <chang.shu@nokia.com>
Reviewed by Laszlo Gombos.
https://bugs.webkit.org/show_bug.cgi?id=36139
[Qt] Clean up cache while setting cache quota. This behavior matches other platforms,
such as mac and gtk.
- Api/qwebsettings.cpp:
(QWebSettings::setOfflineWebApplicationCacheQuota):
2010-03-17 Chang Shu <chang.shu@nokia.com>
Reviewed by Laszlo Gombos.
https://bugs.webkit.org/show_bug.cgi?id=36139
[Qt] Clean up cache each time DumpRenderTree starts. This behavior
matches other platforms, such as mac and gtk.
- DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::DumpRenderTree::DumpRenderTree):
- 6:32 PM Changeset in webkit [56139] by
-
- 3 edits in trunk/WebCore
databaseIdentifiers are not filtered for slashes
<rdar://problem/7708789> and https://bugs.webkit.org/show_bug.cgi?id=36243
Reviewed by Darin Adler.
In addition to filtering for '/' and '\', to remove the directory vulnerability
on all platforms, it seems worth it to also escape other characters that are
obviously dangerous or illegal to have in a filename (mostly inspired by the
Windows illegal-character list).
No new tests - It's unclear how a test could possibly work into our testing
infrastructure.
- page/SecurityOrigin.cpp:
(WebCore::): Added a 128-bool table "needsEscaping" that has a true/false answer
for lower-ASCII.
(WebCore::SecurityOrigin::SecurityOrigin):
(WebCore::SecurityOrigin::createFromDatabaseIdentifier): "Unescape" the host
component using the KURL utility.
(WebCore::shouldEscapeUChar): If the char is lower-ASCII, look it up in the
needsEscaping table. Otherwise, let it pass.
(WebCore::encodedHost): Modeled after KURL's host escaping method, but targeted
for the escaping considerations for the host component. We don't use the KURL
version because this one is "different" enough because it operates on UTF16 and
has its own "is bad character?" decider.
(WebCore::SecurityOrigin::databaseIdentifier): Create the escaped host if needed,
and use it instead of the unescaped host.
- page/SecurityOrigin.h:
- 6:17 PM Changeset in webkit [56138] by
-
- 2 edits in trunk/WebKitTools
2010-03-17 Adam Barth <abarth@webkit.org>
Unreviewed.
Turns out this needs to be a string.
- Scripts/webkitpy/bugzilla.py:
- 6:09 PM Changeset in webkit [56137] by
-
- 12 edits in trunk/WebKitTools
2010-03-17 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Add more infrastructure for sheriff-bot, including making what-broke more awesome
https://bugs.webkit.org/show_bug.cgi?id=36254
- Scripts/webkitpy/bugzilla.py:
- Made the various URL methods return None when passed None.
- Scripts/webkitpy/bugzilla_unittest.py:
- Test that the url methods work as expected.
- Scripts/webkitpy/buildbot.py:
- Add a static Build.build_url so that its possible to generate a build url without a Build object.
- Give users a URL in _fetch_xmlrpc_build_dictionary error message.
- Scripts/webkitpy/changelogs.py:
- Add a new ChangeLogEntry class to encapsulate entry-parsing logic.
- Add is_path_to_changelog to greatly simplify SCM.modified_changelogs code.
- Make ChangeLog.parse_latest_entry_from_file a public method.
- Scripts/webkitpy/changelogs_unittest.py:
- Add tests for new ChangeLog entry parsing.
- Scripts/webkitpy/commands/queries.py:
- Make "what-broke" not print "ok" builders, only failing ones.
- Print much more information on failing builders, including links and authorship/reviewer information.
- Scripts/webkitpy/commands/queues_unittest.py:
- Use a fake_checkout path since fixing the cwd (as part of fixing scm_unittests.py) was breaking tests.
- Scripts/webkitpy/mock_bugzillatool.py:
- Move MockSCM away from using os.getcwd() as that was fragile (and wrong).
- Scripts/webkitpy/patch/patcher.py:
- Remove code which was broken now that this file has moved.
- Code was also redundant now that SCM.find_checkout_root() exists.
- Scripts/webkitpy/scm.py:
- Greatly simplify modified_changelogs now that I understand list comprehensions.
- Expect ChangeLogEntry objects instead of raw strings.
- Add changed_files_for_revision, committer_email_for_revision and contents_at_revision
- Add commit_with_message argument to all sites since someone half-added it before. :(
- Get rid of copy/paste code using _status_regexp()
- Scripts/webkitpy/scm_unittest.py:
- Fix these tests!
- Add new tests for new scm code.
- Fix spelling of "awsome" to "awesome".
- 5:37 PM Changeset in webkit [56136] by
-
- 1 edit4 adds in trunk/LayoutTests
2010-03-17 Drew Wilson <atwilson@chromium.org>
Reviewed by David Levin.
Add tests for "load shared worker in iframe" case.
https://bugs.webkit.org/show_bug.cgi?id=36203
Makes sure that creating a worker simultaneously in a document and in
a child iframe works (you end up with a single instance).
- fast/workers/resources/shared-worker-count-connections.js: Added.
- fast/workers/resources/shared-worker-iframe.html: Added.
- fast/workers/shared-worker-in-iframe-expected.txt: Added.
- fast/workers/shared-worker-in-iframe.html: Added.
- 5:10 PM Changeset in webkit [56135] by
-
- 2 edits in trunk/JavaScriptCore
Speed up Math.round a little by removing unneeded special case
https://bugs.webkit.org/show_bug.cgi?id=36107
Reviewed by Oliver Hunt.
Test: fast/js/math.html
- runtime/MathObject.cpp:
(JSC::mathProtoFuncRound): This function had a special case for numbers
between -0.5 and -0.0 to return -0.0. But the algorithm in the function
already yields -0.0 for those cases, so the extra checking and branching
is unneeded.
- 4:40 PM Changeset in webkit [56134] by
-
- 2 edits3 adds in trunk/LayoutTests
2010-03-17 Shu Chang <Chang.Shu@nokia.com>
Reviewed by Eric Seidel.
[Qt] Rebaseline the test and remove it from Skipped.
https://bugs.webkit.org/show_bug.cgi?id=36059
- platform/qt/Skipped:
- platform/qt/fast/canvas/canvas-text-baseline-expected.checksum: Added.
- platform/qt/fast/canvas/canvas-text-baseline-expected.png: Added.
- platform/qt/fast/canvas/canvas-text-baseline-expected.txt: Added.
- 4:39 PM Changeset in webkit [56133] by
-
- 5 edits in trunk/WebKitTools
2010-03-17 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Change post-rollout to create-rollout and have it make a new bug
instead of posting the rollout to the old bug.
https://bugs.webkit.org/show_bug.cgi?id=36250
The new bug blocks the old bug instead of adding more complexity to the
old bug. One tricky question is whether to create the bug if we're
unable to create a rollout patch. In this patch, we do create the bug,
but we might revist this question in the future.
- Scripts/webkitpy/bugzilla.py:
- Scripts/webkitpy/commands/download.py:
- Scripts/webkitpy/commands/download_unittest.py:
- Scripts/webkitpy/steps/createbug.py:
- 4:18 PM Changeset in webkit [56132] by
-
- 2 edits in trunk/WebKitTools
2010-03-17 Daniel Bates <dbates@rim.com>
Rubber-stamped by David Levin.
Add myself to the list of reviewers.
- Scripts/webkitpy/committers.py:
- 4:01 PM WebKit Team edited by
- Moved my entry from Committer to Reviewer. (diff)
- 3:38 PM Changeset in webkit [56131] by
-
- 5 edits3 adds in trunk
[v8] Avoid reentry into v8 after TerminateExecution() on a worker thread.
https://bugs.webkit.org/show_bug.cgi?id=36239
Reviewed by Dimitri Glazkov.
WebCore:
Test: fast/workers/termination-with-port-messages.html
- bindings/v8/V8Proxy.h:
(WebCore::throwError): Avoid throwing if v8 execution is terminated anyways.
- bindings/v8/WorkerScriptController.h:
(WebCore::WorkerScriptController::proxy): Return V8 proxy as 0 if execution is terminating. Callers to check for 0 before invoking v8.
- bindings/v8/custom/V8WorkerContextCustom.cpp:
(WebCore::SetTimeoutOrInterval): Bail out if v8 proxy is 0.
(WebCore::toV8): Ditto
LayoutTests:
- fast/workers/resources/termination-with-port-messages.js: Added.
(echo):
(onmessage):
- fast/workers/termination-with-port-messages-expected.txt: Added.
- fast/workers/termination-with-port-messages.html: Added.
- 3:23 PM Changeset in webkit [56130] by
-
- 1 edit2 adds in trunk/WebKit
2010-03-17 Leandro Pereira <leandro@profusion.mobi>
Reviewed by Kenneth Rohde Christiansen.
Add EFL example browser to efl/EWebLauncher.
http://webkit.org/b/36176
- efl/EWebLauncher/main.c: Added.
- 2:58 PM Changeset in webkit [56129] by
-
- 2 edits in trunk/WebKit/chromium
[chromium] Roll Chromium builder's DEPS to current revs.
https://bugs.webkit.org/show_bug.cgi?id=36241
Reviewed by Dimitri Glazkov.
- DEPS:
- 2:47 PM Changeset in webkit [56128] by
-
- 11 edits1 delete in trunk/WebCore
2010-03-17 José Millán Soto <jmillan@igalia.com>
Reviewed by Adam Barth.
Change the way of prefetching DNS to allow prefetching function to use full URL
https://bugs.webkit.org/show_bug.cgi?id=35589
Creates a new function, ResourceHandle::prepareForURL, whose default implementation
calls prefetchDNS with the host of the given URL as the parameter.
Soup implementation of ResourceHandle::prepareForURL executes soup_session_prepare_for_uri.
Soup implementation of prefetchDNS is removed.
Changed various prefetchDNS calls to ResourceHandle::prepareForURL calls.
- GNUmakefile.am:
- html/HTMLAnchorElement.cpp: (WebCore::HTMLAnchorElement::parseMappedAttribute):
- html/HTMLLinkElement.cpp: (WebCore::HTMLLinkElement::process):
- page/Chrome.cpp: (WebCore::Chrome::mouseDidMoveOverElement):
- platform/network/DNS.h:
- platform/network/ResourceHandle.cpp: (WebCore::ResourceHandle::prepareForURL):
- platform/network/ResourceHandle.h:
- platform/network/chromium/DNSChromium.cpp: (WebCore::ResourceHandle::prepareForURL):
- platform/network/soup/DNSSoup.cpp: Removed.
- platform/network/soup/ResourceHandleSoup.cpp: (WebCore::ResourceHandle::prepareForURL):
- wml/WMLAElement.cpp: (WebCore::WMLAElement::parseMappedAttribute):
- 2:11 PM Changeset in webkit [56127] by
-
- 15 edits2 deletes in trunk
2010-03-17 Kenneth Russell <kbr@google.com>
Reviewed by Darin Fisher.
Revert WebGL context attributes changes 33416 / r56074 and 36200 / r56093
https://bugs.webkit.org/show_bug.cgi?id=36233
The patch for bug 33416, which added multisampling support to the
WebGL back buffer, uncovered some OpenGL driver bugs on the build
bots which need further investigation to determine the appropriate
workaround. Reverting this change, the minor build fix in 36189,
and the skipping of the affected tests in bug 36200.
Built and tested WebKit and Chromium and ran all WebGL layout
tests in both.
- src/GraphicsContext3D.cpp: (WebCore::GraphicsContext3DInternal::GraphicsContext3DInternal): (WebCore::GraphicsContext3DInternal::~GraphicsContext3DInternal): (WebCore::GraphicsContext3DInternal::reshape): (WebCore::GraphicsContext3DInternal::beginPaint): (WebCore::GraphicsContext3DInternal::bindFramebuffer): (WebCore::GraphicsContext3D::readPixels):
2010-03-17 Kenneth Russell <kbr@google.com>
Reviewed by Darin Fisher.
Revert WebGL context attributes changes 33416 / r56074 and 36200 / r56093
https://bugs.webkit.org/show_bug.cgi?id=36233
The patch for bug 33416, which added multisampling support to the
WebGL back buffer, uncovered some OpenGL driver bugs on the build
bots which need further investigation to determine the appropriate
workaround. Reverting this change, the minor build fix in 36189,
and the skipping of the affected tests in bug 36200.
Built and tested WebKit and Chromium and ran all WebGL layout
tests in both.
- bindings/v8/custom/V8HTMLCanvasElementCustom.cpp: (WebCore::V8HTMLCanvasElement::getContextCallback):
- platform/graphics/GraphicsContext3D.h:
- platform/graphics/mac/Canvas3DLayer.h:
- platform/graphics/mac/Canvas3DLayer.mm: (-[Canvas3DLayer drawInCGLContext:pixelFormat:forLayerTime:displayTime:]):
- platform/graphics/mac/GraphicsContext3DMac.cpp: (WebCore::GraphicsContext3D::GraphicsContext3D): (WebCore::GraphicsContext3D::~GraphicsContext3D): (WebCore::GraphicsContext3D::reshape): (WebCore::GraphicsContext3D::bindFramebuffer): (WebCore::GraphicsContext3D::readPixels):
- platform/graphics/mac/GraphicsLayerCA.mm: (WebCore::GraphicsLayerCA::setContentsToGraphicsContext3D):
2010-03-17 Kenneth Russell <kbr@google.com>
Reviewed by Darin Fisher.
Revert WebGL context attributes changes 33416 / r56074 and 36200 / r56093
https://bugs.webkit.org/show_bug.cgi?id=36233
The patch for bug 33416, which added multisampling support to the
WebGL back buffer, uncovered some OpenGL driver bugs on the build
bots which need further investigation to determine the appropriate
workaround. Reverting this change, the minor build fix in 36189,
and the skipping of the affected tests in bug 36200.
Built and tested WebKit and Chromium and ran all WebGL layout
tests in both.
- fast/canvas/webgl/context-attributes-alpha-depth-stencil-antialias-expected.txt: Removed.
- fast/canvas/webgl/context-attributes-alpha-depth-stencil-antialias.html: Removed.
- fast/canvas/webgl/context-attributes-expected.txt:
- fast/canvas/webgl/context-attributes.html:
- fast/canvas/webgl/gl-get-calls-expected.txt:
- fast/canvas/webgl/gl-get-calls.html:
- platform/mac/Skipped:
- 2:02 PM Changeset in webkit [56126] by
-
- 8 edits in trunk/WebCore
Optimize painting for HTMLProgressElement
https://bugs.webkit.org/show_bug.cgi?id=36113
Cache the progress bar's position, so it is not required to recalculate
it for each repaint.
Call repaintRectangle() when the position changes.
Reviewed by Darin Adler.
No new tests, as no new functionality introduced.
- html/HTMLProgressElement.cpp:
- platform/qt/RenderThemeQt.cpp:
- platform/qt/RenderThemeQt.h:
- rendering/RenderProgress.cpp:
- rendering/RenderProgress.h:
- rendering/RenderTheme.cpp:
- rendering/RenderTheme.h:
- 1:52 PM Changeset in webkit [56125] by
-
- 3 edits9 adds in trunk/WebKitTools
2010-03-17 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Add a way for the bots to send messages to IRC
https://bugs.webkit.org/show_bug.cgi?id=36235
We'll use these classes to notify #webkit about bad SVN revisions.
This patch just has some skeleton code for us to play with.
- Scripts/webkitpy/irc/init.py: Added.
- Scripts/webkitpy/irc/ircbot.py: Added.
A bot that knows how to talk to IRC.
- Scripts/webkitpy/irc/ircproxy.py: Added.
We need to run the bot on its own thread because the irclib needs
its own mainloop. This class provides an abstraction of the
threading.
- Scripts/webkitpy/irc/messagepump.py: Added.
- Scripts/webkitpy/irc/messagepump_unittest.py: Added.
- Scripts/webkitpy/irc/threadedmessagequeue.py: Added.
A thread-safe message queue for sending messages from the main
thread to the IRC thread.
- Scripts/webkitpy/irc/threadedmessagequeue_unittest.py: Added.
- Scripts/webkitpy/irc/unittests.py: Added.
- Scripts/webkitpy/thirdparty/autoinstalled/init.py:
Autoinstall irclib
- Scripts/webkitpy/unittests.py:
- 11:47 AM Changeset in webkit [56124] by
-
- 2 edits in trunk/JavaScriptCore
2010-03-17 Mike Homey <glandium@debian.org>
Reviewed by Gustavo Noronha.
Build fix for SPARC. Fix missing macro value.
- wtf/Platform.h:
- 11:44 AM Changeset in webkit [56123] by
-
- 2 edits in trunk/WebKitTools
2010-03-17 Victor Wang <victorw@chromium.org>
Reviewed by Dimitri Glazkov.
Fix image_diff syntax in webkitpy/port/base.py.
The syntax is wrong if diff_filename is specified.
- Scripts/webkitpy/layout_tests/port/base.py:
- 11:22 AM Changeset in webkit [56122] by
-
- 2 edits in trunk/LayoutTests
- platform/gtk/Skipped: Also, resize-from-plugin.html got skipped twice tonight, removing one of the lines.
- 11:15 AM Changeset in webkit [56121] by
-
- 1 edit in trunk/WebKit/win/Interfaces/WebKit.idl
Touch WebKit.idl to fix the build
- 11:11 AM Changeset in webkit [56120] by
-
- 2 edits in trunk/WebCore
Mac Buildfix: Using ASSERT_UNUSED instead of ASSERT.
Reviewed by Simon fraser.
Patch by Antonio Gomes <tonikitoo@webkit.org>
- dom/SelectElement.cpp:
(WebCore::SelectElement::listBoxDefaultEventHandler):
- 11:02 AM Changeset in webkit [56119] by
-
- 2 edits in trunk/LayoutTests
- platform/gtk/Skipped: Updated to reference a newly filed bug.
- 11:00 AM Changeset in webkit [56118] by
-
- 8 edits in trunk
Missing support for showing compositing layers borders and repaint count on Windows.
<rdar://problem/7760736>
<https://bugs.webkit.org/show_bug.cgi?id=36197>
Reviewed by Darin Adler.
WebCore:
- platform/graphics/win/GraphicsLayerCACF.cpp:
(WebCore::WebLayer::drawInContext): Modified to use the correct font on Windows.
WebKit/win:
- Interfaces/IWebPreferencesPrivate.idl:
- WebPreferenceKeysPrivate.h:
- WebPreferences.cpp:
(WebPreferences::initializeDefaultSettings):
(WebPreferences::showDebugBorders):
(WebPreferences::setShowDebugBorders):
(WebPreferences::showRepaintCounter):
(WebPreferences::setShowRepaintCounter):
- WebPreferences.h:
- WebView.cpp:
(WebView::notifyPreferencesChanged):
- 10:37 AM Changeset in webkit [56117] by
-
- 2 edits in trunk/WebKitTools
2010-03-16 Diego Gonzalez <diego.gonzalez@openbossa.org>
Reviewed by Kenneth Christiansen.
Provide to QtLauncher a way to change the ViewportUpdateMode
when it's in graphics based mode.
[Qt] Make QtLaucher able to select the ViewportUpdateMode
https://bugs.webkit.org/show_bug.cgi?id=36175
- QtLauncher/main.cpp: (LauncherWindow::selectViewportUpdateMode): (LauncherWindow::createChrome):
- 10:25 AM Changeset in webkit [56116] by
-
- 3 edits in trunk/WebCore
Multiselect Popup - SelectElement refactoring. https://bugs.webkit.org/show_bug.cgi?id=36124
Reviewed by Antti Koivisto.
As it is today it is not possible to the menulists popups to tell SelectElement
that more then one option is selected. If you select one the other ones
selected state will turn off.
For <select multiple> I needed to extend the API used by menulist popups. This
is the first step. Just refactoring SelectElement without any behavior change.
Separating code that will be reused in future patches.
- dom/SelectElement.cpp:
(WebCore::SelectElement::updateSelectedState):
(WebCore::SelectElement::listBoxDefaultEventHandler):
- dom/SelectElement.h:
- 10:09 AM Changeset in webkit [56115] by
-
- 1 edit1 copy1 delete in trunk/WebCore
2010-03-17 Nate Chapin <Nate Chapin>
Unreviewed, Chromium build fix.
Delete the correct file this time.
- bindings/v8/custom/V8XMLHttpRequestCustom.cpp: Copied from WebCore/bindings/v8/custom/V8XMLHttpRequestCustom.cpp.
- bindings/v8/custom/V8XMLHttpRequestUploadCustom.cpp: Removed.
- 9:51 AM Changeset in webkit [56114] by
-
- 14 edits1 delete in trunk/WebCore
2010-03-17 Nate Chapin <Nate Chapin>
Reviewed by Dimitri Glazkov.
[V8] Remove custom bindings callbacks that aren't in use.
(The relevant .idl doesn't mark them as V8Custom or Custom).
- Android.v8bindings.mk:
- WebCore.gypi:
- bindings/scripts/CodeGeneratorV8.pm:
- bindings/v8/custom/V8DOMWindowCustom.cpp:
- bindings/v8/custom/V8WebGLArrayCustom.h:
- bindings/v8/custom/V8WebGLByteArrayCustom.cpp:
- bindings/v8/custom/V8WebGLFloatArrayCustom.cpp:
- bindings/v8/custom/V8WebGLIntArrayCustom.cpp:
- bindings/v8/custom/V8WebGLShortArrayCustom.cpp:
- bindings/v8/custom/V8WebGLUnsignedByteArrayCustom.cpp:
- bindings/v8/custom/V8WebGLUnsignedIntArrayCustom.cpp:
- bindings/v8/custom/V8WebGLUnsignedShortArrayCustom.cpp:
- bindings/v8/custom/V8XMLHttpRequestCustom.cpp:
- bindings/v8/custom/V8XMLHttpRequestUploadCustom.cpp: Removed.
- 9:11 AM Changeset in webkit [56113] by
-
- 2 edits in trunk/WebKitTools
2010-03-17 Zoltan Horvath <zoltan@webkit.org>
Reviewed by Darin Adler.
Ambiguous error message when building for unspecified platform
https://bugs.webkit.org/show_bug.cgi?id=30203
Add an extra line information to the error message.
- Scripts/webkitdirs.pm:
- 8:24 AM Changeset in webkit [56112] by
-
- 3 edits in trunk/WebCore
2010-03-17 Steve Block <steveblock@google.com>
Reviewed by Dimitri Glazkov.
Adds ENABLE(WORKERS) guards to V8 bindings
https://bugs.webkit.org/show_bug.cgi?id=36221
Build fix only, no new tests.
- bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::instantiateV8Object):
- bindings/v8/V8Proxy.cpp: (WebCore::toV8Context):
- 7:57 AM ImprovingLifeOnWindows edited by
- Rolled out changeset 56044 as to broke the Windows Debug (test) bot. … (diff)
- 7:40 AM Changeset in webkit [56111] by
-
- 2 edits in trunk/LayoutTests
2010-03-17 Pavel Feldman <pfeldman@chromium.org>
Not reviewed: update mimetype expectations in inspector tests.
- inspector/timeline-network-resource-expected.txt:
- 7:30 AM Changeset in webkit [56110] by
-
- 3 edits1 delete in trunk
2010-03-17 Pavel Feldman <pfeldman@chromium.org>
Not reviewed: GTK tests fix - removed custom expectation that was
added with no good reason.
- inspector/timeline-test.js:
- platform/gtk/inspector/timeline-network-resource-expected.txt: Removed.
- 7:20 AM Changeset in webkit [56109] by
-
- 2 edits in trunk/WebCore
2010-03-17 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Remove unused reference to InspectorController from InspectorFrontend.
- inspector/InspectorFrontend.h:
- 7:08 AM Changeset in webkit [56108] by
-
- 14 edits in trunk
2010-03-17 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Pavel Feldman.
WebInspector: Timeline improvements - next iteration.
The top level records should be collapsed.
Virtually linked events should be nested in Timeline like Send Request and
corresponding Received Responce, Timer Install and Timer Fire etc.
It should be possible to see Main Resource request.
- inspector/InspectorController.cpp: (WebCore::InspectorController::resetScriptObjects): (WebCore::InspectorController::didReceiveResponse):
- inspector/InspectorTimelineAgent.cpp: (WebCore::InspectorTimelineAgent::willReceiveResourceResponse): (WebCore::InspectorTimelineAgent::didReceiveResourceResponse):
- inspector/InspectorTimelineAgent.h:
- inspector/front-end/TimelinePanel.js: (WebInspector.TimelinePanel): (WebInspector.TimelinePanel.prototype._createStatusbarButtons): (WebInspector.TimelinePanel.prototype.addRecordToTimeline): (WebInspector.TimelinePanel.prototype._findParentRecord): (WebInspector.TimelinePanel.prototype._innerAddRecordToTimeline): (WebInspector.TimelinePanel.prototype.resize): (WebInspector.TimelinePanel.prototype._createTopLevelRecord): (WebInspector.TimelinePanel.prototype.reset): (WebInspector.TimelinePanel.prototype._clean): (WebInspector.TimelinePanel.prototype._refresh): (WebInspector.TimelinePanel.prototype._refreshRecords): (WebInspector.TimelinePanel.prototype._addToRecordsWindow): (WebInspector.TimelineCalculator.prototype.computeBarGraphPercentages): (WebInspector.TimelineCalculator.prototype.updateBoundaries): (WebInspector.TimelineRecordGraphRow): (WebInspector.TimelineRecordGraphRow.prototype.update): (WebInspector.TimelinePanel.FormattedRecord): (WebInspector.TimelinePanel.FormattedRecord.prototype.get children): (WebInspector.TimelinePanel.FormattedRecord.prototype._generatePopupContent):
- inspector/front-end/inspector.css:
- loader/ResourceLoader.cpp: (WebCore::ResourceLoader::didReceiveResponse):
- 6:51 AM Changeset in webkit [56107] by
-
- 11 edits in trunk/WebCore
2010-03-17 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: Reimplement style-related audits using native API
https://bugs.webkit.org/show_bug.cgi?id=36172
- inspector/InspectorBackend.cpp: (WebCore::InspectorBackend::getAllStyles):
- inspector/InspectorBackend.h:
- inspector/InspectorBackend.idl:
- inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::getAllStyles): (WebCore::InspectorDOMAgent::getMatchedCSSRules): (WebCore::InspectorDOMAgent::buildObjectForStyleSheet): (WebCore::InspectorDOMAgent::buildObjectForRule):
- inspector/InspectorDOMAgent.h:
- inspector/InspectorFrontend.cpp: (WebCore::InspectorFrontend::didGetAllStyles):
- inspector/InspectorFrontend.h:
- inspector/front-end/AuditRules.js: (WebInspector.AuditRules.evaluateInTargetWindow): (WebInspector.AuditRules.UnusedCssRule.prototype.doRun.evalCallback.selectorsCallback): (WebInspector.AuditRules.UnusedCssRule.prototype.doRun.evalCallback.routine): (WebInspector.AuditRules.UnusedCssRule.prototype.doRun.evalCallback): (WebInspector.AuditRules.UnusedCssRule.prototype.doRun.routine): (WebInspector.AuditRules.UnusedCssRule.prototype.doRun): (WebInspector.AuditRules.ImageDimensionsRule.prototype.doRun): (WebInspector.AuditRules.CssInHeadRule.prototype.doRun): (WebInspector.AuditRules.StylesScriptsOrderRule.prototype.doRun):
- inspector/front-end/DOMAgent.js:
- inspector/front-end/InjectedScript.js: (injectedScriptConstructor):
- 5:47 AM Changeset in webkit [56106] by
-
- 4 edits in trunk
WebKit/qt: [Qt] Enable accelerated compositing by default
https://bugs.webkit.org/show_bug.cgi?id=35866
Reviewed by Kenneth Rohde Christiansen.
- Api/qwebsettings.cpp:
(QWebSettings::QWebSettings):
LayoutTests: [Qt] GraphicsLayer: fix test regressions
https://bugs.webkit.org/show_bug.cgi?id=36191
Reviewed by Kenneth Rohde Christiansen.
Enabling accelerated compositing (AC) by default make 3 tests fail.
AC is more important now than these tests, so they are skipped until
fix and AC is enabled.
- platform/qt/Skipped:
- animations/fill-mode-transform.html skipped
- animations/play-state.html skipped
- animations/simultaneous-start-left.html skipped
- 5:10 AM Changeset in webkit [56105] by
-
- 6 edits in trunk/WebCore
2010-03-17 Steve Block <steveblock@google.com>
Reviewed by Jeremy Orlow.
Replace instances of bzero in WebCore/bridge common code with memset
https://bugs.webkit.org/show_bug.cgi?id=36214
Syntax change only, no new tests.
- bridge/jni/JNIUtility.cpp: (JSC::Bindings::getJNIField):
- bridge/jni/jsc/JNIBridgeJSC.cpp: (JavaField::dispatchValueFromInstance):
- bridge/jni/jsc/JNIUtilityPrivate.cpp: (JSC::Bindings::convertValueToJValue):
- bridge/jni/v8/JNIUtilityPrivate.cpp: (JSC::Bindings::convertNPVariantToJValue):
- bridge/jni/v8/JavaNPObjectV8.cpp: (JSC::Bindings::AllocJavaNPObject):
- 3:59 AM Changeset in webkit [56104] by
-
- 5 edits in trunk/WebCore
2010-03-17 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Mark inspector resources as changed so that they are reloaded on the next frontend connection.
Split resetScriptObjects into code specific for page navigation and insepctor frontend disconnection.
- WebCore.xcodeproj/project.pbxproj: Added InspectorWorkerResource.h to the project file.
- inspector/InspectorController.cpp: (WebCore::InspectorController::disconnectFrontend): (WebCore::InspectorController::unbindAllResources): (WebCore::InspectorController::didCommitLoad):
- inspector/InspectorController.h:
- inspector/InspectorResource.cpp: (WebCore::InspectorResource::releaseScriptObject):
- 2:57 AM Changeset in webkit [56103] by
-
- 2 edits in trunk/WebCore
2010-03-17 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: Capture main resource load events in timeline panel.
- inspector/front-end/TimelinePanel.js: (WebInspector.TimelinePanel.prototype._createStatusbarButtons):
- 1:05 AM Changeset in webkit [56102] by
-
- 3 edits in trunk/LayoutTests
Disable new plugin tests from r56079 on Gtk and Qt, since they are failing.
- platform/gtk/Skipped:
- platform/qt/Skipped:
- 12:51 AM Changeset in webkit [56101] by
-
- 2 edits in trunk/LayoutTests
2010-03-17 Xan Lopez <xlopez@igalia.com>
Skip a couple of failing tests in the bots.
- platform/gtk/Skipped:
- 12:39 AM Changeset in webkit [56100] by
-
- 2 edits in trunk/WebCore
2010-03-17 Zoltan Horvath <zoltan@webkit.org>
Reviewed by Eric Seidel.
Allow custom memory allocation control for AtomicString class
https://bugs.webkit.org/show_bug.cgi?id=35907
Inherits the following class from FastAllocBase because it is
instantiated by 'new':
class name - instantiated at: WebCore/'location'
AtomicString - WebCore/html/HTMLTableElement.cpp:525
- platform/text/AtomicString.h:
