Context Navigation

← Previous Period
Next Period →

Timeline

Mar 20, 2010:

7:45 PM Changeset in webkit [56313] by kevino@webkit.org

2 edits in trunk/WebKitTools

[wx] Build fix after recent database API change.

5:39 PM Changeset in webkit [56312] by eric@webkit.org

4 edits in trunk/WebKitTools

2010-03-20 Chris Jerdonek <Chris Jerdonek>

Reviewed by Adam Barth.

Renamed UnitTestLogStream to TestLogStream in webkitpy.

https://bugs.webkit.org/show_bug.cgi?id=36099

TestLogStream is more concise and more consistent with the name of
the module (logtesting rather than logunittesting) and its main
class (LogTesting rather than LogUnitTesting).

Scripts/webkitpy/init/logtesting.py:
- Renamings.

Scripts/webkitpy/style/checker_unittest.py:
- Renamings.

Scripts/webkitpy/style_references.py:
- Renamings.

3:20 PM Changeset in webkit [56311] by tonikitoo@webkit.org

3 edits in trunk/WebCore

Spatial Navigation: Code simplification in FocusController.cpp and SpatialNavigation.cpp (part I)
https://bugs.webkit.org/show_bug.cgi?id=36168

Reviewed by Kenneth Christiansen.
Patch by Antonio Gomes <tonikitoo@webkit.org>

Make use of isNull and document methods introduced in FocusCandidate class by patch in bug 36167.
No functionalty change.

page/FocusController.cpp:

(WebCore::updateFocusCandidateIfCloser):

page/SpatialNavigation.cpp:

(WebCore::distanceInDirection):

2:00 PM Changeset in webkit [56310] by dpranke@chromium.org

1 edit in trunk/WebKitTools/ChangeLog

2010-03-20 Dirk Pranke <dpranke@chromium.org>

Unreviewed change.

Fix typo in Changelog.

WebKitTools/ChangeLog:

1:05 PM Changeset in webkit [56309] by kevino@webkit.org

15 edits in trunk

[wx] Build fixes after recent changes.

12:21 PM Changeset in webkit [56308] by Dimitri Glazkov

2 edits
1 delete in trunk/LayoutTests

Unreviewed, expectations tweak.

Remove expectations for chromium-mac editing/style/apply-through-end-of-document.html as it
now matches platform/mac.

platform/chromium-mac/editing/style/apply-through-end-of-document-expected.txt: Removed.
platform/chromium/test_expectations.txt: Adjusted expectations.

12:10 PM Changeset in webkit [56307] by Dimitri Glazkov

2 edits in trunk/WebKitTools

Unreviewed, tool fix.

Remove vestiges of downstream directory names to unbreak rebaselining tool.

Scripts/webkitpy/layout_tests/port/chromium.py: Changed paths to use WebKit repo.

10:21 AM Changeset in webkit [56306] by Dimitri Glazkov

2 edits in trunk/WebKitTools

2010-03-20 Dirk Pranke <dpranke@chromium.org>

Reviewed by Dimitri Glazkov.

Re-enable the downstream test_expectations overrides file that was
disabled in bug 36396 / r56287.

https://bugs.chromium.org/show_bug.cgi?id=36401

Scripts/webkitpy/layout_tests/port/chromium.py:

10:14 AM Changeset in webkit [56305] by Dimitri Glazkov

2 edits in trunk/LayoutTests

Unreviewed, expectations tweak.

Mark editing/style/apply-through-end-of-document.html as failing

platform/chromium/test_expectations.txt:

9:56 AM Changeset in webkit [56304] by Dimitri Glazkov

2 edits in trunk/LayoutTests

Unreviewed, expectations tweak.

Marked svg/filters/filterRes.svg as failing after
http://trac.webkit.org/changeset/56288/

platform/chromium/test_expectations.txt: Added expectations for svg/filters/filterRes.svg.

9:31 AM Changeset in webkit [56303] by Dimitri Glazkov

4 edits
4 deletes in trunk/WebKit/chromium

2010-03-20 Dimitri Glazkov <Dimitri Glazkov>

No review, rolling out r56294.
http://trac.webkit.org/changeset/56294
https://bugs.webkit.org/show_bug.cgi?id=36262

Broke compile on Chromium canaries.

WebKit.gyp:
public/WebGraphicsContext3D.h: Removed.
public/WebKitClient.h:
src/GraphicsContext3D.cpp: (WebCore::GraphicsContext3DInternal::): (WebCore::GraphicsContext3DInternal::GLConnection::chooseFBConfig): (WebCore::GraphicsContext3DInternal::GLConnection::createNewContext): (WebCore::GraphicsContext3DInternal::GLConnection::createPbuffer): (WebCore::GraphicsContext3DInternal::GLConnection::destroyPbuffer): (WebCore::GraphicsContext3DInternal::GLConnection::makeCurrent): (WebCore::GraphicsContext3DInternal::GLConnection::destroyContext): (WebCore::GraphicsContext3DInternal::GLConnection::getCurrentContext): (WebCore::GraphicsContext3DInternal::GLConnection::GLConnection): (WebCore::GraphicsContext3DInternal::GLConnection::create): (WebCore::GraphicsContext3DInternal::GLConnection::~GLConnection): (WebCore::GraphicsContext3DInternal::VertexAttribPointerState::VertexAttribPointerState): (WebCore::GraphicsContext3DInternal::GraphicsContext3DInternal): (WebCore::GraphicsContext3DInternal::~GraphicsContext3DInternal): (WebCore::GraphicsContext3DInternal::makeContextCurrent): (WebCore::GraphicsContext3DInternal::platformGraphicsContext3D): (WebCore::GraphicsContext3DInternal::platformTexture): (WebCore::createTextureObject): (WebCore::GraphicsContext3DInternal::reshape): (WebCore::GraphicsContext3DInternal::flipVertically): (WebCore::GraphicsContext3DInternal::beginPaint): (WebCore::GraphicsContext3DInternal::activeTexture): (WebCore::GraphicsContext3DInternal::bindBuffer): (WebCore::GraphicsContext3DInternal::bindFramebuffer): (WebCore::GraphicsContext3DInternal::bindTexture): (WebCore::GraphicsContext3DInternal::bufferDataImpl): (WebCore::GraphicsContext3DInternal::disableVertexAttribArray): (WebCore::GraphicsContext3DInternal::enableVertexAttribArray): (WebCore::GraphicsContext3DInternal::getError): (WebCore::GraphicsContext3DInternal::getContextAttributes): (WebCore::GraphicsContext3DInternal::vertexAttribPointer): (WebCore::GraphicsContext3DInternal::viewportImpl): (WebCore::GraphicsContext3DInternal::synthesizeGLError): (WebCore::GraphicsContext3D::create): (WebCore::GraphicsContext3D::GraphicsContext3D): (WebCore::GraphicsContext3D::~GraphicsContext3D): (WebCore::GraphicsContext3D::platformGraphicsContext3D): (WebCore::GraphicsContext3D::platformTexture): (WebCore::GraphicsContext3D::makeContextCurrent): (WebCore::GraphicsContext3D::reshape): (WebCore::GraphicsContext3D::beginPaint): (WebCore::GraphicsContext3D::endPaint): (WebCore::GraphicsContext3D::sizeInBytes): (WebCore::GraphicsContext3D::createBuffer): (WebCore::GraphicsContext3D::createFramebuffer): (WebCore::GraphicsContext3D::createProgram): (WebCore::GraphicsContext3D::createRenderbuffer): (WebCore::GraphicsContext3D::createShader): (WebCore::GraphicsContext3D::createTexture): (WebCore::GraphicsContext3D::deleteBuffer): (WebCore::GraphicsContext3D::deleteFramebuffer): (WebCore::GraphicsContext3D::deleteProgram): (WebCore::GraphicsContext3D::deleteRenderbuffer): (WebCore::GraphicsContext3D::deleteShader): (WebCore::GraphicsContext3D::deleteTexture): (WebCore::GraphicsContext3D::activeTexture): (WebCore::GraphicsContext3D::bindAttribLocation): (WebCore::GraphicsContext3D::bindBuffer): (WebCore::GraphicsContext3D::bindFramebuffer): (WebCore::GraphicsContext3D::bindTexture): (WebCore::GraphicsContext3D::bufferData): (WebCore::GraphicsContext3D::bufferSubData): (WebCore::GraphicsContext3D::checkFramebufferStatus): (WebCore::GraphicsContext3D::detachShader): (WebCore::GraphicsContext3D::disableVertexAttribArray): (WebCore::GraphicsContext3D::drawArrays): (WebCore::GraphicsContext3D::drawElements): (WebCore::GraphicsContext3D::enableVertexAttribArray): (WebCore::GraphicsContext3D::generateMipmap): (WebCore::GraphicsContext3D::getActiveAttrib): (WebCore::GraphicsContext3D::getActiveUniform): (WebCore::GraphicsContext3D::getAttribLocation): (WebCore::GraphicsContext3D::getBooleanv): (WebCore::GraphicsContext3D::getBufferParameteriv): (WebCore::GraphicsContext3D::getContextAttributes): (WebCore::GraphicsContext3D::getError): (WebCore::GraphicsContext3D::getFloatv): (WebCore::GraphicsContext3D::getFramebufferAttachmentParameteriv): (WebCore::GraphicsContext3D::getIntegerv): (WebCore::GraphicsContext3D::getProgramiv): (WebCore::GraphicsContext3D::getProgramInfoLog): (WebCore::GraphicsContext3D::getRenderbufferParameteriv): (WebCore::GraphicsContext3D::getShaderiv): (WebCore::GraphicsContext3D::getShaderInfoLog): (WebCore::GraphicsContext3D::getShaderSource): (WebCore::GraphicsContext3D::getString): (WebCore::GraphicsContext3D::getTexParameterfv): (WebCore::GraphicsContext3D::getTexParameteriv): (WebCore::GraphicsContext3D::getUniformfv): (WebCore::GraphicsContext3D::getUniformiv): (WebCore::GraphicsContext3D::getUniformLocation): (WebCore::GraphicsContext3D::getVertexAttribfv): (WebCore::GraphicsContext3D::getVertexAttribiv): (WebCore::GraphicsContext3D::getVertexAttribOffset): (WebCore::GraphicsContext3D::isBuffer): (WebCore::GraphicsContext3D::isEnabled): (WebCore::GraphicsContext3D::isFramebuffer): (WebCore::GraphicsContext3D::isProgram): (WebCore::GraphicsContext3D::isRenderbuffer): (WebCore::GraphicsContext3D::isShader): (WebCore::GraphicsContext3D::isTexture): (WebCore::GraphicsContext3D::pixelStorei): (WebCore::GraphicsContext3D::readPixels): (WebCore::GraphicsContext3D::releaseShaderCompiler): (WebCore::GraphicsContext3D::shaderSource): (WebCore::GraphicsContext3D::synthesizeGLError): (WebCore::GraphicsContext3D::texImage2D): (WebCore::GraphicsContext3D::texSubImage2D): (WebCore::GraphicsContext3D::uniform1fv): (WebCore::GraphicsContext3D::uniform1iv): (WebCore::GraphicsContext3D::uniform2fv): (WebCore::GraphicsContext3D::uniform2iv): (WebCore::GraphicsContext3D::uniform3fv): (WebCore::GraphicsContext3D::uniform3iv): (WebCore::GraphicsContext3D::uniform4fv): (WebCore::GraphicsContext3D::uniform4iv): (WebCore::GraphicsContext3D::uniformMatrix2fv): (WebCore::GraphicsContext3D::uniformMatrix3fv): (WebCore::GraphicsContext3D::uniformMatrix4fv): (WebCore::GraphicsContext3D::vertexAttrib1fv): (WebCore::GraphicsContext3D::vertexAttrib2fv): (WebCore::GraphicsContext3D::vertexAttrib3fv): (WebCore::GraphicsContext3D::vertexAttrib4fv): (WebCore::GraphicsContext3D::vertexAttribPointer): (WebCore::GraphicsContext3D::viewport):
src/WebGraphicsContext3D.cpp: Removed.
src/WebGraphicsContext3DDefaultImpl.cpp: Removed.
src/WebGraphicsContext3DDefaultImpl.h: Removed.

2:07 AM Changeset in webkit [56302] by mjs@apple.com

4 edits in trunk/WebKitSite

2010-03-20 Maciej Stachowiak <mjs@apple.com>

Reviewed by Mark Rowe.

WebKit blog should be valid HTML5
https://bugs.webkit.org/show_bug.cgi?id=36410

blog/wp-content/themes/webkit/comments-popup.php:
blog/wp-content/themes/webkit/footer.php:
blog/wp-content/themes/webkit/header.php:

2:04 AM Changeset in webkit [56301] by Joseph Pecoraro

3 edits in trunk/WebCore

2010-03-20 Joseph Pecoraro <Joseph Pecoraro>

Reviewed by David Kilzer.

Assertion failure in media/video-controls-with-mutation-event-handler.html
https://bugs.webkit.org/show_bug.cgi?id=36376

Test: media/video-controls-with-mutation-event-handler.html

Break early (when not attached) in the defaultEventHandler before the
slider is completely set up.

rendering/MediaControlElements.cpp: (WebCore::MediaControlTimelineElement::defaultEventHandler): (WebCore::MediaControlVolumeSliderElement::defaultEventHandler):
rendering/RenderMedia.cpp: (WebCore::RenderMedia::createVolumeSlider):

1:12 AM Changeset in webkit [56300] by mjs@apple.com

24 edits in trunk/WebKitSite

2010-03-20 Maciej Stachowiak <mjs@apple.com>

Reviewed by Mark Rowe.

Fix a bunch of HTML5 validation errors on various pages.
https://bugs.webkit.org/show_bug.cgi?id=36409

building/build.html:
building/checkout.html:
building/debug.html:
building/run.html:
building/tools.html:
coding/coding-style.html:
coding/contributing.html:
coding/major-objects.html:
css/main.css: (.asciiart):
demos/index.html:
header.inc:
projects/compat/index.html:
projects/css/index.html:
projects/documentation/index.html:
projects/goals.html:
projects/index.html:
projects/mathml/index.html:
quality/bugpriorities.html:
quality/bugwriting.html:
quality/crashlogs.html:
quality/lifecycle.html:
quality/testing.html:
quality/testwriting.html:

12:24 AM Changeset in webkit [56299] by mjs@apple.com

6 edits in trunk/WebKitSite

2010-03-19 Maciej Stachowiak <mjs@apple.com>

Reviewed by Mark Rowe.

webkit.org should use the HTML5 doctype
https://bugs.webkit.org/show_bug.cgi?id=36407

header.inc:
misc/drosera/index.html:
perf/slickspeed/system/index.php:
perf/slickspeed/system/template.php:
specs/index.html:

Mar 19, 2010:

11:42 PM Changeset in webkit [56298] by mjs@apple.com

2 edits in trunk/WebKitSite

2010-03-19 Maciej Stachowiak <mjs@apple.com>

Reviewed by Mark Rowe.

http://webkit.org/ has an HTML5 validation error
https://bugs.webkit.org/show_bug.cgi?id=36406

nav.inc:

10:29 PM Changeset in webkit [56297] by hamaji@chromium.org

3 edits
2 adds in trunk

2010-03-19 Shinichiro Hamaji <hamaji@chromium.org>

Reviewed by Dan Bernstein.

WebCore::RenderButton::styleDidChange ReadAV@NULL (6739b7fe455ecb54a6812c0866c3b47c)
https://bugs.webkit.org/show_bug.cgi?id=34641

fast/css/first-letter-block-form-controls-crash-expected.txt: Added.
fast/css/first-letter-block-form-controls-crash.html: Added.

2010-03-19 Shinichiro Hamaji <hamaji@chromium.org>

Reviewed by Dan Bernstein.

WebCore::RenderButton::styleDidChange ReadAV@NULL (6739b7fe455ecb54a6812c0866c3b47c)
https://bugs.webkit.org/show_bug.cgi?id=34641

Don't dig into buttons and menu lists when finding which element
should be modified by :first-letter pseudo class. Even before
this change, we didn't dig into inline buttons and menu lists as
they are replaced so this issue wasn't found long time.

Test: fast/css/first-letter-block-form-controls-crash.html

rendering/RenderBlock.cpp: (WebCore::RenderBlock::updateFirstLetter):

9:29 PM Changeset in webkit [56296] by mrowe@apple.com

1 edit
1 add in trunk/LayoutTests

Land a test result that should have been added along with the test in r56286.

transitions/transition-end-event-destroy-iframe-expected.txt: Copied from LayoutTests/transitions/transition-end-event-destroy-renderer-expected.txt.

8:55 PM Changeset in webkit [56295] by eric@webkit.org

11 edits
2 copies
2 adds in trunk

2010-03-19 Adam Barth <abarth@webkit.org>

Reviewed by Daniel Bates.

Change XSSAuditor block syntax
https://bugs.webkit.org/show_bug.cgi?id=34436

Update tests to account for the new blocking syntax. Added test for
disabling the XSS filter.

http/tests/security/xssAuditor/malformed-xss-protection-header-expected.txt:
http/tests/security/xssAuditor/malformed-xss-protection-header.html:
http/tests/security/xssAuditor/no-protection-script-tag-expected.txt: Added.
http/tests/security/xssAuditor/no-protection-script-tag.html: Added.
http/tests/security/xssAuditor/resources/echo-head-base-href.pl:
http/tests/security/xssAuditor/resources/echo-intertag-click-and-notify.pl:
http/tests/security/xssAuditor/resources/echo-intertag.pl:
http/tests/security/xssAuditor/xss-protection-parsing-01-expected.txt: Added.
http/tests/security/xssAuditor/xss-protection-parsing-01.html: Added.

2010-03-19 Adam Barth <abarth@webkit.org>

Reviewed by Daniel Bates.

Change XSSAuditor block syntax
https://bugs.webkit.org/show_bug.cgi?id=34436

Update our blocking syntax to something more reasonable. Also,
implemented a way for a web site to disable the filter.

Tests: http/tests/security/xssAuditor/no-protection-script-tag.html

http/tests/security/xssAuditor/xss-protection-parsing-01.html

page/XSSAuditor.cpp: (WebCore::XSSAuditor::xssProtection): (WebCore::XSSAuditor::findInRequest):
page/XSSAuditor.h:
platform/network/HTTPParsers.cpp: (WebCore::skipToken): (WebCore::parseXSSProtectionHeader):
platform/network/HTTPParsers.h: (WebCore::):

8:35 PM Changeset in webkit [56294] by eric@webkit.org

4 edits
4 adds in trunk/WebKit/chromium

2010-03-19 Kenneth Russell <kbr@google.com>

Reviewed by Darin Fisher.

Add GraphicsContext3D abstraction to WebKit API
https://bugs.webkit.org/show_bug.cgi?id=36262

Added WebGraphicsContext3D to the WebKit API and refactored Chromium's
GraphicsContext3D implementation to use it. All of the OpenGL calls have
been moved out of WebKit/chromium/src/GraphicsContext3D.cpp and into the
WebGraphicsContext3D implementation. GraphicsContext3D is still
responsible for the transfer of rendered output from the
WebGraphicsContext3D to the HTMLCanvasElement.

The GraphicsContext3DInternal class, which is a data member of
GraphicsContext3D for the Chromium port, remains. It is possible to
eliminate this class and thereby one level of delegation, but this is
being deferred.

The needed entry point for a Chrome implementation of
WebGraphicsContext3D has been added to WebKitClient, but it is not being
called yet by GraphicsContext3D. It will be once this patch lands and
Chromium is rolled forward to support this entry point.

This is a large patch, but the transformation is almost entirely
mechanical and there is no change in functionality. Nearly all of
GraphicsContext3D and GraphicsContext3DInternal has been moved to
WebGraphicsContext3DDefaultImpl. The only area where the splitting of
logic is less than mechanical is GraphicsContext3D::beginPaint() and its
callees.

Ran all WebGL layout tests and demos from Khronos site in Chromium.

WebKit.gyp:
public/WebGraphicsContext3D.h: Added. (WebKit::WebGraphicsContext3D::Attributes::Attributes): (WebKit::WebGraphicsContext3D::~WebGraphicsContext3D):
public/WebKitClient.h: (WebKit::WebKitClient::createGraphicsContext3D):
src/GraphicsContext3D.cpp: (WebCore::GraphicsContext3DInternal::GraphicsContext3DInternal): (WebCore::GraphicsContext3DInternal::~GraphicsContext3DInternal): (WebCore::GraphicsContext3DInternal::initialize): (WebCore::GraphicsContext3DInternal::platformGraphicsContext3D): (WebCore::GraphicsContext3DInternal::platformTexture): (WebCore::GraphicsContext3DInternal::beginPaint): (WebCore::GraphicsContext3DInternal::endPaint): (WebCore::GraphicsContext3DInternal::reshape): (WebCore::GraphicsContext3DInternal::bindAttribLocation): (WebCore::GraphicsContext3DInternal::bindTexture): (WebCore::GraphicsContext3DInternal::bufferData): (WebCore::GraphicsContext3DInternal::bufferSubData): (WebCore::GraphicsContext3DInternal::getActiveAttrib): (WebCore::GraphicsContext3DInternal::getActiveUniform): (WebCore::GraphicsContext3DInternal::getAttribLocation): (WebCore::GraphicsContext3DInternal::getContextAttributes): (WebCore::GraphicsContext3DInternal::getProgramInfoLog): (WebCore::GraphicsContext3DInternal::getShaderInfoLog): (WebCore::GraphicsContext3DInternal::getShaderSource): (WebCore::GraphicsContext3DInternal::getString): (WebCore::GraphicsContext3DInternal::getUniformLocation): (WebCore::GraphicsContext3DInternal::readPixels): (WebCore::GraphicsContext3DInternal::shaderSource): (WebCore::GraphicsContext3DInternal::texImage2D): (WebCore::GraphicsContext3DInternal::texSubImage2D): (WebCore::GraphicsContext3DInternal::uniform1fv): (WebCore::GraphicsContext3DInternal::uniform1iv): (WebCore::GraphicsContext3DInternal::uniform2fv): (WebCore::GraphicsContext3DInternal::uniform2iv): (WebCore::GraphicsContext3DInternal::uniform3fv): (WebCore::GraphicsContext3DInternal::uniform3iv): (WebCore::GraphicsContext3DInternal::uniform4fv): (WebCore::GraphicsContext3DInternal::uniform4iv): (WebCore::GraphicsContext3DInternal::uniformMatrix2fv): (WebCore::GraphicsContext3DInternal::uniformMatrix3fv): (WebCore::GraphicsContext3DInternal::uniformMatrix4fv): (WebCore::GraphicsContext3D::GraphicsContext3D): (WebCore::GraphicsContext3D::~GraphicsContext3D): (WebCore::GraphicsContext3D::create): (WebCore::GraphicsContext3D::platformGraphicsContext3D): (WebCore::GraphicsContext3D::platformTexture): (WebCore::GraphicsContext3D::texImage2D): (WebCore::GraphicsContext3D::texSubImage2D):
src/WebGraphicsContext3D.cpp: Added. (WebKit::WebGraphicsContext3D::createDefault):
src/WebGraphicsContext3DDefaultImpl.cpp: Added. (WebKit::WebGraphicsContext3DDefaultImpl::GLConnection::create): (WebKit::WebGraphicsContext3DDefaultImpl::GLConnection::~GLConnection): (WebKit::WebGraphicsContext3DDefaultImpl::VertexAttribPointerState::VertexAttribPointerState): (WebKit::WebGraphicsContext3DDefaultImpl::WebGraphicsContext3DDefaultImpl): (WebKit::WebGraphicsContext3DDefaultImpl::~WebGraphicsContext3DDefaultImpl): (WebKit::WebGraphicsContext3DDefaultImpl::initialize): (WebKit::WebGraphicsContext3DDefaultImpl::makeContextCurrent): (WebKit::WebGraphicsContext3DDefaultImpl::width): (WebKit::WebGraphicsContext3DDefaultImpl::height): (WebKit::WebGraphicsContext3DDefaultImpl::sizeInBytes): (WebKit::createTextureObject): (WebKit::WebGraphicsContext3DDefaultImpl::reshape): (WebKit::WebGraphicsContext3DDefaultImpl::flipVertically): (WebKit::WebGraphicsContext3DDefaultImpl::readBackFramebuffer): (WebKit::WebGraphicsContext3DDefaultImpl::activeTexture): (WebKit::WebGraphicsContext3DDefaultImpl::bindBuffer): (WebKit::WebGraphicsContext3DDefaultImpl::bindFramebuffer): (WebKit::WebGraphicsContext3DDefaultImpl::disableVertexAttribArray): (WebKit::WebGraphicsContext3DDefaultImpl::drawElements): (WebKit::WebGraphicsContext3DDefaultImpl::enableVertexAttribArray): (WebKit::WebGraphicsContext3DDefaultImpl::generateMipmap): (WebKit::WebGraphicsContext3DDefaultImpl::getActiveAttrib): (WebKit::WebGraphicsContext3DDefaultImpl::getActiveUniform): (WebKit::WebGraphicsContext3DDefaultImpl::getContextAttributes): (WebKit::WebGraphicsContext3DDefaultImpl::getError): (WebKit::WebGraphicsContext3DDefaultImpl::getProgramInfoLog): (WebKit::WebGraphicsContext3DDefaultImpl::getShaderInfoLog): (WebKit::WebGraphicsContext3DDefaultImpl::getShaderSource): (WebKit::WebGraphicsContext3DDefaultImpl::getString): (WebKit::WebGraphicsContext3DDefaultImpl::getVertexAttribOffset): (WebKit::WebGraphicsContext3DDefaultImpl::releaseShaderCompiler): (WebKit::WebGraphicsContext3DDefaultImpl::shaderSource): (WebKit::WebGraphicsContext3DDefaultImpl::vertexAttribPointer): (WebKit::WebGraphicsContext3DDefaultImpl::createBuffer): (WebKit::WebGraphicsContext3DDefaultImpl::createFramebuffer): (WebKit::WebGraphicsContext3DDefaultImpl::createProgram): (WebKit::WebGraphicsContext3DDefaultImpl::createRenderbuffer): (WebKit::WebGraphicsContext3DDefaultImpl::createTexture): (WebKit::WebGraphicsContext3DDefaultImpl::deleteBuffer): (WebKit::WebGraphicsContext3DDefaultImpl::deleteFramebuffer): (WebKit::WebGraphicsContext3DDefaultImpl::deleteProgram): (WebKit::WebGraphicsContext3DDefaultImpl::deleteRenderbuffer): (WebKit::WebGraphicsContext3DDefaultImpl::deleteShader): (WebKit::WebGraphicsContext3DDefaultImpl::deleteTexture): (WebKit::WebGraphicsContext3DDefaultImpl::synthesizeGLError):
src/WebGraphicsContext3DDefaultImpl.h: Added. (WebKit::WebGraphicsContext3DDefaultImpl::): (WebKit::WebGraphicsContext3DDefaultImpl::GLConnection::chooseFBConfig): (WebKit::WebGraphicsContext3DDefaultImpl::GLConnection::createNewContext): (WebKit::WebGraphicsContext3DDefaultImpl::GLConnection::createPbuffer): (WebKit::WebGraphicsContext3DDefaultImpl::GLConnection::destroyPbuffer): (WebKit::WebGraphicsContext3DDefaultImpl::GLConnection::makeCurrent): (WebKit::WebGraphicsContext3DDefaultImpl::GLConnection::destroyContext): (WebKit::WebGraphicsContext3DDefaultImpl::GLConnection::getCurrentContext): (WebKit::WebGraphicsContext3DDefaultImpl::GLConnection::GLConnection):

8:03 PM Changeset in webkit [56293] by eric@webkit.org

13 edits in trunk/WebCore

2010-03-19 Eric Uhrhane <ericu@chromium.org>

Reviewed by Dmitry Titov.

Refactor DatabaseTracker.cpp for thread safety
https://bugs.webkit.org/show_bug.cgi?id=34991

This enables calling into DatabaseTracker from multiple context threads,
as will happen once Workers can access the Database. It required a fair
amount of reshuffling of locks. I ended up splitting the public
interface [calls that take locks and call private functions] from the
implementations [calls that assert that locks are already held] in order
to avoid lock conflicts. I also had to make sure we weren't sharing
Strings or SecurityOrigins across threads.

No new tests.

Allow access to database handles from multiple threads IFF SQLite is new enough and the user requests it.

platform/sql/SQLiteDatabase.cpp: (WebCore::SQLiteDatabase::SQLiteDatabase): (WebCore::SQLiteDatabase::disableThreadingChecks):
platform/sql/SQLiteDatabase.h: (WebCore::SQLiteDatabase::sqlite3Handle): (WebCore::SQLiteDatabase::disableThreadingChecks):

Remove an asynchronous call from Database::close back to the execution thread, so that cleanup can be more deterministic.

storage/Database.cpp: (WebCore::Database::markAsDeletedAndClose): (WebCore::Database::close):
storage/Database.h: (WebCore::Database::):
storage/DatabaseDetails.h: (WebCore::DatabaseDetails::DatabaseDetails): (WebCore::DatabaseDetails::thread):
storage/DatabaseTask.cpp: (WebCore::DatabaseCloseTask::doPerformTask):
storage/DatabaseThread.cpp: (WebCore::DatabaseThread::databaseThread):

Any Strings that get stored in DatabaseTracker, and any Strings returned from DatabaseTracker, are now threadsafeCopies.
Public functions now take all needed locks, then generally call only private functions [there are a few exceptions: deletion functions and origins()].
Private functions no longer take locks.
m_quotaMapGuard becomes m_databaseGuard, and now protects m_database, m_quotaMap, m_proposedDatabases, m_databaseDirectoryPath, m_originsBeingDeleted, m_beingCreated, and m_beingDeleted.
m_proposedDatabases replaces m_proposedDatabase, to account for reentrancy.

storage/DatabaseTracker.h:
storage/DatabaseTracker.cpp: (WebCore::DatabaseTracker::originQuotaManagerNoLock): (WebCore::DatabaseTracker::originQuotaManager): (WebCore::DatabaseTracker::DatabaseTracker): (WebCore::DatabaseTracker::setDatabaseDirectoryPath): (WebCore::DatabaseTracker::databaseDirectoryPath): (WebCore::DatabaseTracker::trackerDatabasePath): (WebCore::DatabaseTracker::openTrackerDatabase): (WebCore::DatabaseTracker::canEstablishDatabase): (WebCore::DatabaseTracker::hasEntryForOriginNoLock): (WebCore::DatabaseTracker::hasEntryForOrigin): (WebCore::DatabaseTracker::hasEntryForDatabase): (WebCore::DatabaseTracker::originPath): (WebCore::DatabaseTracker::fullPathForDatabaseNoLock): (WebCore::DatabaseTracker::fullPathForDatabase): (WebCore::DatabaseTracker::populateOrigins): (WebCore::DatabaseTracker::origins): (WebCore::DatabaseTracker::databaseNamesForOriginNoLock): (WebCore::DatabaseTracker::databaseNamesForOrigin): (WebCore::DatabaseTracker::detailsForNameAndOrigin): (WebCore::DatabaseTracker::setDatabaseDetails): (WebCore::DatabaseTracker::usageForDatabase): (WebCore::DatabaseTracker::addOpenDatabase): (WebCore::DatabaseTracker::removeOpenDatabase): (WebCore::DatabaseTracker::usageForOriginNoLock): (WebCore::DatabaseTracker::usageForOrigin): (WebCore::DatabaseTracker::quotaForOriginNoLock): (WebCore::DatabaseTracker::quotaForOrigin): (WebCore::DatabaseTracker::setQuota): (WebCore::DatabaseTracker::addDatabase): (WebCore::DatabaseTracker::deleteAllDatabases): (WebCore::DatabaseTracker::deleteOrigin): (WebCore::DatabaseTracker::deleteDatabase): (WebCore::DatabaseTracker::deleteDatabaseFile): (WebCore::DatabaseTracker::setClient): (WebCore::DatabaseTracker::scheduleNotifyDatabaseChanged): (WebCore::DatabaseTracker::notifyDatabasesChanged):

These functions keep track of in-progress deletions and creations, so that we can make sure nobody every deletes a database file while a live database is using it.
(WebCore::DatabaseTracker::canCreateDatabase):
(WebCore::DatabaseTracker::recordCreatingDatabase):
(WebCore::DatabaseTracker::doneCreatingDatabase):
(WebCore::DatabaseTracker::creatingDatabase):
(WebCore::DatabaseTracker::canDeleteDatabase):
(WebCore::DatabaseTracker::recordDeletingDatabase):
(WebCore::DatabaseTracker::doneDeletingDatabase):
(WebCore::DatabaseTracker::deletingDatabase):
(WebCore::DatabaseTracker::canDeleteOrigin):
(WebCore::DatabaseTracker::deletingOrigin):
(WebCore::DatabaseTracker::recordDeletingOrigin):
(WebCore::DatabaseTracker::doneDeletingOrigin):

Any SecurityOrigins stored in OriginQuotaManager are now threadsafeCopies of inputs. There's a new tryLock() function in addition to the existing lock().

storage/OriginQuotaManager.cpp: (WebCore::OriginQuotaManager::tryLock): (WebCore::OriginQuotaManager::trackOrigin):
storage/OriginQuotaManager.h:

page/SecurityOrigin.cpp: (WebCore::SecurityOrigin::databaseIdentifier): Removed DEFINE_STATIC_LOCAL wrapper on a local variable; it appears to have been a small optimization, but it's not thread-safe.

7:35 PM Changeset in webkit [56292] by eric@webkit.org

6 edits
2 adds in trunk/WebCore

2010-03-19 Luiz Agostini <luiz.agostini@openbossa.org>

Reviewed by Antti Koivisto.

Multiselect popups - rendering
https://bugs.webkit.org/show_bug.cgi?id=36006

The objective of this patch is to create a compile time flag that can be used
to force all <select> elements to be rendered as menu lists.

Theme stylesheet mechanism has been used to change the appearance of the elements.

Class QtStyleOptionWebComboBox has been introduced to provide to QStyle objects
the needed information to render <select multiple> comboboxes.

WebCore.pri:
WebCore.pro:
css/themeQtNoListboxes.css: Added. (select[size][multiple]):
dom/SelectElement.h: (WebCore::SelectElementData::usesMenuList):
platform/qt/QtStyleOptionWebComboBox.h: Added. (WebCore::QtStyleOptionWebComboBox::QtStyleOptionWebComboBox): (WebCore::QtStyleOptionWebComboBox::multiple): (WebCore::QtStyleOptionWebComboBox::checkMultiple):
platform/qt/RenderThemeQt.cpp: (WebCore::RenderThemeQt::extraDefaultStyleSheet): (WebCore::RenderThemeQt::paintMenuList): (WebCore::RenderThemeQt::paintMenuListButton):
platform/qt/RenderThemeQt.h:

6:58 PM Changeset in webkit [56291] by eric@webkit.org

25 edits in trunk

2010-03-19 Zhenyao Mo <zmo@google.com>

Reviewed by Oliver Hunt.

Update WebGLArray.slice() to new spec
https://bugs.webkit.org/show_bug.cgi?id-35612

fast/canvas/webgl/array-unit-tests-expected.txt: Changed tests to reflect the new slice parameters; add new test cases for default inputs for slice.
fast/canvas/webgl/array-unit-tests.html: Ditto.
fast/canvas/webgl/webgl-array-invalid-ranges-expected.txt: Changed tests to reflect the new slice parameters.
fast/canvas/webgl/webgl-array-invalid-ranges.html: Ditto.

2010-03-19 Zhenyao Mo <zmo@google.com>

Reviewed by Oliver Hunt.

Update WebGLArray.slice() to new spec
https://bugs.webkit.org/show_bug.cgi?id-35612

bindings/js/JSWebGLArrayCustom.cpp: Adding support for default inputs. (WebCore::JSWebGLArray::slice):
bindings/v8/custom/V8WebGLArrayCustom.cpp: Ditto. (WebCore::V8WebGLArray::sliceCallback):
html/canvas/WebGLArray.cpp: Map start/end to offset/length. (WebCore::WebGLArray::calculateOffsetAndLength):
html/canvas/WebGLArray.h: Modified slice parameters.
html/canvas/WebGLArray.idl: Define custom binding for slice().
html/canvas/WebGLByteArray.cpp: Modified slice parameters. (WebCore::WebGLByteArray::slice):
html/canvas/WebGLByteArray.h: Ditto.
html/canvas/WebGLFloatArray.cpp: Ditto. (WebCore::WebGLFloatArray::slice):
html/canvas/WebGLFloatArray.h: Ditto.
html/canvas/WebGLIntArray.cpp: Ditto. (WebCore::WebGLIntArray::slice):
html/canvas/WebGLIntArray.h: Ditto.
html/canvas/WebGLShortArray.cpp: Ditto. (WebCore::WebGLShortArray::slice):
html/canvas/WebGLShortArray.h: Ditto.
html/canvas/WebGLUnsignedByteArray.cpp: Ditto. (WebCore::WebGLUnsignedByteArray::slice):
html/canvas/WebGLUnsignedByteArray.h: Ditto.
html/canvas/WebGLUnsignedIntArray.cpp: Ditto. (WebCore::WebGLUnsignedIntArray::slice):
html/canvas/WebGLUnsignedIntArray.h: Ditto.
html/canvas/WebGLUnsignedShortArray.cpp: Ditto. (WebCore::WebGLUnsignedShortArray::slice):
html/canvas/WebGLUnsignedShortArray.h: Ditto.

6:39 PM Changeset in webkit [56290] by eric@webkit.org

1 edit
4 adds in trunk/LayoutTests

2010-03-19 Adam Barth <abarth@webkit.org>

Reviewed by Darin Adler.

Freeze sandbox attributes on creation
https://bugs.webkit.org/show_bug.cgi?id=34184

Test that allow-forms is frozen on document creation.

fast/frames/resources/sandboxed-iframe-form-dynamic-allowed.html: Added.
fast/frames/resources/sandboxed-iframe-form-dynamic-disallowed.html: Added.
fast/frames/sandboxed-iframe-forms-dynamic-expected.txt: Added.
fast/frames/sandboxed-iframe-forms-dynamic.html: Added.

6:20 PM Changeset in webkit [56289] by eric@webkit.org

2 edits
2 adds in trunk/WebCore

2010-03-19 Yong Li <yong.li@torchmobile.com> and Andy Estes <aestes@apple.com>

Reviewed by Darin Adler.

Ensure the segments inside SharedBuffer are merged before constructing
a CFData with it.

https://bugs.webkit.org/show_bug.cgi?id=50843

manual-tests/WebKitSite.webarchive: Added.
manual-tests/webarchive-test.html: Added.
platform/cf/SharedBufferCF.cpp: (WebCore::SharedBuffer::createCFData):

5:45 PM Changeset in webkit [56288] by oliver@apple.com

4 edits
2 adds in trunk

2010-03-19 Justin Schuh <jschuh@chromium.org>

Reviewed by Oliver Hunt.

Security: ReadAV@NULL for negative feMorphology filter radius
https://bugs.webkit.org/show_bug.cgi?id=34566

Prevents building the filter if either radius is negative.
Catches negative radii resulting from conversions.

Test: svg/filters/feMorphology-invalid-radius.svg

svg/SVGFEMorphologyElement.cpp: (WebCore::SVGFEMorphologyElement::build):
svg/graphics/filters/SVGFEMorphology.cpp: (WebCore::FEMorphology::apply):

5:41 PM Changeset in webkit [56287] by dpranke@chromium.org

5 edits in trunk/WebKitTools

2010-03-19 Dirk Pranke <dpranke@chromium.org>

Reviewed by Dimitri Glazkov.

Disable the downstream override expectations temporarily to allow
us to test that we've upstreamed everything correctly. Also, stop
looking at the downstream baselines at all (now you will only be
able to update baselines upstream). In theory this should work, but
if we need to we can always add the downstream dirs back in.

https://bugs.webkit.org/show_bug.cgi?id=36396

Scripts/webkitpy/layout_tests/port/chromium.py:
Scripts/webkitpy/layout_tests/port/chromium_linux.py:
Scripts/webkitpy/layout_tests/port/chromium_mac.py:
Scripts/webkitpy/layout_tests/port/chromium_win.py:

5:28 PM Changeset in webkit [56286] by cmarrin@apple.com

3 edits
2 adds in trunk

Fixed a crash with AnimationController getting deleted out from under itself.

It's possible for the Frame that owns an AnimationController to get deleted
in the EndTransitionEvent (or other animation events) to get deleted in the
event handler. Normally this case is protected against by preventing the Frame
from getting deleted until the end of the runloop. But native uses of the
WebView can subvert this protection. So I added a protector to the
animation event dispatcher to protect it in those cases.

5:08 PM Changeset in webkit [56285] by eric@webkit.org

4 edits in trunk/WebCore

2010-03-19 Luiz Agostini <luiz.agostini@openbossa.org>

Reviewed by Antti Koivisto.

Multiselect Popup - PopupMenuClient extension
https://bugs.webkit.org/show_bug.cgi?id=36178

PopupMenuClient class is the interface used by combobox popup implementations.
It needs to be extended to handle <select multiple> needs.

A new interface named ListPopupMenuClient that inherits from PopupMenuClient was created.
The use of this new class instead of adding methods to PopupMenuClient avoids changes
in other non related implementations of PopupMenuClient.

RenderMenuList has changed to inherit ListPopupMenuClient instead of PopupMenuClient
and to have the new methods implemented.

platform/PopupMenuClient.h:
rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::listBoxSelectItem): (WebCore::RenderMenuList::multiple):
rendering/RenderMenuList.h:

4:42 PM Changeset in webkit [56284] by Simon Fraser

4 edits
2 adds in trunk

2010-03-19 Simon Fraser <Simon Fraser>

Reviewed by Dimitri Glazkov.

https://bugs.webkit.org/show_bug.cgi?id=36387
REGRESSION: Can "uncheck" radio buttons by clicking on them

My change in r56174 caused radio buttons and checkboxes to go down the same code path by virtue
of allowsIndeterminate(), but this broke save/restore behavior on radio buttons.

Fix by saving and restoring both the intermediate and checked state for radio buttons
and checkboxes, as well as the "current radio button" state.

Test: fast/forms/radio-checkbox-restore-indeterminate.html

html/HTMLInputElement.cpp: (WebCore::EventHandlingState::EventHandlingState): New struct to hold state between preDispatchEventHandler() and postDispatchEventHandler(). (WebCore::HTMLInputElement::preDispatchEventHandler): Store intermedate and checked state and the current radio button. (WebCore::HTMLInputElement::postDispatchEventHandler): Restore state as appropriate.
html/HTMLInputElement.h: Add a comment to clarify how 'intermediate' interacts with 'checked', according to the spec.

4:38 PM Changeset in webkit [56283] by dpranke@chromium.org

2 edits in trunk/WebKitTools

2010-03-19 Dirk Pranke <dpranke@chromium.org>

Reviewed by Dimitri Glazkov.

fix typo in chromium test expectations overrides routine
https://bugs.webkit.org/show_bug.cgi?id=36397

Scripts/webkitpy/layout_tests/port/chromium.py:

4:09 PM Changeset in webkit [56282] by darin@chromium.org

2 edits in trunk/LayoutTests

2010-03-19 Darin Fisher <darin@chromium.org>

Temporarily suppress fast/loader/frame-src-change-added-to-history.html
for Tiger to make the bot green.

https://bugs.webkit.org/show_bug.cgi?id=36382

platform/mac-tiger/Skipped:

4:06 PM Changeset in webkit [56281] by dpranke@chromium.org

1 add in trunk/LayoutTests/platform/chromium/test_expectations.txt

2010-03-19 Dirk Pranke <dpranke@chromium.org>

Unreviewed change.

Add in missing test_expectations.txt file that didn't actually
make it into the commit.

https://bugs.webkit.org/show_bug.cgi?id=36326

LayoutTests/platform/chromium/test_expectations.txt

4:05 PM Changeset in webkit [56280] by eric@webkit.org

3 edits in trunk/WebCore

2010-03-19 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: caret moves past prompt in javascript console
https://bugs.webkit.org/show_bug.cgi?id=26602

Having noticed any Element children besides a leading <br> (which are empty
text nodes), WebCore editing facility thinks it should delete the <br>,
thus clearing away the text prompt contents.

inspector/front-end/TextPrompt.js: (WebInspector.TextPrompt.prototype.clearAutoComplete): (WebInspector.TextPrompt.prototype._completionsReady):
inspector/front-end/utilities.js: (Element.prototype.pruneEmptyTextNodes):

4:02 PM Changeset in webkit [56279] by dpranke@chromium.org

3 edits in trunk

2010-03-19 Dirk Pranke <dpranke@chromium.org>

Reviewed by Dimitri Glazkov.

Flip the Chromium ports to look first for the test expectations
in LayoutTests/platform/chromium and only afterwards look in the
Chromium repo downstream for overrides.

https://bugs.webkit.org/show_bug.cgi?id=36326

WebKitTools/Scripts/webkitpy/layout_tests/port/chromium.py:
LayoutTests/platform/chromium/test_expectations.txt

3:52 PM Changeset in webkit [56278] by dpranke@chromium.org

1 edit
2371 adds in trunk/LayoutTests

2010-03-19 Dirk Pranke <dpranke@chromium.org>

Reviewed by Dimitri Glazkov.
Land remaining chromium-linux LayoutTest baselines
(file list omitted due to length).

https://bugs.webkit.org/show_bug.cgi?id=28397

3:43 PM Changeset in webkit [56277] by dpranke@chromium.org

1 edit
1491 adds in trunk/LayoutTests

2010-03-19 Dirk Pranke <dpranke@chromium.org>

Reviewed by Dimitri Glazkov.

Land chromium-linux/fast/{block,css,forms,text} LayoutTest baselines
(file list omitted due to length).

https://bugs.webkit.org/show_bug.cgi?id=28397

platform/chromium-linux/fast/block : Added.
platform/chromium-linux/fast/css : Added.
platform/chromium-linux/fast/forms : Added.
platform/chromium-linux/fast/text : Added.

3:35 PM Changeset in webkit [56276] by dpranke@chromium.org

1 edit
1453 adds in trunk/LayoutTests

2010-03-19 Dirk Pranke <dpranke@chromium.org>

Reviewed by Dimitri Glazkov.

Land chromium-linux/editing LayoutTest baselines
(file list omitted due to length).

https://bugs.webkit.org/show_bug.cgi?id=28397

platform/chromium-linux/editing : Added.

3:33 PM Changeset in webkit [56275] by jhawkins@chromium.org

2 edits in trunk/WebKitTools

2010-03-19 James Hawkins <jhawkins@chromium.org>

Unreviewed.

Add myself to the committers list.

Scripts/webkitpy/committers.py:

3:29 PM Changeset in webkit [56274] by dpranke@chromium.org

1 edit
1893 adds in trunk/LayoutTests

2010-03-19 Dirk Pranke <dpranke@chromium.org>

Reviewed by Dimitri Glazkov.

Land chromium-linux/tables LayoutTest baselines
(file list omitted due to length).

https://bugs.webkit.org/show_bug.cgi?id=28397

platform/chromium-linux/tables : Added.

3:18 PM Changeset in webkit [56273] by dpranke@chromium.org

1 edit
1251 adds in trunk/LayoutTests

010-03-19 Dirk Pranke <dpranke@chromium.org>

Reviewed by Dimitri Glazkov.

Land chromium-linux/svg LayoutTest baselines
(file list omitted due to length).

https://bugs.webkit.org/show_bug.cgi?id=28397

platform/chromium-linux/svg : Added.

3:09 PM Changeset in webkit [56272] by dpranke@chromium.org

1 edit
1244 adds in trunk/LayoutTests

2010-03-19 Dirk Pranke <dpranke@chromium.org>

Reviewed by Dimitri Glazkov.

Land chromium-linux/css* LayoutTest baselines
(file list omitted due to length).

https://bugs.webkit.org/show_bug.cgi?id=28397

platform/chromium-linux/css* : Added.

3:00 PM Changeset in webkit [56271] by dpranke@chromium.org

1 edit
2661 adds in trunk/LayoutTests

2010-03-19 Dirk Pranke <dpranke@chromium.org>

Reviewed by Dimitri Glazkov.

Land remaining chromium-win/* LayoutTest baselines
(file list omitted due to length).

https://bugs.webkit.org/show_bug.cgi?id=28397

platform/chromium-win/* : Added.

2:50 PM Changeset in webkit [56270] by dpranke@chromium.org

1 edit
1811 adds in trunk/LayoutTests

2010-03-19 Dirk Pranke <dpranke@chromium.org>

Reviewed by Dimitri Glazkov.

Land chromium-win/css* LayoutTest baselines
(file list ommitted due to length).

https://bugs.webkit.org/show_bug.cgi?id=28397

platform/chromium-win/css* : Added.

2:38 PM Changeset in webkit [56269] by Csaba Osztrogonác

2 edits in trunk/LayoutTests

[Qt] Back-forward list dumping is incorrect
https://bugs.webkit.org/show_bug.cgi?id=36392

platform/qt/Skipped: fast/loader/frame-src-change-added-to-history.html skipped until fix.

2:34 PM Changeset in webkit [56268] by dpranke@chromium.org

1 edit
2436 adds in trunk/LayoutTests

2010-03-19 Dirk Pranke <dpranke@chromium.org>

Reviewed by Dimitri Glazkov.

Land chromium-win/fast/[l-z]* LayoutTest baselines
(file list ommitted due to length).

https://bugs.webkit.org/show_bug.cgi?id=28397

platform/chromium-win/fast/[l-z]* : Added.

2:24 PM Changeset in webkit [56267] by dpranke@chromium.org

1 edit
2380 adds in trunk/LayoutTests

2010-03-19 Dirk Pranke <dpranke@chromium.org>

Reviewed by Dimitri Glazkov.

Land chromium-win/fast/{a,c,d,e,f,g,h,i,j}* LayoutTest baselines
(file list ommitted due to length).

https://bugs.webkit.org/show_bug.cgi?id=28397

platform/chromium-win/fast/{a,c,d,e,f,g,h,i,j}* : Added.

2:14 PM Changeset in webkit [56266] by xan@webkit.org

2 edits in trunk/LayoutTests

2010-03-19 Xan Lopez <xlopez@igalia.com>

Rubber-stamped by Gustavo Noronha.

r56188 removed lastPosition from the Geolocation code, but the the
geolocation window properties wasn't updated to reflect this. It's
only failing on the GTK+ port, since the other ports have it on
their Skipped list.

fast/dom/Window/window-properties-geolocation-expected.txt:

2:11 PM Changeset in webkit [56265] by Csaba Osztrogonác

2 edits in trunk/LayoutTests

[Qt] REGRESSION (r56209): fast/media/print-restores-previous-mediatype.htm crashes
https://bugs.webkit.org/show_bug.cgi?id=36386

platform/qt/Skipped: fast/media/print-restores-previous-mediatype.html skipped until fix.

2:04 PM Changeset in webkit [56264] by dpranke@chromium.org

1 edit
1216 adds in trunk/LayoutTests

2010-03-19 Dirk Pranke <dpranke@chromium.org>

Reviewed by Dimitri Glazkov.

Land the first part of chromium-win/fast LayoutTest baselines
(file list ommitted due to length).

https://bugs.webkit.org/show_bug.cgi?id=28397

platform/chromium-win/fast: Added.

2:01 PM Changeset in webkit [56263] by abarth@webkit.org

3 edits in trunk/WebKitTools

2010-03-19 Adam Barth <abarth@webkit.org>

Unreviewed.

Fix SheriffBot exception lock when we can't retrieve the first build
from buildbot. (I'll ask Eric to review this change after the fact,
but he's at lunch and I want to get the bot unlocked.)

Scripts/webkitpy/buildbot.py:
Scripts/webkitpy/buildbot_unittest.py:

1:48 PM QtWebKitJournal edited by Simon Hausmann

(diff)

1:21 PM Changeset in webkit [56262] by ap@apple.com

6 edits in trunk/WebKitTools

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=36380
websocket/tests/frame-lengths.html times out on Tiger bot

https://bugs.webkit.org/show_bug.cgi?id=35041
websocket/tests/frame-lengths.html / websocket/tests/simple-stress.html fail on Windows bot

Double the timeout (from 15 seconds to 30 seconds). We can increase it more, if necessary -
sampling the DRT process on Mac OS X takes much longer anyway, so it's better to avoid
timing out than to detect it early.

DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::setWaitToDump):
DumpRenderTree/mac/LayoutTestControllerMac.mm:
DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::waitUntilDone):
DumpRenderTree/win/LayoutTestControllerWin.cpp:
Scripts/run-webkit-tests:

1:20 PM Changeset in webkit [56261] by xan@webkit.org

2 edits in trunk/LayoutTests

2010-03-19 Xan Lopez <xlopez@igalia.com>

Unreviewed, land new expected result for test.

platform/gtk/svg/css/getComputedStyle-basic-expected.txt:

1:15 PM Changeset in webkit [56260] by Laszlo Gombos

4 edits in trunk

2010-03-19 Laszlo Gombos <Laszlo Gombos>

Unreviewed.

Buildfix for Qt v4.5.

Api/qgraphicswebview.cpp: (QGraphicsWebViewOverlay::q):

2010-03-19 Laszlo Gombos <Laszlo Gombos>

Unreviewed.

Buildfix for Qt v4.5.

QtLauncher/main.cpp: (LauncherWindow::LauncherWindow): (LauncherWindow::applyZoom):

1:10 PM Changeset in webkit [56259] by dpranke@chromium.org

1 edit
2855 adds in trunk/LayoutTests

2010-03-19 Dirk Pranke <dpranke@chromium.org>

Reviewed by Dimitri Glazkov.

Land the chromium-win/tables LayoutTest baselines (file list
ommitted due to length).

https://bugs.webkit.org/show_bug.cgi?id=28397

platform/chromium-win/tables: Added.

1:09 PM Changeset in webkit [56258] by Dimitri Glazkov

2 edits in trunk/WebKit/chromium

Unreviewed, build fix.

Rename enqueueStorageEvent to enqueueEvent to match changes in
http://trac.webkit.org/changeset/56249.

src/StorageAreaProxy.cpp:

(WebCore::StorageAreaProxy::storageEvent): Renamed.

1:05 PM Changeset in webkit [56257] by abarth@webkit.org

4 edits in trunk/WebKitTools

2010-03-19 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Operational tweaks to SheriffBot
https://bugs.webkit.org/show_bug.cgi?id=36385

These changes aren't pretty, but they're helpful to make SheriffBot
work operationally. I plan to iterate in these areas, but I wanted to
get this patch landed so I could be running the bot against TOT.

Scripts/webkitpy/commands/sheriffbot.py:
Scripts/webkitpy/irc/ircbot.py:
Scripts/webkitpy/thirdparty/autoinstalled/init.py:

1:01 PM Changeset in webkit [56256] by Adam Roben

3 edits in trunk/WebCore

Windows clean build fix after r56192

WebCore.vcproj/WebCore.vcproj: Copy headers from

platform/graphics/cg to $WebKitOutputDir as part of the post-build
event so that WebKit can use them. (The only one we currently require
is FontPlatformData.h.)

platform/graphics/win/FontPlatformDataCGWin.cpp: Touched to force a

build.

12:56 PM Changeset in webkit [56255] by dpranke@chromium.org

2149 adds in trunk/LayoutTests/platform/chromium-win

2010-03-19 Dirk Pranke <dpranke@chromium.org>

Reviewed by Dimitri Glazkov.

Land the chromium-win/svg LayoutTest baselines (file list
ommitted due to length).

https://bugs.webkit.org/show_bug.cgi?id=28397

platform/chromium-win/svg: Added.

12:54 PM Changeset in webkit [56254] by beidson@apple.com

1 edit
1 move in trunk/LayoutTests

Rubberstamped by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=35594

fast/loader/api-test-new-window-data-load-base-url.html: Removed.
fast/loader/api-test-new-window-data-load-base-url.html-disabled: Copied from fast/loader/api-test-new-window-data-load-base-url.html.

12:41 PM Changeset in webkit [56253] by dpranke@chromium.org

1 edit
103 adds in trunk/LayoutTests

2010-03-19 Dirk Pranke <dpranke@chromium.org>

Reviewed by Dimitri Glazkov.

Land the chromium-win-vista LayoutTest baselines (file list
ommitted due to length).

https://bugs.webkit.org/show_bug.cgi?id=28397

platform/chromium-win-vista: Added.

12:40 PM Changeset in webkit [56252] by dpranke@chromium.org

1 edit
141 adds in trunk/LayoutTests

2010-03-19 Dirk Pranke <dpranke@chromium.org>

Reviewed by Dimitri Glazkov.

Land the chromium-win-xp LayoutTest baselines (file list ommitted due to
length).

https://bugs.webkit.org/show_bug.cgi?id=28397

platform/chromium-win-xp: Added.

12:38 PM Changeset in webkit [56251] by dpranke@chromium.org

1 edit
831 adds in trunk/LayoutTests

2010-03-19 Dirk Pranke <dpranke@chromium.org>

Reviewed by Dimitri Glazkov.

Land the chromium-mac LayoutTest baselines (file list ommitted due to
length).

https://bugs.webkit.org/show_bug.cgi?id=28397

platform/chromium-mac: Added.

11:37 AM Changeset in webkit [56250] by Joseph Pecoraro

2 edits in trunk/WebCore

2010-03-19 Joseph Pecoraro <Joseph Pecoraro>

Reviewed by David Kilzer.

Assertion failure in media/video-controls-with-mutation-event-handler.html
https://bugs.webkit.org/show_bug.cgi?id=36376

Fix crashing test. Underlying the media element's volume slider is a
range input, which sanitizes values before expected on the media control.

rendering/RenderMedia.cpp: (WebCore::RenderMedia::createVolumeSlider):

11:25 AM Changeset in webkit [56249] by beidson@apple.com

6 edits in trunk/WebCore

3 of the new HTML5 loading events need to be asynchronous.

Reviewed by Darin Adler.

Laying the groundwork for:
https://bugs.webkit.org/show_bug.cgi?id=36201
https://bugs.webkit.org/show_bug.cgi?id=36202
https://bugs.webkit.org/show_bug.cgi?id=36334
https://bugs.webkit.org/show_bug.cgi?id=36335

Document already had an asynchronous event delivery mechanism for storage events, so
we can repurpose that for all async events.

No new tests. (No change in behavior)

dom/Document.cpp:

(WebCore::Document::Document):
(WebCore::Document::implicitClose): Use Document::schedule* for the related events.
(WebCore::Document::enqueueEvent): Renamed from enqueueStorageEvent
(WebCore::Document::pendingEventTimerFired): Renamed from "storageEventTimerFired"
(WebCore::Document::statePopped): Use Document::schedulePopstateEvent
(WebCore::Document::enqueuePageshowEvent): All Pageshow events are piped through here.

This will be made asynchronous in a separate patch.

(WebCore::Document::enqueueHashchangeEvent): All Hashchange events are piped through here.

This will be made asynchronous in a separate patch.

(WebCore::Document::enqueuePopstateEvent): All Popstate events are piped through here.

This will be made asynchronous in a separate patch.

dom/Document.h:

(WebCore::):

history/CachedFrame.cpp:

(WebCore::CachedFrameBase::restore): Use Document::enqueuePageshowEvent

loader/FrameLoader.cpp:

(WebCore::FrameLoader::loadInSameDocument): Use Document::enqueueHashchangeEvent

storage/StorageEventDispatcher.cpp:

(WebCore::StorageEventDispatcher::dispatch): Use Document::enqueueEvent

11:23 AM Changeset in webkit [56248] by eric@webkit.org

4 edits in trunk/WebKitTools

2010-03-19 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Help sheriff-bot avoid warning about flaky tests (and add more unit testing)
https://bugs.webkit.org/show_bug.cgi?id=36354

Scripts/webkitpy/buildbot.py:
- Make Build creation easier to Mock and test
Scripts/webkitpy/buildbot_unittest.py:
- Test finding green to red transitions and suspect revisions
Scripts/webkitpy/commands/queries.py:
- Make what-broke note when builders have only failed once.

11:19 AM Changeset in webkit [56247] by ap@apple.com

2 edits in trunk/WebKit/mac

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=36337
Log an error when an OOP plug-in sends an unknown object id

Making these LOG_ERROR and not ASSERTs, because I don't want early returns to look
temporary or redundant.

Plugins/Hosted/NetscapePluginInstanceProxy.mm: (WebKit::NetscapePluginInstanceProxy::evaluate): (WebKit::NetscapePluginInstanceProxy::invoke): (WebKit::NetscapePluginInstanceProxy::invokeDefault): (WebKit::NetscapePluginInstanceProxy::construct): (WebKit::NetscapePluginInstanceProxy::getProperty): (WebKit::NetscapePluginInstanceProxy::setProperty): (WebKit::NetscapePluginInstanceProxy::removeProperty): (WebKit::NetscapePluginInstanceProxy::hasProperty): (WebKit::NetscapePluginInstanceProxy::hasMethod): (WebKit::NetscapePluginInstanceProxy::enumerate):

11:16 AM Changeset in webkit [56246] by kdecker@apple.com

4 edits in trunk/WebCore

Reviewed by Darin Adler and Brady Eidson.

First step toward:
https://bugs.webkit.org/show_bug.cgi?id=36328

This is the first step torward eliminating the WebKit WebNullPluginView class. The responsibility for this will soon
be in platform-independent code in WebCore. The plan is to change RenderEmbeddedObject and give it the capability of
drawing the missing plug-in text.

loader/FrameLoader.cpp: (WebCore::FrameLoader::requestObject): Renamed the renderer parameter to requestEmbeddedObject and made it a RenderEmbeddedObject. (WebCore::FrameLoader::loadPlugin): Likewise.
loader/FrameLoader.h: Updated loadPlugin() and requestObject() method signatures accordingly.

11:01 AM Changeset in webkit [56245] by dpranke@chromium.org

2 edits in trunk/WebKitTools

2010-03-19 Dirk Pranke <dpranke@chromium.org>

Reviewed by Dimitri Glazkov.

Fix the rebaselining tool, which was broken by r36324 when I
added the concept of overridding expectations.

https://bugs.webkit.org/show_bug.cgi?id=36374

Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:

10:30 AM Changeset in webkit [56244] by darin@chromium.org

2 edits in trunk/WebKit/chromium

2010-03-19 Darin Fisher <darin@chromium.org>

Reviewed by Dimitri Glazkov.

[chromium] querying the current history item during a back/forward
navigation should not clobber the scroll offset, etc.
https://bugs.webkit.org/show_bug.cgi?id=36347

We should only allow the current history item to be modified if we are
no longer loading or if the load is a new navigation (i.e., not a
back/forward/reload variant).

src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::currentHistoryItem):

9:41 AM Changeset in webkit [56243] by eric@webkit.org

2 edits in trunk/WebCore

2010-03-19 Laszlo Gombos <Laszlo Gombos>

Reviewed by Simon Hausmann.

[Qt] Disable TILED_BACKING_STORE if Qt version is earlier than Qt4.6
https://bugs.webkit.org/show_bug.cgi?id=36348

Backing store implementation for QtWebKit requires at least Qt
version 4.6.

No new tests as there is no new functionality.

WebCore.pri:

9:16 AM Changeset in webkit [56242] by Joseph Pecoraro

16 edits
2 adds in trunk

2010-03-19 Joseph Pecoraro <Joseph Pecoraro>

Reviewed by David Kilzer.

<input type=range> does not validate correctly without a renderer and the tests are incorrect
https://bugs.webkit.org/show_bug.cgi?id=36259

Setting value attribute on an <input type=range> to an out-of-range value fires oninput
https://bugs.webkit.org/show_bug.cgi?id=16990

Part 2 of 2: When setting the range element's value, overflows and underflows
are automatically sanitized to valid values. Moved the general case
sanitization code out of the Renderer into HTMLInputElement::sanitizeValue.

html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::value): when getting a default value on reset() ensure the defaultValue is provided (WebCore::HTMLInputElement::sanitizeValue): clamp the value within the max/min/step range constraints
html/StepRange.cpp: (WebCore::StepRange::StepRange): allow const element in the constructor (WebCore::StepRange::clampValue): clamp from a String value
html/StepRange.h: (WebCore::StepRange::defaultValue): easy calculation of the default value for max/min/step range constraints
rendering/RenderSlider.cpp: (WebCore::RenderSlider::updateFromElement): no longer handle the general case sanitization in the renderer

2010-03-19 Joseph Pecoraro <Joseph Pecoraro>

Reviewed by David Kilzer.

<input type=range> does not validate correctly without a renderer and the tests are incorrect
https://bugs.webkit.org/show_bug.cgi?id=36259

Setting value attribute on an <input type=range> to an out-of-range value fires oninput
https://bugs.webkit.org/show_bug.cgi?id=16990

When setting the range element's value, overflows and underflows are
automatically sanitized to valid values. Fixed the behavior and removed
tests that were testing for improper behavior.

fast/forms/ValidityState-rangeOverflow-expected.txt:
fast/forms/ValidityState-rangeUnderflow-expected.txt:
fast/forms/input-stepup-stepdown-expected.txt:
fast/forms/script-tests/ValidityState-rangeOverflow.js:
fast/forms/script-tests/ValidityState-rangeUnderflow.js:
fast/forms/script-tests/input-stepup-stepdown.js:
fast/forms/script-tests/validationMessage.js:
fast/forms/validationMessage-expected.txt:

Added test verifying that bug 16990 was fixed as well.

fast/forms/range-input-dynamic-oninput-expected.txt: Added.
fast/forms/range-input-dynamic-oninput.html Added.

Improved test because handling of this case changed.

fast/forms/range-reset-expected.txt:
fast/forms/range-reset.html:

9:16 AM Changeset in webkit [56241] by Joseph Pecoraro

7 edits
2 adds in trunk/WebCore

2010-03-19 Joseph Pecoraro <Joseph Pecoraro>

Reviewed by David Kilzer.

<input type=range> does not validate correctly without a renderer and the tests are incorrect
https://bugs.webkit.org/show_bug.cgi?id=36259

Part 1 of 2: Refactoring the SliderRange struct out of RenderSlider
into a more appropriate place. Changed the named to StepRange. Changed
from a struct to a class.

Added new files to the build.

GNUmakefile.am:
WebCore.gypi:
WebCore.pro:
WebCore.vcproj/WebCore.vcproj:
WebCore.xcodeproj/project.pbxproj:

Renamed and moved class SliderRange to StepRange.

html/StepRange.cpp: Added. (WebCore::StepRange::StepRange): (WebCore::StepRange::clampValue): (WebCore::StepRange::valueFromElement): (WebCore::sliderPosition):
html/StepRange.h: Added. (WebCore::StepRange::proportionFromValue): (WebCore::StepRange::valueFromProportion):
rendering/RenderSlider.cpp: (WebCore::RenderSlider::updateFromElement): updated to use StepRange (WebCore::RenderSlider::setValueForPosition): updated to use StepRange

8:34 AM QtWebKitJournal edited by Simon Hausmann

(diff)

8:33 AM Changeset in webkit [56240] by darin@chromium.org

2 edits in trunk/LayoutTests

2010-03-19 Darin Fisher <darin@chromium.org>

Fix expected results for fast/loader/frame-src-change-added-to-history.html

fast/loader/frame-src-change-added-to-history-expected.txt:

8:27 AM Changeset in webkit [56239] by Simon Hausmann

2 edits in trunk/WebCore

https://bugs.webkit.org/show_bug.cgi?id=36366
Repaint loop when painting using scaled CTMs with different translations

Patch by Antti Koivisto <koivisto@iki.fi> on 2010-03-19
Reviewed by Simon Hausmann.

The code in RenderBoxModelScaleObserver::shouldPaintBackgroundAtLowQuality
tests if the scaling has changed from the previous value by comparing the
transformations. The test fails if the scale is the same but the translation
changes. This can lead to infinite repaint loop if the document is painted
in pieces using different translations (for example for tiling).

rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelScaleObserver::shouldPaintBackgroundAtLowQuality):

8:06 AM QtWebKitBackportingFixes edited by Laszlo Gombos

(diff)

8:03 AM Changeset in webkit [56238] by hamaji@chromium.org

1 edit
5 adds in trunk/LayoutTests

2010-03-19 Shinichiro Hamaji <hamaji@chromium.org>

Reviewed by Darin Adler.

Need a layout test for finding yensign from documents with Japanese encodings
https://bugs.webkit.org/show_bug.cgi?id=36288

editing/selection/find-yensign-and-backslash-expected.txt: Added.
editing/selection/find-yensign-and-backslash.html: Added.
platform/gtk/editing/selection/find-yensign-and-backslash-expected.txt: Added.
platform/qt/editing/selection/find-yensign-and-backslash-expected.txt: Added.
platform/win/editing/selection/find-yensign-and-backslash-expected.txt: Added.

7:10 AM QtWebKitJournal edited by Simon Hausmann

(diff)

6:35 AM Changeset in webkit [56237] by pfeldman@chromium.org

5 edits in trunk/WebCore

2010-03-19 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: editing shorthands does not always work.

https://bugs.webkit.org/show_bug.cgi?id=36362

inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::applyStyleText): (WebCore::InspectorDOMAgent::populateObjectWithStyleProperties): (WebCore::InspectorDOMAgent::shorthandValue):
inspector/InspectorDOMAgent.h:
inspector/front-end/StylesSidebarPane.js: (WebInspector.StylePropertyTreeElement.prototype):
inspector/front-end/inspector.css: (.section .properties li.disabled .enabled-button):
inspector/front-end/inspector.js: (WebInspector.startEditing.editingCommitted):

6:10 AM Changeset in webkit [56236] by vestbo@webkit.org

2 edits in trunk/WebCore

[Qt] Don't replace clip when drawing complex text

Reviewed by Simon Hausmann.

platform/graphics/qt/FontQt.cpp:

3:05 AM Changeset in webkit [56235] by abarth@webkit.org

4 edits in trunk/WebKitTools

2010-03-19 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Misc bug fixes to make the SheriffBot actually work
https://bugs.webkit.org/show_bug.cgi?id=36355

With these changes, I can actually run the sheriff-bot from start to
finish.

Scripts/webkitpy/irc/ircproxy.py:
Scripts/webkitpy/patch/patcher.py:
Scripts/webkitpy/statusserver.py:

2:51 AM Changeset in webkit [56234] by abarth@webkit.org

3 edits in trunk/WebKitTools

2010-03-19 Adam Barth <abarth@webkit.org>

Unreviewed.

Actually import the sheriff-bot command so we can run it. Also, move
the bot to #webkit-test so it doesn't cause a ruckus while we test it.

Scripts/webkitpy/patch/patcher.py:
Scripts/webkitpy/irc/ircbot.py:

2:44 AM Changeset in webkit [56233] by abarth@webkit.org

5 edits
1 copy in trunk/WebKitTools

2010-03-19 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Second cut at SheriffBot
https://bugs.webkit.org/show_bug.cgi?id=36353

This patch should contain a complete SheriffBot that's capable of
saying reasonable things on IRC. I had to refactor the use of
CommitInfo to make the SheriffBot testable, but I did the minimum
necessary. We should grow webkitcheckout over time to contain the
knowledge of ChangeLogs from scm.

Scripts/webkitpy/commands/sheriffbot.py:
Scripts/webkitpy/commands/sheriffbot_unittest.py:
Scripts/webkitpy/mock_bugzillatool.py:
Scripts/webkitpy/patch/patcher.py:
Scripts/webkitpy/webkitcheckout.py: Added.

1:44 AM Changeset in webkit [56232] by abarth@webkit.org

2 edits in trunk/WebKitTools

2010-03-19 Adam Barth <abarth@webkit.org>

Unreviewed.

Fix Hyatt's IRC nickname.

Scripts/webkitpy/committers.py:

1:42 AM Changeset in webkit [56231] by eric@webkit.org

3 edits in trunk/WebKitTools

2010-03-19 Adam Barth <abarth@webkit.org>

Unreviewed.

Add IRC nicknames for the non-reviewer committers.

Scripts/webkitpy/committers.py:

1:10 AM Changeset in webkit [56230] by abarth@webkit.org

2 edits in trunk/WebKitTools

2010-03-19 Adam Barth <abarth@webkit.org>

Unreviewed.

Add IRC nicknames for the non-reviewer committers.

Scripts/webkitpy/committers.py:

12:59 AM Changeset in webkit [56229] by abarth@webkit.org

2 edits in trunk/WebKitTools

2010-03-19 Adam Barth <abarth@webkit.org>

Unreviewed.

More reviewer IRC nicknames.

Scripts/webkitpy/committers.py:

12:53 AM Changeset in webkit [56228] by abarth@webkit.org

2 edits in trunk/WebKitTools

2010-03-19 Adam Barth <abarth@webkit.org>

Unreviewed.

Add a bunch of IRC nicknames for reviewers.

Scripts/webkitpy/committers.py:

12:47 AM Changeset in webkit [56227] by zoltan@webkit.org

2 edits in trunk/WebKitTools

2010-03-19 Zoltan Horvath <zoltan@webkit.org>

Reviewed by Oliver Hunt.

Added USE_SYSTEM_MALLOC flag to build-webkit
https://bugs.webkit.org/show_bug.cgi?id=21272

Add system-alloc flag to build-webkit. It makes easy to switch
between system allocator and TCmalloc.

Scripts/build-webkit:

12:44 AM Changeset in webkit [56226] by abarth@webkit.org

2 edits in trunk/WebKitTools

2010-03-19 Adam Barth <abarth@webkit.org>

Unreviewed "build" fix.

Of course, I caused a regression in the file that isn't tested. :(

Scripts/webkitpy/statusserver.py:

12:37 AM Changeset in webkit [56225] by eric@webkit.org

3 edits in trunk/WebKitTools

2010-03-19 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Simplify BuildBot core builder code for easier re-use
https://bugs.webkit.org/show_bug.cgi?id=36350

I simply couldn't see anything through all this Yak-hair.

Scripts/webkitpy/buildbot.py:
Scripts/webkitpy/commands/queries.py:

12:33 AM Changeset in webkit [56224] by abarth@webkit.org

3 edits in trunk/WebKitTools

2010-03-19 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

committers.py should know IRC nicknames
https://bugs.webkit.org/show_bug.cgi?id=36349

I'll add the actual nicknames in another patch.

Scripts/webkitpy/committers.py:
Scripts/webkitpy/committers_unittest.py:

12:31 AM Changeset in webkit [56223] by darin@chromium.org

6 edits
2 adds in trunk

2010-03-18 Darin Fisher <darin@chromium.org>

Reviewed by Adam Barth.

If a frame is already in the document, then setting its "src" attribute
should add the resultant navigation to history.

https://bugs.webkit.org/show_bug.cgi?id=9166

This behavior is specified in section 4.8.2 of the HTML5 spec.

Test: fast/loader/frame-src-change-added-to-history.html

html/HTMLFrameElementBase.cpp: (WebCore::HTMLFrameElementBase::openURL): (WebCore::HTMLFrameElementBase::setLocation):
html/HTMLFrameElementBase.h:
loader/FrameLoader.cpp: (WebCore::FrameLoader::requestFrame):
loader/FrameLoader.h:

12:20 AM Changeset in webkit [56222] by Simon Hausmann

2 edits in trunk/WebKitTools

https://bugs.webkit.org/show_bug.cgi?id=36318

Patch by Anders Bakken <Anders Bakken <agbakken@gmail.com>> on 2010-03-18
Reviewed by Simon Hausmann.

QtLauncher runs as a GuiClient by default in Qt Embedded which will
make it try to connect to an existing GuiServer. This patch makes it
run like a stand-alone app.