Context Navigation

Added WebGraphicsContext3D to the WebKit API and refactored Chromium's
GraphicsContext3D implementation to use it. All of the OpenGL calls have
been moved out of WebKit/chromium/src/GraphicsContext3D.cpp and into the
WebGraphicsContext3D implementation. GraphicsContext3D is still
responsible for the transfer of rendered output from the
WebGraphicsContext3D to the HTMLCanvasElement.

The GraphicsContext3DInternal class, which is a data member of
GraphicsContext3D for the Chromium port, remains. It is possible to
eliminate this class and thereby one level of delegation, but this is
being deferred.

The needed entry point for a Chrome implementation of
WebGraphicsContext3D has been added to WebKitClient, but it is not being
called yet by GraphicsContext3D. It will be once this patch lands and
Chromium is rolled forward to support this entry point.

This is a large patch, but the transformation is almost entirely
mechanical and there is no change in functionality. Nearly all of
GraphicsContext3D and GraphicsContext3DInternal has been moved to
WebGraphicsContext3DDefaultImpl. The only area where the splitting of
logic is less than mechanical is GraphicsContext3D::beginPaint() and its
callees.

Ran all WebGL layout tests and demos from Khronos site in Chromium
on Mac and Windows.

WebKit.gyp:
public/WebGraphicsContext3D.h: Added. (WebKit::WebGraphicsContext3D::Attributes::Attributes): (WebKit::WebGraphicsContext3D::~WebGraphicsContext3D):
public/WebKitClient.h: (WebKit::WebKitClient::createGraphicsContext3D):
src/GraphicsContext3D.cpp: (WebCore::GraphicsContext3DInternal::GraphicsContext3DInternal): (WebCore::GraphicsContext3DInternal::~GraphicsContext3DInternal): (WebCore::GraphicsContext3DInternal::initialize): (WebCore::GraphicsContext3DInternal::platformGraphicsContext3D): (WebCore::GraphicsContext3DInternal::platformTexture): (WebCore::GraphicsContext3DInternal::beginPaint): (WebCore::GraphicsContext3DInternal::endPaint): (WebCore::GraphicsContext3DInternal::reshape): (WebCore::GraphicsContext3DInternal::bindAttribLocation): (WebCore::GraphicsContext3DInternal::bindTexture): (WebCore::GraphicsContext3DInternal::bufferData): (WebCore::GraphicsContext3DInternal::bufferSubData): (WebCore::GraphicsContext3DInternal::getActiveAttrib): (WebCore::GraphicsContext3DInternal::getActiveUniform): (WebCore::GraphicsContext3DInternal::getAttribLocation): (WebCore::GraphicsContext3DInternal::getContextAttributes): (WebCore::GraphicsContext3DInternal::getProgramInfoLog): (WebCore::GraphicsContext3DInternal::getShaderInfoLog): (WebCore::GraphicsContext3DInternal::getShaderSource): (WebCore::GraphicsContext3DInternal::getString): (WebCore::GraphicsContext3DInternal::getUniformLocation): (WebCore::GraphicsContext3DInternal::readPixels): (WebCore::GraphicsContext3DInternal::shaderSource): (WebCore::GraphicsContext3DInternal::texImage2D): (WebCore::GraphicsContext3DInternal::texSubImage2D): (WebCore::GraphicsContext3DInternal::uniform1fv): (WebCore::GraphicsContext3DInternal::uniform1iv): (WebCore::GraphicsContext3DInternal::uniform2fv): (WebCore::GraphicsContext3DInternal::uniform2iv): (WebCore::GraphicsContext3DInternal::uniform3fv): (WebCore::GraphicsContext3DInternal::uniform3iv): (WebCore::GraphicsContext3DInternal::uniform4fv): (WebCore::GraphicsContext3DInternal::uniform4iv): (WebCore::GraphicsContext3DInternal::uniformMatrix2fv): (WebCore::GraphicsContext3DInternal::uniformMatrix3fv): (WebCore::GraphicsContext3DInternal::uniformMatrix4fv): (WebCore::GraphicsContext3D::GraphicsContext3D): (WebCore::GraphicsContext3D::~GraphicsContext3D): (WebCore::GraphicsContext3D::create): (WebCore::GraphicsContext3D::platformGraphicsContext3D): (WebCore::GraphicsContext3D::platformTexture): (WebCore::GraphicsContext3D::texImage2D): (WebCore::GraphicsContext3D::texSubImage2D):
src/WebGraphicsContext3D.cpp: Added. (WebKit::WebGraphicsContext3D::createDefault):
src/WebGraphicsContext3DDefaultImpl.cpp: Added. (WebKit::WebGraphicsContext3DDefaultImpl::GLConnection::create): (WebKit::WebGraphicsContext3DDefaultImpl::GLConnection::~GLConnection): (WebKit::WebGraphicsContext3DDefaultImpl::VertexAttribPointerState::VertexAttribPointerState): (WebKit::WebGraphicsContext3DDefaultImpl::WebGraphicsContext3DDefaultImpl): (WebKit::WebGraphicsContext3DDefaultImpl::~WebGraphicsContext3DDefaultImpl): (WebKit::WebGraphicsContext3DDefaultImpl::initialize): (WebKit::WebGraphicsContext3DDefaultImpl::makeContextCurrent): (WebKit::WebGraphicsContext3DDefaultImpl::width): (WebKit::WebGraphicsContext3DDefaultImpl::height): (WebKit::WebGraphicsContext3DDefaultImpl::sizeInBytes): (WebKit::createTextureObject): (WebKit::WebGraphicsContext3DDefaultImpl::reshape): (WebKit::WebGraphicsContext3DDefaultImpl::flipVertically): (WebKit::WebGraphicsContext3DDefaultImpl::readBackFramebuffer): (WebKit::WebGraphicsContext3DDefaultImpl::activeTexture): (WebKit::WebGraphicsContext3DDefaultImpl::bindBuffer): (WebKit::WebGraphicsContext3DDefaultImpl::bindFramebuffer): (WebKit::WebGraphicsContext3DDefaultImpl::disableVertexAttribArray): (WebKit::WebGraphicsContext3DDefaultImpl::drawElements): (WebKit::WebGraphicsContext3DDefaultImpl::enableVertexAttribArray): (WebKit::WebGraphicsContext3DDefaultImpl::generateMipmap): (WebKit::WebGraphicsContext3DDefaultImpl::getActiveAttrib): (WebKit::WebGraphicsContext3DDefaultImpl::getActiveUniform): (WebKit::WebGraphicsContext3DDefaultImpl::getContextAttributes): (WebKit::WebGraphicsContext3DDefaultImpl::getError): (WebKit::WebGraphicsContext3DDefaultImpl::getProgramInfoLog): (WebKit::WebGraphicsContext3DDefaultImpl::getShaderInfoLog): (WebKit::WebGraphicsContext3DDefaultImpl::getShaderSource): (WebKit::WebGraphicsContext3DDefaultImpl::getString): (WebKit::WebGraphicsContext3DDefaultImpl::getVertexAttribOffset): (WebKit::WebGraphicsContext3DDefaultImpl::releaseShaderCompiler): (WebKit::WebGraphicsContext3DDefaultImpl::shaderSource): (WebKit::WebGraphicsContext3DDefaultImpl::vertexAttribPointer): (WebKit::WebGraphicsContext3DDefaultImpl::createBuffer): (WebKit::WebGraphicsContext3DDefaultImpl::createFramebuffer): (WebKit::WebGraphicsContext3DDefaultImpl::createProgram): (WebKit::WebGraphicsContext3DDefaultImpl::createRenderbuffer): (WebKit::WebGraphicsContext3DDefaultImpl::createTexture): (WebKit::WebGraphicsContext3DDefaultImpl::deleteBuffer): (WebKit::WebGraphicsContext3DDefaultImpl::deleteFramebuffer): (WebKit::WebGraphicsContext3DDefaultImpl::deleteProgram): (WebKit::WebGraphicsContext3DDefaultImpl::deleteRenderbuffer): (WebKit::WebGraphicsContext3DDefaultImpl::deleteShader): (WebKit::WebGraphicsContext3DDefaultImpl::deleteTexture): (WebKit::WebGraphicsContext3DDefaultImpl::synthesizeGLError):
src/WebGraphicsContext3DDefaultImpl.h: Added. (WebKit::WebGraphicsContext3DDefaultImpl::): (WebKit::WebGraphicsContext3DDefaultImpl::GLConnection::chooseFBConfig): (WebKit::WebGraphicsContext3DDefaultImpl::GLConnection::createNewContext): (WebKit::WebGraphicsContext3DDefaultImpl::GLConnection::createPbuffer): (WebKit::WebGraphicsContext3DDefaultImpl::GLConnection::destroyPbuffer): (WebKit::WebGraphicsContext3DDefaultImpl::GLConnection::makeCurrent): (WebKit::WebGraphicsContext3DDefaultImpl::GLConnection::destroyContext): (WebKit::WebGraphicsContext3DDefaultImpl::GLConnection::getCurrentContext): (WebKit::WebGraphicsContext3DDefaultImpl::GLConnection::GLConnection):

11:08 PM Changeset in webkit [56380] by ukai@chromium.org

3 edits
4 adds in trunk

2010-03-19 Abhishek Arya <inferno@chromium.org>

Reviewed by Adam Barth.

https://bugs.webkit.org/show_bug.cgi?id=36339
This LayoutTest tests for webkit ability to process long invalid headers generated by misbehaving websockets servers.

websocket/tests/long-invalid-header-expected.txt: Added.
websocket/tests/long-invalid-header.html: Added.
websocket/tests/long-invalid-header_wsh.py: Added.
websocket/tests/script-tests/long-invalid-header.js: Added.

2010-03-19 Abhishek Arya <inferno@chromium.org>

Reviewed by Adam Barth.

https://bugs.webkit.org/show_bug.cgi?id=36339
Off-by-one memory corruption fix for long invalid websockets upgrade header

Test: websocket/tests/long-invalid-header.html

websockets/WebSocketHandshake.cpp: (WebCore::WebSocketHandshake::readServerHandshake):

10:51 PM Changeset in webkit [56379] by eric@webkit.org

2 edits in trunk/LayoutTests

2010-03-22 David Kilzer <ddkilzer@apple.com>

Remove http/tests/cookies/simple-cookies-expired.html from skip list after CFNetwork issue is resolved
<http://webkit.org/b/25861>
<rdar://problem/6901322>

Reviewed by Darin Adler.

platform/win/Skipped: Removed:
http/tests/cookies/simple-cookies-expired.html

10:32 PM Changeset in webkit [56378] by eric@webkit.org

1 edit
1 move in trunk/LayoutTests

2010-03-22 Eric Seidel <eric@webkit.org>

Rubber-stamped by Brady Eidson.

fast/loader/cancel-load-during-port-block-timer.html fails on Tiger bot
https://bugs.webkit.org/show_bug.cgi?id=36425

This test bleeds into the next test and causes failures. Unsure of the
cause. Brady suggests we disable it for now (to match the other disabled) api test.

fast/loader/api-test-go-to-current-back-forward-item.html-disabled: Renamed from LayoutTests/fast/loader/api-test-go-to-current-back-forward-item.html.

10:03 PM Changeset in webkit [56377] by ukai@chromium.org

2 edits in trunk/WebCore

2010-03-22 Fumitoshi Ukai <ukai@chromium.org>

Unreviewed build fix for Chromim Mac at r56376

Fix initializer order of PopupContainer.

platform/chromium/PopupMenuChromium.cpp: (WebCore::PopupContainer::PopupContainer):

8:01 PM Changeset in webkit [56376] by eric@webkit.org

10 edits in trunk

2010-03-22 Jay Campan <jcampan@google.com>

Reviewed by Darin Fisher.

Making Chromium select popups not steal activation from the browser.
Select popups are now like autocomplete popups, shown in non-activated
windows.
https://bugs.webkit.org/show_bug.cgi?id=36062

page/chromium/ChromeClientChromium.h:
platform/chromium/PopupMenuChromium.cpp: (WebCore::): (WebCore::PopupContainer::create): (WebCore::PopupContainer::PopupContainer): (WebCore::PopupContainer::~PopupContainer): (WebCore::PopupContainer::showPopup): (WebCore::PopupContainer::showExternal): (WebCore::PopupContainer::hidePopup): (WebCore::PopupMenu::show):
platform/chromium/PopupMenuChromium.h: (WebCore::PopupContainer::): (WebCore::PopupContainer::popupType):

2010-03-22 Jay Campan <jcampan@google.com>

Reviewed by Darin Fisher.

Making Chromium select popups not steal activation from the browser.
Select popups are now like autocomplete popups, shown in non-activated
windows.
https://bugs.webkit.org/show_bug.cgi?id=36062

public/WebViewClient.h: (WebKit::WebViewClient::createPopupMenu):
src/ChromeClientImpl.cpp: (WebKit::ChromeClientImpl::popupOpened): (WebKit::ChromeClientImpl::popupClosed):
src/ChromeClientImpl.h:
src/WebViewImpl.cpp: (WebKit::): (WebKit::WebViewImpl::mouseDown): (WebKit::WebViewImpl::keyEvent): (WebKit::WebViewImpl::selectPopupHandleKeyEvent): (WebKit::WebViewImpl::hideSelectPopup): (WebKit::WebViewImpl::popupOpened): (WebKit::WebViewImpl::popupClosed): (WebKit::WebViewImpl::setFocus): (WebKit::WebViewImpl::applyAutoFillSuggestions): (WebKit::WebViewImpl::applyAutocompleteSuggestions):
src/WebViewImpl.h:

7:21 PM Changeset in webkit [56375] by dimich@chromium.org

4 edits
2 adds in trunk

[v8] Crash if the worker is terminated before its initial script is executed.
https://bugs.webkit.org/show_bug.cgi?id=36336

Reviewed by Nate Chapin.

WebCore:

Test: fast/workers/termination-early.html

bindings/v8/WorkerContextExecutionProxy.cpp:

(WebCore::WorkerContextExecutionProxy::initContextIfNeeded): Check for 0 context. When terminated, the v8 heap initialization returns 0.
(WebCore::WorkerContextExecutionProxy::evaluate): Don't execute script if initialization failed.

bindings/v8/WorkerContextExecutionProxy.h:

LayoutTests:

fast/workers/termination-early-expected.txt: Added.
fast/workers/termination-early.html: Added.

7:11 PM Changeset in webkit [56374] by eric@webkit.org

2 edits in trunk/WebCore

2010-03-22 Andrey Kosyakov <caseq@chromium.org>

Reviewed by Pavel Feldman.

Support creation of fake workers before document is loaded by deferring
attaching of fake workers iframe until document is loaded and buffering all
messages addressed to worker.
https://bugs.webkit.org/show_bug.cgi?id=36445

inspector/front-end/InjectedFakeWorker.js: (InjectedFakeWorker.FakeWorker.prototype.postMessage): (InjectedFakeWorker.FakeWorker.prototype._buildWorker): (InjectedFakeWorker.FakeWorker.prototype._attachWorkerFrameToDocument): (InjectedFakeWorker.FakeWorker.prototype._onWorkerFrameLoaded):

6:31 PM Changeset in webkit [56373] by eric@webkit.org

4 edits in trunk/WebKit/qt

2010-03-22 Kent Hansen <kent.hansen@nokia.com>

Reviewed by Laszlo Gombos.

[Qt] Fix qdoc warnings
https://bugs.webkit.org/show_bug.cgi?id=36447

Api/qgraphicswebview.cpp: Add missing ().
Api/qwebframe.cpp: Remove reference to non-existent parameter "url".
Api/qwebsettings.cpp: Document parameter "location".

6:13 PM Changeset in webkit [56372] by eric@webkit.org

3 edits in trunk/WebKitTools

2010-03-22 Csaba Osztrogonác <Csaba Osztrogonác>

Reviewed by Adam Barth.

Make build_webkit_command() pass MAKEFLAGS environment variable to make.
https://bugs.webkit.org/show_bug.cgi?id=36440

Scripts/webkitpy/webkitport.py:
Scripts/webkitpy/webkitport_unittest.py:

5:28 PM Changeset in webkit [56371] by mjs@apple.com

1 edit
1 add in trunk/WebKitSite

(Not reviewed.)

Add another example.

demos/accessible-ascii-art/butterfly-figure.html: Added.

5:28 PM Changeset in webkit [56370] by eric@webkit.org

4 edits
3 adds in trunk/JavaScriptCore

2010-03-22 Siddharth Mathur <siddharth.mathur@nokia.com>

Reviewed by Laszlo Gombos.

[Symbian] More efficient aligned memory allocation for JSC Collector
https://bugs.webkit.org/show_bug.cgi?id=34350

JavaScriptCore.pri: Added 2 new Symbian source files and HAL linkage

runtime/Collector.cpp: Reduced port-specific code and added private data member (JSC::Heap::Heap): (JSC::Heap::~Heap): (JSC::Heap::destroy): (JSC::Heap::allocateBlock): (JSC::Heap::freeBlockPtr):

runtime/Collector.h: Added private data member

wtf/symbian: Added.
wtf/symbian/BlockAllocatorSymbian.cpp: Added. (WTF::AlignedBlockAllocator::AlignedBlockAllocator): Helper class to allocate aligned blocks more efficiently as required by Collector (WTF::AlignedBlockAllocator::alloc): (WTF::AlignedBlockAllocator::free): (WTF::AlignedBlockAllocator::destroy): (WTF::AlignedBlockAllocator::~AlignedBlockAllocator):
wtf/symbian/BlockAllocatorSymbian.h: Added.

4:51 PM Changeset in webkit [56369] by Csaba Osztrogonác

3 edits in trunk/LayoutTests

Unreviewed, skip new failing test.

fast/loader/stateobjects/replacestate-in-iframe.html caused infinite loop.
https://bugs.webkit.org/show_bug.cgi?id=36467

platform/gtk/Skipped: fast/loader/stateobjects/replacestate-in-iframe.html skipped until fix.
platform/qt/Skipped: fast/loader/stateobjects/replacestate-in-iframe.html skipped until fix.

4:43 PM Changeset in webkit [56368] by mjs@apple.com

1 edit
2 adds in trunk/WebKitSite

(Not reviewed.)

Add example of accessible ASCII art for HTML WG.

demos/accessible-ascii-art: Added.
demos/accessible-ascii-art/butterfly.html: Added.

4:14 PM Changeset in webkit [56367] by Nate Chapin

5 edits
6 adds in trunk/LayoutTests

2010-03-22 Nate Chapin <Nate Chapin>

Unreviewed, Chromium test fixes.

platform/chromium-linux/fast/dynamic/flash-replacement-test-expected.checksum:
platform/chromium-linux/fast/dynamic/flash-replacement-test-expected.png:
platform/chromium-linux/plugins/embed-attributes-style-expected.checksum:
platform/chromium-linux/plugins/embed-attributes-style-expected.png:
platform/chromium-mac/svg/filters/feColorMatrix-values-expected.checksum: Added.
platform/chromium-mac/svg/filters/feColorMatrix-values-expected.png: Added.
platform/chromium-mac/svg/filters/feColorMatrix-values-expected.txt: Added.
platform/chromium-win/svg/filters/feColorMatrix-values-expected.checksum: Added.
platform/chromium-win/svg/filters/feColorMatrix-values-expected.png: Added.
platform/chromium-win/svg/filters/feColorMatrix-values-expected.txt: Added.

4:04 PM Changeset in webkit [56366] by dpranke@chromium.org

4 edits in trunk/WebKitTools

2010-03-22 Dirk Pranke <dpranke@chromium.org>

Reviewed by Dimitri Glazkov.

Change baseline_path() to point to the upstream locations for the
Chromium ports. Also change the reabselining scripts to use the
correct functions to get the baseline directories, and fix the
script's sys.path to pull in simplejson correctly.

https://bugs.webkit.org/show_bug.cgi?id=36417

Scripts/rebaseline-chromium-webkit-tests:
- fix sys.path to pick up simplejson properly
Scripts/webkitpy/layout_tests/port/chromium.py:
- change baseline_path() to use webkit_baseline_path()
- error out correctly if we can't find the chromium base dir
Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
- call baseline_path(), not chromium_baseline_path()

3:57 PM Changeset in webkit [56365] by darin@chromium.org

3 edits
2 adds in trunk

2010-03-22 Darin Fisher <darin@chromium.org>

Reviewed by Brady Eidson.

HistoryController::replaceState() should modify m_currentItem
instead of the current HistoryItem of the BackForwardList.

https://bugs.webkit.org/show_bug.cgi?id=36435

Test: fast/loader/stateobjects/replacestate-in-iframe.html

loader/HistoryController.cpp: (WebCore::HistoryController::replaceState):

3:54 PM Changeset in webkit [56364] by Simon Hausmann

1 edit in trunk/WebKitTools/ChangeLog

Oops, fix spurious angle brackets around name in patch I landed manually

3:31 PM Changeset in webkit [56363] by Joseph Pecoraro

5 edits in trunk/WebCore

2010-03-22 Joseph Pecoraro <Joseph Pecoraro>

Reviewed by David Kilzer.

Upstream Part of the iPhone Platform sharing code with the Mac Platform
https://bugs.webkit.org/show_bug.cgi?id=35870
<rdar://problem/7707283> and <rdar://problem/7707318>

Part 3 of 3: Shared code between iphone and mac. The shared code was
refactored to be usable by both platforms without platform specific
typing, meaning no NSEvent versus WebEvent special cases.

Shared code usable by either mac or iphone platforms.

platform/cocoa/KeyEventCocoa.h:
platform/cocoa/KeyEventCocoa.mm: (WebCore::keyIdentifierForCharCode): (WebCore::windowsKeyCodeForKeyCode): (WebCore::windowsKeyCodeForCharCode):

Make use of the shared code. Keep anything platform specific in the
original file before calling the shared code.

platform/iphone/KeyEventIPhone.mm: (WebCore::keyIdentifierForKeyEvent):
platform/mac/KeyEventMac.mm: (WebCore::keyIdentifierForKeyEvent): (WebCore::windowsKeyCodeForKeyEvent):

3:17 PM Rebaseline edited by Dimitri Glazkov

(diff)

3:15 PM Rebaseline edited by Dimitri Glazkov

Added title. (diff)

3:09 PM Rebaseline edited by Dimitri Glazkov

Clean up rebaseline doc. (diff)

3:05 PM Changeset in webkit [56362] by kdecker@apple.com

8 edits
3 deletes in trunk

Reviewed by Simon Fraser.

https://bugs.webkit.org/show_bug.cgi?id=36328

rendering/RenderEmbeddedObject.cpp: (WebCore::RenderEmbeddedObject::RenderEmbeddedObject): Fix a find/repalce mistake from my earlier patch. Rename m_setShowsMissingPluginIndicator -> m_showsMissingPluginIndicator. (WebCore::RenderEmbeddedObject::updateWidget): Don't update the widget if we're showing the missing plug-in indicator. (WebCore::RenderEmbeddedObject::paint):Fix a find/repalce mistake from my earlier patch. Rename m_setShowsMissingPluginIndicator -> m_showsMissingPluginIndicator. (WebCore::RenderEmbeddedObject::paintReplaced): Ditto.
rendering/RenderEmbeddedObject.h: Ditto. (WebCore::RenderEmbeddedObject::setShowsMissingPluginIndicator): Ditto. (WebCore::RenderEmbeddedObject::showsMissingPluginIndicator): Ditto.

Plugins/WebNetscapePluginView.mm:
Plugins/WebNullPluginView.h: Removed.
Plugins/WebNullPluginView.mm: Removed.
Resources/nullplugin.tiff: Removed.
WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::createPlugin): Invoke the resource load delegate if the plug-in failed to load.

2:56 PM Changeset in webkit [56361] by Joseph Pecoraro

3 edits
1 copy
2 adds in trunk/WebCore

2010-03-22 Joseph Pecoraro <Joseph Pecoraro>

Reviewed by David Kilzer.

Upstream Part of the iPhone Platform sharing code with the Mac Platform
https://bugs.webkit.org/show_bug.cgi?id=35870
<rdar://problem/7707283>

Part 2 of 3: No changes other than moving code around.
Copied KeyEvent function from platform/mac to a platform/cocoa shared directory.

WebCore.xcodeproj/project.pbxproj: Added cocoa group and new files.
platform/cocoa/KeyEventCocoa.h: Added.
platform/cocoa/KeyEventCocoa.mm: Copied from WebCore/platform/mac/KeyEventMac.mm. (WebCore::keyIdentifierForKeyEvent): (WebCore::windowsKeyCodeForKeyEvent): Include the shared code.
platform/mac/KeyEventMac.mm:

2:24 PM Changeset in webkit [56360] by Joseph Pecoraro

3 edits
3 adds in trunk/WebCore

2010-03-22 Joseph Pecoraro <Joseph Pecoraro>

Reviewed by David Kilzer.

Part 1 of 3: Upstream iPhone KeyEvent platform code and share with Mac platform
https://bugs.webkit.org/show_bug.cgi?id=35870
<rdar://problem/7707283>

WebCore.xcodeproj/project.pbxproj: Added iphone group and new files.
platform/iphone: Added.
platform/iphone/KeyEventCodesIPhone.h: Added.
platform/iphone/KeyEventIPhone.mm: Added. Ensure PLATFORM(IPHONE)
platform/mac/KeyEventMac.mm: Ensure PLATFORM(MAC)

2:14 PM Changeset in webkit [56359] by kenneth@webkit.org

2 edits in trunk/LayoutTests

Unreviewed.

Skip editing test that fails

platform/qt/Skipped:

2:08 PM Changeset in webkit [56358] by krit@webkit.org

2 edits in trunk/LayoutTests

2010-03-22 Dirk Schulze <krit@webkit.org>

Out of bounds read in SVG feColorMatrix filter
https://bugs.webkit.org/show_bug.cgi?id=32714

SVG Test has text in it. This caused a wrong DRT result on Mac.
The other result was created on Windows.

platform/mac/svg/filters/feColorMatrix-values-expected.txt:

1:38 PM Changeset in webkit [56357] by kdecker@apple.com

2 edits in trunk/WebCore

Attempt to fix the Leopard build.

rendering/RenderEmbeddedObject.cpp: Add ".f" to contants.

1:28 PM Changeset in webkit [56356] by krit@webkit.org

1 edit
1 add in trunk/LayoutTests

2010-03-22 Dirk Schulze <krit@webkit.org>

Out of bounds read in SVG feColorMatrix filter
https://bugs.webkit.org/show_bug.cgi?id=32714

Add missing expected result.

platform/mac/svg/filters/feColorMatrix-values-expected.txt: Added.

1:24 PM QtWebKitBackportingFixes edited by Laszlo Gombos

(diff)

12:46 PM Changeset in webkit [56355] by krit@webkit.org

3 edits
7 adds in trunk

2010-03-22 Justin Schuh <jschuh@chromium.org>

Reviewed by Dirk Schulze.

Out of bounds read in SVG feColorMatrix filter
https://bugs.webkit.org/show_bug.cgi?id=32714

Prevents an invalid read when a valid values attribute is not
supplied for an feColorMatrix SVG filter. Also fixes general
handling of missing or invalid values attribute.

Tests: svg/filters/feColorMatrix-invalid-value.svg

svg/filters/feColorMatrix-values.svg

svg/SVGFEColorMatrixElement.cpp: (WebCore::SVGFEColorMatrixElement::build):

2010-03-22 Justin Schuh <jschuh@chromium.org>

Reviewed by Dirk Schulze.

Out of bounds read in SVG feColorMatrix filter
https://bugs.webkit.org/show_bug.cgi?id=32714

Prevents an invalid read when a valid values attribute is not
supplied for an feColorMatrix SVG filter. Also fixes general
handling of missing or invalid values attribute.

platform/win/svg/filters: Added.
platform/win/svg/filters/feColorMatrix-values-expected.checksum: Added.
platform/win/svg/filters/feColorMatrix-values-expected.png: Added.
platform/win/svg/filters/feColorMatrix-values-expected.txt: Added.
svg/filters/feColorMatrix-invalid-value-expected.txt: Added.
svg/filters/feColorMatrix-invalid-value.svg: Added.
svg/filters/feColorMatrix-values.svg: Added.

12:37 PM Changeset in webkit [56354] by Philippe Normand

4 edits
2 adds in trunk/WebCore

2010-03-22 Philippe Normand <pnormand@igalia.com>

Reviewed by Eric Carlson.

[GStreamer] Use ImageBuffer API to do painting
https://bugs.webkit.org/show_bug.cgi?id=35783

New ImageGStreamer class abstracting the conversion of GStreamer
buffers to cairo surfaces. Using this makes the painting code of
the player more generic.

GNUmakefile.am:
platform/graphics/gstreamer/ImageGStreamer.h: Added. (WebCore::ImageGStreamer::image):
platform/graphics/gstreamer/ImageGStreamerCairo.cpp: Added. (ImageGStreamer::createImage): (ImageGStreamer::ImageGStreamer): (ImageGStreamer::~ImageGStreamer):
platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivate::paint):
platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:

12:36 PM Changeset in webkit [56353] by Beth Dakin

2 edits in trunk/WebCore

Fix for <rdar://problem/7766437> With Web Inspector opened, a crash
occurs at Webcore:getMatchedCSSRules() when navigating to a
previous page

Reviewed by Darin Adler.

defaultView() can legitimately by null (as it is in this case), so
it must be null-checked.

inspector/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::getStyles):
(WebCore::InspectorDOMAgent::getComputedStyle):
(WebCore::InspectorDOMAgent::getMatchedCSSRules):

12:30 PM Changeset in webkit [56352] by kdecker@apple.com

5 edits in trunk/WebCore

Reviewed by Darin.

https://bugs.webkit.org/show_bug.cgi?id=36328

loader/FrameLoader.cpp: (WebCore::FrameLoader::loadPlugin): Call setShowsMissingPluginIndicator(true) in cases that fail to generate a widget.
rendering/RenderEmbeddedObject.cpp: Added new missing plug-in related static constants (WebCore::RenderEmbeddedObject::RenderEmbeddedObject): Initialize newly boolean to false. (WebCore::RenderEmbeddedObject::paint): Added. (WebCore::RenderEmbeddedObject::paintReplaced): Added. Draws a subtle rounded rectangle containing the text "Missing Plug-in".
rendering/RenderEmbeddedObject.h: Added the following two methods below. (WebCore::RenderEmbeddedObject::setShowsMissingPluginIndicator): (WebCore::RenderEmbeddedObject::showsMissingPluginIndicator):
rendering/RenderWidget.h: Moved paint(PaintInfo&, int, int) from private to protected.

11:45 AM Changeset in webkit [56351] by ap@apple.com

4 edits in trunk/WebKit/mac

Reviewed by John Sullivan.

https://bugs.webkit.org/show_bug.cgi?id=36455
Make WebKit more resistant against plug-in crashes

No tests, because crashing on build bots isn't good, even if it's only helper processes
that crash.

Plugins/Hosted/NetscapePluginInstanceProxy.h: (WebKit::NetscapePluginInstanceProxy::waitForReply): Protect "this", because this function needs it after waiting for reply. Some callers used to do this, but not all, and we really shouldn't depend on callers here.

Plugins/Hosted/NetscapePluginInstanceProxy.mm: (WebKit::NetscapePluginInstanceProxy::wheelEvent): Don't protect the plug-in instance proxy, because this function doesn't use it after waiting for reply. (WebKit::NetscapePluginInstanceProxy::createBindingsInstance): Ditto.

Plugins/Hosted/ProxyInstance.mm: (WebKit::ProxyInstance::invoke): Added an m_instanceProxy null check for another code path.

11:44 AM Changeset in webkit [56350] by Nate Chapin

2 edits in trunk/LayoutTests

2010-03-22 Nate Chapin <Nate Chapin>

Unreviewed, Chromium expectations tweak.

Add fast/dom/error-to-string-stack-overflow.html to expected
failures due to http://trac.webkit.org/changeset/56329.

platform/chromium/test_expectations.txt:

11:40 AM Changeset in webkit [56349] by jwieczorek@webkit.org

5 edits in trunk

2010-03-22 Jakub Wieczorek <faw217@gmail.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Phonon media backend: expose supported MIME types to WebCore

https://bugs.webkit.org/show_bug.cgi?id=33453

List all skipped media tests individually and unskip two fixed by the patch.

platform/qt/Skipped:

2010-03-22 Jakub Wieczorek <faw217@gmail.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Phonon media backend: expose supported MIME types to WebCore

https://bugs.webkit.org/show_bug.cgi?id=33453

MediaPlayerPrivate should expose the MIME types that are supported
by the underlying backend in Phonon.

platform/graphics/qt/MediaPlayerPrivatePhonon.cpp: (WebCore::MediaPlayerPrivate::supportedTypesCache): (WebCore::MediaPlayerPrivate::getSupportedTypes): (WebCore::MediaPlayerPrivate::supportsType):
platform/graphics/qt/MediaPlayerPrivatePhonon.h:

11:33 AM Changeset in webkit [56348] by ggaren@apple.com

6 edits
2 adds in trunk

JavaScriptCore: Fixed <rdar://problem/7728196> REGRESSION (r46701): -(-2147483648)
evaluates to -2147483648 on 32 bit (35842)

Reviewed by Sam Weinig.

Two ways to fix the same bug:

Check for overflow when negating, since negating the largest negative

int causes overflow.

Constant-fold even when negating a negative, since, like they say in

high school, "math works."

assembler/MacroAssemblerARM.h:

(JSC::MacroAssemblerARM::branchNeg32):

assembler/MacroAssemblerX86Common.h:

(JSC::MacroAssemblerX86Common::branchNeg32): Added a branching version
of the negate operator.

jit/JITArithmetic.cpp:

(JSC::JIT::emit_op_negate): Use the branching version of the negate
operator to check for overflow.

(JSC::JIT::emitSlow_op_negate): Link the check for overflow to a slow case.
(We could emit inline code for this, since we know what the result would
be, but that's probably just a waste of generated code.)

parser/Grammar.y: Constant fold even when negating a negative.

LayoutTests: Added a test for <rdar://problem/7728196> REGRESSION (r46701): -(-2147483648)
evaluates to -2147483648 on 32 bit (35842)

Reviewed by Sam Weinig.

fast/js/negate-overflow-expected.txt: Added.
fast/js/negate-overflow.html: Added.

11:18 AM Changeset in webkit [56347] by apavlov@chromium.org

3 edits in trunk/WebCore

2010-03-22 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: AuditRules still use getMatchedCSSRules as a part of the img-related audit.
https://bugs.webkit.org/show_bug.cgi?id=36424

inspector/front-end/AuditRules.js: (WebInspector.AuditRules.ImageDimensionsRule.prototype.doRun): (WebInspector.AuditRules.ImageDimensionsRule.prototype.doRun.receivedImages): (WebInspector.AuditRules.ImageDimensionsRule.prototype.doRun.pushImageNodes):
inspector/front-end/InjectedScript.js: (injectedScriptConstructor):

11:17 AM Changeset in webkit [56346] by darin@chromium.org

3 edits
2 adds in trunk

2010-03-22 Darin Fisher <darin@chromium.org>

Reviewed by Nate Chapin.

[chromium] Renderer crashes when navigating to a reference fragment in
a frame that has no current HistoryItem.

https://bugs.webkit.org/show_bug.cgi?id=36443

Test: fast/loader/crash-replacing-location-before-load.html

src/FrameLoaderClientImpl.cpp: (WebKit::FrameLoaderClientImpl::dispatchDidNavigateWithinPage):

10:51 AM Changeset in webkit [56345] by Darin Adler

2 edits in trunk/WebCore

2010-03-22 Darin Adler <Darin Adler>

Reviewed by Dan Bernstein.

TextBreakIteratorICU.cpp is incompatible with new UBreakIterator type in ICU 4.4
https://bugs.webkit.org/show_bug.cgi?id=36381

platform/text/TextBreakIteratorICU.cpp: (WebCore::setUpIterator): Use reinterpret_cast instead of static_cast or relying on conversion to void*. (WebCore::textBreakFirst): Ditto. (WebCore::textBreakLast): Ditto. (WebCore::textBreakNext): Ditto. (WebCore::textBreakPrevious): Ditto. (WebCore::textBreakPreceding): Ditto. (WebCore::textBreakFollowing): Ditto. (WebCore::textBreakCurrent): Ditto. (WebCore::isTextBreak): Ditto. (WebCore::setUpIteratorWithRules): Ditto.

10:48 AM Changeset in webkit [56344] by eric.carlson@apple.com

8 edits in trunk/WebCore

2010-03-22 Eric Carlson <eric.carlson@apple.com>

Reviewed by Sam Weinig.

Typo in GPL license text
https://bugs.webkit.org/show_bug.cgi?id=36442

Fix typo - "aint with this library" -> "along with this library".

bindings/scripts/CodeGenerator.pm:
bindings/scripts/CodeGeneratorJS.pm:
bindings/scripts/CodeGeneratorObjC.pm:
bindings/scripts/CodeGeneratorV8.pm:
bindings/scripts/IDLParser.pm:
bindings/scripts/IDLStructure.pm:
bindings/scripts/generate-bindings.pl:

10:42 AM Changeset in webkit [56343] by jwieczorek@webkit.org

5 edits in trunk

2010-03-22 Jakub Wieczorek <jwieczorek@webkit.org>

Reviewed by Simon Hausmann.

[Qt] Don't construct a QLineEdit every time when painting a text field
https://bugs.webkit.org/show_bug.cgi?id=36373

Instead, keep one instance per RenderTheme around.

platform/qt/RenderThemeQt.cpp: (WebCore::findFrameLineWidth):

2010-03-22 Jakub Wieczorek <jwieczorek@webkit.org>

Reviewed by Simon Hausmann.

[Qt] Don't construct a QLineEdit every time when painting a text field
https://bugs.webkit.org/show_bug.cgi?id=36373

Add a simple benchmark covering this area.

tests/benchmarks/painting/tst_painting.cpp: (tst_Painting::textAreas):

10:39 AM Changeset in webkit [56342] by ddkilzer@apple.com

3 edits in trunk/JavaScriptCore

<http://webkit.org/b/36431> Clean up 'int' use in UString.cpp after r54789

Reviewed by Darin Adler.

runtime/UString.cpp:

(JSC::UString::from): Changed argument type from 'unsigned int'
to 'unsigned' to match WebKit coding style.
(JSC::UString::find): Changed static_cast<int>() to
static_cast<unsigned>() now that this method returns unsigned.
(JSC::UString::rfind): Ditto.

runtime/UString.h:

(JSC::UString::from): Changed argument type from 'unsigned int'
to 'unsigned' to match WebKit coding style.

10:38 AM Changeset in webkit [56341] by eric@webkit.org

3 edits in trunk/WebCore

2010-03-22 Luiz Agostini <luiz.agostini@openbossa.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Multiselect Popup - adjusting QtAbstractWebPopup
https://bugs.webkit.org/show_bug.cgi?id=36186

QtAbstractWebPopup must provide new methods to be used by its descendants that
wish to handle <select multiple> elements.

platform/qt/QtAbstractWebPopup.cpp: (WebCore::QtAbstractWebPopup::selectItem): (WebCore::QtAbstractWebPopup::multiple):
platform/qt/QtAbstractWebPopup.h:

10:20 AM Changeset in webkit [56340] by eric@webkit.org

4 edits
10 adds in trunk

2010-03-22 Alex Milowski <alex@milowski.com>

Reviewed by Kenneth Rohde Christiansen.

Basic tests of mfrac (fractions)

mathml/presentation/fractions.xhtml: Added.
mathml/presentation/fractions-vertical-alignment.xhtml: Added
platform/mac/mathml/presentation/fractions-expected.checksum: Added.
platform/mac/mathml/presentation/fractions-expected.png: Added.
platform/mac/mathml/presentation/fractions-expected.txt: Added.
platform/mac/mathml/presentation/fractions-vertical-alignment-expected.checksum: Added.
platform/mac/mathml/presentation/fractions-vertical-alignment-expected.png: Added.
platform/mac/mathml/presentation/fractions-vertical-alignment-expected.txt: Added.

2010-03-22 Alex Milowski <alex@milowski.com>

Reviewed by Kenneth Rohde Christiansen.

Added basic support for mfrac (fractions)

Test: mathml/presentation/fractions.xhtml

WebCore.xcodeproj/project.pbxproj:
mathml/MathMLInlineContainerElement.cpp: (WebCore::MathMLInlineContainerElement::createRenderer):
mathml/RenderMathMLFraction.cpp: Added. (WebCore::RenderMathMLFraction::RenderMathMLFraction): (WebCore::RenderMathMLFraction::updateFromElement): (WebCore::RenderMathMLFraction::addChild):
mathml/RenderMathMLFraction.h: Added.

9:47 AM Changeset in webkit [56339] by Darin Adler

4 edits in trunk/WebKit

WebKit: * StringsNotToBeLocalized.txt: Updated for recent changes.

WebKit/win: * WebCoreLocalizedStrings.cpp:
(WebCore::missingPluginText): Fixed localization helper text to match the same
string from Mac WebKit.

9:46 AM Rebaseline created by Dimitri Glazkov

Ported rebaseline tool documentation from Chromium wiki

9:45 AM Changeset in webkit [56338] by ap@apple.com

1 edit
2 adds in trunk/LayoutTests

Reviewed by Oliver Hunt.

https://bugs.webkit.org/show_bug.cgi?id=36400
Add a test for r15750 (Flash crashes after it replaces itself via a document.write())

plugins/destroy-plugin-from-callback-expected.txt: Added.
plugins/destroy-plugin-from-callback.html: Added.

9:29 AM Changeset in webkit [56337] by kdecker@apple.com

14 edits in trunk

Reviewed by John Sullivan.

https://bugs.webkit.org/show_bug.cgi?id=36328

page/mac/WebCoreViewFactory.h: Added -missingPluginText method
platform/LocalizedStrings.h: Added missingPluginText()
platform/gtk/LocalizedStringsGtk.cpp: Likewise.
platform/mac/LocalizedStringsMac.mm: Same here.
platform/qt/Localizations.cpp: Ditto.
English.lproj/Localizable.strings: Added "Missing Plug-in" string.
src/LocalizedStrings.cpp: (WebCore::missingPluginText): Added
WebCoreSupport/WebViewFactory.mm: (-[WebViewFactory missingPluginText]): Added.

9:24 AM Changeset in webkit [56336] by eric@webkit.org

2 edits in trunk/WebKitTools

2010-03-22 Chris Jerdonek <Chris Jerdonek>

Reviewed by Adam Barth.

Refactored the cpu_count() code in executive.py.

https://bugs.webkit.org/show_bug.cgi?id=36437

Scripts/webkitpy/executive.py:
- Moved the import of the multiprocessing module to the top of the file rather than importing from within a function.

8:24 AM Changeset in webkit [56335] by tonikitoo@webkit.org

3 edits in trunk/WebKitTools

Revert "2010-03-18 Jesus Sanchez-Palencia <jesus.palencia@openbossa.org>"

This reverts commit d76f355a659be5b3384f9c26bc6ad64f3256c9fb.

Conflicts:

WebKitTools/ChangeLog

8:09 AM Changeset in webkit [56334] by eric@webkit.org

3 edits in trunk/WebKit/qt

2010-03-22 Yi Shen <shenyi2006@gmail.com>

Reviewed by Simon Hausmann.

https://bugs.webkit.org/show_bug.cgi?id=35933
[Qt] [Symbian] Can not backward select (highlight) text using virtual keyboard
Make sure the selection start index is smaller than the selection end index.

Api/qwebpage.cpp: (QWebPagePrivate::inputMethodEvent):
tests/qwebpage/tst_qwebpage.cpp: (tst_QWebPage::inputMethods):

7:37 AM Changeset in webkit [56333] by eric@webkit.org

7 edits
3 adds in trunk/JavaScriptCore

2010-03-22 Jedrzej Nowacki <jedrzej.nowacki@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

Add support for syntax checking in the QtScript API.

New class was created; the QScriptSyntaxCheckResult which main
responsibility is to provide results of the ECMA Script code
syntax check. The class is not fully functional as the JSC C API
doesn't expose an error column number, but it is a good start point
for a future development.

[Qt] QtScript functionality should be extended by syntax checking.
https://bugs.webkit.org/show_bug.cgi?id=36123

qt/api/QtScript.pro:
qt/api/qscriptengine.cpp: (QScriptEngine::checkSyntax):
qt/api/qscriptengine.h:
qt/api/qscriptengine_p.cpp: (QScriptEnginePrivate::checkSyntax):
qt/api/qscriptengine_p.h:
qt/api/qscriptsyntaxcheckresult.cpp: Added. (QScriptSyntaxCheckResult::QScriptSyntaxCheckResult): (QScriptSyntaxCheckResult::~QScriptSyntaxCheckResult): (QScriptSyntaxCheckResult::operator=): (QScriptSyntaxCheckResult::state): (QScriptSyntaxCheckResult::errorLineNumber): (QScriptSyntaxCheckResult::errorColumnNumber): (QScriptSyntaxCheckResult::errorMessage):
qt/api/qscriptsyntaxcheckresult.h: Added.
qt/api/qscriptsyntaxcheckresult_p.cpp: Added. (QScriptSyntaxCheckResultPrivate::~QScriptSyntaxCheckResultPrivate): (QScriptSyntaxCheckResultPrivate::errorMessage): (QScriptSyntaxCheckResultPrivate::errorLineNumber):
qt/api/qscriptsyntaxcheckresult_p.h: Added. (QScriptSyntaxCheckResultPrivate::get): (QScriptSyntaxCheckResultPrivate::QScriptSyntaxCheckResultPrivate): (QScriptSyntaxCheckResultPrivate::state): (QScriptSyntaxCheckResultPrivate::errorColumnNumber):
qt/tests/qscriptengine/tst_qscriptengine.cpp: (tst_QScriptEngine::checkSyntax_data): (tst_QScriptEngine::checkSyntax):

6:26 AM Changeset in webkit [56332] by yurys@chromium.org

2 edits in trunk/WebKit/chromium

2010-03-22 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Fix inspected Page crash in destructor when Web Inspector is open.

https://bugs.webkit.org/show_bug.cgi?id=36441

src/js/InjectDispatch.js: (inspectedPageDestroyed): Added stub for missing method.

5:49 AM Changeset in webkit [56331] by Chris Jerdonek

2 edits
1 copy
1 add in trunk/WebKitTools

Created a function for getting a module-specific logging.logger
based on the file value of the module.

Reviewed by Adam Barth.

https://bugs.webkit.org/show_bug.cgi?id=35821

This function allows us to get the module-specific logger for
a module without having to hard-code the fully-qualified name
of the module in the module itself. The code can be the same
in every case: "_log = logutils.get_logger(file)".

Scripts/webkitpy/init/logutils.py: Added.
- Added a module with a get_logger() function to return a module-specific logger based on the module's file variable.

Scripts/webkitpy/init/logutils_unittest.py: Added.
- Added unit tests for logutils.py.

Scripts/webkitpy/init/unittests.py:
- Added logutils_unittest to the list of imports.

4:43 AM QtWebKitBackportingFixes edited by Simon Hausmann

(diff)

4:07 AM Changeset in webkit [56330] by eric@webkit.org

3 edits in trunk/WebKit/chromium

2010-03-22 Jochen Eisinger <jochen@chromium.org>

Reviewed by Jeremy Orlow.

Added methods to WebSecurityOrigin for invoking
SecurityOrigin::canAccess and SecurityOrigin::Create
https://bugs.webkit.org/show_bug.cgi?id=36356

public/WebSecurityOrigin.h:
src/WebSecurityOrigin.cpp: (WebKit::WebSecurityOrigin::create): (WebKit::WebSecurityOrigin::canAccess):

2:46 AM Changeset in webkit [56329] by yurys@chromium.org

8 edits
1 add in trunk

2010-03-22 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Handle worker exceptions in V8MessageHandler like it's done in regular documents. This way all worker exceptions will be logged in the console not only those which happen in event listeners.

https://bugs.webkit.org/show_bug.cgi?id=31171

bindings/v8/V8AbstractEventListener.cpp: (WebCore::V8AbstractEventListener::invokeEventHandler): Removed explicit call to reportException.
bindings/v8/V8Utilities.cpp: reportException function was removed since it's not used. (WebCore::getScriptExecutionContext):
bindings/v8/V8Utilities.h:
bindings/v8/WorkerContextExecutionProxy.cpp: (WebCore::v8MessageHandler): (WebCore::WorkerContextExecutionProxy::initContextIfNeeded): Setup message handler when first worker context is created.

2010-03-22 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Test that uncaught exception thrown from setTimeout callback in a Worker is reported to the worker object.

https://bugs.webkit.org/show_bug.cgi?id=31171

fast/workers/resources/worker-exception-in-timeout-callback.js: Added.
fast/workers/worker-script-error-expected.txt:
fast/workers/worker-script-error.html:

2:43 AM Changeset in webkit [56328] by eric@webkit.org

4 edits in trunk

2010-03-22 Kenneth Rohde Christiansen <kenneth@webkit.org>

Reviewed by Simon Hausmann.

[Qt] REGRESSION (r56209): fast/media/print-restores-previous-mediatype.htm crashes
https://bugs.webkit.org/show_bug.cgi?id=36386

platform/qt/Skipped: unskip the test as it now passes.

2010-03-22 Kenneth Rohde Christiansen <kenneth@webkit.org>

Reviewed by Simon Hausmann.

[Qt] REGRESSION (r56209): fast/media/print-restores-previous-mediatype.htm crashes
https://bugs.webkit.org/show_bug.cgi?id=36386

Fix the regression by implementing a null printer for Qt DRT.

DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::NullPrinter::NullPaintEngine::begin): (WebCore::NullPrinter::NullPaintEngine::end): (WebCore::NullPrinter::NullPaintEngine::type): (WebCore::NullPrinter::NullPaintEngine::drawPixmap): (WebCore::NullPrinter::NullPaintEngine::updateState): (WebCore::NullPrinter::paintEngine): (WebCore::DumpRenderTree::dryRunPrint):

2:24 AM Changeset in webkit [56327] by eric@webkit.org

2 edits in trunk/WebCore

2010-03-22 Leandro Pereira <leandro@profusion.mobi>

Reviewed by Simon Hausmann.

Add EFL-specific code to page/EventHandler.cpp.
http://webkit.org/b/36306

page/EventHandler.cpp:

2:06 AM Changeset in webkit [56326] by eric@webkit.org

3 edits in trunk/WebCore

2010-03-22 Leandro Pereira <leandro@profusion.mobi>

Reviewed by Simon Hausmann.

Add EFL-specific code to platform/DragImage.h and
platform/DragData.h.
http://webkit.org/b/36310

platform/DragImage.h:
platform/DragData.h:

1:45 AM Changeset in webkit [56325] by eric@webkit.org

2 edits in trunk/WebCore

2010-03-22 Leandro Pereira <leandro@profusion.mobi>

Reviewed by Simon Hausmann.

Add EFL-specific code to platform/FileSystem.h.
http://webkit.org/b/36313

platform/FileSystem.h:

1:26 AM Changeset in webkit [56324] by eric@webkit.org

2 edits in trunk/WebCore

2010-03-22 Leandro Pereira <leandro@profusion.mobi>

Reviewed by Simon Hausmann.

Add EFL-specific code to platform/Cursor.h.
http://webkit.org/b/36319

platform/Cursor.h:

1:05 AM Changeset in webkit [56323] by eric@webkit.org

2 edits in trunk/WebCore

2010-03-22 Leandro Pereira <leandro@profusion.mobi>

Reviewed by Simon Hausmann.

Add EFL-specific code to platform/NotImplemented.h.
http://webkit.org/b/36320

platform/NotImplemented.h:

Mar 21, 2010:

4:21 PM Changeset in webkit [56322] by eric@webkit.org

3 edits in trunk/WebKit/qt

2010-03-21 Kristian Amlie <kristian.amlie@nokia.com>

Reviewed by Simon Hausmann.

Fixed updating the VKB display when inputting into QGraphicsWebView.
https://bugs.webkit.org/show_bug.cgi?id=36292

Api/qgraphicswebview.cpp: (QGraphicsWebViewPrivate::_q_updateMicroFocus): (QGraphicsWebView::setPage):
Api/qgraphicswebview.h:

3:52 PM Changeset in webkit [56321] by eric@webkit.org

2 edits in trunk/WebCore

2010-03-21 Kim Grönholm <kim.gronholm@nomovok.com>

Reviewed by Simon Hausmann.

[Qt] GraphicsLayer: matrix interpolations in transform-animations don't behave correctly
https://bugs.webkit.org/show_bug.cgi?id=35520

The case where the list of source and target transform operations are
not the same but have the same size needs to be special-cased in
GraphicsLayerQt, as well as the case where the source or target
operation list is empty. The URLs listed here render correctly after
applying the patch.

Tests: https://bug-35520-attachments.webkit.org/attachment.cgi?id=49890

https://bug-35520-attachments.webkit.org/attachment.cgi?id=49889

platform/graphics/qt/GraphicsLayerQt.cpp: (WebCore::TransformAnimationQt::applyFrame):

3:30 PM Changeset in webkit [56320] by eric@webkit.org

7 edits
1 copy
2 adds in trunk/JavaScriptCore

2010-03-21 Jedrzej Nowacki <jedrzej.nowacki@nokia.com>

Reviewed by Simon Hausmann.

New class; QScriptProgram.

The class should be used to evaluate the same script multiple times
more efficiently.

[Qt] QtScript should have QScriptProgram class
https://bugs.webkit.org/show_bug.cgi?id=36008

qt/api/QtScript.pro:
qt/api/qscriptengine.cpp: (QScriptEngine::evaluate):
qt/api/qscriptengine.h:
qt/api/qscriptengine_p.cpp: (QScriptEnginePrivate::evaluate):
qt/api/qscriptengine_p.h: (QScriptEnginePrivate::evaluate):
qt/api/qscriptprogram.cpp: Added. (QScriptProgram::QScriptProgram): (QScriptProgram::~QScriptProgram): (QScriptProgram::operator=): (QScriptProgram::isNull): (QScriptProgram::sourceCode): (QScriptProgram::fileName): (QScriptProgram::firstLineNumber): (QScriptProgram::operator==): (QScriptProgram::operator!=):
qt/api/qscriptprogram.h: Added.
qt/api/qscriptprogram_p.h: Added. (QScriptProgramPrivate::get): (QScriptProgramPrivate::QScriptProgramPrivate): (QScriptProgramPrivate::~QScriptProgramPrivate): (QScriptProgramPrivate::isNull): (QScriptProgramPrivate::sourceCode): (QScriptProgramPrivate::fileName): (QScriptProgramPrivate::firstLineNumber): (QScriptProgramPrivate::operator==): (QScriptProgramPrivate::operator!=): (QScriptProgramPrivate::program): (QScriptProgramPrivate::file): (QScriptProgramPrivate::line):
qt/tests/qscriptengine/tst_qscriptengine.cpp: (tst_QScriptEngine::evaluateProgram):

3:19 PM Changeset in webkit [56319] by ddkilzer@apple.com

5 edits
2 adds in trunk

<http://webkit.org/b/14858> <col> width ignored when not tied to a single cell

Patch by Dmitry Gorbik <socket.h@gmail.com> on 2010-03-21
Reviewed by David Kilzer.

Fixed width calculation for cells with span when <col> is defined.

WebCore:

Test: fast/table/col-width-span-expand.html

rendering/RenderTableCell.cpp:

(WebCore::RenderTableCell::styleOrColWidth): Added the calculation of cell width
in case of <col> defined and span > 1.

LayoutTests:

fast/table/col-width-span-expand-expected.txt: Added.
fast/table/col-width-span-expand.html: Added.

1:08 PM Changeset in webkit [56318] by ddkilzer@apple.com

3 edits in trunk/JavaScriptCore

Blind attempt #2 to fix the Windows build after r56314

API/tests/testapi.c: Include JSObjectRefPrivate.h for the new

methods instead of declaring them locally (and non-extern).

JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:

Backed out previous change.

12:56 PM Changeset in webkit [56317] by ddkilzer@apple.com

2 edits in trunk/JavaScriptCore

Blind attempt to fix the Windows build after r56314

Try to fix the following errors on the Windows buildbot:

Linking...
testapi.obj : error LNK2001: unresolved external symbol "bool cdecl JSObjectSetPrivateProperty(struct OpaqueJSContext const *,struct OpaqueJSValue *,struct OpaqueJSString *,struct OpaqueJSValue const *)" (?JSObjectSetPrivateProperty@@YA_NPBUOpaqueJSContext@@PAUOpaqueJSValue@@PAUOpaqueJSString@@PBU2@@Z)
testapi.obj : error LNK2001: unresolved external symbol "struct OpaqueJSValue const * cdecl JSObjectGetPrivateProperty(struct OpaqueJSContext const *,struct OpaqueJSValue *,struct OpaqueJSString *)" (?JSObjectGetPrivateProperty@@YAPBUOpaqueJSValue@@PBUOpaqueJSContext@@PAU1@PAUOpaqueJSString@@@Z)
C:\cygwin\home\buildbot\slave\win-release\build\WebKitBuild\bin\testapi.exe : fatal error LNK1120: 2 unresolved externals

JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def: Added

missing symbols to be exported.

12:09 PM Changeset in webkit [56316] by Martin Robinson

4 edits in trunk

2010-03-20 Martin Robinson <Martin Robinson>

Reviewed by Xan Lopez

[GTK] eventSender.zoomPageOut() bug?
https://bugs.webkit.org/show_bug.cgi?id=30575

Unskip some tests that were failing because of the bug in DRT.

platform/gtk/Skipped:

2010-03-20 Martin Robinson <Martin Robinson>

Reviewed by Xan Lopez.

[GTK] eventSender.zoomPageOut() bug?
https://bugs.webkit.org/show_bug.cgi?id=30575

Make zoomPage{In/Out}Callback respect the 1.2f zoom factor that DRT should be using.

DumpRenderTree/gtk/EventSender.cpp: (zoomIn): Added. (zoomOut): Added. (textZoomInCallback): Use zoomIn helper function. (textZoomOutCallback): Use zoomOut helper function. (zoomPageInCallback): Use zoomIn helper function, which respects zoom factor. (zoomPageOutCallback): Use zoomOut helper function, which respects zoom factor.

5:22 AM QtWebKitPlugins edited by yael.aharon@nokia.com

(diff)

1:35 AM Changeset in webkit [56315] by oliver@apple.com

2 edits in trunk/JavaScriptCore

Documentation fix for previous patch.

Reviewed by Maciej Stachowiak.

API/JSObjectRefPrivate.h:

12:40 AM Changeset in webkit [56314] by oliver@apple.com

6 edits
1 add in trunk/JavaScriptCore

2010-03-20 Oliver Hunt <oliver@apple.com>

Reviewed by Maciej Stachowiak.

JSC needs an API to allow custom objects to have aprivate GC-accessible properties
https://bugs.webkit.org/show_bug.cgi?id=36420

Add new API methods to support "private" properties on custom
objects.

API/JSCallbackObject.h: (JSC::JSCallbackObjectData::JSCallbackObjectData): (JSC::JSCallbackObjectData::~JSCallbackObjectData): (JSC::JSCallbackObjectData::getPrivateProperty): (JSC::JSCallbackObjectData::setPrivateProperty): (JSC::JSCallbackObjectData::deletePrivateProperty): (JSC::JSCallbackObjectData::markChildren): (JSC::JSCallbackObjectData::JSPrivatePropertyMap::getPrivateProperty): (JSC::JSCallbackObjectData::JSPrivatePropertyMap::setPrivateProperty): (JSC::JSCallbackObjectData::JSPrivatePropertyMap::deletePrivateProperty): (JSC::JSCallbackObjectData::JSPrivatePropertyMap::markChildren): (JSC::JSCallbackObject::getPrivateProperty): (JSC::JSCallbackObject::setPrivateProperty): (JSC::JSCallbackObject::deletePrivateProperty): (JSC::JSCallbackObject::markChildren):
API/JSObjectRef.cpp: (JSObjectGetPrivateProperty): (JSObjectSetPrivateProperty): (JSObjectDeletePrivateProperty):
API/JSObjectRefPrivate.h: Added.
API/tests/testapi.c: (main):
JavaScriptCore.exp:
JavaScriptCore.xcodeproj/project.pbxproj:

Note: See TracTimeline for information about the timeline view.

Download in other formats:

RSS Feed