Timeline
Mar 23, 2010:
- 10:55 PM Changeset in webkit [56434] by
-
- 1 edit3 adds in trunk/WebKitTools
2010-03-23 Kent Tamura <tkent@chromium.org>
Reviewed by Dimitri Glazkov.
[DRT/Chromium] Add TestNavigationController and TestWebWorker
https://bugs.webkit.org/show_bug.cgi?id=36489
Add TestNavigationController and TestWebWorker classes, which are
going to be used by DumpRenderTree Chromium port. These files are
based on:
- src/webkit/tools/test_shell/test_navigation_controller.{cc,h}
- src/webkit/tools/test_shell/test_web_worker.h of Chromium rev.40492.
TestNavigationController has non-style changes.
- Change ContentState type: binary string -> WebHistoryItem
- Remove TestShell dependency by introducing NavigationHost interface.
- DumpRenderTree/chromium/TestNavigationController.cpp: Added.
- DumpRenderTree/chromium/TestNavigationController.h: Added.
- DumpRenderTree/chromium/TestWebWorker.h: Added.
- 9:27 PM Changeset in webkit [56433] by
-
- 2 edits in trunk/LayoutTests
Skip plugins/destroy-plugin-from-callback.html, which has been failing on SL bots since it
was added in r56338.
- platform/mac-snowleopard/Skipped:
- 8:17 PM Changeset in webkit [56432] by
-
- 2 edits in trunk/JavaScriptCore
Build fix.
- runtime/ArrayPrototype.cpp:
(JSC::arrayProtoFuncSplice): Some versions of GCC emit a warning about the implicit 64- to 32-bit truncation
that takes place here. An explicit cast is sufficient to silence it.
- 5:31 PM Changeset in webkit [56431] by
-
- 2 edits in trunk/WebKit/mac
Reverted accidental change from r56429.
- WebCoreSupport/WebContextMenuClient.mm:
(WebContextMenuClient::getCustomMenuFromDefaultItems):
- 5:29 PM Changeset in webkit [56430] by
-
- 2 edits in trunk/WebCore
Fixed typos.
- manual-tests/plugin-visible-rect-change.html:
- 5:27 PM Changeset in webkit [56429] by
-
- 12 edits1 add in trunk
WebCore: WebCore part of
<rdar://problem/7197736> Plug-in clip rect does not update when overflow
clip changes
https://bugs.webkit.org/show_bug.cgi?id=36479.
Reviewed by John Sullivan.
- manual-tests/plugin-visible-rect-change.html: Added.
- platform/mac/WidgetMac.mm:
(WebCore::WidgetPrivate::WidgetPrivate): Added previousVisibleRect.
(WebCore::Widget::setFrameRect): If the visible rect changed but the
frame rect did not, send a -visibleRectDidChange message to the view,
if it responds to it.
(WebCore::Widget::releasePlatformWidget): Reset previousVisibleRect.
- rendering/RenderWidget.cpp:
(WebCore::RenderWidget::setWidgetGeometry): Track changes to the clip rect
imposed by the enclosing layer. Call Widget::setFrameRect when it changes,
even if the frame rect did not.
- rendering/RenderWidget.h:
(WebCore::RenderWidget::windowClipRect): Added this accessor.
WebKit/mac: WebKit part of
<rdar://problem/7197736> Plug-in clip rect does not update when overflow
clip changes
https://bugs.webkit.org/show_bug.cgi?id=36479.
Reviewed by John Sullivan.
- Plugins/Hosted/WebHostedNetscapePluginView.mm:
(-[WebHostedNetscapePluginView visibleRectDidChange]): Added. Calls
WKSyncSurfaceToView().
- Plugins/WebBaseNetscapePluginView.h:
- Plugins/WebBaseNetscapePluginView.mm:
(-[WebBaseNetscapePluginView _windowClipRect]): Changed to use Widget::windowClipRect().
(-[WebBaseNetscapePluginView visibleRectDidChange]): Added. Invokes -renewGState.
WebKitLibraries: WebKitSystemInterface part of
<rdar://problem/7197736> Plug-in clip rect does not update when overflow
clip changes
https://bugs.webkit.org/show_bug.cgi?id=36479.
Reviewed by John Sullivan.
- WebKitSystemInterface.h: Added WKSyncSurfaceToView().
- libWebKitSystemInterfaceSnowLeopard.a: Updated
- 5:06 PM Changeset in webkit [56428] by
-
- 3 edits2 adds in trunk
2010-03-23 Simon Fraser <Simon Fraser>
Reviewed by Dan Bernstein.
Assertion ASSERTION FAILED: rootLayer == m_clipRectsRoot at hulu.com
https://bugs.webkit.org/show_bug.cgi?id=34065
Fix another cause of assertions related to the clip rects root. Embeds
with zero size caused the overlap testing to fail, yet we require them to work
for correct compositing, so when the composited bounds is empty, use a 1x1 rect
for overlap testing.
Test: compositing/geometry/empty-embed-rects.html
- rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::addToOverlapMap): (WebCore::RenderLayerCompositor::computeCompositingRequirements):
- 4:31 PM Changeset in webkit [56427] by
-
- 2 edits in trunk/JavaScriptCore
Build fix.
- runtime/ArrayPrototype.cpp: (JSC::arrayProtoFuncSplice): Fixed a typo - length doesn't need to be converted with toInteger().
- 4:28 PM Changeset in webkit [56426] by
-
- 2 edits in trunk/WebKit/chromium
2010-03-23 Kenneth Russell <kbr@google.com>
Unreviewed build fix.
Add #include <stdio.h> to fix Chromium Linux build.
- src/WebGraphicsContext3DDefaultImpl.cpp:
- 4:12 PM Changeset in webkit [56425] by
-
- 3 edits3 adds in trunk
Reviewed by Geoff Garen.
https://bugs.webkit.org/show_bug.cgi?id=36511
<rdar://problem/7753498> Safari freezes when using SPUTNIK JavaScript conformance check
Test: fast/js/sputnik-S15.4.4.12_A3_T3.html
- runtime/ArrayPrototype.cpp: (JSC::arrayProtoFuncSplice): We were incorrectly computing the start offset, and iterated over (almost) all integers. Note that this can be fixed without using doubles, but the code would be much more complicated, and there is no important reason to stick to integers here.
- 3:57 PM Changeset in webkit [56424] by
-
- 2 edits in trunk/WebKit/qt
2010-03-23 Luiz Agostini <luiz.agostini@openbossa.org>
Reviewed by Kenneth Rohde Christiansen.
QGraphicsWebView crash when calling setView on the QWebPage...
https://bugs.webkit.org/show_bug.cgi?id=36436
Checking for pageClient existance before showing popups.
- WebCoreSupport/QtFallbackWebPopup.cpp: (WebCore::QtFallbackWebPopup::show):
- 3:40 PM Changeset in webkit [56423] by
-
- 2 edits in trunk/WebKit/qt
2010-03-23 Anders Bakken <anders.bakken@nokia.com>, Jesus Sanchez-Palencia <jesus.palencia@openbossa.org>
Reviewed by Kenneth Rohde Christiansen.
Check if q->scene() is available before actually using it
on QGraphicsWebViewPrivate.
QGraphicsWebView crash
https://bugs.webkit.org/show_bug.cgi?id=32670
- Api/qgraphicswebview.cpp: (QGraphicsWebViewPrivate::screenNumber): (QGraphicsWebViewPrivate::ownerWidget):
- 3:27 PM Changeset in webkit [56422] by
-
- 3 edits2 adds in trunk
[chromium] XMLHttpRequest.send sends 'undefined' string when passed undefined value.
https://bugs.webkit.org/show_bug.cgi?id=36506
Reviewed by Nate Chapin.
WebCore:
Test: http/tests/xmlhttprequest/send-undefined-and-null.html
- bindings/v8/custom/V8XMLHttpRequestCustom.cpp:
(WebCore::isDocumentType): Unrelated style fix: fixed the casing of the method.
(WebCore::V8XMLHttpRequest::sendCallback): Added check for null/undefined to do the send.
This mirrors what is done in the JSC bindings. Previously, sending 'null' worked because
the last case, which did "toWebCoreStringWithNullCheck", resulted in sending an empty
request body.
LayoutTests:
Added a test to verify that sending either undefined and null both result in an empty request body.
- http/tests/xmlhttprequest/send-undefined-and-null-expected.txt: Added.
- http/tests/xmlhttprequest/send-undefined-and-null.html: Added.
- 3:24 PM Changeset in webkit [56421] by
-
- 5 edits in trunk/WebKitTools
2010-03-23 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Add support for revision -> build lookup in buildbot.py and layout test result parsing
https://bugs.webkit.org/show_bug.cgi?id=36474
- Scripts/webkitpy/bugzilla_unittest.py: Added a FIXME about sharing code.
- Scripts/webkitpy/buildbot.py:
- Add support for looking up builds by revision number.
- Add support for fetching and parsing results.html files from buildbot.
- build_for_revision has an allow_failed_lookups option to work around the fact that our buildbot's xmlrpc calls return failure on old revision numbers.
- Add parsing support for twisted directory listings.
- Scripts/webkitpy/buildbot_unittest.py:
- Unit test all the new code.
- Scripts/webkitpy/commands/queries.py:
- Add a new results-for command which prints all the results for a given revision (very slow due to slow revision lookup)
- 3:07 PM Changeset in webkit [56420] by
-
- 3 edits3 adds in trunk
WebCore: Fix hard-to-see crash due to incorrect libxml API usage.
Patch by Chris Evans <cevans@chromium.org> on 2010-03-23
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=36000
Test: fast/text/bad-encoding.html
- dom/XMLTokenizerLibxml2.cpp:
(WebCore::XMLTokenizer::doEnd): Avoid operations on a closed context.
LayoutTests: Add test for crash due to calling into libxml in invalid state. Note
that it is unlikely that this will actually crash for you in the test
environment because it is highly intermittent. However, adding test in
order to exercise the code path and prevent related regression.
See https://bugs.webkit.org/show_bug.cgi?id=36000
Patch by Chris Evans <cevans@chromium.org> on 2010-03-23
Reviewed by Darin Adler.
- fast/text/bad-encoding.html: Added.
- fast/text/bad-encoding-expected.txt: Added.
- fast/text/resources/bad-encoding.xml: Added.
- 2:47 PM Changeset in webkit [56419] by
-
- 2 edits in trunk/WebKitTools
2010-03-23 Daniel Bates <dbates@rim.com>
Reviewed by Adam Roben.
Detect if the Windows Platform SDK is missing when building with
Visual C++ Express Edition and inform the user to download it.
- Scripts/webkitdirs.pm:
- 2:38 PM Changeset in webkit [56418] by
-
- 2 edits in trunk/LayoutTests
2010-03-23 Nate Chapin <Nate Chapin>
Unreviewed, Chromium test expectations update.
Mark fast/dom/error-to-string-stack-overflow.html as failing on
all Chromium platforms, and http/tests/xmlhttprequest/xmlhttprequest-50ms-download-dispatch.html
as failing on Windows.
- platform/chromium/test_expectations.txt:
- 2:33 PM Changeset in webkit [56417] by
-
- 3 edits in trunk/WebKitTools
Tell Subversion about more directories that expect to have .pyc files.
- Scripts/webkitpy: Modified property svn:ignore.
- Scripts/webkitpy/irc: Added property svn:ignore.
- 2:24 PM Changeset in webkit [56416] by
-
- 10 edits in trunk
2010-03-23 Nate Chapin <Nate Chapin>
Unreviewed, revert r56376.
This revision introduced a crash in a couple of layout tests
on Chromium Linux.
- page/chromium/ChromeClientChromium.h:
- platform/chromium/PopupMenuChromium.cpp: (WebCore::): (WebCore::PopupContainer::create): (WebCore::PopupContainer::PopupContainer): (WebCore::PopupContainer::showPopup): (WebCore::PopupContainer::showExternal): (WebCore::PopupContainer::hidePopup): (WebCore::PopupMenu::show):
- platform/chromium/PopupMenuChromium.h: (WebCore::PopupItem::): (WebCore::PopupItem::PopupItem): (WebCore::PopupContainerSettings::): (WebCore::PopupContainer::listBox):
- 2:15 PM Changeset in webkit [56415] by
-
- 5 edits in trunk/WebKit/chromium
2010-03-23 Sergey Ulanov <sergeyu@chromium.org>
Reviewed by Dmitry Titov.
Changes needed to implement Show/Hide Controls command for <video> in
chrome: (1) added Controls action in WebMediaPlayerAction that toggles
controls for media player, (2) added MediaHasVideo in
WebContextMenuData so that controls can be made toggleable only for
video player but not for audio.
https://bugs.webkit.org/show_bug.cgi?id=36460
- public/WebContextMenuData.h: (WebKit::WebContextMenuData::):
- public/WebMediaPlayerAction.h: (WebKit::WebMediaPlayerAction::):
- src/ContextMenuClientImpl.cpp: (WebKit::ContextMenuClientImpl::getCustomMenuFromDefaultItems):
- src/WebViewImpl.cpp: (WebKit::WebViewImpl::performMediaPlayerAction):
- 1:52 PM Changeset in webkit [56414] by
-
- 3 edits2 adds in trunk
https://bugs.webkit.org/show_bug.cgi?id=36272, make sure nth-child can work when the portion with "n" is omitted.
Reviewed by Simon Fraser and Darin Adler.
Added fast/css/nth-child-implied-step.html
- css/CSSGrammar.y:
- css/tokenizer.flex:
- 1:51 PM Changeset in webkit [56413] by
-
- 2 edits in trunk/WebKitTools
2010-03-23 Daniel Bates <dbates@rim.com>
Reviewed by Adam Barth.
Import the GNU readline interface to modify the behavior
of raw_input so as to provide line editing support. In
particular this will prevent "delete" characters from
appearing in the returned value for function raw_input.
- Scripts/webkitpy/user.py:
- 1:48 PM Changeset in webkit [56412] by
-
- 10 edits in trunk/WebCore
2010-03-23 Darin Adler <Darin Adler>
Reviewed by Sam Weinig.
Reduce and straighten internal use of DOMImplementation
https://bugs.webkit.org/show_bug.cgi?id=36501
- WebCore.xcodeproj/project.pbxproj: Xcode decided to re-sort this file.
- dom/Clipboard.cpp: Removed unneeded include of DOMImplementation.h.
- dom/DOMImplementation.cpp: Removed unneeded createDocument and createHTMLDocument functions. These should be done directly instead of involving the DOMImplementation class.
- dom/DOMImplementation.h: Ditto.
- dom/DocumentType.cpp: Removed unneeded include of DOMImplementation.h.
- html/HTMLViewSourceDocument.cpp: (WebCore::HTMLViewSourceDocument::createTokenizer): Don't allocate a DOMImplementation object just to use a class member function.
- loader/CachedFont.cpp: Removed unneeded include of DOMImplementation.h.
- xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::responseXML): Use Document::create to create a new document instead of involving DOMImplementation.
- xml/XSLTProcessor.cpp: (WebCore::XSLTProcessor::createDocumentFromSource): Ditto. And in the case where we do need to call DOMImplementation to interpret the MIME type, don't allocate a DOMImplementation object just to use a class member function.
- 1:06 PM Changeset in webkit [56411] by
-
- 2 edits in trunk/WebCore
2010-03-23 Luiz Agostini <luiz.agostini@openbossa.org>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Maemo5 theme - all <select> elements should be rendered as menu lists.
https://bugs.webkit.org/show_bug.cgi?id=36367
Enabling NO_LISTBOX_RENDERING in WebCore.pri for Maemo5.
- WebCore.pri:
- 12:39 PM Changeset in webkit [56410] by
-
- 2 edits in trunk/WebKit/chromium
2010-03-23 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
When uncaught exception happens reveal Scripts panel only if reporting uncaught exceptions is on.
- src/js/DebuggerAgent.js: (devtools.DebuggerAgent.prototype.handleExceptionEvent_):
- 12:37 PM Changeset in webkit [56409] by
-
- 1 edit in trunk/WebCore/ChangeLog
Revert accidental ChangeLog commit r56407.
- 12:23 PM Changeset in webkit [56408] by
-
- 3 edits in trunk/WebCore
2010-03-22 Joseph Pecoraro <Joseph Pecoraro>
Reviewed by David Kilzer.
Upstream iPhone KeyEvent platform code and share with Mac platform
https://bugs.webkit.org/show_bug.cgi?id=35870
- platform/iphone/KeyEventCodesIPhone.h: Improper comment for #endif.
- platform/iphone/KeyEventIPhone.mm: Fixed headers.
- 12:23 PM Changeset in webkit [56407] by
-
- 1 edit in trunk/WebCore/ChangeLog
Reviewed by Simon Fraser.
- rendering/RenderEmbeddedObject.cpp: (WebCore::RenderEmbeddedObject::RenderEmbeddedObject): Fix a find/repalce mistake from my earlier patch. Rename m_setShowsMissingPluginIndicator -> m_showsMissingPluginIndicator. (WebCore::RenderEmbeddedObject::updateWidget): Don't update the widget if we're showing the missing plug-in indicator. (WebCore::RenderEmbeddedObject::paint):Fix a find/repalce mistake from my earlier patch. Rename m_setShowsMissingPluginIndicator -> m_showsMissingPluginIndicator. (WebCore::RenderEmbeddedObject::paintReplaced): Ditto.
- rendering/RenderEmbeddedObject.h: Ditto. (WebCore::RenderEmbeddedObject::setShowsMissingPluginIndicator): Ditto. (WebCore::RenderEmbeddedObject::showsMissingPluginIndicator): Ditto.
- Plugins/WebNetscapePluginView.mm:
- Plugins/WebNullPluginView.h: Removed.
- Plugins/WebNullPluginView.mm: Removed.
- Resources/nullplugin.tiff: Removed.
- WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::createPlugin): Invoke the resource load delegate if the plug-in failed to load.
- 12:22 PM Changeset in webkit [56406] by
-
- 2 edits in trunk/WebKit/chromium
2010-03-23 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: TimelinePanel stays in the recording state after reopening WebInspector.
https://bugs.webkit.org/show_bug.cgi?id=36503
- src/WebDevToolsAgentImpl.cpp: (WebKit::WebDevToolsAgentImpl::detach):
- 11:51 AM Changeset in webkit [56405] by
-
- 2 edits2 adds in trunk
https://bugs.webkit.org/show_bug.cgi?id=36277, make sure nth-child supports the positive unary prefix (+) as well as the negative
one (-).
Reviewed by Jeremy Orlow.
Added fast/css/nth-child-unary-prefix.html
- css/tokenizer.flex:
- 11:49 AM Changeset in webkit [56404] by
-
- 15 edits in trunk/WebCore
2010-03-23 Andrey Kosyakov <caseq@chromium.org>
Reviewed by Dmitry Titov.
Change notification sent to inspector frontend on workers creation / destruction
to be posted asynchronously to avoid JS reenterability problems. Also, renamed
willDestroyWorker to didDestroyWorker to reflect that it gets called later and got
rid of explicit IDs for workers (use addresses instead).
https://bugs.webkit.org/show_bug.cgi?id=36213
- inspector/InjectedScriptHost.cpp: (WebCore::InjectedScriptHost::didDestroyWorker):
- inspector/InjectedScriptHost.h:
- inspector/InjectedScriptHost.idl:
- inspector/InspectorController.cpp: (WebCore::PostWorkerNotificationToFrontendTask::create): (WebCore::PostWorkerNotificationToFrontendTask::PostWorkerNotificationToFrontendTask): (WebCore::PostWorkerNotificationToFrontendTask::performTask): (WebCore::InspectorController::postWorkerNotificationToFrontend): (WebCore::InspectorController::didCreateWorker): (WebCore::InspectorController::didDestroyWorker):
- inspector/InspectorController.h: (WebCore::InspectorController::):
- inspector/InspectorFrontend.cpp: (WebCore::InspectorFrontend::didDestroyWorker):
- inspector/InspectorFrontend.h:
- inspector/InspectorWorkerResource.h: (WebCore::InspectorWorkerResource::create): (WebCore::InspectorWorkerResource::id): (WebCore::InspectorWorkerResource::InspectorWorkerResource):
- inspector/front-end/InjectedFakeWorker.js: (InjectedFakeWorker.FakeWorker.prototype.terminate):
- inspector/front-end/WorkersSidebarPane.js: (WebInspector.didDestroyWorker):
- workers/AbstractWorker.cpp: (WebCore::AbstractWorker::AbstractWorker): (WebCore::AbstractWorker::onDestroyWorker):
- workers/AbstractWorker.h: (WebCore::AbstractWorker::asID):
- workers/SharedWorker.cpp: (WebCore::SharedWorker::SharedWorker):
- workers/Worker.cpp: (WebCore::Worker::Worker):
- 11:30 AM Changeset in webkit [56403] by
-
- 2 edits in trunk/JavaScriptCore
2010-03-23 Kent Hansen <kent.hansen@nokia.com>
Reviewed by Darin Adler.
Fix compilation on Itanium in 32-bit mode
https://bugs.webkit.org/show_bug.cgi?id=36494
- wtf/Platform.h: Introduce CPU(IA64_32). Don't define WTF_USE_JSVALUE64 if the CPU is in 32-bit mode.
- 10:53 AM Changeset in webkit [56402] by
-
- 15 edits2 adds in trunk
https://bugs.webkit.org/show_bug.cgi?id=36266, support DOM Level 3 focusin/focusout events. Add support for
IE onfocusin/onfocusout extensions to HTML. The old DOM level 2 names (DOMFocusIn/DOMFocusOut are still supported).
Reviewed by Sam Weinig.
Added fast/events/focusinout.html
- dom/Document.cpp:
(WebCore::Document::setFocusedNode):
- dom/Event.cpp:
(WebCore::Event::aliasedType):
(WebCore::Event::hasAliasedType):
- dom/Event.h:
- dom/EventNames.h:
- dom/EventTarget.cpp:
(WebCore::EventTarget::fireEventListeners):
- dom/EventTarget.h:
- dom/Node.cpp:
(WebCore::Node::dispatchUIEvent):
- html/HTMLAttributeNames.in:
- html/HTMLButtonElement.cpp:
(WebCore::HTMLButtonElement::parseMappedAttribute):
- html/HTMLElement.cpp:
(WebCore::HTMLElement::parseMappedAttribute):
- html/HTMLFormControlElement.cpp:
(WebCore::HTMLTextFormControlElement::parseMappedAttribute):
- html/HTMLFrameSetElement.cpp:
(WebCore::HTMLFrameSetElement::parseMappedAttribute):
- html/HTMLSelectElement.cpp:
(WebCore::HTMLSelectElement::parseMappedAttribute):
- svg/SVGElement.cpp:
(WebCore::SVGElement::parseMappedAttribute):
- 10:36 AM QtWebKit edited by
- (diff)
- 10:30 AM QtWebKitBackportingFixes edited by
- Moved r56370 to Incoming list (diff)
- 10:10 AM Changeset in webkit [56401] by
-
- 3 edits2 adds in trunk
2010-03-23 MORITA Hajime <morrita@google.com>
Reviewed by Alexey Proskuryakov.
WebCore::SelectionController::setSelection NULL pointer
https://bugs.webkit.org/show_bug.cgi?id=31545
- svg/dom/frame-related-api-during-load-expected.txt: Added.
- svg/dom/frame-related-api-during-load.html: Added.
2010-03-23 MORITA Hajime <morrita@google.com>
Reviewed by Alexey Proskuryakov.
WebCore::SelectionController::setSelection NULL pointer
https://bugs.webkit.org/show_bug.cgi?id=31545
Added missing NULL-check that other APIs have.
Test: svg/dom/frame-related-api-during-load.html
- svg/SVGSVGElement.cpp: (WebCore::SVGSVGElement::deselectAll):
- 10:09 AM Changeset in webkit [56400] by
-
- 3 edits in trunk/JavaScriptCore
Interpreter fix for <rdar://problem/7728196> REGRESSION (r46701): -(-2147483648)
evaluates to -2147483648 on 32 bit (35842)
Reviewed by Mark Rowe.
- interpreter/Interpreter.cpp:
(JSC::Interpreter::privateExecute): Only take the fast negate path if
a bit other than bit 31 is set. If none of bits 0-30 are set, then the
value we're negating can only be 0 or -2147483648, and neither can be
negated in int space.
- jit/JITArithmetic.cpp:
(JSC::JIT::emit_op_negate):
(JSC::JIT::emitSlow_op_negate): Updated the JIT implementation to match
the interpreter, since it's slightly simpler.
- 9:52 AM Changeset in webkit [56399] by
-
- 2 edits in trunk/WebKit/qt
2010-03-23 David Leong <david.leong@nokia.com>
Reviewed by Laszlo Gombos.
Build fix for Symbian Def file.
- symbian/eabi/QtWebKitu.def:
- 9:44 AM QtWebKitBackportingFixes edited by
- added JSC collector memory improvement #34350 (diff)
- 9:34 AM Changeset in webkit [56398] by
-
- 5 edits2 adds in trunk
2010-03-23 Qi Zhang <qi.2.zhang@nokia.com>
Reviewed by Simon Hausmann.
Qt] LayoutTests/fast/canvas/fillrect_gradient.html failed
https://bugs.webkit.org/show_bug.cgi?id=36444
Enable LayoutTests/fast/canvas/fillrect_gradient.html
- platform/qt/Skipped:
- platform/qt/fast/canvas/fillrect_gradient-expected.checksum: Added.
- platform/qt/fast/canvas/fillrect_gradient-expected.png: Added.
- platform/qt/fast/canvas/fillrect_gradient-expected.txt:
2010-03-23 Qi Zhang <qi.2.zhang@nokia.com>
Reviewed by Simon Hausmann.
[Qt] LayoutTests/fast/canvas/fillrect_gradient.html failed
https://bugs.webkit.org/show_bug.cgi?id=36444
Handle duplicated or unsorted colorStop at platformDestory
- platform/graphics/qt/GradientQt.cpp: (WebCore::Gradient::platformGradient):
- 8:47 AM Changeset in webkit [56397] by
-
- 3 edits in trunk/WebCore
Unreviewed build fix.
Try to make the window buildbot happy.
- xml/XMLHttpRequestProgressEventThrottle.cpp:
- xml/XMLHttpRequestProgressEventThrottle.h: Move initialization of the
static const in the cpp file.
- 8:42 AM Changeset in webkit [56396] by
-
- 2 edits in trunk/WebCore
2010-03-23 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: make gear menu appear on styles panel at all times.
- inspector/front-end/inspector.css:
- 8:39 AM Changeset in webkit [56395] by
-
- 6 edits in trunk/WebCore
2010-03-23 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: render nodes in inherited style bars as links.
- English.lproj/localizedStrings.js:
- inspector/front-end/BreakpointsSidebarPane.js: (WebInspector.BreakpointsSidebarPane.prototype._appendBreakpointElement.breakpointClicked): (WebInspector.BreakpointsSidebarPane.prototype._appendBreakpointElement):
- inspector/front-end/StylesSidebarPane.js: (WebInspector.StylesSidebarPane.prototype._update.else.insertInheritedNodeSeparator): (WebInspector.StylesSidebarPane.prototype._update): (WebInspector.StylesSidebarPane.prototype._selectNode):
- inspector/front-end/inspector.js:
- 8:33 AM Changeset in webkit [56394] by
-
- 10 edits5 adds in trunk
[XHR] onProgress event needs to be dispatched according to what the specification states
https://bugs.webkit.org/show_bug.cgi?id=18654
Reviewed by Alexey Proskuryakov.
WebCore:
Test: http/tests/xmlhttprequest/xmlhttprequest-50ms-download-dispatch.html
- Android.mk:
- GNUmakefile.am:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
Added XMLHttpRequestProgressEventThrottle to the build systems.
- xml/XMLHttpRequest.cpp:
(WebCore::XMLHttpRequest::XMLHttpRequest): Created the throttle.
(WebCore::XMLHttpRequest::callReadyStateChangeListener): The 'readyState' event are
dispatched using the XMLHttpRequestProgressEventThrottle now. For the DONE state, we
need to flush any pending progress event as we do not want it to be dispatched after
the DONE readyState event.
(WebCore::XMLHttpRequest::createRequest): Made this event use the
XMLHttpRequestProgressEventThrottle for event dispatching.
(WebCore::XMLHttpRequest::abort): Ditto.
(WebCore::XMLHttpRequest::networkError): Ditto.
(WebCore::XMLHttpRequest::abortError): Ditto.
(WebCore::XMLHttpRequest::didReceiveData): Ditto. Also fixed a potential warning.
(WebCore::XMLHttpRequest::suspend):
(WebCore::XMLHttpRequest::resume): Implemented the logic for suspend / resume.
- xml/XMLHttpRequest.h:
- xml/XMLHttpRequestProgressEventThrottle.cpp: Added.
(WebCore::XMLHttpRequestProgressEventThrottle::XMLHttpRequestProgressEventThrottle):
(WebCore::XMLHttpRequestProgressEventThrottle::~XMLHttpRequestProgressEventThrottle):
(WebCore::XMLHttpRequestProgressEventThrottle::dispatchProgressEvent): Implemented the bulk
of the event throttling here: we use a timer to do so, as long as the timer is active it means
that events are coming faster than the throttling time and we coalesce them.
(WebCore::XMLHttpRequestProgressEventThrottle::dispatchEvent): Generic method to dispatch an event.
(WebCore::XMLHttpRequestProgressEventThrottle::flushProgressEvent): Called when we want to dispatch
any pending events and stopping any further dispatching.
(WebCore::XMLHttpRequestProgressEventThrottle::dispatchPausedEvent): Used to dispatch the event
that was queued due to the object being suspended.
(WebCore::XMLHttpRequestProgressEventThrottle::fired): Used to dispatch any coalesced event.
(WebCore::XMLHttpRequestProgressEventThrottle::hasEventToDispatch): Used to check if we have
an event to dispatch.
(WebCore::XMLHttpRequestProgressEventThrottle::suspend): Marked the object as suspended.
(WebCore::XMLHttpRequestProgressEventThrottle::resume): Dispatched the event that was queued.
- xml/XMLHttpRequestProgressEventThrottle.h: Added.
(WebCore::):
(WebCore::XMLHttpRequestProgressEventThrottle::suspended):
LayoutTests:
Add a test to check that progress events are really throttled.
- http/tests/xmlhttprequest/resources/download-with-delay.php: Added.
- http/tests/xmlhttprequest/xmlhttprequest-50ms-download-dispatch-expected.txt: Added.
- http/tests/xmlhttprequest/xmlhttprequest-50ms-download-dispatch.html: Added.
- 8:14 AM Changeset in webkit [56393] by
-
- 4 edits2 adds in trunk
2010-03-23 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: Element inspector search funtion: Error dispatching: performSearch.
Test: inspector/elements-panel-search.html
- inspector/front-end/ElementsPanel.js: (WebInspector.ElementsPanel.prototype.performSearch): (WebInspector.ElementsPanel.prototype.addNodesToSearchResult):
- inspector/front-end/InjectedScript.js: (injectedScriptConstructor.): (injectedScriptConstructor):
- 7:57 AM Changeset in webkit [56392] by
-
- 2 edits in trunk
2010-03-23 Laszlo Gombos <Laszlo Gombos>
Unreviewed, fix the reviwer for r56391.
- WebCore/ChangeLog
- LayoutTests/ChangeLog
- 7:37 AM Changeset in webkit [56391] by
-
- 6 edits2 adds in trunk
2010-03-23 Qi Zhang <qi.2.zhang@nokia.com>
Reviewed by Laszlo Gombos.
[Qt] fast/canvas/patternfill-repeat.html failed.
https://bugs.webkit.org/show_bug.cgi?id=34477
Change Pattern to expose the repeatX and repeatY
at GraphicsContextQt to apply repeatX and repeatY
- platform/graphics/Pattern.h: (WebCore::Pattern::repeatX): (WebCore::Pattern::repeatY):
- platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::drawLine): (WebCore::GraphicsContext::fillRect): (WebCore::GraphicsContext::rotate):
2010-03-23 Qi Zhang <qi.2.zhang@nokia.com>
Reviewed by Laszlo Gombos.
[Qt] fast/canvas/patternfill-repeat.html failed.
https://bugs.webkit.org/show_bug.cgi?id=34477
Enable LayoutTests/fast/canvas/patternfill-repeat.html.
- platform/qt/Skipped:
- platform/qt/fast/canvas/patternfill-repeat-expected.checksum: Added.
- platform/qt/fast/canvas/patternfill-repeat-expected.png: Added.
- platform/qt/fast/canvas/patternfill-repeat-expected.txt:
- 7:19 AM QtWebKitBugs edited by
- minor (diff)
- 7:05 AM Changeset in webkit [56390] by
-
- 35 edits in trunk
2010-03-23 Alex Milowski <alex@milowski.com>
Reviewed by Kenneth Rohde Christiansen.
Updated test results from removal of use of STIX fonts.
- platform/mac/mathml/presentation/fractions-expected.checksum:
- platform/mac/mathml/presentation/fractions-expected.png:
- platform/mac/mathml/presentation/fractions-expected.txt:
- platform/mac/mathml/presentation/fractions-vertical-alignment-expected.checksum:
- platform/mac/mathml/presentation/fractions-vertical-alignment-expected.png:
- platform/mac/mathml/presentation/fractions-vertical-alignment-expected.txt:
- platform/mac/mathml/presentation/mo-expected.checksum:
- platform/mac/mathml/presentation/mo-expected.png:
- platform/mac/mathml/presentation/mo-expected.txt:
- platform/mac/mathml/presentation/over-expected.checksum:
- platform/mac/mathml/presentation/over-expected.png:
- platform/mac/mathml/presentation/over-expected.txt:
- platform/mac/mathml/presentation/row-expected.checksum:
- platform/mac/mathml/presentation/row-expected.png:
- platform/mac/mathml/presentation/row-expected.txt:
- platform/mac/mathml/presentation/sub-expected.checksum:
- platform/mac/mathml/presentation/sub-expected.png:
- platform/mac/mathml/presentation/sub-expected.txt:
- platform/mac/mathml/presentation/subsup-expected.checksum:
- platform/mac/mathml/presentation/subsup-expected.png:
- platform/mac/mathml/presentation/subsup-expected.txt:
- platform/mac/mathml/presentation/sup-expected.checksum:
- platform/mac/mathml/presentation/sup-expected.png:
- platform/mac/mathml/presentation/tables-expected.checksum:
- platform/mac/mathml/presentation/tables-expected.png:
- platform/mac/mathml/presentation/tables-expected.txt:
- platform/mac/mathml/presentation/under-expected.checksum:
- platform/mac/mathml/presentation/under-expected.png:
- platform/mac/mathml/presentation/under-expected.txt:
- platform/mac/mathml/presentation/underover-expected.checksum:
- platform/mac/mathml/presentation/underover-expected.png:
- platform/mac/mathml/presentation/underover-expected.txt:
2010-03-23 Alex Milowski <alex@milowski.com>
Reviewed by Kenneth Rohde Christiansen.
Removed the use of beta STIX fonts.
- css/mathml.css:
- 6:34 AM Changeset in webkit [56389] by
-
- 2 edits in trunk/LayoutTests
Unreviewed.
[Qt] websocket/tests/long-invalid-header.html fails
https://bugs.webkit.org/show_bug.cgi?id=36492
- platform/qt/Skipped: websocket/tests/long-invalid-header.html skipped until fix.
- 6:23 AM Changeset in webkit [56388] by
-
- 2 edits in trunk/LayoutTests
2010-03-23 Gustavo Noronha Silva <Gustavo Noronha Silva>
[GTK] Failing fast/css/zoom-body-scroll.html - sizes are off by one after zooming out
https://bugs.webkit.org/show_bug.cgi?id=36491
Skipping test that fails on 32 bits bots.
- platform/gtk/Skipped:
- 6:23 AM Changeset in webkit [56387] by
-
- 11 edits1 add in trunk
WebCore
2010-03-23 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Reviewed by Holger Freyther.
[GTK] Does not build with latest GTK+ development release
https://bugs.webkit.org/show_bug.cgi?id=36398
Fix building with newest GTK+ versions.
- GNUmakefile.am:
- platform/gtk/GtkPluginWidget.cpp: (WebCore::GtkPluginWidget::invalidateRect): (WebCore::GtkPluginWidget::paint):
- platform/gtk/GtkVersioning.h: Added.
- platform/gtk/PlatformScreenGtk.cpp: (WebCore::getVisual): (WebCore::screenRect): (WebCore::screenAvailableRect):
- platform/gtk/ScrollbarGtk.cpp: (ScrollbarGtk::paint):
- plugins/gtk/gtk2xtbin.c: (gtk_xtbin_set_position): (gtk_xtbin_unrealize):
WebKit/gtk
2010-03-23 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Reviewed by Holger Freyther.
[GTK] Does not build with latest GTK+ development release
https://bugs.webkit.org/show_bug.cgi?id=36398
Fix building with newest GTK+ versions.
- WebCoreSupport/ChromeClientGtk.cpp: (WebKit::ChromeClient::windowRect): (WebKit::ChromeClient::setWindowRect): (WebKit::ChromeClient::unfocus): (WebKit::ChromeClient::canTakeFocus): (WebKit::ChromeClient::contentsSizeChanged):
- webkit/webkitprivate.cpp: (currentToplevelCallback):
- webkit/webkitwebframe.cpp: (webkit_web_frame_print_full): (webkit_web_frame_print):
- webkit/webkitwebview.cpp: (webkit_web_view_grab_focus): (webkit_web_view_focus_in_event): (webkit_web_view_script_dialog):
- 5:52 AM Changeset in webkit [56386] by
-
- 16 edits in trunk
2010-03-23 Laszlo Gombos <Laszlo Gombos>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Remove support for Qt v4.4
https://bugs.webkit.org/show_bug.cgi?id=36389
No new tests as there is no new functionality.
- WebCore.pri:
- WebCore.pro:
- platform/network/qt/ResourceHandleQt.cpp: (WebCore::ResourceHandle::willLoadFromCache):
- platform/qt/CookieJarQt.cpp: (WebCore::setCookies): (WebCore::cookies):
- platform/qt/KURLQt.cpp: (WebCore::KURL::operator QUrl):
- platform/qt/ScrollbarThemeQt.cpp: (WebCore::ScrollbarThemeQt::paintScrollCorner):
- plugins/mac/PluginViewMac.cpp:
2010-03-23 Laszlo Gombos <Laszlo Gombos>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Remove support for Qt v4.4
https://bugs.webkit.org/show_bug.cgi?id=36389
- Api/qwebelement.cpp: (QWebElement::classes):
- Api/qwebpage.cpp: (QWebPagePrivate::editorActionForKeyEvent): (QWebPage::userAgentForUrl):
- WebCoreSupport/EditorClientQt.cpp: (WebCore::EditorClientQt::handleKeyboardEvent):
- tests/tests.pro:
2010-03-23 Laszlo Gombos <Laszlo Gombos>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Remove support for Qt v4.4
https://bugs.webkit.org/show_bug.cgi?id=36389
- DumpRenderTree/qt/main.cpp: (main):
- QtLauncher/mainwindow.cpp: (MainWindow::MainWindow):
- 4:07 AM Changeset in webkit [56385] by
-
- 8 edits in trunk/WebCore
2010-03-23 Kent Tamura <tkent@chromium.org>
Reviewed by Adam Barth.
Add checks if setNeedsWillValidateCheck() and
setNeedsValidityCheck() are called correctly.
https://bugs.webkit.org/show_bug.cgi?id=34924
Introduce HTMLFormControlElement::m_willValidate and
m_isValid. They are the caches of willValidate() and
isValidFormControlElement(). setNeedsWillValidateCheck() updates
m_willValidate and setNeedsValidityCheck() updates m_isValid.
willValidate() and isValidFormControlElement() have assertions to
check m_willvalidate or m_isValid has the correct state. If
setNeedsWillValidateCheck() or setNeedsValidityCheck() is needed
to be called and is not called, these assertions fail.
- html/HTMLButtonElement.h: (WebCore::HTMLButtonElement::recalcWillValidate):
- html/HTMLFieldSetElement.h: (WebCore::HTMLFieldSetElement::recalcWillValidate):
- html/HTMLFormControlElement.cpp: (WebCore::HTMLFormControlElement::HTMLFormControlElement): (WebCore::HTMLFormControlElement::parseMappedAttribute): (WebCore::HTMLFormControlElement::recalcWillValidate): (WebCore::HTMLFormControlElement::willValidate): (WebCore::HTMLFormControlElement::setNeedsWillValidateCheck): (WebCore::HTMLFormControlElement::validationMessage): (WebCore::HTMLFormControlElement::isValidFormControlElement): (WebCore::HTMLFormControlElement::setNeedsValidityCheck):
- html/HTMLFormControlElement.h:
- html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::setInputType): (WebCore::HTMLInputElement::parseMappedAttribute): (WebCore::HTMLInputElement::setValue): (WebCore::HTMLInputElement::recalcWillValidate):
- html/HTMLInputElement.h:
- html/HTMLTextAreaElement.cpp: (WebCore::HTMLTextAreaElement::setNonDirtyValue):
- 1:18 AM Changeset in webkit [56384] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, remove flaky tag in websocket tests.
flakiness in websocket tests (http://crbug.com/38397) introducted at
Chromium r41818 has been fixed at r42320.
- platform/chromium/test_expectations.txt: remove BUG38397
- 12:07 AM Changeset in webkit [56383] by
-
- 11 edits2 adds in trunk
2010-03-22 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Dave Hyatt.
Web Inspector: display CSS selector source line in the styles sidebar pane.
This change adds a sourceLine field into the CSSStyleRule that is populated
from within the parser. CSSParser is now keeping track of the line numbers
and last selector line number that is being used while creating CSSStyleRules.
Test: inspector/styles-source-lines.html
- css/CSSGrammar.y:
- css/CSSParser.cpp: (WebCore::CSSParser::CSSParser): (WebCore::CSSParser::lex): (WebCore::CSSParser::countLines): (WebCore::CSSParser::createStyleRule):
- css/CSSParser.h: (WebCore::CSSParser::updateLastSelectorLine):
- css/CSSStyleRule.cpp: (WebCore::CSSStyleRule::CSSStyleRule):
- css/CSSStyleRule.h: (WebCore::CSSStyleRule::create): (WebCore::CSSStyleRule::sourceLine):
- css/tokenizer.flex:
- inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::buildObjectForRule):
- inspector/front-end/DOMAgent.js: (WebInspector.CSSStyleDeclaration.parseRule):
- inspector/front-end/StylesSidebarPane.js: (WebInspector.StylePropertiesSection):
Mar 22, 2010:
- 11:48 PM Changeset in webkit [56382] by
-
- 4 edits3 adds in trunk
2010-03-22 Qi Zhang <qi.2.zhang@nokia.com>
Reviewed by Laszlo Gombos.
Qt] Fix arc function in canvas
https://bugs.webkit.org/show_bug.cgi?id=36296
- platform/qt/Skipped:
- platform/qt/fast/canvas/arc360-expected.checksum: Added.
- platform/qt/fast/canvas/arc360-expected.png: Added.
- platform/qt/fast/canvas/arc360-expected.txt: Added.
2010-03-22 Qi Zhang <qi.2.zhang@nokia.com>
Reviewed by Laszlo Gombos.
[Qt] Fix arc function in canvas
https://bugs.webkit.org/show_bug.cgi?id=36296
Based on HTLM5 spec (4.8.10.1.8 Complex shapes), arc function should draw a line to previous point, not only the arc.
- platform/graphics/qt/PathQt.cpp: (WebCore::Path::addArc):
- 11:30 PM Changeset in webkit [56381] by
-
- 4 edits4 adds in trunk/WebKit/chromium
2010-03-22 Kenneth Russell <kbr@google.com>
Reviewed by Darin Fisher.
Add GraphicsContext3D abstraction to WebKit API
https://bugs.webkit.org/show_bug.cgi?id=36262
Added WebGraphicsContext3D to the WebKit API and refactored Chromium's
GraphicsContext3D implementation to use it. All of the OpenGL calls have
been moved out of WebKit/chromium/src/GraphicsContext3D.cpp and into the
WebGraphicsContext3D implementation. GraphicsContext3D is still
responsible for the transfer of rendered output from the
WebGraphicsContext3D to the HTMLCanvasElement.
The GraphicsContext3DInternal class, which is a data member of
GraphicsContext3D for the Chromium port, remains. It is possible to
eliminate this class and thereby one level of delegation, but this is
being deferred.
The needed entry point for a Chrome implementation of
WebGraphicsContext3D has been added to WebKitClient, but it is not being
called yet by GraphicsContext3D. It will be once this patch lands and
Chromium is rolled forward to support this entry point.
This is a large patch, but the transformation is almost entirely
mechanical and there is no change in functionality. Nearly all of
GraphicsContext3D and GraphicsContext3DInternal has been moved to
WebGraphicsContext3DDefaultImpl. The only area where the splitting of
logic is less than mechanical is GraphicsContext3D::beginPaint() and its
callees.
Ran all WebGL layout tests and demos from Khronos site in Chromium
on Mac and Windows.
- WebKit.gyp:
- public/WebGraphicsContext3D.h: Added. (WebKit::WebGraphicsContext3D::Attributes::Attributes): (WebKit::WebGraphicsContext3D::~WebGraphicsContext3D):
- public/WebKitClient.h: (WebKit::WebKitClient::createGraphicsContext3D):
- src/GraphicsContext3D.cpp: (WebCore::GraphicsContext3DInternal::GraphicsContext3DInternal): (WebCore::GraphicsContext3DInternal::~GraphicsContext3DInternal): (WebCore::GraphicsContext3DInternal::initialize): (WebCore::GraphicsContext3DInternal::platformGraphicsContext3D): (WebCore::GraphicsContext3DInternal::platformTexture): (WebCore::GraphicsContext3DInternal::beginPaint): (WebCore::GraphicsContext3DInternal::endPaint): (WebCore::GraphicsContext3DInternal::reshape): (WebCore::GraphicsContext3DInternal::bindAttribLocation): (WebCore::GraphicsContext3DInternal::bindTexture): (WebCore::GraphicsContext3DInternal::bufferData): (WebCore::GraphicsContext3DInternal::bufferSubData): (WebCore::GraphicsContext3DInternal::getActiveAttrib): (WebCore::GraphicsContext3DInternal::getActiveUniform): (WebCore::GraphicsContext3DInternal::getAttribLocation): (WebCore::GraphicsContext3DInternal::getContextAttributes): (WebCore::GraphicsContext3DInternal::getProgramInfoLog): (WebCore::GraphicsContext3DInternal::getShaderInfoLog): (WebCore::GraphicsContext3DInternal::getShaderSource): (WebCore::GraphicsContext3DInternal::getString): (WebCore::GraphicsContext3DInternal::getUniformLocation): (WebCore::GraphicsContext3DInternal::readPixels): (WebCore::GraphicsContext3DInternal::shaderSource): (WebCore::GraphicsContext3DInternal::texImage2D): (WebCore::GraphicsContext3DInternal::texSubImage2D): (WebCore::GraphicsContext3DInternal::uniform1fv): (WebCore::GraphicsContext3DInternal::uniform1iv): (WebCore::GraphicsContext3DInternal::uniform2fv): (WebCore::GraphicsContext3DInternal::uniform2iv): (WebCore::GraphicsContext3DInternal::uniform3fv): (WebCore::GraphicsContext3DInternal::uniform3iv): (WebCore::GraphicsContext3DInternal::uniform4fv): (WebCore::GraphicsContext3DInternal::uniform4iv): (WebCore::GraphicsContext3DInternal::uniformMatrix2fv): (WebCore::GraphicsContext3DInternal::uniformMatrix3fv): (WebCore::GraphicsContext3DInternal::uniformMatrix4fv): (WebCore::GraphicsContext3D::GraphicsContext3D): (WebCore::GraphicsContext3D::~GraphicsContext3D): (WebCore::GraphicsContext3D::create): (WebCore::GraphicsContext3D::platformGraphicsContext3D): (WebCore::GraphicsContext3D::platformTexture): (WebCore::GraphicsContext3D::texImage2D): (WebCore::GraphicsContext3D::texSubImage2D):
- src/WebGraphicsContext3D.cpp: Added. (WebKit::WebGraphicsContext3D::createDefault):
- src/WebGraphicsContext3DDefaultImpl.cpp: Added. (WebKit::WebGraphicsContext3DDefaultImpl::GLConnection::create): (WebKit::WebGraphicsContext3DDefaultImpl::GLConnection::~GLConnection): (WebKit::WebGraphicsContext3DDefaultImpl::VertexAttribPointerState::VertexAttribPointerState): (WebKit::WebGraphicsContext3DDefaultImpl::WebGraphicsContext3DDefaultImpl): (WebKit::WebGraphicsContext3DDefaultImpl::~WebGraphicsContext3DDefaultImpl): (WebKit::WebGraphicsContext3DDefaultImpl::initialize): (WebKit::WebGraphicsContext3DDefaultImpl::makeContextCurrent): (WebKit::WebGraphicsContext3DDefaultImpl::width): (WebKit::WebGraphicsContext3DDefaultImpl::height): (WebKit::WebGraphicsContext3DDefaultImpl::sizeInBytes): (WebKit::createTextureObject): (WebKit::WebGraphicsContext3DDefaultImpl::reshape): (WebKit::WebGraphicsContext3DDefaultImpl::flipVertically): (WebKit::WebGraphicsContext3DDefaultImpl::readBackFramebuffer): (WebKit::WebGraphicsContext3DDefaultImpl::activeTexture): (WebKit::WebGraphicsContext3DDefaultImpl::bindBuffer): (WebKit::WebGraphicsContext3DDefaultImpl::bindFramebuffer): (WebKit::WebGraphicsContext3DDefaultImpl::disableVertexAttribArray): (WebKit::WebGraphicsContext3DDefaultImpl::drawElements): (WebKit::WebGraphicsContext3DDefaultImpl::enableVertexAttribArray): (WebKit::WebGraphicsContext3DDefaultImpl::generateMipmap): (WebKit::WebGraphicsContext3DDefaultImpl::getActiveAttrib): (WebKit::WebGraphicsContext3DDefaultImpl::getActiveUniform): (WebKit::WebGraphicsContext3DDefaultImpl::getContextAttributes): (WebKit::WebGraphicsContext3DDefaultImpl::getError): (WebKit::WebGraphicsContext3DDefaultImpl::getProgramInfoLog): (WebKit::WebGraphicsContext3DDefaultImpl::getShaderInfoLog): (WebKit::WebGraphicsContext3DDefaultImpl::getShaderSource): (WebKit::WebGraphicsContext3DDefaultImpl::getString): (WebKit::WebGraphicsContext3DDefaultImpl::getVertexAttribOffset): (WebKit::WebGraphicsContext3DDefaultImpl::releaseShaderCompiler): (WebKit::WebGraphicsContext3DDefaultImpl::shaderSource): (WebKit::WebGraphicsContext3DDefaultImpl::vertexAttribPointer): (WebKit::WebGraphicsContext3DDefaultImpl::createBuffer): (WebKit::WebGraphicsContext3DDefaultImpl::createFramebuffer): (WebKit::WebGraphicsContext3DDefaultImpl::createProgram): (WebKit::WebGraphicsContext3DDefaultImpl::createRenderbuffer): (WebKit::WebGraphicsContext3DDefaultImpl::createTexture): (WebKit::WebGraphicsContext3DDefaultImpl::deleteBuffer): (WebKit::WebGraphicsContext3DDefaultImpl::deleteFramebuffer): (WebKit::WebGraphicsContext3DDefaultImpl::deleteProgram): (WebKit::WebGraphicsContext3DDefaultImpl::deleteRenderbuffer): (WebKit::WebGraphicsContext3DDefaultImpl::deleteShader): (WebKit::WebGraphicsContext3DDefaultImpl::deleteTexture): (WebKit::WebGraphicsContext3DDefaultImpl::synthesizeGLError):
- src/WebGraphicsContext3DDefaultImpl.h: Added. (WebKit::WebGraphicsContext3DDefaultImpl::): (WebKit::WebGraphicsContext3DDefaultImpl::GLConnection::chooseFBConfig): (WebKit::WebGraphicsContext3DDefaultImpl::GLConnection::createNewContext): (WebKit::WebGraphicsContext3DDefaultImpl::GLConnection::createPbuffer): (WebKit::WebGraphicsContext3DDefaultImpl::GLConnection::destroyPbuffer): (WebKit::WebGraphicsContext3DDefaultImpl::GLConnection::makeCurrent): (WebKit::WebGraphicsContext3DDefaultImpl::GLConnection::destroyContext): (WebKit::WebGraphicsContext3DDefaultImpl::GLConnection::getCurrentContext): (WebKit::WebGraphicsContext3DDefaultImpl::GLConnection::GLConnection):
- 11:08 PM Changeset in webkit [56380] by
-
- 3 edits4 adds in trunk
2010-03-19 Abhishek Arya <inferno@chromium.org>
Reviewed by Adam Barth.
https://bugs.webkit.org/show_bug.cgi?id=36339
This LayoutTest tests for webkit ability to process long invalid headers generated by misbehaving websockets servers.
- websocket/tests/long-invalid-header-expected.txt: Added.
- websocket/tests/long-invalid-header.html: Added.
- websocket/tests/long-invalid-header_wsh.py: Added.
- websocket/tests/script-tests/long-invalid-header.js: Added.
2010-03-19 Abhishek Arya <inferno@chromium.org>
Reviewed by Adam Barth.
https://bugs.webkit.org/show_bug.cgi?id=36339
Off-by-one memory corruption fix for long invalid websockets upgrade header
Test: websocket/tests/long-invalid-header.html
- websockets/WebSocketHandshake.cpp: (WebCore::WebSocketHandshake::readServerHandshake):
- 10:51 PM Changeset in webkit [56379] by
-
- 2 edits in trunk/LayoutTests
2010-03-22 David Kilzer <ddkilzer@apple.com>
Remove http/tests/cookies/simple-cookies-expired.html from skip list after CFNetwork issue is resolved
<http://webkit.org/b/25861>
<rdar://problem/6901322>
Reviewed by Darin Adler.
- platform/win/Skipped: Removed:
- http/tests/cookies/simple-cookies-expired.html
- 10:32 PM Changeset in webkit [56378] by
-
- 1 edit1 move in trunk/LayoutTests
2010-03-22 Eric Seidel <eric@webkit.org>
Rubber-stamped by Brady Eidson.
fast/loader/cancel-load-during-port-block-timer.html fails on Tiger bot
https://bugs.webkit.org/show_bug.cgi?id=36425
This test bleeds into the next test and causes failures. Unsure of the
cause. Brady suggests we disable it for now (to match the other disabled) api test.
- fast/loader/api-test-go-to-current-back-forward-item.html-disabled: Renamed from LayoutTests/fast/loader/api-test-go-to-current-back-forward-item.html.
- 10:03 PM Changeset in webkit [56377] by
-
- 2 edits in trunk/WebCore
2010-03-22 Fumitoshi Ukai <ukai@chromium.org>
Unreviewed build fix for Chromim Mac at r56376
Fix initializer order of PopupContainer.
- platform/chromium/PopupMenuChromium.cpp: (WebCore::PopupContainer::PopupContainer):
- 8:01 PM Changeset in webkit [56376] by
-
- 10 edits in trunk
2010-03-22 Jay Campan <jcampan@google.com>
Reviewed by Darin Fisher.
Making Chromium select popups not steal activation from the browser.
Select popups are now like autocomplete popups, shown in non-activated
windows.
https://bugs.webkit.org/show_bug.cgi?id=36062
- page/chromium/ChromeClientChromium.h:
- platform/chromium/PopupMenuChromium.cpp: (WebCore::): (WebCore::PopupContainer::create): (WebCore::PopupContainer::PopupContainer): (WebCore::PopupContainer::~PopupContainer): (WebCore::PopupContainer::showPopup): (WebCore::PopupContainer::showExternal): (WebCore::PopupContainer::hidePopup): (WebCore::PopupMenu::show):
- platform/chromium/PopupMenuChromium.h: (WebCore::PopupContainer::): (WebCore::PopupContainer::popupType):
2010-03-22 Jay Campan <jcampan@google.com>
Reviewed by Darin Fisher.
Making Chromium select popups not steal activation from the browser.
Select popups are now like autocomplete popups, shown in non-activated
windows.
https://bugs.webkit.org/show_bug.cgi?id=36062
- public/WebViewClient.h: (WebKit::WebViewClient::createPopupMenu):
- src/ChromeClientImpl.cpp: (WebKit::ChromeClientImpl::popupOpened): (WebKit::ChromeClientImpl::popupClosed):
- src/ChromeClientImpl.h:
- src/WebViewImpl.cpp: (WebKit::): (WebKit::WebViewImpl::mouseDown): (WebKit::WebViewImpl::keyEvent): (WebKit::WebViewImpl::selectPopupHandleKeyEvent): (WebKit::WebViewImpl::hideSelectPopup): (WebKit::WebViewImpl::popupOpened): (WebKit::WebViewImpl::popupClosed): (WebKit::WebViewImpl::setFocus): (WebKit::WebViewImpl::applyAutoFillSuggestions): (WebKit::WebViewImpl::applyAutocompleteSuggestions):
- src/WebViewImpl.h:
- 7:21 PM Changeset in webkit [56375] by
-
- 4 edits2 adds in trunk
[v8] Crash if the worker is terminated before its initial script is executed.
https://bugs.webkit.org/show_bug.cgi?id=36336
Reviewed by Nate Chapin.
WebCore:
Test: fast/workers/termination-early.html
- bindings/v8/WorkerContextExecutionProxy.cpp:
(WebCore::WorkerContextExecutionProxy::initContextIfNeeded): Check for 0 context. When terminated, the v8 heap initialization returns 0.
(WebCore::WorkerContextExecutionProxy::evaluate): Don't execute script if initialization failed.
- bindings/v8/WorkerContextExecutionProxy.h:
LayoutTests:
- fast/workers/termination-early-expected.txt: Added.
- fast/workers/termination-early.html: Added.
- 7:11 PM Changeset in webkit [56374] by
-
- 2 edits in trunk/WebCore
2010-03-22 Andrey Kosyakov <caseq@chromium.org>
Reviewed by Pavel Feldman.
Support creation of fake workers before document is loaded by deferring
attaching of fake workers iframe until document is loaded and buffering all
messages addressed to worker.
https://bugs.webkit.org/show_bug.cgi?id=36445
- inspector/front-end/InjectedFakeWorker.js: (InjectedFakeWorker.FakeWorker.prototype.postMessage): (InjectedFakeWorker.FakeWorker.prototype._buildWorker): (InjectedFakeWorker.FakeWorker.prototype._attachWorkerFrameToDocument): (InjectedFakeWorker.FakeWorker.prototype._onWorkerFrameLoaded):
- 6:31 PM Changeset in webkit [56373] by
-
- 4 edits in trunk/WebKit/qt
2010-03-22 Kent Hansen <kent.hansen@nokia.com>
Reviewed by Laszlo Gombos.
[Qt] Fix qdoc warnings
https://bugs.webkit.org/show_bug.cgi?id=36447
- Api/qgraphicswebview.cpp: Add missing ().
- Api/qwebframe.cpp: Remove reference to non-existent parameter "url".
- Api/qwebsettings.cpp: Document parameter "location".
- 6:13 PM Changeset in webkit [56372] by
-
- 3 edits in trunk/WebKitTools
2010-03-22 Csaba Osztrogonác <Csaba Osztrogonác>
Reviewed by Adam Barth.
Make build_webkit_command() pass MAKEFLAGS environment variable to make.
https://bugs.webkit.org/show_bug.cgi?id=36440
- Scripts/webkitpy/webkitport.py:
- Scripts/webkitpy/webkitport_unittest.py:
- 5:28 PM Changeset in webkit [56371] by
-
- 1 edit1 add in trunk/WebKitSite
(Not reviewed.)
Add another example.
- demos/accessible-ascii-art/butterfly-figure.html: Added.
- 5:28 PM Changeset in webkit [56370] by
-
- 4 edits3 adds in trunk/JavaScriptCore
2010-03-22 Siddharth Mathur <siddharth.mathur@nokia.com>
Reviewed by Laszlo Gombos.
[Symbian] More efficient aligned memory allocation for JSC Collector
https://bugs.webkit.org/show_bug.cgi?id=34350
- JavaScriptCore.pri: Added 2 new Symbian source files and HAL linkage
- runtime/Collector.cpp: Reduced port-specific code and added private data member (JSC::Heap::Heap): (JSC::Heap::~Heap): (JSC::Heap::destroy): (JSC::Heap::allocateBlock): (JSC::Heap::freeBlockPtr):
- runtime/Collector.h: Added private data member
- wtf/symbian: Added.
- wtf/symbian/BlockAllocatorSymbian.cpp: Added. (WTF::AlignedBlockAllocator::AlignedBlockAllocator): Helper class to allocate aligned blocks more efficiently as required by Collector (WTF::AlignedBlockAllocator::alloc): (WTF::AlignedBlockAllocator::free): (WTF::AlignedBlockAllocator::destroy): (WTF::AlignedBlockAllocator::~AlignedBlockAllocator):
- wtf/symbian/BlockAllocatorSymbian.h: Added.
- 4:51 PM Changeset in webkit [56369] by
-
- 3 edits in trunk/LayoutTests
Unreviewed, skip new failing test.
fast/loader/stateobjects/replacestate-in-iframe.html caused infinite loop.
https://bugs.webkit.org/show_bug.cgi?id=36467
- platform/gtk/Skipped: fast/loader/stateobjects/replacestate-in-iframe.html skipped until fix.
- platform/qt/Skipped: fast/loader/stateobjects/replacestate-in-iframe.html skipped until fix.
- 4:43 PM Changeset in webkit [56368] by
-
- 1 edit2 adds in trunk/WebKitSite
(Not reviewed.)
Add example of accessible ASCII art for HTML WG.
- demos/accessible-ascii-art: Added.
- demos/accessible-ascii-art/butterfly.html: Added.
- 4:14 PM Changeset in webkit [56367] by
-
- 5 edits6 adds in trunk/LayoutTests
2010-03-22 Nate Chapin <Nate Chapin>
Unreviewed, Chromium test fixes.
- platform/chromium-linux/fast/dynamic/flash-replacement-test-expected.checksum:
- platform/chromium-linux/fast/dynamic/flash-replacement-test-expected.png:
- platform/chromium-linux/plugins/embed-attributes-style-expected.checksum:
- platform/chromium-linux/plugins/embed-attributes-style-expected.png:
- platform/chromium-mac/svg/filters/feColorMatrix-values-expected.checksum: Added.
- platform/chromium-mac/svg/filters/feColorMatrix-values-expected.png: Added.
- platform/chromium-mac/svg/filters/feColorMatrix-values-expected.txt: Added.
- platform/chromium-win/svg/filters/feColorMatrix-values-expected.checksum: Added.
- platform/chromium-win/svg/filters/feColorMatrix-values-expected.png: Added.
- platform/chromium-win/svg/filters/feColorMatrix-values-expected.txt: Added.
- 4:04 PM Changeset in webkit [56366] by
-
- 4 edits in trunk/WebKitTools
2010-03-22 Dirk Pranke <dpranke@chromium.org>
Reviewed by Dimitri Glazkov.
Change baseline_path() to point to the upstream locations for the
Chromium ports. Also change the reabselining scripts to use the
correct functions to get the baseline directories, and fix the
script's sys.path to pull in simplejson correctly.
- Scripts/rebaseline-chromium-webkit-tests:
- fix sys.path to pick up simplejson properly
- Scripts/webkitpy/layout_tests/port/chromium.py:
- change baseline_path() to use webkit_baseline_path()
- error out correctly if we can't find the chromium base dir
- Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
- call baseline_path(), not chromium_baseline_path()
- 3:57 PM Changeset in webkit [56365] by
-
- 3 edits2 adds in trunk
2010-03-22 Darin Fisher <darin@chromium.org>
Reviewed by Brady Eidson.
HistoryController::replaceState() should modify m_currentItem
instead of the current HistoryItem of the BackForwardList.
Test: fast/loader/stateobjects/replacestate-in-iframe.html
- loader/HistoryController.cpp: (WebCore::HistoryController::replaceState):
- 3:54 PM Changeset in webkit [56364] by
-
- 1 edit in trunk/WebKitTools/ChangeLog
Oops, fix spurious angle brackets around name in patch I landed manually
- 3:31 PM Changeset in webkit [56363] by
-
- 5 edits in trunk/WebCore
2010-03-22 Joseph Pecoraro <Joseph Pecoraro>
Reviewed by David Kilzer.
Upstream Part of the iPhone Platform sharing code with the Mac Platform
https://bugs.webkit.org/show_bug.cgi?id=35870
<rdar://problem/7707283> and <rdar://problem/7707318>
Part 3 of 3: Shared code between iphone and mac. The shared code was
refactored to be usable by both platforms without platform specific
typing, meaning no NSEvent versus WebEvent special cases.
Shared code usable by either mac or iphone platforms.
- platform/cocoa/KeyEventCocoa.h:
- platform/cocoa/KeyEventCocoa.mm: (WebCore::keyIdentifierForCharCode): (WebCore::windowsKeyCodeForKeyCode): (WebCore::windowsKeyCodeForCharCode):
Make use of the shared code. Keep anything platform specific in the
original file before calling the shared code.
- platform/iphone/KeyEventIPhone.mm: (WebCore::keyIdentifierForKeyEvent):
- platform/mac/KeyEventMac.mm: (WebCore::keyIdentifierForKeyEvent): (WebCore::windowsKeyCodeForKeyEvent):
- 3:17 PM Rebaseline edited by
- (diff)
- 3:15 PM Rebaseline edited by
- Added title. (diff)
- 3:09 PM Rebaseline edited by
- Clean up rebaseline doc. (diff)
- 3:05 PM Changeset in webkit [56362] by
-
- 8 edits3 deletes in trunk
Reviewed by Simon Fraser.
- rendering/RenderEmbeddedObject.cpp: (WebCore::RenderEmbeddedObject::RenderEmbeddedObject): Fix a find/repalce mistake from my earlier patch. Rename m_setShowsMissingPluginIndicator -> m_showsMissingPluginIndicator. (WebCore::RenderEmbeddedObject::updateWidget): Don't update the widget if we're showing the missing plug-in indicator. (WebCore::RenderEmbeddedObject::paint):Fix a find/repalce mistake from my earlier patch. Rename m_setShowsMissingPluginIndicator -> m_showsMissingPluginIndicator. (WebCore::RenderEmbeddedObject::paintReplaced): Ditto.
- rendering/RenderEmbeddedObject.h: Ditto. (WebCore::RenderEmbeddedObject::setShowsMissingPluginIndicator): Ditto. (WebCore::RenderEmbeddedObject::showsMissingPluginIndicator): Ditto.
- Plugins/WebNetscapePluginView.mm:
- Plugins/WebNullPluginView.h: Removed.
- Plugins/WebNullPluginView.mm: Removed.
- Resources/nullplugin.tiff: Removed.
- WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::createPlugin): Invoke the resource load delegate if the plug-in failed to load.
- 2:56 PM Changeset in webkit [56361] by
-
- 3 edits1 copy2 adds in trunk/WebCore
2010-03-22 Joseph Pecoraro <Joseph Pecoraro>
Reviewed by David Kilzer.
Upstream Part of the iPhone Platform sharing code with the Mac Platform
https://bugs.webkit.org/show_bug.cgi?id=35870
<rdar://problem/7707283>
Part 2 of 3: No changes other than moving code around.
Copied KeyEvent function from platform/mac to a platform/cocoa shared directory.
- WebCore.xcodeproj/project.pbxproj: Added cocoa group and new files.
- platform/cocoa/KeyEventCocoa.h: Added.
- platform/cocoa/KeyEventCocoa.mm: Copied from WebCore/platform/mac/KeyEventMac.mm. (WebCore::keyIdentifierForKeyEvent): (WebCore::windowsKeyCodeForKeyEvent): Include the shared code.
- platform/mac/KeyEventMac.mm:
- 2:24 PM Changeset in webkit [56360] by
-
- 3 edits3 adds in trunk/WebCore
2010-03-22 Joseph Pecoraro <Joseph Pecoraro>
Reviewed by David Kilzer.
Part 1 of 3: Upstream iPhone KeyEvent platform code and share with Mac platform
https://bugs.webkit.org/show_bug.cgi?id=35870
<rdar://problem/7707283>
- WebCore.xcodeproj/project.pbxproj: Added iphone group and new files.
- platform/iphone: Added.
- platform/iphone/KeyEventCodesIPhone.h: Added.
- platform/iphone/KeyEventIPhone.mm: Added. Ensure PLATFORM(IPHONE)
- platform/mac/KeyEventMac.mm: Ensure PLATFORM(MAC)
- 2:14 PM Changeset in webkit [56359] by
-
- 2 edits in trunk/LayoutTests
Unreviewed.
Skip editing test that fails
- platform/qt/Skipped:
- 2:08 PM Changeset in webkit [56358] by
-
- 2 edits in trunk/LayoutTests
2010-03-22 Dirk Schulze <krit@webkit.org>
Out of bounds read in SVG feColorMatrix filter
https://bugs.webkit.org/show_bug.cgi?id=32714
SVG Test has text in it. This caused a wrong DRT result on Mac.
The other result was created on Windows.
- platform/mac/svg/filters/feColorMatrix-values-expected.txt:
- 1:38 PM Changeset in webkit [56357] by
-
- 2 edits in trunk/WebCore
Attempt to fix the Leopard build.
- rendering/RenderEmbeddedObject.cpp: Add ".f" to contants.
- 1:28 PM Changeset in webkit [56356] by
-
- 1 edit1 add in trunk/LayoutTests
2010-03-22 Dirk Schulze <krit@webkit.org>
Out of bounds read in SVG feColorMatrix filter
https://bugs.webkit.org/show_bug.cgi?id=32714
Add missing expected result.
- platform/mac/svg/filters/feColorMatrix-values-expected.txt: Added.
- 1:24 PM QtWebKitBackportingFixes edited by
- (diff)
- 12:46 PM Changeset in webkit [56355] by
-
- 3 edits7 adds in trunk
2010-03-22 Justin Schuh <jschuh@chromium.org>
Reviewed by Dirk Schulze.
Out of bounds read in SVG feColorMatrix filter
https://bugs.webkit.org/show_bug.cgi?id=32714
Prevents an invalid read when a valid values attribute is not
supplied for an feColorMatrix SVG filter. Also fixes general
handling of missing or invalid values attribute.
Tests: svg/filters/feColorMatrix-invalid-value.svg
svg/filters/feColorMatrix-values.svg
- svg/SVGFEColorMatrixElement.cpp: (WebCore::SVGFEColorMatrixElement::build):
2010-03-22 Justin Schuh <jschuh@chromium.org>
Reviewed by Dirk Schulze.
Out of bounds read in SVG feColorMatrix filter
https://bugs.webkit.org/show_bug.cgi?id=32714
Prevents an invalid read when a valid values attribute is not
supplied for an feColorMatrix SVG filter. Also fixes general
handling of missing or invalid values attribute.
- platform/win/svg/filters: Added.
- platform/win/svg/filters/feColorMatrix-values-expected.checksum: Added.
- platform/win/svg/filters/feColorMatrix-values-expected.png: Added.
- platform/win/svg/filters/feColorMatrix-values-expected.txt: Added.
- svg/filters/feColorMatrix-invalid-value-expected.txt: Added.
- svg/filters/feColorMatrix-invalid-value.svg: Added.
- svg/filters/feColorMatrix-values.svg: Added.
- 12:37 PM Changeset in webkit [56354] by
-
- 4 edits2 adds in trunk/WebCore
2010-03-22 Philippe Normand <pnormand@igalia.com>
Reviewed by Eric Carlson.
[GStreamer] Use ImageBuffer API to do painting
https://bugs.webkit.org/show_bug.cgi?id=35783
New ImageGStreamer class abstracting the conversion of GStreamer
buffers to cairo surfaces. Using this makes the painting code of
the player more generic.
- GNUmakefile.am:
- platform/graphics/gstreamer/ImageGStreamer.h: Added. (WebCore::ImageGStreamer::image):
- platform/graphics/gstreamer/ImageGStreamerCairo.cpp: Added. (ImageGStreamer::createImage): (ImageGStreamer::ImageGStreamer): (ImageGStreamer::~ImageGStreamer):
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivate::paint):
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:
- 12:36 PM Changeset in webkit [56353] by
-
- 2 edits in trunk/WebCore
Fix for <rdar://problem/7766437> With Web Inspector opened, a crash
occurs at Webcore:getMatchedCSSRules() when navigating to a
previous page
Reviewed by Darin Adler.
defaultView() can legitimately by null (as it is in this case), so
it must be null-checked.
- inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::getStyles):
(WebCore::InspectorDOMAgent::getComputedStyle):
(WebCore::InspectorDOMAgent::getMatchedCSSRules):
- 12:30 PM Changeset in webkit [56352] by
-
- 5 edits in trunk/WebCore
Reviewed by Darin.
- loader/FrameLoader.cpp: (WebCore::FrameLoader::loadPlugin): Call setShowsMissingPluginIndicator(true) in cases that fail to generate a widget.
- rendering/RenderEmbeddedObject.cpp: Added new missing plug-in related static constants (WebCore::RenderEmbeddedObject::RenderEmbeddedObject): Initialize newly boolean to false. (WebCore::RenderEmbeddedObject::paint): Added. (WebCore::RenderEmbeddedObject::paintReplaced): Added. Draws a subtle rounded rectangle containing the text "Missing Plug-in".
- rendering/RenderEmbeddedObject.h: Added the following two methods below. (WebCore::RenderEmbeddedObject::setShowsMissingPluginIndicator): (WebCore::RenderEmbeddedObject::showsMissingPluginIndicator):
- rendering/RenderWidget.h: Moved paint(PaintInfo&, int, int) from private to protected.
- 11:45 AM Changeset in webkit [56351] by
-
- 4 edits in trunk/WebKit/mac
Reviewed by John Sullivan.
https://bugs.webkit.org/show_bug.cgi?id=36455
Make WebKit more resistant against plug-in crashes
No tests, because crashing on build bots isn't good, even if it's only helper processes
that crash.
- Plugins/Hosted/NetscapePluginInstanceProxy.h: (WebKit::NetscapePluginInstanceProxy::waitForReply): Protect "this", because this function needs it after waiting for reply. Some callers used to do this, but not all, and we really shouldn't depend on callers here.
- Plugins/Hosted/NetscapePluginInstanceProxy.mm: (WebKit::NetscapePluginInstanceProxy::wheelEvent): Don't protect the plug-in instance proxy, because this function doesn't use it after waiting for reply. (WebKit::NetscapePluginInstanceProxy::createBindingsInstance): Ditto.
- Plugins/Hosted/ProxyInstance.mm: (WebKit::ProxyInstance::invoke): Added an m_instanceProxy null check for another code path.
- 11:44 AM Changeset in webkit [56350] by
-
- 2 edits in trunk/LayoutTests
2010-03-22 Nate Chapin <Nate Chapin>
Unreviewed, Chromium expectations tweak.
Add fast/dom/error-to-string-stack-overflow.html to expected
failures due to http://trac.webkit.org/changeset/56329.
- platform/chromium/test_expectations.txt:
- 11:40 AM Changeset in webkit [56349] by
-
- 5 edits in trunk
2010-03-22 Jakub Wieczorek <faw217@gmail.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Phonon media backend: expose supported MIME types to WebCore
List all skipped media tests individually and unskip two fixed by the patch.
- platform/qt/Skipped:
2010-03-22 Jakub Wieczorek <faw217@gmail.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Phonon media backend: expose supported MIME types to WebCore
MediaPlayerPrivate should expose the MIME types that are supported
by the underlying backend in Phonon.
- platform/graphics/qt/MediaPlayerPrivatePhonon.cpp: (WebCore::MediaPlayerPrivate::supportedTypesCache): (WebCore::MediaPlayerPrivate::getSupportedTypes): (WebCore::MediaPlayerPrivate::supportsType):
- platform/graphics/qt/MediaPlayerPrivatePhonon.h:
- 11:33 AM Changeset in webkit [56348] by
-
- 6 edits2 adds in trunk
JavaScriptCore: Fixed <rdar://problem/7728196> REGRESSION (r46701): -(-2147483648)
evaluates to -2147483648 on 32 bit (35842)
Reviewed by Sam Weinig.
Two ways to fix the same bug:
- Check for overflow when negating, since negating the largest negative
int causes overflow.
- Constant-fold even when negating a negative, since, like they say in
high school, "math works."
- assembler/MacroAssemblerARM.h:
(JSC::MacroAssemblerARM::branchNeg32):
- assembler/MacroAssemblerX86Common.h:
(JSC::MacroAssemblerX86Common::branchNeg32): Added a branching version
of the negate operator.
- jit/JITArithmetic.cpp:
(JSC::JIT::emit_op_negate): Use the branching version of the negate
operator to check for overflow.
(JSC::JIT::emitSlow_op_negate): Link the check for overflow to a slow case.
(We could emit inline code for this, since we know what the result would
be, but that's probably just a waste of generated code.)
- parser/Grammar.y: Constant fold even when negating a negative.
LayoutTests: Added a test for <rdar://problem/7728196> REGRESSION (r46701): -(-2147483648)
evaluates to -2147483648 on 32 bit (35842)
Reviewed by Sam Weinig.
- fast/js/negate-overflow-expected.txt: Added.
- fast/js/negate-overflow.html: Added.
- 11:18 AM Changeset in webkit [56347] by
-
- 3 edits in trunk/WebCore
2010-03-22 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: AuditRules still use getMatchedCSSRules as a part of the img-related audit.
https://bugs.webkit.org/show_bug.cgi?id=36424
- inspector/front-end/AuditRules.js: (WebInspector.AuditRules.ImageDimensionsRule.prototype.doRun): (WebInspector.AuditRules.ImageDimensionsRule.prototype.doRun.receivedImages): (WebInspector.AuditRules.ImageDimensionsRule.prototype.doRun.pushImageNodes):
- inspector/front-end/InjectedScript.js: (injectedScriptConstructor):
- 11:17 AM Changeset in webkit [56346] by
-
- 3 edits2 adds in trunk
2010-03-22 Darin Fisher <darin@chromium.org>
Reviewed by Nate Chapin.
[chromium] Renderer crashes when navigating to a reference fragment in
a frame that has no current HistoryItem.
Test: fast/loader/crash-replacing-location-before-load.html
- src/FrameLoaderClientImpl.cpp: (WebKit::FrameLoaderClientImpl::dispatchDidNavigateWithinPage):
- 10:51 AM Changeset in webkit [56345] by
-
- 2 edits in trunk/WebCore
2010-03-22 Darin Adler <Darin Adler>
Reviewed by Dan Bernstein.
TextBreakIteratorICU.cpp is incompatible with new UBreakIterator type in ICU 4.4
https://bugs.webkit.org/show_bug.cgi?id=36381
- platform/text/TextBreakIteratorICU.cpp: (WebCore::setUpIterator): Use reinterpret_cast instead of static_cast or relying on conversion to void*. (WebCore::textBreakFirst): Ditto. (WebCore::textBreakLast): Ditto. (WebCore::textBreakNext): Ditto. (WebCore::textBreakPrevious): Ditto. (WebCore::textBreakPreceding): Ditto. (WebCore::textBreakFollowing): Ditto. (WebCore::textBreakCurrent): Ditto. (WebCore::isTextBreak): Ditto. (WebCore::setUpIteratorWithRules): Ditto.
- 10:48 AM Changeset in webkit [56344] by
-
- 8 edits in trunk/WebCore
2010-03-22 Eric Carlson <eric.carlson@apple.com>
Reviewed by Sam Weinig.
Typo in GPL license text
https://bugs.webkit.org/show_bug.cgi?id=36442
Fix typo - "aint with this library" -> "along with this library".
- bindings/scripts/CodeGenerator.pm:
- bindings/scripts/CodeGeneratorJS.pm:
- bindings/scripts/CodeGeneratorObjC.pm:
- bindings/scripts/CodeGeneratorV8.pm:
- bindings/scripts/IDLParser.pm:
- bindings/scripts/IDLStructure.pm:
- bindings/scripts/generate-bindings.pl:
- 10:42 AM Changeset in webkit [56343] by
-
- 5 edits in trunk
2010-03-22 Jakub Wieczorek <jwieczorek@webkit.org>
Reviewed by Simon Hausmann.
[Qt] Don't construct a QLineEdit every time when painting a text field
https://bugs.webkit.org/show_bug.cgi?id=36373
Instead, keep one instance per RenderTheme around.
- platform/qt/RenderThemeQt.cpp: (WebCore::findFrameLineWidth):
2010-03-22 Jakub Wieczorek <jwieczorek@webkit.org>
Reviewed by Simon Hausmann.
[Qt] Don't construct a QLineEdit every time when painting a text field
https://bugs.webkit.org/show_bug.cgi?id=36373
Add a simple benchmark covering this area.
- tests/benchmarks/painting/tst_painting.cpp: (tst_Painting::textAreas):
- 10:39 AM Changeset in webkit [56342] by
-
- 3 edits in trunk/JavaScriptCore
<http://webkit.org/b/36431> Clean up 'int' use in UString.cpp after r54789
Reviewed by Darin Adler.
- runtime/UString.cpp:
(JSC::UString::from): Changed argument type from 'unsigned int'
to 'unsigned' to match WebKit coding style.
(JSC::UString::find): Changed static_cast<int>() to
static_cast<unsigned>() now that this method returns unsigned.
(JSC::UString::rfind): Ditto.
- runtime/UString.h:
(JSC::UString::from): Changed argument type from 'unsigned int'
to 'unsigned' to match WebKit coding style.
- 10:38 AM Changeset in webkit [56341] by
-
- 3 edits in trunk/WebCore
2010-03-22 Luiz Agostini <luiz.agostini@openbossa.org>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Multiselect Popup - adjusting QtAbstractWebPopup
https://bugs.webkit.org/show_bug.cgi?id=36186
QtAbstractWebPopup must provide new methods to be used by its descendants that
wish to handle <select multiple> elements.
- platform/qt/QtAbstractWebPopup.cpp: (WebCore::QtAbstractWebPopup::selectItem): (WebCore::QtAbstractWebPopup::multiple):
- platform/qt/QtAbstractWebPopup.h:
- 10:20 AM Changeset in webkit [56340] by
-
- 4 edits10 adds in trunk
2010-03-22 Alex Milowski <alex@milowski.com>
Reviewed by Kenneth Rohde Christiansen.
Basic tests of mfrac (fractions)
- mathml/presentation/fractions.xhtml: Added.
- mathml/presentation/fractions-vertical-alignment.xhtml: Added
- platform/mac/mathml/presentation/fractions-expected.checksum: Added.
- platform/mac/mathml/presentation/fractions-expected.png: Added.
- platform/mac/mathml/presentation/fractions-expected.txt: Added.
- platform/mac/mathml/presentation/fractions-vertical-alignment-expected.checksum: Added.
- platform/mac/mathml/presentation/fractions-vertical-alignment-expected.png: Added.
- platform/mac/mathml/presentation/fractions-vertical-alignment-expected.txt: Added.
2010-03-22 Alex Milowski <alex@milowski.com>
Reviewed by Kenneth Rohde Christiansen.
Added basic support for mfrac (fractions)
Test: mathml/presentation/fractions.xhtml
- WebCore.xcodeproj/project.pbxproj:
- mathml/MathMLInlineContainerElement.cpp: (WebCore::MathMLInlineContainerElement::createRenderer):
- mathml/RenderMathMLFraction.cpp: Added. (WebCore::RenderMathMLFraction::RenderMathMLFraction): (WebCore::RenderMathMLFraction::updateFromElement): (WebCore::RenderMathMLFraction::addChild):
- mathml/RenderMathMLFraction.h: Added.
- 9:47 AM Changeset in webkit [56339] by
-
- 4 edits in trunk/WebKit
WebKit: * StringsNotToBeLocalized.txt: Updated for recent changes.
WebKit/win: * WebCoreLocalizedStrings.cpp:
(WebCore::missingPluginText): Fixed localization helper text to match the same
string from Mac WebKit.
- 9:46 AM Rebaseline created by
- Ported rebaseline tool documentation from Chromium wiki
- 9:45 AM Changeset in webkit [56338] by
-
- 1 edit2 adds in trunk/LayoutTests
Reviewed by Oliver Hunt.
https://bugs.webkit.org/show_bug.cgi?id=36400
Add a test for r15750 (Flash crashes after it replaces itself via a document.write())
- plugins/destroy-plugin-from-callback-expected.txt: Added.
- plugins/destroy-plugin-from-callback.html: Added.
- 9:29 AM Changeset in webkit [56337] by
-
- 14 edits in trunk
Reviewed by John Sullivan.
- page/mac/WebCoreViewFactory.h: Added -missingPluginText method
- platform/LocalizedStrings.h: Added missingPluginText()
- platform/gtk/LocalizedStringsGtk.cpp: Likewise.
- platform/mac/LocalizedStringsMac.mm: Same here.
- platform/qt/Localizations.cpp: Ditto.
- English.lproj/Localizable.strings: Added "Missing Plug-in" string.
- src/LocalizedStrings.cpp: (WebCore::missingPluginText): Added
- WebCoreSupport/WebViewFactory.mm: (-[WebViewFactory missingPluginText]): Added.
- 9:24 AM Changeset in webkit [56336] by
-
- 2 edits in trunk/WebKitTools
2010-03-22 Chris Jerdonek <Chris Jerdonek>
Reviewed by Adam Barth.
Refactored the cpu_count() code in executive.py.
- Scripts/webkitpy/executive.py:
- Moved the import of the multiprocessing module to the top of the file rather than importing from within a function.
- 8:24 AM Changeset in webkit [56335] by
-
- 3 edits in trunk/WebKitTools
Revert "2010-03-18 Jesus Sanchez-Palencia <jesus.palencia@openbossa.org>"
This reverts commit d76f355a659be5b3384f9c26bc6ad64f3256c9fb.
Conflicts:
WebKitTools/ChangeLog
- 8:09 AM Changeset in webkit [56334] by
-
- 3 edits in trunk/WebKit/qt
2010-03-22 Yi Shen <shenyi2006@gmail.com>
Reviewed by Simon Hausmann.
https://bugs.webkit.org/show_bug.cgi?id=35933
[Qt] [Symbian] Can not backward select (highlight) text using virtual keyboard
Make sure the selection start index is smaller than the selection end index.
- Api/qwebpage.cpp: (QWebPagePrivate::inputMethodEvent):
- tests/qwebpage/tst_qwebpage.cpp: (tst_QWebPage::inputMethods):
- 7:37 AM Changeset in webkit [56333] by
-
- 7 edits3 adds in trunk/JavaScriptCore
2010-03-22 Jedrzej Nowacki <jedrzej.nowacki@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
Add support for syntax checking in the QtScript API.
New class was created; the QScriptSyntaxCheckResult which main
responsibility is to provide results of the ECMA Script code
syntax check. The class is not fully functional as the JSC C API
doesn't expose an error column number, but it is a good start point
for a future development.
[Qt] QtScript functionality should be extended by syntax checking.
https://bugs.webkit.org/show_bug.cgi?id=36123
- qt/api/QtScript.pro:
- qt/api/qscriptengine.cpp: (QScriptEngine::checkSyntax):
- qt/api/qscriptengine.h:
- qt/api/qscriptengine_p.cpp: (QScriptEnginePrivate::checkSyntax):
- qt/api/qscriptengine_p.h:
- qt/api/qscriptsyntaxcheckresult.cpp: Added. (QScriptSyntaxCheckResult::QScriptSyntaxCheckResult): (QScriptSyntaxCheckResult::~QScriptSyntaxCheckResult): (QScriptSyntaxCheckResult::operator=): (QScriptSyntaxCheckResult::state): (QScriptSyntaxCheckResult::errorLineNumber): (QScriptSyntaxCheckResult::errorColumnNumber): (QScriptSyntaxCheckResult::errorMessage):
- qt/api/qscriptsyntaxcheckresult.h: Added.
- qt/api/qscriptsyntaxcheckresult_p.cpp: Added. (QScriptSyntaxCheckResultPrivate::~QScriptSyntaxCheckResultPrivate): (QScriptSyntaxCheckResultPrivate::errorMessage): (QScriptSyntaxCheckResultPrivate::errorLineNumber):
- qt/api/qscriptsyntaxcheckresult_p.h: Added. (QScriptSyntaxCheckResultPrivate::get): (QScriptSyntaxCheckResultPrivate::QScriptSyntaxCheckResultPrivate): (QScriptSyntaxCheckResultPrivate::state): (QScriptSyntaxCheckResultPrivate::errorColumnNumber):
- qt/tests/qscriptengine/tst_qscriptengine.cpp: (tst_QScriptEngine::checkSyntax_data): (tst_QScriptEngine::checkSyntax):
- 6:26 AM Changeset in webkit [56332] by
-
- 2 edits in trunk/WebKit/chromium
2010-03-22 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Fix inspected Page crash in destructor when Web Inspector is open.
- src/js/InjectDispatch.js: (inspectedPageDestroyed): Added stub for missing method.
- 5:49 AM Changeset in webkit [56331] by
-
- 2 edits1 copy1 add in trunk/WebKitTools
Created a function for getting a module-specific logging.logger
based on the file value of the module.
Reviewed by Adam Barth.
https://bugs.webkit.org/show_bug.cgi?id=35821
This function allows us to get the module-specific logger for
a module without having to hard-code the fully-qualified name
of the module in the module itself. The code can be the same
in every case: "_log = logutils.get_logger(file)".
- Scripts/webkitpy/init/logutils.py: Added.
- Added a module with a get_logger() function to return a module-specific logger based on the module's file variable.
- Scripts/webkitpy/init/logutils_unittest.py: Added.
- Added unit tests for logutils.py.
- Scripts/webkitpy/init/unittests.py:
- Added logutils_unittest to the list of imports.
- 4:43 AM QtWebKitBackportingFixes edited by
- (diff)
- 4:07 AM Changeset in webkit [56330] by
-
- 3 edits in trunk/WebKit/chromium
2010-03-22 Jochen Eisinger <jochen@chromium.org>
Reviewed by Jeremy Orlow.
Added methods to WebSecurityOrigin for invoking
SecurityOrigin::canAccess and SecurityOrigin::Create
https://bugs.webkit.org/show_bug.cgi?id=36356
- public/WebSecurityOrigin.h:
- src/WebSecurityOrigin.cpp: (WebKit::WebSecurityOrigin::create): (WebKit::WebSecurityOrigin::canAccess):
- 2:46 AM Changeset in webkit [56329] by
-
- 8 edits1 add in trunk
2010-03-22 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Handle worker exceptions in V8MessageHandler like it's done in regular documents. This way all worker exceptions will be logged in the console not only those which happen in event listeners.
- bindings/v8/V8AbstractEventListener.cpp: (WebCore::V8AbstractEventListener::invokeEventHandler): Removed explicit call to reportException.
- bindings/v8/V8Utilities.cpp: reportException function was removed since it's not used. (WebCore::getScriptExecutionContext):
- bindings/v8/V8Utilities.h:
- bindings/v8/WorkerContextExecutionProxy.cpp: (WebCore::v8MessageHandler): (WebCore::WorkerContextExecutionProxy::initContextIfNeeded): Setup message handler when first worker context is created.
2010-03-22 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Test that uncaught exception thrown from setTimeout callback in a Worker is reported to the worker object.
- fast/workers/resources/worker-exception-in-timeout-callback.js: Added.
- fast/workers/worker-script-error-expected.txt:
- fast/workers/worker-script-error.html:
- 2:43 AM Changeset in webkit [56328] by
-
- 4 edits in trunk
2010-03-22 Kenneth Rohde Christiansen <kenneth@webkit.org>
Reviewed by Simon Hausmann.
[Qt] REGRESSION (r56209): fast/media/print-restores-previous-mediatype.htm crashes
https://bugs.webkit.org/show_bug.cgi?id=36386
- platform/qt/Skipped: unskip the test as it now passes.
2010-03-22 Kenneth Rohde Christiansen <kenneth@webkit.org>
Reviewed by Simon Hausmann.
[Qt] REGRESSION (r56209): fast/media/print-restores-previous-mediatype.htm crashes
https://bugs.webkit.org/show_bug.cgi?id=36386
Fix the regression by implementing a null printer for Qt DRT.
- DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::NullPrinter::NullPaintEngine::begin): (WebCore::NullPrinter::NullPaintEngine::end): (WebCore::NullPrinter::NullPaintEngine::type): (WebCore::NullPrinter::NullPaintEngine::drawPixmap): (WebCore::NullPrinter::NullPaintEngine::updateState): (WebCore::NullPrinter::paintEngine): (WebCore::DumpRenderTree::dryRunPrint):
- 2:24 AM Changeset in webkit [56327] by
-
- 2 edits in trunk/WebCore
2010-03-22 Leandro Pereira <leandro@profusion.mobi>
Reviewed by Simon Hausmann.
Add EFL-specific code to page/EventHandler.cpp.
http://webkit.org/b/36306
- page/EventHandler.cpp:
- 2:06 AM Changeset in webkit [56326] by
-
- 3 edits in trunk/WebCore
2010-03-22 Leandro Pereira <leandro@profusion.mobi>
Reviewed by Simon Hausmann.
Add EFL-specific code to platform/DragImage.h and
platform/DragData.h.
http://webkit.org/b/36310
- platform/DragImage.h:
- platform/DragData.h:
- 1:45 AM Changeset in webkit [56325] by
-
- 2 edits in trunk/WebCore
2010-03-22 Leandro Pereira <leandro@profusion.mobi>
Reviewed by Simon Hausmann.
Add EFL-specific code to platform/FileSystem.h.
http://webkit.org/b/36313
- platform/FileSystem.h:
- 1:26 AM Changeset in webkit [56324] by
-
- 2 edits in trunk/WebCore
2010-03-22 Leandro Pereira <leandro@profusion.mobi>
Reviewed by Simon Hausmann.
Add EFL-specific code to platform/Cursor.h.
http://webkit.org/b/36319
- platform/Cursor.h:
- 1:05 AM Changeset in webkit [56323] by
-
- 2 edits in trunk/WebCore
2010-03-22 Leandro Pereira <leandro@profusion.mobi>
Reviewed by Simon Hausmann.
Add EFL-specific code to platform/NotImplemented.h.
http://webkit.org/b/36320
- platform/NotImplemented.h:
