⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Mar 25, 2010:

11:34 PM Changeset in webkit [56606] by abarth@webkit.org
  • 12 edits
    1 move
    2 adds
    1 delete in trunk

2010-03-25 Charlie Reis <​creis@chromium.org>

Reviewed by Adam Barth.

onbeforeunload not called at window close + frame or iframe focused
​https://bugs.webkit.org/show_bug.cgi?id=27481

Adds a layout test for bug 27481. Requires calling shouldClose on
the WebView, which is done with a new method on LayoutTestController.

  • fast/events/onbeforeunload-focused-iframe-expected.txt: Added.
  • fast/events/onbeforeunload-focused-iframe.html: Added.
  • fast/events/resources/onbeforeunload-focused-iframe-frame.html: Added.
  • platform/gtk/Skipped:
  • platform/qt/Skipped:

2010-03-25 Charlie Reis <​creis@chromium.org>

Reviewed by Adam Barth.

onbeforeunload not called at window close + frame or iframe focused
​https://bugs.webkit.org/show_bug.cgi?id=27481

Test: fast/events/onbeforeunload-focused-iframe.html

Replaces initial manual tests with a layout test.

  • manual-tests/onbeforeunload-focused-iframe.html: Removed.
  • manual-tests/resources/focused-iframe.html: Removed.

2010-03-25 Charlie Reis <​creis@chromium.org>

Reviewed by Adam Barth.

onbeforeunload not called at window close + frame or iframe focused
​https://bugs.webkit.org/show_bug.cgi?id=27481

Adds a callShouldCloseOnWebView method to LayoutTestController,
to allow automated testing for bug 27481.

  • DumpRenderTree/LayoutTestController.cpp: (callShouldCloseOnWebViewCallback): (LayoutTestController::staticFunctions):
  • DumpRenderTree/LayoutTestController.h:
  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::callShouldCloseOnWebView):
  • DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::callShouldCloseOnWebView):
  • DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::callShouldCloseOnWebView):
  • DumpRenderTree/qt/LayoutTestControllerQt.h:
  • DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::callShouldCloseOnWebView):
11:23 PM Changeset in webkit [56605] by eric@webkit.org
  • 2 edits in trunk/LayoutTests

2010-03-25 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

REGRESSION: plugins/netscape-construct.html and plugins/mouse-events-fixedpos.html failing on Snow Leopard Bot
​https://bugs.webkit.org/show_bug.cgi?id=36462

Adding tests to the Skipped list per Alexey's recommendation
until someone from Apple can update the version of Safari
on the Snow Leopard bot.

  • platform/mac-snowleopard/Skipped:
11:06 PM Changeset in webkit [56604] by eric@webkit.org
  • 3 edits
    2 adds in trunk

2010-03-25 Eric Uhrhane <​ericu@chromium.org>

Reviewed by David Levin.

Missing lock in call to doneCreatingDatabase
​https://bugs.webkit.org/show_bug.cgi?id=36473

Added new test storage/open-database-over-quota.html.

  • storage/open-database-over-quota.html: Added.
  • storage/open-database-over-quota-expected.txt: Added.

2010-03-25 Eric Uhrhane <​ericu@chromium.org>

Reviewed by David Levin.

Missing lock in call to doneCreatingDatabase
​https://bugs.webkit.org/show_bug.cgi?id=36473

Added new test storage/open-database-over-quota.html.

  • storage/DatabaseTracker.cpp: (WebCore::DatabaseTracker::canEstablishDatabase): Added missing lock call.
10:48 PM Changeset in webkit [56603] by eric@webkit.org
  • 5 edits in trunk

2010-03-25 Tony Chang <​tony@chromium.org>

Reviewed by David Levin.

[chromium] correctly handle move drag operations
​https://bugs.webkit.org/show_bug.cgi?id=36484

  • platform/chromium/test_expectations.txt:

2010-03-25 Tony Chang <​tony@chromium.org>

Reviewed by David Levin.

[chromium] correctly handle move drag operations
​https://bugs.webkit.org/show_bug.cgi?id=36484

  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::dragTargetDragEnter): (WebKit::WebViewImpl::dragTargetDragOver): (WebKit::WebViewImpl::dragTargetDragEnterOrOver): Combine common code into a helper method

and properly mask against the drag effect.

(WebKit::WebViewImpl::createUniqueIdentifierForRequest):

  • src/WebViewImpl.h:
10:42 PM Changeset in webkit [56602] by abarth@webkit.org
  • 4 edits in trunk/WebKitTools

2010-03-25 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Add webkit-patch lkgr for finding last known good revision
​https://bugs.webkit.org/show_bug.cgi?id=36626

This is rather slow for now because the command
has to compute this information from the buildbot.
A better long-term solution would be to have a server
somewhere store a pre-computed LKGR and then any
script (like webkit-patch) could just fetch it.

  • Scripts/webkitpy/common/net/buildbot.py:
  • Scripts/webkitpy/tool/commands/queries.py:
10:38 PM Changeset in webkit [56601] by abarth@webkit.org
  • 10 edits in trunk/WebKitTools

2010-03-25 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Move modified_changelogs (and friends) from scm to checkout
​https://bugs.webkit.org/show_bug.cgi?id=36636

These functions know about ChangeLogs, which is forbidden knowledge in
scm.py.

  • Scripts/webkitpy/common/checkout/api.py:
  • Scripts/webkitpy/common/checkout/changelog.py:
  • Scripts/webkitpy/common/checkout/scm.py:
  • Scripts/webkitpy/tool/mocktool.py:
  • Scripts/webkitpy/tool/steps/abstractstep.py:
  • Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
  • Scripts/webkitpy/tool/steps/revertrevision.py:
  • Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py:
  • Scripts/webkitpy/tool/steps/validatereviewer.py:
10:32 PM Changeset in webkit [56600] by abarth@webkit.org
  • 6 edits in trunk/WebKitTools

2010-03-25 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Move apply_patch from scm to checkout
​https://bugs.webkit.org/show_bug.cgi?id=36635

SCM shouldn't have any knowledge of WebKit scripts.

  • Scripts/webkitpy/common/checkout/api.py:
  • Scripts/webkitpy/common/checkout/scm.py:
  • Scripts/webkitpy/common/checkout/scm_unittest.py:
  • Scripts/webkitpy/tool/mocktool.py:
  • Scripts/webkitpy/tool/steps/applypatch.py:
9:48 PM Changeset in webkit [56599] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2010-03-25 Eric Seidel <​eric@webkit.org>

Unreviewed build fix to un-break webkit-patch land.
Test-case coming in follow-up commit.

Move commit_message_for_this_commit from scm to checkout
​https://bugs.webkit.org/show_bug.cgi?id=36629

  • Scripts/webkitpy/common/checkout/api.py: import scm.CommitMessage
9:40 PM Changeset in webkit [56598] by ojan@chromium.org
  • 4 edits in trunk

WebCore:
2010-03-25 Ojan Vafai <​ojan@chromium.org>

Reviewed by Eric Seidel.

[chromium] REGRESSION: Some LayoutTests fail after r56567
​https://bugs.webkit.org/show_bug.cgi?id=36630

Fix boolean logic goofup. This was a last minute code review
change that didn't get tested on Windows before commit.

  • editing/SelectionController.cpp: (WebCore::SelectionController::setIsDirectional):

LayoutTests:
2010-03-25 Ojan Vafai <​ojan@chromium.org>

Reviewed by Eric Seidel.

[chromium] REGRESSION: Some LayoutTests fail after r56567
​https://bugs.webkit.org/show_bug.cgi?id=36630

  • platform/chromium/test_expectations.txt:
9:35 PM Changeset in webkit [56597] by mitz@apple.com
  • 11 edits
    1 copy
    5 adds in trunk

<rdar://problem/7728903> Support color bitmap fonts

Reviewed by Darin Adler.

WebCore:

Test: platform/mac/fonts/color-bitmap.html

  • platform/graphics/mac/FontMac.mm:

(WebCore::showGlyphsWithAdvances): Added. Calls CGContextShowGlyphsWithAdvances()
or CTFontShowGlyphs() depending on whether the font is a color bitmap font.
(WebCore::Font::drawGlyphs): Use showGlyphsWithAdvances(). Don’t include the font’s matrix in
the context’s text matrix when drawing with a color bitmap font, because CTFontShowGlyphs()
factors it in.

  • platform/graphics/mac/FontPlatformData.h:

(WebCore::FontPlatformData::FontPlatformData): Added m_isColorBitmapFont member
and initialized it in constructors.
(WebCore::FontPlatformData::isColorBitmapFont): Added this getter.

  • platform/graphics/mac/FontPlatformDataMac.mm:

(WebCore::FontPlatformData::FontPlatformData): Initialize m_isColorBitmapFont.
(WebCore::FontPlatformData::operator=): Copy m_isColorBitmapFont.
(WebCore::FontPlatformData::setFont): Set m_isColorBitmapFont.

WebKitTools:

  • DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Added ColorBits.ttf

and ColorBits-A.png.

  • DumpRenderTree/fonts/ColorBits-A.png: Copied from WebCore/inspector/front-end/Images/successGreenDot.png.
  • DumpRenderTree/fonts/ColorBits.ttf: Added.
  • DumpRenderTree/mac/DumpRenderTree.mm:

(activateFonts): Activate ColorBits.ttf.

LayoutTests:

  • platform/mac-leopard/Skipped:
  • platform/mac-snowleopard/Skipped:
  • platform/mac-tiger/Skipped:
  • platform/mac/fonts/color-bitmap-expected.checksum: Added.
  • platform/mac/fonts/color-bitmap-expected.png: Added.
  • platform/mac/fonts/color-bitmap-expected.txt: Added.
  • platform/mac/fonts/color-bitmap.html: Added.
9:28 PM Changeset in webkit [56596] by dimich@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed, another attempt to unblock Chromium Win test bot.

  • platform/chromium/test_expectations.txt:
9:23 PM Changeset in webkit [56595] by dimich@chromium.org
  • 1 edit
    1 delete in trunk/LayoutTests

Unreviewed, removing stale expectation file for Chromium.

The test was updated by ​http://trac.webkit.org/changeset/56506 to a script test.

  • platform/chromium-win/editing/inserting/6633727-expected.txt: Removed.
9:13 PM Changeset in webkit [56594] by dimich@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed, temporarily disabling test on Chromium bots.

​http://crbug.com/39423

  • platform/chromium/test_expectations.txt:
8:04 PM Changeset in webkit [56593] by mrowe@apple.com
  • 2 edits in trunk/WebKitTools

Remove a printf that was causing commit-log-editor to spew the name of the editor
to the terminal many times during a commit.

  • Scripts/commit-log-editor:
8:04 PM Changeset in webkit [56592] by eric@webkit.org
  • 8 edits in trunk/WebKitTools

2010-03-25 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Move commit_message_for_this_commit from scm to checkout
​https://bugs.webkit.org/show_bug.cgi?id=36629

This function requires knowledge of ChangeLogs, but scm shouldn't know
about ChangeLogs.

  • Scripts/webkitpy/common/checkout/api.py:
  • Scripts/webkitpy/common/checkout/scm.py:
  • Scripts/webkitpy/tool/commands/upload.py:
  • Scripts/webkitpy/tool/commands/upload_unittest.py:
  • Scripts/webkitpy/tool/mocktool.py:
  • Scripts/webkitpy/tool/steps/applypatchwithlocalcommit.py:
  • Scripts/webkitpy/tool/steps/commit.py:
7:46 PM Changeset in webkit [56591] by eric@webkit.org
  • 7 edits
    20 adds in trunk

2010-03-25 Adam Barth <​abarth@webkit.org>

Reviewed by Sam Weinig.

Implement allow-top-navigation for HTML5 sandbox attribute
​https://bugs.webkit.org/show_bug.cgi?id=36549

Test various cases relating to navigating top level frames and the
allow-top-navigation directive. This feature is tricky to test
exhaustively because there are a lot of permutations.

  • fast/frames/resources/fail-and-notify-done.html: Added.
  • fast/frames/resources/navigate-top-by-constant-name-to-pass.html: Added.
  • fast/frames/resources/navigate-top-by-constant-name2-to-pass.html: Added.
  • fast/frames/resources/navigate-top-by-name-to-fail.html: Added.
  • fast/frames/resources/navigate-top-by-name-to-pass.html: Added.
  • fast/frames/resources/navigate-top-to-fail.html: Added.
  • fast/frames/resources/navigate-top-to-pass.html: Added.
  • fast/frames/resources/pass-and-notify-done.html: Added.
  • fast/frames/sandboxed-iframe-navigation-top-by-constant-name-expected.txt: Added.
  • fast/frames/sandboxed-iframe-navigation-top-by-constant-name.html: Added.
  • fast/frames/sandboxed-iframe-navigation-top-by-constant-name2-expected.txt: Added.
  • fast/frames/sandboxed-iframe-navigation-top-by-constant-name2.html: Added.
  • fast/frames/sandboxed-iframe-navigation-top-by-name-denied-expected.txt: Added.
  • fast/frames/sandboxed-iframe-navigation-top-by-name-denied.html: Added.
  • fast/frames/sandboxed-iframe-navigation-top-by-name-expected.txt: Added.
  • fast/frames/sandboxed-iframe-navigation-top-by-name.html: Added.
  • fast/frames/sandboxed-iframe-navigation-top-denied-expected.txt: Added.
  • fast/frames/sandboxed-iframe-navigation-top-denied.html: Added.
  • fast/frames/sandboxed-iframe-navigation-top-expected.txt: Added.
  • fast/frames/sandboxed-iframe-navigation-top.html: Added.

2010-03-25 Adam Barth <​abarth@webkit.org>

Reviewed by Sam Weinig.

Implement allow-top-navigation for HTML5 sandbox attribute
​https://bugs.webkit.org/show_bug.cgi?id=36549

Tests: fast/frames/sandboxed-iframe-navigation-top-by-constant-name.html

fast/frames/sandboxed-iframe-navigation-top-by-constant-name2.html
fast/frames/sandboxed-iframe-navigation-top-by-name-denied.html
fast/frames/sandboxed-iframe-navigation-top-by-name.html
fast/frames/sandboxed-iframe-navigation-top-denied.html
fast/frames/sandboxed-iframe-navigation-top.html

  • bindings/generic/BindingDOMWindow.h: (WebCore::::createWindow):
  • bindings/js/JSDOMWindowCustom.cpp: (WebCore::createWindow): Moved the security check to FrameLoader because we need to allow window.open navigation to succeed sometimes when the SandboxNavigation bit is set.
  • html/HTMLIFrameElement.cpp: (WebCore::parseSandboxAttribute): Added allow-top-navigation to the parser.
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::createWindow): The SandboxNavigation check now occurs after we search for the frame by name. Notice that the named frame navigation case is caught by the generic navigation access check. (WebCore::FrameLoader::shouldAllowNavigation): Update the navigation access check to allow navigating of top unless it's forbidden.
  • loader/FrameLoaderTypes.h: Introduce a bit for SandboxedTopNavigation. (WebCore::):
7:32 PM Changeset in webkit [56590] by ap@apple.com
  • 2 edits in trunk/WebKit/mac

Reviewed by Mark Rowe.

  • Plugins/Hosted/NetscapePluginHostProxy.mm: (WKPCRunSyncOpenPanel): Re-fetch host proxy in a way that works in a function that doesn't have a pluginID argument for some reason.
7:21 PM Changeset in webkit [56589] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2010-03-25 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

REGRESSION: webkit-patch land can't land "rubber-stamped" patches
​https://bugs.webkit.org/show_bug.cgi?id=36582

Allow a "-" in rubber stamped.

  • Scripts/webkitpy/tool/steps/validatereviewer.py:
7:12 PM Changeset in webkit [56588] by dumi@chromium.org
  • 5 edits in trunk

Unreviewed, Chromium build fix.

WebCore:

V8CustomVoidCallback should not check if a return value is a
boolean. It should only convert the value to a boolean.

  • bindings/v8/custom/V8CustomVoidCallback.cpp:

(WebCore::invokeCallback):

LayoutTests:

Update the expectations for statement-error-callback.html for Chromium.

  • platform/chromium-mac/storage/statement-error-callback-expected.txt:
  • platform/chromium-win/storage/statement-error-callback-expected.txt:
6:48 PM Changeset in webkit [56587] by dimich@chromium.org
  • 4 edits in trunk/WebCore

Revert "2010-03-25 Laszlo Gombos <Laszlo Gombos>"

This reverts commit 2a3b308efc33f4829fe9717d93a4b245d3b25f6d.

6:26 PM Changeset in webkit [56586] by abarth@webkit.org
  • 14 edits in trunk/WebKitTools

2010-03-25 Adam Barth <​abarth@webkit.org>

Unreviewed. Fix some copyright lines to remove extraneous comma and
python directive.

  • Scripts/webkitpy/tool/bot/patchcollection.py:
  • Scripts/webkitpy/tool/bot/patchcollection_unittest.py:
  • Scripts/webkitpy/tool/bot/queueengine.py:
  • Scripts/webkitpy/tool/bot/queueengine_unittest.py:
  • Scripts/webkitpy/tool/commands/download.py:
  • Scripts/webkitpy/tool/commands/earlywarningsystem.py:
  • Scripts/webkitpy/tool/commands/queries.py:
  • Scripts/webkitpy/tool/commands/queues.py:
  • Scripts/webkitpy/tool/commands/sheriffbot.py:
  • Scripts/webkitpy/tool/comments.py:
  • Scripts/webkitpy/tool/grammar.py:
  • Scripts/webkitpy/tool/multicommandtool.py:
  • Scripts/webkitpy/tool/multicommandtool_unittest.py:
6:04 PM Changeset in webkit [56585] by eric@webkit.org
  • 4 edits in trunk/WebCore

2010-03-25 Laszlo Gombos <Laszlo Gombos>

Reviewed by Darin Adler.

Fix build if NPAPI support is disabled
​https://bugs.webkit.org/show_bug.cgi?id=36621

No new tests, this is a build fix.

  • plugins/PluginView.cpp: Guard getValueStatic() with NETSCAPE_PLUGIN_API (WebCore::PluginView::getValue):
  • plugins/PluginView.h: Guard getValue() with NETSCAPE_PLUGIN_API
  • plugins/PluginViewNone.cpp: Guard platformGetValue() and platformGetValueStatic with NETSCAPE_PLUGIN_API; Guard privateBrowsingStateChanged() and setJavaScriptPaused() with PLATFORM(MAC)
5:53 PM Changeset in webkit [56584] by dimich@chromium.org
  • 6 edits in trunk/LayoutTests

Not reviewed, update pixel results for Chromium bots.

The rendering of these tests was changed by ​http://trac.webkit.org/changeset/56507.
Also updated Chromium's test_expectations.txt.

  • platform/chromium-linux/fast/dynamic/flash-replacement-test-expected.checksum:
  • platform/chromium-linux/fast/dynamic/flash-replacement-test-expected.png:
  • platform/chromium-linux/plugins/embed-attributes-style-expected.checksum:
  • platform/chromium-linux/plugins/embed-attributes-style-expected.png:
  • platform/chromium/test_expectations.txt: Use BUG_WKXXXX instead of WKXXXX notation to appease validation on the bot.
5:46 PM Changeset in webkit [56583] by Simon Fraser
  • 4 edits in trunk/WebKitTools

2010-03-25 Simon Fraser <Simon Fraser>

Reviewed by Darin Adler, Alexey Proskuryakov.

​https://bugs.webkit.org/show_bug.cgi?id=36631
Allow the test plugin to run scripts in response to NPP_SetWindow calls

Hook up the ability for the TestNetscapePlugIn to run JavaScript in
response to NPP_SetWindow.

  • DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: (pluginAllocate):
  • DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h:
  • DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp: (NPP_New): (NPP_Destroy): (NPP_SetWindow):
5:26 PM Changeset in webkit [56582] by dimich@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed, fixing Chromium test bots.

[chromium] REGRESSION: Some LayoutTests fail after r56567
​https://bugs.webkit.org/show_bug.cgi?id=36630

  • platform/chromium/test_expectations.txt: Update expectations.
5:24 PM Changeset in webkit [56581] by eric@webkit.org
  • 3 edits in trunk/WebKit/qt

2010-03-25 Yael Aharon <​yael.aharon@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] QtLauncher crashes on Mac OS and Linux when exiting with QGraphicsView mode enabled
​https://bugs.webkit.org/show_bug.cgi?id=35251

Followed the way QWebView registers for the signal QWebPage::destroyed(), to prevent
QGraphicsWebView from referencing QWebPage after it was deleted.

  • Api/qgraphicswebview.cpp: (QGraphicsWebViewPrivate::_q_pageDestroyed): (QGraphicsWebView::setPage):
  • Api/qgraphicswebview.h:
5:06 PM Changeset in webkit [56580] by eric@webkit.org
  • 9 edits in trunk

2010-03-25 Drew Wilson <​atwilson@chromium.org>

Reviewed by Nate Chapin.

[v8] Error in getScriptExecutionContext() when worker context is terminating.
​https://bugs.webkit.org/show_bug.cgi?id=36565

Removed WorkerScriptExecutionProxy::retrieve() and added WorkerScriptController::controllerForContext(). This allows
callers to differentiate between "the current context is shutting down" vs "the current context is not a worker context".

Test: Existing worker tests suffice.

  • bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::getConstructor): Changed to use WorkerScriptController::controllerForContext() instead of WorkerScriptExecutionProxy::retrieve().
  • bindings/v8/V8Utilities.cpp: (WebCore::getScriptExecutionContext): Changed to use WorkerScriptController::controllerForContext() instead of WorkerScriptExecutionProxy::retrieve().
  • bindings/v8/WorkerContextExecutionProxy.cpp: Removed WorkerScriptExecutionProxy::retrieve().
  • bindings/v8/WorkerContextExecutionProxy.h: Removed WorkerScriptExecutionProxy::retrieve().
  • bindings/v8/WorkerScriptController.cpp: (WebCore::WorkerScriptController::controllerForContext): Added helper function to get the WorkerScriptController for the current context.
  • bindings/v8/WorkerScriptController.h: Added declaration for controllerForContext().

2010-03-25 Drew Wilson <​atwilson@chromium.org>

Reviewed by Nate Chapin.

[v8] Error in getScriptExecutionContext() when worker context is terminating
​https://bugs.webkit.org/show_bug.cgi?id=36565

Test: Existing worker tests suffice.

  • src/WebWorkerClientImpl.cpp: (WebKit::WebWorkerClientImpl::createWorkerContextProxy): Changed to use WorkerScriptController::controllerForContext() instead of WorkerScriptExecutionProxy::retrieve().
4:48 PM Changeset in webkit [56579] by eric@webkit.org
  • 4 edits
    1 add in trunk/WebKit/chromium

2010-03-25 Jeremy Orlow <​jorlow@chromium.org>

Reviewed by Darin Fisher.

[Chromium] Add an ASSERT macro to the Chromium WebKit API
​https://bugs.webkit.org/show_bug.cgi?id=36545

  • WebKit.gyp: Add WebCommon.cpp
  • public/WebCommon.h: Add the Macro.
  • public/WebPrivatePtr.h: (WebKit::WebPrivatePtr::~WebPrivatePtr): Verify the pointer is now 0.
  • src/WebCommon.cpp: Added. (WebKit::failedAssertion): Calls the WTF assert function and then crashes.
4:33 PM Changeset in webkit [56578] by kov@webkit.org
  • 3 edits in trunk/LayoutTests

2010-03-25 Gustavo Noronha Silva <Gustavo Noronha Silva>

Needs a "LinuxEditingBehavior", perhaps with a better name
​https://bugs.webkit.org/show_bug.cgi?id=36627

Skipping tests that started failing after 56567. We need to figure
out a proper fix, that may involve adding a new editing behavior
for our platform.

  • platform/gtk/Skipped:
  • platform/qt/Skipped:
4:30 PM Changeset in webkit [56577] by eric@webkit.org
  • 2 edits in trunk/WebKit/qt

2010-03-25 Kent Hansen <​kent.hansen@nokia.com>

Reviewed by Simon Hausmann.

[Qt] QWebFrame::pageChanged() signal is not documented
​https://bugs.webkit.org/show_bug.cgi?id=36609

  • Api/qwebframe.cpp:
4:12 PM Changeset in webkit [56576] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-03-25 Simon Hausmann <​simon.hausmann@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Fix the package build on Maemo 5

​https://bugs.webkit.org/show_bug.cgi?id=36607

Always embed the stylesheet for the no-listbox rendering. This way it'll be
included in the generated files for the package generation.

  • WebCore.pri:
4:09 PM Changeset in webkit [56575] by Laszlo Gombos
  • 2 edits in trunk/WebKitTools

2010-03-25 Laszlo Gombos <Laszlo Gombos>

Unreviewed, build fix.

[Qt] Fix QtLauncher guards.

  • QtLauncher/main.cpp: (LauncherWindow::showFPS): (LauncherWindow::updateFPS):
3:49 PM Changeset in webkit [56574] by kov@webkit.org
  • 2 edits in trunk/WebKit/gtk/po

2010-03-25 Reinout van Schouwen <​reinouts@gnome.org>

Reviewed by Gustavo Noronha.

Updated Dutch translation
​https://bugs.webkit.org/show_bug.cgi?id=36432

  • nl.po:
3:38 PM Changeset in webkit [56573] by scherkus@chromium.org
  • 2 edits in trunk/LayoutTests

2010-03-25 Andrew Scherkus <​scherkus@chromium.org>

Unreviewed, expectations tweak.

Reorganized and updated comments for media test expectations.

  • platform/chromium/test_expectations.txt: Tweaked.
3:29 PM Changeset in webkit [56572] by dumi@chromium.org
  • 8 edits in trunk

WebCore: Changing the V8 and JSC implementations of
SQLStatementErrorCallback to interpret as false all results that
could be converted to a false boolean. Pretty much a revert of
r54981.

Reviewed by Dimitri Glazkov.

​https://bugs.webkit.org/show_bug.cgi?id=36569

  • bindings/js/JSCustomSQLStatementErrorCallback.cpp:

(WebCore::JSCustomSQLStatementErrorCallback::handleEvent):

  • bindings/v8/custom/V8CustomSQLStatementErrorCallback.cpp:

(WebCore::V8CustomSQLStatementErrorCallback::handleEvent):

  • bindings/v8/custom/V8CustomVoidCallback.cpp:

(WebCore::invokeCallback):

  • bindings/v8/custom/V8CustomVoidCallback.h:

LayoutTests: Updating the test to conform to the latest spec changes.

Reviewed by Dimitri Glazkov.

  • storage/statement-error-callback-expected.txt:
  • storage/statement-error-callback.html:
3:25 PM Changeset in webkit [56571] by eric@webkit.org
  • 2 edits in trunk/WebKit/chromium

2010-03-25 Jochen Eisinger <​jochen@chromium.org>

Reviewed by Jeremy Orlow.

Remove ASSERT(isMainThread()) which is violated for workers and not necessary at this point.
​https://bugs.webkit.org/show_bug.cgi?id=36614

  • src/DatabaseObserver.cpp: (WebCore::DatabaseObserver::canEstablishDatabase):
2:58 PM Changeset in webkit [56570] by dimich@chromium.org
  • 2 edits in trunk/WebCore

Unreviewed, fix Chromium tests.

Recent ​http://trac.webkit.org/changeset/56489 made all urls in Chromium that
have unspecified port to return invalidPortNumber from KURL::port().

  • platform/KURLGoogle.cpp: Return 0 for unspecified ports, mimic WebKit KURL behavior for invalid ports.

(WebCore::KURL::port):

2:39 PM Changeset in webkit [56569] by krit@webkit.org
  • 3 edits in trunk/WebCore

2010-03-25 Dirk Schulze <​krit@webkit.org>

Reviewed by Nikolas Zimmermann.

This is a follow up of:
​https://bugs.webkit.org/show_bug.cgi?id=30055
Bad DOM performance in large SVG files

Just save and restore the GraphicsContext, if we realy modify it.
(Cairo)Path::contains checks if a point is in the boundingBox
as a heuristic. The intention was to make the process faster for
points outside of this rect, but it rather causes the
opposite.

No new test cases added. No change in functionality.

  • platform/graphics/cairo/PathCairo.cpp: (WebCore::Path::contains):
  • rendering/RenderPath.cpp: (WebCore::RenderPath::paint):
2:33 PM Changeset in webkit [56568] by Simon Fraser
  • 2 edits in trunk/WebCore

2010-03-25 Simon Fraser <Simon Fraser>

Revert r56565 which was based on an incorrect premise.

  • page/animation/CompositeAnimation.cpp: (WebCore::CompositeAnimation::clearRenderer): (WebCore::CompositeAnimation::updateKeyframeAnimations): (WebCore::CompositeAnimation::getAnimatedStyle): (WebCore::CompositeAnimation::setAnimating): (WebCore::CompositeAnimation::timeToNextService): (WebCore::CompositeAnimation::getAnimationForProperty): (WebCore::CompositeAnimation::suspendAnimations): (WebCore::CompositeAnimation::resumeAnimations): (WebCore::CompositeAnimation::isAnimatingProperty): (WebCore::CompositeAnimation::pauseAnimationAtTime): (WebCore::CompositeAnimation::numberOfActiveAnimations):
1:21 PM Changeset in webkit [56567] by ojan@chromium.org
  • 11 edits
    8 deletes in trunk

2010-03-25 Ojan Vafai <​ojan@chromium.org>

Reviewed by David Levin.

mouse-based selections are always directional on Window/Linux
​https://bugs.webkit.org/show_bug.cgi?id=25195

The tests are modified to expect different things for Win/Linux vs. Mac.

  • editing/selection/5195166-1.html:
  • editing/selection/extend-after-mouse-selection.html:
  • editing/selection/extend-selection-after-double-click-expected.txt:
  • editing/selection/extend-selection-after-double-click.html:
  • platform/chromium-linux/editing/selection/5195166-1-expected.checksum: Removed.
  • platform/chromium-linux/editing/selection/5195166-1-expected.png: Removed.
  • platform/chromium-win/editing/selection/5195166-1-expected.checksum: Removed.
  • platform/chromium-win/editing/selection/5195166-1-expected.png: Removed.
  • platform/chromium-win/editing/selection/5195166-1-expected.txt: Removed.
  • platform/mac/editing/selection/5195166-1-expected.checksum: Removed.
  • platform/mac/editing/selection/5195166-1-expected.png: Removed.
  • platform/mac/editing/selection/5195166-1-expected.txt:
  • platform/qt/editing/selection/5195166-1-expected.txt: Removed.
  • platform/win/editing/selection/extend-after-mouse-selection-expected.txt:

2010-03-25 Ojan Vafai <​ojan@chromium.org>

Reviewed by David Levin.

mouse-based selections are always directional on Windows/Linux
​https://bugs.webkit.org/show_bug.cgi?id=25195

Change m_lastChangeWasHorizontalExtension to m_isDirectional
and make m_isDirectional always be true for Windows/Linux.

  • editing/SelectionController.cpp: (WebCore::SelectionController::SelectionController): (WebCore::SelectionController::setSelection): (WebCore::SelectionController::setIsDirectional): (WebCore::SelectionController::willBeModified): When double-clicking, the base/extent will be in the middle of the selection instead of the start/end of it. Changed to maintain that modifications after double-click still move the start/end of the selection, not the base/extent. (WebCore::SelectionController::modify):
  • editing/SelectionController.h:
  • page/EventHandler.cpp: (WebCore::EventHandler::handleMousePressEventSingleClick): (WebCore::EventHandler::updateSelectionForMouseDrag):
1:20 PM Changeset in webkit [56566] by yurys@chromium.org
  • 11 edits in trunk/WebKitTools

2010-03-25 Yury Semikhatsky <​yurys@chromium.org>

Reviewed by Pavel Feldman.

Allow running tests with enabled developer extras and closed Web Inspector. Tests that have inspector-enabled/ in their path/url will have developer extras enabled.

​https://bugs.webkit.org/show_bug.cgi?id=36610

  • DumpRenderTree/LayoutTestController.h:
  • DumpRenderTree/gtk/DumpRenderTree.cpp: (shouldEnableDeveloperExtras): (runTest):
  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::setJavaScriptProfilingEnabled): (LayoutTestController::setDeveloperExtrasEnabled): (LayoutTestController::showWebInspector): (LayoutTestController::closeWebInspector):
  • DumpRenderTree/mac/DumpRenderTree.mm: (shouldEnableDeveloperExtras): (runTest):
  • DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::setJavaScriptProfilingEnabled): (LayoutTestController::setDeveloperExtrasEnabled): (LayoutTestController::showWebInspector): (LayoutTestController::closeWebInspector):
  • DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::shouldEnableDeveloperExtras): (WebCore::DumpRenderTree::open):
  • DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::closeWebInspector): (LayoutTestController::setDeveloperExtrasEnabled): (LayoutTestController::showWebInspector): (LayoutTestController::setJavaScriptProfilingEnabled):
  • DumpRenderTree/win/DumpRenderTree.cpp: (shouldEnableDeveloperExtras): (runTest):
  • DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::setJavaScriptProfilingEnabled): (LayoutTestController::setDeveloperExtrasEnabled): (LayoutTestController::showWebInspector): (LayoutTestController::closeWebInspector):
12:57 PM Changeset in webkit [56565] by Simon Fraser
  • 2 edits in trunk/WebCore

2010-03-25 Simon Fraser <Simon Fraser>

Reviewed by Eric Carlson.

Make calls to m_keyframeAnimations.checkConsistency() debug-only
​https://bugs.webkit.org/show_bug.cgi?id=36555

Remove lots of calls to m_keyframeAnimations.checkConsistency(); which were left after some earlier
debugging. Leave one in CompositeAnimation::animate() to catch any future issues, which is OK since
these calls are no-ops in release builds.

  • page/animation/CompositeAnimation.cpp: (WebCore::CompositeAnimation::clearRenderer): (WebCore::CompositeAnimation::updateKeyframeAnimations): (WebCore::CompositeAnimation::getAnimatedStyle): (WebCore::CompositeAnimation::setAnimating): (WebCore::CompositeAnimation::timeToNextService): (WebCore::CompositeAnimation::getAnimationForProperty): (WebCore::CompositeAnimation::suspendAnimations): (WebCore::CompositeAnimation::resumeAnimations): (WebCore::CompositeAnimation::isAnimatingProperty): (WebCore::CompositeAnimation::pauseAnimationAtTime): (WebCore::CompositeAnimation::numberOfActiveAnimations):
12:07 PM Changeset in webkit [56564] by Simon Fraser
  • 2 edits in trunk/WebKit/mac

2010-03-25 Simon Fraser <Simon Fraser>

Build fix: no review.

Another c_str() -> data().

  • Plugins/Hosted/NetscapePluginInstanceProxy.mm: (WebKit::NetscapePluginInstanceProxy::enumerate):
11:58 AM Changeset in webkit [56563] by barraclough@apple.com
  • 2 edits in trunk/JavaScriptCore
  • profiler/ProfileGenerator.cpp:

(JSC::ProfileGenerator::willExecute):
(JSC::ProfileGenerator::didExecute):

Reviewed by NOBODY (build fix).

11:48 AM Changeset in webkit [56562] by Simon Fraser
  • 3 edits
    6 adds in trunk

2010-03-25 Simon Fraser <Simon Fraser>

Reviewed by Geoffrey Garen.

​https://bugs.webkit.org/show_bug.cgi?id=36557
Animations use the wrong timing-function sometimes

Fix an issue where animations picked the wrong style for their "unanimated" value.

Previously, the "unanimated" style was considered to be the style before the animation
was applied. This caused us to pick up stale values for animation timing functions, for
blending when a property is missing from the first keyframe, and for resuming transitions
once an animation ends.

Instead, we need to use the "current" style, which is the one that causes the animation
to kick off.

Tests: animations/longhand-timing-function.html

animations/transition-and-animation-3.html
animations/unanimated-style.html

  • page/animation/CompositeAnimation.cpp: (WebCore::CompositeAnimation::updateKeyframeAnimations):
11:37 AM WebKit Team edited by Chris Jerdonek
Updated link to committers.py. (diff)
11:29 AM Changeset in webkit [56561] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

Unreviewed expected file fix.

  • platform/mac/fast/frames/flattening/frameset-flattening-grid-expected.txt: Needless newline removed.
11:20 AM Changeset in webkit [56560] by barraclough@apple.com
  • 16 edits in trunk

Bug 36611 - Cleanup JSC::CString
Rename CString::c_str() -> CString::data(), CString::size() -> CString::length(),
remove UString::getCString() (all uses are wrong, should use UString::UTF8String()).

Reviewed by Geoff Garen.

JavaScriptCore:

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::printUnaryOp):
(JSC::CodeBlock::printBinaryOp):
(JSC::CodeBlock::printConditionalJump):
(JSC::CodeBlock::printGetByIdOp):
(JSC::CodeBlock::printPutByIdOp):
(JSC::printGlobalResolveInfo):
(JSC::printStructureStubInfo):
(JSC::CodeBlock::printStructure):
(JSC::CodeBlock::printStructures):
(JSC::CodeBlock::dump):

  • jsc.cpp:

(functionPrint):
(functionDebug):
(runInteractive):
(fillBufferWithContentsOfFile):

  • profiler/CallIdentifier.h:

(JSC::CallIdentifier::c_str):

  • profiler/Profile.cpp:

(JSC::Profile::debugPrintDataSampleStyle):

  • profiler/ProfileNode.cpp:

(JSC::ProfileNode::debugPrintData):
(JSC::ProfileNode::debugPrintDataSampleStyle):

  • runtime/DateConversion.cpp:

(JSC::parseDate):

  • runtime/JSGlobalObjectFunctions.cpp:

(JSC::encode):
(JSC::globalFuncJSCPrint):

  • runtime/UString.cpp:

(JSC::operator==):
(JSC::UString::toDouble):

  • runtime/UString.h:

(JSC::CString::length):
(JSC::CString::data):

WebCore:

  • bridge/NP_jsobject.cpp:

(_NPN_Enumerate):

  • bridge/c/c_utility.cpp:

(JSC::Bindings::convertValueToNPVariant):

  • bridge/jni/jsc/JNIBridgeJSC.cpp:

(JavaField::valueFromInstance):
(JavaField::setValueToInstance):

  • bridge/jni/jsc/JavaInstanceJSC.cpp:

(JavaInstance::invokeMethod):

  • bridge/jni/jsc/JavaStringJSC.h:

(JSC::Bindings::JavaStringImpl::UTF8String):

11:03 AM Changeset in webkit [56559] by jwieczorek@webkit.org
  • 7 edits in trunk/LayoutTests

2010-03-25 Jakub Wieczorek <​jwieczorek@webkit.org>

Rubber-stamped by Tor Arne Vestbø.

[Qt] Update test results after r56555.
​https://bugs.webkit.org/show_bug.cgi?id=36413

  • platform/qt/fast/forms/basic-inputs-expected.txt:
  • platform/qt/fast/forms/isindex-placeholder-expected.txt:
  • platform/qt/fast/forms/text-style-color-expected.txt:
  • platform/qt/fast/forms/textarea-placeholder-pseudo-style-expected.txt:
  • platform/qt/fast/forms/textarea-placeholder-set-attribute-expected.txt:
  • platform/qt/fast/forms/textarea-placeholder-set-value-expected.txt:
11:00 AM Changeset in webkit [56558] by ap@apple.com
  • 2 edits in trunk/WebKit/mac

Reviewed by Mark Rowe.

Correctness fix after r56493.

  • Plugins/Hosted/NetscapePluginHostProxy.mm: (WKPCRunSyncOpenPanel): We still need to update our hostProxy reference, even though we didn't use to have instanceProxy. Nothing guarantees that the host proxy won't go away while the open panel is up.
10:51 AM Changeset in webkit [56557] by tonikitoo@webkit.org
  • 2 edits in trunk/LayoutTests

2010-03-25 Antonio Gomes <​tonikitoo@webkit.org>

Unreview expectation result fix.

After ​http://trac.webkit.org/changeset/56547, the test needs new (and proper)
results.

  • platform/mac/fast/frames/flattening/frameset-flattening-grid-expected.txt:
10:39 AM Changeset in webkit [56556] by Joseph Pecoraro
  • 2 edits in trunk/WebKitSite

2010-03-25 Joseph Pecoraro <Joseph Pecoraro>

Reviewed by David Levin.

Asking Questions Page Grammar Fixes
​https://bugs.webkit.org/show_bug.cgi?id=36608

  • asking_questions.html:
10:30 AM Changeset in webkit [56555] by jwieczorek@webkit.org
  • 6 edits in trunk

2010-03-25 Jakub Wieczorek <​jwieczorek@webkit.org>

Reviewed by Eric Seidel.

[Qt] RenderTheme: fix size adjustment for text fields
​https://bugs.webkit.org/show_bug.cgi?id=36413

Update test results after RenderTheme changes.

  • platform/qt/fast/forms/textarea-placeholder-pseudo-style-expected.txt:
  • platform/qt/fast/forms/textarea-placeholder-set-attribute-expected.txt:
  • platform/qt/fast/forms/textarea-placeholder-set-value-expected.txt:

2010-03-25 Jakub Wieczorek <​jwieczorek@webkit.org>

Reviewed by Eric Seidel.

[Qt] RenderTheme: fix size adjustment for text fields
​https://bugs.webkit.org/show_bug.cgi?id=36413

To match other ports, remove the hardcoded dimensions for text fields so that
the default ones from WebCore can be used.
Properly apply the correct padding to text areas - this fixes their appearance
with the Oxygen style.

  • platform/qt/RenderThemeQt.cpp: (WebCore::RenderThemeQt::computeSizeBasedOnStyle):
10:21 AM Changeset in webkit [56554] by abarth@webkit.org
  • 4 edits in trunk/WebKitTools

2010-03-25 Adam Barth <​abarth@webkit.org>

Rubber stamped by Eric Seidel.

Tweaks to sheriffbot to improve latency by keeping the working copy up
to date even when there's no build break. Also, officially move
sheriffbot to #webkit.

(Also teach ValidateReviewer to understand rubber stamps.)

  • Scripts/webkitpy/common/net/irc/ircbot.py:
  • Scripts/webkitpy/tool/commands/sheriffbot.py:
  • Scripts/webkitpy/tool/steps/validatereviewer.py:
10:18 AM Changeset in webkit [56553] by tonikitoo@webkit.org
  • 4 edits in trunk/WebKitTools

Not displaying FPS info on the terminal. On S60 and Maemo the Window title will be used and Status bar will used on desktop.

Reviewed by Simon Hausmann.
Patch by Jesus Palencia <​jesus.palencia@openbossa.org>

[Qt] QtLauncher's FPS info should not be displayed on the terminal
​https://bugs.webkit.org/show_bug.cgi?id=36244

  • QtLauncher/main.cpp:

(LauncherWindow::initializeView):
(LauncherWindow::showFPS):
(LauncherWindow::updateFPS):

  • QtLauncher/webview.cpp:

(WebViewGraphicsBased::setFrameRateMeasurementEnabled):
(WebViewGraphicsBased::updateFrameRate):

  • QtLauncher/webview.h:

(WebViewGraphicsBased::frameRateMeasurementEnabled):

9:42 AM Changeset in webkit [56552] by vestbo@webkit.org
  • 6 edits in trunk

[Qt] Implement ChromeClient::windowResizerRect()

Reviewed by Simon Hausmann.

​https://bugs.webkit.org/show_bug.cgi?id=21300

We assume the resize corner to be in the lower right corner of
the window and having the width and height of the scrollbars.

The helper function geometryRelativeToOwnerWidget() in the page
client is used to clip the resize rect to the actual size of the
viewport, not the size of the QGraphicsView.

9:31 AM Changeset in webkit [56551] by Joseph Pecoraro
  • 2 edits in trunk/WebKitSite

2010-03-25 Joseph Pecoraro <Joseph Pecoraro>

Reviewed by Timothy Hatcher.

New Asking Questions Page is not Valid HTML5
​https://bugs.webkit.org/show_bug.cgi?id=36605

  • asking_questions.html: fixed issues raised by the validator.
9:18 AM Changeset in webkit [56550] by jchaffraix@webkit.org
  • 4 edits in trunk/LayoutTests

[Qt][GTK] http/tests/xmlhttprequest/xmlhttprequest-onProgress-open-should-zero-length.html
fails after r56394
​https://bugs.webkit.org/show_bug.cgi?id=36531

Reviewed by Alexey Proskuryakov.

The test was assuming that we would receive 3 progress events which may not be the case anymore
due to the event throttling added in r56394.

  • http/tests/xmlhttprequest/xmlhttprequest-onProgress-open-should-zero-length.html: Removed

the counting as it belonged to the original version of the test and instead use the position
to determine when to reset the XHR.

  • platform/gtk/Skipped:
  • platform/qt/Skipped:

Removed the test from the Skipped lists now that it should pass.

9:09 AM Changeset in webkit [56549] by Joseph Pecoraro
  • 2 edits in trunk/WebCore

2010-03-25 Joseph Pecoraro <Joseph Pecoraro>

Reviewed by Pavel Feldman.

Web Inspector: reloading debug target window with cmd-R from inspector window produces beep.
​https://bugs.webkit.org/show_bug.cgi?id=36554

  • inspector/front-end/inspector.js: (WebInspector.documentKeyDown): prevent the default behavior, if handled, which would result in a system beep.
8:49 AM QtWebKitBackportingFixes edited by Simon Hausmann
(diff)
8:25 AM Changeset in webkit [56548] by eric@webkit.org
  • 7 edits in trunk

2010-03-25 Jochen Eisinger <​jochen@chromium.org>

Reviewed by Jeremy Orlow.

Forward DatabaseTracker::canEstablishDatabase to chromium layer.
​https://bugs.webkit.org/show_bug.cgi?id=36595

  • storage/chromium/DatabaseObserver.h:
  • storage/chromium/DatabaseTrackerChromium.cpp: (WebCore::DatabaseTracker::canEstablishDatabase):

2010-03-25 Jochen Eisinger <​jochen@chromium.org>

Reviewed by Jeremy Orlow.

Forward DatabaseTracker::canEstablishDatabase to chromium layer.
​https://bugs.webkit.org/show_bug.cgi?id=36595

  • public/WebFrameClient.h: (WebKit::WebFrameClient::allowDatabase):
  • src/DatabaseObserver.cpp: (WebCore::DatabaseObserver::canEstablishDatabase):
  • src/WebWorkerBase.h: (WebKit::WebWorkerBase::allowDatabase):
8:24 AM Changeset in webkit [56547] by tonikitoo@webkit.org
  • 5 edits in trunk

Added missing frame flattening activation on fast/frames/flattening/frameset-flattening-grid.html; removed unnecessary CONSOLE MESSAGE from the expected file; reset the setFrameSetFlatteningEnabled for each test.

Reviewed by Kenneth Christiansen.
Patch by Diego Gonzalez <​diego.gonzalez@openbossa.org>

WebKitTools:

  • DumpRenderTree/qt/DumpRenderTreeQt.cpp:

(WebCore::WebPage::resetSettings):

LayoutTests:

  • fast/frames/flattening/frameset-flattening-grid.html:
  • platform/qt/fast/frames/flattening/frameset-flattening-grid-expected.txt:
8:06 AM Changeset in webkit [56546] by eric@webkit.org
  • 4 edits in trunk/WebCore

2010-03-25 yael aharon <​yael.aharon@nokia.com>

Reviewed by Laszlo Gombos.

[Qt] Windowed netscape plugins don't work with QGraphicsWebView on Symbian
​https://bugs.webkit.org/show_bug.cgi?id=35112

Add a proxy widget when loading a QWidget based plugin in a QGraphicsWebView.

  • plugins/symbian/PluginContainerSymbian.cpp: (PluginContainerSymbian::PluginContainerSymbian): (PluginContainerSymbian::focusInEvent):
  • plugins/symbian/PluginContainerSymbian.h: (WebCore::PluginContainerSymbian::proxy):
  • plugins/symbian/PluginViewSymbian.cpp: (WebCore::PluginView::updatePluginWidget): (WebCore::PluginView::platformStart): (WebCore::PluginView::platformDestroy):
8:04 AM QtWebKitBackportingFixes edited by Simon Hausmann
(diff)
8:04 AM Changeset in webkit [56545] by Chris Jerdonek
  • 3 edits in trunk/WebKitTools

Moved deprecated_logging unit test import statement from
webkitpy/unittests.py to webkitpy/common/system/unittests.py.

Reviewed by Adam Barth.

​https://bugs.webkit.org/show_bug.cgi?id=36093

This is part of the master bug to reorganize webkitpy.

  • Scripts/webkitpy/common/system/unittests.py:
  • Scripts/webkitpy/unittests.py:
7:46 AM Changeset in webkit [56544] by Chris Jerdonek
  • 40 edits
    2 moves in trunk/WebKitTools

Moved webkit_logging.py to common/system/deprecated_logging.py
inside webkitpy.

Reviewed by Adam Barth.

​https://bugs.webkit.org/show_bug.cgi?id=36093

This is part of the master bug to reorganize webkitpy.

  • Scripts/validate-committer-lists:
  • Scripts/webkitpy/common/checkout/changelog.py:
  • Scripts/webkitpy/common/checkout/scm.py:
  • Scripts/webkitpy/common/net/bugzilla.py:
  • Scripts/webkitpy/common/net/buildbot.py:
  • Scripts/webkitpy/common/net/credentials.py:
  • Scripts/webkitpy/common/net/irc/ircproxy.py:
  • Scripts/webkitpy/common/net/networktransaction.py:
  • Scripts/webkitpy/common/net/statusserver.py:
  • Scripts/webkitpy/common/system/deprecated_logging.py: Copied from WebKitTools/Scripts/webkitpy/webkit_logging.py.
  • Scripts/webkitpy/common/system/deprecated_logging_unittest.py: Copied from WebKitTools/Scripts/webkitpy/webkit_logging_unittest.py.
  • Scripts/webkitpy/common/system/executive.py:
  • Scripts/webkitpy/tool/bot/queueengine.py:
  • Scripts/webkitpy/tool/commands/download.py:
  • Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
  • Scripts/webkitpy/tool/commands/openbugs.py:
  • Scripts/webkitpy/tool/commands/queries.py:
  • Scripts/webkitpy/tool/commands/queues.py:
  • Scripts/webkitpy/tool/commands/sheriffbot.py:
  • Scripts/webkitpy/tool/commands/stepsequence.py:
  • Scripts/webkitpy/tool/commands/upload.py:
  • Scripts/webkitpy/tool/main.py:
  • Scripts/webkitpy/tool/mocktool.py:
  • Scripts/webkitpy/tool/multicommandtool.py:
  • Scripts/webkitpy/tool/steps/abstractstep.py:
  • Scripts/webkitpy/tool/steps/applypatch.py:
  • Scripts/webkitpy/tool/steps/build.py:
  • Scripts/webkitpy/tool/steps/checkstyle.py:
  • Scripts/webkitpy/tool/steps/closebug.py:
  • Scripts/webkitpy/tool/steps/closebugforlanddiff.py:
  • Scripts/webkitpy/tool/steps/confirmdiff.py:
  • Scripts/webkitpy/tool/steps/ensurebuildersaregreen.py:
  • Scripts/webkitpy/tool/steps/ensurelocalcommitifneeded.py:
  • Scripts/webkitpy/tool/steps/obsoletepatches.py:
  • Scripts/webkitpy/tool/steps/preparechangelog.py:
  • Scripts/webkitpy/tool/steps/reopenbugafterrollout.py:
  • Scripts/webkitpy/tool/steps/runtests.py:
  • Scripts/webkitpy/tool/steps/update.py:
  • Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py:
  • Scripts/webkitpy/tool/steps/validatereviewer.py:
  • Scripts/webkitpy/unittests.py:
  • Scripts/webkitpy/webkit_logging.py: Removed.
  • Scripts/webkitpy/webkit_logging_unittest.py: Removed.
7:31 AM Changeset in webkit [56543] by Simon Fraser
  • 5 edits
    2 adds in trunk

2010-03-25 Simon Fraser <Simon Fraser>

Reviewed by Adele Peterson.

​https://bugs.webkit.org/show_bug.cgi?id=35714
Computed style on delayed transform animations is incorrect

When fetching computed style while a delayed accelerated animation is in effect,
we would get the value form the first keyframe, rather than getting the current
style.

Fix by checking to see whether we've in the delay phase (with no backwards-fill)
in KeyframeAnimation::getAnimatedStyle().

Test: compositing/animation/computed-style-during-delay.html

  • page/animation/KeyframeAnimation.cpp: (WebCore::KeyframeAnimation::getAnimatedStyle):
7:31 AM Changeset in webkit [56542] by Simon Fraser
  • 1 edit in trunk/JavaScriptCore/ChangeLog

Additional refptr/passrefptr workarounds for WINSCW compiler

​https://bugs.webkit.org/show_bug.cgi?id=28054

Patch by Janne Koskinen <​janne.p.koskinen@digia.com> on 2010-02-12

Reviewed by Tor Arne Vestbø.

  • wtf/PassRefPtr.h:

(WTF::refIfNotNull):
(WTF::PassRefPtr::PassRefPtr):
(WTF::PassRefPtr::~PassRefPtr):
(WTF::PassRefPtr::clear):
(WTF::::operator):

  • wtf/RefPtr.h:

(WTF::RefPtr::RefPtr):
(WTF::::operator):

7:27 AM Changeset in webkit [56541] by jchaffraix@webkit.org
  • 2 edits
    1 add in trunk/WebKitSite

Add a page on how to ask questions
​https://bugs.webkit.org/show_bug.cgi?id=35223

Reviewed by David Levin.

  • asking_questions.html: Added.

Add a page on how to ask questions based on Ariya Hidayat's mail: how
to get help effectively
(​http://article.gmane.org/gmane.os.opendarwin.webkit.user/145/match=get+help+effectively)

  • contact.html: Tweaked the wording to make it more clear what the

mailing list are used for. Also changed the formatting to better
underline the different mailing lists.

7:14 AM PythonGuidelines edited by Chris Jerdonek
Added note on cleaning *.pyc files. (diff)
7:13 AM Changeset in webkit [56540] by jchaffraix@webkit.org
  • 2 edits in trunk/WebKitTools

commit-log-editor can call itself in an infinite loop
​https://bugs.webkit.org/show_bug.cgi?id=35291

Reviewed by Kenneth Rohde Christiansen.

if $editor ends up being commit-log-editor, the script will exec itself
in an infinite loop.

To avoid this, we now check that the $editor variable is not
commit-log-editor to avoid this case.

  • Scripts/commit-log-editor: Added an isCommitLogEditor method and

reworked the $editor setting to add this check.

7:04 AM Changeset in webkit [56539] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2010-03-25 Jesus Sanchez-Palencia <​jesus.palencia@openbossa.org>

Reviewed by Kenneth Rohde Christiansen.

Add a Toggle Frame Flattening option to QtLauncher.
It will be enabled by default on Maemo5 and S60 platforms.

[Qt] Add enable/disable Frame Flattening option to QtLauncher
​https://bugs.webkit.org/show_bug.cgi?id=36558

  • QtLauncher/main.cpp: (LauncherWindow::applyPrefs): (LauncherWindow::toggleFrameFlattening): (LauncherWindow::createChrome):
6:45 AM Changeset in webkit [56538] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-03-25 Yury Semikhatsky <​yurys@chromium.org>

Reviewed by Pavel Feldman.

Initialize Web Inspector title with inspected page URL when opening Web Inspector.

​https://bugs.webkit.org/show_bug.cgi?id=36534

  • inspector/InspectorController.cpp: (WebCore::InspectorController::setFrontend):
6:43 AM Changeset in webkit [56537] by chang.shu@nokia.com
  • 2 edits in trunk/WebKit/qt

2010-03-25 Shu Chang <​chang.shu@nokia.com>

Reviewed by Simon Hausmann.

[Qt] Added documentation for delete button.
​https://bugs.webkit.org/show_bug.cgi?id=31560

  • Api/qwebsettings.cpp:
6:21 AM Changeset in webkit [56536] by eric@webkit.org
  • 2 edits in trunk/WebKit/qt

2010-03-25 Tasuku Suzuki <​tasuku.suzuki@nokia.com>

Reviewed by Eric Seidel.

[Qt]Fix compile error with QT_NO_DESKTOPSERVICES
​https://bugs.webkit.org/show_bug.cgi?id=36533

  • Api/qwebsettings.cpp: (QWebSettings::enablePersistentStorage):
6:02 AM Changeset in webkit [56535] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-03-25 Antti Koivisto <​koivisto@iki.fi>

Reviewed by Kenneth Rohde Christiansen.

​https://bugs.webkit.org/show_bug.cgi?id=36316
Tiles of selected content do not update if not in viewport

Don't clip repaints to viewport when tiling is enabled.

  • page/Frame.cpp: (WebCore::Frame::setView): (WebCore::Frame::setTiledBackingStoreEnabled):
5:43 AM Changeset in webkit [56534] by eric@webkit.org
  • 4 edits in trunk

2010-03-25 Diego Gonzalez <​diego.gonzalez@openbossa.org>

Reviewed by Eric Seidel.

Missing forward ENABLE_DATALIST macro to JavaScript enabled features macros
on WebKit.pri

[Qt] Forward ENABLE_DATALIST macro to JavaScript enabled macros
​https://bugs.webkit.org/show_bug.cgi?id=36547

  • platform/qt/Skipped:

2010-03-25 Diego Gonzalez <​diego.gonzalez@openbossa.org>

Reviewed by Eric Seidel.

Missing forward ENABLE_DATALIST macro to JavaScript enabled features macros
on WebKit.pri

[Qt] Forward ENABLE_DATALIST macro to JavaScript enabled macros
​https://bugs.webkit.org/show_bug.cgi?id=36547

  • WebCore.pri:
5:22 AM Changeset in webkit [56533] by eric@webkit.org
  • 2 edits in trunk/WebKit/qt

2010-03-25 Tasuku Suzuki <​tasuku.suzuki@nokia.com>

Reviewed by Eric Seidel.

[Qt]Fix compile error with QT_NO_DEBUG_STREAM
​https://bugs.webkit.org/show_bug.cgi?id=36533

  • Api/qgraphicswebview.cpp: (QGraphicsWebViewPrivate::graphicsItemVisibleRect):
5:19 AM Changeset in webkit [56532] by pfeldman@chromium.org
  • 3 edits in trunk/WebCore

2010-03-25 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: Expect console object wrapping to fail.

​https://bugs.webkit.org/show_bug.cgi?id=36587

  • inspector/front-end/InjectedScript.js: (injectedScriptConstructor):
5:03 AM Changeset in webkit [56531] by eric@webkit.org
  • 4 edits in trunk/WebKit/gtk

2010-03-25 Sergio Villar Senín <​svillar@igalia.com>

Reviewed by Xan Lopez.

Added new API webkit_web_back_forward_list_clear. This function
clears the back forward list

[GTK] http/history tests are failing
​https://bugs.webkit.org/show_bug.cgi?id=36173

  • tests/testwebbackforwardlist.c: (test_webkit_web_back_forward_list_clear): (main): added new unit test for the new API
  • webkit/webkitwebbackforwardlist.cpp: (webkit_web_back_forward_list_clear):
  • webkit/webkitwebbackforwardlist.h: new function that clears the back forward list
4:44 AM Changeset in webkit [56530] by eric@webkit.org
  • 3 edits
    2 adds in trunk

2010-03-25 Joanmarie Diggs <​joanmarie.diggs@gmail.com>

Reviewed by Eric Seidel.

​https://bugs.webkit.org/show_bug.cgi?id=36371
[Gtk] Elements with a title attribute should not be ignored

  • platform/gtk/accessibility/object-with-title.html: Added
  • platform/gtk/accessibility/object-with-title-expected.txt: Added

2010-03-25 Joanmarie Diggs <​joanmarie.diggs@gmail.com>

Reviewed by Eric Seidel.

​https://bugs.webkit.org/show_bug.cgi?id=36371
[Gtk] Elements with a title attribute should not be ignored

  • accessibility/AccessibilityRenderObject.cpp: (AccessibilityRenderObject::accessibilityIsIgnored):
4:23 AM Changeset in webkit [56529] by eric@webkit.org
  • 2 edits in trunk/WebKit/qt

2010-03-25 Kenneth Rohde Christiansen <​kenneth@webkit.org>

Reviewed by Eric Seidel.

Make QWebPage not depend on view() but use the client->ownerWidget()
instead. Also, handle the case where there is not page client.

  • Api/qwebpage.cpp: (QWebPagePrivate::createContextMenu): (QWebPagePrivate::keyPressEvent): (QWebPage::javaScriptAlert): (QWebPage::javaScriptConfirm): (QWebPage::javaScriptPrompt): (QWebPage::shouldInterruptJavaScript): (QWebPage::createWindow): (QWebPage::action): (QWebPage::extension): (QWebPage::chooseFile): (QWebPage::userAgentForUrl):
4:20 AM Changeset in webkit [56528] by jocelyn.turcotte@nokia.com
  • 2 edits in trunk/JavaScriptCore

[Qt] Build fix on MSVC. Reverts r55633 for stdint.h

Reviewed by nobody, build fix.

This file gets included in generated moc files which don't
include the prefix header.

  • os-win32/stdint.h:
3:43 AM PythonGuidelines edited by Chris Jerdonek
Added note about *.pyc files (diff)
3:40 AM Changeset in webkit [56527] by steveblock@google.com
  • 2 edits in trunk/WebCore

2010-03-24 Steve Block <​steveblock@google.com>

Reviewed by David Levin.

Adds a missing ENABLE(WORKERS) guards to the V8 bindings.
​https://bugs.webkit.org/show_bug.cgi?id=36550

Build fix only, no new tests.

  • bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::instantiateV8Object):
3:33 AM Changeset in webkit [56526] by eric@webkit.org
  • 3 edits in trunk/WebCore

2010-03-25 Leandro Pereira <​leandro@profusion.mobi>

Reviewed by Eric Seidel.

Add EFL-specific code to platform/ScrollView.cpp and
platform/Scrollbar.cpp.
​http://webkit.org/b/36305

  • platform/ScrollView.cpp:
  • platform/Scrollbar.cpp:
3:30 AM PythonGuidelines edited by Chris Jerdonek
Added Basics and Code Structure sub-sections (diff)
3:12 AM Changeset in webkit [56525] by eric@webkit.org
  • 3 edits in trunk/WebCore

2010-03-25 Tasuku Suzuki <​tasuku.suzuki@nokia.com>

Reviewed by Eric Seidel.

[Qt]Fix compile error with QT_NO_LIBRARY
​https://bugs.webkit.org/show_bug.cgi?id=36533

  • platform/FileSystem.h:
  • platform/qt/FileSystemQt.cpp: (WebCore::unloadModule):
2:46 AM Changeset in webkit [56524] by zoltan@webkit.org
  • 2 edits in trunk/WebKitTools

2010-03-25 Zoltan Horvath <​zoltan@webkit.org>

Reviewed by Eric Seidel.

svn-create-patch prints a warning for large patches
​https://bugs.webkit.org/show_bug.cgi?id=32582

svn-create-patch prints a warning message for larger patches than 20k.

  • Scripts/svn-create-patch:
2:40 AM Changeset in webkit [56523] by eric@webkit.org
  • 3 edits in trunk/WebCore

2010-03-25 Tasuku Suzuki <​tasuku.suzuki@nokia.com>

Reviewed by Eric Seidel.

[Qt]Fix compile error with QT_NO_ANIMATION
​https://bugs.webkit.org/show_bug.cgi?id=36526

  • platform/graphics/qt/GraphicsLayerQt.cpp: (WebCore::GraphicsLayerQtImpl::~GraphicsLayerQtImpl):
  • platform/graphics/qt/GraphicsLayerQt.h:
2:32 AM Changeset in webkit [56522] by abarth@webkit.org
  • 3 edits
    2 moves in trunk/WebKitTools

2010-03-25 Adam Barth <​abarth@webkit.org>

Unreviewed. Renamed early_warning_system.py to earlywarningsystem.py.
​https://bugs.webkit.org/show_bug.cgi?id=36093

  • Scripts/webkitpy/tool/commands/early_warning_system.py: Removed.
  • Scripts/webkitpy/tool/commands/early_warning_system_unittest.py: Removed.
  • Scripts/webkitpy/tool/commands/earlywarningsystem.py: Copied from Scripts/webkitpy/tool/commands/early_warning_system.py.
  • Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py: Copied from Scripts/webkitpy/tool/commands/early_warning_system_unittest.py.
  • Scripts/webkitpy/tool/main.py:
  • Scripts/webkitpy/tool/unittests.py:
2:30 AM Changeset in webkit [56521] by Chris Jerdonek
  • 3 edits
    2 copies
    1 add in trunk/WebKitTools

In webkitpy, pushed the unit test import statements in
webkitpy/unittests.py into appropriate unittests.py files in the
new root-level packages beneath webkitpy.

Reviewed by Adam Barth.

​https://bugs.webkit.org/show_bug.cgi?id=36093

This is part of the master bug to reorganize webkitpy.

  • Scripts/webkitpy/common/system/unittests.py:
  • Scripts/webkitpy/common/unittests.py: Added.
  • Scripts/webkitpy/python24/unittests.py: Added.
  • Scripts/webkitpy/tool/unittests.py: Added.
  • Scripts/webkitpy/unittests.py:
2:17 AM Changeset in webkit [56520] by abarth@webkit.org
  • 3 edits
    1 move in trunk/WebKitTools

2010-03-25 Adam Barth <​abarth@webkit.org>

Unreviewed. Move WebKitCheckout into the webkitpy.common.checkout
package.
​https://bugs.webkit.org/show_bug.cgi?id=36093

  • Scripts/webkitpy/common/checkout/api.py: Copied from Scripts/webkitpy/webkitcheckout.py.
  • Scripts/webkitpy/tool/main.py:
  • Scripts/webkitpy/tool/mocktool.py:
  • Scripts/webkitpy/webkitcheckout.py: Removed.
2:11 AM Changeset in webkit [56519] by abarth@webkit.org
  • 10 edits
    1 move in trunk/WebKitTools

2010-03-25 Adam Barth <​abarth@webkit.org>

Unreviewed. Move OutputCapture to webkitpy.common.system.
​https://bugs.webkit.org/show_bug.cgi?id=36093

  • Scripts/webkitpy/common/net/bugzilla_unittest.py:
  • Scripts/webkitpy/common/net/credentials_unittest.py:
  • Scripts/webkitpy/common/system/outputcapture.py: Copied from Scripts/webkitpy/outputcapture.py.
  • Scripts/webkitpy/outputcapture.py: Removed.
  • Scripts/webkitpy/tool/commands/commandtest.py:
  • Scripts/webkitpy/tool/commands/queues_unittest.py:
  • Scripts/webkitpy/tool/commands/queuestest.py:
  • Scripts/webkitpy/tool/multicommandtool_unittest.py:
  • Scripts/webkitpy/tool/steps/closebugforlanddiff_unittest.py:
  • Scripts/webkitpy/tool/steps/steps_unittest.py:
  • Scripts/webkitpy/tool/steps/updatechangelogswithreview_unittests.py:
2:05 AM Changeset in webkit [56518] by abarth@webkit.org
  • 7 edits
    2 moves in trunk/WebKitTools

2010-03-25 Adam Barth <​abarth@webkit.org>

Unreviewed. Move user.py to webkitpy.common.system.

  • Scripts/webkitpy/common/checkout/scm.py:
  • Scripts/webkitpy/common/net/bugzilla.py:
  • Scripts/webkitpy/common/net/credentials.py:
  • Scripts/webkitpy/common/system/user.py: Copied from Scripts/webkitpy/user.py.
  • Scripts/webkitpy/common/system/user_unittest.py: Copied from Scripts/webkitpy/user_unittest.py.
  • Scripts/webkitpy/tool/commands/upload.py:
  • Scripts/webkitpy/tool/main.py:
  • Scripts/webkitpy/unittests.py:
  • Scripts/webkitpy/user.py: Removed.
  • Scripts/webkitpy/user_unittest.py: Removed.
2:01 AM Changeset in webkit [56517] by abarth@webkit.org
  • 19 edits
    2 moves in trunk/WebKitTools

2010-03-25 Adam Barth <​abarth@webkit.org>

Unreviewed. Move executive.py to webkitpy.common.system.
​https://bugs.webkit.org/show_bug.cgi?id=36093

  • Scripts/webkitpy/common/checkout/scm.py:
  • Scripts/webkitpy/common/checkout/scm_unittest.py:
  • Scripts/webkitpy/common/config/ports.py:
  • Scripts/webkitpy/common/config/ports_unittest.py:
  • Scripts/webkitpy/common/net/credentials.py:
  • Scripts/webkitpy/common/net/credentials_unittest.py:
  • Scripts/webkitpy/common/system/executive.py: Copied from Scripts/webkitpy/executive.py.
  • Scripts/webkitpy/common/system/executive_unittest.py: Copied from Scripts/webkitpy/executive_unittest.py.
  • Scripts/webkitpy/executive.py: Removed.
  • Scripts/webkitpy/executive_unittest.py: Removed.
  • Scripts/webkitpy/layout_tests/port/mac.py:
  • Scripts/webkitpy/tool/bot/queueengine.py:
  • Scripts/webkitpy/tool/bot/queueengine_unittest.py:
  • Scripts/webkitpy/tool/commands/download.py:
  • Scripts/webkitpy/tool/commands/early_warning_system.py:
  • Scripts/webkitpy/tool/commands/queues.py:
  • Scripts/webkitpy/tool/commands/stepsequence.py:
  • Scripts/webkitpy/tool/main.py:
  • Scripts/webkitpy/tool/steps/checkstyle.py:
  • Scripts/webkitpy/tool/steps/preparechangelog.py:
  • Scripts/webkitpy/unittests.py:
  • Scripts/webkitpy/webkit_logging_unittest.py:
1:50 AM Changeset in webkit [56516] by abarth@webkit.org
  • 9 edits
    2 moves in trunk/WebKitTools

2010-03-25 Adam Barth <​abarth@webkit.org>

Unreviewed. Move grammary.py into webkitpy.tool.
​https://bugs.webkit.org/show_bug.cgi?id=36093

  • Scripts/webkitpy/grammar.py: Removed.
  • Scripts/webkitpy/grammar_unittest.py: Removed.
  • Scripts/webkitpy/tool/commands/download.py:
  • Scripts/webkitpy/tool/commands/queries.py:
  • Scripts/webkitpy/tool/commands/queues.py:
  • Scripts/webkitpy/tool/commands/upload.py:
  • Scripts/webkitpy/tool/grammar.py: Copied from Scripts/webkitpy/grammar.py.
  • Scripts/webkitpy/tool/grammar_unittest.py: Copied from Scripts/webkitpy/grammar_unittest.py.
  • Scripts/webkitpy/tool/multicommandtool.py:
  • Scripts/webkitpy/tool/steps/obsoletepatches.py:
  • Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py:
  • Scripts/webkitpy/unittests.py:
1:49 AM Changeset in webkit [56515] by jam@chromium.org
  • 2 edits in trunk/WebKit/chromium

2010-03-10 John Abd-El-Malek <​jam@chromium.org>

Reviewed by Darin Fisher.

[chromium] Fix up WebMouseWheelEventBuilder to properly calculate the units
​https://bugs.webkit.org/show_bug.cgi?id=35989

  • src/WebInputEventConversion.cpp:
1:48 AM Changeset in webkit [56514] by Chris Jerdonek
  • 6 edits
    1 move in trunk/WebKitTools

In webkitpy, moved init/ to common/system/.

Reviewed by Adam Barth.

​https://bugs.webkit.org/show_bug.cgi?id=36093

This is part of the master bug to reorganize webkitpy.

  • Scripts/webkitpy/common/system: Copied from WebKitTools/Scripts/webkitpy/init.
  • Scripts/webkitpy/common/system/logutils.py:
  • Scripts/webkitpy/common/system/logutils_unittest.py:
  • Scripts/webkitpy/init: Removed.
  • Scripts/webkitpy/init/init.py: Removed.
  • Scripts/webkitpy/init/logtesting.py: Removed.
  • Scripts/webkitpy/init/logutils.py: Removed.
  • Scripts/webkitpy/init/logutils_unittest.py: Removed.
  • Scripts/webkitpy/init/unittests.py: Removed.
  • Scripts/webkitpy/python24/versioning_unittest.py:
  • Scripts/webkitpy/style_references.py:
  • Scripts/webkitpy/unittests.py:
1:46 AM Changeset in webkit [56513] by tony@chromium.org
  • 2 edits in trunk/WebCore

2010-03-25 Tony Chang <​tony@chromium.org>

Reviewed by Eric Seidel.

​https://bugs.webkit.org/show_bug.cgi?id=33697
Have dragOpFromIEOp("move") return DragOperationGeneric | DragOperationMove
because only returning Generic doesn't work for platforms that don't
have a generic operation.

Covered by existing tests (fast/events/drag-and-drop.html).

  • dom/Clipboard.cpp: (WebCore::dragOpFromIEOp): (WebCore::Clipboard::destinationOperation): (WebCore::Clipboard::setDestinationOperation):
1:42 AM Changeset in webkit [56512] by abarth@webkit.org
  • 4 edits
    1 move in trunk/WebKitTools

2010-03-25 Adam Barth <​abarth@webkit.org>

Unreviewed. Move stepsequence to webkitpy.tool.commands.
​https://bugs.webkit.org/show_bug.cgi?id=36093

  • Scripts/webkitpy/stepsequence.py: Removed.
  • Scripts/webkitpy/tool/commands/abstractsequencedcommand.py:
  • Scripts/webkitpy/tool/commands/download.py:
  • Scripts/webkitpy/tool/commands/queues.py:
  • Scripts/webkitpy/tool/commands/stepsequence.py: Copied from Scripts/webkitpy/stepsequence.py.
1:38 AM Changeset in webkit [56511] by ukai@chromium.org
  • 4 edits in trunk

2010-03-25 Fumitoshi Ukai <​ukai@chromium.org>

Reviewed by Eric Seidel.

[Qt] websocket/tests/long-invalid-header.html fails
​https://bugs.webkit.org/show_bug.cgi?id=36492

  • websocket/tests/long-invalid-header-expected.txt: trim console message.

2010-03-25 Fumitoshi Ukai <​ukai@chromium.org>

Reviewed by Eric Seidel.

[Qt] websocket/tests/long-invalid-header.html fails
​https://bugs.webkit.org/show_bug.cgi?id=36492

trim message at most 128 bytes from the current position.
I believe it's enough data to investigate the error reason and
it makes test not depend on buffered size.

  • websockets/WebSocketHandshake.cpp: (WebCore::trimConsoleMessage): (WebCore::WebSocketHandshake::readServerHandshake): (WebCore::WebSocketHandshake::readHTTPHeaders):
1:34 AM Changeset in webkit [56510] by abarth@webkit.org
  • 15 edits
    1 copy
    8 moves
    1 add in trunk/WebKitTools

2010-03-25 Adam Barth <​abarth@webkit.org>

Unreviewed. Create webkitpy.common.checkout as described in
​https://bugs.webkit.org/show_bug.cgi?id=36093

  • Scripts/webkitpy/changelogs.py: Removed.
  • Scripts/webkitpy/changelogs_unittest.py: Removed.
  • Scripts/webkitpy/commitinfo.py: Removed.
  • Scripts/webkitpy/commitinfo_unittest.py: Removed.
  • Scripts/webkitpy/common/checkout: Added.
  • Scripts/webkitpy/common/checkout/init.py: Copied from Scripts/webkitpy/common/init.py.
  • Scripts/webkitpy/common/checkout/changelog.py: Copied from Scripts/webkitpy/changelogs.py.
  • Scripts/webkitpy/common/checkout/changelog_unittest.py: Copied from Scripts/webkitpy/changelogs_unittest.py.
  • Scripts/webkitpy/common/checkout/commitinfo.py: Copied from Scripts/webkitpy/commitinfo.py.
  • Scripts/webkitpy/common/checkout/commitinfo_unittest.py: Copied from Scripts/webkitpy/commitinfo_unittest.py.
  • Scripts/webkitpy/common/checkout/diff_parser.py: Copied from Scripts/webkitpy/diff_parser.py.
  • Scripts/webkitpy/common/checkout/diff_parser_unittest.py: Copied from Scripts/webkitpy/diff_parser_unittest.py.
  • Scripts/webkitpy/common/checkout/scm.py: Copied from Scripts/webkitpy/scm.py.
  • Scripts/webkitpy/common/checkout/scm_unittest.py: Copied from Scripts/webkitpy/scm_unittest.py.
  • Scripts/webkitpy/common/net/credentials.py:
  • Scripts/webkitpy/diff_parser.py: Removed.
  • Scripts/webkitpy/diff_parser_unittest.py: Removed.
  • Scripts/webkitpy/layout_tests/port/base.py:
  • Scripts/webkitpy/scm.py: Removed.
  • Scripts/webkitpy/scm_unittest.py: Removed.
  • Scripts/webkitpy/stepsequence.py:
  • Scripts/webkitpy/style_references.py:
  • Scripts/webkitpy/tool/commands/download.py:
  • Scripts/webkitpy/tool/commands/queries.py:
  • Scripts/webkitpy/tool/comments.py:
  • Scripts/webkitpy/tool/main.py:
  • Scripts/webkitpy/tool/mocktool.py:
  • Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
  • Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py:
  • Scripts/webkitpy/tool/steps/validatereviewer.py:
  • Scripts/webkitpy/unittests.py:
  • Scripts/webkitpy/webkitcheckout.py:
1:02 AM Changeset in webkit [56509] by Chris Jerdonek
  • 5 edits
    1 copy
    2 moves
    1 add in trunk/WebKitTools

In webkitpy, moved init/versioning.py to python24/.

Reviewed by Adam Barth.

​https://bugs.webkit.org/show_bug.cgi?id=36093

This is part of the master bug to reorganize webkitpy.

  • Scripts/test-webkitpy:
  • Scripts/webkit-patch:
  • Scripts/webkitpy/init/unittests.py:
  • Scripts/webkitpy/init/versioning.py: Removed.
  • Scripts/webkitpy/init/versioning_unittest.py: Removed.
  • Scripts/webkitpy/python24: Added.
  • Scripts/webkitpy/python24/init.py: Copied from WebKitTools/Scripts/webkitpy/tool/init.py.
  • Scripts/webkitpy/python24/versioning.py: Copied from WebKitTools/Scripts/webkitpy/init/versioning.py.
  • Scripts/webkitpy/python24/versioning_unittest.py: Copied from WebKitTools/Scripts/webkitpy/init/versioning_unittest.py.
  • Scripts/webkitpy/unittests.py:
12:52 AM Changeset in webkit [56508] by abarth@webkit.org
  • 20 edits
    10 moves
    2 adds in trunk/WebKitTools

2010-03-25 Adam Barth <​abarth@webkit.org>

Unreviewed.

Create webkitpy.common.net as described in
​https://bugs.webkit.org/show_bug.cgi?id=36093

  • Scripts/webkitpy/bugzilla.py: Removed.
  • Scripts/webkitpy/bugzilla_unittest.py: Removed.
  • Scripts/webkitpy/buildbot.py: Removed.
  • Scripts/webkitpy/buildbot_unittest.py: Removed.
  • Scripts/webkitpy/commitinfo.py:
  • Scripts/webkitpy/common/net: Added.
  • Scripts/webkitpy/common/net/init.py: Added.
  • Scripts/webkitpy/common/net/bugzilla.py: Copied from Scripts/webkitpy/bugzilla.py.
  • Scripts/webkitpy/common/net/bugzilla_unittest.py: Copied from Scripts/webkitpy/bugzilla_unittest.py.
  • Scripts/webkitpy/common/net/buildbot.py: Copied from Scripts/webkitpy/buildbot.py.
  • Scripts/webkitpy/common/net/buildbot_unittest.py: Copied from Scripts/webkitpy/buildbot_unittest.py.
  • Scripts/webkitpy/common/net/credentials.py: Copied from Scripts/webkitpy/credentials.py.
  • Scripts/webkitpy/common/net/credentials_unittest.py: Copied from Scripts/webkitpy/credentials_unittest.py.
  • Scripts/webkitpy/common/net/irc: Copied from Scripts/webkitpy/irc.
  • Scripts/webkitpy/common/net/irc/ircbot.py:
  • Scripts/webkitpy/common/net/irc/ircproxy.py:
  • Scripts/webkitpy/common/net/irc/messagepump_unittest.py:
  • Scripts/webkitpy/common/net/irc/threadedmessagequeue_unittest.py:
  • Scripts/webkitpy/common/net/irc/unittests.py:
  • Scripts/webkitpy/common/net/networktransaction.py: Copied from Scripts/webkitpy/networktransaction.py.
  • Scripts/webkitpy/common/net/networktransaction_unittest.py: Copied from Scripts/webkitpy/networktransaction_unittest.py.
  • Scripts/webkitpy/common/net/statusserver.py: Copied from Scripts/webkitpy/statusserver.py.
  • Scripts/webkitpy/credentials.py: Removed.
  • Scripts/webkitpy/credentials_unittest.py: Removed.
  • Scripts/webkitpy/irc: Removed.
  • Scripts/webkitpy/irc/init.py: Removed.
  • Scripts/webkitpy/irc/ircbot.py: Removed.
  • Scripts/webkitpy/irc/ircproxy.py: Removed.
  • Scripts/webkitpy/irc/messagepump.py: Removed.
  • Scripts/webkitpy/irc/messagepump_unittest.py: Removed.
  • Scripts/webkitpy/irc/threadedmessagequeue.py: Removed.
  • Scripts/webkitpy/irc/threadedmessagequeue_unittest.py: Removed.
  • Scripts/webkitpy/irc/unittests.py: Removed.
  • Scripts/webkitpy/networktransaction.py: Removed.
  • Scripts/webkitpy/networktransaction_unittest.py: Removed.
  • Scripts/webkitpy/scm_unittest.py:
  • Scripts/webkitpy/statusserver.py: Removed.
  • Scripts/webkitpy/tool/bot/queueengine.py:
  • Scripts/webkitpy/tool/commands/download.py:
  • Scripts/webkitpy/tool/commands/queries.py:
  • Scripts/webkitpy/tool/commands/queries_unittest.py:
  • Scripts/webkitpy/tool/commands/queues.py:
  • Scripts/webkitpy/tool/commands/queues_unittest.py:
  • Scripts/webkitpy/tool/commands/queuestest.py:
  • Scripts/webkitpy/tool/commands/upload.py:
  • Scripts/webkitpy/tool/main.py:
  • Scripts/webkitpy/tool/mocktool.py:
  • Scripts/webkitpy/tool/steps/postdiffforrevert.py:
  • Scripts/webkitpy/unittests.py:
12:37 AM Changeset in webkit [56507] by jhoneycutt@apple.com
  • 4 edits in trunk

<rdar://problem/7780798> Missing plug-ins should be represented by text
only, instead of lego block

​https://bugs.webkit.org/show_bug.cgi?id=36583

Reviewed by Dan Bernstein.

WebCore:

  • rendering/RenderEmbeddedObject.cpp:

(WebCore::RenderEmbeddedObject::paintReplaced):
Set the font rendering mode and the computed size, so that the text will
draw properly on Windows.

WebKit/win:

  • WebCoreSupport/WebFrameLoaderClient.cpp:

(WebFrameLoaderClient::createPlugin):
Return 0 if we failed to initialize the plug-in, which causes the new
"missing plug-in" text to draw.

12:34 AM Changeset in webkit [56506] by eric@webkit.org
  • 2 edits
    2 adds
    4 deletes in trunk/LayoutTests

2010-03-25 Kinuko Yasuda <​kinuko@chromium.org>

Reviewed by David Levin.

Rewrite the layout test editing/inserting/6633727 to use dumpAsText
​https://bugs.webkit.org/show_bug.cgi?id=31579

  • editing/inserting/6633727-expected.txt: Added.
  • editing/inserting/6633727.html:
  • editing/inserting/script-tests/6633727.js: Added.
  • platform/gtk/editing/inserting/6633727-expected.txt: Removed.
  • platform/mac/editing/inserting/6633727-expected.checksum: Removed.
  • platform/mac/editing/inserting/6633727-expected.png: Removed.
  • platform/mac/editing/inserting/6633727-expected.txt: Removed.
12:24 AM Changeset in webkit [56505] by Chris Jerdonek
  • 11 edits in trunk/WebKitTools

In webkitpy, renamed MockBugzillaTool to MockTool.

Reviewed by Adam Barth.

  • Scripts/webkitpy/tool/commands/commandtest.py:
  • Scripts/webkitpy/tool/commands/queries_unittest.py:
  • Scripts/webkitpy/tool/commands/queues_unittest.py:
  • Scripts/webkitpy/tool/commands/queuestest.py:
  • Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
  • Scripts/webkitpy/tool/commands/upload_unittest.py:
  • Scripts/webkitpy/tool/mocktool.py:
  • Scripts/webkitpy/tool/steps/closebugforlanddiff_unittest.py:
  • Scripts/webkitpy/tool/steps/steps_unittest.py:
  • Scripts/webkitpy/tool/steps/updatechangelogswithreview_unittests.py:
12:18 AM Changeset in webkit [56504] by Chris Jerdonek
  • 14 edits
    2 copies
    4 moves
    2 adds in trunk/WebKitTools

In Scripts/webkitpy, moved webkitport.py and committers.py into
common/config/ (also creating common/config/).

Reviewed by Adam Barth.

​https://bugs.webkit.org/show_bug.cgi?id=36093

This is part of the master bug to reorganize webkitpy.

  • Scripts/validate-committer-lists:
  • Scripts/webkitpy/bugzilla.py:
  • Scripts/webkitpy/bugzilla_unittest.py:
  • Scripts/webkitpy/changelogs.py:
  • Scripts/webkitpy/commitinfo.py:
  • Scripts/webkitpy/commitinfo_unittest.py:
  • Scripts/webkitpy/committers.py: Removed.
  • Scripts/webkitpy/committers_unittest.py: Removed.
  • Scripts/webkitpy/common: Added.
  • Scripts/webkitpy/common/init.py: Copied from WebKitTools/Scripts/webkitpy/style/init.py.
  • Scripts/webkitpy/common/config: Added.
  • Scripts/webkitpy/common/config/init.py: Copied from WebKitTools/Scripts/webkitpy/style/init.py.
  • Scripts/webkitpy/common/config/committers.py: Copied from WebKitTools/Scripts/webkitpy/committers.py.
  • Scripts/webkitpy/common/config/committers_unittest.py: Copied from WebKitTools/Scripts/webkitpy/committers_unittest.py.
  • Scripts/webkitpy/common/config/ports.py: Copied from WebKitTools/Scripts/webkitpy/webkitport.py.
  • Scripts/webkitpy/common/config/ports_unittest.py: Copied from WebKitTools/Scripts/webkitpy/webkitport_unittest.py.
  • Scripts/webkitpy/mock_bugzillatool.py:
  • Scripts/webkitpy/tool/commands/early_warning_system.py:
  • Scripts/webkitpy/tool/commands/queries.py:
  • Scripts/webkitpy/tool/commands/sheriffbot.py:
  • Scripts/webkitpy/tool/commands/upload.py:
  • Scripts/webkitpy/tool/steps/abstractstep.py:
  • Scripts/webkitpy/unittests.py:
  • Scripts/webkitpy/webkitport.py: Removed.
  • Scripts/webkitpy/webkitport_unittest.py: Removed.
12:09 AM Changeset in webkit [56503] by abarth@webkit.org
  • 10 edits
    1 move in trunk/WebKitTools

2010-03-25 Adam Barth <​abarth@webkit.org>

Unreviewed. Move mock_bugzillatool.py to tool/mocktool.py.

  • Scripts/webkitpy/mock_bugzillatool.py: Removed.
  • Scripts/webkitpy/tool/commands/commandtest.py:
  • Scripts/webkitpy/tool/commands/queries_unittest.py:
  • Scripts/webkitpy/tool/commands/queues_unittest.py:
  • Scripts/webkitpy/tool/commands/queuestest.py:
  • Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
  • Scripts/webkitpy/tool/commands/upload_unittest.py:
  • Scripts/webkitpy/tool/mocktool.py: Copied from Scripts/webkitpy/mock_bugzillatool.py.
  • Scripts/webkitpy/tool/steps/closebugforlanddiff_unittest.py:
  • Scripts/webkitpy/tool/steps/steps_unittest.py:
  • Scripts/webkitpy/tool/steps/updatechangelogswithreview_unittests.py:
12:07 AM Changeset in webkit [56502] by eric@webkit.org
  • 6 edits in trunk

2010-03-24 Vangelis Kokkevis <​vangelis@chromium.org>

Reviewed by Dimitri Glazkov.

Removing unecessary redraws of LayerSkia contents:
​https://bugs.webkit.org/show_bug.cgi?id=36470

Test: No new functionality added, no tests.

  • platform/graphics/skia/LayerRendererSkia.cpp: (WebCore::LayerRendererSkia::drawLayerInCanvasRecursive): Debug borders now rendered at composite time rather than update time.
  • platform/graphics/skia/LayerSkia.cpp: (WebCore::LayerSkia::updateContents): (WebCore::LayerSkia::drawDebugBorder): Debug border drawing removed from updateContents and split into a separate method that can be called at composite time. (WebCore::LayerSkia::setBounds): Resetting the bounds causes the layer to redraw its contents. (WebCore::LayerSkia::setNeedsDisplay):
  • platform/graphics/skia/LayerSkia.h: Added declaration for drawDebugBorders method.

2010-03-24 Vangelis Kokkevis <​vangelis@chromium.org>

Reviewed by Dimitri Glazkov.

Eliminate unecessary redraws of GraphicsLayer contents when doing accelerated compositing:
​https://bugs.webkit.org/show_bug.cgi?id=36470

  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::paint): Remove call that forced redrawing the contents of the entire layer hierarchy.

Mar 24, 2010:

11:59 PM Changeset in webkit [56501] by abarth@webkit.org
  • 12 edits
    3 moves in trunk/WebKitTools

2010-03-24 Adam Barth <​abarth@webkit.org>

Unreviewed. Move comments.py and multicommandtool.py to their new
home.

  • Scripts/webkitpy/comments.py: Removed.
  • Scripts/webkitpy/multicommandtool.py: Removed.
  • Scripts/webkitpy/multicommandtool_unittest.py: Removed.
  • Scripts/webkitpy/tool/commands/abstractsequencedcommand.py:
  • Scripts/webkitpy/tool/commands/download.py:
  • Scripts/webkitpy/tool/commands/openbugs.py:
  • Scripts/webkitpy/tool/commands/queries.py:
  • Scripts/webkitpy/tool/commands/queues.py:
  • Scripts/webkitpy/tool/commands/upload.py:
  • Scripts/webkitpy/tool/comments.py: Copied from Scripts/webkitpy/comments.py.
  • Scripts/webkitpy/tool/main.py:
  • Scripts/webkitpy/tool/multicommandtool.py: Copied from Scripts/webkitpy/multicommandtool.py.
  • Scripts/webkitpy/tool/multicommandtool_unittest.py: Copied from Scripts/webkitpy/multicommandtool_unittest.py.
  • Scripts/webkitpy/tool/steps/closebugforlanddiff.py:
  • Scripts/webkitpy/tool/steps/closepatch.py:
  • Scripts/webkitpy/tool/steps/reopenbugafterrollout.py:
  • Scripts/webkitpy/unittests.py:
11:47 PM Changeset in webkit [56500] by abarth@webkit.org
  • 2 edits in trunk/WebKitTools

2010-03-24 Adam Barth <​abarth@webkit.org>

Unreviewed. Fixup one import statement I didn't find because the .pyc
masked the error.

  • Scripts/webkitpy/stepsequence.py:
11:44 PM Changeset in webkit [56499] by abarth@webkit.org
  • 4 edits
    2 moves in trunk/WebKitTools

2010-03-24 Adam Barth <​abarth@webkit.org>

Unreviewed. Move queueengine.py to its new home.

  • Scripts/webkitpy/queueengine.py: Removed.
  • Scripts/webkitpy/queueengine_unittest.py: Removed.
  • Scripts/webkitpy/tool/bot/queueengine.py: Copied from Scripts/webkitpy/queueengine.py.
  • Scripts/webkitpy/tool/bot/queueengine_unittest.py: Copied from Scripts/webkitpy/queueengine_unittest.py.
  • Scripts/webkitpy/tool/commands/early_warning_system.py:
  • Scripts/webkitpy/tool/commands/queues.py:
  • Scripts/webkitpy/unittests.py:
11:40 PM Changeset in webkit [56498] by abarth@webkit.org
  • 3 edits
    2 moves
    2 adds in trunk/WebKitTools

2010-03-24 Adam Barth <​abarth@webkit.org>

Unreviewed. Move patchcollection.py to its new home.

  • Scripts/webkitpy/patchcollection.py: Removed.
  • Scripts/webkitpy/patchcollection_unittest.py: Removed.
  • Scripts/webkitpy/tool/bot: Added.
  • Scripts/webkitpy/tool/bot/init.py: Added.
  • Scripts/webkitpy/tool/bot/patchcollection.py: Copied from WebKitTools/Scripts/webkitpy/patchcollection.py.
  • Scripts/webkitpy/tool/bot/patchcollection_unittest.py: Copied from WebKitTools/Scripts/webkitpy/patchcollection_unittest.py.
  • Scripts/webkitpy/tool/commands/queues.py:
  • Scripts/webkitpy/unittests.py:
11:27 PM Changeset in webkit [56497] by Chris Jerdonek
  • 38 edits
    2 moves in trunk/WebKitTools

In Scripts/webkitpy, moved steps_references.py and the steps
folder into webkitpy/patch.

Reviewed by Adam Barth.

​https://bugs.webkit.org/show_bug.cgi?id=36093

  • Scripts/webkitpy/steps: Removed.
  • Scripts/webkitpy/steps/init.py: Removed.
  • Scripts/webkitpy/steps/abstractstep.py: Removed.
  • Scripts/webkitpy/steps/applypatch.py: Removed.
  • Scripts/webkitpy/steps/applypatchwithlocalcommit.py: Removed.
  • Scripts/webkitpy/steps/build.py: Removed.
  • Scripts/webkitpy/steps/checkstyle.py: Removed.
  • Scripts/webkitpy/steps/cleanworkingdirectory.py: Removed.
  • Scripts/webkitpy/steps/cleanworkingdirectorywithlocalcommits.py: Removed.
  • Scripts/webkitpy/steps/closebug.py: Removed.
  • Scripts/webkitpy/steps/closebugforlanddiff.py: Removed.
  • Scripts/webkitpy/steps/closebugforlanddiff_unittest.py: Removed.
  • Scripts/webkitpy/steps/closepatch.py: Removed.
  • Scripts/webkitpy/steps/commit.py: Removed.
  • Scripts/webkitpy/steps/confirmdiff.py: Removed.
  • Scripts/webkitpy/steps/createbug.py: Removed.
  • Scripts/webkitpy/steps/editchangelog.py: Removed.
  • Scripts/webkitpy/steps/ensurebuildersaregreen.py: Removed.
  • Scripts/webkitpy/steps/ensurelocalcommitifneeded.py: Removed.
  • Scripts/webkitpy/steps/metastep.py: Removed.
  • Scripts/webkitpy/steps/obsoletepatches.py: Removed.
  • Scripts/webkitpy/steps/options.py: Removed.
  • Scripts/webkitpy/steps/postdiff.py: Removed.
  • Scripts/webkitpy/steps/postdiffforcommit.py: Removed.
  • Scripts/webkitpy/steps/postdiffforrevert.py: Removed.
  • Scripts/webkitpy/steps/preparechangelog.py: Removed.
  • Scripts/webkitpy/steps/preparechangelogforrevert.py: Removed.
  • Scripts/webkitpy/steps/promptforbugortitle.py: Removed.
  • Scripts/webkitpy/steps/reopenbugafterrollout.py: Removed.
  • Scripts/webkitpy/steps/revertrevision.py: Removed.
  • Scripts/webkitpy/steps/runtests.py: Removed.
  • Scripts/webkitpy/steps/steps_unittest.py: Removed.
  • Scripts/webkitpy/steps/update.py: Removed.
  • Scripts/webkitpy/steps/updatechangelogswithreview_unittests.py: Removed.
  • Scripts/webkitpy/steps/updatechangelogswithreviewer.py: Removed.
  • Scripts/webkitpy/steps/validatereviewer.py: Removed.
  • Scripts/webkitpy/steps_references.py: Removed.
  • Scripts/webkitpy/stepsequence.py:
  • Scripts/webkitpy/tool/commands/download.py:
  • Scripts/webkitpy/tool/commands/upload.py:
  • Scripts/webkitpy/tool/steps: Copied from WebKitTools/Scripts/webkitpy/steps.
  • Scripts/webkitpy/tool/steps/init.py:
  • Scripts/webkitpy/tool/steps/applypatch.py:
  • Scripts/webkitpy/tool/steps/applypatchwithlocalcommit.py:
  • Scripts/webkitpy/tool/steps/build.py:
  • Scripts/webkitpy/tool/steps/checkstyle.py:
  • Scripts/webkitpy/tool/steps/cleanworkingdirectory.py:
  • Scripts/webkitpy/tool/steps/cleanworkingdirectorywithlocalcommits.py:
  • Scripts/webkitpy/tool/steps/closebug.py:
  • Scripts/webkitpy/tool/steps/closebugforlanddiff.py:
  • Scripts/webkitpy/tool/steps/closebugforlanddiff_unittest.py:
  • Scripts/webkitpy/tool/steps/closepatch.py:
  • Scripts/webkitpy/tool/steps/commit.py:
  • Scripts/webkitpy/tool/steps/confirmdiff.py:
  • Scripts/webkitpy/tool/steps/createbug.py:
  • Scripts/webkitpy/tool/steps/editchangelog.py:
  • Scripts/webkitpy/tool/steps/ensurebuildersaregreen.py:
  • Scripts/webkitpy/tool/steps/ensurelocalcommitifneeded.py:
  • Scripts/webkitpy/tool/steps/metastep.py:
  • Scripts/webkitpy/tool/steps/obsoletepatches.py:
  • Scripts/webkitpy/tool/steps/postdiff.py:
  • Scripts/webkitpy/tool/steps/postdiffforcommit.py:
  • Scripts/webkitpy/tool/steps/postdiffforrevert.py:
  • Scripts/webkitpy/tool/steps/preparechangelog.py:
  • Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
  • Scripts/webkitpy/tool/steps/promptforbugortitle.py:
  • Scripts/webkitpy/tool/steps/reopenbugafterrollout.py:
  • Scripts/webkitpy/tool/steps/revertrevision.py:
  • Scripts/webkitpy/tool/steps/runtests.py:
  • Scripts/webkitpy/tool/steps/steps_unittest.py:
  • Scripts/webkitpy/tool/steps/update.py:
  • Scripts/webkitpy/tool/steps/updatechangelogswithreview_unittests.py:
  • Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py:
  • Scripts/webkitpy/tool/steps/validatereviewer.py:
  • Scripts/webkitpy/tool/steps_references.py: Copied from WebKitTools/Scripts/webkitpy/steps_references.py.
  • Scripts/webkitpy/unittests.py:
11:22 PM Changeset in webkit [56496] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2010-03-24 Eric Seidel <​eric@webkit.org>

Unreviewed, build fix only.

Abstract LayoutTestResults logic for easier reuse
​https://bugs.webkit.org/show_bug.cgi?id=36579

  • Scripts/webkitpy/buildbot_unittest.py: Add a missing import.
11:15 PM Changeset in webkit [56495] by abarth@webkit.org
  • 3 edits in trunk/WebKitTools

2010-03-24 Adam Barth <​abarth@webkit.org>

Unreviewed. Fix a stray comma to test landing an patch without review.

  • Scripts/webkitpy/commitinfo.py:
11:10 PM Changeset in webkit [56494] by Chris Jerdonek
  • 16 edits
    2 moves in trunk/WebKitTools

In Scripts/webkitpy, moved commands_references.py and the commands
folder into webkitpy/patch.

Reviewed by Adam Barth.

​https://bugs.webkit.org/show_bug.cgi?id=36483

This is part of master bug 36093 to organize webkitpy.

  • Scripts/webkitpy/commands: Removed.
  • Scripts/webkitpy/commands/init.py: Removed.
  • Scripts/webkitpy/commands/abstractsequencedcommand.py: Removed.
  • Scripts/webkitpy/commands/commandtest.py: Removed.
  • Scripts/webkitpy/commands/download.py: Removed.
  • Scripts/webkitpy/commands/download_unittest.py: Removed.
  • Scripts/webkitpy/commands/early_warning_system.py: Removed.
  • Scripts/webkitpy/commands/early_warning_system_unittest.py: Removed.
  • Scripts/webkitpy/commands/openbugs.py: Removed.
  • Scripts/webkitpy/commands/openbugs_unittest.py: Removed.
  • Scripts/webkitpy/commands/queries.py: Removed.
  • Scripts/webkitpy/commands/queries_unittest.py: Removed.
  • Scripts/webkitpy/commands/queues.py: Removed.
  • Scripts/webkitpy/commands/queues_unittest.py: Removed.
  • Scripts/webkitpy/commands/queuestest.py: Removed.
  • Scripts/webkitpy/commands/sheriffbot.py: Removed.
  • Scripts/webkitpy/commands/sheriffbot_unittest.py: Removed.
  • Scripts/webkitpy/commands/upload.py: Removed.
  • Scripts/webkitpy/commands/upload_unittest.py: Removed.
  • Scripts/webkitpy/commands_references.py: Removed.
  • Scripts/webkitpy/tool/commands: Copied from WebKitTools/Scripts/webkitpy/commands.
  • Scripts/webkitpy/tool/commands/commandtest.py:
  • Scripts/webkitpy/tool/commands/download.py:
  • Scripts/webkitpy/tool/commands/download_unittest.py:
  • Scripts/webkitpy/tool/commands/early_warning_system.py:
  • Scripts/webkitpy/tool/commands/early_warning_system_unittest.py:
  • Scripts/webkitpy/tool/commands/openbugs_unittest.py:
  • Scripts/webkitpy/tool/commands/queries_unittest.py:
  • Scripts/webkitpy/tool/commands/queues_unittest.py:
  • Scripts/webkitpy/tool/commands/queuestest.py:
  • Scripts/webkitpy/tool/commands/sheriffbot.py:
  • Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
  • Scripts/webkitpy/tool/commands/upload.py:
  • Scripts/webkitpy/tool/commands/upload_unittest.py:
  • Scripts/webkitpy/tool/commands_references.py: Copied from WebKitTools/Scripts/webkitpy/commands_references.py.
  • Scripts/webkitpy/tool/main.py:
  • Scripts/webkitpy/unittests.py:
11:07 PM Changeset in webkit [56493] by mrowe@apple.com
  • 2 edits in trunk/WebKit/mac

Build fix after r56474.

  • Plugins/Hosted/NetscapePluginHostProxy.mm:

(WKPCRunSyncOpenPanel):

11:07 PM Changeset in webkit [56492] by mrowe@apple.com
  • 5 edits in trunk

Revert the portion of r56489 that dealt with port zero as it introduced some test failures.

WebCore:

  • platform/KURL.cpp:

(WebCore::KURL::port): Use the "ok" argument to charactersToUIntStrict to determine whether
it was able to successfully parse the string as an unsigned integer, rather than relying on
the fact it returned zero when it failed.

LayoutTests:

  • platform/mac/security/block-test-expected.txt:
  • security/block-test.html:
10:51 PM Changeset in webkit [56491] by abarth@webkit.org
  • 2 edits
    1 copy
    1 move
    1 delete in trunk/WebKitTools

2010-03-24 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Rename webkitpy.patch to webkitpy.tool
​https://bugs.webkit.org/show_bug.cgi?id=36580

This is in preparation for the great webkitpy naming cleanup.

  • Scripts/webkit-patch:
  • Scripts/webkitpy/patch: Removed.
  • Scripts/webkitpy/patch/init.py: Removed.
  • Scripts/webkitpy/patch/patcher.py: Removed.
  • Scripts/webkitpy/tool: Copied from WebKitTools/Scripts/webkitpy/patch.
  • Scripts/webkitpy/tool/main.py: Copied from WebKitTools/Scripts/webkitpy/patch/patcher.py.
  • Scripts/webkitpy/tool/patcher.py: Removed.
10:36 PM Changeset in webkit [56490] by barraclough@apple.com
  • 2 edits in trunk/WebCore
  • platform/text/String.cpp:

(WebCore::putUTF8Triple): Correct capitalization of function name.
(WebCore::String::utf8): Fix C-style casts.
(WebCore::String::fromUTF8): Remove unnecessary newline.
(WebCore::String::fromUTF8WithLatin1Fallback): Use early return.

Reviewed by Sam Weinig.

10:26 PM Changeset in webkit [56489] by mrowe@apple.com
  • 6 edits in trunk

WebKit should treat port numbers outside the valid range as being blacklisted
<​http://webkit.org/b/36571> / <rdar://problem/7790908>

Reviewed by Darin Adler.

WebCore:

  • platform/KURL.cpp:

(WebCore::KURL::port): Map invalid port numbers to invalidPortNumber.
(WebCore::portAllowed): Add invalidPortNumber to the blacklist.

  • platform/KURLGoogle.cpp: invalid port numbers to invalidPortNumber.

(WebCore::KURL::port): Add invalidPortNumber to the blacklist.
Also bring this in to sync with KURL. Having this identical code in two places is stupid.

LayoutTests:

  • platform/mac/security/block-test-expected.txt:
  • security/block-test.html: Add tests of a few invalid port numbers.
10:25 PM Changeset in webkit [56488] by eric@webkit.org
  • 4 edits in trunk/WebKitTools

2010-03-24 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Abstract LayoutTestResults logic for easier reuse
​https://bugs.webkit.org/show_bug.cgi?id=36579

  • Scripts/webkitpy/buildbot.py:
    • Split out logic into new LayoutTestResults class.
  • Scripts/webkitpy/buildbot_unittest.py:
    • Rename the testing class to match.
  • Scripts/webkitpy/commands/queries.py:
    • Use the new LayoutTestResults class.
10:14 PM Changeset in webkit [56487] by eric@webkit.org
  • 4 edits in trunk/WebKitTools

2010-03-24 Eric Seidel <​eric@webkit.org>

Reviewed by Eric Seidel.

Move Bugzilla.prompt_for_component to User.prompt_with_list for re-use
​https://bugs.webkit.org/show_bug.cgi?id=36577

  • Scripts/webkitpy/bugzilla.py:
    • Move prompt_for_component to User
  • Scripts/webkitpy/commands/queries.py:
    • Add a missing argument_names declaration.
  • Scripts/webkitpy/user.py:
    • Add prompt_with_list
    • Make staticmethods classmethods for easier mocking
9:58 PM Changeset in webkit [56486] by eric@webkit.org
  • 3 edits in trunk/LayoutTests

2010-03-24 MORITA Hajime <​morrita@google.com>

Reviewed by Eric Seidel.

​https://bugs.webkit.org/show_bug.cgi?id=36517
svg/dom/frame-related-api-during-load.html shoud be more self-descriptive.

  • svg/dom/frame-related-api-during-load-expected.txt:
  • svg/dom/frame-related-api-during-load.html:
9:28 PM Changeset in webkit [56485] by ddkilzer@apple.com
  • 1 edit in trunk/WebKitTools/ChangeLog

Fix bug URL.

9:25 PM Changeset in webkit [56484] by ddkilzer@apple.com
  • 2 edits in trunk/WebKitTools

<htp://webkit.org/b/36572> commit-log-editor: thinks mergeChangeLogs.pl is a ChangeLog file

Reviewed by Eric Seidel.

Fixes the following error when committing a file with
"ChangeLog" in the name that isn't a ChangeLog (like
mergeChangeLogs.pl from r56471 and r56472):

$ git commit .
Can't open WebKitTools/Scripts/webkitperl/VCSUtils_unittest/mergeChangeLog at commit-log-editor line 132.
error: There was a problem with the editor 'commit-log-editor'.
Please supply the message using either -m or -F option.

  • Scripts/commit-log-editor: Added '$' to anchor "ChangeLog" to

the end of the file name when searching for ChangeLog files in a
commit.

9:15 PM Changeset in webkit [56483] by ddkilzer@apple.com
  • 2 edits in trunk/WebKitTools

<​http://webkit.org/b/36570> resolve-ChangeLogs: fall back to git-merge-file if ChangeLog can't be merged

Reviewed by Eric Seidel.

  • Scripts/resolve-ChangeLogs: Switched to exec git-merge-file if

the merge attempt fails.

9:15 PM Changeset in webkit [56482] by barraclough@apple.com
  • 2 edits in trunk/JavaScriptCore

Switch String::latin1, String::utf8, String::fromUTF8 to
use WTF's Unicode conversion methods rather than TextEncoder.
These methods only perform simple conversion, and don't need
really require TextEncoder's full capability (to look up arbitrary
encodings by name), switching to only be dependent on WTF will
make it easier if we chose to move WebCore::String to WTF.

Reviewed by Sam Weinig.

9:08 PM Changeset in webkit [56481] by scherkus@chromium.org
  • 13 edits in trunk/LayoutTests

2010-03-24 Andrew Scherkus <​scherkus@chromium.org>

Reviewed by Eric Carlson, Eric Seidel and David Levin.

Update a few more media layout tests to choose test clips based on codec support.

​https://bugs.webkit.org/show_bug.cgi?id=30435

  • media/audio-constructor-src.html: Switched to use findMediaFile().
  • media/audio-play-event-expected.txt: Updated results.
  • media/audio-play-event.html: Switched to use findMediaFile().
  • media/video-no-audio.html: Ditto.
  • media/video-source-add-src.html: Ditto.
  • media/video-src-change.html: Closed p tag.
  • platform/mac-leopard/media/video-no-audio-expected.checksum: New results due to changing source video.
  • platform/mac-leopard/media/video-no-audio-expected.png: Ditto.
  • platform/mac-leopard/media/video-no-audio-expected.txt: Ditto.
  • platform/mac/media/video-no-audio-expected.checksum: Ditto.
  • platform/mac/media/video-no-audio-expected.png: Ditto.
  • platform/mac/media/video-no-audio-expected.txt: Ditto.
9:07 PM Changeset in webkit [56480] by barraclough@apple.com
  • 2 edits in trunk/JavaScriptCore

Switch String::latin1, String::utf8, String::fromUTF8 to
use WTF's Unicode conversion methods rather than TextEncoder.
These methods only perform simple conversion, and don't need
really require TextEncoder's full capability (to look up arbitrary
encodings by name), switching to only be dependent on WTF will
make it easier if we chose to move WebCore::String to WTF.

Reviewed by Sam Weinig.

8:56 PM Changeset in webkit [56479] by weinig@apple.com
  • 2 edits in trunk/WebCore

Add some missing exports.

Reviewed by Mark Rowe.

  • WebCore.base.exp:
8:45 PM Changeset in webkit [56478] by abarth@webkit.org
  • 7 edits
    1 add in trunk/WebKitTools

2010-03-24 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

webkit-patch or pre-commit hook should validate reviewer lines before committing
​https://bugs.webkit.org/show_bug.cgi?id=26927

Validate that patches have valid reivewers listed in their ChangeLogs
before landing. For patches without reviewers can be landed if their
ChangeLogs state that they are unreviewed.

  • Scripts/webkitpy/changelogs.py:
  • Scripts/webkitpy/commands/download.py:
  • Scripts/webkitpy/commitinfo.py:
  • Scripts/webkitpy/commitinfo_unittest.py:
  • Scripts/webkitpy/mock_bugzillatool.py:
  • Scripts/webkitpy/steps/init.py:
  • Scripts/webkitpy/steps/validatereviewer.py: Added.
8:43 PM Changeset in webkit [56477] by barraclough@apple.com
  • 2 edits in trunk/WebCore

Switch String::latin1, String::utf8, String::fromUTF8 to
use WTF's Unicode conversion methods rather than TextEncoder.
These methods only perform simple conversion, and don't need
really require TextEncoder's full capability (to look up arbitrary
encodings by name), switching to only be dependent on WTF will
make it easier if we chose to move WebCore::String to WTF.

Reviewed by Sam Weinig.

  • platform/text/String.cpp:

(WebCore::String::latin1):
(WebCore::putUTF8triple):
(WebCore::String::utf8):
(WebCore::String::fromUTF8):

6:10 PM Changeset in webkit [56476] by eric@webkit.org
  • 1 edit in trunk/WebCore/ChangeLog

Restore peace and justice to the universe.

6:06 PM Changeset in webkit [56475] by zecke@webkit.org
  • 5 edits in trunk/WebKitTools

Undefined names reported by pyflakes in python scripts

ttps://bugs.webkit.org/show_bug.cgi?id=36403

Attempt to use names that exist or can exist in the lexical
scope instead of not being available at all.

  • Scripts/webkitpy/changelogs.py: Use self._content.
  • Scripts/webkitpy/layout_tests/port/base.py: Use os.stat
  • Scripts/webkitpy/layout_tests/test_types/fuzzy_image_diff.py: Use self._port
  • Scripts/webkitpy/style/processors/cpp_unittest.py: Use expected_message_re
5:52 PM Changeset in webkit [56474] by ap@apple.com
  • 4 edits in trunk/WebKit/mac

Reviewed by Anders Carlsson.

​https://bugs.webkit.org/show_bug.cgi?id=36563
A plug-in makes Safari crash on ​http://www.itscodingtime.com/

  • Plugins/Hosted/NetscapePluginHostProxy.h: (WebKit::NetscapePluginHostProxy::port): Assert that the object is still alive. This isn't beautifully systemic, but helped catch a bug, and may help catch more. (WebKit::NetscapePluginHostProxy::clientPort): Ditto. (WebKit::NetscapePluginHostProxy::isProcessingRequests): Changed m_processingRequests to a static. This doesn't change behavior much, but helps avoid writing into deallocated memory.
  • Plugins/Hosted/NetscapePluginHostProxy.mm: (WebKit::NetscapePluginHostProxy::NetscapePluginHostProxy): Changed m_processingRequests to a static. (WebKit::NetscapePluginHostProxy::processRequests): Ditto. Changing m_processingRequests after destroying the object in pluginHostDied() was wrong, but reasonably harmless, as there wasn't much time for some other object to be allocated at this address. (WKPCEvaluate): Refetch host proxy, as it may have been destroyed. (WKPCInvoke): Ditto. (WKPCInvokeDefault): Ditto. (WKPCGetProperty): Ditto. (WKPCSetProperty): Ditto. (WKPCRemoveProperty): Ditto. (WKPCHasProperty): Ditto. (WKPCHasMethod): Ditto. (WKPCEnumerate): Ditto. (WKPCRunSyncOpenPanel): Ditto.
  • Plugins/Hosted/NetscapePluginInstanceProxy.mm: (WebKit::NetscapePluginInstanceProxy::processRequestsAndWaitForReply): Bail out of the "event loop" if host proxy went away while processing a request.
5:02 PM Changeset in webkit [56473] by eric@webkit.org
  • 3 edits in trunk/WebKit/qt

2010-03-24 Jesus Sanchez-Palencia <​jesus.palencia@openbossa.org>

Reviewed by Kenneth Rohde Christiansen.

Add the FrameFlatteningEnabled WebAttribute to QWebSettings.

[Qt] Missing QWebSettings for Frame Flattening
​https://bugs.webkit.org/show_bug.cgi?id=36553

  • Api/qwebsettings.cpp: (QWebSettingsPrivate::apply): (QWebSettings::QWebSettings):
  • Api/qwebsettings.h:
4:50 PM Changeset in webkit [56472] by ddkilzer@apple.com
  • 3 edits in trunk/WebKitTools

<​http://webkit.org/b/36560> resolve-ChangeLogs: git-rebase fails when resolve-ChangeLogs can't merge

Reviewed by Eric Seidel.

When resolve-ChangeLogs fails to merge a patch while running as
a git merge driver, it deletes the original file, which causes
an internal failure and stops git mid-merge:

fatal: Failed to execute internal merge

The fix is to use the --force switch with patch so that it will
always attempt to apply the patch. (The change in
mergeChangeLogs() for the previous commit also fixed this, but
adding --force also prevents any potential user interaction that
patch may want to display.)

  • Scripts/VCSUtils.pm:

(mergeChangeLogs): Added --force switch to patch command. Also
changed to use the exit status from the patch command to
determine the return value for this method.

  • Scripts/webkitperl/VCSUtils_unittest/mergeChangeLogs.pl: Added

test to cover this bug.

4:50 PM Changeset in webkit [56471] by ddkilzer@apple.com
  • 3 edits
    1 add in trunk/WebKitTools

<​http://webkit.org/b/36560> resolve-ChangeLogs: move mergeChanges() into VCSUtils package

Reviewed by Eric Seidel.

  • Scripts/VCSUtils.pm:

(mergeChangeLogs): Copied from mergeChanges() in
resolve-ChangeLogs and renamed. Added method documentation.
Fixed bug found by new tests where the original file to be
patched was deleted when cleaning up after a traditinal rejected
patch failed to apply.

  • Scripts/resolve-ChangeLogs: Switched to using

mergeChangeLogs().
(mergeChanges): Moved to VCSUtils.pm and renamed to
mergeChangeLogs().

  • Scripts/webkitperl/VCSUtils_unittest/mergeChangeLogs.pl: Added.
4:36 PM Changeset in webkit [56470] by eric@webkit.org
  • 5 edits in trunk/WebKitTools

2010-03-24 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Add support for qt's unassigned list to webkit-patch assign-to-committer
​https://bugs.webkit.org/show_bug.cgi?id=36559

  • Scripts/webkitpy/bugzilla.py:
    • Move Bugzilla.unassigned_email into Bug and make it a set.
  • Scripts/webkitpy/bugzilla_unittest.py:
    • Test the new Bug.is_unassigned method
  • Scripts/webkitpy/commands/upload.py:
    • Use the new Bug.is_unassigned method instead of an explicit ==
  • Scripts/webkitpy/mock_bugzillatool.py:
    • Bugzilla.unassigned_email no longer needs mocking
4:30 PM Changeset in webkit [56469] by dimich@chromium.org
  • 4 edits in trunk

2010-03-24 Dmitry Titov <​dimich@chromium.org>

No review, rolling out r56453.
​http://trac.webkit.org/changeset/56453
​https://bugs.webkit.org/show_bug.cgi?id=36426

In Chromium port, it broke invalid-image-data-standalone.html
invalid-image-data.html multipart-wait-before-boundary.html
stop-crash.html win-boundary-crash.html

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::finishedLoadingDocument):

2010-03-24 Dmitry Titov <​dimich@chromium.org>

No review, rolling out r56453.
​http://trac.webkit.org/changeset/56453
​https://bugs.webkit.org/show_bug.cgi?id=36426

In Chromium port, it broke invalid-image-data-standalone.html
invalid-image-data.html multipart-wait-before-boundary.html
stop-crash.html win-boundary-crash.html

  • src/ResourceHandle.cpp: (WebCore::ResourceHandleInternal::ResourceHandleInternal): (WebCore::ResourceHandleInternal::start): (WebCore::ResourceHandleInternal::cancel): (WebCore::ResourceHandleInternal::didReceiveResponse): (WebCore::ResourceHandleInternal::didReceiveData): (WebCore::ResourceHandleInternal::didFinishLoading): (WebCore::ResourceHandleInternal::didFail):
4:21 PM Changeset in webkit [56468] by ap@apple.com
  • 2 edits in trunk/JavaScriptCore

Reviewed by Geoff Garen.

  • wtf/FastMalloc.h: Added a using directive for fastMallocSize, like we do for all public WTF symbols. Also sorted the list alphabetically.
4:18 PM Changeset in webkit [56467] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-03-24 Ilya Tikhonovsky <​loislo@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Significant scroll speed degradation if Timeline has
an expanded record with significant number of children.
​https://bugs.webkit.org/show_bug.cgi?id=36543

  • inspector/front-end/TimelinePanel.js: (WebInspector.TimelinePanel.prototype._updateBoundaries): (WebInspector.TimelinePanel.prototype._addToRecordsWindow): (WebInspector.TimelinePanel.prototype._filterRecords): (WebInspector.TimelinePanel.prototype._refreshRecords):
4:08 PM Changeset in webkit [56466] by kov@webkit.org
  • 1 edit
    1 add in trunk/WebKit/gtk/po

2010-03-24 Yuri Chornoivan <​yurchor@ukr.net>

Reviewed by Gustavo Noronha.

Ukrainian translation.

  • uk.po: Added.
4:02 PM Changeset in webkit [56465] by kov@webkit.org
  • 2 edits in trunk/WebCore

2010-03-24 Gustavo Noronha Silva <​gustavo.noronha@collabora.co.uk>

Reviewed by Eric Carlson.

[GStreamer] Fails to go to Loaded state because of floating point discrepancies
​https://bugs.webkit.org/show_bug.cgi?id=35891

Use the m_fillStatus variable, which is more reliable, instead of
using the calculation, for the completed case.

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivate::fillTimerFired):
4:00 PM Changeset in webkit [56464] by dimich@chromium.org
  • 2 edits in trunk/WebCore

Unreviewed, Chromium test fix.

Recent r56445 added CustomEvent and a test but it didn't work on Chromium bots.
Test crashed due to infinte recursion because the compiler did not have the right definition of toV8(CustomEvent*)
and was substituting toV8(Event*).

Fixing test fast/events/custom-event.html

  • bindings/v8/custom/V8EventCustom.cpp:
3:45 PM Changeset in webkit [56463] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-03-24 MORITA Hajime <​morrita@google.com>

Reviewed by Darin Adler.

Refactoring: HTMLFormControlElement should not have redundant null check
​https://bugs.webkit.org/show_bug.cgi?id=36487

No new tests as there is no new functionality.

  • html/HTMLFormControlElement.cpp: (WebCore::HTMLFormControlElement::dispatchFocusEvent): (WebCore::HTMLFormControlElement::dispatchBlurEvent):
3:22 PM Changeset in webkit [56462] by eric@webkit.org
  • 4 edits in trunk

2010-03-24 Eric Uhrhane <​ericu@chromium.org>

DOMCoreException needs NoStaticTables modifier
​https://bugs.webkit.org/show_bug.cgi?id=36458

No new tests, but this shows up in tests of Database accesses from the
Worker thread that I'll be checking in soon. The symptom is that
DOMCoreException.toString() returns [object DOMException] instead of
something more helpful.

  • fast/workers/worker-context-multi-port-expected.txt: Adjusted expectation that was depending on the broken behavior.

2010-03-24 Eric Uhrhane <​ericu@chromium.org>

Reviewed by Alexey Proskuryakov.

DOMCoreException needs NoStaticTables modifier
​https://bugs.webkit.org/show_bug.cgi?id=36458

No new tests, but this shows up in tests of Database accesses from the
Worker thread that I'll be checking in soon. The symptom is that
DOMCoreException.toString() returns [object DOMException] instead of
something more helpful.

  • dom/DOMCoreException.idl: Added NoStaticTables.
3:05 PM Changeset in webkit [56461] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-03-24 Drew Wilson <​atwilson@chromium.org>

Reviewed by Dmitry Titov.

Failed assertion in V8Proxy::setDOMException() if worker is shutting down.
​https://bugs.webkit.org/show_bug.cgi?id=36514

Test: none (existing worker tests suffice)

  • bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::setDOMException): Updated setDOMException() to check for an empty exception (due to no active context) and avoid throwing in that case.
2:37 PM Changeset in webkit [56460] by evan@chromium.org
  • 7 edits in trunk

2010-03-23 Evan Martin <​evan@chromium.org>

Reviewed by Dmitry Titov.

[chromium] use integral glyph widths
​https://bugs.webkit.org/show_bug.cgi?id=36510

Extend a Linux Chromium layout test to also cover slight-hinted text.

  • platform/chromium/fast/text/chromium-linux-fontconfig-renderstyle.html:

2010-03-23 Evan Martin <​evan@chromium.org>

Reviewed by Dmitry Titov.

[chromium] use integral glyph widths
​https://bugs.webkit.org/show_bug.cgi?id=36510

Despite WebKit (and Skia, to an extent) supporting non-integral
glyph widths, the font code path we hit in Skia only supports
integral glyph positions. This means that we would accumulate
offsets when drawing a sequence up non-integer-width glyphs
which would cause gaps when snapped to the pixel grid when drawing.

  • platform/graphics/chromium/SimpleFontDataLinux.cpp: (WebCore::SimpleFontData::platformWidthForGlyph): round glyph widths to integers.
2:16 PM Changeset in webkit [56459] by dino@apple.com
  • 2 edits in trunk/WebCore

2010-03-24 Dean Jackson <​dino@apple.com>

Reviewed by Kevin Decker.

<rdar://problem/7785305>
Fix regression caused by r55576. It turned out that ensuring
CoreAnimation always gets a correct fill parameter caused flashing
as non-filled animations ended (CA briefly showed the initial animation
value before the style system set the final value).

  • platform/graphics/mac/GraphicsLayerCA.mm: (WebCore::GraphicsLayerCA::setupAnimation):
2:12 PM Changeset in webkit [56458] by eric@webkit.org
  • 2 edits in trunk/WebKit/qt

2010-03-24 Viatcheslav Ostapenko <​ostapenko.viatcheslav@nokia.com>

Reviewed by Laszlo Gombos.

Auto-uppercase and predictive text need to be disabled for S60 (as for maemo)
​https://bugs.webkit.org/show_bug.cgi?id=33176

  • WebCoreSupport/EditorClientQt.cpp:
2:08 PM Changeset in webkit [56457] by jam@chromium.org
  • 5 edits
    2 adds in trunk/WebKit/chromium

2010-03-24 John Abd-El-Malek <​jam@chromium.org>

Reviewed by Darin Fisher.

[chromium]WebKit side of adding search support to Pepper.
​https://bugs.webkit.org/show_bug.cgi?id=36434

  • WebKit.gyp:
  • public/WebDocument.h:
  • public/WebNode.h: (WebKit::WebNode::to): (WebKit::WebNode::toConst):
  • public/WebPluginDocument.h: Added. (WebKit::WebPluginDocument::WebPluginDocument): (WebKit::WebPluginDocument::operator=): (WebKit::WebPluginDocument::assign):
  • src/WebDocument.cpp: (WebKit::WebDocument::isPluginDocument):
  • src/WebPluginDocument.cpp: Added. (WebKit::WebPluginDocument::plugin): (WebKit::WebPluginDocument::WebPluginDocument): (WebKit::WebPluginDocument::operator=): (WebKit::WebPluginDocument::operator PassRefPtr<PluginDocument>):
1:55 PM Changeset in webkit [56456] by eric@webkit.org
  • 5 edits in trunk

2010-03-24 Kent Hansen <​kent.hansen@nokia.com>

Reviewed by Simon Hausmann.

[Qt] Rename QWebSettings::XSSAuditorEnabled to XSSAuditingEnabled
​https://bugs.webkit.org/show_bug.cgi?id=36522

For consistency with other QWebSettings attributes.

  • Api/qwebsettings.cpp: (QWebSettingsPrivate::apply):
  • Api/qwebsettings.h:

2010-03-24 Kent Hansen <​kent.hansen@nokia.com>

Reviewed by Simon Hausmann.

[Qt] Rename QWebSettings::XSSAuditorEnabled to XSSAuditingEnabled
​https://bugs.webkit.org/show_bug.cgi?id=36522

  • DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::setXSSAuditorEnabled): Use the new name.
1:50 PM Changeset in webkit [56455] by weinig@apple.com
  • 2 edits in trunk/WebKitSite

Rubber-stamped by Anders Carlsson..

Update Security Group Members list.

  • security/security-group-members.html:
1:38 PM Changeset in webkit [56454] by eric@webkit.org
  • 6 edits in trunk

2010-03-24 Hayato Ito <​hayato@chromium.org>

Reviewed by NOBODY (Need!).

Refactor computePageRects so that Mac can make use of it.
​https://bugs.webkit.org/show_bug.cgi?id=36159

Refactoring only, so no new tests.

  • WebCore.base.exp:
  • page/PrintContext.cpp: (WebCore::PrintContext::computePageRects): (WebCore::PrintContext::computePageRectsWithPageSize): (WebCore::PrintContext::computePageRectsWithPageSizeInternal): (WebCore::PrintContext::pageNumberForElement): (WebCore::PrintContext::numberOfPages):
  • page/PrintContext.h:

2010-03-24 Hayato Ito <​hayato@chromium.org>

Reviewed by Shinichiro Hamaji.

Refactor computePageRects so that Mac can make use of it.
​https://bugs.webkit.org/show_bug.cgi?id=36159

Refactoring only, so no new tests.

  • WebView/WebFrame.mm: (-[WebFrame _computePageRectsWithPrintWidthScaleFactor:printHeight:]):
1:20 PM Changeset in webkit [56453] by eric@webkit.org
  • 4 edits in trunk

2010-03-24 Jeremy Moskovich <​jeremy@chromium.org>

Reviewed by Jeremy Orlow.

Add some diagnostics to try to track down cause of crash in ArchiveFactory::isArchiveMimeType().

​https://bugs.webkit.org/show_bug.cgi?id=36426

No new tests as there is no new functionality.

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::finishedLoadingDocument): Make copy of mimeType string to isolate crash.

2010-03-24 Jeremy Moskovich <​jeremy@chromium.org>

Reviewed by Jeremy Orlow.

Add some diagnostics to try to track down cause of crash in ArchiveFactory::isArchiveMimeType().

​https://bugs.webkit.org/show_bug.cgi?id=36426

  • src/ResourceHandle.cpp: Track state across ResourceHandle invocations. (WebCore::ResourceHandleInternal::ResourceHandleInternal): (WebCore::ResourceHandleInternal::): (WebCore::ResourceHandleInternal::start): (WebCore::ResourceHandleInternal::cancel): (WebCore::ResourceHandleInternal::didReceiveResponse): (WebCore::ResourceHandleInternal::didReceiveData): (WebCore::ResourceHandleInternal::didFinishLoading): (WebCore::ResourceHandleInternal::didFail):
1:02 PM Changeset in webkit [56452] by eric@webkit.org
  • 4 edits in trunk/WebCore

2010-03-24 Anton Muhin <​antonm@chromium.org>

Reviewed by Nate Chapin.

Use newly introduced SetPrototype method to deal with global objects.
​https://bugs.webkit.org/show_bug.cgi?id=36497

No new tests, should be covered by the current test infrastructure.

  • bindings/v8/V8DOMWindowShell.cpp: (WebCore::V8DOMWindowShell::installDOMWindow):
  • bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::getConstructor):
  • bindings/v8/WorkerContextExecutionProxy.cpp: (WebCore::WorkerContextExecutionProxy::initContextIfNeeded):
12:23 PM Changeset in webkit [56451] by dimich@chromium.org
  • 2 edits in trunk/WebCore

Unreviewed, Chromium build fix.

  • platform/chromium/PopupMenuChromium.cpp:

(WebCore::PopupContainer::PopupContainer): Fix order of initializers.
(WebCore::PopupContainer::layout): Remove unused variable.

12:05 PM Changeset in webkit [56450] by kenneth@webkit.org
  • 7 edits in trunk

WebCore: Add a way to check if the page client is making use of
a QWidget.

Reviewed by Simon Hausmann.

  • platform/qt/QWebPageClient.h:

(QWebPageClient::isQWidgetClient):

WebKit/qt: Calling setView on a QWebPage being shown by a QGraphicsWebView,
would uninstall the page client, resulting in not expected
behaviour.

Reviewed by Simon Hausmann.

  • Api/qwebpage.cpp:

(QWebPageWidgetClient::QWebPageWidgetClient):
(QWebPageWidgetClient::isQWidgetClient):
(QWebPageWidgetClient::screenNumber):
(QWebPage::QWebPage):
(QWebPage::setView):

11:41 AM Changeset in webkit [56449] by eric@webkit.org
  • 10 edits in trunk

2010-03-24 Jay Campan <​jcampan@google.com>

Reviewed by Darin Fisher.

Making Chromium select popups not steal activation from the browser.
Select popups are now like autocomplete popups, shown in non-activated
windows.
​https://bugs.webkit.org/show_bug.cgi?id=36062

  • page/chromium/ChromeClientChromium.h:
  • platform/chromium/PopupMenuChromium.cpp: (WebCore::): (WebCore::PopupListBox::setMaxHeight): (WebCore::PopupListBox::disconnectClient): (WebCore::PopupListBox::PopupListBox): (WebCore::PopupContainer::create): (WebCore::PopupContainer::PopupContainer): (WebCore::PopupContainer::showPopup): (WebCore::PopupContainer::showExternal): (WebCore::PopupContainer::hidePopup): (WebCore::PopupContainer::layout): (WebCore::PopupContainer::chromeClientChromium): (WebCore::PopupListBox::hidePopup): (WebCore::PopupListBox::layout): (WebCore::PopupMenu::~PopupMenu): (WebCore::PopupMenu::show):
  • platform/chromium/PopupMenuChromium.h: (WebCore::PopupItem::): (WebCore::PopupItem::PopupItem): (WebCore::PopupContainerSettings::): (WebCore::PopupContainer::): (WebCore::PopupContainer::listBox): (WebCore::PopupContainer::popupType):

2010-03-24 Jay Campan <​jcampan@google.com>

Reviewed by Darin Fisher.

Making Chromium select popups not steal activation from the browser.
Select popups are now like autocomplete popups, shown in non-activated
windows.
​https://bugs.webkit.org/show_bug.cgi?id=36062

  • public/WebViewClient.h: (WebKit::WebViewClient::createPopupMenu):
  • src/ChromeClientImpl.cpp: (WebKit::ChromeClientImpl::popupOpened): (WebKit::ChromeClientImpl::popupClosed):
  • src/ChromeClientImpl.h:
  • src/WebViewImpl.cpp: (WebKit::): (WebKit::WebViewImpl::mouseDown): (WebKit::WebViewImpl::keyEvent): (WebKit::WebViewImpl::selectPopupHandleKeyEvent): (WebKit::WebViewImpl::hideSelectPopup): (WebKit::WebViewImpl::popupOpened): (WebKit::WebViewImpl::popupClosed): (WebKit::WebViewImpl::setFocus): (WebKit::WebViewImpl::applyAutoFillSuggestions): (WebKit::WebViewImpl::applyAutocompleteSuggestions):
  • src/WebViewImpl.h:
11:11 AM Changeset in webkit [56448] by apavlov@chromium.org
  • 2 edits in trunk/WebKit/chromium

2010-03-24 Alexander Pavlov <​apavlov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: [Chromium] Audits never complete
​https://bugs.webkit.org/show_bug.cgi?id=36544

  • src/js/InspectorControllerImpl.js: (devtools.InspectorBackendImpl):
10:50 AM Changeset in webkit [56447] by levin@chromium.org
  • 8 edits in trunk/WebCore

Need to move items that CanvasRenderingContext2D depends on into CanvasSurface.
​https://bugs.webkit.org/show_bug.cgi?id=35453

Reviewed by Oliver Hunt.

Prepartory changes to allow for an OffscreenCanvas which may be used in a worker
or outside of the DOM.

No change in functionality, so new tests.

  • dom/CanvasSurface.cpp: Moved functionality that CanvasRenderingContext2D depends on

into this class (and removed dependencies on document/html element).
(WebCore::CanvasSurface::CanvasSurface):
(WebCore::CanvasSurface::~CanvasSurface): Put the desctructor in the cpp file
to avoid needing access to ~ImageBuffer in the header file.
(WebCore::CanvasSurface::setSurfaceSize): Does basic items needed
when the size changes. It is protected to force outside callers to go
through HTMLCanvasElement::setSize.
(WebCore::CanvasSurface::toDataURL): Just moved from HTMLCanvasElement and
made a note about a method to fix for worker usage.
(WebCore::CanvasSurface::willDraw): Made this virtual to allow an overide
which uses the renderbox and tracks a dirtyRect.
(WebCore::CanvasSurface::convertLogicalToDevice): Moved and changed to
rely on a member variable for page scale (to avoid using the document).
(WebCore::CanvasSurface::createImageBuffer):
(WebCore::CanvasSurface::drawingContext): Simple move from HTMLCanvasElement.
(WebCore::CanvasSurface::buffer): Ditto.
(WebCore::CanvasSurface::baseTransform): Ditto.

  • dom/CanvasSurface.h:

(WebCore::CanvasSurface::width): Simple move from HTMLCanvasElement.
(WebCore::CanvasSurface::height): Ditto.
(WebCore::CanvasSurface::size): Ditto.
(WebCore::CanvasSurface::setOriginTainted): Ditto.
(WebCore::CanvasSurface::originClean): Ditto.
(WebCore::CanvasSurface::hasCreatedImageBuffer): Ditto (with small name change).

  • html/HTMLCanvasElement.cpp:

(WebCore::HTMLCanvasElement::HTMLCanvasElement): Pass in the scale factor to CanvasSurface
so it doesn't need the document.
(WebCore::HTMLCanvasElement::willDraw): Moved the relevant portion to CanvasSurface.
(WebCore::HTMLCanvasElement::reset): Small changes due to refactoring.
(WebCore::HTMLCanvasElement::paint): Ditto.

  • html/HTMLCanvasElement.h:

(WebCore::HTMLCanvasElement::setSize): Ditto.

  • platform/MIMETypeRegistry.cpp:

(WebCore::MIMETypeRegistry::isSupportedImageMIMETypeForEncoding): Added assert
to verify that this is only called on the main thread.

  • platform/graphics/Image.cpp:

(WebCore::Image::nullImage): Ditto.

  • platform/graphics/cg/ImageBufferCG.cpp:

(WebCore::utiFromMIMEType): Ditto.

10:21 AM Changeset in webkit [56446] by apavlov@chromium.org
  • 6 edits in trunk

2010-03-24 Alexander Pavlov <​apavlov@chromium.org>

Reviewed by Pavel Feldman.

Inspector: XML Tags should not be converted to lowercase
​https://bugs.webkit.org/show_bug.cgi?id=28600

LayoutTests:

  • inspector/elements-panel-xhtml-structure-expected.txt:
  • inspector/elements-panel-xhtml-structure.xhtml:

WebCore:

  • inspector/front-end/ElementsPanel.js: (WebInspector.ElementsPanel.prototype.updateBreadcrumb): (WebInspector.ElementsPanel.prototype.decorateNodeLabel):
  • inspector/front-end/ElementsTreeOutline.js: (WebInspector.ElementsTreeOutline.prototype.nodeNameToCorrectCase): (WebInspector.ElementsTreeElement.prototype._updateChildren): (WebInspector.ElementsTreeElement.prototype._nodeTitleInfo):
10:15 AM Changeset in webkit [56445] by kenneth@webkit.org
  • 17 edits
    5 adds in trunk

WebCore: Add support for DOM Level 3 Custom Event
​http://www.w3.org/TR/DOM-Level-3-Events

Reviewed by Antti Koivisto.

Test: fast/events/custom-event.html

  • DerivedSources.cpp:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pri:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSEventCustom.cpp:

(WebCore::toJS):

  • bindings/scripts/CodeGeneratorJS.pm:
  • bindings/scripts/CodeGeneratorV8.pm:
  • dom/CustomEvent.cpp: Added.

(WebCore::CustomEvent::CustomEvent):
(WebCore::CustomEvent::initCustomEvent):
(WebCore::CustomEvent::isCustomEvent):

  • dom/CustomEvent.h: Added.

(WebCore::CustomEvent::create):
(WebCore::CustomEvent::detail):

  • dom/Document.cpp:

(WebCore::Document::createEvent):

  • dom/Event.cpp:

(WebCore::Event::isCustomEvent):

  • dom/Event.h:

LayoutTests: Layout test for DOM Level 3 Custom Event
​http://www.w3.org/TR/DOM-Level-3-Events

Reviewed by Antti Koivisto.

  • fast/events/custom-event-expected.txt: Added.
  • fast/events/custom-event.html: Added.
9:56 AM Changeset in webkit [56444] by apavlov@chromium.org
  • 4 edits in trunk/WebCore

2010-03-24 Alexander Pavlov <​apavlov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Error when highlighting JavaScript with an invalid mime type
​https://bugs.webkit.org/show_bug.cgi?id=36530

  • inspector/front-end/SourceTokenizer.js: (WebInspector.SourceTokenizer.Registry):
  • inspector/front-end/SourceView.js: (WebInspector.SourceView.prototype._contentLoaded): (WebInspector.SourceView.prototype._canonicalMimeType):
  • inspector/front-end/TextEditorHighlighter.js: (WebInspector.TextEditorHighlighter):
9:33 AM QtWebKitBackportingFixes edited by Simon Hausmann
(diff)
9:28 AM QtWebKitRelease20 edited by Simon Hausmann
(diff)
9:25 AM Changeset in webkit [56443] by pfeldman@chromium.org
  • 2 edits in trunk/WebCore

2010-03-24 Pavel Feldman <​pfeldman@chromium.org>

Not reviewed. Chromium test fix: added a frameCount check to the
debugger function call.

  • bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::createUtilityContext):
8:47 AM Changeset in webkit [56442] by apavlov@chromium.org
  • 2 edits in trunk/WebKit/chromium

2010-03-24 Alexander Pavlov <​apavlov@chromium.org>

Reviewed by Pavel Feldman.

[Chromium] Fix VKEY_F10, VKEY_F11 translation in WebInputEvent.cpp
​https://bugs.webkit.org/show_bug.cgi?id=36524

  • src/WebInputEvent.cpp: (WebKit::staticKeyIdentifiers):
8:18 AM Porting Macros plan edited by efidler@rim.com
(diff)
7:11 AM Changeset in webkit [56441] by Csaba Osztrogonác
  • 3 edits in trunk/LayoutTests

Rubber-stamped by Simon Hausmann and Gustavo Noronha Silva.

[Qt][GTK] http/tests/xmlhttprequest/xmlhttprequest-onProgress-open-should-zero-length.html fails after r56394
​https://bugs.webkit.org/show_bug.cgi?id=36531

  • platform/gtk/Skipped: http/tests/xmlhttprequest/xmlhttprequest-onProgress-open-should-zero-length.html skipped until fix.
  • platform/qt/Skipped: http/tests/xmlhttprequest/xmlhttprequest-onProgress-open-should-zero-length.html skipped until fix.
6:25 AM QtWebKitBugs edited by vestbo@webkit.org
(diff)
6:21 AM ImprovingLifeOnWindows edited by Adam Roben
Removed section about detecting a missing Platform SDK. We now do this … (diff)
4:07 AM Changeset in webkit [56440] by Simon Hausmann
  • 2 edits in trunk/WebCore

[Qt] Support for QT_LIBINFIX in Symbian builds

Patch by Miikka Heikkinen <​miikka.heikkinen@digia.com> on 2010-03-19
Reviewed by Simon Hausmann.

Configuring Qt with -qtlibinfix parameter will enable installing
an alternate version of Qt on devices that already have it on ROM.
This patch provides support for infixed builds of Webkit.

  • WebCore.pro:
2:36 AM Changeset in webkit [56439] by tkent@chromium.org
  • 36 edits in trunk

2010-03-24 Kent Tamura <​tkent@chromium.org>

Reviewed by Darin Adler.

Make Icon::createIconForFiles() optional.
​https://bugs.webkit.org/show_bug.cgi?id=35072

r54923 made Icon::createIconForFiles() deprecated. However moving
existing icon loading code to outside of WebCore is not good. So,
we assume:

  • ChromeClient::chooseIconForFiles(), renamed from iconForFiles(), is the primary API to load icons.
  • Icon::createIconForFiles() is an optional API to help implementing ChromeClient::iconForFiles().

This patch removes a call to Icon::createIconForFiles() from
FileChooser::loadIcon(), and ChromeClient::chooseIconForFiles() of
non-Chromium ports calls Icon::createIconForFiles().

  • WebCore.base.exp: Export FileChooser::iconLoaded(), Icon::createIconForFiles(), and Icon::~Icon().
  • WebCore.xcodeproj/project.pbxproj: Export Icon.h
  • loader/EmptyClient.h: Rename iconForFiles() to chooseIconForFiles().
  • page/Chrome.cpp: ditto.
  • page/Chrome.h: ditto.
  • page/ChromeClient.h: ditto.
  • platform/FileChooser.cpp: (WebCore::FileChooser::loadIcon):
  • platform/graphics/Icon.h: Remove a comment on createIconForFiles().
  • platform/graphics/chromium/IconChromiumLinux.cpp: Remove createIconForFiles().
  • platform/graphics/chromium/IconChromiumMac.cpp: ditto.
  • platform/graphics/chromium/IconChromiumWin.cpp: ditto.
  • rendering/RenderFileUploadControl.cpp: Rename iconForFiles() to chooseIconForFiles().
  • rendering/RenderFileUploadControl.h: ditto.

2010-03-24 Kent Tamura <​tkent@chromium.org>

Reviewed by Darin Adler.

Make Icon::createIconForFiles() optional.
​https://bugs.webkit.org/show_bug.cgi?id=35072

  • Rename iconForFiles() to chooseIconForFiles().
  • Call Icon::createIconForFiles() from chooseIconForFiles().
  • src/ChromeClientImpl.cpp: (WebKit::ChromeClientImpl::chooseIconForFiles):
  • src/ChromeClientImpl.h:

2010-03-24 Kent Tamura <​tkent@chromium.org>

Reviewed by Darin Adler.

Make Icon::createIconForFiles() optional.
​https://bugs.webkit.org/show_bug.cgi?id=35072

  • Rename iconForFiles() to chooseIconForFiles().
  • Call Icon::createIconForFiles() from chooseIconForFiles().
  • WebCoreSupport/ChromeClientGtk.cpp:
  • WebCoreSupport/ChromeClientGtk.h:

2010-03-24 Kent Tamura <​tkent@chromium.org>

Reviewed by Darin Adler.

Make Icon::createIconForFiles() optional.
​https://bugs.webkit.org/show_bug.cgi?id=35072

  • Rename iconForFiles() to chooseIconForFiles().
  • Call Icon::createIconForFiles() from chooseIconForFiles().
  • WebCoreSupport/ChromeClientHaiku.cpp: (WebCore::ChromeClientHaiku::chooseIconForFiles):
  • WebCoreSupport/ChromeClientHaiku.h:

2010-03-24 Kent Tamura <​tkent@chromium.org>

Reviewed by Darin Adler.

Make Icon::createIconForFiles() optional.
​https://bugs.webkit.org/show_bug.cgi?id=35072

  • Rename iconForFiles() to chooseIconForFiles().
  • Call Icon::createIconForFiles() from chooseIconForFiles().
  • WebCoreSupport/WebChromeClient.h:
  • WebCoreSupport/WebChromeClient.mm: (WebChromeClient::chooseIconForFiles):

2010-03-24 Kent Tamura <​tkent@chromium.org>

Reviewed by Darin Adler.

Make Icon::createIconForFiles() optional.
​https://bugs.webkit.org/show_bug.cgi?id=35072

  • Rename iconForFiles() to chooseIconForFiles().
  • Call Icon::createIconForFiles() from chooseIconForFiles().
  • WebCoreSupport/ChromeClientQt.cpp: (WebCore::ChromeClientQt::chooseIconForFiles):
  • WebCoreSupport/ChromeClientQt.h:

2010-03-24 Kent Tamura <​tkent@chromium.org>

Reviewed by Darin Adler.

Make Icon::createIconForFiles() optional.
​https://bugs.webkit.org/show_bug.cgi?id=35072

  • Rename iconForFiles() to chooseIconForFiles().
  • Call Icon::createIconForFiles() from chooseIconForFiles().
  • WebCoreSupport/WebChromeClient.cpp: (WebChromeClient::chooseIconForFiles):
  • WebCoreSupport/WebChromeClient.h:

2010-03-24 Kent Tamura <​tkent@chromium.org>

Reviewed by Darin Adler.

Make Icon::createIconForFiles() optional.
​https://bugs.webkit.org/show_bug.cgi?id=35072

  • Rename iconForFiles() to chooseIconForFiles().
  • Call Icon::createIconForFiles() from chooseIconForFiles().
  • WebKitSupport/ChromeClientWx.cpp: (WebCore::ChromeClientWx::chooseIconForFiles):
  • WebKitSupport/ChromeClientWx.h:
1:43 AM QtWebKitFeaturePlanning edited by Henry Haverinen
(diff)
1:36 AM QtWebKitFeaturePlanning created by Henry Haverinen
1:35 AM Changeset in webkit [56438] by barraclough@apple.com
  • 2 edits in trunk/JavaScriptCore

Bug 36519 - JSGlobalContextRelease is unnecessarily slow

Reviewed by Oliver Hunt.

Since [ ​http://trac.webkit.org/changeset/35917 ], calling
JSGlobalContextRelease always triggers a GC heap collection
(if not a full destroy). As per 35917's changelog "This is
only really necessary when the (JSGlobalObject's) last
reference is released, but there is no way to determine that,
and no harm in collecting slightly more often."

Well, we now know of cases of API clients who are harmed by
the performance penalty of collecting too often, so it's time
to add a way to determine whether a call to JSGlobalContextRelease
is removing the last protect from it's global object. If further
protects are retaining the global object (likely from other
JSGlobalContextRefs), then don't trigger a GC collection.

  • API/JSContextRef.cpp:
  • runtime/Collector.cpp:

(JSC::Heap::unprotect): return a boolean indicating that the value is now unprotected.

  • runtime/Collector.h:
  • wtf/HashCountedSet.h:

(WTF::::remove): return a boolean indicating whether the value was removed from the set.

12:50 AM Changeset in webkit [56437] by Chris Jerdonek
  • 6 edits in trunk/WebKitTools

Added to check-webkit-style support for a --debug flag.

Reviewed by Shinichiro Hamaji.

​https://bugs.webkit.org/show_bug.cgi?id=36100

The --debug flag adjusts the logging level to DEBUG and
includes the logger name and level in each log message.

  • Scripts/check-webkit-style:
    • Changed the code to check for the --debug flag and pass the result to the configure_logging() method.
  • Scripts/webkitpy/style/checker.py:
    • Added an is_debug parameter to configure_logging().
    • Refactored configure_logging() by adding calls to the following two methods: _create_log_handlers() and _create_debug_log_handlers().
  • Scripts/webkitpy/style/checker_unittest.py:
    • Added unit tests for configure_logging() with is_debug True by splitting the ConfigureLoggingTest class into ConfigureLoggingTest and ConfigureLoggingTestBase, and adding ConfigureLoggingDebugTest.
  • Scripts/webkitpy/style/optparser.py:
    • Updated the usage string.
    • Added an is_debug data attribute to the CommandOptionValues class.
    • Added support for the --debug flag to the ArgumentParser.parse() method.
    • Also added extra error information to the parse() method in the case of an invalid flag.
  • Scripts/webkitpy/style/optparser_unittest.py:
    • Updated the unit tests as necessary.
    • Also fixed an issue with the CommandOptionValuesTest.test_eq() unit test.
12:46 AM Changeset in webkit [56436] by barraclough@apple.com
  • 2 edits in trunk/JavaScriptCore

Bug 36519 - JSGlobalContextRelease is unnecessarily slow

Reviewed by Oliver Hunt.

Since [ ​http://trac.webkit.org/changeset/35917 ], calling
JSGlobalContextRelease always triggers a GC heap collection
(if not a full destroy). As per 35917's changelog "This is
only really necessary when the (JSGlobalObject's) last
reference is released, but there is no way to determine that,
and no harm in collecting slightly more often."

Well, we now know of cases of API clients who are harmed by
the performance penalty of collecting too often, so it's time
to add a way to determine whether a call to JSGlobalContextRelease
is removing the last protect from it's global object. If further
protects are retaining the global object (likely from other
JSGlobalContextRefs), then don't trigger a GC collection.

  • API/JSContextRef.cpp:
  • runtime/Collector.cpp:

(JSC::Heap::unprotect): return a boolean indicating that the value is now unprotected.

  • runtime/Collector.h:
  • wtf/HashCountedSet.h:

(WTF::::remove): return a boolean indicating whether the value was removed from the set.

12:42 AM QtWebKit edited by Henry Haverinen
(diff)
12:11 AM Changeset in webkit [56435] by barraclough@apple.com
  • 5 edits in trunk/JavaScriptCore

Bug 36519 - JSGlobalContextRelease is unnecessarily slow

Reviewed by Oliver Hunt.

Since [ ​http://trac.webkit.org/changeset/35917 ], calling
JSGlobalContextRelease always triggers a GC heap collection
(if not a full destroy). As per 35917's changelog "This is
only really necessary when the (JSGlobalObject's) last
reference is released, but there is no way to determine that,
and no harm in collecting slightly more often."

Well, we now know of cases of API clients who are harmed by
the performance penalty of collecting too often, so it's time
to add a way to determine whether a call to JSGlobalContextRelease
is removing the last protect from it's global object. If further
protects are retaining the global object (likely from other
JSGlobalContextRefs), then don't trigger a GC collection.

  • API/JSContextRef.cpp:
  • runtime/Collector.cpp:

(JSC::Heap::unprotect): return a boolean indicating that the value is now unprotected.

  • runtime/Collector.h:
  • wtf/HashCountedSet.h:

(WTF::::remove): return a boolean indicating whether the value was removed from the set.

Note: See TracTimeline for information about the timeline view.