Context Navigation

← Previous Period
Next Period →

Timeline

Mar 26, 2010:

10:44 PM Changeset in webkit [56658] by abarth@webkit.org

10 edits
2 copies in trunk/WebKitTools

2010-03-26 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Add some basic IRC commands to sheriffbot
https://bugs.webkit.org/show_bug.cgi?id=36684

Adds support for sheriffbot to respond to a "hi" command and a
"last-green-revision" command. It's lame that we're rebuilding
MultiCommandTool, but as discussed in person we'll intergrate the two
once we see what the requirements are.

Scripts/webkitpy/tool/bot/irc_command.py: Added.
Scripts/webkitpy/tool/bot/queueengine.py:
Scripts/webkitpy/tool/bot/queueengine_unittest.py:
Scripts/webkitpy/tool/bot/sheriffircbot.py:
Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py: Added.
Scripts/webkitpy/tool/commands/queues.py:
Scripts/webkitpy/tool/commands/queuestest.py:
Scripts/webkitpy/tool/commands/sheriffbot.py:
Scripts/webkitpy/tool/main.py:
Scripts/webkitpy/tool/mocktool.py:
Scripts/webkitpy/tool/unittests.py:

10:42 PM Changeset in webkit [56657] by abarth@webkit.org

2 edits in trunk/WebKitTools

2010-03-26 Adam Barth <abarth@webkit.org>

Unreviewed. More errors in the IRC module. I have no idea how to test
ircbot.py, which is too bad. Hopefully we've abstracted it away enough
that we don't have to touch it very much after this patch.

Scripts/webkitpy/common/net/irc/ircbot.py:

10:37 PM Changeset in webkit [56656] by abarth@webkit.org

3 edits
1 copy in trunk/WebKitTools

2010-03-26 Adam Barth <abarth@webkit.org>

Unreviewed. Add a missing "_".

Scripts/webkitpy/common/net/irc/ircproxy.py:
Scripts/webkitpy/common/net/irc/ircproxy_unittest.py: Added.
Scripts/webkitpy/common/net/irc/unittests.py:

10:08 PM Changeset in webkit [56655] by dbates@webkit.org

7 edits
68 adds in trunk

2010-03-26 Daniel Bates <dbates@rim.com>

Reviewed by Beth Dakin.

https://bugs.webkit.org/show_bug.cgi?id=9268

As per sections 14.2 (http://www.w3.org/TR/CSS2/colors.html#background)
and 17.5.1 (http://www.w3.org/TR/CSS2/tables.html#table-layers) of the
CSS 2.1 spec., the background-image of a table-row should span the
entire area of the table-row (i.e cover all the <td>'s). Moreover,
fixes background image painting with respect to row-groups, columns
and column-groups (*).

Currently, the background-image of a table row, row-group, and column-group
is inherited by the table cells. This directly contradicts section 14.2.
Instead, the background-image should cover the entire area of the table row,
row-group, column, or column-group, respectively as described in section 17.5.1.

(*) A follow up patch to compute the absolute content box of a column, and
column-group is needed so that background image positioning for these table
elements works. See bug #36104.

Tests: fast/table/table-background.html

fast/table/table-cell-border-draws-on-top-of-col-background.html
fast/table/table-cell-border-draws-on-top-of-col-group-background.html
fast/table/table-cell-border-draws-on-top-of-row-background.html
fast/table/table-cell-border-draws-on-top-of-row-group-background.html
fast/table/table-cell-overrides-row-background.html
fast/table/table-col-background.html
fast/table/table-col-group-background.html
fast/table/table-col-group-col-span-background.html
fast/table/table-col-group-span-background.html
fast/table/table-col-span-background.html
fast/table/table-row-background-left-50px.html
fast/table/table-row-background-right-100percent.html
fast/table/table-row-background-right-50px.html
fast/table/table-row-background.html
fast/table/table-row-group-background-positioned.html
fast/table/table-row-group-background.html

rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelObject::paintFillLayerExtended): (WebCore::RenderBoxModelObject::calculateBackgroundImageGeometry): Modified to call RenderObject::adjustBackgroundImagePosition.
rendering/RenderBoxModelObject.h:
rendering/RenderObject.h: (WebCore::RenderObject::adjustBackgroundImagePosition): Added.
rendering/RenderTableCell.cpp: (WebCore::RenderTableCell::adjustBackgroundImagePosition): Added.
rendering/RenderTableCell.h:

2010-03-26 Daniel Bates <dbates@rim.com>

Reviewed by Beth Dakin.

https://bugs.webkit.org/show_bug.cgi?id=9268

Tests that background-image support for table, table-cell, table-row,
row-group, table-column and column-group (*) conform to section 17.5.1
of the CSS 2.1 spec.

(*) A follow up patch to compute the absolute content box of a column, and
column-group is needed so that background image positioning for these table
elements works. See bug #36104.

fast/table/table-background.html: Added.
fast/table/table-cell-border-draws-on-top-of-col-background.html: Added.
fast/table/table-cell-border-draws-on-top-of-col-group-background.html: Added.
fast/table/table-cell-border-draws-on-top-of-row-background.html: Added.
fast/table/table-cell-border-draws-on-top-of-row-group-background.html: Added.
fast/table/table-cell-overrides-row-background.html: Added.
fast/table/table-col-background.html: Added.
fast/table/table-col-group-background.html: Added.
fast/table/table-col-group-col-span-background.html: Added.
fast/table/table-col-group-span-background.html: Added.
fast/table/table-col-span-background.html: Added.
fast/table/table-row-background-left-50px.html: Added.
fast/table/table-row-background-right-100percent.html: Added.
fast/table/table-row-background-right-50px.html: Added.
fast/table/table-row-background.html: Added.
fast/table/table-row-group-background-positioned.html: Added.
fast/table/table-row-group-background.html: Added.
platform/mac/fast/table/table-background-expected.checksum: Added.
platform/mac/fast/table/table-background-expected.png: Added.
platform/mac/fast/table/table-background-expected.txt: Added.
platform/mac/fast/table/table-cell-border-draws-on-top-of-col-background-expected.checksum: Added.
platform/mac/fast/table/table-cell-border-draws-on-top-of-col-background-expected.png: Added.
platform/mac/fast/table/table-cell-border-draws-on-top-of-col-background-expected.txt: Added.
platform/mac/fast/table/table-cell-border-draws-on-top-of-col-group-background-expected.checksum: Added.
platform/mac/fast/table/table-cell-border-draws-on-top-of-col-group-background-expected.png: Added.
platform/mac/fast/table/table-cell-border-draws-on-top-of-col-group-background-expected.txt: Added.
platform/mac/fast/table/table-cell-border-draws-on-top-of-row-background-expected.checksum: Added.
platform/mac/fast/table/table-cell-border-draws-on-top-of-row-background-expected.png: Added.
platform/mac/fast/table/table-cell-border-draws-on-top-of-row-background-expected.txt: Added.
platform/mac/fast/table/table-cell-border-draws-on-top-of-row-group-background-expected.checksum: Added.
platform/mac/fast/table/table-cell-border-draws-on-top-of-row-group-background-expected.png: Added.
platform/mac/fast/table/table-cell-border-draws-on-top-of-row-group-background-expected.txt: Added.
platform/mac/fast/table/table-cell-overrides-row-background-expected.checksum: Added.
platform/mac/fast/table/table-cell-overrides-row-background-expected.png: Added.
platform/mac/fast/table/table-cell-overrides-row-background-expected.txt: Added.
platform/mac/fast/table/table-col-background-expected.checksum: Added.
platform/mac/fast/table/table-col-background-expected.png: Added.
platform/mac/fast/table/table-col-background-expected.txt: Added.
platform/mac/fast/table/table-col-group-background-expected.checksum: Added.
platform/mac/fast/table/table-col-group-background-expected.png: Added.
platform/mac/fast/table/table-col-group-background-expected.txt: Added.
platform/mac/fast/table/table-col-group-col-span-background-expected.checksum: Added.
platform/mac/fast/table/table-col-group-col-span-background-expected.png: Added.
platform/mac/fast/table/table-col-group-col-span-background-expected.txt: Added.
platform/mac/fast/table/table-col-group-span-background-expected.checksum: Added.
platform/mac/fast/table/table-col-group-span-background-expected.png: Added.
platform/mac/fast/table/table-col-group-span-background-expected.txt: Added.
platform/mac/fast/table/table-col-span-background-expected.checksum: Added.
platform/mac/fast/table/table-col-span-background-expected.png: Added.
platform/mac/fast/table/table-col-span-background-expected.txt: Added.
platform/mac/fast/table/table-row-background-expected.checksum: Added.
platform/mac/fast/table/table-row-background-expected.png: Added.
platform/mac/fast/table/table-row-background-expected.txt: Added.
platform/mac/fast/table/table-row-background-left-50px-expected.checksum: Added.
platform/mac/fast/table/table-row-background-left-50px-expected.png: Added.
platform/mac/fast/table/table-row-background-left-50px-expected.txt: Added.
platform/mac/fast/table/table-row-background-right-100percent-expected.checksum: Added.
platform/mac/fast/table/table-row-background-right-100percent-expected.png: Added.
platform/mac/fast/table/table-row-background-right-100percent-expected.txt: Added.
platform/mac/fast/table/table-row-background-right-50px-expected.checksum: Added.
platform/mac/fast/table/table-row-background-right-50px-expected.png: Added.
platform/mac/fast/table/table-row-background-right-50px-expected.txt: Added.
platform/mac/fast/table/table-row-group-background-expected.checksum: Added.
platform/mac/fast/table/table-row-group-background-expected.png: Added.
platform/mac/fast/table/table-row-group-background-expected.txt: Added.
platform/mac/fast/table/table-row-group-background-positioned-expected.checksum: Added.
platform/mac/fast/table/table-row-group-background-positioned-expected.png: Added.
platform/mac/fast/table/table-row-group-background-positioned-expected.txt: Added.

10:00 PM Changeset in webkit [56654] by abarth@webkit.org

2 edits in trunk/WebKitTools

2010-03-26 Adam Barth <abarth@webkit.org>

Unreviewed. Fix a the commit queue after my recent change.

Scripts/webkitpy/tool/bot/queueengine.py:

9:31 PM Changeset in webkit [56653] by Laszlo Gombos

2 edits in trunk/WebCore

2010-03-26 Laszlo Gombos <Laszlo Gombos>

Unreviewed, minor build fix.

[Gtk] Guard defined but not used function

Eliminate the "defined but not used" warning after r52684.
No new tests as there is no new functionality.

platform/ContextMenu.cpp:

7:38 PM Changeset in webkit [56652] by dpranke@chromium.org

2 edits in trunk/WebKitTools

2010-03-26 Dirk Pranke <dpranke@chromium.org>

Unreviewed fix.

Fix the return value for port/base.diff_image (changed from 1/0 to
True/False in bug 34826.

Scripts/webkitpy/layout_tests/port/base.py:

7:15 PM Changeset in webkit [56651] by abarth@webkit.org

5 edits
2 adds in trunk

2010-03-26 Justin Schuh <jschuh@chromium.org>

Reviewed by Adam Barth.

Security: iFrame.src accepts JavaScript URL via nodeValue or textContent
https://bugs.webkit.org/show_bug.cgi?id=36502

Overrode inherited nodeValue and textContent in Attr.idl so they proxy
to value, which performs a security check.

http/tests/security/xss-DENIED-iframe-src-alias-expected.txt: Added.
http/tests/security/xss-DENIED-iframe-src-alias.html: Added.

2010-03-26 Justin Schuh <jschuh@chromium.org>

Reviewed by Adam Barth.

Security: iFrame.src accepts JavaScript URL via nodeValue or textContent
https://bugs.webkit.org/show_bug.cgi?id=36502

Overrode inherited nodeValue and textContent in Attr.idl so they proxy
to value, which performs a security check.

Test: http/tests/security/xss-DENIED-iframe-src-alias.html

bindings/js/JSAttrCustom.cpp: (WebCore::JSAttr::nodeValue): (WebCore::JSAttr::setNodeValue): (WebCore::JSAttr::textContent): (WebCore::JSAttr::setTextContent):
bindings/v8/custom/V8AttrCustom.cpp: (WebCore::V8Attr::nodeValueAccessorSetter): (WebCore::V8Attr::nodeValueAccessorGetter): (WebCore::V8Attr::textContentAccessorSetter): (WebCore::V8Attr::textContentAccessorGetter):
dom/Attr.idl:

6:20 PM Changeset in webkit [56650] by eric.carlson@apple.com

12 edits in trunk/WebCore

2010-03-26 Eric Carlson <eric.carlson@apple.com>

<rdar://problem/7320584>
https://bugs.webkit.org/show_bug.cgi?id=36681
"new Audio()" doesn't work with plug-in backed media engine.

Don't require plug-in backed <video> and <audio> elements to be in the document to play.

html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::HTMLMediaElement): Initialize m_proxyWidget (WebCore::HTMLMediaElement::createRenderer): Set renderer widget if it has already been allocated. (WebCore::HTMLMediaElement::scheduleLoad): Call createMediaPlayerProxy to make sure we have a plug-in proxy. (WebCore::HTMLMediaElement::loadResource): Ditto. (WebCore::HTMLMediaElement::allocateMediaPlayerIfNecessary): Allocate media player. (WebCore::HTMLMediaElement::setMediaPlayerProxy): Call allocateMediaPlayerIfNecessary. (WebCore::HTMLMediaElement::getPluginProxyParams): New, return the url and params vectors. (WebCore::HTMLMediaElement::finishParsingChildren): Call createMediaPlayerProxy. (WebCore::HTMLMediaElement::createMediaPlayerProxy): New, allocate the proxy widget if necessary.
html/HTMLMediaElement.h:

loader/EmptyClients.h: (WebCore::EmptyFrameLoaderClient::createMediaPlayerProxyPlugin): Add declaration.

loader/FrameLoader.cpp: (WebCore::toPlugInElement): Don't allow an audio or video element to be cast to a plug-in element. (WebCore::FrameLoader::loadPlugin): (WebCore::FrameLoader::loadMediaPlayerProxyPlugin): New, allocate a media player proxy plug-in.

loader/FrameLoader.h: Declare loadMediaPlayerProxyPlugin.

loader/FrameLoaderClient.h: Declare createMediaPlayerProxyPlugin.

rendering/RenderEmbeddedObject.cpp: (WebCore::RenderEmbeddedObject::updateWidget): Call loadMediaPlayerProxyPlugin when passed an audio or video node.

rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::requiresCompositingForVideo):

rendering/RenderVideo.cpp: (WebCore::RenderVideo::RenderVideo): Get default width and height from defaultSize. (WebCore::RenderVideo::defaultSize): New, return the spec defined default width and height.
rendering/RenderVideo.h:

6:11 PM Changeset in webkit [56649] by dpranke@chromium.org

134 edits
2 adds in trunk/LayoutTests

2010-03-26 Dirk Pranke <dpranke@chromium.org>

Reviewed by David Levin.

Update a bunch of incorrect image checksums, and suppress all of the
remaining IMAGE failures in platform/mac/test_expectations.txt.

https://bugs.webkit.org/show_bug.cgi?id=36620

platform/mac-leopard/compositing/geometry/root-layer-update-expected.checksum:
platform/mac-leopard/compositing/overflow/overflow-positioning-expected.checksum:
platform/mac-leopard/compositing/repaint/become-overlay-composited-layer-expected.checksum:
platform/mac-leopard/compositing/repaint/layer-repaint-rects-expected.checksum:
platform/mac-leopard/media/video-zoom-controls-expected.checksum:
platform/mac/animations/3d/change-transform-in-end-event-expected.checksum:
platform/mac/animations/3d/state-at-end-event-transform-expected.checksum:
platform/mac/animations/state-at-end-event-expected.checksum:
platform/mac/compositing/animation/state-at-end-event-transform-layer-expected.checksum:
platform/mac/compositing/color-matching/pdf-image-match-expected.checksum:
platform/mac/compositing/compositing-visible-descendant-expected.checksum:
platform/mac/compositing/generated-content-expected.checksum:
platform/mac/compositing/geometry/abs-position-inside-opacity-expected.checksum:
platform/mac/compositing/geometry/fixed-position-expected.checksum:
platform/mac/compositing/geometry/horizontal-scroll-composited-expected.checksum:
platform/mac/compositing/geometry/outline-change-expected.checksum:
platform/mac/compositing/geometry/partial-layout-update-expected.checksum:
platform/mac/compositing/geometry/root-layer-update-expected.checksum:
platform/mac/compositing/geometry/transfrom-origin-on-zero-size-layer-expected.checksum:
platform/mac/compositing/masks/direct-image-mask-expected.checksum:
platform/mac/compositing/masks/masked-ancestor-expected.checksum:
platform/mac/compositing/masks/multiple-masks-expected.checksum:
platform/mac/compositing/masks/simple-composited-mask-expected.checksum:
platform/mac/compositing/overflow/ancestor-overflow-expected.checksum:
platform/mac/compositing/overflow/fixed-position-ancestor-clip-expected.checksum:
platform/mac/compositing/overflow/overflow-positioning-expected.checksum:
platform/mac/compositing/overflow/parent-overflow-expected.checksum:
platform/mac/compositing/overflow/scrollbar-painting-expected.checksum:
platform/mac/compositing/reflections/reflection-in-composited-expected.checksum:
platform/mac/compositing/reflections/reflection-ordering-expected.checksum:
platform/mac/compositing/reflections/simple-composited-reflections-expected.checksum:
platform/mac/compositing/repaint/become-overlay-composited-layer-expected.checksum:
platform/mac/compositing/repaint/content-into-overflow-expected.checksum:
platform/mac/compositing/repaint/layer-repaint-expected.checksum:
platform/mac/compositing/repaint/layer-repaint-rects-expected.checksum:
platform/mac/compositing/repaint/opacity-between-absolute-expected.checksum:
platform/mac/compositing/repaint/opacity-between-absolute2-expected.checksum:
platform/mac/compositing/repaint/overflow-into-content-expected.checksum:
platform/mac/compositing/sibling-positioning-expected.checksum:
platform/mac/compositing/transitions/singular-scale-transition-expected.checksum:
platform/mac/css2.1/t0905-c5525-flthw-00-c-g-expected.checksum:
platform/mac/css2.1/t0905-c5526-flthw-00-c-g-expected.checksum:
platform/mac/editing/deleting/delete-to-select-table-expected.checksum:
platform/mac/editing/deleting/type-delete-after-quote-expected.checksum:
platform/mac/editing/inserting/5418891-expected.checksum:
platform/mac/editing/selection/4960116-expected.checksum:
platform/mac/editing/selection/caret-rtl-2-expected.checksum:
platform/mac/editing/selection/extend-by-word-002-expected.checksum:
platform/mac/editing/selection/select-all-002-expected.checksum:
platform/mac/editing/selection/select-text-overflow-ellipsis-expected.checksum:
platform/mac/editing/selection/transformed-selection-rects-expected.checksum:
platform/mac/fast/backgrounds/background-clip-text-expected.checksum:
platform/mac/fast/backgrounds/quirks-mode-line-box-backgrounds-expected.checksum:
platform/mac/fast/backgrounds/repeat/mask-negative-offset-repeat-expected.checksum:
platform/mac/fast/backgrounds/size/backgroundSize15-expected.checksum:
platform/mac/fast/backgrounds/size/backgroundSize16-expected.checksum:
platform/mac/fast/backgrounds/size/contain-and-cover-expected.checksum: Added.
platform/mac/fast/backgrounds/svg-as-background-3-expected.checksum:
platform/mac/fast/backgrounds/svg-as-background-5-expected.checksum:
platform/mac/fast/backgrounds/svg-as-background-6-expected.checksum:
platform/mac/fast/backgrounds/svg-as-mask-expected.checksum:
platform/mac/fast/block/float/avoidance-percent-width-compat-expected.checksum:
platform/mac/fast/block/float/avoidance-percent-width-strict-expected.checksum:
platform/mac/fast/block/margin-collapse/103-expected.checksum:
platform/mac/fast/box-shadow/basic-shadows-expected.checksum:
platform/mac/fast/box-shadow/transform-fringing-expected.checksum:
platform/mac/fast/css/apple-prefix-expected.checksum:
platform/mac/fast/css/color-correction-backgrounds-and-text-expected.checksum:
platform/mac/fast/css/color-correction-expected.checksum:
platform/mac/fast/css/color-correction-on-background-image-expected.checksum:
platform/mac/fast/css/color-correction-on-backgrounds-expected.checksum:
platform/mac/fast/css/color-correction-on-box-shadow-expected.checksum:
platform/mac/fast/css/color-correction-on-text-expected.checksum:
platform/mac/fast/css/color-correction-on-text-shadow-expected.checksum:
platform/mac/fast/css/color-correction-untagged-images-expected.checksum:
platform/mac/fast/css/namespaces/namespaces-comments-expected.checksum:
platform/mac/fast/css/namespaces/namespaces-empty-expected.checksum:
platform/mac/fast/css/namespaces/namespaces-escapes-expected.checksum:
platform/mac/fast/css/namespaces/namespaces-invalid-at-expected.checksum:
platform/mac/fast/css/variables/misplaced-import-test-expected.checksum:
platform/mac/fast/encoding/invalid-UTF-8-expected.checksum:
platform/mac/fast/events/standalone-image-drag-to-editable-expected.checksum:
platform/mac/fast/fast-mobile-scrolling/fixed-position-element-expected.checksum:
platform/mac/fast/fast-mobile-scrolling/no-fixed-position-elements-expected.checksum:
platform/mac/fast/forms/001-expected.checksum:
platform/mac/fast/forms/menulist-clip-expected.checksum:
platform/mac/fast/forms/menulist-narrow-width-expected.checksum:
platform/mac/fast/forms/menulist-option-wrap-expected.checksum:
platform/mac/fast/forms/menulist-restrict-line-height-expected.checksum:
platform/mac/fast/forms/menulist-style-color-expected.checksum:
platform/mac/fast/forms/select-baseline-expected.checksum:
platform/mac/fast/forms/textarea-scrollbar-expected.checksum:
platform/mac/fast/frames/viewsource-attribute-expected.checksum:
platform/mac/fast/inline/long-wrapped-line-expected.checksum:
platform/mac/fast/lists/anonymous-items-expected.checksum:
platform/mac/fast/lists/markers-in-selection-expected.checksum:
platform/mac/fast/multicol/client-rects-expected.checksum: Added.
platform/mac/fast/multicol/float-multicol-expected.checksum:
platform/mac/fast/overflow/line-clamp-expected.checksum:
platform/mac/fast/overflow/position-fixed-transform-clipping-expected.checksum:
platform/mac/fast/reflections/abs-position-in-reflection-expected.checksum:
platform/mac/fast/reflections/opacity-reflection-transform-expected.checksum:
platform/mac/fast/repaint/backgroundSizeRepaint-expected.checksum:
platform/mac/fast/repaint/box-shadow-h-expected.checksum:
platform/mac/fast/repaint/box-shadow-v-expected.checksum:
platform/mac/fast/repaint/line-in-scrolled-clipped-block-expected.checksum:
platform/mac/fast/repaint/no-caret-repaint-in-non-content-editable-element-expected.checksum:
platform/mac/fast/repaint/rel-positioned-inline-with-overflow-expected.checksum:
platform/mac/fast/repaint/selection-gap-overflow-scroll-2-expected.checksum:
platform/mac/fast/repaint/subtree-layoutstate-transform-expected.checksum:
platform/mac/fast/repaint/table-outer-border-expected.checksum:
platform/mac/fast/table/fixed-table-with-percent-inside-percent-table-expected.checksum:
platform/mac/fast/table/fixed-table-with-percent-width-inside-auto-table-expected.checksum:
platform/mac/fast/table/fixed-table-with-percent-width-inside-div-expected.checksum:
platform/mac/fast/table/fixed-table-with-percent-width-inside-extra-large-div-expected.checksum:
platform/mac/fast/table/fixed-table-with-percent-width-inside-fixed-width-table-expected.checksum:
platform/mac/fast/table/fixed-table-with-small-percent-width-expected.checksum:
platform/mac/fast/text/atsui-partial-selection-expected.checksum:
platform/mac/fast/text/capitalize-boundaries-expected.checksum:
platform/mac/fast/text/drawBidiText-expected.checksum:
platform/mac/fast/text/line-breaking-with-kerning-expected.checksum:
platform/mac/fast/text/sticky-typesetting-features-expected.checksum:
platform/mac/fast/transforms/shadows-expected.checksum:
platform/mac/http/tests/misc/slow-loading-mask-expected.checksum:
platform/mac/media/video-zoom-controls-expected.checksum:
platform/mac/plugins/embed-attributes-style-expected.checksum:
platform/mac/plugins/qt-qwidget-plugin-expected.checksum:
platform/mac/tables/mozilla/bugs/bug106158-1-expected.checksum:
platform/mac/tables/mozilla/bugs/bug106158-2-expected.checksum:
platform/mac/tables/mozilla/bugs/bug34176-expected.checksum:
platform/mac/tables/mozilla/bugs/bug6674-expected.checksum:
platform/mac/test_expectations.txt:
platform/mac/transforms/2d/transform-fixed-container-expected.checksum:
platform/mac/transitions/move-after-transition-expected.checksum:
platform/mac/transitions/transition-end-event-rendering-expected.checksum:

5:15 PM Changeset in webkit [56648] by dpranke@chromium.org

3 edits
1 add in trunk

2010-03-25 Dirk Pranke <dpranke@chromium.org>

Reviewed by Eric Seidel.

Add a test_expectations.txt file for the mac platform so
new-run-webkit-tests can track IMAGE failures.

https://bugs.webkit.org/show_bug.cgi?id=36619

platform/mac/test_expectations.txt: Added.

2010-03-26 Dirk Pranke <dpranke@chromium.org>

Reviewed by Eric Seidel.

Change the Mac port of new-run-webkit-tests to look for a
test_expectations.txt file in addition to the Skipped files, so we
can track pixel failures.

https://bugs.webkit.org/show_bug.cgi?id=36619

Scripts/webkitpy/layout_tests/port/mac.py:

4:38 PM Changeset in webkit [56647] by dpranke@chromium.org

3 edits
1 add in trunk/WebKitTools

2010-03-26 Dirk Pranke <dpranke@chromium.org>

Reviewed by Eric Seidel.

Implement pixel tests (image diff) properly on the Mac port.

This change introduces a new "ServerPocess" class that can be used
to manage processes that the run-webkit-tests harness forks off and
expects to stay up for longer than a single request/response session.
Both DumpRenderTree and ImageDiff use this style of communication,
although the current code forks off a new ImageDiff for each diff
(We need to restructure other parts of the code to be able to do this
safely in a multi-threaded environment).

Also, now that the ServerProcess abstraction exists, we can probably
clean up and simplify some of the thread management logic in
test_shell_thread as well.

https://bugs.webkit.org/show_bug.cgi?id=34826

Scripts/webkitpy/layout_tests/port/mac.py:
Scripts/webkitpy/layout_tests/port/server_process.py:
Scripts/webkitpy/layout_tests/test_types/image_diff.py:

3:23 PM Changeset in webkit [56646] by Simon Fraser

7 edits
4 adds in trunk

2010-03-26 Simon Fraser <Simon Fraser>

Reviewed by Dan Bernstein, Darin Adler.

Re-entrant layout via plug-ins may cause crashes with bad RenderWidgets
https://bugs.webkit.org/show_bug.cgi?id=36675
<rdar://problem/7787617>

Fix two places in the code where RenderWidgets can get destroyed while being iterated over.
This can happen when plug-ins execute script from NPP_SetWindow, and that script makes a change
to the page that destroys a RenderWidget.

Tests: plugins/reentrant-update-widget-positions.html

plugins/update-widgets-crash.html

page/FrameView.cpp: (WebCore::FrameView::updateWidgets): ref() the RenderEmbeddedObjects that are put into the vector before iterating of them, and deref() them at the end. Rather than checking the m_widgetUpdateSet to see if the RenderWidget is still live, test object->node().

rendering/RenderView.cpp: (WebCore::RenderView::RenderView): Initialize some data members to make it more obvious in the debugger that the object is not garbage. (WebCore::RenderView::updateWidgetPositions): Use a Vector of RenderWidget* to keep the RenderWidgets alive during iteration, by reffing and dereffing them.
rendering/RenderWidget.h: (WebCore::RenderWidget::ref): Make this and deref() public.

3:16 PM Changeset in webkit [56645] by eric@webkit.org

2 edits in trunk/WebKitTools

2010-03-26 Sergio Villar Senin <svillar@igalia.com>

Reviewed by Eric Seidel.

Print didFinishLoadForFrame outcome in DRT

[GTK] Improve reporting of frame loader callbacks in DRT
https://bugs.webkit.org/show_bug.cgi?id=36454

DumpRenderTree/gtk/DumpRenderTree.cpp: (webViewLoadCommitted):

3:12 PM Changeset in webkit [56644] by Beth Dakin

4 edits in trunk

WebCore: Partial fix for https://bugs.webkit.org/show_bug.cgi?id=36564
Performance regression for setting content of <text> in SVG
-and corresponding-
<rdar://problem/7693963>

Reviewed by Darin Adler.

toClipPath() is extremely inefficient, so this patch removes the
call to it from RenderSVGResourceClipper::resourceBoundingBox()
which is very hot code in SVG with clip-paths. It is sufficient to
call unite with the objectBoundingBox(), which will return early if
objectBoundingBox() is empty.

rendering/RenderSVGResourceClipper.cpp:

(WebCore::RenderSVGResourceClipper::resourceBoundingBox):

LayoutTests: Updated test for https://bugs.webkit.org/show_bug.cgi?id=36564
Performance regression for setting content of <text> in SVG
-and corresponding-
<rdar://problem/7693963>

Reviewed by Darin Adler.

platform/mac/svg/custom/clip-path-referencing-use2-expected.txt:

2:51 PM Changeset in webkit [56643] by eric@webkit.org

2 edits in trunk/WebKitTools

2010-03-26 Eric Seidel <eric@webkit.org>

Unreviewed test fix.
My change conflicted with one of Adam's causing test-webkitpy to fail.

Move commit_message_for_this_commit from scm to checkout
https://bugs.webkit.org/show_bug.cgi?id=36629

Scripts/webkitpy/common/checkout/api_unittest.py:
- modified_changelogs is now on Checkout instead of scm.

2:45 PM Changeset in webkit [56642] by abarth@webkit.org

7 edits
1 copy
1 add in trunk/WebKitTools

2010-03-26 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Refactor IRCBot controller logic to allow for commands
https://bugs.webkit.org/show_bug.cgi?id=36676

We need to move the controller logic into the tool package so it can
know about commands. The changes to queueengine could go in a
different patch, but we're going to need it anyway.

Scripts/webkitpy/common/config/irc.py: Added.
Scripts/webkitpy/common/net/irc/ircbot.py:
Scripts/webkitpy/common/net/irc/ircproxy.py:
Scripts/webkitpy/tool/bot/queueengine.py:
Scripts/webkitpy/tool/bot/sheriffircbot.py: Added.
Scripts/webkitpy/tool/commands/sheriffbot.py:
Scripts/webkitpy/tool/main.py:
Scripts/webkitpy/tool/mocktool.py:

1:44 PM Changeset in webkit [56641] by Joseph Pecoraro

3 edits
6 adds in trunk

2010-03-26 Joseph Pecoraro <Joseph Pecoraro>

Reviewed by Dave Hyatt.

Generated run-in Content is Mistakenly Getting Deleted
https://bugs.webkit.org/show_bug.cgi?id=36505
<rdar://problem/7767161>

Test: fast/runin/generated2.html
Test: fast/runin/generated3.html
Test: fast/runin/generated4.html

Do not destroy :before/:after generated content with display run-in
when relaying out different nodes. Have their real owners correctly
handle them.

rendering/RenderObjectChildList.cpp: (WebCore::RenderObjectChildList::updateBeforeAfterContent): simplified logic (WebCore::RenderObjectChildList::beforeAfterContainer): skip generated run-ins when checking children, check for them in grandchildren

2010-03-26 Joseph Pecoraro <Joseph Pecoraro>

Reviewed by Dave Hyatt.

Generated run-in Content is Mistakenly Getting Deleted
https://bugs.webkit.org/show_bug.cgi?id=36505
<rdar://problem/7767161>

Test dynamic update of the inner block, containing the generated
run-in, but not owning it with the :before rule, and owners.

fast/runin/generated2.html: Added.
platform/mac/fast/runin/generated2-expected.txt: Added.

Test dynamic update of the outer block, this block owns the
generated run-in, but it is actually contained in a child block.

fast/runin/generated3.html: Added.
platform/mac/fast/runin/generated3-expected.txt: Added.

Test dynamic updates affecting generated run-ins both
in relation to and not in relation to list markers.

fast/runin/generated4.html: Added.
platform/mac/fast/runin/generated4-expected.txt: Added.

1:22 PM Changeset in webkit [56640] by abarth@webkit.org

5 edits
4 moves
3 adds in trunk/WebKitTools

2010-03-26 Adam Barth <abarth@webkit.org>

Rubber stamped by Eric Seidel.

Move the threading code into its own module. (It has nothing to do with IRC.)

Scripts/webkitpy/common/net/irc/ircbot.py:
Scripts/webkitpy/common/net/irc/ircproxy.py:
Scripts/webkitpy/common/net/irc/messagepump.py: Removed.
Scripts/webkitpy/common/net/irc/messagepump_unittest.py: Removed.
Scripts/webkitpy/common/net/irc/threadedmessagequeue.py: Removed.
Scripts/webkitpy/common/net/irc/threadedmessagequeue_unittest.py: Removed.
Scripts/webkitpy/common/net/irc/unittests.py:
Scripts/webkitpy/common/thread: Added.
Scripts/webkitpy/common/thread/init.py: Added.
Scripts/webkitpy/common/thread/messagepump.py: Copied from Scripts/webkitpy/common/net/irc/messagepump.py.
Scripts/webkitpy/common/thread/messagepump_unittest.py: Copied from Scripts/webkitpy/common/net/irc/messagepump_unittest.py.
Scripts/webkitpy/common/thread/threadedmessagequeue.py: Copied from Scripts/webkitpy/common/net/irc/threadedmessagequeue.py.
Scripts/webkitpy/common/thread/threadedmessagequeue_unittest.py: Copied from Scripts/webkitpy/common/net/irc/threadedmessagequeue_unittest.py.
Scripts/webkitpy/common/thread/unittests.py: Added.
Scripts/webkitpy/common/unittests.py:

1:19 PM Changeset in webkit [56639] by ojan@chromium.org

8 edits in trunk

2010-03-25 Ojan Vafai <ojan@chromium.org>

Reviewed by Darin Adler.

shift+home/end and cmd+shift+left/right don't extend the selection correctly
https://bugs.webkit.org/show_bug.cgi?id=36539

editing/selection/extend-after-mouse-selection.html:
editing/selection/extend-selection-expected.txt: Extending forward by lineboundary selects the whole line. Now extending backwards by lineboundary after the whole line is selected is a noop instead of collapsed the selection to the start.
editing/selection/move-begin-end.html: Just cleaned up this test.
platform/mac/editing/selection/extend-after-mouse-selection-expected.txt:

2010-03-25 Ojan Vafai <ojan@chromium.org>

Reviewed by Darin Adler.

shift+home/end and cmd+shift+left/right don't extend the selection correctly
https://bugs.webkit.org/show_bug.cgi?id=36539

WebCore.base.exp:
editing/SelectionController.cpp: (WebCore::SelectionController::modify):
editing/SelectionController.h:

12:47 PM Changeset in webkit [56638] by eric@webkit.org

3 edits
1 add in trunk/WebKitTools

2010-03-26 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Move commit_message_for_this_commit from scm to checkout
https://bugs.webkit.org/show_bug.cgi?id=36629

Finally add some basic unit testing for Checkout.commit_message_for_this_commit

Scripts/webkitpy/common/checkout/api.py:
Scripts/webkitpy/common/checkout/api_unittest.py: Added.
Scripts/webkitpy/common/unittests.py:

12:40 PM Changeset in webkit [56637] by jhawkins@chromium.org

8 edits
4 adds in trunk/WebKit/chromium

2010-03-24 James Hawkins <jhawkins@chromium.org>

Reviewed by Darin Fisher.

[Chromium] Implement WebFormControlElement and WebSelectElement. Add
a getFormControlElements method to WebFormElement.

https://bugs.webkit.org/show_bug.cgi?id=36562

WebKit.gyp:
public/WebElement.h:
public/WebFormControlElement.h: Added.
public/WebFormElement.h:
public/WebInputElement.h: (WebKit::WebInputElement::WebInputElement): (WebKit::WebInputElement::operator=): (WebKit::WebInputElement::assign):
public/WebSelectElement.h: Added.
src/WebElement.cpp: (WebKit::WebElement::isFormControlElement):
src/WebFormControlElement.cpp: Added.
src/WebFormElement.cpp: (WebKit::WebFormElement::getFormControlElements):
src/WebInputElement.cpp: (WebKit::WebInputElement::WebInputElement):
src/WebSelectElement.cpp: Added.

12:30 PM Changeset in webkit [56636] by tonikitoo@webkit.org

5 edits
2 adds in trunk/WebKitTools

User Agent Switcher on QtLauncher https://bugs.webkit.org/show_bug.cgi?id=36451

Patch by Diego Gonzalez <diego.gonzalez@openbossa.org> on 2010-03-26
Reviewed by Simon Hausmann.

Make possible to change the QtLauncher user agent via
a predefined list.

QtLauncher/QtLauncher.pro:
QtLauncher/QtLauncher.qrc: Added.
QtLauncher/main.cpp:

(LauncherWindow::showUserAgentDialog):
(LauncherWindow::createChrome):

QtLauncher/useragentlist.txt: Added.
QtLauncher/webpage.cpp:

(WebPage::userAgentForUrl):

QtLauncher/webpage.h:

(WebPage::setUserAgent):

11:21 AM QtWebKitBackportingFixes edited by Laszlo Gombos

(diff)

11:14 AM Changeset in webkit [56635] by eric@webkit.org

9 edits
4 adds in trunk/WebKitTools

2010-03-26 Victor Wang <victorw@chromium.org>

Reviewed by Adam Barth.

Host layout test flakiness dashboard in TestResultServer appengine.

Flakiness dashboard is a tool to monitor layout test status and
help layout test regression diagnostics.

https://bugs.webkit.org/show_bug.cgi?id=36195

TestResultServer/handlers/dashboardhandler.py: Added.
- New handler to handle dashboard request
TestResultServer/handlers/menu.py:
- Add new dashboard links
TestResultServer/handlers/testfilehandler.py:
- Request routes refactory
TestResultServer/index.yaml:
TestResultServer/main.py:
- Add new dashboard request routes and refactor test result file rountes.
TestResultServer/model/dashboardfile.py: Added.
- Model to access datastore for dashboard files
TestResultServer/model/testfile.py:
TestResultServer/stylesheets/dashboardfile.css: Added.
TestResultServer/templates/dashboardfilelist.html: Added.
TestResultServer/templates/showfilelist.html:

11:06 AM Changeset in webkit [56634] by bweinstein@apple.com

2 edits in trunk/LayoutTests

Add fast/multicol/hit-test-above-or-below.html, this is failing in the same way as Qt, and is being
tracked by the same bug (https://bugs.webkit.org/show_bug.cgi?id=35973).

platform/win/Skipped:

10:38 AM Changeset in webkit [56633] by levin@chromium.org

2 edits in trunk/LayoutTests

Rubber-stamped by Nate Chapin.

[chromium] Updated test expectations due to recent failures,
added bugs, etc.

platform/chromium/test_expectations.txt:

10:37 AM FastMalloc Glossary created by ggaren@apple.com

10:32 AM Changeset in webkit [56632] by eric@webkit.org

5 edits in trunk/WebKitTools

2010-03-26 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Remove some evil statics from CommitInfo
https://bugs.webkit.org/show_bug.cgi?id=36637

These methods should really be on checkout. You can tell because they
know about ChangeLogs and take an SCM as an argument. :)

Scripts/webkitpy/common/checkout/api.py:
Scripts/webkitpy/common/checkout/changelog.py:
Scripts/webkitpy/common/checkout/commitinfo.py:
Scripts/webkitpy/tool/commands/queries.py:

10:32 AM WikiStart edited by ggaren@apple.com

(diff)

10:29 AM WikiStart edited by ggaren@apple.com

(diff)

10:04 AM Changeset in webkit [56631] by eric@webkit.org

2 edits in trunk/WebCore

2010-03-26 Janne Koskinen <janne.p.koskinen@digia.com>

Reviewed by Laszlo Gombos.

Don't undefine SKIP_STATIC_CONSTRUCTORS_ON_GCC for Symbian HW targets.
https://bugs.webkit.org/show_bug.cgi?id=34081

Defining StringImpl instances as globals will cause a crash on process exit as
StringImpl::Remove expects TLS which was already deleted at time of exiting main and ends up
constructing one exiting thread.

config.h:

9:34 AM Changeset in webkit [56630] by eric@webkit.org

8 edits in trunk

2010-03-26 Andrey Kosyakov <caseq@chromium.org>

Reviewed by Pavel Feldman.

Send worker resource content to inspector to enable display of web
workers in inspector's resource tab.
https://bugs.webkit.org/show_bug.cgi?id=36658

inspector/InspectorController.cpp: (WebCore::InspectorController::resourceRetrievedByXMLHttpRequest): (WebCore::InspectorController::scriptImported):
inspector/InspectorResource.cpp: (WebCore::InspectorResource::type): (WebCore::InspectorResource::setOverrideContent): (WebCore::InspectorResource::sourceString):
inspector/InspectorResource.h:
workers/DefaultSharedWorkerRepository.cpp: (WebCore::SharedWorkerScriptLoader::notifyFinished):
workers/Worker.cpp: (WebCore::Worker::notifyFinished):

2010-03-26 Andrey Kosyakov <caseq@chromium.org>

Reviewed by Pavel Feldman.

Send worker resource content to inspector to enable display of web
workers in inspector's resource tab.
https://bugs.webkit.org/show_bug.cgi?id=36658

src/SharedWorkerRepository.cpp: (WebCore::SharedWorkerScriptLoader::notifyFinished):

8:42 AM Changeset in webkit [56629] by yael.aharon@nokia.com

10 edits in trunk

WebCore: Fix the rendering of HTMLProgressElement
https://bugs.webkit.org/show_bug.cgi?id=36206

Reviewed by Antti Koivisto.

Update the rendering and css to conform to
http://www.whatwg.org/specs/web-apps/current-work/complete.html#the-progress-element-0.
Updated the tests and the expected results accordingly.

css/html.css:
rendering/RenderProgress.cpp:
rendering/RenderProgress.h:

LayoutTests: Fix the rendering of HTMLProgressElement
https://bugs.webkit.org/show_bug.cgi?id=36206
Add dir=rtl test and update the expected results.

Reviewed by Antti Koivisto.

fast/dom/HTMLProgressElement/progress-element.html:
platform/qt/fast/dom/HTMLProgressElement/progress-element-expected.checksum:
platform/qt/fast/dom/HTMLProgressElement/progress-element-expected.png:
platform/qt/fast/dom/HTMLProgressElement/progress-element-expected.txt:

8:30 AM Changeset in webkit [56628] by jchaffraix@webkit.org

2 edits in trunk/WebCore

Unreviewed build fix.

FontPlatformDataPango.cpp: prototype for
'WebCore::FontPlatformData::FontPlatformData(cairo_font_face_t*, int, bool, bool)'
does not match any in class
https://bugs.webkit.org/show_bug.cgi?id=36496

platform/graphics/gtk/FontPlatformDataPango.cpp:

(WebCore::FontPlatformData::FontPlatformData): The 'size' parameter
should be a float to match the declaration and the other definitions.

8:22 AM Changeset in webkit [56627] by eric@webkit.org

2 edits in trunk/WebCore

2010-03-26 Shu Chang <chang.shu@nokia.com>

Reviewed by Eric Seidel.

[Qt] Prevent referring d->m_job in the future because calling abort()
deletes the instance itself.
https://bugs.webkit.org/show_bug.cgi?id=36618

Test: http/tests/appcache/fallback.html

platform/network/qt/ResourceHandleQt.cpp: (WebCore::ResourceHandle::cancel):

7:49 AM QtWebKit edited by zoltan@webkit.org

(diff)

7:37 AM Changeset in webkit [56626] by Simon Hausmann

2 edits in trunk/WebKit/qt

[Qt] Compile with QT_USE_FAST_OPERATOR_PLUS

Patch by Olivier Goffart <ogoffart@trolltech.com> on 2010-03-26
Reviewed by Simon Hausmann.

WebCoreSupport/InspectorClientQt.cpp:

(WebCore::InspectorClientQt::populateSetting):
(WebCore::InspectorClientQt::storeSetting):

7:35 AM Changeset in webkit [56625] by Simon Hausmann

2 edits in trunk/WebKit/qt

[Qt] Doc: Simplified Commercial Editions for Qt 4.7.

Patch by David Boddie <dboddie@trolltech.com> on 2010-03-26
Reviewed by Simon Hausmann.

docs/qtwebkit.qdoc:

7:26 AM Changeset in webkit [56624] by senorblanco@chromium.org

4 edits
2 deletes in trunk

2010-03-26 Stephen White <senorblanco@chromium.org>

Unreviewed; build fix.

Rolling out 56620; too many layout test failures.

Covered by fast/css/*.

css/CSSPrimitiveValue.cpp: (WebCore::CSSPrimitiveValue::cleanup): (WebCore::CSSPrimitiveValue::cssText):
css/CSSPrimitiveValue.h: (WebCore::CSSPrimitiveValue::):

2010-03-26 Stephen White <senorblanco@chromium.org>

Unreviewed; build fix.

Rolling out 56620; too many layout test failures.

fast/css/cssText-cache-expected.txt: Removed.
fast/css/cssText-cache.html: Removed.

7:05 AM Changeset in webkit [56623] by Simon Hausmann

9 edits in trunk

[Qt] Build JavaScriptCore as a static library.
https://bugs.webkit.org/show_bug.cgi?id=36590

Patch by Jocelyn Turcotte <jocelyn.turcotte@nokia.com> on 2010-03-26
Reviewed by Simon Hausmann.

This patch takes what was left of the unused JavaScriptCore.pro
and moved the compilation logic from JavaScriptCore.pri to
JavaScriptCore.pro.

WebKit.pro:

JavaScriptCore:

JavaScriptCore.pri:
JavaScriptCore.pro:
jsc.pro:
qt/api/QtScript.pro:

WebCore:

WebCore.pro:

6:44 AM Changeset in webkit [56622] by Simon Hausmann

2 edits in trunk/WebCore

[Qt] Fix compilation on Windows

Patch by Olivier Goffart <ogoffart@trolltech.com> on 2010-03-26
Reviewed by Simon Hausmann.

For some reason, the MSVC compiler choose the
operator+(const QString &, const QString &) instead of
operator+(const WebCore::String &, const WebCore::String &)
resulting in errors when QT_USE_FAST_OPERATOR_PLUS is used.

dom/XMLTokenizerQt.cpp:

(WebCore::handleElementNamespaces):

6:28 AM Changeset in webkit [56621] by Philippe Normand

2 edits in trunk/LayoutTests

2010-03-26 Philippe Normand <pnormand@igalia.com>

fast/parser/xml-declaration-missing-ending-mark.html crashed on Gtk bot
https://bugs.webkit.org/show_bug.cgi?id=33027

Skipping test that fails on GTK+ Debug bots.

platform/gtk/Skipped:

6:18 AM Changeset in webkit [56620] by senorblanco@chromium.org

4 edits
2 adds in trunk

2010-03-24 Stephen White <senorblanco@chromium.org>

Reviewed by Darin Adler.

In order to speed up multiple calls to CSSPrimitiveValue::cssText(),
this CL caches the String result. When m_value is changed, the
cached string is cleared. This gives a good speedup on benchmarks
which do a lot of CSS property gets, such as Peacekeeper.
The processing cost should be negligible, since the strings are
refcounted. The memory cost is an additional 4 bytes per
CSSPrimitiveValue, and the extended lifetime of the computed string
(potentially, the same as the lifetime of the CSSPrimitiveValue).

https://bugs.webkit.org/show_bug.cgi?id=36556

Covered by fast/css/large-number-round-trip.html, and more.

css/CSSPrimitiveValue.cpp: (WebCore::CSSPrimitiveValue::CSSPrimitiveValue): (WebCore::CSSPrimitiveValue::cleanup): (WebCore::CSSPrimitiveValue::cssText):
css/CSSPrimitiveValue.h:

2010-03-25 Stephen White <senorblanco@chromium.org>

Reviewed by Darin Adler.

Added a test for CSSPrimitiveValue::cssText() string cacheing.

https://bugs.webkit.org/show_bug.cgi?id=36556

fast/css/cssText-cache-expected.txt: Added.
fast/css/cssText-cache.html: Added.

5:58 AM Changeset in webkit [56619] by eric@webkit.org

4 edits in trunk

2010-03-26 Qi Zhang <qi.2.zhang@nokia.com>

Reviewed by Laszlo Gombos.

[Qt] fast/canvas/drawImage-with-negative-source-destination.html failed
https://bugs.webkit.org/show_bug.cgi?id=35005

Enable fast/canvas/drawImage-with-negative-source-destination.html

platform/qt/Skipped:

2010-03-26 Qi Zhang <qi.2.zhang@nokia.com>

Reviewed by Laszlo Gombos.

[Qt] fast/canvas/drawImage-with-negative-source-destination.html failed
https://bugs.webkit.org/show_bug.cgi?id=35005

To support negative width or height at context.drawImage

platform/graphics/qt/StillImageQt.cpp: (WebCore::StillImage::draw):

5:52 AM Changeset in webkit [56618] by tonikitoo@webkit.org

3 edits in trunk/WebKitTools

Reviewed by Simon Hausmann.

Add an option to QtLauncher to enable/disable a QGLWidget as Viewport
of the QGraphicsView when the launcher is running on graphicsview mode.

[Qt] QtLauncher needs an option to Enable/Disable a QGLWidget as Viewport
https://bugs.webkit.org/show_bug.cgi?id=36270

QtLauncher/QtLauncher.pro:
QtLauncher/main.cpp:

(LauncherWindow::toggleQGLWidgetViewport):
(LauncherWindow::createChrome):

4:11 AM Changeset in webkit [56617] by ager@chromium.org

2 edits in trunk/LayoutTests

2010-03-26 Mads Ager <ager@chromium.org>

Reviewed by Jeremy Orlow.

Tweak Chromium test expectations
https://bugs.webkit.org/show_bug.cgi?id=36651

fast/js/large-expressions.html started failing on Linux in release
mode occassionally. Also fails on other platforms.

platform/chromium/test_expectations.txt:

2:21 AM Changeset in webkit [56616] by ukai@chromium.org

2 edits in trunk/LayoutTests

Unreviewed, removing websocket/tests/long-invalid-header.html from Chromium test_expectations.txt

platform/chromium/test_expectations.txt: remove websocket/tests/long-invalid-header.html

1:58 AM Changeset in webkit [56615] by Philippe Normand

2 edits in trunk/WebCore

2010-03-08 Philippe Normand <pnormand@igalia.com>

Reviewed by Gustavo Noronha.

[GStreamer] soften dependency on libsoup in the http src element
https://bugs.webkit.org/show_bug.cgi?id=35864

Replaced SoupURI calls with KURL and pause/resume internal soup
messages only if the element is compiled for a port depending on
libsoup.

platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp: (webkit_web_src_init): (webKitWebSrcSetUri): (webKitWebSrcNeedDataMainCb): (webKitWebSrcEnoughDataMainCb):

1:45 AM Changeset in webkit [56614] by ukai@chromium.org

2 edits in trunk/WebKitTools

2010-03-26 Fumitoshi Ukai <ukai@chromium.org>

Reviewed by Shinichiro Hamaji.

[Chromium-Win] websocket_server.py failed to start
https://bugs.webkit.org/show_bug.cgi?id=36586

subproess.Popen() on Python 2.4/Windows with stdout,stdout, but no stdin will fail, because it uses return value of GetStdHandle(STD_INPUT_HANDLE), but DuplicateHandle requires integer, not the handle.
We don't need stdin, so use devnull as stdin.

Scripts/webkitpy/layout_tests/port/websocket_server.py: open os.devnull for stdin

1:05 AM Changeset in webkit [56613] by pfeldman@chromium.org

4 edits in trunk/WebCore

2010-03-25 Ilya Tikhonovsky <loislo@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Shot record filter is implemented in Timeline Panel.
https://bugs.webkit.org/show_bug.cgi?id=36606

English.lproj/localizedStrings.js:
inspector/front-end/TimelinePanel.js: (WebInspector.TimelinePanel): (WebInspector.TimelinePanel.prototype.get statusBarItems): (WebInspector.TimelinePanel.prototype._createStatusbarButtons): (WebInspector.TimelinePanel.prototype._toggleFilterButtonClicked): (WebInspector.TimelinePanel.prototype._innerAddRecordToTimeline): (WebInspector.TimelinePanel.prototype._addToRecordsWindow): (WebInspector.TimelineRecordGraphRow.prototype.update): (WebInspector.TimelinePanel.FormattedRecord.prototype.get _isLongEvent):
inspector/front-end/inspector.css:

12:58 AM Changeset in webkit [56612] by tkent@chromium.org

1 edit
2 adds in trunk/WebKitTools

2010-03-26 Kent Tamura <tkent@chromium.org>

Reviewed by Dimitri Glazkov.

[DRT/Chromium] Add TestNavigationController and TestWebWorker
https://bugs.webkit.org/show_bug.cgi?id=36520

Add LayoutTestController class, which is going to be used by
DumpRenderTree Chromium port. These files are based on:

src/webkit/tools/test_shell/layout_test_controller.cc
src/webkit/tools/test_shell/layout_test_controller.h of Chromium rev.40492.

DumpRenderTree/chromium/LayoutTestController.cpp: Added.
DumpRenderTree/chromium/LayoutTestController.h: Added.

12:55 AM Changeset in webkit [56611] by Simon Hausmann

2 edits in trunk/WebKit/qt

Symbian build fix.

[Qt] Updated the def file with new exports used by QtLauncher.

symbian/eabi/QtWebKitu.def:

12:43 AM Changeset in webkit [56610] by tkent@chromium.org

3 edits in trunk/WebCore

Rollout r56609. It was accidental commit.

12:34 AM Changeset in webkit [56609] by tkent@chromium.org

3 edits in trunk/WebCore

2009-10-20 Mikhail Naganov <mnaganov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: populate child nodes before sorting them.

https://bugs.webkit.org/show_bug.cgi?id=29673

inspector/front-end/BottomUpProfileDataGridTree.js: (WebInspector.BottomUpProfileDataGridNode): Swapped with BottomUpProfileDataGridTree to be consistent with TopDownProfileDataGridNode. (WebInspector.BottomUpProfileDataGridNode.prototype._takePropertiesFromProfileDataGridNode): (WebInspector.BottomUpProfileDataGridNode.prototype._keepOnlyChild): (WebInspector.BottomUpProfileDataGridNode.prototype._exclude): (WebInspector.BottomUpProfileDataGridNode.prototype._merge): (WebInspector.BottomUpProfileDataGridNode.prototype._sharedPopulate): (WebInspector.BottomUpProfileDataGridTree.prototype.exclude):
inspector/front-end/ProfileDataGridTree.js: (WebInspector.ProfileDataGridNode.prototype.sort): Added missing parentheses. (WebInspector.ProfileDataGridNode.prototype.get _parent): (WebInspector.ProfileDataGridNode.prototype._populate):
inspector/front-end/TopDownProfileDataGridTree.js: (WebInspector.TopDownProfileDataGridNode.prototype._sharedPopulate):

12:13 AM Changeset in webkit [56608] by pfeldman@chromium.org

10 edits in trunk/WebCore

2010-03-25 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: Implement CSSStyleSelector::pseudoStyleForElement and use it in the InspectorDOMAgent.

https://bugs.webkit.org/show_bug.cgi?id=36509

This change provides pseudo elements information into the inspector styles sidebar pane.
Changes applied:

CSSStyleSelector::pseudoStyleRulesForElement implemented. I changed the signature to accept PseudoId instead of a String since it better reflected the needs;
Accompanied elementStyle checks with m_collectRulesOnly checks;
Removed pseudoStyleRulesForElement usage from DOMWindow::getMatchedCSSRules. It was anyways returning 0, while I would need to convert String to PseudoId in order to leave the call in place;
Needed to introduce AFTER_LAST_INTERNAL_PSEUDOID marker const in RenderStyleConstants' PseudoId enum
InspectorDOMAgent is now iterating over all pseudo ids to get all styles (including internal ones).
Brushed up front-end code so that proper overriding took place locally within pseudo id categories.

English.lproj/localizedStrings.js:
css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::styleRulesForElement): (WebCore::CSSStyleSelector::pseudoStyleRulesForElement): (WebCore::CSSStyleSelector::SelectorChecker::checkSelector): (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector):
css/CSSStyleSelector.h:
inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::getStyles): (WebCore::InspectorDOMAgent::buildObjectForAttributeStyles): (WebCore::InspectorDOMAgent::buildArrayForCSSRules): (WebCore::InspectorDOMAgent::buildArrayForPseudoElements):
inspector/InspectorDOMAgent.h:
inspector/front-end/StylesSidebarPane.js: (WebInspector.StylesSidebarPane.prototype.update.callback): (WebInspector.StylesSidebarPane.prototype.update): (WebInspector.StylesSidebarPane.prototype._update): (WebInspector.StylesSidebarPane.prototype._refreshStyleRules): (WebInspector.StylesSidebarPane.prototype._rebuildStyleRules.insertInheritedNodeSeparator): (WebInspector.StylesSidebarPane.prototype._rebuildStyleRules): (WebInspector.StylesSidebarPane.prototype._markUsedProperties): (WebInspector.StylesSidebarPane.prototype._refreshSectionsForStyleRules): (WebInspector.StylesSidebarPane.prototype._rebuildSectionsForStyleRules): (WebInspector.StylesSidebarPane.prototype._changeColorFormat): (WebInspector.StylesSidebarPane.prototype.addBlankSection): (WebInspector.StylesSidebarPane.prototype.removeSection):
inspector/front-end/inspector.css: (.styles-sidebar-separator):
page/DOMWindow.cpp: (WebCore::DOMWindow::getMatchedCSSRules):
rendering/style/RenderStyleConstants.h: (WebCore::):

12:11 AM Changeset in webkit [56607] by mrowe@apple.com

7 edits in trunk/WebKitLibraries

Update WebCoreSQLite3 to SQLite v3.6.12.

Rubber-stamped by Dan Bernstein.

WebCoreSQLite3/sqlite3.h:
WebCoreSQLite3/sqlite3ext.h:
libWebCoreSQLite3.a:
libWebKitSystemInterfaceLeopard.a:
libWebKitSystemInterfaceSnowLeopard.a:
libWebKitSystemInterfaceTiger.a:

Mar 25, 2010:

11:34 PM Changeset in webkit [56606] by abarth@webkit.org

12 edits
1 move
2 adds
1 delete in trunk

2010-03-25 Charlie Reis <creis@chromium.org>

Reviewed by Adam Barth.

onbeforeunload not called at window close + frame or iframe focused
https://bugs.webkit.org/show_bug.cgi?id=27481

Adds a layout test for bug 27481. Requires calling shouldClose on
the WebView, which is done with a new method on LayoutTestController.

fast/events/onbeforeunload-focused-iframe-expected.txt: Added.
fast/events/onbeforeunload-focused-iframe.html: Added.
fast/events/resources/onbeforeunload-focused-iframe-frame.html: Added.
platform/gtk/Skipped:
platform/qt/Skipped:

2010-03-25 Charlie Reis <creis@chromium.org>

Reviewed by Adam Barth.

onbeforeunload not called at window close + frame or iframe focused
https://bugs.webkit.org/show_bug.cgi?id=27481

Test: fast/events/onbeforeunload-focused-iframe.html

Replaces initial manual tests with a layout test.

manual-tests/onbeforeunload-focused-iframe.html: Removed.
manual-tests/resources/focused-iframe.html: Removed.

2010-03-25 Charlie Reis <creis@chromium.org>

Reviewed by Adam Barth.

onbeforeunload not called at window close + frame or iframe focused
https://bugs.webkit.org/show_bug.cgi?id=27481

Adds a callShouldCloseOnWebView method to LayoutTestController,
to allow automated testing for bug 27481.

DumpRenderTree/LayoutTestController.cpp: (callShouldCloseOnWebViewCallback): (LayoutTestController::staticFunctions):
DumpRenderTree/LayoutTestController.h:
DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::callShouldCloseOnWebView):
DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::callShouldCloseOnWebView):
DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::callShouldCloseOnWebView):
DumpRenderTree/qt/LayoutTestControllerQt.h:
DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::callShouldCloseOnWebView):

11:23 PM Changeset in webkit [56605] by eric@webkit.org

2 edits in trunk/LayoutTests

2010-03-25 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

REGRESSION: plugins/netscape-construct.html and plugins/mouse-events-fixedpos.html failing on Snow Leopard Bot
https://bugs.webkit.org/show_bug.cgi?id=36462

Adding tests to the Skipped list per Alexey's recommendation
until someone from Apple can update the version of Safari
on the Snow Leopard bot.

platform/mac-snowleopard/Skipped:

11:06 PM Changeset in webkit [56604] by eric@webkit.org

3 edits
2 adds in trunk

2010-03-25 Eric Uhrhane <ericu@chromium.org>

Reviewed by David Levin.

Missing lock in call to doneCreatingDatabase
https://bugs.webkit.org/show_bug.cgi?id=36473

Added new test storage/open-database-over-quota.html.

storage/open-database-over-quota.html: Added.
storage/open-database-over-quota-expected.txt: Added.

2010-03-25 Eric Uhrhane <ericu@chromium.org>

Reviewed by David Levin.

Missing lock in call to doneCreatingDatabase
https://bugs.webkit.org/show_bug.cgi?id=36473

Added new test storage/open-database-over-quota.html.

storage/DatabaseTracker.cpp: (WebCore::DatabaseTracker::canEstablishDatabase): Added missing lock call.

10:48 PM Changeset in webkit [56603] by eric@webkit.org

5 edits in trunk

2010-03-25 Tony Chang <tony@chromium.org>

Reviewed by David Levin.

[chromium] correctly handle move drag operations
https://bugs.webkit.org/show_bug.cgi?id=36484

platform/chromium/test_expectations.txt:

2010-03-25 Tony Chang <tony@chromium.org>

Reviewed by David Levin.

[chromium] correctly handle move drag operations
https://bugs.webkit.org/show_bug.cgi?id=36484

src/WebViewImpl.cpp: (WebKit::WebViewImpl::dragTargetDragEnter): (WebKit::WebViewImpl::dragTargetDragOver): (WebKit::WebViewImpl::dragTargetDragEnterOrOver): Combine common code into a helper method

and properly mask against the drag effect.

(WebKit::WebViewImpl::createUniqueIdentifierForRequest):

src/WebViewImpl.h:

10:42 PM Changeset in webkit [56602] by abarth@webkit.org

4 edits in trunk/WebKitTools

2010-03-25 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Add webkit-patch lkgr for finding last known good revision
https://bugs.webkit.org/show_bug.cgi?id=36626

This is rather slow for now because the command
has to compute this information from the buildbot.
A better long-term solution would be to have a server
somewhere store a pre-computed LKGR and then any
script (like webkit-patch) could just fetch it.

Scripts/webkitpy/common/net/buildbot.py:
Scripts/webkitpy/tool/commands/queries.py:

10:38 PM Changeset in webkit [56601] by abarth@webkit.org

10 edits in trunk/WebKitTools

2010-03-25 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Move modified_changelogs (and friends) from scm to checkout
https://bugs.webkit.org/show_bug.cgi?id=36636

These functions know about ChangeLogs, which is forbidden knowledge in
scm.py.

Scripts/webkitpy/common/checkout/api.py:
Scripts/webkitpy/common/checkout/changelog.py:
Scripts/webkitpy/common/checkout/scm.py:
Scripts/webkitpy/tool/mocktool.py:
Scripts/webkitpy/tool/steps/abstractstep.py:
Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
Scripts/webkitpy/tool/steps/revertrevision.py:
Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py:
Scripts/webkitpy/tool/steps/validatereviewer.py:

10:32 PM Changeset in webkit [56600] by abarth@webkit.org

6 edits in trunk/WebKitTools

2010-03-25 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Move apply_patch from scm to checkout
https://bugs.webkit.org/show_bug.cgi?id=36635

SCM shouldn't have any knowledge of WebKit scripts.

Scripts/webkitpy/common/checkout/api.py:
Scripts/webkitpy/common/checkout/scm.py:
Scripts/webkitpy/common/checkout/scm_unittest.py:
Scripts/webkitpy/tool/mocktool.py:
Scripts/webkitpy/tool/steps/applypatch.py:

9:48 PM Changeset in webkit [56599] by eric@webkit.org

2 edits in trunk/WebKitTools

2010-03-25 Eric Seidel <eric@webkit.org>

Unreviewed build fix to un-break webkit-patch land.
Test-case coming in follow-up commit.

Move commit_message_for_this_commit from scm to checkout
https://bugs.webkit.org/show_bug.cgi?id=36629

Scripts/webkitpy/common/checkout/api.py: import scm.CommitMessage

9:40 PM Changeset in webkit [56598] by ojan@chromium.org

4 edits in trunk

WebCore:
2010-03-25 Ojan Vafai <ojan@chromium.org>

Reviewed by Eric Seidel.

[chromium] REGRESSION: Some LayoutTests fail after r56567
https://bugs.webkit.org/show_bug.cgi?id=36630

Fix boolean logic goofup. This was a last minute code review
change that didn't get tested on Windows before commit.

editing/SelectionController.cpp: (WebCore::SelectionController::setIsDirectional):

LayoutTests:
2010-03-25 Ojan Vafai <ojan@chromium.org>

Reviewed by Eric Seidel.

[chromium] REGRESSION: Some LayoutTests fail after r56567
https://bugs.webkit.org/show_bug.cgi?id=36630

platform/chromium/test_expectations.txt:

9:35 PM Changeset in webkit [56597] by mitz@apple.com

11 edits
1 copy
5 adds in trunk

<rdar://problem/7728903> Support color bitmap fonts

Reviewed by Darin Adler.

WebCore:

Test: platform/mac/fonts/color-bitmap.html

platform/graphics/mac/FontMac.mm:

(WebCore::showGlyphsWithAdvances): Added. Calls CGContextShowGlyphsWithAdvances()
or CTFontShowGlyphs() depending on whether the font is a color bitmap font.
(WebCore::Font::drawGlyphs): Use showGlyphsWithAdvances(). Don’t include the font’s matrix in
the context’s text matrix when drawing with a color bitmap font, because CTFontShowGlyphs()
factors it in.

platform/graphics/mac/FontPlatformData.h:

(WebCore::FontPlatformData::FontPlatformData): Added m_isColorBitmapFont member
and initialized it in constructors.
(WebCore::FontPlatformData::isColorBitmapFont): Added this getter.

platform/graphics/mac/FontPlatformDataMac.mm:

(WebCore::FontPlatformData::FontPlatformData): Initialize m_isColorBitmapFont.
(WebCore::FontPlatformData::operator=): Copy m_isColorBitmapFont.
(WebCore::FontPlatformData::setFont): Set m_isColorBitmapFont.

WebKitTools:

DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Added ColorBits.ttf

and ColorBits-A.png.

DumpRenderTree/fonts/ColorBits-A.png: Copied from WebCore/inspector/front-end/Images/successGreenDot.png.
DumpRenderTree/fonts/ColorBits.ttf: Added.
DumpRenderTree/mac/DumpRenderTree.mm:

(activateFonts): Activate ColorBits.ttf.

LayoutTests:

platform/mac-leopard/Skipped:
platform/mac-snowleopard/Skipped:
platform/mac-tiger/Skipped:
platform/mac/fonts/color-bitmap-expected.checksum: Added.
platform/mac/fonts/color-bitmap-expected.png: Added.
platform/mac/fonts/color-bitmap-expected.txt: Added.
platform/mac/fonts/color-bitmap.html: Added.

9:28 PM Changeset in webkit [56596] by dimich@chromium.org

2 edits in trunk/LayoutTests

Unreviewed, another attempt to unblock Chromium Win test bot.

platform/chromium/test_expectations.txt:

9:23 PM Changeset in webkit [56595] by dimich@chromium.org

1 edit
1 delete in trunk/LayoutTests

Unreviewed, removing stale expectation file for Chromium.

The test was updated by http://trac.webkit.org/changeset/56506 to a script test.

platform/chromium-win/editing/inserting/6633727-expected.txt: Removed.

9:13 PM Changeset in webkit [56594] by dimich@chromium.org

2 edits in trunk/LayoutTests

Unreviewed, temporarily disabling test on Chromium bots.

http://crbug.com/39423

platform/chromium/test_expectations.txt:

8:04 PM Changeset in webkit [56593] by mrowe@apple.com

2 edits in trunk/WebKitTools

Remove a printf that was causing commit-log-editor to spew the name of the editor
to the terminal many times during a commit.

Scripts/commit-log-editor:

8:04 PM Changeset in webkit [56592] by eric@webkit.org

8 edits in trunk/WebKitTools

2010-03-25 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Move commit_message_for_this_commit from scm to checkout
https://bugs.webkit.org/show_bug.cgi?id=36629

This function requires knowledge of ChangeLogs, but scm shouldn't know
about ChangeLogs.

Scripts/webkitpy/common/checkout/api.py:
Scripts/webkitpy/common/checkout/scm.py:
Scripts/webkitpy/tool/commands/upload.py:
Scripts/webkitpy/tool/commands/upload_unittest.py:
Scripts/webkitpy/tool/mocktool.py:
Scripts/webkitpy/tool/steps/applypatchwithlocalcommit.py:
Scripts/webkitpy/tool/steps/commit.py:

7:46 PM Changeset in webkit [56591] by eric@webkit.org

7 edits
20 adds in trunk

2010-03-25 Adam Barth <abarth@webkit.org>

Reviewed by Sam Weinig.

Implement allow-top-navigation for HTML5 sandbox attribute
https://bugs.webkit.org/show_bug.cgi?id=36549

Test various cases relating to navigating top level frames and the
allow-top-navigation directive. This feature is tricky to test
exhaustively because there are a lot of permutations.

fast/frames/resources/fail-and-notify-done.html: Added.
fast/frames/resources/navigate-top-by-constant-name-to-pass.html: Added.
fast/frames/resources/navigate-top-by-constant-name2-to-pass.html: Added.
fast/frames/resources/navigate-top-by-name-to-fail.html: Added.
fast/frames/resources/navigate-top-by-name-to-pass.html: Added.
fast/frames/resources/navigate-top-to-fail.html: Added.
fast/frames/resources/navigate-top-to-pass.html: Added.
fast/frames/resources/pass-and-notify-done.html: Added.
fast/frames/sandboxed-iframe-navigation-top-by-constant-name-expected.txt: Added.
fast/frames/sandboxed-iframe-navigation-top-by-constant-name.html: Added.
fast/frames/sandboxed-iframe-navigation-top-by-constant-name2-expected.txt: Added.
fast/frames/sandboxed-iframe-navigation-top-by-constant-name2.html: Added.
fast/frames/sandboxed-iframe-navigation-top-by-name-denied-expected.txt: Added.
fast/frames/sandboxed-iframe-navigation-top-by-name-denied.html: Added.
fast/frames/sandboxed-iframe-navigation-top-by-name-expected.txt: Added.
fast/frames/sandboxed-iframe-navigation-top-by-name.html: Added.
fast/frames/sandboxed-iframe-navigation-top-denied-expected.txt: Added.
fast/frames/sandboxed-iframe-navigation-top-denied.html: Added.
fast/frames/sandboxed-iframe-navigation-top-expected.txt: Added.
fast/frames/sandboxed-iframe-navigation-top.html: Added.

2010-03-25 Adam Barth <abarth@webkit.org>

Reviewed by Sam Weinig.

Implement allow-top-navigation for HTML5 sandbox attribute
https://bugs.webkit.org/show_bug.cgi?id=36549

Tests: fast/frames/sandboxed-iframe-navigation-top-by-constant-name.html

fast/frames/sandboxed-iframe-navigation-top-by-constant-name2.html
fast/frames/sandboxed-iframe-navigation-top-by-name-denied.html
fast/frames/sandboxed-iframe-navigation-top-by-name.html
fast/frames/sandboxed-iframe-navigation-top-denied.html
fast/frames/sandboxed-iframe-navigation-top.html

bindings/generic/BindingDOMWindow.h: (WebCore::::createWindow):
bindings/js/JSDOMWindowCustom.cpp: (WebCore::createWindow): Moved the security check to FrameLoader because we need to allow window.open navigation to succeed sometimes when the SandboxNavigation bit is set.
html/HTMLIFrameElement.cpp: (WebCore::parseSandboxAttribute): Added allow-top-navigation to the parser.
loader/FrameLoader.cpp: (WebCore::FrameLoader::createWindow): The SandboxNavigation check now occurs after we search for the frame by name. Notice that the named frame navigation case is caught by the generic navigation access check. (WebCore::FrameLoader::shouldAllowNavigation): Update the navigation access check to allow navigating of top unless it's forbidden.
loader/FrameLoaderTypes.h: Introduce a bit for SandboxedTopNavigation. (WebCore::):

7:32 PM Changeset in webkit [56590] by ap@apple.com

2 edits in trunk/WebKit/mac

Reviewed by Mark Rowe.

Plugins/Hosted/NetscapePluginHostProxy.mm: (WKPCRunSyncOpenPanel): Re-fetch host proxy in a way that works in a function that doesn't have a pluginID argument for some reason.

7:21 PM Changeset in webkit [56589] by eric@webkit.org

2 edits in trunk/WebKitTools

2010-03-25 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

REGRESSION: webkit-patch land can't land "rubber-stamped" patches
https://bugs.webkit.org/show_bug.cgi?id=36582

Allow a "-" in rubber stamped.

Scripts/webkitpy/tool/steps/validatereviewer.py:

7:12 PM Changeset in webkit [56588] by dumi@chromium.org

5 edits in trunk

Unreviewed, Chromium build fix.

WebCore:

V8CustomVoidCallback should not check if a return value is a
boolean. It should only convert the value to a boolean.

bindings/v8/custom/V8CustomVoidCallback.cpp:

(WebCore::invokeCallback):

LayoutTests:

Update the expectations for statement-error-callback.html for Chromium.

platform/chromium-mac/storage/statement-error-callback-expected.txt:
platform/chromium-win/storage/statement-error-callback-expected.txt:

6:48 PM Changeset in webkit [56587] by dimich@chromium.org

4 edits in trunk/WebCore

Revert "2010-03-25 Laszlo Gombos <Laszlo Gombos>"

This reverts commit 2a3b308efc33f4829fe9717d93a4b245d3b25f6d.

6:26 PM Changeset in webkit [56586] by abarth@webkit.org

14 edits in trunk/WebKitTools

2010-03-25 Adam Barth <abarth@webkit.org>

Unreviewed. Fix some copyright lines to remove extraneous comma and
python directive.

Scripts/webkitpy/tool/bot/patchcollection.py:
Scripts/webkitpy/tool/bot/patchcollection_unittest.py:
Scripts/webkitpy/tool/bot/queueengine.py:
Scripts/webkitpy/tool/bot/queueengine_unittest.py:
Scripts/webkitpy/tool/commands/download.py:
Scripts/webkitpy/tool/commands/earlywarningsystem.py:
Scripts/webkitpy/tool/commands/queries.py:
Scripts/webkitpy/tool/commands/queues.py:
Scripts/webkitpy/tool/commands/sheriffbot.py:
Scripts/webkitpy/tool/comments.py:
Scripts/webkitpy/tool/grammar.py:
Scripts/webkitpy/tool/multicommandtool.py:
Scripts/webkitpy/tool/multicommandtool_unittest.py:

6:04 PM Changeset in webkit [56585] by eric@webkit.org

4 edits in trunk/WebCore

2010-03-25 Laszlo Gombos <Laszlo Gombos>

Reviewed by Darin Adler.

Fix build if NPAPI support is disabled
https://bugs.webkit.org/show_bug.cgi?id=36621

No new tests, this is a build fix.

plugins/PluginView.cpp: Guard getValueStatic() with NETSCAPE_PLUGIN_API (WebCore::PluginView::getValue):
plugins/PluginView.h: Guard getValue() with NETSCAPE_PLUGIN_API
plugins/PluginViewNone.cpp: Guard platformGetValue() and platformGetValueStatic with NETSCAPE_PLUGIN_API; Guard privateBrowsingStateChanged() and setJavaScriptPaused() with PLATFORM(MAC)

5:53 PM Changeset in webkit [56584] by dimich@chromium.org

6 edits in trunk/LayoutTests

Not reviewed, update pixel results for Chromium bots.

The rendering of these tests was changed by http://trac.webkit.org/changeset/56507.
Also updated Chromium's test_expectations.txt.

platform/chromium-linux/fast/dynamic/flash-replacement-test-expected.checksum:
platform/chromium-linux/fast/dynamic/flash-replacement-test-expected.png:
platform/chromium-linux/plugins/embed-attributes-style-expected.checksum:
platform/chromium-linux/plugins/embed-attributes-style-expected.png:
platform/chromium/test_expectations.txt: Use BUG_WKXXXX instead of WKXXXX notation to appease validation on the bot.

5:46 PM Changeset in webkit [56583] by Simon Fraser

4 edits in trunk/WebKitTools

2010-03-25 Simon Fraser <Simon Fraser>

Reviewed by Darin Adler, Alexey Proskuryakov.

https://bugs.webkit.org/show_bug.cgi?id=36631
Allow the test plugin to run scripts in response to NPP_SetWindow calls

Hook up the ability for the TestNetscapePlugIn to run JavaScript in
response to NPP_SetWindow.

DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: (pluginAllocate):
DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h:
DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp: (NPP_New): (NPP_Destroy): (NPP_SetWindow):

5:26 PM Changeset in webkit [56582] by dimich@chromium.org

2 edits in trunk/LayoutTests

Unreviewed, fixing Chromium test bots.

[chromium] REGRESSION: Some LayoutTests fail after r56567
https://bugs.webkit.org/show_bug.cgi?id=36630

platform/chromium/test_expectations.txt: Update expectations.

5:24 PM Changeset in webkit [56581] by eric@webkit.org

3 edits in trunk/WebKit/qt

2010-03-25 Yael Aharon <yael.aharon@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] QtLauncher crashes on Mac OS and Linux when exiting with QGraphicsView mode enabled
https://bugs.webkit.org/show_bug.cgi?id=35251

Followed the way QWebView registers for the signal QWebPage::destroyed(), to prevent
QGraphicsWebView from referencing QWebPage after it was deleted.

Api/qgraphicswebview.cpp: (QGraphicsWebViewPrivate::_q_pageDestroyed): (QGraphicsWebView::setPage):
Api/qgraphicswebview.h:

5:06 PM Changeset in webkit [56580] by eric@webkit.org

9 edits in trunk

2010-03-25 Drew Wilson <atwilson@chromium.org>

Reviewed by Nate Chapin.

[v8] Error in getScriptExecutionContext() when worker context is terminating.
https://bugs.webkit.org/show_bug.cgi?id=36565

Removed WorkerScriptExecutionProxy::retrieve() and added WorkerScriptController::controllerForContext(). This allows
callers to differentiate between "the current context is shutting down" vs "the current context is not a worker context".

Test: Existing worker tests suffice.

bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::getConstructor): Changed to use WorkerScriptController::controllerForContext() instead of WorkerScriptExecutionProxy::retrieve().
bindings/v8/V8Utilities.cpp: (WebCore::getScriptExecutionContext): Changed to use WorkerScriptController::controllerForContext() instead of WorkerScriptExecutionProxy::retrieve().
bindings/v8/WorkerContextExecutionProxy.cpp: Removed WorkerScriptExecutionProxy::retrieve().
bindings/v8/WorkerContextExecutionProxy.h: Removed WorkerScriptExecutionProxy::retrieve().
bindings/v8/WorkerScriptController.cpp: (WebCore::WorkerScriptController::controllerForContext): Added helper function to get the WorkerScriptController for the current context.
bindings/v8/WorkerScriptController.h: Added declaration for controllerForContext().

2010-03-25 Drew Wilson <atwilson@chromium.org>

Reviewed by Nate Chapin.

[v8] Error in getScriptExecutionContext() when worker context is terminating
https://bugs.webkit.org/show_bug.cgi?id=36565

Test: Existing worker tests suffice.

src/WebWorkerClientImpl.cpp: (WebKit::WebWorkerClientImpl::createWorkerContextProxy): Changed to use WorkerScriptController::controllerForContext() instead of WorkerScriptExecutionProxy::retrieve().

4:48 PM Changeset in webkit [56579] by eric@webkit.org

4 edits
1 add in trunk/WebKit/chromium

2010-03-25 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Darin Fisher.

[Chromium] Add an ASSERT macro to the Chromium WebKit API
https://bugs.webkit.org/show_bug.cgi?id=36545

WebKit.gyp: Add WebCommon.cpp
public/WebCommon.h: Add the Macro.
public/WebPrivatePtr.h: (WebKit::WebPrivatePtr::~WebPrivatePtr): Verify the pointer is now 0.
src/WebCommon.cpp: Added. (WebKit::failedAssertion): Calls the WTF assert function and then crashes.

4:33 PM Changeset in webkit [56578] by kov@webkit.org

3 edits in trunk/LayoutTests

2010-03-25 Gustavo Noronha Silva <Gustavo Noronha Silva>

Needs a "LinuxEditingBehavior", perhaps with a better name
https://bugs.webkit.org/show_bug.cgi?id=36627

Skipping tests that started failing after 56567. We need to figure
out a proper fix, that may involve adding a new editing behavior
for our platform.

platform/gtk/Skipped:
platform/qt/Skipped:

4:30 PM Changeset in webkit [56577] by eric@webkit.org

2 edits in trunk/WebKit/qt

2010-03-25 Kent Hansen <kent.hansen@nokia.com>

Reviewed by Simon Hausmann.

[Qt] QWebFrame::pageChanged() signal is not documented
https://bugs.webkit.org/show_bug.cgi?id=36609

Api/qwebframe.cpp:

4:12 PM Changeset in webkit [56576] by eric@webkit.org

2 edits in trunk/WebCore

2010-03-25 Simon Hausmann <simon.hausmann@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Fix the package build on Maemo 5

https://bugs.webkit.org/show_bug.cgi?id=36607

Always embed the stylesheet for the no-listbox rendering. This way it'll be
included in the generated files for the package generation.

WebCore.pri:

4:09 PM Changeset in webkit [56575] by Laszlo Gombos

2 edits in trunk/WebKitTools

2010-03-25 Laszlo Gombos <Laszlo Gombos>

Unreviewed, build fix.

[Qt] Fix QtLauncher guards.

QtLauncher/main.cpp: (LauncherWindow::showFPS): (LauncherWindow::updateFPS):

3:49 PM Changeset in webkit [56574] by kov@webkit.org

2 edits in trunk/WebKit/gtk/po

2010-03-25 Reinout van Schouwen <reinouts@gnome.org>

Reviewed by Gustavo Noronha.

Updated Dutch translation
https://bugs.webkit.org/show_bug.cgi?id=36432

nl.po:

3:38 PM Changeset in webkit [56573] by scherkus@chromium.org

2 edits in trunk/LayoutTests

2010-03-25 Andrew Scherkus <scherkus@chromium.org>

Unreviewed, expectations tweak.

Reorganized and updated comments for media test expectations.

platform/chromium/test_expectations.txt: Tweaked.

3:29 PM Changeset in webkit [56572] by dumi@chromium.org

8 edits in trunk

WebCore: Changing the V8 and JSC implementations of
SQLStatementErrorCallback to interpret as false all results that
could be converted to a false boolean. Pretty much a revert of
r54981.

Reviewed by Dimitri Glazkov.

https://bugs.webkit.org/show_bug.cgi?id=36569

bindings/js/JSCustomSQLStatementErrorCallback.cpp:

(WebCore::JSCustomSQLStatementErrorCallback::handleEvent):

bindings/v8/custom/V8CustomSQLStatementErrorCallback.cpp:

(WebCore::V8CustomSQLStatementErrorCallback::handleEvent):

bindings/v8/custom/V8CustomVoidCallback.cpp:

(WebCore::invokeCallback):

bindings/v8/custom/V8CustomVoidCallback.h:

LayoutTests: Updating the test to conform to the latest spec changes.

Reviewed by Dimitri Glazkov.

storage/statement-error-callback-expected.txt:
storage/statement-error-callback.html:

3:25 PM Changeset in webkit [56571] by eric@webkit.org

2 edits in trunk/WebKit/chromium

2010-03-25 Jochen Eisinger <jochen@chromium.org>

Reviewed by Jeremy Orlow.

Remove ASSERT(isMainThread()) which is violated for workers and not necessary at this point.
https://bugs.webkit.org/show_bug.cgi?id=36614

src/DatabaseObserver.cpp: (WebCore::DatabaseObserver::canEstablishDatabase):

2:58 PM Changeset in webkit [56570] by dimich@chromium.org

2 edits in trunk/WebCore

Unreviewed, fix Chromium tests.

Recent http://trac.webkit.org/changeset/56489 made all urls in Chromium that
have unspecified port to return invalidPortNumber from KURL::port().

platform/KURLGoogle.cpp: Return 0 for unspecified ports, mimic WebKit KURL behavior for invalid ports.

(WebCore::KURL::port):

2:39 PM Changeset in webkit [56569] by krit@webkit.org

3 edits in trunk/WebCore

2010-03-25 Dirk Schulze <krit@webkit.org>

Reviewed by Nikolas Zimmermann.

This is a follow up of:
https://bugs.webkit.org/show_bug.cgi?id=30055
Bad DOM performance in large SVG files

Just save and restore the GraphicsContext, if we realy modify it.
(Cairo)Path::contains checks if a point is in the boundingBox
as a heuristic. The intention was to make the process faster for
points outside of this rect, but it rather causes the
opposite.

No new test cases added. No change in functionality.

platform/graphics/cairo/PathCairo.cpp: (WebCore::Path::contains):
rendering/RenderPath.cpp: (WebCore::RenderPath::paint):

2:33 PM Changeset in webkit [56568] by Simon Fraser

2 edits in trunk/WebCore

2010-03-25 Simon Fraser <Simon Fraser>

Revert r56565 which was based on an incorrect premise.

page/animation/CompositeAnimation.cpp: (WebCore::CompositeAnimation::clearRenderer): (WebCore::CompositeAnimation::updateKeyframeAnimations): (WebCore::CompositeAnimation::getAnimatedStyle): (WebCore::CompositeAnimation::setAnimating): (WebCore::CompositeAnimation::timeToNextService): (WebCore::CompositeAnimation::getAnimationForProperty): (WebCore::CompositeAnimation::suspendAnimations): (WebCore::CompositeAnimation::resumeAnimations): (WebCore::CompositeAnimation::isAnimatingProperty): (WebCore::CompositeAnimation::pauseAnimationAtTime): (WebCore::CompositeAnimation::numberOfActiveAnimations):

1:21 PM Changeset in webkit [56567] by ojan@chromium.org

11 edits
8 deletes in trunk

2010-03-25 Ojan Vafai <ojan@chromium.org>

Reviewed by David Levin.

mouse-based selections are always directional on Window/Linux
https://bugs.webkit.org/show_bug.cgi?id=25195

The tests are modified to expect different things for Win/Linux vs. Mac.

editing/selection/5195166-1.html:
editing/selection/extend-after-mouse-selection.html:
editing/selection/extend-selection-after-double-click-expected.txt:
editing/selection/extend-selection-after-double-click.html:
platform/chromium-linux/editing/selection/5195166-1-expected.checksum: Removed.
platform/chromium-linux/editing/selection/5195166-1-expected.png: Removed.
platform/chromium-win/editing/selection/5195166-1-expected.checksum: Removed.
platform/chromium-win/editing/selection/5195166-1-expected.png: Removed.
platform/chromium-win/editing/selection/5195166-1-expected.txt: Removed.
platform/mac/editing/selection/5195166-1-expected.checksum: Removed.
platform/mac/editing/selection/5195166-1-expected.png: Removed.
platform/mac/editing/selection/5195166-1-expected.txt:
platform/qt/editing/selection/5195166-1-expected.txt: Removed.
platform/win/editing/selection/extend-after-mouse-selection-expected.txt:

2010-03-25 Ojan Vafai <ojan@chromium.org>

Reviewed by David Levin.

mouse-based selections are always directional on Windows/Linux
https://bugs.webkit.org/show_bug.cgi?id=25195

Change m_lastChangeWasHorizontalExtension to m_isDirectional
and make m_isDirectional always be true for Windows/Linux.

editing/SelectionController.cpp: (WebCore::SelectionController::SelectionController): (WebCore::SelectionController::setSelection): (WebCore::SelectionController::setIsDirectional): (WebCore::SelectionController::willBeModified): When double-clicking, the base/extent will be in the middle of the selection instead of the start/end of it. Changed to maintain that modifications after double-click still move the start/end of the selection, not the base/extent. (WebCore::SelectionController::modify):
editing/SelectionController.h:
page/EventHandler.cpp: (WebCore::EventHandler::handleMousePressEventSingleClick): (WebCore::EventHandler::updateSelectionForMouseDrag):

1:20 PM Changeset in webkit [56566] by yurys@chromium.org

11 edits in trunk/WebKitTools

2010-03-25 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Allow running tests with enabled developer extras and closed Web Inspector. Tests that have inspector-enabled/ in their path/url will have developer extras enabled.

https://bugs.webkit.org/show_bug.cgi?id=36610

DumpRenderTree/LayoutTestController.h:
DumpRenderTree/gtk/DumpRenderTree.cpp: (shouldEnableDeveloperExtras): (runTest):
DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::setJavaScriptProfilingEnabled): (LayoutTestController::setDeveloperExtrasEnabled): (LayoutTestController::showWebInspector): (LayoutTestController::closeWebInspector):
DumpRenderTree/mac/DumpRenderTree.mm: (shouldEnableDeveloperExtras): (runTest):
DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::setJavaScriptProfilingEnabled): (LayoutTestController::setDeveloperExtrasEnabled): (LayoutTestController::showWebInspector): (LayoutTestController::closeWebInspector):
DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::shouldEnableDeveloperExtras): (WebCore::DumpRenderTree::open):
DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::closeWebInspector): (LayoutTestController::setDeveloperExtrasEnabled): (LayoutTestController::showWebInspector): (LayoutTestController::setJavaScriptProfilingEnabled):
DumpRenderTree/win/DumpRenderTree.cpp: (shouldEnableDeveloperExtras): (runTest):
DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::setJavaScriptProfilingEnabled): (LayoutTestController::setDeveloperExtrasEnabled): (LayoutTestController::showWebInspector): (LayoutTestController::closeWebInspector):

12:57 PM Changeset in webkit [56565] by Simon Fraser

2 edits in trunk/WebCore

2010-03-25 Simon Fraser <Simon Fraser>

Reviewed by Eric Carlson.

Make calls to m_keyframeAnimations.checkConsistency() debug-only
https://bugs.webkit.org/show_bug.cgi?id=36555

Remove lots of calls to m_keyframeAnimations.checkConsistency(); which were left after some earlier
debugging. Leave one in CompositeAnimation::animate() to catch any future issues, which is OK since
these calls are no-ops in release builds.

page/animation/CompositeAnimation.cpp: (WebCore::CompositeAnimation::clearRenderer): (WebCore::CompositeAnimation::updateKeyframeAnimations): (WebCore::CompositeAnimation::getAnimatedStyle): (WebCore::CompositeAnimation::setAnimating): (WebCore::CompositeAnimation::timeToNextService): (WebCore::CompositeAnimation::getAnimationForProperty): (WebCore::CompositeAnimation::suspendAnimations): (WebCore::CompositeAnimation::resumeAnimations): (WebCore::CompositeAnimation::isAnimatingProperty): (WebCore::CompositeAnimation::pauseAnimationAtTime): (WebCore::CompositeAnimation::numberOfActiveAnimations):

12:07 PM Changeset in webkit [56564] by Simon Fraser

2 edits in trunk/WebKit/mac

2010-03-25 Simon Fraser <Simon Fraser>

Build fix: no review.

Another c_str() -> data().

Plugins/Hosted/NetscapePluginInstanceProxy.mm: (WebKit::NetscapePluginInstanceProxy::enumerate):

11:58 AM Changeset in webkit [56563] by barraclough@apple.com

2 edits in trunk/JavaScriptCore

profiler/ProfileGenerator.cpp:

(JSC::ProfileGenerator::willExecute):
(JSC::ProfileGenerator::didExecute):

Reviewed by NOBODY (build fix).

11:48 AM Changeset in webkit [56562] by Simon Fraser

3 edits
6 adds in trunk

2010-03-25 Simon Fraser <Simon Fraser>

Reviewed by Geoffrey Garen.

https://bugs.webkit.org/show_bug.cgi?id=36557
Animations use the wrong timing-function sometimes

Fix an issue where animations picked the wrong style for their "unanimated" value.

Previously, the "unanimated" style was considered to be the style before the animation
was applied. This caused us to pick up stale values for animation timing functions, for
blending when a property is missing from the first keyframe, and for resuming transitions
once an animation ends.

Instead, we need to use the "current" style, which is the one that causes the animation
to kick off.

Tests: animations/longhand-timing-function.html

animations/transition-and-animation-3.html
animations/unanimated-style.html

page/animation/CompositeAnimation.cpp: (WebCore::CompositeAnimation::updateKeyframeAnimations):

11:37 AM WebKit Team edited by Chris Jerdonek

Updated link to committers.py. (diff)

11:29 AM Changeset in webkit [56561] by Csaba Osztrogonác

2 edits in trunk/LayoutTests

Unreviewed expected file fix.

platform/mac/fast/frames/flattening/frameset-flattening-grid-expected.txt: Needless newline removed.

11:20 AM Changeset in webkit [56560] by barraclough@apple.com

16 edits in trunk

Bug 36611 - Cleanup JSC::CString
Rename CString::c_str() -> CString::data(), CString::size() -> CString::length(),
remove UString::getCString() (all uses are wrong, should use UString::UTF8String()).

Reviewed by Geoff Garen.

JavaScriptCore:

bytecode/CodeBlock.cpp:

(JSC::CodeBlock::printUnaryOp):
(JSC::CodeBlock::printBinaryOp):
(JSC::CodeBlock::printConditionalJump):
(JSC::CodeBlock::printGetByIdOp):
(JSC::CodeBlock::printPutByIdOp):
(JSC::printGlobalResolveInfo):
(JSC::printStructureStubInfo):
(JSC::CodeBlock::printStructure):
(JSC::CodeBlock::printStructures):
(JSC::CodeBlock::dump):

jsc.cpp:

(functionPrint):
(functionDebug):
(runInteractive):
(fillBufferWithContentsOfFile):

profiler/CallIdentifier.h:

(JSC::CallIdentifier::c_str):

profiler/Profile.cpp:

(JSC::Profile::debugPrintDataSampleStyle):

profiler/ProfileNode.cpp:

(JSC::ProfileNode::debugPrintData):
(JSC::ProfileNode::debugPrintDataSampleStyle):

runtime/DateConversion.cpp:

(JSC::parseDate):

runtime/JSGlobalObjectFunctions.cpp:

(JSC::encode):
(JSC::globalFuncJSCPrint):

runtime/UString.cpp:

(JSC::operator==):
(JSC::UString::toDouble):

runtime/UString.h:

(JSC::CString::length):
(JSC::CString::data):

WebCore:

bridge/NP_jsobject.cpp:

(_NPN_Enumerate):

bridge/c/c_utility.cpp:

(JSC::Bindings::convertValueToNPVariant):

bridge/jni/jsc/JNIBridgeJSC.cpp:

(JavaField::valueFromInstance):
(JavaField::setValueToInstance):

bridge/jni/jsc/JavaInstanceJSC.cpp:

(JavaInstance::invokeMethod):

bridge/jni/jsc/JavaStringJSC.h:

(JSC::Bindings::JavaStringImpl::UTF8String):

11:03 AM Changeset in webkit [56559] by jwieczorek@webkit.org

7 edits in trunk/LayoutTests

2010-03-25 Jakub Wieczorek <jwieczorek@webkit.org>

Rubber-stamped by Tor Arne Vestbø.

[Qt] Update test results after r56555.
https://bugs.webkit.org/show_bug.cgi?id=36413

platform/qt/fast/forms/basic-inputs-expected.txt:
platform/qt/fast/forms/isindex-placeholder-expected.txt:
platform/qt/fast/forms/text-style-color-expected.txt:
platform/qt/fast/forms/textarea-placeholder-pseudo-style-expected.txt:
platform/qt/fast/forms/textarea-placeholder-set-attribute-expected.txt:
platform/qt/fast/forms/textarea-placeholder-set-value-expected.txt:

11:00 AM Changeset in webkit [56558] by ap@apple.com

2 edits in trunk/WebKit/mac

Reviewed by Mark Rowe.

Correctness fix after r56493.

Plugins/Hosted/NetscapePluginHostProxy.mm: (WKPCRunSyncOpenPanel): We still need to update our hostProxy reference, even though we didn't use to have instanceProxy. Nothing guarantees that the host proxy won't go away while the open panel is up.

10:51 AM Changeset in webkit [56557] by tonikitoo@webkit.org

2 edits in trunk/LayoutTests

2010-03-25 Antonio Gomes <tonikitoo@webkit.org>

Unreview expectation result fix.

After http://trac.webkit.org/changeset/56547, the test needs new (and proper)
results.

platform/mac/fast/frames/flattening/frameset-flattening-grid-expected.txt:

10:39 AM Changeset in webkit [56556] by Joseph Pecoraro

2 edits in trunk/WebKitSite

2010-03-25 Joseph Pecoraro <Joseph Pecoraro>

Reviewed by David Levin.

Asking Questions Page Grammar Fixes
https://bugs.webkit.org/show_bug.cgi?id=36608

asking_questions.html:

10:30 AM Changeset in webkit [56555] by jwieczorek@webkit.org

6 edits in trunk

2010-03-25 Jakub Wieczorek <jwieczorek@webkit.org>

Reviewed by Eric Seidel.

[Qt] RenderTheme: fix size adjustment for text fields
https://bugs.webkit.org/show_bug.cgi?id=36413

Update test results after RenderTheme changes.

platform/qt/fast/forms/textarea-placeholder-pseudo-style-expected.txt:
platform/qt/fast/forms/textarea-placeholder-set-attribute-expected.txt:
platform/qt/fast/forms/textarea-placeholder-set-value-expected.txt:

2010-03-25 Jakub Wieczorek <jwieczorek@webkit.org>

Reviewed by Eric Seidel.

[Qt] RenderTheme: fix size adjustment for text fields
https://bugs.webkit.org/show_bug.cgi?id=36413

To match other ports, remove the hardcoded dimensions for text fields so that
the default ones from WebCore can be used.
Properly apply the correct padding to text areas - this fixes their appearance
with the Oxygen style.

platform/qt/RenderThemeQt.cpp: (WebCore::RenderThemeQt::computeSizeBasedOnStyle):

10:21 AM Changeset in webkit [56554] by abarth@webkit.org

4 edits in trunk/WebKitTools

2010-03-25 Adam Barth <abarth@webkit.org>

Rubber stamped by Eric Seidel.

Tweaks to sheriffbot to improve latency by keeping the working copy up
to date even when there's no build break. Also, officially move
sheriffbot to #webkit.

(Also teach ValidateReviewer to understand rubber stamps.)

Scripts/webkitpy/common/net/irc/ircbot.py:
Scripts/webkitpy/tool/commands/sheriffbot.py:
Scripts/webkitpy/tool/steps/validatereviewer.py:

10:18 AM Changeset in webkit [56553] by tonikitoo@webkit.org

4 edits in trunk/WebKitTools

Not displaying FPS info on the terminal. On S60 and Maemo the Window title will be used and Status bar will used on desktop.

Reviewed by Simon Hausmann.
Patch by Jesus Palencia <jesus.palencia@openbossa.org>

[Qt] QtLauncher's FPS info should not be displayed on the terminal
https://bugs.webkit.org/show_bug.cgi?id=36244

QtLauncher/main.cpp:

(LauncherWindow::initializeView):
(LauncherWindow::showFPS):
(LauncherWindow::updateFPS):

QtLauncher/webview.cpp:

(WebViewGraphicsBased::setFrameRateMeasurementEnabled):
(WebViewGraphicsBased::updateFrameRate):

QtLauncher/webview.h:

(WebViewGraphicsBased::frameRateMeasurementEnabled):

9:42 AM Changeset in webkit [56552] by vestbo@webkit.org

6 edits in trunk

[Qt] Implement ChromeClient::windowResizerRect()

Reviewed by Simon Hausmann.

https://bugs.webkit.org/show_bug.cgi?id=21300

We assume the resize corner to be in the lower right corner of
the window and having the width and height of the scrollbars.

The helper function geometryRelativeToOwnerWidget() in the page
client is used to clip the resize rect to the actual size of the
viewport, not the size of the QGraphicsView.

9:31 AM Changeset in webkit [56551] by Joseph Pecoraro

2 edits in trunk/WebKitSite

2010-03-25 Joseph Pecoraro <Joseph Pecoraro>

Reviewed by Timothy Hatcher.

New Asking Questions Page is not Valid HTML5
https://bugs.webkit.org/show_bug.cgi?id=36605

asking_questions.html: fixed issues raised by the validator.

9:18 AM Changeset in webkit [56550] by jchaffraix@webkit.org

4 edits in trunk/LayoutTests

[Qt][GTK] http/tests/xmlhttprequest/xmlhttprequest-onProgress-open-should-zero-length.html
fails after r56394
https://bugs.webkit.org/show_bug.cgi?id=36531

Reviewed by Alexey Proskuryakov.

The test was assuming that we would receive 3 progress events which may not be the case anymore
due to the event throttling added in r56394.

http/tests/xmlhttprequest/xmlhttprequest-onProgress-open-should-zero-length.html: Removed

the counting as it belonged to the original version of the test and instead use the position
to determine when to reset the XHR.

platform/gtk/Skipped:
platform/qt/Skipped:

Removed the test from the Skipped lists now that it should pass.

9:09 AM Changeset in webkit [56549] by Joseph Pecoraro

2 edits in trunk/WebCore

2010-03-25 Joseph Pecoraro <Joseph Pecoraro>

Reviewed by Pavel Feldman.

Web Inspector: reloading debug target window with cmd-R from inspector window produces beep.
https://bugs.webkit.org/show_bug.cgi?id=36554

inspector/front-end/inspector.js: (WebInspector.documentKeyDown): prevent the default behavior, if handled, which would result in a system beep.

8:49 AM QtWebKitBackportingFixes edited by Simon Hausmann

(diff)

8:25 AM Changeset in webkit [56548] by eric@webkit.org

7 edits in trunk

2010-03-25 Jochen Eisinger <jochen@chromium.org>

Reviewed by Jeremy Orlow.

Forward DatabaseTracker::canEstablishDatabase to chromium layer.
https://bugs.webkit.org/show_bug.cgi?id=36595

storage/chromium/DatabaseObserver.h:
storage/chromium/DatabaseTrackerChromium.cpp: (WebCore::DatabaseTracker::canEstablishDatabase):

2010-03-25 Jochen Eisinger <jochen@chromium.org>

Reviewed by Jeremy Orlow.

Forward DatabaseTracker::canEstablishDatabase to chromium layer.
https://bugs.webkit.org/show_bug.cgi?id=36595

public/WebFrameClient.h: (WebKit::WebFrameClient::allowDatabase):
src/DatabaseObserver.cpp: (WebCore::DatabaseObserver::canEstablishDatabase):
src/WebWorkerBase.h: (WebKit::WebWorkerBase::allowDatabase):

8:24 AM Changeset in webkit [56547] by tonikitoo@webkit.org

5 edits in trunk

Added missing frame flattening activation on fast/frames/flattening/frameset-flattening-grid.html; removed unnecessary CONSOLE MESSAGE from the expected file; reset the setFrameSetFlatteningEnabled for each test.

Reviewed by Kenneth Christiansen.
Patch by Diego Gonzalez <diego.gonzalez@openbossa.org>

WebKitTools:

DumpRenderTree/qt/DumpRenderTreeQt.cpp:

(WebCore::WebPage::resetSettings):

LayoutTests:

fast/frames/flattening/frameset-flattening-grid.html:
platform/qt/fast/frames/flattening/frameset-flattening-grid-expected.txt:

8:06 AM Changeset in webkit [56546] by eric@webkit.org

4 edits in trunk/WebCore

2010-03-25 yael aharon <yael.aharon@nokia.com>

Reviewed by Laszlo Gombos.

[Qt] Windowed netscape plugins don't work with QGraphicsWebView on Symbian
https://bugs.webkit.org/show_bug.cgi?id=35112

Add a proxy widget when loading a QWidget based plugin in a QGraphicsWebView.

plugins/symbian/PluginContainerSymbian.cpp: (PluginContainerSymbian::PluginContainerSymbian): (PluginContainerSymbian::focusInEvent):
plugins/symbian/PluginContainerSymbian.h: (WebCore::PluginContainerSymbian::proxy):
plugins/symbian/PluginViewSymbian.cpp: (WebCore::PluginView::updatePluginWidget): (WebCore::PluginView::platformStart): (WebCore::PluginView::platformDestroy):

8:04 AM QtWebKitBackportingFixes edited by Simon Hausmann

(diff)

8:04 AM Changeset in webkit [56545] by Chris Jerdonek

3 edits in trunk/WebKitTools

Moved deprecated_logging unit test import statement from
webkitpy/unittests.py to webkitpy/common/system/unittests.py.

Reviewed by Adam Barth.

https://bugs.webkit.org/show_bug.cgi?id=36093

This is part of the master bug to reorganize webkitpy.

Scripts/webkitpy/common/system/unittests.py:
Scripts/webkitpy/unittests.py:

7:46 AM Changeset in webkit [56544] by Chris Jerdonek

40 edits
2 moves in trunk/WebKitTools

Moved webkit_logging.py to common/system/deprecated_logging.py
inside webkitpy.

Reviewed by Adam Barth.

https://bugs.webkit.org/show_bug.cgi?id=36093

This is part of the master bug to reorganize webkitpy.

Scripts/validate-committer-lists:
Scripts/webkitpy/common/checkout/changelog.py:
Scripts/webkitpy/common/checkout/scm.py:
Scripts/webkitpy/common/net/bugzilla.py:
Scripts/webkitpy/common/net/buildbot.py:
Scripts/webkitpy/common/net/credentials.py:
Scripts/webkitpy/common/net/irc/ircproxy.py:
Scripts/webkitpy/common/net/networktransaction.py:
Scripts/webkitpy/common/net/statusserver.py:
Scripts/webkitpy/common/system/deprecated_logging.py: Copied from WebKitTools/Scripts/webkitpy/webkit_logging.py.
Scripts/webkitpy/common/system/deprecated_logging_unittest.py: Copied from WebKitTools/Scripts/webkitpy/webkit_logging_unittest.py.
Scripts/webkitpy/common/system/executive.py:
Scripts/webkitpy/tool/bot/queueengine.py:
Scripts/webkitpy/tool/commands/download.py:
Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
Scripts/webkitpy/tool/commands/openbugs.py:
Scripts/webkitpy/tool/commands/queries.py:
Scripts/webkitpy/tool/commands/queues.py:
Scripts/webkitpy/tool/commands/sheriffbot.py:
Scripts/webkitpy/tool/commands/stepsequence.py:
Scripts/webkitpy/tool/commands/upload.py:
Scripts/webkitpy/tool/main.py:
Scripts/webkitpy/tool/mocktool.py:
Scripts/webkitpy/tool/multicommandtool.py:
Scripts/webkitpy/tool/steps/abstractstep.py:
Scripts/webkitpy/tool/steps/applypatch.py:
Scripts/webkitpy/tool/steps/build.py:
Scripts/webkitpy/tool/steps/checkstyle.py:
Scripts/webkitpy/tool/steps/closebug.py:
Scripts/webkitpy/tool/steps/closebugforlanddiff.py:
Scripts/webkitpy/tool/steps/confirmdiff.py:
Scripts/webkitpy/tool/steps/ensurebuildersaregreen.py:
Scripts/webkitpy/tool/steps/ensurelocalcommitifneeded.py:
Scripts/webkitpy/tool/steps/obsoletepatches.py:
Scripts/webkitpy/tool/steps/preparechangelog.py:
Scripts/webkitpy/tool/steps/reopenbugafterrollout.py:
Scripts/webkitpy/tool/steps/runtests.py:
Scripts/webkitpy/tool/steps/update.py:
Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py:
Scripts/webkitpy/tool/steps/validatereviewer.py:
Scripts/webkitpy/unittests.py:
Scripts/webkitpy/webkit_logging.py: Removed.
Scripts/webkitpy/webkit_logging_unittest.py: Removed.

7:31 AM Changeset in webkit [56543] by Simon Fraser

5 edits
2 adds in trunk

2010-03-25 Simon Fraser <Simon Fraser>

Reviewed by Adele Peterson.

https://bugs.webkit.org/show_bug.cgi?id=35714
Computed style on delayed transform animations is incorrect

When fetching computed style while a delayed accelerated animation is in effect,
we would get the value form the first keyframe, rather than getting the current
style.

Fix by checking to see whether we've in the delay phase (with no backwards-fill)
in KeyframeAnimation::getAnimatedStyle().

Test: compositing/animation/computed-style-during-delay.html

page/animation/KeyframeAnimation.cpp: (WebCore::KeyframeAnimation::getAnimatedStyle):

7:31 AM Changeset in webkit [56542] by Simon Fraser

1 edit in trunk/JavaScriptCore/ChangeLog

Additional refptr/passrefptr workarounds for WINSCW compiler

https://bugs.webkit.org/show_bug.cgi?id=28054

Patch by Janne Koskinen <janne.p.koskinen@digia.com> on 2010-02-12

Reviewed by Tor Arne Vestbø.

wtf/PassRefPtr.h:

(WTF::refIfNotNull):
(WTF::PassRefPtr::PassRefPtr):
(WTF::PassRefPtr::~PassRefPtr):
(WTF::PassRefPtr::clear):
(WTF::::operator):

wtf/RefPtr.h:

(WTF::RefPtr::RefPtr):
(WTF::::operator):

7:27 AM Changeset in webkit [56541] by jchaffraix@webkit.org

2 edits
1 add in trunk/WebKitSite

Add a page on how to ask questions
https://bugs.webkit.org/show_bug.cgi?id=35223

Reviewed by David Levin.

asking_questions.html: Added.

Add a page on how to ask questions based on Ariya Hidayat's mail: how
to get help effectively
(http://article.gmane.org/gmane.os.opendarwin.webkit.user/145/match=get+help+effectively)

contact.html: Tweaked the wording to make it more clear what the

mailing list are used for. Also changed the formatting to better
underline the different mailing lists.

7:14 AM PythonGuidelines edited by Chris Jerdonek

Added note on cleaning *.pyc files. (diff)

7:13 AM Changeset in webkit [56540] by jchaffraix@webkit.org

2 edits in trunk/WebKitTools

commit-log-editor can call itself in an infinite loop
https://bugs.webkit.org/show_bug.cgi?id=35291

Reviewed by Kenneth Rohde Christiansen.

if $editor ends up being commit-log-editor, the script will exec itself
in an infinite loop.

To avoid this, we now check that the $editor variable is not
commit-log-editor to avoid this case.

Scripts/commit-log-editor: Added an isCommitLogEditor method and

reworked the $editor setting to add this check.

7:04 AM Changeset in webkit [56539] by eric@webkit.org

2 edits in trunk/WebKitTools

2010-03-25 Jesus Sanchez-Palencia <jesus.palencia@openbossa.org>

Reviewed by Kenneth Rohde Christiansen.

Add a Toggle Frame Flattening option to QtLauncher.
It will be enabled by default on Maemo5 and S60 platforms.

[Qt] Add enable/disable Frame Flattening option to QtLauncher
https://bugs.webkit.org/show_bug.cgi?id=36558

QtLauncher/main.cpp: (LauncherWindow::applyPrefs): (LauncherWindow::toggleFrameFlattening): (LauncherWindow::createChrome):

6:45 AM Changeset in webkit [56538] by eric@webkit.org

2 edits in trunk/WebCore

2010-03-25 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Initialize Web Inspector title with inspected page URL when opening Web Inspector.

https://bugs.webkit.org/show_bug.cgi?id=36534

inspector/InspectorController.cpp: (WebCore::InspectorController::setFrontend):

6:43 AM Changeset in webkit [56537] by chang.shu@nokia.com

2 edits in trunk/WebKit/qt

2010-03-25 Shu Chang <chang.shu@nokia.com>

Reviewed by Simon Hausmann.

[Qt] Added documentation for delete button.
https://bugs.webkit.org/show_bug.cgi?id=31560

Api/qwebsettings.cpp:

6:21 AM Changeset in webkit [56536] by eric@webkit.org

2 edits in trunk/WebKit/qt

2010-03-25 Tasuku Suzuki <tasuku.suzuki@nokia.com>

Reviewed by Eric Seidel.

[Qt]Fix compile error with QT_NO_DESKTOPSERVICES
https://bugs.webkit.org/show_bug.cgi?id=36533

Api/qwebsettings.cpp: (QWebSettings::enablePersistentStorage):

6:02 AM Changeset in webkit [56535] by eric@webkit.org

2 edits in trunk/WebCore

2010-03-25 Antti Koivisto <koivisto@iki.fi>

Reviewed by Kenneth Rohde Christiansen.

https://bugs.webkit.org/show_bug.cgi?id=36316
Tiles of selected content do not update if not in viewport

Don't clip repaints to viewport when tiling is enabled.

page/Frame.cpp: (WebCore::Frame::setView): (WebCore::Frame::setTiledBackingStoreEnabled):

5:43 AM Changeset in webkit [56534] by eric@webkit.org

4 edits in trunk

2010-03-25 Diego Gonzalez <diego.gonzalez@openbossa.org>

Reviewed by Eric Seidel.

Missing forward ENABLE_DATALIST macro to JavaScript enabled features macros
on WebKit.pri

[Qt] Forward ENABLE_DATALIST macro to JavaScript enabled macros
https://bugs.webkit.org/show_bug.cgi?id=36547

platform/qt/Skipped:

2010-03-25 Diego Gonzalez <diego.gonzalez@openbossa.org>

Reviewed by Eric Seidel.

Missing forward ENABLE_DATALIST macro to JavaScript enabled features macros
on WebKit.pri

[Qt] Forward ENABLE_DATALIST macro to JavaScript enabled macros
https://bugs.webkit.org/show_bug.cgi?id=36547

WebCore.pri:

5:22 AM Changeset in webkit [56533] by eric@webkit.org

2 edits in trunk/WebKit/qt

2010-03-25 Tasuku Suzuki <tasuku.suzuki@nokia.com>

Reviewed by Eric Seidel.

[Qt]Fix compile error with QT_NO_DEBUG_STREAM
https://bugs.webkit.org/show_bug.cgi?id=36533

Api/qgraphicswebview.cpp: (QGraphicsWebViewPrivate::graphicsItemVisibleRect):

5:19 AM Changeset in webkit [56532] by pfeldman@chromium.org

3 edits in trunk/WebCore

2010-03-25 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: Expect console object wrapping to fail.

https://bugs.webkit.org/show_bug.cgi?id=36587

inspector/front-end/InjectedScript.js: (injectedScriptConstructor):

5:03 AM Changeset in webkit [56531] by eric@webkit.org

4 edits in trunk/WebKit/gtk

2010-03-25 Sergio Villar Senín <svillar@igalia.com>

Reviewed by Xan Lopez.

Added new API webkit_web_back_forward_list_clear. This function
clears the back forward list

[GTK] http/history tests are failing
https://bugs.webkit.org/show_bug.cgi?id=36173

tests/testwebbackforwardlist.c: (test_webkit_web_back_forward_list_clear): (main): added new unit test for the new API
webkit/webkitwebbackforwardlist.cpp: (webkit_web_back_forward_list_clear):
webkit/webkitwebbackforwardlist.h: new function that clears the back forward list

4:44 AM Changeset in webkit [56530] by eric@webkit.org

3 edits
2 adds in trunk

2010-03-25 Joanmarie Diggs <joanmarie.diggs@gmail.com>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=36371
[Gtk] Elements with a title attribute should not be ignored

platform/gtk/accessibility/object-with-title.html: Added
platform/gtk/accessibility/object-with-title-expected.txt: Added

2010-03-25 Joanmarie Diggs <joanmarie.diggs@gmail.com>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=36371
[Gtk] Elements with a title attribute should not be ignored

accessibility/AccessibilityRenderObject.cpp: (AccessibilityRenderObject::accessibilityIsIgnored):

4:23 AM Changeset in webkit [56529] by eric@webkit.org

2 edits in trunk/WebKit/qt

2010-03-25 Kenneth Rohde Christiansen <kenneth@webkit.org>

Reviewed by Eric Seidel.

Make QWebPage not depend on view() but use the client->ownerWidget()
instead. Also, handle the case where there is not page client.

Api/qwebpage.cpp: (QWebPagePrivate::createContextMenu): (QWebPagePrivate::keyPressEvent): (QWebPage::javaScriptAlert): (QWebPage::javaScriptConfirm): (QWebPage::javaScriptPrompt): (QWebPage::shouldInterruptJavaScript): (QWebPage::createWindow): (QWebPage::action): (QWebPage::extension): (QWebPage::chooseFile): (QWebPage::userAgentForUrl):

4:20 AM Changeset in webkit [56528] by jocelyn.turcotte@nokia.com

2 edits in trunk/JavaScriptCore

[Qt] Build fix on MSVC. Reverts r55633 for stdint.h

Reviewed by nobody, build fix.

This file gets included in generated moc files which don't
include the prefix header.

os-win32/stdint.h:

3:43 AM PythonGuidelines edited by Chris Jerdonek

Added note about *.pyc files (diff)

3:40 AM Changeset in webkit [56527] by steveblock@google.com

2 edits in trunk/WebCore

2010-03-24 Steve Block <steveblock@google.com>

Reviewed by David Levin.

Adds a missing ENABLE(WORKERS) guards to the V8 bindings.
https://bugs.webkit.org/show_bug.cgi?id=36550

Build fix only, no new tests.

bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::instantiateV8Object):

3:33 AM Changeset in webkit [56526] by eric@webkit.org

3 edits in trunk/WebCore

2010-03-25 Leandro Pereira <leandro@profusion.mobi>

Reviewed by Eric Seidel.

Add EFL-specific code to platform/ScrollView.cpp and
platform/Scrollbar.cpp.
http://webkit.org/b/36305

platform/ScrollView.cpp:
platform/Scrollbar.cpp:

3:30 AM PythonGuidelines edited by Chris Jerdonek

Added Basics and Code Structure sub-sections (diff)

3:12 AM Changeset in webkit [56525] by eric@webkit.org

3 edits in trunk/WebCore

2010-03-25 Tasuku Suzuki <tasuku.suzuki@nokia.com>

Reviewed by Eric Seidel.

[Qt]Fix compile error with QT_NO_LIBRARY
https://bugs.webkit.org/show_bug.cgi?id=36533

platform/FileSystem.h:
platform/qt/FileSystemQt.cpp: (WebCore::unloadModule):

2:46 AM Changeset in webkit [56524] by zoltan@webkit.org

2 edits in trunk/WebKitTools

2010-03-25 Zoltan Horvath <zoltan@webkit.org>

Reviewed by Eric Seidel.

svn-create-patch prints a warning for large patches
https://bugs.webkit.org/show_bug.cgi?id=32582

svn-create-patch prints a warning message for larger patches than 20k.

Scripts/svn-create-patch:

2:40 AM Changeset in webkit [56523] by eric@webkit.org

3 edits in trunk/WebCore

2010-03-25 Tasuku Suzuki <tasuku.suzuki@nokia.com>

Reviewed by Eric Seidel.

[Qt]Fix compile error with QT_NO_ANIMATION
https://bugs.webkit.org/show_bug.cgi?id=36526

platform/graphics/qt/GraphicsLayerQt.cpp: (WebCore::GraphicsLayerQtImpl::~GraphicsLayerQtImpl):
platform/graphics/qt/GraphicsLayerQt.h:

2:32 AM Changeset in webkit [56522] by abarth@webkit.org

3 edits
2 moves in trunk/WebKitTools

2010-03-25 Adam Barth <abarth@webkit.org>

Unreviewed. Renamed early_warning_system.py to earlywarningsystem.py.
https://bugs.webkit.org/show_bug.cgi?id=36093

Scripts/webkitpy/tool/commands/early_warning_system.py: Removed.
Scripts/webkitpy/tool/commands/early_warning_system_unittest.py: Removed.
Scripts/webkitpy/tool/commands/earlywarningsystem.py: Copied from Scripts/webkitpy/tool/commands/early_warning_system.py.
Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py: Copied from Scripts/webkitpy/tool/commands/early_warning_system_unittest.py.
Scripts/webkitpy/tool/main.py:
Scripts/webkitpy/tool/unittests.py:

2:30 AM Changeset in webkit [56521] by Chris Jerdonek

3 edits
2 copies
1 add in trunk/WebKitTools

In webkitpy, pushed the unit test import statements in
webkitpy/unittests.py into appropriate unittests.py files in the
new root-level packages beneath webkitpy.

Reviewed by Adam Barth.

https://bugs.webkit.org/show_bug.cgi?id=36093

This is part of the master bug to reorganize webkitpy.

Scripts/webkitpy/common/system/unittests.py:
Scripts/webkitpy/common/unittests.py: Added.
Scripts/webkitpy/python24/unittests.py: Added.
Scripts/webkitpy/tool/unittests.py: Added.
Scripts/webkitpy/unittests.py:

2:17 AM Changeset in webkit [56520] by abarth@webkit.org

3 edits
1 move in trunk/WebKitTools

2010-03-25 Adam Barth <abarth@webkit.org>

Unreviewed. Move WebKitCheckout into the webkitpy.common.checkout
package.
https://bugs.webkit.org/show_bug.cgi?id=36093

Scripts/webkitpy/common/checkout/api.py: Copied from Scripts/webkitpy/webkitcheckout.py.
Scripts/webkitpy/tool/main.py:
Scripts/webkitpy/tool/mocktool.py:
Scripts/webkitpy/webkitcheckout.py: Removed.

2:11 AM Changeset in webkit [56519] by abarth@webkit.org

10 edits
1 move in trunk/WebKitTools

2010-03-25 Adam Barth <abarth@webkit.org>

Unreviewed. Move OutputCapture to webkitpy.common.system.
https://bugs.webkit.org/show_bug.cgi?id=36093

Scripts/webkitpy/common/net/bugzilla_unittest.py:
Scripts/webkitpy/common/net/credentials_unittest.py:
Scripts/webkitpy/common/system/outputcapture.py: Copied from Scripts/webkitpy/outputcapture.py.
Scripts/webkitpy/outputcapture.py: Removed.
Scripts/webkitpy/tool/commands/commandtest.py:
Scripts/webkitpy/tool/commands/queues_unittest.py:
Scripts/webkitpy/tool/commands/queuestest.py:
Scripts/webkitpy/tool/multicommandtool_unittest.py:
Scripts/webkitpy/tool/steps/closebugforlanddiff_unittest.py:
Scripts/webkitpy/tool/steps/steps_unittest.py:
Scripts/webkitpy/tool/steps/updatechangelogswithreview_unittests.py:

2:05 AM Changeset in webkit [56518] by abarth@webkit.org

7 edits
2 moves in trunk/WebKitTools

2010-03-25 Adam Barth <abarth@webkit.org>

Unreviewed. Move user.py to webkitpy.common.system.

Scripts/webkitpy/common/checkout/scm.py:
Scripts/webkitpy/common/net/bugzilla.py:
Scripts/webkitpy/common/net/credentials.py:
Scripts/webkitpy/common/system/user.py: Copied from Scripts/webkitpy/user.py.
Scripts/webkitpy/common/system/user_unittest.py: Copied from Scripts/webkitpy/user_unittest.py.
Scripts/webkitpy/tool/commands/upload.py:
Scripts/webkitpy/tool/main.py:
Scripts/webkitpy/unittests.py:
Scripts/webkitpy/user.py: Removed.
Scripts/webkitpy/user_unittest.py: Removed.

2:01 AM Changeset in webkit [56517] by abarth@webkit.org

19 edits
2 moves in trunk/WebKitTools

2010-03-25 Adam Barth <abarth@webkit.org>

Unreviewed. Move executive.py to webkitpy.common.system.
https://bugs.webkit.org/show_bug.cgi?id=36093

Scripts/webkitpy/common/checkout/scm.py:
Scripts/webkitpy/common/checkout/scm_unittest.py:
Scripts/webkitpy/common/config/ports.py:
Scripts/webkitpy/common/config/ports_unittest.py:
Scripts/webkitpy/common/net/credentials.py:
Scripts/webkitpy/common/net/credentials_unittest.py:
Scripts/webkitpy/common/system/executive.py: Copied from Scripts/webkitpy/executive.py.
Scripts/webkitpy/common/system/executive_unittest.py: Copied from Scripts/webkitpy/executive_unittest.py.
Scripts/webkitpy/executive.py: Removed.
Scripts/webkitpy/executive_unittest.py: Removed.
Scripts/webkitpy/layout_tests/port/mac.py:
Scripts/webkitpy/tool/bot/queueengine.py:
Scripts/webkitpy/tool/bot/queueengine_unittest.py:
Scripts/webkitpy/tool/commands/download.py:
Scripts/webkitpy/tool/commands/early_warning_system.py:
Scripts/webkitpy/tool/commands/queues.py:
Scripts/webkitpy/tool/commands/stepsequence.py:
Scripts/webkitpy/tool/main.py:
Scripts/webkitpy/tool/steps/checkstyle.py:
Scripts/webkitpy/tool/steps/preparechangelog.py:
Scripts/webkitpy/unittests.py:
Scripts/webkitpy/webkit_logging_unittest.py:

1:50 AM Changeset in webkit [56516] by abarth@webkit.org

9 edits
2 moves in trunk/WebKitTools

2010-03-25 Adam Barth <abarth@webkit.org>

Unreviewed. Move grammary.py into webkitpy.tool.
https://bugs.webkit.org/show_bug.cgi?id=36093

Scripts/webkitpy/grammar.py: Removed.
Scripts/webkitpy/grammar_unittest.py: Removed.
Scripts/webkitpy/tool/commands/download.py:
Scripts/webkitpy/tool/commands/queries.py:
Scripts/webkitpy/tool/commands/queues.py:
Scripts/webkitpy/tool/commands/upload.py:
Scripts/webkitpy/tool/grammar.py: Copied from Scripts/webkitpy/grammar.py.
Scripts/webkitpy/tool/grammar_unittest.py: Copied from Scripts/webkitpy/grammar_unittest.py.
Scripts/webkitpy/tool/multicommandtool.py:
Scripts/webkitpy/tool/steps/obsoletepatches.py:
Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py:
Scripts/webkitpy/unittests.py:

1:49 AM Changeset in webkit [56515] by jam@chromium.org

2 edits in trunk/WebKit/chromium

2010-03-10 John Abd-El-Malek <jam@chromium.org>

Reviewed by Darin Fisher.

[chromium] Fix up WebMouseWheelEventBuilder to properly calculate the units
https://bugs.webkit.org/show_bug.cgi?id=35989

src/WebInputEventConversion.cpp:

1:48 AM Changeset in webkit [56514] by Chris Jerdonek

6 edits
1 move in trunk/WebKitTools

In webkitpy, moved init/ to common/system/.

Reviewed by Adam Barth.

https://bugs.webkit.org/show_bug.cgi?id=36093

This is part of the master bug to reorganize webkitpy.

Scripts/webkitpy/common/system: Copied from WebKitTools/Scripts/webkitpy/init.
Scripts/webkitpy/common/system/logutils.py:
Scripts/webkitpy/common/system/logutils_unittest.py:
Scripts/webkitpy/init: Removed.
Scripts/webkitpy/init/init.py: Removed.
Scripts/webkitpy/init/logtesting.py: Removed.
Scripts/webkitpy/init/logutils.py: Removed.
Scripts/webkitpy/init/logutils_unittest.py: Removed.
Scripts/webkitpy/init/unittests.py: Removed.
Scripts/webkitpy/python24/versioning_unittest.py:
Scripts/webkitpy/style_references.py:
Scripts/webkitpy/unittests.py:

1:46 AM Changeset in webkit [56513] by tony@chromium.org

2 edits in trunk/WebCore

2010-03-25 Tony Chang <tony@chromium.org>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=33697
Have dragOpFromIEOp("move") return DragOperationGeneric | DragOperationMove
because only returning Generic doesn't work for platforms that don't
have a generic operation.

Covered by existing tests (fast/events/drag-and-drop.html).

dom/Clipboard.cpp: (WebCore::dragOpFromIEOp): (WebCore::Clipboard::destinationOperation): (WebCore::Clipboard::setDestinationOperation):

1:42 AM Changeset in webkit [56512] by abarth@webkit.org

4 edits
1 move in trunk/WebKitTools

2010-03-25 Adam Barth <abarth@webkit.org>

Unreviewed. Move stepsequence to webkitpy.tool.commands.
https://bugs.webkit.org/show_bug.cgi?id=36093

Scripts/webkitpy/stepsequence.py: Removed.
Scripts/webkitpy/tool/commands/abstractsequencedcommand.py:
Scripts/webkitpy/tool/commands/download.py:
Scripts/webkitpy/tool/commands/queues.py:
Scripts/webkitpy/tool/commands/stepsequence.py: Copied from Scripts/webkitpy/stepsequence.py.

1:38 AM Changeset in webkit [56511] by ukai@chromium.org

4 edits in trunk

2010-03-25 Fumitoshi Ukai <ukai@chromium.org>

Reviewed by Eric Seidel.

[Qt] websocket/tests/long-invalid-header.html fails
https://bugs.webkit.org/show_bug.cgi?id=36492

websocket/tests/long-invalid-header-expected.txt: trim console message.

2010-03-25 Fumitoshi Ukai <ukai@chromium.org>

Reviewed by Eric Seidel.

[Qt] websocket/tests/long-invalid-header.html fails
https://bugs.webkit.org/show_bug.cgi?id=36492

trim message at most 128 bytes from the current position.
I believe it's enough data to investigate the error reason and
it makes test not depend on buffered size.

websockets/WebSocketHandshake.cpp: (WebCore::trimConsoleMessage): (WebCore::WebSocketHandshake::readServerHandshake): (WebCore::WebSocketHandshake::readHTTPHeaders):

1:34 AM Changeset in webkit [56510] by abarth@webkit.org

15 edits
1 copy
8 moves
1 add in trunk/WebKitTools

2010-03-25 Adam Barth <abarth@webkit.org>

Unreviewed. Create webkitpy.common.checkout as described in
https://bugs.webkit.org/show_bug.cgi?id=36093

Scripts/webkitpy/changelogs.py: Removed.
Scripts/webkitpy/changelogs_unittest.py: Removed.
Scripts/webkitpy/commitinfo.py: Removed.
Scripts/webkitpy/commitinfo_unittest.py: Removed.
Scripts/webkitpy/common/checkout: Added.
Scripts/webkitpy/common/checkout/init.py: Copied from Scripts/webkitpy/common/init.py.
Scripts/webkitpy/common/checkout/changelog.py: Copied from Scripts/webkitpy/changelogs.py.
Scripts/webkitpy/common/checkout/changelog_unittest.py: Copied from Scripts/webkitpy/changelogs_unittest.py.
Scripts/webkitpy/common/checkout/commitinfo.py: Copied from Scripts/webkitpy/commitinfo.py.
Scripts/webkitpy/common/checkout/commitinfo_unittest.py: Copied from Scripts/webkitpy/commitinfo_unittest.py.
Scripts/webkitpy/common/checkout/diff_parser.py: Copied from Scripts/webkitpy/diff_parser.py.
Scripts/webkitpy/common/checkout/diff_parser_unittest.py: Copied from Scripts/webkitpy/diff_parser_unittest.py.
Scripts/webkitpy/common/checkout/scm.py: Copied from Scripts/webkitpy/scm.py.
Scripts/webkitpy/common/checkout/scm_unittest.py: Copied from Scripts/webkitpy/scm_unittest.py.
Scripts/webkitpy/common/net/credentials.py:
Scripts/webkitpy/diff_parser.py: Removed.
Scripts/webkitpy/diff_parser_unittest.py: Removed.
Scripts/webkitpy/layout_tests/port/base.py:
Scripts/webkitpy/scm.py: Removed.
Scripts/webkitpy/scm_unittest.py: Removed.
Scripts/webkitpy/stepsequence.py:
Scripts/webkitpy/style_references.py:
Scripts/webkitpy/tool/commands/download.py:
Scripts/webkitpy/tool/commands/queries.py:
Scripts/webkitpy/tool/comments.py:
Scripts/webkitpy/tool/main.py:
Scripts/webkitpy/tool/mocktool.py:
Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py:
Scripts/webkitpy/tool/steps/validatereviewer.py:
Scripts/webkitpy/unittests.py:
Scripts/webkitpy/webkitcheckout.py:

1:02 AM Changeset in webkit [56509] by Chris Jerdonek

5 edits
1 copy
2 moves
1 add in trunk/WebKitTools

In webkitpy, moved init/versioning.py to python24/.

Reviewed by Adam Barth.

https://bugs.webkit.org/show_bug.cgi?id=36093

This is part of the master bug to reorganize webkitpy.

Scripts/test-webkitpy:
Scripts/webkit-patch:
Scripts/webkitpy/init/unittests.py:
Scripts/webkitpy/init/versioning.py: Removed.
Scripts/webkitpy/init/versioning_unittest.py: Removed.
Scripts/webkitpy/python24: Added.
Scripts/webkitpy/python24/init.py: Copied from WebKitTools/Scripts/webkitpy/tool/init.py.
Scripts/webkitpy/python24/versioning.py: Copied from WebKitTools/Scripts/webkitpy/init/versioning.py.
Scripts/webkitpy/python24/versioning_unittest.py: Copied from WebKitTools/Scripts/webkitpy/init/versioning_unittest.py.
Scripts/webkitpy/unittests.py:

12:52 AM Changeset in webkit [56508] by abarth@webkit.org

20 edits
10 moves
2 adds in trunk/WebKitTools

2010-03-25 Adam Barth <abarth@webkit.org>

Unreviewed.

Create webkitpy.common.net as described in
https://bugs.webkit.org/show_bug.cgi?id=36093

Scripts/webkitpy/bugzilla.py: Removed.
Scripts/webkitpy/bugzilla_unittest.py: Removed.
Scripts/webkitpy/buildbot.py: Removed.
Scripts/webkitpy/buildbot_unittest.py: Removed.
Scripts/webkitpy/commitinfo.py:
Scripts/webkitpy/common/net: Added.
Scripts/webkitpy/common/net/init.py: Added.
Scripts/webkitpy/common/net/bugzilla.py: Copied from Scripts/webkitpy/bugzilla.py.
Scripts/webkitpy/common/net/bugzilla_unittest.py: Copied from Scripts/webkitpy/bugzilla_unittest.py.
Scripts/webkitpy/common/net/buildbot.py: Copied from Scripts/webkitpy/buildbot.py.
Scripts/webkitpy/common/net/buildbot_unittest.py: Copied from Scripts/webkitpy/buildbot_unittest.py.
Scripts/webkitpy/common/net/credentials.py: Copied from Scripts/webkitpy/credentials.py.
Scripts/webkitpy/common/net/credentials_unittest.py: Copied from Scripts/webkitpy/credentials_unittest.py.
Scripts/webkitpy/common/net/irc: Copied from Scripts/webkitpy/irc.
Scripts/webkitpy/common/net/irc/ircbot.py:
Scripts/webkitpy/common/net/irc/ircproxy.py:
Scripts/webkitpy/common/net/irc/messagepump_unittest.py:
Scripts/webkitpy/common/net/irc/threadedmessagequeue_unittest.py:
Scripts/webkitpy/common/net/irc/unittests.py:
Scripts/webkitpy/common/net/networktransaction.py: Copied from Scripts/webkitpy/networktransaction.py.
Scripts/webkitpy/common/net/networktransaction_unittest.py: Copied from Scripts/webkitpy/networktransaction_unittest.py.
Scripts/webkitpy/common/net/statusserver.py: Copied from Scripts/webkitpy/statusserver.py.
Scripts/webkitpy/credentials.py: Removed.
Scripts/webkitpy/credentials_unittest.py: Removed.
Scripts/webkitpy/irc: Removed.
Scripts/webkitpy/irc/init.py: Removed.
Scripts/webkitpy/irc/ircbot.py: Removed.
Scripts/webkitpy/irc/ircproxy.py: Removed.
Scripts/webkitpy/irc/messagepump.py: Removed.
Scripts/webkitpy/irc/messagepump_unittest.py: Removed.
Scripts/webkitpy/irc/threadedmessagequeue.py: Removed.
Scripts/webkitpy/irc/threadedmessagequeue_unittest.py: Removed.
Scripts/webkitpy/irc/unittests.py: Removed.
Scripts/webkitpy/networktransaction.py: Removed.
Scripts/webkitpy/networktransaction_unittest.py: Removed.
Scripts/webkitpy/scm_unittest.py:
Scripts/webkitpy/statusserver.py: Removed.
Scripts/webkitpy/tool/bot/queueengine.py:
Scripts/webkitpy/tool/commands/download.py:
Scripts/webkitpy/tool/commands/queries.py:
Scripts/webkitpy/tool/commands/queries_unittest.py:
Scripts/webkitpy/tool/commands/queues.py:
Scripts/webkitpy/tool/commands/queues_unittest.py:
Scripts/webkitpy/tool/commands/queuestest.py:
Scripts/webkitpy/tool/commands/upload.py:
Scripts/webkitpy/tool/main.py:
Scripts/webkitpy/tool/mocktool.py:
Scripts/webkitpy/tool/steps/postdiffforrevert.py:
Scripts/webkitpy/unittests.py:

12:37 AM Changeset in webkit [56507] by jhoneycutt@apple.com

4 edits in trunk

<rdar://problem/7780798> Missing plug-ins should be represented by text
only, instead of lego block

https://bugs.webkit.org/show_bug.cgi?id=36583

Reviewed by Dan Bernstein.

WebCore:

rendering/RenderEmbeddedObject.cpp:

(WebCore::RenderEmbeddedObject::paintReplaced):
Set the font rendering mode and the computed size, so that the text will
draw properly on Windows.

WebKit/win:

WebCoreSupport/WebFrameLoaderClient.cpp:

(WebFrameLoaderClient::createPlugin):
Return 0 if we failed to initialize the plug-in, which causes the new
"missing plug-in" text to draw.

12:34 AM Changeset in webkit [56506] by eric@webkit.org

2 edits
2 adds
4 deletes in trunk/LayoutTests

2010-03-25 Kinuko Yasuda <kinuko@chromium.org>

Reviewed by David Levin.

Rewrite the layout test editing/inserting/6633727 to use dumpAsText
https://bugs.webkit.org/show_bug.cgi?id=31579

editing/inserting/6633727-expected.txt: Added.
editing/inserting/6633727.html:
editing/inserting/script-tests/6633727.js: Added.
platform/gtk/editing/inserting/6633727-expected.txt: Removed.
platform/mac/editing/inserting/6633727-expected.checksum: Removed.
platform/mac/editing/inserting/6633727-expected.png: Removed.
platform/mac/editing/inserting/6633727-expected.txt: Removed.

12:24 AM Changeset in webkit [56505] by Chris Jerdonek

11 edits in trunk/WebKitTools

In webkitpy, renamed MockBugzillaTool to MockTool.

Reviewed by Adam Barth.

Scripts/webkitpy/tool/commands/commandtest.py:
Scripts/webkitpy/tool/commands/queries_unittest.py:
Scripts/webkitpy/tool/commands/queues_unittest.py:
Scripts/webkitpy/tool/commands/queuestest.py:
Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
Scripts/webkitpy/tool/commands/upload_unittest.py:
Scripts/webkitpy/tool/mocktool.py:
Scripts/webkitpy/tool/steps/closebugforlanddiff_unittest.py:
Scripts/webkitpy/tool/steps/steps_unittest.py:
Scripts/webkitpy/tool/steps/updatechangelogswithreview_unittests.py:

12:18 AM Changeset in webkit [56504] by Chris Jerdonek

14 edits
2 copies
4 moves
2 adds in trunk/WebKitTools

In Scripts/webkitpy, moved webkitport.py and committers.py into
common/config/ (also creating common/config/).

Reviewed by Adam Barth.

https://bugs.webkit.org/show_bug.cgi?id=36093

This is part of the master bug to reorganize webkitpy.

Scripts/validate-committer-lists:
Scripts/webkitpy/bugzilla.py:
Scripts/webkitpy/bugzilla_unittest.py:
Scripts/webkitpy/changelogs.py:
Scripts/webkitpy/commitinfo.py:
Scripts/webkitpy/commitinfo_unittest.py:
Scripts/webkitpy/committers.py: Removed.
Scripts/webkitpy/committers_unittest.py: Removed.
Scripts/webkitpy/common: Added.
Scripts/webkitpy/common/init.py: Copied from WebKitTools/Scripts/webkitpy/style/init.py.
Scripts/webkitpy/common/config: Added.
Scripts/webkitpy/common/config/init.py: Copied from WebKitTools/Scripts/webkitpy/style/init.py.
Scripts/webkitpy/common/config/committers.py: Copied from WebKitTools/Scripts/webkitpy/committers.py.
Scripts/webkitpy/common/config/committers_unittest.py: Copied from WebKitTools/Scripts/webkitpy/committers_unittest.py.
Scripts/webkitpy/common/config/ports.py: Copied from WebKitTools/Scripts/webkitpy/webkitport.py.
Scripts/webkitpy/common/config/ports_unittest.py: Copied from WebKitTools/Scripts/webkitpy/webkitport_unittest.py.
Scripts/webkitpy/mock_bugzillatool.py:
Scripts/webkitpy/tool/commands/early_warning_system.py:
Scripts/webkitpy/tool/commands/queries.py:
Scripts/webkitpy/tool/commands/sheriffbot.py:
Scripts/webkitpy/tool/commands/upload.py:
Scripts/webkitpy/tool/steps/abstractstep.py:
Scripts/webkitpy/unittests.py:
Scripts/webkitpy/webkitport.py: Removed.
Scripts/webkitpy/webkitport_unittest.py: Removed.

12:09 AM Changeset in webkit [56503] by abarth@webkit.org

10 edits
1 move in trunk/WebKitTools

2010-03-25 Adam Barth <abarth@webkit.org>

Unreviewed. Move mock_bugzillatool.py to tool/mocktool.py.

Scripts/webkitpy/mock_bugzillatool.py: Removed.
Scripts/webkitpy/tool/commands/commandtest.py:
Scripts/webkitpy/tool/commands/queries_unittest.py:
Scripts/webkitpy/tool/commands/queues_unittest.py:
Scripts/webkitpy/tool/commands/queuestest.py:
Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
Scripts/webkitpy/tool/commands/upload_unittest.py:
Scripts/webkitpy/tool/mocktool.py: Copied from Scripts/webkitpy/mock_bugzillatool.py.
Scripts/webkitpy/tool/steps/closebugforlanddiff_unittest.py:
Scripts/webkitpy/tool/steps/steps_unittest.py:
Scripts/webkitpy/tool/steps/updatechangelogswithreview_unittests.py:

12:07 AM Changeset in webkit [56502] by eric@webkit.org

6 edits in trunk

2010-03-24 Vangelis Kokkevis <vangelis@chromium.org>

Reviewed by Dimitri Glazkov.

Removing unecessary redraws of LayerSkia contents:
https://bugs.webkit.org/show_bug.cgi?id=36470

Test: No new functionality added, no tests.

platform/graphics/skia/LayerRendererSkia.cpp: (WebCore::LayerRendererSkia::drawLayerInCanvasRecursive): Debug borders now rendered at composite time rather than update time.
platform/graphics/skia/LayerSkia.cpp: (WebCore::LayerSkia::updateContents): (WebCore::LayerSkia::drawDebugBorder): Debug border drawing removed from updateContents and split into a separate method that can be called at composite time. (WebCore::LayerSkia::setBounds): Resetting the bounds causes the layer to redraw its contents. (WebCore::LayerSkia::setNeedsDisplay):
platform/graphics/skia/LayerSkia.h: Added declaration for drawDebugBorders method.

2010-03-24 Vangelis Kokkevis <vangelis@chromium.org>

Reviewed by Dimitri Glazkov.

Eliminate unecessary redraws of GraphicsLayer contents when doing accelerated compositing:
https://bugs.webkit.org/show_bug.cgi?id=36470

src/WebViewImpl.cpp: (WebKit::WebViewImpl::paint): Remove call that forced redrawing the contents of the entire layer hierarchy.

Note: See TracTimeline for information about the timeline view.

Download in other formats:

RSS Feed