Context Navigation

← Previous Period
Next Period →

Timeline

Mar 29, 2010:

11:52 PM Changeset in webkit [56767] by alice.liu@apple.com

2 edits in trunk/JavaScriptCore

JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGenerated.make:

add JSObjectRefPrivate.h

Reviewed by NOBODY (build fix).

11:46 PM BuildingQtOnLinux edited by fboudra@gmail.com

Fix typo (diff)

11:44 PM Changeset in webkit [56766] by levin@chromium.org

11 edits
9 adds in trunk/LayoutTests

[chromium] Many new test results are needed due to recent check-ins.
https://bugs.webkit.org/show_bug.cgi?id=36799

Reviewed by Shinichiro Hamaji.

Various rebaselines due to changes in layout or new tests. The revision that caused
each change is by the change.

platform/chromium-mac/tables/mozilla/bugs/bug1296-expected.checksum: Added. Due to r56655.
platform/chromium-mac/tables/mozilla/bugs/bug1296-expected.png: Added. Ditto.
platform/chromium-mac/tables/mozilla/bugs/bug1296-expected.txt: Copied from LayoutTests/platform/mac/tables/mozilla/bugs/bug1296-expected.txt.
platform/chromium-mac/tables/mozilla/bugs/bug1430-expected.checksum: Added. Ditto.
platform/chromium-mac/tables/mozilla/bugs/bug1430-expected.png: Added. Ditto.
platform/chromium-mac/tables/mozilla/bugs/bug1430-expected.txt: Copied from LayoutTests/platform/mac/tables/mozilla/bugs/bug1430-expected.txt.
platform/chromium-win/fast/media/media-feature-wgt-view-mode-expected.checksum: Added. Due to r56740.
platform/chromium-win/fast/media/media-feature-wgt-view-mode-expected.png: Added. Ditto.
platform/chromium-win/fast/media/media-feature-wgt-view-mode-expected.txt: Added. Ditto.
platform/chromium-win/svg/custom/marker-overflow-clip-expected.txt: Due to r56693.
platform/chromium-win/tables/mozilla/marvin/backgr_simple-table-column-expected.checksum: Due to r56655.
platform/chromium-win/tables/mozilla/marvin/backgr_simple-table-column-expected.png: Ditto.
platform/chromium-win/tables/mozilla/marvin/backgr_simple-table-row-expected.checksum: Ditto.
platform/chromium-win/tables/mozilla/marvin/backgr_simple-table-row-expected.png: Ditto.
platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_position-table-column-group-expected.checksum: Ditto.
platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_position-table-column-group-expected.png: Ditto.
platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_position-table-row-expected.checksum: Ditto.
platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_position-table-row-expected.png: Ditto.
platform/chromium/test_expectations.txt: Added a few failures with follow up bugs.

11:42 PM BuildingQtOnLinux edited by fboudra@gmail.com

Add missing build dependencies (diff)

11:16 PM Changeset in webkit [56765] by eric@webkit.org

2 edits in trunk/WebKitTools

2010-03-29 Eric Seidel <eric@webkit.org>

Unreviewed, build fix only.

Scripts/webkitpy/tool/steps/validatereviewer.py: Add missing import.

11:15 PM Changeset in webkit [56764] by hamaji@chromium.org

7 edits
4 adds in trunk

2010-03-29 Shinichiro Hamaji <hamaji@chromium.org>

Reviewed by David Hyatt.

No vertical scrollbar after the CSS class change
https://bugs.webkit.org/show_bug.cgi?id=36461

fast/repaint/overflow-scroll-body-appear.html: Added.
platform/chromium/test_expectations.txt:
platform/gtk/Skipped:
platform/mac/fast/repaint/overflow-scroll-body-appear-expected.checksum: Added.
platform/mac/fast/repaint/overflow-scroll-body-appear-expected.png: Added.
platform/mac/fast/repaint/overflow-scroll-body-appear-expected.txt: Added.
platform/qt/Skipped:
platform/win/Skipped:

2010-03-29 Shinichiro Hamaji <hamaji@chromium.org>

Reviewed by David Hyatt.

No vertical scrollbar after the CSS class change
https://bugs.webkit.org/show_bug.cgi?id=36461

Don't suppress scrollbar change for non-first layouts.
In the first layout, the scrollbar change will happen in later
adjustViewSize() call, but in other layouts, adjustViewSize() may
not be called when the size of contents doesn't change.

page/FrameView.cpp: (WebCore::FrameView::layout):

11:08 PM Changeset in webkit [56763] by eric@webkit.org

3 edits in trunk/WebKitTools

2010-03-29 Hayato Ito <hayato@chromium.org>

Reviewed by Shinichiro Hamaji.

Remove '_flymake' suffix from base part of file name so that
check-webkit-style uses a correct header guard name when it is called from Emacs's flymake.

https://bugs.webkit.org/show_bug.cgi?id=36573

Scripts/webkitpy/style/processors/cpp.py:
Scripts/webkitpy/style/processors/cpp_unittest.py:

10:41 PM Changeset in webkit [56762] by eric@webkit.org

2 edits in trunk/WebKitTools

2010-03-29 Chris Jerdonek <Chris Jerdonek>

Reviewed by Eric Seidel.

Get the following test-webkitpy unit test working again:
scm_unittest.SVNTest.test_svn_apply().

https://bugs.webkit.org/show_bug.cgi?id=36696

Scripts/webkitpy/common/checkout/scm_unittest.py:
- Add leading spaces to the empty lines of the ChangeLog strings.
- Manually set the _reviewer attribute on the Attachment object to get the tests to pass.

10:09 PM Changeset in webkit [56761] by sfalken@apple.com

2 edits in trunk/WebKit/win

2010-03-29 Steve Falkenburg <sfalken@apple.com>

Reviewed by Adele Peterson.

Default value of accelerated compositing should be false for Windows
https://bugs.webkit.org/show_bug.cgi?id=36805

WebPreferences.cpp: (WebPreferences::initializeDefaultSettings):

9:04 PM Changeset in webkit [56760] by Martin Robinson

2 edits in trunk/WebKitTools

2010-03-29 Martin Robinson <Martin Robinson>

Reviewed by Holger Freyther.

[GTK] suppress (un)desired launcher output that can make layout test to fail with stderr
https://bugs.webkit.org/show_bug.cgi?id=36390

Suppress debugging messages sent to the GLib logger during DRT runs.

DumpRenderTree/gtk/DumpRenderTree.cpp: (logHandler): Added. (main): Use logHandler as the default GLib log message handler.

7:59 PM Changeset in webkit [56759] by eric@webkit.org

9 edits in trunk/JavaScriptCore

2010-03-29 Chao-ying Fu <fu@mips.com>

Reviewed by Oliver Hunt.

MIPS JIT Supports
https://bugs.webkit.org/show_bug.cgi?id=30144

The following changes enable MIPS JIT.

assembler/MIPSAssembler.h: (JSC::MIPSAssembler::lbu): (JSC::MIPSAssembler::linkWithOffset):
assembler/MacroAssemblerMIPS.h: (JSC::MacroAssemblerMIPS::load8): (JSC::MacroAssemblerMIPS::branch8): (JSC::MacroAssemblerMIPS::branchTest8): (JSC::MacroAssemblerMIPS::setTest8): (JSC::MacroAssemblerMIPS::setTest32):
jit/JIT.h:
jit/JITInlineMethods.h: (JSC::JIT::preserveReturnAddressAfterCall): (JSC::JIT::restoreReturnAddressBeforeReturn):
jit/JITOpcodes.cpp:
jit/JITStubs.cpp: (JSC::JITThunks::JITThunks):
jit/JITStubs.h: (JSC::JITStackFrame::returnAddressSlot):
wtf/Platform.h:

7:44 PM Changeset in webkit [56758] by levin@chromium.org

49 edits in trunk/LayoutTests

[chromium] Many new test results are needed due to recent check-ins.
https://bugs.webkit.org/show_bug.cgi?id=36799

Reviewed by Dimitri Glazkov.

r56655 changed how tables layout which causes a lot of pixels tests for
tables to need rebaselines.

r56693 did some svg changes.

platform/chromium-linux/tables/mozilla/bugs/bug1296-expected.checksum: Due to r56655.
platform/chromium-linux/tables/mozilla/bugs/bug1296-expected.png: Ditto.
platform/chromium-linux/tables/mozilla/bugs/bug1430-expected.checksum: Ditto.
platform/chromium-linux/tables/mozilla/bugs/bug1430-expected.png: Ditto.
platform/chromium-linux/tables/mozilla/marvin/backgr_simple-table-column-group-expected.checksum: Ditto.
platform/chromium-linux/tables/mozilla/marvin/backgr_simple-table-column-group-expected.png: Ditto.
platform/chromium-linux/tables/mozilla/marvin/backgr_simple-table-row-group-expected.checksum: Ditto.
platform/chromium-linux/tables/mozilla/marvin/backgr_simple-table-row-group-expected.png: Ditto.
platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_border-table-column-expected.checksum: Ditto.
platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_border-table-column-expected.png: Ditto.
platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_border-table-column-group-expected.checksum: Ditto.
platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_border-table-column-group-expected.png: Ditto.
platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_border-table-row-expected.checksum: Ditto.
platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_border-table-row-expected.png: Ditto.
platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_fixed-bg-expected.checksum: Ditto.
platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_fixed-bg-expected.png: Ditto.
platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_layers-hide-expected.checksum: Ditto.
platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_layers-hide-expected.png: Ditto.
platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_position-table-column-expected.checksum: Ditto.
platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_position-table-column-expected.png: Ditto.
platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_position-table-row-group-expected.checksum: Ditto.
platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_position-table-row-group-expected.png: Ditto.
platform/chromium-win/svg/custom/invalid-css-expected.txt: Due to r56693.
platform/chromium-win/svg/custom/marker-default-width-height-expected.txt: Ditto.
platform/chromium-win/svg/custom/shapes-supporting-markers-expected.txt: Ditto.
platform/chromium-win/tables/mozilla/bugs/bug1296-expected.checksum: Due to r56655.
platform/chromium-win/tables/mozilla/bugs/bug1296-expected.png: Ditto.
platform/chromium-win/tables/mozilla/bugs/bug1430-expected.checksum: Ditto.
platform/chromium-win/tables/mozilla/bugs/bug1430-expected.png: Ditto.
platform/chromium-win/tables/mozilla/marvin/backgr_simple-table-column-group-expected.checksum: Ditto.
platform/chromium-win/tables/mozilla/marvin/backgr_simple-table-column-group-expected.png: Ditto.
platform/chromium-win/tables/mozilla/marvin/backgr_simple-table-row-group-expected.checksum: Ditto.
platform/chromium-win/tables/mozilla/marvin/backgr_simple-table-row-group-expected.png: Ditto.
platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_border-table-column-expected.checksum: Ditto.
platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_border-table-column-expected.png: Ditto.
platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_border-table-column-group-expected.checksum: Ditto.
platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_border-table-column-group-expected.png: Ditto.
platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_border-table-row-expected.checksum: Ditto.
platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_border-table-row-expected.png: Ditto.
platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_fixed-bg-expected.checksum: Ditto.
platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_fixed-bg-expected.png: Ditto.
platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_layers-hide-expected.checksum: Ditto.
platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_layers-hide-expected.png: Ditto.
platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_position-table-column-expected.checksum: Ditto.
platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_position-table-column-expected.png: Ditto.
platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_position-table-row-group-expected.checksum: Ditto.
platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_position-table-row-group-expected.png: Ditto.
platform/chromium/test_expectations.txt: Two newly added tests are timing out (covered by http://crbug.com/35387).

7:32 PM Changeset in webkit [56757] by eric@webkit.org

6 edits in trunk

2010-03-29 Chris Evans <cevans@chromium.org>

Reviewed by Adam Barth.

fast/xmlhttprequest/xmlhttprequest-no-file-access.html: Check that an isolated file:// origin can access about:blank iframes that it created itself.

2010-03-29 Chris Evans <cevans@chromium.org>

Reviewed by Adam Barth.

Don't use unique domains for file:// separation: it breaks local
databases, and access to your own same-origin iframes. Instead, use
path-based access checks.

https://bugs.webkit.org/show_bug.cgi?id=36692

Test: fast/xmlhttprequest/xmlhttprequest-no-file-access.html

dom/Document.cpp: (WebCore::Document::initSecurityContext): renamed API.
page/SecurityOrigin.h:
page/SecurityOrigin.cpp: (WebCore::SecurityOrigin::SecurityOrigin): Initialize new flag. Take note of file:// path. Copy new fields in copy constructor. (WebCore::SecurityOrigin::canAccess): Take into account path-based origin separation for file:// (WebCore::SecurityOrigin::enforceFilePathSeparation): New method to enable file:// path origin separation. (WebCore::SecurityOrigin::toString): Return a null domain for an isolated file origin. (WebCore::SecurityOrigin::isSameSchemeHostPort): Take into account path-based origin separation for file:// (WebCore::SecurityOrigin::passesFileCheck): Abstraction of common logic for file:// access checks.

6:38 PM Changeset in webkit [56756] by eric@webkit.org

11 edits in trunk

2010-03-29 Rafael Weinstein <rafaelw@chromium.org>

Reviewed by Adam Barth.

Change NotificationPresenter::checkPermission() to take the source frames full KURL,
rather than its SecurityOrigin. This will aid chromium in having more fine grained
permissions to control notification spam.

notifications/Notification.cpp: (WebCore::Notification::Notification):
notifications/NotificationCenter.cpp: (WebCore::NotificationCenter::checkPermission):
notifications/NotificationPresenter.h:

2010-03-29 Rafael Weinstein <rafaelw@chromium.org>

Reviewed by Adam Barth.

Change NotificationPresenter::checkPermission() to take the source frames full KURL,
rather than its SecurityOrigin. This will aid chromium in having more fine grained
permissions to control notification spam.

public/WebNotificationPresenter.h: (WebKit::WebNotificationPresenter::checkPermission):
src/NotificationPresenterImpl.cpp: (WebKit::NotificationPresenterImpl::checkPermission):
src/NotificationPresenterImpl.h:

2010-03-29 Rafael Weinstein <rafaelw@chromium.org>

Reviewed by Adam Barth.

Change NotificationPresenter::checkPermission() to take the source frames full KURL,
rather than its SecurityOrigin. This will aid chromium in having more fine grained
permissions to control notification spam.

WebCoreSupport/WebDesktopNotificationsDelegate.cpp: (WebDesktopNotificationsDelegate::checkPermission):
WebCoreSupport/WebDesktopNotificationsDelegate.h:

6:15 PM Changeset in webkit [56755] by eric@webkit.org

3 edits in trunk/WebKitTools

2010-03-29 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

sheriff-bot should comment on bugs when builders break
https://bugs.webkit.org/show_bug.cgi?id=36786

Scripts/webkitpy/tool/commands/sheriffbot.py:
- Add a new _post_blame_comment_to_bug and all it from process_work_item
- Move commit-queue logic into _post_rollout_patch to make its api match the other _post commands.
Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
- Test the new _post_blame_comment_to_bug call

6:07 PM Changeset in webkit [56754] by eric@webkit.org

2 edits in trunk/WebKitTools

2010-03-29 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

sheriff-bot fails to get information about certain builds
https://bugs.webkit.org/show_bug.cgi?id=36768

This seems to be caused by:
http://buildbot.net/trac/ticket/753
I have no work-around, but for now at least we're logging
the error better. I also added allow_none to our ServerProxy
creation in case that fixes things for other versions of python.

Scripts/webkitpy/common/net/buildbot.py:

5:34 PM Changeset in webkit [56753] by eric@webkit.org

4 edits in trunk/WebKitTools

2010-03-29 Victor Wang <victorw@chromium.org>

Reviewed by Adam Barth.

Add sign in/out link to TestResults appengine

Add a link to main menu for sign in/out to this appengine.
People signed in with admin privilege could perform
actions that are only allowed to admins like deleting files.

https://bugs.webkit.org/show_bug.cgi?id=36767

TestResultServer/handlers/menu.py:
TestResultServer/stylesheets/menu.css: (.sign):
TestResultServer/templates/menu.html:

5:16 PM Changeset in webkit [56752] by eric@webkit.org

2 edits in trunk/WebCore

2010-03-29 Luiz Agostini <luiz.agostini@openbossa.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Multiselect - Adding method itemIsSelected() to QtAbstractWebPopup
https://bugs.webkit.org/show_bug.cgi?id=36769

Adding method itemIsSelected() to QtAbstractWebPopup.

platform/qt/QtAbstractWebPopup.h: (WebCore::QtAbstractWebPopup::itemIsSelected):

4:58 PM Changeset in webkit [56751] by levin@chromium.org

8 edits
6 moves
53 adds in trunk/LayoutTests

Rubber-stamped by Dmitry Titov.

[Chromium] pixel layout test fixes.

r56655 caused runin test which needed separate results for each platform.
r56673 caused computed-style-expected.
r56655 cause the fast/table changes (and we need linux specific results).
r56644 caused clip-path-referencing-use2-expected.
r56693 caused painting-marker-01-f-expected.

platform/chromium-linux/fast/runin/generated2-expected.checksum: Added.
platform/chromium-linux/fast/runin/generated2-expected.png: Added.
platform/chromium-linux/fast/runin/generated2-expected.txt: Added.
platform/chromium-linux/fast/runin/generated3-expected.checksum: Added.
platform/chromium-linux/fast/runin/generated3-expected.png: Added.
platform/chromium-linux/fast/runin/generated3-expected.txt: Added.
platform/chromium-linux/fast/runin/generated4-expected.checksum: Added.
platform/chromium-linux/fast/runin/generated4-expected.png: Added.
platform/chromium-linux/fast/runin/generated4-expected.txt: Added.
platform/chromium-linux/fast/table/table-background-expected.checksum: Added.
platform/chromium-linux/fast/table/table-background-expected.png: Added.
platform/chromium-linux/fast/table/table-cell-border-draws-on-top-of-col-background-expected.checksum: Added.
platform/chromium-linux/fast/table/table-cell-border-draws-on-top-of-col-background-expected.png: Added.
platform/chromium-linux/fast/table/table-cell-border-draws-on-top-of-col-group-background-expected.checksum: Added.
platform/chromium-linux/fast/table/table-cell-border-draws-on-top-of-col-group-background-expected.png: Added.
platform/chromium-linux/fast/table/table-cell-border-draws-on-top-of-row-background-expected.checksum: Added.
platform/chromium-linux/fast/table/table-cell-border-draws-on-top-of-row-background-expected.png: Added.
platform/chromium-linux/fast/table/table-cell-border-draws-on-top-of-row-group-background-expected.checksum: Added.
platform/chromium-linux/fast/table/table-cell-border-draws-on-top-of-row-group-background-expected.png: Added.
platform/chromium-linux/fast/table/table-cell-overrides-row-background-expected.checksum: Added.
platform/chromium-linux/fast/table/table-cell-overrides-row-background-expected.png: Added.
platform/chromium-linux/fast/table/table-col-background-expected.checksum: Added.
platform/chromium-linux/fast/table/table-col-background-expected.png: Added.
platform/chromium-linux/fast/table/table-col-group-background-expected.checksum: Added.
platform/chromium-linux/fast/table/table-col-group-background-expected.png: Added.
platform/chromium-linux/fast/table/table-col-group-col-span-background-expected.checksum: Added.
platform/chromium-linux/fast/table/table-col-group-col-span-background-expected.png: Added.
platform/chromium-linux/fast/table/table-col-group-span-background-expected.checksum: Added.
platform/chromium-linux/fast/table/table-col-group-span-background-expected.png: Added.
platform/chromium-linux/fast/table/table-col-span-background-expected.checksum: Added.
platform/chromium-linux/fast/table/table-col-span-background-expected.png: Added.
platform/chromium-linux/fast/table/table-row-background-expected.checksum: Added.
platform/chromium-linux/fast/table/table-row-background-expected.png: Added.
platform/chromium-linux/fast/table/table-row-background-left-50px-expected.checksum: Added.
platform/chromium-linux/fast/table/table-row-background-left-50px-expected.png: Added.
platform/chromium-linux/fast/table/table-row-background-right-100percent-expected.checksum: Added.
platform/chromium-linux/fast/table/table-row-background-right-100percent-expected.png: Added.
platform/chromium-linux/fast/table/table-row-background-right-50px-expected.checksum: Added.
platform/chromium-linux/fast/table/table-row-background-right-50px-expected.png: Added.
platform/chromium-linux/fast/table/table-row-group-background-expected.checksum: Added.
platform/chromium-linux/fast/table/table-row-group-background-expected.png: Added.
platform/chromium-linux/fast/table/table-row-group-background-positioned-expected.checksum: Added.
platform/chromium-linux/fast/table/table-row-group-background-positioned-expected.png: Added.
platform/chromium-mac/fast/css/getComputedStyle/computed-style-expected.txt:
platform/chromium-mac/fast/runin/generated2-expected.checksum: Renamed from LayoutTests/platform/chromium/fast/runin/generated2-expected.checksum.
platform/chromium-mac/fast/runin/generated2-expected.png: Renamed from LayoutTests/platform/chromium/fast/runin/generated2-expected.png.
platform/chromium-mac/fast/runin/generated3-expected.checksum: Renamed from LayoutTests/platform/chromium/fast/runin/generated3-expected.checksum.
platform/chromium-mac/fast/runin/generated3-expected.png: Renamed from LayoutTests/platform/chromium/fast/runin/generated3-expected.png.
platform/chromium-mac/fast/runin/generated4-expected.checksum: Renamed from LayoutTests/platform/chromium/fast/runin/generated4-expected.checksum.
platform/chromium-mac/fast/runin/generated4-expected.png: Renamed from LayoutTests/platform/chromium/fast/runin/generated4-expected.png.
platform/chromium-mac/svg/custom/clip-path-referencing-use2-expected.txt:
platform/chromium-win/fast/css/getComputedStyle/computed-style-expected.txt:
platform/chromium-win/fast/runin/generated2-expected.checksum: Added.
platform/chromium-win/fast/runin/generated2-expected.png: Added.
platform/chromium-win/fast/runin/generated2-expected.txt: Added.
platform/chromium-win/fast/runin/generated3-expected.checksum: Added.
platform/chromium-win/fast/runin/generated3-expected.png: Added.
platform/chromium-win/fast/runin/generated3-expected.txt: Added.
platform/chromium-win/fast/runin/generated4-expected.checksum: Added.
platform/chromium-win/fast/runin/generated4-expected.png: Added.
platform/chromium-win/fast/runin/generated4-expected.txt: Added.
platform/chromium-win/svg/W3C-SVG-1.1/painting-marker-01-f-expected.txt:
platform/chromium-win/svg/W3C-SVG-1.1/painting-marker-02-f-expected.txt:
platform/chromium-win/svg/W3C-SVG-1.1/painting-marker-03-f-expected.txt:
platform/chromium-win/svg/custom/clip-path-referencing-use2-expected.txt:

4:58 PM Changeset in webkit [56750] by eric@webkit.org

8 edits in trunk

2010-03-29 Dawit Alemayehu <adawit@kde.org>

Reviewed by Simon Hausmann.

Added a function, WebCore::shouldTreatAsAttachment, to HTTPParsers.*

https://bugs.webkit.org/show_bug.cgi?id=36395

This function, which was moved from WebKit/chromium/src/FrameClientImpl.cpp,
is used to check whether or not a request is supposed to be rendered or
simply downloaded based on the "Content-Disposition" header sent by the
web server. The intent of code refactoring is to avoid code duplication
so that this piece of code can be used by other implementations such as
QtWebKit.

platform/network/HTTPParsers.cpp: (WebCore::shouldTreatAsAttachment):
platform/network/HTTPParsers.h:

2010-03-29 Dawit Alemayehu <adawit@kde.org>

Reviewed by Simon Hausmann.

Factored out the 'ShouldTreatAsAttachment' function to HTTPParsers.*
and replacted local version with the factored out version.

The code was factored out to make possible its use in other implementations
such as QtWebKit.

src/FrameLoaderClientImpl.cpp: (WebKit::FrameLoaderClientImpl::dispatchDecidePolicyForMIMEType):

2010-03-29 Dawit Alemayehu <adawit@kde.org>

Reviewed by Simon Hausmann.

[Qt] Added support for handling the HTTP "Content-Disposition" header.

https://bugs.webkit.org/show_bug.cgi?id=36395

Whenever a server response contains a "Content-Disposition: attachment..." header,
treat the request as a download and emit the unsupportedContent signal.

Api/qwebpage.cpp:
WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::download): (WebCore::FrameLoaderClientQt::dispatchDecidePolicyForMIMEType):

4:38 PM Changeset in webkit [56749] by eric@webkit.org

3 edits
2 adds in trunk

2010-03-29 Chris Fleizach <Chris Fleizach>

Reviewed by Beth Dakin.

Bug 36735 - Live regions don't send out notifications when the element changing is the live region
https://bugs.webkit.org/show_bug.cgi?id=36735

platform/mac/accessibility/aria-liveregion-on-image-expected.txt: Added.
platform/mac/accessibility/aria-liveregion-on-image.html: Added.

2010-03-29 Chris Fleizach <Chris Fleizach>

Reviewed by Beth Dakin.

Bug 36735 - Live regions don't send out notifications when the element changing is the live region
https://bugs.webkit.org/show_bug.cgi?id=36735

Test: platform/mac/accessibility/aria-liveregion-on-image.html

accessibility/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::contentChanged):

4:33 PM Changeset in webkit [56748] by eric@webkit.org

2 edits
1 add in trunk/WebKitTools

2010-03-29 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

ValidateReviewer step is draconian and un-tested
https://bugs.webkit.org/show_bug.cgi?id=36792

ValidateReviewer logic was commented out in
http://trac.webkit.org/changeset/56744
That was a symptom of the fact that validatereviewer.py
is too inflexible to be used when real humans are driving webkit-patch.
For now we just disable ValidateReviewer when humans are at the keyboard.

Scripts/webkitpy/tool/steps/validatereviewer.py:
- Only run when in non-interactive mode.
Scripts/webkitpy/tool/steps/validatereviewer_unittest.py: Added.
- Test our validation logic to make sure it's sane.

4:18 PM Changeset in webkit [56747] by eric@webkit.org

2 edits in trunk/WebKitTools

2010-03-29 Chris Jerdonek <Chris Jerdonek>

Reviewed by Shinichiro Hamaji.

Eliminate explicit slash characters from check-webkit-style's
_rel_path() method to make its implementation more platform
independent.

https://bugs.webkit.org/show_bug.cgi?id=36759

Scripts/webkitpy/style/main.py:
- Changed to use os.sep instead of slash_chars "/
  ". This can be done since os.path.abspath() converts slashes to os.sep.

3:35 PM Changeset in webkit [56746] by dpranke@chromium.org

2 edits in trunk/WebKitTools

2010-03-29 Dirk Pranke <dpranke@chromium.org>

Reviewed by Dimitri Glazkov.

Change new-run-webkit-tests to not use more than four threads by
default on the mac port until
https://bugs.webkit.org/show_bug.cgi?id=36622 is fixed.

https://bugs.webkit.org/show_bug.cgi?id=36687

Scripts/webkitpy/layout_tests/port/mac.py:

3:34 PM Changeset in webkit [56745] by dpranke@chromium.org

2 edits in trunk/WebKitTools

2010-03-29 Dirk Pranke <dpranke@chromium.org>

Reviewed by Dimitri Glazkov.

Reformat port/mac.py to fit witin 80 columns for PEP-8 compliance.

https://bugs.webkit.org/show_bug.cgi?id=36691

Scripts/webkitpy/layout_tests/port/mac.py:

3:28 PM Changeset in webkit [56744] by senorblanco@chromium.org

5 edits
2 adds in trunk

2010-03-29 Stephen White <senorblanco@chromium.org>

Reviewed by Dave Hyatt.

In order to speed up multiple calls to CSSPrimitiveValue::cssText(),
this CL caches the String result. When m_value is changed, the
cached string is cleared. This gives a good speedup on benchmarks
which do a lot of CSS property gets, such as Peacekeeper.
The processing cost should be negligible, since the strings are
refcounted. The memory cost is an additional 4 bytes per
CSSPrimitiveValue, and the extended lifetime of the computed string
(potentially, the same as the lifetime of the CSSPrimitiveValue).

https://bugs.webkit.org/show_bug.cgi?id=36556

Covered by fast/css/cssText-cache.html, and more.

css/CSSPrimitiveValue.cpp: (WebCore::CSSPrimitiveValue::CSSPrimitiveValue): (WebCore::CSSPrimitiveValue::cleanup): (WebCore::CSSPrimitiveValue::cssText):
css/CSSPrimitiveValue.h:

2010-03-29 Stephen White <senorblanco@chromium.org>

Reviewed by Dave Hyatt.

Added a test for CSSPrimitiveValue::cssText() string cacheing.

https://bugs.webkit.org/show_bug.cgi?id=36556

fast/css/cssText-cache-expected.txt: Added.
fast/css/cssText-cache.html: Added.

3:26 PM April 2010 Meeting edited by Laszlo Gombos

(diff)

3:20 PM Changeset in webkit [56743] by eric@webkit.org

2 edits in trunk/WebKitTools

2010-03-29 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

new-run-webkit-tests fails java/lc3 on a clean checkout
https://bugs.webkit.org/show_bug.cgi?id=36078

Scripts/webkitpy/layout_tests/port/mac.py:
- Build the java support files in check_build
- Unwrap a line which would still fit under 80col

3:19 PM Changeset in webkit [56742] by bweinstein@apple.com

1 edit in trunk/WebKit/win/Interfaces/WebKit.idl

Build Fix: Touch WebKit.idl to force Interfaces to rebuild

3:15 PM Changeset in webkit [56741] by sfalken@apple.com

1 edit in trunk/WebKit/win/Interfaces/WebKit.idl

Build fix. Touch WebKit.idl to force rebuild.

2:44 PM Changeset in webkit [56740] by kenneth@webkit.org

19 edits
2 adds in trunk

JavaScriptCore: Add an enable flag for the Widgets (http://www.w3.org/TR/widgets-reqs/)
and turn it on for Qt only.

Reviewed by Simon Fraser.

wtf/Platform.h:

WebCore: When enabling Web Widgets, add support for the view-mode media
feature (http://www.w3.org/TR/widgets-vmmf/).

Reviewed by Simon Fraser.

Test: fast/media/media-feature-wgt-view-mode.html

css/CSSValueKeywords.in:
css/MediaFeatureNames.h:
css/MediaQueryEvaluator.cpp:

(WebCore::view_modeMediaFeatureEval):

page/ChromeClient.h:

(WebCore::ChromeClient::isDocked):
(WebCore::ChromeClient::isFloating):
(WebCore::ChromeClient::isApplication):
(WebCore::ChromeClient::isFullscreen):

WebKit/qt: Add an internal Qt API for changing the view mode media feature
(http://www.w3.org/TR/widgets-vmmf/).

Reviewed by Simon Fraser.

Api/qwebpage.cpp:

(qt_wrt_setViewMode):
(QWebPagePrivate::priv):

Api/qwebpage_p.h:
WebCoreSupport/ChromeClientQt.cpp:

(WebCore::ChromeClientQt::isDocked):
(WebCore::ChromeClientQt::isFloating):
(WebCore::ChromeClientQt::isApplication):
(WebCore::ChromeClientQt::isFullscreen):

WebCoreSupport/ChromeClientQt.h:

WebKitTools: Add hooks to the Qt DRT for testing the view mode media feature.

Reviewed by Simon Fraser.

DumpRenderTree/qt/LayoutTestControllerQt.cpp:

(LayoutTestController::setViewModeMediaFeature):

DumpRenderTree/qt/LayoutTestControllerQt.h:

LayoutTests: Add a test and an expected result for the Widgets 1.0: View Mode
Media Feature (http://www.w3.org/TR/widgets-vmmf/).

Reviewed by Simon Fraser.

Skip on all other platforms than Qt, that has Skipped files.

fast/media/media-feature-wgt-view-mode.html: Added.
fast/media/media-feature-wgt-view-mode-expected.txt: Added.
platform/gtk/Skipped:
platform/mac/Skipped:
platform/win/Skipped:

1:51 PM Changeset in webkit [56739] by abarth@webkit.org

3 edits in trunk/WebKitTools

2010-03-29 Adam Barth <abarth@webkit.org>

Unreviewed. Update expected results for unit tests.

Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:

1:49 PM Changeset in webkit [56738] by abarth@webkit.org

2 edits in trunk/WebKitTools

2010-03-29 Adam Barth <abarth@webkit.org>

Unreviewed. I think Eric meant svn_revision.

Scripts/webkitpy/tool/commands/sheriffbot.py:

1:40 PM Changeset in webkit [56737] by eric@webkit.org

7 edits in trunk/WebKitTools

2010-03-26 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

webkit-patch commit-queue should notice if it breaks builders (and roll out its own changes)
https://bugs.webkit.org/show_bug.cgi?id=29311

Now that we have sheriff-bot watching the tree, it can post
rollout patches on behalf of the commit queue.

Scripts/webkitpy/common/checkout/commitinfo.py: add responsible_parties()
Scripts/webkitpy/common/checkout/commitinfo_unittest.py: test responsible_parties()
Scripts/webkitpy/tool/commands/sheriffbot.py:
- Break IRC logic out into _post_irc_warning for easier testing.
- Add _post_rollout_patch for posting rollout patches to bugzilla.
Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
- Test _rollout_reason
Scripts/webkitpy/tool/grammar.py:
- Fix join_with_separators to not add Adam's "oxford comma" for two item lists.
Scripts/webkitpy/tool/grammar_unittest.py:
- Test join_with_separators

1:31 PM Changeset in webkit [56736] by abarth@webkit.org

4 edits in trunk/WebKitTools

2010-03-29 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Sheriffbot should actually run commands
https://bugs.webkit.org/show_bug.cgi?id=36776

Some minor changes to Sheriffbot:

1) We should actually run commands (by giving control back to the
command processing object.

2) Use URLs instead of just numbers to represent SVN revisions (making
it easier to folks in IRC ot followup).

Scripts/webkitpy/tool/bot/irc_command.py:
Scripts/webkitpy/tool/bot/queueengine.py:
Scripts/webkitpy/tool/commands/sheriffbot.py:

12:51 PM QtWebKitRelease20 edited by fboudra@gmail.com

(diff)

12:50 PM QtWebKitRelease20 edited by fboudra@gmail.com

nicer (diff)

12:48 PM QtWebKitRelease20 edited by fboudra@gmail.com

Link to the top of the page (diff)

12:45 PM BuildingQtOnLinux edited by fboudra@gmail.com

Update build dependencies for Debian and Ubuntu (diff)

11:54 AM April 2010 Meeting edited by geoffrey.levand@am.sony.com

Add Geoff Levand. (diff)

11:28 AM Changeset in webkit [56735] by kbr@google.com

2 edits in trunk/WebCore

2010-03-29 Kenneth Russell <kbr@google.com>

Reviewed by Darin Fisher.

Eliminate use of GL_BGRA in GraphicsContext3DSkia.cpp
https://bugs.webkit.org/show_bug.cgi?id=36737

No new tests; ran WebGL demos in Chromium on Windows to verify fix.

platform/graphics/skia/GraphicsContext3DSkia.cpp: (WebCore::GraphicsContext3D::getImageData):

11:20 AM Changeset in webkit [56734] by levin@chromium.org

1 edit
109 adds in trunk/LayoutTests

Rubber-stamped by Dmitry Titov.

Add chromium specific baselines for table tests added in r56641
and for runin tests added in r56655.

platform/chromium-mac/fast/table/table-background-expected.checksum: Added.
platform/chromium-mac/fast/table/table-background-expected.png: Added.
platform/chromium-mac/fast/table/table-background-expected.txt: Copied from LayoutTests/platform/mac/fast/table/table-background-expected.txt.
platform/chromium-mac/fast/table/table-cell-border-draws-on-top-of-col-background-expected.checksum: Added.
platform/chromium-mac/fast/table/table-cell-border-draws-on-top-of-col-background-expected.png: Added.
platform/chromium-mac/fast/table/table-cell-border-draws-on-top-of-col-background-expected.txt: Copied from LayoutTests/platform/mac/fast/table/table-cell-border-draws-on-top-of-col-background-expected.txt.
platform/chromium-mac/fast/table/table-cell-border-draws-on-top-of-col-group-background-expected.checksum: Added.
platform/chromium-mac/fast/table/table-cell-border-draws-on-top-of-col-group-background-expected.png: Added.
platform/chromium-mac/fast/table/table-cell-border-draws-on-top-of-col-group-background-expected.txt: Copied from LayoutTests/platform/mac/fast/table/table-cell-border-draws-on-top-of-col-group-background-expected.txt.
platform/chromium-mac/fast/table/table-cell-border-draws-on-top-of-row-background-expected.checksum: Added.
platform/chromium-mac/fast/table/table-cell-border-draws-on-top-of-row-background-expected.png: Added.
platform/chromium-mac/fast/table/table-cell-border-draws-on-top-of-row-background-expected.txt: Copied from LayoutTests/platform/mac/fast/table/table-cell-border-draws-on-top-of-row-background-expected.txt.
platform/chromium-mac/fast/table/table-cell-border-draws-on-top-of-row-group-background-expected.checksum: Added.
platform/chromium-mac/fast/table/table-cell-border-draws-on-top-of-row-group-background-expected.png: Added.
platform/chromium-mac/fast/table/table-cell-border-draws-on-top-of-row-group-background-expected.txt: Copied from LayoutTests/platform/mac/fast/table/table-cell-border-draws-on-top-of-row-group-background-expected.txt.
platform/chromium-mac/fast/table/table-cell-overrides-row-background-expected.checksum: Added.
platform/chromium-mac/fast/table/table-cell-overrides-row-background-expected.png: Added.
platform/chromium-mac/fast/table/table-cell-overrides-row-background-expected.txt: Copied from LayoutTests/platform/mac/fast/table/table-cell-overrides-row-background-expected.txt.
platform/chromium-mac/fast/table/table-col-background-expected.checksum: Added.
platform/chromium-mac/fast/table/table-col-background-expected.png: Added.
platform/chromium-mac/fast/table/table-col-background-expected.txt: Copied from LayoutTests/platform/mac/fast/table/table-col-background-expected.txt.
platform/chromium-mac/fast/table/table-col-group-background-expected.checksum: Added.
platform/chromium-mac/fast/table/table-col-group-background-expected.png: Added.
platform/chromium-mac/fast/table/table-col-group-background-expected.txt: Copied from LayoutTests/platform/mac/fast/table/table-col-group-background-expected.txt.
platform/chromium-mac/fast/table/table-col-group-col-span-background-expected.checksum: Added.
platform/chromium-mac/fast/table/table-col-group-col-span-background-expected.png: Added.
platform/chromium-mac/fast/table/table-col-group-col-span-background-expected.txt: Copied from LayoutTests/platform/mac/fast/table/table-col-group-col-span-background-expected.txt.
platform/chromium-mac/fast/table/table-col-group-span-background-expected.checksum: Added.
platform/chromium-mac/fast/table/table-col-group-span-background-expected.png: Added.
platform/chromium-mac/fast/table/table-col-group-span-background-expected.txt: Copied from LayoutTests/platform/mac/fast/table/table-col-group-span-background-expected.txt.
platform/chromium-mac/fast/table/table-col-span-background-expected.checksum: Added.
platform/chromium-mac/fast/table/table-col-span-background-expected.png: Added.
platform/chromium-mac/fast/table/table-col-span-background-expected.txt: Copied from LayoutTests/platform/mac/fast/table/table-col-span-background-expected.txt.
platform/chromium-mac/fast/table/table-row-background-expected.checksum: Added.
platform/chromium-mac/fast/table/table-row-background-expected.png: Added.
platform/chromium-mac/fast/table/table-row-background-expected.txt: Copied from LayoutTests/platform/mac/fast/table/table-row-background-expected.txt.
platform/chromium-mac/fast/table/table-row-background-left-50px-expected.checksum: Added.
platform/chromium-mac/fast/table/table-row-background-left-50px-expected.png: Added.
platform/chromium-mac/fast/table/table-row-background-left-50px-expected.txt: Copied from LayoutTests/platform/mac/fast/table/table-row-background-left-50px-expected.txt.
platform/chromium-mac/fast/table/table-row-background-right-100percent-expected.checksum: Added.
platform/chromium-mac/fast/table/table-row-background-right-100percent-expected.png: Added.
platform/chromium-mac/fast/table/table-row-background-right-100percent-expected.txt: Copied from LayoutTests/platform/mac/fast/table/table-row-background-right-100percent-expected.txt.
platform/chromium-mac/fast/table/table-row-background-right-50px-expected.checksum: Added.
platform/chromium-mac/fast/table/table-row-background-right-50px-expected.png: Added.
platform/chromium-mac/fast/table/table-row-background-right-50px-expected.txt: Copied from LayoutTests/platform/mac/fast/table/table-row-background-right-50px-expected.txt.
platform/chromium-mac/fast/table/table-row-group-background-expected.checksum: Added.
platform/chromium-mac/fast/table/table-row-group-background-expected.png: Added.
platform/chromium-mac/fast/table/table-row-group-background-expected.txt: Copied from LayoutTests/platform/mac/fast/table/table-row-group-background-expected.txt.
platform/chromium-mac/fast/table/table-row-group-background-positioned-expected.checksum: Added.
platform/chromium-mac/fast/table/table-row-group-background-positioned-expected.png: Added.
platform/chromium-mac/fast/table/table-row-group-background-positioned-expected.txt: Copied from LayoutTests/platform/mac/fast/table/table-row-group-background-positioned-expected.txt.
platform/chromium-win/fast/table/table-background-expected.checksum: Added.
platform/chromium-win/fast/table/table-background-expected.png: Added.
platform/chromium-win/fast/table/table-background-expected.txt: Added.
platform/chromium-win/fast/table/table-cell-border-draws-on-top-of-col-background-expected.checksum: Added.
platform/chromium-win/fast/table/table-cell-border-draws-on-top-of-col-background-expected.png: Added.
platform/chromium-win/fast/table/table-cell-border-draws-on-top-of-col-background-expected.txt: Added.
platform/chromium-win/fast/table/table-cell-border-draws-on-top-of-col-group-background-expected.checksum: Added.
platform/chromium-win/fast/table/table-cell-border-draws-on-top-of-col-group-background-expected.png: Added.
platform/chromium-win/fast/table/table-cell-border-draws-on-top-of-col-group-background-expected.txt: Added.
platform/chromium-win/fast/table/table-cell-border-draws-on-top-of-row-background-expected.checksum: Added.
platform/chromium-win/fast/table/table-cell-border-draws-on-top-of-row-background-expected.png: Added.
platform/chromium-win/fast/table/table-cell-border-draws-on-top-of-row-background-expected.txt: Added.
platform/chromium-win/fast/table/table-cell-border-draws-on-top-of-row-group-background-expected.checksum: Added.
platform/chromium-win/fast/table/table-cell-border-draws-on-top-of-row-group-background-expected.png: Added.
platform/chromium-win/fast/table/table-cell-border-draws-on-top-of-row-group-background-expected.txt: Added.
platform/chromium-win/fast/table/table-cell-overrides-row-background-expected.checksum: Added.
platform/chromium-win/fast/table/table-cell-overrides-row-background-expected.png: Added.
platform/chromium-win/fast/table/table-cell-overrides-row-background-expected.txt: Added.
platform/chromium-win/fast/table/table-col-background-expected.checksum: Added.
platform/chromium-win/fast/table/table-col-background-expected.png: Added.
platform/chromium-win/fast/table/table-col-background-expected.txt: Added.
platform/chromium-win/fast/table/table-col-group-background-expected.checksum: Added.
platform/chromium-win/fast/table/table-col-group-background-expected.png: Added.
platform/chromium-win/fast/table/table-col-group-background-expected.txt: Added.
platform/chromium-win/fast/table/table-col-group-col-span-background-expected.checksum: Added.
platform/chromium-win/fast/table/table-col-group-col-span-background-expected.png: Added.
platform/chromium-win/fast/table/table-col-group-col-span-background-expected.txt: Added.
platform/chromium-win/fast/table/table-col-group-span-background-expected.checksum: Added.
platform/chromium-win/fast/table/table-col-group-span-background-expected.png: Added.
platform/chromium-win/fast/table/table-col-group-span-background-expected.txt: Added.
platform/chromium-win/fast/table/table-col-span-background-expected.checksum: Added.
platform/chromium-win/fast/table/table-col-span-background-expected.png: Added.
platform/chromium-win/fast/table/table-col-span-background-expected.txt: Added.
platform/chromium-win/fast/table/table-row-background-expected.checksum: Added.
platform/chromium-win/fast/table/table-row-background-expected.png: Added.
platform/chromium-win/fast/table/table-row-background-expected.txt: Added.
platform/chromium-win/fast/table/table-row-background-left-50px-expected.checksum: Added.
platform/chromium-win/fast/table/table-row-background-left-50px-expected.png: Added.
platform/chromium-win/fast/table/table-row-background-left-50px-expected.txt: Added.
platform/chromium-win/fast/table/table-row-background-right-100percent-expected.checksum: Added.
platform/chromium-win/fast/table/table-row-background-right-100percent-expected.png: Added.
platform/chromium-win/fast/table/table-row-background-right-100percent-expected.txt: Added.
platform/chromium-win/fast/table/table-row-background-right-50px-expected.checksum: Added.
platform/chromium-win/fast/table/table-row-background-right-50px-expected.png: Added.
platform/chromium-win/fast/table/table-row-background-right-50px-expected.txt: Added.
platform/chromium-win/fast/table/table-row-group-background-expected.checksum: Added.
platform/chromium-win/fast/table/table-row-group-background-expected.png: Added.
platform/chromium-win/fast/table/table-row-group-background-expected.txt: Added.
platform/chromium-win/fast/table/table-row-group-background-positioned-expected.checksum: Added.
platform/chromium-win/fast/table/table-row-group-background-positioned-expected.png: Added.
platform/chromium-win/fast/table/table-row-group-background-positioned-expected.txt: Added.
platform/chromium/fast/runin/generated2-expected.checksum: Added.
platform/chromium/fast/runin/generated2-expected.png: Added.
platform/chromium/fast/runin/generated3-expected.checksum: Added.
platform/chromium/fast/runin/generated3-expected.png: Added.
platform/chromium/fast/runin/generated4-expected.checksum: Added.
platform/chromium/fast/runin/generated4-expected.png: Added.

11:10 AM Changeset in webkit [56733] by Joseph Pecoraro

1 edit
2 adds in trunk/LayoutTests

2010-03-29 Joseph Pecoraro <Joseph Pecoraro>

Reviewed by Darin Adler.

Test for Ensuring Pseudo Class's are Respected on Dynamic Changes
https://bugs.webkit.org/show_bug.cgi?id=36765

This tests elements affected by a CSS pseudo class selector is updated
after a dynamic DOM change.

fast/css/dynamic-pseudo-class-expected.txt: Added.
fast/css/dynamic-pseudo-class.html: Added.

10:59 AM Changeset in webkit [56732] by apavlov@chromium.org

7 edits in trunk

2010-03-29 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Cover the Audits panel with tests
https://bugs.webkit.org/show_bug.cgi?id=36613

LayoutTests:

inspector/audits-panel-functional-expected.txt: Added.
inspector/audits-panel-functional.html: Added.
inspector/resources/audits-script1.js: Added. (foo1):
inspector/resources/audits-script2.js: Added. (foo2):
inspector/resources/audits-script3.js: Added. (foo3):

WebCore:

English.lproj/localizedStrings.js:
inspector/front-end/AuditResultView.js: (WebInspector.AuditResultView): (WebInspector.AuditCategoryResultPane.ruleSorter): (WebInspector.AuditCategoryResultPane):
inspector/front-end/AuditRules.js: (WebInspector.AuditRules.GzipRule.prototype.doRun): (WebInspector.AuditRules.CombineExternalResourcesRule.prototype.doRun): (WebInspector.AuditRules.UnusedCssRule.prototype.doRun.evalCallback.selectorsCallback): (WebInspector.AuditRules.ImageDimensionsRule.prototype.doRun): (WebInspector.AuditRules.CssInHeadRule.prototype.doRun): (WebInspector.AuditRules.CookieSizeRule.prototype.processCookies):
inspector/front-end/AuditsPanel.js: (WebInspector.AuditRuleResult.linkifyDisplayName): (WebInspector.AuditRuleResult.resourceDomain): (WebInspector.AuditRuleResult.prototype.addURL):
inspector/front-end/inspector.js: (WebInspector.displayNameForURL):

10:54 AM April 2010 Meeting edited by ericu@chromium.org

(diff)

10:50 AM Changeset in webkit [56731] by eric@webkit.org

2 edits in trunk/WebKit/qt

2010-03-29 Kenneth Rohde Christiansen <kenneth@webkit.org>

Reviewed by Antti Koivisto.

Use 'Mobile Safari' instead of 'Safari' on mobile Qt platforms.

Api/qwebpage.cpp: (QWebPage::userAgentForUrl):

10:39 AM Changeset in webkit [56730] by jocelyn.turcotte@nokia.com

2 edits in trunk/WebCore

[Qt] Fix build break introduced in r56724.

Reviewed by nobody, build fix.

WebCore.pro:

10:31 AM Changeset in webkit [56729] by eric@webkit.org

2 edits in trunk/JavaScriptCore

2010-03-29 Patrick Gansterer <paroga@paroga.com>

Reviewed by Darin Adler.

Corrected name of (u)int64_t compile time assert.
https://bugs.webkit.org/show_bug.cgi?id=36739

int64_t_is_four_bytes -> int64_t_is_eight_bytes

os-win32/stdint.h:

10:13 AM Changeset in webkit [56728] by eric@webkit.org

3 edits in trunk/WebKit/chromium

2010-03-29 Jochen Eisinger <jochen@chromium.org>

Reviewed by Darin Fisher.

Pass a WebFrame to WebFrameClient::allowDatabase instead of a WebSecurityOrigin
https://bugs.webkit.org/show_bug.cgi?id=36743

public/WebFrameClient.h: (WebKit::WebFrameClient::allowDatabase):
src/DatabaseObserver.cpp: (WebCore::DatabaseObserver::canEstablishDatabase):

10:11 AM Changeset in webkit [56727] by apavlov@chromium.org

4 edits in trunk

2010-03-29 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector should highlight when clicking a node's closing tag
https://bugs.webkit.org/show_bug.cgi?id=16258

LayoutTests:

inspector/elements-panel-limited-children.html:

WebCore:

inspector/front-end/ElementsTreeOutline.js: (WebInspector.ElementsTreeOutline.prototype.set suppressRevealAndSelect): (WebInspector.ElementsTreeOutline.prototype.revealAndSelectNode): (WebInspector.ElementsTreeOutline.prototype._keyDown): (WebInspector.ElementsTreeOutline.prototype._onmousemove): (WebInspector.ElementsTreeElement): (WebInspector.ElementsTreeElement.prototype.showChild): (WebInspector.ElementsTreeElement.prototype.onpopulate): (WebInspector.ElementsTreeElement.prototype.updateChildren): (WebInspector.ElementsTreeElement.prototype.insertChildElement): (WebInspector.ElementsTreeElement.prototype.moveChild): (WebInspector.ElementsTreeElement.prototype._updateChildren): (WebInspector.ElementsTreeElement.prototype.onexpand): (WebInspector.ElementsTreeElement.prototype.oncollapse): (WebInspector.ElementsTreeElement.prototype.onselect): (WebInspector.ElementsTreeElement.prototype.ondblclick): ():

10:03 AM April 2010 Meeting edited by chang.shu@nokia.com

(diff)

10:00 AM April 2010 Meeting edited by Chris Jerdonek

Alphabetize list of attendees (diff)

9:56 AM April 2010 Meeting edited by darin@chromium.org

(diff)

9:56 AM Changeset in webkit [56726] by eric@webkit.org

4 edits in trunk/WebCore

2010-03-29 Marcus Bulach <bulach@chromium.org>

Reviewed by Jeremy Orlow.

https://bugs.webkit.org/show_bug.cgi?id=36315

Remove obsolete Geolocation::m_currentPosition
(follow up on https://bugs.webkit.org/show_bug.cgi?id=30676)

page/Geolocation.cpp: (WebCore::Geolocation::positionChanged): (WebCore::Geolocation::makeSuccessCallbacks):
page/Geolocation.h:
platform/chromium/GeolocationServiceChromium.cpp: (WebCore::GeolocationServiceChromium::GeolocationServiceChromium):

9:52 AM April 2010 Meeting edited by treat@kde.org

(diff)

9:51 AM April 2010 Meeting edited by dbates@webkit.org

Added myself to the list of attendees (diff)

9:31 AM April 2010 Meeting edited by levin@chromium.org

(diff)

9:24 AM Changeset in webkit [56725] by jocelyn.turcotte@nokia.com

2 edits in trunk/JavaScriptCore

[Qt] Use the -l syntax for linking against JavaScriptCore on Windows.
This allow qmake to extract dependencies correctly when generating VS
solutions.

Reviewed by Simon Hausmann.

JavaScriptCore.pri:

9:24 AM Changeset in webkit [56724] by jocelyn.turcotte@nokia.com

2 edits in trunk/WebCore

[Qt] Do not generate INSTALLS for webkit when building inside Qt.
Qt will do this for us.

Reviewed by Simon Hausmann.

WebCore.pro:

9:21 AM April 2010 Meeting edited by rik@webkit.org

(diff)

9:19 AM April 2010 Meeting edited by ben@webkit.org

(diff)

9:10 AM April 2010 Meeting edited by levin@chromium.org

(diff)

9:05 AM Changeset in webkit [56723] by antti.j.koivisto@nokia.com

2 edits in trunk/WebCore

https://bugs.webkit.org/show_bug.cgi?id=36703
Timer restart loop during page loading

Reviewed by Kenneth Rohde Christiansen.

Fix regression introduced in http://trac.webkit.org/changeset/54526.
Restarting the request timer unconditionally from the timer callback is a bad idea.
Instead, start the timer when a non-cached request completes.

loader/loader.cpp:

(WebCore::Loader::Host::nonCacheRequestComplete):
(WebCore::Loader::Host::servePendingRequests):

9:04 AM April 2010 Meeting edited by vestbo@webkit.org

(diff)

8:29 AM April 2010 Meeting edited by kenneth@webkit.org

(diff)

8:28 AM April 2010 Meeting edited by kenneth@webkit.org

(diff)

8:16 AM April 2010 Meeting created by Chris Jerdonek

Started page for WebKit meeting

8:15 AM Changeset in webkit [56722] by Csaba Osztrogonác

1 edit
1 add in trunk/LayoutTests

Rubber-stamped by Kenneth Rohde Christiansen.

Add support for iframe flattening
https://bugs.webkit.org/show_bug.cgi?id=36662

platform/mac/fast/frames/flattening/iframe-flattening-simple-expected.txt: Added.

8:12 AM WikiStart edited by Chris Jerdonek

Fix typo (diff)

8:11 AM WikiStart edited by Chris Jerdonek

Created link to a page for the April 2010 WebKit meeting (diff)

7:48 AM Changeset in webkit [56721] by Simon Hausmann

2 edits in trunk/WebKit/qt

[Qt] unit tests don't compile inside of Qt

Reviewed by Tor Arne Vestbø.

https://bugs.webkit.org/show_bug.cgi?id=36756

tests/tests.pri: Don't do the target substitution inside Qt and find the sources

through VPATH instead of relying on the location of the .pro file exclusively.

7:40 AM Changeset in webkit [56720] by Csaba Osztrogonác

2 edits in trunk/LayoutTests

Rubber-stamped by Kenneth Rohde Christiansen.

Add support for iframe flattening
https://bugs.webkit.org/show_bug.cgi?id=36662

platform/mac/fast/frames/flattening/frameset-flattening-subframe-resize-expected.txt: updated after r56718.

7:03 AM Changeset in webkit [56719] by Simon Hausmann

2 edits in trunk/WebCore

[Qt] Shadowbuilds of WebCore with Qt on Symbian fails.

Patch by Thomas Zander <t.zander@nokia.com> on 2010-03-29
Reviewed by Simon Hausmann.

https://bugs.webkit.org/show_bug.cgi?id=36749

Doing a 'make sis' expects the dll in the libdir, so place it
there. This fixes out-of-source building to always put the dll
in the expected dir.

WebCore.pro: Fix for shadow builds inside Qt.

7:03 AM Changeset in webkit [56718] by kenneth@webkit.org

47 edits
2 adds in trunk

WebCore: Implement flattening for iframes.

Reviewed by Antti Koivisto.

Refactoring of frameset flattening code to reuse it for
iframe flattening.

Tests: fast/frames/flattening/iframe-flattening-simple.html

WebCore.base.exp:
page/FrameView.cpp:

(WebCore::FrameView::layout):
(WebCore::FrameView::scheduleRelayout):

page/Settings.cpp:

(WebCore::Settings::Settings):
(WebCore::Settings::setFrameFlatteningEnabled):

page/Settings.h:

(WebCore::Settings::frameFlatteningEnabled):

rendering/RenderFrame.cpp:
rendering/RenderFrame.h:
rendering/RenderFrameSet.cpp:

(WebCore::RenderFrameSet::flattenFrameSet):

rendering/RenderFrameSet.h:
rendering/RenderPart.cpp:

(WebCore::RenderPart::layoutWithFlattening):

rendering/RenderPart.h:
rendering/RenderPartObject.cpp:

(WebCore::RenderPartObject::flattenFrame):
(WebCore::RenderPartObject::calcHeight):
(WebCore::RenderPartObject::calcWidth):
(WebCore::RenderPartObject::layout):

rendering/RenderPartObject.h:

WebKit/mac: Change method name due to it dealing with both flattening
of frame sets and inner frames.

Reviewed by Antti Koivisto.

WebView/WebPreferenceKeysPrivate.h:
WebView/WebPreferences.mm:

(+[WebPreferences initialize]):
(-[WebPreferences isFrameFlatteningEnabled]):
(-[WebPreferences setFrameFlatteningEnabled:]):

WebView/WebPreferencesPrivate.h:
WebView/WebView.mm:

(-[WebView _preferencesChangedNotification:]):

WebKit/qt: Change due to renaming of frame flattening setting.

Reviewed by Antti Koivisto.

Api/qwebpage.cpp:

(qt_drt_setFrameFlatteningEnabled):

Api/qwebsettings.cpp:

(QWebSettingsPrivate::apply):

symbian/eabi/QtWebKitu.def:

WebKit/win: Change method name due to it dealing with both flattening
of frame sets and inner frames.

Reviewed by Antti Koivisto.

Interfaces/IWebPreferencesPrivate.idl:
WebPreferenceKeysPrivate.h:
WebPreferences.cpp:

(WebPreferences::initializeDefaultSettings):
(WebPreferences::isFrameFlatteningEnabled):
(WebPreferences::setFrameFlatteningEnabled):

WebPreferences.h:
WebView.cpp:

(WebView::notifyPreferencesChanged):

WebKitTools: Renaming of frame flattening LayoutTestController method
to setFrameFlatteningEnabled(bool)

Reviewed by Antti Koivisto.

DumpRenderTree/LayoutTestController.cpp:

(setFrameFlatteningEnabledCallback):
(LayoutTestController::staticFunctions):

DumpRenderTree/LayoutTestController.h:
DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: