Timeline
Apr 4, 2010:
- 11:30 PM Changeset in webkit [57064] by
-
- 9 edits1 move1 delete in trunk
2010-04-04 Pavel Feldman <pfeldman@chromium.org>
Not reviewed. Rolling out chromium changes r57028 and r57032
for breaking chromium layout tests.
- WebCore.gyp/WebCore.gyp:
- WebCore.gypi:
- platform/chromium/DragImageChromium.cpp: Added. (WebCore::dragImageSize): (WebCore::deleteDragImage): (WebCore::scaleDragImage): (WebCore::dissolveDragImageToFraction): (WebCore::createDragImageFromImage): (WebCore::createDragImageIconForCachedImage):
- platform/chromium/DragImageChromiumMac.cpp: Removed.
- platform/chromium/DragImageChromiumSkia.cpp: Removed.
- platform/chromium/DragImageRef.h:
WebKit/chromium:
- public/WebViewClient.h: (WebKit::WebViewClient::startDragging):
- src/DragClientImpl.cpp: (WebKit::DragClientImpl::startDrag):
- src/WebViewImpl.cpp: (WebKit::WebViewImpl::startDragging):
- src/WebViewImpl.h:
- 7:28 PM Changeset in webkit [57063] by
-
- 2 edits in trunk/WebKitTools
2010-04-04 John Gregg <johnnyg@google.com>
Unreviewed, add myself to the committers list.
- Scripts/webkitpy/common/config/committers.py:
- 7:11 PM Changeset in webkit [57062] by
-
- 3 edits in trunk/LayoutTests
Unreviewed expected results fix.
Patch by Antonio Gomes <tonikitoo@webkit.org>
The implementation was fixed, and results were no longer valid.
- fast/events/spatial-navigation/snav-iframe-no-scrollable-content-expected.txt:
- fast/events/spatial-navigation/snav-iframe-no-scrollable-content.html:
- 7:10 PM Changeset in webkit [57061] by
-
- 6 edits in trunk/WebCore
2010-03-29 Antonio Gomes <tonikitoo@webkit.org>
Reviewed by Simon Fraser.
Patch by Antonio Gomes <tonikitoo@webkit.org>
Spatial Navigation: Initial code simplification in FocusController.cpp and SpatialNavigation.cpp
WebCore::distanceInDirection method was handling much of the logic not
strictly only related to the distance between nodes acquisition. This
method was simplified and renamed to 'WebCore::distanceDataForNode'.
The latter is now responsible for only getting the distance and alignment
data, while all assignement logic previously in distanceInDirection method
was moved place to updateFocusCandidateIfCloser.
Parent document distance and alignment acquisitions, in turn, have also
changed location: they are both got from deepFindFocusableNodeInDirection,
and passed in a recursive call to findFocusableNodeInDirection via the
candidateParent variable (optional parameter). In addition, the need for
the 'focusCandidateCopy' variable in deepFindFocusableNodeInDirection method
was removed, making the code much cleaner.
No behaviour change at this point. Mostly moving code around to the place
where it should live in.
- page/FocusController.cpp: (WebCore::FocusController::advanceFocusDirectionally): (WebCore::updateFocusCandidateIfCloser): (WebCore::FocusController::findFocusableNodeInDirection): (WebCore::FocusController::deepFindFocusableNodeInDirection):
- page/FocusController.h:
- page/SpatialNavigation.cpp: (WebCore::distanceDataForNode): (WebCore::renderRectRelativeToRootDocument):
- page/SpatialNavigation.
- 3:18 PM Changeset in webkit [57060] by
-
- 2 edits in trunk/WebCore
2010-04-04 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: In the inherited styles, do not render non-inherited properties as overriden.
- inspector/front-end/StylesSidebarPane.js: (WebInspector.StylePropertiesSection.prototype.isPropertyOverloaded):
- 3:00 PM Changeset in webkit [57059] by
-
- 1 edit21 adds in trunk/WebKitSite
2010-04-04 Pavel Feldman <pfeldman@chromium.org>
(Not reviewed).
Adding images for inspector blog post. Previewed by Timothy Hatcher.
- blog-files/inspector/audits_launcher.png: Added.
- blog-files/inspector/audits_panel.png: Added.
- blog-files/inspector/console_panel.png: Added.
- blog-files/inspector/context_menu.png: Added.
- blog-files/inspector/css_highlighted_line.png: Added.
- blog-files/inspector/css_line_number_snippet.png: Added.
- blog-files/inspector/css_line_numbers.png: Added.
- blog-files/inspector/deactivate_breakpoints.png: Added.
- blog-files/inspector/evaluate_on_hover.png: Added.
- blog-files/inspector/evaluate_on_hover_2.png: Added.
- blog-files/inspector/inherited_styles.png: Added.
- blog-files/inspector/large_dom.png: Added.
- blog-files/inspector/large_resources.png: Added.
- blog-files/inspector/pseudo_elements.png: Added.
- blog-files/inspector/redirect_headers.png: Added.
- blog-files/inspector/redirect_headers_full.png: Added.
- blog-files/inspector/redirects.png: Added.
- blog-files/inspector/redirects_full.png: Added.
- blog-files/inspector/timeline_overview.png: Added.
- blog-files/inspector/timeline_panel.png: Added.
- blog-files/inspector/timeline_record_details.png: Added.
- 4:52 AM Changeset in webkit [57058] by
-
- 2 edits in trunk/WebKitTools
2010-04-04 Robert Hogan <robert@webkit.org>
Unreviewed, add myself to the committers list.
- Scripts/webkitpy/common/config/committers.py:
- 1:53 AM Changeset in webkit [57057] by
-
- 2 edits in trunk/WebKitTools
Unreviewed, adding my IRC nickname to committers.py
- Scripts/webkitpy/common/config/committers.py:
- 1:26 AM Changeset in webkit [57056] by
-
- 5 edits in trunk/WebKitTools
2010-04-04 Chris Jerdonek <Chris Jerdonek>
Reviewed by Shinichiro Hamaji.
Refactored check-webkit-style's option-parsing code.
- Scripts/check-webkit-style:
- Moved the "WebKit checkout not found" check from ArgumentParser.parse() to the calling code.
- Moved the --git-commit argument validation from the calling code to ArgumentParser.parse().
- Scripts/webkitpy/style/checker_unittest.py:
- Updated a unit test as necessary.
- Scripts/webkitpy/style/optparser.py:
- Renamed ArgumentParser._exit_with_help() to _parse_error() and made its error_message parameter required.
- Removed the found_checkout parameter from ArgumentParser.parse().
- Removed the "WebKit checkout not found" check and moved it to the calling code.
- Added --git-commit argument checking.
- Scripts/webkitpy/style/optparser_unittest.py:
- Adjusted the import statements to be fully qualified.
- Changed the ArgumentParserTest class to inherit from LoggingTestCase, and updated the class as necessary.
- Added a unit-test for the --git-commit validation.
- Added unit tests for the --git-diff and --git-since variants of --git-commit.
Apr 3, 2010:
- 11:53 PM Changeset in webkit [57055] by
-
- 6 edits in trunk/JavaScriptCore
https://bugs.webkit.org/show_bug.cgi?id=37068
Change UString to use a 0 rep for null strings instead of a null object.
Reviewed by Oliver Hunt.
No performance impact.
- JavaScriptCore.exp:
- runtime/InternalFunction.cpp:
(JSC::InternalFunction::InternalFunction):
- runtime/JSString.h:
(JSC::RopeBuilder::JSString):
- runtime/UString.cpp:
(JSC::initializeUString):
- runtime/UString.h:
(JSC::UString::UString):
(JSC::UString::data):
(JSC::UString::size):
(JSC::UString::isNull):
(JSC::UString::isEmpty):
(JSC::UString::cost):
- 6:53 PM PythonGuidelines edited by
- Added another reason for the from/import ordering suggestion. (diff)
- 6:17 PM Changeset in webkit [57054] by
-
- 3 edits in trunk/JavaScriptCore
2010-04-03 Balazs Kelemen <kb@inf.u-szeged.hu>
Reviewed by Oliver Hunt.
Fix uninitalised members in CallLinkInfo and BytecodeGenerator.
- bytecode/CodeBlock.cpp: (JSC::CodeBlock::CodeBlock):
- bytecode/CodeBlock.h: (JSC::CallLinkInfo::CallLinkInfo):
- 1:28 PM PythonGuidelines edited by
- Moved the PEP8 remark to the style section. (diff)
- 1:20 PM PythonGuidelines edited by
- Fixed typo. (diff)
- 1:19 PM PythonGuidelines edited by
- Added a style section. (diff)
- 1:01 PM WikiStart edited by
- Retitled link to Python page (diff)
- 11:59 AM Changeset in webkit [57053] by
-
- 2 edits in trunk/LayoutTests
2010-04-03 Jakub Wieczorek <jwieczorek@webkit.org>
Unreviewed.
[Qt] Skip five XMLHttpRequest tests that are timing out.
- platform/qt/Skipped: Add a comment on why they are failing.
- 10:40 AM Changeset in webkit [57052] by
-
- 2 edits in trunk/LayoutTests
2010-04-03 Jakub Wieczorek <jwieczorek@webkit.org>
Rubber-stamped by Daniel Bates.
Fix the fast/events/popup-allowed-from-gesture-initiated-event.html test
failure on the Qt and GTK+ ports.
Refactor it to not hardcode any metrics (in order to dispatch mouse events)
but instead calculate them from the offset* properties.
- fast/events/popup-allowed-from-gesture-initiated-event.html:
- 10:40 AM WikiStart edited by
- (diff)
- 10:38 AM Keeping the Tree Green edited by
- (diff)
- 10:35 AM Keeping the Tree Green edited by
- (diff)
- 10:34 AM Keeping the Tree Green edited by
- (diff)
- 10:34 AM Keeping the Tree Green created by
- 10:27 AM Changeset in webkit [57051] by
-
- 11 edits in trunk
2010-04-03 yael aharon <yael.aharon@nokia.com>
Reviewed by Darin Adler.
Enable HTMLProgressElement for Safari on OSX
https://bugs.webkit.org/show_bug.cgi?id=36961
- Configurations/FeatureDefines.xcconfig:
2010-04-03 Kenneth Russell <kbr@google.com>
Reviewed by Darin Fisher.
Inconsistent failure modes from uniform[Matrix]* with null WebGLUniformLocation
https://bugs.webkit.org/show_bug.cgi?id=36574
Fixed bugs in JavaScript bindings for uniform[Matrix]* entry
points causing them to throw exceptions rather than synthesize GL
errors. Fixed the implementations to synthesize INVALID_VALUE
rather than INVALID_OPERATION to comply to the WebGL spec. Updated
uniform-location-expected.txt to incorporate the correct error.
Tested in Safari and Chromium.
- fast/canvas/webgl/null-uniform-location-expected.txt: Added.
- fast/canvas/webgl/null-uniform-location.html: Added.
- fast/canvas/webgl/script-tests/null-uniform-location.js: Added. (callUniformFunction):
- fast/canvas/webgl/uniform-location-expected.txt:
2010-04-03 yael aharon <yael.aharon@nokia.com>
Reviewed by Darin Adler.
Enable HTMLProgressElement for Safari on OSX
https://bugs.webkit.org/show_bug.cgi?id=36961
- Configurations/FeatureDefines.xcconfig:
- WebCore.xcodeproj/project.pbxproj:
- rendering/RenderThemeMac.h:
- rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::animationRepeatIntervalForProgressBar): (WebCore::RenderThemeMac::animationDurationForProgressBar): (WebCore::RenderThemeMac::adjustProgressBarStyle): (WebCore::RenderThemeMac::paintProgressBar):
2010-04-03 yael aharon <yael.aharon@nokia.com>
Reviewed by Darin Adler.
Enable HTMLProgressElement for Safari on OSX
https://bugs.webkit.org/show_bug.cgi?id=36961
- Configurations/FeatureDefines.xcconfig:
- 7:34 AM Changeset in webkit [57050] by
-
- 2 edits in trunk/WebCore
2010-04-03 Jakub Wieczorek <jwieczorek@webkit.org>
Unreviewed.
Fix debug build with GCC >= 4.3.
- platform/graphics/GraphicsLayer.cpp: Include stdio.h explicitly.
- 12:49 AM Changeset in webkit [57049] by
-
- 5 edits3 adds in trunk
2010-04-03 Kenneth Russell <kbr@google.com>
Reviewed by Darin Fisher.
Inconsistent failure modes from uniform[Matrix]* with null WebGLUniformLocation
https://bugs.webkit.org/show_bug.cgi?id=36574
Fixed bugs in JavaScript bindings for uniform[Matrix]* entry
points causing them to throw exceptions rather than synthesize GL
errors. Fixed the implementations to synthesize INVALID_VALUE
rather than INVALID_OPERATION to comply to the WebGL spec. Updated
uniform-location-expected.txt to incorporate the correct error.
Tested in Safari and Chromium.
- fast/canvas/webgl/null-uniform-location-expected.txt: Added.
- fast/canvas/webgl/null-uniform-location.html: Added.
- fast/canvas/webgl/script-tests/null-uniform-location.js: Added. (callUniformFunction):
- fast/canvas/webgl/uniform-location-expected.txt:
2010-04-03 Kenneth Russell <kbr@google.com>
Reviewed by Darin Fisher.
Inconsistent failure modes from uniform[Matrix]* with null WebGLUniformLocation
https://bugs.webkit.org/show_bug.cgi?id=36574
Fixed bugs in JavaScript bindings for uniform[Matrix]* entry
points causing them to throw exceptions rather than synthesize GL
errors. Fixed the implementations to synthesize INVALID_VALUE
rather than INVALID_OPERATION to comply to the WebGL spec. Updated
uniform-location-expected.txt to incorporate the correct error.
Tested in Safari and Chromium.
Test: fast/canvas/webgl/null-uniform-location.html
- bindings/v8/custom/V8WebGLRenderingContextCustom.cpp: (WebCore::V8WebGLRenderingContext::getUniformCallback): (WebCore::vertexAttribAndUniformHelperf): (WebCore::uniformHelperi): (WebCore::uniformMatrixHelper):
- html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::uniform1f): (WebCore::WebGLRenderingContext::uniform1fv): (WebCore::WebGLRenderingContext::uniform1i): (WebCore::WebGLRenderingContext::uniform1iv): (WebCore::WebGLRenderingContext::uniform2f): (WebCore::WebGLRenderingContext::uniform2fv): (WebCore::WebGLRenderingContext::uniform2i): (WebCore::WebGLRenderingContext::uniform2iv): (WebCore::WebGLRenderingContext::uniform3f): (WebCore::WebGLRenderingContext::uniform3fv): (WebCore::WebGLRenderingContext::uniform3i): (WebCore::WebGLRenderingContext::uniform3iv): (WebCore::WebGLRenderingContext::uniform4f): (WebCore::WebGLRenderingContext::uniform4fv): (WebCore::WebGLRenderingContext::uniform4i): (WebCore::WebGLRenderingContext::uniform4iv): (WebCore::WebGLRenderingContext::uniformMatrix2fv): (WebCore::WebGLRenderingContext::uniformMatrix3fv): (WebCore::WebGLRenderingContext::uniformMatrix4fv):
- 12:46 AM Changeset in webkit [57048] by
-
- 4 edits in trunk/WebKitTools
The check-webkit-style script now logs an ERROR and exits when
encountering a file path that does not exist. Previously, it failed
silently on such paths.
Reviewed by Shinichiro Hamaji.
https://bugs.webkit.org/show_bug.cgi?id=36957
- Scripts/webkitpy/common/system/logtesting.py:
- Added a FIXME to rename the LoggingTestCase class to LoggingTestCaseBase.
- Scripts/webkitpy/style/checker.py:
- In the StyleChecker.check_file() method:
- Added a mock_os_path_exists parameter.
- Renamed the process_file parameter to mock_process_file.
- Added logic to log an error and exist if the given path does not exist.
- In the StyleChecker.check_file() method:
- Scripts/webkitpy/style/checker_unittest.py:
- Refactored the StyleCheckerCheckFileTest class slightly to inherit from LoggingTestCase.
- Added a test method to unit-test the case of a file that does not exist.
- Adjusted the other test methods as necessary.
- 12:34 AM Changeset in webkit [57047] by
-
- 3 edits in trunk/WebKitTools
2010-04-03 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Add Tiger Bot to the list of "core builders" (builders which block the commit-queue when red)
https://bugs.webkit.org/show_bug.cgi?id=33289
Add Tiger and SnowLeopard Tests to the core builders. This is a bit of
an experiment now that the bots are green. Hopefully we can keep them
on the list and have the tree stay greener.
- Scripts/webkitpy/common/net/buildbot.py:
- 12:12 AM Changeset in webkit [57046] by
-
- 2 edits in trunk/WebKit/chromium
2010-04-03 Darin Fisher <darin@chromium.org>
Add default implementations of WebNotificationPresenter methods to
repair the downstream Chromium build.
- public/WebNotificationPresenter.h: (WebKit::WebNotificationPresenter::show): (WebKit::WebNotificationPresenter::cancel): (WebKit::WebNotificationPresenter::objectDestroyed): (WebKit::WebNotificationPresenter::checkPermission): (WebKit::WebNotificationPresenter::requestPermission):
- 12:05 AM Changeset in webkit [57045] by
-
- 13 edits8 adds in trunk
2010-04-02 Andy Estes <aestes@apple.com>
Reviewed by Adam Barth.
- fast/events/popup-allowed-from-gesture-initiated-event-expected.txt: Added.
- fast/events/popup-allowed-from-gesture-initiated-event.html: Added.
- fast/events/popup-blocked-from-fake-button-click-expected.txt: Added.
- fast/events/popup-blocked-from-fake-button-click.html: Added.
- fast/events/popup-blocked-from-fake-focus-expected.txt: Added.
- fast/events/popup-blocked-from-fake-focus.html: Added.
2010-04-02 Andy Estes <aestes@apple.com>
Reviewed by Adam Barth.
The previous mechanism for testing whether an event was due to a user
gesture only checked the event type, not the source of the event. This
allowed scripts to defeat popup blocking by programatically emitting
certain types of events.
Change the user gesture detection to check for a flag that is only set
when the event in question was generated through the platform and not
through the DOM.
Tests: fast/events/popup-allowed-from-gesture-initiated-event.html
fast/events/popup-blocked-from-fake-button-click.html
fast/events/popup-blocked-from-fake-focus.html
- Android.mk: Add UserGestureIndicator.{cpp, h}.
- GNUmakefile.am: Same.
- WebCore.gypi: Same.
- WebCore.pro: Same.
- WebCore.vcproj/WebCore.vcproj: Same.
- WebCore.xcodeproj/project.pbxproj: Same.
- bindings/v8/ScriptController.cpp: (WebCore::ScriptController::processingUserGesture): Check the value of UserGesureIndicator::processingUserGesture().
- dom/Document.cpp: (WebCore::Document::createEvent): Remove call to Event::setCreatedByDOM().
- dom/Event.cpp: (WebCore::Event::Event): Remove initializers for m_createdByDOM. (WebCore::Event::fromUserGesture): Check the value of UserGestureIndicator::processingUserGesture().
- dom/Event.h: Remove m_createdByDOM.
- dom/UserGestureIndicator.cpp: Added. (WebCore::UserGestureIndicator::UserGestureIndicator): Save the previous value of s_processingUserGesture before setting it to true. (WebCore::UserGestureIndicator::~UserGestureIndicator): Restore s_processingUserGesture to its previous value.
- dom/UserGestureIndicator.h: Added. (WebCore::UserGestureIndicator::processingUserGesture): Return the value of s_processingUserGesture.
- page/EventHandler.cpp: (WebCore::EventHandler::handleMousePressEvent): Instantiate a UserGestureIndicator object on the stack to indicate a user gesture is being processed. (WebCore::EventHandler::handleMouseDoubleClickEvent): Same. (WebCore::EventHandler::handleMouseReleaseEvent): Same. (WebCore::EventHandler::keyEvent): Same. (WebCore::EventHandler::handleTouchEvent): Same.
