⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Apr 5, 2010:

11:59 PM Changeset in webkit [57130] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-04-05 MORITA Hajime <​morrita@google.com>

Reviewed by Darin Adler.

RenderProgress.cpp is missing CurrentTime.h
​https://bugs.webkit.org/show_bug.cgi?id=37080

No new tests. just fixed compilation error.

  • rendering/RenderProgress.cpp:
11:48 PM Changeset in webkit [57129] by eric@webkit.org
  • 2 edits in trunk/WebKit/win

2010-04-05 Peter Nelson <​charn.opcode@gmail.com>

Reviewed by Eric Seidel.

Fixed style errors in DOMCoreClasses.h to bring it up to scratch
for ​https://bugs.webkit.org/show_bug.cgi?id=34979.

  • DOMCoreClasses.h: (DOMObject::throwException): (DOMObject::callWebScriptMethod): (DOMObject::evaluateWebScript): (DOMObject::removeWebScriptKey): (DOMObject::stringRepresentation): (DOMObject::webScriptValueAtIndex): (DOMObject::setWebScriptValueAtIndex): (DOMObject::setException): (DOMNodeList::throwException): (DOMNodeList::callWebScriptMethod): (DOMNodeList::evaluateWebScript): (DOMNodeList::removeWebScriptKey): (DOMNodeList::stringRepresentation): (DOMNodeList::webScriptValueAtIndex): (DOMNodeList::setWebScriptValueAtIndex): (DOMNodeList::setException): (DOMDocument::throwException): (DOMDocument::callWebScriptMethod): (DOMDocument::evaluateWebScript): (DOMDocument::removeWebScriptKey): (DOMDocument::stringRepresentation): (DOMDocument::webScriptValueAtIndex): (DOMDocument::setWebScriptValueAtIndex): (DOMDocument::setException): (DOMDocument::nodeName): (DOMDocument::nodeValue): (DOMDocument::setNodeValue): (DOMDocument::nodeType): (DOMDocument::parentNode): (DOMDocument::childNodes): (DOMDocument::firstChild): (DOMDocument::lastChild): (DOMDocument::previousSibling): (DOMDocument::nextSibling): (DOMDocument::attributes): (DOMDocument::ownerDocument): (DOMDocument::insertBefore): (DOMDocument::replaceChild): (DOMDocument::removeChild): (DOMDocument::appendChild): (DOMDocument::hasChildNodes): (DOMDocument::cloneNode): (DOMDocument::isSupported): (DOMDocument::namespaceURI): (DOMDocument::prefix): (DOMDocument::setPrefix): (DOMDocument::localName): (DOMDocument::hasAttributes): (DOMDocument::isSameNode): (DOMDocument::isEqualNode): (DOMDocument::textContent): (DOMDocument::setTextContent): (DOMElement::throwException): (DOMElement::callWebScriptMethod): (DOMElement::evaluateWebScript): (DOMElement::removeWebScriptKey): (DOMElement::stringRepresentation): (DOMElement::webScriptValueAtIndex): (DOMElement::setWebScriptValueAtIndex): (DOMElement::setException): (DOMElement::nodeName): (DOMElement::nodeValue): (DOMElement::setNodeValue): (DOMElement::nodeType): (DOMElement::parentNode): (DOMElement::childNodes): (DOMElement::firstChild): (DOMElement::lastChild): (DOMElement::previousSibling): (DOMElement::nextSibling): (DOMElement::attributes): (DOMElement::ownerDocument): (DOMElement::insertBefore): (DOMElement::replaceChild): (DOMElement::removeChild): (DOMElement::appendChild): (DOMElement::hasChildNodes): (DOMElement::cloneNode): (DOMElement::isSupported): (DOMElement::namespaceURI): (DOMElement::prefix): (DOMElement::setPrefix): (DOMElement::localName): (DOMElement::hasAttributes): (DOMElement::isSameNode): (DOMElement::isEqualNode): (DOMElement::textContent): (DOMElement::setTextContent):
11:33 PM Changeset in webkit [57128] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-04-05 Eric Uhrhane <​ericu@chromium.org>

Reviewed by Brady Eidson.

window.openDatabase() always fails for new databases when using WebKit nightly with Safari 4.0.5
​https://bugs.webkit.org/show_bug.cgi?id=36671

The previous "fix" I mistakenly compared hashes, an improvement over comparing pointers, but still not right.

No new tests.

  • storage/DatabaseTracker.cpp: (WebCore::DatabaseTracker::fullPathForDatabaseNoLock): Use SecurityOrigin::equal to compare instead of SecurityOriginHash.
11:32 PM WebInspector edited by Joseph Pecoraro
(diff)
11:11 PM Changeset in webkit [57127] by eric@webkit.org
  • 3 edits in trunk/WebCore

2010-04-05 Anthony Ricaud <​rik@webkit.org>

Reviewed by Timothy Hatcher.

Web Inspector: Audits launcher view is unusable with a small height window
​https://bugs.webkit.org/show_bug.cgi?id=37109

Use flex box instead of absolute positioning to avoid overlapping elements.

  • inspector/front-end/AuditLauncherView.js: (WebInspector.AuditLauncherView.prototype._createLauncherUI):
  • inspector/front-end/audits.css: (.audit-launcher-view .audit-launcher-view-content): (.audit-launcher-view div.button-container): (.audit-launcher-view .flexible-space):
11:08 PM WikiStart edited by Joseph Pecoraro
(diff)
11:01 PM Changeset in webkit [57126] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-04-05 Luiz Agostini <​luiz.agostini@openbossa.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Maemo5 theme - wrong spelling
​https://bugs.webkit.org/show_bug.cgi?id=37110

Correcting wrong spelling in RenderThemeQt.cpp.

  • platform/qt/RenderThemeQt.cpp:
10:52 PM Changeset in webkit [57125] by abarth@webkit.org
  • 6 edits in trunk/WebKitTools

2010-04-05 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

SheriffBot should force_build builders that are idle and have failed exactly once
​https://bugs.webkit.org/show_bug.cgi?id=37059

We can get into a deadlocked state where the commit-queue is stopped
because the builders are red but the SheriffBot hasn't taken action
because the builder has failed only once. The SheriffBot should force
build idle builders that have failed exactly once to either turn the
tree green again (if the test was flaky) or trigger the "failed twice"
remedies (IRC and bug posts).

  • Scripts/webkitpy/common/net/buildbot.py:
  • Scripts/webkitpy/tool/bot/sheriff.py:
  • Scripts/webkitpy/tool/bot/sheriff_unittest.py:
  • Scripts/webkitpy/tool/commands/sheriffbot.py:
  • Scripts/webkitpy/tool/mocktool.py:
10:51 PM Changeset in webkit [57124] by eric@webkit.org
  • 4 edits in trunk/WebCore

2010-04-05 Leandro Pereira <​leandro@profusion.mobi>

Reviewed by Kenneth Rohde Christiansen.

Add EFL-specific code to platform/Platform*Event.h.
​http://webkit.org/b/36309

  • platform/PlatformWheelEvent.h:
  • platform/PlatformMouseEvent.h:
  • platform/PlatformKeyboardEvent.h:
10:23 PM Changeset in webkit [57123] by oliver@apple.com
  • 2 edits in trunk/JavaScriptCore

Another build fix

10:07 PM Changeset in webkit [57122] by oliver@apple.com
  • 2 edits in trunk/JavaScriptCore

And another build fix.

10:00 PM Changeset in webkit [57121] by oliver@apple.com
  • 2 edits in trunk/JavaScriptCore

Build fix

9:18 PM Changeset in webkit [57120] by oliver@apple.com
  • 4 edits
    3 adds in trunk/JavaScriptCore

2010-04-05 Oliver Hunt <​oliver@apple.com>

Reviewed by Gavin Barraclough.

Support weak maps in JSC
​https://bugs.webkit.org/show_bug.cgi?id=37132

Expose an API to allow creation of a map for storing
weak JS references.

  • API/JSWeakObjectMapRefInternal.h: Added. (OpaqueJSWeakObjectMap::create): (OpaqueJSWeakObjectMap::map): (OpaqueJSWeakObjectMap::~OpaqueJSWeakObjectMap): (OpaqueJSWeakObjectMap::OpaqueJSWeakObjectMap):
  • API/JSWeakObjectMapRefPrivate.cpp: Added.
  • API/JSWeakObjectMapRefPrivate.h: Added.
  • JavaScriptCore.exp:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • runtime/JSGlobalObject.h: (JSC::JSGlobalObject::registerWeakMap): (JSC::JSGlobalObject::deregisterWeakMap):
8:59 PM Changeset in webkit [57119] by hamaji@chromium.org
  • 3 edits in trunk/WebKitTools

2010-04-05 Chris Jerdonek <Chris Jerdonek>

Reviewed by Shinichiro Hamaji.

Fixed check-webkit-style issue where the script was prematurely
exiting when encountering deleted files in patches.

​https://bugs.webkit.org/show_bug.cgi?id=37122

  • Scripts/webkitpy/style/checker.py:
    • Changed non-existent file message from ERROR to WARN.
    • StyleChecker.check_file() no longer raises an exception when a file is not found.
  • Scripts/webkitpy/style/checker_unittest.py:
    • Updated unit tests as necessary.
8:50 PM Changeset in webkit [57118] by eric@webkit.org
  • 5 edits in trunk/WebCore

2010-04-05 Leandro Pereira <​leandro@profusion.mobi>

Reviewed by Kenneth Rohde Christiansen.

Add EFL-specific code to platform/graphics/*.h.
​http://webkit.org/b/36308

  • platform/graphics/Icon.h:
  • platform/graphics/IntRect.h:
  • platform/graphics/FloatRect.h:
  • platform/graphics/IntPoint.h:
8:33 PM Changeset in webkit [57117] by eric@webkit.org
  • 3 edits in trunk/WebCore

2010-04-05 Robert Hogan <​robert@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Fix infinite redirection loop in QNetworkReplyHandler

Put a maximum on consecutive redirections so we don't have to
worry about whether it's the same url or not.

Tolerate up to 10 consecutive redirections, anything beyond
that is considered a potentially infinite recursion in the
redirection requests. This is the same behaviour as Firefox.

​https://bugs.webkit.org/show_bug.cgi?id=37097

  • platform/network/qt/QNetworkReplyHandler.cpp: (WebCore::QNetworkReplyHandler::QNetworkReplyHandler): (WebCore::QNetworkReplyHandler::sendResponseIfNeeded):
  • platform/network/qt/QNetworkReplyHandler.h:
8:08 PM Changeset in webkit [57116] by jamesr@google.com
  • 6 edits
    6 adds in trunk

2010-04-05 Dimitri Glazkov <Dimitri Glazkov> and James Robinson <​jamesr@chromium.org>

Reviewed by Darin Adler and Dimitri Glazkov.

Style update done due to mutation event dispatching in textarea can be
used to corrupt the render tree.
​https://bugs.webkit.org/show_bug.cgi?id=36864

Tests: fast/forms/select-change-listbox-to-popup-roundtrip.html

fast/forms/select-change-popup-to-listbox-roundtrip.html
fast/forms/textarea-and-mutation-events.html

  • dom/Document.cpp: (WebCore::Document::finishedParsing): Added updateStyleIfNeeded()

call to ensure that object loads start before firing window load.

  • dom/Node.cpp: (WebCore::Node::dispatchGenericEvent): Removed invocation of

Document::updateStyleForAllDocuments

  • html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::parseMappedAttribute): Added explicit

recalc to ensure accuracy of representation, especially for
menuList/listBox switches.

2010-04-05 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Darin Adler

Style update done due to mutation event dispatching in textarea can be
used to corrupt the render tree.
​https://bugs.webkit.org/show_bug.cgi?id=36864

Modified listbox-selection.html to correctly set the size during
creation. Otherwise, options added to it as a menuList, resulting
in a default selection of the first item.

Added a few more tests to ensure we capture correct behavior for
select elements and their default selection, as well as the influence
of when layout occurs.

  • fast/forms/listbox-selection.html:
  • fast/forms/select-change-listbox-to-popup-roundtrip.html: Added.
  • fast/forms/select-change-popup-to-listbox-roundtrip.html: Added.
  • fast/forms/textarea-and-mutation-events.html: Added.
8:02 PM Changeset in webkit [57115] by abarth@webkit.org
  • 7 edits in trunk/WebKitTools

2010-04-05 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

SheriffBot should include blamelist when posting to bugs
​https://bugs.webkit.org/show_bug.cgi?id=37113

When posting on bugs, we should include the full list of SVN revisions
that caused the regression to folks have a better sense of whether they
are to blame.

  • Scripts/webkitpy/tool/bot/sheriff.py:
  • Scripts/webkitpy/tool/bot/sheriff_unittest.py:
  • Scripts/webkitpy/tool/commands/sheriffbot.py:
  • Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
  • Scripts/webkitpy/tool/commands/upload_unittest.py:
  • Scripts/webkitpy/tool/mocktool.py:
7:32 PM Changeset in webkit [57114] by Chris Jerdonek
  • 2 edits
    1 delete in trunk/WebKitTools

Unreviewed after discussion with Adam, Darin, and Eric.

Deleted the auto-install directory since it is no longer needed in
source control (it is auto-generated).

Also added webkitpy/thirdparty/autoinstalled to webkitpy/thirdparty's
svn:ignore property.

  • Scripts/webkitpy/thirdparty/autoinstalled: Removed.
7:24 PM Changeset in webkit [57113] by mrowe@apple.com
  • 2 edits in trunk/LayoutTests

Update a test result.

  • platform/mac/editing/inserting/break-blockquote-after-delete-expected.txt:
7:03 PM Changeset in webkit [57112] by tonikitoo@webkit.org
  • 2 edits
    1 add in trunk/WebCore

2010-04-05 Antonio Gomes <​tonikitoo@webkit.org>

Reviewed by Laszlo Gombos.

Cleaned up spatial-navigation-test-cases.html by removing the wrongly
used <frameset> tag. Patch also adds a manual-test specifically to
test Spatial Navigation with framesets.

  • manual-tests/spatial-navigation/frameset.html: Added.
  • manual-tests/spatial-navigation/spatial-navigation-test-cases.html:
6:45 PM Changeset in webkit [57111] by mrowe@apple.com
  • 12 edits
    2 adds in trunk

Test case for <​http://webkit.org/b/37115> / <rdar://problem/7829331>.
REGRESSION(r56989): Crash in Mail in WebCore::Position::isCandidate when deleting block using block deletion UI

Reviewed by Adele Peterson.

WebKit/mac:

  • WebView/WebHTMLView.mm:

(-[WebHTMLView _updateFontPanel]): Ask the window whether it is the key window rather than doing the comparison
manually. This allows DumpRenderTree's override of isKeyWindow to force this code path to be taken during tests.

WebKitTools:

Add a JavaScript hook in DRT to call through to WebView's -setEditable:. This is required in order to reproduce
the crash.

  • DumpRenderTree/LayoutTestController.cpp:

(setWebViewEditableCallback):
(LayoutTestController::staticFunctions):

  • DumpRenderTree/LayoutTestController.h:
  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:

(LayoutTestController::setWebViewEditable):

  • DumpRenderTree/mac/DumpRenderTree.mm:

(resetWebViewToConsistentStateBeforeTesting):

  • DumpRenderTree/mac/LayoutTestControllerMac.mm:

(LayoutTestController::setWebViewEditable):

  • DumpRenderTree/win/LayoutTestControllerWin.cpp:

(LayoutTestController::setWebViewEditable):

  • DumpRenderTree/wx/LayoutTestControllerWx.cpp:

(LayoutTestController::setWebViewEditable):
(LayoutTestController::layerTreeAsText):

LayoutTests:

  • platform/mac/editing/deleting/deletionUI-successful-deletion-expected.txt: Added.
  • platform/mac/editing/deleting/deletionUI-successful-deletion.html: Added.
  • platform/mac/editing/deleting/resources/deletionUI-helpers.js:

(deletionUIDeleteButtonForElement):
(determineDeletionUIExistence):

6:45 PM Changeset in webkit [57110] by mrowe@apple.com
  • 3 edits in trunk/WebCore

Roll out r56989 as it introduced crashes in Mail.
<​http://webkit.org/b/37115> / <rdar://problem/7829331>

Reviewed by Adele Peterson.

  • dom/Position.cpp:

(WebCore::Position::isCandidate):

  • dom/PositionIterator.cpp:

(WebCore::PositionIterator::isCandidate):

6:38 PM Changeset in webkit [57109] by Darin Adler
  • 18 edits
    3 adds in trunk

Images must re-load when an image-holding element moves into a new document
​https://bugs.webkit.org/show_bug.cgi?id=37127

Reviewed by Sam Weinig.

WebCore:

Test: fast/images/move-image-to-new-document.html

  • html/HTMLImageElement.cpp:

(WebCore::HTMLImageElement::willMoveToNewOwnerDocument): Call ImageLoader's
elementWillMoveToNewOwnerDocument function.

  • html/HTMLImageElement.h: Added willMoveToNewOwnerDocument.
  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::willMoveToNewOwnerDocument): Ditto.

  • html/HTMLPlugInImageElement.cpp:

(WebCore::HTMLPlugInImageElement::willMoveToNewOwnerDocument): Ditto.

  • html/HTMLPlugInImageElement.h: Ditto.
  • html/HTMLVideoElement.cpp:

(WebCore::HTMLVideoElement::willMoveToNewOwnerDocument): Ditto.

  • html/HTMLVideoElement.h: Ditto.
  • svg/SVGImageElement.cpp:

(WebCore::SVGImageElement::willMoveToNewOwnerDocument): Ditto.

  • svg/SVGImageElement.h: Ditto.
  • html/HTMLMediaElement.h: Made willMoveToNewOwnerDocument protected

so it can be called by HTMLVideoElement.cpp.

  • loader/ImageLoader.cpp:

(WebCore::ImageLoader::elementWillMoveToNewOwnerDocument): Added.
Resets the loader by clearing out the cached image.

  • loader/ImageLoader.h: Added it.

LayoutTests:

  • fast/images/move-image-to-new-document-expected.txt: Added.
  • fast/images/move-image-to-new-document.html: Added.
  • fast/images/script-tests/move-image-to-new-document.js: Added.
  • fast/js/resources/js-test-post.js: Added a feature for doing asynchronous scripting

tests. The caller sets jsTestIsAsync to true and then calls finishJSTest when done.
Used by the above test.

  • platform/mac/editing/pasteboard/drag-image-to-contenteditable-in-iframe-expected.checksum:
  • platform/mac/editing/pasteboard/drag-image-to-contenteditable-in-iframe-expected.png:
  • platform/mac/editing/pasteboard/drag-image-to-contenteditable-in-iframe-expected.txt:

Updated since the old test result relied on an incorrect load of an image.
The relative URL has a different base when moved into the subframe document.

5:55 PM Changeset in webkit [57108] by eric@webkit.org
  • 4 edits in trunk

2010-04-05 Laszlo Gombos <Laszlo Gombos>

Reviewed by Kenneth Rohde Christiansen.

[Symbian] Consolidate Symbian WINSCW environment configuration
​https://bugs.webkit.org/show_bug.cgi?id=37100

Move the "undefinition" of WIN32 and _WIN32 from WebCore/config.h
to JavaScriptCore/wtf/Platform.h as it is not specific to WebCore.

PLATFORM(WIN) and OS(WIN) no longer needs to be undefined as
undefining WIN32 takes care of it.

  • wtf/Platform.h:

2010-04-05 Laszlo Gombos <Laszlo Gombos>

Reviewed by Kenneth Rohde Christiansen.

[Symbian] Consolidate Symbian WINSCW environment configuration
​https://bugs.webkit.org/show_bug.cgi?id=37100

Move the "undefinition" of WIN32 and _WIN32 from WebCore/config.h
to JavaScriptCore/wtf/Platform.h as it is not specific to WebCore.

No new tests as there is no new functionality.

  • config.h:
5:34 PM Changeset in webkit [57107] by eric@webkit.org
  • 1 edit
    1 add in trunk/WebCore

2010-04-05 Leandro Pereira <​leandro@profusion.mobi>

Reviewed by Kenneth Rohde Christiansen.

Add missing ClipboardEfl.h to platform/efl.
​http://webkit.org/b/36242

  • platform/efl/ClipboardEfl.h: Added.
5:18 PM Changeset in webkit [57106] by eric@webkit.org
  • 7 edits in trunk/LayoutTests

2010-04-05 Zhenyao Mo <​zmo@google.com>

Reviewed by Darin Adler.

A few tests in fast/canvas/webgl/ failed on Leopard Release Bot randomly.
​https://bugs.webkit.org/show_bug.cgi?id=37077
​https://bugs.webkit.org/show_bug.cgi?id=37098

  • fast/canvas/webgl/drawArraysOutOfBounds-expected.txt: Gathering more information about framebuffer status when failure happens.
  • fast/canvas/webgl/drawArraysOutOfBounds.html: Ditto.
  • fast/canvas/webgl/drawElementssOutOfBounds-expected.txt: Ditto.
  • fast/canvas/webgl/drawElementssOutOfBounds.html: Ditto.
  • fast/canvas/webgl/index-validation-copies-indices-expected.txt: Ditto.
  • fast/canvas/webgl/index-validation-copies-indices.html: Ditto.
5:08 PM Changeset in webkit [57105] by eric@webkit.org
  • 7 edits
    3 adds in trunk

2010-04-05 Yuta Kitamura <​yutak@chromium.org>

Reviewed by Darin Adler.

Escape control characters in CSS string value when it is serialilzed.

When WebKit serializes a CSS string value that contains binary characters
('\0\1\2' for example), it did not escape these characters. As a result,
users got (invisible) control characters through scripts. This change fixes
this issue.

As a side effect, two separate codes for escaping CSS strings are merged, and
become a public function (quoteCSSString).

CSS string value is not correctly serialized when it contains binary characters
​https://bugs.webkit.org/show_bug.cgi?id=28938

  • fast/css/script-tests/string-quote-binary.js: Added.
  • fast/css/string-quote-binary-expected.txt: Added.
  • fast/css/string-quote-binary.html: Added.
  • fast/js/resources/js-test-pre.js: (shouldBeEqualToString): Considering the case when the argument contains binary characters.

2010-04-05 Yuta Kitamura <​yutak@chromium.org>

Reviewed by Darin Adler.

Escape control characters in CSS string value when it is serialilzed.

When WebKit serializes a CSS string value that contains binary characters
('\0\1\2' for example), it did not escape these characters. As a result,
users got (invisible) control characters through scripts. This change fixes
this issue.

As a side effect, two separate codes for escaping CSS strings are merged, and
become a public function (quoteCSSString).

CSS string value is not correctly serialized when it contains binary characters
​https://bugs.webkit.org/show_bug.cgi?id=28938

Test: fast/css/string-quote-binary.html

  • css/CSSParser.cpp: (WebCore::isCSSTokenizerIdentifier): (WebCore::isCSSTokenizerURL): (WebCore::quoteCSSString): (WebCore::quoteCSSStringIfNeeded): (WebCore::quoteCSSURLIfNeeded):
  • css/CSSParser.h:
  • css/CSSPrimitiveValue.cpp: (WebCore::CSSPrimitiveValue::cssText):
  • css/FontFamilyValue.cpp: (WebCore::FontFamilyValue::cssText):
5:06 PM Changeset in webkit [57104] by Darin Adler
  • 2 edits in trunk/SunSpider

Updated the ignore property for changes to the contents here.

  • .: Modified property svn:ignore.
4:54 PM Changeset in webkit [57103] by eric@webkit.org
  • 3 edits
    2 adds in trunk

2010-04-05 John Gregg <​johnnyg@google.com>

Reviewed by Darin Adler.

Notifications should not resolve an empty icon parameter as a relative URL
​https://bugs.webkit.org/show_bug.cgi?id=36862

  • fast/notifications/notifications-no-icon-expected.txt: Added.
  • fast/notifications/notifications-no-icon.html-disabled: Added.

2010-04-05 John Gregg <​johnnyg@google.com>

Reviewed by Darin Adler.

Notifications should not resolve an empty icon parameter as a relative URL
​https://bugs.webkit.org/show_bug.cgi?id=36862

  • notifications/Notification.cpp: (WebCore::Notification::Notification):
4:40 PM Changeset in webkit [57102] by Darin Adler
  • 10 edits in trunk/WebKitTools

Ignore more files the Python tools strew about the working directory.

  • Scripts/webkitpy: Added property svn:ignore.
  • Scripts/webkitpy/common: Added property svn:ignore.
  • Scripts/webkitpy/common/checkout: Added property svn:ignore.
  • Scripts/webkitpy/common/config: Added property svn:ignore.
  • Scripts/webkitpy/common/net: Added property svn:ignore.
  • Scripts/webkitpy/common/thread: Added property svn:ignore.
  • Scripts/webkitpy/python24: Added property svn:ignore.
  • Scripts/webkitpy/thirdparty/autoinstalled: Modified property svn:ignore.
  • Scripts/webkitpy/tool/bot: Added property svn:ignore.
4:19 PM Changeset in webkit [57101] by Darin Adler
  • 5 edits in trunk/WebCore

Removed some unneeded type casts.

Reviewed by Mark Rowe.

  • css/CSSPrimitiveValue.cpp:

(WebCore::CSSPrimitiveValue::cssText): Removed an unneeded cast.

  • page/Location.cpp:

(WebCore::Location::host): Removed unneeded parentheses and cast.
(WebCore::Location::port): Ditto.

  • platform/KURLGoogle.cpp:

(WebCore::KURL::setPort): Ditto.

  • workers/WorkerLocation.cpp:

(WebCore::WorkerLocation::host): Ditto.
(WebCore::WorkerLocation::port): Ditto.

4:07 PM Changeset in webkit [57100] by abarth@webkit.org
  • 5 edits
    6 deletes in trunk

2010-04-05 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r57081.
​http://trac.webkit.org/changeset/57081
​https://bugs.webkit.org/show_bug.cgi?id=37121

We think it triggered two tests to fail on Tiger because of
race conditions (Requested by abarth on #webkit).

  • fast/forms/listbox-selection.html:
  • fast/forms/select-change-listbox-to-popup-roundtrip-expected.txt: Removed.
  • fast/forms/select-change-listbox-to-popup-roundtrip.html: Removed.
  • fast/forms/select-change-popup-to-listbox-roundtrip-expected.txt: Removed.
  • fast/forms/select-change-popup-to-listbox-roundtrip.html: Removed.
  • fast/forms/textarea-and-mutation-events-expected.txt: Removed.
  • fast/forms/textarea-and-mutation-events.html: Removed.

2010-04-05 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r57081.
​http://trac.webkit.org/changeset/57081
​https://bugs.webkit.org/show_bug.cgi?id=37121

We think it triggered two tests to fail on Tiger because of
race conditions (Requested by abarth on #webkit).

  • dom/Node.cpp: (WebCore::Node::dispatchGenericEvent):
  • html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::parseMappedAttribute):
3:57 PM Changeset in webkit [57099] by beidson@apple.com
  • 2 edits in trunk/WebCore

ASSERT close()ing the same StorageAreaImpl twice when using multiple PageGroups
<rdar://problem/7828420> and ​https://bugs.webkit.org/show_bug.cgi?id=37120

Reviewed by Oliver Hunt.

No new tests. (No behavior change)

  • storage/StorageNamespaceImpl.cpp:

(WebCore::StorageNamespaceImpl::close): Change this invalid ASSERT to an early return.

3:39 PM Changeset in webkit [57098] by ap@apple.com
  • 3 edits in trunk/LayoutTests

Updated expected pixel results for missing plug-in, now using text placeholder.

  • platform/mac/plugins/qt-qwidget-plugin-expected.checksum:
  • platform/mac/plugins/qt-qwidget-plugin-expected.png:
3:03 PM Changeset in webkit [57097] by yael.aharon@nokia.com
  • 1 edit
    5 adds in trunk/LayoutTests

Unreviewed.
Separate test results for windows platform because progress element is not implemented for that platform yet.

  • platform/win/fast/dom/Window/window-property-descriptors-expected.txt: Added.
  • platform/win/fast/dom/prototype-inheritance-2-expected.txt: Added.
  • platform/win/fast/dom/prototype-inheritance-expected.txt: Added.
  • platform/win/fast/js: Added.
  • platform/win/fast/js/global-constructors-expected.txt: Added.
2:52 PM Changeset in webkit [57096] by abarth@webkit.org
  • 3 edits in trunk/WebCore

2010-04-05 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r57030.
​http://trac.webkit.org/changeset/57030
​https://bugs.webkit.org/show_bug.cgi?id=37114

Regressed fast/repaint/line-flow-with-floats-9 pixel tests in
chromium port (Requested by jamesr on #webkit).

  • rendering/RenderBlock.h:
  • rendering/RenderBlockLineLayout.cpp: (WebCore::RenderBlock::layoutInlineChildren):
2:49 PM Changeset in webkit [57095] by ap@apple.com
  • 22 edits in trunk

Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=37111
<rdar://problem/7790327> Draw replacement text when plug-in host crashes

2:16 PM Changeset in webkit [57094] by Chris Fleizach
  • 2 edits in trunk/LayoutTests

Unreviewed.

Bug 37112 - aria-liveregion-notifications.html fails on leopard release bot
​https://bugs.webkit.org/show_bug.cgi?id=37112

Disabling this test on Leopard until further investigation can reveal the answer.
It looks like at this point, any new test added will cause this test to fail on Leopard
release bot, even if it has nothing to do with live regions.

  • platform/mac-leopard/Skipped:
1:41 PM Changeset in webkit [57093] by Chris Fleizach
  • 8 edits
    2 adds in trunk

WebCore: Bug 37040 - AX: need to send selected children change notification when aria-selected changed
​https://bugs.webkit.org/show_bug.cgi?id=37040

Reviewed by Darin Adler.

When aria-selected is changed in the DOM, it will trigger a selected children change notification.

Test: platform/mac/accessibility/aria-listbox-selectedchildren-change.html

  • accessibility/AXObjectCache.cpp:

(WebCore::AXObjectCache::selectedChildrenChanged):

  • accessibility/AXObjectCache.h:
  • accessibility/AccessibilityMediaControls.cpp:

(WebCore::AccessibilityMediaControl::controlType):

Remove extra whitespace before comment (webkit-style).

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::observableObject):

Allowed a listBox to be an observable object.

(WebCore::AccessibilityRenderObject::ariaRoleHasPresentationalChildren):
(WebCore::AccessibilityRenderObject::ariaListboxSelectedChildren):

Updated and streamlined existing code.

  • dom/Element.cpp:

(WebCore::Element::updateAfterAttributeChanged):

LayoutTests: Tests for
Bug 37040 - AX: need to send selected children change notification when aria-selected changed
​https://bugs.webkit.org/show_bug.cgi?id=37040

Reviewed by Darin Adler.

  • platform/mac/accessibility/aria-listbox-selectedchildren-change-expected.txt: Added.
  • platform/mac/accessibility/aria-listbox-selectedchildren-change.html: Added.
1:38 PM Changeset in webkit [57092] by yael.aharon@nokia.com
  • 1 edit
    4 adds in trunk/LayoutTests

Unreviewed.
Separate test results for gtk platform because progress element is not implemented for that platform yet.

  • platform/gtk/fast/dom/Window/window-property-descriptors-expected.txt: Added.
  • platform/gtk/fast/dom/prototype-inheritance-expected.txt: Added.
  • platform/gtk/fast/js: Added.
  • platform/gtk/fast/js/global-constructors-expected.txt: Added.
12:55 PM Changeset in webkit [57091] by ojan@chromium.org
  • 6 edits in trunk/WebKitTools

2010-04-05 Adam Barth <​abarth@webkit.org>

Unreviewed. Add Vitaly Repeshko as a committer.

  • Scripts/webkitpy/common/config/committers.py:
12:33 PM Changeset in webkit [57090] by abarth@webkit.org
  • 2 edits in trunk/WebKitTools

2010-04-05 Adam Barth <​abarth@webkit.org>

Unreviewed. Add Vitaly Repeshko as a committer.

  • Scripts/webkitpy/common/config/committers.py:
12:27 PM Changeset in webkit [57089] by treat@webkit.org
  • 2 edits in trunk/WebCore

Fix regression in pixel test for animated svg background images.

Patch by Adam Treat <​atreat@rim.com> on 2010-04-05
Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=37027

  • svg/graphics/SVGImage.cpp:

(WebCore::SVGImageChromeClient::invalidateContentsAndWindow):

11:30 AM Changeset in webkit [57088] by abarth@webkit.org
  • 2 edits in trunk/WebKitTools

2010-04-05 Adam Barth <​abarth@webkit.org>

Unreviewed. Update kenne's IRC nick to his registered nick.

  • Scripts/webkitpy/common/config/committers.py:
11:27 AM Changeset in webkit [57087] by abarth@webkit.org
  • 6 edits in trunk/LayoutTests

2010-04-05 Adam Barth <​abarth@webkit.org>

Unreviewed.

Update expected results for addition of HTMLProgressElement. We didn't
see these errors until later because our dependencies are screwed up.

  • fast/dom/Window/window-properties-expected.txt:
  • fast/dom/Window/window-property-descriptors-expected.txt:
  • fast/dom/prototype-inheritance-2-expected.txt:
  • fast/dom/prototype-inheritance-expected.txt:
  • fast/js/global-constructors-expected.txt:
11:24 AM Changeset in webkit [57086] by kenneth@webkit.org
  • 5 edits in trunk/LayoutTests

Unreviewed layout test fix.

Update mac results for iframe flattening.

  • platform/mac/fast/frames/flattening/iframe-flattening-fixed-height-expected.txt:
  • platform/mac/fast/frames/flattening/iframe-flattening-fixed-width-and-height-expected.txt:
  • platform/mac/fast/frames/flattening/iframe-flattening-fixed-width-expected.txt:
  • platform/mac/fast/frames/flattening/iframe-flattening-simple-expected.txt:
11:16 AM WebKit Team edited by abarth@webkit.org
(diff)
10:57 AM Changeset in webkit [57085] by robert@webkit.org
  • 4 edits in trunk

2010-04-05 Robert Hogan <​robert@webkit.org>

Reviewed by Kenneth Rohde-Christiansen.

[Qt] Fix infinite redirection loop in QNetworkReplyHandler

Qt enters an infinite loop if a redirect response redirects to itself.

Fixes http/tests/xmlhttprequest/connection-error-sync.html

​https://bugs.webkit.org/show_bug.cgi?id=37097

  • platform/network/qt/QNetworkReplyHandler.cpp: (WebCore::QNetworkReplyHandler::sendResponseIfNeeded):

2010-04-05 Robert Hogan <​robert@webkit.org>

Reviewed by Kenneth Rohde-Christiansen.

[Qt] Fix infinite redirection loop in QNetworkReplyHandler

Unskip http/tests/xmlhttprequest/connection-error-sync.html

​https://bugs.webkit.org/show_bug.cgi?id=37097

  • platform/qt/Skipped:
10:55 AM Changeset in webkit [57084] by ojan@chromium.org
  • 2 edits in trunk/WebKitTools

2010-04-05 Ojan Vafai <​ojan@chromium.org>

Reviewed by Eric Seidel.

prepare-ChangeLog should take a merge-base for which git branch to diff against.
​https://bugs.webkit.org/show_bug.cgi?id=36394

  • Scripts/prepare-ChangeLog:
10:36 AM Changeset in webkit [57083] by kenneth@webkit.org
  • 5 edits in trunk/LayoutTests

Unreviewed layout test fix.

Update Qt results for iframe flattening.

  • platform/qt/fast/frames/flattening/iframe-flattening-fixed-height-expected.txt:
  • platform/qt/fast/frames/flattening/iframe-flattening-fixed-width-and-height-expected.txt:
  • platform/qt/fast/frames/flattening/iframe-flattening-fixed-width-expected.txt:
  • platform/qt/fast/frames/flattening/iframe-flattening-simple-expected.txt:
10:35 AM Changeset in webkit [57082] by yurys@chromium.org
  • 19 edits
    4 deletes in trunk

2010-04-05 Yury Semikhatsky <​yurys@chromium.org>

Unreviewed, revert r57078.

10:27 AM Changeset in webkit [57081] by Dimitri Glazkov
  • 5 edits
    6 adds in trunk

2010-04-05 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Darin Adler.

Style update done due to mutation event dispatching in textarea can be
used to corrupt the render tree.
​https://bugs.webkit.org/show_bug.cgi?id=36864

Modified listbox-selection.html to correctly set the size during
creation. Otherwise, options added to it as a menuList, resulting
in a default selection of the first item.

Added a few more tests to ensure we capture correct behavior for
select elements and their default selection, as well as the influence
of when layout occurs.

  • fast/forms/listbox-selection.html:
  • fast/forms/select-change-listbox-to-popup-roundtrip.html: Added.
  • fast/forms/select-change-popup-to-listbox-roundtrip.html: Added.
  • fast/forms/textarea-and-mutation-events.html: Added.

2010-04-05 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Darin Adler.

Style update done due to mutation event dispatching in textarea can be
used to corrupt the render tree.
​https://bugs.webkit.org/show_bug.cgi?id=36864

Tests: fast/forms/select-change-listbox-to-popup-roundtrip.html

fast/forms/select-change-popup-to-listbox-roundtrip.html
fast/forms/textarea-and-mutation-events.html

  • dom/Node.cpp: (WebCore::Node::dispatchGenericEvent): Removed invocation of

Document::updateStyleForAllDocuments

  • html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::parseMappedAttribute): Added explicit

recalc to ensure accuracy of representation, especially for
menuList/listBox switches.

10:18 AM Changeset in webkit [57080] by kenneth@webkit.org
  • 4 edits in trunk/WebCore

iframe flattening doesn't flatten
​https://bugs.webkit.org/show_bug.cgi?id=36798

Reviewed by Dave Hyatt.

Fixed to the iframe flattening code so that the iframes on
​http://www.samisite.com/test-csb2nf/id43.htm are actually
flattened.

Covered by current tests.

  • page/FrameView.cpp: Propagate contents changes of iframes

and subframes in framesets to the parent so that it is relayouted
(WebCore::FrameView::setContentsSize):
(WebCore::FrameView::adjustViewSize):
(WebCore::FrameView::scheduleRelayout):

  • rendering/RenderPart.cpp: HTMLIFrameElement do not inherit from

HTMLFrameElement, but HTMLFrameElementBase, correct cast. Correct
the use of inset border values. Avoid a sometimes unnecessary
relayout.
(WebCore::RenderPart::layoutWithFlattening):

  • rendering/RenderPartObject.cpp: Make the calcHeight and calcWidth

return the right values, considering scrolling and fixed width/height
(WebCore::RenderPartObject::flattenFrame):
(WebCore::RenderPartObject::calcHeight):
(WebCore::RenderPartObject::calcWidth):
(WebCore::RenderPartObject::layout):

10:06 AM Changeset in webkit [57079] by vitalyr@chromium.org
  • 2 edits in trunk/WebCore

2010-04-05 Vitaly Repeshko <​vitalyr@chromium.org>

Reviewed by Yury Semikhatsky.

[V8] Extend the set of types supported by SerializedScriptValue
​https://bugs.webkit.org/show_bug.cgi?id=37052

New types include sparse arrays, Uint32, Date, and ImageData.

Serialization process became more flexible. A state can either
directly write primitive values (instead of returning them like
iterator) or construct a new state for serializing complex values
that will return to the current state when done.

Deserialization process now avoids exposing the tags using a set
of factory functions for complex objects instead.

Internal buffer type changed to uint8_t to be independent of
whether char is signed or not.

  • bindings/v8/SerializedScriptValue.cpp: (WebCore::): (WebCore::Writer::Writer): (WebCore::Writer::writeString): (WebCore::Writer::writeUint32): (WebCore::Writer::writeDate): (WebCore::Writer::writeNumber): (WebCore::Writer::writeImageData): (WebCore::Writer::writeArray): (WebCore::Writer::writeObject): (WebCore::Writer::writeSparseArray): (WebCore::Writer::doWriteUint32): (WebCore::Writer::doWriteNumber): (WebCore::Writer::append): (WebCore::Writer::fillHole): (WebCore::Writer::byteAt): (WebCore::Serializer::Serializer): (WebCore::Serializer::serialize): (WebCore::Serializer::writeArray): (WebCore::Serializer::writeObject): (WebCore::Serializer::writeSparseArray): (WebCore::Serializer::StateBase::StateBase): (WebCore::Serializer::ErrorState::ErrorState): (WebCore::Serializer::ErrorState::advance): (WebCore::Serializer::State::composite): (WebCore::Serializer::State::State): (WebCore::Serializer::ArrayState::ArrayState): (WebCore::Serializer::ArrayState::advance): (WebCore::Serializer::AbstractObjectState::AbstractObjectState): (WebCore::Serializer::AbstractObjectState::advance): (WebCore::Serializer::ObjectState::ObjectState): (WebCore::Serializer::ObjectState::objectDone): (WebCore::Serializer::SparseArrayState::SparseArrayState): (WebCore::Serializer::SparseArrayState::objectDone): (WebCore::Serializer::push): (WebCore::Serializer::pop): (WebCore::Serializer::handleError): (WebCore::Serializer::checkComposite): (WebCore::Serializer::writeString): (WebCore::Serializer::writeImageData): (WebCore::Serializer::newArrayState): (WebCore::Serializer::newObjectState): (WebCore::Serializer::doSerialize): (WebCore::Reader::Reader): (WebCore::Reader::read): (WebCore::Reader::readString): (WebCore::Reader::readUint32): (WebCore::Reader::readDate): (WebCore::Reader::readNumber): (WebCore::Reader::readImageData): (WebCore::Reader::doReadUint32): (WebCore::Reader::doReadNumber): (WebCore::Deserializer::Deserializer): (WebCore::Deserializer::createArray): (WebCore::Deserializer::createObject): (WebCore::Deserializer::createSparseArray): (WebCore::Deserializer::initializeObject): (WebCore::Deserializer::doDeserialize): (WebCore::Deserializer::stackDepth): (WebCore::SerializedScriptValue::deserialize):
10:00 AM Changeset in webkit [57078] by yurys@chromium.org
  • 19 edits
    3 copies
    1 add in trunk

2010-04-05 Yury Semikhatsky <​yurys@chromium.org>

Reviewed by Pavel Feldman.

Refactored error reporting mechanizm on Worker Global Objects.
Unlike other event listeners which accept single argument(Event)
onerror handler on worker global object should be a function
accepting three arguments. This error reporting was implementedas
EventListener::reportError method which had custom implementations
for v8 and JSC. This patch removes EventListener::reportError and
moves its functionality into custom bindings(V8WorkerContextErrorHandler
and JSWorkerContextErrorHandler) that implement EventListener inerface
for the onerror handler.

This patch also makes uncaught exceptions that happen in the onerror
listener be reported to the Worker's onerror handler.

​https://bugs.webkit.org/show_bug.cgi?id=36375

  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSEventListener.cpp:
  • bindings/js/JSEventListener.h:
  • bindings/js/JSWorkerContextErrorHandler.cpp: Added. (WebCore::JSWorkerContextErrorHandler::JSWorkerContextErrorHandler): (WebCore::JSWorkerContextErrorHandler::~JSWorkerContextErrorHandler): (WebCore::JSWorkerContextErrorHandler::handleEvent):
  • bindings/js/JSWorkerContextErrorHandler.h: Added. (WebCore::JSWorkerContextErrorHandler::create): (WebCore::createJSWorkerContextErrorHandler):
  • bindings/scripts/CodeGeneratorJS.pm:
  • bindings/scripts/CodeGeneratorV8.pm:
  • bindings/v8/V8WorkerContextErrorHandler.cpp: Added. (WebCore::V8WorkerContextErrorHandler::V8WorkerContextErrorHandler): (WebCore::V8WorkerContextErrorHandler::callListenerFunction):
  • bindings/v8/V8WorkerContextErrorHandler.h: Added. (WebCore::V8WorkerContextErrorHandler::create):
  • bindings/v8/V8WorkerContextEventListener.cpp:
  • bindings/v8/V8WorkerContextEventListener.h:
  • dom/EventListener.h: Removed reportError method that was used only for reporting worker errors.
  • workers/WorkerContext.cpp: (WebCore::WorkerContext::WorkerContext): (WebCore::WorkerContext::reportException):

2010-04-05 Yury Semikhatsky <​yurys@chromium.org>

Reviewed by Pavel Feldman.

Test that exception which occurs in onerror handler is reported to the Worker object.

​https://bugs.webkit.org/show_bug.cgi?id=36375

  • fast/workers/worker-script-error-expected.txt:
  • fast/workers/worker-script-error.html:
  • workers/WorkerContext.h:
8:53 AM Changeset in webkit [57077] by tonikitoo@webkit.org
  • 3 edits in trunk/WebCore

Fix some "explicit braces to avoid ambiguous 'else'" warnings
​https://bugs.webkit.org/show_bug.cgi?id=37088

Reviewed by Darin Adler.
Patch by Antonio Gomes (​tonikitoo@webkit.org)

  • dom/Node.cpp:

(WebCore::Node::dispatchGenericEvent):

  • page/DOMWindow.cpp:

(WebCore::DOMWindow::dispatchEvent):

7:28 AM Changeset in webkit [57076] by Laszlo Gombos
  • 2 edits in trunk/WebCore

2010-04-05 Laszlo Gombos <Laszlo Gombos>

Reviewed by Kenneth Rohde Christiansen.

Consolidate the definition of SKIP_STATIC_CONSTRUCTORS_ON_GCC

Instead of defining and undefining it later, let's not
define SKIP_STATIC_CONSTRUCTORS_ON_GCC for WINSCW.

No new tests as there is no new functionality.

  • config.h:
7:12 AM Changeset in webkit [57075] by robert@webkit.org
  • 2 edits in trunk/LayoutTests

2010-04-05 Robert Hogan <​robert@webkit.org>

Rubber-stamped by Kenneth-Rohde Christiansen.

re-login.html and re-login-async.html are now tracked in bugzilla.

​https://bugs.webkit.org/show_bug.cgi?id=37084

  • platform/qt/Skipped:
6:47 AM Changeset in webkit [57074] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-04-05 Laszlo Gombos <Laszlo Gombos>

Reviewed by Kenneth Rohde Christiansen.

[Qt] [Symbian] Remove obsolete build flags for Symbian
​https://bugs.webkit.org/show_bug.cgi?id=37083

Symbian port of QtWebKit port does not use icu, so it does
not need U_HAVE_* defines.

Symbian now has inttypes.h as part of OpenC.

stdio.h, limits.h and MathExtras.h are already included in
more appropriate locations.

No new tests as there is no new functionality.

  • config.h:
5:48 AM Changeset in webkit [57073] by pfeldman@chromium.org
  • 2 edits in trunk/WebCore

2010-04-05 Pavel Feldman <​pfeldman@chromium.org>

Not reviewed: chromium build fix.

  • bindings/v8/custom/V8InspectorFrontendHostCustom.cpp: (WebCore::V8InspectorFrontendHost::platformCallback): (WebCore::V8InspectorFrontendHost::portCallback):
5:48 AM Changeset in webkit [57072] by kov@webkit.org
  • 1 edit
    1 add in trunk/WebKit/gtk/po

2010-04-05 Lucas Lommer <​llommer@svn.gnome.org>

Reviewed by Gustavo Noronha.

Czech translation for WebKitGtk
​https://bugs.webkit.org/show_bug.cgi?id=36879

  • cs.po: Added.
5:44 AM Changeset in webkit [57071] by kov@webkit.org
  • 2 edits in trunk/WebKit/gtk/po

2010-04-05 Christian Kirbach <​Christian.Kirbach@googlemail.com>

Reviewed by Gustavo Noronha.

Updated German translation
​https://bugs.webkit.org/show_bug.cgi?id=36453

  • de.po:
5:38 AM Changeset in webkit [57070] by kov@webkit.org
  • 2 edits in trunk/WebKit/gtk/po

2010-04-05 Luca Ferretti <​elle.uca@libero.it>

Reviewed by Gustavo Noronha.

Italian translation for 1.1.90
​https://bugs.webkit.org/show_bug.cgi?id=36323

  • it.po:
5:37 AM Changeset in webkit [57069] by pfeldman@chromium.org
  • 6 edits in trunk/WebCore

2010-04-05 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: [REGRESSION] platform detection in Chromium
has regressed to unknown.

​https://bugs.webkit.org/show_bug.cgi?id=37081

  • bindings/js/JSInspectorFrontendHostCustom.cpp: (WebCore::JSInspectorFrontendHost::platform): (WebCore::JSInspectorFrontendHost::port):
  • bindings/v8/custom/V8InspectorFrontendHostCustom.cpp: (WebCore::V8InspectorFrontendHost::platform): (WebCore::V8InspectorFrontendHost::port):
  • inspector/InspectorFrontendHost.cpp:
  • inspector/InspectorFrontendHost.h:
  • inspector/InspectorFrontendHost.idl:
4:59 AM Changeset in webkit [57068] by eric@webkit.org
  • 8 edits in trunk/WebCore

2010-04-05 Andrey Kosyakov <​caseq@chromium.org>

Reviewed by Yury Semikhatsky.

Remove logging of successful XHR and worker's importScript()
to inspector console
​https://bugs.webkit.org/show_bug.cgi?id=37078

  • bindings/js/JSWorkerContextCustom.cpp: (WebCore::JSWorkerContext::importScripts):
  • bindings/v8/custom/V8WorkerContextCustom.cpp: (WebCore::V8WorkerContext::importScriptsCallback):
  • workers/DedicatedWorkerContext.cpp: (WebCore::DedicatedWorkerContext::importScripts):
  • workers/DedicatedWorkerContext.h:
  • workers/WorkerContext.cpp: (WebCore::WorkerContext::importScripts):
  • workers/WorkerContext.h:
  • xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::didFinishLoading):
2:27 AM Changeset in webkit [57067] by pfeldman@chromium.org
  • 2 edits in trunk/LayoutTests

2010-04-05 Pavel Feldman <​pfeldman@chromium.org>

Not reviewed: chromium test expectations update for the roll.

  • platform/chromium/test_expectations.txt:
12:41 AM Changeset in webkit [57066] by eric@webkit.org
  • 5 edits in trunk/WebKitTools

2010-04-05 Chris Jerdonek <Chris Jerdonek>

Reviewed by Shinichiro Hamaji.

Removed the PatchStyleErrorHandler class and incorporated its
functionality into the DefaultStyleErrorHandler class.

​https://bugs.webkit.org/show_bug.cgi?id=37067

  • Scripts/webkitpy/style/checker.py:
    • In the StyleChecker class:
      • Added a line_number parameter to the check_file() method.
      • Renamed the handle_style_error parameter to mock_handle_style_error to be consistent with the other mock_* parameter names.
      • Added a mock_check_file parameter to the check_patch() method to facilitate unit testing the changes in this patch.
      • Rewrote the check_patch() method with the patch-parsing logic taken from the PatchStyleErrorHandler class.
  • Scripts/webkitpy/style/checker_unittest.py:
    • Added a StyleCheckerCheckFileBase class and sub-classed the existing StyleCheckerCheckFileTest class from it.
    • Added a StyleCheckerCheckPatchTest class to unit-test the rewritten check_patch() method.
    • Removed the vestigial main code at the bottom of the file. This is left over from when check-webkit-style was implemented as a module and a wrapper module.
  • Scripts/webkitpy/style/error_handlers.py:
    • Added an optional line_numbers parameter to the DefaultStyleErrorHandler class constructor and adjusted the call() method as necessary.
    • Removed the PatchStyleErrorHandler class.
  • Scripts/webkitpy/style/error_handlers_unittest.py:
    • Removed the PatchStyleErrorHandlerTest class which unit-tested the PatchStyleErrorHandler class which is being removed in this patch.
    • Added a test_line_numbers() test method to the DefaultStyleErrorHandlerTest class to test use of the DefaultStyleErrorHandler's new line_numbers attribute.
12:24 AM Changeset in webkit [57065] by abarth@webkit.org
  • 4 edits in trunk/WebKitTools

2010-04-05 Adam Barth <​abarth@webkit.org>

Unreviewed.

Tighten SheriffBot's flaky test detector
​https://bugs.webkit.org/show_bug.cgi?id=37063

Instead of just looking for two sequential red builds, look for two
sequential failures of the same test. This should reduce sheriffbot
false positive substantially.

I'm landing this change unreviewed because I've noticed SheriffBot
triggering a lot more false positives now that we've expanded the set
of core builders. I've tried to take Eric's comments on Bug 37063 into
account. I'm happy to iterate on this patch tomorrow once Eric wakes
up.

  • Scripts/webkitpy/common/net/buildbot.py:
  • Scripts/webkitpy/common/net/buildbot_unittest.py:
  • Scripts/webkitpy/tool/commands/queries.py:

Apr 4, 2010:

11:30 PM Changeset in webkit [57064] by pfeldman@chromium.org
  • 9 edits
    1 move
    1 delete in trunk

2010-04-04 Pavel Feldman <​pfeldman@chromium.org>

Not reviewed. Rolling out chromium changes r57028 and r57032
for breaking chromium layout tests.

  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:
  • platform/chromium/DragImageChromium.cpp: Added. (WebCore::dragImageSize): (WebCore::deleteDragImage): (WebCore::scaleDragImage): (WebCore::dissolveDragImageToFraction): (WebCore::createDragImageFromImage): (WebCore::createDragImageIconForCachedImage):
  • platform/chromium/DragImageChromiumMac.cpp: Removed.
  • platform/chromium/DragImageChromiumSkia.cpp: Removed.
  • platform/chromium/DragImageRef.h:


WebKit/chromium:

  • public/WebViewClient.h: (WebKit::WebViewClient::startDragging):
  • src/DragClientImpl.cpp: (WebKit::DragClientImpl::startDrag):
  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::startDragging):
  • src/WebViewImpl.h:
7:28 PM Changeset in webkit [57063] by johnnyg@google.com
  • 2 edits in trunk/WebKitTools

2010-04-04 John Gregg <​johnnyg@google.com>

Unreviewed, add myself to the committers list.

  • Scripts/webkitpy/common/config/committers.py:
7:11 PM Changeset in webkit [57062] by tonikitoo@webkit.org
  • 3 edits in trunk/LayoutTests

Unreviewed expected results fix.
Patch by Antonio Gomes <​tonikitoo@webkit.org>

The implementation was fixed, and results were no longer valid.

  • fast/events/spatial-navigation/snav-iframe-no-scrollable-content-expected.txt:
  • fast/events/spatial-navigation/snav-iframe-no-scrollable-content.html:
7:10 PM Changeset in webkit [57061] by tonikitoo@webkit.org
  • 6 edits in trunk/WebCore

2010-03-29 Antonio Gomes <​tonikitoo@webkit.org>

Reviewed by Simon Fraser.
Patch by Antonio Gomes <​tonikitoo@webkit.org>

Spatial Navigation: Initial code simplification in FocusController.cpp and SpatialNavigation.cpp

WebCore::distanceInDirection method was handling much of the logic not
strictly only related to the distance between nodes acquisition. This
method was simplified and renamed to 'WebCore::distanceDataForNode'.
The latter is now responsible for only getting the distance and alignment
data, while all assignement logic previously in distanceInDirection method
was moved place to updateFocusCandidateIfCloser.

Parent document distance and alignment acquisitions, in turn, have also
changed location: they are both got from deepFindFocusableNodeInDirection,
and passed in a recursive call to findFocusableNodeInDirection via the
candidateParent variable (optional parameter). In addition, the need for
the 'focusCandidateCopy' variable in deepFindFocusableNodeInDirection method
was removed, making the code much cleaner.

No behaviour change at this point. Mostly moving code around to the place
where it should live in.

  • page/FocusController.cpp: (WebCore::FocusController::advanceFocusDirectionally): (WebCore::updateFocusCandidateIfCloser): (WebCore::FocusController::findFocusableNodeInDirection): (WebCore::FocusController::deepFindFocusableNodeInDirection):
  • page/FocusController.h:
  • page/SpatialNavigation.cpp: (WebCore::distanceDataForNode): (WebCore::renderRectRelativeToRootDocument):
  • page/SpatialNavigation.
3:18 PM Changeset in webkit [57060] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-04-04 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: In the inherited styles, do not render non-inherited properties as overriden.

​https://bugs.webkit.org/show_bug.cgi?id=37072

  • inspector/front-end/StylesSidebarPane.js: (WebInspector.StylePropertiesSection.prototype.isPropertyOverloaded):
3:00 PM Changeset in webkit [57059] by pfeldman@chromium.org
  • 1 edit
    21 adds in trunk/WebKitSite

2010-04-04 Pavel Feldman <​pfeldman@chromium.org>

(Not reviewed).

Adding images for inspector blog post. Previewed by Timothy Hatcher.

  • blog-files/inspector/audits_launcher.png: Added.
  • blog-files/inspector/audits_panel.png: Added.
  • blog-files/inspector/console_panel.png: Added.
  • blog-files/inspector/context_menu.png: Added.
  • blog-files/inspector/css_highlighted_line.png: Added.
  • blog-files/inspector/css_line_number_snippet.png: Added.
  • blog-files/inspector/css_line_numbers.png: Added.
  • blog-files/inspector/deactivate_breakpoints.png: Added.
  • blog-files/inspector/evaluate_on_hover.png: Added.
  • blog-files/inspector/evaluate_on_hover_2.png: Added.
  • blog-files/inspector/inherited_styles.png: Added.
  • blog-files/inspector/large_dom.png: Added.
  • blog-files/inspector/large_resources.png: Added.
  • blog-files/inspector/pseudo_elements.png: Added.
  • blog-files/inspector/redirect_headers.png: Added.
  • blog-files/inspector/redirect_headers_full.png: Added.
  • blog-files/inspector/redirects.png: Added.
  • blog-files/inspector/redirects_full.png: Added.
  • blog-files/inspector/timeline_overview.png: Added.
  • blog-files/inspector/timeline_panel.png: Added.
  • blog-files/inspector/timeline_record_details.png: Added.
4:52 AM Changeset in webkit [57058] by robert@webkit.org
  • 2 edits in trunk/WebKitTools

2010-04-04 Robert Hogan <​robert@webkit.org>

Unreviewed, add myself to the committers list.

  • Scripts/webkitpy/common/config/committers.py:
1:53 AM Changeset in webkit [57057] by dumi@chromium.org
  • 2 edits in trunk/WebKitTools

Unreviewed, adding my IRC nickname to committers.py

  • Scripts/webkitpy/common/config/committers.py:
1:26 AM Changeset in webkit [57056] by Chris Jerdonek
  • 5 edits in trunk/WebKitTools

2010-04-04 Chris Jerdonek <Chris Jerdonek>

Reviewed by Shinichiro Hamaji.

Refactored check-webkit-style's option-parsing code.

​https://bugs.webkit.org/show_bug.cgi?id=37064

  • Scripts/check-webkit-style:
    • Moved the "WebKit checkout not found" check from ArgumentParser.parse() to the calling code.
    • Moved the --git-commit argument validation from the calling code to ArgumentParser.parse().
  • Scripts/webkitpy/style/checker_unittest.py:
    • Updated a unit test as necessary.
  • Scripts/webkitpy/style/optparser.py:
    • Renamed ArgumentParser._exit_with_help() to _parse_error() and made its error_message parameter required.
    • Removed the found_checkout parameter from ArgumentParser.parse().
    • Removed the "WebKit checkout not found" check and moved it to the calling code.
    • Added --git-commit argument checking.
  • Scripts/webkitpy/style/optparser_unittest.py:
    • Adjusted the import statements to be fully qualified.
    • Changed the ArgumentParserTest class to inherit from LoggingTestCase, and updated the class as necessary.
    • Added a unit-test for the --git-commit validation.
    • Added unit tests for the --git-diff and --git-since variants of --git-commit.
Note: See TracTimeline for information about the timeline view.