Timeline
Apr 6, 2010:
- 11:40 PM Changeset in webkit [57195] by
-
- 6 edits in trunk/WebKitTools
2010-03-31 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Add webkit-patch command to crawl buildbot history and find when tests
started to fail.
https://bugs.webkit.org/show_bug.cgi?id=36911
This is a very bare-bones implementation, which works, but isn't pretty.
We will need further re-factoring and improvement to this code, but
after long discussions with Adam, I think it's best that we land this
and iterate from there.
- Scripts/webkitpy/common/net/buildbot.py:
- Add revision_build_pairs_with_results for cleaner code and possible optimization of this command.
- Return None if a build number can't be found for a revision in build_for_revision
- Separate out suspect_revisions_for_transition for re-use by FailureReason
- Add LayoutTestResults.failing_tests() and make our parsing code explict about what tables it accepts.
- Scripts/webkitpy/tool/commands/queries.py:
- Move _print_blame_information_for_commit out of WhatBroke for re-use by FailureReason.
- Add FailureReason command which can crawl a given builder and explain why it is currently red on a per-test basis.
- 10:14 PM Changeset in webkit [57194] by
-
- 3 edits in trunk/WebCore
https://bugs.webkit.org/show_bug.cgi?id=37188
WebCore::page::Geolocation::m_shouldClearCache is not used.
Reviewed by Darin Adler.
- page/Geolocation.cpp:
(WebCore::Geolocation::Geolocation): Remove m_shouldClearCache.
- page/Geolocation.h:
(WebCore::Geolocation::): Ditto.
- 9:58 PM Changeset in webkit [57193] by
-
- 3 edits in trunk/WebCore
2010-04-06 Laszlo Gombos <Laszlo Gombos>
Reviewed by Eric Seidel.
Remove obsolete MOBILE flag
https://bugs.webkit.org/show_bug.cgi?id=37125
The MOBILE flag is no longer used by any of the ports.
The flag use to control some tokenizer defaults that
can be changed runtime.
No new tests as there is no new functionality.
- config.h:
- html/HTMLTokenizer.cpp:
- 9:38 PM Changeset in webkit [57192] by
-
- 19 edits1 copy3 adds in trunk
2010-04-06 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
REGRESSION: Worker termination via JS timeout may cause worker tests like fast/workers/worker-terminate.html fail.
https://bugs.webkit.org/show_bug.cgi?id=36646
Add a new exception type for forcibly terminating a JavaScript stack.
The new exception functions similarly to the
InterruptedExecutionException but is conceptually different because
execution is terminated instead of just interrupted.
- GNUmakefile.am:
- Added new Terminator.h file.
- JavaScriptCore.gypi:
- Added new Terminator.h file.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
- Added new Terminator.h file.
- JavaScriptCore.xcodeproj/project.pbxproj:
- Added new Terminator.h file.
- interpreter/Interpreter.cpp:
(JSC::Interpreter::throwException):
- Fully unwind the stack for TerminatedExecutionException.
(JSC::Interpreter::privateExecute):
- Check if we've been terminated at the same time we check if we've timed out.
- jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
- Check if we've been terminated at the same time we check if we've timed out.
- runtime/Completion.cpp:
- Some exceptions define special completion types so that calls can see why we terminated evaluation.
(JSC::evaluate):
- runtime/Completion.h:
- Define a new completion type for termination.
(JSC::):
- runtime/ExceptionHelpers.cpp:
- Define TerminatedExecutionException and refactor pseudo-RTTI virtual function to be more semantic.
(JSC::InterruptedExecutionError::exceptionType):
(JSC::TerminatedExecutionError::TerminatedExecutionError):
(JSC::TerminatedExecutionError::exceptionType):
(JSC::TerminatedExecutionError::toString):
(JSC::createTerminatedExecutionException):
- runtime/ExceptionHelpers.h:
- Entry point for generating a TerminatedExecutionException.
- runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::JSGlobalData):
- Add a Terminator object that can be used to asynchronously terminate a JavaScript execution stack.
- runtime/JSGlobalData.h:
- runtime/JSObject.h:
(JSC::JSObject::exceptionType):
- Define that, by default, thrown objects have a normal exception type.
- runtime/Terminator.h: Added.
- Added a new controller object that can be used to terminate execution asynchronously. This object is more or less a glorified bool.
(JSC::Terminator::Terminator):
(JSC::Terminator::termianteSoon):
(JSC::Terminator::shouldTerminate):
2010-04-06 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
REGRESSION: Worker termination via JS timeout may cause worker tests like fast/workers/worker-terminate.html fail.
https://bugs.webkit.org/show_bug.cgi?id=36646
- fast/workers/resources/worker-run-forever.js: Added.
- fast/workers/worker-terminate-forever-expected.txt: Added.
- fast/workers/worker-terminate-forever.html: Added.
- Test what happens when we terminate an infinitely running worker. The essential point is that we don't spam the console with nonsense about a timeout.
- platform/mac/Skipped:
- Rescue worker-terminate.html from the Skipped list now that we've fixed the underlying bug that was causing the flakiness.
2010-04-06 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
REGRESSION: Worker termination via JS timeout may cause worker tests like fast/workers/worker-terminate.html fail.
https://bugs.webkit.org/show_bug.cgi?id=36646
Cause the worker code to swallow termination exceptions because these
need not be reported to the user because they are an implementation
detail of how we terminate worker execution.
Test: fast/workers/worker-terminate-forever.html
- bindings/js/JSDOMBinding.cpp:
(WebCore::reportException):
- Refuse to report termination exceptions to the user because they are an implementation detail.
- bindings/js/WorkerScriptController.cpp:
(WebCore::WorkerScriptController::forbidExecution):
- Instead of using timeouts to stop run away workers, use our fancy new Terminator object.
- 9:17 PM Changeset in webkit [57191] by
-
- 5 edits2 adds in trunk/LayoutTests
2010-04-06 Andrew Scherkus <scherkus@chromium.org>
Reviewed by Eric Seidel.
Checking in new baselines for media/video-controls-rendering.html and fast/layers/video-layer.html.
https://bugs.webkit.org/show_bug.cgi?id=37180
- platform/chromium-linux/media/video-controls-rendering-expected.checksum: Wasn't rebaselined when Linux scrollbars changed.
- platform/chromium-linux/media/video-controls-rendering-expected.png: Ditto.
- platform/chromium-mac/fast/layers/video-layer-expected.txt: Wasn't rebaselined when audio/video UI was refreshed.
- platform/chromium-win/fast/layers/video-layer-expected.txt: Ditto.
- platform/chromium/test_expectations.txt: Removed expectations for the above two tests.
- 8:10 PM Changeset in webkit [57190] by
-
- 2 edits in trunk/WebKit/mac
Tiger build fix after r57184.
- WebView/WebHTMLViewPrivate.h:
- 7:54 PM Changeset in webkit [57189] by
-
- 2 edits in trunk/WebKit/mac
Tiger build fix after r57184.
- WebView/WebHTMLViewPrivate.h:
- 7:39 PM Changeset in webkit [57188] by
-
- 5 edits2 adds in trunk/WebKitTools
2010-04-06 Kent Tamura <tkent@chromium.org>
Reviewed by Dimitri Glazkov.
[DRT/Chromium] Add DumpRenderTree.gyp, and some small fixes
https://bugs.webkit.org/show_bug.cgi?id=37137
- Add DumpRenderTree.gyp
- Remove some dependencies to base/string_util.h, base/compiler_specific.h, base/file_path.h, base/file_util.h, base/message_loop.h, base/sys_string_conversions.h,
- DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp: Added.
- DumpRenderTree/chromium/CppVariant.cpp: (CppVariant::toStringVector):
- DumpRenderTree/chromium/EventSender.cpp: (EventSender::EventSender): (EventSender::keyDown): (EventSender::scheduleAsynchronousClick): (EventSender::beginDragWithFiles):
- DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::setUserStyleSheetLocation): (LayoutTestController::pathToLocalResource):
- DumpRenderTree/chromium/TextInputController.cpp: (TextInputController::markedRange): (TextInputController::selectedRange):
- 7:33 PM Changeset in webkit [57187] by
-
- 2 edits in trunk/WebKitTools
2010-04-06 Dirk Pranke <dpranke@chromium.org>
Reviewed by Eric Seidel.
Write stack traces into the results directory for new-run-webkit-tests,
instead of writing them alongside the test file.
- Scripts/webkitpy/layout_tests/layout_package/test_shell_thread.py:
- 7:29 PM Changeset in webkit [57186] by
-
- 2 edits in trunk/WebKit/mac
2010-04-06 Adam Barth <abarth@webkit.org>
Unreviewed.
Speculative build fix for Tiger.
- WebView/WebHTMLViewPrivate.h:
- 7:27 PM Changeset in webkit [57185] by
-
- 2 edits in trunk/WebKitTools
2010-04-06 Dirk Pranke <dpranke@chromium.org>
Unreviewed build fix.
Enable pixel tests by default in new-run-webkit-tests unless
explicitly set by the port or by the command line. This was broken in
the fix for bug 36801 (rev. 57173).
- Scripts/webkitpy/layout_tests/run_webkit_tests.py:
- 6:53 PM Changeset in webkit [57184] by
-
- 3 edits in trunk/WebKit/mac
Expose WebHTMLView’s page breaking logic as SPI.
Reviewed by Sam Weinig and Anders Carlsson.
- WebView/WebHTMLView.mm:
(-[WebHTMLView _adjustedBottomOfPageWithTop:bottom:limit:]): Factored out of -adjustPageHeightNew:top:bottom:limit:
(-[WebHTMLView adjustPageHeightNew:top:bottom:limit:]): Call -_adjustedBottomOfPageWithTop:bottom:limit:
- WebView/WebHTMLViewPrivate.h: Declared -_adjustedBottomOfPageWithTop:bottom:limit:
- 6:40 PM Changeset in webkit [57183] by
-
- 2 edits in trunk/WebKit/mac
Add an #if in order to make Tiger happy.
- WebView/WebViewData.mm:
(-[WebViewPrivate init]):
- 6:29 PM Changeset in webkit [57182] by
-
- 3 edits in trunk/WebCore
2010-04-06 Kinuko Yasuda <kinuko@chromium.org>
Reviewed by Jian Li.
Add basic FileSystem operations for FileReader/FileWriter support for POSIX (incl. Mac)
https://bugs.webkit.org/show_bug.cgi?id=36938
No new tests; will be added when we implement upper layers.
- platform/FileSystem.h: (WebCore::):
- platform/posix/FileSystemPOSIX.cpp: (WebCore::openFile): (WebCore::closeFile): (WebCore::seekFile): (WebCore::truncateFile): (WebCore::writeToFile): (WebCore::readFromFile):
- 6:15 PM Changeset in webkit [57181] by
-
- 2 edits in trunk/WebKit/mac
Build fix.
- WebView/WebViewData.mm:
(-[WebViewPrivate init]): Use objc_collectingEnabled like we do elsewhere in WebKit.
- 6:02 PM Changeset in webkit [57180] by
-
- 6 edits in trunk
2010-04-06 Nicolas Weber <thakis@chromium.org>
Reviewed by Dimitri Glazkov.
Implement DragImage functionality for chromium/mac.
https://bugs.webkit.org/show_bug.cgi?id=37069
- page/chromium/DragControllerChromium.cpp: (WebCore::DragController::maxDragImageSize): Use a max size of 400x400 on OS X.
- platform/chromium/DragImageChromiumMac.cpp: (WebCore::dragImageSize): Implement. (WebCore::deleteDragImage): Implement. (WebCore::scaleDragImage): Implement. (WebCore::dissolveDragImageToFraction): Implement. (WebCore::createDragImageFromImage): Implement.
- platform/chromium/DragImageRef.h: Use CGImageRefs as DragImageRef on OS X.
2010-04-06 Nicolas Weber <thakis@chromium.org>
Reviewed by Dimitri Glazkov.
Use drag images on OS X as well.
https://bugs.webkit.org/show_bug.cgi?id=37069
- src/DragClientImpl.cpp: (WebKit::DragClientImpl::startDrag):
- 4:37 PM Changeset in webkit [57179] by
-
- 1 edit3 adds in trunk/LayoutTests
REGRESSION (r57113): editing/inserting/break-blockquote-after-delete.html fails on Windows
<http://webkit.org/b/37156> / <rdar://problem/7832408>
Rubber-stamped by Oliver Hunt.
Land Windows-specific results for editing/inserting/break-blockquote-after-delete.html. <rdar://problem/7834280>
tracks understanding the root cause of this difference between Mac and Windows.
- platform/win/editing/inserting/break-blockquote-after-delete-expected.checksum: Copied from LayoutTests/platform/mac/editing/inserting/break-blockquote-after-delete-expected.checksum.
- platform/win/editing/inserting/break-blockquote-after-delete-expected.png: Copied from LayoutTests/platform/mac/editing/inserting/break-blockquote-after-delete-expected.png.
- platform/win/editing/inserting/break-blockquote-after-delete-expected.txt: Copied from LayoutTests/platform/chromium-mac/editing/inserting/break-blockquote-after-delete-expected.txt.
- 4:36 PM Changeset in webkit [57178] by
-
- 3 edits2 adds in trunk
2010-04-06 Chris Evans <cevans@chromium.org>
Reviewed by Adam Barth.
Add test for javascript:window.open() popup blocker bypass.
https://bugs.webkit.org/show_bug.cgi?id=37138
- fast/events/popup-blocked-from-window-open.html: added
- fast/events/popup-blocked-from-window-open-expected.txt: added
2010-04-06 Chris Evans <cevans@chromium.org>
Reviewed by Adam Barth.
Use the new UserGestureIndictor to process javascript:window.open()
- bindings/v8/ScriptController.cpp (WebCore::ScriptController::processingUserGesture): Use the new UserGestureIndicator when processing a javascript:window.open()
- 4:27 PM Changeset in webkit [57177] by
-
- 3 edits in trunk/LayoutTests
2010-04-06 Adam Barth <abarth@webkit.org>
Reviewed by Alexey Proskuryakov.
transitions/transition-end-event-transform.html fails intermittently on Tiger Intel Release bot
https://bugs.webkit.org/show_bug.cgi?id=37145
The timeout on this test is wrong because the helper library assumes
that we're only going to do one transition, but the test actually does
two in sequence. This patch doubles the timeout to account for that.
The design of these tests are quite unfortunate because these timeout
behaviors don't seem like they'd be reliable on slow machines like
Tiger. I'm not 100% convinced that this will fix the flakiness, but it
seems like an improvement.
I'll file a separate bug about DRT leaking state from one test to
another.
- transitions/transition-end-event-helpers.js:
- transitions/transition-end-event-set-none.html:
- 4:17 PM Changeset in webkit [57176] by
-
- 11 edits in trunk
2010-04-06 Vangelis Kokkevis <vangelis@chromium.org>
Reviewed by Dimitri Glazkov.
Renaming Graphics Layer related classes used by Chromium from *Skia to *Chromium and replacing wherever possible Skia-specific
data types with WebCore equivalents. The source files will be renamed accordingly and moved out of platform/graphics/skia
in a subsequent CL.
https://bugs.webkit.org/show_bug.cgi?id=37116
No new functionality so no new tests.
- platform/graphics/GraphicsLayer.h:
- platform/graphics/skia/GraphicsLayerSkia.cpp: (WebCore::setLayerBorderColor): (WebCore::clearBorderColor): (WebCore::setLayerBackgroundColor): (WebCore::clearLayerBackgroundColor): (WebCore::GraphicsLayer::create): (WebCore::GraphicsLayerChromium::GraphicsLayerChromium): (WebCore::GraphicsLayerChromium::~GraphicsLayerChromium): (WebCore::GraphicsLayerChromium::setName): (WebCore::GraphicsLayerChromium::nativeLayer): (WebCore::GraphicsLayerChromium::setChildren): (WebCore::GraphicsLayerChromium::addChild): (WebCore::GraphicsLayerChromium::addChildAtIndex): (WebCore::GraphicsLayerChromium::addChildBelow): (WebCore::GraphicsLayerChromium::addChildAbove): (WebCore::GraphicsLayerChromium::replaceChild): (WebCore::GraphicsLayerChromium::removeFromParent): (WebCore::GraphicsLayerChromium::setPosition): (WebCore::GraphicsLayerChromium::setAnchorPoint): (WebCore::GraphicsLayerChromium::setSize): (WebCore::GraphicsLayerChromium::setTransform): (WebCore::GraphicsLayerChromium::setChildrenTransform): (WebCore::GraphicsLayerChromium::setPreserves3D): (WebCore::GraphicsLayerChromium::setMasksToBounds): (WebCore::GraphicsLayerChromium::setDrawsContent): (WebCore::GraphicsLayerChromium::setBackgroundColor): (WebCore::GraphicsLayerChromium::clearBackgroundColor): (WebCore::GraphicsLayerChromium::setContentsOpaque): (WebCore::GraphicsLayerChromium::setBackfaceVisibility): (WebCore::GraphicsLayerChromium::setOpacity): (WebCore::GraphicsLayerChromium::setNeedsDisplay): (WebCore::GraphicsLayerChromium::setNeedsDisplayInRect): (WebCore::GraphicsLayerChromium::setContentsRect): (WebCore::GraphicsLayerChromium::setContentsToImage): (WebCore::GraphicsLayerChromium::setContentsToVideo): (WebCore::GraphicsLayerChromium::setGeometryOrientation): (WebCore::GraphicsLayerChromium::hostLayerForSublayers): (WebCore::GraphicsLayerChromium::layerForSuperlayer): (WebCore::GraphicsLayerChromium::platformLayer): (WebCore::GraphicsLayerChromium::setDebugBackgroundColor): (WebCore::GraphicsLayerChromium::setDebugBorder): (WebCore::GraphicsLayerChromium::updateSublayerList): (WebCore::GraphicsLayerChromium::updateLayerPosition): (WebCore::GraphicsLayerChromium::updateLayerSize): (WebCore::GraphicsLayerChromium::updateAnchorPoint): (WebCore::GraphicsLayerChromium::updateTransform): (WebCore::GraphicsLayerChromium::updateChildrenTransform): (WebCore::GraphicsLayerChromium::updateMasksToBounds): (WebCore::GraphicsLayerChromium::updateContentsOpaque): (WebCore::GraphicsLayerChromium::updateBackfaceVisibility): (WebCore::GraphicsLayerChromium::updateLayerPreserves3D): (WebCore::GraphicsLayerChromium::updateLayerDrawsContent): (WebCore::GraphicsLayerChromium::updateLayerBackgroundColor): (WebCore::GraphicsLayerChromium::updateContentsImage): (WebCore::GraphicsLayerChromium::updateContentsVideo): (WebCore::GraphicsLayerChromium::updateContentsRect): (WebCore::GraphicsLayerChromium::updateGeometryOrientation): (WebCore::GraphicsLayerChromium::setupContentsLayer): (WebCore::GraphicsLayerChromium::updateOpacityOnLayer):
- platform/graphics/skia/GraphicsLayerSkia.h: (WebCore::GraphicsLayerChromium::primaryLayer): (WebCore::GraphicsLayerChromium::contentsLayer):
- platform/graphics/skia/LayerRendererSkia.cpp: (WebCore::LayerRendererChromium::create): (WebCore::LayerRendererChromium::LayerRendererChromium): (WebCore::LayerRendererChromium::~LayerRendererChromium): (WebCore::LayerRendererChromium::updateLayerContents): (WebCore::LayerRendererChromium::drawLayersInCanvas): (WebCore::LayerRendererChromium::drawLayerInCanvasRecursive): (WebCore::LayerRendererChromium::updateLayerContentsRecursive):
- platform/graphics/skia/LayerRendererSkia.h: (WebCore::LayerRendererChromium::setRootLayer): (WebCore::LayerRendererChromium::rootLayer):
- platform/graphics/skia/LayerSkia.cpp: (WebCore::LayerChromium::create): (WebCore::LayerChromium::LayerChromium): (WebCore::LayerChromium::~LayerChromium): (WebCore::LayerChromium::updateGraphicsContext): (WebCore::LayerChromium::updateContents): (WebCore::LayerChromium::drawDebugBorder): (WebCore::LayerChromium::setNeedsCommit): (WebCore::LayerChromium::addSublayer): (WebCore::LayerChromium::insertSublayer): (WebCore::LayerChromium::removeFromSuperlayer): (WebCore::LayerChromium::removeSublayer): (WebCore::LayerChromium::indexOfSublayer): (WebCore::LayerChromium::setBackingStoreRect): (WebCore::LayerChromium::setBounds): (WebCore::LayerChromium::setFrame): (WebCore::LayerChromium::rootLayer): (WebCore::LayerChromium::removeAllSublayers): (WebCore::LayerChromium::setSublayers): (WebCore::LayerChromium::setSuperlayer): (WebCore::LayerChromium::superlayer): (WebCore::LayerChromium::setNeedsDisplay):
- platform/graphics/skia/LayerSkia.h: (WebCore::LayerChromium::setAnchorPoint): (WebCore::LayerChromium::anchorPoint): (WebCore::LayerChromium::borderWidth): (WebCore::LayerChromium::bounds): (WebCore::LayerChromium::frame): (WebCore::LayerChromium::setPosition): (WebCore::LayerChromium::position): (WebCore::LayerChromium::zPosition): (WebCore::LayerChromium::getSublayers): (WebCore::LayerChromium::setSublayerTransform): (WebCore::LayerChromium::sublayerTransform): (WebCore::LayerChromium::setTransform): (WebCore::LayerChromium::transform):
2010-04-06 Vangelis Kokkevis <vangelis@chromium.org>
Reviewed by Dimitri Glazkov.
Changing references to Graphics Layer related classes from *Skia to *Chromium.
https://bugs.webkit.org/show_bug.cgi?id=37116
- src/WebViewImpl.cpp: (WebKit::WebViewImpl::paint): (WebKit::WebViewImpl::setAcceleratedCompositing): (WebKit::WebViewImpl::updateRootLayerContents):
- src/WebViewImpl.h:
- 4:04 PM Changeset in webkit [57175] by
-
- 2 edits in trunk/LayoutTests
2010-04-06 Krithigassree Sambamurthy <krithigassree.sambamurthy@nokia.com>
Reviewed by Laszlo Gombos.
[Qt] These tests can be removed from the skipped list since these
work after the redirection loop detection implemented in qt network.
https://bugs.webkit.org/show_bug.cgii?id=36690
- platform/qt/Skipped:
- 3:55 PM Changeset in webkit [57174] by
-
- 3 edits in trunk/WebCore
2010-04-06 Jarkko Sakkinen <jarkko.j.sakkinen@gmail.com>
Reviewed by Laszlo Gombos.
[Qt] WebKit does not build on Windows with --3d-canvas
https://bugs.webkit.org/show_bug.cgi?id=37026
- platform/graphics/GraphicsContext3D.h:
- platform/graphics/qt/GraphicsContext3DQt.cpp: (WebCore::GraphicsContext3D::getActiveAttrib): (WebCore::GraphicsContext3D::getActiveUniform):
- 3:47 PM Changeset in webkit [57173] by
-
- 6 edits in trunk/WebKitTools
2010-04-06 Dirk Pranke <dpranke@chromium.org>
Reviewed by Eric Seidel.
Disable pixel tests on the mac port by default.
Also, revamp the way we check for pixel tests being enabled or
disabled. We now look for options.pixel_tests instead of
options.no_pixel_tests, and we have the "--pixel-tests" (force enable)
and "--no-pixel-tests" (force disable) flags.
- Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
- Scripts/webkitpy/layout_tests/layout_package/test_expectations_test.py:
- Scripts/webkitpy/layout_tests/port/chromium.py:
- Scripts/webkitpy/layout_tests/port/mac.py:
- Scripts/webkitpy/layout_tests/run_webkit_tests.py:
- 3:42 PM Changeset in webkit [57172] by
-
- 2 edits in trunk/WebKitTools
2010-04-06 Diego Gonzalez <diego.gonzalez@openbossa.org>
Reviewed by Laszlo Gombos.
[Qt] Added the iPhone and iPad latest user agent in QtLauncher UA switcher
https://bugs.webkit.org/show_bug.cgi?id=37159
- QtLauncher/useragentlist.txt:
- 3:39 PM Changeset in webkit [57171] by
-
- 3 edits in trunk/WebKit/chromium
2010-04-06 James Hawkins <jhawkins@chromium.org>
Reviewed by Adam Barth.
[Chromium] Implement WebInputElement::maxLength.
https://bugs.webkit.org/show_bug.cgi?id=37172
- public/WebInputElement.h:
- src/WebInputElement.cpp: (WebKit::WebInputElement::maxLength):
- 3:32 PM Changeset in webkit [57170] by
-
- 2 edits in trunk/WebCore
2010-04-06 Abhinav Mithal <abhinav.mithal@nokia.com>
Reviewed by Laszlo Gombos.
[Qt] npapi header leaves XP_WIN flag defined even when SYMBIAN32 flag is found
https://bugs.webkit.org/show_bug.cgi?id=34614
Do not define XP_WIN if WebKit is compiled for Symbian.
No new tests as there is no new functionality.
- bridge/npapi.h:
- 3:02 PM Changeset in webkit [57169] by
-
- 1 edit in trunk/WebKitTools/Scripts/webkitpy/common/config/committers.py
Added myself to the committers list.
- 2:58 PM Changeset in webkit [57168] by
-
- 2 edits in trunk/LayoutTests
2010-04-06 Andrew Scherkus <scherkus@chromium.org>
Unreviewed, media test expectations tweak.
We now regularly run http/tests/media and have to mark a few tests as TIMEOUT.
- platform/chromium/test_expectations.txt:
- 2:28 PM Changeset in webkit [57167] by
-
- 3 edits2 adds in trunk
aria-label doesn't work on image map area
https://bugs.webkit.org/show_bug.cgi?id=36977
Reviewed by Beth Dakin.
WebCore:
Test: platform/mac/accessibility/area-with-aria-label.html
- accessibility/AccessibilityImageMapLink.cpp:
(WebCore::AccessibilityImageMapLink::accessibilityDescription):
LayoutTests:
- platform/mac/accessibility/area-with-aria-label-expected.txt: Added.
- platform/mac/accessibility/area-with-aria-label.html: Added.
- 2:21 PM Changeset in webkit [57166] by
-
- 2 edits in trunk/LayoutTests
2010-04-06 Andrew Scherkus <scherkus@chromium.org>
Unreviewed, cleaning up media layout test expectations.
Mostly correcting bug numbers, updating comments, and fixing expectations.
- platform/chromium/test_expectations.txt:
- 1:44 PM Changeset in webkit [57165] by
-
- 6 edits in trunk/WebCore
2010-04-06 James Robinson <jamesr@chromium.org>
Reviewed by Simon Fraser.
Reverts the incorrect fixed position fastpath scrolling logic
https://bugs.webkit.org/show_bug.cgi?id=33150
This code does not properly handle overflow or transforms on fixed
position elements, causing repaint bugs on scroll.
No new tests.
- page/FrameView.cpp: (WebCore::FrameView::addFixedObject): (WebCore::FrameView::removeFixedObject):
- page/FrameView.h:
- platform/ScrollView.cpp: (WebCore::ScrollView::scrollContents):
- platform/ScrollView.h:
- rendering/RenderObject.cpp: (WebCore::RenderObject::styleWillChange):
- 12:58 PM Changeset in webkit [57164] by
-
- 2 edits in trunk/WebCore
[wx] Build fix for wxMac / Cocoa on wx trunk.
- 12:50 PM Changeset in webkit [57163] by
-
- 2 edits in trunk/WebCore
2010-04-06 Simon Hausmann <simon.hausmann@nokia.com>
Reviewed by Darin Adler.
JS code generator does not support feature conditional attributes that are writable
https://bugs.webkit.org/show_bug.cgi?id=37149
Write out the feature #ifdef not only for the getter, but also for the setter
function.
- bindings/scripts/CodeGeneratorJS.pm:
- 12:17 PM Changeset in webkit [57162] by
-
- 9 edits1 copy1 move in trunk
2010-04-06 Evan Stade <estade@chromium.org>
Reviewed by Dimitri Glazkov.
[chromium] need DragImage implementation
https://bugs.webkit.org/show_bug.cgi?id=35811
Use the DragImageRef that the DragController passes to us.
This was previously committed but rolled back for breaking layout
tests. The fix is on the WebKit/chromium side.
- WebCore.gyp/WebCore.gyp:
- WebCore.gypi:
- platform/chromium/DragImageChromium.cpp: Removed.
- platform/chromium/DragImageChromiumMac.cpp: Added. (WebCore::dragImageSize): (WebCore::deleteDragImage): (WebCore::scaleDragImage): (WebCore::dissolveDragImageToFraction): (WebCore::createDragImageFromImage): (WebCore::createDragImageIconForCachedImage):
- platform/chromium/DragImageChromiumSkia.cpp: Added. (WebCore::dragImageSize): (WebCore::deleteDragImage): (WebCore::scaleDragImage): (WebCore::dissolveDragImageToFraction): (WebCore::createDragImageFromImage): (WebCore::createDragImageIconForCachedImage):
- platform/chromium/DragImageRef.h:
2010-04-06 Evan Stade <estade@chromium.org>
Reviewed by Dimitri Glazkov.
[chromium] need DragImage implementation
https://bugs.webkit.org/show_bug.cgi?id=35811
Basic implementation using SkBitmap. Transformations are not supported
yet. No implementation for mac.
This was previously committed but rolled back for breaking layout
tests.
- public/WebViewClient.h: (WebKit::WebViewClient::startDragging):
- src/DragClientImpl.cpp: (WebKit::DragClientImpl::startDrag): new: check for null dragImage.
- src/WebViewImpl.cpp: (WebKit::WebViewImpl::startDragging):
- src/WebViewImpl.h:
- 11:56 AM Changeset in webkit [57161] by
-
- 5 edits in trunk
2010-04-01 Yuzo Fujishima <yuzo@google.com>
Reviewed by Darin Adler.
Fix bug: CSS3 :not selector with ID simple selector sequence test fails
https://bugs.webkit.org/show_bug.cgi?id=36276
- fast/css/invalid-not-with-simple-selector-sequence-expected.txt: Added.
- fast/css/invalid-not-with-simple-selector-sequence.html: Added.
2010-04-01 Yuzo Fujishima <yuzo@google.com>
Reviewed by Darin Adler.
Fix bug: CSS3 :not selector with ID simple selector sequence test fails
As per http://www.w3.org/TR/css3-selectors/#negation, :not(X) takes a simple selector as an argument.
WebKit was accepting a simple selector *sequence*.
This patch adds WebCore::CSSSelector::isSimple which judges if the selector is simple.
The method is used in CSSGrammar.y to decide whether to accept the selector as the argument of :not().
https://bugs.webkit.org/show_bug.cgi?id=36276
Test: fast/css/invalid-not-with-simple-selector-sequence.html
- css/CSSGrammar.y:
- css/CSSSelector.cpp: (WebCore::CSSSelector::isSimple):
- css/CSSSelector.h:
- 11:18 AM Changeset in webkit [57160] by
-
- 1 edit1 copy in trunk/LayoutTests
REGRESSION (r57109): editing/pasteboard/drag-image-to-contenteditable-in-iframe.html fails on Windows
https://bugs.webkit.org/show_bug.cgi?id=37157
- platform/win/editing/pasteboard/drag-image-to-contenteditable-in-iframe-expected.txt:
Copied from platform/mac/editing/pasteboard/drag-image-to-contenteditable-in-iframe-expected.txt.
Windows gets a different result than Mac because the dragging code ends up making the src attribute
of the dragged element have a full path on Windows, but not on Mac.
- 11:17 AM Changeset in webkit [57159] by
-
- 3 edits in trunk/WebCore
Rubber-stamped by Dan Bernstein.
Patch by Andy Estes <aestes@apple.com> on 2010-04-06
Remove non-ASCII characters from license headers to fix build errors on
Japanese Windows.
https://bugs.webkit.org/show_bug.cgi?id=37008
- dom/UserGestureIndicator.cpp:
- dom/UserGestureIndicator.h:
- 10:59 AM Changeset in webkit [57158] by
-
- 5 edits in trunk/WebKit/chromium
2010-04-06 James Hawkins <jhawkins@chromium.org>
Reviewed by Dimitri Glazkov.
[Chromium] Move the getElementsByTagName from WebDocument to WebNode.
https://bugs.webkit.org/show_bug.cgi?id=37161
- public/WebDocument.h:
- public/WebNode.h:
- src/WebDocument.cpp:
- src/WebNode.cpp: (WebKit::WebNode::getElementsByTagName):
- 10:49 AM Changeset in webkit [57157] by
-
- 2 edits in trunk/WebCore
2010-04-06 Andrei Popescu <andreip@google.com>
Reviewed by Dimitri Glazkov.
[V8][Android] PageCache crashes when JavaScript is disabled
https://bugs.webkit.org/show_bug.cgi?id=37150
This patch ensures that saving and restoration of the script
state only happens when JS is enabled and each frame has a
non-null context.
No new tests: existing tests show the feature is working
when JS is enabled. When JS is disabled, manual testing
is required.
- bindings/v8/ScriptCachedFrameData.cpp: (WebCore::ScriptCachedFrameData::ScriptCachedFrameData): (WebCore::ScriptCachedFrameData::restore):
- 10:39 AM Changeset in webkit [57156] by
-
- 2 edits in trunk/LayoutTests
2010-04-06 Bryan Yeung <bryeung@chromium.org>
Reviewed by Dimitri Glazkov.
Update chromium expectations for passing Linux tests.
- platform/chromium/test_expectations.txt:
- 10:29 AM Changeset in webkit [57155] by
-
- 2 edits in trunk/WebKit/qt
2010-04-06 Diego Gonzalez <diego.gonzalez@openbossa.org>
Reviewed by Simon Hausmann.
[Qt] Add mechanism to detect QtWebKit 2.0 via the preprocessor
https://bugs.webkit.org/show_bug.cgi?id=36538
- Api/qwebkitglobal.h:
- 10:11 AM Changeset in webkit [57154] by
-
- 4 edits in trunk/LayoutTests
2010-04-06 Yury Semikhatsky <yurys@chromium.org>
Unreviewed. Update Chromium test expectations for fast/dom/error-to-string-stack-overflow.html.
- platform/chromium-mac/fast/dom/error-to-string-stack-overflow-expected.txt:
- platform/chromium-win/fast/dom/error-to-string-stack-overflow-expected.txt:
- platform/chromium/test_expectations.txt:
- 9:15 AM Changeset in webkit [57153] by
-
- 2 edits in trunk/WebKit/chromium
2010-04-06 Ilya Tikhonovsky <loislo@chromium.org>
Unreviewed build fix for Chromium DEPS.
- DEPS:
- 8:56 AM Changeset in webkit [57152] by
-
- 2 edits in trunk/WebKit/chromium
2010-04-06 Ilya Tikhonovsky <loislo@chromium.org>
Unreviewed: build fixi for WebKit Chromium bots.
- DEPS:
- 8:11 AM Changeset in webkit [57151] by
-
- 2 edits4 adds in trunk/WebCore
2010-04-06 Ilya Tikhonovsky <loislo@chromium.org>
Unreviewed build fix.
Web Inspector: missed files were added.
- GNUmakefile.am:
- bindings/js/ScriptGCEvent.h: Added. (WebCore::ScriptGCEvent::addEventListener): (WebCore::ScriptGCEvent::removeEventListener): (WebCore::ScriptGCEvent::getHeapSize):
- bindings/v8/ScriptGCEvent.cpp: Added. (WebCore::ScriptGCEvent::addEventListener): (WebCore::ScriptGCEvent::removeEventListener): (WebCore::ScriptGCEvent::getHeapSize): (WebCore::ScriptGCEvent::getUsedHeapSize): (WebCore::ScriptGCEvent::gcPrologueCallback): (WebCore::ScriptGCEvent::gcEpilogueCallback):
- bindings/v8/ScriptGCEvent.h: Added.
- inspector/ScriptGCEventListener.h: Added. (WebCore::ScriptGCEventListener::~ScriptGCEventListener):
- 7:50 AM QtWebKitBackportingFixes edited by
- (diff)
- 7:46 AM QtWebKitBackportingFixes edited by
- (diff)
- 7:44 AM Changeset in webkit [57150] by
-
- 28 edits in trunk
2010-04-06 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: The JS code can be not optimal from memory usage point of view.
As example it can generate a lot of temp objects and GC will spend significant time to collect these objects.
GC event will show us these moments. Also each event can show us how much memory is in use.
https://bugs.webkit.org/show_bug.cgi?id=37025
- WebCore.gypi:
- WebCore.pro:
- inspector/InspectorTimelineAgent.cpp: (WebCore::InspectorTimelineAgent::InspectorTimelineAgent): (WebCore::InspectorTimelineAgent::pushGCEventRecords): (WebCore::InspectorTimelineAgent::didGC): (WebCore::InspectorTimelineAgent::~InspectorTimelineAgent): (WebCore::InspectorTimelineAgent::didInstallTimer): (WebCore::InspectorTimelineAgent::didRemoveTimer): (WebCore::InspectorTimelineAgent::willSendResourceRequest): (WebCore::InspectorTimelineAgent::didFinishLoadingResource): (WebCore::InspectorTimelineAgent::didMarkTimeline): (WebCore::InspectorTimelineAgent::addRecordToTimeline): (WebCore::InspectorTimelineAgent::setHeapSizeStatistic): (WebCore::InspectorTimelineAgent::didCompleteCurrentRecord): (WebCore::InspectorTimelineAgent::pushCurrentRecord):
- inspector/InspectorTimelineAgent.h: (WebCore::): (WebCore::InspectorTimelineAgent::instanceCount): (WebCore::InspectorTimelineAgent::TimelineRecordEntry::TimelineRecordEntry): (WebCore::InspectorTimelineAgent::GCEvent::GCEvent):
- inspector/TimelineRecordFactory.cpp: (WebCore::TimelineRecordFactory::createGCEventData):
- inspector/TimelineRecordFactory.h:
- inspector/front-end/Popover.js: (WebInspector.PopoverHelper.prototype._mouseHover):
- inspector/front-end/TimelineAgent.js:
- inspector/front-end/TimelinePanel.js: (WebInspector.TimelinePanel.prototype.get _recordStyles): (WebInspector.TimelinePanel.FormattedRecord): (WebInspector.TimelinePanel.FormattedRecord.prototype._generatePopupContent): (WebInspector.TimelinePanel.FormattedRecord.prototype._getRecordDetails):
- 7:33 AM Changeset in webkit [57149] by
-
- 1 edit in trunk/WebCore/rendering/RenderBox.cpp
Unreviewed identation fix.
- 7:32 AM Changeset in webkit [57148] by
-
- 2 edits in trunk/WebCore
Remove unused DIRECTIONAL_PAD_NAVIGATION
https://bugs.webkit.org/show_bug.cgi?id=37134
Reviewed by Laszlo Gombos.
Patch by Antonio Gomes <tonikitoo@webkit.org>
Android browser was planning to have a "directional pad navigation" available on
trunk, under a build guard called DIRECTIONAL_PAD_NAVIGATION, but according to
https://bugs.webkit.org/show_bug.cgi?id=23145#c3 , the plan was dropped.
However bug 23163 landed some code relying on the build flag supposedly to be added,
and is now dead code in trunk.
- dom/Element.cpp:
(WebCore::Element::updateFocusAppearance):
- 7:00 AM Changeset in webkit [57147] by
-
- 2 edits in trunk/LayoutTests
2010-04-06 Yury Semikhatsky <yurys@chromium.org>
Unreviewed. Update Chromium test expectations.
- platform/chromium-win/fast/workers/worker-script-error-expected.txt:
- 6:45 AM Changeset in webkit [57146] by
-
- 13 edits in trunk
2010-04-06 Mattias Nissler <mnissler@chromium.org>
Reviewed by Pavel Feldman.
Rework inspector docking to issue a request call from the frontend
whenever the user triggers to (un)dock the inspector window. Doing so
enables InspectorFrontendHost implementations to asynchronously decide
whether the window is docked or not. The old canAttachWindow() is not
required anymore, remove it.
https://bugs.webkit.org/show_bug.cgi?id=36944
- inspector/InspectorFrontendClient.h:
- inspector/InspectorFrontendClientLocal.cpp: (WebCore::InspectorFrontendClientLocal::requestAttachWindow):
- inspector/InspectorFrontendClientLocal.h:
- inspector/InspectorFrontendHost.cpp: (WebCore::InspectorFrontendHost::requestAttachWindow):
- inspector/InspectorFrontendHost.h:
- inspector/InspectorFrontendHost.idl:
- inspector/front-end/inspector.js: (WebInspector.toggleAttach):
2010-04-06 Mattias Nissler <mnissler@chromium.org>
Reviewed by Pavel Feldman.
Handle docking requests from the developer tools and forward them to
WebDevToolsFrontendClient.
https://bugs.webkit.org/show_bug.cgi?id=36944
- public/WebDevToolsFrontendClient.h: (WebKit::WebDevToolsFrontendClient::requestDockWindow):
- src/WebDevToolsFrontendImpl.cpp: (WebKit::WebDevToolsFrontendImpl::WebDevToolsFrontendImpl): (WebKit::WebDevToolsFrontendImpl::jsRequestAttachWindow):
- src/WebDevToolsFrontendImpl.h:
- 6:33 AM Changeset in webkit [57145] by
-
- 2 edits in trunk/WebCore
2010-04-06 Vitaly Repeshko <vitalyr@chromium.org>
Reviewed by Yury Semikhatsky.
[V8] Extend the set of types supported by SerializedScriptValue
https://bugs.webkit.org/show_bug.cgi?id=37052
New types include sparse arrays, Uint32, Date, and ImageData.
Serialization process became more flexible. A state can either
directly write primitive values (instead of returning them like
iterator) or construct a new state for serializing complex values
that will return to the current state when done.
Deserialization process now avoids exposing the tags using a set
of factory functions for complex objects instead.
Internal buffer type changed to uint8_t to be independent of
whether char is signed or not.
- bindings/v8/SerializedScriptValue.cpp: (WebCore::): (WebCore::Writer::Writer): (WebCore::Writer::writeString): (WebCore::Writer::writeUint32): (WebCore::Writer::writeDate): (WebCore::Writer::writeNumber): (WebCore::Writer::writeImageData): (WebCore::Writer::writeArray): (WebCore::Writer::writeObject): (WebCore::Writer::writeSparseArray): (WebCore::Writer::doWriteUint32): (WebCore::Writer::doWriteNumber): (WebCore::Writer::append): (WebCore::Writer::fillHole): (WebCore::Writer::byteAt): (WebCore::Serializer::Serializer): (WebCore::Serializer::serialize): (WebCore::Serializer::writeArray): (WebCore::Serializer::writeObject): (WebCore::Serializer::writeSparseArray): (WebCore::Serializer::StateBase::StateBase): (WebCore::Serializer::ErrorState::ErrorState): (WebCore::Serializer::ErrorState::advance): (WebCore::Serializer::State::composite): (WebCore::Serializer::State::State): (WebCore::Serializer::ArrayState::ArrayState): (WebCore::Serializer::ArrayState::advance): (WebCore::Serializer::AbstractObjectState::AbstractObjectState): (WebCore::Serializer::AbstractObjectState::advance): (WebCore::Serializer::ObjectState::ObjectState): (WebCore::Serializer::ObjectState::objectDone): (WebCore::Serializer::SparseArrayState::SparseArrayState): (WebCore::Serializer::SparseArrayState::objectDone): (WebCore::Serializer::push): (WebCore::Serializer::pop): (WebCore::Serializer::handleError): (WebCore::Serializer::checkComposite): (WebCore::Serializer::writeString): (WebCore::Serializer::writeImageData): (WebCore::Serializer::newArrayState): (WebCore::Serializer::newObjectState): (WebCore::Serializer::doSerialize): (WebCore::Reader::Reader): (WebCore::Reader::read): (WebCore::Reader::readString): (WebCore::Reader::readUint32): (WebCore::Reader::readDate): (WebCore::Reader::readNumber): (WebCore::Reader::readImageData): (WebCore::Reader::doReadUint32): (WebCore::Reader::doReadNumber): (WebCore::Deserializer::Deserializer): (WebCore::Deserializer::createArray): (WebCore::Deserializer::createObject): (WebCore::Deserializer::createSparseArray): (WebCore::Deserializer::initializeObject): (WebCore::Deserializer::doDeserialize): (WebCore::Deserializer::stackDepth): (WebCore::SerializedScriptValue::deserialize):
- 6:29 AM QtWebKitTriageRoster edited by
- (diff)
- 6:19 AM Changeset in webkit [57144] by
-
- 2 edits in trunk/WebKitTools
2010-04-06 Laszlo Gombos <Laszlo Gombos>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Add current user-agent string for Symbian for QtLauncher
https://bugs.webkit.org/show_bug.cgi?id=37131
- QtLauncher/useragentlist.txt:
- 5:53 AM QtWebKitTriageRoster edited by
- (diff)
- 5:50 AM QtWebKitTriageRoster edited by
- (diff)
- 5:46 AM QtWebKitTriageRoster edited by
- (diff)
- 5:35 AM QtWebKitTriageRoster edited by
- (diff)
- 5:31 AM QtWebKitTriageRoster created by
- 5:26 AM Changeset in webkit [57143] by
-
- 2 edits7 adds in trunk/LayoutTests
2010-04-06 Pavel Feldman <pfeldman@chromium.org>
Not reviewed: rebaselining Chromium layout test expectations.
- platform/chromium-mac/editing/inserting/break-blockquote-after-delete-expected.txt: Added.
- platform/chromium-mac/editing/pasteboard/drag-image-to-contenteditable-in-iframe-expected.checksum: Added.
- platform/chromium-mac/editing/pasteboard/drag-image-to-contenteditable-in-iframe-expected.png: Added.
- platform/chromium-mac/editing/pasteboard/drag-image-to-contenteditable-in-iframe-expected.txt: Added.
- platform/chromium-mac/fast/backgrounds/size/contain-and-cover-expected.checksum: Added.
- platform/chromium-mac/fast/backgrounds/size/contain-and-cover-expected.png: Added.
- platform/chromium/test_expectations.txt:
- 5:26 AM QtWebKitBugs edited by
- (diff)
- 5:25 AM QtWebKitBugs edited by
- (diff)
- 5:25 AM QtWebKitBugs edited by
- (diff)
- 4:54 AM Changeset in webkit [57142] by
-
- 2 edits3 adds in trunk/LayoutTests
2010-04-06 Csaba Osztrogonác <Csaba Osztrogonác>
Reviewed by Eric Seidel.
[Qt] LayoutTests/fast/canvas/canvas-text-alignment.html skipped on Qt
https://bugs.webkit.org/show_bug.cgi?id=36058
fast/canvas/canvas-text-alignment.html passes, so it can be unskipped.
Compared to png file and Mac expected file.
- platform/qt/Skipped: fast/canvas/canvas-text-alignment.html unskipped.
- platform/qt/fast/canvas/canvas-text-alignment-expected.checksum: Added.
- platform/qt/fast/canvas/canvas-text-alignment-expected.png: Added.
- platform/qt/fast/canvas/canvas-text-alignment-expected.txt: Added.
- 3:47 AM Changeset in webkit [57141] by
-
- 2 edits in trunk/WebCore
Unreviewed buildfix for --minimal build.
Buildfix after r57134. Add ENABLE(WORKERS) guard.
original bug: https://bugs.webkit.org/show_bug.cgi?id=36375
- bindings/js/JSWorkerContextErrorHandler.cpp:
- 3:37 AM Changeset in webkit [57140] by
-
- 3 edits3 adds in trunk
2010-04-06 Dirk Schulze <krit@webkit.org>
Reviewed by Oliver Hunt.
SVG/SMIL parse failure on attribute keySplines
https://bugs.webkit.org/show_bug.cgi?id=37071
Test: svg/animations/animate-keySplines.html
The String in 'keySplines' can have multiple spaces between numbers
and delimiters. The parsing code is inspired by SVGParserUtilities
and respects this.
- svg/SVGAnimationElement.cpp: (WebCore::parseKeySplines):
2010-04-06 Dirk Schulze <krit@webkit.org>
Reviewed by Oliver Hunt.
SVG/SMIL parse failure on attribute keySplines
https://bugs.webkit.org/show_bug.cgi?id=37071
Test correct parsing of keySplines.
- svg/animations/animate-keySplines-expected.txt: Added.
- svg/animations/animate-keySplines.html: Added.
- svg/animations/script-tests/animate-keySplines.js: Added. (sample1): (sample2): (sample3): (executeTest):
- 3:34 AM Changeset in webkit [57139] by
-
- 1 edit in trunk/LayoutTests/platform/chromium/test_expectations.txt
2010-04-06 Pavel Feldman <pfeldman@chromium.org>
Not reviewed: more updates to test expectations for Chromium roll.
- platform/chromium/test_expectations.txt:
- 3:14 AM Changeset in webkit [57138] by
-
- 2 edits in trunk/WebKit/chromium
2010-04-06 Andrey Kosyakov <caseq@chromium.org>
Reviewed by Yury Semikhatsky.
Fixed logging of unhndled worker exceptions.
https://bugs.webkit.org/show_bug.cgi?id=37143
- src/WebWorkerClientImpl.cpp: (WebKit::WebWorkerClientImpl::postExceptionToWorkerObject):
- 2:59 AM Changeset in webkit [57137] by
-
- 5 edits in trunk/WebKitTools
2010-04-06 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Explain how to handle rollout patches
https://bugs.webkit.org/show_bug.cgi?id=37139
We need to set expectations for how long landing rollout patches with
the commit-queue takes. The commit-queue is optimized for safety, not
performance. Also, give folks an alternative way to land patches
quickly.
In addition, improve our testing of add_patch_to_bug by having
MockBugzilla log. This caused me to tighten a bunch of tests and
notice that one of our tests wasn't being run.
- Scripts/webkitpy/tool/commands/download_unittest.py:
- Scripts/webkitpy/tool/commands/upload_unittest.py:
- Scripts/webkitpy/tool/mocktool.py:
- Scripts/webkitpy/tool/steps/postdiffforrevert.py:
- 2:58 AM Changeset in webkit [57136] by
-
- 2 edits in trunk/LayoutTests
2010-04-06 Pavel Feldman <pfeldman@chromium.org>
Not reviewed: more updates to test expectations for Chromium roll.
- platform/chromium/test_expectations.txt:
- 2:07 AM Changeset in webkit [57135] by
-
- 2 edits in trunk/LayoutTests
2010-04-06 Pavel Feldman <pfeldman@chromium.org>
Not reviewed: updated test expectations for Chromium roll.
- platform/chromium/test_expectations.txt:
- 1:46 AM Changeset in webkit [57134] by
-
- 20 edits3 copies1 add in trunk
2010-04-06 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Refactored error reporting mechanizm on Worker Global Objects.
Unlike other event listeners which accept single argument(Event)
onerror handler on worker global object should be a function
accepting three arguments. This error reporting was implementedas
EventListener::reportError method which had custom implementations
for v8 and JSC. This patch removes EventListener::reportError and
moves its functionality into custom bindings(V8WorkerContextErrorHandler
and JSWorkerContextErrorHandler) that implement EventListener inerface
for the onerror handler.
This patch also makes uncaught exceptions that happen in the onerror
listener be reported to the Worker's onerror handler.
- Android.jscbindings.mk:
- GNUmakefile.am:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/JSBindingsAllInOne.cpp:
- bindings/js/JSEventListener.cpp:
- bindings/js/JSEventListener.h:
- bindings/js/JSWorkerContextErrorHandler.cpp: Added. (WebCore::JSWorkerContextErrorHandler::JSWorkerContextErrorHandler): (WebCore::JSWorkerContextErrorHandler::~JSWorkerContextErrorHandler): (WebCore::JSWorkerContextErrorHandler::handleEvent):
- bindings/js/JSWorkerContextErrorHandler.h: Added. (WebCore::JSWorkerContextErrorHandler::create): (WebCore::createJSWorkerContextErrorHandler):
- bindings/scripts/CodeGeneratorJS.pm:
- bindings/scripts/CodeGeneratorV8.pm:
- bindings/v8/V8WorkerContextErrorHandler.cpp: Added. (WebCore::V8WorkerContextErrorHandler::V8WorkerContextErrorHandler): (WebCore::V8WorkerContextErrorHandler::callListenerFunction):
- bindings/v8/V8WorkerContextErrorHandler.h: Added. (WebCore::V8WorkerContextErrorHandler::create):
- bindings/v8/V8WorkerContextEventListener.cpp:
- bindings/v8/V8WorkerContextEventListener.h:
- dom/EventListener.h:
- workers/WorkerContext.cpp: (WebCore::WorkerContext::WorkerContext): (WebCore::WorkerContext::reportException):
- workers/WorkerContext.h:
2010-04-06 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Test that exception which occurs in onerror handler is reported to the Worker object.
- fast/workers/worker-script-error-expected.txt:
- fast/workers/worker-script-error.html:
- 1:12 AM Changeset in webkit [57133] by
-
- 2 edits in trunk/WebCore
2010-04-06 Pavel Feldman <pfeldman@chromium.org>
Not reviewed: reverting v8 change at r57079 for crashing Chromium layout tests.
- 12:27 AM Changeset in webkit [57132] by
-
- 5 edits in trunk/WebKitTools
2010-04-06 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Turns out commit_info.committer() can be None
https://bugs.webkit.org/show_bug.cgi?id=37106
When the committer isn't in committers.py, the committer() property on
commit_info can be None. We need to handle that case gracefully.
- Scripts/webkitpy/common/checkout/commitinfo.py:
- Scripts/webkitpy/tool/bot/sheriff.py:
- Scripts/webkitpy/tool/bot/sheriff_unittest.py:
- Scripts/webkitpy/tool/commands/queries.py:
- 12:09 AM Changeset in webkit [57131] by
-
- 2 edits in trunk/WebKitTools
2010-04-06 Laszlo Gombos <Laszlo Gombos>
Reviewed by Kenneth Rohde Christiansen.
[Qt] [Symbian] Build fix for Dumprendertree if Qt printing is not supported
https://bugs.webkit.org/show_bug.cgi?id=37082
Use the QT_NO_PRINTER guard to flag QPrinter dependent code.
- DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::DumpRenderTree::dryRunPrint):
Apr 5, 2010:
- 11:59 PM Changeset in webkit [57130] by
-
- 2 edits in trunk/WebCore
2010-04-05 MORITA Hajime <morrita@google.com>
Reviewed by Darin Adler.
RenderProgress.cpp is missing CurrentTime.h
https://bugs.webkit.org/show_bug.cgi?id=37080
No new tests. just fixed compilation error.
- rendering/RenderProgress.cpp:
- 11:48 PM Changeset in webkit [57129] by
-
- 2 edits in trunk/WebKit/win
2010-04-05 Peter Nelson <charn.opcode@gmail.com>
Reviewed by Eric Seidel.
Fixed style errors in DOMCoreClasses.h to bring it up to scratch
for https://bugs.webkit.org/show_bug.cgi?id=34979.
- DOMCoreClasses.h: (DOMObject::throwException): (DOMObject::callWebScriptMethod): (DOMObject::evaluateWebScript): (DOMObject::removeWebScriptKey): (DOMObject::stringRepresentation): (DOMObject::webScriptValueAtIndex): (DOMObject::setWebScriptValueAtIndex): (DOMObject::setException): (DOMNodeList::throwException): (DOMNodeList::callWebScriptMethod): (DOMNodeList::evaluateWebScript): (DOMNodeList::removeWebScriptKey): (DOMNodeList::stringRepresentation): (DOMNodeList::webScriptValueAtIndex): (DOMNodeList::setWebScriptValueAtIndex): (DOMNodeList::setException): (DOMDocument::throwException): (DOMDocument::callWebScriptMethod): (DOMDocument::evaluateWebScript): (DOMDocument::removeWebScriptKey): (DOMDocument::stringRepresentation): (DOMDocument::webScriptValueAtIndex): (DOMDocument::setWebScriptValueAtIndex): (DOMDocument::setException): (DOMDocument::nodeName): (DOMDocument::nodeValue): (DOMDocument::setNodeValue): (DOMDocument::nodeType): (DOMDocument::parentNode): (DOMDocument::childNodes): (DOMDocument::firstChild): (DOMDocument::lastChild): (DOMDocument::previousSibling): (DOMDocument::nextSibling): (DOMDocument::attributes): (DOMDocument::ownerDocument): (DOMDocument::insertBefore): (DOMDocument::replaceChild): (DOMDocument::removeChild): (DOMDocument::appendChild): (DOMDocument::hasChildNodes): (DOMDocument::cloneNode): (DOMDocument::isSupported): (DOMDocument::namespaceURI): (DOMDocument::prefix): (DOMDocument::setPrefix): (DOMDocument::localName): (DOMDocument::hasAttributes): (DOMDocument::isSameNode): (DOMDocument::isEqualNode): (DOMDocument::textContent): (DOMDocument::setTextContent): (DOMElement::throwException): (DOMElement::callWebScriptMethod): (DOMElement::evaluateWebScript): (DOMElement::removeWebScriptKey): (DOMElement::stringRepresentation): (DOMElement::webScriptValueAtIndex): (DOMElement::setWebScriptValueAtIndex): (DOMElement::setException): (DOMElement::nodeName): (DOMElement::nodeValue): (DOMElement::setNodeValue): (DOMElement::nodeType): (DOMElement::parentNode): (DOMElement::childNodes): (DOMElement::firstChild): (DOMElement::lastChild): (DOMElement::previousSibling): (DOMElement::nextSibling): (DOMElement::attributes): (DOMElement::ownerDocument): (DOMElement::insertBefore): (DOMElement::replaceChild): (DOMElement::removeChild): (DOMElement::appendChild): (DOMElement::hasChildNodes): (DOMElement::cloneNode): (DOMElement::isSupported): (DOMElement::namespaceURI): (DOMElement::prefix): (DOMElement::setPrefix): (DOMElement::localName): (DOMElement::hasAttributes): (DOMElement::isSameNode): (DOMElement::isEqualNode): (DOMElement::textContent): (DOMElement::setTextContent):
- 11:33 PM Changeset in webkit [57128] by
-
- 2 edits in trunk/WebCore
2010-04-05 Eric Uhrhane <ericu@chromium.org>
Reviewed by Brady Eidson.
window.openDatabase() always fails for new databases when using WebKit nightly with Safari 4.0.5
https://bugs.webkit.org/show_bug.cgi?id=36671
The previous "fix" I mistakenly compared hashes, an improvement over comparing pointers, but still not right.
No new tests.
- storage/DatabaseTracker.cpp: (WebCore::DatabaseTracker::fullPathForDatabaseNoLock): Use SecurityOrigin::equal to compare instead of SecurityOriginHash.
- 11:32 PM WebInspector edited by
- (diff)
- 11:11 PM Changeset in webkit [57127] by
-
- 3 edits in trunk/WebCore
2010-04-05 Anthony Ricaud <rik@webkit.org>
Reviewed by Timothy Hatcher.
Web Inspector: Audits launcher view is unusable with a small height window
https://bugs.webkit.org/show_bug.cgi?id=37109
Use flex box instead of absolute positioning to avoid overlapping elements.
- inspector/front-end/AuditLauncherView.js: (WebInspector.AuditLauncherView.prototype._createLauncherUI):
- inspector/front-end/audits.css: (.audit-launcher-view .audit-launcher-view-content): (.audit-launcher-view div.button-container): (.audit-launcher-view .flexible-space):
- 11:08 PM WikiStart edited by
- (diff)
- 11:01 PM Changeset in webkit [57126] by
-
- 2 edits in trunk/WebCore
2010-04-05 Luiz Agostini <luiz.agostini@openbossa.org>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Maemo5 theme - wrong spelling
https://bugs.webkit.org/show_bug.cgi?id=37110
Correcting wrong spelling in RenderThemeQt.cpp.
- platform/qt/RenderThemeQt.cpp:
- 10:52 PM Changeset in webkit [57125] by
-
- 6 edits in trunk/WebKitTools
2010-04-05 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
SheriffBot should force_build builders that are idle and have failed exactly once
https://bugs.webkit.org/show_bug.cgi?id=37059
We can get into a deadlocked state where the commit-queue is stopped
because the builders are red but the SheriffBot hasn't taken action
because the builder has failed only once. The SheriffBot should force
build idle builders that have failed exactly once to either turn the
tree green again (if the test was flaky) or trigger the "failed twice"
remedies (IRC and bug posts).
- Scripts/webkitpy/common/net/buildbot.py:
- Scripts/webkitpy/tool/bot/sheriff.py:
- Scripts/webkitpy/tool/bot/sheriff_unittest.py:
- Scripts/webkitpy/tool/commands/sheriffbot.py:
- Scripts/webkitpy/tool/mocktool.py:
- 10:51 PM Changeset in webkit [57124] by
-
- 4 edits in trunk/WebCore
2010-04-05 Leandro Pereira <leandro@profusion.mobi>
Reviewed by Kenneth Rohde Christiansen.
Add EFL-specific code to platform/Platform*Event.h.
http://webkit.org/b/36309
- platform/PlatformWheelEvent.h:
- platform/PlatformMouseEvent.h:
- platform/PlatformKeyboardEvent.h:
- 10:23 PM Changeset in webkit [57123] by
-
- 2 edits in trunk/JavaScriptCore
Another build fix
- 10:07 PM Changeset in webkit [57122] by
-
- 2 edits in trunk/JavaScriptCore
And another build fix.
- 10:00 PM Changeset in webkit [57121] by
-
- 2 edits in trunk/JavaScriptCore
Build fix
- 9:18 PM Changeset in webkit [57120] by
-
- 4 edits3 adds in trunk/JavaScriptCore
2010-04-05 Oliver Hunt <oliver@apple.com>
Reviewed by Gavin Barraclough.
Support weak maps in JSC
https://bugs.webkit.org/show_bug.cgi?id=37132
Expose an API to allow creation of a map for storing
weak JS references.
- API/JSWeakObjectMapRefInternal.h: Added. (OpaqueJSWeakObjectMap::create): (OpaqueJSWeakObjectMap::map): (OpaqueJSWeakObjectMap::~OpaqueJSWeakObjectMap): (OpaqueJSWeakObjectMap::OpaqueJSWeakObjectMap):
- API/JSWeakObjectMapRefPrivate.cpp: Added.
- API/JSWeakObjectMapRefPrivate.h: Added.
- JavaScriptCore.exp:
- JavaScriptCore.xcodeproj/project.pbxproj:
- runtime/JSGlobalObject.h: (JSC::JSGlobalObject::registerWeakMap): (JSC::JSGlobalObject::deregisterWeakMap):
- 8:59 PM Changeset in webkit [57119] by
-
- 3 edits in trunk/WebKitTools
2010-04-05 Chris Jerdonek <Chris Jerdonek>
Reviewed by Shinichiro Hamaji.
Fixed check-webkit-style issue where the script was prematurely
exiting when encountering deleted files in patches.
- Scripts/webkitpy/style/checker.py:
- Changed non-existent file message from ERROR to WARN.
- StyleChecker.check_file() no longer raises an exception when a file is not found.
- Scripts/webkitpy/style/checker_unittest.py:
- Updated unit tests as necessary.
- 8:50 PM Changeset in webkit [57118] by
-
- 5 edits in trunk/WebCore
2010-04-05 Leandro Pereira <leandro@profusion.mobi>
Reviewed by Kenneth Rohde Christiansen.
Add EFL-specific code to platform/graphics/*.h.
http://webkit.org/b/36308
- platform/graphics/Icon.h:
- platform/graphics/IntRect.h:
- platform/graphics/FloatRect.h:
- platform/graphics/IntPoint.h:
- 8:33 PM Changeset in webkit [57117] by
-
- 3 edits in trunk/WebCore
2010-04-05 Robert Hogan <robert@webkit.org>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Fix infinite redirection loop in QNetworkReplyHandler
Put a maximum on consecutive redirections so we don't have to
worry about whether it's the same url or not.
Tolerate up to 10 consecutive redirections, anything beyond
that is considered a potentially infinite recursion in the
redirection requests. This is the same behaviour as Firefox.
- platform/network/qt/QNetworkReplyHandler.cpp: (WebCore::QNetworkReplyHandler::QNetworkReplyHandler): (WebCore::QNetworkReplyHandler::sendResponseIfNeeded):
- platform/network/qt/QNetworkReplyHandler.h:
- 8:08 PM Changeset in webkit [57116] by
-
- 6 edits6 adds in trunk
2010-04-05 Dimitri Glazkov <Dimitri Glazkov> and James Robinson <jamesr@chromium.org>
Reviewed by Darin Adler and Dimitri Glazkov.
Style update done due to mutation event dispatching in textarea can be
used to corrupt the render tree.
https://bugs.webkit.org/show_bug.cgi?id=36864
Tests: fast/forms/select-change-listbox-to-popup-roundtrip.html
fast/forms/select-change-popup-to-listbox-roundtrip.html
fast/forms/textarea-and-mutation-events.html
- dom/Document.cpp: (WebCore::Document::finishedParsing): Added updateStyleIfNeeded()
call to ensure that object loads start before firing window load.
- dom/Node.cpp: (WebCore::Node::dispatchGenericEvent): Removed invocation of
Document::updateStyleForAllDocuments
- html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::parseMappedAttribute): Added explicit
recalc to ensure accuracy of representation, especially for
menuList/listBox switches.
2010-04-05 Dimitri Glazkov <Dimitri Glazkov>
Reviewed by Darin Adler
Style update done due to mutation event dispatching in textarea can be
used to corrupt the render tree.
https://bugs.webkit.org/show_bug.cgi?id=36864
Modified listbox-selection.html to correctly set the size during
creation. Otherwise, options added to it as a menuList, resulting
in a default selection of the first item.
Added a few more tests to ensure we capture correct behavior for
select elements and their default selection, as well as the influence
of when layout occurs.
- fast/forms/listbox-selection.html:
- fast/forms/select-change-listbox-to-popup-roundtrip.html: Added.
- fast/forms/select-change-popup-to-listbox-roundtrip.html: Added.
- fast/forms/textarea-and-mutation-events.html: Added.
- 8:02 PM Changeset in webkit [57115] by
-
- 7 edits in trunk/WebKitTools
2010-04-05 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
SheriffBot should include blamelist when posting to bugs
https://bugs.webkit.org/show_bug.cgi?id=37113
When posting on bugs, we should include the full list of SVN revisions
that caused the regression to folks have a better sense of whether they
are to blame.
- Scripts/webkitpy/tool/bot/sheriff.py:
- Scripts/webkitpy/tool/bot/sheriff_unittest.py:
- Scripts/webkitpy/tool/commands/sheriffbot.py:
- Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
- Scripts/webkitpy/tool/commands/upload_unittest.py:
- Scripts/webkitpy/tool/mocktool.py:
- 7:32 PM Changeset in webkit [57114] by
-
- 2 edits1 delete in trunk/WebKitTools
Unreviewed after discussion with Adam, Darin, and Eric.
Deleted the auto-install directory since it is no longer needed in
source control (it is auto-generated).
Also added webkitpy/thirdparty/autoinstalled to webkitpy/thirdparty's
svn:ignore property.
- Scripts/webkitpy/thirdparty/autoinstalled: Removed.
- 7:24 PM Changeset in webkit [57113] by
-
- 2 edits in trunk/LayoutTests
Update a test result.
- platform/mac/editing/inserting/break-blockquote-after-delete-expected.txt:
- 7:03 PM Changeset in webkit [57112] by
-
- 2 edits1 add in trunk/WebCore
2010-04-05 Antonio Gomes <tonikitoo@webkit.org>
Reviewed by Laszlo Gombos.
Cleaned up spatial-navigation-test-cases.html by removing the wrongly
used <frameset> tag. Patch also adds a manual-test specifically to
test Spatial Navigation with framesets.
- manual-tests/spatial-navigation/frameset.html: Added.
- manual-tests/spatial-navigation/spatial-navigation-test-cases.html:
- 6:45 PM Changeset in webkit [57111] by
-
- 12 edits2 adds in trunk
Test case for <http://webkit.org/b/37115> / <rdar://problem/7829331>.
REGRESSION(r56989): Crash in Mail in WebCore::Position::isCandidate when deleting block using block deletion UI
Reviewed by Adele Peterson.
WebKit/mac:
- WebView/WebHTMLView.mm:
(-[WebHTMLView _updateFontPanel]): Ask the window whether it is the key window rather than doing the comparison
manually. This allows DumpRenderTree's override of isKeyWindow to force this code path to be taken during tests.
WebKitTools:
Add a JavaScript hook in DRT to call through to WebView's -setEditable:. This is required in order to reproduce
the crash.
- DumpRenderTree/LayoutTestController.cpp:
(setWebViewEditableCallback):
(LayoutTestController::staticFunctions):
- DumpRenderTree/LayoutTestController.h:
- DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
(LayoutTestController::setWebViewEditable):
- DumpRenderTree/mac/DumpRenderTree.mm:
(resetWebViewToConsistentStateBeforeTesting):
- DumpRenderTree/mac/LayoutTestControllerMac.mm:
(LayoutTestController::setWebViewEditable):
- DumpRenderTree/win/LayoutTestControllerWin.cpp:
(LayoutTestController::setWebViewEditable):
- DumpRenderTree/wx/LayoutTestControllerWx.cpp:
(LayoutTestController::setWebViewEditable):
(LayoutTestController::layerTreeAsText):
LayoutTests:
- platform/mac/editing/deleting/deletionUI-successful-deletion-expected.txt: Added.
- platform/mac/editing/deleting/deletionUI-successful-deletion.html: Added.
- platform/mac/editing/deleting/resources/deletionUI-helpers.js:
(deletionUIDeleteButtonForElement):
(determineDeletionUIExistence):
- 6:45 PM Changeset in webkit [57110] by
-
- 3 edits in trunk/WebCore
Roll out r56989 as it introduced crashes in Mail.
<http://webkit.org/b/37115> / <rdar://problem/7829331>
Reviewed by Adele Peterson.
- dom/Position.cpp:
(WebCore::Position::isCandidate):
- dom/PositionIterator.cpp:
(WebCore::PositionIterator::isCandidate):
- 6:38 PM Changeset in webkit [57109] by
-
- 18 edits3 adds in trunk
Images must re-load when an image-holding element moves into a new document
https://bugs.webkit.org/show_bug.cgi?id=37127
Reviewed by Sam Weinig.
WebCore:
Test: fast/images/move-image-to-new-document.html
- html/HTMLImageElement.cpp:
(WebCore::HTMLImageElement::willMoveToNewOwnerDocument): Call ImageLoader's
elementWillMoveToNewOwnerDocument function.
- html/HTMLImageElement.h: Added willMoveToNewOwnerDocument.
- html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::willMoveToNewOwnerDocument): Ditto.
- html/HTMLPlugInImageElement.cpp:
(WebCore::HTMLPlugInImageElement::willMoveToNewOwnerDocument): Ditto.
- html/HTMLPlugInImageElement.h: Ditto.
- html/HTMLVideoElement.cpp:
(WebCore::HTMLVideoElement::willMoveToNewOwnerDocument): Ditto.
- html/HTMLVideoElement.h: Ditto.
- svg/SVGImageElement.cpp:
(WebCore::SVGImageElement::willMoveToNewOwnerDocument): Ditto.
- svg/SVGImageElement.h: Ditto.
- html/HTMLMediaElement.h: Made willMoveToNewOwnerDocument protected
so it can be called by HTMLVideoElement.cpp.
- loader/ImageLoader.cpp:
(WebCore::ImageLoader::elementWillMoveToNewOwnerDocument): Added.
Resets the loader by clearing out the cached image.
- loader/ImageLoader.h: Added it.
LayoutTests:
- fast/images/move-image-to-new-document-expected.txt: Added.
- fast/images/move-image-to-new-document.html: Added.
- fast/images/script-tests/move-image-to-new-document.js: Added.
- fast/js/resources/js-test-post.js: Added a feature for doing asynchronous scripting
tests. The caller sets jsTestIsAsync to true and then calls finishJSTest when done.
Used by the above test.
- platform/mac/editing/pasteboard/drag-image-to-contenteditable-in-iframe-expected.checksum:
- platform/mac/editing/pasteboard/drag-image-to-contenteditable-in-iframe-expected.png:
- platform/mac/editing/pasteboard/drag-image-to-contenteditable-in-iframe-expected.txt:
Updated since the old test result relied on an incorrect load of an image.
The relative URL has a different base when moved into the subframe document.
- 5:55 PM Changeset in webkit [57108] by
-
- 4 edits in trunk
2010-04-05 Laszlo Gombos <Laszlo Gombos>
Reviewed by Kenneth Rohde Christiansen.
[Symbian] Consolidate Symbian WINSCW environment configuration
https://bugs.webkit.org/show_bug.cgi?id=37100
Move the "undefinition" of WIN32 and _WIN32 from WebCore/config.h
to JavaScriptCore/wtf/Platform.h as it is not specific to WebCore.
PLATFORM(WIN) and OS(WIN) no longer needs to be undefined as
undefining WIN32 takes care of it.
- wtf/Platform.h:
2010-04-05 Laszlo Gombos <Laszlo Gombos>
Reviewed by Kenneth Rohde Christiansen.
[Symbian] Consolidate Symbian WINSCW environment configuration
https://bugs.webkit.org/show_bug.cgi?id=37100
Move the "undefinition" of WIN32 and _WIN32 from WebCore/config.h
to JavaScriptCore/wtf/Platform.h as it is not specific to WebCore.
No new tests as there is no new functionality.
- config.h:
- 5:34 PM Changeset in webkit [57107] by
-
- 1 edit1 add in trunk/WebCore
2010-04-05 Leandro Pereira <leandro@profusion.mobi>
Reviewed by Kenneth Rohde Christiansen.
Add missing ClipboardEfl.h to platform/efl.
http://webkit.org/b/36242
- platform/efl/ClipboardEfl.h: Added.
- 5:18 PM Changeset in webkit [57106] by
-
- 7 edits in trunk/LayoutTests
2010-04-05 Zhenyao Mo <zmo@google.com>
Reviewed by Darin Adler.
A few tests in fast/canvas/webgl/ failed on Leopard Release Bot randomly.
https://bugs.webkit.org/show_bug.cgi?id=37077
https://bugs.webkit.org/show_bug.cgi?id=37098
- fast/canvas/webgl/drawArraysOutOfBounds-expected.txt: Gathering more information about framebuffer status when failure happens.
- fast/canvas/webgl/drawArraysOutOfBounds.html: Ditto.
- fast/canvas/webgl/drawElementssOutOfBounds-expected.txt: Ditto.
- fast/canvas/webgl/drawElementssOutOfBounds.html: Ditto.
- fast/canvas/webgl/index-validation-copies-indices-expected.txt: Ditto.
- fast/canvas/webgl/index-validation-copies-indices.html: Ditto.
- 5:08 PM Changeset in webkit [57105] by
-
- 7 edits3 adds in trunk
2010-04-05 Yuta Kitamura <yutak@chromium.org>
Reviewed by Darin Adler.
Escape control characters in CSS string value when it is serialilzed.
When WebKit serializes a CSS string value that contains binary characters
('\0\1\2' for example), it did not escape these characters. As a result,
users got (invisible) control characters through scripts. This change fixes
this issue.
As a side effect, two separate codes for escaping CSS strings are merged, and
become a public function (quoteCSSString).
CSS string value is not correctly serialized when it contains binary characters
https://bugs.webkit.org/show_bug.cgi?id=28938
- fast/css/script-tests/string-quote-binary.js: Added.
- fast/css/string-quote-binary-expected.txt: Added.
- fast/css/string-quote-binary.html: Added.
- fast/js/resources/js-test-pre.js: (shouldBeEqualToString): Considering the case when the argument contains binary characters.
2010-04-05 Yuta Kitamura <yutak@chromium.org>
Reviewed by Darin Adler.
Escape control characters in CSS string value when it is serialilzed.
When WebKit serializes a CSS string value that contains binary characters
('\0\1\2' for example), it did not escape these characters. As a result,
users got (invisible) control characters through scripts. This change fixes
this issue.
As a side effect, two separate codes for escaping CSS strings are merged, and
become a public function (quoteCSSString).
CSS string value is not correctly serialized when it contains binary characters
https://bugs.webkit.org/show_bug.cgi?id=28938
Test: fast/css/string-quote-binary.html
- css/CSSParser.cpp: (WebCore::isCSSTokenizerIdentifier): (WebCore::isCSSTokenizerURL): (WebCore::quoteCSSString): (WebCore::quoteCSSStringIfNeeded): (WebCore::quoteCSSURLIfNeeded):
- css/CSSParser.h:
- css/CSSPrimitiveValue.cpp: (WebCore::CSSPrimitiveValue::cssText):
- css/FontFamilyValue.cpp: (WebCore::FontFamilyValue::cssText):
- 5:06 PM Changeset in webkit [57104] by
-
- 2 edits in trunk/SunSpider
Updated the ignore property for changes to the contents here.
- .: Modified property svn:ignore.
- 4:54 PM Changeset in webkit [57103] by
-
- 3 edits2 adds in trunk
2010-04-05 John Gregg <johnnyg@google.com>
Reviewed by Darin Adler.
Notifications should not resolve an empty icon parameter as a relative URL
https://bugs.webkit.org/show_bug.cgi?id=36862
- fast/notifications/notifications-no-icon-expected.txt: Added.
- fast/notifications/notifications-no-icon.html-disabled: Added.
2010-04-05 John Gregg <johnnyg@google.com>
Reviewed by Darin Adler.
Notifications should not resolve an empty icon parameter as a relative URL
https://bugs.webkit.org/show_bug.cgi?id=36862
- notifications/Notification.cpp: (WebCore::Notification::Notification):
- 4:40 PM Changeset in webkit [57102] by
-
- 10 edits in trunk/WebKitTools
Ignore more files the Python tools strew about the working directory.
- Scripts/webkitpy: Added property svn:ignore.
- Scripts/webkitpy/common: Added property svn:ignore.
- Scripts/webkitpy/common/checkout: Added property svn:ignore.
- Scripts/webkitpy/common/config: Added property svn:ignore.
- Scripts/webkitpy/common/net: Added property svn:ignore.
- Scripts/webkitpy/common/thread: Added property svn:ignore.
- Scripts/webkitpy/python24: Added property svn:ignore.
- Scripts/webkitpy/thirdparty/autoinstalled: Modified property svn:ignore.
- Scripts/webkitpy/tool/bot: Added property svn:ignore.
- 4:19 PM Changeset in webkit [57101] by
-
- 5 edits in trunk/WebCore
Removed some unneeded type casts.
Reviewed by Mark Rowe.
- css/CSSPrimitiveValue.cpp:
(WebCore::CSSPrimitiveValue::cssText): Removed an unneeded cast.
- page/Location.cpp:
(WebCore::Location::host): Removed unneeded parentheses and cast.
(WebCore::Location::port): Ditto.
- platform/KURLGoogle.cpp:
(WebCore::KURL::setPort): Ditto.
- workers/WorkerLocation.cpp:
(WebCore::WorkerLocation::host): Ditto.
(WebCore::WorkerLocation::port): Ditto.
- 4:07 PM Changeset in webkit [57100] by
-
- 5 edits6 deletes in trunk
2010-04-05 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r57081.
http://trac.webkit.org/changeset/57081
https://bugs.webkit.org/show_bug.cgi?id=37121
We think it triggered two tests to fail on Tiger because of
race conditions (Requested by abarth on #webkit).
- fast/forms/listbox-selection.html:
- fast/forms/select-change-listbox-to-popup-roundtrip-expected.txt: Removed.
- fast/forms/select-change-listbox-to-popup-roundtrip.html: Removed.
- fast/forms/select-change-popup-to-listbox-roundtrip-expected.txt: Removed.
- fast/forms/select-change-popup-to-listbox-roundtrip.html: Removed.
- fast/forms/textarea-and-mutation-events-expected.txt: Removed.
- fast/forms/textarea-and-mutation-events.html: Removed.
2010-04-05 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r57081.
http://trac.webkit.org/changeset/57081
https://bugs.webkit.org/show_bug.cgi?id=37121
We think it triggered two tests to fail on Tiger because of
race conditions (Requested by abarth on #webkit).
- dom/Node.cpp: (WebCore::Node::dispatchGenericEvent):
- html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::parseMappedAttribute):
- 3:57 PM Changeset in webkit [57099] by
-
- 2 edits in trunk/WebCore
ASSERT close()ing the same StorageAreaImpl twice when using multiple PageGroups
<rdar://problem/7828420> and https://bugs.webkit.org/show_bug.cgi?id=37120
Reviewed by Oliver Hunt.
No new tests. (No behavior change)
- storage/StorageNamespaceImpl.cpp:
(WebCore::StorageNamespaceImpl::close): Change this invalid ASSERT to an early return.
- 3:39 PM Changeset in webkit [57098] by
-
- 3 edits in trunk/LayoutTests
Updated expected pixel results for missing plug-in, now using text placeholder.
- platform/mac/plugins/qt-qwidget-plugin-expected.checksum:
- platform/mac/plugins/qt-qwidget-plugin-expected.png:
- 3:03 PM Changeset in webkit [57097] by
-
- 1 edit5 adds in trunk/LayoutTests
Unreviewed.
Separate test results for windows platform because progress element is not implemented for that platform yet.
- platform/win/fast/dom/Window/window-property-descriptors-expected.txt: Added.
- platform/win/fast/dom/prototype-inheritance-2-expected.txt: Added.
- platform/win/fast/dom/prototype-inheritance-expected.txt: Added.
- platform/win/fast/js: Added.
- platform/win/fast/js/global-constructors-expected.txt: Added.
- 2:52 PM Changeset in webkit [57096] by
-
- 3 edits in trunk/WebCore
2010-04-05 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r57030.
http://trac.webkit.org/changeset/57030
https://bugs.webkit.org/show_bug.cgi?id=37114
Regressed fast/repaint/line-flow-with-floats-9 pixel tests in
chromium port (Requested by jamesr on #webkit).
- rendering/RenderBlock.h:
- rendering/RenderBlockLineLayout.cpp: (WebCore::RenderBlock::layoutInlineChildren):
- 2:49 PM Changeset in webkit [57095] by
-
- 22 edits in trunk
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=37111
<rdar://problem/7790327> Draw replacement text when plug-in host crashes
- 2:16 PM Changeset in webkit [57094] by
-
- 2 edits in trunk/LayoutTests
Unreviewed.
Bug 37112 - aria-liveregion-notifications.html fails on leopard release bot
https://bugs.webkit.org/show_bug.cgi?id=37112
Disabling this test on Leopard until further investigation can reveal the answer.
It looks like at this point, any new test added will cause this test to fail on Leopard
release bot, even if it has nothing to do with live regions.
- platform/mac-leopard/Skipped:
- 1:41 PM Changeset in webkit [57093] by
-
- 8 edits2 adds in trunk
WebCore: Bug 37040 - AX: need to send selected children change notification when aria-selected changed
https://bugs.webkit.org/show_bug.cgi?id=37040
Reviewed by Darin Adler.
When aria-selected is changed in the DOM, it will trigger a selected children change notification.
Test: platform/mac/accessibility/aria-listbox-selectedchildren-change.html
- accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::selectedChildrenChanged):
- accessibility/AXObjectCache.h:
- accessibility/AccessibilityMediaControls.cpp:
(WebCore::AccessibilityMediaControl::controlType):
Remove extra whitespace before comment (webkit-style).
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::observableObject):
Allowed a listBox to be an observable object.
(WebCore::AccessibilityRenderObject::ariaRoleHasPresentationalChildren):
(WebCore::AccessibilityRenderObject::ariaListboxSelectedChildren):
Updated and streamlined existing code.
- dom/Element.cpp:
(WebCore::Element::updateAfterAttributeChanged):
LayoutTests: Tests for
Bug 37040 - AX: need to send selected children change notification when aria-selected changed
https://bugs.webkit.org/show_bug.cgi?id=37040
Reviewed by Darin Adler.
- platform/mac/accessibility/aria-listbox-selectedchildren-change-expected.txt: Added.
- platform/mac/accessibility/aria-listbox-selectedchildren-change.html: Added.
- 1:38 PM Changeset in webkit [57092] by
-
- 1 edit4 adds in trunk/LayoutTests
Unreviewed.
Separate test results for gtk platform because progress element is not implemented for that platform yet.
- platform/gtk/fast/dom/Window/window-property-descriptors-expected.txt: Added.
- platform/gtk/fast/dom/prototype-inheritance-expected.txt: Added.
- platform/gtk/fast/js: Added.
- platform/gtk/fast/js/global-constructors-expected.txt: Added.
- 12:55 PM Changeset in webkit [57091] by
-
- 6 edits in trunk/WebKitTools
2010-04-05 Adam Barth <abarth@webkit.org>
Unreviewed. Add Vitaly Repeshko as a committer.
- Scripts/webkitpy/common/config/committers.py:
- 12:33 PM Changeset in webkit [57090] by
-
- 2 edits in trunk/WebKitTools
2010-04-05 Adam Barth <abarth@webkit.org>
Unreviewed. Add Vitaly Repeshko as a committer.
- Scripts/webkitpy/common/config/committers.py:
- 12:27 PM Changeset in webkit [57089] by
-
- 2 edits in trunk/WebCore
Fix regression in pixel test for animated svg background images.
Patch by Adam Treat <atreat@rim.com> on 2010-04-05
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=37027
- svg/graphics/SVGImage.cpp:
(WebCore::SVGImageChromeClient::invalidateContentsAndWindow):
- 11:30 AM Changeset in webkit [57088] by
-
- 2 edits in trunk/WebKitTools
2010-04-05 Adam Barth <abarth@webkit.org>
Unreviewed. Update kenne's IRC nick to his registered nick.
- Scripts/webkitpy/common/config/committers.py:
- 11:27 AM Changeset in webkit [57087] by
-
- 6 edits in trunk/LayoutTests
2010-04-05 Adam Barth <abarth@webkit.org>
Unreviewed.
Update expected results for addition of HTMLProgressElement. We didn't
see these errors until later because our dependencies are screwed up.
- fast/dom/Window/window-properties-expected.txt:
- fast/dom/Window/window-property-descriptors-expected.txt:
- fast/dom/prototype-inheritance-2-expected.txt:
- fast/dom/prototype-inheritance-expected.txt:
- fast/js/global-constructors-expected.txt:
- 11:24 AM Changeset in webkit [57086] by
-
- 5 edits in trunk/LayoutTests
Unreviewed layout test fix.
Update mac results for iframe flattening.
- platform/mac/fast/frames/flattening/iframe-flattening-fixed-height-expected.txt:
- platform/mac/fast/frames/flattening/iframe-flattening-fixed-width-and-height-expected.txt:
- platform/mac/fast/frames/flattening/iframe-flattening-fixed-width-expected.txt:
- platform/mac/fast/frames/flattening/iframe-flattening-simple-expected.txt:
- 11:16 AM WebKit Team edited by
- (diff)
- 10:57 AM Changeset in webkit [57085] by
-
- 4 edits in trunk
2010-04-05 Robert Hogan <robert@webkit.org>
Reviewed by Kenneth Rohde-Christiansen.
[Qt] Fix infinite redirection loop in QNetworkReplyHandler
Qt enters an infinite loop if a redirect response redirects to itself.
Fixes http/tests/xmlhttprequest/connection-error-sync.html
- platform/network/qt/QNetworkReplyHandler.cpp: (WebCore::QNetworkReplyHandler::sendResponseIfNeeded):
2010-04-05 Robert Hogan <robert@webkit.org>
Reviewed by Kenneth Rohde-Christiansen.
[Qt] Fix infinite redirection loop in QNetworkReplyHandler
Unskip http/tests/xmlhttprequest/connection-error-sync.html
- platform/qt/Skipped:
- 10:55 AM Changeset in webkit [57084] by
-
- 2 edits in trunk/WebKitTools
2010-04-05 Ojan Vafai <ojan@chromium.org>
Reviewed by Eric Seidel.
prepare-ChangeLog should take a merge-base for which git branch to diff against.
https://bugs.webkit.org/show_bug.cgi?id=36394
- Scripts/prepare-ChangeLog:
- 10:36 AM Changeset in webkit [57083] by
-
- 5 edits in trunk/LayoutTests
Unreviewed layout test fix.
Update Qt results for iframe flattening.
- platform/qt/fast/frames/flattening/iframe-flattening-fixed-height-expected.txt:
- platform/qt/fast/frames/flattening/iframe-flattening-fixed-width-and-height-expected.txt:
- platform/qt/fast/frames/flattening/iframe-flattening-fixed-width-expected.txt:
- platform/qt/fast/frames/flattening/iframe-flattening-simple-expected.txt:
- 10:35 AM Changeset in webkit [57082] by
-
- 19 edits4 deletes in trunk
2010-04-05 Yury Semikhatsky <yurys@chromium.org>
Unreviewed, revert r57078.
- 10:27 AM Changeset in webkit [57081] by
-
- 5 edits6 adds in trunk
2010-04-05 Dimitri Glazkov <Dimitri Glazkov>
Reviewed by Darin Adler.
Style update done due to mutation event dispatching in textarea can be
used to corrupt the render tree.
https://bugs.webkit.org/show_bug.cgi?id=36864
Modified listbox-selection.html to correctly set the size during
creation. Otherwise, options added to it as a menuList, resulting
in a default selection of the first item.
Added a few more tests to ensure we capture correct behavior for
select elements and their default selection, as well as the influence
of when layout occurs.
- fast/forms/listbox-selection.html:
- fast/forms/select-change-listbox-to-popup-roundtrip.html: Added.
- fast/forms/select-change-popup-to-listbox-roundtrip.html: Added.
- fast/forms/textarea-and-mutation-events.html: Added.
2010-04-05 Dimitri Glazkov <Dimitri Glazkov>
Reviewed by Darin Adler.
Style update done due to mutation event dispatching in textarea can be
used to corrupt the render tree.
https://bugs.webkit.org/show_bug.cgi?id=36864
Tests: fast/forms/select-change-listbox-to-popup-roundtrip.html
fast/forms/select-change-popup-to-listbox-roundtrip.html
fast/forms/textarea-and-mutation-events.html
- dom/Node.cpp: (WebCore::Node::dispatchGenericEvent): Removed invocation of
Document::updateStyleForAllDocuments
- html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::parseMappedAttribute): Added explicit
recalc to ensure accuracy of representation, especially for
menuList/listBox switches.
- 10:18 AM Changeset in webkit [57080] by
-
- 4 edits in trunk/WebCore
iframe flattening doesn't flatten
https://bugs.webkit.org/show_bug.cgi?id=36798
Reviewed by Dave Hyatt.
Fixed to the iframe flattening code so that the iframes on
http://www.samisite.com/test-csb2nf/id43.htm are actually
flattened.
Covered by current tests.
- page/FrameView.cpp: Propagate contents changes of iframes
and subframes in framesets to the parent so that it is relayouted
(WebCore::FrameView::setContentsSize):
(WebCore::FrameView::adjustViewSize):
(WebCore::FrameView::scheduleRelayout):
- rendering/RenderPart.cpp: HTMLIFrameElement do not inherit from
HTMLFrameElement, but HTMLFrameElementBase, correct cast. Correct
the use of inset border values. Avoid a sometimes unnecessary
relayout.
(WebCore::RenderPart::layoutWithFlattening):
- rendering/RenderPartObject.cpp: Make the calcHeight and calcWidth
return the right values, considering scrolling and fixed width/height
(WebCore::RenderPartObject::flattenFrame):
(WebCore::RenderPartObject::calcHeight):
(WebCore::RenderPartObject::calcWidth):
(WebCore::RenderPartObject::layout):
- 10:06 AM Changeset in webkit [57079] by
-
- 2 edits in trunk/WebCore
2010-04-05 Vitaly Repeshko <vitalyr@chromium.org>
Reviewed by Yury Semikhatsky.
[V8] Extend the set of types supported by SerializedScriptValue
https://bugs.webkit.org/show_bug.cgi?id=37052
New types include sparse arrays, Uint32, Date, and ImageData.
Serialization process became more flexible. A state can either
directly write primitive values (instead of returning them like
iterator) or construct a new state for serializing complex values
that will return to the current state when done.
Deserialization process now avoids exposing the tags using a set
of factory functions for complex objects instead.
Internal buffer type changed to uint8_t to be independent of
whether char is signed or not.
- bindings/v8/SerializedScriptValue.cpp: (WebCore::): (WebCore::Writer::Writer): (WebCore::Writer::writeString): (WebCore::Writer::writeUint32): (WebCore::Writer::writeDate): (WebCore::Writer::writeNumber): (WebCore::Writer::writeImageData): (WebCore::Writer::writeArray): (WebCore::Writer::writeObject): (WebCore::Writer::writeSparseArray): (WebCore::Writer::doWriteUint32): (WebCore::Writer::doWriteNumber): (WebCore::Writer::append): (WebCore::Writer::fillHole): (WebCore::Writer::byteAt): (WebCore::Serializer::Serializer): (WebCore::Serializer::serialize): (WebCore::Serializer::writeArray): (WebCore::Serializer::writeObject): (WebCore::Serializer::writeSparseArray): (WebCore::Serializer::StateBase::StateBase): (WebCore::Serializer::ErrorState::ErrorState): (WebCore::Serializer::ErrorState::advance): (WebCore::Serializer::State::composite): (WebCore::Serializer::State::State): (WebCore::Serializer::ArrayState::ArrayState): (WebCore::Serializer::ArrayState::advance): (WebCore::Serializer::AbstractObjectState::AbstractObjectState): (WebCore::Serializer::AbstractObjectState::advance): (WebCore::Serializer::ObjectState::ObjectState): (WebCore::Serializer::ObjectState::objectDone): (WebCore::Serializer::SparseArrayState::SparseArrayState): (WebCore::Serializer::SparseArrayState::objectDone): (WebCore::Serializer::push): (WebCore::Serializer::pop): (WebCore::Serializer::handleError): (WebCore::Serializer::checkComposite): (WebCore::Serializer::writeString): (WebCore::Serializer::writeImageData): (WebCore::Serializer::newArrayState): (WebCore::Serializer::newObjectState): (WebCore::Serializer::doSerialize): (WebCore::Reader::Reader): (WebCore::Reader::read): (WebCore::Reader::readString): (WebCore::Reader::readUint32): (WebCore::Reader::readDate): (WebCore::Reader::readNumber): (WebCore::Reader::readImageData): (WebCore::Reader::doReadUint32): (WebCore::Reader::doReadNumber): (WebCore::Deserializer::Deserializer): (WebCore::Deserializer::createArray): (WebCore::Deserializer::createObject): (WebCore::Deserializer::createSparseArray): (WebCore::Deserializer::initializeObject): (WebCore::Deserializer::doDeserialize): (WebCore::Deserializer::stackDepth): (WebCore::SerializedScriptValue::deserialize):
- 10:00 AM Changeset in webkit [57078] by
-
- 19 edits3 copies1 add in trunk
2010-04-05 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Refactored error reporting mechanizm on Worker Global Objects.
Unlike other event listeners which accept single argument(Event)
onerror handler on worker global object should be a function
accepting three arguments. This error reporting was implementedas
EventListener::reportError method which had custom implementations
for v8 and JSC. This patch removes EventListener::reportError and
moves its functionality into custom bindings(V8WorkerContextErrorHandler
and JSWorkerContextErrorHandler) that implement EventListener inerface
for the onerror handler.
This patch also makes uncaught exceptions that happen in the onerror
listener be reported to the Worker's onerror handler.
- WebCore.gypi:
- WebCore.pro:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/JSEventListener.cpp:
- bindings/js/JSEventListener.h:
- bindings/js/JSWorkerContextErrorHandler.cpp: Added. (WebCore::JSWorkerContextErrorHandler::JSWorkerContextErrorHandler): (WebCore::JSWorkerContextErrorHandler::~JSWorkerContextErrorHandler): (WebCore::JSWorkerContextErrorHandler::handleEvent):
- bindings/js/JSWorkerContextErrorHandler.h: Added. (WebCore::JSWorkerContextErrorHandler::create): (WebCore::createJSWorkerContextErrorHandler):
- bindings/scripts/CodeGeneratorJS.pm:
- bindings/scripts/CodeGeneratorV8.pm:
- bindings/v8/V8WorkerContextErrorHandler.cpp: Added. (WebCore::V8WorkerContextErrorHandler::V8WorkerContextErrorHandler): (WebCore::V8WorkerContextErrorHandler::callListenerFunction):
- bindings/v8/V8WorkerContextErrorHandler.h: Added. (WebCore::V8WorkerContextErrorHandler::create):
- bindings/v8/V8WorkerContextEventListener.cpp:
- bindings/v8/V8WorkerContextEventListener.h:
- dom/EventListener.h: Removed reportError method that was used only for reporting worker errors.
- workers/WorkerContext.cpp: (WebCore::WorkerContext::WorkerContext): (WebCore::WorkerContext::reportException):
2010-04-05 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Test that exception which occurs in onerror handler is reported to the Worker object.
- fast/workers/worker-script-error-expected.txt:
- fast/workers/worker-script-error.html:
- workers/WorkerContext.h:
- 8:53 AM Changeset in webkit [57077] by
-
- 3 edits in trunk/WebCore
Fix some "explicit braces to avoid ambiguous 'else'" warnings
https://bugs.webkit.org/show_bug.cgi?id=37088
Reviewed by Darin Adler.
Patch by Antonio Gomes (tonikitoo@webkit.org)
- dom/Node.cpp:
(WebCore::Node::dispatchGenericEvent):
- page/DOMWindow.cpp:
(WebCore::DOMWindow::dispatchEvent):
- 7:28 AM Changeset in webkit [57076] by
-
- 2 edits in trunk/WebCore
2010-04-05 Laszlo Gombos <Laszlo Gombos>
Reviewed by Kenneth Rohde Christiansen.
Consolidate the definition of SKIP_STATIC_CONSTRUCTORS_ON_GCC
Instead of defining and undefining it later, let's not
define SKIP_STATIC_CONSTRUCTORS_ON_GCC for WINSCW.
No new tests as there is no new functionality.
- config.h:
- 7:12 AM Changeset in webkit [57075] by
-
- 2 edits in trunk/LayoutTests
2010-04-05 Robert Hogan <robert@webkit.org>
Rubber-stamped by Kenneth-Rohde Christiansen.
re-login.html and re-login-async.html are now tracked in bugzilla.
- platform/qt/Skipped:
- 6:47 AM Changeset in webkit [57074] by
-
- 2 edits in trunk/WebCore
2010-04-05 Laszlo Gombos <Laszlo Gombos>
Reviewed by Kenneth Rohde Christiansen.
[Qt] [Symbian] Remove obsolete build flags for Symbian
https://bugs.webkit.org/show_bug.cgi?id=37083
Symbian port of QtWebKit port does not use icu, so it does
not need U_HAVE_* defines.
Symbian now has inttypes.h as part of OpenC.
stdio.h, limits.h and MathExtras.h are already included in
more appropriate locations.
No new tests as there is no new functionality.
- config.h:
- 5:48 AM Changeset in webkit [57073] by
-
- 2 edits in trunk/WebCore
2010-04-05 Pavel Feldman <pfeldman@chromium.org>
Not reviewed: chromium build fix.
- bindings/v8/custom/V8InspectorFrontendHostCustom.cpp: (WebCore::V8InspectorFrontendHost::platformCallback): (WebCore::V8InspectorFrontendHost::portCallback):
- 5:48 AM Changeset in webkit [57072] by
-
- 1 edit1 add in trunk/WebKit/gtk/po
2010-04-05 Lucas Lommer <llommer@svn.gnome.org>
Reviewed by Gustavo Noronha.
Czech translation for WebKitGtk
https://bugs.webkit.org/show_bug.cgi?id=36879
- cs.po: Added.
- 5:44 AM Changeset in webkit [57071] by
-
- 2 edits in trunk/WebKit/gtk/po
2010-04-05 Christian Kirbach <Christian.Kirbach@googlemail.com>
Reviewed by Gustavo Noronha.
Updated German translation
https://bugs.webkit.org/show_bug.cgi?id=36453
- de.po:
- 5:38 AM Changeset in webkit [57070] by
-
- 2 edits in trunk/WebKit/gtk/po
2010-04-05 Luca Ferretti <elle.uca@libero.it>
Reviewed by Gustavo Noronha.
Italian translation for 1.1.90
https://bugs.webkit.org/show_bug.cgi?id=36323
- it.po:
- 5:37 AM Changeset in webkit [57069] by
-
- 6 edits in trunk/WebCore
2010-04-05 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: [REGRESSION] platform detection in Chromium
has regressed to unknown.
- bindings/js/JSInspectorFrontendHostCustom.cpp: (WebCore::JSInspectorFrontendHost::platform): (WebCore::JSInspectorFrontendHost::port):
- bindings/v8/custom/V8InspectorFrontendHostCustom.cpp: (WebCore::V8InspectorFrontendHost::platform): (WebCore::V8InspectorFrontendHost::port):
- inspector/InspectorFrontendHost.cpp:
- inspector/InspectorFrontendHost.h:
- inspector/InspectorFrontendHost.idl:
- 4:59 AM Changeset in webkit [57068] by
-
- 8 edits in trunk/WebCore
2010-04-05 Andrey Kosyakov <caseq@chromium.org>
Reviewed by Yury Semikhatsky.
Remove logging of successful XHR and worker's importScript()
to inspector console
https://bugs.webkit.org/show_bug.cgi?id=37078
- bindings/js/JSWorkerContextCustom.cpp: (WebCore::JSWorkerContext::importScripts):
- bindings/v8/custom/V8WorkerContextCustom.cpp: (WebCore::V8WorkerContext::importScriptsCallback):
- workers/DedicatedWorkerContext.cpp: (WebCore::DedicatedWorkerContext::importScripts):
- workers/DedicatedWorkerContext.h:
- workers/WorkerContext.cpp: (WebCore::WorkerContext::importScripts):
- workers/WorkerContext.h:
- xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::didFinishLoading):
- 2:27 AM Changeset in webkit [57067] by
-
- 2 edits in trunk/LayoutTests
2010-04-05 Pavel Feldman <pfeldman@chromium.org>
Not reviewed: chromium test expectations update for the roll.
- platform/chromium/test_expectations.txt:
- 12:41 AM Changeset in webkit [57066] by
-
- 5 edits in trunk/WebKitTools
2010-04-05 Chris Jerdonek <Chris Jerdonek>
Reviewed by Shinichiro Hamaji.
Removed the PatchStyleErrorHandler class and incorporated its
functionality into the DefaultStyleErrorHandler class.
- Scripts/webkitpy/style/checker.py:
- In the StyleChecker class:
- Added a line_number parameter to the check_file() method.
- Renamed the handle_style_error parameter to mock_handle_style_error to be consistent with the other mock_* parameter names.
- Added a mock_check_file parameter to the check_patch() method to facilitate unit testing the changes in this patch.
- Rewrote the check_patch() method with the patch-parsing logic taken from the PatchStyleErrorHandler class.
- In the StyleChecker class:
- Scripts/webkitpy/style/checker_unittest.py:
- Added a StyleCheckerCheckFileBase class and sub-classed the existing StyleCheckerCheckFileTest class from it.
- Added a StyleCheckerCheckPatchTest class to unit-test the rewritten check_patch() method.
- Removed the vestigial main code at the bottom of the file. This is left over from when check-webkit-style was implemented as a module and a wrapper module.
- Scripts/webkitpy/style/error_handlers.py:
- Added an optional line_numbers parameter to the DefaultStyleErrorHandler class constructor and adjusted the call() method as necessary.
- Removed the PatchStyleErrorHandler class.
- Scripts/webkitpy/style/error_handlers_unittest.py:
- Removed the PatchStyleErrorHandlerTest class which unit-tested the PatchStyleErrorHandler class which is being removed in this patch.
- Added a test_line_numbers() test method to the DefaultStyleErrorHandlerTest class to test use of the DefaultStyleErrorHandler's new line_numbers attribute.
- 12:24 AM Changeset in webkit [57065] by
-
- 4 edits in trunk/WebKitTools
2010-04-05 Adam Barth <abarth@webkit.org>
Unreviewed.
Tighten SheriffBot's flaky test detector
https://bugs.webkit.org/show_bug.cgi?id=37063
Instead of just looking for two sequential red builds, look for two
sequential failures of the same test. This should reduce sheriffbot
false positive substantially.
I'm landing this change unreviewed because I've noticed SheriffBot
triggering a lot more false positives now that we've expanded the set
of core builders. I've tried to take Eric's comments on Bug 37063 into
account. I'm happy to iterate on this patch tomorrow once Eric wakes
up.
- Scripts/webkitpy/common/net/buildbot.py:
- Scripts/webkitpy/common/net/buildbot_unittest.py:
- Scripts/webkitpy/tool/commands/queries.py:
