Timeline
Apr 8, 2010:
- 11:43 PM Changeset in webkit [57313] by
-
- 8 edits2 adds in trunk
2010-04-08 Chris Evans <cevans@chromium.org>
Reviewed by Sam Weinig.
Add test for POST & _blank popup blocker bypass.
https://bugs.webkit.org/show_bug.cgi?id=34541
- fast/events/popup-blocked-to-post-blank.html: added
- fast/events/popup-blocked-to-post-blank-expected.txt: added
2010-04-08 Chris Evans <cevans@chromium.org>
Reviewed by Sam Weinig.
Use the new UserGestureIndictor for _blank POST requests.
Test: fast/events/popup-blocked-to-post-blank.html
- bindings/v8/ScriptController.cpp: (WebCore::ScriptController::processingUserGesture): Use UserGestureIndicator in more cases.
- page/EventHandler.cpp: (WebCore::EventHandler): Impact from UserGestureIndicator API change. (WebCore::FrameLoader::submitForm): Block the load immediately if popups are not allowed and it would open a new window.
- loader/RedirectScheduler.cpp: (WebCore::ScheduledFormSubmission::ScheduledFormSubmission): Note the UserGestureIndicator status at the time of submission. (WebCore::ScheduledFormSubmission::fire): Use the stored UserGestureIndicator status in the asynchronous callback.
- dom/UserGestureIndicator.h:
- dom/UserGestureIndicator.cpp: (WebCore::UserGestureIndicator::UserGestureIndicator): Add ability to store a negative indication.
- 6:14 PM Changeset in webkit [57312] by
-
- 2 edits in trunk/WebKitTools
Add option to build WebKit2 to build-webkit.
Reviewed by Darin Adler.
- Scripts/build-webkit:
- 5:52 PM Changeset in webkit [57311] by
-
- 1 edit23 adds in trunk/WebKit2
Add build support for WebKit2.
Reviewed by Anders Carlsson.
- Configurations: Added.
- Configurations/Base.xcconfig: Added.
- Configurations/DebugRelease.xcconfig: Added.
- Configurations/FeatureDefines.xcconfig: Added.
- Configurations/Version.xcconfig: Added.
- Configurations/WebKit2.xcconfig: Added.
- English.lproj: Added.
- English.lproj/InfoPlist.strings: Added.
- Info.plist: Added.
- Makefile: Added.
- WebKit2.xcodeproj: Added.
- WebKit2.xcodeproj/project.pbxproj: Added.
- WebKit2Prefix.cpp: Added.
- WebKit2Prefix.h: Added.
- WebKit2_Prefix.pch: Added.
- WebProcess-Info.plist: Added.
- version.plist: Added.
- win: Added.
- win/WebKit2.def: Added.
- win/WebKit2.vcproj: Added.
- win/WebKit2Generated.make: Added.
- win/WebKit2Generated.vcproj: Added.
- win/WebKit2WebProcess.vcproj: Added.
- 5:50 PM Changeset in webkit [57310] by
-
- 1 edit73 adds in trunk/WebKit2
Add WebKit2/UIProcess directory.
Patch by Anders Carlsson <andersca@apple.com> on 2010-04-08
Reviewed by Sam Weinig.
- UIProcess: Added.
- UIProcess/API: Added.
- UIProcess/API/C: Added.
- UIProcess/API/C/WKAPICast.h: Added.
- UIProcess/API/C/WKBase.h: Added.
- UIProcess/API/C/WKContext.cpp: Added.
- UIProcess/API/C/WKContext.h: Added.
- UIProcess/API/C/WKFrame.cpp: Added.
- UIProcess/API/C/WKFrame.h: Added.
- UIProcess/API/C/WKFramePolicyListener.cpp: Added.
- UIProcess/API/C/WKFramePolicyListener.h: Added.
- UIProcess/API/C/WKPage.cpp: Added.
- UIProcess/API/C/WKPage.h: Added.
- UIProcess/API/C/WKPageNamespace.cpp: Added.
- UIProcess/API/C/WKPageNamespace.h: Added.
- UIProcess/API/C/WKPreferences.cpp: Added.
- UIProcess/API/C/WKPreferences.h: Added.
- UIProcess/API/C/WebKit2.h: Added.
- UIProcess/API/mac: Added.
- UIProcess/API/mac/PageClientImpl.h: Added.
- UIProcess/API/mac/PageClientImpl.mm: Added.
- UIProcess/API/mac/WKView.h: Added.
- UIProcess/API/mac/WKView.mm: Added.
- UIProcess/API/mac/WKViewInternal.h: Added.
- UIProcess/API/win: Added.
- UIProcess/API/win/WKAPICastWin.h: Added.
- UIProcess/API/win/WKBaseWin.h: Added.
- UIProcess/API/win/WKView.cpp: Added.
- UIProcess/API/win/WKView.h: Added.
- UIProcess/Launcher: Added.
- UIProcess/Launcher/WebProcessLauncher.h: Added.
- UIProcess/Launcher/mac: Added.
- UIProcess/Launcher/mac/WebProcessLauncher.mm: Added.
- UIProcess/Launcher/win: Added.
- UIProcess/Launcher/win/WebProcessLauncher.cpp: Added.
- UIProcess/PageClient.h: Added.
- UIProcess/ProcessModel.h: Added.
- UIProcess/ResponsivenessTimer.cpp: Added.
- UIProcess/ResponsivenessTimer.h: Added.
- UIProcess/ScriptReturnValueCallback.cpp: Added.
- UIProcess/ScriptReturnValueCallback.h: Added.
- UIProcess/WebContext.cpp: Added.
- UIProcess/WebContext.h: Added.
- UIProcess/WebFramePolicyListenerProxy.cpp: Added.
- UIProcess/WebFramePolicyListenerProxy.h: Added.
- UIProcess/WebFrameProxy.cpp: Added.
- UIProcess/WebFrameProxy.h: Added.
- UIProcess/WebLoaderClient.cpp: Added.
- UIProcess/WebLoaderClient.h: Added.
- UIProcess/WebPageNamespace.cpp: Added.
- UIProcess/WebPageNamespace.h: Added.
- UIProcess/WebPageProxy.cpp: Added.
- UIProcess/WebPageProxy.h: Added.
- UIProcess/WebPolicyClient.cpp: Added.
- UIProcess/WebPolicyClient.h: Added.
- UIProcess/WebPreferences.cpp: Added.
- UIProcess/WebPreferences.h: Added.
- UIProcess/WebProcessManager.cpp: Added.
- UIProcess/WebProcessManager.h: Added.
- UIProcess/WebProcessProxy.cpp: Added.
- UIProcess/WebProcessProxy.h: Added.
- UIProcess/WebUIClient.cpp: Added.
- UIProcess/WebUIClient.h: Added.
- UIProcess/mac: Added.
- UIProcess/mac/DrawingAreaProxy.h: Added.
- UIProcess/mac/DrawingAreaProxy.mm: Added.
- UIProcess/mac/DrawingAreaProxyUpdateChunk.h: Added.
- UIProcess/mac/DrawingAreaProxyUpdateChunk.mm: Added.
- UIProcess/win: Added.
- UIProcess/win/DrawingAreaProxy.cpp: Added.
- UIProcess/win/DrawingAreaProxy.h: Added.
- UIProcess/win/WebView.cpp: Added.
- UIProcess/win/WebView.h: Added.
- 5:49 PM Changeset in webkit [57309] by
-
- 1 edit50 adds in trunk/WebKit2
Add WebKit2/WebProcess directory.
Patch by Anders Carlsson <andersca@apple.com> on 2010-04-08
Reviewed by Sam Weinig and Oliver Hunt.
- WebProcess: Added.
- WebProcess/Launching: Added.
- WebProcess/Launching/mac: Added.
- WebProcess/Launching/mac/WebProcessMain.mm: Added.
- WebProcess/Launching/win: Added.
- WebProcess/Launching/win/WebProcessWinMain.cpp: Added.
- WebProcess/WebCoreSupport: Added.
- WebProcess/WebCoreSupport/WebChromeClient.cpp: Added.
- WebProcess/WebCoreSupport/WebChromeClient.h: Added.
- WebProcess/WebCoreSupport/WebContextMenuClient.cpp: Added.
- WebProcess/WebCoreSupport/WebContextMenuClient.h: Added.
- WebProcess/WebCoreSupport/WebDragClient.cpp: Added.
- WebProcess/WebCoreSupport/WebDragClient.h: Added.
- WebProcess/WebCoreSupport/WebEditorClient.cpp: Added.
- WebProcess/WebCoreSupport/WebEditorClient.h: Added.
- WebProcess/WebCoreSupport/WebErrors.h: Added.
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp: Added.
- WebProcess/WebCoreSupport/WebInspectorClient.h: Added.
- WebProcess/WebCoreSupport/mac: Added.
- WebProcess/WebCoreSupport/mac/WebErrorsMac.mm: Added.
- WebProcess/WebCoreSupport/mac/WebSystemInterface.h: Added.
- WebProcess/WebCoreSupport/mac/WebSystemInterface.m: Added.
- WebProcess/WebCoreSupport/win: Added.
- WebProcess/WebCoreSupport/win/WebCoreLocalizedStrings.cpp: Added.
- WebProcess/WebCoreSupport/win/WebErrorsWin.cpp: Added.
- WebProcess/WebPage: Added.
- WebProcess/WebPage/DrawingArea.cpp: Added.
- WebProcess/WebPage/DrawingArea.h: Added.
- WebProcess/WebPage/WebFrame.cpp: Added.
- WebProcess/WebPage/WebFrame.h: Added.
- WebProcess/WebPage/WebPage.cpp: Added.
- WebProcess/WebPage/WebPage.h: Added.
- WebProcess/WebPage/mac: Added.
- WebProcess/WebPage/mac/DrawingAreaUpdateChunk.cpp: Added.
- WebProcess/WebPage/mac/DrawingAreaUpdateChunk.h: Added.
- WebProcess/WebPage/mac/WebPageMac.mm: Added.
- WebProcess/WebPage/win: Added.
- WebProcess/WebPage/win/DrawingAreaUpdateChunk.cpp: Added.
- WebProcess/WebPage/win/DrawingAreaUpdateChunk.h: Added.
- WebProcess/WebPage/win/WebPageWin.cpp: Added.
- WebProcess/WebProcess.cpp: Added.
- WebProcess/WebProcess.h: Added.
- WebProcess/win: Added.
- WebProcess/win/DllMain.cpp: Added.
- WebProcess/win/WebLocalizableStrings.cpp: Added.
- WebProcess/win/WebLocalizableStrings.h: Added.
- WebProcess/win/WebProcessMain.cpp: Added.
- WebProcess/win/WebProcessMain.h: Added.
- 5:47 PM Changeset in webkit [57308] by
-
- 1 edit24 adds in trunk/WebKit2
Add WebKit2/Shared directory.
Reviewed by Anders Carlsson.
- Shared: Added.
- Shared/CoreIPCSupport: Added.
- Shared/CoreIPCSupport/DrawingAreaMessageKinds.h: Added.
- Shared/CoreIPCSupport/DrawingAreaProxyMessageKinds.h: Added.
- Shared/CoreIPCSupport/WebPageMessageKinds.h: Added.
- Shared/CoreIPCSupport/WebPageProxyMessageKinds.h: Added.
- Shared/CoreIPCSupport/WebProcessMessageKinds.h: Added.
- Shared/NotImplemented.h: Added.
- Shared/WebCoreTypeArgumentMarshalling.h: Added.
- Shared/WebEvent.h: Added.
- Shared/WebEventConversion.cpp: Added.
- Shared/WebEventConversion.h: Added.
- Shared/WebPreferencesStore.cpp: Added.
- Shared/WebPreferencesStore.h: Added.
- Shared/mac: Added.
- Shared/mac/UpdateChunk.cpp: Added.
- Shared/mac/UpdateChunk.h: Added.
- Shared/mac/WebEventFactory.h: Added.
- Shared/mac/WebEventFactory.mm: Added.
- Shared/win: Added.
- Shared/win/UpdateChunk.cpp: Added.
- Shared/win/UpdateChunk.h: Added.
- Shared/win/WebEventFactory.cpp: Added.
- Shared/win/WebEventFactory.h: Added.
- 5:46 PM Changeset in webkit [57307] by
-
- 1 edit29 adds in trunk/WebKit2
Add WebKit2/Platform directory.
Reviewed by Anders Carlsson.
- Platform: Added.
- Platform/CoreIPC: Added.
- Platform/CoreIPC/ArgumentDecoder.cpp: Added.
- Platform/CoreIPC/ArgumentDecoder.h: Added.
- Platform/CoreIPC/ArgumentEncoder.cpp: Added.
- Platform/CoreIPC/ArgumentEncoder.h: Added.
- Platform/CoreIPC/Arguments.h: Added.
- Platform/CoreIPC/Attachment.cpp: Added.
- Platform/CoreIPC/Attachment.h: Added.
- Platform/CoreIPC/Connection.cpp: Added.
- Platform/CoreIPC/Connection.h: Added.
- Platform/CoreIPC/MessageID.h: Added.
- Platform/CoreIPC/mac: Added.
- Platform/CoreIPC/mac/ConnectionMac.cpp: Added.
- Platform/CoreIPC/mac/MachPort.h: Added.
- Platform/CoreIPC/win: Added.
- Platform/CoreIPC/win/ConnectionWin.cpp: Added.
- Platform/PlatformProcessIdentifier.h: Added.
- Platform/RunLoop.cpp: Added.
- Platform/RunLoop.h: Added.
- Platform/WorkItem.h: Added.
- Platform/WorkQueue.cpp: Added.
- Platform/WorkQueue.h: Added.
- Platform/mac: Added.
- Platform/mac/RunLoopMac.mm: Added.
- Platform/mac/WorkQueueMac.cpp: Added.
- Platform/win: Added.
- Platform/win/RunLoopWin.cpp: Added.
- 5:37 PM Changeset in webkit [57306] by
-
- 2 edits in trunk/WebKitTools
run-webkit-tests should respect argument order
https://bugs.webkit.org/show_bug.cgi?id=37257
Reviewed by Alexey Proskuryakov.
- Scripts/run-webkit-tests: Changed so that sorting is done only
on the results of iterating directories. Test order is based on
what's passed on the command line. Removed code that aimed to
eliminate duplicates since it can be useful to run the same test
more than once.
- 4:31 PM Changeset in webkit [57305] by
-
- 2 edits in trunk/LayoutTests
2010-04-08 Ojan Vafai <ojan@chromium.org>
Reviewed by Adam Barth.
[Chromium] Mark failing tests after r57292
https://bugs.webkit.org/show_bug.cgi?id=37298
- platform/chromium/test_expectations.txt:
- 4:24 PM Changeset in webkit [57304] by
-
- 3 edits2 adds in trunk
Spatial Navigation: proper handle negative x or y coordinates https://bugs.webkit.org/show_bug.cgi?id=36773
Reviewed by Simon Fraser.
Patch by Antonio Gomes <tonikitoo@webkit.org>
WebCore:
In Spatial Navigation logic, during rect acquisition in renderRectRelativeToRootDocument,
sometimes negative x() or y() values are got, and the current algorithm bails out in
any of such cases.
However, when a node is in a scrollable content (content overflow <div>) and
this scrollable container scrolled up, element gets offscreen, and gets negative values
for y(), for example. In such cases, they are still valid to be used in Spatial Navigation
logic.
Test: fast/events/spatial-navigation/snav-offscreen-content.html
- page/SpatialNavigation.cpp:
(WebCore::distanceDataForNode):
(WebCore::checkNegativeCoordsForNode):
LayoutTests:
- fast/events/spatial-navigation/snav-offscreen-content-expected.txt: Added.
- fast/events/spatial-navigation/snav-offscreen-content.html: Added.
- 4:07 PM Changeset in webkit [57303] by
-
- 2 edits in trunk/LayoutTests
[Qt] r57274 removed fast/forms/willvalidate-000.html,
so it should be removed from Skipped list too.
- platform/qt/Skipped: fast/forms/willvalidate-000.html removed.
- 3:59 PM Changeset in webkit [57302] by
-
- 2 edits in trunk/WebKit/win
WebView::isLoading should null check m_mainFrame
https://bugs.webkit.org/show_bug.cgi?id=37294
Reviewed by Darin Adler.
- WebView.cpp:
(WebView::isLoading):
- 3:55 PM Changeset in webkit [57301] by
-
- 5 edits in trunk
WebCore: Create the creation callback is the current world.
https://bugs.webkit.org/show_bug.cgi?id=37290
Reviewed by Geoffrey Garen.
- bindings/js/JSDatabaseCallback.cpp:
(WebCore::JSDatabaseCallback::JSDatabaseCallback):
LayoutTests: Test that the creation callback is executed in the world where it
was created.
https://bugs.webkit.org/show_bug.cgi?id=37290
Reviewed by Geoffrey Garen.
- storage/open-database-creation-callback-isolated-world-expected.txt:
- storage/open-database-creation-callback-isolated-world.html:
- 3:39 PM Changeset in webkit [57300] by
-
- 2 edits in trunk/LayoutTests
[Qt] Skip new tests introduced in r57292, because of unimplemented
layoutTestController.computedStyleIncludingVisitedInfo()
- platform/qt/Skipped:
- fast/history/nested-visited-test.html skipped.
- fast/history/self-is-visited.html skipped.
- fast/history/sibling-visited-test.html skipped.
- 3:37 PM Changeset in webkit [57299] by
-
- 5 edits in trunk/WebCore
Followup optimization to bug 24300, don't leak history info via CSS :visited. If a Web
site uses document colors that are the same for link and vlink in HTML and also doesn't
specify any :link or :visited rules, then don't waste time resolving visited styles.
Reviewed by Oliver Hunt.
There is a further optimization that could be done to detect when :link and :visited are
used together in the same rule to specify a color, and this is how most sites turn off
visited link colors, but this fix doesn't address that. It just restores the optimization
that existed prior to the patch in 24300 landing.
- css/CSSGrammar.y:
- css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::styleForElement):
- dom/Document.cpp:
(WebCore::Document::Document):
- dom/Document.h:
(WebCore::Document::usesLinkRules):
(WebCore::Document::setUsesLinkRules):
- 3:36 PM WebKit2 edited by
- (diff)
- 3:18 PM Changeset in webkit [57298] by
-
- 1 edit2 adds in trunk/LayoutTests
2010-04-08 Yuzo Fujishima <yuzo@google.com>
Reviewed by Darin Adler.
Another trial
Tests that should have been landed as part of the earlier patch for Bug 36276.
https://bugs.webkit.org/show_bug.cgi?id=36276
- fast/css/invalid-not-with-simple-selector-sequence-expected.txt: Added.
- fast/css/invalid-not-with-simple-selector-sequence.html: Added.
- 3:18 PM WebKit2 created by
- Initial chech-in.
- 3:17 PM Changeset in webkit [57297] by
-
- 2 edits in trunk/WebCore
Caught by pixel tests. I missed patching the borderRightColor() call for fieldset border painting so the
border stopped showing up.
Reviewed by Oliver Hunt.
- rendering/RenderFieldset.cpp:
(WebCore::RenderFieldset::paintBorderMinusLegend):
- 3:16 PM WikiStart edited by
- Add link to WebKit2 design doc (diff)
- 3:09 PM Changeset in webkit [57296] by
-
- 2 adds in trunk/WebKit2
Rubber-stamped by Mark Rowe.
Add WebKit2 directory.
- 3:05 PM Changeset in webkit [57295] by
-
- 1 edit in trunk/LayoutTests/ChangeLog
2010-04-08 Yuzo Fujishima <yuzo@google.com>
Reviewed by Darin Adler.
Tests that should have been landed as part of the earlier patch for Bug 36276.
https://bugs.webkit.org/show_bug.cgi?id=36276
- fast/css/invalid-not-with-simple-selector-sequence-expected.txt: Added.
- fast/css/invalid-not-with-simple-selector-sequence.html: Added.
- 3:02 PM Changeset in webkit [57294] by
-
- 1 edit in trunk/WebKitTools/DumpRenderTree/qt/LayoutTestControllerQt.cpp
Fix Qt build.
- 2:48 PM Changeset in webkit [57293] by
-
- 22 edits1 delete in trunk/LayoutTests
2010-04-08 Ojan Vafai <ojan@chromium.org>
Reviewed by Dimitri Glazkov.
[chromium] Many new test results are needed due to recent check-ins.
https://bugs.webkit.org/show_bug.cgi?id=36799
I missed the linux-only results in http://trac.webkit.org/changeset/57291
- platform/chromium-linux/tables/mozilla/bugs/bug1296-expected.checksum:
- platform/chromium-linux/tables/mozilla/bugs/bug1296-expected.png: Removed.
- platform/chromium-linux/tables/mozilla/bugs/bug1430-expected.checksum:
- platform/chromium-linux/tables/mozilla/bugs/bug1430-expected.png:
- platform/chromium-linux/tables/mozilla/marvin/backgr_simple-table-column-group-expected.checksum:
- platform/chromium-linux/tables/mozilla/marvin/backgr_simple-table-column-group-expected.png:
- platform/chromium-linux/tables/mozilla/marvin/backgr_simple-table-row-group-expected.checksum:
- platform/chromium-linux/tables/mozilla/marvin/backgr_simple-table-row-group-expected.png:
- platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_border-table-column-expected.checksum:
- platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_border-table-column-expected.png:
- platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_border-table-column-group-expected.checksum:
- platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_border-table-column-group-expected.png:
- platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_border-table-row-expected.checksum:
- platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_border-table-row-expected.png:
- platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_fixed-bg-expected.checksum:
- platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_fixed-bg-expected.png:
- platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_layers-hide-expected.checksum:
- platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_layers-hide-expected.png:
- platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_position-table-column-expected.checksum:
- platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_position-table-column-expected.png:
- platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_position-table-row-group-expected.checksum:
- platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_position-table-row-group-expected.png:
- 2:29 PM Changeset in webkit [57292] by
-
- 44 edits7 adds3 deletes in trunk
WebCore: https://bugs.webkit.org/show_bug.cgi?id=24300, don't leak history info via CSS :visited.
Reviewed by Oliver Hunt.
This patch implements the policy described by David Baron here:
http://dbaron.org/mozilla/visited-privacy
Added new tests in fast/history.
- WebCore.base.exp:
Expose functions needed for the WebKit SPI used by layout tests.
- WebCore.xcodeproj/project.pbxproj:
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::isVisited):
Make sure accessibility objects still return visited information.
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::CSSComputedStyleDeclaration):
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
- css/CSSComputedStyleDeclaration.h:
(WebCore::computedStyle):
Add a boolean to computed style declarations that - if set - causes the computed style
to still return :visited information. For normal Web pages, this will be false. It is set
to true for the Web Inspector and by the WebKit SPI used by the layout tests.
- css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::initElement):
(WebCore::CSSStyleSelector::SelectorChecker::SelectorChecker):
(WebCore::CSSStyleSelector::SelectorChecker::determineLinkState):
(WebCore::CSSStyleSelector::SelectorChecker::checkSelector):
(WebCore::CSSStyleSelector::canShareStyleWithElement):
(WebCore::CSSStyleSelector::styleForElement):
(WebCore::CSSStyleSelector::keyframeStylesForAnimation):
(WebCore::CSSStyleSelector::pseudoStyleForElement):
(WebCore::CSSStyleSelector::pseudoStyleRulesForElement):
(WebCore::CSSStyleSelector::checkSelector):
(WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector):
(WebCore::CSSStyleSelector::applyPropertyToStyle):
(WebCore::CSSStyleSelector::getColorFromPrimitiveValue):
- css/CSSStyleSelector.h:
Rework the style selector to resolve two styles instead of one. The first forces the link to
be unvisited, and the second forces the link to be visited. The real state of the link is
cached on the principal (unvisited) style. The visited style hangs off the principal style
as a pseudo style (VISITED_LINK).
- dom/Element.cpp:
(WebCore::Element::pseudoStyleCacheIsInvalid):
Make sure to deal with the VISITED_LINK pseudo to know when only :visited style info changed.
- inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::getStyles):
Let the Web Inspector see :visited computed styles by default.
- platform/LinkHash.cpp:
(WebCore::visitedURL):
Fix an issue where <a href=""> is not hashed properly to the document's base URI, so it wasn't
correctly reported as :visited.
- rendering/InlineFlowBox.cpp:
(WebCore::InlineFlowBox::paintBoxDecorations):
(WebCore::InlineFlowBox::paintTextDecorations):
- rendering/InlineTextBox.cpp:
(WebCore::InlineTextBox::paint):
(WebCore::InlineTextBox::paintSelection):
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::paintColumnRules):
(WebCore::RenderBlock::paintObject):
- rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::paintBorder):
- rendering/RenderFieldset.cpp:
(WebCore::RenderFieldset::paintBorderMinusLegend):
- rendering/RenderImage.cpp:
(WebCore::RenderImage::paintFocusRings):
- rendering/RenderInline.cpp:
(WebCore::RenderInline::paintOutline):
(WebCore::RenderInline::paintOutlineForLine):
- rendering/RenderObject.cpp:
(WebCore::RenderObject::drawLineForBoxSide):
(WebCore::RenderObject::drawArcForBoxSide):
(WebCore::RenderObject::paintOutline):
(WebCore::decorationColor):
(WebCore::RenderObject::getTextDecorationColors):
- rendering/RenderObject.h:
- rendering/RenderPath.cpp:
(WebCore::RenderPath::paint):
- rendering/RenderReplaced.cpp:
(WebCore::RenderReplaced::paint):
- rendering/RenderSVGContainer.cpp:
(WebCore::RenderSVGContainer::paint):
- rendering/RenderSVGImage.cpp:
(WebCore::RenderSVGImage::paint):
- rendering/RenderSVGRoot.cpp:
(WebCore::RenderSVGRoot::paint):
- rendering/RenderTableCell.cpp:
(WebCore::RenderTableCell::collapsedLeftBorder):
(WebCore::RenderTableCell::collapsedRightBorder):
(WebCore::RenderTableCell::collapsedTopBorder):
(WebCore::RenderTableCell::collapsedBottomBorder):
(WebCore::RenderTableCell::paintCollapsedBorder):
- rendering/style/CollapsedBorderValue.h:
(WebCore::CollapsedBorderValue::CollapsedBorderValue):
(WebCore::CollapsedBorderValue::color):
(WebCore::CollapsedBorderValue::operator==):
Patch painting code to fetch visitedDependentColors from the RenderStyle. Properties that
are honored include background-color, color, border colors, outline color, column rules,
and fill and stroke (both SVG and our custom versions).
- rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::RenderStyle):
(WebCore::RenderStyle::diff):
(WebCore::borderStyleForColorProperty):
(WebCore::colorIncludingFallback):
(WebCore::RenderStyle::visitedDependentColor):
- rendering/style/RenderStyle.h:
(WebCore::):
(WebCore::InheritedFlags::NonInheritedFlags::operator==):
(WebCore::InheritedFlags::setBitDefaults):
(WebCore::InheritedFlags::insideLink):
(WebCore::InheritedFlags::isLink):
(WebCore::InheritedFlags::setInsideLink):
(WebCore::InheritedFlags::setIsLink):
- rendering/style/RenderStyleConstants.h:
Change how link information is stored. The noninherited flags now have a bit set for if you're a link
or not. The inherited flags now cache whether you're inside a visited or unvisited link (or no link at
all).
(WebCore::):
- svg/graphics/SVGPaintServer.cpp:
(WebCore::SVGPaintServer::fillPaintServer):
(WebCore::SVGPaintServer::strokePaintServer):
Patch SVG fill/stroke painting to honor :visited.
WebKit/mac: https://bugs.webkit.org/show_bug.cgi?id=24300, don't expose history info via CSS
Reviewed by Oliver Hunt.
Add SPI so that layout tests can access computed style including :visited information.
- WebView/WebRenderNode.mm:
(copyRenderNode):
- WebView/WebView.mm:
(-[WebView _computedStyleIncludingVisitedInfo:forElement:]):
- WebView/WebViewInternal.h:
- WebView/WebViewPrivate.h:
WebKitTools: https://bugs.webkit.org/show_bug.cgi?id=24300, don't expose history info via CSS. Add a new method for
obtaining computed style with :visited info included. This allows layout tests to actually tell that
:visited is in effect.
Reviewed by Oliver Hunt.
- DumpRenderTree/LayoutTestController.cpp:
(computedStyleIncludingVisitedInfoCallback):
(LayoutTestController::staticFunctions):
- DumpRenderTree/LayoutTestController.h:
- DumpRenderTree/mac/LayoutTestControllerMac.mm:
(LayoutTestController::computedStyleIncludingVisitedInfo):
LayoutTests: https://bugs.webkit.org/show_bug.cgi?id=24300, don't expose history info via CSS
Reviewed by Oliver Hunt.
- fast/history/clicked-link-is-visited.html: Removed.
- fast/history/nested-visited-test-expected.txt: Added.
- fast/history/nested-visited-test.html: Added.
- fast/history/resources/dummy.html: Added.
- fast/history/self-is-visited-expected.txt: Added.
- fast/history/self-is-visited.html: Added.
- fast/history/sibling-visited-test-expected.txt: Added.
- fast/history/sibling-visited-test.html: Added.
- fast/history/subframe-is-visited-expected.txt: Removed.
- fast/history/subframe-is-visited.html: Removed.
- 2:09 PM Changeset in webkit [57291] by
-
- 33 edits4 deletes in trunk/LayoutTests
2010-04-08 Ojan Vafai <ojan@chromium.org>
Reviewed by Daniel Bates.
[chromium] Many new test results are needed due to recent check-ins.
https://bugs.webkit.org/show_bug.cgi?id=36799
Adds new results for all the tests that started failing after http://trac.webkit.org/changeset/57287.
- platform/chromium-mac/tables/mozilla/bugs/bug1296-expected.checksum: Removed.
- platform/chromium-mac/tables/mozilla/bugs/bug1296-expected.png: Removed.
- platform/chromium-mac/tables/mozilla/bugs/bug1430-expected.checksum: Removed.
- platform/chromium-mac/tables/mozilla/bugs/bug1430-expected.png: Removed.
- platform/chromium-win/tables/mozilla/bugs/bug1296-expected.checksum:
- platform/chromium-win/tables/mozilla/bugs/bug1296-expected.png:
- platform/chromium-win/tables/mozilla/bugs/bug1430-expected.checksum:
- platform/chromium-win/tables/mozilla/bugs/bug1430-expected.png:
- platform/chromium-win/tables/mozilla/marvin/backgr_simple-table-column-expected.checksum:
- platform/chromium-win/tables/mozilla/marvin/backgr_simple-table-column-expected.png:
- platform/chromium-win/tables/mozilla/marvin/backgr_simple-table-column-group-expected.checksum:
- platform/chromium-win/tables/mozilla/marvin/backgr_simple-table-column-group-expected.png:
- platform/chromium-win/tables/mozilla/marvin/backgr_simple-table-row-expected.checksum:
- platform/chromium-win/tables/mozilla/marvin/backgr_simple-table-row-expected.png:
- platform/chromium-win/tables/mozilla/marvin/backgr_simple-table-row-group-expected.checksum:
- platform/chromium-win/tables/mozilla/marvin/backgr_simple-table-row-group-expected.png:
- platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_border-table-column-expected.checksum:
- platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_border-table-column-expected.png:
- platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_border-table-column-group-expected.checksum:
- platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_border-table-column-group-expected.png:
- platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_border-table-row-expected.checksum:
- platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_border-table-row-expected.png:
- platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_border-table-row-group-expected.checksum:
- platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_border-table-row-group-expected.png:
- platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_fixed-bg-expected.checksum:
- platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_fixed-bg-expected.png:
- platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_layers-hide-expected.checksum:
- platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_layers-hide-expected.png:
- platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_position-table-column-expected.checksum:
- platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_position-table-column-expected.png:
- platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_position-table-column-group-expected.checksum:
- platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_position-table-column-group-expected.png:
- platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_position-table-row-expected.checksum:
- platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_position-table-row-expected.png:
- platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_position-table-row-group-expected.checksum:
- platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_position-table-row-group-expected.png:
- 1:47 PM Changeset in webkit [57290] by
-
- 3 edits in trunk/WebKitTools
2010-04-07 Laszlo Gombos <Laszlo Gombos>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Fix trunk (non-standalone) builds for Symbian
https://bugs.webkit.org/show_bug.cgi?id=37136
Test for source files before building instead of relying on
standalone_package config.
- WebKit.pro:
- 12:46 PM Changeset in webkit [57289] by
-
- 1 edit51 deletes in trunk/LayoutTests
2010-04-08 Daniel Bates <dbates@rim.com>
No review, rolling out 56717.
http://trac.webkit.org/changeset/56717
https://bugs.webkit.org/show_bug.cgi?id=9268
Rolling out the change committed in change set 56717
since we rolled out the change committed in change set 56655,
<http://trac.webkit.org/changeset/56655> (in change set 57287,
<http://trac.webkit.org/changeset/57287>). The change committed
in change set 56655 caused a layout test regression of the some
of the mozilla- and mozilla expected failure- tests. See bug #9268
for more details.
- platform/qt/fast/table/table-background-expected.checksum: Removed.
- platform/qt/fast/table/table-background-expected.png: Removed.
- platform/qt/fast/table/table-background-expected.txt: Removed.
- platform/qt/fast/table/table-cell-border-draws-on-top-of-col-background-expected.checksum: Removed.
- platform/qt/fast/table/table-cell-border-draws-on-top-of-col-background-expected.png: Removed.
- platform/qt/fast/table/table-cell-border-draws-on-top-of-col-background-expected.txt: Removed.
- platform/qt/fast/table/table-cell-border-draws-on-top-of-col-group-background-expected.checksum: Removed.
- platform/qt/fast/table/table-cell-border-draws-on-top-of-col-group-background-expected.png: Removed.
- platform/qt/fast/table/table-cell-border-draws-on-top-of-col-group-background-expected.txt: Removed.
- platform/qt/fast/table/table-cell-border-draws-on-top-of-row-background-expected.checksum: Removed.
- platform/qt/fast/table/table-cell-border-draws-on-top-of-row-background-expected.png: Removed.
- platform/qt/fast/table/table-cell-border-draws-on-top-of-row-background-expected.txt: Removed.
- platform/qt/fast/table/table-cell-border-draws-on-top-of-row-group-background-expected.checksum: Removed.
- platform/qt/fast/table/table-cell-border-draws-on-top-of-row-group-background-expected.png: Removed.
- platform/qt/fast/table/table-cell-border-draws-on-top-of-row-group-background-expected.txt: Removed.
- platform/qt/fast/table/table-cell-overrides-row-background-expected.checksum: Removed.
- platform/qt/fast/table/table-cell-overrides-row-background-expected.png: Removed.
- platform/qt/fast/table/table-cell-overrides-row-background-expected.txt: Removed.
- platform/qt/fast/table/table-col-background-expected.checksum: Removed.
- platform/qt/fast/table/table-col-background-expected.png: Removed.
- platform/qt/fast/table/table-col-background-expected.txt: Removed.
- platform/qt/fast/table/table-col-group-background-expected.checksum: Removed.
- platform/qt/fast/table/table-col-group-background-expected.png: Removed.
- platform/qt/fast/table/table-col-group-background-expected.txt: Removed.
- platform/qt/fast/table/table-col-group-col-span-background-expected.checksum: Removed.
- platform/qt/fast/table/table-col-group-col-span-background-expected.png: Removed.
- platform/qt/fast/table/table-col-group-col-span-background-expected.txt: Removed.
- platform/qt/fast/table/table-col-group-span-background-expected.checksum: Removed.
- platform/qt/fast/table/table-col-group-span-background-expected.png: Removed.
- platform/qt/fast/table/table-col-group-span-background-expected.txt: Removed.
- platform/qt/fast/table/table-col-span-background-expected.checksum: Removed.
- platform/qt/fast/table/table-col-span-background-expected.png: Removed.
- platform/qt/fast/table/table-col-span-background-expected.txt: Removed.
- platform/qt/fast/table/table-row-background-expected.checksum: Removed.
- platform/qt/fast/table/table-row-background-expected.png: Removed.
- platform/qt/fast/table/table-row-background-expected.txt: Removed.
- platform/qt/fast/table/table-row-background-left-50px-expected.checksum: Removed.
- platform/qt/fast/table/table-row-background-left-50px-expected.png: Removed.
- platform/qt/fast/table/table-row-background-left-50px-expected.txt: Removed.
- platform/qt/fast/table/table-row-background-right-100percent-expected.checksum: Removed.
- platform/qt/fast/table/table-row-background-right-100percent-expected.png: Removed.
- platform/qt/fast/table/table-row-background-right-100percent-expected.txt: Removed.
- platform/qt/fast/table/table-row-background-right-50px-expected.checksum: Removed.
- platform/qt/fast/table/table-row-background-right-50px-expected.png: Removed.
- platform/qt/fast/table/table-row-background-right-50px-expected.txt: Removed.
- platform/qt/fast/table/table-row-group-background-expected.checksum: Removed.
- platform/qt/fast/table/table-row-group-background-expected.png: Removed.
- platform/qt/fast/table/table-row-group-background-expected.txt: Removed.
- platform/qt/fast/table/table-row-group-background-positioned-expected.checksum: Removed.
- platform/qt/fast/table/table-row-group-background-positioned-expected.png: Removed.
- platform/qt/fast/table/table-row-group-background-positioned-expected.txt: Removed.
- 12:42 PM Changeset in webkit [57288] by
-
- 2 edits in trunk/WebCore
2010-04-08 Benjamin Otte <otte@gnome.org>
Reviewed by Gustavo Noronha.
Fix build with MathML enabled.
- GNUmakefile.am:
- 12:21 PM Changeset in webkit [57287] by
-
- 7 edits68 deletes in trunk
2010-04-08 Daniel Bates <dbates@rim.com>
No review, rolling out 56655.
http://trac.webkit.org/changeset/56655
https://bugs.webkit.org/show_bug.cgi?id=9268
Rolling out the change committed in change set 56655
because it caused a regression in some of the mozilla
and mozilla expected failure test cases, such as:
tables/mozilla/marvin/backgr_simple-table-row.html, and
tables/mozilla/marvin/backgr_simple-table-row-group.html.
We need to look into this issue some more.
- rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelObject::paintFillLayerExtended): (WebCore::RenderBoxModelObject::calculateBackgroundImageGeometry):
- rendering/RenderBoxModelObject.h:
- rendering/RenderObject.h:
- rendering/RenderTableCell.cpp:
- rendering/RenderTableCell.h:
2010-04-08 Daniel Bates <dbates@rim.com>
No review, rolling out 56655.
http://trac.webkit.org/changeset/56655
https://bugs.webkit.org/show_bug.cgi?id=9268
Rolling out the change committed in change set 56655
because it caused a regression in some of the mozilla
and mozilla expected failure test cases, such as:
tables/mozilla/marvin/backgr_simple-table-row.html, and
tables/mozilla/marvin/backgr_simple-table-row-group.html.
We need to look into this issue some more.
- fast/table/table-background.html: Removed.
- fast/table/table-cell-border-draws-on-top-of-col-background.html: Removed.
- fast/table/table-cell-border-draws-on-top-of-col-group-background.html: Removed.
- fast/table/table-cell-border-draws-on-top-of-row-background.html: Removed.
- fast/table/table-cell-border-draws-on-top-of-row-group-background.html: Removed.
- fast/table/table-cell-overrides-row-background.html: Removed.
- fast/table/table-col-background.html: Removed.
- fast/table/table-col-group-background.html: Removed.
- fast/table/table-col-group-col-span-background.html: Removed.
- fast/table/table-col-group-span-background.html: Removed.
- fast/table/table-col-span-background.html: Removed.
- fast/table/table-row-background-left-50px.html: Removed.
- fast/table/table-row-background-right-100percent.html: Removed.
- fast/table/table-row-background-right-50px.html: Removed.
- fast/table/table-row-background.html: Removed.
- fast/table/table-row-group-background-positioned.html: Removed.
- fast/table/table-row-group-background.html: Removed.
- platform/mac/fast/table/table-background-expected.checksum: Removed.
- platform/mac/fast/table/table-background-expected.png: Removed.
- platform/mac/fast/table/table-background-expected.txt: Removed.
- platform/mac/fast/table/table-cell-border-draws-on-top-of-col-background-expected.checksum: Removed.
- platform/mac/fast/table/table-cell-border-draws-on-top-of-col-background-expected.png: Removed.
- platform/mac/fast/table/table-cell-border-draws-on-top-of-col-background-expected.txt: Removed.
- platform/mac/fast/table/table-cell-border-draws-on-top-of-col-group-background-expected.checksum: Removed.
- platform/mac/fast/table/table-cell-border-draws-on-top-of-col-group-background-expected.png: Removed.
- platform/mac/fast/table/table-cell-border-draws-on-top-of-col-group-background-expected.txt: Removed.
- platform/mac/fast/table/table-cell-border-draws-on-top-of-row-background-expected.checksum: Removed.
- platform/mac/fast/table/table-cell-border-draws-on-top-of-row-background-expected.png: Removed.
- platform/mac/fast/table/table-cell-border-draws-on-top-of-row-background-expected.txt: Removed.
- platform/mac/fast/table/table-cell-border-draws-on-top-of-row-group-background-expected.checksum: Removed.
- platform/mac/fast/table/table-cell-border-draws-on-top-of-row-group-background-expected.png: Removed.
- platform/mac/fast/table/table-cell-border-draws-on-top-of-row-group-background-expected.txt: Removed.
- platform/mac/fast/table/table-cell-overrides-row-background-expected.checksum: Removed.
- platform/mac/fast/table/table-cell-overrides-row-background-expected.png: Removed.
- platform/mac/fast/table/table-cell-overrides-row-background-expected.txt: Removed.
- platform/mac/fast/table/table-col-background-expected.checksum: Removed.
- platform/mac/fast/table/table-col-background-expected.png: Removed.
- platform/mac/fast/table/table-col-background-expected.txt: Removed.
- platform/mac/fast/table/table-col-group-background-expected.checksum: Removed.
- platform/mac/fast/table/table-col-group-background-expected.png: Removed.
- platform/mac/fast/table/table-col-group-background-expected.txt: Removed.
- platform/mac/fast/table/table-col-group-col-span-background-expected.checksum: Removed.
- platform/mac/fast/table/table-col-group-col-span-background-expected.png: Removed.
- platform/mac/fast/table/table-col-group-col-span-background-expected.txt: Removed.
- platform/mac/fast/table/table-col-group-span-background-expected.checksum: Removed.
- platform/mac/fast/table/table-col-group-span-background-expected.png: Removed.
- platform/mac/fast/table/table-col-group-span-background-expected.txt: Removed.
- platform/mac/fast/table/table-col-span-background-expected.checksum: Removed.
- platform/mac/fast/table/table-col-span-background-expected.png: Removed.
- platform/mac/fast/table/table-col-span-background-expected.txt: Removed.
- platform/mac/fast/table/table-row-background-expected.checksum: Removed.
- platform/mac/fast/table/table-row-background-expected.png: Removed.
- platform/mac/fast/table/table-row-background-expected.txt: Removed.
- platform/mac/fast/table/table-row-background-left-50px-expected.checksum: Removed.
- platform/mac/fast/table/table-row-background-left-50px-expected.png: Removed.
- platform/mac/fast/table/table-row-background-left-50px-expected.txt: Removed.
- platform/mac/fast/table/table-row-background-right-100percent-expected.checksum: Removed.
- platform/mac/fast/table/table-row-background-right-100percent-expected.png: Removed.
- platform/mac/fast/table/table-row-background-right-100percent-expected.txt: Removed.
- platform/mac/fast/table/table-row-background-right-50px-expected.checksum: Removed.
- platform/mac/fast/table/table-row-background-right-50px-expected.png: Removed.
- platform/mac/fast/table/table-row-background-right-50px-expected.txt: Removed.
- platform/mac/fast/table/table-row-group-background-expected.checksum: Removed.
- platform/mac/fast/table/table-row-group-background-expected.png: Removed.
- platform/mac/fast/table/table-row-group-background-expected.txt: Removed.
- platform/mac/fast/table/table-row-group-background-positioned-expected.checksum: Removed.
- platform/mac/fast/table/table-row-group-background-positioned-expected.png: Removed.
- platform/mac/fast/table/table-row-group-background-positioned-expected.txt: Removed.
- 11:40 AM Changeset in webkit [57286] by
-
- 4 edits in trunk/WebCore
Refactor DatabaseTracker, part 1: Remove the dependency on
OriginQuotaManager from DatabaseTracker.h.
Reviewed by Dimitri Glazkov.
https://bugs.webkit.org/show_bug.cgi?id=31482
- storage/DatabaseTracker.cpp:
(originQuotaManager):
(WebCore::DatabaseTracker::DatabaseTracker):
(WebCore::DatabaseTracker::canEstablishDatabase):
(WebCore::DatabaseTracker::hasEntryForOrigin):
(WebCore::DatabaseTracker::getMaxSizeForDatabase):
(WebCore::DatabaseTracker::databaseChanged):
(WebCore::DatabaseTracker::fullPathForDatabaseNoLock):
(WebCore::DatabaseTracker::fullPathForDatabase):
(WebCore::DatabaseTracker::populateOrigins):
(WebCore::DatabaseTracker::origins):
(WebCore::DatabaseTracker::databaseNamesForOrigin):
(WebCore::DatabaseTracker::removeOpenDatabase):
(WebCore::DatabaseTracker::usageForOriginNoLock):
(WebCore::DatabaseTracker::usageForOrigin):
(WebCore::DatabaseTracker::quotaForOrigin):
(WebCore::DatabaseTracker::setQuota):
(WebCore::DatabaseTracker::deleteOrigin):
(WebCore::DatabaseTracker::deleteDatabase):
(WebCore::DatabaseTracker::deleteDatabaseFile):
- storage/DatabaseTracker.h:
- storage/SQLTransactionClient.cpp:
(WebCore::SQLTransactionClient::didExecuteStatement):
- 11:11 AM Changeset in webkit [57285] by
-
- 2 edits in trunk/LayoutTests
2010-04-08 Ojan Vafai <ojan@chromium.org>
Reviewed by Dimitri Glazkov.
A couple test expectations cleanups
https://bugs.webkit.org/show_bug.cgi?id=37285
- platform/chromium/test_expectations.txt:
- 9:57 AM BuildBot edited by
- webkit-dev is a better choice for bot discussions (diff)
- 9:35 AM Changeset in webkit [57284] by
-
- 2 edits in trunk/LayoutTests
2010-04-08 Ojan Vafai <ojan@chromium.org>
Reviewed by Adam Barth.
Fix http.conf for GTK-Debug and Chromium-Linux bots
https://bugs.webkit.org/show_bug.cgi?id=37279
- http/conf/apache2-debian-httpd.conf:
- 9:23 AM Changeset in webkit [57283] by
-
- 2 edits in trunk/WebCore
2010-04-08 Kwang Yul Seo <skyul@company100.net>
Reviewed by Simon Hausmann.
[WINCE] Replace max with std::max
https://bugs.webkit.org/show_bug.cgi?id=37201
std::max is preferred.
- platform/wince/FileSystemWince.cpp: (WebCore::makeAllDirectories): (WebCore::pathGetFileName):
- 9:08 AM Changeset in webkit [57282] by
-
- 1 edit1 move1 add in trunk/WebCore
[EFL] Move AccessibilityObjectEfl.cpp from page to accessibility
https://bugs.webkit.org/show_bug.cgi?id=36405
Reviewed by Laszlo Gombos.
Patch by Antonio Gomes <tonikitoo@webkit.org>
- accessibility/efl/AccessibilityObjectEfl.cpp: Renamed from WebCore/page/efl/AccessibilityObjectEfl.cpp.
(WebCore::AccessibilityObject::accessibilityIgnoreAttachment):
- 8:57 AM Changeset in webkit [57281] by
-
- 2 edits in trunk/WebKit/qt
2010-04-08 Benjamin Poulain <benjamin.poulain@nokia.com>
Reviewed by Simon Hausmann.
[Qt] Warnings when compiling InspectorClientQt.cpp
https://bugs.webkit.org/show_bug.cgi?id=37266
Add a default: for the switch()-case to avoid
warnings.
- WebCoreSupport/InspectorClientQt.cpp: (WebCore::variantToSetting):
- 8:27 AM Changeset in webkit [57280] by
-
- 14 edits in trunk
2010-04-08 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: Render Load, DOM Content and MarkTimeline event dividers on Timeline panel.
- English.lproj/localizedStrings.js:
- inspector/InspectorController.cpp: (WebCore::InspectorController::mainResourceFiredDOMContentEvent): (WebCore::InspectorController::mainResourceFiredLoadEvent):
- inspector/InspectorController.h:
- inspector/InspectorTimelineAgent.cpp: (WebCore::InspectorTimelineAgent::didMarkDOMContentEvent): (WebCore::InspectorTimelineAgent::didMarkLoadEvent):
- inspector/InspectorTimelineAgent.h: (WebCore::):
- inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel.prototype.updateGraphDividersIfNeeded):
- inspector/front-end/TimelineAgent.js:
- inspector/front-end/TimelineGrid.js: (WebInspector.TimelineGrid.prototype.removeEventDividers):
- inspector/front-end/TimelinePanel.js: (WebInspector.TimelinePanel): (WebInspector.TimelinePanel.prototype.get _recordStyles): (WebInspector.TimelinePanel.prototype._updateMarks): (WebInspector.TimelinePanel.prototype._innerAddRecordToTimeline): (WebInspector.TimelinePanel.prototype._clearPanel): (WebInspector.TimelinePanel.prototype._refresh): (WebInspector.TimelinePanel.prototype._refreshRecords): (WebInspector.TimelineCalculator.prototype.computeBarGraphWindowPosition): (WebInspector.TimelineRecordGraphRow.prototype.update):
- inspector/front-end/inspector.css: (.resources-event-divider): (.resources-red-divider): (.resources-blue-divider): (.resources-orange-divider):
- 8:00 AM Changeset in webkit [57279] by
-
- 2 edits in trunk/LayoutTests
Unreviewed. Fix a test for the behavior change by r57274.
- fast/css/pseudo-invalid-novalidate-001.html:
- 7:43 AM Changeset in webkit [57278] by
-
- 7 edits in trunk/WebKitTools
2010-04-05 Antonio Gomes <tonikitoo@webkit.org>
Reviewed by Simon Hausmann.
[Qt] REGRESSION:(r50665) QWebFrame::setScrollBarPolicy(Qt::Vertical,Qt::ScrollBarAlwaysOff) has no effect.
https://bugs.webkit.org/show_bug.cgi?id=29431
Added stubs for Mac, win, gtk and wx DRTs to implement setScrollbarPolicy method.
- DumpRenderTree/LayoutTestController.cpp: (setScrollbarPolicyCallback): (LayoutTestController::staticFunctions):
- DumpRenderTree/LayoutTestController.h:
- DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::setScrollbarPolicy):
- DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::setScrollbarPolicy):
- DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::setScrollbarPolicy):
- DumpRenderTree/wx/LayoutTestControllerWx.cpp: (LayoutTestController::setScrollbarPolicy):
- 7:38 AM Changeset in webkit [57277] by
-
- 19 edits2 adds in trunk
2010-04-01 Antonio Gomes <tonikitoo@webkit.org>
Reviewed by David Hyatt.
[Qt] REGRESSION:(r50665) QWebFrame::setScrollBarPolicy(Qt::Vertical,Qt::ScrollBarAlwaysOff) has no effect.
https://bugs.webkit.org/show_bug.cgi?id=29431
Test: fast/overflow/scrollbar-restored-and-then-locked.html
WebCore:
Patch introduces a lock scrollbars concept to ScrollView, as in WebDynamicScrollBarsView.mm/h
on WebKit/mac. It is needed because in QtWebKit, we have Api for setting both vertical and
horizontal scrollbars on/off/auto. When it is set to off, for example, it should remain
as such, unless unset.
For the locking concept, optional 'lock' parameters were added to setScrollbarModes,
setHorizontalScrollbarMode and setVerticalScrollbarMode methods of ScrollView. As these
are all optional, any previous code calling them do not need modification.
Two optional parameters were also added to Frame's createView method, for horizontal and vertical
lock state persistence cross page loads.
- WebCore.base.exp:
- page/Frame.cpp: (WebCore::Frame::createView):
- platform/ScrollView.cpp: (WebCore::ScrollView::ScrollView): (WebCore::ScrollView::setScrollbarModes): (WebCore::ScrollView::setHorizontalScrollbarMode): (WebCore::ScrollView::setVerticalScrollbarMode):
- platform/ScrollView.h: (WebCore::ScrollView::setHorizontalScrollbarLock): (WebCore::ScrollView::isHorizontalScrollbarLocked): (WebCore::ScrollView::setVerticalScrollbarLock): (WebCore::ScrollView::isVerticalScrollbarLocked): (WebCore::ScrollView::setScrollingModesLocked):
WebKit/qt:
Make use of the new lock parameter of set{Vertical,Horizontal}ScrollbarMode.
Always added a qt auto test for set scrollbar policy feature.
- Api/qwebframe.cpp: (QWebFrame::setScrollBarPolicy):
- tests/qwebframe/tst_qwebframe.cpp:
- WebCoreSupport/FrameLoaderClientQt.cpp: (FrameLoaderClientQt::transitionToCommittedForNewPage):
WebKitTools:
Make possible to DRT to set scrollbar policies (on, off or auto).
- DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::setScrollbarPolicy):
- DumpRenderTree/qt/LayoutTestControllerQt.h:
- QtLauncher/main.cpp: (LauncherWindow::toggleScrollbars): (LauncherWindow::createChrome):
LayoutTests:
- fast/overflow/scrollbar-restored-and-then-locked-expected.txt: Added.
- fast/overflow/scrollbar-restored-and-then-locked.html: Added.
- 7:29 AM QtWebKitJournal edited by
- (diff)
- 7:28 AM Changeset in webkit [57276] by
-
- 5 edits in trunk
2010-04-08 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Correctly save number of properties when object being serialized
have properties in its prorotype.
- bindings/v8/SerializedScriptValue.cpp: (WebCore::ZigZag::Serializer::AbstractObjectState::AbstractObjectState): (WebCore::ZigZag::Serializer::AbstractObjectState::advance):
2010-04-08 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Test that object with ptototype can be sent as message.
- fast/dom/Window/window-postmessage-clone-expected.txt:
- fast/dom/Window/window-postmessage-clone.html:
- 7:14 AM Changeset in webkit [57275] by
-
- 4 edits in trunk/WebCore
2010-04-08 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Yury Semikhatsky.
IDB callbacks should fire asynchronously
https://bugs.webkit.org/show_bug.cgi?id=37265
Fix the firing behavior of the callbacks to not be synchronous.
There's still a major bug that I'm trying to track down that is keeping
us from testing this stuff. Promise lots of tests ASAP.
- bindings/v8/custom/V8CustomIDBCallbacks.h: (WebCore::V8CustomIDBCallbacks::onSuccessAsync): (WebCore::V8CustomIDBCallbacks::onErrorAsync):
- storage/IDBCallbacks.h: (WebCore::IDBCallbacks::IDBCallbacks): (WebCore::IDBCallbacks::onSuccess): (WebCore::IDBCallbacks::onError): (WebCore::IDBCallbacks::timerFired):
- storage/IndexedDatabaseRequest.cpp:
- 7:10 AM Changeset in webkit [57274] by
-
- 9 edits3 adds20 deletes in trunk
willValidate doesn't need to check existence of a form element and a name attribute.
https://bugs.webkit.org/show_bug.cgi?id=34733
Reviewed by Darin Adler.
WebCore:
Remove checks against m_form and m_hasName in
HTMLFormControlElement::willValidate(), and remove the code to
track their updates.
Test: fast/forms/willvalidate.html
- html/HTMLFormControlElement.cpp:
(WebCore::HTMLFormControlElement::HTMLFormControlElement):
(WebCore::HTMLFormControlElement::parseMappedAttribute):
(WebCore::HTMLFormControlElement::insertedIntoTree):
(WebCore::HTMLFormControlElement::removedFromTree):
(WebCore::HTMLFormControlElement::recalcWillValidate):
(WebCore::HTMLFormControlElement::willValidate):
(WebCore::HTMLFormControlElement::setNeedsWillValidateCheck):
- html/HTMLFormControlElement.h:
(WebCore::HTMLFormControlElement::formDestroyed):
- html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::setInputType):
setNeedsWillValidateCheck() should be called before
setAttribute(valueAttr, ...) is called.
LayoutTests:
- Merge willvalidate-00x tests into one file.
- Update tests affected by the willValidate behavior change.
- fast/forms/input-live-pseudo-selectors-expected.txt:
- fast/forms/resources/input-live-pseudo-selectors.js:
- fast/forms/resources/textarea-live-pseudo-selectors.js:
- fast/forms/script-tests/willvalidate.js: Added.
- fast/forms/textarea-live-pseudo-selectors-expected.txt:
- fast/forms/willvalidate-000-expected.txt: Removed.
- fast/forms/willvalidate-000.html: Removed.
- fast/forms/willvalidate-001-expected.txt: Removed.
- fast/forms/willvalidate-001.html: Removed.
- fast/forms/willvalidate-002-expected.txt: Removed.
- fast/forms/willvalidate-002.html: Removed.
- fast/forms/willvalidate-003-expected.txt: Removed.
- fast/forms/willvalidate-003.html: Removed.
- fast/forms/willvalidate-004-expected.txt: Removed.
- fast/forms/willvalidate-004.html: Removed.
- fast/forms/willvalidate-005-expected.txt: Removed.
- fast/forms/willvalidate-005.html: Removed.
- fast/forms/willvalidate-006-expected.txt: Removed.
- fast/forms/willvalidate-006.html: Removed.
- fast/forms/willvalidate-007-expected.txt: Removed.
- fast/forms/willvalidate-007.html: Removed.
- fast/forms/willvalidate-008-expected.txt: Removed.
- fast/forms/willvalidate-008.html: Removed.
- fast/forms/willvalidate-009-expected.txt: Removed.
- fast/forms/willvalidate-009.html: Removed.
- fast/forms/willvalidate-expected.txt: Added.
- fast/forms/willvalidate.html: Added.
- 7:05 AM Changeset in webkit [57273] by
-
- 7 edits in trunk/WebCore
2010-04-08 Young Han Lee <joybro@company100.net>
Reviewed by Simon Hausmann.
[WINCE] Add missing headers
https://bugs.webkit.org/show_bug.cgi?id=37199
Include missing headers.
- platform/graphics/wince/FontCustomPlatformData.cpp:
- platform/graphics/wince/FontPlatformData.cpp:
- platform/graphics/wince/GraphicsContextWince.cpp:
- platform/graphics/wince/ImageBufferWince.cpp:
- platform/graphics/wince/PlatformPathWince.h:
- platform/wince/FileSystemWince.cpp:
- 6:54 AM Changeset in webkit [57272] by
-
- 3 edits in trunk/WebCore
2010-04-08 Kwang Yul Seo <skyul@company100.net>
Reviewed by Simon Hausmann.
[WINCE] Use WebCore::instanceHandle()
https://bugs.webkit.org/show_bug.cgi?id=37202
Page::instanceHandle() is moved to WebCore::instanceHandle().
- platform/wince/PasteboardWince.cpp: (WebCore::Pasteboard::Pasteboard):
- platform/wince/SharedTimerWince.cpp: (WebCore::initializeOffScreenTimerWindow):
- 6:44 AM Changeset in webkit [57271] by
-
- 2 edits in trunk/JavaScriptCore
2010-04-08 Kwang Yul Seo <skyul@company100.net>
Reviewed by Simon Hausmann.
[WINCE] Check if ARM or _ARM_ is defined
https://bugs.webkit.org/show_bug.cgi?id=37200
MSVC defines ARM and _ARM_ for Windows CE ARM. Define WTF_CPU_ARM=1
when either ARM or _ARM_ is defined.
- wtf/Platform.h:
- 6:24 AM Changeset in webkit [57270] by
-
- 3 edits in trunk/WebKit/qt
2010-04-08 Joe Ligman <joseph.ligman@nokia.com>
Reviewed by Simon Hausmann.
[Qt] WebKit crashes while input text through input method.
The formatted text underline painting crashes when painting with invalid indexes.
https://bugs.webkit.org/show_bug.cgi?id=36870
- Api/qwebpage.cpp: (QWebPagePrivate::inputMethodEvent):
- tests/qwebpage/tst_qwebpage.cpp: (tst_QWebPage::inputMethodsTextFormat_data): (tst_QWebPage::inputMethodsTextFormat):
- 5:38 AM QtWebKitBackportingFixes edited by
- (diff)
- 3:15 AM Changeset in webkit [57269] by
-
- 9 edits2 adds in trunk
2010-04-08 Vitaly Repeshko <vitalyr@chromium.org>
Reviewed by Dimitri Glazkov.
[V8] Fix crash in NodeFilterCondition in detached iframe
https://bugs.webkit.org/show_bug.cgi?id=37234
Test: fast/dom/node-filter-detached-iframe-crash.html
- bindings/v8/V8NodeFilterCondition.cpp: (WebCore::V8NodeFilterCondition::acceptNode): Switched to using callFunctionWithoutFrame.
- bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::callFunctionWithoutFrame): Added a function to call V8 with no current frame.
- bindings/v8/V8Proxy.h:
2010-04-08 Vitaly Repeshko <vitalyr@chromium.org>
Reviewed by Dimitri Glazkov.
[V8] Fix crash in NodeFilterCondition in detached iframe
https://bugs.webkit.org/show_bug.cgi?id=37234
- fast/dom/node-filter-detached-iframe-crash-expected.txt: Added.
- fast/dom/node-filter-detached-iframe-crash.html: Added.
- 2:50 AM Changeset in webkit [57268] by
-
- 2 edits in trunk/LayoutTests
2010-04-08 Eric Seidel <eric@webkit.org>
Unreviewed. Update test_expectations to account for tests which fail
when run out of order.
fast/dom/SelectorAPI/dumpNodeList tests fail when run out of order.
https://bugs.webkit.org/show_bug.cgi?id=37259
- platform/mac/test_expectations.txt:
- 2:23 AM Changeset in webkit [57267] by
-
- 2 edits in trunk/WebCore
2010-04-08 Jarkko Sakkinen <jarkko.sakkinen@tieto.com>
Reviewed by Simon Hausmann.
[Qt] Remove shaderSource manipulation from GraphicsContext3DQt.cpp
https://bugs.webkit.org/show_bug.cgi?id=37226
- platform/graphics/qt/GraphicsContext3DQt.cpp: (WebCore::GraphicsContext3D::shaderSource):
- 2:13 AM Changeset in webkit [57266] by
-
- 2 edits in trunk/WebKit/qt
2010-04-08 Joe Ligman <joseph.ligman@nokia.com>
Reviewed by Simon Hausmann.
[Qt] qtwebkit_webframe_scrollRecursively scrolls when body.style.overflow="hidden"
https://bugs.webkit.org/show_bug.cgi?id=36674
The scrolling check was based on the frameview's scrolloffset, and
maximumScrollPosition, which does not acknowledge the overflow properties.
I am now basing the scrolling off the scrollbar position. The scrollbars are
affected by the overflow properties indicating when not to scroll. The scrollbar
positions also continue to work for CSS ::-webkit-scrollbar styles.
- Api/qwebframe.cpp: (qtwebkit_webframe_scrollRecursively):
- 1:59 AM Changeset in webkit [57265] by
-
- 2 edits in trunk/WebKitTools
2010-04-08 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
new-run-webkit-tests should give a percent complete indication
https://bugs.webkit.org/show_bug.cgi?id=37258
Because it's awesome.
- Scripts/webkitpy/layout_tests/run_webkit_tests.py:
- 1:26 AM Changeset in webkit [57264] by
-
- 2 edits in trunk/LayoutTests
2010-04-08 Adam Barth <abarth@webkit.org>
Unreviewed. Update test_expectations to account for some tests that
fail when run out of order.
- platform/mac/test_expectations.txt:
- 1:19 AM Changeset in webkit [57263] by
-
- 3 edits2 adds in trunk
2010-04-08 Chris Evans <cevans@chromium.org>
Reviewed by Adam Barth.
Add test for SVG image with excessive nesting.
https://bugs.webkit.org/show_bug.cgi?id=37247
- fast/images/svg-nested.html: added
- fast/images/svg-nested-expected.txt: added
2010-04-08 Chris Evans <cevans@chromium.org>
Reviewed by Adam Barth.
Sanity: apply a max node depth to XML parsing.
Test: fast/images/svg-nested.html
- dom/XMLTokenizer.cpp: (WebCore::XMLTokenizer::pushCurrentNode): Error out the parse upon a really large node depth.
- 1:16 AM Changeset in webkit [57262] by
-
- 2 edits in trunk/JavaScriptCore
Reviewed Oliver Hunt.
[Qt]r57240 broke Qt build (might be a gcc bug)
https://bugs.webkit.org/show_bug.cgi?id=37253
Workaround until fix. On PLATFORM(QT) use inline instead of ALWAYS_INLINE.
- wtf/PassRefPtr.h: Qt guards added.
- 1:04 AM Changeset in webkit [57261] by
-
- 3 edits in trunk/LayoutTests
2010-04-08 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
cross-frame-access-put depends on test ordering
https://bugs.webkit.org/show_bug.cgi?id=37254
If you run the tests in a different order, the value of this property
can change. We just need to avoid printing the actual value.
- http/tests/security/cross-frame-access-put-expected.txt:
- http/tests/security/resources/cross-frame-iframe-for-put-test.html:
- 12:54 AM Changeset in webkit [57260] by
-
- 2 edits in trunk/LayoutTests
2010-04-07 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
WebKit Apache configs only listen on IPv4 addresses, causing random timeouts
https://bugs.webkit.org/show_bug.cgi?id=37104
Turns out the CYGWIN also uses Apache 1.3, so can't bind to ::1 either.
- http/conf/cygwin-httpd.conf:
- 12:51 AM Changeset in webkit [57259] by
-
- 2 edits in trunk/LayoutTests
2010-04-08 Andrew Scherkus <scherkus@chromium.org>
Unreviewed, cleaning up Chromium Mac test expecatations for fast/media.
- platform/chromium/test_expectations.txt:
- 12:49 AM Changeset in webkit [57258] by
-
- 2 edits in trunk/WebKitTools
2010-04-08 Adam Barth <abarth@webkit.org>
Unreviewed.
Add back the --target option because it's needed by the downstream
Chromium bots.
- Scripts/webkitpy/layout_tests/run_webkit_tests.py:
- 12:45 AM Changeset in webkit [57257] by
-
- 4 edits in trunk/WebKitTools
2010-04-08 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
new-run-webkit-tests should understand set-webkit-configuration
https://bugs.webkit.org/show_bug.cgi?id=37252
- Scripts/webkitpy/layout_tests/port/base.py:
- Scripts/webkitpy/layout_tests/port/mac.py:
- Scripts/webkitpy/layout_tests/run_webkit_tests.py:
- 12:27 AM Changeset in webkit [57256] by
-
- 15 edits in trunk/WebKitTools
2010-04-08 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Rename target to configuration in new-run-webkit-tests to match the rest of WebKit
https://bugs.webkit.org/show_bug.cgi?id=37251
The rest of our tools call --debug or --release the configuration.
It's confusing to call it target in this script.
- Scripts/webkitpy/layout_tests/driver_test.py:
- Scripts/webkitpy/layout_tests/layout_package/test_shell_thread.py:
- Scripts/webkitpy/layout_tests/port/base.py:
- Scripts/webkitpy/layout_tests/port/chromium.py:
- Scripts/webkitpy/layout_tests/port/chromium_linux.py:
- Scripts/webkitpy/layout_tests/port/chromium_mac.py:
- Scripts/webkitpy/layout_tests/port/chromium_win.py:
- Scripts/webkitpy/layout_tests/port/mac.py:
- Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
- Scripts/webkitpy/layout_tests/run_webkit_tests.py:
- Scripts/webkitpy/layout_tests/test_types/fuzzy_image_diff.py:
- Scripts/webkitpy/layout_tests/test_types/image_diff.py:
- Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
- Scripts/webkitpy/layout_tests/test_types/text_diff.py:
- 12:19 AM Changeset in webkit [57255] by
-
- 2 edits in trunk/LayoutTests
2010-04-08 Andrew Scherkus <scherkus@chromium.org>
Unreviewed, cleaning up test expectations for fast/media and media/video-played-reset.html.
Previously all of fast/media was marked as PASS FAIL, but now has finer-grained
expectations for all tests.
Due to Chromium-side changes, media/video-played-reset.html is now passing again.
- platform/chromium/test_expectations.txt:
Apr 7, 2010:
- 11:56 PM Changeset in webkit [57254] by
-
- 2 edits in trunk/WebKitTools
2010-04-07 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Remove depricated op.popen2 call in new-run-webkit-tests
https://bugs.webkit.org/show_bug.cgi?id=37249
Python complains that this API is depricated. We already solved this
problem in executive.py.
- Scripts/webkitpy/layout_tests/port/mac.py:
- 11:55 PM Changeset in webkit [57253] by
-
- 2 edits in trunk/WebKitTools
2010-04-07 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
new-run-webkit-tests crashes when run on a 64-bit machine
https://bugs.webkit.org/show_bug.cgi?id=37248
- Scripts/webkitpy/layout_tests/port/mac.py:
- The code was trying to always run the 32-bit intel version of the DumpRenderTree binary. DRT does not build 32-bit on 64-bit machines so that makes no sense. This may have made sense for test_shell at some point, but I think we should just remove this for DRT.
- 11:51 PM Changeset in webkit [57252] by
-
- 2 edits in trunk/LayoutTests
2010-04-07 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
transitions/transition-end-event-transform.html fails intermittently on Tiger Intel Release bot
https://bugs.webkit.org/show_bug.cgi?id=37145
I think this test might be getting confused because it only expects the
end event to fire once but actually it fires again for the second
transition. Let's try this patch and see if it fixes the flakiness.
- transitions/transition-end-event-set-none.html:
- 11:40 PM QtWebKit edited by
- (diff)
- 11:13 PM Changeset in webkit [57251] by
-
- 1 edit1 add in trunk/WebKitSite
(Not reviewed.)
Random demo to look cool on twitter.
- misc/gradient-input.html: Added.
- 11:03 PM Changeset in webkit [57250] by
-
- 2 edits in trunk/LayoutTests
2010-04-07 Eric Seidel <eric@webkit.org>
Reviewed by Alexey Proskuryakov.
WebKit Apache configs only listen on IPv4 addresses, causing random timeouts
https://bugs.webkit.org/show_bug.cgi?id=37104
Apache 1.3 does not support IPv6, so remove the Listen [::1] directive
and add a warning about how that may cause flakiness on systems which
use Apache 1.3, but support IPv6.
- http/conf/httpd.conf:
- 10:00 PM Changeset in webkit [57249] by
-
- 9 edits in trunk
2010-04-07 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
WebKit Apache configs only listen on IPv4 addresses, causing random timeouts
https://bugs.webkit.org/show_bug.cgi?id=37104
WebKit Apache configs were only listening on IPv4 loopback (127.0.0.1), however
the system will resolve "localhost." to both IPv4 and IPv6 (::1) loopback
addreses when IPv6 is enabled. Since DNS lookup returns addresses in random
order, we would occasionally fail to make connections to "localhost" addresses
if the various network re-tries all happen to resolve to the IPv6 loopback.
To make matters worse, the kernel has a connection reset throttle which we
could trigger if we would repeatedly attempt to connect to ::1 and fail.
The trottle would cause a 1 or 2 second delay on the connection, sometimes
causing slow tests to time out.
I also discovered during this investigation that we have some partial support
for specifying our apache port numbers at runtime. The support is already incomplete
by not accounting for WebSockets or SSL ports. This fix will make our partial
support for dynamic apache port numbers even more broken.
I've added Listen [::1]:PORT directives for 8000, 8080, and 8443 to all
platforms (except cygwin which does not have the 8443 directive to begin with).
- http/conf/apache2-debian-httpd.conf:
- http/conf/apache2-httpd.conf:
- http/conf/cygwin-httpd.conf:
- http/conf/fedora-httpd.conf:
- http/conf/httpd.conf:
2010-04-07 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
WebKit Apache configs only listen on IPv4 addresses, causing random timeouts
https://bugs.webkit.org/show_bug.cgi?id=37104
Add warnings that the partial support for specifying what port numbers
apache should bind to is even more broken after this fix.
- Scripts/run-webkit-httpd:
- Scripts/run-webkit-tests:
- 9:35 PM Changeset in webkit [57248] by
-
- 2 edits in trunk/JavaScriptCore
Vector<UString> makes many needless calls to UString::UString and UString::~UString
Reviewed by Anders Carlsson.
Add a VectorTrait<UString> specialisation to allow vector to simply memset/memcpy
data around. Only difference from the VectorTrait<RefPtr<T> > traits is the inability
to use memset to initialize data.
- runtime/UString.h:
(WTF::):
- 9:12 PM Changeset in webkit [57247] by
-
- 2 edits in trunk/WebKitTools
2010-04-07 Shinichiro Hamaji <hamaji@chromium.org>
Reviewed by Darin Adler.
LayoutTestController::m_handlesAuthenticationChallenges isn't initialized
https://bugs.webkit.org/show_bug.cgi?id=37190
- DumpRenderTree/LayoutTestController.cpp: (LayoutTestController::LayoutTestController):
- 9:11 PM Changeset in webkit [57246] by
-
- 5 edits in trunk/WebKit/mac
Refactor WebHTMLView printing code and add private methods to enter and exit printing mode.
https://bugs.webkit.org/show_bug.cgi?id=37246
Reviewed by Adele Peterson.
- Misc/WebNSPrintOperationExtras.h: Declared -_web_availablePaperWidth and -_web_availablePaperHeight.
- Misc/WebNSPrintOperationExtras.m:
(-[NSPrintOperation _web_availablePaperWidth]): Turned -[WebHTMLView _availablePaperWidthForPrintOperation:]
into this method.
(-[NSPrintOperation _web_availablePaperHeight]): Turned -[WebHTMLView _calculatePrintHeight] into this
method.
- WebView/WebHTMLView.mm:
(-[WebHTMLView _isInPrintMode]): Added this accessor.
(-[WebHTMLView _beginPrintModeWithPageWidth:shrinkToFit:]): Added. Moved the code from -knowsPageRange: that
computes the layout widths and enters printing mode into this private method.
(-[WebHTMLView _endPrintMode]): New private method (the old -_endPrintMode has been renamed).
(-[WebHTMLView _scaleFactorForPrintOperation:]): Use -[NSPrintOperation _web_availablePaperWidth].
(-[WebHTMLView _endPrintModeAndRestoreWindowAutodisplay]): Renamed -_endPrintMode to this, changed it to call
_endPrintMode.
(-[WebHTMLView _delayedEndPrintMode:]): Updated for rename.
(-[WebHTMLView knowsPageRange:]): Use -_beginPrintModeWithPageWidth:shrintToFit:,
-[NSPrintOperation _web_availablePaperWidth], and -[NSPrintOperation _web_availablePaperHeight]. Updated for
rename.
(-[WebHTMLView beginDocument]): Updated for rename.
(-[WebHTMLView endDocument]): Ditto.
- WebView/WebHTMLViewPrivate.h: Declared new private methods -_isInPrintMode,
-_beginPrintModeWithPageWidth:shrinkToFit: and -_endPrintMode.
- 6:18 PM Changeset in webkit [57245] by
-
- 9 edits in trunk/WebCore
Fix Chromium's HTML5 DB support in --single-process mode.
https://bugs.webkit.org/show_bug.cgi?id=37186.
Reviewed by Jeremy Orlow.
Always register and use Chromium's SQLite VFS for
WebSQLDatabases. Keep using the default VFS in all other
cases. This change should allow Chromium to support
WebSQLDatabases in --single-process mode.
Also, cleaning up a bit SQLiteFileSystemChromium and getting rid
of the SQLITE_OPEN_FULLMUTEX flag: we use sqlite DB handles only
on the DB thread, so we don't need multi-threaded support.
- platform/sql/SQLiteDatabase.cpp:
(WebCore::SQLiteDatabase::open):
- platform/sql/SQLiteDatabase.h:
- platform/sql/SQLiteFileSystem.cpp:
(WebCore::SQLiteFileSystem::openDatabase):
- platform/sql/SQLiteFileSystem.h:
- platform/sql/chromium/SQLiteFileSystemChromium.cpp:
(WebCore::SQLiteFileSystem::openDatabase):
- platform/sql/chromium/SQLiteFileSystemChromiumPosix.cpp:
(WebCore::SQLiteFileSystem::registerSQLiteVFS):
- platform/sql/chromium/SQLiteFileSystemChromiumWin.cpp:
(WebCore::SQLiteFileSystem::registerSQLiteVFS):
- storage/Database.cpp:
(WebCore::Database::performOpenAndVerify):
- 5:38 PM Changeset in webkit [57244] by
-
- 7 edits3 deletes in trunk
Remove QuartzCoreInterface from the build
No longer needed since QuartzCore.dll is now included in the latest Safari release (4.0.5).
- 5:32 PM Changeset in webkit [57243] by
-
- 2 edits2 deletes in trunk
2010-04-07 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r57178.
http://trac.webkit.org/changeset/57178
https://bugs.webkit.org/show_bug.cgi?id=37240
Caused chromium browser_test and ui_test regressions
(Requested by ojan on #webkit).
- bindings/v8/ScriptController.cpp: (WebCore::ScriptController::processingUserGesture):
- 4:52 PM Changeset in webkit [57242] by
-
- 5 edits4 adds in trunk/LayoutTests
2010-04-07 Ojan Vafai <ojan@chromium.org>
Reviewed by Adam Barth.
New chromium expected results after r57215
https://bugs.webkit.org/show_bug.cgi?id=37239
- platform/chromium-linux/fast/repaint/stacked-diacritics-expected.checksum: Added.
- platform/chromium-linux/fast/text/line-breaks-expected.checksum:
- platform/chromium-linux/fast/text/line-breaks-expected.png:
- platform/chromium-linux/fast/text/line-breaks-expected.txt: Our new behavior is no more broken than the old behavior. Evan says he'll fix the underlying problem some day.
- platform/chromium-win/fast/repaint/stacked-diacritics-expected.checksum: Added.
- platform/chromium-win/fast/repaint/stacked-diacritics-expected.png: Added.
- platform/chromium-win/fast/repaint/stacked-diacritics-expected.txt: Added. This is a new test. These are just the usual windows vs. mac font rendering differences.
- platform/chromium/test_expectations.txt:
- 4:49 PM Changeset in webkit [57241] by
-
- 3 edits in trunk/LayoutTests
2010-04-07 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Fix two cookie tests to clean up after themselves (so they can be run repeatedly)
https://bugs.webkit.org/show_bug.cgi?id=37235
Tiger's CFNetwork doesn't seem to understand "max-age=-1" so we'll
use "expires=some date in the past" to clear cookies instead.
I've verified that these tests still work on Snow Leopard.
- http/tests/xmlhttprequest/resources/cross-origin-set-cookies.php:
- http/tests/xmlhttprequest/resources/get-set-cookie.cgi:
- 4:06 PM Changeset in webkit [57240] by
-
- 2 edits in trunk/JavaScriptCore
Beat gcc with a clue bat -- force inlining of refIfNotNull and derefIfNotNull
Reviewed by Geoff Garen.
- wtf/PassRefPtr.h:
- 4:04 PM Changeset in webkit [57239] by
-
- 3 edits in trunk/WebCore
Add the comment and assert that we're generating version 4 random number
based UUIDs.
https://bugs.webkit.org/show_bug.cgi?id=36472
Reviewed by Adam Barth and Dmitry Titov.
- platform/UUID.cpp:
(WebCore::createCanonicalUUIDString):
- platform/UUID.h:
- 3:59 PM Changeset in webkit [57238] by
-
- 5 edits2 adds in trunk
2010-04-07 Erik Arvidsson <arv@chromium.org>
Reviewed by Adam Barth.
Allow white listing access from origin to local origin.
https://bugs.webkit.org/show_bug.cgi?id=37228
This makes it possible to load a local resource from a non local
origin if the access has previously been white listed by calling
SecurityOrigin::whiteListAccessFromOrigin.
- http/tests/security/local-image-from-remote-whitelisted-expected.txt: Added.
- http/tests/security/local-image-from-remote-whitelisted.html: Added.
2010-04-07 Erik Arvidsson <arv@chromium.org>
Reviewed by Adam Barth.
Allow white listing access from origin to local origin.
https://bugs.webkit.org/show_bug.cgi?id=37228
This makes it possible to load a local resource from a non local
origin if the access has previously been white listed by calling
SecurityOrigin::whiteListAccessFromOrigin.
Test: http/tests/security/local-image-from-remote-whitelisted.html
- page/OriginAccessEntry.cpp: (WebCore::OriginAccessEntry::OriginAccessEntry): Removed assert that only the http and https protocol are valid.
- page/SecurityOrigin.cpp: (WebCore::SecurityOrigin::canRequest): Use isAccessWhiteListed (WebCore::SecurityOrigin::isAccessWhiteListed): Extracted code that goes through the originAccessMap to do the origin matching. (WebCore::SecurityOrigin::canLoad): Check if access has been white listed.
- page/SecurityOrigin.h: Add private function isAccessWhiteListed
- 3:43 PM Changeset in webkit [57237] by
-
- 5 edits in trunk/LayoutTests
2010-04-07 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Fix two cookie tests to clean up after themselves (so they can be run repeatedly)
https://bugs.webkit.org/show_bug.cgi?id=37235
Added a ?clear=1 query parameter to the two "set cookies" cgi scripts
that these tests use, and call it to clear the cookies before leaving the test.
I could not resist the temptation of cleaning up the ridiculously awful copy/paste
in these tests, so the changes are larger than strictly necessary.
- http/tests/xmlhttprequest/cookies.html:
- http/tests/xmlhttprequest/cross-origin-cookie-storage.html:
- http/tests/xmlhttprequest/resources/cross-origin-set-cookies.php:
- http/tests/xmlhttprequest/resources/get-set-cookie.cgi:
- 2:53 PM Changeset in webkit [57236] by
-
- 3 edits in trunk/WebCore
2010-04-07 Luiz Agostini <luiz.agostini@openbossa.org>
Reviewed by Darin Adler.
Adding static method zero() to classes IntPoint and FloatPoint.
https://bugs.webkit.org/show_bug.cgi?id=37220
Adding static method zero() to classes IntPoint and FloatPoint as suggested by Darin Adler.
- platform/graphics/FloatPoint.h: (WebCore::FloatPoint::zero):
- platform/graphics/IntPoint.h: (WebCore::IntPoint::zero): (WebCore::IntPoint::clampNegativeToZero):
- 2:32 PM Changeset in webkit [57235] by
-
- 2 edits in trunk/WebCore
- platform/network/mac/AuthenticationMac.mm: Fix a typo in comment.
- 2:30 PM Changeset in webkit [57234] by
-
- 3 edits in trunk/LayoutTests
2010-04-07 Zhenyao Mo <zmo@google.com>
Reviewed by Eric Seidel.
A few tests in fast/canvas/webgl failed randomly on Leopard Commit Bot
https://bugs.webkit.org/show_bug.cgi?id=37098
- fast/canvas/webgl/resources/webgl-test.js: Turn off stencil/antialias by default. (create3DContext):
- fast/canvas/webgl/script-tests/index-validation.js: By default antialias is off.
- 2:25 PM Changeset in webkit [57233] by
-
- 1 edit in trunk/WebCore/ChangeLog
Fix a typo.
- 2:25 PM Changeset in webkit [57232] by
-
- 5 edits in trunk/WebCore
Reviewed by Darinn Adler.
https://bugs.webkit.org/show_bug.cgi?id=37230
<rdar://problem/7813115> REGRESSION (4.0.5): Safari asks for credentials all the time when
authenticating to Windows IIS Server
- platform/network/ProtectionSpace.h: (WebCore::ProtectionSpaceAuthenticationScheme): Added a constant for ProtectionSpaceAuthenticationSchemeUnknown.
- platform/network/cf/AuthenticationCF.cpp: (WebCore::core):
- platform/network/cf/SocketStreamHandleCFNet.cpp: (WebCore::authenticationSchemeFromAuthenticationMethod): Return ProtectionSpaceAuthenticationSchemeUnknown for unknown scheme.
- platform/network/mac/AuthenticationMac.mm: (WebCore::mac): Support NTLM on systems older than 10.6. We actually get this string from NSURLConnection, even though there was no public constant. (WebCore::core): Return ProtectionSpaceAuthenticationSchemeUnknown for unknown scheme.
- 2:20 PM Changeset in webkit [57231] by
-
- 17 edits in trunk
2010-04-07 Jaime Yap <jaimeyap@google.com>
Reviewed by Pavel Feldman.
Tests expectations changed due to the addition of the function symbol name for
the call location for records sent by the InspectorTimelineAgent.
https://bugs.webkit.org/show_bug.cgi?id=36839
No new tests.
- inspector/timeline-test.js:
- platform/chromium-win/inspector/timeline-event-dispatch-expected.txt:
- platform/chromium-win/inspector/timeline-mark-timeline-expected.txt:
- platform/chromium-win/inspector/timeline-network-resource-expected.txt:
- platform/chromium-win/inspector/timeline-paint-expected.txt:
- platform/chromium-win/inspector/timeline-parse-html-expected.txt:
2010-04-07 Jaime Yap <jaimeyap@google.com>
Reviewed by Pavel Feldman.
Adds the ability to get the function symbol name when looking up the call location
for records sent by the InspectorTimelineAgent.
https://bugs.webkit.org/show_bug.cgi?id=36839
No new tests.
- bindings/js/ScriptCallStack.cpp: (WebCore::ScriptCallStack::callLocation):
- bindings/js/ScriptCallStack.h:
- bindings/v8/ScriptCallStack.cpp: (WebCore::ScriptCallStack::create): (WebCore::ScriptCallStack::callLocation): (WebCore::ScriptCallStack::ScriptCallStack):
- bindings/v8/ScriptCallStack.h:
- bindings/v8/ScriptDebugServer.cpp: (WebCore::ScriptDebugServer::createUtilityContext): (WebCore::ScriptDebugServer::topStackFrame):
- bindings/v8/ScriptDebugServer.h: (WebCore::ScriptDebugServer::utilityContext):
- bindings/v8/V8Proxy.cpp:
- bindings/v8/V8Proxy.h:
- inspector/TimelineRecordFactory.cpp: (WebCore::TimelineRecordFactory::createGenericRecord):
- 2:10 PM Changeset in webkit [57230] by
-
- 3 edits3 adds in trunk
2010-04-07 Jay Civelli <jcivelli@chromium.org>
Reviewed by Jian Li.
[chromium] Add test for a popup related crasher.
https://bugs.webkit.org/show_bug.cgi?id=37141
- platform/chromium/fast/forms: Added.
- platform/chromium/fast/forms/search-popup-crasher-expected.txt: Added.
- platform/chromium/fast/forms/search-popup-crasher.html: Added.
2010-04-07 Jay Civelli <jcivelli@chromium.org>
Reviewed by Jian Li.
[chromium] Fixing a NULL pointer being dereferenced in some cases.
https://bugs.webkit.org/show_bug.cgi?id=37141
Test: platform/chromium/fast/forms/search-popup-crasher.html
- platform/chromium/PopupMenuChromium.cpp: (WebCore::PopupMenu::~PopupMenu):
- 1:47 PM Changeset in webkit [57229] by
-
- 8 edits3 copies in trunk/WebCore
Add skeleton FileStream module for providing sync file operations for FileAPI
https://bugs.webkit.org/show_bug.cgi?id=37217
Patch by Kinuko Yasuda <kinuko@chromium.org> on 2010-04-07
Reviewed by Jian Li.
For now the module just defines an interface and is almost empty.
Implementation will be added.
No new tests; will be added when we have complete implementation.
- GNUmakefile.am:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- html/FileStream.cpp: Added.
- html/FileStream.h: Added.
- html/FileStreamClient.h: Added.
- html/FileThread.cpp:
(WebCore::SameFilePredicate::SameFilePredicate):
(WebCore::SameFilePredicate::operator()):
(WebCore::FileThread::unscheduleTasks):
- html/FileThread.h:
(WebCore::FileThread::Task::stream):
(WebCore::FileThread::Task::Task):
- 1:44 PM Changeset in webkit [57228] by
-
- 1 edit2 adds in trunk/LayoutTests
Rubber-stamped by Kenneth Rohde Christiansen.
Poor rendering on lala.com with frame flattening
https://bugs.webkit.org/show_bug.cgi?id=37164
Platform specific expected files added for test introduced in r57225.
- platform/mac/fast/frames/flattening/iframe-flattening-offscreen-expected.txt: Added.
- platform/qt/fast/frames/flattening/iframe-flattening-offscreen-expected.txt: Added.
- 1:37 PM Changeset in webkit [57227] by
-
- 5 edits in trunk/WebCore
2010-04-07 Oliver Hunt <oliver@apple.com>
Reviewed by Darin Adler.
Remove some unnecessary uses of commonJSGlobalData
https://bugs.webkit.org/show_bug.cgi?id=37229
Pass the ExecState down to identifierFromNPIdentifier and update call sites
- bridge/NP_jsobject.cpp: (_NPN_Invoke): (_NPN_GetProperty): (_NPN_SetProperty): (_NPN_RemoveProperty): (_NPN_HasProperty): (_NPN_HasMethod):
- bridge/c/c_instance.cpp: (JSC::Bindings::CInstance::getPropertyNames):
- bridge/c/c_utility.cpp: (JSC::Bindings::identifierFromNPIdentifier):
- bridge/c/c_utility.h:
- 1:32 PM Changeset in webkit [57226] by
-
- 2 edits in trunk/JavaScriptCore
2010-04-07 Kwang Yul Seo <skyul@company100.net>
Reviewed by Darin Adler.
Replace isprint with isASCIIPrintable
https://bugs.webkit.org/show_bug.cgi?id=37223
WebKit does not use functions in <ctype.h> as they are dependent on the current
locale. Use the equivalent functions in <wtf/ASCIICType.h>. isASCIIPrintable
replaces isprint.
- pcre/pcre_exec.cpp: (pchars):
- 1:22 PM Changeset in webkit [57225] by
-
- 3 edits1 add in trunk
2010-04-07 Kenneth Rohde Christiansen <kenneth@webkit.org>
Reviewed by Darin Adler.
Poor rendering on lala.com with frame flattening
https://bugs.webkit.org/show_bug.cgi?id=37164
Do not flatten offscreen iframes.
Test: fast/frames/flattening/iframe-flattening-offscreen.html
- rendering/RenderPartObject.cpp: (WebCore::RenderPartObject::flattenFrame):
- rendering/RenderPartObject.h:
- 12:57 PM BuildBot edited by
- update contact and port (diff)
- 12:49 PM Changeset in webkit [57224] by
-
- 3 edits3 adds in trunk
2010-04-07 Abhishek Arya <inferno@chromium.org>
Reviewed by Adam Barth.
Make sure that calling bindings constructors as function does not result in crash.
- fast/constructors: Added.
- fast/constructors/constructor-as-function-crash-expected.txt: Added.
- fast/constructors/constructor-as-function-crash.html: Added.
2010-04-07 Abhishek Arya <inferno@chromium.org>
Reviewed by Adam Barth.
[V8] Add a missing check for constructor call in WebKitPointConstructor.
https://bugs.webkit.org/show_bug.cgi?id=37210
Test: fast/constructors/constructor-as-function-crash.html
- bindings/v8/custom/V8WebKitPointConstructor.cpp: (WebCore::V8WebKitPoint::constructorCallback): Added a check for constructor call.
- 12:17 PM Changeset in webkit [57223] by
-
- 5 edits in trunk/LayoutTests
2010-04-07 Ojan Vafai <ojan@chromium.org>
Reviewed by Simon Fraser.
Make tests pass with tolerance=0 after r57215
https://bugs.webkit.org/show_bug.cgi?id=37225
- platform/mac-leopard/fast/text/complex-text-opacity-expected.checksum:
- platform/mac-leopard/fast/text/complex-text-opacity-expected.png:
- platform/mac/fast/repaint/stacked-diacritics-expected.checksum:
- platform/mac/fast/repaint/stacked-diacritics-expected.png:
- 11:54 AM Changeset in webkit [57222] by
-
- 2 edits3 deletes in trunk/LayoutTests
2010-04-07 Andrew Scherkus <scherkus@chromium.org>
Unreviewed, skipping fast/media/media-feature-wgt-view-mode.html for Chromium.
Chromium doesn't implement layoutTestController.setViewModeMediaFeature(), which is needed
to pass this layout test.
- platform/chromium-win/fast/media/media-feature-wgt-view-mode-expected.checksum: Removed.
- platform/chromium-win/fast/media/media-feature-wgt-view-mode-expected.png: Removed.
- platform/chromium-win/fast/media/media-feature-wgt-view-mode-expected.txt: Removed.
- platform/chromium/test_expectations.txt: Skip fast/media/media-feature-wgt-view-mode.html.
- 11:44 AM Changeset in webkit [57221] by
-
- 1 edit in trunk/WebCore/platform/graphics/mac/SimpleFontDataMac.mm
Fixing TIGER build (take 2)
- 11:16 AM Changeset in webkit [57220] by
-
- 3 edits5 adds in trunk/WebKit/chromium
2010-04-07 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Chromium: support themes in devtools window.
- WebKit.gypi:
- src/js/DevTools.js: (WebInspector.setToolbarColors): (WebInspector.resetToolbarColors):
- src/js/Images/segmentChromium2.png: Added.
- src/js/Images/segmentHoverChromium2.png: Added.
- src/js/Images/segmentSelectedChromium2.png: Added.
- src/js/Images/statusbarBackgroundChromium2.png: Added.
- src/js/Images/statusbarMenuButtonChromium2.png: Added.
- 11:12 AM Changeset in webkit [57219] by
-
- 3 edits4 adds in trunk/LayoutTests
2010-04-07 Andrew Scherkus <scherkus@chromium.org>
Unreviewed, checking in missing image baselines for fast/layers/video-layer.html
- platform/chromium-linux/fast/layers/video-layer-expected.checksum: Added.
- platform/chromium-linux/fast/layers/video-layer-expected.png: Added.
- platform/chromium-mac/fast/layers/video-layer-expected.checksum: Added.
- platform/chromium-mac/fast/layers/video-layer-expected.png: Added.
- platform/chromium-win/fast/layers/video-layer-expected.checksum: Updated.
- platform/chromium-win/fast/layers/video-layer-expected.png: Updated.
- 10:59 AM Changeset in webkit [57218] by
-
- 5 edits in trunk
https://bugs.webkit.org/show_bug.cgi?id=37219
Reviewed by Darin Adler.
This change disables text caret for the iPhone platflorm.
- wtf/Platform.h: Disabled text caret for iPhone.
WebCore:
This change disables text caret for the iPhone platflorm.
Added UNUSED_PARAM to build when ENABLE_TEXT_CARET is 0.
- editing/SelectionController.cpp:
(WebCore::SelectionController::recomputeCaretRect):
(WebCore::SelectionController::paintCaret):
- page/Frame.cpp:
(WebCore::Frame::paintDragCaret):
- 10:57 AM Changeset in webkit [57217] by
-
- 1 edit in trunk/WebCore/platform/graphics/mac/SimpleFontDataMac.mm
Fixing TIGER build
- 10:06 AM Changeset in webkit [57216] by
-
- 1 edit in trunk/LayoutTests/ChangeLog
Text repainting does not account for glyphs which draw outside the typographic bounds of the font (6274).
<rdar://problem/6649734>
<https://bugs.webkit.org/show_bug.cgi?id=6274>
Reviewed by Dave Hyatt.
- fast/repaint/stacked-diacritics.html: Added.
- platform/mac/fast/repaint/stacked-diacritics-expected.checksum: Added.
- platform/mac/fast/repaint/stacked-diacritics-expected.png: Added.
- platform/mac/fast/repaint/stacked-diacritics-expected.txt: Added.
- 10:01 AM Changeset in webkit [57215] by
-
- 42 edits2 moves4 adds in trunk
WebCore: Text repainting does not account for glyphs which draw outside the typographic bounds of the font (6274).
<rdar://problem/6649734>
<https://bugs.webkit.org/show_bug.cgi?id=6274>
Reviewed by Dave Hyatt.
In order to be able to handle successfully this case, it is necessary to change the glyph width cache to store
the bounding box for the glyph instead of the simply caching the glyph width.
Retrieving the bounding box for the glyph is expensive, therefore we do it only
when we are rendering text using the complex text path to minimize the performance impact.
To support characters with stacked diacritics, the method canUseGlyphCache has been modified to
return false for the range of characters with stacked diacritics.
The glyph cache has been also updated to allow storing the glyph bounding box together with the
horizontal width. The bounding box is populated only for complex text.
The original version of this patch has been written by Dan Bernstein.
Test: fast/repaint/stacked-diacritics.html
- Android.mk: File name change.
- GNUmakefile.am: File name change.
- WebCore.base.exp: Added parameter in exported function.
- WebCore.gypi: File name change.
- WebCore.vcproj/WebCore.vcproj: File name change.
- WebCore.xcodeproj/project.pbxproj: File name change.
- platform/graphics/Font.cpp:
(WebCore::Font::floatWidth): Added glyphOverflow parameter.
- platform/graphics/Font.h:
(WebCore::GlyphOverflow::GlyphOverflow): Added.
(WebCore::Font::width): Added glyphOverflow parameter.
- platform/graphics/FontFastPath.cpp:
(WebCore::Font::canUseGlyphCache): Modified to render characters with stacked diacritics with complex text path.
- platform/graphics/GlyphMetricsMap.cpp: Copied from WebCore/platform/graphics/GlyphWidthMap.cpp.
(WebCore::GlyphMetricsMap::locatePageSlowCase): Class name changed to reflect new semantics.
- platform/graphics/GlyphMetricsMap.h: Copied from WebCore/platform/graphics/GlyphWidthMap.h.
(WebCore::GlyphMetricsMap::GlyphMetricsMap):
(WebCore::GlyphMetricsMap::~GlyphMetricsMap):
(WebCore::GlyphMetricsMap::metricsForGlyph):
(WebCore::GlyphMetricsMap::widthForGlyph):
(WebCore::GlyphMetricsMap::setMetricsForGlyph):
(WebCore::GlyphMetricsMap::GlyphMetricsPage::metricsForGlyph):
(WebCore::GlyphMetricsMap::GlyphMetricsPage::setMetricsForGlyph):
(WebCore::GlyphMetricsMap::GlyphMetricsPage::setMetricsForIndex):
(WebCore::GlyphMetricsMap::locatePage):
- platform/graphics/GlyphWidthMap.cpp: Removed.
- platform/graphics/GlyphWidthMap.h: Removed.
- platform/graphics/SimpleFontData.cpp:
(WebCore::SimpleFontData::platformGlyphInit):
- platform/graphics/SimpleFontData.h:
(WebCore::):
(WebCore::SimpleFontData::widthForGlyph):
(WebCore::SimpleFontData::metricsForGlyph):
- platform/graphics/cairo/SimpleFontDataCairo.cpp:
(WebCore::SimpleFontData::platformMetricsForGlyph): Name and signature change.
- platform/graphics/chromium/FontChromiumWin.cpp:
(WebCore::Font::floatWidthForComplexText): Added parameter.
- platform/graphics/chromium/FontLinux.cpp:
(WebCore::Font::floatWidthForComplexText): Added parameter.
- platform/graphics/chromium/SimpleFontDataChromiumWin.cpp:
(WebCore::SimpleFontData::platformMetricsForGlyph): Name and signature change.
- platform/graphics/chromium/SimpleFontDataLinux.cpp:
(WebCore::SimpleFontData::platformWidthForGlyph): Name and signature vachange
- platform/graphics/efl/FontEfl.cpp:
(WebCore::Font::floatWidthForComplexText): Name and signature change.
- platform/graphics/gtk/SimpleFontDataPango.cpp:
(WebCore::SimpleFontData::platformMetricsForGlyph): Name and signature change.
- platform/graphics/haiku/FontHaiku.cpp:
(WebCore::Font::floatWidthForComplexText): Added parameter.
- platform/graphics/haiku/SimpleFontDataHaiku.cpp:
(WebCore::SimpleFontData::platformMetricsForGlyph): Name and signature change.
- platform/graphics/mac/ComplexTextController.cpp:
(WebCore::ComplexTextController::ComplexTextController):
(WebCore::ComplexTextController::adjustGlyphsAndAdvances):
- platform/graphics/mac/ComplexTextController.h:
(WebCore::ComplexTextController::minGlyphBoundingBoxX):
(WebCore::ComplexTextController::maxGlyphBoundingBoxX):
(WebCore::ComplexTextController::minGlyphBoundingBoxY):
(WebCore::ComplexTextController::maxGlyphBoundingBoxY):
- platform/graphics/mac/FontComplexTextMac.cpp:
(WebCore::Font::floatWidthForComplexText): Added paramter.
- platform/graphics/mac/SimpleFontDataMac.mm:
(WebCore::SimpleFontData::platformMetricsForGlyph): Name and signature change.
- platform/graphics/qt/FontQt.cpp:
(WebCore::Font::floatWidthForComplexText): Added paramter.
- platform/graphics/win/FontWin.cpp:
(WebCore::Font::floatWidthForComplexText): Added parameter.
- platform/graphics/win/SimpleFontDataCGWin.cpp:
(WebCore::SimpleFontData::platformMetricsForGlyph): Name and signature change.
- platform/graphics/win/SimpleFontDataWin.cpp:
(WebCore::SimpleFontData::metricsForGDIGlyph):
- platform/graphics/win/UniscribeController.cpp:
(WebCore::UniscribeController::UniscribeController):
(WebCore::UniscribeController::shapeAndPlaceItem):
- platform/graphics/win/UniscribeController.h:
(WebCore::UniscribeController::minGlyphBoundingBoxX):
(WebCore::UniscribeController::maxGlyphBoundingBoxX):
(WebCore::UniscribeController::minGlyphBoundingBoxY):
(WebCore::UniscribeController::maxGlyphBoundingBoxY):
- platform/graphics/wince/FontWince.cpp:
(WebCore::Font::floatWidthForComplexText): Added parameter.
- platform/graphics/wx/FontWx.cpp:
(WebCore::Font::floatWidthForComplexText): Added parameter.
- platform/graphics/wx/SimpleFontDataWx.cpp:
(WebCore::SimpleFontData::platformMetricsForGlyph): Name and signature change.
- rendering/InlineFlowBox.cpp:
(WebCore::InlineFlowBox::placeBoxesHorizontally):
(WebCore::InlineFlowBox::computeLogicalBoxHeights):
(WebCore::InlineFlowBox::computeVerticalOverflow):
- rendering/InlineTextBox.cpp:
(WebCore::InlineTextBox::setFallbackFonts):
(WebCore::InlineTextBox::fallbackFonts):
(WebCore::InlineTextBox::setGlyphOverflow):
(WebCore::InlineTextBox::glyphOverflow):
- rendering/InlineTextBox.h:
(WebCore::InlineTextBox::clearGlyphOverflowAndFallbackFontMap): Added.
- rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::computeHorizontalPositionsForLine):
(WebCore::RenderBlock::layoutInlineChildren):
- rendering/RenderText.cpp:
(WebCore::RenderText::RenderText):
(WebCore::RenderText::styleDidChange):
(WebCore::RenderText::widthFromCache):
(WebCore::RenderText::trimmedPrefWidths):
(WebCore::RenderText::calcPrefWidths):
(WebCore::RenderText::setText):
(WebCore::RenderText::width):
- rendering/RenderText.h:
LayoutTests: Text repainting does not account for glyphs which draw outside the typographic bounds of the font (6274).
<rdar://problem/6649734>
<https://bugs.webkit.org/show_bug.cgi?id=6274>
Reviewed by Dave Hyatt.
- fast/repaint/stacked-diacritics.html: Added.
- platform/mac/fast/repaint/stacked-diacritics-expected.checksum: Added.
- platform/mac/fast/repaint/stacked-diacritics-expected.png: Added.
- platform/mac/fast/repaint/stacked-diacritics-expected.txt: Added.
- 9:53 AM Changeset in webkit [57214] by
-
- 2 edits in trunk/WebCore
2010-04-07 Joseph Pecoraro <Joseph Pecoraro>
Reviewed by Darin Adler.
Fix incorrect white-space in WebGLRenderingContext.idl
https://bugs.webkit.org/show_bug.cgi?id=31339
- html/canvas/WebGLRenderingContext.idl: Remove offending extra whitespace.
- 9:43 AM Changeset in webkit [57213] by
-
- 2 edits in trunk/WebCore
2010-04-07 Rodrigo Belem <rodrigo.belem@openbossa.org>
Reviewed by Simon Hausmann.
[Qt] The build system is not installing the generated headers (QGraphicsWebView, QWebDatabase, etc)
https://bugs.webkit.org/show_bug.cgi?id=37173
This patch sets the correct path to the classheaders.pri and then
fixes the installation of the generated headers.
- WebCore.pro:
- 9:33 AM Changeset in webkit [57212] by
-
- 1 edit2 adds in trunk/WebKit
2010-04-07 Leandro Pereira <leandro@profusion.mobi>
Reviewed by Kenneth Rohde Christiansen.
Add ewk_view (the high level object to acces the WebKit-EFL browser
component) to efl/ewk.
http://webkit.org/b/35932
- efl/ewk/ewk_view.cpp: Added.
- efl/ewk/ewk_view.h: Added.
- 9:32 AM Changeset in webkit [57211] by
-
- 2 edits in trunk/WebCore
Spatial Navigation: bail out as soon as algorithm finds a focus candidate is not applicable https://bugs.webkit.org/show_bug.cgi?id=37135
Reviewed by Kenneth Christiansen.
Patch by Antonio Gomes <tonikitoo@webkit.org>
It happens, for example, when distanceDataForNode assigns numeric_limits<long long> to
current focus candidate's. It means that current candidate is not in direction, or not
a valid target node.
- page/FocusController.cpp:
(WebCore::FocusController::findFocusableNodeInDirection):
- 9:18 AM Changeset in webkit [57210] by
-
- 44 edits in trunk
2010-04-07 Andrey Kosyakov <caseq@chromium.org>
Reviewed by Yury Semikhatsky.
Removed inspector methods from ScriptExecutionContext and derived classes.
Removed MessageDestination parameter from console-related calls (we now always
log to the same destination(s)).
Removed redundant FrameLoaderClient::dispatchDidLoadResourceByXMLHttpRequest()
https://bugs.webkit.org/show_bug.cgi?id=36949
- dom/Document.cpp: (WebCore::Document::reportException): (WebCore::Document::addMessage):
- dom/Document.h:
- dom/ScriptExecutionContext.h:
- loader/EmptyClients.h: (WebCore::EmptyFrameLoaderClient::dispatchDidLoadResourceFromMemoryCache):
- loader/FrameLoaderClient.h:
- loader/ResourceLoadNotifier.cpp:
- loader/ResourceLoadNotifier.h:
- websockets/WebSocket.cpp: (WebCore::WebSocket::connect):
- websockets/WebSocketChannel.cpp: (WebCore::WebSocketChannel::didOpen): (WebCore::WebSocketChannel::appendToBuffer):
- websockets/WebSocketHandshake.cpp: (WebCore::WebSocketHandshake::readServerHandshake): (WebCore::WebSocketHandshake::readHTTPHeaders): (WebCore::WebSocketHandshake::checkResponseHeaders):
- workers/DefaultSharedWorkerRepository.cpp: (WebCore::postConsoleMessageTask): (WebCore::SharedWorkerProxy::postConsoleMessageToWorkerObject):
- workers/WorkerContext.cpp: (WebCore::WorkerContext::importScripts): (WebCore::WorkerContext::addMessage):
- workers/WorkerContext.h:
- workers/WorkerMessagingProxy.cpp: (WebCore::postConsoleMessageTask): (WebCore::WorkerMessagingProxy::postConsoleMessageToWorkerObject):
- workers/WorkerMessagingProxy.h:
- workers/WorkerReportingProxy.h:
- xml/XMLHttpRequest.cpp: (WebCore::reportUnsafeUsage): (WebCore::XMLHttpRequest::didFinishLoading):
2010-04-07 Andrey Kosyakov <caseq@chromium.org>
Reviewed by Yury Semikhatsky.
Removed inspector methods from ScriptExecutionContext and derived classes.
Removed MessageDestination parameter from console-related calls (we now always
log to the same destination(s)).
Removed redundant FrameLoaderClient::dispatchDidLoadResourceByXMLHttpRequest()
https://bugs.webkit.org/show_bug.cgi?id=36949
- public/WebCommonWorkerClient.h: (WebKit::WebCommonWorkerClient::postConsoleMessageToWorkerObject):
- src/FrameLoaderClientImpl.cpp:
- src/FrameLoaderClientImpl.h:
- src/WebWorkerBase.cpp: (WebKit::WebWorkerBase::postConsoleMessageToWorkerObject): (WebKit::WebWorkerBase::postConsoleMessageTask):
- src/WebWorkerBase.h:
- src/WebWorkerClientImpl.cpp: (WebKit::WebWorkerClientImpl::postConsoleMessageToWorkerObject): (WebKit::WebWorkerClientImpl::postConsoleMessageToWorkerObjectTask):
- src/WebWorkerClientImpl.h:
2010-04-07 Andrey Kosyakov <caseq@chromium.org>
Reviewed by Yury Semikhatsky.
Removed redundant FrameLoaderClient::dispatchDidLoadResourceByXMLHttpRequest()
https://bugs.webkit.org/show_bug.cgi?id=36949
- WebCoreSupport/FrameLoaderClientGtk.cpp:
- WebCoreSupport/FrameLoaderClientGtk.h:
2010-04-07 Andrey Kosyakov <caseq@chromium.org>
Reviewed by Yury Semikhatsky.
Removed redundant FrameLoaderClient::dispatchDidLoadResourceByXMLHttpRequest()
https://bugs.webkit.org/show_bug.cgi?id=36949
- WebCoreSupport/FrameLoaderClientHaiku.cpp:
- WebCoreSupport/FrameLoaderClientHaiku.h:
2010-04-07 Andrey Kosyakov <caseq@chromium.org>
Reviewed by Yury Semikhatsky.
Removed redundant FrameLoaderClient::dispatchDidLoadResourceByXMLHttpRequest()
https://bugs.webkit.org/show_bug.cgi?id=36949
- WebCoreSupport/WebFrameLoaderClient.h:
- WebCoreSupport/WebFrameLoaderClient.mm:
2010-04-07 Andrey Kosyakov <caseq@chromium.org>
Reviewed by Yury Semikhatsky.
Removed redundant FrameLoaderClient::dispatchDidLoadResourceByXMLHttpRequest()
https://bugs.webkit.org/show_bug.cgi?id=36949
- WebCoreSupport/FrameLoaderClientQt.cpp:
- WebCoreSupport/FrameLoaderClientQt.h:
2010-04-07 Andrey Kosyakov <caseq@chromium.org>
Reviewed by Yury Semikhatsky.
Removed redundant FrameLoaderClient::dispatchDidLoadResourceByXMLHttpRequest()
https://bugs.webkit.org/show_bug.cgi?id=36949
- WebCoreSupport/WebFrameLoaderClient.cpp:
- WebCoreSupport/WebFrameLoaderClient.h:
2010-04-07 Andrey Kosyakov <caseq@chromium.org>
Reviewed by Yury Semikhatsky.
Removed redundant FrameLoaderClient::dispatchDidLoadResourceByXMLHttpRequest()
https://bugs.webkit.org/show_bug.cgi?id=36949
- WebKitSupport/FrameLoaderClientWx.cpp:
- WebKitSupport/FrameLoaderClientWx.h:
- 8:52 AM Changeset in webkit [57209] by
-
- 2 edits in trunk/WebKit/chromium
2010-04-07 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Darin Fisher.
[Chromium] WebIDBDatabaseError::assign doesn't work correctly
https://bugs.webkit.org/show_bug.cgi?id=37209
- src/WebIDBDatabaseError.cpp: (WebKit::WebIDBDatabaseError::assign):
- 7:14 AM Changeset in webkit [57208] by
-
- 7 edits in trunk
https://bugs.webkit.org/show_bug.cgi?id=36827
Patch by Dawit Alemayehu <adawit@kde.org> on 2010-04-07
Reviewed by Simon Hausmann.
WebCore:
Replaced the 'shouldTreatAsAttachment' function with a more generic
function that returns the content disposition type.
See comments 39-42 in https://bugs.webkit.org/show_bug.cgi?id=36395
- platform/network/HTTPParsers.cpp:
(WebCore::contentDispositionType):
- platform/network/HTTPParsers.h:
(WebCore::):
WebKit/chromium:
Updated the WebCore::shouldTreatAsAttachement function call with the
new more generic replacement WebCore::contentDispositionType.
See comments 39-42 in https://bugs.webkit.org/show_bug.cgi?id=36395
- src/FrameLoaderClientImpl.cpp:
(WebKit::FrameLoaderClientImpl::dispatchDecidePolicyForMIMEType):
WebKit/qt:
Updated the WebCore::shouldTreatAsAttachement function call with the
new more generic replacement WebCore::contentDispositionType.
See comments 39-42 in https://bugs.webkit.org/show_bug.cgi?id=36395
- WebCoreSupport/FrameLoaderClientQt.cpp:
(WebCore::FrameLoaderClientQt::dispatchDecidePolicyForMIMEType):
- 7:04 AM Changeset in webkit [57207] by
-
- 10 edits in trunk/WebCore
2010-04-07 Vitaly Repeshko <vitalyr@chromium.org>
Reviewed by Yury Semikhatsky.
[V8] Throw exception in SerializedScriptValue on input errors
https://bugs.webkit.org/show_bug.cgi?id=37160
When cycles are detected SerializedScriptValue should throw
NOT_SUPPORTED_ERR. See
http://www.whatwg.org/specs/web-apps/2009-10-27/multipage/urls.html#structured-clone
- bindings/scripts/CodeGeneratorV8.pm: Custom processing for function arguments of type SerializedScriptValue.
- bindings/v8/SerializedScriptValue.cpp: (WebCore::SerializedScriptValue::SerializedScriptValue):
- bindings/v8/SerializedScriptValue.h: (WebCore::SerializedScriptValue::create): Added a constructor function with an extra paratemer to check whether an exception was thrown.
SerializedScriptValue::create callers updated to check for
exceptions:
- bindings/v8/custom/V8DOMWindowCustom.cpp: (WebCore::V8DOMWindow::postMessageCallback):
- bindings/v8/custom/V8DedicatedWorkerContextCustom.cpp: (WebCore::V8DedicatedWorkerContext::postMessageCallback):
- bindings/v8/custom/V8HistoryCustom.cpp: (WebCore::V8History::pushStateCallback): (WebCore::V8History::replaceStateCallback):
- bindings/v8/custom/V8MessagePortCustom.cpp: (WebCore::V8MessagePort::postMessageCallback):
- bindings/v8/custom/V8PopStateEventCustom.cpp: (WebCore::V8PopStateEvent::initPopStateEventCallback):
- bindings/v8/custom/V8WorkerCustom.cpp: (WebCore::V8Worker::postMessageCallback):
- 6:10 AM Changeset in webkit [57206] by
-
- 5 edits in trunk/WebCore
2010-04-07 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: Provide a placeholder for resources with no content available
https://bugs.webkit.org/show_bug.cgi?id=37142
- English.lproj/localizedStrings.js:
- inspector/front-end/ImageView.js: (WebInspector.ImageView): (WebInspector.ImageView.prototype.contentTabSelected):
- inspector/front-end/ResourceView.js: (WebInspector.ResourceView.prototype._innerSelectContentTab): (WebInspector.ResourceView.prototype.contentTabSelected):
- inspector/front-end/inspector.css: (.resource-content-unavailable):
- 5:48 AM Changeset in webkit [57205] by
-
- 4 edits in trunk/WebCore
https://bugs.webkit.org/show_bug.cgi?id=36750
Reviewed by Laszlo Gombos.
[Qt] Package build without touch support is broken
Use the conditional attribute instead of #ifdefs in the idl file for the
touch specific properties, to make the generated files compile with and
without the touch events enabled.
- dom/Document.idl: Use conditional instead of #ifdef.
- dom/Element.idl: Ditto.
- page/DOMWindow.idl: Ditto.
- 5:03 AM Changeset in webkit [57204] by
-
- 4 edits in trunk/WebCore
Add the touch event related IDL files to the idl generation, so that
they can be safely included from generated JS bindings files. The
generated files have #ifdef feature guards.
Reviewed by Holger Freyther.
- DerivedSources.cpp:
- DerivedSources.make:
- GNUmakefile.am:
- 4:39 AM Changeset in webkit [57203] by
-
- 4 edits in trunk/WebCore
2010-04-06 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Adam Barth.
V8CustomIDBCallbacks<> should not hold a reference to the frame
https://bugs.webkit.org/show_bug.cgi?id=37154
Don't hold on to a Frame reference.
Instead, be an ActiveDOMObject and use scriptExecutionContext()
to get the v8 context.
Factor the guts of onSuccess and onError out.
Doesn't work enough to test yet.
- bindings/v8/custom/V8CustomIDBCallbacks.h: (WebCore::V8CustomIDBCallbacks::create): (WebCore::V8CustomIDBCallbacks::onSuccess): (WebCore::V8CustomIDBCallbacks::onError): (WebCore::V8CustomIDBCallbacks::V8CustomIDBCallbacks): (WebCore::V8CustomIDBCallbacks::onEvent):
- bindings/v8/custom/V8IndexedDatabaseRequestCustom.cpp: (WebCore::V8IndexedDatabaseRequest::openCallback):
- storage/IDBCallbacks.h: (WebCore::IDBCallbacks::IDBCallbacks):
- 4:14 AM Changeset in webkit [57202] by
-
- 2 edits in trunk/WebKit/qt
2010-04-07 Andreas Kling <andreas.kling@nokia.com>
Reviewed by Simon Hausmann.
[Qt] When providing a widget for the PDF mime type it will cause a crash
m_pluginView may actually be a Widget (for embedded Qt widgets),
so always check isPluginView() before calling PluginView specific methods.
- WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::finishedLoading): (WebCore::FrameLoaderClientQt::setMainDocumentError): (WebCore::FrameLoaderClientQt::committedLoad):
- 3:19 AM Changeset in webkit [57201] by
-
- 12 edits in trunk
2010-04-07 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r57196.
http://trac.webkit.org/changeset/57196
https://bugs.webkit.org/show_bug.cgi?id=37196
Multiple layout test failures on Chromium (Requested by yurys
on #webkit).
- inspector/timeline-test.js:
2010-04-07 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r57196.
http://trac.webkit.org/changeset/57196
https://bugs.webkit.org/show_bug.cgi?id=37196
Multiple layout test failures on Chromium (Requested by yurys
on #webkit).
- bindings/js/ScriptCallStack.cpp: (WebCore::ScriptCallStack::callLocation):
- bindings/js/ScriptCallStack.h:
- bindings/v8/ScriptCallStack.cpp: (WebCore::ScriptCallStack::create): (WebCore::ScriptCallStack::callLocation): (WebCore::ScriptCallStack::ScriptCallStack):
- bindings/v8/ScriptCallStack.h:
- bindings/v8/ScriptDebugServer.cpp:
- bindings/v8/ScriptDebugServer.h:
- bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::createUtilityContext): (WebCore::V8Proxy::sourceLineNumber): (WebCore::V8Proxy::sourceName):
- bindings/v8/V8Proxy.h: (WebCore::V8Proxy::utilityContext):
- inspector/TimelineRecordFactory.cpp: (WebCore::TimelineRecordFactory::createGenericRecord):
- 3:07 AM QtWebKitTriageRoster edited by
- (diff)
- 2:19 AM Changeset in webkit [57200] by
-
- 4 edits in trunk/WebCore
Unreviewed, rolling out r57199.
http://trac.webkit.org/changeset/57199
https://bugs.webkit.org/show_bug.cgi?id=36750
Breaks non-touch enabled build
- dom/Document.idl:
- dom/Element.idl:
- page/DOMWindow.idl:
- 2:08 AM Changeset in webkit [57199] by
-
- 4 edits in trunk/WebCore
https://bugs.webkit.org/show_bug.cgi?id=36750
Reviewed by Laszlo Gombos.
[Qt] Package build without touch support is broken
Use the conditional attribute instead of #ifdefs in the idl file for the
touch specific properties, to make the generated files compile with and
without the touch events enabled.
- dom/Document.idl: Use conditional instead of #ifdef.
- dom/Element.idl: Ditto.
- page/DOMWindow.idl: Ditto.
- 1:15 AM Changeset in webkit [57198] by
-
- 2 edits in trunk
2010-04-07 Laszlo Gombos <Laszlo Gombos>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Fix trunk (non-standalone) builds for Symbian
https://bugs.webkit.org/show_bug.cgi?id=37136
Test for source files before building instead of relying on
standalone_package config.
- WebKit.pro:
- 12:39 AM Changeset in webkit [57197] by
-
- 3 edits in trunk/WebKit/chromium
2010-04-07 Jochen Eisinger <jochen@chromium.org>
Reviewed by Darin Fisher.
Add createApplicationCacheHost to WebFrameClient so
the ApplicationCacheHost has access to its frame.
- public/WebFrameClient.h: (WebKit::WebFrameClient::createApplicationCacheHost):
- src/ApplicationCacheHostInternal.h: (WebCore::ApplicationCacheHostInternal::ApplicationCacheHostInternal):
- 12:20 AM Changeset in webkit [57196] by
-
- 12 edits in trunk
2010-04-07 Jaime Yap <jaimeyap@google.com>
Reviewed by Yury Semikhatsky.
Adds callerFuncName to the list of nondeterministic fields in the timeline
layout tests.
https://bugs.webkit.org/show_bug.cgi?id=36839
- inspector/timeline-test.js:
2010-04-07 Jaime Yap <jaimeyap@google.com>
Reviewed by Yury Semikhatsky.
Adds the ability to get the function symbol name when looking up the call location
for records sent by the InspectorTimelineAgent.
https://bugs.webkit.org/show_bug.cgi?id=36839
No new tests.
- bindings/js/ScriptCallStack.cpp: (WebCore::ScriptCallStack::callLocation):
- bindings/js/ScriptCallStack.h:
- bindings/v8/ScriptCallStack.cpp: (WebCore::ScriptCallStack::create): (WebCore::ScriptCallStack::callLocation): (WebCore::ScriptCallStack::ScriptCallStack):
- bindings/v8/ScriptCallStack.h:
- bindings/v8/ScriptDebugServer.cpp: (WebCore::ScriptDebugServer::createUtilityContext): (WebCore::ScriptDebugServer::lastCallFrame):
- bindings/v8/ScriptDebugServer.h: (WebCore::ScriptDebugServer::utilityContext):
- bindings/v8/V8Proxy.cpp:
- bindings/v8/V8Proxy.h:
- inspector/TimelineRecordFactory.cpp: (WebCore::TimelineRecordFactory::createGenericRecord):
