⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Apr 15, 2010:

11:20 PM Changeset in webkit [57715] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-04-15 Matt Perry <​mpcomplete@chromium.org>

Reviewed by Adam Barth.

Remove the check for the main frame's scheme when deciding which
v8 extensions to add to a script context. Instead, Chromium will
handle that check elsewhere to allow finer-grained control over
what APIs we expose to web pages.
​https://bugs.webkit.org/show_bug.cgi?id=37681

  • bindings/v8/V8DOMWindowShell.cpp: (WebCore::V8DOMWindowShell::createNewContext):
10:59 PM Changeset in webkit [57714] by eric@webkit.org
  • 2 edits
    1 add in trunk/WebCore

2010-04-15 Luiz Agostini <​luiz.agostini@openbossa.org>

Reviewed by Antti Koivisto.

No default selection for <select multiple> menu lists.
​https://bugs.webkit.org/show_bug.cgi?id=37530

Manual test: manual-tests/no-listbox-rendering.html

For menu lists, if the selection is not indicated by the html file, the first <option> will be
selected after loading the page or reseting the form. On the other hand listboxes may have no
element selected after loading the page or reseting the form.

When NO_LISTBOX_RENDERING is enabled listboxes becomes menu lists. Those <select multiple>
that did not have selected elements, now being menu lists, will have the first <option>
selected. That is the behavior difference that this patch corrects.

When NO_LISTBOX_RENDERING is enabled usesMenuList() always returns true then usesMenuList() cannot
be used to decide about initial selection of the elements. This patch replaces (usesMenuLists())
by (!multiple && size <= 1) where initial selection is considered.

  • dom/SelectElement.cpp: (WebCore::SelectElement::recalcListItems): (WebCore::SelectElement::reset):
  • manual-tests/no-listbox-rendering.html: Added.
10:36 PM Changeset in webkit [57713] by tony@chromium.org
  • 2 edits in trunk/LayoutTests

2010-04-15 Tony Chang <​tony@chromium.org>

Not reviewed, trying to make the tree green.

[qt] fast/url/hosts.html is failing, skip until someone can
investigate.
​https://bugs.webkit.org/show_bug.cgi?id=37697

  • platform/qt/Skipped:
7:50 PM Changeset in webkit [57712] by eric@webkit.org
  • 9 edits in trunk/LayoutTests

2010-04-15 Adam Barth <​abarth@webkit.org>

Reviewed by Jeremy Orlow.

Clean up unicode URL tests cases
​https://bugs.webkit.org/show_bug.cgi?id=37678

When we started writing these URL tests, I didn't understand how to
handle the unicodes test cases properly. With a bunch of help (and a
pointer to ​http://rishida.net/tools/conversion/), I've fixed these to
be more or less faithful to the original unit tests.

  • fast/url/anchor-expected.txt:
  • fast/url/query-expected.txt:
  • fast/url/script-tests/anchor.js:
  • fast/url/script-tests/query.js:
  • fast/url/script-tests/standard-url.js:
  • fast/url/script-tests/trivial.js:
    • Updated this test to use the shared implementations
    • Also, removed assumptions about the base URL.
  • fast/url/standard-url-expected.txt:
  • fast/url/trivial-expected.txt:
7:38 PM Changeset in webkit [57711] by eric@webkit.org
  • 1 edit
    3 adds in trunk/LayoutTests

2010-04-15 Adam Barth <​abarth@webkit.org>

Reviewed by Jeremy Orlow.

Add URL parsing tests for host names
​https://bugs.webkit.org/show_bug.cgi?id=37666

  • fast/url/host-expected.txt: Added.
  • fast/url/host.html: Added.
  • fast/url/script-tests/host.js: Added.
7:27 PM Changeset in webkit [57710] by eric@webkit.org
  • 1 edit
    3 adds in trunk/LayoutTests

2010-04-15 Adam Barth <​abarth@webkit.org>

Reviewed by Jeremy Orlow.

Add URL parsing tests for paths
​https://bugs.webkit.org/show_bug.cgi?id=37672

  • fast/url/path-expected.txt: Added.
  • fast/url/path.html: Added.
  • fast/url/script-tests/path.js: Added.
7:01 PM Changeset in webkit [57709] by eric@webkit.org
  • 7 edits in trunk

2010-04-15 Zhenyao Mo <​zmo@google.com>

Reviewed by Dimitri Glazkov.

Index validation code validates too many vertex attributes
​https://bugs.webkit.org/show_bug.cgi?id=31892

  • fast/canvas/webgl/index-validation-expected.txt: Add new test cases for index validations.
  • fast/canvas/webgl/script-tests/index-validation.js: Ditto.

2010-04-15 Zhenyao Mo <​zmo@google.com>

Reviewed by Dimitri Glazkov.

Index validation code validates too many vertex attributes
​https://bugs.webkit.org/show_bug.cgi?id=31892

  • html/canvas/WebGLProgram.cpp: (WebCore::WebGLProgram::cacheActiveAttribLocations): Cache active attribute locations for a program at linkProgram time. (WebCore::WebGLProgram::getActiveAttribLocation): Get the cached attribute location. (WebCore::WebGLProgram::numActiveAttribLocations): Get the number of cached attribute locations.
  • html/canvas/WebGLProgram.h: Add attribute locations member.
  • html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::validateRenderingState): Add logic not to validate those attributes that do not belong to the current program. (WebCore::WebGLRenderingContext::linkProgram): Call cacheActiveAttribLocations().
6:38 PM Changeset in webkit [57708] by jianli@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed.

Mark send-form-data-with-sliced-file.html as failed on Chromium Linux.

  • platform/chromium/test_expectations.txt:
6:34 PM Changeset in webkit [57707] by weinig@apple.com
  • 2 edits in trunk/WebKit2

Use GDI text rendering on Windows by default.

Reviewed by Adam Roben.

  • WebProcess/WebPage/win/WebPageWin.cpp:

(WebKit::WebPage::platformInitialize): Use the AlternateRenderingMode
setting.

6:24 PM Changeset in webkit [57706] by weinig@apple.com
  • 2 edits in trunk/WebKitTools

Use the threaded process model for MiniBrowser if holding down
the shift key on startup.

Reviewed by Adam Roben.

  • MiniBrowser/win/BrowserView.cpp:

(BrowserView::create):

6:20 PM Changeset in webkit [57705] by weinig@apple.com
  • 2 edits in trunk/WebCore

Don't assert when soft-linked libraries can't be found

Patch by Adam Roben <Adam Roben> on 2010-04-16
In some situations (e.g., when using SOFT_LINK_OPTIONAL), we expect soft-link libraries not
to be able to be found in all cases. So we shouldn't assert that they're always found.

Reviewed by Sam Weinig.

  • platform/win/SoftLinking.h:

(SOFT_LINK): Don't assert when LoadLibrary fails.

6:17 PM Changeset in webkit [57704] by dimich@chromium.org
  • 15 edits
    8 deletes in trunk

2010-04-15 Dmitry Titov <​dimich@chromium.org>

Unreviewed, rolling out r57688.
​http://trac.webkit.org/changeset/57688
​https://bugs.webkit.org/show_bug.cgi?id=34992

Makes fast/workers/dedicated-worker-lifecycle.html crashing on all GTK bots

  • fast/workers/change-version-handle-reuse-worker-expected.txt: Removed.
  • fast/workers/change-version-handle-reuse-worker.html: Removed.
  • fast/workers/execute-sql-args-worker-expected.txt: Removed.
  • fast/workers/execute-sql-args-worker.html: Removed.
  • fast/workers/resources/database-worker-controller.js: Removed.
  • fast/workers/resources/database-worker.js: Removed.
  • storage/change-version-handle-reuse-expected.txt:
  • storage/change-version-handle-reuse.html:
  • storage/change-version-handle-reuse.js: Removed.
  • storage/execute-sql-args.html:
  • storage/execute-sql-args.js: Removed.

2010-04-15 Dmitry Titov <​dimich@chromium.org>

Unreviewed, rolling out r57688.
​http://trac.webkit.org/changeset/57688
​https://bugs.webkit.org/show_bug.cgi?id=34992

Makes fast/workers/dedicated-worker-lifecycle.html crashing on all GTK bots

  • bindings/js/JSWorkerContextCustom.cpp:
  • bindings/v8/custom/V8WorkerContextCustom.cpp:
  • storage/Database.idl:
  • storage/SQLError.idl:
  • storage/SQLResultSet.idl:
  • storage/SQLResultSetRowList.idl:
  • storage/SQLTransaction.idl:
  • workers/WorkerContext.cpp: (WebCore::WorkerContext::openDatabase):
  • workers/WorkerContext.h: (WebCore::WorkerContext::databaseExceededQuota):
  • workers/WorkerContext.idl:
6:16 PM Changeset in webkit [57703] by tony@chromium.org
  • 2 edits
    1 add in trunk/WebKitTools

2010-04-15 Tony Chang <​tony@chromium.org>

Reviewed by Dimitri Glazkov.

[chromium] Add TestShellGtk.cpp so we can link on Linux
​https://bugs.webkit.org/show_bug.cgi?id=37561

  • DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp: Add new file and

add platform file exceptions.

  • DumpRenderTree/chromium/TestShellGtk.cpp: Added. (AlarmHandler): (TestShell::waitTestFinished):
6:13 PM Changeset in webkit [57702] by tony@chromium.org
  • 5 edits in trunk

2010-04-15 Tony Chang <​tony@chromium.org>

Reviewed by Dimitri Glazkov.

build DRT on chromium mac
​https://bugs.webkit.org/show_bug.cgi?id=37639

  • gyp_webkit: generate build files for DRT on mac

2010-04-15 Tony Chang <​tony@chromium.org>

Reviewed by Dimitri Glazkov.

build DRT on chromium mac
​https://bugs.webkit.org/show_bug.cgi?id=37639

  • DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
  • Scripts/build-dumprendertree: enable build-dumprendertree --chromium
6:08 PM Changeset in webkit [57701] by yurys@chromium.org
  • 18 edits
    1 add in trunk

2010-04-15 Yury Semikhatsky <​yurys@google.com>

Reviewed by Pavel Feldman.


Support basic debugging capabilities including step in/over/out in v8
implementation of ScriptDebugServer.

​https://bugs.webkit.org/show_bug.cgi?id=37604

  • bindings/js/JSInjectedScriptHostCustom.cpp: (WebCore::InjectedScriptHost::createInjectedScript):
  • bindings/v8/ScriptDebugServer.cpp: (WebCore::ScriptDebugServer::ScriptDebugServer): (WebCore::ScriptDebugServer::setDebuggerScriptSource): (WebCore::ScriptDebugServer::addListener): (WebCore::ScriptDebugServer::removeListener): (WebCore::ScriptDebugServer::setBreakpoint): (WebCore::ScriptDebugServer::removeBreakpoint): (WebCore::ScriptDebugServer::clearBreakpoints): (WebCore::ScriptDebugServer::setBreakpointsActivated): (WebCore::ScriptDebugServer::continueProgram): (WebCore::ScriptDebugServer::stepIntoStatement): (WebCore::ScriptDebugServer::stepOverStatement): (WebCore::ScriptDebugServer::stepOutOfFunction): (WebCore::ScriptDebugServer::currentCallFrameState): (WebCore::ScriptDebugServer::currentCallFrameV8): (WebCore::ScriptDebugServer::onV8DebugMessage): (WebCore::ScriptDebugServer::onV8DebugHostDispatch): (WebCore::ScriptDebugServer::handleV8DebugHostDispatch): (WebCore::ScriptDebugServer::handleV8DebugMessage): (WebCore::ScriptDebugServer::dispatchDidParseSource): (WebCore::ScriptDebugServer::ensureDebuggerScriptCompiled): (WebCore::ScriptDebugServer::didResume):
  • bindings/v8/ScriptDebugServer.h: (WebCore::ScriptDebugServer::pauseOnExceptionsState): (WebCore::ScriptDebugServer::setPauseOnExceptionsState): (WebCore::ScriptDebugServer::setMessageLoopDispatchHandler):
  • bindings/v8/custom/V8InjectedScriptHostCustom.cpp: (WebCore::InjectedScriptHost::createInjectedScript): (WebCore::V8InjectedScriptHost::currentCallFrameCallback): (WebCore::V8InjectedScriptHost::isActivationCallback):
  • inspector/front-end/InjectedScript.js: (injectedScriptConstructor): (injectedScriptConstructor.):
  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel):

2010-04-15 Yury Semikhatsky <​yurys@google.com>

Reviewed by Pavel Feldman.

Support basic debugging capabilities including step in/over/out in v8
implementation of ScriptDebugServer.

​https://bugs.webkit.org/show_bug.cgi?id=37604

  • WebKit.gypi:
  • src/DebuggerAgent.h:
  • src/DebuggerAgentImpl.cpp: (WebKit::DebuggerAgentImpl::setDebuggerScriptSource):
  • src/DebuggerAgentImpl.h:
  • src/DebuggerAgentManager.cpp: (WebKit::DebuggerAgentManager::hostDispatchHandler): (WebKit::DebuggerAgentManager::debugAttach): (WebKit::DebuggerAgentManager::debugDetach): (WebKit::DebuggerAgentManager::setMessageLoopDispatchHandler):
  • src/DebuggerAgentManager.h:
  • src/InspectorFrontendClientImpl.cpp: (WebKit::InspectorFrontendClientImpl::windowObjectCleared):
  • src/js/DebuggerScript.js: Added. (debuggerScriptConstructor.DebuggerScript.getAfterCompileScript): (debuggerScriptConstructor.DebuggerScript.getScripts): (debuggerScriptConstructor.DebuggerScript._formatScript): (debuggerScriptConstructor.DebuggerScript.setBreakpoint): (debuggerScriptConstructor.DebuggerScript.removeBreakpoint): (debuggerScriptConstructor.DebuggerScript.currentCallFrame): (debuggerScriptConstructor.DebuggerScript.stepIntoStatement): (debuggerScriptConstructor.DebuggerScript.stepOverStatement): (debuggerScriptConstructor.DebuggerScript.stepOutOfFunction): (debuggerScriptConstructor.DebuggerScript.clearBreakpoints): (debuggerScriptConstructor.DebuggerScript.setBreakpointsActivated): (debuggerScriptConstructor.DebuggerScript._frameMirrorToJSCallFrame): (debuggerScriptConstructor.DebuggerScript._webkitToV8LineNumber): (debuggerScriptConstructor.DebuggerScript._v8ToWwebkitLineNumber): (debuggerScriptConstructor):
  • src/js/DevTools.js: (WebInspector.loaded): (.): ():
  • src/js/DevToolsHostStub.js: (.RemoteDebuggerAgentStub.prototype.setDebuggerScriptSource):
  • src/js/InspectorControllerImpl.js: (devtools.InspectorBackendImpl):
6:00 PM Changeset in webkit [57700] by mrowe@apple.com
  • 2 edits in tags/Safari-533.5.1/WebKit/mac

Merge r57692.

6:00 PM Changeset in webkit [57699] by eric@webkit.org
  • 7 edits in trunk/WebKit/chromium

2010-04-15 Matt Perry <​mpcomplete@chromium.org>

Reviewed by Dimitri Glazkov.

Implement layoutTestController's addUserStyleSheet and
setAuthorAndUserStylesEnabled on Chromium port.
​https://bugs.webkit.org/show_bug.cgi?id=37595

  • public/WebSettings.h:
  • public/WebView.h:
  • src/WebSettingsImpl.cpp: (WebKit::WebSettingsImpl::setAuthorAndUserStylesEnabled):
  • src/WebSettingsImpl.h:
  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::addUserStyleSheet):
  • src/WebViewImpl.h:
5:58 PM Changeset in webkit [57698] by mrowe@apple.com
  • 5 edits in tags/Safari-533.5.1

Versioning.

5:58 PM Changeset in webkit [57697] by jianli@chromium.org
  • 4 edits in trunk/LayoutTests

Unreviewed.

Updated Skipped list to use the right directory due to directory
shuffling at r57695.

  • platform/gtk/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:
5:54 PM Changeset in webkit [57696] by ajwong@chromium.org
  • 5 edits in trunk/LayoutTests

Not reviewed. Sheriffing.

[Chromium] Build fix. Rebaseline these again since the fonts changed again.

  • platform/chromium-win/fast/backgrounds/svg-as-background-1-expected.checksum:
  • platform/chromium-win/fast/backgrounds/svg-as-background-1-expected.png:
  • platform/chromium-win/fast/backgrounds/svg-as-background-3-expected.checksum:
  • platform/chromium-win/fast/backgrounds/svg-as-background-3-expected.png:
5:50 PM Changeset in webkit [57695] by jianli@chromium.org
  • 12 edits
    2 moves
    9 adds
    1 delete in trunk

Support using FormData to send a sliced file via XHR.
​https://bugs.webkit.org/show_bug.cgi?id=36678

Reviewed by Dmitry Titov.

WebCore:

Tests: http/tests/local/formdata/send-form-data-with-sliced-file.html

  • html/Blob.h:

(WebCore::Blob::isFile):

  • html/DOMFormData.cpp:

(WebCore::DOMFormData::append):

  • html/File.h:

(WebCore::File::isFile):

  • html/FormDataList.h:

(WebCore::FormDataList::appendBlob):
(WebCore::FormDataList::Item::Item):
(WebCore::FormDataList::Item::blob):

  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::appendFormData):

  • platform/network/FormData.cpp:

(WebCore::FormData::appendDOMFormData):

  • platform/network/mac/FormDataStreamMac.mm:

(WebCore::closeCurrentStream):

LayoutTests:

Move common functionality to test sending FormData into a helper file
so that it can be shared by FormData layout tests.
Also move the form data testing files to a new subdirectory formdata/.

  • http/tests/local/formdata/resources/send-form-data-common.js: Added.
  • http/tests/local/formdata/script-tests/TEMPLATE.html: Added.
  • http/tests/local/formdata/script-tests/send-form-data-with-sliced-file.js: Added.
  • http/tests/local/formdata/script-tests/send-form-data.js: Added.
  • http/tests/local/formdata/send-form-data-expected.txt: Renamed from LayoutTests/http/tests/local/send-form-data-expected.txt.
  • http/tests/local/formdata/send-form-data-with-sliced-file-expected.txt: Added.
  • http/tests/local/formdata/send-form-data-with-sliced-file.html: Added.
  • http/tests/local/formdata/send-form-data.html: Added.
  • http/tests/local/resources/send-form-data.js: Removed.
  • http/tests/local/send-form-data.html: Removed.
  • platform/gtk/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:
5:43 PM Changeset in webkit [57694] by eric@webkit.org
  • 5 edits
    2 adds in trunk

2010-04-15 Zhenyao Mo <​zmo@google.com>

Reviewed by Dimitri Glazkov.

Must enable GL_VERTEX_PROGRAM_POINT_SIZE during initialization
​https://bugs.webkit.org/show_bug.cgi?id=37178

  • fast/canvas/webgl/point-size-expected.txt: Added.
  • fast/canvas/webgl/point-size.html: Added.

2010-04-15 Zhenyao Mo <​zmo@google.com>

Reviewed by Dimitri Glazkov.

Must enable GL_VERTEX_PROGRAM_POINT_SIZE during initialization
​https://bugs.webkit.org/show_bug.cgi?id=37178

Test: fast/canvas/webgl/point-size.html

  • platform/graphics/mac/GraphicsContext3DMac.cpp: Enable GL_VERTEX_PROGRAM_POINT_SIZE during initialization. (WebCore::GraphicsContext3D::GraphicsContext3D):

2010-04-15 Zhenyao Mo <​zmo@google.com>

Reviewed by Dimitri Glazkov.

Must enable GL_VERTEX_PROGRAM_POINT_SIZE during initialization
​https://bugs.webkit.org/show_bug.cgi?id=37178

  • src/WebGraphicsContext3DDefaultImpl.cpp: Enable GL_VERTEX_PROGRAM_POINT_SIZE during initialization. (WebKit::WebGraphicsContext3DDefaultImpl::initialize):
5:42 PM Changeset in webkit [57693] by mrowe@apple.com
  • 1 copy in tags/Safari-533.5.1

New tag.

5:40 PM Changeset in webkit [57692] by mrowe@apple.com
  • 2 edits in trunk/WebKit/mac

<rdar://problem/7870651> WebDynamicScrollBarsView.h generates compile errors when included in plain Objective-C files.

Reviewed by Sam Weinig.

  • WebView/WebDynamicScrollBarsView.h:
5:36 PM Changeset in webkit [57691] by weinig@apple.com
  • 2 edits in trunk/WebKit2

Fix crash when trying to load an invalid URL.

Reviewed by Adam Roben.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::loadURL): Use constructor for ResourceRequest
that takes a KURL instead of the one that takes a String. The one
that takes a string expects a valid URL.

5:31 PM Changeset in webkit [57690] by eric@webkit.org
  • 2 edits
    1 add in trunk/WebKitTools

2010-04-15 Kent Tamura <​tkent@chromium.org>

Reviewed by Dimitri Glazkov.

[DRT/Chromium] Add LayoutTestHelper for Mac
​https://bugs.webkit.org/show_bug.cgi?id=37668

LayouTestHelper.mm is based on webkit/tools/test_shell/mac/layout_test_helper.mm
of Chromium.

  • DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
  • DumpRenderTree/chromium/LayoutTestHelper.mm: Added.
5:22 PM Changeset in webkit [57689] by weinig@apple.com
  • 2 edits in trunk/WebKit2

Make tooltips work. Thanks Adam!

Reviewed by Adam Roben.

  • UIProcess/win/WebView.cpp:

(WebKit::WebView::toolTipChanged): Pass the WebView's HWND, not the tooltip's.

5:10 PM Changeset in webkit [57688] by eric@webkit.org
  • 15 edits
    3 copies
    5 adds in trunk

2010-04-15 Eric Uhrhane <​ericu@chromium.org>

Reviewed by Dmitry Titov.

Add bindings for async DB API in Workers.
​https://bugs.webkit.org/show_bug.cgi?id=34992

  • storage/change-version-handle-reuse.html: Refactored to share code with the worker version of the test.
  • storage/change-version-handle-reuse-expected.html: Removed reference to reloading, which this test doesn't do.
  • storage/change-version-handle-reuse.js: This is the extracted shared core of the test.
  • storage/execute-sql-args.html: Refactored to share code with the worker version of the test.
  • storage/execute-sql-args.js: This is the extracted shared core of the test.

These are the worker versions of the tests; they're tiny shims around shared code.

  • fast/workers/execute-sql-args-worker-expected.txt: Added.
  • fast/workers/execute-sql-args-worker.html: Added.
  • fast/workers/change-version-handle-reuse-worker-expected.txt: Added.
  • fast/workers/change-version-handle-reuse-worker.html: Added. This file gets included from worker database tests; it does all the boilerplate that's needed on the DOM side.
  • fast/workers/resources/database-worker-controller.js: Added. This file is the boilerplate for the worker side of the database tests. It will import and run the actual test on command, and will report back completion and exceptions.
  • fast/workers/resources/database-worker.js: Added.

2010-04-15 Eric Uhrhane <​ericu@chromium.org>

Reviewed by Dmitry Titov.

Add bindings for async DB API in Workers.
​https://bugs.webkit.org/show_bug.cgi?id=34992

Tests: storage/change-version-handle-reuse-worker.html

storage/execute-sql-args-worker.html

  • bindings/js/JSWorkerContextCustom.cpp: Add openDatabase binding. (WebCore::JSWorkerContext::openDatabase):
  • bindings/v8/custom/V8WorkerContextCustom.cpp: Add openDatabase stub; Chromium will need work both in V8 and in the browser process before we can turn this on there. (WebCore::V8WorkerContext::openDatabaseCallback):

Add NoStaticTables flags to all objects now shared with workers.

  • storage/Database.idl:
  • storage/SQLError.idl:
  • storage/SQLResultSet.idl:
  • storage/SQLResultSetRowList.idl:
  • storage/SQLTransaction.idl:
  • workers/WorkerContext.h: Add databaseExceededQuota.
  • workers/WorkerContext.cpp: (WebCore::WorkerContext::databaseExceededQuota): Add stub implementation for testing; you just get 5MB for now. (WebCore::WorkerContext::openDatabase): Remove invalid assertion.

Add the IDL for the call to openDatabase.

  • workers/WorkerContext.idl:
4:58 PM Changeset in webkit [57687] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-04-15 Nicolas Weber <​thakis@chromium.org>

Reviewed by Dimitri Glazkov.

Fix drag image thumbnails for indexed images.
​https://bugs.webkit.org/show_bug.cgi?id=37621

  • platform/chromium/DragImageChromiumMac.cpp: (WebCore::scaleDragImage): Always use RGB color space. (WebCore::dissolveDragImageToFraction): Always use RGB color space.
4:56 PM Changeset in webkit [57686] by andersca@apple.com
  • 2 edits in trunk/WebKit2

Fix build dependencies.

Reviewed by Adam Roben.

  • WebKit2.sln:
4:52 PM Changeset in webkit [57685] by ap@apple.com
  • 5 edits
    1 delete in trunk

Reviewed by Geoff Garen.

​https://bugs.webkit.org/show_bug.cgi?id=37494
<rdar://problem/7857060> REGRESSION (r57340): fast/events/mouse-drag-from-frame-to-other-frame.html
fails on Windows

  • DumpRenderTree/win/EventSender.cpp: (makeEventSender):
  • DumpRenderTree/win/EventSender.h: Tell EventSender if it's being created for a top frame.


  • DumpRenderTree/win/FrameLoadDelegate.cpp: (FrameLoadDelegate::didClearWindowObjectForFrameInStandardWorld): We only want to reset EventSender machinery when a new test is loaded, not when an iframe (or just its global object) is created.
4:51 PM Changeset in webkit [57684] by weinig@apple.com
  • 5 edits in trunk

Fix Windows WebKit2 build.

WebKit2:

Patch by Adam Roben <Adam Roben> on 2010-04-15

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::processDidExit):

  • win/WebKit2Generated.make:

WebKitTools:

Patch by Adam Roben <Adam Roben> on 2010-04-15

  • MiniBrowser/win/MiniBrowser.cpp:
4:37 PM WebKit Team edited by Joseph Pecoraro
Italics look like quotes in WikiFormatting. But its Magic Quotes. (diff)
4:34 PM WebKit Team edited by Joseph Pecoraro
Moving up in the world ;) (diff)
3:53 PM Changeset in webkit [57683] by Adam Roben
  • 2 edits in trunk/WebKit/mac

Export WebUserContentURLPattern from WebKit

Rubber-stamped by Mark Rowe.

  • WebKit.exp:
3:33 PM Changeset in webkit [57682] by mitz@apple.com
  • 2 edits in trunk/WebKit/mac

Made consecutive calls to -[WebHTMLView _beginPrintModeWithPageWidth:shrinkToFit:] work
without intermediate calls -[WebHTMLView _endPrintMode].

Reviewed by Simon Fraser.

  • WebView/WebHTMLView.mm:

(-[WebHTMLView _setPrinting:minimumPageWidth:maximumPageWidth:adjustViewSize:]):

3:30 PM Changeset in webkit [57681] by Chris Fleizach
  • 3 edits in trunk/LayoutTests

Unreviewed.

Layout test fix for new test that works differently on leopard v. snow leopard.

AXHelp is being appended from ancestors incorrectly
​https://bugs.webkit.org/show_bug.cgi?id=37659

  • platform/mac/accessibility/unexpected-help-text-expected.txt:
  • platform/mac/accessibility/unexpected-help-text.html:
3:19 PM Changeset in webkit [57680] by Adam Roben
  • 11 edits
    5 adds in trunk

Expose UserContentURLPattern as WebKit SPI

Fixes <​http://webkit.org/b/37354>.

Reviewed by Tim Hatcher.

WebCore:

  • WebCore.base.exp: Export UserContentURLPattern::parse, and sorted

the file.

  • WebCore.xcodeproj/project.pbxproj: Marked UserContentURLPattern.h as

"Private".

  • page/UserContentURLPattern.h:

(WebCore::UserContentURLPattern::UserContentURLPattern): Added a
default constructor.
(WebCore::UserContentURLPattern::isValid): Added this getter.

WebKit:

  • WebKit.xcodeproj/project.pbxproj: Add WebUserContentURLPattern.

WebKit/mac:

  • Misc/WebUserContentURLPattern.h: Added.
  • Misc/WebUserContentURLPattern.mm: Added.

(-[WebUserContentURLPattern initWithPatternString:]): Initialize
_private and then parse the passed-in string into a
UserContentURLPattern.
(-[WebUserContentURLPattern dealloc]): Release _private.

(-[WebUserContentURLPattern isValid]):
(-[WebUserContentURLPattern scheme]):
(-[WebUserContentURLPattern host]):
(-[WebUserContentURLPattern matchesSubdomains]):
Call through to UserContentURLPattern.

WebKit/win:

  • Interfaces/IWebUserContentURLPattern.idl: Added.
  • Interfaces/WebKit.idl: Added WebUserContentURLPattern.
  • WebKit.vcproj/Interfaces.vcproj: Added IWebUserContentURLPattern.
  • WebKit.vcproj/WebKit.vcproj: Added WebUserContentURLPattern.
  • WebUserContentURLPattern.cpp: Added.

(WebUserContentURLPattern::WebUserContentURLPattern):
(WebUserContentURLPattern::~WebUserContentURLPattern):
(WebUserContentURLPattern::createInstance):
(WebUserContentURLPattern::AddRef):
(WebUserContentURLPattern::Release):
(WebUserContentURLPattern::QueryInterface):
Standard COM implementations.

(WebUserContentURLPattern::parse): Parse the string into a
UserContentURLPattern and store it.

(WebUserContentURLPattern::isValid):
(WebUserContentURLPattern::scheme):
(WebUserContentURLPattern::host):
(WebUserContentURLPattern::matchesSubdomains):
Call through to UserContentURLPattern.

  • WebUserContentURLPattern.h: Added.
3:18 PM Changeset in webkit [57679] by ojan@chromium.org
  • 3 edits in trunk/WebKitTools

2010-04-15 Ojan Vafai <​ojan@chromium.org>

Reviewed by Adam Barth.

Include codereview issue number in patch description
​https://bugs.webkit.org/show_bug.cgi?id=37677

This lets us know which rietveld issue this patch is tied to.

Also, make it so that --fancy-review overrides --no-review.

  • Scripts/webkitpy/tool/steps/postcodereview.py:
  • Scripts/webkitpy/tool/steps/postdiff.py:
3:11 PM Changeset in webkit [57678] by Adam Roben
  • 2 edits in trunk/WebKitTools

Make --exit-after-n-failures work when all tests are timing out or crashing

Fixes <​http://webkit.org/b/37679>.

Reviewed by Jon Honeycutt.

  • Scripts/run-webkit-tests:

(top level): When a test crashes or times out, break out of the main loop if
stopRunningTestsEarlyIfNeeded returns true. Moved some code from the bottom of the main loop
from here...
(stopRunningTestsEarlyIfNeeded): ...to here.

2:50 PM Changeset in webkit [57677] by ajwong@chromium.org
  • 6 edits in trunk/LayoutTests

Not reviewed, sheriffing.

[Chromium] Update chromium layout tests expecataions with new baselines. Remove expectations for some tests that seem to be passing now.

  • platform/chromium-win/fast/backgrounds/svg-as-background-1-expected.checksum:
  • platform/chromium-win/fast/backgrounds/svg-as-background-1-expected.png:
  • platform/chromium-win/fast/backgrounds/svg-as-background-3-expected.checksum:
  • platform/chromium-win/fast/backgrounds/svg-as-background-3-expected.png:
  • platform/chromium/test_expectations.txt:
2:23 PM Changeset in webkit [57676] by weinig@apple.com
  • 14 edits
    2 copies
    5 adds in trunk

Add WebHistoryClient support.
​https://bugs.webkit.org/show_bug.cgi?id=37671

Reviewed by Anders Carlsson.

WebKit2:

Adds the following callbacks:

didNavigateWithNavigationData
didPerformClientRedirect
didPerformServerRedirect
didUpdateHistoryTitle

  • Shared/CoreIPCSupport/WebPageProxyMessageKinds.h:

(WebPageProxyMessage::):

  • Shared/WebNavigationDataStore.h: Added.
  • UIProcess/API/C/WKAPICast.h:
  • UIProcess/API/C/WKBase.h:
  • UIProcess/API/C/WKNavigationData.cpp: Added.
  • UIProcess/API/C/WKNavigationData.h: Added.
  • UIProcess/API/C/WKPage.cpp:
  • UIProcess/API/C/WKPage.h:
  • UIProcess/API/C/WebKit2.h:
  • UIProcess/WebHistoryClient.cpp: Copied from UIProcess/WebUIClient.cpp.
  • UIProcess/WebHistoryClient.h: Copied from UIProcess/WebUIClient.h.
  • UIProcess/WebNavigationData.cpp: Added.
  • UIProcess/WebNavigationData.h: Added.
  • UIProcess/WebPageProxy.cpp:
  • UIProcess/WebPageProxy.h:
  • WebKit2.xcodeproj/project.pbxproj:
  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
  • win/WebKit2.vcproj:

WebKitTools:

Add HistoryClient logging.

  • MiniBrowser/mac/BrowserWindowController.m:

(_didNavigateWithNavigationData):
(_didPerformClientRedirect):
(_didPerformServerRedirect):
(_didUpdateHistoryTitle):
(-[BrowserWindowController awakeFromNib]):

2:15 PM Changeset in webkit [57675] by andersca@apple.com
  • 2 edits in trunk/WebKitTools

2010-04-15 Anders Carlsson <​andersca@apple.com>

Reviewed by Sam Weinig.

Start the mini browser in threaded mode if shift is pressed during startup.
​https://bugs.webkit.org/show_bug.cgi?id=37670

  • MiniBrowser/mac/AppDelegate.m: (-[BrowserAppDelegate init]):
2:05 PM Changeset in webkit [57674] by Chris Fleizach
  • 11 edits
    2 adds in trunk

AXHelp is being appended from ancestors incorrectly
​https://bugs.webkit.org/show_bug.cgi?id=37659

Reviewed by Beth Dakin.

WebCore:

Test: platform/mac/accessibility/unexpected-help-text.html

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::helpText):

WebKitTools:

  • DumpRenderTree/AccessibilityUIElement.cpp:

(getHelpTextCallback):
(AccessibilityUIElement::getJSClass):

  • DumpRenderTree/AccessibilityUIElement.h:
  • DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:

(AccessibilityUIElement::helpText):

  • DumpRenderTree/mac/AccessibilityUIElementMac.mm:

(AccessibilityUIElement::helpText):

  • DumpRenderTree/win/AccessibilityUIElementWin.cpp:

(AccessibilityUIElement::helpText):

LayoutTests:

  • platform/mac/accessibility/table-attributes-expected.txt:
  • platform/mac/accessibility/table-sections-expected.txt:

Update tests because they were wrong. AXCells should not have their AXHelp come from the AXTable.

  • platform/mac/accessibility/unexpected-help-text-expected.txt: Added.
  • platform/mac/accessibility/unexpected-help-text.html: Added.
2:01 PM Changeset in webkit [57673] by dpranke@chromium.org
  • 2 edits in trunk/WebKitTools

2010-04-15 Dirk Pranke <​dpranke@chromium.org>

Reviewed by Adam Barth.

Re-format run-webkit-tests to fit in 80-columns for PEP-8 compliance.
(broken by r57463 and r57381, at least). I've also filed bug 37477
to fix check-webkit-style to catch these things.

​https://bugs.webkit.org/show_bug.cgi?id=38586

  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2:01 PM Changeset in webkit [57672] by dpranke@chromium.org
  • 5 edits in trunk/WebKitTools

2010-04-15 Dirk Pranke <​dpranke@chromium.org>

Reviewed by Dimitri Glazkov.

Add a way to override the user-visible name for the test binary since
some ports don't call it DumpRenderTree (e.g., Chromium Win uses
test_shell, Chromium Mac uses TestShell) by adding a driver_name()
method to the Port interface.

​https://bugs.webkit.org/show_bug.cgi?id=37631

  • Scripts/webkitpy/layout_tests/port/base.py:
  • Scripts/webkitpy/layout_tests/port/chromium.py:
  • Scripts/webkitpy/layout_tests/port/chromium_mac.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1:55 PM Changeset in webkit [57671] by hyatt@apple.com
  • 5 edits in trunk/WebCore

​https://bugs.webkit.org/show_bug.cgi?id=37669, REGRESSION: visited styles don't work right when only the visited path specifies
a pseudoelement.

Reviewed by Anders Carlsson.

Rework the pseudo cache on RenderStyles to support nesting, i.e., a pseudo hanging off a pseudo. The existing model gets
confused by this concept, since it relies on a singly linked list of chained pseudo styles (instead of a Vector owned by a primary
style). I changed the style cache to be a Vector instead.

Reworked both styleForElement and pseudoStyleForElement to resolve visited styles first, since in the pseudoStyleForElement case
you need to do this in order to know to allocate an unvisited pseudo style even if one shouldn't normally exist.

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::styleForElement):
(WebCore::CSSStyleSelector::pseudoStyleForElement):

  • dom/Element.cpp:

(WebCore::Element::pseudoStyleCacheIsInvalid):

  • rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::getCachedPseudoStyle):
(WebCore::RenderStyle::addCachedPseudoStyle):

  • rendering/style/RenderStyle.h:

(WebCore::):
(WebCore::InheritedFlags::cachedPseudoStyles):

1:45 PM Changeset in webkit [57670] by ajwong@chromium.org
  • 18 edits
    1 delete in trunk

2010-04-15 Albert J. Wong <​ajwong@chromium.org>

Unreviewed, rolling out r57660.
​http://trac.webkit.org/changeset/57660
​https://bugs.webkit.org/show_bug.cgi?id=37604

Broke a large number of inspector layout tests in chromium.

  • bindings/js/JSInjectedScriptHostCustom.cpp: (WebCore::InjectedScriptHost::createInjectedScript):
  • bindings/v8/ScriptDebugServer.cpp:
  • bindings/v8/ScriptDebugServer.h: (WebCore::ScriptDebugServer::addListener): (WebCore::ScriptDebugServer::removeListener): (WebCore::ScriptDebugServer::setBreakpoint): (WebCore::ScriptDebugServer::removeBreakpoint): (WebCore::ScriptDebugServer::clearBreakpoints): (WebCore::ScriptDebugServer::setBreakpointsActivated): (WebCore::ScriptDebugServer::pauseOnExceptionsState): (WebCore::ScriptDebugServer::setPauseOnExceptionsState): (WebCore::ScriptDebugServer::continueProgram): (WebCore::ScriptDebugServer::stepIntoStatement): (WebCore::ScriptDebugServer::stepOverStatement): (WebCore::ScriptDebugServer::stepOutOfFunction): (WebCore::ScriptDebugServer::currentCallFrameState): (WebCore::ScriptDebugServer::ScriptDebugServer):
  • bindings/v8/custom/V8InjectedScriptHostCustom.cpp: (WebCore::InjectedScriptHost::createInjectedScript): (WebCore::V8InjectedScriptHost::currentCallFrameCallback): (WebCore::V8InjectedScriptHost::isActivationCallback):
  • inspector/front-end/InjectedScript.js: (injectedScriptConstructor):
  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel):

2010-04-15 Albert J. Wong <​ajwong@chromium.org>

Unreviewed, rolling out r57660.
​http://trac.webkit.org/changeset/57660
​https://bugs.webkit.org/show_bug.cgi?id=37604

Broke a large number of inspector layout tests in chromium.

  • WebKit.gypi:
  • src/DebuggerAgent.h:
  • src/DebuggerAgentImpl.cpp:
  • src/DebuggerAgentImpl.h:
  • src/DebuggerAgentManager.cpp: (WebKit::DebuggerAgentManager::debugAttach): (WebKit::DebuggerAgentManager::debugDetach): (WebKit::DebuggerAgentManager::setMessageLoopDispatchHandler):
  • src/DebuggerAgentManager.h:
  • src/InspectorFrontendClientImpl.cpp: (WebKit::InspectorFrontendClientImpl::windowObjectCleared):
  • src/js/DebuggerScript.js: Removed.
  • src/js/DevTools.js: (WebInspector.loaded): (WebInspector.UnresolvedPropertyValue): ():
  • src/js/DevToolsHostStub.js:
  • src/js/InspectorControllerImpl.js: (devtools.InspectorBackendImpl):
1:44 PM Changeset in webkit [57669] by eric@webkit.org
  • 2 edits in trunk/WebKit/qt

2010-04-15 Kent Hansen <​kent.hansen@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Mark QWebFrame::overloadedSlots autotest as expected failure

​https://bugs.webkit.org/show_bug.cgi?id=37319

  • tests/qwebframe/tst_qwebframe.cpp:
1:40 PM Changeset in webkit [57668] by dumi@chromium.org
  • 4 edits in trunk/WebCore

DatabaseTracker refactoring: remove the dependency on
OriginQuotaManager from DatabaseTracker.h
​https://bugs.webkit.org/show_bug.cgi?id=31482

Reviewed by Dimitri Glazkov.

  • storage/DatabaseTracker.cpp:

(WebCore::DatabaseTracker::DatabaseTracker):
(WebCore::DatabaseTracker::~DatabaseTracker):
(WebCore::DatabaseTracker::canEstablishDatabase):
(WebCore::DatabaseTracker::hasEntryForOrigin):
(WebCore::DatabaseTracker::getMaxSizeForDatabase):
(WebCore::DatabaseTracker::databaseChanged):
(WebCore::DatabaseTracker::fullPathForDatabaseNoLock):
(WebCore::DatabaseTracker::fullPathForDatabase):
(WebCore::DatabaseTracker::populateOrigins):
(WebCore::DatabaseTracker::origins):
(WebCore::DatabaseTracker::databaseNamesForOrigin):
(WebCore::DatabaseTracker::addOpenDatabase):
(WebCore::DatabaseTracker::removeOpenDatabase):
(WebCore::DatabaseTracker::usageForOriginNoLock):
(WebCore::DatabaseTracker::usageForOrigin):
(WebCore::DatabaseTracker::quotaForOrigin):
(WebCore::DatabaseTracker::setQuota):
(WebCore::DatabaseTracker::deleteOrigin):
(WebCore::DatabaseTracker::deleteDatabase):
(WebCore::DatabaseTracker::deleteDatabaseFile):

  • storage/DatabaseTracker.h:
  • storage/SQLTransactionClient.cpp:

(WebCore::SQLTransactionClient::didExecuteStatement):

1:36 PM Changeset in webkit [57667] by weinig@apple.com
  • 2 edits in trunk/WebKit2

Remove empty file configurations.

Reviewed by Adam Roben.

  • win/WebKit2.vcproj:
1:28 PM Changeset in webkit [57666] by eric@webkit.org
  • 2 edits in trunk/LayoutTests

2010-04-15 Anton Muhin <​antonm@chromium.org>

Reviewed by David Levin.

[v8] mark Array.prototype.sort tests which verify if sorting is stable as passing for Chromium
​https://bugs.webkit.org/show_bug.cgi?id=37655

  • platform/chromium/test_expectations.txt:
1:18 PM Changeset in webkit [57665] by eric@webkit.org
  • 1 edit
    2 adds in trunk/WebKit

2010-04-15 Leandro Pereira <​leandro@profusion.mobi>

Reviewed by Kenneth Rohde Christiansen.

Add EFL port files to efl/WebCoreSupport.
​http://webkit.org/b/35918

  • efl/WebCoreSupport/EditorClientEfl.cpp: Added.
  • efl/WebCoreSupport/EditorClientEfl.h: Added.
1:07 PM Changeset in webkit [57664] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-04-15 Zhenyao Mo <​zmo@google.com>

Reviewed by Adam Barth.

Several tests in fast/canvas/webgl/ failed randomly on Leopard Commit Bot
This fixes an uninitialized variable bug and restores a glFinish call that used to be present.
​https://bugs.webkit.org/show_bug.cgi?id=36908

  • platform/graphics/mac/GraphicsContext3DMac.cpp: (WebCore::GraphicsContext3D::GraphicsContext3D): Initialize width/height to 0/0. (WebCore::GraphicsContext3D::prepareTexture): Restore glFinish() in every path.
12:33 PM Changeset in webkit [57663] by tonikitoo@webkit.org
  • 2 edits in trunk/WebCore

Spatial Navigation: make hasOffscreenRect() to earlier return 'true' if absoluteClippedOverflowRect() gives an empty rect
​https://bugs.webkit.org/show_bug.cgi?id=37635

Reviewed by Simon Fraser.
Patch by Antonio Gomes <​tonikitoo@webkit.org>

absoluteClippedOverflowRect method of RenderObject does return an empty IntRect for offscreen nodes.
So hasOffscreenRect method (SpatialNavigation.cpp) can safily bail out earlier in such cases.

  • page/SpatialNavigation.cpp:

(WebCore::hasOffscreenRect):

12:26 PM Changeset in webkit [57662] by tonikitoo@webkit.org
  • 2 edits in trunk/WebCore

Spatial Navigation: remove unnecessery assignment in updateFocusCandidateIfCloser method ​https://bugs.webkit.org/show_bug.cgi?id=37634

Reviewed by Simon Fraser.
Patch by Antonio Gomes <​tonikitoo@webkit.org>

This assignment line is not longer needed after r57061, bug that refactored all
assignment logic to happen lines below in the method.

  • page/FocusController.cpp:

(WebCore::updateFocusCandidateIfCloser):

11:47 AM Changeset in webkit [57661] by weinig@apple.com
  • 3 edits in trunk/WebKit2

Fix WebKit2s build. Don't return temporaries.

Reviewed by Anders Carlsson.

  • UIProcess/API/C/cf/WKStringCF.cpp:

(WKStringCreateWithCFString):

  • UIProcess/API/C/cf/WKURLCF.cpp:

(WKURLCreateWithCFURL):
(WKURLCopyCFURL):

11:40 AM Changeset in webkit [57660] by yurys@chromium.org
  • 18 edits
    1 add in trunk

2010-04-15 Yury Semikhatsky <​yurys@google.com>

Reviewed by Pavel Feldman.


Support basic debugging capabilities including step in/over/out in v8
implementation of ScriptDebugServer.

​https://bugs.webkit.org/show_bug.cgi?id=37604

  • bindings/js/JSInjectedScriptHostCustom.cpp: (WebCore::InjectedScriptHost::createInjectedScript):
  • bindings/v8/ScriptDebugServer.cpp: (WebCore::ScriptDebugServer::ScriptDebugServer): (WebCore::ScriptDebugServer::setDebuggerScriptSource): (WebCore::ScriptDebugServer::addListener): (WebCore::ScriptDebugServer::removeListener): (WebCore::ScriptDebugServer::setBreakpoint): (WebCore::ScriptDebugServer::removeBreakpoint): (WebCore::ScriptDebugServer::clearBreakpoints): (WebCore::ScriptDebugServer::setBreakpointsActivated): (WebCore::ScriptDebugServer::continueProgram): (WebCore::ScriptDebugServer::stepIntoStatement): (WebCore::ScriptDebugServer::stepOverStatement): (WebCore::ScriptDebugServer::stepOutOfFunction): (WebCore::ScriptDebugServer::currentCallFrameState): (WebCore::ScriptDebugServer::currentCallFrameV8): (WebCore::ScriptDebugServer::onV8DebugMessage): (WebCore::ScriptDebugServer::onV8DebugHostDispatch): (WebCore::ScriptDebugServer::handleV8DebugHostDispatch): (WebCore::ScriptDebugServer::handleV8DebugMessage): (WebCore::ScriptDebugServer::dispatchDidParseSource): (WebCore::ScriptDebugServer::ensureDebuggerScriptCompiled): (WebCore::ScriptDebugServer::didResume):
  • bindings/v8/ScriptDebugServer.h: (WebCore::ScriptDebugServer::pauseOnExceptionsState): (WebCore::ScriptDebugServer::setPauseOnExceptionsState): (WebCore::ScriptDebugServer::setMessageLoopDispatchHandler):
  • bindings/v8/custom/V8InjectedScriptHostCustom.cpp: (WebCore::InjectedScriptHost::createInjectedScript): (WebCore::V8InjectedScriptHost::currentCallFrameCallback): (WebCore::V8InjectedScriptHost::isActivationCallback):
  • inspector/front-end/InjectedScript.js: (injectedScriptConstructor): (injectedScriptConstructor.):
  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel):

2010-04-15 Yury Semikhatsky <​yurys@google.com>

Reviewed by Pavel Feldman.

Support basic debugging capabilities including step in/over/out in v8
implementation of ScriptDebugServer.

​https://bugs.webkit.org/show_bug.cgi?id=37604

  • WebKit.gypi:
  • src/DebuggerAgent.h:
  • src/DebuggerAgentImpl.cpp: (WebKit::DebuggerAgentImpl::setDebuggerScriptSource):
  • src/DebuggerAgentImpl.h:
  • src/DebuggerAgentManager.cpp: (WebKit::DebuggerAgentManager::hostDispatchHandler): (WebKit::DebuggerAgentManager::debugAttach): (WebKit::DebuggerAgentManager::debugDetach): (WebKit::DebuggerAgentManager::setMessageLoopDispatchHandler):
  • src/DebuggerAgentManager.h:
  • src/InspectorFrontendClientImpl.cpp: (WebKit::InspectorFrontendClientImpl::windowObjectCleared):
  • src/js/DebuggerScript.js: Added. (debuggerScriptConstructor.DebuggerScript.getAfterCompileScript): (debuggerScriptConstructor.DebuggerScript.getScripts): (debuggerScriptConstructor.DebuggerScript._formatScript): (debuggerScriptConstructor.DebuggerScript.setBreakpoint): (debuggerScriptConstructor.DebuggerScript.removeBreakpoint): (debuggerScriptConstructor.DebuggerScript.currentCallFrame): (debuggerScriptConstructor.DebuggerScript.stepIntoStatement): (debuggerScriptConstructor.DebuggerScript.stepOverStatement): (debuggerScriptConstructor.DebuggerScript.stepOutOfFunction): (debuggerScriptConstructor.DebuggerScript.clearBreakpoints): (debuggerScriptConstructor.DebuggerScript.setBreakpointsActivated): (debuggerScriptConstructor.DebuggerScript._frameMirrorToJSCallFrame): (debuggerScriptConstructor.DebuggerScript._webkitToV8LineNumber): (debuggerScriptConstructor.DebuggerScript._v8ToWwebkitLineNumber): (debuggerScriptConstructor):
  • src/js/DevTools.js: (WebInspector.loaded): (.): ():
  • src/js/DevToolsHostStub.js: (.RemoteDebuggerAgentStub.prototype.setDebuggerScriptSource):
  • src/js/InspectorControllerImpl.js: (devtools.InspectorBackendImpl):
11:32 AM Changeset in webkit [57659] by Nikolas Zimmermann
  • 6 edits
    4 adds in trunk

2010-04-15 Nikolas Zimmermann <​nzimmermann@rim.com>

Reviewed by Beth Dakin.

RenderSVGResource <-> id mapping should be cached
​https://bugs.webkit.org/show_bug.cgi?id=37575

Test: svg/custom/clip-path-id-changes.svg

  • rendering/RenderSVGResource.h: (WebCore::RenderSVGResource::RenderSVGResource): (WebCore::RenderSVGResource::~RenderSVGResource): (WebCore::RenderSVGResource::idChanged): (WebCore::getRenderSVGResourceById):
  • svg/SVGDocumentExtensions.cpp: (WebCore::SVGDocumentExtensions::addResource): (WebCore::SVGDocumentExtensions::removeResource): (WebCore::SVGDocumentExtensions::resourceById):
  • svg/SVGDocumentExtensions.h:
  • svg/SVGStyledElement.cpp: (WebCore::SVGStyledElement::svgAttributeChanged):

2010-04-15 Nikolas Zimmermann <​nzimmermann@rim.com>

Reviewed by Beth Dakin.

RenderSVGResource <-> id mapping should be cached
​https://bugs.webkit.org/show_bug.cgi?id=37575

  • platform/mac/svg/custom/clip-path-id-changes-expected.checksum: Added.
  • platform/mac/svg/custom/clip-path-id-changes-expected.png: Added.
  • platform/mac/svg/custom/clip-path-id-changes-expected.txt: Added.
  • svg/custom/clip-path-id-changes.svg: Added.
11:24 AM Changeset in webkit [57658] by ajwong@chromium.org
  • 2 edits in trunk/WebCore

2010-04-15 Justin Schuh <​jschuh@chromium.org>

Reviewed by Dimitri Glazkov.

LayoutTest breakage in V8 bindings after r57627
​https://bugs.webkit.org/show_bug.cgi?id=37660

Fixes breakage of the following tests due to an error in V8 bindings for
NamedNodeMap:
hc_namednodemapinuseattributeerr.html
hc_namednodemapsetnameditemreturnvalue.html
hc_namednodemapwrongdocumenterr.html
hc_namednodemapinvalidtype1.html
NamedNodeMap-setNamedItem-crash.html

  • bindings/v8/custom/V8NamedNodeMapCustom.cpp: (WebCore::V8NamedNodeMap::setNamedItemNSCallback): (WebCore::V8NamedNodeMap::setNamedItemCallback):
11:22 AM Changeset in webkit [57657] by hyatt@apple.com
  • 3 edits in trunk/WebCore

​https://bugs.webkit.org/show_bug.cgi?id=37567, :first-letter inside a :visited link is wrong color. Make sure
that the pseudo style caching allows visited link styles to hang off other pseudo styles.

Reviewed by Anders Carlsson.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::updateFirstLetter):

  • rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::getCachedPseudoStyle):

11:21 AM Changeset in webkit [57656] by tonikitoo@webkit.org
  • 2 edits in trunk/WebKit/qt

REGRESSION(r56552): Broken scrollbars size ​https://bugs.webkit.org/show_bug.cgi?id=36853

Reviewed by Kenneth Christiansen and Tor Arne Vestbø.
Patch by Antonio Gomes <​tonikitoo@webkit.org>

The regression was caused by r56552, which introduced a fix to bug
webkit.org/b/21300. The bug solved an issue with the resize handle on mac,
but did it in a way that affected all Qt platforms and thus broke the behavior
on non-mac platforms.

This patch makes the mac specific change ifdef'ed and only applied for the mac
platform.

  • WebCoreSupport/ChromeClientQt.cpp:

(WebCore::ChromeClientQt::windowResizerRect):

11:13 AM Changeset in webkit [57655] by benm@google.com
  • 5 edits in trunk

2010-04-15 Ben Murdoch <​benm@google.com>

Unreviewed, rolling out r57652.
​http://trac.webkit.org/changeset/57652
​https://bugs.webkit.org/show_bug.cgi?id=37609

Caused a build break on Chromium Mac and Layout Test fail on
Qt

  • src/WebInputEventConversion.cpp: (WebKit::toPlatformTouchPointState):

2010-04-15 Ben Murdoch <​benm@google.com>

Unreviewed, rolling out r57652.
​http://trac.webkit.org/changeset/57652
​https://bugs.webkit.org/show_bug.cgi?id=37609

Caused a build break on Chromium Mac and Layout Test fail on
Qt

  • platform/PlatformTouchPoint.h: (WebCore::PlatformTouchPoint::):
  • platform/qt/PlatformTouchPointQt.cpp: (WebCore::PlatformTouchPoint::PlatformTouchPoint):
10:51 AM Changeset in webkit [57654] by andersca@apple.com
  • 4 edits in trunk/WebKitTools

2010-04-14 Anders Carlsson <​andersca@apple.com>

Reviewed by Adam Roben.

Add "Force Repaint" to debug menu.
​https://bugs.webkit.org/show_bug.cgi?id=37627

  • MiniBrowser/mac/BrowserWindowController.h:
  • MiniBrowser/mac/BrowserWindowController.m: (-[BrowserWindowController forceRepaint:]):
  • MiniBrowser/mac/English.lproj/MainMenu.xib:
10:33 AM Changeset in webkit [57653] by eric@webkit.org
  • 4 edits in trunk/WebCore

2010-04-15 Yaar Schnitman <​yaar@chromium.org>

Reviewed by Nate Chapin.

Overloads auto-generation in V8
​https://bugs.webkit.org/show_bug.cgi?id=37373

This will be used by XHR.send/open, Canvas.*, WebGL.* methods that are currently custom. When more than a single overload exists for a method, the correct overload is chosen based on the total number of arguments passed as well as the values passed to non-primitive arguments.

Overload dispatch order depends on the order the functions are defined in the IDL. Overloads must be specified from the most precise (overloads with wrapper type arguments) to the least precise (overloads with only primitive type arguments).

  • bindings/scripts/CodeGeneratorV8.pm: Identify and output overloads callbacks and dispatch code.
  • bindings/v8/test/TestObj.idl: Overloads sample.
  • bindings/v8/test/V8TestObj.cpp: Output change.
10:18 AM Changeset in webkit [57652] by benm@google.com
  • 5 edits in trunk

2010-04-14 Ben Murdoch <​benm@google.com>

Reviewed by Kenneth Rohde Christiansen.

The TouchStationary state of WebCore::PlatformTouchPoint is not
handled inside the touch event handler.
​https://bugs.webkit.org/show_bug.cgi?id=37609

After discussions at the WebKit contributors meeting, we decided that
this is a currently unused state without a good future use case in the
Touch API and thus decided to remove it. This patch actions that decision.

  • src/WebInputEventConversion.cpp: (WebKit::toPlatformTouchPointState): Remove TouchStationary.

2010-04-15 Ben Murdoch <​benm@google.com>

Reviewed by Kenneth Rohde Christiansen.

The TouchStationary state of WebCore::PlatformTouchPoint
is not handled inside the touch event handler.
​https://bugs.webkit.org/show_bug.cgi?id=37609

After discussions at the WebKit contributors meeting, we decided
that this is a currently unused state without a good future use
case in the Touch API and thus decided to remove it. This patch
actions that decision.

As the TouchStationary state is not handled in the EventHandler,
there is no change in functionality so no new tests are required.

  • platform/PlatformTouchPoint.h: (WebCore::PlatformTouchPoint::): Remove TouchStationary.
  • platform/qt/PlatformTouchPointQt.cpp: (WebCore::PlatformTouchPoint::PlatformTouchPoint): Remove TouchStationary.
10:03 AM Changeset in webkit [57651] by weinig@apple.com
  • 2 edits
    1 copy in trunk/WebKitTools

Add debug-minibrowser script.

Reviewed by Adam Roben.

  • Scripts/debug-minibrowser: Copied from Scripts/run-minibrowser.
  • Scripts/webkitdirs.pm:
9:57 AM Changeset in webkit [57650] by sfalken@apple.com
  • 3 edits in trunk/WebCore

2010-04-15 Steve Falkenburg <​sfalken@apple.com>

Reviewed by Adam Roben.

Use a lower-overhead mechanism for plug-in message throttling
​https://bugs.webkit.org/show_bug.cgi?id=37642
<rdar://problem/7418285> Very high CPU usage idling in gmail under Windows 7 (plug-in related)


GMail has an instance of Flash that loads on the main mail page.
This Flash content sends us a constant stream of WM_USER+1 messsages.


There was already code in PluginMessageThrottlerWin to queue and process these
excess WM_USER+1 messages from Flash. Unfortunately, there were a couple of
problems with this code:


  • The timer used to process the excess messages had a very low timeout (1ms). Chrome uses a value of 5ms for this delay, and doesn't use excess CPU here, while still maintaining good Flash frame rate.


  • The overhead involved in generating a constant stream of 5ms timers still swamped the CPU, resulting in continued high CPU utilization.


To fix this, I changed the throttling code to:


  • Process a queued WM_USER+1 message directly if none has been processed in 5ms. This allows us to avoid the overhead of a timer.


  • Process remaining delayed WM_USER+1 messages on a 16ms timer.


This reduces our CPU utilization idling in GMail from ~20% to ~2-3% on my system.
I also verified the frame rate for Flash content wasn't reduced with this change.

  • plugins/win/PluginMessageThrottlerWin.cpp: (WebCore::PluginMessageThrottlerWin::PluginMessageThrottlerWin): Initialize m_lastMessageTime. (WebCore::PluginMessageThrottlerWin::appendMessage): Process a queued message directly if >5ms have passed. (WebCore::PluginMessageThrottlerWin::processQueuedMessage): Split out from messageThrottleTimerFired. (WebCore::PluginMessageThrottlerWin::messageThrottleTimerFired): Call through to processQueuedMessage.
  • plugins/win/PluginMessageThrottlerWin.h: Add processQueuedMessage, m_lastMessageTime.
8:59 AM Changeset in webkit [57649] by eric@webkit.org
  • 3 edits
    1 add in trunk/WebKitTools

2010-04-15 Roland Steiner <​rolandsteiner@chromium.org>

Reviewed by Dimitri Glazkov.

Bug 37636 - [DRT/Chromium] Implement DRT/Chromium for Windows
​https://bugs.webkit.org/show_bug.cgi?id=37636

Second patch: add Windows-specific implementation parts
of TestShell.

  • DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
  • DumpRenderTree/chromium/TestShell.h: (TestShell::finishedEvent):
  • DumpRenderTree/chromium/TestShellWin.cpp: (watchDogThread): (TestShell::waitTestFinished):
8:50 AM Changeset in webkit [57648] by eric@webkit.org
  • 7 edits in trunk/WebKitTools

2010-04-15 Roland Steiner <​rolandsteiner@chromium.org>

Reviewed by Dimitri Glazkov.

Bug 37636 - [DRT/Chromium] Implement DRT/Chromium for Windows
​https://bugs.webkit.org/show_bug.cgi?id=37636

First patch: fix compiler errors.

  • DumpRenderTree/chromium/EventSender.cpp: (EventSender::reset): (EventSender::dispatchMessage):
  • DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::pathToLocalResource):
  • DumpRenderTree/chromium/TestWebWorker.h:
  • DumpRenderTree/chromium/TextInputController.cpp:
  • DumpRenderTree/chromium/WebViewHost.h:
  • DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
8:20 AM Changeset in webkit [57647] by antonm@chromium.org
  • 2 edits
    4 adds in trunk/LayoutTests

2010-04-15 Anton Muhin <​antonm@chromium.org>

Not reviewed, sheriffing.

[Chromium] rebaseline URL related tests: update expectations for Win and Mac.

​https://bugs.webkit.org/show_bug.cgi?id=37654

  • platform/chromium-mac/fast/url/mailto-expected.txt: Added.
  • platform/chromium-mac/fast/url/scheme-expected.txt: Added.
  • platform/chromium-win/fast/url/mailto-expected.txt: Added.
  • platform/chromium-win/fast/url/scheme-expected.txt: Added.
7:52 AM Changeset in webkit [57646] by hamaji@chromium.org
  • 3 edits in trunk/WebCore

2010-04-15 Shinichiro Hamaji <​hamaji@chromium.org>

Reviewed by David Levin.

LEAK: in ThreadableWebSocketChannel::create()
​https://bugs.webkit.org/show_bug.cgi?id=37584

No new tests because this change just fixes a leak.

  • websockets/WorkerThreadableWebSocketChannel.cpp: (WebCore::WorkerThreadableWebSocketChannel::WorkerThreadableWebSocketChannel):
  • websockets/WorkerThreadableWebSocketChannel.h: (WebCore::WorkerThreadableWebSocketChannel::Bridge::create):
7:41 AM Changeset in webkit [57645] by ggaren@apple.com
  • 17 edits
    1 delete in trunk/WebKit2

Fixed complexity and performance FIXME created by using KURL in the UI
process -- it turned out that everywhere we were using KURL, we could
have just used String instead. (That's how Windows WebKit works, too.)

Reviewed by Anders Carlsson.

I kept WKURLRef and WKStringRef distinct opaque types in the API for now,
though, since there may be profit in changing their backing stores in the
future, and it's nice for the API to encode a difference between generic
strings and strings that are valid, canonical URLs.

  • Shared/KURLWrapper.h: Removed. Yay!
  • Shared/WebCoreTypeArgumentMarshalling.h: Nixed KURL marshalling functions.

Old callers marshal Strings now, instead. (This is what KURL was doing
under the covers, anyway.)

  • UIProcess/API/C/WKAPICast.h:

(toWK): Backed by StringImpl* now.
(toURLRef): Added a disambiguating function for specifying that you want
a WKURLRef, since StringImpl* converts to WKStringRef by default.

  • UIProcess/API/C/WKFrame.cpp:

(WKFrameGetProvisionalURL):
(WKFrameGetURL):

  • UIProcess/API/C/WKPage.cpp:

(WKPageLoadURL):

  • UIProcess/API/C/WKURL.cpp:
  • UIProcess/API/C/cf/WKURLCF.cpp:

(WKURLCreateWithCFURL):
(WKURLCopyCFURL):

  • UIProcess/WebFrameProxy.cpp:

(WebKit::WebFrameProxy::didStartProvisionalLoad):
(WebKit::WebFrameProxy::didCommitLoad):

  • UIProcess/WebFrameProxy.h:

(WebKit::WebFrameProxy::url):
(WebKit::WebFrameProxy::provisionalURL):

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::loadURL):
(WebKit::WebPageProxy::didReceiveMessage):
(WebKit::WebPageProxy::didStartProvisionalLoadForFrame):
(WebKit::WebPageProxy::decidePolicyForNavigationAction):
(WebKit::WebPageProxy::decidePolicyForNewWindowAction):
(WebKit::WebPageProxy::decidePolicyForMIMEType):
(WebKit::WebPageProxy::processDidExit):

  • UIProcess/WebPageProxy.h:

(WebKit::WebPageProxy::urlAtProcessExit):

  • UIProcess/WebPolicyClient.cpp:

(WebKit::WebPolicyClient::decidePolicyForNavigationAction):
(WebKit::WebPolicyClient::decidePolicyForNewWindowAction):
(WebKit::WebPolicyClient::decidePolicyForMIMEType):

  • UIProcess/WebPolicyClient.h:
  • WebKit2.xcodeproj/project.pbxproj:
  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::dispatchDidStartProvisionalLoad):
(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForMIMEType):
(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::loadURL):
(WebKit::WebPage::didReceiveMessage):

  • WebProcess/WebPage/WebPage.h: Replaced KURL / KURLWrapper with String.
7:40 AM Changeset in webkit [57644] by antonm@chromium.org
  • 6 edits in trunk/LayoutTests

2010-04-15 Anton Muhin <​antonm@chromium.org>

Not reviewed, sheriffing.

[Chromium] rebaseline svg/custom/path-bad-data.svg after ​http://trac.webkit.org/changeset/57591/

​http://trac.webkit.org/changeset/57591://bugs.webkit.org/show_bug.cgi?id=37657

  • platform/chromium-linux/svg/custom/path-bad-data-expected.checksum:
  • platform/chromium-linux/svg/custom/path-bad-data-expected.png:
  • platform/chromium-win/svg/custom/path-bad-data-expected.checksum:
  • platform/chromium-win/svg/custom/path-bad-data-expected.png:
  • platform/chromium-win/svg/custom/path-bad-data-expected.txt:
7:18 AM Changeset in webkit [57643] by antonm@chromium.org
  • 1 edit
    8 adds in trunk/LayoutTests

2010-04-15 Anton Muhin <​antonm@chromium.org>

Not reviewed, sheriffing.

[Chromium] rebaseline fast/repaint/fixed-tranformed.html after
​http://trac.webkit.org/changeset/57633/

​https://bugs.webkit.org/show_bug.cgi?id=37656

  • platform/chromium-linux/fast/repaint/fixed-tranformed-expected.checksum: Added.
  • platform/chromium-linux/fast/repaint/fixed-tranformed-expected.png: Added.
  • platform/chromium-mac/fast/repaint/fixed-tranformed-expected.checksum: Added.
  • platform/chromium-mac/fast/repaint/fixed-tranformed-expected.png: Added.
  • platform/chromium-win-xp/fast/repaint: Added.
  • platform/chromium-win-xp/fast/repaint/fixed-tranformed-expected.png: Added.
  • platform/chromium-win/fast/repaint/fixed-tranformed-expected.checksum: Added.
  • platform/chromium-win/fast/repaint/fixed-tranformed-expected.png: Added.
6:41 AM Changeset in webkit [57642] by wsiegrist@apple.com
  • 1 edit in trunk/WebKitTools/BuildSlaveSupport/build.webkit.org-config/master.cfg

2010-04-15 William Siegrist <​wsiegrist@apple.com>

Give a name to new KillOldProcesss step so it does not collide with the other compile step.

6:39 AM QtWebKitTableOfFeatures20 edited by Henry Haverinen
(diff)
6:19 AM Changeset in webkit [57641] by wsiegrist@apple.com
  • 2 edits in trunk/WebKitTools/BuildSlaveSupport/build.webkit.org-config

2010-04-15 William Siegrist <​wsiegrist@apple.com>

Add core/noncore categories to builders.

6:15 AM Changeset in webkit [57640] by antonm@chromium.org
  • 1 edit
    13 adds in trunk/LayoutTests

2010-04-15 Anton Muhin <​antonm@chromium.org>

Not reviewed, sheriffing.

Rebaseline some recently added LayoutTests under fast/url.

  • platform/chromium-linux/fast/url: Added.
  • platform/chromium-linux/fast/url/mailto-expected.txt: Added.
  • platform/chromium-linux/fast/url/scheme-expected.txt: Added.
  • platform/chromium-mac/fast/url: Added.
  • platform/chromium-mac/fast/url/ipv6-expected.txt: Added.
  • platform/chromium-mac/fast/url/path-url-expected.txt: Added.
  • platform/chromium-mac/fast/url/port-expected.txt: Added.
  • platform/chromium-mac/fast/url/standard-url-expected.txt: Added.
  • platform/chromium-win/fast/url: Added.
  • platform/chromium-win/fast/url/ipv6-expected.txt: Added.
  • platform/chromium-win/fast/url/path-url-expected.txt: Added.
  • platform/chromium-win/fast/url/port-expected.txt: Added.
  • platform/chromium-win/fast/url/standard-url-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
6:03 AM QtWebKitTableOfFeatures20 edited by Henry Haverinen
(diff)
5:54 AM QtWebKitTableOfFeatures20 edited by Henry Haverinen
(diff)
5:32 AM QtWebKitTableOfFeatures20 edited by Henry Haverinen
(diff)
4:51 AM Changeset in webkit [57639] by eric@webkit.org
  • 3 edits in trunk/WebCore

2010-04-15 Gyuyoung Kim <​gyuyoung.kim@samsung.com>

Reviewed by Eric Seidel.

Duplicated patches related to wml were pushed to trunk. So, one of
the patches should be reverted.
​https://bugs.webkit.org/show_bug.cgi?id=37542

  • wml/WMLOptionElement.h:
  • wml/WMLSelectElement.h:
4:01 AM QtWebKitTableOfFeatures20 edited by Henry Haverinen
(diff)
3:32 AM BuildingQtOnLinux edited by jocelyn.turcotte@nokia.com
(diff)
3:03 AM Changeset in webkit [57638] by eric@webkit.org
  • 5 edits in trunk

2010-04-15 Bruno Schmidt <​bruno.schmidt@gmail.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Null QObjects properties cause Segmentation Fault
​https://bugs.webkit.org/show_bug.cgi?id=34730

QObjects exported to the QWebkit javascript with properties that are
a null "QObject*" cause Segmentation Fault.

If an QObject is added to the javascript context and it contains
properties of the type QObject* with NULL value, calling the property
causes Segmentation Fault.
So now the code below properly checks for null pointers:

  • bridge/qt/qt_instance.cpp: (JSC::Bindings::QtInstance::getClass): may return NULL (JSC::Bindings::QtInstance::getMethod): may return jsNull() (JSC::Bindings::QtInstance::stringValue): may return jsNull() (JSC::Bindings::QtInstance::booleanValue): may return false
  • bridge/qt/qt_runtime.cpp: (JSC::Bindings::convertValueToQVariant): (JSC::Bindings::convertQVariantToValue): May return jsNull on QObjectStar

2010-04-15 Bruno Schmidt <​bruno.schmidt@gmail.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Null QObjects properties cause Segmentation Fault
​https://bugs.webkit.org/show_bug.cgi?id=34730

QObjects exported to the QWebkit javascript with properties that are
a null "QObject*" cause Segmentation Fault.

If an QObject is added to the javascript context and it contains
properties of the type QObject* with NULL value, calling the property
causes Segmentation Fault.

Follow the tests for the corrections done over WebCore.

  • tests/qwebframe/tst_qwebframe.cpp: (MyQObject::MyQObject): init the field m_objectStar (MyQObject::objectStarProperty): read the Object* prop (MyQObject::setObjectStarProperty): write the Object* prop (tst_QWebFrame::getSetStaticProperty): new tests for the new prop
2:53 AM Changeset in webkit [57637] by eric@webkit.org
  • 3 edits in trunk/JavaScriptCore

2010-04-15 Jedrzej Nowacki <​jedrzej.nowacki@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

Fix memory leak in QScriptEngine::evaluate().

QScriptEnginePrivate::evaluate should release temporary variables.

[Qt] QScriptEngine::evaluate has memory leak.
​https://bugs.webkit.org/show_bug.cgi?id=37596

  • qt/api/qscriptengine_p.cpp: (QScriptEnginePrivate::evaluate):
  • qt/api/qscriptengine_p.h:
1:14 AM Changeset in webkit [57636] by abarth@webkit.org
  • 1 edit
    3 adds in trunk/LayoutTests

2010-04-15 Jonathan Dixon <​joth@chromium.org>

Reviewed by Adam Barth.

​https://bugs.webkit.org/show_bug.cgi?id=37492

Add mailto: canonicalization tests to the URL regressions tests

  • fast/url/mailto-expected.txt: Added.
  • fast/url/mailto.html: Added.
  • fast/url/script-tests/mailto.js: Added.
1:07 AM Changeset in webkit [57635] by abarth@webkit.org
  • 2 edits
    3 adds in trunk/LayoutTests

2010-04-15 Adam Barth <​abarth@webkit.org>

Reviewed by Maciej Stachowiak.

Add URL scheme parsing tests
​https://bugs.webkit.org/show_bug.cgi?id=37496

I'm not super happy with how these test turned out. It's difficult to
test these cases with this methodology because most of the cases get
treated as relative URLs. I tired using the "protocol" property of the
HTMLAnchorElement, but that often caused the test case to be ignored
for reasons I don't fully understand.

  • fast/url/resources/utilities.js: (setBaseURL):
    • In the course of trying various variations of this test, I wrote this function. It seemed useful, so I left it here for the benefit of future test writing.
  • fast/url/scheme-expected.txt: Added.
  • fast/url/scheme.html: Added.
  • fast/url/script-tests/scheme.js: Added.
12:55 AM Changeset in webkit [57634] by abarth@webkit.org
  • 2 edits in trunk/LayoutTests

2010-04-15 Adam Barth <​abarth@webkit.org>

Reviewed by Darin Fisher.

Add comments back to IPv4 URL parsing test
​https://bugs.webkit.org/show_bug.cgi?id=37620

I removed these comments when importing this test. The comments are
likley to be helpful to us in the future, so I've restored them.

  • fast/url/script-tests/ipv4.js:

Apr 14, 2010:

11:49 PM April 2010 Meeting edited by vestbo@webkit.org
(diff)
9:48 PM Changeset in webkit [57633] by Simon Fraser
  • 3 edits
    4 adds in trunk

2010-04-14 Simon Fraser <Simon Fraser>

Reviewed by Dan Bernstein.

Repaint of fixed, transformed element is broken
​https://bugs.webkit.org/show_bug.cgi?id=37637

RenderBox::computeRectForRepaint() failed to set the 'fixed' flag correctly
for elements that had both fixed position and a transform. If the element has
a transform, 'fixed' should only remain true if the element itself is fixed
position.

Also cache style()->position() in a local variable for performance.

Test: fast/repaint/fixed-tranformed.html

  • rendering/RenderBox.cpp: (WebCore::RenderBox::computeRectForRepaint):
9:47 PM Changeset in webkit [57632] by Simon Fraser
  • 1 edit in trunk/JavaScriptCore/ChangeLog

Additional refptr/passrefptr workarounds for WINSCW compiler

​https://bugs.webkit.org/show_bug.cgi?id=28054

Patch by Janne Koskinen <​janne.p.koskinen@digia.com> on 2010-02-12

Reviewed by Tor Arne Vestbø.

  • wtf/PassRefPtr.h:

(WTF::refIfNotNull):
(WTF::PassRefPtr::PassRefPtr):
(WTF::PassRefPtr::~PassRefPtr):
(WTF::PassRefPtr::clear):
(WTF::::operator):

  • wtf/RefPtr.h:

(WTF::RefPtr::RefPtr):
(WTF::::operator):

9:04 PM Changeset in webkit [57631] by eric@webkit.org
  • 8 edits in trunk

2010-04-14 Luiz Agostini <​luiz.agostini@openbossa.org>

Reviewed by Kenneth Rohde Christiansen.

Changing view mode names due to specification changes
​https://bugs.webkit.org/show_bug.cgi?id=37615

specification: ​http://dev.w3.org/2006/waf/widgets-vmmf/

  • fast/media/media-feature-wgt-view-mode.html:

2010-04-14 Luiz Agostini <​luiz.agostini@openbossa.org>

Reviewed by Kenneth Rohde Christiansen.

Changing view mode names due to specification changes
​https://bugs.webkit.org/show_bug.cgi?id=37615

test: fast/media/media-feature-wgt-view-mode.html

specification: ​http://dev.w3.org/2006/waf/widgets-vmmf/

  • css/MediaQueryEvaluator.cpp: (WebCore::view_modeMediaFeatureEval):
  • page/ChromeClient.h: (WebCore::ChromeClient::isWindowed): (WebCore::ChromeClient::isMaximized): (WebCore::ChromeClient::isMinimized):

2010-04-14 Luiz Agostini <​luiz.agostini@openbossa.org>

Reviewed by Kenneth Rohde Christiansen.

Changing view mode names due to specification changes
​https://bugs.webkit.org/show_bug.cgi?id=37615

test: fast/media/media-feature-wgt-view-mode.html

specification: ​http://dev.w3.org/2006/waf/widgets-vmmf/

  • WebCoreSupport/ChromeClientQt.cpp: (WebCore::ChromeClientQt::isWindowed): (WebCore::ChromeClientQt::isFullscreen): (WebCore::ChromeClientQt::isMaximized): (WebCore::ChromeClientQt::isMinimized):
  • WebCoreSupport/ChromeClientQt.h:
8:37 PM Changeset in webkit [57630] by abarth@webkit.org
  • 2 edits in trunk/WebCore

2010-04-14 Adam Barth <​abarth@webkit.org>

Unreviewed attempt to fix Qt build.

  • bindings/js/JSNodeCustom.cpp:
8:34 PM Changeset in webkit [57629] by eric@webkit.org
  • 6 edits in trunk

2010-04-14 Luiz Agostini <​luiz.agostini@openbossa.org>

Reviewed by Simon Hausmann.

[Qt] Moving setViewMode from DumpRenderTreeSupportQt to qwebpage.cpp
​https://bugs.webkit.org/show_bug.cgi?id=37622

Method qt_wrt_setViewMode was removed from qwebpage.cpp by mistake in r57433
(bug 35844). Moving it back.

  • Api/qwebpage.cpp: (qt_wrt_setViewMode):
  • WebCoreSupport/DumpRenderTreeSupportQt.cpp: (DumpRenderTreeSupportQt::setMediaType):
  • WebCoreSupport/DumpRenderTreeSupportQt.h:

2010-04-14 Luiz Agostini <​luiz.agostini@openbossa.org>

Reviewed by Simon Hausmann.

[Qt] Moving setViewMode from DumpRenderTreeSupportQt to qwebpage.cpp
​https://bugs.webkit.org/show_bug.cgi?id=37622

Method qt_wrt_setViewMode was removed from qwebpage.cpp by mistake in r57433
(bug 35844). Moving it back.

  • DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::setViewModeMediaFeature):
8:17 PM Changeset in webkit [57628] by eric@webkit.org
  • 2 edits in trunk/JavaScriptCore

2010-04-14 Jedrzej Nowacki <​jedrzej.nowacki@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

Fix a memory leak in QScriptValue::inherits.

[Qt] QScriptValue::inherits has a memory leak.
​https://bugs.webkit.org/show_bug.cgi?id=37617

  • qt/api/qscriptvalue_p.h: (QScriptValuePrivate::inherits):
8:11 PM Changeset in webkit [57627] by abarth@webkit.org
  • 16 edits in trunk

2010-04-14 Justin Schuh <​jschuh@chromium.org>

Reviewed by Adam Barth.

Javascript URL can be set as iframe.src via multiple DOM aliases
​https://bugs.webkit.org/show_bug.cgi?id=37031

Moved frame/iframe checks from Attr to Node on inherited members.
Node child manipulation methods now return NOT_SUPPORTED_ERR if used
on a frame/iframe src attribute.
NamedNodeMap set methods now perform frame/iframe src checks.
Moved allowSettingSrcToJavascriptURL static helper function from
JSElementCustom.cpp to exported function in JSDOMBinding.h.

  • bindings/js/JSAttrCustom.cpp: (WebCore::JSAttr::setValue):
  • bindings/js/JSDOMBinding.cpp: (WebCore::allowSettingSrcToJavascriptURL):
  • bindings/js/JSDOMBinding.h:
  • bindings/js/JSElementCustom.cpp:
  • bindings/js/JSNamedNodeMapCustom.cpp: (WebCore::JSNamedNodeMap::setNamedItem): (WebCore::JSNamedNodeMap::setNamedItemNS):
  • bindings/js/JSNodeCustom.cpp: (WebCore::isAttrFrameSrc): (WebCore::JSNode::setNodeValue): (WebCore::JSNode::setTextContent): (WebCore::JSNode::insertBefore): (WebCore::JSNode::replaceChild): (WebCore::JSNode::removeChild): (WebCore::JSNode::appendChild):
  • bindings/v8/custom/V8AttrCustom.cpp:
  • bindings/v8/custom/V8NamedNodeMapCustom.cpp: (WebCore::V8NamedNodeMap::setNamedItemNSCallback): (WebCore::V8NamedNodeMap::setNamedItemCallback): (WebCore::toV8):
  • bindings/v8/custom/V8NodeCustom.cpp: (WebCore::isFrameSrc): (WebCore::V8Node::textContentAccessorSetter): (WebCore::V8Node::nodeValueAccessorSetter): (WebCore::V8Node::insertBeforeCallback): (WebCore::V8Node::replaceChildCallback): (WebCore::V8Node::removeChildCallback): (WebCore::V8Node::appendChildCallback):
  • dom/Attr.idl:
  • dom/NamedNodeMap.idl:
  • dom/Node.idl:

2010-04-14 Justin Schuh <​jschuh@chromium.org>

Reviewed by Adam Barth.

Fix frame/iframe src setting for JavaScript URLs
​https://bugs.webkit.org/show_bug.cgi?id=37031

  • http/tests/security/xss-DENIED-iframe-src-alias-expected.txt:
  • http/tests/security/xss-DENIED-iframe-src-alias.html:
8:07 PM Changeset in webkit [57626] by eric@webkit.org
  • 3 edits in trunk/JavaScriptCore

2010-04-14 Jedrzej Nowacki <​jedrzej.nowacki@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

Fix a few memory leaks in QScriptEngine.

Syntax checking caused memory leak, not all temporary variables were released.

[Qt] Syntax checking in the QtScript cause a memory leak.
​https://bugs.webkit.org/show_bug.cgi?id=37610

  • qt/api/qscriptengine_p.cpp: (QScriptEnginePrivate::checkSyntax):
  • qt/api/qscriptsyntaxcheckresult.cpp: (QScriptSyntaxCheckResultPrivate::errorMessage): (QScriptSyntaxCheckResultPrivate::errorLineNumber):
7:58 PM Changeset in webkit [57625] by eric@webkit.org
  • 2 edits in trunk/JavaScriptCore

2010-04-14 Jedrzej Nowacki <​jedrzej.nowacki@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

Fix memory leak inside QScriptEnginePrivate::makeJSValue.

QScriptEnginePrivate::makeJSValue should release temporary JSStringRef variable.

[Qt] tst_QScriptValue::toString has a memory leak.
​https://bugs.webkit.org/show_bug.cgi?id=37598

  • qt/api/qscriptengine_p.h: (QScriptEnginePrivate::makeJSValue):
6:39 PM Changeset in webkit [57624] by alex
  • 2 edits in trunk/WebCore

2010-04-14 Alejandro G. Castro <​alex@igalia.com>

Reviewed by Xan Lopez.

We have to check if the resource handler is cancelled before
checking the client, other case it could crash.

  • platform/network/soup/ResourceHandleSoup.cpp: (WebCore::parseDataUrl):
6:06 PM Changeset in webkit [57623] by eric@webkit.org
  • 2 edits in trunk/WebKit/qt

2010-04-14 Andreas Kling <​andreas.kling@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Rendering artifacts on Qt plugins when scrolling the page
​https://bugs.webkit.org/show_bug.cgi?id=37152

Because we no longer repaint the entire viewport on scroll,
we must trigger a repaint of QtPluginWidgets when their geometry changes.

  • WebCoreSupport/FrameLoaderClientQt.cpp:
5:59 PM Changeset in webkit [57622] by dpranke@chromium.org
  • 2 edits
    1 add in trunk/WebKitTools

2010-04-15 Dirk Pranke <​dpranke@chromium.org>

Reviewed by Adam Barth.

Add some very minimal unit tests for new-run-webkit-tests. This should
be enough to catch egregious brokenness like syntax errors and import
declaration issues.

​https://bugs.webkit.org/show_bug.cgi?id=37432

  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py: Added.
5:46 PM Changeset in webkit [57621] by andersca@apple.com
  • 6 edits in trunk/WebKit2

2010-04-14 Anders Carlsson <​andersca@apple.com>

Reviewed by Sam Weinig.

Fix horizontal scrollbar repainting
​https://bugs.webkit.org/show_bug.cgi?id=37626

Make sure that the update chunk is flipped because that's what WebCore expects.


  • Shared/mac/UpdateChunk.cpp: (WebKit::UpdateChunk::createImage):
  • Shared/mac/UpdateChunk.h: Add new createImage member function that creates a CGImageRef from the update chunk.


  • UIProcess/mac/DrawingAreaProxyUpdateChunk.mm: (WebKit::DrawingAreaProxyUpdateChunk::drawUpdateChunkIntoBackingStore): Pass the right rectangle here; CoreGraphics wants it in non-flipped coordinates.


(WebKit::DrawingAreaProxyUpdateChunk::ensureBackingStore):
Create a flipped backing store.

  • WebProcess/WebPage/mac/DrawingAreaUpdateChunk.cpp: (WebKit::DrawingAreaUpdateChunk::paintIntoUpdateChunk): Flip the update chunk.
5:13 PM Changeset in webkit [57620] by tony@chromium.org
  • 2 edits in trunk/WebKit/chromium

2010-04-12 Tony Chang <​tony@chromium.org>

Reviewed by Darin Fisher.

[chromium] update chromium DEPS for upstream compile
​https://bugs.webkit.org/show_bug.cgi?id=36578

  • DEPS: Pull sub deps from chromium's DEPS file
4:33 PM Changeset in webkit [57619] by mrowe@apple.com
  • 5 edits in trunk

Versioning.

4:31 PM Changeset in webkit [57618] by mrowe@apple.com
  • 1 copy in tags/Safari-533.5

New tag.

4:25 PM Changeset in webkit [57617] by xan@webkit.org
  • 2 edits in trunk/LayoutTests

2010-04-14 Xan Lopez <​xlopez@igalia.com>

[GTK] scrollbars/scrollbar-crash-on-refresh.html is flakey on debug bots
​https://bugs.webkit.org/show_bug.cgi?id=37623

We are on a mission here, people.

  • platform/gtk/Skipped:
4:11 PM Changeset in webkit [57616] by eric@webkit.org
  • 5 edits
    2 deletes in trunk

2010-04-14 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r57609.
​http://trac.webkit.org/changeset/57609
​https://bugs.webkit.org/show_bug.cgi?id=37614

"Broke multiple builders. Probably needs new test results,
but may be an Inspector bug." (Requested by eseidel on
#webkit).

  • inspector/console-resource-errors-expected.txt: Removed.
  • inspector/console-resource-errors.html: Removed.

2010-04-14 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r57609.
​http://trac.webkit.org/changeset/57609
​https://bugs.webkit.org/show_bug.cgi?id=37614

"Broke multiple builders. Probably needs new test results,
but may be an Inspector bug." (Requested by eseidel on
#webkit).

  • inspector/InspectorController.cpp: (WebCore::InspectorController::didReceiveResponse): (WebCore::InspectorController::didFailLoading):
  • inspector/front-end/Resource.js: (WebInspector.Resource.prototype._mimeTypeIsConsistentWithType):
  • inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel.prototype.recreateViewForResourceIfNeeded):
4:01 PM Changeset in webkit [57615] by Adam Roben
  • 5 edits in trunk/WebKit/win

Expose DOMWrapperWorld::unregisterWorld as WebKit SPI on Windows

Fixes <​http://webkit.org/b/37619>.

Reviewed by Steve Falkenburg.

  • Interfaces/IWebScriptWorld.idl: Added unregisterWorld.
  • Interfaces/WebKit.idl: Touched to force a build.
  • WebScriptWorld.cpp:

(WebScriptWorld::unregisterWorld):

  • WebScriptWorld.h:

Added. Just calls through to DOMWrapperWorld::unregisterWorld.

3:32 PM Changeset in webkit [57614] by alex
  • 2 edits in trunk/LayoutTests

2010-04-14 Alejandro G. Castro <​alex@igalia.com>

Rubber-stamped by Xan Lopez.

Skipping fast/workers/shared-worker-frame-lifecycle.html
​https://bugs.webkit.org/show_bug.cgi?id=37616

  • platform/gtk/Skipped:
3:15 PM Changeset in webkit [57613] by sfalken@apple.com
  • 2 edits in trunk/WebCore

2010-04-14 Steve Falkenburg <​sfalken@apple.com>

Reviewed by Dan Bernstein.

Don't cache SimpleFontData* in getLastResortFallbackFont. The cached entry may be invalidated.
​https://bugs.webkit.org/show_bug.cgi?id=37599

  • platform/graphics/win/FontCacheWin.cpp: (WebCore::fontDataFromDescriptionAndLogFont): (WebCore::FontCache::getLastResortFallbackFont):
3:06 PM Changeset in webkit [57612] by alex
  • 2 edits in trunk/LayoutTests

2010-04-14 Alejandro G. Castro <​alex@igalia.com>

Rubber-stamped by Xan Lopez.

Skipping printing, I've duplicated the other printing bugs and
left this one.
​https://bugs.webkit.org/show_bug.cgi?id=37613

  • platform/gtk/Skipped:
2:53 PM Changeset in webkit [57611] by bweinstein@apple.com
  • 1 edit in trunk/WebKit/win/Interfaces/WebKit.idl

Touch WebKit.idl to fix the build

2:51 PM Changeset in webkit [57610] by alex
  • 2 edits in trunk/LayoutTests

2010-04-14 Alejandro G. Castro <​alex@igalia.com>

Rubber-stamped by Xan Lopez.

Skipping inspector/timeline-layout.html fails
​https://bugs.webkit.org/show_bug.cgi?id=37611

  • platform/gtk/Skipped:
2:49 PM Changeset in webkit [57609] by eric@webkit.org
  • 5 edits
    2 adds in trunk

2010-04-14 Andrey Kosyakov <​caseq@chromium.ru>

Reviewed by Timothy Hatcher.

Log error message to inspector console if a resource fails to load.
Disable checking of mime-type consistency for failed resources.
​https://bugs.webkit.org/show_bug.cgi?id=37215

  • inspector/console-resource-errors-expected.txt: Added.
  • inspector/console-resource-errors.html: Added.

2010-04-14 Andrey Kosyakov <​caseq@chromium.ru>

Reviewed by Timothy Hatcher.

Log error message to inspector console if a resource fails to load.
Disable checking of mime-type consistency for failed resources.
​https://bugs.webkit.org/show_bug.cgi?id=37215

Test: inspector/console-resource-errors.html

  • inspector/InspectorController.cpp: (WebCore::InspectorController::didReceiveResponse): (WebCore::InspectorController::didFailLoading):
  • inspector/front-end/Resource.js: (WebInspector.Resource.prototype._mimeTypeIsConsistentWithType):
  • inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel.prototype.recreateViewForResourceIfNeeded):
2:38 PM Changeset in webkit [57608] by eric@webkit.org
  • 5 edits in trunk/JavaScriptCore

2010-04-14 Peter Varga <​pvarga@inf.u-szeged.hu>

Reviewed by Geoffrey Garen.

Move the YARR JIT fallback detection from RegexJIT.cpp to
RegexCompiler.cpp.

​https://bugs.webkit.org/show_bug.cgi?id=37571

  • yarr/RegexCompiler.cpp: (JSC::Yarr::RegexPatternConstructor::atomBackReference): (JSC::Yarr::RegexPatternConstructor::quantifyAtom):
  • yarr/RegexJIT.cpp: (JSC::Yarr::RegexGenerator::generateTerm): (JSC::Yarr::RegexGenerator::RegexGenerator): (JSC::Yarr::jitCompileRegex):
  • yarr/RegexJIT.h: (JSC::Yarr::RegexCodeBlock::operator!):
  • yarr/RegexPattern.h: (JSC::Yarr::RegexPattern::RegexPattern): (JSC::Yarr::RegexPattern::reset):
2:24 PM Changeset in webkit [57607] by alex
  • 2 edits in trunk/LayoutTests

2010-04-14 Alejandro G. Castro <​alex@igalia.com>

Rubber-stamped by Xan Lopez.

Skipping printing/page-break-always.html
​https://bugs.webkit.org/show_bug.cgi?id=37607

  • platform/gtk/Skipped:
2:10 PM Changeset in webkit [57606] by eric@webkit.org
  • 6 edits
    1 delete in trunk

2010-04-14 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r57599.
​http://trac.webkit.org/changeset/57599
​https://bugs.webkit.org/show_bug.cgi?id=37605

"Broke Chromium build" (Requested by dglazkov on #webkit).

  • platform/chromium/PopupMenuChromium.cpp: (WebCore::PopupContainer::PopupContainer): (WebCore::PopupContainer::showPopup): (WebCore::PopupContainer::notifyPopupHidden):
  • platform/chromium/PopupMenuChromium.h:

2010-04-14 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r57599.
​http://trac.webkit.org/changeset/57599
​https://bugs.webkit.org/show_bug.cgi?id=37605

"Broke Chromium build" (Requested by dglazkov on #webkit).

  • WebKit.gyp:
  • src/WebViewImpl.h:
  • tests/PopupMenuTest.cpp: Removed.
2:08 PM Changeset in webkit [57605] by weinig@apple.com
  • 3 edits
    2 adds in trunk/WebKit2

Add WKRetainPtr helper class as private header
​https://bugs.webkit.org/show_bug.cgi?id=37603

Reviewed by Anders Carlsson.

WKRetainPtr is just like RetainPtr, but works for WK types instead of
CF/NS types.

  • UIProcess/API/cpp: Added.
  • UIProcess/API/cpp/WKRetainPtr.h: Added.
  • WebKit2.xcodeproj/project.pbxproj: Add new file.
  • win/WebKit2.vcproj: Ditto.
1:51 PM Changeset in webkit [57604] by aa@chromium.org
  • 10 edits in trunk

2010-04-14 Aaron Boodman <​aa@chromium.org>

Reviewed by David Levin.

Support relative URLs for notifications on Chromium. They weren't working previously because WebCore was inserting
the relative URL into a KURL instance, but when KURL is backed by GURL as it is on Chromium, relative URLs are
unsupported. Fixed by resolving the relative URL first.

​https://bugs.webkit.org/show_bug.cgi?id=36623

Adding tests for this is difficult because we don't currently have DRT support for notifications on Mac, only Windows.

  • notifications/Notification.cpp: (WebCore::Notification::Notification): Accept resolved KURL instead of relative string.
  • notifications/Notification.h: (WebCore::Notification::create): Ditto. (WebCore::Notification::iconURL): Return resolved KURL instead of relative string.
  • notifications/NotificationCenter.h: (WebCore::NotificationCenter::createHTMLNotification): Immediately resolve URL instead of passing off relative string. (WebCore::NotificationCenter::createNotification): Ditto.
  • notifications/NotificationContents.h: (WebCore::NotificationContents::NotificationContents): Accept resolved KURL instead of relative string. (WebCore::NotificationContents::icon): Return resolved URL.

2010-04-14 Aaron Boodman <​aa@chromium.org>

Reviewed by David Levin.

Support relative URLs for notifications on Chromium. They weren't working previously because WebCore was inserting
the relative URL into a KURL instance, but when KURL is backed by GURL as it is on Chromium, relative URLs are
unsupported. Fixed by resolving the relative URL first.

​https://bugs.webkit.org/show_bug.cgi?id=36623

Adding tests for this is difficult because we don't currently have DRT support for notifications on Mac, only Windows.

  • public/WebNotification.h: Remove deprecated icon() method.
  • src/WebNotification.cpp: Ditto.

2010-04-14 Aaron Boodman <​aa@chromium.org>

Reviewed by David Levin.

Support relative URLs for notifications on Chromium. They weren't working previously because WebCore was inserting
the relative URL into a KURL instance, but when KURL is backed by GURL as it is on Chromium, relative URLs are
unsupported. Fixed by resolving the relative URL first.

​https://bugs.webkit.org/show_bug.cgi?id=36623

Adding tests for this is difficult because we don't currently have DRT support for notifications on Mac, only Windows.

  • WebCoreSupport/NotificationPresenterClientQt.cpp: (NotificationPresenterClientQt::show): Return type of NotificationContents::iconURL() changed.
1:39 PM Changeset in webkit [57603] by andersca@apple.com
  • 3 edits in trunk/WebCore

2010-04-14 Anders Carlsson <​andersca@apple.com>

Reviewed by Sam Weinig.

Add ThemeMac::ensuredView and get rid of a workaround in ThemeMac::paintButton.
​https://bugs.webkit.org/show_bug.cgi?id=37601

  • platform/mac/ThemeMac.h:
  • platform/mac/ThemeMac.mm: (-[WebCoreFlippedView isFlipped]): (WebCore::paintButton): (WebCore::ThemeMac::ensuredView):
1:32 PM Changeset in webkit [57602] by bweinstein@apple.com
  • 2 edits
    2 adds in trunk/WebKitTools

Add a way for the buildbot to kill any old processes that are running. This
is useful because the Windows bots can get in states where a process remains
running (httpd.exe, DumpRenderTree.exe), which causes the bots to get in a red
state, and the processes must be killed manually.

Reviewed by Adam Roben.

  • BuildSlaveSupport/build.webkit.org-config/master.cfg: If we are on Windows, kill

the old processes that might be running.

  • BuildSlaveSupport/win/kill-old-processes: Added.
1:26 PM Changeset in webkit [57601] by weinig@apple.com
  • 3 edits in trunk/WebKit2

Make the WebProcess a LSUIElement to suppress its icon from the Dock.

Reviewed by Anders Carlsson.

  • WebKit2.xcodeproj/project.pbxproj:
  • WebProcess/Info.plist:
1:23 PM Changeset in webkit [57600] by weinig@apple.com
  • 4 edits in trunk/WebKitTools

Tear down WebKit more completely on window closing and application
termination. We still don't block application termination for pending
close, but this is a step in the right direction.

Reviewed by Anders Carlsson.

  • MiniBrowser/mac/AppDelegate.m:

(-[BrowserAppDelegate applicationWillTerminate:]):

  • MiniBrowser/mac/BrowserWindowController.h:
  • MiniBrowser/mac/BrowserWindowController.m:

(-[BrowserWindowController dealloc]):
(-[BrowserWindowController windowWillClose:]):
(-[BrowserWindowController applicationTerminating]):

1:21 PM Changeset in webkit [57599] by eric@webkit.org
  • 6 edits
    1 add in trunk

2010-04-14 Jay Civelli <​jcivelli@chromium.org>

Reviewed by Dimitri Glazkov.

[chromium] Select popups would assert when destroyed.
​https://bugs.webkit.org/show_bug.cgi?id=37436

  • platform/chromium/PopupMenuChromium.cpp: (WebCore::PopupContainer::PopupContainer): (WebCore::PopupContainer::showPopup): (WebCore::PopupContainer::notifyPopupHidden):
  • platform/chromium/PopupMenuChromium.h:

2010-04-14 Jay Civelli <​jcivelli@chromium.org>

Reviewed by Dimitri Glazkov.

[chromium] Select popups would assert when destroyed.
Also adding unit-tests for the select popup code.
​https://bugs.webkit.org/show_bug.cgi?id=37436

  • WebKit.gyp:
  • src/WebViewImpl.h: (WebKit::WebViewImpl::selectPopup):
  • tests/PopupMenuTest.cpp: Added.
1:18 PM Changeset in webkit [57598] by Adam Roben
  • 2 edits in trunk/LayoutTests

Skip xss-DENIED-iframe-src-alias.html on Windows

I thought that skipping this test was causing other http tests to time
out, but Brian Weinstein pointed out that the timing-out tests come
before this one so shouldn't be affected by it.

<​http://webkit.org/b/37096> tracks making this test not time out.

Rubber-stamped by Brian Weinstein.

  • platform/win/Skipped:
1:01 PM Changeset in webkit [57597] by eric@webkit.org
  • 1 edit
    3 adds in trunk/LayoutTests

2010-04-14 Darin Fisher <​darin@chromium.org>

Reviewed by Adam Barth.

Add tests for ipv6 address canonicalization.
​https://bugs.webkit.org/show_bug.cgi?id=37583

  • fast/url/ipv6-expected.txt: Added.
  • fast/url/ipv6.html: Added.
  • fast/url/script-tests/ipv6.js: Added.
12:44 PM PythonGuidelines edited by Chris Jerdonek
Clarified suggested import ordering style guideline. (diff)
12:42 PM Changeset in webkit [57596] by andersca@apple.com
  • 3 edits in trunk/WebKit2

2010-04-14 Anders Carlsson <​andersca@apple.com>

Reviewed by Sam Weinig.

Factor code to paint into an update chunk out into a separate function.
​https://bugs.webkit.org/show_bug.cgi?id=37594

  • WebProcess/WebPage/mac/DrawingAreaUpdateChunk.cpp: (WebKit::DrawingAreaUpdateChunk::paintIntoUpdateChunk): (WebKit::DrawingAreaUpdateChunk::display): (WebKit::DrawingAreaUpdateChunk::setSize):
  • WebProcess/WebPage/mac/DrawingAreaUpdateChunk.h:
12:24 PM Changeset in webkit [57595] by dumi@chromium.org
  • 2 edits in trunk/WebCore

Remove an incorrect ASSERT in UniscribeHelper::draw().
​https://bugs.webkit.org/show_bug.cgi?id=37533

Reviewed by Jian Li.

  • platform/graphics/chromium/UniscribeHelper.cpp:

(WebCore::UniscribeHelper::draw):

11:56 AM Changeset in webkit [57594] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-04-14 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: readline shortcuts don't work in Chromium.

  • inspector/front-end/TextPrompt.js: (WebInspector.TextPrompt.prototype._onKeyDown): (WebInspector.TextPrompt.prototype._moveCaretToStartOfPrompt):
11:45 AM Changeset in webkit [57593] by alex
  • 2 edits in trunk/LayoutTests

2010-04-14 Alejandro G. Castro <​alex@igalia.com>

Rubber-stamped by Xan Lopez.

Skipping printing/page-break-always-for-overflow.html
​https://bugs.webkit.org/show_bug.cgi?id=37592

  • platform/gtk/Skipped:
11:42 AM Changeset in webkit [57592] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-04-14 Alexander Pavlov <​apavlov@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: Console: Shift-Tab does not cycle autocompletions in the reverse order
​https://bugs.webkit.org/show_bug.cgi?id=37582

  • inspector/front-end/TextPrompt.js: (WebInspector.TextPrompt.prototype.complete): (WebInspector.TextPrompt.prototype._completionsReady): (WebInspector.TextPrompt.prototype._tabKeyPressed):
11:30 AM Changeset in webkit [57591] by eric@webkit.org
  • 8 edits in trunk

2010-04-14 Jeff Schiller <​codedread@gmail.com>

Reviewed by Dirk Schulze.

Update path parser test for Bug 37413: ​https://bugs.webkit.org/show_bug.cgi?id=37413
now that all path segments render up until the first error

  • platform/mac/svg/custom/path-bad-data-expected.txt: updated path segments that render
  • svg/custom/path-bad-data.svg: updated test to ensure reference image is the same
  • svg/dom/fuzz-path-parser-expected.txt: updated path segments that render
  • svg/dom/path-parser-expected.txt: updated path segments that render
  • svg/dom/script-tests/path-parser.js: changed expected results for path segments that render ():

2010-04-14 Jeff Schiller <​codedread@gmail.com>

Reviewed by Dirk Schulze.

Render SVG Paths up to first error, bug 37413: ​https://bugs.webkit.org/show_bug.cgi?id=37413

  • svg/SVGParserUtilities.cpp: (WebCore::SVGPathSegListBuilder::build):
11:18 AM Changeset in webkit [57590] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-04-14 Alexander Pavlov <​apavlov@chromium.org>

Reviewed by Joseph Pecoraro.

Web Inspector: Ctrl-L (Clear History) does nothing on Windows
​https://bugs.webkit.org/show_bug.cgi?id=37579

  • inspector/front-end/ConsoleView.js: (WebInspector.ConsoleView):
10:51 AM Changeset in webkit [57589] by alex
  • 2 edits in trunk/LayoutTests

2010-04-14 Alejandro G. Castro <​alex@igalia.com>

Rubber-stamped by Xan Lopez.

Skipping printing/numberOfPages.html
​https://bugs.webkit.org/show_bug.cgi?id=37585

  • platform/gtk/Skipped:
10:42 AM Changeset in webkit [57588] by eric@webkit.org
  • 1 edit
    3 adds in trunk/LayoutTests

2010-04-14 Adam Barth <​abarth@webkit.org>

Reviewed by Darin Fisher.

Add port URL tests
​https://bugs.webkit.org/show_bug.cgi?id=37524

This went pretty well.

  • fast/url/port-expected.txt: Added.
  • fast/url/port.html: Added.
  • fast/url/script-tests/port.js: Added.
10:27 AM Changeset in webkit [57587] by eric@webkit.org
  • 5 edits
    1 copy in trunk/WebKitTools

2010-04-14 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Use pretty patch for confirming webkit-patch diffs
​https://bugs.webkit.org/show_bug.cgi?id=37489

  • Scripts/webkitpy/common/prettypatch.py: Added.
  • Scripts/webkitpy/tool/commands/download_unittest.py:
  • Scripts/webkitpy/tool/commands/upload_unittest.py:
  • Scripts/webkitpy/tool/mocktool.py:
  • Scripts/webkitpy/tool/steps/confirmdiff.py:
10:16 AM Changeset in webkit [57586] by eric@webkit.org
  • 1 edit
    3 adds in trunk/LayoutTests

2010-04-14 Adam Barth <​abarth@webkit.org>

Reviewed by Darin Fisher.

Add LayoutTests for parsing "path" URLs
​https://bugs.webkit.org/show_bug.cgi?id=37581

  • fast/url/path-url-expected.txt: Added.
  • fast/url/path-url.html: Added.
  • fast/url/script-tests/path-url.js: Added.
10:06 AM Changeset in webkit [57585] by eric@webkit.org
  • 1 edit
    3 adds in trunk/LayoutTests

2010-04-14 Adam Barth <​abarth@webkit.org>

Reviewed by Darin Fisher.

Add LayoutTests for parsing standard URLs
​https://bugs.webkit.org/show_bug.cgi?id=37580

  • fast/url/script-tests/standard-url.js: Added.
  • fast/url/standard-url-expected.txt: Added.
  • fast/url/standard-url.html: Added.
9:39 AM Changeset in webkit [57584] by Adam Roben
  • 2 edits in trunk/LayoutTests

Roll out r57566

It seems to have caused other http tests to hang on Windows.

  • platform/win/Skipped:
9:26 AM Changeset in webkit [57583] by eric@webkit.org
  • 2 edits in trunk/JavaScriptCore

2010-04-14 Kent Hansen <​kent.hansen@nokia.com>

Reviewed by Maciej Stachowiak.

Mac OS X: Use deployment target to determine whether memory tagging should be enabled
​https://bugs.webkit.org/show_bug.cgi?id=34888

When building on (Snow) Leopard but targeting Tiger
(TARGETING_TIGER defined, BUILDING_ON_TIGER not defined),
WebKit would crash on Tiger because the tags passed to mmap
caused those function calls to fail.

Conversely, when building on Tiger but targeting Leopard
(BUILDING_ON_TIGER defined, TARGETING_LEOPARD defined), WebKit
would crash on Leopard because the tags passed to vm_map and
vm_allocate caused those function calls to fail.

Solution: Use TARGETING_TIGER rather than BUILDING_ON_TIGER to
govern the tag definitions. Use the same tags for vm_map and
vm_allocate regardless of target, since they work on
both. Fall back to the mmap tags that work on Tiger (that is,
"no tags") if targeting Tiger, since those tags also work on
Leopard.

  • wtf/VMTags.h:
9:17 AM WebInspector edited by apavlov@chromium.org
Fix column title, add Chrome/Chromium-specific shortcuts (diff)
9:08 AM Changeset in webkit [57582] by antonm@chromium.org
  • 2 edits in trunk/LayoutTests

2010-04-14 Anton Muhin <​antonm@chromium.org>

Reviewed by David Levin.

Skip some and add test expectations for other layout tests which started to fail
against Chromium after ​http://trac.webkit.org/changeset/57535/

  • platform/chromium/test_expectations.txt:
8:48 AM WebInspector edited by apavlov@chromium.org
Add Win/Linux shortcuts (diff)
8:19 AM QtWebKitTableOfFeatures20 edited by Henry Haverinen
(diff)
8:10 AM QtWebKitTableOfFeatures20 edited by Henry Haverinen
(diff)
8:07 AM QtWebKitTableOfFeatures20 edited by Henry Haverinen
(diff)
8:02 AM QtWebKitTableOfFeatures20 edited by Henry Haverinen
(diff)
7:56 AM Changeset in webkit [57581] by Nikolas Zimmermann
  • 2 edits in trunk/LayoutTests

2010-04-14 Nikolas Zimmermann <​nzimmermann@rim.com>

Not reviewed. Skipping another crash on the 64bit Gtk slave.

  • platform/gtk/Skipped:
7:52 AM Changeset in webkit [57580] by alex
  • 2 edits in trunk/LayoutTests

2010-04-14 Alejandro G. Castro <​alex@igalia.com>

Rubber-stamped by Xan Lopez.

Skipping plugins/open-and-close-window-with-plugin.html
​https://bugs.webkit.org/show_bug.cgi?id=37572

Skipping media/video-played-ranges-1.html
​https://bugs.webkit.org/show_bug.cgi?id=37573

  • platform/gtk/Skipped:
7:45 AM QtWebKitTableOfFeatures20 edited by Henry Haverinen
(diff)
7:25 AM QtWebKitTableOfFeatures20 edited by Henry Haverinen
(diff)
7:12 AM Changeset in webkit [57579] by antonm@chromium.org
  • 26 edits
    147 adds
    1 delete in trunk/LayoutTests/platform

Not reviewed.

BUG=​http://code.google.com/p/chromium/issues/detail?id=41450

6:49 AM QtWebKitTableOfFeatures20 edited by Henry Haverinen
(diff)
5:12 AM Changeset in webkit [57578] by antonm@chromium.org
  • 2 edits in trunk/WebCore

2010-04-14 Anton Muhin <​antonm@chromium.org>

Not review, build fix.

Add <limits.h> include to bring UINT_MAX.

  • html/canvas/WebGLArray.h:
4:11 AM Changeset in webkit [57577] by eric@webkit.org
  • 2 edits in trunk/LayoutTests

2010-04-14 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r57573.
​http://trac.webkit.org/changeset/57573
​https://bugs.webkit.org/show_bug.cgi?id=37569

Revert r57573 which unskipped http/tests/media/video-
cookie.html on SnowLeopard Intel Release (Tests). Let's get a
core builder back to green again. (Requested by WildFox on
#webkit).

  • platform/mac/Skipped:
4:00 AM Changeset in webkit [57576] by Nikolas Zimmermann
  • 2 edits in trunk/WebCore

2010-04-14 Nikolas Zimmermann <​nzimmermann@rim.com>

Not reviewed. Attempt to unbreak build - NodeRenderStyle.h is an _interessting_ concept...

  • rendering/style/SVGRenderStyle.cpp: Include 'NodeRenderStyle.h'
3:44 AM Changeset in webkit [57575] by Nikolas Zimmermann
  • 14 edits in trunk/WebCore

2010-04-14 Nikolas Zimmermann <​nzimmermann@rim.com>

Reviewed by Dirk Schulze.

SVGRenderStyle/SVGRenderStyleDefs needs a cleanup
​https://bugs.webkit.org/show_bug.cgi?id=37568

Cleanup SVGRenderStyle / SVGRenderStyleDefs:

  • use copy constructors in initialization list to initialize members, instead of assignment operators in the body
  • fix style issues (misplaced references, abbrevations)
  • merge StyleClipData/StyleMaskData to save memory, rename it StyleResourceData
  • move filter property in StyleResourceData
  • rename StyleMarkerData to StyleInheritedResourceData to highlight the difference to StyleResourceData
  • unify naming schemes for all resources (filter/clipper/masker/markers)
    • clipPath() -> clipperResource()
    • maskElement() -> maskerResource()
    • startMarker() -> markerStartResource()
    • midMarker() -> markerMidResource()
    • endMarker() -> markerEndResource()
    • filter() -> filterResource()

Adapt all callsites to the renames above.
No new tests, as this doesn't affect anything except memory overhead.

  • css/SVGCSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::getSVGPropertyCSSValue):
  • css/SVGCSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applySVGProperty):
  • rendering/RenderPath.cpp: (WebCore::RenderPath::calculateMarkerBoundsIfNeeded):
  • rendering/RenderSVGContainer.cpp: (WebCore::RenderSVGContainer::selfWillPaint):
  • rendering/RenderSVGRoot.cpp: (WebCore::RenderSVGRoot::selfWillPaint):
  • rendering/SVGRenderSupport.cpp: (WebCore::SVGRenderBase::prepareToRenderSVGContent): (WebCore::SVGRenderBase::filterBoundingBoxForRenderer): (WebCore::SVGRenderBase::clipperBoundingBoxForRenderer): (WebCore::SVGRenderBase::maskerBoundingBoxForRenderer): (WebCore::deregisterFromResources):
  • rendering/SVGRenderTreeAsText.cpp: (WebCore::writeStyle): (WebCore::writeResources):
  • rendering/style/SVGRenderStyle.cpp: (WebCore::SVGRenderStyle::SVGRenderStyle): (WebCore::SVGRenderStyle::operator==): (WebCore::SVGRenderStyle::inheritedNotEqual): (WebCore::SVGRenderStyle::inheritFrom):
  • rendering/style/SVGRenderStyle.h:
  • rendering/style/SVGRenderStyleDefs.cpp: (WebCore::StyleFillData::StyleFillData): (WebCore::StyleFillData::operator==): (WebCore::StyleStrokeData::StyleStrokeData): (WebCore::StyleStrokeData::operator==): (WebCore::StyleStopData::StyleStopData): (WebCore::StyleStopData::operator==): (WebCore::StyleTextData::StyleTextData): (WebCore::StyleMiscData::StyleMiscData): (WebCore::StyleMiscData::operator==): (WebCore::StyleShadowSVGData::StyleShadowSVGData): (WebCore::StyleShadowSVGData::operator==): (WebCore::StyleResourceData::StyleResourceData): (WebCore::StyleResourceData::operator==): (WebCore::StyleInheritedResourceData::StyleInheritedResourceData): (WebCore::StyleInheritedResourceData::operator==):
  • rendering/style/SVGRenderStyleDefs.h: (WebCore::StyleFillData::operator!=): (WebCore::StyleStopData::operator!=): (WebCore::StyleMiscData::create): (WebCore::StyleMiscData::copy): (WebCore::StyleMiscData::operator!=): (WebCore::StyleShadowSVGData::create): (WebCore::StyleShadowSVGData::copy): (WebCore::StyleShadowSVGData::operator!=): (WebCore::StyleResourceData::create): (WebCore::StyleResourceData::copy): (WebCore::StyleResourceData::operator!=): (WebCore::StyleInheritedResourceData::create): (WebCore::StyleInheritedResourceData::copy): (WebCore::StyleInheritedResourceData::operator!=):
  • svg/SVGDocumentExtensions.cpp: (WebCore::SVGDocumentExtensions::addResource): (WebCore::SVGDocumentExtensions::removeResource):
  • svg/SVGDocumentExtensions.h:
  • svg/SVGStyledElement.cpp: (WebCore::SVGStyledElement::invalidateResources):
3:23 AM Changeset in webkit [57574] by eric@webkit.org
  • 9 edits
    2 adds in trunk

2010-04-14 Zhenyao Mo <​zmo@google.com>

Reviewed by Dimitri Glazkov.

readPixels must take PACK_ALIGNMENT into account
​https://bugs.webkit.org/show_bug.cgi?id=34718

  • fast/canvas/webgl/read-pixels-expected.txt: Verify pixelStorei and readPixels.
  • fast/canvas/webgl/read-pixels.html: Ditto.

2010-04-14 Zhenyao Mo <​zmo@google.com>

Reviewed by Dimitri Glazkov.

readPixels must take PACK_ALIGNMENT into account
​https://bugs.webkit.org/show_bug.cgi?id=34718

Test: fast/canvas/webgl/read-pixels.html

  • html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::WebGLRenderingContext): Init members to support pack_alignment. (WebCore::WebGLRenderingContext::pixelStorei): Save pack/unpack_alignment. (WebCore::WebGLRenderingContext::readPixels): Validate enum and deal with pack_alignment.
  • html/canvas/WebGLRenderingContext.h: Add members to support pack_alignment.
  • platform/graphics/GraphicsContext3D.h: Refactor readPixels.
  • platform/graphics/mac/GraphicsContext3DMac.cpp: (WebCore::GraphicsContext3D::readPixels): Move array allocation and alpha fix to WebGLRenderingContext; flush before read pixels.

2010-04-14 Zhenyao Mo <​zmo@google.com>

Reviewed by Dimitri Glazkov.

readPixels must take PACK_ALIGNMENT into account
​https://bugs.webkit.org/show_bug.cgi?id=34718

  • src/GraphicsContext3D.cpp: Refactor readPixels.
  • src/WebGraphicsContext3DDefaultImpl.cpp: (WebKit::WebGraphicsContext3DDefaultImpl::readBackFramebuffer): Temporarily disable pack alignment for glReadPixels. (WebKit::WebGraphicsContext3DDefaultImpl::readPixels): Move array allocation and alpha fix to WebGLRenderingContext; flush before read pixels.
3:11 AM Changeset in webkit [57573] by eric@webkit.org
  • 2 edits in trunk/LayoutTests

2010-04-14 Nicolas Weber <​thakis@chromium.org>

Reviewed by Gustavo Noronha Silva.

Remove passing test from Skipped list.
​https://bugs.webkit.org/show_bug.cgi?id=34287

  • platform/mac/Skipped: video-cookie.html seems to be passing, so remove it from Skipped list.
2:00 AM Changeset in webkit [57572] by eric@webkit.org
  • 6 edits in trunk/WebKitTools

2010-04-14 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Teach webkit-patch how to handle revisions missing ChangeLogs
​https://bugs.webkit.org/show_bug.cgi?id=37519

Make commit_info_for_revision return None when revision
is missing a ChangeLog. Previously we would throw an array index
exception.
Teach callers how to handle None.

  • Scripts/webkitpy/common/checkout/api.py:
  • Scripts/webkitpy/common/checkout/api_unittest.py:
  • Scripts/webkitpy/tool/commands/download.py:
  • Scripts/webkitpy/tool/commands/queries.py:
  • Scripts/webkitpy/tool/commands/sheriffbot.py:
1:51 AM Changeset in webkit [57571] by eric@webkit.org
  • 2 edits in trunk/WebKit/chromium

2010-04-14 Mikhail Naganov <​mnaganov@chromium.org>

Reviewed by Pavel Feldman.

Re-write testProfilerTab to match the new implementation.

​https://bugs.webkit.org/show_bug.cgi?id=37516

  • src/js/Tests.js: (.TestSuite.prototype.testProfilerTab.findDisplayedNode): (.TestSuite.prototype.testProfilerTab.findVisibleView): (.TestSuite.prototype.testProfilerTab):
12:34 AM Changeset in webkit [57570] by alex
  • 2 edits in trunk/LayoutTests

2010-04-14 Alejandro G. Castro <​alex@igalia.com>

Rubber-stamped by Xan Lopez.

Skipping media/audio-data-url.html
​https://bugs.webkit.org/show_bug.cgi?id=37564

  • platform/gtk/Skipped:
12:15 AM Changeset in webkit [57569] by alex
  • 2 edits in trunk/LayoutTests

2010-04-14 Alejandro G. Castro <​alex@igalia.com>

Rubber-stamped by Xan Lopez.

Skipping plugins/update-widgets-crash.html
​https://bugs.webkit.org/show_bug.cgi?id=37562

  • platform/gtk/Skipped:
12:03 AM Changeset in webkit [57568] by alex
  • 2 edits in trunk/LayoutTests

2010-04-13 Alejandro G. Castro <​alex@igalia.com>

Rubber-stamped by Xan Lopez.

Skipping media/video-seeking.html
​https://bugs.webkit.org/show_bug.cgi?id=37551

Skipping media/video-timeupdate-reverse-play.html
​https://bugs.webkit.org/show_bug.cgi?id=37552

Skipping media/video-played-reset.html
​https://bugs.webkit.org/show_bug.cgi?id=37556

Skipping http/tests/misc/image-blocked-src-change.html
​https://bugs.webkit.org/show_bug.cgi?id=37557

Skipping inspector/console-clear.html
​https://bugs.webkit.org/show_bug.cgi?id=37558

Skipping inspector/console-format-collections.html
​https://bugs.webkit.org/show_bug.cgi?id=37559

Skipping svg/dom/SVGScriptElement/script-set-href.svg
​https://bugs.webkit.org/show_bug.cgi?id=37560

  • platform/gtk/Skipped:
Note: See TracTimeline for information about the timeline view.