Context Navigation

← Previous Period
Next Period →

Timeline

Apr 17, 2010:

11:27 PM Changeset in webkit [57791] by abarth@webkit.org

1 edit
1 add in trunk/WebKitSite

2010-04-17 Adam Barth <abarth@webkit.org>

Unreviewed. Added loader diagram for upcoming blog post.

blog-files/loader-diagram.svg: Added.

11:03 PM Changeset in webkit [57790] by ap@apple.com

8 edits in trunk

Reviewed by Adam Barth.

https://bugs.webkit.org/show_bug.cgi?id=37720
<rdar://problem/7873752> HTMLFrameSetElement-window-eventListener-attributes.html sometimes
crashes on SnowLeopard Release

Tests:

fast/dom/Window/HTMLBodyElement-window-eventListener-attributes.html:
fast/dom/Window/HTMLFrameSetElement-window-eventListener-attributes.html:

bindings/scripts/CodeGeneratorJS.pm: Use global object as a wrapper for window event listeners set via document.body. The body wrapper can go away if nothing else references it.

html/HTMLBodyElement.idl: Override listeners that exist on Element with custom implementations, because we need to use window object as a wrapper, not the element. Marked all window event listeners as such for code generator.

html/HTMLFrameSetElement.idl: Ditto.

10:00 PM Changeset in webkit [57789] by Joseph Pecoraro

2 edits in trunk/WebCore

2010-04-17 Juan C. Montemayor <jmonte03@cs.tufts.edu>

Reviewed by Joseph Pecoraro.

Databases pane doesn't recognize table creation/deletion
https://bugs.webkit.org/show_bug.cgi?id=20219

inspector/front-end/DatabaseQueryView.js: (WebInspector.DatabaseQueryView.prototype._queryFinished):

5:42 PM Changeset in webkit [57788] by eric@webkit.org

13 edits
2 deletes in trunk/WebKitTools

2010-04-17 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Remove steps_references and commands_references
https://bugs.webkit.org/show_bug.cgi?id=37758

We tried using the mumble_references convention to manage our
dependencies, but it doesn't seem to be providing much value for the
steps and commands module because these modules are small pieces of the
larger tool module. In this patch, I've removed the references file
for these modules.

I've left the style_references file for the style module because that
module seems better isolated from the rest of webkitpy and the
style_references file appears to be providing some value.

Scripts/webkitpy/tool/commands/commandtest.py:
Scripts/webkitpy/tool/commands/download_unittest.py:
Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
Scripts/webkitpy/tool/commands/queries_unittest.py:
Scripts/webkitpy/tool/commands/queues_unittest.py:
Scripts/webkitpy/tool/commands/queuestest.py:
Scripts/webkitpy/tool/commands/upload.py:
Scripts/webkitpy/tool/commands/upload_unittest.py:
Scripts/webkitpy/tool/commands_references.py: Removed.
Scripts/webkitpy/tool/steps/closebugforlanddiff_unittest.py:
Scripts/webkitpy/tool/steps/steps_unittest.py:
Scripts/webkitpy/tool/steps/updatechangelogswithreview_unittest.py:
Scripts/webkitpy/tool/steps/validatereviewer_unittest.py:
Scripts/webkitpy/tool/steps_references.py: Removed.

1:43 PM Changeset in webkit [57787] by eric@webkit.org

7 edits in trunk/WebCore

2010-04-17 Yaar Schnitman <yaar@chromium.org>

Reviewed by Adam Barth.

Auto-generate V8 bindings for canvas.* overloads
https://bugs.webkit.org/show_bug.cgi?id=37453

bindings/v8/custom/V8CanvasRenderingContext2DCustom.cpp: Deleted custom code that is now auto-generated.
bindings/scripts/CodeGeneratorV8.pm: Not generating custom signatures for overloaded methods and accepting Object as a string input.
html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::drawImage): Added missing 9-arguments overloads for drawImage.
html/canvas/CanvasRenderingContext2D.h:
html/canvas/CanvasRenderingContext2D.idl: Overloaded methods defined (V8 only).

1:10 PM Changeset in webkit [57786] by eric@webkit.org

2 edits
1 copy
2 adds in trunk/LayoutTests

2010-04-17 Adam Barth <abarth@webkit.org>

Unreviewed.

Test file: URL canonicalization
https://bugs.webkit.org/show_bug.cgi?id=37700

Re-land http://trac.webkit.org/changeset/57719, hopefully not breaking
the Windows bot this time.

fast/url/file-expected.txt: Added.
fast/url/file.html: Added.
fast/url/mailto.html:
fast/url/script-tests/file.js: Added.

1:00 PM Changeset in webkit [57785] by eric@webkit.org

1 edit
9 adds in trunk/LayoutTests

2010-04-17 Adam Barth <abarth@webkit.org>

Unreviewed, but I took Jeremy Orlow's suggestions on an earlier
iteration of this patch.

Add URL parsing tests for relative URL resolution
https://bugs.webkit.org/show_bug.cgi?id=37644

I've split the platform specific parts of this test into separate
files. On KURL-based ports these should have the same results on every
platform. We can decide whether to have platform-specific behavior at
a later time.

fast/url/relative-expected.txt: Added.
fast/url/relative-unix-expected.txt: Added.
fast/url/relative-unix.html: Added.
fast/url/relative-win-expected.txt: Added.
fast/url/relative-win.html: Added.
fast/url/relative.html: Added.
fast/url/script-tests/relative-unix.js: Added.
fast/url/script-tests/relative-win.js: Added.
fast/url/script-tests/relative.js: Added.

11:42 AM Changeset in webkit [57784] by eric@webkit.org

9 edits
2 moves in trunk/WebCore

2010-04-17 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: move JavaScriptCallFrame.{h,cpp} to WebCore/bindings/js

https://bugs.webkit.org/show_bug.cgi?id=37740

GNUmakefile.am:
WebCore.gypi:
WebCore.pro:
WebCore.vcproj/WebCore.vcproj:
WebCore.xcodeproj/project.pbxproj:
bindings/js/JSBindingsAllInOne.cpp:
bindings/js/JavaScriptCallFrame.cpp: Renamed from WebCore/inspector/JavaScriptCallFrame.cpp. (WebCore::JavaScriptCallFrame::JavaScriptCallFrame): (WebCore::JavaScriptCallFrame::caller): (WebCore::JavaScriptCallFrame::scopeChain): (WebCore::JavaScriptCallFrame::dynamicGlobalObject): (WebCore::JavaScriptCallFrame::functionName): (WebCore::JavaScriptCallFrame::type): (WebCore::JavaScriptCallFrame::thisObject): (WebCore::JavaScriptCallFrame::evaluate):
bindings/js/JavaScriptCallFrame.h: Renamed from WebCore/inspector/JavaScriptCallFrame.h. (WebCore::JavaScriptCallFrame::create): (WebCore::JavaScriptCallFrame::invalidate): (WebCore::JavaScriptCallFrame::isValid): (WebCore::JavaScriptCallFrame::sourceID): (WebCore::JavaScriptCallFrame::line): (WebCore::JavaScriptCallFrame::update):
inspector/InjectedScriptHost.h:
inspector/InspectorController.h:

9:00 AM Changeset in webkit [57783] by alex

2 edits in trunk/LayoutTests

2010-04-17 Alejandro G. Castro <alex@igalia.com>

Rubber-stamped by Xan Lopez.

Skipping media/audio-constructor-preload.html
https://bugs.webkit.org/show_bug.cgi?id=37753

platform/gtk/Skipped:

8:49 AM Changeset in webkit [57782] by alex

2 edits in trunk/LayoutTests

2010-04-17 Alejandro G. Castro <alex@igalia.com>

Rubber-stamped by Xan Lopez.

Skipping inspector/timeline-paint.html
https://bugs.webkit.org/show_bug.cgi?id=37752

platform/gtk/Skipped:

8:16 AM Changeset in webkit [57781] by alex

2 edits in trunk/WebKit/gtk

2010-04-17 Alejandro G. Castro <alex@igalia.com>

Reviewed by Xan Lopez.

We have to initialize the timer attribute after destroying it, not
doing it was causing crashes in some situations.

webkit/webkitdownload.cpp: (webkit_download_finalize):

7:55 AM Changeset in webkit [57780] by eric@webkit.org

5 edits
3 adds in trunk

2010-04-17 Vangelis Kokkevis <vangelis@chromium.org>

Reviewed by Dimitri Glazkov.

Adding definition of GLES2Context class.
https://bugs.webkit.org/show_bug.cgi?id=37541

No new functionality implemented yet, no tests.

WebCore.gypi: Added GLES2Context.h
platform/chromium/GLES2Context.h: Added.

2010-04-17 Vangelis Kokkevis <vangelis@chromium.org>

Reviewed by Dimitri Glazkov.

Adding the implementation of GLES2Context class which provides WebCore access to a GL ES context.
https://bugs.webkit.org/show_bug.cgi?id=37541

WebKit.gyp:
public/WebGLES2Context.h: Added. (WebKit::WebGLES2Context::~WebGLES2Context):
src/GLES2Context.cpp: Added. (WebCore::GLES2ContextInternal::GLES2ContextInternal): (WebCore::GLES2ContextInternal::~GLES2ContextInternal): (WebCore::GLES2ContextInternal::getWebGLES2Context): (WebCore::GLES2ContextInternal::initialize): (WebCore::GLES2Context::create): (WebCore::GLES2Context::~GLES2Context): (WebCore::GLES2Context::initialize): (WebCore::GLES2Context::makeCurrent): (WebCore::GLES2Context::destroy): (WebCore::GLES2Context::swapBuffers):

6:37 AM Changeset in webkit [57779] by jchaffraix@webkit.org

3 edits
3 adds in trunk

Crash while handling SVG font in the wrong namespace imported with @font-face
https://bugs.webkit.org/show_bug.cgi?id=18862

Reviewed by Darin Adler.

WebCore:

Test: fast/invalid/invalidSVGFont.html

loader/CachedFont.cpp:

(WebCore::CachedFont::getSVGFontById): Make sure we really get an SVGFontElement by using
getElementsByNameNS: the element factory chooses which element to create based on both
localName and namespace.

LayoutTests:

Test that load an SVG document not in the SVG namespace with @font-face does not
lead to a crash.

fast/invalid/invalidSVGFont-expected.txt: Added.
fast/invalid/invalidSVGFont.html: Added.
fast/invalid/resources/svgFontWrongNamespace.svg: Added.

1:13 AM Changeset in webkit [57778] by eric@webkit.org

2 edits in trunk/WebKitTools

2010-04-17 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

WebKit needs a Chromium Mac EWS Builder
https://bugs.webkit.org/show_bug.cgi?id=37742

Scripts/webkitpy/tool/commands/earlywarningsystem.py:

1:02 AM Changeset in webkit [57777] by abarth@webkit.org

2 edits in trunk/WebKitTools

2010-04-17 Adam Barth <abarth@webkit.org>

Fix expected results for unit test broken by
http://trac.webkit.org/changeset/57772

Scripts/webkitpy/common/net/buildbot_unittest.py:

Apr 16, 2010:

11:14 PM Changeset in webkit [57776] by Csaba Osztrogonác

4 edits in trunk

Unreviewed, rolling out r57770.
http://trac.webkit.org/changeset/57770
https://bugs.webkit.org/show_bug.cgi?id=37746

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2010-04-16
8 test cases crashed (Requested by Ossy on #webkit).

WebCore:

platform/graphics/qt/GraphicsLayerQt.cpp:

(WebCore::AnimationQtBase::AnimationQtBase):
(WebCore::TransformAnimationQt::~TransformAnimationQt):
(WebCore::TransformAnimationQt::applyFrame):
(WebCore::OpacityAnimationQt::applyFrame):
(WebCore::GraphicsLayerQt::addAnimation):

LayoutTests:

platform/qt/Skipped:

9:40 PM Changeset in webkit [57775] by dbates@webkit.org

11 edits
2 adds in trunk/WebCore

2010-04-16 Daniel Bates <dbates@rim.com>

Reviewed by Adam Treat.

https://bugs.webkit.org/show_bug.cgi?id=36312

Adds support for the viewport meta tag. The code is largely derived in whole
or in part from the WebCore-528.15 source published as part of the iPhone 3.1.3
source code <http://www.opensource.apple.com/source/WebCore/WebCore-528.15/>.

Android.mk: Added file ViewportArguments.cpp.
GNUmakefile.am: Added files ViewportArguments.cpp and ViewportArguments.h.
WebCore.gypi: Ditto.
WebCore.pro: Ditto.
WebCore.vcproj/WebCore.vcproj: Ditto.
WebCore.xcodeproj/project.pbxproj: Ditto.
dom/Document.cpp: (WebCore::isSeparator): Added. (WebCore::Document::processArguments): Added. (WebCore::Document::processViewport): Added.
dom/Document.h:
dom/ViewportArguments.cpp: Added. (WebCore::setViewportFeature): (WebCore::viewportErrorMessageTemplate): (WebCore::viewportErrorMessageLevel): (WebCore::reportViewportWarning):
dom/ViewportArguments.h: Added. (WebCore::): (WebCore::ViewportArguments::): (WebCore::ViewportArguments::ViewportArguments): (WebCore::ViewportArguments::hasCustomArgument):
html/HTMLMetaElement.cpp: (WebCore::HTMLMetaElement::process): Modified to call Document::processViewport.
page/ChromeClient.h: (WebCore::ChromeClient::didReceiveViewportArguments): Added.

8:23 PM Changeset in webkit [57774] by weinig@apple.com

4 edits
1 delete in trunk/WebKit2

Remove the need for a .defs file! Define WK_EXPORT.

Reviewed by Jon "The Belly" Honeycutt.

UIProcess/API/C/WKBase.h:
WebProcess/win/WebProcessMain.h:
win/WebKit2.def: Removed.
win/WebKit2.vcproj:

8:06 PM Changeset in webkit [57773] by weinig@apple.com

8 edits in trunk

Teach windows MiniBrowser how to work with window.open()
and targeted links.

Reviewed by Adam Roben.

WebKit2:

Export WKPageSetPageUIClient.

win/WebKit2.def:

WebKitTools:

MiniBrowser/win/BrowserView.cpp:

(createNewPage): Create a new BrowserWindow and return its page.
(showPage): Show the page.
(closePage): Empty implementation.
(runJavaScriptAlert): Empty implementation.
(BrowserView::create): Register a UIClient.

MiniBrowser/win/BrowserView.h:

(BrowserView::webView): Added.
Change create to take a BrowserWindow instead of an HWND.

MiniBrowser/win/BrowserWindow.cpp:

(BrowserWindow::wndProc): Respond to WM_NCDESTROY.
(BrowserWindow::goToURL): Added. Forwards to BrowserView.
(BrowserWindow::onCreate): Don't always go to the default
url. Let the caller do this.
(BrowserWindow::onNCDestroy): Delete the window.

MiniBrowser/win/BrowserWindow.h:

(BrowserWindow::view): Added.
(BrowserWindow::window): Added.

MiniBrowser/win/main.cpp:

(_tWinMain):
Go to the default URL for the initial page. Allocate the initial
window on the heap for correctness.

7:53 PM Changeset in webkit [57772] by Adam Roben

2 edits in trunk/WebKitTools

Add the Windows Debug (Test) builder to the list of core builders

It's been green for a few days now, and all the known Windows
flakiness is Release-only.

Rubber-stamped by Mark Rowe.

Scripts/webkitpy/common/net/buildbot.py:

(BuildBot.core_builder_name_regexps): Added a regular expression to
match the "Windows Debug (Test)" builder.

7:30 PM Changeset in webkit [57771] by dumi@chromium.org

2 edits in trunk/WebKit/chromium

Get rid of the UNUSED_PARAM macro in GraphicsContext3D.cpp.
https://bugs.webkit.org/show_bug.cgi?id=37733

Reviewed by Eric Seidel.

src/GraphicsContext3D.cpp:

(WebCore::GraphicsContext3D::GraphicsContext3D):

7:04 PM Changeset in webkit [57770] by eric@webkit.org

4 edits in trunk

2010-04-16 No'am Rosenthal <noam.rosenthal@nokia.com>

Reviewed by Antti Koivisto.

[Qt] GraphicsLayer: support fill-modes
https://bugs.webkit.org/show_bug.cgi?id=36216

Remove LayoutTests/animations/fill-mode-transform.html from the skip list

platform/qt/Skipped:

2010-04-16 No'am Rosenthal <noam.rosenthal@nokia.com>

Reviewed by Antti Koivisto.

[Qt] GraphicsLayer: support fill-modes
https://bugs.webkit.org/show_bug.cgi?id=36216
Implement the CSS-animation "fill mode" concept in GraphicsLayerQt. The concept
enables a key-frame animation to go to the animation's starting point before the delay,
and/or to stay at the animation's ending point after its ended, without reverting to the default
value.
We do that by manually setting the value to keyframe-0 before the delay if fill-mode is backwards/both,
and manually modifying the default value to the animated value as we animate, with fill-mode forwards/both.

platform/graphics/qt/GraphicsLayerQt.cpp: (WebCore::AnimationQtBase::AnimationQtBase): (WebCore::TransformAnimationQt::~TransformAnimationQt): (WebCore::TransformAnimationQt::applyFrame): (WebCore::GraphicsLayerQt::addAnimation):

5:24 PM Changeset in webkit [57769] by barraclough@apple.com

2 edits in trunk/WebCore

bindings/js/JSDesktopNotificationsCustom.cpp:

(WebCore::JSNotification::addEventListener):
(WebCore::JSNotification::removeEventListener):

Reviewed by NOBODY (arm build fix).

5:20 PM Changeset in webkit [57768] by dumi@chromium.org

4 edits in trunk/WebKit/chromium

Changing the return type of WebSecurityOrigin::createFromDatabaseIdentifier().
https://bugs.webkit.org/show_bug.cgi?id=34466

Reviewed by Jeremy Orlow.

Changing the return type of
WebSecurityOrigin::createFromDatabaseIdentifier() from
WebSecurityOrigin* to WebSecurityOrigin, to make it more
consistent with the other WebSecurityOrigin methods.

public/WebSecurityOrigin.h:
src/WebDatabase.cpp:

(WebKit::WebDatabase::closeDatabaseImmediately):

src/WebSecurityOrigin.cpp:

(WebKit::WebSecurityOrigin::createFromDatabaseIdentifier):

5:14 PM QtWebKitBackportingFixes edited by Simon Hausmann

(diff)

5:12 PM Changeset in webkit [57767] by dimich@chromium.org

7 edits
1 move
1 add in trunk

WebCore: [v8] In Workers, script errors right after close() are not delivered to the Worker.onerror.
https://bugs.webkit.org/show_bug.cgi?id=37691

Reviewed by Yury Semikhatsky.

Existing worker-close.html will now work in Chromium.

bindings/v8/V8Utilities.cpp:

(WebCore::getScriptExecutionContext): Stop using proxy() to just retrieve WorkerContext which should be always available.

bindings/v8/WorkerContextExecutionProxy.h: removed workerContext() accessor which moved to WorkerScriptController.
bindings/v8/WorkerScriptController.h:

(WebCore::WorkerScriptController::workerContext): Added, to be able to pull WorkerContext out from the controller.

WebKit/chromium: [v8] In Workers, script errors right after close() are not delivered to the Worker.onerror
https://bugs.webkit.org/show_bug.cgi?id=37691

Reviewed by Yury Semikhatsky.

src/WebWorkerClientImpl.cpp:

(WebKit::WebWorkerClientImpl::createWorkerContextProxy): Don't need to pull V8 proxy to retrieve current WorkerContext.

LayoutTests: [v8] In Workers, script errors right after close() are not delivered to the Worker.onerror
https://bugs.webkit.org/show_bug.cgi?id=37691

Reviewed by Yury Semikhatsky.

Moved the expected result into platform-independent chromium subdirectory, since
the only chromium-specific difference is the way v8 formats an error message.
Also updated the expected result to match the passing now test.

platform/chromium-win/fast/workers/worker-close-expected.txt: Removed.
platform/chromium/fast/workers/worker-close-expected.txt: Added.

5:10 PM Changeset in webkit [57766] by barraclough@apple.com

28 edits in trunk/WebCore

https://bugs.webkit.org/show_bug.cgi?id=37735
Remove JSC specific code from WebCore::AtomicString

Reviewed by Sam Weinig.

Add generic constructor/add/find methods that take a UChar* & length, along
with a known existing hash for the string.
This removes the remaining JSC specific code from platform/text.

bindings/js/JSAbstractWorkerCustom.cpp:

(WebCore::JSAbstractWorker::addEventListener):
(WebCore::JSAbstractWorker::removeEventListener):

bindings/js/JSDOMApplicationCacheCustom.cpp:

(WebCore::JSDOMApplicationCache::addEventListener):
(WebCore::JSDOMApplicationCache::removeEventListener):

bindings/js/JSDOMBinding.cpp:

(WebCore::ustringToAtomicString):
(WebCore::identifierToAtomicString):
(WebCore::findAtomicString):

bindings/js/JSDOMBinding.h:
bindings/js/JSDOMWindowCustom.cpp:

(WebCore::childFrameGetter):
(WebCore::JSDOMWindow::getOwnPropertySlot):
(WebCore::JSDOMWindow::getOwnPropertyDescriptor):
(WebCore::JSDOMWindow::open):
(WebCore::JSDOMWindow::addEventListener):
(WebCore::JSDOMWindow::removeEventListener):

bindings/js/JSElementCustom.cpp:

(WebCore::JSElement::setAttribute):
(WebCore::JSElement::setAttributeNS):

bindings/js/JSEventSourceCustom.cpp:

(WebCore::JSEventSource::addEventListener):
(WebCore::JSEventSource::removeEventListener):

bindings/js/JSHTMLAllCollectionCustom.cpp:

(WebCore::getNamedItems):
(WebCore::JSHTMLAllCollection::canGetItemsForName):

bindings/js/JSHTMLCollectionCustom.cpp:

(WebCore::getNamedItems):
(WebCore::JSHTMLCollection::canGetItemsForName):

bindings/js/JSHTMLDocumentCustom.cpp:

(WebCore::JSHTMLDocument::canGetItemsForName):

bindings/js/JSHTMLFormElementCustom.cpp:

(WebCore::JSHTMLFormElement::canGetItemsForName):
(WebCore::JSHTMLFormElement::nameGetter):

bindings/js/JSHTMLFrameSetElementCustom.cpp:

(WebCore::JSHTMLFrameSetElement::canGetItemsForName):
(WebCore::JSHTMLFrameSetElement::nameGetter):

bindings/js/JSMessageEventCustom.cpp:

(WebCore::JSMessageEvent::initMessageEvent):

bindings/js/JSMessagePortCustom.cpp:

(WebCore::JSMessagePort::addEventListener):
(WebCore::JSMessagePort::removeEventListener):

bindings/js/JSMimeTypeArrayCustom.cpp:

(WebCore::JSMimeTypeArray::canGetItemsForName):
(WebCore::JSMimeTypeArray::nameGetter):

bindings/js/JSNodeCustom.cpp:

(WebCore::JSNode::addEventListener):
(WebCore::JSNode::removeEventListener):

bindings/js/JSNodeListCustom.cpp:

(WebCore::JSNodeList::canGetItemsForName):
(WebCore::JSNodeList::nameGetter):

bindings/js/JSPluginArrayCustom.cpp:

(WebCore::JSPluginArray::canGetItemsForName):
(WebCore::JSPluginArray::nameGetter):

bindings/js/JSPluginCustom.cpp:

(WebCore::JSPlugin::canGetItemsForName):
(WebCore::JSPlugin::nameGetter):

bindings/js/JSPopStateEventCustom.cpp:

(WebCore::JSPopStateEvent::initPopStateEvent):

bindings/js/JSSVGElementInstanceCustom.cpp:

(WebCore::JSSVGElementInstance::addEventListener):
(WebCore::JSSVGElementInstance::removeEventListener):

bindings/js/JSWebSocketCustom.cpp:

(WebCore::JSWebSocket::addEventListener):
(WebCore::JSWebSocket::removeEventListener):

bindings/js/JSWorkerContextCustom.cpp:

(WebCore::JSWorkerContext::addEventListener):
(WebCore::JSWorkerContext::removeEventListener):

bindings/js/JSXMLHttpRequestCustom.cpp:

(WebCore::JSXMLHttpRequest::setRequestHeader):
(WebCore::JSXMLHttpRequest::getResponseHeader):
(WebCore::JSXMLHttpRequest::addEventListener):
(WebCore::JSXMLHttpRequest::removeEventListener):

bindings/js/JSXMLHttpRequestUploadCustom.cpp:

(WebCore::JSXMLHttpRequestUpload::addEventListener):
(WebCore::JSXMLHttpRequestUpload::removeEventListener):

platform/text/AtomicString.cpp:

(WebCore::AtomicString::add):
(WebCore::AtomicString::find):

platform/text/AtomicString.h:

(WebCore::AtomicString::AtomicString):

4:58 PM Changeset in webkit [57765] by Adam Roben

2 edits in trunk/LayoutTests

Fix typo from r55729

platform/win/Skipped:

4:51 PM Changeset in webkit [57764] by weinig@apple.com

5 edits in trunk

Fix window.open() and targeted links.

Reviewed by Anders Carlsson.

WebKit2:

UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::didReceiveSyncMessage): Pass in the new pageID
instead of 0.

WebProcess/WebProcess.cpp:

(WebKit::WebProcess::createWebPage): Allow for the page to have already
been created, as is the case with programmatic window opening from within
WebCore (e.g. window.open() or <a target="_blank">).

WebKitTools:

MiniBrowser/mac/BrowserWindowController.m:

(_createNewPage): Use the correct initializer to and load the window.

4:45 PM Changeset in webkit [57763] by ajwong@chromium.org

2 edits in trunk/LayoutTests

Not reviewed. Fixing chromium build.

[chromium] Upstream test_expectations.txt changes from chromium.
Mark letter_spacing.html as consistently failing for mac.
Fixing a syntax error in the test_expectations.txt file.

platform/chromium/test_expectations.txt:

4:31 PM Changeset in webkit [57762] by ajwong@chromium.org

2 edits in trunk/LayoutTests

Not reviewed. Fixing chromiumg build.

[chromium] filterRes.svg is consistently failing now. Marking as such.

platform/chromium/test_expectations.txt:

4:23 PM Changeset in webkit [57761] by weinig@apple.com

2 edits in trunk/WebKit2

Don't optimize debug builds.

Reviewed by Mark Rowe.

WebKit2.xcodeproj/project.pbxproj: Define GCC_OPTIMIZATION_LEVEL correctly.

4:13 PM Changeset in webkit [57760] by ukai@chromium.org

3 edits
4 adds in trunk

2010-04-16 Fumitoshi Ukai <ukai@chromium.org>

Reviewed by Alexey Proskuryakov.

WebSocket crash when it receives bad header.
https://bugs.webkit.org/show_bug.cgi?id=37682

websocket/tests/bad-handshake-crash-expected.txt: Added.
websocket/tests/bad-handshake-crash.html: Added.
websocket/tests/bad-handshake-crash_wsh.py: Added.
websocket/tests/script-tests/bad-handshake-crash.js: Added.

2010-04-16 Fumitoshi Ukai <ukai@chromium.org>

Reviewed by Alexey Proskuryakov.

WebSocket crash when it receives bad header.
https://bugs.webkit.org/show_bug.cgi?id=37682

If name or value is not valid UTF-8, nameStr or valueStr would be
null string, so crashed in headers->add(nameStr, valueStr).
Check both nameStr and valueStr are not null string.
Otherwise handshake will fail.

Test: websocket/tests/bad-handshake-crash.html

websockets/WebSocketHandshake.cpp: (WebCore::WebSocketHandshake::readHTTPHeaders): check nameStr and valueStr are not null string.

4:10 PM Changeset in webkit [57759] by mitz@apple.com

3 edits
2 adds in trunk

<rdar://problem/7873647> Crash when updating hover state

Reviewed by Simon Fraser.

WebCore:

Test: fast/dynamic/hover-style-recalc-crash.html

Updating the hover state of an element caused the document to need style
recalc, and then updating the hover state of a link caused style recalc,
which changed the render tree while updateHoverActiveState() was iterating
over it, leading to a crash.

rendering/RenderLayer.cpp:

(WebCore::RenderLayer::updateHoverActiveState): Collect the nodes to be
updated into vectors, then update their active and hover states.

LayoutTests:

fast/dynamic/hover-style-recalc-crash-expected.txt: Added.
fast/dynamic/hover-style-recalc-crash.html: Added.

4:07 PM Changeset in webkit [57758] by ajwong@chromium.org

2 edits in trunk/WebKit/chromium

Not reviewed. Build fix.

[chromium] Compile fix. Missing include header, and missing type conversion.

src/GraphicsContext3D.cpp:

(WebCore::GraphicsContext3DInternal::beginPaint):

3:42 PM Changeset in webkit [57757] by andersca@apple.com

2 edits in trunk/WebKit2

Fix build.

WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::runJavaScriptInMainFrame):

3:31 PM Changeset in webkit [57756] by barraclough@apple.com

2 edits in trunk/JavaScriptCore

Bug 37730 - Remove JSC::UString dependencies from WebCore::StringImpl
(Following on from bug #37675).

Reviewed by Oliver Hunt.

Make the argument ordering for UStringImpl's constructor & create
methods match, when passed a shared buffer.

JavaScriptCore.exp:
runtime/UStringImpl.cpp:

(JSC::UStringImpl::create):

runtime/UStringImpl.h:

3:29 PM Changeset in webkit [57755] by scherkus@chromium.org

2 edits in trunk/LayoutTests

2010-04-16 Andrew Scherkus <scherkus@chromium.org>

Unreviewed, fixing Chromium test_expectations.txt due to removed tests in r57292.

platform/chromium/test_expectations.txt:

3:11 PM Changeset in webkit [57754] by dumi@chromium.org

2 edits in trunk/WebCore

Make Safari correctly allocate 5MB of DB storage to all new
origins.
https://bugs.webkit.org/show_bug.cgi?id=36671

Reviewed by Alexey Proskuryakov.

Eric fixed the same problem in
DatabaseTracker::fullPathForDatabaseNoLock() in r57128, but forgot
to fix it in DatabaseTracker::detailsForNameAndOrigin() too.

storage/DatabaseTracker.cpp:

(WebCore::DatabaseTracker::detailsForNameAndOrigin):

3:06 PM Changeset in webkit [57753] by scherkus@chromium.org

2 edits
2 adds in trunk/LayoutTests

2010-04-16 Andrew Scherkus <scherkus@chromium.org>

Unreviewed, checking in Chromium baselines for media/video-seek-past-end-playing.html.

platform/chromium-mac/media/video-seek-past-end-playing-expected.txt: Added.
platform/chromium-win/media/video-seek-past-end-playing-expected.txt: Added.
platform/chromium/test_expectations.txt:

3:05 PM Changeset in webkit [57752] by barraclough@apple.com

2 edits in trunk/JavaScriptCore

Bug 37730 - Remove JSC::UString dependencies from WebCore::StringImpl
(Following on from bug #37675).

Reviewed by Oliver Hunt.

Make the argument ordering for UStringImpl's constructor & create
methods match, when passed a shared buffer.

JavaScriptCore.exp:
runtime/UStringImpl.cpp:

(JSC::UStringImpl::create):

runtime/UStringImpl.h:

2:57 PM Changeset in webkit [57751] by mrowe@apple.com

4 edits in tags/Safari-533.5.2/WebKit/win

Merge r57615.

2:56 PM Changeset in webkit [57750] by mrowe@apple.com

5 edits in tags/Safari-533.5.2

Versioning.

2:55 PM Changeset in webkit [57749] by kinuko@chromium.org

9 edits
3 adds in trunk/WebCore

2010-04-16 Kinuko Yasuda <kinuko@chromium.org>

Reviewed by Jian Li.

Implement FileStreamProxy that calls FileStream methods on FileThread for FileAPI
https://bugs.webkit.org/show_bug.cgi?id=37218

No new tests; tests will be added when we add upper layer implementations.

GNUmakefile.am:
WebCore.gypi:
WebCore.pro:
WebCore.vcproj/WebCore.vcproj:
WebCore.xcodeproj/project.pbxproj:
html/FileStream.cpp: (WebCore::FileStream::stop):
html/FileStream.h:
html/FileStreamClient.h: (WebCore::FileStreamClient::didStop):
html/FileStreamProxy.cpp: Added
html/FileStreamProxy.h: Added
html/FileThreadTask.h: Added

2:50 PM Changeset in webkit [57748] by barraclough@apple.com

11 edits in trunk

Bug 37730 - Remove JSC::UString dependencies from WebCore::StringImpl
(Following on from bug #37675).

Reviewed by Oliver Hunt.

JavaScriptCore:

Make the argument ordering for UStringImpl's constructor & create
methods match, when passed a shared buffer.

JavaScriptCore.exp:
runtime/UStringImpl.cpp:

(JSC::UStringImpl::create):

runtime/UStringImpl.h:

WebCore:

Remove ustring() method, and constructor passed a UString.

WebCore.base.exp:
bindings/js/JSDOMBinding.cpp:

(WebCore::stringimplToUString):
(WebCore::jsStringSlowCase):
(WebCore::ustringToString):
(WebCore::stringToUString):
(WebCore::identifierToString):

bindings/js/JSDOMBinding.h:

(WebCore::jsString):

platform/text/AtomicString.cpp:

(WebCore::AtomicString::operator UString):

platform/text/StringImpl.cpp:

(WebCore::StringImpl::create):

platform/text/StringImpl.h:

2:39 PM Changeset in webkit [57747] by eric@webkit.org

7 edits in trunk

2010-04-16 Jarkko Sakkinen <jarkko.j.sakkinen@gmail.com>

Reviewed by Simon Hausmann.

[Qt] WebGL is not visible when QGLWidget viewport is used
https://bugs.webkit.org/show_bug.cgi?id=37070

Added HostWindow parameter to the constructor of GraphicsContext3D.
Shared OpenGL context is initialized with parent QGLWidget.

html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::create):
platform/graphics/GraphicsContext3D.h:
platform/graphics/mac/GraphicsContext3DMac.cpp: (WebCore::GraphicsContext3D::create): (WebCore::GraphicsContext3D::GraphicsContext3D):
platform/graphics/qt/GraphicsContext3DQt.cpp: (WebCore::GraphicsContext3DInternal::GraphicsContext3DInternal): (WebCore::GraphicsContext3DInternal::~GraphicsContext3DInternal): (WebCore::GraphicsContext3DInternal::getOwnerGLWidget): (WebCore::GraphicsContext3D::create): (WebCore::GraphicsContext3D::GraphicsContext3D):

2010-04-16 Jarkko Sakkinen <jarkko.j.sakkinen@gmail.com>

Reviewed by Simon Hausmann.

[Qt] WebGL is not visible when QGLWidget viewport is used
https://bugs.webkit.org/show_bug.cgi?id=37070

Added HostWindow parameter to the constructor of GraphicsContext3D.
Shared OpenGL context is initialized with parent QGLWidget.

src/GraphicsContext3D.cpp: (WebCore::GraphicsContext3D::GraphicsContext3D):

2:39 PM Changeset in webkit [57746] by mrowe@apple.com

1 copy in tags/Safari-533.5.2

New tag.

2:27 PM Changeset in webkit [57745] by eric@webkit.org

2 edits in trunk/WebCore

2010-04-16 Jarkko Sakkinen <jarkko.j.sakkinen@gmail.com>

Reviewed by Simon Hausmann.

[Qt] WebKit compilation fails with --3d-canvas
https://bugs.webkit.org/show_bug.cgi?id=37699

API for readPixels() has been changed.

platform/graphics/qt/GraphicsContext3DQt.cpp: (WebCore::GraphicsContext3D::readPixels):

2:16 PM Changeset in webkit [57744] by eric@webkit.org

2 edits in trunk/WebCore

2010-04-16 No'am Rosenthal <noam.rosenthal@nokia.com>

Reviewed by Antti Koivisto.

[Qt]QtLauncher crash on page with CSS 3D transform
https://bugs.webkit.org/show_bug.cgi?id=36859

Added a neccessary null-pointer check, lack of which created the crash circumstances.

Tested by http://css-vfx.googlecode.com/svn/trunk/snowstack/snowstack.html

platform/graphics/qt/GraphicsLayerQt.cpp: (WebCore::GraphicsLayerQtImpl::flushChanges):

2:14 PM Changeset in webkit [57743] by scherkus@chromium.org

59 edits in trunk/LayoutTests

2010-04-16 Sergey Ulanov <sergeyu@chromium.org>

Unreviewed, checking in baselines due to changes to Chromium's video scaling algorithm.

platform/chromium-linux/media/controls-after-reload-expected.checksum:
platform/chromium-linux/media/controls-after-reload-expected.png:
platform/chromium-linux/media/controls-strict-expected.checksum:
platform/chromium-linux/media/controls-strict-expected.png:
platform/chromium-linux/media/video-aspect-ratio-expected.checksum:
platform/chromium-linux/media/video-aspect-ratio-expected.png:
platform/chromium-linux/media/video-controls-rendering-expected.checksum:
platform/chromium-linux/media/video-controls-rendering-expected.png:
platform/chromium-linux/media/video-display-toggle-expected.checksum:
platform/chromium-linux/media/video-display-toggle-expected.png:
platform/chromium-linux/media/video-layer-crash-expected.checksum:
platform/chromium-linux/media/video-layer-crash-expected.png:
platform/chromium-linux/media/video-no-audio-expected.checksum:
platform/chromium-linux/media/video-no-audio-expected.png:
platform/chromium-linux/media/video-transformed-expected.checksum:
platform/chromium-linux/media/video-transformed-expected.png:
platform/chromium-linux/media/video-volume-slider-expected.checksum:
platform/chromium-linux/media/video-volume-slider-expected.png:
platform/chromium-linux/media/video-zoom-expected.checksum:
platform/chromium-linux/media/video-zoom-expected.png:
platform/chromium-mac/media/controls-after-reload-expected.checksum:
platform/chromium-mac/media/controls-after-reload-expected.png:
platform/chromium-mac/media/controls-strict-expected.checksum:
platform/chromium-mac/media/controls-strict-expected.png:
platform/chromium-mac/media/video-aspect-ratio-expected.checksum:
platform/chromium-mac/media/video-aspect-ratio-expected.png:
platform/chromium-mac/media/video-controls-rendering-expected.checksum:
platform/chromium-mac/media/video-controls-rendering-expected.png:
platform/chromium-mac/media/video-display-toggle-expected.checksum:
platform/chromium-mac/media/video-display-toggle-expected.png:
platform/chromium-mac/media/video-layer-crash-expected.checksum:
platform/chromium-mac/media/video-layer-crash-expected.png:
platform/chromium-mac/media/video-no-audio-expected.checksum:
platform/chromium-mac/media/video-no-audio-expected.png:
platform/chromium-mac/media/video-transformed-expected.checksum:
platform/chromium-mac/media/video-transformed-expected.png:
platform/chromium-mac/media/video-volume-slider-expected.checksum:
platform/chromium-mac/media/video-volume-slider-expected.png:
platform/chromium-mac/media/video-zoom-expected.checksum:
platform/chromium-mac/media/video-zoom-expected.png:
platform/chromium-win/media/controls-after-reload-expected.checksum:
platform/chromium-win/media/controls-after-reload-expected.png:
platform/chromium-win/media/controls-strict-expected.checksum:
platform/chromium-win/media/controls-strict-expected.png:
platform/chromium-win/media/video-aspect-ratio-expected.checksum:
platform/chromium-win/media/video-aspect-ratio-expected.png:
platform/chromium-win/media/video-controls-rendering-expected.checksum:
platform/chromium-win/media/video-controls-rendering-expected.png:
platform/chromium-win/media/video-display-toggle-expected.checksum:
platform/chromium-win/media/video-display-toggle-expected.png:
platform/chromium-win/media/video-layer-crash-expected.checksum:
platform/chromium-win/media/video-layer-crash-expected.png:
platform/chromium-win/media/video-no-audio-expected.checksum:
platform/chromium-win/media/video-no-audio-expected.png:
platform/chromium-win/media/video-transformed-expected.checksum:
platform/chromium-win/media/video-transformed-expected.png:
platform/chromium-win/media/video-volume-slider-expected.checksum:
platform/chromium-win/media/video-volume-slider-expected.png:

2:08 PM Changeset in webkit [57742] by Adam Roben

2 edits in trunk/WebKitTools

Fix links to layout test results from build status pages

Reviewed by Mark Rowe.

BuildSlaveSupport/build.webkit.org-config/master.cfg:

(ExtractTestResults.finished): Prepend "/" on the URL of the test
results page so that it is treated as an absolute URL.

1:52 PM Changeset in webkit [57741] by andersca@apple.com

2 edits in trunk/WebCore

Make sure to update the current graphics context when calling out to AppKit.

Reviewed by Sam Weinig.

platform/mac/ThemeMac.mm:

(WebCore::paintCheckbox):
(WebCore::paintRadio):

1:34 PM Changeset in webkit [57740] by barraclough@apple.com

3 edits in trunk/WebKit/win

WebFrame.cpp:

(WebFrame::stringByEvaluatingJavaScriptInScriptWorld):

WebView.cpp:

(WebView::stringByEvaluatingJavaScriptFromString):

Reviewed by NOBODY (Windows build fix).

1:26 PM Changeset in webkit [57739] by andersca@apple.com

4 edits in trunk/WebKit2

Fix windows build.

Reviewed by Sam Weinig.

Platform/win/RunLoopWin.cpp:

(RunLoop::run):

UIProcess/Launcher/win/WebProcessLauncher.cpp:

(WebKit::webThreadBody):
(WebKit::launchWebProcess):

WebProcess/win/WebProcessMain.cpp:

(WebKit::WebProcessMain):

1:21 PM Changeset in webkit [57738] by barraclough@apple.com

73 edits in trunk

https://bugs.webkit.org/show_bug.cgi?id=37675
Remove casts/constructors to/from JSC::UString type from WebCore::String

Reviewed by Sam Weinig & Oliver Hunt.

WebCore's strings should not know about JSC::UString, this should be abstracted
away in the bindings. Add explicit conversion methods rather than relying on
overloaded cast operators / constructors being implicitly called.

This patch only changes the class String, once this has landed StringImpl, and
hopefully AtomicString too, should follow suit.

WebCore:

This patch adds:

WebCore::identifierToString
WebCore::ustringToString
WebCore::stringToUString

to JSDOMBindings.h, and updates code to call these methods.

WebCore.base.exp:
WebCore.order:
bindings/js/CachedScriptSourceProvider.h:

(WebCore::CachedScriptSourceProvider::CachedScriptSourceProvider):

bindings/js/JSAudioConstructor.cpp:

(WebCore::constructAudio):

bindings/js/JSCSSStyleDeclarationCustom.cpp:

(WebCore::JSCSSStyleDeclaration::nameGetter):

bindings/js/JSCanvasRenderingContext2DCustom.cpp:

(WebCore::toHTMLCanvasStyle):
(WebCore::JSCanvasRenderingContext2D::setFillColor):
(WebCore::JSCanvasRenderingContext2D::setStrokeColor):
(WebCore::JSCanvasRenderingContext2D::drawImageFromRect):
(WebCore::JSCanvasRenderingContext2D::setShadow):
(WebCore::JSCanvasRenderingContext2D::fillText):
(WebCore::JSCanvasRenderingContext2D::strokeText):

bindings/js/JSClipboardCustom.cpp:

(WebCore::JSClipboard::types):
(WebCore::JSClipboard::clearData):
(WebCore::JSClipboard::getData):
(WebCore::JSClipboard::setData):

bindings/js/JSCustomXPathNSResolver.cpp:

(WebCore::JSCustomXPathNSResolver::lookupNamespaceURI):

bindings/js/JSDOMBinding.cpp:

(WebCore::identifierToString):
(WebCore::ustringToString):
(WebCore::stringToUString):
(WebCore::valueToStringWithNullCheck):
(WebCore::valueToStringWithUndefinedOrNullCheck):
(WebCore::reportException):

bindings/js/JSDOMBinding.h:
bindings/js/JSDOMFormDataCustom.cpp:

(WebCore::JSDOMFormData::append):

bindings/js/JSDOMWindowCustom.cpp:

(WebCore::namedItemGetter):
(WebCore::JSDOMWindow::setLocation):
(WebCore::JSDOMWindow::openDatabase):

bindings/js/JSDatabaseCustom.cpp:

(WebCore::JSDatabase::changeVersion):

bindings/js/JSDocumentCustom.cpp:

(WebCore::JSDocument::setLocation):

bindings/js/JSEventListener.cpp:

(WebCore::JSEventListener::handleEvent):

bindings/js/JSEventSourceConstructor.cpp:

(WebCore::constructEventSource):

bindings/js/JSHTMLAllCollectionCustom.cpp:

(WebCore::callHTMLAllCollection):

bindings/js/JSHTMLCanvasElementCustom.cpp:

(WebCore::JSHTMLCanvasElement::getContext):

bindings/js/JSHTMLCollectionCustom.cpp:

(WebCore::callHTMLCollection):

bindings/js/JSHTMLDocumentCustom.cpp:

(WebCore::JSHTMLDocument::nameGetter):
(WebCore::documentWrite):

bindings/js/JSInjectedScriptHostCustom.cpp:

(WebCore::InjectedScriptHost::createInjectedScript):

bindings/js/JSInspectorFrontendHostCustom.cpp:

(WebCore::JSInspectorFrontendHost::showContextMenu):

bindings/js/JSLazyEventListener.cpp:

(WebCore::JSLazyEventListener::initializeJSFunction):

bindings/js/JSLocationCustom.cpp:

(WebCore::JSLocation::setHref):
(WebCore::JSLocation::setProtocol):
(WebCore::JSLocation::setHost):
(WebCore::JSLocation::setHostname):
(WebCore::JSLocation::setPathname):
(WebCore::JSLocation::setSearch):
(WebCore::JSLocation::setHash):
(WebCore::JSLocation::replace):
(WebCore::JSLocation::assign):

bindings/js/JSMessageEventCustom.cpp:

(WebCore::JSMessageEvent::initMessageEvent):

bindings/js/JSNamedNodeMapCustom.cpp:

(WebCore::JSNamedNodeMap::canGetItemsForName):
(WebCore::JSNamedNodeMap::nameGetter):

bindings/js/JSOptionConstructor.cpp:

(WebCore::constructHTMLOptionElement):

bindings/js/JSSQLResultSetRowListCustom.cpp:

(WebCore::JSSQLResultSetRowList::item):

bindings/js/JSSQLTransactionCustom.cpp:

(WebCore::JSSQLTransaction::executeSql):

bindings/js/JSSharedWorkerConstructor.cpp:

(WebCore::constructSharedWorker):

bindings/js/JSStorageCustom.cpp:

(WebCore::JSStorage::canGetItemsForName):
(WebCore::JSStorage::nameGetter):
(WebCore::JSStorage::deleteProperty):
(WebCore::JSStorage::getOwnPropertyNames):
(WebCore::JSStorage::putDelegate):

bindings/js/JSStyleSheetListCustom.cpp:

(WebCore::JSStyleSheetList::canGetItemsForName):
(WebCore::JSStyleSheetList::nameGetter):

bindings/js/JSWebKitCSSMatrixConstructor.cpp:

(WebCore::constructWebKitCSSMatrix):

bindings/js/JSWebSocketConstructor.cpp:

(WebCore::constructWebSocket):

bindings/js/JSWebSocketCustom.cpp:

(WebCore::JSWebSocket::send):

bindings/js/JSWorkerConstructor.cpp:

(WebCore::constructWorker):

bindings/js/JSWorkerContextCustom.cpp:

(WebCore::JSWorkerContext::importScripts):

bindings/js/JSXMLHttpRequestCustom.cpp:

(WebCore::JSXMLHttpRequest::open):
(WebCore::JSXMLHttpRequest::setRequestHeader):
(WebCore::JSXMLHttpRequest::send):
(WebCore::JSXMLHttpRequest::overrideMimeType):

bindings/js/JSXSLTProcessorCustom.cpp:

(WebCore::JSXSLTProcessor::setParameter):
(WebCore::JSXSLTProcessor::getParameter):
(WebCore::JSXSLTProcessor::removeParameter):

bindings/js/ScheduledAction.cpp:

(WebCore::ScheduledAction::create):

bindings/js/ScriptCallFrame.cpp:

(WebCore::ScriptCallFrame::ScriptCallFrame):

bindings/js/ScriptController.cpp:

(WebCore::ScriptController::evaluateInWorld):

bindings/js/ScriptDebugServer.cpp:

(WebCore::ScriptDebugServer::hasBreakpoint):
(WebCore::ScriptDebugServer::dispatchDidParseSource):
(WebCore::ScriptDebugServer::dispatchFailedToParseSource):
(WebCore::ScriptDebugServer::sourceParsed):

bindings/js/ScriptEventListener.cpp:

(WebCore::getEventListenerHandlerBody):

bindings/js/ScriptFunctionCall.cpp:

(WebCore::ScriptFunctionCall::appendArgument):
(WebCore::ScriptFunctionCall::call):
(WebCore::ScriptFunctionCall::construct):

bindings/js/ScriptObject.cpp:

(WebCore::ScriptObject::set):

bindings/js/ScriptProfiler.cpp:

(WebCore::ScriptProfiler::start):
(WebCore::ScriptProfiler::stop):

bindings/js/ScriptString.h:

(WebCore::ScriptString::operator String):
(WebCore::ScriptString::ustring):
(WebCore::ScriptString::operator+=):

bindings/js/ScriptValue.cpp:

(WebCore::ScriptValue::getString):

bindings/js/ScriptValue.h:

(WebCore::ScriptValue::toString):

bindings/js/SerializedScriptValue.cpp:

(WebCore::SerializedObject::set):
(WebCore::SerializingTreeWalker::convertIfTerminal):
(WebCore::DeserializingTreeWalker::putProperty):

bindings/js/StringSourceProvider.h:

(WebCore::StringSourceProvider::StringSourceProvider):

bindings/objc/WebScriptObject.mm:

(-[WebScriptObject callWebScriptMethod:withArguments:]):
(-[WebScriptObject setValue:forKey:]):
(-[WebScriptObject valueForKey:]):
(-[WebScriptObject removeWebScriptKey:]):

bindings/scripts/CodeGeneratorJS.pm:
bridge/IdentifierRep.cpp:

(WebCore::IdentifierRep::get):

bridge/c/c_utility.cpp:

(JSC::Bindings::identifierFromNPIdentifier):

inspector/InspectorController.cpp:

(WebCore::InspectorController::scriptImported):
(WebCore::InspectorController::addProfileFinishedMessageToConsole):
(WebCore::InspectorController::createProfileHeader):

inspector/InspectorResource.cpp:

(WebCore::InspectorResource::sourceString):

inspector/JavaScriptCallFrame.cpp:

(WebCore::JavaScriptCallFrame::functionName):

platform/KURL.h:

(WebCore::KURL::operator const String&):

platform/text/AtomicString.cpp:

(WebCore::AtomicString::operator UString):

platform/text/AtomicString.h:
platform/text/PlatformString.h:
platform/text/String.cpp:

WebKit/mac:

Plugins/Hosted/NetscapePluginHostProxy.mm:

(identifierFromIdentifierRep):

Plugins/Hosted/NetscapePluginInstanceProxy.mm:

(WebKit::NetscapePluginInstanceProxy::addValueToArray):
(WebKit::NetscapePluginInstanceProxy::moveGlobalExceptionToExecState):

Plugins/Hosted/ProxyInstance.mm:

(WebKit::ProxyInstance::getPropertyNames):

WebView/WebFrame.mm:

(-[WebFrame _stringByEvaluatingJavaScriptFromString:forceUserGesture:]):
(-[WebFrame _stringByEvaluatingJavaScriptFromString:withGlobalObject:inScriptWorld:]):

WebView/WebScriptDebugDelegate.mm:

(-[WebScriptCallFrame evaluateWebScript:]):

WebView/WebScriptDebugger.mm:

(toNSURL):

WebView/WebView.mm:

(aeDescFromJSValue):

1:15 PM Changeset in webkit [57737] by weinig@apple.com

8 edits in trunk/WebKit2

Make resizing responsive on Windows.

Reviewed by Anders Carlsson.

Use the same waitFor logic as do for the Mac resizing DrawingAreaUpdateChunk code.

Shared/win/UpdateChunk.cpp:

(WebKit::UpdateChunk::UpdateChunk):

Shared/win/UpdateChunk.h: Add a constructor that only takes an IntRect and allocates the shared memory mapping for you.
UIProcess/win/DrawingAreaProxy.cpp:

(WebKit::DrawingAreaProxy::DrawingAreaProxy):
(WebKit::DrawingAreaProxy::ensureBackingStore):
(WebKit::DrawingAreaProxy::paint):
(WebKit::DrawingAreaProxy::drawUpdateChunkIntoBackingStore):
(WebKit::DrawingAreaProxy::setSize):
(WebKit::DrawingAreaProxy::didSetSize):
(WebKit::DrawingAreaProxy::didReceiveMessage):

UIProcess/win/DrawingAreaProxy.h:

Perform wait in paint as we do on the mac.

UIProcess/win/WebView.cpp:

(WebKit::WebView::onSizeEvent):
Change to use an IntSize.

WebProcess/WebPage/win/DrawingAreaUpdateChunk.cpp:

(WebKit::DrawingAreaUpdateChunk::paintIntoUpdateChunk):
(WebKit::DrawingAreaUpdateChunk::display):
(WebKit::DrawingAreaUpdateChunk::setSize):

WebProcess/WebPage/win/DrawingAreaUpdateChunk.h:

Specialize setSize() drawing and factor out painting
into a helper function.

1:13 PM Changeset in webkit [57736] by ajwong@chromium.org

3 edits
4 adds in trunk/LayoutTests

Not reviewed. Build fix for chromium.

[chromium] Add in new baselines for chromium-mac and chromium-win
also since this test there as well.

platform/chromium-mac/fast/url/host-expected.txt: Copied from LayoutTests/platform/chromium-linux/fast/url/host-expected.txt.
platform/chromium-mac/fast/url/path-expected.txt: Copied from LayoutTests/platform/chromium-linux/fast/url/path-expected.txt.
platform/chromium-mac/fast/url/standard-url-expected.txt:
platform/chromium-win/fast/url/host-expected.txt: Copied from LayoutTests/platform/chromium-linux/fast/url/host-expected.txt.
platform/chromium-win/fast/url/path-expected.txt: Copied from LayoutTests/platform/chromium-linux/fast/url/path-expected.txt.
platform/chromium-win/fast/url/standard-url-expected.txt:

1:05 PM Changeset in webkit [57735] by ajwong@chromium.org

1 edit
3 adds in trunk/LayoutTests

Not reviewed. Build fix for chromium.

[chromium] Add in new baselines for chromium-linux since this test
fully passes on this platform.

platform/chromium-linux/fast/url/host-expected.txt: Added.
platform/chromium-linux/fast/url/path-expected.txt: Added.
platform/chromium-linux/fast/url/standard-url-expected.txt: Added.

12:58 PM Changeset in webkit [57734] by andersca@apple.com

3 edits in trunk/WebCore

2010-04-16 Anders Carlsson <andersca@apple.com>

Reviewed by David Hyatt.

Always pass a view to the AppKit drawing functions.
https://bugs.webkit.org/show_bug.cgi?id=37724

platform/mac/ThemeMac.mm: (WebCore::paintCheckbox): (WebCore::paintRadio):
rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::paintMenuList): (WebCore::RenderThemeMac::paintSliderThumb): (WebCore::RenderThemeMac::paintSearchField): (WebCore::RenderThemeMac::paintSearchFieldCancelButton): (WebCore::RenderThemeMac::paintSearchFieldResultsDecoration): (WebCore::RenderThemeMac::paintSearchFieldResultsButton):

12:45 PM Changeset in webkit [57733] by ap@apple.com

3 edits
2 adds in trunk

Reviewed by Dan Bernstein.

https://bugs.webkit.org/show_bug.cgi?id=37718
Safari crashes with certain JavaScript charCode events in EventHandler::needsKeyboardEventDisambiguationQuirks

Test: fast/events/recorded-keydown-event.html

dom/KeyboardEvent.cpp: (WebCore::KeyboardEvent::charCode): Check if the view (window) is frameless.

12:36 PM Changeset in webkit [57732] by andersca@apple.com

8 edits in trunk/WebKit2

2010-04-16 Anders Carlsson <andersca@apple.com>

Reviewed by David Hyatt.

Make run loops be allocated as thread specific data.
https://bugs.webkit.org/show_bug.cgi?id=37723

Platform/RunLoop.cpp: (RunLoop::initializeMainRunLoop): (RunLoop::current): (RunLoop::main):
Platform/RunLoop.h:
Platform/mac/RunLoopMac.mm: (RunLoop::run): (RunLoop::stop):
UIProcess/Launcher/mac/WebProcessLauncher.mm: (WebKit::webThreadBody): (WebKit::launchWebProcess):
UIProcess/ResponsivenessTimer.cpp: (WebKit::ResponsivenessTimer::ResponsivenessTimer):
WebProcess/Launching/mac/WebProcessMain.mm: (main):
WebProcess/WebProcess.cpp: (WebKit::WebProcess::isSeparateProcess):

11:52 AM Changeset in webkit [57731] by Adam Roben

2 edits in trunk/LayoutTests

Skip HTMLFrameSetElement-window-eventListener-attributes.html on SnowLeopard

It is crashing sometimes. <http://webkit.org/b/37720> tracks investigating this.

Rubber-stamped by Sam Weinig.

platform/mac-snowleopard/Skipped:

11:40 AM Changeset in webkit [57730] by Adam Roben

3 edits in trunk/WebKit/win

Make it possible for clients to instantiate a WebUserContentURLPattern

Reviewed by Tim Hatcher.

ForEachCoClass.h: Added WebUserContentURLPattern to the FOR_EACH_COCLASS macro, which

lists all our instantiatable classes.

WebKitClassFactory.cpp: Added a now-required #include.

11:19 AM Changeset in webkit [57729] by Adam Roben

2 edits in trunk/LayoutTests

SKip xss-DENIED-mime-type-execute-as-html.html to see if it makes the http test stop timing out on Windows

<http://webkit.org/b/37714> tracks this investigation.

Rubber-stamped by Sam Weinig.

platform/win/Skipped:

11:19 AM Changeset in webkit [57728] by ukai@chromium.org

2 edits in trunk/WebKit/chromium

2010-04-16 Fumitoshi Ukai <ukai@chromium.org>

Reviewed by Jian Li.

[chromium] WebKit::WebURLResponse::addHTTPHeaderField will crash if response is invalid UTF-8
https://bugs.webkit.org/show_bug.cgi?id=37687

src/WebURLResponse.cpp: (WebKit::WebURLResponse::addHTTPHeaderField): ignore if name or value is null string.

11:07 AM Changeset in webkit [57727] by Dimitri Glazkov

2 edits in trunk/WebCore

2010-04-16 Jian Li <jianli@chromium.org>

Reviewed by Dmitry Titov.

Update FormDataList to fix style violations in old code.
https://bugs.webkit.org/show_bug.cgi?id=37689

html/FormDataList.h: (WebCore::FormDataList::appendData): (WebCore::FormDataList::appendBlob):

11:00 AM Changeset in webkit [57726] by jianli@chromium.org

2 edits in trunk/WebCore

Update FormDataList to fix style violations in old code.
https://bugs.webkit.org/show_bug.cgi?id=37689

Reviewed by Dmitry Titov.

html/FormDataList.h:

(WebCore::FormDataList::appendData):
(WebCore::FormDataList::appendBlob):

10:59 AM Changeset in webkit [57725] by andersca@apple.com

2 edits in trunk/WebCore

Fix WebKit2 build.

WebCore.base.exp:

10:18 AM Changeset in webkit [57724] by eric@webkit.org

6 edits
1 add in trunk

2010-04-16 Jay Civelli <jcivelli@chromium.org>

Reviewed by Dimitri Glazkov.

[chromium] Select popups would assert when destroyed.
https://bugs.webkit.org/show_bug.cgi?id=37436

platform/chromium/PopupMenuChromium.cpp: (WebCore::PopupContainer::PopupContainer): (WebCore::PopupContainer::showPopup): (WebCore::PopupContainer::notifyPopupHidden):
platform/chromium/PopupMenuChromium.h:

2010-04-16 Jay Civelli <jcivelli@chromium.org>

Reviewed by Dimitri Glazkov.

[chromium] Select popups would assert when destroyed.
Also adding unit-tests for the select popup code.
https://bugs.webkit.org/show_bug.cgi?id=37436

WebKit.gyp:
src/WebViewImpl.h: (WebKit::WebViewImpl::selectPopup):
tests/PopupMenuTest.cpp: Added.

10:09 AM Changeset in webkit [57723] by mitz@apple.com

3 edits in trunk/WebKit/mac

Expose the extremal shrink factors WebHTMLView uses when shrinking pages to fit in the
printing width as SPI.

Reviewed by John Sullivan.

WebView/WebHTMLView.mm:

Replaced two macros with constants.
(-[WebHTMLView _beginPrintModeWithPageWidth:shrinkToFit:]): Changed to use the constants.
(-[WebHTMLView _scaleFactorForPrintOperation:]): Ditto.

WebView/WebHTMLViewPrivate.h: Declared _WebHTMLViewPrintingMinimumShrinkFactor and

_WebHTMLViewPrintingMaximumShrinkFactor.

9:18 AM Changeset in webkit [57722] by eric@webkit.org

9 edits
3 deletes in trunk/LayoutTests

2010-04-16 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r57719.
http://trac.webkit.org/changeset/57719
https://bugs.webkit.org/show_bug.cgi?id=37708

Broke 8 URL tests on Windows due to use of file:///tmp/ URLs,
which don't work on Windows. (Requested by aroben on #webkit).

fast/url/anchor.html:
fast/url/file-expected.txt: Removed.
fast/url/file.html: Removed.
fast/url/ipv4.html:
fast/url/path-url.html:
fast/url/port.html:
fast/url/query.html:
fast/url/script-tests/TEMPLATE.html:
fast/url/script-tests/file.js: Removed.
fast/url/standard-url.html:
fast/url/trivial.html:

7:11 AM Changeset in webkit [57721] by tonikitoo@webkit.org

2 edits in trunk/WebCore

2010-04-16 Antonio Gomes <tonikitoo@webkit.org>

Unreviewed QtWebKit (with Qt 4.7) build fix.

Bug 37683 moved code from FontQt.cpp to FontPlatformDataQt.cpp but did not
renamed the variable used.

platform/graphics/qt/FontPlatformDataQt.cpp: (WebCore::FontPlatformData::FontPlatformData):

1:06 AM QtWebKitTableOfFeatures20 edited by Henry Haverinen

(diff)

12:36 AM Changeset in webkit [57720] by eric@webkit.org

5 edits in trunk

2010-04-16 Tony Chang <tony@chromium.org>

Reviewed by Dimitri Glazkov.

[chromium] build DRT on Linux
https://bugs.webkit.org/show_bug.cgi?id=37690

DEPS: Need to roll deps to remove a dependency on src/chrome
gyp_webkit: generate makefiles for DRT.gyp on Linux

2010-04-16 Tony Chang <tony@chromium.org>

Reviewed by Dimitri Glazkov.

[chromium] build DRT on Linux
https://bugs.webkit.org/show_bug.cgi?id=37690

Scripts/build-dumprendertree: Add support for win and linux

12:27 AM Changeset in webkit [57719] by mjs@apple.com

9 edits
3 adds in trunk/LayoutTests

2010-04-16 Maciej Stachowiak <mjs@apple.com>

Reviewed by Adam Barth.

Test file: URL canonicalization
https://bugs.webkit.org/show_bug.cgi?id=37700

fast/url/script-tests/file.js: Added new test.
fast/url/file-expected.txt: Added (expected results).
fast/url/file.html: Added (wrapper).

fast/url/script-tests/TEMPLATE.html: Add an explicit dependable <base> URL to the template, to avoid making test expectations system dependent.

Other test wrappers regenerated for the above change:

fast/url/anchor.html:
fast/url/ipv4.html:
fast/url/path-url.html:
fast/url/port.html:
fast/url/query.html:
fast/url/standard-url.html:
fast/url/trivial.html:

12:25 AM Changeset in webkit [57718] by eric@webkit.org

2 edits in trunk/WebCore

2010-04-16 Noam Rosenthal <noam.rosenthal@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

Make GraphicsLayerQt always use ItemCoordinateCache, and remove ItemUsesExtendedStyleOption.
This aligns our implementation with the Safari implementation - layers are always uploaded
to textures in item units, and WebCore is responsible for the heuristics.

[Qt] GraphicsLayer: performance optimizations
https://bugs.webkit.org/show_bug.cgi?id=35393

No new tests. Still no FPS benchmarks available (on any platform)
but animations are noticably better.

platform/graphics/qt/GraphicsLayerQt.cpp: (WebCore::GraphicsLayerQtImpl::GraphicsLayerQtImpl): (WebCore::GraphicsLayerQtImpl::paint): (WebCore::GraphicsLayerQtImpl::flushChanges): (WebCore::TransformAnimationQt::updateState):

12:20 AM QtWebKitRelease20 edited by Henry Haverinen