⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Apr 18, 2010:

11:36 PM Changeset in webkit [57805] by eric@webkit.org
  • 3 edits in trunk/WebKitTools

2010-04-18 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Roben.

Make failure-reason more forgiving
​https://bugs.webkit.org/show_bug.cgi?id=37525

Removed search_limit, which wasn't very useful anyway.
Added a log about the long load time loading from the builders.
Prompt the user for what revision to start walking from (makes it easy to restart upon failure).

  • Scripts/webkitpy/common/net/buildbot.py:
  • Scripts/webkitpy/tool/commands/queries.py:
10:13 PM Changeset in webkit [57804] by eric@webkit.org
  • 2 edits in trunk/JavaScriptCore

2010-04-18 Kwang Yul Seo <​skyul@company100.net>

Reviewed by Laszlo Gombos.

[WINCE] Don't define WTF_CPU_MIDDLE_ENDIAN=1
​https://bugs.webkit.org/show_bug.cgi?id=37434

Windows CE supports little-endian format only, so don't define
WTF_CPU_MIDDLE_ENDIAN=1.

  • wtf/Platform.h:
9:26 PM Changeset in webkit [57803] by Chris Jerdonek
  • 3 edits
    2 adds in trunk/WebKitTools

Created a class for check-webkit-style that encapsulates iterating
over text files and reading them.

Reviewed by Shinichiro Hamaji.

​https://bugs.webkit.org/show_bug.cgi?id=37754

This revision is an intermediate step towards separating our
style-checking code from the logic of iterating over files and
reading them.

  • Scripts/webkitpy/common/system/logtesting.py:
    • Added a logMessages() method to the LoggingTestCase class. This method provides unit tests with access to the raw list of log messages in case the tester needs to do something more than simply assert the list of existing messages.
  • Scripts/webkitpy/style/checker.py:
    • Added a ProcessorBase class that processors of lists of lines should eventually inherit from.
    • Also added a FIXME to use the ProcessorBase class and the TextFileReader class added below.
  • Scripts/webkitpy/style/filereader.py: Added.
    • Created a TextFileReader class that encapsulates reading and iterating over text files.
  • Scripts/webkitpy/style/filereader_unittest.py: Added.
    • Added a TextFileReaderTest class to unit-test the new TextFileReader class.
9:22 PM Changeset in webkit [57802] by eric@webkit.org
  • 4 edits in trunk

2010-04-18 Simon Hausmann <​simon.hausmann@nokia.com>

Reviewed by Laszlo Gombos.

[Qt] Fix JavaScriptCore's include path for WinCE builds

​https://bugs.webkit.org/show_bug.cgi?id=36751

2010-04-18 Simon Hausmann <​simon.hausmann@nokia.com>

Reviewed by Laszlo Gombos.

[Qt] Fix JavaScriptCore's include path for WinCE builds

​https://bugs.webkit.org/show_bug.cgi?id=36751

  • WebCore.pro:
9:08 PM Changeset in webkit [57801] by eric@webkit.org
  • 2 edits in trunk

2010-04-18 Michael Forney <​michael@mforney.org>

Reviewed by Laszlo Gombos.

​https://bugs.webkit.org/show_bug.cgi?id=37762

Fixes the sandbox option in configure.

  • configure.ac: Fix cut and paste error in the sandbox option causing --{enable,disable}-sandbox to be ineffective, and it to be controlled by the ruby flag.
8:26 PM Changeset in webkit [57800] by tony@chromium.org
  • 5 edits in trunk/WebKitTools

2010-04-15 Tony Chang <​tony@chromium.org>

Reviewed by Adam Barth.

[chromium] new-run-webkit-tests should be able to use chromium DRT
​https://bugs.webkit.org/show_bug.cgi?id=37645

Make sure that the lack of a chromium checkout doesn't cause the script to
fail.

  • Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
  • Scripts/webkitpy/layout_tests/port/chromium.py:
  • Scripts/webkitpy/layout_tests/port/chromium_mac.py: Fix up a few paths

to be relative to an upstream output dir.

  • Scripts/webkitpy/layout_tests/run_webkit_tests.py: Add --use-drt flag.
2:25 PM Changeset in webkit [57799] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2010-04-18 Eric Seidel <​eric@webkit.org>

Unreviewed, fixing the Qt bot.

Add a layer of indirection when calling run-webkit-tests to allow testing new-run-webkit-tests on various platforms
​https://bugs.webkit.org/show_bug.cgi?id=37632

  • Scripts/run-webkit-tests:
    • Exit non-zero of launching the harness fails.
1:58 PM Changeset in webkit [57798] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2010-04-18 Eric Seidel <​eric@webkit.org>

Unreviewed, fixing the Qt bot.

Add a layer of indirection when calling run-webkit-tests to allow testing new-run-webkit-tests on various platforms
​https://bugs.webkit.org/show_bug.cgi?id=37632

  • Scripts/run-webkit-tests:
    • Fix the wrapper to work for users who do not have WebKitTools/Scripts in their path.
1:56 PM Changeset in webkit [57797] by abarth@webkit.org
  • 2 edits in trunk/WebKitSite

2010-04-18 Adam Barth <​abarth@webkit.org>

Unreviewed. Update a label of the diagram to better match the
description in the text of the blog post.

  • blog-files/loader-diagram.svg:
1:34 PM Changeset in webkit [57796] by eric@webkit.org
  • 3 edits
    1 copy in trunk/WebKitTools

2010-04-14 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Add a layer of indirection when calling run-webkit-tests to
allow testing new-run-webkit-tests on various platforms.
​https://bugs.webkit.org/show_bug.cgi?id=37632

This will let us test and fix bugs in new-run-webkit-tests
without needing to restart the buildbot master between tests.

Currently this change leaves run-webkit-tests as-is, but once
its landed we will easily be able to turn on/off
new-run-webkit-tests for various ports/configurations.

I will send a note out to webkit-dev about how we will
be using this launcher script to test on the bots.

  • Scripts/old-run-webkit-tests: Copied from WebKitTools/Scripts/run-webkit-tests.
  • Scripts/run-webkit-tests:
    • A new script which decides whether to run new- or old- run-webkit-tests based on the platform.
  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
    • Add some dummy argument handling for arguments which old-run-webkit-tests supports but new-run-webkit-tests does not yet.
10:43 AM Changeset in webkit [57795] by eric@webkit.org
  • 3 edits in trunk/WebKitTools

2010-04-18 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Add Gtk bots to the list of "core builders" (builders which stop the commit-queue when they turn red)
​https://bugs.webkit.org/show_bug.cgi?id=33295

The Gtk builders have been green every time I've looked
at them in the last 5 days or so. It would appear webkit
is now keeping them green and we should update the core
builder list to match reality.

  • Scripts/webkitpy/common/net/buildbot.py:
  • Scripts/webkitpy/common/net/buildbot_unittest.py:
4:01 AM Changeset in webkit [57794] by robert@webkit.org
  • 4 edits
    1 add in trunk/LayoutTests

[Qt] Add support for LayoutTestController commands

2010-04-18 Robert Hogan <​robert@webkit.org>

Unreviewed fix to pixel differences in unskipped layout tests.

[Qt] Add support for LayoutTestController commands

Fix up minor pixel differences on unskipped tests from r57793.

​https://bugs.webkit.org/show_bug.cgi?id=35844

  • platform/qt/editing/deleting/smart-delete-003-expected.txt:
  • platform/qt/editing/deleting/smart-delete-004-expected.txt:
  • platform/qt/editing/selection/5195166-1-expected.txt: Copied from LayoutTests/platform/mac/editing/selection/5195166-1-expected.txt.
  • platform/qt/editing/selection/5195166-2-expected.txt:
3:36 AM Changeset in webkit [57793] by robert@webkit.org
  • 17 edits in trunk

[Qt] Add support for LayoutTestController commands
2010-04-18 Robert Hogan <​robert@webkit.org>

Reviewed by Simon Hausmann.

[Qt] Add support for LayoutTestController commands:

setSmartInsertDeleteEnabled
setSelectTrailingWhitespaceEnabled
execCommand
isCommandEnabled

​https://bugs.webkit.org/show_bug.cgi?id=35844

  • Api/qwebpage.cpp: (QWebPagePrivate::QWebPagePrivate):
  • Api/qwebpage_p.h:
  • WebCoreSupport/DumpRenderTreeSupportQt.cpp: (DumpRenderTreeSupportQt::setSmartInsertDeleteEnabled): (DumpRenderTreeSupportQt::setSelectTrailingWhitespaceEnabled): (DumpRenderTreeSupportQt::executeCoreCommandByName): (DumpRenderTreeSupportQt::isCommandEnabled):
  • WebCoreSupport/DumpRenderTreeSupportQt.h:
  • WebCoreSupport/EditorClientQt.cpp: (WebCore::EditorClientQt::smartInsertDeleteEnabled): (WebCore::EditorClientQt::toggleSmartInsertDelete): (WebCore::EditorClientQt::isSelectTrailingWhitespaceEnabled):
  • WebCoreSupport/EditorClientQt.h:

2010-04-18 Robert Hogan <​robert@webkit.org>

Reviewed by Simon Hausmann.

[Qt] Add support for LayoutTestController commands:

setSmartInsertDeleteEnabled
setSelectTrailingWhitespaceEnabled
execCommand
isCommandEnabled

Unskip tests:
editing/deleting/smart-editing-disabled.html
editing/execCommand/19089.html
editing/execCommand/delete-image-in-anchor.html
editing/execCommand/enabling-and-selection-2.html
editing/selection/doubleclick-whitespace-crash.html
editing/selection/doubleclick-whitespace-img-crash.html
editing/selection/doubleclick-whitespace.html
editing/selection/select-line.html
editing/deleting/5300379.html
editing/deleting/smart-delete-003.html
editing/deleting/smart-delete-004.html
editing/selection/5195166-1.html
editing/selection/5195166-2.html

​https://bugs.webkit.org/show_bug.cgi?id=35844

  • platform/qt/Skipped:
  • platform/qt/editing/deleting/5300379-expected.txt: Update platform-specific results.
  • platform/qt/editing/deleting/smart-delete-003-expected.txt: Update platform-specific results.
  • platform/qt/editing/deleting/smart-delete-004-expected.txt: Update platform-specific results.
  • platform/qt/editing/selection/5195166-1-expected.txt: Copied from LayoutTests/platform/mac/editing/selection/5195166-1-expected.txt.
  • platform/qt/editing/selection/5195166-2-expected.txt: Update platform-specific results.

2010-04-18 Robert Hogan <​robert@webkit.org>

Reviewed by Simon Hausmann.

[Qt] Add support for LayoutTestController commands:

setSmartInsertDeleteEnabled
setSelectTrailingWhitespaceEnabled
execCommand
isCommandEnabled

​https://bugs.webkit.org/show_bug.cgi?id=35844

  • DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::WebPage::resetSettings):
  • DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::setSmartInsertDeleteEnabled): (LayoutTestController::setSelectTrailingWhitespaceEnabled): (LayoutTestController::execCommand): (LayoutTestController::isCommandEnabled):
  • DumpRenderTree/qt/LayoutTestControllerQt.h:
3:25 AM Changeset in webkit [57792] by tonikitoo@webkit.org
  • 2 edits in trunk/LayoutTests

2010-04-18 Antonio Gomes <​tonikitoo@webkit.org>

[Qt] Unreviewed fix: remove svg/custom/clip-path-display-none-child.svg from Skipped (non-existent test)

It was removed by r57511.

  • platform/qt/Skipped:

Apr 17, 2010:

11:27 PM Changeset in webkit [57791] by abarth@webkit.org
  • 1 edit
    1 add in trunk/WebKitSite

2010-04-17 Adam Barth <​abarth@webkit.org>

Unreviewed. Added loader diagram for upcoming blog post.

  • blog-files/loader-diagram.svg: Added.
11:03 PM Changeset in webkit [57790] by ap@apple.com
  • 8 edits in trunk

Reviewed by Adam Barth.

​https://bugs.webkit.org/show_bug.cgi?id=37720
<rdar://problem/7873752> HTMLFrameSetElement-window-eventListener-attributes.html sometimes
crashes on SnowLeopard Release

Tests:

  • fast/dom/Window/HTMLBodyElement-window-eventListener-attributes.html:
  • fast/dom/Window/HTMLFrameSetElement-window-eventListener-attributes.html:
  • bindings/scripts/CodeGeneratorJS.pm: Use global object as a wrapper for window event listeners set via document.body. The body wrapper can go away if nothing else references it.
  • html/HTMLBodyElement.idl: Override listeners that exist on Element with custom implementations, because we need to use window object as a wrapper, not the element. Marked all window event listeners as such for code generator.
  • html/HTMLFrameSetElement.idl: Ditto.
10:00 PM Changeset in webkit [57789] by Joseph Pecoraro
  • 2 edits in trunk/WebCore

2010-04-17 Juan C. Montemayor <​jmonte03@cs.tufts.edu>

Reviewed by Joseph Pecoraro.

Databases pane doesn't recognize table creation/deletion
​https://bugs.webkit.org/show_bug.cgi?id=20219

  • inspector/front-end/DatabaseQueryView.js: (WebInspector.DatabaseQueryView.prototype._queryFinished):
5:42 PM Changeset in webkit [57788] by eric@webkit.org
  • 13 edits
    2 deletes in trunk/WebKitTools

2010-04-17 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Remove steps_references and commands_references
​https://bugs.webkit.org/show_bug.cgi?id=37758

We tried using the mumble_references convention to manage our
dependencies, but it doesn't seem to be providing much value for the
steps and commands module because these modules are small pieces of the
larger tool module. In this patch, I've removed the references file
for these modules.

I've left the style_references file for the style module because that
module seems better isolated from the rest of webkitpy and the
style_references file appears to be providing some value.

  • Scripts/webkitpy/tool/commands/commandtest.py:
  • Scripts/webkitpy/tool/commands/download_unittest.py:
  • Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
  • Scripts/webkitpy/tool/commands/queries_unittest.py:
  • Scripts/webkitpy/tool/commands/queues_unittest.py:
  • Scripts/webkitpy/tool/commands/queuestest.py:
  • Scripts/webkitpy/tool/commands/upload.py:
  • Scripts/webkitpy/tool/commands/upload_unittest.py:
  • Scripts/webkitpy/tool/commands_references.py: Removed.
  • Scripts/webkitpy/tool/steps/closebugforlanddiff_unittest.py:
  • Scripts/webkitpy/tool/steps/steps_unittest.py:
  • Scripts/webkitpy/tool/steps/updatechangelogswithreview_unittest.py:
  • Scripts/webkitpy/tool/steps/validatereviewer_unittest.py:
  • Scripts/webkitpy/tool/steps_references.py: Removed.
1:43 PM Changeset in webkit [57787] by eric@webkit.org
  • 7 edits in trunk/WebCore

2010-04-17 Yaar Schnitman <​yaar@chromium.org>

Reviewed by Adam Barth.

Auto-generate V8 bindings for canvas.* overloads
​https://bugs.webkit.org/show_bug.cgi?id=37453

  • bindings/v8/custom/V8CanvasRenderingContext2DCustom.cpp: Deleted custom code that is now auto-generated.
  • bindings/scripts/CodeGeneratorV8.pm: Not generating custom signatures for overloaded methods and accepting Object as a string input.
  • html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::drawImage): Added missing 9-arguments overloads for drawImage.
  • html/canvas/CanvasRenderingContext2D.h:
  • html/canvas/CanvasRenderingContext2D.idl: Overloaded methods defined (V8 only).
1:10 PM Changeset in webkit [57786] by eric@webkit.org
  • 2 edits
    1 copy
    2 adds in trunk/LayoutTests

2010-04-17 Adam Barth <​abarth@webkit.org>

Unreviewed.

Test file: URL canonicalization
​https://bugs.webkit.org/show_bug.cgi?id=37700

Re-land ​http://trac.webkit.org/changeset/57719, hopefully not breaking
the Windows bot this time.

  • fast/url/file-expected.txt: Added.
  • fast/url/file.html: Added.
  • fast/url/mailto.html:
  • fast/url/script-tests/file.js: Added.
1:00 PM Changeset in webkit [57785] by eric@webkit.org
  • 1 edit
    9 adds in trunk/LayoutTests

2010-04-17 Adam Barth <​abarth@webkit.org>

Unreviewed, but I took Jeremy Orlow's suggestions on an earlier
iteration of this patch.

Add URL parsing tests for relative URL resolution
​https://bugs.webkit.org/show_bug.cgi?id=37644

I've split the platform specific parts of this test into separate
files. On KURL-based ports these should have the same results on every
platform. We can decide whether to have platform-specific behavior at
a later time.

  • fast/url/relative-expected.txt: Added.
  • fast/url/relative-unix-expected.txt: Added.
  • fast/url/relative-unix.html: Added.
  • fast/url/relative-win-expected.txt: Added.
  • fast/url/relative-win.html: Added.
  • fast/url/relative.html: Added.
  • fast/url/script-tests/relative-unix.js: Added.
  • fast/url/script-tests/relative-win.js: Added.
  • fast/url/script-tests/relative.js: Added.
11:42 AM Changeset in webkit [57784] by eric@webkit.org
  • 9 edits
    2 moves in trunk/WebCore

2010-04-17 Yury Semikhatsky <​yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: move JavaScriptCallFrame.{h,cpp} to WebCore/bindings/js

​https://bugs.webkit.org/show_bug.cgi?id=37740

  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSBindingsAllInOne.cpp:
  • bindings/js/JavaScriptCallFrame.cpp: Renamed from WebCore/inspector/JavaScriptCallFrame.cpp. (WebCore::JavaScriptCallFrame::JavaScriptCallFrame): (WebCore::JavaScriptCallFrame::caller): (WebCore::JavaScriptCallFrame::scopeChain): (WebCore::JavaScriptCallFrame::dynamicGlobalObject): (WebCore::JavaScriptCallFrame::functionName): (WebCore::JavaScriptCallFrame::type): (WebCore::JavaScriptCallFrame::thisObject): (WebCore::JavaScriptCallFrame::evaluate):
  • bindings/js/JavaScriptCallFrame.h: Renamed from WebCore/inspector/JavaScriptCallFrame.h. (WebCore::JavaScriptCallFrame::create): (WebCore::JavaScriptCallFrame::invalidate): (WebCore::JavaScriptCallFrame::isValid): (WebCore::JavaScriptCallFrame::sourceID): (WebCore::JavaScriptCallFrame::line): (WebCore::JavaScriptCallFrame::update):
  • inspector/InjectedScriptHost.h:
  • inspector/InspectorController.h:
9:00 AM Changeset in webkit [57783] by alex
  • 2 edits in trunk/LayoutTests

2010-04-17 Alejandro G. Castro <​alex@igalia.com>

Rubber-stamped by Xan Lopez.

Skipping media/audio-constructor-preload.html
​https://bugs.webkit.org/show_bug.cgi?id=37753

  • platform/gtk/Skipped:
8:49 AM Changeset in webkit [57782] by alex
  • 2 edits in trunk/LayoutTests

2010-04-17 Alejandro G. Castro <​alex@igalia.com>

Rubber-stamped by Xan Lopez.

Skipping inspector/timeline-paint.html
​https://bugs.webkit.org/show_bug.cgi?id=37752

  • platform/gtk/Skipped:
8:16 AM Changeset in webkit [57781] by alex
  • 2 edits in trunk/WebKit/gtk

2010-04-17 Alejandro G. Castro <​alex@igalia.com>

Reviewed by Xan Lopez.

We have to initialize the timer attribute after destroying it, not
doing it was causing crashes in some situations.

  • webkit/webkitdownload.cpp: (webkit_download_finalize):
7:55 AM Changeset in webkit [57780] by eric@webkit.org
  • 5 edits
    3 adds in trunk

2010-04-17 Vangelis Kokkevis <​vangelis@chromium.org>

Reviewed by Dimitri Glazkov.

Adding definition of GLES2Context class.
​https://bugs.webkit.org/show_bug.cgi?id=37541

No new functionality implemented yet, no tests.

  • WebCore.gypi: Added GLES2Context.h
  • platform/chromium/GLES2Context.h: Added.

2010-04-17 Vangelis Kokkevis <​vangelis@chromium.org>

Reviewed by Dimitri Glazkov.

Adding the implementation of GLES2Context class which provides WebCore access to a GL ES context.
​https://bugs.webkit.org/show_bug.cgi?id=37541

  • WebKit.gyp:
  • public/WebGLES2Context.h: Added. (WebKit::WebGLES2Context::~WebGLES2Context):
  • src/GLES2Context.cpp: Added. (WebCore::GLES2ContextInternal::GLES2ContextInternal): (WebCore::GLES2ContextInternal::~GLES2ContextInternal): (WebCore::GLES2ContextInternal::getWebGLES2Context): (WebCore::GLES2ContextInternal::initialize): (WebCore::GLES2Context::create): (WebCore::GLES2Context::~GLES2Context): (WebCore::GLES2Context::initialize): (WebCore::GLES2Context::makeCurrent): (WebCore::GLES2Context::destroy): (WebCore::GLES2Context::swapBuffers):
6:37 AM Changeset in webkit [57779] by jchaffraix@webkit.org
  • 3 edits
    3 adds in trunk

Crash while handling SVG font in the wrong namespace imported with @font-face
​https://bugs.webkit.org/show_bug.cgi?id=18862

Reviewed by Darin Adler.

WebCore:

Test: fast/invalid/invalidSVGFont.html

  • loader/CachedFont.cpp:

(WebCore::CachedFont::getSVGFontById): Make sure we really get an SVGFontElement by using
getElementsByNameNS: the element factory chooses which element to create based on both
localName and namespace.

LayoutTests:

Test that load an SVG document not in the SVG namespace with @font-face does not
lead to a crash.

  • fast/invalid/invalidSVGFont-expected.txt: Added.
  • fast/invalid/invalidSVGFont.html: Added.
  • fast/invalid/resources/svgFontWrongNamespace.svg: Added.
1:13 AM Changeset in webkit [57778] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2010-04-17 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

WebKit needs a Chromium Mac EWS Builder
​https://bugs.webkit.org/show_bug.cgi?id=37742

  • Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1:02 AM Changeset in webkit [57777] by abarth@webkit.org
  • 2 edits in trunk/WebKitTools

2010-04-17 Adam Barth <​abarth@webkit.org>

Fix expected results for unit test broken by
​http://trac.webkit.org/changeset/57772

  • Scripts/webkitpy/common/net/buildbot_unittest.py:
Note: See TracTimeline for information about the timeline view.