Timeline
Apr 23, 2010:
- 10:17 PM Changeset in webkit [58209] by
-
- 5 edits in trunk
2010-04-23 Zhenyao Mo <zmo@google.com>
Reviewed by Darin Fisher.
Add isGLES2Compliant to GraphicsContext3D: make the method const.
https://bugs.webkit.org/show_bug.cgi?id=37872
- platform/graphics/GraphicsContext3D.h: Make isGLES2Compliant() const.
- platform/graphics/mac/GraphicsContext3DMac.cpp: Ditto. (WebCore::GraphicsContext3D::isGLES2Compliant):
2010-04-23 Zhenyao Mo <zmo@google.com>
Reviewed by Darin Fisher.
Add isGLES2Compliant to GraphicsContext3D: make the method const.
https://bugs.webkit.org/show_bug.cgi?id=37872
- src/GraphicsContext3D.cpp: Make isGLES2Compliant() const. (WebCore::GraphicsContext3DInternal::isGLES2Compliant): (WebCore::GraphicsContext3D::isGLES2Compliant):
- 8:36 PM Changeset in webkit [58208] by
-
- 3 edits in trunk/LayoutTests
2010-04-23 Ben Murdoch <benm@google.com>
Reviewed by Jeremy Orlow.
[Android] The touchmove delta used in basic-single-touch-events.html is too small for Android
https://bugs.webkit.org/show_bug.cgi?id=38056
- fast/events/touch/basic-single-touch-events-expected.txt:
- update the test expected output
- fast/events/touch/script-tests/basic-single-touch-events.js: (verifyTouch): update test expectation with new coordinates. (singleTouchSequence): increase the touch move delta. (touchTargets): Start the touch at a different point to
singleTouchSequence to make examining behavior easier.
- 8:27 PM Changeset in webkit [58207] by
-
- 3 edits1 delete in trunk
2010-04-23 Qi Zhang <qi.2.zhang@nokia.com>
Reviewed by Laszlo Gombos.
[Qt] LayoutTests/fast/canvas/pointInPath.html passed, actually it failed
https://bugs.webkit.org/show_bug.cgi?id=37276
pointInPath.html passed because the expected.txt expect it fail, it is wrong.
- platform/qt/fast/canvas/pointInPath-expected.txt: Removed.
2010-04-23 Qi Zhang <qi.2.zhang@nokia.com>
Reviewed by Laszlo Gombos.
[Qt] LayoutTests/fast/canvas/pointInPath.html passed, actually it failed
https://bugs.webkit.org/show_bug.cgi?id=37276
QPainterPath::contains doesn't count the point on the bound.
- platform/graphics/qt/PathQt.cpp: (WebCore::isPointOnPathBorder): (WebCore::Path::contains):
- 6:07 PM Changeset in webkit [58206] by
-
- 9 edits3 copies9 adds in trunk
Fix for https://bugs.webkit.org/show_bug.cgi?id=38060
Split up Threading.h
Reviewed by David Levin.
Move bits for of Threading.h into 3 new files.
- Atomics.h for atomic operations.
- ThreadSafeShared.h for the ThreadSafeShared class.
- ThreadingPrimitives.h for the primitives and platform types.
Basic threading operations (creation, etc.) remain in Threading.h.
- GNUmakefile.am:
- JavaScriptCore.gypi:
- JavaScriptCore.vcproj/WTF/WTF.vcproj:
- JavaScriptCore.xcodeproj/project.pbxproj:
- wtf/Atomics.h: Copied from wtf/Threading.h.
- wtf/ThreadSafeShared.h: Copied from wtf/Threading.h.
- wtf/Threading.h:
- wtf/ThreadingPrimitives.h: Copied from wtf/Threading.h.
JavaScriptGlue:
Add necessary forwarding headers.
- ForwardingHeaders/wtf/Atomics.h: Added.
- ForwardingHeaders/wtf/ThreadSafeShared.h: Added.
- ForwardingHeaders/wtf/ThreadingPrimitives.h: Added.
WebCore:
Add necessary forwarding headers.
- ForwardingHeaders/wtf/Atomics.h: Added.
- ForwardingHeaders/wtf/ThreadSafeShared.h: Added.
- ForwardingHeaders/wtf/ThreadingPrimitives.h: Added.
WebKitTools:
Add necessary forwarding headers.
- DumpRenderTree/ForwardingHeaders/wtf/Atomics.h: Added.
- DumpRenderTree/ForwardingHeaders/wtf/ThreadSafeShared.h: Added.
- DumpRenderTree/ForwardingHeaders/wtf/ThreadingPrimitives.h: Added.
- 6:05 PM Changeset in webkit [58205] by
-
- 4 edits1 add in trunk
2010-04-23 Rafael Weinstein <rafaelw@grafaelw.sfo.corp.google.com>
Reviewed by Darin Fisher.
This patch adds a vector of additionalFeatures to WindowFeatures
and populates it with any feature strings that evaluate to "yes"
and aren't directly observed in WindowFeatures. This allows
clients to capture experimental window features.
- page/WindowFeatures.cpp: (WebCore::WindowFeatures::setWindowFeature):
- page/WindowFeatures.h:
2010-04-23 Rafael Weinstein <rafaelw@grafaelw.sfo.corp.google.com>
Reviewed by Darin Fisher.
This patch adds a WebWindowFeatures binding struct for the
chromium client in anticipation of a follow-on patch which will
pass it to WebViewClient::createWindow.
- public/WebViewClient.h: (WebKit::WebViewClient::createView):
- public/WebWindowFeatures.h: Added. (WebKit::WebWindowFeatures::WebWindowFeatures):
- src/ChromeClientImpl.cpp: (WebKit::ChromeClientImpl::createWindow):
- 5:54 PM Changeset in webkit [58204] by
-
- 2 edits in trunk/WebKitTools
2010-04-23 Xiaomei Ji <xji@chromium.org>
No need to review.
Add xji as committer.
- Scripts/webkitpy/common/config/committers.py:
- 5:48 PM Changeset in webkit [58203] by
-
- 3 edits2 adds in trunk
2010-04-23 Simon Fraser <Simon Fraser>
Reviewed by Dan Bernstein.
ASSERT(willBeComposited == needsToBeComposited(layer)); on gmail.com
https://bugs.webkit.org/show_bug.cgi?id=38066
When a layer goes into compositing mode because it has a negative z-index child that is going
into compositing mode, then set willBeComposited to true. Also add another assertion to catch
any other cases where the state of willBeComposited is mismanaged.
Test: compositing/composited-negative-zindex-child.html
- rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::computeCompositingRequirements):
- 5:48 PM Changeset in webkit [58202] by
-
- 2 edits in trunk/WebKit/mac
2010-04-23 Simon Fraser <Simon Fraser>
Reviewed by Anders Carlsson.
<rdar://problem/7894489> When printing Flash, send a drawRect event, rather than NPPrint
When printing Flash plug-ins in 32-bit, send a drawRect event with a CGContextRef, rather than calling
NPPrint with a GWorldPtr, since Flash prefers the CGContext path.
- Plugins/WebNetscapePluginView.mm: (-[WebNetscapePluginView drawRect:]):
- 5:16 PM Changeset in webkit [58201] by
-
- 3 edits4 adds in trunk
<rdar://problem/7898436> :after content is duplicated
Reviewed by Simon Fraser.
WebCore:
Test: fast/css-generated-content/after-duplicated-after-split.html
- rendering/RenderInline.cpp:
(WebCore::RenderInline::splitInlines): Pass the correct owner of the child list.
LayoutTests:
- fast/css-generated-content/after-duplicated-after-split.html: Added.
- platform/mac/fast/css-generated-content/after-duplicated-after-split-expected.checksum: Added.
- platform/mac/fast/css-generated-content/after-duplicated-after-split-expected.png: Added.
- platform/mac/fast/css-generated-content/after-duplicated-after-split-expected.txt: Added.
- 5:12 PM Changeset in webkit [58200] by
-
- 2 edits in trunk/WebKitTools
[wx] Build fix, add platform stub for new LayoutTestController method.
- 5:02 PM Changeset in webkit [58199] by
-
- 5 edits1 copy5 moves1 delete in trunk/WebKit2
https://bugs.webkit.org/show_bug.cgi?id=38065
Merge mac and win DrawingAreaProxyUpdateChunk implementations.
Reviewed by Anders Carlsson.
- UIProcess/API/mac/WKView.mm:
(-[WKView drawRect:]):
- UIProcess/DrawingAreaProxy.cpp: Copied from UIProcess/mac/DrawingAreaProxy.mm.
- UIProcess/DrawingAreaProxy.h: Copied from UIProcess/mac/DrawingAreaProxy.h.
- UIProcess/DrawingAreaProxyUpdateChunk.cpp: Copied from UIProcess/mac/DrawingAreaProxyUpdateChunk.mm.
(WebKit::DrawingAreaProxyUpdateChunk::DrawingAreaProxyUpdateChunk):
(WebKit::DrawingAreaProxyUpdateChunk::paint):
(WebKit::DrawingAreaProxyUpdateChunk::setSize):
(WebKit::DrawingAreaProxyUpdateChunk::didSetSize):
(WebKit::DrawingAreaProxyUpdateChunk::update):
(WebKit::DrawingAreaProxyUpdateChunk::didReceiveMessage):
- UIProcess/DrawingAreaProxyUpdateChunk.h: Copied from UIProcess/mac/DrawingAreaProxyUpdateChunk.h.
- UIProcess/mac/DrawingAreaProxy.h: Removed.
- UIProcess/mac/DrawingAreaProxy.mm: Removed.
- UIProcess/mac/DrawingAreaProxyUpdateChunk.h: Removed.
- UIProcess/mac/DrawingAreaProxyUpdateChunk.mm: Removed.
- UIProcess/mac/DrawingAreaProxyUpdateChunkMac.mm: Copied from UIProcess/mac/DrawingAreaProxyUpdateChunk.mm.
(WebKit::DrawingAreaProxyUpdateChunk::page):
(WebKit::DrawingAreaProxyUpdateChunk::invalidateBackingStore):
(WebKit::DrawingAreaProxyUpdateChunk::platformPaint):
(WebKit::DrawingAreaProxyUpdateChunk::drawUpdateChunkIntoBackingStore):
- UIProcess/win/DrawingAreaProxy.cpp: Removed.
- UIProcess/win/DrawingAreaProxy.h: Removed.
- UIProcess/win/DrawingAreaProxyUpdateChunkWin.cpp: Copied from UIProcess/win/DrawingAreaProxy.cpp.
(WebKit::DrawingAreaProxyUpdateChunk::page):
(WebKit::DrawingAreaProxyUpdateChunk::ensureBackingStore):
(WebKit::DrawingAreaProxyUpdateChunk::invalidateBackingStore):
(WebKit::DrawingAreaProxyUpdateChunk::platformPaint):
(WebKit::DrawingAreaProxyUpdateChunk::drawUpdateChunkIntoBackingStore):
- UIProcess/win/WebView.cpp:
(WebKit::WebView::WebView):
(WebKit::WebView::onPaintEvent):
- WebKit2.xcodeproj/project.pbxproj:
- win/WebKit2.vcproj:
- 4:50 PM Changeset in webkit [58198] by
-
- 2 edits in trunk/LayoutTests
2010-04-23 Xiaomei Ji <xji@chromium.org>
Reviewed by Eric Seidel
QT does not support textInputController.firstRectForCharacterRange(),
so, skip editing/inserting/caret-position.html for QT.
https://bugs.webkit.org/show_bug.cgi?id=25319
- platform/qt/Skipped:
- 4:21 PM Changeset in webkit [58197] by
-
- 2 edits in trunk/WebCore
Fixing the Tiger build for real.
- platform/graphics/mac/SimpleFontDataMac.mm:
- 4:08 PM Changeset in webkit [58196] by
-
- 2 edits in trunk/WebCore
Fixing the Tiger build.
- platform/graphics/mac/SimpleFontDataMac.mm:
(WebCore::SimpleFontData::platformBoundsForGlyph):
- 3:31 PM Changeset in webkit [58195] by
-
- 1 edit2 adds in trunk/LayoutTests
2010-04-23 MORITA Hajime <morrita@google.com>
Not reviewed. Added missing expectation files for
https://bugs.webkit.org/show_bug.cgi?id=37187
- platform/mac/svg/custom/broken-internal-references-expected.checksum: Added.
- platform/mac/svg/custom/broken-internal-references-expected.png: Added.
- 3:20 PM Changeset in webkit [58194] by
-
- 13 edits2 adds in trunk/WebCore
Add FileError for File API.
https://bugs.webkit.org/show_bug.cgi?id=37840
Reviewed by Dmitry Titov.
The test will be added when implementing FileReader and FilerWriter.
- Android.derived.jscbindings.mk:
- Android.derived.v8bindings.mk:
- DerivedSources.cpp:
- DerivedSources.make:
- GNUmakefile.am:
- WebCore.gypi:
- WebCore.pri:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- dom/ExceptionCode.h:
(WebCore::):
- html/FileError.h: Added.
- html/FileError.idl: Added.
- page/DOMWindow.idl:
- 3:20 PM Changeset in webkit [58193] by
-
- 5 edits in trunk/WebCore
Improve code generator scripts to handle OR ('|') condition in the
extended attributes.
https://bugs.webkit.org/show_bug.cgi?id=37998
Reviewed by Adam Barth.
- bindings/scripts/CodeGeneratorJS.pm:
- bindings/scripts/CodeGeneratorObjC.pm:
- bindings/scripts/CodeGeneratorV8.pm:
- bindings/scripts/IDLStructure.pm:
- 3:16 PM Changeset in webkit [58192] by
-
- 21 edits1 delete in trunk/WebCore
Fix for <rdar://problem/7855777> REGRESSION: Memory usage increase caused by storing glyph bounds in GlyphMetricsMap
https://bugs.webkit.org/show_bug.cgi?id=37936
Reviewed by Dan Bernstein.
This change breaks the GlyphMetricsMap into two maps - one for width and one for bounds, so that we don't store
a FloatRect for the glyph bounds unless we need to.
Covered by existing tests. This should not cause any change in functionality.
Updated for removal of GlyphMetricsMap.cpp
- Android.mk:
- GNUmakefile.am:
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
Made GlyphMetricsMap a template, so it can be used for separate width and bounds maps.
- platform/graphics/GlyphMetricsMap.cpp: Removed.
- platform/graphics/GlyphMetricsMap.h:
(WebCore::GlyphMetricsMap::metricsForGlyph):
(WebCore::GlyphMetricsMap::setMetricsForGlyph):
(WebCore::GlyphMetricsMap::GlyphMetricsPage::metricsForGlyph):
(WebCore::GlyphMetricsMap::GlyphMetricsPage::setMetricsForGlyph):
(WebCore::GlyphMetricsMap::GlyphMetricsPage::setMetricsForIndex):
(WebCore::::unknownMetrics):
(WebCore::::locatePageSlowCase):
- platform/graphics/mac/ComplexTextController.cpp: (WebCore::ComplexTextController::adjustGlyphsAndAdvances):
Call boundsForGlyph instead of metricsForGlyph.
- platform/graphics/win/UniscribeController.cpp: (WebCore::UniscribeController::shapeAndPlaceItem):
ditto.
- platform/graphics/SimpleFontData.cpp: (WebCore::SimpleFontData::platformGlyphInit):
Call setMetricsForGlyph for both glyph maps.
Break getters and setters for metricsForGlyph into widthForGlyph and boundsForGlyph, maintaining present behavior.
- platform/graphics/SimpleFontData.h:
(WebCore::):
(WebCore::SimpleFontData::boundsForGlyph):
(WebCore::SimpleFontData::widthForGlyph):
- platform/graphics/cairo/SimpleFontDataCairo.cpp:
(WebCore::SimpleFontData::platformBoundsForGlyph):
(WebCore::SimpleFontData::platformWidthForGlyph):
- platform/graphics/chromium/SimpleFontDataChromiumWin.cpp:
(WebCore::SimpleFontData::platformBoundsForGlyph):
(WebCore::SimpleFontData::platformWidthForGlyph):
- platform/graphics/chromium/SimpleFontDataLinux.cpp:
(WebCore::SimpleFontData::platformBoundsForGlyph):
(WebCore::SimpleFontData::platformWidthForGlyph):
- platform/graphics/gtk/SimpleFontDataPango.cpp:
(WebCore::SimpleFontData::platformBoundsForGlyph):
(WebCore::SimpleFontData::platformWidthForGlyph):
- platform/graphics/mac/SimpleFontDataMac.mm:
(WebCore::SimpleFontData::platformBoundsForGlyph):
(WebCore::SimpleFontData::platformWidthForGlyph):
- platform/graphics/win/SimpleFontDataCGWin.cpp:
(WebCore::SimpleFontData::platformBoundsForGlyph):
(WebCore::SimpleFontData::platformWidthForGlyph):
- platform/graphics/win/SimpleFontDataCairoWin.cpp:
(WebCore::SimpleFontData::platformBoundsForGlyph):
- platform/graphics/win/SimpleFontDataWin.cpp:
(WebCore::SimpleFontData::boundsForGDIGlyph):
(WebCore::SimpleFontData::widthForGDIGlyph):
- platform/graphics/wince/SimpleFontDataWince.cpp:
(WebCore::SimpleFontData::platformBoundsForGlyph):
- platform/graphics/wx/SimpleFontDataWx.cpp:
(WebCore::SimpleFontData::platformBoundsForGlyph):
(WebCore::SimpleFontData::platformWidthForGlyph):
- 3:07 PM Changeset in webkit [58191] by
-
- 4 edits2 adds in trunk
2010-04-23 Xiaomei Ji <xji@chromium.org>
Reviewed by Dan Bernstein and Darin Adler
Fix issue "caret does not paint after type in characters in right
aligned div or after delete all characters in RTL div or
0px right padding RTL textarea"
https://bugs.webkit.org/show_bug.cgi?id=25319
Test: editing/inserting/caret-position.html
- rendering/RenderText.cpp: (WebCore::RenderText::localCaretRect):
2010-04-23 Xiaomei Ji <xji@chromium.org>
Reviewed by Dan Bernstein and Darin Adler
Fix issue "caret does not paint after type in characters in right
aligned div or after delete all characters in RTL div or
0px right padding RTL textarea"
https://bugs.webkit.org/show_bug.cgi?id=25319
- editing/inserting/caret-position-expected.txt: Added.
- editing/inserting/caret-position.html: Added.
- platform/mac/editing/input/caret-primary-bidi-expected.txt:
- 3:02 PM Changeset in webkit [58190] by
-
- 2 edits in trunk/WebCore
2010-04-23 No'am Rosenthal <noam.rosenthal@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] [Performance] GraphicsLayer: constructing the layers takes too long
https://bugs.webkit.org/show_bug.cgi?id=36365
The issue came from using QGraphicsView's cache as is. The problem is that
several code-paths require re-rendering of the item, but not re-rendering
of the web content into the cache.
The way to solve it is by having GraphicsLayerQt manage the cache directly
via QPixmapCache, instead of using QGraphicsItem cache modes.
FPS measurement shows significant improvement (20FPS before, 40FPS after)
on several use-cases, including blog-files/leaves on a desktop environment.
- platform/graphics/qt/GraphicsLayerQt.cpp: (WebCore::GraphicsLayerQtImpl::GraphicsLayerQtImpl): (WebCore::GraphicsLayerQtImpl::recache): (WebCore::GraphicsLayerQtImpl::paint): (WebCore::GraphicsLayerQtImpl::flushChanges):
- 2:58 PM Changeset in webkit [58189] by
-
- 5 edits1 copy3 moves1 delete in trunk/WebKit2
Fix for https://bugs.webkit.org/show_bug.cgi?id=38059
Merge mac and win DrawingAreaUpdateChunk implementation.
Reviewed by Anders Carlsson.
- UIProcess/win/DrawingAreaProxy.cpp:
(WebKit::DrawingAreaProxy::didSetSize):
(WebKit::DrawingAreaProxy::didReceiveMessage):
- UIProcess/win/DrawingAreaProxy.h:
- WebKit2.xcodeproj/project.pbxproj:
- WebProcess/WebPage/DrawingAreaUpdateChunk.cpp: Copied from WebProcess/WebPage/mac/DrawingAreaUpdateChunk.cpp.
(WebKit::DrawingAreaUpdateChunk::setSize):
- WebProcess/WebPage/DrawingAreaUpdateChunk.h: Copied from WebProcess/WebPage/mac/DrawingAreaUpdateChunk.h.
- WebProcess/WebPage/mac/DrawingAreaUpdateChunk.cpp: Removed.
- WebProcess/WebPage/mac/DrawingAreaUpdateChunk.h: Removed.
- WebProcess/WebPage/mac/DrawingAreaUpdateChunkMac.cpp: Copied from WebProcess/WebPage/mac/DrawingAreaUpdateChunk.cpp.
- WebProcess/WebPage/win/DrawingAreaUpdateChunk.cpp: Removed.
- WebProcess/WebPage/win/DrawingAreaUpdateChunk.h: Removed.
- WebProcess/WebPage/win/DrawingAreaUpdateChunkWin.cpp: Copied from WebProcess/WebPage/win/DrawingAreaUpdateChunk.cpp.
(WebKit::DrawingAreaUpdateChunk::paintIntoUpdateChunk):
- win/WebKit2.vcproj:
- 2:13 PM Changeset in webkit [58188] by
-
- 2 edits in trunk/WebCore
2010-04-23 James Robinson <jamesr@chromium.org>
Reviewed by Dimitri Glazkov.
Avoid marking symbols as dllexport in chromium win builds
https://bugs.webkit.org/show_bug.cgi?id=38058
No new tests.
- config.h:
- 1:39 PM Changeset in webkit [58187] by
-
- 6 edits2 adds in trunk
2010-04-23 MORITA Hajime <morrita@google.com>
Reviewed by Nikolas Zimmermann.
https://bugs.webkit.org/show_bug.cgi?id=37187
SVG <use href="foo"> is interpreted as <use href="#foo">
getTarget() did return url parameter as is if doesn't have
fragment identifier. So fixed to return empty string in such case
because we need to distinguish "yyy.html" from "xxx.svg#yyy.html".
Test: svg/custom/broken-internal-references.svg
- svg/SVGElement.cpp: (WebCore::SVGElement::insertedIntoDocument):
- svg/SVGURIReference.cpp: (WebCore::SVGURIReference::getTarget):
2010-04-23 MORITA Hajime <morrita@google.com>
Reviewed by Nikolas Zimmermann.
https://bugs.webkit.org/show_bug.cgi?id=37187
SVG <use href="foo"> is interpreted as <use href="#foo">
- platform/mac/svg/custom/broken-internal-references-expected.checksum: Added.
- platform/mac/svg/custom/broken-internal-references-expected.png: Added.
- platform/mac/svg/custom/broken-internal-references-expected.txt: Added.
- svg/custom/broken-internal-references.svg: Added.
- svg/dynamic-updates/SVGTRefElement-dom-href-attr-expected.txt:
- svg/dynamic-updates/script-tests/SVGTRefElement-dom-href-attr.js: (executeTest): Updated to follow this fix. href value should be an URL, not an id.
- 1:22 PM Changeset in webkit [58186] by
-
- 4 edits in trunk/WebCore
2010-04-23 Simon Fraser <Simon Fraser>
Reviewed by Dan Bernstein.
When webkitAnimationEnd event fires, on-screen rendering should show the last frame of animation
https://bugs.webkit.org/show_bug.cgi?id=37955
After r37484, animation and transition end events were fired on a timer, after the animation/transition
ended. This opened up one event loop cycle in which the non-animating state of the element was visible
before the event fired, resulting in flashes in content that reset style from the event handler.
Fix by firing these events in the same event cycle as the animation end, once all animations
have been updated. This also required moving the place that start animations are fixed until
a later state in the state machine, so that animations have their start time set at the point
the event is fired (to avoid an assertion when using the freeze API in DRT).
Not testable, since the flash is very transitory and cannot be captured in a pixel test.
- page/animation/AnimationBase.cpp: (WebCore::AnimationBase::updateStateMachine): Move the firing of 'start' events into the state where the start time is known.
- page/animation/AnimationControllerPrivate.h:
- page/animation/AnimationController.cpp: (WebCore::AnimationControllerPrivate::updateStyleIfNeededDispatcherFired): Call the new fireEventsAndUpdateStyle() method. (WebCore::AnimationControllerPrivate::fireEventsAndUpdateStyle): New method to share code that used to be in updateStyleIfNeededDispatcherFired(). (WebCore::AnimationControllerPrivate::animationTimerFired): Call fireEventsAndUpdateStyle() once we've processed all animations.
- 1:22 PM Changeset in webkit [58185] by
-
- 2 edits in trunk/WebCore
2010-04-23 Simon Fraser <Simon Fraser>
Reviewed by Dan Bernstein.
CompositeAnimation::updateKeyframeAnimations() can make a KeyframeAnimation for animation "none"
https://bugs.webkit.org/show_bug.cgi?id=38017
Check to see if the animation name is "none", and don't fire off a keyframe animation in
that case.
- page/animation/CompositeAnimation.cpp: (WebCore::CompositeAnimation::updateKeyframeAnimations):
- 1:10 PM Changeset in webkit [58184] by
-
- 2 edits in trunk/WebKit2
Remove an assert. (It's not valid when resizing).
Reviewed by Sam Weinig.
- WebProcess/WebPage/win/DrawingAreaUpdateChunk.cpp:
(WebKit::DrawingAreaUpdateChunk::didUpdate):
- 12:43 PM Changeset in webkit [58183] by
-
- 2 edits in trunk/WebKitTools
2010-04-19 Dirk Pranke <dpranke@chromium.org>
Reviewed by Adam Barth.
new-run-webkit-tests: add a "--retry-failures" flag and a
"--no-retry-failures" flag (the former is the default). Also, rename
"--print-unexpected-results" and "--retry-unexpected-results" to
"--print-last-failures" and "--retry-last-failures" because the
retry flag was confusing. The new flag names aren't great, but
hopefully they're less confusing.
- Scripts/webkitpy/layout_tests/run_webkit_tests.py:
- 12:35 PM Changeset in webkit [58182] by
-
- 45 edits in trunk/LayoutTests
2010-04-23 Adam Langley <agl@chromium.org>
Unreviewed, expectations update.
Merging Skia r526 lead to a number of pixels changing color by 1 in
layout tests. This is the rebaseline for Windows and Linux. (Mac isn't
using Skia for this.)
- platform/chromium-linux/css2.1/t0803-c5505-mrgn-00-b-ag-expected.checksum:
- platform/chromium-linux/css2.1/t0803-c5505-mrgn-00-b-ag-expected.png:
- platform/chromium-linux/css2.1/t0804-c5509-padn-l-03-f-g-expected.checksum:
- platform/chromium-linux/css2.1/t0804-c5509-padn-l-03-f-g-expected.png:
- platform/chromium-linux/fast/dom/Window/btoa-pnglet-expected.checksum:
- platform/chromium-linux/fast/dom/Window/btoa-pnglet-expected.png:
- platform/chromium-linux/fast/replaced/image-solid-color-with-alpha-expected.checksum:
- platform/chromium-linux/fast/replaced/image-solid-color-with-alpha-expected.png:
- platform/chromium-linux/tables/mozilla/bugs/bug10565-expected.checksum:
- platform/chromium-linux/tables/mozilla/bugs/bug10565-expected.png:
- platform/chromium-linux/tables/mozilla/bugs/bug10633-expected.checksum:
- platform/chromium-linux/tables/mozilla/bugs/bug10633-expected.png:
- platform/chromium-linux/tables/mozilla/bugs/bug14323-expected.checksum:
- platform/chromium-linux/tables/mozilla/bugs/bug14323-expected.png:
- platform/chromium-linux/tables/mozilla/bugs/bug16012-expected.checksum:
- platform/chromium-linux/tables/mozilla/bugs/bug16012-expected.png:
- platform/chromium-linux/tables/mozilla/bugs/bug20804-expected.checksum:
- platform/chromium-linux/tables/mozilla/bugs/bug20804-expected.png:
- platform/chromium-linux/tables/mozilla/bugs/bug4427-expected.checksum:
- platform/chromium-linux/tables/mozilla/bugs/bug4427-expected.png:
- platform/chromium-linux/tables/mozilla/bugs/bug4803-expected.checksum:
- platform/chromium-linux/tables/mozilla/bugs/bug4803-expected.png:
- platform/chromium-win/css2.1/t0803-c5505-mrgn-00-b-ag-expected.checksum:
- platform/chromium-win/css2.1/t0803-c5505-mrgn-00-b-ag-expected.png:
- platform/chromium-win/css2.1/t0804-c5509-padn-l-03-f-g-expected.checksum:
- platform/chromium-win/css2.1/t0804-c5509-padn-l-03-f-g-expected.png:
- platform/chromium-win/fast/dom/Window/btoa-pnglet-expected.checksum:
- platform/chromium-win/fast/dom/Window/btoa-pnglet-expected.png:
- platform/chromium-win/fast/replaced/image-solid-color-with-alpha-expected.checksum:
- platform/chromium-win/fast/replaced/image-solid-color-with-alpha-expected.png:
- platform/chromium-win/tables/mozilla/bugs/bug10565-expected.checksum:
- platform/chromium-win/tables/mozilla/bugs/bug10565-expected.png:
- platform/chromium-win/tables/mozilla/bugs/bug10633-expected.checksum:
- platform/chromium-win/tables/mozilla/bugs/bug10633-expected.png:
- platform/chromium-win/tables/mozilla/bugs/bug14323-expected.checksum:
- platform/chromium-win/tables/mozilla/bugs/bug14323-expected.png:
- platform/chromium-win/tables/mozilla/bugs/bug16012-expected.checksum:
- platform/chromium-win/tables/mozilla/bugs/bug16012-expected.png:
- platform/chromium-win/tables/mozilla/bugs/bug20804-expected.checksum:
- platform/chromium-win/tables/mozilla/bugs/bug20804-expected.png:
- platform/chromium-win/tables/mozilla/bugs/bug4427-expected.checksum:
- platform/chromium-win/tables/mozilla/bugs/bug4427-expected.png:
- platform/chromium-win/tables/mozilla/bugs/bug4803-expected.checksum:
- platform/chromium-win/tables/mozilla/bugs/bug4803-expected.png:
- 12:11 PM Changeset in webkit [58181] by
-
- 2 edits in trunk/JavaScriptCore
Fix Qt build.
- wtf/qt/MainThreadQt.cpp: #include <QThread>
- 12:01 PM Changeset in webkit [58180] by
-
- 3 edits in trunk/WebKit2
Fix build.
- UIProcess/win/DrawingAreaProxy.cpp:
(WebKit::DrawingAreaProxy::paint):
(WebKit::DrawingAreaProxy::setSize):
(WebKit::DrawingAreaProxy::didReceiveMessage):
- WebProcess/WebPage/win/DrawingAreaUpdateChunk.cpp:
(WebKit::DrawingAreaUpdateChunk::setSize):
(WebKit::DrawingAreaUpdateChunk::didReceiveMessage):
- 11:59 AM Changeset in webkit [58179] by
-
- 13 edits2 adds in trunk
Fix for https://bugs.webkit.org/show_bug.cgi?id=38022
Move isMainThread predicate function to MainThread.h
Reviewed by Anders Carlsson.
- wtf/MainThread.cpp:
(WTF::initializeMainThread):
(WTF::isMainThread):
- wtf/MainThread.h:
- wtf/Threading.h:
- wtf/ThreadingPthreads.cpp:
(WTF::initializeThreading):
- wtf/ThreadingWin.cpp:
(WTF::initializeThreading):
- wtf/gtk/ThreadingGtk.cpp:
(WTF::initializeThreading):
- wtf/mac/MainThreadMac.mm:
(WTF::initializeMainThreadPlatform):
(WTF::isMainThread):
- wtf/qt/MainThreadQt.cpp:
(WTF::isMainThread):
- wtf/qt/ThreadingQt.cpp:
(WTF::initializeThreading):
- wtf/text/AtomicString.cpp:
JavaScriptGlue:
Added forwarding header for MainThread.h
- ForwardingHeaders/wtf/MainThread.h: Added.
WebKitTools:
Added forwarding header for MainThread.h
- DumpRenderTree/ForwardingHeaders/wtf/MainThread.h: Added.
- 11:31 AM Changeset in webkit [58178] by
-
- 4 edits in trunk
2010-04-23 Laszlo Gombos <Laszlo Gombos>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Disable Netscape plugin support for minimal configuration
https://bugs.webkit.org/show_bug.cgi?id=38026
No new tests, as there is no new functionality.
- WebCore.pri:
2010-04-23 Laszlo Gombos <Laszlo Gombos>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Disable Netscape plugin support for minimal configuration
https://bugs.webkit.org/show_bug.cgi?id=38026
Pass the minimal configuration option to Qt build system
as part of the CONFIG variable.
- Scripts/build-webkit:
- 10:33 AM Changeset in webkit [58177] by
-
- 21 edits in trunk/WebCore
2010-04-23 Shinichiro Hamaji <hamaji@chromium.org>
Reviewed by Darin Adler.
Need borderAndPadding(Width|Height)
https://bugs.webkit.org/show_bug.cgi?id=38046
Refactoring only, so no new tests.
- rendering/InlineBox.cpp: (WebCore::InlineBox::height):
- rendering/RenderApplet.cpp: (WebCore::RenderApplet::createWidgetIfNecessary):
- rendering/RenderBlock.cpp: (WebCore::RenderBlock::isSelfCollapsingBlock): (WebCore::RenderBlock::calcPrefWidths):
- rendering/RenderBox.cpp: (WebCore::RenderBox::calcBorderBoxWidth): (WebCore::RenderBox::calcBorderBoxHeight): (WebCore::RenderBox::calcContentBoxWidth): (WebCore::RenderBox::calcContentBoxHeight): (WebCore::RenderBox::calcWidth): (WebCore::RenderBox::calcHeight): (WebCore::RenderBox::calcPercentageHeight): (WebCore::RenderBox::calcReplacedHeightUsing): (WebCore::RenderBox::availableHeightUsing): (WebCore::RenderBox::calcAbsoluteHorizontal): (WebCore::RenderBox::calcAbsoluteVertical): (WebCore::RenderBox::calcAbsoluteHorizontalReplaced): (WebCore::RenderBox::calcAbsoluteVerticalReplaced): (WebCore::RenderBox::positionForPoint):
- rendering/RenderBoxModelObject.h: (WebCore::RenderBoxModelObject::borderAndPaddingHeight): (WebCore::RenderBoxModelObject::borderAndPaddingWidth):
- rendering/RenderDataGrid.cpp: (WebCore::RenderDataGrid::calcPrefWidths):
- rendering/RenderFieldset.cpp: (WebCore::RenderFieldset::calcPrefWidths):
- rendering/RenderFileUploadControl.cpp: (WebCore::RenderFileUploadControl::calcPrefWidths):
- rendering/RenderFlexibleBox.cpp: (WebCore::RenderFlexibleBox::calcPrefWidths): (WebCore::RenderFlexibleBox::allowedChildFlex):
- rendering/RenderImage.cpp: (WebCore::RenderImage::calcPrefWidths):
- rendering/RenderLayer.cpp: (WebCore::RenderLayer::resize):
- rendering/RenderListBox.cpp: (WebCore::RenderListBox::calcPrefWidths): (WebCore::RenderListBox::calcHeight):
- rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::calcPrefWidths):
- rendering/RenderReplaced.cpp: (WebCore::RenderReplaced::calcPrefWidths):
- rendering/RenderSVGRoot.cpp: (WebCore::RenderSVGRoot::calcPrefWidths):
- rendering/RenderSlider.cpp: (WebCore::RenderSlider::calcPrefWidths): (WebCore::RenderSlider::layout):
- rendering/RenderTableCell.cpp: (WebCore::RenderTableCell::styleOrColWidth):
- rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::textBlockHeight): (WebCore::RenderTextControl::textBlockWidth): (WebCore::RenderTextControl::calcHeight): (WebCore::RenderTextControl::calcPrefWidths):
- rendering/RenderTextControlSingleLine.cpp: (WebCore::RenderTextControlSingleLine::layout):
- rendering/RenderWidget.cpp: (WebCore::RenderWidget::updateWidgetPosition):
- 10:18 AM Changeset in webkit [58176] by
-
- 2 edits in trunk/WebCore
Size mismatch between format string and argument in dumpTextEncodingNameMap()
Reviewed by Darin Adler.
See Bug 38030 and r58157.
- platform/text/TextEncodingRegistry.cpp:
(WebCore::dumpTextEncodingNameMap): Assigned
textEncodingNameMap->size() to an unsigned variable before using
it in the fprintf() statement.
- 10:00 AM Changeset in webkit [58175] by
-
- 2 edits in trunk/WebCore
BUILD FIX: Attempt to fix Windows build after Bug 36187 landed in r58168
- DerivedSources.cpp: Changed include of JSMedia.cpp to
JSStyleMedia.cpp.
- 9:47 AM Changeset in webkit [58174] by
-
- 2 edits in trunk/WebCore
BUILD FIX: Fix Mac build after Bug 36187 landed in r58168
- WebCore.xcodeproj/project.pbxproj: Renamed DOMMedia.h,
DOMMedia.mm, DOMMediaInternal.h to DOMStyleMedia.h,
DOMStyleMedia.mm, DOMStyleMediaInternal.h.
- 9:33 AM Changeset in webkit [58173] by
-
- 2 edits in trunk/WebCore
Unreviewed build fix.
Change Media to StyleMedia
- DerivedSources.make:
- 9:28 AM Changeset in webkit [58172] by
-
- 2 edits in trunk/LayoutTests
Unreviewed layout fix.
Change [object Media] to [object StyleMedia]
- platform/qt/fast/dom/Window/window-properties-expected.txt:
- 9:24 AM Changeset in webkit [58171] by
-
- 1 edit in trunk/WebKit/win/Interfaces/WebKit.idl
Touch WebKit.idl to force a rebuild.
- 9:15 AM Changeset in webkit [58170] by
-
- 2 edits in trunk/LayoutTests
Unreviewed layout fix.
Change [object Media] to [object StyleMedia]
- fast/dom/Window/window-properties-expected.txt:
- 9:08 AM Changeset in webkit [58169] by
-
- 2 edits in trunk/WebCore
2010-04-23 Xan Lopez <xlopez@igalia.com>
Try to fix the GTK+ bots.
- GNUmakefile.am:
- 8:42 AM Changeset in webkit [58168] by
-
- 15 edits3 moves in trunk
WebCore: Rename window.media to window.styleMedia
https://bugs.webkit.org/show_bug.cgi?id=36187
Reviewed by Laszlo Gombos.
Rename the interface Media to StyleMedia as required by the
new CSSOM View spec.
- Android.derived.jscbindings.mk:
- Android.derived.v8bindings.mk:
- GNUmakefile.am:
- WebCore.gypi:
- WebCore.pri:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- css/Media.cpp: Removed.
- css/Media.h: Removed.
- css/Media.idl: Removed.
- css/StyleMedia.cpp: Added.
(WebCore::StyleMedia::StyleMedia):
(WebCore::StyleMedia::type):
(WebCore::StyleMedia::matchMedium):
- css/StyleMedia.h: Added.
(WebCore::StyleMedia::create):
(WebCore::StyleMedia::disconnectFrame):
- css/StyleMedia.idl: Added.
- page/DOMWindow.cpp:
(WebCore::DOMWindow::styleMedia):
- page/DOMWindow.h:
(WebCore::DOMWindow::optionalMedia):
- page/DOMWindow.idl:
LayoutTests: Updated test results as the interface Media was renamed
to StyleMedia.
Reviewed by NOBODY (OOPS!).
- fast/dom/prototype-inheritance-2-expected.txt:
- platform/win/fast/dom/prototype-inheritance-2-expected.txt:
- 8:38 AM Changeset in webkit [58167] by
-
- 7 edits in trunk/JavaScriptCore
2010-04-23 Gabor Rapcsanyi <rgabor@inf.u-szeged.hu>
Reviewed by Laszlo Gombos.
Add RVCT support for Linux
Developed in cooperation with Gabor Loki.
- API/JSStringRef.h:
- jit/ExecutableAllocator.h:
- jit/ExecutableAllocatorPosix.cpp: (JSC::ExecutableAllocator::cacheFlush):
- jit/JITStubs.cpp:
- wtf/MathExtras.h:
- wtf/unicode/qt4/UnicodeQt4.h:
- 8:02 AM Changeset in webkit [58166] by
-
- 6 edits in trunk/WebCore
2010-04-23 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: provide JSC implementation for scopeType method on
call frame and use same jsvascript code for JSC and v8 when collecting
scope chain data.
- bindings/js/JSInjectedScriptHostCustom.cpp: (WebCore::JSInjectedScriptHost::currentCallFrame):
- bindings/js/JSJavaScriptCallFrameCustom.cpp: (WebCore::JSJavaScriptCallFrame::scopeType):
- bindings/v8/custom/V8InjectedScriptHostCustom.cpp: (WebCore::V8InjectedScriptHost::currentCallFrameCallback):
- inspector/InjectedScriptHost.idl:
- inspector/front-end/InjectedScript.js: (injectedScriptConstructor.):
- 7:59 AM Changeset in webkit [58165] by
-
- 3 edits1 move in trunk/JavaScriptCore
2010-04-23 Patrick Gansterer <paroga@paroga.com>
Reviewed by Laszlo Gombos.
[WIN] Move OwnPtrWin.cpp into platform specific folder.
https://bugs.webkit.org/show_bug.cgi?id=38042
- JavaScriptCore.gypi:
- JavaScriptCore.vcproj/WTF/WTF.vcproj:
- wtf/OwnPtrWin.cpp: Removed.
- wtf/win/OwnPtrWin.cpp: Copied from JavaScriptCore/wtf/OwnPtrWin.cpp.
- 7:45 AM Changeset in webkit [58164] by
-
- 1 edit1 move in trunk/JavaScriptCore
2010-04-23 Patrick Gansterer <paroga@paroga.com>
Reviewed by Laszlo Gombos.
[BREWMP] Move OwnPtrBrew.cpp into platform specific folder.
https://bugs.webkit.org/show_bug.cgi?id=38042
- wtf/OwnPtrBrew.cpp: Removed.
- wtf/brew/OwnPtrBrew.cpp: Copied from JavaScriptCore/wtf/OwnPtrBrew.cpp.
- 6:05 AM Changeset in webkit [58163] by
-
- 2 edits in trunk/WebCore
2010-04-23 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: Audits (Image Dimensions): full image URLs are prefixed with the hosting page name
https://bugs.webkit.org/show_bug.cgi?id=37988
- inspector/front-end/AuditRules.js: (WebInspector.AuditRules.ImageDimensionsRule.prototype.doRun):
- 2:51 AM Changeset in webkit [58162] by
-
- 2 edits in trunk/WebCore
2010-04-23 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Yury Semikhatsky.
WebInspector: Flaky Inspector tests.
https://bugs.webkit.org/show_bug.cgi?id=36217
- inspector/InspectorController.cpp: (WebCore::InspectorController::didCommitLoad):
- 2:42 AM Changeset in webkit [58161] by
-
- 9 edits in trunk
2010-04-23 Yaar Schnitman <yaar@chromium.org>
Reviewed by Adam Barth.
Auto-generate WebGLRenderingContext overloads in V8
https://bugs.webkit.org/show_bug.cgi?id=37818
- fast/canvas/webgl/script-tests/texImageTest.js: Test was wrong: Passing 0 value for a WebGLArray argument in texImage2D should throw the same exception as when passed to textSubImage2D.
- platform/chromium-mac/fast/canvas/webgl/texImageTest-expected.txt:
- fast/canvas/webgl/texImageTest-expected.txt: Changes to reflect test.
2010-04-23 Yaar Schnitman <yaar@chromium.org>
Reviewed by Adam Barth.
Auto-generate WebGLRenderingContext overloads in V8
https://bugs.webkit.org/show_bug.cgi?id=37818
- bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:
- html/canvas/WebGLRenderingContext.cpp: Added missing overloads for the following:. (WebCore::WebGLRenderingContext::texImage2D) (WebCore::WebGLRenderingContext::texSubImage2D)
- html/canvas/WebGLRenderingContext.h: Added missing overloads.
- html/canvas/WebGLRenderingContext.idl: IDL definition of overloads.
- 2:31 AM Changeset in webkit [58160] by
-
- 4 edits1 add in trunk/WebCore
2010-04-23 Jeff Schiller <codedread@gmail.com>
Reviewed by Nikolas Zimmermann.
Display tooltips when hovering over SVG elements, Bug 16854
https://bugs.webkit.org/show_bug.cgi?id=16854
Manual test added for verifying tooltips.
- manual-tests/svg-tooltip.svg: Added.
- svg/SVGAElement.cpp: (WebCore::SVGAElement::title): xlink:title takes precedence, otherwise SVGStyledElement::title() is used
- svg/SVGStyledElement.cpp: (WebCore::SVGStyledElement::title): checks for a shadow parent and uses that title, otherwise uses the content's title
- svg/SVGStyledElement.h: add title() method declaration
- 1:43 AM Changeset in webkit [58159] by
-
- 2 edits in trunk/LayoutTests
2010-04-23 Yuzo Fujishima <yuzo@google.com>
Unreviewed, Chromium test expectation change.
Change expectation of fast/url/file-http-base.html for Chromium to TEXT.
https://bugs.webkit.org/show_bug.cgi?id=38038
- platform/chromium/test_expectations.txt:
- 1:23 AM Changeset in webkit [58158] by
-
- 2 edits in trunk/WebCore
<http://webkit.org/b/38032> No need to content sniff 304 responses
<rdar://problem/7891726>
Reviewed by Brady Eidson.
- platform/network/mac/ResourceHandleMac.mm:
(-[WebCoreResourceHandleAsDelegate connection:didReceiveResponse:]):
No need to adjust the MIME type on 304 responses since they're
only used to determine if the resource needs to be refetched.
- 1:05 AM Changeset in webkit [58157] by
-
- 3 edits in trunk/WebCore
<http://webkit.org/b/38030> Add WebCore::dumpTextEncodingNameMap() to dump text encoding map on debug builds
Reviewed by Alexey Proskuryakov.
- platform/text/TextEncodingRegistry.cpp:
(WebCore::dumpTextEncodingNameMap): Added.
- platform/text/TextEncodingRegistry.h:
(WebCore::dumpTextEncodingNameMap): Added declaration.
- 12:36 AM Changeset in webkit [58156] by
-
- 2 edits in trunk/WebKit/mac
<http://webkit.org/b/38029> +[WebTextIteratorPrivate initialize] is missing call to JSC::initializeThreading()
Reviewed by Timothy Hatcher.
Every other Objective-C class that calls
WebCoreObjCFinalizeOnMainThread(self) in +initialize also calls
JSC::initializeThreading(). The WebTextIteratorPrivate class
was the only one missing this call.
- WebView/WebTextIterator.mm:
(+[WebTextIteratorPrivate initialize]): Added call to
JSC::initializeThreading().
- 12:18 AM Changeset in webkit [58155] by
-
- 1 edit in trunk/WebKit/win/Interfaces/WebKit.idl
Touch WebKit.idl to force a rebuild.
- 12:14 AM Changeset in webkit [58154] by
-
- 3 edits in trunk/WebKit/win
Roll out http://trac.webkit.org/changeset/55385.
Rubber stamped by Steve Falkenburg.
<rdar://problem/7884444>
- Interfaces/IWebUIDelegatePrivate.idl:
- Interfaces/WebKit.idl:
- WebCoreSupport/WebFrameLoaderClient.cpp:
(WebFrameLoaderClient::createPlugin):
- 12:04 AM Changeset in webkit [58153] by
-
- 3 edits2 adds in trunk
2010-04-22 Tony Chang <tony@chromium.org>
Reviewed by Dan Bernstein.
Crash in WebCore::TextIterator::handleTextNode() encountered in Google rich-text products
https://bugs.webkit.org/show_bug.cgi?id=37950
- editing/text-iterator/rtl-selection-crash-expected.txt: Added.
- editing/text-iterator/rtl-selection-crash.html: Added.
2010-04-22 Tony Chang <tony@chromium.org>
Reviewed by Dan Bernstein.
Crash in WebCore::TextIterator::handleTextNode() encountered in Google rich-text products
https://bugs.webkit.org/show_bug.cgi?id=37950
Test: editing/text-iterator/rtl-selection-crash.html
- editing/TextIterator.cpp: (WebCore::TextIterator::handleTextNode):
- 12:00 AM Changeset in webkit [58152] by
-
- 1 edit3 adds in trunk/LayoutTests
2010-04-22 Maciej Stachowiak <mjs@apple.com>
Reviewed by Adam Barth.
Add a test for file URL canonicalization with an http base
https://bugs.webkit.org/show_bug.cgi?id=38035
- fast/url/file-http-base-expected.txt: Added.
- fast/url/file-http-base.html: Added.
- fast/url/script-tests/file-http-base.js: Added.
Apr 22, 2010:
- 10:59 PM Changeset in webkit [58151] by
-
- 2 edits in trunk
Fix up my immediately previous ChangeLogs.
- 10:47 PM Changeset in webkit [58150] by
-
- 6 edits6 adds in trunk
2010-04-22 Maciej Stachowiak <mjs@apple.com>
Reviewed by Dan Bernstein.
Links around blocks (e.g. divs) results in too many VoiceOver call outs
https://bugs.webkit.org/show_bug.cgi?id=37079
The basic change is to modify the AccessibilityRenderObject tree
traversal methods to account for inline continuations in the
render tree and make the accessibility tree look as if
continuations didn't exist - the same as if CSS blocks could just
sit in CSS inlines. This is slightly tricky code but creates a
much saner accessibility tree.
Tests: accessibility/image-link-inline-cont.html
accessibility/image-link.html
accessibility/inline-continuations.html
- accessibility/AccessibilityRenderObject.cpp: (WebCore::isInlineWithContinuation): Helper function for traversal functions to use in accounting for continuations. (WebCore::firstChildInContinuation): ditto (WebCore::firstChildConsideringContinuation): ditto (WebCore::lastChildConsideringContinuation): ditto (WebCore::startOfContinuations): ditto (WebCore::endOfContinuations): ditto (WebCore::childBeforeConsideringContinuations): ditto (WebCore::firstChildIsInlineContinuation): ditto (WebCore::lastChildHasContinuation): ditto (WebCore::AccessibilityRenderObject::firstChild): Account for inline continuations. (WebCore::AccessibilityRenderObject::lastChild): ditto (WebCore::AccessibilityRenderObject::previousSibling): Account for inline continuations and their anonymous block parents. (WebCore::AccessibilityRenderObject::nextSibling): ditto (WebCore::AccessibilityRenderObject::parentObjectIfExists): Account for inline continuations. (WebCore::AccessibilityRenderObject::parentObject): Account for inline continuations.
- rendering/RenderInline.h: Make RenderInline::inlineContinuation public.
2010-04-22 Maciej Stachowiak <mjs@apple.com>
Reviewed by Dan Bernstein.
Links around blocks (e.g. divs) results in too many VoiceOver call outs
https://bugs.webkit.org/show_bug.cgi?id=37079
The new test cases verify the accessibility tree created by an image inside a link, and verify
that adding a div with role=presentation now has no effect on the accessibility tree (as expected).
- accessibility/image-link-inline-cont-expected.txt: Added.
- accessibility/image-link-inline-cont.html: Added.
- accessibility/image-link.html: Added.
- platform/gtk/Skipped:
- platform/mac/accessibility/image-link-expected.txt: Added.
- platform/win/Skipped:
Test to check that accessibility tree doesn't get duplicate content in the presence
of inline continuations (this was a bug in an earlier version of this patch).
- accessibility/inline-continuations-expected.txt: Added.
- accessibility/inline-continuations.html: Added.
- 9:51 PM Changeset in webkit [58149] by
-
- 5 edits in trunk
2010-04-22 Shinichiro Hamaji <hamaji@chromium.org>
Reviewed by Darin Adler.
REGRESSION: TextIterator may use freed memory
https://bugs.webkit.org/show_bug.cgi?id=37973
- platform/chromium/test_expectations.txt:
2010-04-22 Shinichiro Hamaji <hamaji@chromium.org>
Reviewed by Darin Adler.
REGRESSION: TextIterator may use freed memory
https://bugs.webkit.org/show_bug.cgi?id=37973
Added TextIterator::m_text to hold the returned String.
No new tests because there are no behavior change, but
copy-backslash-with-euc.html on chromium-win should test this.
- editing/TextIterator.cpp: (WebCore::TextIterator::emitText):
- editing/TextIterator.h:
- 9:48 PM Changeset in webkit [58148] by
-
- 2 edits in trunk/BugsSite
2010-04-22 Adam Barth <abarth@webkit.org>
Reviewed by Darin Adler.
The new review tools shouldn't clear the comment box automatically
https://bugs.webkit.org/show_bug.cgi?id=38004
Instead, we now have a button for doing that explicitly. If people
like this tool, we can look at fancier solutions.
Also, tried to make the tool work on the edit page as well as the review page.
- PrettyPatch/PrettyPatch.rb:
- 9:32 PM Changeset in webkit [58147] by
-
- 2 edits in trunk/WebKitTools
Unreviewed fix.
- Scripts/webkitpy/layout_tests/port/websocket_server.py: fix NameError: global name 'f' is not defined.
- 9:29 PM Changeset in webkit [58146] by
-
- 6 edits in trunk/WebKitTools
2010-04-22 James Robinson <jamesr@chromium.org>
Reviewed by Adam Barth.
Revert 58077 and follow-ups. It's broken.
https://bugs.webkit.org/show_bug.cgi?id=37664
- Scripts/new-run-webkit-httpd:
- Scripts/new-run-webkit-websocketserver:
- Scripts/webkitpy/layout_tests/port/chromium_win.py:
- Scripts/webkitpy/layout_tests/port/http_server.py:
- Scripts/webkitpy/layout_tests/port/websocket_server.py:
- 9:20 PM Changeset in webkit [58145] by
-
- 2 edits in trunk/WebCore
2010-04-22 Michael Forney <mforney@mforney.org>
Reviewed by Adam Barth.
Only include JSDatabase.h and JSDatabaseCallback.h when database is
enabled. This partially fixes building with --disable-database.
- bindings/js/JSDOMWindowCustom.cpp: Add a check for database around database-related headers.
- 8:39 PM Changeset in webkit [58144] by
-
- 2 edits in trunk/WebCore
2010-04-22 Ray Rischpater <Raymond.Rischpater@Nokia.com>
Reviewed by Darin Adler.
In HTMLInputElement.cpp, shouldUseInputMethod does not return true for
some text input types (TELEPHONE, NUMBER, URL, and EMAIL). Addressed
this by changing shouldUseInputMethod to use internal methods to
check that the field is a text field that isn't a password field.
No new tests.
- html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::shouldUseInputMethod):
- 8:30 PM Changeset in webkit [58143] by
-
- 2 edits1 add1 delete in trunk
2010-04-22 Yaar Schnitman <yaar@chromium.org>
Reviewed by Adam Barth.
Integrate v8 testing utility with webkit tests
https://bugs.webkit.org/show_bug.cgi?id=37731
- bindings/v8/test/run_tests.py: Removed.
2010-04-22 Yaar Schnitman <yaar@chromium.org>
Reviewed by Adam Barth.
Integrate v8 testing utility with webkit tests
https://bugs.webkit.org/show_bug.cgi?id=37731
- Scripts/run-bindings-tests: Added.
- 8:10 PM Changeset in webkit [58142] by
-
- 2 edits in trunk/JavaScriptCore
2010-04-22 Steve Block <steveblock@google.com>
Reviewed by Adam Barth.
Update Android to use isfinite, isinf, isnan and signbit from namespace std.
https://bugs.webkit.org/show_bug.cgi?id=37948
- wtf/MathExtras.h:
- 7:52 PM Changeset in webkit [58141] by
-
- 4 edits in trunk/WebKit/qt
2010-04-22 John Pavan <john.pavan@nokia.com>
Reviewed by Laszlo Gombos.
[Qt] inputMethodQuery returns coordinates in web page coordinates rather than in item coordinates.
https://bugs.webkit.org/show_bug.cgi?id=37163
QWebPage::inputMethodQuery is modified so that it
returns coordinates in the widget's coordinate system.
Tests are added for QGraphicsWebView and QWebView
to verify that this behavior is correct after the webpage
has been scrolled.
- Api/qwebpage.cpp: (QWebPage::inputMethodQuery):
- tests/qgraphicswebview/tst_qgraphicswebview.cpp: (tst_QGraphicsWebView::microFocusCoordinates):
- tests/qwebview/tst_qwebview.cpp: (tst_QWebView::microFocusCoordinates):
- 7:07 PM Changeset in webkit [58140] by
-
- 10 edits in trunk
2010-04-22 Zhenyao Mo <zmo@google.com>
Reviewed by Darin Fisher.
Add isGLES2Compliant to GraphicsContext3D
https://bugs.webkit.org/show_bug.cgi?id=37872
- html/canvas/WebGLRenderingContext.cpp: Add isGLES2Compliant(). (WebCore::WebGLRenderingContext::isGLES2Compliant):
- html/canvas/WebGLRenderingContext.h: Ditto.
- platform/graphics/GraphicsContext3D.h: Ditto.
- platform/graphics/mac/GraphicsContext3DMac.cpp: Ditto. (WebCore::GraphicsContext3D::isGLES2Compliant):
2010-04-22 Zhenyao Mo <zmo@google.com>
Reviewed by Darin Fisher.
Add isGLES2Compliant to GraphicsContext3D
https://bugs.webkit.org/show_bug.cgi?id=37872
- public/WebGraphicsContext3D.h: Add isGLES2Compliant().
- src/GraphicsContext3D.cpp: Ditto.
- src/WebGraphicsContext3DDefaultImpl.cpp: Ditto. (WebKit::WebGraphicsContext3DDefaultImpl::isGLES2Compliant):
- src/WebGraphicsContext3DDefaultImpl.h: Ditto.
- 6:55 PM Changeset in webkit [58139] by
-
- 2 edits in trunk/WebKitTools
2010-04-22 Eric Seidel <eric@webkit.org>
Reviewed by Dimitri Glazkov.
new-run-webkit-tests --verbose shows ever-increasing #EOF lines
https://bugs.webkit.org/show_bug.cgi?id=37794
- Scripts/webkitpy/layout_tests/port/webkit.py:
- Remove the assert() since our ServerProcess code does not always seem to be reading the full stderr output (or we're not waiting for it to).
- 6:32 PM Changeset in webkit [58138] by
-
- 2 edits in trunk/JavaScriptCore
Unreviewed build fix.
- wtf/MD5.cpp: fix include path of CString.h
- 6:31 PM Changeset in webkit [58137] by
-
- 2 edits in trunk/LayoutTests
2010-04-22 Yuzo Fujishima <yuzo@google.com>
Unreviewed. Chromium test expectation change.
Mark fast/events/touch/send-oncancel-event.html as failing (TEXT).
https://bugs.webkit.org/show_bug.cgi?id=38020
- platform/chromium/test_expectations.txt:
- 6:13 PM Changeset in webkit [58136] by
-
- 9 edits3 adds in trunk
2010-04-22 Fumitoshi Ukai <ukai@chromium.org>
Reviewed by Adam Barth.
MD5 is required for WebSocket new protocol implementation
https://bugs.webkit.org/show_bug.cgi?id=37913
- GNUmakefile.am:
- JavaScriptCore.exp:
- JavaScriptCore.gypi:
- JavaScriptCore.pro:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
- JavaScriptCore.vcproj/WTF/WTF.vcproj:
- JavaScriptCore.xcodeproj/project.pbxproj:
- wtf/MD5.cpp: Added.
- wtf/MD5.h: Added.
2010-04-22 Fumitoshi Ukai <ukai@chromium.org>
Reviewed by Adam Barth.
MD5 is required for WebSocket new protocol implementation
https://bugs.webkit.org/show_bug.cgi?id=37913
- ForwardingHeaders/wtf/MD5.h: Added.
- 5:44 PM Changeset in webkit [58135] by
-
- 2 edits in trunk/WebKit2
Remove an assert. (It's not valid when resizing).
Reviewed by Sam Weinig.
- WebProcess/WebPage/mac/DrawingAreaUpdateChunk.cpp:
(WebKit::DrawingAreaUpdateChunk::didUpdate):
- 5:16 PM Changeset in webkit [58134] by
-
- 2 edits in trunk/JavaScriptCore
Errk, accidentally committed commenting out two ASSERTs! reverting.
Reviewed by NOBODY (build fix).
- runtime/Collector.cpp:
(JSC::Heap::protect):
(JSC::Heap::unprotect):
- 5:11 PM Changeset in webkit [58133] by
-
- 8 edits in trunk/JavaScriptCore
https://bugs.webkit.org/show_bug.cgi?id=38006
Change lifetime of JSC::IdentifierTables used by WebCores to match AtomicStringTable
Reviewed by Geoff Garen.
Presently JSC's IdentifierTables are owned by the JSGlobalData. For
JSGlobalData objects created via the API this should continue to be the case,
but for the JSGlobalData objects used by WebCore (the main thread's common
global data, and those for workers) use a IdentifierTable provided (and owned)
by wtfThreadData. This allow the lifetime of these IdentifierTable to match
those of the corresponding AtomicStringTables.
- API/APIShims.h:
(JSC::APIEntryShim::APIEntryShim):
- API/JSContextRef.cpp:
(JSContextGroupCreate):
- runtime/Collector.cpp:
(JSC::Heap::protect):
(JSC::Heap::unprotect):
(JSC::Heap::markRoots):
- runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::JSGlobalData):
(JSC::JSGlobalData::~JSGlobalData):
(JSC::JSGlobalData::createContextGroup):
(JSC::JSGlobalData::create):
(JSC::JSGlobalData::sharedInstance):
- runtime/JSGlobalData.h:
(JSC::JSGlobalData::):
(JSC::JSGlobalData::isSharedInstance):
- runtime/JSLock.cpp:
(JSC::JSLock::JSLock):
(JSC::JSLock::lock):
(JSC::JSLock::unlock):
(JSC::JSLock::DropAllLocks::DropAllLocks):
- wtf/WTFThreadData.cpp:
(WTF::WTFThreadData::WTFThreadData):
(WTF::WTFThreadData::~WTFThreadData):
- 5:08 PM Changeset in webkit [58132] by
-
- 2 edits in trunk/WebCore
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=38012
REGRESSION: Ctrl- and Option- shortcuts get wrong keyCode on non-QWERTY keyboard
- platform/mac/KeyEventMac.mm: (WebCore::windowsKeyCodeForKeyEvent): Also look at unmodified characters, to avoid falling through to virtual key code lookup for Roman characters.
- 5:07 PM Changeset in webkit [58131] by
-
- 2 edits in trunk/JavaScriptGlue
Do not get the globaldata for the APIShim via the
global object; global object construction creates identifiers
which results in the ASSERTs checking the thread data's
identifierTable has been set failing.
Rubber stamped by Sam Weinig
- JSUtils.cpp:
(unprotectGlobalObject):
(getThreadGlobalData):
(getThreadGlobalObject):
(JSGlueAPIEntry::JSGlueAPIEntry):
(JSGlueAPICallback::~JSGlueAPICallback):
- 5:02 PM Changeset in webkit [58130] by
-
- 5 edits in trunk
Versioning.
- 5:00 PM Changeset in webkit [58129] by
-
- 1 copy in tags/Safari-533.6
New tag.
- 4:46 PM Changeset in webkit [58128] by
-
- 2 edits in trunk/WebKitTools
2010-04-22 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Add code to help debug new-run-webkit-test hangs on the Chromium bots
https://bugs.webkit.org/show_bug.cgi?id=38011
I can see no reasonable way to test this change.
Stubbing out sys._current_frames() and traceback.extract_stack
seems folly. Dumping real data would have line number
(and possibly other call stack) variance between runs.
- Scripts/webkitpy/layout_tests/run_webkit_tests.py:
- Add _dump_thread_states and _dump_thread_states_if_necessary to have our main thread dump the states of all threads every 60 seconds when running in verbose mode.
- Better document what is going on in our main loop.
- 4:40 PM Changeset in webkit [58127] by
-
- 1 edit6 adds in trunk/LayoutTests
2010-04-22 James Robinson <jamesr@chromium.org>
Unreviewed, expectations only change.
Land chromium platform-specific results for fast/text/format-control.html
- platform/chromium-linux/fast/text/format-control-expected.checksum: Added.
- platform/chromium-linux/fast/text/format-control-expected.png: Added.
- platform/chromium-mac/fast/text/format-control-expected.checksum: Added.
- platform/chromium-win/fast/text/format-control-expected.checksum: Added.
- platform/chromium-win/fast/text/format-control-expected.png: Added.
- platform/chromium-win/fast/text/format-control-expected.txt: Added.
- 4:37 PM Changeset in webkit [58126] by
-
- 4 edits in trunk/WebCore
2010-04-22 Jocelyn Turcotte <jocelyn.turcotte@nokia.com>
Reviewed by Darin Adler.
Fix the MSVC 64bit build.
https://bugs.webkit.org/show_bug.cgi?id=37980
- platform/text/TextStream.cpp:
- platform/text/TextStream.h:
- plugins/win/PluginViewWin.cpp: (WebCore::PluginView::platformStart):
- 4:35 PM Changeset in webkit [58125] by
-
- 4 edits1 delete in trunk/WebKit2
Merge the prefix headers.
Reviewed by Anders Carlsson.
- Configurations/BaseTarget.xcconfig:
- WebKit2.xcodeproj/project.pbxproj:
- WebKit2Prefix.h:
- WebKit2_Prefix.pch: Removed.
- 4:00 PM Changeset in webkit [58124] by
-
- 2 edits in trunk/WebKit
2010-04-22 Leandro Pereira <leandro@profusion.mobi>
Reviewed by Gustavo Noronha Silva.
Implement findThemePath to locate the correct theme file instead of
relying on a hardcoded location.
http://webkit.org/b/37996
- efl/EWebLauncher/main.c: (findThemePath): Fix to locate the correct theme files. (main): Use findThemePath() instead of a hardcoded one.
- 3:58 PM Changeset in webkit [58123] by
-
- 4 edits in trunk/WebKit2
Don't pass the new size when calling didSetSize, it's possible to get
the size from the update chunk.
Reviewed by Sam Weinig.
- UIProcess/mac/DrawingAreaProxyUpdateChunk.h:
- UIProcess/mac/DrawingAreaProxyUpdateChunk.mm:
(WebKit::DrawingAreaProxyUpdateChunk::didSetSize):
(WebKit::DrawingAreaProxyUpdateChunk::didReceiveMessage):
- WebProcess/WebPage/mac/DrawingAreaUpdateChunk.cpp:
(WebKit::DrawingAreaUpdateChunk::setSize):
- 3:51 PM Changeset in webkit [58122] by
-
- 2 edits in trunk/WebKit
2010-04-22 Leandro Pereira <leandro@profusion.mobi>
Reviewed by Gustavo Noronha Silva.
Update efl/ewebkit.pc.in to match the variable substitution syntax
of CMake.
http://webkit.org/b/37999
- efl/ewebkit.pc.in: Updated.
- 3:41 PM Changeset in webkit [58121] by
-
- 3 edits in trunk/WebKit
2010-04-22 Leandro Pereira <leandro@profusion.mobi>
Reviewed by Gustavo Noronha Silva.
Update EWebKit (EFL port) to match recent API changes.
http://webkit.org/b/37997
- efl/ewk/ewk_frame.cpp: (ewk_frame_zoom_set): Change to use WebCore::ZoomMode. (ewk_frame_zoom_text_only_set): Change to use WebCore::ZoomMode. (_ewk_frame_handle_key_scrolling): s/WebCore::VK_/VK_/g (ewk_frame_plugin_create): Disable temporarily PluginView-related code until a proper plugin implementation is made.
- efl/ewk/ewk_view.cpp: Fix typo in _parent_sc declaration. (ewk_view_selection_get): Fix a reference to WebCore::CString to WTF::CString.
- 3:33 PM Changeset in webkit [58120] by
-
- 2 edits in trunk/WebKit/mac
Rubber-stamped by Mark Rowe.
<rdar://problem/7805969> REGRESSION: iTunes unable to play trailers
Undo the changes made for https://bugs.webkit.org/show_bug.cgi?id=35215 (<rdar://problem/7673157>)
for now. Clients rely on the old behavior, so a fix that changes it will need to account for
those.
- WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::createPlugin): Pass pluginURL instead of baseURL again.
- 3:09 PM Changeset in webkit [58119] by
-
- 5 edits in trunk/WebKit2
Rename SetFrame and DidSetFrame to SetSize and DidSetSize.
Reviewed by Sam Weinig.
- Shared/CoreIPCSupport/DrawingAreaMessageKinds.h:
(DrawingAreaMessage::):
- Shared/CoreIPCSupport/DrawingAreaProxyMessageKinds.h:
(DrawingAreaProxyMessage::):
- UIProcess/mac/DrawingAreaProxyUpdateChunk.mm:
(WebKit::DrawingAreaProxyUpdateChunk::drawRectIntoContext):
(WebKit::DrawingAreaProxyUpdateChunk::setSize):
(WebKit::DrawingAreaProxyUpdateChunk::didReceiveMessage):
- WebProcess/WebPage/mac/DrawingAreaUpdateChunk.cpp:
(WebKit::DrawingAreaUpdateChunk::setSize):
(WebKit::DrawingAreaUpdateChunk::didReceiveMessage):
- 2:44 PM Changeset in webkit [58118] by
-
- 2 edits in trunk/JavaScriptCore
2010-04-22 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r58110.
http://trac.webkit.org/changeset/58110
https://bugs.webkit.org/show_bug.cgi?id=38007
Caused an internal compiler error on Qt (Requested by abarth
on #webkit).
- wtf/MathExtras.h:
- 1:56 PM Changeset in webkit [58117] by
-
- 21 edits1 copy3 adds in trunk
Fix for https://bugs.webkit.org/show_bug.cgi?id=38002
Add rudimentary statistics gathering for WebKit2
Reviewed by Anders Carlsson.
WebKit2:
- UIProcess/API/C/WKContext.cpp:
(WKContextGetStatistics):
- UIProcess/API/C/WKContextPrivate.h: Copied from WebKit2/UIProcess/API/C/WKContext.h.
- UIProcess/API/C/WKPageNamespace.cpp:
(WKPageNamespaceGetContext):
- UIProcess/API/C/WKPageNamespace.h:
- UIProcess/WebContext.cpp:
(WebKit::WebContext::getStatistics):
- UIProcess/WebContext.h:
- UIProcess/WebPageNamespace.cpp:
(WebKit::WebPageNamespace::getStatistics):
- UIProcess/WebPageNamespace.h:
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::getStatistics):
- UIProcess/WebPageProxy.h:
- UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::numberOfPages):
- UIProcess/WebProcessProxy.h:
- WebKit2.xcodeproj/project.pbxproj:
- win/WebKit2.vcproj:
WebKitTools:
- MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
- MiniBrowser/mac/AppDelegate.h:
- MiniBrowser/mac/AppDelegate.m:
(-[BrowserAppDelegate init]):
(-[BrowserAppDelegate newWindow:]):
(-[BrowserAppDelegate getCurrentPageNamespace]):
(-[BrowserAppDelegate _setProcessModel:]):
(-[BrowserAppDelegate showStatisticsWindow:]):
(-[BrowserAppDelegate applicationWillTerminate:]):
- MiniBrowser/mac/BrowserStatisticsWindow.xib: Added.
- MiniBrowser/mac/BrowserStatisticsWindowController.h: Added.
- MiniBrowser/mac/BrowserStatisticsWindowController.m: Added.
(-[BrowserStatisticsWindowController initWithThreadedWKContextRef:processWKContextRef:]):
(-[BrowserStatisticsWindowController dealloc]):
(-[BrowserStatisticsWindowController windowDidLoad]):
(-[BrowserStatisticsWindowController refreshStatistics:]):
- MiniBrowser/mac/BrowserWindowController.h:
- MiniBrowser/mac/English.lproj/MainMenu.xib:
- MiniBrowser/mac/MiniBrowser_Prefix.pch:
- 1:50 PM Changeset in webkit [58116] by
-
- 2 edits in trunk/JavaScriptCore
- API/JSWeakObjectMapRefPrivate.cpp:
Reviewed by NOBODY (windows build fix).
- 1:42 PM Changeset in webkit [58115] by
-
- 3 edits in trunk/JavaScriptCore
- API/JSBase.cpp:
- API/JSCallbackObject.cpp:
Reviewed by NOBODY (windows build fix).
- 1:31 PM Changeset in webkit [58114] by
-
- 15 edits1 add in trunk/JavaScriptCore
https://bugs.webkit.org/show_bug.cgi?id=37978
Unify JSC::IdentifierTable and WebCore::AtomicStringTable implementations.
Reviewed by Geoff Garen.
These two classes both implement a HashSet of uniqued StringImpls, with
translator classes to avoid unnecessary object creation. The only difference
between the classes is which flag (isIdentifier or inTable) is set.
Combine the two classes using a template predicated on which flag to use.
New class AtomicStringTable created, containing all the goodness from
IdentifierTable & AtomicStringTable, expect for Identifier's literalTable,
which has been moved onto JSGlobalData. Removed duplicate string translator
classes. Renamed StringImpl's inTable flag to more explicit 'isAtomic',
and set this on the empty string (which matches Identifier behaviour, and
removes a redundant check for zero-length).
- GNUmakefile.am:
- JavaScriptCore.gypi:
- JavaScriptCore.vcproj/WTF/WTF.vcproj:
- JavaScriptCore.xcodeproj/project.pbxproj:
- runtime/Identifier.cpp:
(JSC::createLiteralTable):
(JSC::deleteLiteralTable):
(JSC::Identifier::add):
(JSC::Identifier::addSlowCase):
- runtime/Identifier.h:
- runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::JSGlobalData):
(JSC::JSGlobalData::~JSGlobalData):
- runtime/JSGlobalData.h:
- wtf/WTFThreadData.cpp:
(WTF::WTFThreadData::WTFThreadData):
(WTF::WTFThreadData::~WTFThreadData):
- wtf/WTFThreadData.h:
(WTF::WTFThreadData::atomicStringTable):
- wtf/text/AtomicString.cpp:
(WebCore::table):
(WebCore::operator==):
(WebCore::AtomicString::add):
(WebCore::AtomicString::find):
(WebCore::AtomicString::remove):
- wtf/text/AtomicStringTable.h: Added.
(WTF::CStringTranslator::hash):
(WTF::CStringTranslator::equal):
(WTF::CStringTranslator::translate):
(WTF::UCharBufferTranslator::hash):
(WTF::UCharBufferTranslator::equal):
(WTF::UCharBufferTranslator::translate):
(WTF::HashAndCharactersTranslator::hash):
(WTF::HashAndCharactersTranslator::equal):
(WTF::HashAndCharactersTranslator::translate):
(WTF::IdentifierOrAtomicStringTable::remove):
(WTF::::~IdentifierOrAtomicStringTable):
(WTF::::add):
(WTF::::find):
- wtf/text/StringImpl.cpp:
(WebCore::StringImpl::~StringImpl):
- wtf/text/StringImpl.h:
(WebCore::StringImpl::isAtomic):
(WebCore::StringImpl::setIsAtomic):
(WebCore::equal):
- wtf/text/StringImplBase.h:
(WTF::StringImplBase::StringImplBase):
- 1:17 PM Changeset in webkit [58113] by
-
- 2 edits in trunk/LayoutTests
2010-04-22 MORITA Hajime <morrita@google.com>
Not reviewed.
Picked a review feedback left on:
https://bugs.webkit.org/show_bug.cgi?id=37056
LayoutTests/editing/selection/move-left-right.html is slow
- editing/selection/move-left-right.html:
- 1:12 PM Changeset in webkit [58112] by
-
- 4 edits in trunk/WebKit/qt
[Qt] Fix createPlugin() tests in tst_qwebpage to match behaviour of Qt plugins
when PluginsEnabled is false.
2010-04-22 Robert Hogan <robert@webkit.org>
Reviewed by Simon Hausmann.
[Qt] Fix createPlugin() tests in tst_qwebpage to match behaviour of Qt plugins
when PluginsEnabled is false.
tst_qwebpage should have been updated as part of r56662.
(See https://bugs.webkit.org/show_bug.cgi?id=32196)
Updated documentation of QWebPage::createPlugin and QWebSetting::pluginsEnabled
to match the new behaviour.
- Api/qwebpage.cpp: Update docs.
- Api/qwebsettings.cpp: Update docs.
- tests/qwebpage/tst_qwebpage.cpp: (createPlugin): (tst_QWebPage::createPluginWithPluginsEnabled): (tst_QWebPage::createPluginWithPluginsDisabled):
- 1:03 PM Changeset in webkit [58111] by
-
- 39 edits2 adds in trunk
2010-04-22 Dave Moore <davemoore@chromium.org>
Reviewed by Dimitri Glazkov.
Add test for icon change notifications.
- fast/dom/icon-url-property-expected.txt: Added.
- fast/dom/icon-url-property.html: Added.
- Skipped on all platforms but Win
2010-04-22 Dave Moore <davemoore@chromium.org>
Reviewed by Dimitri Glazkov.
Added notification when the favicons for a page are changed
from a script.
The Document object will notify the frame loader, which will
notify the client. Implementations of FrameLoaderClient will
have to add one method; dispatchDidChangeIcons().
Test: fast/dom/icon-url-property.html
- dom/Document.cpp: (WebCore::Document::setIconURL):
- loader/DocumentLoader.cpp: (WebCore::DocumentLoader::setIconURL):
- loader/DocumentLoader.h: (WebCore::DocumentLoader::iconURL):
- loader/EmptyClients.h: (WebCore::EmptyFrameLoaderClient::dispatchDidChangeIcons):
- loader/FrameLoader.cpp: (WebCore::FrameLoader::setIconURL): (WebCore::FrameLoader::didChangeIcons):
- loader/FrameLoader.h:
- loader/FrameLoaderClient.h:
2010-04-22 Dave Moore <davemoore@chromium.org>
Reviewed by Dimitri Glazkov.
Added notification when the favicons for a page are changed
from a script.
The Document object will notify the frame loader, which will
notify the client. Implementations of FrameLoaderClient will
have to add one method; dispatchDidChangeIcons().
- public/WebFrameClient.h: (WebKit::WebFrameClient::didChangeIcons):
- src/FrameLoaderClientImpl.cpp: (WebKit::FrameLoaderClientImpl::dispatchDidChangeIcons):
- src/FrameLoaderClientImpl.h:
2010-04-22 Dave Moore <davemoore@chromium.org>
Reviewed by Dimitri Glazkov.
Added notification when the favicons for a page are changed
from a script.
The Document object will notify the frame loader, which will
notify the client. Implementations of FrameLoaderClient will
have to add one method; dispatchDidChangeIcons().
- WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::dispatchDidChangeIcons):
- WebCoreSupport/FrameLoaderClientGtk.h:
2010-04-22 Dave Moore <davemoore@chromium.org>
Reviewed by Dimitri Glazkov.
Added notification when the favicons for a page are changed
from a script.
The Document object will notify the frame loader, which will
notify the client. Implementations of FrameLoaderClient will
have to add one method; dispatchDidChangeIcons().
- WebCoreSupport/WebFrameLoaderClient.h:
- WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::dispatchDidChangeIcons):
2010-04-22 Dave Moore <davemoore@chromium.org>
Reviewed by Dimitri Glazkov.
Added notification when the favicons for a page are changed
from a script.
The Document object will notify the frame loader, which will
notify the client. Implementations of FrameLoaderClient will
have to add one method; dispatchDidChangeIcons().
- WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::dispatchDidChangeIcons): (WebCore::FrameLoaderClientQt::didChangeTitle):
- WebCoreSupport/FrameLoaderClientQt.h:
2010-04-22 Dave Moore <davemoore@chromium.org>
Reviewed by Dimitri Glazkov.
Added notification when the favicons for a page are changed
from a script.
The Document object will notify the frame loader, which will
notify the client. Implementations of FrameLoaderClient will
have to add one method; dispatchDidChangeIcons().
- Interfaces/IWebFrameLoadDelegatePrivate2.idl:
- WebCoreSupport/WebFrameLoaderClient.cpp: (WebFrameLoaderClient::dispatchDidChangeIcons):
- WebCoreSupport/WebFrameLoaderClient.h:
- WebFrame.cpp: (WebFrame::didChangeIcons):
- WebFrame.h:
2010-04-22 Dave Moore <davemoore@chromium.org>
Reviewed by Dimitri Glazkov.
Add test support for icon changes.
- DumpRenderTree/LayoutTestController.cpp: (LayoutTestController::LayoutTestController): (dumpIconChangesCallback): (LayoutTestController::staticFunctions):
- DumpRenderTree/LayoutTestController.h: (LayoutTestController::dumpIconChanges): (LayoutTestController::setDumpIconChanges):
- DumpRenderTree/win/FrameLoadDelegate.cpp: (FrameLoadDelegate::didChangeIcons):
- DumpRenderTree/win/FrameLoadDelegate.h:
- WinLauncher/WinLauncher.h: (WinLauncherWebHost::didChangeIcons):
- 12:55 PM Changeset in webkit [58110] by
-
- 2 edits in trunk/JavaScriptCore
2010-04-22 Steve Block <steveblock@google.com>
Reviewed by Adam Barth.
Update Android to use isfinite, isinf, isnan and signbit from namespace std.
https://bugs.webkit.org/show_bug.cgi?id=37948
- wtf/MathExtras.h:
- 12:46 PM Changeset in webkit [58109] by
-
- 3 edits in trunk/LayoutTests
2010-04-22 Eric Carlson <eric.carlson@apple.com>
Test fix, no review.
https://bugs.webkit.org/show_bug.cgi?id=38000
r58107 causes video-play-stall and video-play-stall-seek to fail
Skip http/tests/media/video-play-stall.html and http/tests/media/video-play-stall-seek.html
until we can figure out how to work around QuickTime bug.
- platform/mac-leopard/Skipped:
- platform/mac-tiger/Skipped:
- 12:39 PM Changeset in webkit [58108] by
-
- 10 edits2 adds in trunk
WebCore:
2010-04-22 Xan Lopez <xlopez@igalia.com>
Reviewed by Gustavo Noronha.
[GTK] GObject DOM bindings
https://bugs.webkit.org/show_bug.cgi?id=33590
Extend the bindings to cover most of Document.idl
- GNUmakefile.am:
- bindings/gobject/WebKitDOMBinding.cpp: (WebKit::createWrapper): (WebKit::kit):
- bindings/gobject/WebKitDOMBinding.h:
- bindings/gobject/WebKitHTMLElementWrapperFactory.cpp: Added. (WebKit::createAnchorWrapper): (WebKit::createAppletWrapper): (WebKit::createAreaWrapper): (WebKit::createBaseWrapper): (WebKit::createBaseFontWrapper): (WebKit::createBlockquoteWrapper): (WebKit::createBodyWrapper): (WebKit::createBRWrapper): (WebKit::createButtonWrapper): (WebKit::createCanvasWrapper): (WebKit::createTableCaptionWrapper): (WebKit::createTableColWrapper): (WebKit::createModWrapper): (WebKit::createDirectoryWrapper): (WebKit::createDivWrapper): (WebKit::createDListWrapper): (WebKit::createEmbedWrapper): (WebKit::createFieldSetWrapper): (WebKit::createFontWrapper): (WebKit::createFormWrapper): (WebKit::createFrameWrapper): (WebKit::createFrameSetWrapper): (WebKit::createHeadingWrapper): (WebKit::createHeadWrapper): (WebKit::createHRWrapper): (WebKit::createHtmlWrapper): (WebKit::createIFrameWrapper): (WebKit::createImageWrapper): (WebKit::createInputWrapper): (WebKit::createIsIndexWrapper): (WebKit::createLabelWrapper): (WebKit::createLegendWrapper): (WebKit::createLIWrapper): (WebKit::createLinkWrapper): (WebKit::createMapWrapper): (WebKit::createMarqueeWrapper): (WebKit::createMenuWrapper): (WebKit::createMetaWrapper): (WebKit::createObjectWrapper): (WebKit::createOListWrapper): (WebKit::createOptGroupWrapper): (WebKit::createOptionWrapper): (WebKit::createParagraphWrapper): (WebKit::createParamWrapper): (WebKit::createPreWrapper): (WebKit::createQuoteWrapper): (WebKit::createScriptWrapper): (WebKit::createSelectWrapper): (WebKit::createStyleWrapper): (WebKit::createTableWrapper): (WebKit::createTableSectionWrapper): (WebKit::createTableCellWrapper): (WebKit::createTextAreaWrapper): (WebKit::createTitleWrapper): (WebKit::createTableRowWrapper): (WebKit::createUListWrapper): (WebKit::createHTMLElementWrapper):
- bindings/gobject/WebKitHTMLElementWrapperFactory.h: Added.
- bindings/scripts/CodeGeneratorGObject.pm:
- dom/Node.idl:
WebKit/gtk:
2010-04-22 Xan Lopez <xlopez@igalia.com>
Reviewed by Gustavo Noronha.
[GTK] GObject DOM bindings
https://bugs.webkit.org/show_bug.cgi?id=33590
Add webkit_web_view_get_document to retrieve the WebKitDOMDocument
from a WebKitWebView, and a very simple test for it.
- tests/testwebview.c:
- webkit/webkitwebview.cpp: (webkit_web_view_get_document):
- webkit/webkitwebview.h:
- 11:06 AM Changeset in webkit [58107] by
-
- 3 edits in trunk/WebCore
2010-04-22 Eric Carlson <eric.carlson@apple.com>
Reviewed by Simon Fraser.
Do not pause movie when readyState drops below HAVE_FUTURE_DATA
https://bugs.webkit.org/show_bug.cgi?id=37991
<rdar://problem/7893937>
No new tests, we don't have infrastructure in DRT to test with streamed
movies.
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::HTMLMediaElement): Initialize m_readyStateMaximum. (WebCore::HTMLMediaElement::prepareForLoad): Reset m_readyStateMaximum. (WebCore::HTMLMediaElement::setReadyState): Maintain m_readyStateMaximum. (WebCore::HTMLMediaElement::potentiallyPlaying): Also return true if the readyState was previously >= HAVE_FUTURE_DATA.
- html/HTMLMediaElement.h:
- 10:57 AM Changeset in webkit [58106] by
-
- 4 edits in trunk/WebKit
2010-04-22 Leandro Pereira <leandro@profusion.mobi>
Reviewed by Gustavo Noronha Silva.
Update EFL port files to match recent API changes.
http://webkit.org/b/37876
- efl/WebCoreSupport/ChromeClientEfl.cpp: (kit): Added. (WebCore::ChromeClientEfl::ChromeClientEfl): Coding style fix. (WebCore::ChromeClientEfl::runBeforeUnloadConfirmPanel): Coding style fix. (WebCore::ChromeClientEfl::mouseDidMoveOverElement): Coding style fix. (WebCore::ChromeClientEfl::runOpenPanel): Implemented. (WebCore::ChromeClientEfl::cancelGeolocationPermissionRequestForFrame): Stubbed. (WebCore::ChromeClientEfl::cancelGeolocationPermissionForFrame): Stubbed. (WebCore::ChromeClientEfl::invalidateContents): Stubbed. (WebCore::ChromeClientEfl::invalidateWindow): Stubbed. (WebCore::ChromeClientEfl::invalidateContentsAndWindow): Implemented. (WebCore::ChromeClientEfl::invalidateContentsForSlowScroll): Implemented. (WebCore::ChromeClientEfl::scroll): Updated. (WebCore::ChromeClientEfl::iconForFiles): Stubbed. (WebCore::ChromeClientEfl::chooseIconForFiles): Stubbed.
- efl/WebCoreSupport/ChromeClientEfl.h: Add new method prototypes.
- efl/WebCoreSupport/FrameLoaderClientEfl.cpp: (WebCore::FrameLoaderClientEfl::committedLoad): Call setEncoding() from FrameLoader::writer. (WebCore::FrameLoaderClientEfl::finishedLoading): Ditto. (WebCore::FrameLoaderClientEfl::dispatchDidFailLoading): Ditto. (WebCore::FrameLoaderClientEfl::setMainDocumentError): Ditto.
- 10:32 AM Changeset in webkit [58105] by
-
- 2 edits in trunk/WebKit/qt
2010-04-22 Jocelyn Turcotte <jocelyn.turcotte@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Remove translatable strings from the hybridPixmap test.
https://bugs.webkit.org/show_bug.cgi?id=37867
- tests/hybridPixmap/widget.ui:
- 10:13 AM Changeset in webkit [58104] by
-
- 3 edits in trunk/JavaScriptCore
2010-04-22 Jocelyn Turcotte <jocelyn.turcotte@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Remove dependency of JSC to QtGui
https://bugs.webkit.org/show_bug.cgi?id=37867
The patch also make sure that hal.h is in the include path on Symbian.
The dependency to QtGui took care of that before.
Patch by Thiago Macieira <thiago.macieira@nokia.com>
and Rohan McGovern <rohan.mcgovern@nokia.com>
- JavaScriptCore.pri:
- JavaScriptCore.pro:
- 10:04 AM Changeset in webkit [58103] by
-
- 5 edits in trunk
2010-04-22 Zhenyao Mo <zmo@google.com>
Reviewed by Dimitri Glazkov.
Regression: framebufferRenderbuffer crashes with null renderBuffer
https://bugs.webkit.org/show_bug.cgi?id=37963
- fast/canvas/webgl/framebuffer-object-attachment-expected.txt: Adding test cases for null renderbuffer input.
- fast/canvas/webgl/framebuffer-object-attachment.html: Ditto.
2010-04-22 Zhenyao Mo <zmo@google.com>
Reviewed by Dimitri Glazkov.
Regression: framebufferRenderbuffer crashes with null renderBuffer
https://bugs.webkit.org/show_bug.cgi?id=37963
- html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::framebufferRenderbuffer): Dealing with null renderbuffer input.
- 9:54 AM Changeset in webkit [58102] by
-
- 8 edits in trunk
2010-04-22 Zhenyao Mo <zmo@google.com>
Reviewed by Dimitri Glazkov.
Emulate GL_IMPLEMENTATION_COLOR_READ_FORMAT/TYPE for glGet
https://bugs.webkit.org/show_bug.cgi?id=37281
- fast/canvas/webgl/read-pixels-expected.txt: Add test case for the other supported format/type in readPixels (besides RGBA/UNSIGNED_BYTE); also, changed to a simpler test framework.
- fast/canvas/webgl/read-pixels.html: Ditto.
2010-04-22 Zhenyao Mo <zmo@google.com>
Reviewed by Dimitri Glazkov.
Emulate GL_IMPLEMENTATION_COLOR_READ_FORMAT/TYPE for glGet
https://bugs.webkit.org/show_bug.cgi?id=37281
- html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::WebGLRenderingContext): Remove error check because two enums are supported now. (WebCore::WebGLRenderingContext::getParameter): Add two enums. (WebCore::WebGLRenderingContext::readPixels): Fix a tiny bug.
- platform/graphics/mac/GraphicsContext3DMac.cpp: (WebCore::GraphicsContext3D::getIntegerv): Emulate two enums.
2010-04-22 Zhenyao Mo <zmo@google.com>
Reviewed by Dimitri Glazkov.
Emulate GL_IMPLEMENTATION_COLOR_READ_FORMAT/TYPE for glGet
https://bugs.webkit.org/show_bug.cgi?id=37281
- src/WebGraphicsContext3DDefaultImpl.cpp: (WebKit::WebGraphicsContext3DDefaultImpl::getIntegerv): Emulate two enums.
- 9:50 AM Changeset in webkit [58101] by
-
- 2 edits in trunk/BugsSite
2010-04-22 Adam Barth <abarth@webkit.org>
Unreviewed. Turns out we need to do more escaping because Ruby was
explanding our newlines, creating a syntax error.
- PrettyPatch/PrettyPatch.rb:
- 9:38 AM Changeset in webkit [58100] by
-
- 2 edits in trunk/JavaScriptCore
2010-04-22 Jocelyn Turcotte <jocelyn.turcotte@nokia.com>
Reviewed by Tor Arne Vestbø.
[Qt] Corrects symbols visibility for JavaScriptCore.
- JavaScriptCore.pro:
- 9:28 AM Changeset in webkit [58099] by
-
- 3 edits in trunk/LayoutTests
2010-04-22 Marcus Bulach <bulach@chromium.org>
Reviewed by Dimitri Glazkov.
Enable LayoutTests for EventSource on chromium
https://bugs.webkit.org/show_bug.cgi?id=37863
- platform/chromium/fast/dom/prototype-inheritance-expected.txt:
- platform/chromium/test_expectations.txt:
- 8:46 AM Changeset in webkit [58098] by
-
- 2 edits in trunk/WebKit/gtk
2010-04-22 Diego Escalante Urrelo <descalante@igalia.com>
Reviewed by Xan Lopez.
[Gtk] Evaluate and create tests for all the AtkRole's implemented by
WebKitGtk
https://bugs.webkit.org/show_bug.cgi?id=34449
Expand testatkroles to test ATK_ROLE_COMBO_BOX.
- tests/testatkroles.c: (test_webkit_atk_get_role_combobox): (main):
- 8:36 AM Changeset in webkit [58097] by
-
- 2 edits in trunk/WebCore
2010-04-22 Diego Escalante Urrelo <descalante@igalia.com>
Reviewed by Xan Lopez.
[GTK] Mute/unmute button on <video> elements are backwards
https://bugs.webkit.org/show_bug.cgi?id=33967
Fix mute/unmute buttons icons-action relation and explain why their
variable names and corresponding icons seem to be misleading but are
actually right. Original patch by Mike Hommey.
- platform/gtk/RenderThemeGtk.cpp: (WebCore::RenderThemeGtk::initMediaStyling):
- 7:56 AM Changeset in webkit [58096] by
-
- 13 edits in trunk/WebKit/qt
2010-04-22 Jocelyn Turcotte <jocelyn.turcotte@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Fix autotests .qrc file paths when built in Qt.
Compiling auto-tests from qt/tests/auto/qweb* produced
failing tests since these .pro files include the
ones in WebKit/qt/tests and the .qrc file was
not added to RESOURCES
- tests/benchmarks/loading/loading.pro:
- tests/benchmarks/painting/painting.pro:
- tests/qgraphicswebview/qgraphicswebview.pro:
- tests/qwebelement/qwebelement.pro:
- tests/qwebframe/qwebframe.pro:
- tests/qwebhistory/qwebhistory.pro:
- tests/qwebhistoryinterface/qwebhistoryinterface.pro:
- tests/qwebinspector/qwebinspector.pro:
- tests/qwebpage/qwebpage.pro:
- tests/qwebplugindatabase/qwebplugindatabase.pro:
- tests/qwebview/qwebview.pro:
- tests/tests.pri:
- 7:46 AM Changeset in webkit [58095] by
-
- 2 edits in trunk/WebCore
2010-04-22 Gustavo Sverzut Barbieri <barbieri@profusion.mobi>
Reviewed by Eric Seidel.
Fix build if NPAPI support is disabled
https://bugs.webkit.org/show_bug.cgi?id=36621
No new tests, this is a build fix.
Re-submit r58043 with fix for EFL.
- plugins/PluginViewNone.cpp:
- 7:36 AM Changeset in webkit [58094] by
-
- 3 edits in trunk/WebCore
2010-04-22 Diego Escalante Urrelo <descalante@igalia.com>
Reviewed by Xan Lopez.
[Gtk] Evaluate and create tests for all the AtkRole's implemented by
WebKitGtk
https://bugs.webkit.org/show_bug.cgi?id=34449
Implement ATK_ROLE_COMBO_BOX.
- accessibility/gtk/AccessibilityObjectAtk.cpp: (WebCore::AccessibilityObject::accessibilityPlatformIncludesObject):
- accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (atkRole):
- 6:50 AM Changeset in webkit [58093] by
-
- 15 edits11 moves1 delete in trunk/WebCore
2010-04-22 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Dirk Schulze.
SVGPaintServer needs to be converted to the new RenderSVGResource* system
https://bugs.webkit.org/show_bug.cgi?id=37986
No functional changes, just move the SVGPaintServer* classes from svg/graphics/ to rendering/, the new location for the RenderSVGResource* classes.
This is a preparation for the real patch which follows soon.
- Android.mk: Rename files and move to the right location.
- GNUmakefile.am: Ditto.
- WebCore.gypi: Ditto.
- WebCore.pro: Ditto.
- WebCore.vcproj/WebCore.vcproj: Ditto.
- WebCore.xcodeproj/project.pbxproj: Ditto.
- rendering/RenderSVGResource.cpp: Copied from svg/graphics/SVGPaintServer.cpp.
- rendering/RenderSVGResourceGradient.cpp: Copied from svg/graphics/SVGPaintServerGradient.cpp.
- rendering/RenderSVGResourceGradient.h: Copied from svg/graphics/SVGPaintServerGradient.h.
- rendering/RenderSVGResourceLinearGradient.cpp: Copied from svg/graphics/SVGPaintServerLinearGradient.cpp.
- rendering/RenderSVGResourceLinearGradient.h: Copied from svg/graphics/SVGPaintServerLinearGradient.h.
- rendering/RenderSVGResourcePattern.cpp: Copied from svg/graphics/SVGPaintServerPattern.cpp.
- rendering/RenderSVGResourcePattern.h: Copied from svg/graphics/SVGPaintServerPattern.h.
- rendering/RenderSVGResourceRadialGradient.cpp: Copied from svg/graphics/SVGPaintServerRadialGradient.cpp.
- rendering/RenderSVGResourceRadialGradient.h: Copied from svg/graphics/SVGPaintServerRadialGradient.h.
- rendering/RenderSVGResourceSolidColor.cpp: Copied from svg/graphics/SVGPaintServerSolid.cpp.
- rendering/RenderSVGResourceSolidColor.h: Copied from svg/graphics/SVGPaintServerSolid.h.
- rendering/SVGRenderTreeAsText.cpp: Change include file names.
- svg/SVGFont.cpp: Ditto.
- svg/SVGGradientElement.cpp: Ditto.
- svg/SVGGradientElement.h: Ditto.
- svg/SVGLinearGradientElement.cpp: Ditto.
- svg/SVGPatternElement.cpp: Ditto.
- svg/SVGPatternElement.h: Ditto.
- svg/SVGRadialGradientElement.cpp: Ditto.
- svg/graphics/SVGPaintServer.cpp: Removed.
- svg/graphics/SVGPaintServerGradient.cpp: Removed.
- svg/graphics/SVGPaintServerGradient.h: Removed.
- svg/graphics/SVGPaintServerLinearGradient.cpp: Removed.
- svg/graphics/SVGPaintServerLinearGradient.h: Removed.
- svg/graphics/SVGPaintServerPattern.cpp: Removed.
- svg/graphics/SVGPaintServerPattern.h: Removed.
- svg/graphics/SVGPaintServerRadialGradient.cpp: Removed.
- svg/graphics/SVGPaintServerRadialGradient.h: Removed.
- svg/graphics/SVGPaintServerSolid.cpp: Removed.
- svg/graphics/SVGPaintServerSolid.h: Removed.
- svg/graphics/SVGResourceListener.h: Removed.
- 6:34 AM Changeset in webkit [58092] by
-
- 2 edits in trunk/WebCore
2010-04-22 Jocelyn Turcotte <jocelyn.turcotte@nokia.com>
Reviewed by Simon Hausmann.
[Qt] Hide the OpenGL and QtMultimedia dependencies from syncqt.
This prevents the dependent headers from being included by
qt/include/QtWebKit/QtWebKit
- WebCore.pro:
- 6:24 AM Changeset in webkit [58091] by
-
- 4 edits in trunk/JavaScriptCore
2010-04-22 Gabor Loki <loki@webkit.org>
Reviewed by Gavin Barraclough.
Use BLX and BX to keep happy the return stack predictor above ARMv4
https://bugs.webkit.org/show_bug.cgi?id=37862
Inspired by Jacob Bramley's patch from JaegerMonkey
- assembler/ARMAssembler.cpp: (JSC::ARMAssembler::executableCopy):
- assembler/ARMAssembler.h: (JSC::ARMAssembler::): (JSC::ARMAssembler::bx): (JSC::ARMAssembler::blx): (JSC::ARMAssembler::loadBranchTarget): (JSC::ARMAssembler::jmp): (JSC::ARMAssembler::getLdrImmAddress):
- assembler/MacroAssemblerARM.h: (JSC::MacroAssemblerARM::jump): (JSC::MacroAssemblerARM::nearCall): (JSC::MacroAssemblerARM::call): (JSC::MacroAssemblerARM::ret): (JSC::MacroAssemblerARM::prepareCall): (JSC::MacroAssemblerARM::call32):
- 5:28 AM Changeset in webkit [58090] by
-
- 2 edits in trunk/LayoutTests
2010-04-22 Zhenyao Mo <zmo@google.com>
Reviewed by Eric Seidel.
Turn on antialias and stencil as default canvas attributes.
https://bugs.webkit.org/show_bug.cgi?id=36972
- fast/canvas/webgl/resources/webgl-test.js: (create3DContext): Turn on antialias and stencil as default canvas attributes.
- 5:09 AM Changeset in webkit [58089] by
-
- 2 edits in trunk/WebCore
2010-04-22 Gustavo Sverzut Barbieri <barbieri@profusion.mobi>
Reviewed by Adam Roben.
EFL does not support PluginDatabase yet.
http://webkit.org/b/37854
No behavior changes, so no new tests were added.
- loader/FrameLoader.cpp: (WebCore::FrameLoader::defaultObjectContentType):
- 5:08 AM Changeset in webkit [58088] by
-
- 2 edits in trunk/WebKitTools
2010-04-22 Eric Seidel <eric@webkit.org>
Unreviewed. Script fix. Will ask dpranke to look tomorrow.
new-run-webkit-tests --verbose shows ever-increasing #EOF lines
https://bugs.webkit.org/show_bug.cgi?id=37794
The bots are seeing cases where .error is sometimes empty.
Lets make the code not crash in that case for now.
- Scripts/webkitpy/layout_tests/port/webkit.py:
- 4:21 AM Changeset in webkit [58087] by
-
- 4 edits in trunk/WebCore
2010-04-22 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: Timeline scrolling speed is slow if it has more than 1k timeline marks.
https://bugs.webkit.org/show_bug.cgi?id=37924
- inspector/front-end/TimelineGrid.js: (WebInspector.TimelineGrid.prototype.updateDividers): (WebInspector.TimelineGrid.prototype.addEventDividers):
- inspector/front-end/TimelineOverviewPane.js: (WebInspector.TimelineOverviewPane.prototype.updateEventDividers):
- inspector/front-end/TimelinePanel.js: (WebInspector.TimelinePanel.prototype._updateEventDividers): (WebInspector.TimelinePanel.prototype._refresh):
- 4:15 AM Changeset in webkit [58086] by
-
- 2 edits in trunk/WebKitTools
Unreviewed fix.
- Scripts/webkitpy/layout_tests/port/websocket_server.py: fix NameError: global name 'f' is not defined.
- 4:11 AM Changeset in webkit [58085] by
-
- 24 edits in trunk
2010-04-22 Kenneth Rohde Christiansen <kenneth@webkit.org>
Unreviewed expected results update.
Rename window.media to window.styleMedia
https://bugs.webkit.org/show_bug.cgi?id=36187
- fast/dom/Window/window-properties-expected.txt:
- fast/dom/Window/window-property-descriptors-expected.txt:
- fast/dom/prototype-inheritance-2-expected.txt:
- fast/dom/prototype-inheritance-expected.txt:
- fast/media/print-restores-previous-mediatype-expected.txt:
- platform/chromium/fast/dom/prototype-inheritance-expected.txt:
- platform/gtk/fast/dom/Window/window-properties-expected.txt:
- platform/gtk/fast/dom/Window/window-property-descriptors-expected.txt:
- platform/gtk/fast/dom/prototype-inheritance-expected.txt:
- platform/qt/fast/dom/Window/window-properties-expected.txt:
- platform/qt/fast/dom/Window/window-property-descriptors-expected.txt:
- platform/qt/fast/dom/prototype-inheritance-expected.txt:
- platform/win/fast/dom/Window/window-property-descriptors-expected.txt:
- platform/win/fast/dom/prototype-inheritance-2-expected.txt:
- platform/win/fast/dom/prototype-inheritance-expected.txt:
2010-04-22 Kenneth Rohde Christiansen <kenneth@webkit.org>
Reviewed by Simon Fraser.
Rename window.media to window.styleMedia
https://bugs.webkit.org/show_bug.cgi?id=36187
It has been defined that the AbstractView media extension
defined in the CSSOM View spec should be renamed to styleMedia.
This patch does that and updates the current layout tests
making use of it.
- page/AbstractView.idl:
- page/DOMWindow.cpp: (WebCore::DOMWindow::styleMedia):
- page/DOMWindow.h:
- page/DOMWindow.idl:
- 3:41 AM Changeset in webkit [58084] by
-
- 2 edits in trunk/WebCore
2010-04-22 Anton Muhin <antonm@chromium.org>
Reviewed by Adam Barth.
[v8] Do not pass empty handle into SetHiddenValue which would crash.
https://bugs.webkit.org/show_bug.cgi?id=37801
- bindings/v8/V8AbstractEventListener.cpp: (WebCore::V8AbstractEventListener::handleEvent): add couple of asserts to check for unexpected paths (WebCore::V8AbstractEventListener::invokeEventHandler): bail out of jsEvent is empty handle
- 3:31 AM Changeset in webkit [58083] by
-
- 2 edits in trunk/WebKit/gtk
2010-04-22 Diego Escalante Urrelo <descalante@igalia.com>
Reviewed by Xan Lopez.
[Gtk] Evaluate and create tests for all the AtkRole's implemented by
WebKitGtk
https://bugs.webkit.org/show_bug.cgi?id=34449
Expand testatkroles to test ATK_ROLE_SEPARATOR.
- tests/testatkroles.c: (test_webkit_atk_get_role_separator): (main):
- 3:19 AM Changeset in webkit [58082] by
-
- 2 edits in trunk/WebKitTools
Unreviewed fix.
- Scripts/new-run-webkit-websocketserver: PyWebSocket no longer takes keyword argument 'register_cygwin'.
- 3:00 AM Changeset in webkit [58081] by
-
- 2 edits in trunk/WebKitTools
Unreviewed fix.
- Scripts/webkitpy/layout_tests/port/http_server.py: fix NameError: global name 'env' is not defined.
- 2:59 AM Changeset in webkit [58080] by
-
- 2 edits in trunk/WebKitTools
2010-04-22 Eric Seidel <eric@webkit.org>
Unreviewed. Restore the Leopard bots to using
old-run-webkit-tests for now.
- Scripts/run-webkit-tests:
- 2:48 AM Changeset in webkit [58079] by
-
- 2 edits in trunk/WebKitTools
Unreviewed fix.
- Scripts/webkitpy/layout_tests/port/websocket_server.py: fix NameError: global name 'env' is not defined.
- 2:38 AM Changeset in webkit [58078] by
-
- 3 edits in trunk/WebCore
2010-04-22 Stephan Aßmus <superstippi@gmx.de>
Reviewed by David Levin.
[Haiku] Implement ImageBuffer support
https://bugs.webkit.org/show_bug.cgi?id=35288
Covered by existing tests.
Complete implementation of ImageBuffer for Haiku. Uses StillImage
class to export a WebCore::Image and associated GraphicsContext
to perform arbitrary drawing in the offscreen BBitmap buffer.
- platform/graphics/haiku/ImageBufferData.h:
- platform/graphics/haiku/ImageBufferHaiku.cpp, (WebCore::ImageBufferData::ImageBufferData), (WebCore::ImageBufferData::~ImageBufferData), (WebCore::ImageBuffer::ImageBuffer), (WebCore::ImageBuffer::~ImageBuffer), (WebCore::ImageBuffer::context), (WebCore::ImageBuffer::image):
Implementation uses offscreen BBitmap and BView, wraps StillImage
around those to provide WebCore::Image interface.
(WebCore::ImageBuffer::platformTransformColorSpace):
(WebCore::convertFromData):
Method just performs BGRA <-> RGBA conversion.
(WebCore::convertFromInternalData):
Method just performs BGRA <-> RGBA conversion and handles
pre-multiplying the color values if requested.
(WebCore::convertToInternalData):
Method just performs BGRA <-> RGBA conversion and handles
de.multiplying the color values if requested.
(WebCore::getImageData):
Common code for the next two methods.
(WebCore::ImageBuffer::getUnmultipliedImageData),
(WebCore::ImageBuffer::getPremultipliedImageData):
Implemented.
(WebCore::putImageData):
Common code for the next two methods.
(WebCore::ImageBuffer::putUnmultipliedImageData),
(WebCore::ImageBuffer::putPremultipliedImageData):
Implemented.
(WebCore::ImageBuffer::toDataURL):
Uses Haiku "Translation Kit" to convert image data to data
of the requested mime type.
- 2:34 AM Changeset in webkit [58077] by
-
- 6 edits in trunk/WebKitTools
2010-04-22 Fumitoshi Ukai <ukai@chromium.org>
Reviewed by Adam Barth.
Chromium: Add --chromium option to new-run-webkit-websocketserver
https://bugs.webkit.org/show_bug.cgi?id=37664
Move cygwin setup logic in chromium_win.py.
- Scripts/new-run-webkit-httpd: remove register_cygwin parameter to pass http_server.
- Scripts/new-run-webkit-websocketserver: add --chromium flag
- Scripts/webkitpy/layout_tests/port/chromium_win.py: setup for cygwin
- Scripts/webkitpy/layout_tests/port/http_server.py: remove cygwin setup logic
- Scripts/webkitpy/layout_tests/port/websocket_server.py: remove cygwin setup logic
- 2:20 AM Changeset in webkit [58076] by
-
- 3 edits in trunk/WebKitTools
2010-04-22 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
new-run-webkit-tests --verbose shows ever-increasing #EOF lines
https://bugs.webkit.org/show_bug.cgi?id=37794
- Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
- Fix the log message to explain that this is stderr output, not test output.
- Scripts/webkitpy/layout_tests/port/webkit.py:
- Be sure to reset the server_process.error after reading (seems like the wrong place to do this, but at least this fixes the bug and dpranke and I can talk about better designs later).
- Also remove the #EOF from the stderr output before returning it.
- 2:12 AM Changeset in webkit [58075] by
-
- 2 edits1 add in trunk/BugsSite
2010-04-22 Adam Barth <abarth@webkit.org>
Reviewed by Darin Adler.
Hack up PrettyDiff to allow line-by-line comments
https://bugs.webkit.org/show_bug.cgi?id=37886
Admittedly a bit of a hack, this is a basic line-by-line editor we can
play with thanks to Andrew Scherkus. It's meant to integrate with the
"review" page at bugs.webkit.org.
I changed a few things from Andrew's original version:
1) Trigger text boxes on single click to make iPhone/iPad reviewing
easier.
2) Clear the main text box on load.
3) Reference a version of prototype.js on bugs.webkit.org.
- PrettyPatch/PrettyPatch.rb:
- prototype.js: Added.
- 1:29 AM Changeset in webkit [58074] by
-
- 2 edits in trunk/WebKitTools
2010-04-22 Eric Seidel <eric@webkit.org>
Unreviewed. Fixing new-run-webkit-tests on the bots.
- Scripts/webkitpy/layout_tests/run_webkit_tests.py:
- Fixing _compat_shim_option to take variable keyword args.
- Turns out that nargs + callback is ignored unless type is specified. So I added the type so that the option was properly consumed. This was why new-run-webkit-tests couldn't find any tests, it was looking for them under "20" because that was the argument which should have been consumed by --exit-after-n-failures.
- 1:03 AM Changeset in webkit [58073] by
-
- 2 edits in trunk/WebKitTools
2010-04-22 Tony Chang <tony@chromium.org>
Not reviewed, build fix for chromium Windows.
[chromium] fix ImageDiff compile on windows
https://bugs.webkit.org/show_bug.cgi?id=37979
- DumpRenderTree/chromium/ImageDiff.cpp:
- 12:50 AM Changeset in webkit [58072] by
-
- 42 edits3 deletes in trunk
2010-04-22 Adam Barth <abarth@webkit.org>
Unreviewed, rolling out r58069.
http://trac.webkit.org/changeset/58069
https://bugs.webkit.org/show_bug.cgi?id=27751
Broke compile on Windows.
- editing/execCommand/clipboard-access-expected.txt: Removed.
- editing/execCommand/clipboard-access.html: Removed.
- editing/execCommand/script-tests/clipboard-access.js: Removed.
2010-04-22 Adam Barth <abarth@webkit.org>
Unreviewed, rolling out r58069.
http://trac.webkit.org/changeset/58069
https://bugs.webkit.org/show_bug.cgi?id=27751
Broke compile on Windows.
- WebCore.base.exp:
- editing/EditorCommand.cpp: (WebCore::supportedPaste): (WebCore::createCommandMap):
- page/Settings.cpp: (WebCore::Settings::Settings):
- page/Settings.h:
2010-04-22 Adam Barth <abarth@webkit.org>
Unreviewed, rolling out r58069.
http://trac.webkit.org/changeset/58069
https://bugs.webkit.org/show_bug.cgi?id=27751
Broke compile on Windows.
- public/WebSettings.h:
- src/WebSettingsImpl.cpp:
- src/WebSettingsImpl.h:
2010-04-22 Adam Barth <abarth@webkit.org>
Unreviewed, rolling out r58069.
http://trac.webkit.org/changeset/58069
https://bugs.webkit.org/show_bug.cgi?id=27751
Broke compile on Windows.
- webkit/webkitwebsettings.cpp: (webkit_web_settings_class_init): (webkit_web_settings_set_property): (webkit_web_settings_get_property): (webkit_web_settings_copy):
- webkit/webkitwebview.cpp: (webkit_web_view_update_settings): (webkit_web_view_settings_notify):
2010-04-22 Adam Barth <abarth@webkit.org>
Unreviewed, rolling out r58069.
http://trac.webkit.org/changeset/58069
https://bugs.webkit.org/show_bug.cgi?id=27751
Broke compile on Windows.
- WebView/WebPreferenceKeysPrivate.h:
- WebView/WebPreferences.mm: (+[WebPreferences initialize]):
- WebView/WebPreferencesPrivate.h:
- WebView/WebView.mm: (-[WebView _preferencesChangedNotification:]):
2010-04-22 Adam Barth <abarth@webkit.org>
Unreviewed, rolling out r58069.
http://trac.webkit.org/changeset/58069
https://bugs.webkit.org/show_bug.cgi?id=27751
Broke compile on Windows.
- Api/qwebsettings.cpp: (QWebSettingsPrivate::apply):
- Api/qwebsettings.h:
2010-04-22 Adam Barth <abarth@webkit.org>
Unreviewed, rolling out r58069.
http://trac.webkit.org/changeset/58069
https://bugs.webkit.org/show_bug.cgi?id=27751
Broke compile on Windows.
- Interfaces/IWebPreferencesPrivate.idl:
- WebPreferenceKeysPrivate.h:
- WebPreferences.cpp: (WebPreferences::initializeDefaultSettings):
- WebPreferences.h:
- WebView.cpp: (WebView::notifyPreferencesChanged):
2010-04-22 Adam Barth <abarth@webkit.org>
Unreviewed, rolling out r58069.
http://trac.webkit.org/changeset/58069
https://bugs.webkit.org/show_bug.cgi?id=27751
Broke compile on Windows.
- DumpRenderTree/LayoutTestController.cpp: (LayoutTestController::staticFunctions):
- DumpRenderTree/LayoutTestController.h:
- DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::LayoutTestController): (LayoutTestController::overridePreference):
- DumpRenderTree/chromium/LayoutTestController.h:
- DumpRenderTree/chromium/TestShell.cpp: (TestShell::resetWebSettings):
- DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
- DumpRenderTree/mac/DumpRenderTree.mm: (resetDefaultsToConsistentValues):
- DumpRenderTree/mac/LayoutTestControllerMac.mm:
- DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::WebPage::WebPage): (WebCore::WebPage::resetSettings):
- DumpRenderTree/qt/LayoutTestControllerQt.cpp:
- DumpRenderTree/qt/LayoutTestControllerQt.h:
- DumpRenderTree/win/DumpRenderTree.cpp: (resetDefaultsToConsistentValues):
- DumpRenderTree/win/LayoutTestControllerWin.cpp:
- DumpRenderTree/wx/LayoutTestControllerWx.cpp:
- 12:40 AM Changeset in webkit [58071] by
-
- 4 edits in trunk/WebKitTools
2010-04-22 Eric Seidel <eric@webkit.org>
Unreviewed. Just adding logging.
Adding logging to help debug why the Leopard Bot
can't find any tests to run.
- Scripts/webkitpy/layout_tests/layout_package/test_files.py:
- Scripts/webkitpy/layout_tests/port/base.py:
- Scripts/webkitpy/layout_tests/run_webkit_tests.py:
- Make it a fatal error to have no tests to run.
- 12:40 AM Changeset in webkit [58070] by
-
- 2 edits in trunk/WebKit/chromium
2010-04-22 Tony Chang <tony@chromium.org>
Reviewed by Shinichiro Hamaji.
[chromium] roll chromium deps to pick up some windows build fixes
https://bugs.webkit.org/show_bug.cgi?id=37972
- DEPS:
- 12:37 AM Changeset in webkit [58069] by
-
- 42 edits3 adds in trunk
2010-04-22 Abhishek Arya <inferno@chromium.org>
Reviewed by Adam Barth.
Manual test to verify that javascript cannot access clipboard.
https://bugs.webkit.org/show_bug.cgi?id=27751
- editing/execCommand/clipboard-access-expected.txt: Added.
- editing/execCommand/clipboard-access.html: Added.
- editing/execCommand/script-tests/clipboard-access.js: Added. (enabled): (whenEnabled): (runTest):
2010-04-22 Abhishek Arya <inferno@chromium.org>
Reviewed by Adam Barth.
Add support for controlling clipboard access from javascript.
Clipboard access from javascript is disabled by default.
https://bugs.webkit.org/show_bug.cgi?id=27751
Test: editing/execCommand/clipboard-access.html
- WebCore.base.exp:
- editing/EditorCommand.cpp: (WebCore::supportedCopyCut): (WebCore::supportedPaste): (WebCore::createCommandMap):
- page/Settings.cpp: (WebCore::Settings::Settings): (WebCore::Settings::setJavaScriptCanAccessClipboard):
- page/Settings.h: (WebCore::Settings::javaScriptCanAccessClipboard):
2010-04-22 Abhishek Arya <inferno@chromium.org>
Reviewed by Adam Barth.
Add support for controlling clipboard access from javascript.
Clipboard access from javascript is disabled by default.
https://bugs.webkit.org/show_bug.cgi?id=27751
- public/WebSettings.h:
- src/WebSettingsImpl.cpp: (WebKit::WebSettingsImpl::setJavaScriptCanAccessClipboard):
- src/WebSettingsImpl.h:
2010-04-22 Abhishek Arya <inferno@chromium.org>
Reviewed by Adam Barth.
Add support for controlling clipboard access from javascript.
Clipboard access from javascript is disabled by default.
https://bugs.webkit.org/show_bug.cgi?id=27751
- webkit/webkitwebsettings.cpp: (webkit_web_settings_class_init): (webkit_web_settings_set_property): (webkit_web_settings_get_property): (webkit_web_settings_copy):
- webkit/webkitwebview.cpp: (webkit_web_view_update_settings): (webkit_web_view_settings_notify):
2010-04-22 Abhishek Arya <inferno@chromium.org>
Reviewed by Adam Barth.
Add support for controlling clipboard access from javascript.
Clipboard access from javascript is disabled by default.
https://bugs.webkit.org/show_bug.cgi?id=27751
- WebView/WebPreferenceKeysPrivate.h:
- WebView/WebPreferences.mm: (+[WebPreferences initialize]): (-[WebPreferences javaScriptCanAccessClipboard]): (-[WebPreferences setJavaScriptCanAccessClipboard:]):
- WebView/WebPreferencesPrivate.h:
- WebView/WebView.mm: (-[WebView _preferencesChangedNotification:]):
2010-04-22 Abhishek Arya <inferno@chromium.org>
Reviewed by Adam Barth.
Add support for controlling clipboard access from javascript.
Clipboard access from javascript is disabled by default.
https://bugs.webkit.org/show_bug.cgi?id=27751
- Api/qwebsettings.cpp: (QWebSettingsPrivate::apply):
- Api/qwebsettings.h:
2010-04-22 Abhishek Arya <inferno@chromium.org>
Reviewed by Adam Barth.
Add support for controlling clipboard access from javascript.
Clipboard access from javascript is disabled by default.
https://bugs.webkit.org/show_bug.cgi?id=27751
- Interfaces/IWebPreferencesPrivate.idl:
- WebPreferenceKeysPrivate.h:
- WebPreferences.cpp: (WebPreferences::initializeDefaultSettings): (WebPreferences::javaScriptCanAccessClipboard): (WebPreferences::setJavaScriptCanAccessClipboard):
- WebPreferences.h:
- WebView.cpp: (WebView::notifyPreferencesChanged):
2010-04-22 Abhishek Arya <inferno@chromium.org>
Reviewed by Adam Barth.
Add support for controlling clipboard access from javascript.
Clipboard access from javascript is enabled in test framework.
https://bugs.webkit.org/show_bug.cgi?id=27751
- DumpRenderTree/LayoutTestController.cpp: (setJavaScriptCanAccessClipboardCallback): (LayoutTestController::staticFunctions):
- DumpRenderTree/LayoutTestController.h:
- DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::LayoutTestController): (LayoutTestController::setJavaScriptCanAccessClipboard): (LayoutTestController::overridePreference):
- DumpRenderTree/chromium/LayoutTestController.h:
- DumpRenderTree/chromium/TestShell.cpp: (TestShell::resetWebSettings):
- DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::setJavaScriptCanAccessClipboard):
- DumpRenderTree/mac/DumpRenderTree.mm: (resetDefaultsToConsistentValues):
- DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::setJavaScriptCanAccessClipboard):
- DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::WebPage::WebPage): (WebCore::WebPage::resetSettings):
- DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::setJavaScriptCanAccessClipboard):
- DumpRenderTree/qt/LayoutTestControllerQt.h:
- DumpRenderTree/win/DumpRenderTree.cpp: (resetDefaultsToConsistentValues):
- DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::setJavaScriptCanAccessClipboard):
- DumpRenderTree/wx/LayoutTestControllerWx.cpp: (LayoutTestController::setJavaScriptCanAccessClipboard):
- 12:29 AM Changeset in webkit [58068] by
-
- 2 edits in trunk/WebCore
2010-04-22 Stephan Aßmus <superstippi@gmx.de>
Reviewed by David Levin.
[Haiku] Improve SimpleFontDataHaiku
https://bugs.webkit.org/show_bug.cgi?id=37411
Covered by existing tests.
- platform/graphics/haiku/SimpleFontDataHaiku.cpp:
- Cleaned up includes
- Removed prototype "charUnicodeToUTF8HACK"
(WebCore::SimpleFontData::platformInit):
- Use const BFont pointer
(WebCore::SimpleFontData::smallCapsFontData):
- "fontPlatformData" was leaked. It is only used as the key for the font cache lookup.
(WebCore::SimpleFontData::platformMetricsForGlyph):
- Use existing WebCore encoding infrastructure instead of adding a hack for Haiku.
- 12:11 AM Changeset in webkit [58067] by
-
- 3 edits in trunk/WebKit/win
Reference count WebView's backing store bitmap to prevent
deleteBackingStore() from freeing the bitmap while it is still being
referenced by Core Animation.
Reviewed by Maciej Stachowiak.
https://bugs.webkit.org/show_bug.cgi?id=37954
- WebView.cpp:
(WebView::ensureBackingStore):
(WebView::addToDirtyRegion):
(WebView::scrollBackingStore):
(WebView::updateBackingStore):
(WebView::paint):
(WebView::backingStore):
(releaseBackingStoreCallback): deref m_backingStoreBitmap once Core
Animation has dropeed its reference to the memory.
(WebView::updateRootLayerContents): ref m_backingStoreBitmap before
passing the memory to Core Animation to prevent deleteBackingStore()
from freeing it while it is still referenced by CA.
- WebView.h: Make m_backingStoreBitmap a RefCountedGDIHandle<HBITMAP>,
and make m_backingStoreDirtyRegion a RefCountedGDIHandle<HRGN>.
