⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Apr 25, 2010:

11:49 PM Changeset in webkit [58235] by yuzo@google.com
  • 1 edit
    3 adds in trunk/LayoutTests

2010-04-25 Yuzo Fujishima <​yuzo@google.com>

Unreviewed, Chromium test expectation change.

Rebaseline test expectation for Chromium.
The following tests pass for Chromium.

​https://bugs.webkit.org/show_bug.cgi?id=38083

  • platform/chromium/fast/js/ToNumber-expected.txt: Added.
  • platform/chromium/fast/js/parseFloat-expected.txt: Added.
11:45 PM Changeset in webkit [58234] by tony@chromium.org
  • 2 edits in trunk/LayoutTests

2010-04-25 Tony Chang <​tony@chromium.org>

Not reviewed, trying to get the chromium bots green.
Adding image diffs to pixel tests.

REGRESSION(r58191): Caret moved a pixel, pixel tests failing
​https://bugs.webkit.org/show_bug.cgi?id=38104

  • platform/chromium/test_expectations.txt:
11:12 PM Changeset in webkit [58233] by tony@chromium.org
  • 2 edits
    5 adds in trunk/LayoutTests

2010-04-25 Tony Chang <​tony@chromium.org>

Not reviewed, trying to get the chromium bots
green.

​https://bugs.webkit.org/show_bug.cgi?id=38099
Rebaseline a new test and add another new test to the
expected fail list on windows and linux.

  • platform/chromium-linux/fast/css-generated-content/after-duplicated-after-split-expected.checksum: Added.
  • platform/chromium-linux/fast/css-generated-content/after-duplicated-after-split-expected.png: Added.
  • platform/chromium-win/fast/css-generated-content/after-duplicated-after-split-expected.checksum: Added.
  • platform/chromium-win/fast/css-generated-content/after-duplicated-after-split-expected.png: Added.
  • platform/chromium-win/fast/css-generated-content/after-duplicated-after-split-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
10:56 PM Changeset in webkit [58232] by yuzo@google.com
  • 2 edits in trunk/LayoutTests

2010-04-25 Yuzo Fujishima <​yuzo@google.com>

Unreviewed, Chromium test expectation change.

editing/inserting/caret-position.html is expected to fail for Chromium.
This is because TextInputController::firstRectForCharacterRange is unimplemented for Chromium.

​https://bugs.webkit.org/show_bug.cgi?id=38100

  • platform/chromium/test_expectations.txt:
3:03 PM Changeset in webkit [58231] by kevino@webkit.org
  • 3 edits in trunk/WebKit/wx

Reviewed by Kevin Ollivier.

Update focus handling code to match current approaches used by other platforms,
and fix focus handling for corner cases such as when a mouse down pops up a dialog.

​https://bugs.webkit.org/show_bug.cgi?id=38086

9:16 AM Changeset in webkit [58230] by hamaji@chromium.org
  • 2 edits in trunk/WebKit/qt

2010-04-25 Shinichiro Hamaji <​hamaji@chromium.org>

Reviewed by Simon Hausmann.

[Qt] layoutTestController.counterValueForElementById crashes for a nonexistent ID
​https://bugs.webkit.org/show_bug.cgi?id=34573

  • WebCoreSupport/DumpRenderTreeSupportQt.cpp: (DumpRenderTreeSupportQt::counterValueForElementById):
8:46 AM Changeset in webkit [58229] by abarth@webkit.org
  • 3 edits
    2 adds in trunk

2010-04-25 Andrey Kosyakov <​caseq@chromium.org>

Reviewed by Adam Barth.

Added tests for pages event handlers being called with
page context when an event is dispatched from an isolated
world.
​https://bugs.webkit.org/show_bug.cgi?id=37947

  • http/tests/security/isolatedWorld/dispatchEvent-expected.txt: Added.
  • http/tests/security/isolatedWorld/dispatchEvent.html: Added.

2010-04-25 Andrey Kosyakov <​caseq@chromium.org>

Reviewed by Adam Barth.

Get context properly when event handler was created on
the main world.
​https://bugs.webkit.org/show_bug.cgi?id=37947

Test: http/tests/security/isolatedWorld/dispatchEvent.html

  • bindings/v8/WorldContextHandle.cpp: (WebCore::WorldContextHandle::adjustedContext):
6:52 AM Changeset in webkit [58228] by eric@webkit.org
  • 15 edits
    5 adds in trunk

2010-04-25 yael aharon <​yael.aharon@nokia.com>

Reviewed by Adele Peterson.

Allow styling of HTMLProgressElement.
​https://bugs.webkit.org/show_bug.cgi?id=37901

Added a test for changing the -webkit-appearance statically and dynamically.

  • fast/dom/HTMLProgressElement/progress-bar-value-pseudo-element.html: Added.
  • platform/chromium/test_expectations.txt:
  • platform/gtk/Skipped:
  • platform/mac/fast/dom/HTMLProgressElement: Added.
  • platform/mac/fast/dom/HTMLProgressElement/progress-bar-value-pseudo-element-expected.checksum: Added.
  • platform/mac/fast/dom/HTMLProgressElement/progress-bar-value-pseudo-element-expected.png: Added.
  • platform/mac/fast/dom/HTMLProgressElement/progress-bar-value-pseudo-element-expected.txt: Added.
  • platform/qt/Skipped:
  • platform/win/Skipped:

2010-04-25 yael aharon <​yael.aharon@nokia.com>

Reviewed by Adele Peterson.

Allow styling of HTMLProgressElement.
​https://bugs.webkit.org/show_bug.cgi?id=37901

Added a new pseudo element to represent the value portion of the progress element.
Web developers can style this pseudo element separate from the rest of the progress element.

Test: fast/dom/HTMLProgressElement/progress-bar-value-pseudo-element.html

  • css/CSSPrimitiveValueMappings.h: (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
  • css/CSSSelector.cpp: (WebCore::CSSSelector::pseudoId): (WebCore::nameToPseudoTypeMap): (WebCore::CSSSelector::extractPseudoType):
  • css/CSSSelector.h:
  • css/CSSValueKeywords.in:
  • platform/ThemeTypes.h:
  • rendering/RenderProgress.cpp: (WebCore::ProgressValueElement::isShadowNode): (WebCore::ProgressValueElement::shadowParentNode): (WebCore::ProgressValueElement::ProgressValueElement): (WebCore::RenderProgress::RenderProgress): (WebCore::RenderProgress::~RenderProgress): (WebCore::RenderProgress::layout): (WebCore::RenderProgress::styleDidChange): (WebCore::RenderProgress::updateFromElement): (WebCore::RenderProgress::updateValuePartState): (WebCore::RenderProgress::createStyleForValuePart): (WebCore::RenderProgress::updateAnimationState):
  • rendering/RenderTheme.cpp: (WebCore::RenderTheme::isControlStyled):
  • rendering/RenderProgress.h:
  • rendering/style/RenderStyleConstants.h:
4:37 AM Changeset in webkit [58227] by eric@webkit.org
  • 3 edits in trunk/WebKit/win

2010-04-25 Yury Semikhatsky <​yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: inspector client shouldn't check if it can be opened
docked if it is already in that state.

​https://bugs.webkit.org/show_bug.cgi?id=37946

  • WebCoreSupport/WebInspectorClient.cpp: (WebInspectorFrontendClient::WebInspectorFrontendClient): (WebInspectorFrontendClient::showWindowWithoutNotifications):
  • WebCoreSupport/WebInspectorClient.h:

Apr 24, 2010:

11:44 PM Changeset in webkit [58226] by sfalken@apple.com
  • 2 edits in trunk/WebKit/win

2010-04-24 Steve Falkenburg <​sfalken@apple.com>

Reviewed by Sam Weinig.

Typo in Geolocation code causes crashes when updates are stopped
​https://bugs.webkit.org/show_bug.cgi?id=38089
<rdar://problem/7904104> Crash closing geolocation tab after allowing to use geolocation

  • WebCoreSupport/WebGeolocationControllerClient.cpp: (WebGeolocationControllerClient::stopUpdating): Call unregister instead of register.
10:06 PM Changeset in webkit [58225] by Darin Adler
  • 1 edit in trunk/JavaScriptCore/ChangeLog

Fix log message.

10:00 PM Changeset in webkit [58224] by Darin Adler
  • 4 edits
    6 adds in trunk

2010-04-24 Darin Adler <Darin Adler>

Reviewed by Dan Bernstein.

REGRESSION (r56560): Crash in parseFloat if passed invalid UTF-16 data
​https://bugs.webkit.org/show_bug.cgi?id=38083
rdar://problem/7901044

Tests: fast/js/ToNumber.html

fast/js/parseFloat.html

  • runtime/JSGlobalObjectFunctions.cpp: (JSC::parseInt): Added a FIXME comment about a problem I noticed. (JSC::parseFloat): Added a FIXME comment about a problem I noticed; covered by test cases in the test I added.
  • runtime/UString.cpp: (JSC::UString::toDouble): Added FIXME comments about two problem I noticed; covered by test cases in the tests I added. Added a return statement so we don't crash when illegal UTF-16 sequences are present.

2010-04-24 Darin Adler <Darin Adler>

Reviewed by Dan Bernstein.

REGRESSION (r56560): Crash in parseFloat if passed invalid UTF-16 data
​https://bugs.webkit.org/show_bug.cgi?id=38083
rdar://problem/7901044

  • fast/js/parseFloat-expected.txt: Added.
  • fast/js/parseFloat.html: Added.
  • fast/js/script-tests/parseFloat.js: Added.
  • fast/js/ToNumber-expected.txt: Added.
  • fast/js/ToNumber.html: Added.
  • fast/js/script-tests/ToNumber.js: Added.
5:47 PM Changeset in webkit [58223] by mitz@apple.com
  • 1 edit
    2 adds in trunk/LayoutTests

Add platform-specific results for Mac after r58222.

  • platform/mac/compositing/iframes: Added.
  • platform/mac/compositing/iframes/composited-iframe-expected.txt: Added.
4:59 PM Changeset in webkit [58222] by mitz@apple.com
  • 2 edits in trunk/WebCore

Don't propagate compositing out of iframes on Mac
​https://bugs.webkit.org/show_bug.cgi?id=38072

Patch by Simon Fraser <Simon Fraser> on 2010-04-24
Reviewed by Dan Bernstein.

Propagating compositing out of iframes caused too many regressions on Mac,
so only do it for other platforms that may need to hook compositing layers
together across iframe boundaries.

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::requiresCompositingForIFrame):

2:54 PM Changeset in webkit [58221] by mitz@apple.com
  • 2 edits in trunk/WebKit/mac

<rdar://problem/7903728> REGRESSION (r51617): WebView fails to load plug-in MIME types
​https://bugs.webkit.org/show_bug.cgi?id=38085

Reviewed by Darin Adler.

WebView was calling -_webView in a few places where it should have just used itself. It never
makes sense for WebView to call -_webView on itself, and these calls look like they were copied
from similar code in WebHTMLView, WebFrameView and WebDataSource, where -_webView has a different,
useful meaning.

  • WebView/WebView.mm:

(-[WebView drawSingleRect:]): Replaced [self _webView] with self.
(-[WebView _viewClass:andRepresentationClass:forMIMEType:]): Replaced [[self _webView] preferences]
with _private->preferences.
(-[WebView _canShowMIMEType:]): Ditto.

10:53 AM Changeset in webkit [58220] by eric@webkit.org
  • 5 edits in trunk

2010-04-24 Anton Muhin <​antonm@chromium.org>

Reviewed by Darin Adler.

Allow to construct HashTraits<WebCore::QualifiedName>::constructDeletedValue

Former implementation attempted to use AtomicString(HashTableDeletedValue)
however those values cannot be used that way: one cannot construct
QualifiedNameImpl out of such AtomicString as we'll try to lookup this string
in the table, for example.
​https://bugs.webkit.org/show_bug.cgi?id=37722

  • wtf/RefPtr.h: expose hash table deleted value

2010-04-24 Anton Muhin <​antonm@chromium.org>

Reviewed by Darin Adler.

Allow to construct HashTraits<WebCore::QualifiedName>::constructDeletedValue

Former implementation attempted to use AtomicString(HashTableDeletedValue)
however those values cannot be used that way: one cannot construct
QualifiedNameImpl out of such AtomicString as we'll try to lookup this string
in the table, for example.
​https://bugs.webkit.org/show_bug.cgi?id=37722

  • dom/QualifiedName.cpp: (WebCore::QualifiedName::deref): check that hash table deleted values never derefed
  • dom/QualifiedName.h: (WebCore::QualifiedName::QualifiedName): add a constructor to create hash table deleted values (WebCore::QualifiedName::isHashTableDeletedValue): add a check if given instance is hash table deleted value (WTF::):
9:40 AM Changeset in webkit [58219] by jchaffraix@webkit.org
  • 4 edits
    2 adds in trunk

protocolHostAndPortEquals host check makes a wrong assumption
​https://bugs.webkit.org/show_bug.cgi?id=37777

Reviewed by Alexey Proskuryakov.

WebCore:

The host check assumed that both host started at the same position. This is true
if both URL are the same but sometimes one has credential and the other does not.
In this case, the method would compare invalid positions.

Test: http/tests/appcache/credential-url.html

  • platform/KURL.cpp:

(WebCore::protocolHostAndPortAreEqual):

  • platform/KURLGoogle.cpp:

(WebCore::protocolHostAndPortAreEqual):
Fix the host check to take both URL's credential into account.

LayoutTests:

Add a check that the URL with credential matches the current URL.

  • http/tests/appcache/credential-url-expected.txt: Added.
  • http/tests/appcache/credential-url.html: Added.
7:43 AM Changeset in webkit [58218] by robert@webkit.org
  • 10 edits
    3 adds in trunk

[Qt] Add more support for textInputController

2010-04-20 Robert Hogan <​robert@webkit.org>

Reviewed by Simon Hausmann.

[Qt] Add more support for textInputController

Add support for selectedRange(), setMarkedText(), insertText(),
and firstRectForCharacterRange().

Unskip tests:

fast/forms/input-maxlength-ime-preedit.html
fast/forms/input-maxlength-ime-completed.html
fast/text/international/thai-cursor-position.html
fast/events/ime-composition-events-001.html
editing/selection/5825350-1.html
editing/selection/5825350-2.html
editing/selection/mixed-editability-10.html

​https://bugs.webkit.org/show_bug.cgi?id=35702

  • platform/qt/Skipped:

2010-04-20 Robert Hogan <​robert@webkit.org>

Reviewed by Simon Hausmann.

[Qt] Add more support for textInputController

Add support for selectedRange(), setMarkedText(), insertText(),
and firstRectForCharacterRange().

Unskip tests:

fast/forms/input-maxlength-ime-preedit.html
fast/forms/input-maxlength-ime-completed.html
fast/text/international/thai-cursor-position.html
fast/events/ime-composition-events-001.html
editing/selection/5825350-1.html
editing/selection/5825350-2.html
editing/selection/mixed-editability-10.html

​https://bugs.webkit.org/show_bug.cgi?id=35702

  • DumpRenderTree/qt/TextInputControllerQt.cpp: (TextInputController::setMarkedText): (TextInputController::insertText): (TextInputController::selectedRange): (TextInputController::firstRectForCharacterRange):
  • DumpRenderTree/qt/TextInputControllerQt.h:

2010-04-20 Robert Hogan <​robert@webkit.org>

Reviewed by Simon Hausmann.

[Qt] Add more support for textInputController

Add support for selectedRange(), setMarkedText(), insertText(),
and firstRectForCharacterRange().

​https://bugs.webkit.org/show_bug.cgi?id=35702

  • Api/qwebpage.cpp: (QWebPagePrivate::inputMethodEvent):
  • WebCoreSupport/DumpRenderTreeSupportQt.cpp: (DumpRenderTreeSupportQt::selectedRange): (DumpRenderTreeSupportQt::firstRectForCharacterRange):
  • WebCoreSupport/DumpRenderTreeSupportQt.h:
  • tests/qwebpage/tst_qwebpage.cpp: (tst_QWebPage::inputMethods):
6:48 AM Changeset in webkit [58217] by Nikolas Zimmermann
  • 2 edits in trunk/LayoutTests

2010-04-24 Nikolas Zimmermann <​nzimmermann@rim.com>

Not reviewed.


Attempt to turn the last core builder green again (not related anymore to my previous SVG checkins :-)
Skip http/tests/media/video-play-stall-seek.html on Windows as well (just like it has been done for Mac in r58107).
Bug ​https://bugs.webkit.org/show_bug.cgi?id=38000 describes the problem, and says it's ok to skip the test.

  • platform/win/Skipped:
6:37 AM Changeset in webkit [58216] by Nikolas Zimmermann
  • 1 edit
    10 adds in trunk/LayoutTests

2010-04-24 Nikolas Zimmermann <​nzimmermann@rim.com>

Not reviewed. Add new results for all SVG tests that were missing on Gtk/Qt (since a while, just took the opportunity to add them now)

  • platform/gtk/svg/custom/broken-internal-references-expected.txt: Added.
  • platform/gtk/svg/custom/clip-path-id-changes-expected.txt: Added.
  • platform/qt/svg/custom/broken-internal-references-expected.txt: Added.
  • platform/qt/svg/custom/clip-path-id-changes-expected.txt: Added.
  • platform/qt/svg/custom/mask-on-multiple-objects-expected.txt: Added.
  • platform/qt/svg/custom/resource-invalidate-on-target-update-expected.txt: Added.
  • platform/qt/svg/filters/feColorMatrix-values-expected.txt: Added.
  • platform/qt/svg/filters/filter-clip-expected.txt: Added.
  • platform/qt/svg/zoom/page/zoom-coords-viewattr-01-b-expected.txt: Added.
  • platform/qt/svg/zoom/text/zoom-coords-viewattr-01-b-expected.txt: Added.
6:01 AM Changeset in webkit [58215] by Nikolas Zimmermann
  • 13 edits in trunk/LayoutTests

2010-04-24 Nikolas Zimmermann <​nzimmermann@rim.com>

Not reviewed. Update Qt SVG results, and a weird fast/xpath change (newline added).

  • fast/xpath/namespace-vs-predicate-expected.txt:
  • platform/qt/svg/css/circle-in-mask-with-shadow-expected.txt:
  • platform/qt/svg/css/mask-with-shadow-expected.txt:
  • platform/qt/svg/custom/gradient-userSpaceOnUse-with-percentage-expected.txt:
  • platform/qt/svg/custom/pattern-excessive-malloc-expected.txt:
  • platform/qt/svg/custom/pattern-size-bigger-than-target-size-expected.txt:
  • platform/qt/svg/custom/pattern-skew-transformed-expected.txt:
  • platform/qt/svg/custom/radial-gradient-with-outstanding-focalPoint-expected.txt:
  • platform/qt/svg/custom/use-on-symbol-inside-pattern-expected.txt:
  • platform/qt/svg/filters/feTile-expected.txt:
  • platform/qt/svg/text/selection-background-color-expected.txt:
  • platform/qt/svg/text/selection-styles-expected.txt:
5:47 AM Changeset in webkit [58214] by Nikolas Zimmermann
  • 2 edits in trunk/WebCore

2010-04-24 Nikolas Zimmermann <​nzimmermann@rim.com>

Not reviewed. Fix linkage on several bots (no idea, why it worked in a from-scratch rebuild on Leopard on my machine!) -> include NodeRenderStyle.h
Having to include NodeRenderStyle.h just to pull in the renderStyle() is a crazy concept, but I see what it tries to avoid (including RenderObject.h in Node.h)

  • rendering/SVGRenderSupport.cpp:
5:35 AM Changeset in webkit [58213] by Nikolas Zimmermann
  • 4 edits in trunk/WebCore

2010-04-24 Nikolas Zimmermann <​nzimmermann@rim.com>

Not reviewed. Fix release builds, wrap resourceMode assertion in NDEBUG blocks, use UNUSED_PARAM() otherwhise.

  • rendering/RenderSVGResourceClipper.cpp: (WebCore::RenderSVGResourceClipper::applyResource):
  • rendering/RenderSVGResourceFilter.cpp: (WebCore::RenderSVGResourceFilter::applyResource): (WebCore::RenderSVGResourceFilter::postApplyResource):
  • rendering/RenderSVGResourceMasker.cpp: (WebCore::RenderSVGResourceMasker::applyResource):
4:42 AM Changeset in webkit [58212] by Nikolas Zimmermann
  • 192 edits
    1 add
    3 deletes in trunk

2010-04-24 Nikolas Zimmermann <​nzimmermann@rim.com>

Reviewed by Dirk Schulze.

SVGPaintServer needs to be converted to the new RenderSVGResource* system
​https://bugs.webkit.org/show_bug.cgi?id=37986

Huge speedup for SVG painting using paint servers (gradient/patterns). Cache underlying
WebCore::Gradient/Pattern datastructures, do not rebuild them on every painting. This marks
the finish of the SVGResource -> RenderSVGResource transition.

Outline of same key changes:

  • RenderSVGResource is an abstract base class now, and the previous class is now named RenderSVGResourceContainer All resources except RenderSVGResourceSolidColor now inherit from RenderSVGResourceContainer, as they are all associated with a SVG*Element class. RenderSVGResourceSolidColor inherits from RenderSVGResource, and is not associated with any SVG*Element class. RenderSVGResourceSolidColor is not a render tree object, despite its name. The reason for that is consistency with all other painting resources.
  • RenderSVGResourceSolidColor does not live in the render tree, and exists only as static object, which is shared and always used when filling/stroking with solid colors - just like the old SVGPaintServerSolid.
  • RenderSVGResourceGradient/RenderSVGResourcePattern now store the underlying WebCore::Gradient/Pattern object instead of rebuilding it everytime we're asked to paint -> this is the main difference with the old concept, leading to much faster speed.
  • SVGResource has vanished. All resources (clipper/filter/marker/masker/gradient/pattern) now share the same codepaths to handle updates and client invalidation - which is a huge benefit, and makes the code easier to understand.
  • Android.mk: Remove svg/graphics/SVGResource*, svg/graphics/SVGPaintServer.h from build.
  • GNUmakefile.am: Ditto.
  • WebCore.gypi: Ditto.
  • WebCore.pro: Ditto.
  • WebCore.vcproj/WebCore.vcproj: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • platform/graphics/Gradient.cpp: Add addColorStop() method taking a ColorStop const-reference. (WebCore::Gradient::addColorStop):
  • platform/graphics/Gradient.h: Ditto.
  • platform/graphics/TextRun.h: Rename SVGPaintServer to RenderSVGResource (WebCore::TextRun::TextRun): (WebCore::TextRun::activePaintingResource): Renamed from activePaintServer. (WebCore::TextRun::setActivePaintingResource): Renamed from setActivePaintServer.
  • platform/graphics/win/GraphicsContextWin.cpp: Remove references to SVGResourceImage, which was removed a long time ago.
  • rendering/RenderObject.cpp: (WebCore::RenderObject::toRenderSVGResourceContainer): Renamed from toRenderSVGResource().
  • rendering/RenderObject.h: (WebCore::RenderObject::isSVGGradientStop): Added. (WebCore::RenderObject::isSVGResourceContainer): Renamed from isSVGResource().
  • rendering/RenderPath.cpp: Utilize RenderSVGResource::fill/strokePaintingResource to request paint servers, instead of SVGPaintServer. (WebCore::RenderPath::fillContains): Adapt to new concept. (WebCore::RenderPath::strokeContains): Ditto. (WebCore::fillAndStrokePath): Ditto. (WebCore::RenderPath::paint): Ditto.
  • rendering/RenderSVGGradientStop.cpp: (WebCore::RenderSVGGradientStop::styleDidChange): Ditto.
  • rendering/RenderSVGGradientStop.h: Fixed indention.
  • rendering/RenderSVGResource.cpp: Refactored old SVGPaintServer code to request fill/stroke painting resources, splitted up in several methods to aid readability. (WebCore::registerPendingResource): (WebCore::adjustColorForPseudoRules): (WebCore::RenderSVGResource::fillPaintingResource): (WebCore::RenderSVGResource::strokePaintingResource): (WebCore::RenderSVGResource::sharedSolidPaintingResource): (WebCore::RenderSVGResource::markForLayoutAndResourceInvalidation):
  • rendering/RenderSVGResource.h: Make RenderSVGResource an abstract base class, see above for the reasoning. (WebCore::RenderSVGResource::RenderSVGResource): (WebCore::RenderSVGResource::~RenderSVGResource): (WebCore::RenderSVGResource::postApplyResource):
  • rendering/RenderSVGResourceClipper.cpp: Inherit from RenderSVGResourceContainer instead of RenderSVGResource. (WebCore::RenderSVGResourceClipper::RenderSVGResourceClipper): (WebCore::RenderSVGResourceClipper::invalidateClient): (WebCore::RenderSVGResourceClipper::applyResource): Adapt to signature changes (add RenderStyle* and resource mode parameters) (WebCore::RenderSVGResourceClipper::applyClippingToContext):
  • rendering/RenderSVGResourceClipper.h:
  • rendering/RenderSVGResourceContainer.h: Added. Renamed from RenderSVGResource. Now inherits from RenderSVGHiddenContainer and RenderSVGResource. (WebCore::RenderSVGResourceContainer::RenderSVGResourceContainer): (WebCore::RenderSVGResourceContainer::~RenderSVGResourceContainer): (WebCore::RenderSVGResourceContainer::idChanged): (WebCore::RenderSVGResourceContainer::isSVGResourceContainer): (WebCore::RenderSVGResourceContainer::drawsContents): (WebCore::RenderSVGResourceContainer::toRenderSVGResourceContainer): (WebCore::getRenderSVGResourceContainerById): (WebCore::getRenderSVGResourceById):
  • rendering/RenderSVGResourceFilter.cpp: Inherit from RenderSVGResourceContainer instead of RenderSVGResource. (WebCore::RenderSVGResourceFilter::RenderSVGResourceFilter): (WebCore::RenderSVGResourceFilter::invalidateClient): (WebCore::RenderSVGResourceFilter::applyResource): Adapt to signature changes (add RenderStyle* and resource mode parameters) (WebCore::RenderSVGResourceFilter::postApplyResource):
  • rendering/RenderSVGResourceFilter.h:
  • rendering/RenderSVGResourceGradient.cpp: Moved from SVGPaintServerGradient, cleaned up and refactored. (WebCore::RenderSVGResourceGradient::RenderSVGResourceGradient): (WebCore::RenderSVGResourceGradient::~RenderSVGResourceGradient): (WebCore::RenderSVGResourceGradient::invalidateClients): (WebCore::RenderSVGResourceGradient::invalidateClient): (WebCore::createMaskAndSwapContextForTextGradient): (WebCore::clipToTextMask): (WebCore::RenderSVGResourceGradient::applyResource):
  • rendering/RenderSVGResourceGradient.h: (WebCore::RenderSVGResourceGradient::resourceBoundingBox):
  • rendering/RenderSVGResourceLinearGradient.cpp: Moved from SVGPaintServerLinearGradient, cleaned up and refactored. (WebCore::RenderSVGResourceLinearGradient::RenderSVGResourceLinearGradient): (WebCore::RenderSVGResourceLinearGradient::~RenderSVGResourceLinearGradient): (WebCore::RenderSVGResourceLinearGradient::buildGradient):
  • rendering/RenderSVGResourceLinearGradient.h: (WebCore::RenderSVGResourceLinearGradient::renderName): (WebCore::RenderSVGResourceLinearGradient::resourceType):
  • rendering/RenderSVGResourceMarker.cpp: Inherit from RenderSVGResourceContainer instead of RenderSVGResource. (WebCore::RenderSVGResourceMarker::RenderSVGResourceMarker): (WebCore::RenderSVGResourceMarker::invalidateClient):
  • rendering/RenderSVGResourceMarker.h: (WebCore::RenderSVGResourceMarker::applyResource):
  • rendering/RenderSVGResourceMasker.cpp: Inherit from RenderSVGResourceContainer instead of RenderSVGResource. (WebCore::RenderSVGResourceMasker::RenderSVGResourceMasker): (WebCore::RenderSVGResourceMasker::invalidateClient): (WebCore::RenderSVGResourceMasker::applyResource):
  • rendering/RenderSVGResourceMasker.h: (WebCore::MaskerData::MaskerData):
  • rendering/RenderSVGResourcePattern.cpp: Moved from SVGPaintServerPattern, cleaned up and refactored. (WebCore::RenderSVGResourcePattern::RenderSVGResourcePattern): (WebCore::RenderSVGResourcePattern::~RenderSVGResourcePattern): (WebCore::RenderSVGResourcePattern::invalidateClients): (WebCore::RenderSVGResourcePattern::invalidateClient): (WebCore::RenderSVGResourcePattern::applyResource): (WebCore::RenderSVGResourcePattern::postApplyResource): (WebCore::calculatePatternBoundaries): (WebCore::RenderSVGResourcePattern::calculatePatternBoundariesIncludingOverflow): (WebCore::RenderSVGResourcePattern::createTileImage): (WebCore::RenderSVGResourcePattern::buildPattern):
  • rendering/RenderSVGResourcePattern.h: (WebCore::RenderSVGResourcePattern::renderName): (WebCore::RenderSVGResourcePattern::resourceBoundingBox): (WebCore::RenderSVGResourcePattern::resourceType):
  • rendering/RenderSVGResourceRadialGradient.cpp: Moved from SVGPaintServerRadialGradient, cleaned up and refactored. (WebCore::RenderSVGResourceRadialGradient::RenderSVGResourceRadialGradient): (WebCore::RenderSVGResourceRadialGradient::~RenderSVGResourceRadialGradient): (WebCore::RenderSVGResourceRadialGradient::buildGradient):
  • rendering/RenderSVGResourceRadialGradient.h: (WebCore::RenderSVGResourceRadialGradient::renderName): (WebCore::RenderSVGResourceRadialGradient::resourceType):
  • rendering/RenderSVGResourceSolidColor.cpp: Moved from SVGPaintServerSolid, cleaned up and refactored. (WebCore::RenderSVGResourceSolidColor::RenderSVGResourceSolidColor): (WebCore::RenderSVGResourceSolidColor::~RenderSVGResourceSolidColor): (WebCore::RenderSVGResourceSolidColor::applyResource): (WebCore::RenderSVGResourceSolidColor::postApplyResource):
  • rendering/RenderSVGResourceSolidColor.h: (WebCore::RenderSVGResourceSolidColor::invalidateClients): (WebCore::RenderSVGResourceSolidColor::invalidateClient): (WebCore::RenderSVGResourceSolidColor::resourceBoundingBox): (WebCore::RenderSVGResourceSolidColor::resourceType): (WebCore::RenderSVGResourceSolidColor::color): (WebCore::RenderSVGResourceSolidColor::setColor):
  • rendering/RenderSVGText.cpp: (WebCore::RenderSVGText::paint): Early exit if painting is disabled.
  • rendering/RenderTreeAsText.cpp: (WebCore::write): Add RenderSVGGradientStop dumping. (WebCore::externalRepresentation): Remove SVGResource dumping.
  • rendering/SVGInlineTextBox.cpp: Adapt to SVGPaintServer changes (paint server request). (WebCore::SVGInlineTextBox::paintCharacters): (WebCore::SVGInlineTextBox::paintDecoration):
  • rendering/SVGInlineTextBox.h: Ditto. (WebCore::SVGTextPaintInfo::SVGTextPaintInfo):
  • rendering/SVGRenderSupport.cpp: Ditto. (WebCore::SVGRenderBase::prepareToRenderSVGContent): (WebCore::SVGRenderBase::finishRenderSVGContent): (WebCore::invalidatePaintingResource): (WebCore::deregisterFromResources): (WebCore::dashArrayFromRenderingStyle): Moved here from SVGPaintServer. (WebCore::applyStrokeStyleToContext): Ditto.
  • rendering/SVGRenderSupport.h:
  • rendering/SVGRenderTreeAsText.cpp: Add new gradient/pattern dumping code. Stops are now properly dumped as well! (WebCore::operator<<): (WebCore::writeSVGPaintingResource): (WebCore::writeStyle): (WebCore::boundingBoxModeString): (WebCore::writeCommonGradientProperties): (WebCore::writeSVGResourceContainer): (WebCore::writeSVGGradientStop):
  • rendering/SVGRenderTreeAsText.h:
  • rendering/SVGRootInlineBox.cpp: Adapt to SVGPaintServer changes (paint server request). (WebCore::SVGRootInlineBoxPaintWalker::SVGRootInlineBoxPaintWalker): (WebCore::SVGRootInlineBoxPaintWalker::~SVGRootInlineBoxPaintWalker): (WebCore::SVGRootInlineBoxPaintWalker::teardownFillPaintServer): (WebCore::SVGRootInlineBoxPaintWalker::teardownStrokePaintServer): (WebCore::SVGRootInlineBoxPaintWalker::setupBackground): (WebCore::SVGRootInlineBoxPaintWalker::setupFill): (WebCore::SVGRootInlineBoxPaintWalker::setupFillSelection): (WebCore::SVGRootInlineBoxPaintWalker::setupStroke): (WebCore::SVGRootInlineBoxPaintWalker::setupStrokeSelection): (WebCore::SVGRootInlineBoxPaintWalker::setupForeground): (WebCore::SVGRootInlineBoxPaintWalker::activePaintingResource): (WebCore::SVGRootInlineBoxPaintWalker::paintChunk):
  • svg/GradientAttributes.h: Remove SVGGradientStop, use Gradient::ColorStop vector. Cleanup. (WebCore::GradientAttributes::stops): (WebCore::GradientAttributes::setStops):
  • svg/LinearGradientAttributes.h: Move ENABLE(SVG) guard to correct location.
  • svg/PatternAttributes.h: Add missing includes and class forwards.
  • svg/RadialGradientAttributes.h: Move ENABLE(SVG) guard to correct location.
  • svg/SVGClipPathElement.cpp: Rename invalidateCanvasResources() to invalidateResourceClients(). (WebCore::SVGClipPathElement::svgAttributeChanged): (WebCore::SVGClipPathElement::childrenChanged): Only call invalidateResourceClients() when !changedByParser is set.
  • svg/SVGClipPathElement.h:
  • svg/SVGDocumentExtensions.cpp: Change HashMaps to hash AtomicStrings instead of Strings. Rename RenderSVGResource to RenderSVGResourceContainer. (WebCore::SVGDocumentExtensions::addResource): (WebCore::SVGDocumentExtensions::removeResource): (WebCore::SVGDocumentExtensions::resourceById): (WebCore::SVGDocumentExtensions::addPendingResource):
  • svg/SVGDocumentExtensions.h:
  • svg/SVGElement.cpp: (WebCore::SVGElement::insertedIntoDocument): Remove reference to SVGResource::invalidateClients(), handled differently now. (WebCore::SVGElement::updateAnimatedSVGAttribute): Change assertion, that is incorrect now.
  • svg/SVGElement.h: Make updateAnimatedSVGAttribute() public.
  • svg/SVGFont.cpp: Adapt to SVGPaintServer changes (paint server request). (WebCore::Font::drawTextUsingSVGFont):
  • svg/SVGGElement.cpp: If style()->display() is NONE, create a RenderSVGHiddenContainer, removing hacks in SVGStopElement for pservers-grad-19-b.svg (yes, SVG is crazy.) (WebCore::SVGGElement::createRenderer):
  • svg/SVGGElement.h: Remove childrenChanged() method which _always_ called renderer->setNeedsLayout(true), which is completly wrong and unnecessary. (WebCore::SVGGElement::rendererIsNeeded): Always return true.
  • svg/SVGGradientElement.cpp: Adapt to new RenderSVGResourceGradient code. (WebCore::SVGGradientElement::svgAttributeChanged): (WebCore::SVGGradientElement::childrenChanged): Only call invalidateResourceClients() when !changedByParser is set. (WebCore::SVGGradientElement::buildStops):
  • svg/SVGGradientElement.h:
  • svg/SVGLinearGradientElement.cpp: Adapt to new RenderSVGResourceLinearGradient code. (WebCore::SVGLinearGradientElement::svgAttributeChanged): (WebCore::SVGLinearGradientElement::createRenderer): (WebCore::SVGLinearGradientElement::collectGradientProperties): (WebCore::SVGLinearGradientElement::calculateStartEndPoints):
  • svg/SVGLinearGradientElement.h:
  • svg/SVGMarkerElement.cpp: Rename invalidateCanvasResources() to invalidateResourceClients(). (WebCore::SVGMarkerElement::svgAttributeChanged): (WebCore::SVGMarkerElement::childrenChanged): Only call invalidateResourceClients() when !changedByParser is set. (WebCore::SVGMarkerElement::setOrientToAuto): (WebCore::SVGMarkerElement::setOrientToAngle):
  • svg/SVGMaskElement.cpp: Rename invalidateCanvasResources() to invalidateResourceClients(). (WebCore::SVGMaskElement::svgAttributeChanged): (WebCore::SVGMaskElement::childrenChanged): Only call invalidateResourceClients() when !changedByParser is set.
  • svg/SVGPatternElement.cpp: Rename invalidateCanvasResources() to invalidateResourceClients(). (WebCore::SVGPatternElement::svgAttributeChanged): (WebCore::SVGPatternElement::childrenChanged): Only call invalidateResourceClients() when !changedByParser is set. (WebCore::SVGPatternElement::createRenderer):
  • svg/SVGPatternElement.h:
  • svg/SVGPolyElement.h: Remove unneded rendererIsNeeded() override.
  • svg/SVGRadialGradientElement.cpp: Adapt to new RenderSVGResourceRadialGradient code. (WebCore::SVGRadialGradientElement::svgAttributeChanged): (WebCore::SVGRadialGradientElement::createRenderer): (WebCore::SVGRadialGradientElement::collectGradientProperties): (WebCore::SVGRadialGradientElement::calculateFocalCenterPointsAndRadius):
  • svg/SVGRadialGradientElement.h:
  • svg/SVGStopElement.cpp: Clean up code, moved stop color calculation from SVGGradientElement to here, where it belongs. (WebCore::SVGStopElement::parseMappedAttribute): (WebCore::SVGStopElement::stopColorIncludingOpacity):
  • svg/SVGStopElement.h:
  • svg/SVGStyledElement.cpp: (WebCore::SVGStyledElement::~SVGStyledElement): (WebCore::SVGStyledElement::svgAttributeChanged): Only invalidateResourcesInAncestorChain()/deregisterFromResources() when we're not parsing. (WebCore::SVGStyledElement::invalidateResourcesInAncestorChain): Early exit if we find a parent resources, there is no resource nesting. (WebCore::SVGStyledElement::invalidateResourceClients): Renamed from invalidateCanvasResources() (WebCore::SVGStyledElement::childrenChanged): Only invalidate SVGElementInstances when !changedByParser is set.
  • svg/SVGStyledElement.h: Remove canvasResource() logic, remove detach() method.
  • svg/SVGTextPathElement.h:
  • svg/graphics/SVGPaintServer.h: Removed.
  • svg/graphics/SVGResource.cpp: Removed.
  • svg/graphics/SVGResource.h: Removed.

2010-04-24 Nikolas Zimmermann <​nzimmermann@rim.com>

Reviewed by Dirk Schulze.

SVGPaintServer needs to be converted to the new RenderSVGResource* system
​https://bugs.webkit.org/show_bug.cgi?id=37986

Rebaseline SVG tests, after the RenderSVGResource transition.

NOTE: This WILL affect _any_ platform with custom svg results for tests using gradients/patterns.

That means I have to wait for the bot results, and update them ASAP. Therefore landing out
of california business hours and on the weekend - please stay tuned I'll fix any breakages soon.
(Except for chromium whose test results are not available on build.webkit.org, sorry.)

  • platform/mac/svg/W3C-SVG-1.1/animate-elem-31-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-78-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/color-prop-01-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/coords-units-01-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/filters-color-01-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/filters-comptran-01-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/masking-mask-01-b-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/masking-mask-01-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/masking-mask-01-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/painting-render-01-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/pservers-grad-01-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/pservers-grad-02-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/pservers-grad-03-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/pservers-grad-04-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/pservers-grad-05-b-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/pservers-grad-05-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/pservers-grad-05-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/pservers-grad-06-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/pservers-grad-07-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/pservers-grad-08-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/pservers-grad-09-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/pservers-grad-10-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/pservers-grad-11-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/pservers-grad-12-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/pservers-grad-13-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/pservers-grad-14-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/pservers-grad-15-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/pservers-grad-16-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/pservers-grad-17-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/pservers-grad-18-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/pservers-grad-19-b-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/pservers-grad-19-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/pservers-grad-19-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/pservers-pattern-01-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/struct-group-03-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/struct-use-05-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/styling-inherit-01-b-expected.txt:
  • platform/mac/svg/batik/filters/feTile-expected.txt:
  • platform/mac/svg/batik/masking/maskRegions-expected.txt:
  • platform/mac/svg/batik/paints/gradientLimit-expected.txt:
  • platform/mac/svg/batik/paints/patternPreserveAspectRatioA-expected.txt:
  • platform/mac/svg/batik/paints/patternRegionA-expected.txt:
  • platform/mac/svg/batik/paints/patternRegions-expected.txt:
  • platform/mac/svg/batik/text/textEffect-expected.txt:
  • platform/mac/svg/batik/text/textEffect2-expected.txt:
  • platform/mac/svg/batik/text/textEffect3-expected.txt:
  • platform/mac/svg/batik/text/textProperties-expected.txt:
  • platform/mac/svg/carto.net/colourpicker-expected.txt:
  • platform/mac/svg/carto.net/tabgroup-expected.txt:
  • platform/mac/svg/css/circle-in-mask-with-shadow-expected.txt:
  • platform/mac/svg/css/mask-with-shadow-expected.txt:
  • platform/mac/svg/custom/broken-internal-references-expected.txt:
  • platform/mac/svg/custom/deep-dynamic-updates-expected.txt:
  • platform/mac/svg/custom/dominant-baseline-hanging-expected.checksum:
  • platform/mac/svg/custom/dominant-baseline-hanging-expected.png:
  • platform/mac/svg/custom/dominant-baseline-hanging-expected.txt:
  • platform/mac/svg/custom/feComponentTransfer-Discrete-expected.txt:
  • platform/mac/svg/custom/feComponentTransfer-Gamma-expected.txt:
  • platform/mac/svg/custom/feComponentTransfer-Linear-expected.txt:
  • platform/mac/svg/custom/feComponentTransfer-Table-expected.txt:
  • platform/mac/svg/custom/fill-fallback-expected.txt:
  • platform/mac/svg/custom/gradient-add-stops-expected.txt:
  • platform/mac/svg/custom/gradient-attr-update-expected.txt:
  • platform/mac/svg/custom/gradient-cycle-detection-expected.txt:
  • platform/mac/svg/custom/gradient-deep-referencing-expected.txt:
  • platform/mac/svg/custom/gradient-rotated-bbox-expected.txt:
  • platform/mac/svg/custom/gradient-stop-corner-cases-expected.txt:
  • platform/mac/svg/custom/gradient-stop-style-change-expected.txt:
  • platform/mac/svg/custom/gradient-stroke-width-expected.checksum:
  • platform/mac/svg/custom/gradient-stroke-width-expected.png:
  • platform/mac/svg/custom/gradient-stroke-width-expected.txt:
  • platform/mac/svg/custom/gradient-userSpaceOnUse-with-percentage-expected.txt:
  • platform/mac/svg/custom/grayscale-gradient-mask-expected.txt:
  • platform/mac/svg/custom/group-opacity-expected.txt:
  • platform/mac/svg/custom/inline-svg-in-xhtml-expected.txt:
  • platform/mac/svg/custom/invalid-css-expected.txt:
  • platform/mac/svg/custom/js-late-gradient-and-object-creation-expected.txt:
  • platform/mac/svg/custom/js-late-gradient-creation-expected.txt:
  • platform/mac/svg/custom/js-late-pattern-and-object-creation-expected.txt:
  • platform/mac/svg/custom/js-late-pattern-creation-expected.txt:
  • platform/mac/svg/custom/js-update-gradient-expected.checksum:
  • platform/mac/svg/custom/js-update-gradient-expected.png:
  • platform/mac/svg/custom/js-update-gradient-expected.txt:
  • platform/mac/svg/custom/js-update-pattern-child-expected.txt:
  • platform/mac/svg/custom/js-update-pattern-expected.txt:
  • platform/mac/svg/custom/js-update-stop-expected.txt:
  • platform/mac/svg/custom/large-bounding-box-percents-expected.txt:
  • platform/mac/svg/custom/pattern-cycle-detection-expected.txt:
  • platform/mac/svg/custom/pattern-deep-referencing-expected.txt:
  • platform/mac/svg/custom/pattern-excessive-malloc-expected.txt:
  • platform/mac/svg/custom/pattern-in-defs-expected.txt:
  • platform/mac/svg/custom/pattern-rotate-expected.txt:
  • platform/mac/svg/custom/pattern-size-bigger-than-target-size-expected.txt:
  • platform/mac/svg/custom/pattern-skew-transformed-expected.txt:
  • platform/mac/svg/custom/pattern-with-transformation-expected.txt:
  • platform/mac/svg/custom/pattern-y-offset-expected.txt:
  • platform/mac/svg/custom/resource-client-removal-expected.txt:
  • platform/mac/svg/custom/stroke-fallback-expected.txt:
  • platform/mac/svg/custom/stroked-pattern-expected.txt:
  • platform/mac/svg/custom/text-gradient-no-content-expected.txt:
  • platform/mac/svg/custom/use-on-symbol-inside-pattern-expected.txt:
  • platform/mac/svg/custom/use-recalcStyle-crash-expected.txt:
  • platform/mac/svg/filters/big-sized-filter-expected.txt:
  • platform/mac/svg/filters/feDisplacementMap-expected.txt:
  • platform/mac/svg/filters/feTile-expected.txt:
  • platform/mac/svg/filters/filterRes-expected.txt:
  • platform/mac/svg/hixie/error/003-expected.txt:
  • platform/mac/svg/hixie/perf/005-expected.txt:
  • platform/mac/svg/hixie/perf/006-expected.txt:
  • platform/mac/svg/text/selection-background-color-expected.txt:
  • platform/mac/svg/text/selection-styles-expected.txt:
  • platform/mac/svg/text/text-gradient-positioning-expected.txt:
  • platform/mac/svg/transforms/text-with-pattern-inside-transformed-html-expected.txt:
  • platform/mac/svg/transforms/text-with-pattern-with-svg-transform-expected.txt:
  • platform/win/svg/custom/broken-internal-references-expected.txt:
  • svg/custom/gradient-with-1d-boundingbox-expected.txt:
  • svg/custom/radial-gradient-with-outstanding-focalPoint-expected.txt:
3:29 AM Changeset in webkit [58211] by Nikolas Zimmermann
  • 1 edit
    1 add in trunk/LayoutTests

2010-04-24 Nikolas Zimmermann <​nzimmermann@rim.com>

Not reviewed. Add win specific result for svg/custom/broken-internal-references.svg
It's a bad idea that textPath dumps FLT_MAX when it's not shown - that should be fixed, but it's not related to Moritas testcase.

  • platform/win/svg/custom/broken-internal-references-expected.txt: Added.
12:03 AM Changeset in webkit [58210] by eric@webkit.org
  • 9 edits
    1 copy in trunk/WebKitTools

2010-04-23 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

check-webkit-style complains about non-utf8 data in layout test result
​https://bugs.webkit.org/show_bug.cgi?id=38027

The problem was we were assuming patch files/diff output as utf-8.
Turns out they're not. We have to treat them as binary data because
a single patch may have multiple text files in it with conflicting encodings!

  • Scripts/webkitpy/common/checkout/api.py:
    • contents_at_revision returns a byte array, so decode it to unicode before passing it to parse_latest_entry_from_file
  • Scripts/webkitpy/common/checkout/api_unittest.py:
    • Update our mock mock_contents_at_revision to match the encoding semantics of the real one.
  • Scripts/webkitpy/common/checkout/scm.py:
    • Be careful not to decode output which may contain file contents (like diff, cat or show) as the encoding for that content is unknown.
  • Scripts/webkitpy/common/checkout/scm_unittest.py:
    • Update our tests to use both latin1 and utf-8 encoded data.
  • Scripts/webkitpy/common/net/bugzilla.py:
    • _fill_attachment_form should not assume unicode data. Callers may wish to attach other types of files to bugs.
  • Scripts/webkitpy/common/prettypatch.py:
    • Diffs are byte arrays, deal with them as such.
  • Scripts/webkitpy/common/prettypatch_unittest.py:
    • Test to make sure we handle diffs with multiple conflicting encodings.
  • Scripts/webkitpy/common/system/executive_unittest.py:
    • Make sure that our unicode support does not break our byte array input support for run_command.
Note: See TracTimeline for information about the timeline view.