⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Apr 27, 2010:

11:45 PM Changeset in webkit [58384] by yuzo@google.com
  • 7 edits in trunk

2010-04-27 Yuzo Fujishima <​yuzo@google.com>

Reviewed by Dimitri Glazkov.

Enhance CSS parser for Paged Media (Iteration 3)
Implement size parameter parsing for Paged Media.
​https://bugs.webkit.org/show_bug.cgi?id=35851

  • printing/page-rule-css-text-expected.txt:
  • printing/page-rule-css-text.html:

2010-04-27 Yuzo Fujishima <​yuzo@google.com>

Reviewed by Dimitri Glazkov.

Enhance CSS parser for Paged Media (Iteration 3)
Implement size parameter parsing for Paged Media.
​https://bugs.webkit.org/show_bug.cgi?id=35851

I believe size property hasn't been used so far because (1) it hasn't been properly parsed and
(2) a comment in CSSComputedStyleDeclaration::getPropertyCSSValue says so.
Changing the way of parsing it should not cause any regressions -- no existing tests fail because of this change.

  • css/CSSParser.cpp: (WebCore::CSSParser::parseValue): (WebCore::CSSParser::parseSize): (WebCore::CSSParser::parseSizeParameter):
  • css/CSSParser.h: (WebCore::CSSParser::):
  • css/CSSValueKeywords.in:
11:19 PM Changeset in webkit [58383] by yuzo@google.com
  • 11 edits
    2 adds in trunk

2010-04-27 Yuzo Fujishima <​yuzo@google.com>

Reviewed by Eric Seidel.

Enhance CSS parser for Paged Media (Iteration 2)
Parse and hold paged media rules in CSSStyleSelector.

fast/dom/script-tests/prototype-inheritance-2.js is rebaselined because it assumes @page is ignored.

​https://bugs.webkit.org/show_bug.cgi?id=35782

  • fast/dom/prototype-inheritance-2-expected.txt:
  • fast/dom/script-tests/prototype-inheritance-2.js:
  • printing/page-rule-css-text-expected.txt: Added.
  • printing/page-rule-css-text.html: Added.

2010-04-27 Yuzo Fujishima <​yuzo@google.com>

Reviewed by Eric Seidel.

Enhance CSS parser for Paged Media (Iteration 2)
Parse and hold paged media rules in CSSStyleSelector.

​https://bugs.webkit.org/show_bug.cgi?id=35782

Test: printing/page-rule-css-text.html

  • css/CSSGrammar.y:
  • css/CSSPageRule.cpp: (WebCore::CSSPageRule::CSSPageRule): (WebCore::CSSPageRule::selectorText):
  • css/CSSPageRule.h: (WebCore::CSSPageRule::create): (WebCore::CSSPageRule::isPageRule):
  • css/CSSParser.cpp: (WebCore::CSSParser::createPageRule):
  • css/CSSStyleRule.h:
  • css/CSSStyleSelector.cpp: (WebCore::CSSRuleSet::getPageRules): (WebCore::CSSRuleSet::CSSRuleSet): (WebCore::CSSRuleSet::~CSSRuleSet): (WebCore::CSSRuleSet::addPageRule): (WebCore::CSSRuleSet::addRulesFromSheet):
  • css/CSSStyleSelector.h:
  • css/StyleBase.h: (WebCore::StyleBase::isPageRule):
11:00 PM Changeset in webkit [58382] by eric@webkit.org
  • 2 edits in trunk/WebKit/chromium

2010-04-27 Jens Alfke <​snej@chromium.org>

Reviewed by Eric Seidel.

[chromium] Fix bug that prevents autosave of forms without action attribute
​https://bugs.webkit.org/show_bug.cgi?id=38014
Change is in the Chromium WebKit API so it can't be tested with a JS-based layout test.
It needs a native unit test, which would go in the Chromium repo, not WebKit.

  • src/WebPasswordFormData.cpp: (WebKit::WebPasswordFormData::WebPasswordFormData): Set correct URL if action is NULL
10:42 PM Changeset in webkit [58381] by dbates@webkit.org
  • 7 edits
    6 adds in trunk

2010-04-27 Daniel Bates <​dbates@rim.com>

Reviewed by Oliver Hunt.

​https://bugs.webkit.org/show_bug.cgi?id=37686

Fixes an issue where the canvas method strokeRect will stroke a
rectangle whose dimensions are 0 when lineWidth > 1.

As per the definition of strokeRect in the HTML Canvas 2D Context
spec. <​http://www.w3.org/TR/2dcontext/#dom-context-2d-strokerect>,
this method should have no effect when both the height and width
are zero.

Tests: fast/canvas/canvas-clearRect.html

fast/canvas/canvas-fillRect.html

  • html/canvas/CanvasRenderingContext2D.cpp: (WebCore::validateRectForCanvas): Return false if height, width == 0.

2010-04-27 Daniel Bates <​dbates@rim.com>

Reviewed by Oliver Hunt.

​https://bugs.webkit.org/show_bug.cgi?id=37686

Tests that strokeRect does not paint any artifacts when the
specified rectangle has height, width = 0 and lineWidth > 1.

Also tests that clearRect, fillRect, and rect are ignored when
height, width = 0.

  • fast/canvas/canvas-clearRect-expected.txt: Added.
  • fast/canvas/canvas-clearRect.html: Added.
  • fast/canvas/canvas-fillRect-expected.txt: Added.
  • fast/canvas/canvas-fillRect.html: Added.
  • fast/canvas/canvas-modify-emptyPath-expected.txt:
  • fast/canvas/canvas-strokeRect-expected.txt: Updated results.
  • fast/canvas/script-tests/canvas-clearRect.js: Added.
  • fast/canvas/script-tests/canvas-fillRect.js: Added.
  • fast/canvas/script-tests/canvas-modify-emptyPath.js: Added test case.
  • fast/canvas/script-tests/canvas-strokeRect.js: Ditto. Also, added debug statements so as to distinguish the results for each test.
10:40 PM Changeset in webkit [58380] by eric@webkit.org
  • 8 edits in trunk

2010-04-27 Michael Nordman <Michael Nordman>

Reviewed by Dmitry Titov.

[Chromium] Add two things to the webkit API to support appcaches in workers.
1) WebURLRequest TargetTypes for worker and shared worker main resources.
2) Factory method on class WebCommonWorkerClient to

createApplicationCacheHost() for the associated worker.

​https://bugs.webkit.org/show_bug.cgi?id=38147

  • public/WebCommonWorkerClient.h: add the factory method
  • public/WebURLRequest.h: add the TargetTypes
  • src/WebWorkerBase.cpp: call the embedder's factory when needed (WebKit::WebWorkerBase::didCreateDataSource) (WebKit::WebWorkerBase::createApplicationCacheHost)
  • src/WebWorkerBase.h: ditto
  • src/WebWorkerClientImpl.h: add a stub impl of the factory method (WebKit::WebWorkerClientImpl::createApplicationCacheHost):

2010-04-27 Michael Nordman <Michael Nordman>

Reviewed by Dmitry Titov.

[Chromium] Add two things to the webkit API to support appcaches in workers.
1) WebURLRequest TargetTypes for worker and shared worker main resources.
2) Factory method on class WebCommonWorkerClient to

createApplicationCacheHost() for the associated worker.

​https://bugs.webkit.org/show_bug.cgi?id=38147

  • DumpRenderTree/chromium/TestWebWorker.h add a stub impl of the factory method (TestWebWorker::createApplicationCacheHost):
10:31 PM Changeset in webkit [58379] by eric@webkit.org
  • 8 edits
    3 deletes in trunk/WebCore

2010-04-27 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Remove obsolete custom bindings file
​https://bugs.webkit.org/show_bug.cgi?id=38223

We don't need these files anymore because they are empty.

  • Android.jscbindings.mk:
  • GNUmakefile.am:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSAbstractWorkerCustom.cpp: Removed.
  • bindings/js/JSBindingsAllInOne.cpp:
  • bindings/js/JSDocumentFragmentCustom.cpp: Removed.
  • bindings/js/JSEventSourceCustom.cpp: Removed.
10:21 PM Changeset in webkit [58378] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-04-27 Daniel Cheng <​dcheng@chromium.org>

Reviewed by Jian Li.

[Chromium] Filter out URLs with a file scheme from text/uri-list when dragging.
​https://bugs.webkit.org/show_bug.cgi?id=38227

Unfortunately, the simple fix of not populating the drag data with file URLs doesn't work
since the default drop handling uses the drag data URL to navigate to dropped files/URLs.
For now, we hack around the problem in the Chromium platform, but the proper long term
solution is to change DragController::performDrag to check dragData::asFilenames().

No new tests.

  • platform/chromium/ClipboardChromium.cpp: (WebCore::ClipboardChromium::getData): (WebCore::ClipboardChromium::types):
9:53 PM Changeset in webkit [58377] by tkent@chromium.org
  • 2 edits in trunk/WebKit/chromium

2010-04-27 Kent Tamura <​tkent@chromium.org>

Reviewed by Shinichiro Hamaji.

[DRT/Chromium] Enable Windows project generation
​https://bugs.webkit.org/show_bug.cgi?id=38103

  • Avoid platform.system(), which causes a crash with python.exe in depot_tools. Use sys.platform instead.
  • Process DumpRenderTree.gyp on all platforms.
  • gyp_webkit:
9:49 PM Changeset in webkit [58376] by eric@webkit.org
  • 3 edits in trunk/WebKitTools

2010-04-27 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

run-bindings-tests doesn't work in an SVN checkout
​https://bugs.webkit.org/show_bug.cgi?id=38225

Previously detect_scm_system needed an absolute path for SVN. Now we
accept a relative path.

  • Scripts/webkitpy/common/checkout/scm.py:
  • Scripts/webkitpy/common/checkout/scm_unittest.py:
9:20 PM Changeset in webkit [58375] by Simon Fraser
  • 3 edits
    5 adds in trunk

2010-04-27 Simon Fraser <Simon Fraser>

Reviewed by the inimitable Dan Bernstein.

SVG as background image renders incorrectly after zooming
​https://bugs.webkit.org/show_bug.cgi?id=38215

When doing a partial redraw of an SVGImage used as a CSS background
image, we're limited to drawing the entire Frame, clipped to the dirty rect.
Because of this, we need to fix up the CTM so that the origin is at the
top left of the unclipped image, rather than the top left of the
portion being redrawn.

Test: fast/images/svg-background-partial-redraw.html

  • svg/graphics/SVGImage.cpp: (WebCore::SVGImage::draw):
8:42 PM Changeset in webkit [58374] by yuzo@google.com
  • 8 edits
    2 adds in trunk

2010-04-27 Yuzo Fujishima <​yuzo@google.com>

Reviewed by David Hyatt.

Retry of: Enhance CSS parser for Paged Media (Iteration 1)

In this change, the grammar is extended and skeletal methods for creating page rules and margin at-rules are defined.
The contents of the methods should be implemented by other changes.

​https://bugs.webkit.org/show_bug.cgi?id=35329

  • fast/css/parsing-page-rule-expected.txt: Copied from LayoutTests/editing/selection/5136696-expected.txt.
  • fast/css/parsing-page-rule.html: Added.

2010-04-27 Yuzo Fujishima <​yuzo@google.com>

Reviewed by David Hyatt.

Retry of: Enhance CSS parser for Paged Media (Iteration 1)

In this change, the grammar is extended and skeletal methods for creating page rules and margin at-rules are defined.
The contents of the methods should be implemented by other changes.

​https://bugs.webkit.org/show_bug.cgi?id=35329

Test: fast/css/parsing-page-rule.html

  • css/CSSGrammar.y:
  • css/CSSParser.cpp: (WebCore::CSSParser::CSSParser): (WebCore::CSSParser::clearProperties): (WebCore::CSSParser::createPageRule): (WebCore::CSSParser::createMarginAtRule): (WebCore::CSSParser::startDeclarationsForMarginBox): (WebCore::CSSParser::endDeclarationsForMarginBox):
  • css/CSSParser.h:
  • css/CSSSelector.cpp: (WebCore::CSSSelector::pseudoId): (WebCore::nameToPseudoTypeMap): (WebCore::CSSSelector::extractPseudoType):
  • css/CSSSelector.h: (WebCore::CSSSelector::):
  • css/tokenizer.flex:
8:37 PM Changeset in webkit [58373] by jchaffraix@webkit.org
  • 4 edits
    5 deletes in trunk

Unreviewed, rolling out my changes as it rendered the Qt bot unreliable.

WebCore:

  • loader/DocumentThreadableLoader.cpp:

(WebCore::DocumentThreadableLoader::DocumentThreadableLoader):
(WebCore::DocumentThreadableLoader::makeSimpleCrossOriginAccessRequest):
(WebCore::DocumentThreadableLoader::loadRequest):

LayoutTests:

  • http/tests/xmlhttprequest/access-control-preflight-credential-async-expected.txt: Removed.
  • http/tests/xmlhttprequest/access-control-preflight-credential-async.html: Removed.
  • http/tests/xmlhttprequest/access-control-preflight-credential-sync-expected.txt: Removed.
  • http/tests/xmlhttprequest/access-control-preflight-credential-sync.html: Removed.
  • http/tests/xmlhttprequest/resources/basic-auth/access-control-auth-basic.php: Removed.
  • platform/qt/Skipped:
8:08 PM Changeset in webkit [58372] by jchaffraix@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed.

  • platform/qt/Skipped: Add the 2 newly added test cases to the list

as they involve preflight requests.

7:44 PM Changeset in webkit [58371] by jchaffraix@webkit.org
  • 3 edits
    5 adds in trunk

[XHR] Cross-Origin synchronous request with credential raises NETWORK_ERR
​https://bugs.webkit.org/show_bug.cgi?id=37781
<rdar://problem/7905150>

Reviewed by Alexey Proskuryakov.

WebCore:

Tests: http/tests/xmlhttprequest/access-control-preflight-credential-async.html

http/tests/xmlhttprequest/access-control-preflight-credential-sync.html

  • loader/DocumentThreadableLoader.cpp:

(WebCore::DocumentThreadableLoader::DocumentThreadableLoader): Now we remove the
credential from the request here to avoid forgetting to do so in the different code path.
(WebCore::DocumentThreadableLoader::makeSimpleCrossOriginAccessRequest): Just add the
"Origin" header.
(WebCore::DocumentThreadableLoader::loadRequest): Check here the the credential have
been removed so that we don't leak them. Also tweaked a comment to make it clear that
the URL check has issue when credential is involved.

LayoutTests:

Test that doing a cross-origin request with a preflight check does
not raise a NETWORK_ERR exception and does not send the credentials.

  • http/tests/xmlhttprequest/access-control-preflight-credential-async-expected.txt: Added.
  • http/tests/xmlhttprequest/access-control-preflight-credential-async.html: Added.
  • http/tests/xmlhttprequest/access-control-preflight-credential-sync-expected.txt: Added.
  • http/tests/xmlhttprequest/access-control-preflight-credential-sync.html: Added.
  • http/tests/xmlhttprequest/resources/basic-auth/access-control-auth-basic.php: Added.
7:29 PM Changeset in webkit [58370] by eric@webkit.org
  • 2 edits in trunk/WebKit/chromium

2010-04-27 Jay Civelli <​jcivelli@chromium.org>

Reviewed by Darin Fisher.

Makes clicking a select element close its associated popup if
it is open.
​https://bugs.webkit.org/show_bug.cgi?id=38105

  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::mouseDown):
7:08 PM Changeset in webkit [58369] by eric@webkit.org
  • 4 edits in trunk/WebKit/chromium

2010-04-27 Jay Civelli <​jcivelli@chromium.org>

Reviewed by Darin Fisher.

[chromium] Merged the WebView public method to close suggestion popups
into a single method to close all popups (select and suggestions).
That ensures select popups are closed when the browser window is moved
or resized.
​https://bugs.webkit.org/show_bug.cgi?id=37837

  • public/WebView.h:
  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::hidePopups): (WebKit::WebViewImpl::hideSuggestionsPopup):
  • src/WebViewImpl.h:
6:45 PM Changeset in webkit [58368] by weinig@apple.com
  • 2 edits in trunk/WebKitTools

Always build WebKit2 when building on SnowLeopard and later.

Reviewed by Stephanie Lewis.

  • Scripts/build-webkit:
6:28 PM Changeset in webkit [58367] by weinig@apple.com
  • 6 edits in trunk

Fix for ​https://bugs.webkit.org/show_bug.cgi?id=38238
Allow both WebKit and WebKit2 to link to the same WebCore.framework

Reviewed by Maciej Stachowiak.

WebCore:

  • Configurations/WebCore.xcconfig: Use -allowable_client WebKit2 to add

WebKit2 to the list of frameworks that can link directly to WebCore. It
is not necessary for it to be an umbrella since we don't need to reexport
any symbols.

WebKit2:

  • Configurations/WebKit2.xcconfig: Remove the OTHER_LDFLAGS. We don't

need to set WebCore as a sub_umbrella of WebKit2, since we are not
reexporting any of its symbols.

WebKitTools:

  • Scripts/build-webkit: Remove the UMBRELLA_LDFLAGS override when building

WebCore for WebKit2, it is no longer necessary.

6:24 PM Changeset in webkit [58366] by dumi@chromium.org
  • 11 edits in trunk

WebCore: Turn on AUTO_VACUUM = INCREMENTAL for all HTML5 databases.
​https://bugs.webkit.org/show_bug.cgi?id=38191

Reviewed by David Levin.

Vacuum all databases when the number of free pages is at least 10%
of the number of total pages. Also, add a guard against a bug that
was fixed in SQLite only starting with version 3.6.16.

  • platform/sql/SQLiteDatabase.cpp:

(WebCore::SQLiteDatabase::maximumSize):
(WebCore::SQLiteDatabase::freeSpaceSize):
(WebCore::SQLiteDatabase::totalSize):
(WebCore::SQLiteDatabase::runIncrementalVacuumCommand):
(WebCore::SQLiteDatabase::turnOnIncrementalAutoVacuum):

  • platform/sql/SQLiteDatabase.h:

(WebCore::SQLiteDatabase::):

  • platform/sql/SQLiteStatement.cpp:

(WebCore::SQLiteStatement::prepare):
(WebCore::SQLiteStatement::step):

  • storage/Database.cpp:

(WebCore::Database::performOpenAndVerify):
(WebCore::Database::incrementalVacuumIfNeeded):

  • storage/Database.h:
  • storage/SQLTransaction.cpp:

(WebCore::SQLTransaction::postflightAndCommit):

LayoutTests: Adjusting the expected amount of space used by quota-tracking.html.
​https://bugs.webkit.org/show_bug.cgi?id=38191

Reviewed by David Levin.

The expectations changed because of AUTO_VACUUM's overhead.

  • platform/chromium/test_expectations.txt:
  • storage/quota-tracking-expected.txt:
  • storage/quota-tracking.html:
6:19 PM Changeset in webkit [58365] by jam@chromium.org
  • 1 edit
    1 delete in trunk/WebKit/chromium

2010-04-27 John Abd-El-Malek <​jam@chromium.org>

Reviewed by Darin Adler.

Remove unnecessary header now that Chrome is updated
​https://bugs.webkit.org/show_bug.cgi?id=38211

  • public/win/WebThemeEngine.h: Removed.
6:15 PM Changeset in webkit [58364] by jamesr@google.com
  • 2 edits in trunk/WebKitTools

2010-04-27 James Robinson <​jamesr@chromium.org>

Reviewed by David Levin.

Fix a typo in chromium.py that causes NRWT to fail in --verbose
mode in a Chromium checkout.
​https://bugs.webkit.org/show_bug.cgi?id=38234

  • Scripts/webkitpy/layout_tests/port/chromium.py:
6:09 PM Changeset in webkit [58363] by eric@webkit.org
  • 7 edits in trunk/WebCore

2010-04-27 Garret Kelly <​gdk@chromium.org>

Reviewed by Darin Fisher.

Turn all of the touch event handlers into RuntimeEnabledFeatures, and
modify the createEvent methond on Document so that it won't create a
TouchEvent if the feature is disabled.
​https://bugs.webkit.org/show_bug.cgi?id=37485

  • bindings/generic/RuntimeEnabledFeatures.cpp:
  • bindings/generic/RuntimeEnabledFeatures.h: (WebCore::RuntimeEnabledFeatures::touchEnabled): (WebCore::RuntimeEnabledFeatures::setTouchEnabled): (WebCore::RuntimeEnabledFeatures::ontouchstartEnabled): (WebCore::RuntimeEnabledFeatures::ontouchmoveEnabled): (WebCore::RuntimeEnabledFeatures::ontouchendEnabled): (WebCore::RuntimeEnabledFeatures::ontouchcancelEnabled):
  • dom/Document.cpp: (WebCore::Document::createEvent):
  • dom/Document.idl:
  • dom/Element.idl:
  • page/DOMWindow.idl:
5:55 PM Changeset in webkit [58362] by eric@webkit.org
  • 10 edits in trunk

2010-04-27 Jens Alfke <​snej@chromium.org>

Reviewed by Darin Fisher.

[Chromium] Add some notifications and an accessor to WebKit API
​https://bugs.webkit.org/show_bug.cgi?id=37625

  • dom/Node.cpp: (WebCore::Node::hasNonEmptyBoundingBox): New method.
  • dom/Node.h:
  • html/HTMLAnchorElement.cpp: (WebCore::HTMLAnchorElement::isKeyboardFocusable): Moved part of method into new Node method

2010-04-27 Jens Alfke <​snej@chromium.org>

Reviewed by Darin Fisher.

[Chromium] Add some notifications and an accessor to WebKit API
​https://bugs.webkit.org/show_bug.cgi?id=37625

  • public/WebFrameClient.h: (WebKit::WebFrameClient::didFirstLayout): (WebKit::WebFrameClient::didFirstVisuallyNonEmptyLayout):
  • public/WebNode.h:
  • src/FrameLoaderClientImpl.cpp: (WebKit::FrameLoaderClientImpl::dispatchDidFirstLayout): (WebKit::FrameLoaderClientImpl::dispatchDidFirstVisuallyNonEmptyLayout):
  • src/WebElement.cpp:
  • src/WebNode.cpp: (WebKit::WebNode::hasNonEmptyBoundingBox):
5:41 PM Changeset in webkit [58361] by evan@chromium.org
  • 2 edits in trunk/LayoutTests

2010-04-27 Evan Martin <​evan@chromium.org>

Reviewed by David Levin.

[chromium] update test expectations for ancient linux bug
​https://bugs.webkit.org/show_bug.cgi?id=38229

According to
​http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=plugins%2Fembed-attributes-setting.html
this hasn't crashed in a long time, so the CRASH annotation is superfluous.

  • platform/chromium/test_expectations.txt:
5:38 PM Changeset in webkit [58360] by eric@webkit.org
  • 3 edits in trunk/WebCore

2010-04-27 Jochen Eisinger <​jochen@chromium.org>

Reviewed by Shinichiro Hamaji.

Fix gyp build on Mac OS X with enable_svg=0.
​https://bugs.webkit.org/show_bug.cgi?id=38192

  • WebCore.gyp/WebCore.gyp: Only generate SVG symbols if enable_svg!=0.
  • css/CSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Add missing unimplemented CSS properties to switch statement.
5:33 PM EFLWebKit edited by barbieri@profusion.mobi
update to reflect current situation (diff)
5:29 PM Changeset in webkit [58359] by crogers@google.com
  • 5 edits in branches/audio/WebCore
  • added <xaudio> tag (this is temporary to support the old API)
  • some build changes for new audio javascript types
5:28 PM Changeset in webkit [58358] by eric@webkit.org
  • 6 edits in trunk

2010-04-27 Darin Fisher <​darin@chromium.org>

Reviewed by Dimitri Glazkov.

[Chromium] Remove deprecated form of didChangeLocationWithinPage
​https://bugs.webkit.org/show_bug.cgi?id=38178

  • public/WebFrameClient.h:
  • src/FrameLoaderClientImpl.cpp: (WebKit::FrameLoaderClientImpl::dispatchDidNavigateWithinPage):

2010-04-27 Darin Fisher <​darin@chromium.org>

Reviewed by Dimitri Glazkov.

[Chromium] Remove deprecated form of didChangeLocationWithinPage
​https://bugs.webkit.org/show_bug.cgi?id=38178

Switch over to implementing didNavigateWithinPage.

  • DumpRenderTree/chromium/WebViewHost.cpp: (TestWebViewDelegate::didNavigateWithinPage): (WebViewHost::didChangeLocationWithinPage):
  • DumpRenderTree/chromium/WebViewHost.h:
5:13 PM Changeset in webkit [58357] by crogers@google.com
  • 3 edits
    1 add in branches/audio/WebCore

hacks for CachedAudio including changes to EventTarget
(this supports a temporary and hackish loading mechanism for audio assets later to be replaced by XHR)

5:13 PM Changeset in webkit [58356] by crogers@google.com
  • 1 add in branches/audio/WebCore/audio/HRIR

add HRIR symlink

4:56 PM Changeset in webkit [58355] by Stephanie Lewis
  • 2 edits in trunk/JavaScriptCore

Fix Tiger build.

  • wtf/FastMalloc.cpp:

(WTF::TCMalloc_PageHeap::Carve):

4:42 PM Changeset in webkit [58354] by evan@chromium.org
  • 2 edits in trunk/WebKitTools

2010-04-27 Evan Martin <​evan@chromium.org>

Unreviewed.

Adding myself to commmitters list.

  • Scripts/webkitpy/common/config/committers.py:
4:25 PM Changeset in webkit [58353] by Stephanie Lewis
  • 3 deletes in trunk/WebKitLibraries

Remove more files I didn't intend to commit

4:24 PM Changeset in webkit [58352] by kinuko@chromium.org
  • 2 edits in trunk/WebCore

2010-04-27 Kinuko Yasuda <​kinuko@chromium.org>

Reviewed by Jian Li.

[V8] Handle OR ('|') conditional in action_derivedsourcesallinone.py
​https://bugs.webkit.org/show_bug.cgi?id=38207

No new tests.

  • WebCore.gyp/scripts/action_derivedsourcesallinone.py:
4:23 PM Changeset in webkit [58351] by crogers@google.com
  • 2 deletes in branches/audio/WebCore/audio

remove initial test files

4:19 PM Changeset in webkit [58350] by Stephanie Lewis
  • 8 edits in trunk

Revert Files I didn't intend to commit

4:13 PM Changeset in webkit [58349] by eric@webkit.org
  • 5 edits
    8 adds in trunk

2010-04-27 François Sausset <François Sausset>

Reviewed by Kenneth Rohde Christiansen.

Additional MathML mroot & msqrt tests.
​https://bugs.webkit.org/show_bug.cgi?id=37044

  • mathml/presentation/roots.xhtml: Added.
  • platform/mac/mathml/presentation/roots-expected.checksum: Added.
  • platform/mac/mathml/presentation/roots-expected.png: Added.
  • platform/mac/mathml/presentation/roots-expected.txt: Added.

2010-04-27 François Sausset <François Sausset>

Reviewed by Kenneth Rohde Christiansen.

Implementation of the MathML mroot & msqrt elements.
​https://bugs.webkit.org/show_bug.cgi?id=37044

Test: mathml/presentation/roots.xhtml

  • WebCore.xcodeproj/project.pbxproj:
  • css/mathml.css: (mroot): (mroot > * + *): (mroot > * + mrow, mroot > * + mfenced):
  • mathml/MathMLInlineContainerElement.cpp: (WebCore::MathMLInlineContainerElement::createRenderer):
  • mathml/RenderMathMLRoot.cpp: Added. (WebCore::RenderMathMLRoot::RenderMathMLRoot): (WebCore::RenderMathMLRoot::addChild): (WebCore::RenderMathMLRoot::paint): (WebCore::RenderMathMLRoot::layout):
  • mathml/RenderMathMLRoot.h: Added.
  • mathml/RenderMathMLSquareRoot.cpp: Added. (WebCore::RenderMathMLSquareRoot::RenderMathMLSquareRoot): (WebCore::RenderMathMLSquareRoot::paint): (WebCore::RenderMathMLSquareRoot::layout):
  • mathml/RenderMathMLSquareRoot.h: Added.
4:02 PM Changeset in webkit [58348] by eric@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

2010-04-27 Jeremy Orlow <​jorlow@chromium.org>

Reviewed by Dimitri Glazkov.

[Chromium] Create new baseline for caret-rtl-2
​https://bugs.webkit.org/show_bug.cgi?id=38126

​http://trac.webkit.org/changeset/58191/ caused the caret-rtl-2 layout
test to start failing under Chromium. Since we're the only ones who
run pixel tests, it's possible that the actual baseline needs to be updated
and not just the chromium baseline...but I'm not sure.

I'm tracking the overall progress of figuring this out here:
​https://bugs.webkit.org/show_bug.cgi?id=38109

  • platform/chromium-mac/editing/selection/caret-rtl-2-actual.checksum: Added.
  • platform/chromium-mac/editing/selection/caret-rtl-2-actual.png: Added.
3:56 PM Changeset in webkit [58347] by Darin Adler
  • 1 edit
    1 delete in trunk/WebCore

I noticed an unused forwarding header.

Reviewed by Maciej Stachowiak.

  • ForwardingHeaders/runtime/PropertyMap.h: Removed.
3:55 PM Changeset in webkit [58346] by Stephanie Lewis
  • 8 edits
    9 adds in trunk

​https://bugs.webkit.org/show_bug.cgi?id=38154 FastMalloc calls madvise too often.
<rdar://problem/7834433> REGRESSSION: 1.5% PLT regression due to 56028 (return memory quicker).
To save on madvise calls when recommitting memory recommit the entire span and then carve it
instead of carving the span up and only committing the part that will be used immediately.

Reviewed by Geoff Garen.

  • wtf/FastMalloc.cpp:

(WTF::TCMalloc_PageHeap::New):
(WTF::TCMalloc_PageHeap::AllocLarge):
(WTF::TCMalloc_PageHeap::Carve):

3:51 PM Changeset in webkit [58345] by jamesr@google.com
  • 12 edits in trunk/WebCore

2010-04-27 James Robinson <​jamesr@chromium.org>

Reviewed by Adam Barth.

Fix gcc 4.4.1 warnings on Linux in the chromium V8 bindings code.
​https://bugs.webkit.org/show_bug.cgi?id=38153

  • bindings/scripts/CodeGeneratorV8.pm:
  • bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::callFunction):
3:48 PM Changeset in webkit [58344] by evan@chromium.org
  • 1 edit
    1 add in trunk/LayoutTests

2010-04-27 Evan Martin <​evan@chromium.org>

Unreviewed, making the bots happy.

[chromium] bold bengali text not rendered properly on Linux
​https://bugs.webkit.org/show_bug.cgi?id=37904

Check in a baseline for Mac pulled from the bots.

  • platform/mac/fast/text/international/bold-bengali-expected.txt: Added.
3:47 PM Changeset in webkit [58343] by crogers@google.com
  • 2446 adds in branches/audio/WebCore/audio/AudioSpatialization

add HRIR spatialization files

3:04 PM Changeset in webkit [58342] by eric@webkit.org
  • 13 edits
    1 move
    2 deletes in trunk

2010-04-27 Eric Seidel <​eric@webkit.org>

Unreviewed, rolling out r58318.
​http://trac.webkit.org/changeset/58318
​https://bugs.webkit.org/show_bug.cgi?id=37215

Broke test on Tiger. Might just need updated results,
unclear.

  • http/tests/inspector/console-resource-errors-expected.txt: Removed.
  • http/tests/inspector/console-resource-errors.html: Removed.
  • http/tests/inspector/console-tests.js: Removed.
  • inspector/console-clear.html:
  • inspector/console-dir.html:
  • inspector/console-dirxml.html:
  • inspector/console-format-collections-expected.txt:
  • inspector/console-format-collections.html:
  • inspector/console-format.html:
  • inspector/console-log-before-inspector-open.html:
  • inspector/console-tests.html:
  • inspector/console-tests.js: Added. (dumpConsoleMessages.callback): (dumpConsoleMessages): (dumpConsoleMessagesWithClasses.callback): (dumpConsoleMessagesWithClasses): (frontend_dumpConsoleMessages):

2010-04-27 Eric Seidel <​eric@webkit.org>

Unreviewed, rolling out r58318.
​http://trac.webkit.org/changeset/58318
​https://bugs.webkit.org/show_bug.cgi?id=37215

Broke test on Tiger. Might just need updated results,
unclear.

  • inspector/InspectorController.cpp: (WebCore::InspectorController::didReceiveResponse): (WebCore::InspectorController::didFailLoading):
  • inspector/front-end/Resource.js: (WebInspector.Resource.prototype._mimeTypeIsConsistentWithType):
  • inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel.prototype.recreateViewForResourceIfNeeded):
2:53 PM Changeset in webkit [58341] by evan@chromium.org
  • 6 edits
    4 adds in trunk

2010-04-27 Evan Martin <​evan@chromium.org>

Reviewed by David Levin.

[chromium] bold bengali text not rendered properly on Linux
​https://bugs.webkit.org/show_bug.cgi?id=37904

Add a layout test containing some bold Bengali text.

  • fast/text/international/bold-bengali.html: Added.
  • platform/chromium-linux/fast/text/international/bold-bengali-expected.checksum: Added.
  • platform/chromium-linux/fast/text/international/bold-bengali-expected.png: Added.
  • platform/chromium-linux/fast/text/international/bold-bengali-expected.txt: Added.

2010-04-27 Evan Martin <​evan@chromium.org>

Reviewed by David Levin.

[chromium] bold bengali text not rendered properly on Linux
​https://bugs.webkit.org/show_bug.cgi?id=37904

We must let Skia do font fallback, rather than picking a font name
then handing that to Skia. For example, if we have Bengali text and
choose FreeSans + fake bold, and then later reuse the name, Skia will
helpfully use FreeSansBold (which doesn't cover Bengali).

Test: fast/text/international/bold-bengali.html

  • platform/graphics/chromium/FontCacheLinux.cpp: (WebCore::FontCache::getFontDataForCharacters):

2010-04-27 Evan Martin <​evan@chromium.org>

Reviewed by David Levin.

[chromium] bold bengali text not rendered properly on Linux
Roll forward Chrome DEPS so we get new Skia API.

  • DEPS: update Chrome to r45696.
2:52 PM Changeset in webkit [58340] by jamesr@google.com
  • 6 edits in trunk/WebCore

2010-04-27 James Robinson <​jamesr@chromium.org>

Reviewed by Darin Adler.

Fix warnings emitted by gcc 4.4.1 on linux in chromium-specific platform graphics files.
​https://bugs.webkit.org/show_bug.cgi?id=38158

Most of the issues are signed/unsigned mismatches, but there are a few unusued variables
and functions mixed in.

  • platform/graphics/chromium/FontLinux.cpp: (WebCore::adjustTextRenderMode): (WebCore::TextRunWalker::getTextRun): (WebCore::TextRunWalker::getNormalizedTextRun): (WebCore::TextRunWalker::setGlyphXPositions): (WebCore::glyphIndexForXPositionInScriptRun): (WebCore::Font::offsetForPositionForComplexText): (WebCore::Font::selectionRectForComplexText):
  • platform/graphics/chromium/FontPlatformDataLinux.cpp: (WebCore::FontPlatformData::setupPaint):
  • platform/graphics/chromium/HarfbuzzSkia.cpp: (WebCore::getOutlinePoint):
  • platform/graphics/skia/GraphicsContext3DSkia.cpp: (WebCore::GraphicsContext3D::getImageData):
  • platform/graphics/skia/GraphicsContextSkia.cpp: (WebCore::isCoordinateSkiaSafe): (WebCore::GraphicsContext::fillRect): (WebCore::GraphicsContext::strokePath): (WebCore::GraphicsContext::strokeRect):
2:51 PM Changeset in webkit [58339] by abarth@webkit.org
  • 1 edit
    3 adds in trunk/LayoutTests

2010-04-27 Adam Barth <​abarth@webkit.org>

Reviewed by Darin Adler.

Add test for NodeIterator prototype change behavior
​https://bugs.webkit.org/show_bug.cgi?id=38219

In the process of remove the custom code from NodeIterator, we thought
we fixed a subtle bug where iterating over nodes from another frame
would get the wrong prototype chain. This test documents that we
didn't actually change the behavior and we still have the bug.

  • traversal/node-iterator-prototype-expected.txt: Added.
  • traversal/node-iterator-prototype.html: Added.
  • traversal/resources/node-iterator-prototype-frame.html: Added.
2:44 PM Changeset in webkit [58338] by crogers@google.com
  • 130 adds in branches/audio/WebCore/audio

add initial set of audio engine source files

2:35 PM Changeset in webkit [58337] by jhoneycutt@apple.com
  • 2 edits in trunk/WebKit/win

<rdar://problem/7911140> Hitting the "delete" key goes back twice

Reviewed by Maciej Stachowiak.

  • WebView.cpp:

(WebView::keyDown):
Return true if we navigated back or forward from the key event to
prevent the event from being propagated further.

2:31 PM Changeset in webkit [58336] by jianli@chromium.org
  • 5 edits in trunk/WebCore

Sending a package file using FormData crashes WebKit on Mac.
​https://bugs.webkit.org/show_bug.cgi?id=37882

Reviewed by Darin Adler.

Can't add a layout test because DRT does not support generating the file name.

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::submitForm):
(WebCore::FrameLoader::navigateToDifferentDocument):

  • platform/network/FormData.cpp:

(WebCore::FormData::appendDOMFormData):

  • platform/network/FormData.h:
  • xml/XMLHttpRequest.cpp:

(WebCore::XMLHttpRequest::send):

2:06 PM Changeset in webkit [58335] by ojan@chromium.org
  • 2 edits in trunk/LayoutTests

2010-04-27 Ojan Vafai <​ojan@chromium.org>

Unreviewed. Minor fix after goofup in ​http://trac.webkit.org/changeset/58331

layoutTestController should have dumpAsMarkup
​https://bugs.webkit.org/show_bug.cgi?id=26501

Forgot to reset the test results after doing the code review feedback
of adding a newline.

  • editing/selection/dump-as-markup-expected.txt:
1:59 PM Changeset in webkit [58334] by crogers@google.com
  • 1 add in branches/audio/WebCore/audio/test-commit2

test commit 2

1:55 PM Changeset in webkit [58333] by abarth@webkit.org
  • 14 edits
    1 delete in trunk/WebCore

2010-04-27 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Remove custom NodeIterator bindings
​https://bugs.webkit.org/show_bug.cgi?id=38188

Another example of CallWith=ScriptState. This case shows us the right
way to handle the interaction with exception codes.

In my previous patch, I put the exception code handling after the
ScriptState exception handling. It turns out this was a mistake
(although a harmless one at the time because no IDL caused us to
generate that code). Now that we're generating both kinds of exception
handling, we need to generate them in the right order.

  • WebCore.gypi:
  • bindings/js/JSNodeIteratorCustom.cpp:
  • bindings/scripts/CodeGeneratorJS.pm:
  • bindings/scripts/CodeGeneratorV8.pm:
  • bindings/scripts/test/GObject/WebKitDOMTestObj.cpp: (webkit_dom_test_obj_with_script_state_void_exception): (webkit_dom_test_obj_with_script_state_obj_exception):
  • bindings/scripts/test/GObject/WebKitDOMTestObj.h:
  • bindings/scripts/test/JS/JSTestObj.cpp: (WebCore::): (WebCore::jsTestObjPrototypeFunctionWithScriptStateVoidException): (WebCore::jsTestObjPrototypeFunctionWithScriptStateObjException):
  • bindings/scripts/test/JS/JSTestObj.h:
  • bindings/scripts/test/ObjC/DOMTestObj.h:
  • bindings/scripts/test/ObjC/DOMTestObj.mm: (-[DOMTestObj withScriptStateVoidException]): (-[DOMTestObj withScriptStateObjException]):
  • bindings/scripts/test/TestObj.idl:
  • bindings/scripts/test/V8/V8TestObj.cpp: (WebCore::TestObjInternal::withScriptStateVoidCallback): (WebCore::TestObjInternal::withScriptStateObjCallback): (WebCore::TestObjInternal::withScriptStateVoidExceptionCallback): (WebCore::TestObjInternal::withScriptStateObjExceptionCallback): (WebCore::):
  • bindings/v8/custom/V8NodeIteratorCustom.cpp: Removed.
  • dom/NodeIterator.idl:
1:35 PM Changeset in webkit [58332] by weinig@apple.com
  • 2 edits in trunk/WebKit2

Add comment about not using StringImpl::createCFString in WKStringCopyCFString.

Reviewed by Geoffrey Garen.

  • UIProcess/API/C/cf/WKStringCF.cpp:

(WKStringCopyCFString):

1:29 PM Changeset in webkit [58331] by ojan@chromium.org
  • 1 edit
    4 adds in trunk/LayoutTests

2010-04-26 Ojan Vafai <​ojan@chromium.org>

Reviewed by Darin Adler.

layoutTestController should have dumpAsMarkup
​https://bugs.webkit.org/show_bug.cgi?id=26501

  • editing/selection/dump-as-markup-expected.txt: Added.
  • editing/selection/dump-as-markup.html: Added.
  • resources/dump-as-markup.js: Added. (Markup.dump.get var): (Markup.dump.get catch): (Markup.dump): (Markup.waitUntilDone): (Markup.notifyDone): (Markup._spaces): (Markup._getAttributes): (Markup._getMarkupForTextNode): (Markup._getSelectionMarker):
1:26 PM Changeset in webkit [58330] by abarth@webkit.org
  • 32 edits in trunk/WebCore

2010-04-27 Adam Barth <​abarth@webkit.org>

Reviewed by Darin Adler.

Remove copy/paste addEventListener "custom" bindings via code generation
​https://bugs.webkit.org/show_bug.cgi?id=38210

It's somewhat lame to special case addEventListener and
removeEventListener in the code generator, but it saves a large amount
of boilerplate "custom" bindings code.

Idea shamelessly stolen from the V8 code generator.

This patch points to some good refactoring opportunities in
CodeGeneratorJS.pm, but I'm going to hold off on those for a future
patch. By generating test coverage for the code generator, we make
these future refactorings easier.

  • bindings/js/JSAbstractWorkerCustom.cpp:
  • bindings/js/JSDOMApplicationCacheCustom.cpp:
  • bindings/js/JSDesktopNotificationsCustom.cpp:
  • bindings/js/JSEventSourceCustom.cpp:
  • bindings/js/JSMessagePortCustom.cpp:
  • bindings/js/JSNodeCustom.cpp:
  • bindings/js/JSSVGElementInstanceCustom.cpp:
  • bindings/js/JSWebSocketCustom.cpp:
  • bindings/js/JSWorkerContextCustom.cpp:
  • bindings/js/JSXMLHttpRequestCustom.cpp:
  • bindings/js/JSXMLHttpRequestUploadCustom.cpp:
  • bindings/scripts/CodeGeneratorJS.pm:
  • bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:
  • bindings/scripts/test/GObject/WebKitDOMTestObj.h:
  • bindings/scripts/test/JS/JSTestObj.cpp: (WebCore::): (WebCore::jsTestObjPrototypeFunctionAddEventListener): (WebCore::jsTestObjPrototypeFunctionRemoveEventListener):
  • bindings/scripts/test/JS/JSTestObj.h:
  • bindings/scripts/test/ObjC/DOMTestObj.h:
  • bindings/scripts/test/ObjC/DOMTestObj.mm: (-[DOMTestObj addEventListener:listener:useCapture:]): (-[DOMTestObj removeEventListener:listener:useCapture:]):
  • bindings/scripts/test/TestObj.idl:
  • bindings/scripts/test/V8/V8TestObj.cpp: (WebCore::TestObjInternal::addEventListenerCallback): (WebCore::TestObjInternal::removeEventListenerCallback): (WebCore::):
  • dom/MessagePort.idl:
  • dom/Node.idl:
  • loader/appcache/DOMApplicationCache.idl:
  • notifications/Notification.idl:
  • page/EventSource.idl:
  • svg/SVGElementInstance.idl:
  • websockets/WebSocket.idl:
  • workers/AbstractWorker.idl:
  • workers/WorkerContext.idl:
  • xml/XMLHttpRequest.idl:
  • xml/XMLHttpRequestUpload.idl:
1:25 PM Changeset in webkit [58329] by abarth@webkit.org
  • 2 edits in trunk/WebKitTools

2010-04-27 Adam Barth <​abarth@webkit.org>

Reviewed by Darin Adler.

run-bindings-tests should use --reset-results instead of --overwrite
​https://bugs.webkit.org/show_bug.cgi?id=38200

As requested by Ojan.

  • Scripts/run-bindings-tests:
1:22 PM Changeset in webkit [58328] by abarth@webkit.org
  • 22 edits in trunk/WebKitTools

2010-04-27 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

REGRESSION(r58261): webkit-patch edit-changelogs is broken
​https://bugs.webkit.org/show_bug.cgi?id=38204

In 58261, we added code to abstract step that interrogates the squash
and git_commit options, but it doesn't declare that it uses those
options. That means any command that doesn't happen to declare those
options might be broken if it uses the cached_lookup mechanism.

  • Scripts/webkitpy/tool/steps/abstractstep.py:
  • Scripts/webkitpy/tool/steps/applypatch.py:
  • Scripts/webkitpy/tool/steps/applypatchwithlocalcommit.py:
  • Scripts/webkitpy/tool/steps/build.py:
  • Scripts/webkitpy/tool/steps/checkstyle.py:
  • Scripts/webkitpy/tool/steps/cleanworkingdirectory.py:
  • Scripts/webkitpy/tool/steps/closebug.py:
  • Scripts/webkitpy/tool/steps/closebugforlanddiff.py:
  • Scripts/webkitpy/tool/steps/commit.py:
  • Scripts/webkitpy/tool/steps/confirmdiff.py:
  • Scripts/webkitpy/tool/steps/createbug.py:
  • Scripts/webkitpy/tool/steps/ensurebuildersaregreen.py:
  • Scripts/webkitpy/tool/steps/ensurelocalcommitifneeded.py:
  • Scripts/webkitpy/tool/steps/obsoletepatches.py:
  • Scripts/webkitpy/tool/steps/postcodereview.py:
  • Scripts/webkitpy/tool/steps/postdiff.py:
  • Scripts/webkitpy/tool/steps/preparechangelog.py:
  • Scripts/webkitpy/tool/steps/runtests.py:
  • Scripts/webkitpy/tool/steps/update.py:
  • Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py:
  • Scripts/webkitpy/tool/steps/validatereviewer.py:
1:16 PM Changeset in webkit [58327] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2010-04-27 Eric Seidel <​eric@webkit.org>

Reviewed by David Levin.

prepare-ChangeLog --bug fails on some CYGWIN installs due to missing certs
​https://bugs.webkit.org/show_bug.cgi?id=38212

  • Scripts/prepare-ChangeLog:
    • Pass --insecure to curl to work around CYGWIN missing certs.
1:15 PM Changeset in webkit [58326] by crogers@google.com
  • 1 edit in branches/audio/WebCore/audio/test-commit

testing git svn dcommit

1:05 PM Changeset in webkit [58325] by weinig@apple.com
  • 2 edits in trunk/WebKit2

Remove call to StringImpl::createCFString and instead use CFStringCreateWithCharacters
directly. StringImpl::createCFString only an optimization when called
from the thread that WebCore is running on, which is never the case for
WKStringCopyCFString. We should revisit this later, perhaps adding a
threadspecific allocator. We also now honor the passed in allocator.

Reviewed by Geoffrey Garen.

  • UIProcess/API/C/cf/WKStringCF.cpp:

(WKStringCopyCFString):

12:51 PM Changeset in webkit [58324] by weinig@apple.com
  • 8 edits in trunk

WebCore: Remove now unnecessary EXPERIMENTAL_SINGLE_VIEW_MODE #define.

Rubber-stamped by Beth Dakin.

  • page/EventHandler.cpp:

(WebCore::EventHandler::EventHandler):
(WebCore::EventHandler::clearDragState):

  • page/EventHandler.h:
  • page/mac/DragControllerMac.mm:
  • page/mac/EventHandlerMac.mm:
  • platform/mac/PopupMenuMac.mm:

WebKitTools: It is no longer necessary to set ENABLE_EXPERIMENTAL_SINGLE_VIEW_MODE
or WTF_USE_WEB_THREAD. Remove them.

Rubber-stamped by Beth Dakin.

  • Scripts/build-webkit:
12:50 PM WebKit Team edited by Chris Jerdonek
Changed myself from committer to reviewer. (diff)
12:45 PM Changeset in webkit [58323] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-04-27 Ben Murdoch <​benm@google.com>

Reviewed by Simon Hausmann.

The TouchStationary state of WebCore::PlatformTouchPoint is not handled inside the touch event handler.
​https://bugs.webkit.org/show_bug.cgi?id=37609

No new tests required, only updating documentation.

  • page/EventHandler.cpp: (WebCore::EventHandler::handleTouchEvent): Improve the documentation for handling

the TouchStationary state as a result of discussions in bug 37609.

12:44 PM Changeset in webkit [58322] by Chris Jerdonek
  • 2 edits in trunk/WebKitTools

Changed Chris Jerdonek from committer to reviewer.

Reviewed by David Levin.

  • Scripts/webkitpy/common/config/committers.py:
12:33 PM Changeset in webkit [58321] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2010-04-27 Benjamin Poulain <​benjamin.poulain@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] QGraphicsWebView: Arrow keys scroll the graphics-view instead of the web-page
​https://bugs.webkit.org/show_bug.cgi?id=35834

The scene should always have the size of the web view otherwhise it is
possible to scroll the graphics view.

  • QtLauncher/webview.cpp: (WebViewGraphicsBased::resizeEvent):
12:26 PM Changeset in webkit [58320] by Simon Fraser
  • 5 edits
    5 adds in trunk/WebCore

2010-04-27 Simon Fraser <Simon Fraser>

Reviewed by Darin Adler, Maciej Stachowiak.

REGRESSION (r57919): Some pages opened in background tabs don't render the first time you activate their tab
​https://bugs.webkit.org/show_bug.cgi?id=38183

Rather than sprinkle PLATFORM #ifdefs around, add a new method,
RenderLayerCompositor::shouldPropagateCompositingToIFrameParent(), that indicates whether
an iframe with composited content should trigger compositing mode in the enclosing document
(a behavior that differs between platforms).

Use this new method to determine whether to trigger a style recalc in the parent document
when an iframe becomes composited.

Move the code formerly in RenderView::compositingStateChanged() into RenderLayerCompositor().

  • manual-tests/compositing/accel-comp-iframe-tab-repaint.html: Added.
  • manual-tests/compositing/resources/flash-frame.html: Added.
  • manual-tests/compositing/resources/tab-repaint-part-2.html: Added.
  • rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::enableCompositingMode): (WebCore::RenderLayerCompositor::shouldPropagateCompositingToIFrameParent): (WebCore::RenderLayerCompositor::requiresCompositingForIFrame):
  • rendering/RenderLayerCompositor.h:
  • rendering/RenderView.cpp:
  • rendering/RenderView.h:
12:11 PM Changeset in webkit [58319] by diegohcg@webkit.org
  • 2 edits in trunk/WebKitTools

Unreviewed.

Adding myself to committers.py

  • Scripts/webkitpy/common/config/committers.py:
11:47 AM Changeset in webkit [58318] by eric@webkit.org
  • 13 edits
    1 move
    2 adds in trunk

2010-04-27 Andrey Kosyakov <​caseq@chromium.org>

Reviewed by Yury Semikhatsky.

Log error message to inspector console if a resource fails to load.
Moved console-tests.js to http tests. Added support for sorting
console messages, in case order may vary.
​https://bugs.webkit.org/show_bug.cgi?id=37215

  • http/tests/inspector/console-resource-errors-expected.txt: Added.
  • http/tests/inspector/console-resource-errors.html: Added.
  • http/tests/inspector/console-tests.js: Added. (dumpConsoleMessages.callback): (dumpConsoleMessages): (dumpConsoleMessagesWithClasses.callback): (dumpConsoleMessagesWithClasses): (frontend_dumpConsoleMessages):
  • inspector/console-clear.html:
  • inspector/console-dir.html:
  • inspector/console-dirxml.html:
  • inspector/console-format-collections-expected.txt:
  • inspector/console-format-collections.html:
  • inspector/console-format.html:
  • inspector/console-log-before-inspector-open.html:
  • inspector/console-tests.html:
  • inspector/console-tests.js: Removed.

2010-04-27 Andrey Kosyakov <​caseq@chromium.org>

Reviewed by Yury Semikhatsky.

Log error message to inspector console if a resource fails to load.
Disable checking of mime-type consistency for failed resources.
​https://bugs.webkit.org/show_bug.cgi?id=37215

Test: http/tests/inspector/console-resource-errors.html

  • inspector/InspectorController.cpp: (WebCore::InspectorController::didReceiveResponse): (WebCore::InspectorController::didFailLoading):
  • inspector/front-end/Resource.js: (WebInspector.Resource.prototype._mimeTypeIsConsistentWithType):
  • inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel.prototype.recreateViewForResourceIfNeeded):
11:17 AM Changeset in webkit [58317] by oliver@apple.com
  • 7 edits in trunk/JavaScriptCore

2010-04-26 Oliver Hunt <​oliver@apple.com>

Reviewed by Maciej Stachowiak.

Add specialized thunks for a char code related string functions
​https://bugs.webkit.org/show_bug.cgi?id=38177

This is a simple extension to my prior patch. Basically hoist the
existing character loading logic from the charCodeAt thunk and into
a helper function, then add a helper to load strings from the small
string cache. This allows trivial implementations of fromCharCode
and charAt.

  • create_hash_table:
  • jit/SpecializedThunkJIT.h: (JSC::SpecializedThunkJIT::returnJSCell): (JSC::SpecializedThunkJIT::tagReturnAsJSCell):
  • jit/ThunkGenerators.cpp: (JSC::stringCharLoad): (JSC::charToString): (JSC::charCodeAtThunkGenerator): (JSC::charAtThunkGenerator): (JSC::fromCharCodeThunkGenerator):
  • jit/ThunkGenerators.h:
  • runtime/SmallStrings.h: (JSC::SmallStrings::singleCharacterStrings):
  • runtime/StringConstructor.cpp: (JSC::StringConstructor::StringConstructor):
10:58 AM Changeset in webkit [58316] by vitalyr@chromium.org
  • 2 edits in trunk/WebCore

2010-04-27 Vitaly Repeshko <​vitalyr@chromium.org>

Reviewed by Nate Chapin.

[V8] Fix XHR memory leak in GC controller.
​https://bugs.webkit.org/show_bug.cgi?id=38202

​http://trac.webkit.org/changeset/55798 simplified processing of
active DOM objects but introduced a subtle bug in garbage
collection of XHRs. ActiveDOMObject is not a direct base class of
XHR and so upcasting changes pointer identity and breaks DOM
maps. This leads to forever live persistent handles to XHR that
had pending activity while V8 GC happened.

  • bindings/v8/V8GCController.cpp: (WebCore::GCEpilogueVisitor::visitDOMWrapper):
10:54 AM Changeset in webkit [58315] by abarth@webkit.org
  • 2 edits in trunk/WebCore

2010-04-27 Adam Barth <​abarth@webkit.org>

Unreviewed. Regenerate reference bindings code generator output.

  • bindings/scripts/test/V8/V8TestObj.cpp: (WebCore::TestObjInternal::withScriptStateVoidCallback): (WebCore::TestObjInternal::withScriptStateObjCallback):
10:50 AM Changeset in webkit [58314] by eric@webkit.org
  • 14 edits in trunk/WebKitTools

2010-04-27 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

[chromium] new-run-webkit-tests hangs on Chromium Bots (OS X and Linux)
​https://bugs.webkit.org/show_bug.cgi?id=37987

After further research, I believe the hang is caused by:
​http://bugs.python.org/issue2320
Basically Popen() is not reentrant.
The workaround is to pass close_fds=True to Popen() on Mac/Linux.

I fixed our main Popen wrapper "Executive.run_command" to use close_fds=True
when appropriate.

I audited all places we call Popen() and either moved them to run_command
or left a FIXME that they are not thread safe. A few places I added the
close_fds workaround there and left an explanitory note.

  • Scripts/webkitpy/common/checkout/scm_unittest.py:
    • Added note that this Popen use is not threadsafe.
  • Scripts/webkitpy/common/system/executive.py:
    • Fixed our Executive.run_* to workaround python bug 2320.
  • Scripts/webkitpy/common/system/user.py: _ Added note that this Popen use is not threadsafe.
  • Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py: ditto.
  • Scripts/webkitpy/layout_tests/port/apache_http_server.py: ditto.
  • Scripts/webkitpy/layout_tests/port/base.py:
    • Change wdiff back to using run_command now that we believe it to be threadsafe.
  • Scripts/webkitpy/layout_tests/port/chromium.py:
    • Fix to use Executive in places.
    • Pass self._executive down to the Driver for easier unit testing.
  • Scripts/webkitpy/layout_tests/port/chromium_win.py:
    • Re-factor to use a _kill_all method.
    • Made the _kill_all method use run_command to be threadsafe.
  • Scripts/webkitpy/layout_tests/port/http_server.py:
    • Add FIXME about using Executive.
  • Scripts/webkitpy/layout_tests/port/server_process.py:
    • Use Executive to be threadsafe.
  • Scripts/webkitpy/layout_tests/port/webkit.py:
    • Pass self._executive down to the Driver.
  • Scripts/webkitpy/layout_tests/port/websocket_server.py:
    • Add note about Popen not being threadsafe.
  • Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
    • Move one caller to run_command add notes about moving others.
10:19 AM Changeset in webkit [58313] by Joseph Pecoraro
  • 6 edits
    4 adds in trunk

2010-04-27 Joseph Pecoraro <Joseph Pecoraro>

Reviewed by Dan Bernstein.

<input type="search"> with uneven padding causes text clipping
​https://bugs.webkit.org/show_bug.cgi?id=38160

  • fast/css/input-search-padding.html: Added.
  • platform/mac/fast/css/input-search-padding-expected.checksum: Added.
  • platform/mac/fast/css/input-search-padding-expected.png: Added.
  • platform/mac/fast/css/input-search-padding-expected.txt: Added.

2010-04-27 Joseph Pecoraro <Joseph Pecoraro>

Reviewed by Dan Bernstein.

<input type="search"> with uneven padding causes text clipping
​https://bugs.webkit.org/show_bug.cgi?id=38160

Test: fast/css/input-search-padding.html

An <input type="search"> contains an inner block, which is explicitly
centered in RenderTextControlSingleLine based on the height of the element.
However, the clipping rect was not using the set location, and instead
calculated off of the top border and padding alone. This also vertically
centers the Caps Lock indicator.

  • rendering/RenderTextControl.cpp: moved controlClipRect implementation to RenderTextControlSingleLine
  • rendering/RenderTextControl.h: allow a subclass implementation of controlClipRect, removed redundant hasControlClip implementation, and moved controlClipRect
  • rendering/RenderTextControlSingleLine.cpp: (WebCore::RenderTextControlSingleLine::paint): vertically center the Caps Lock indicator (WebCore::RenderTextControlSingleLine::controlClipRect): use the set location of the anonymous inner block instead
  • rendering/RenderTextControlSingleLine.h: allow for an implementation of controlClipRect for <input type="search">
9:39 AM Changeset in webkit [58312] by pfeldman@chromium.org
  • 2 edits in trunk/WebKit/chromium

2010-04-27 Andrey Kosyakov <​caseq@chromium.org>

Reviewed by Pavel Feldman.

Restore breakpoints associated with script's URL once
script is parsed.
​https://bugs.webkit.org/show_bug.cgi?id=38132

  • src/js/DebuggerAgent.js: (devtools.DebuggerAgent.prototype.initUI): (devtools.DebuggerAgent.prototype.addBreakpoint): (devtools.DebuggerAgent.prototype.addScriptInfo_): (devtools.DebuggerAgent.prototype.restoreBreakpoints_): (devtools.BreakpointInfo): (devtools.BreakpointInfo.prototype.enabled): (devtools.BreakpointInfo.prototype.condition):
7:48 AM Changeset in webkit [58311] by pfeldman@chromium.org
  • 3 edits in trunk/WebKit/chromium

2010-04-27 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Chrome Dev Tools: Further beautify themes.

​https://bugs.webkit.org/show_bug.cgi?id=38187

  • src/js/DevTools.js: (WebInspector.setToolbarColors):
  • src/js/devTools.css: (body.platform-windows #toolbar, body.platform-windows.inactive #toolbar):
7:27 AM Changeset in webkit [58310] by Simon Hausmann
  • 2 edits in trunk/WebCore

[Qt] Fix linking on Symbian on Linux using the Makefile based mkspec.

Patch by Thomas Zander <​t.zander@nokia.com> on 2010-04-27
Reviewed by Simon Hausmann.

Disable thumb mode due to library size limitations, just like it's done
for the sbs/sbsv2 based build system.

  • WebCore.pro:
7:24 AM Changeset in webkit [58309] by Simon Hausmann
  • 2 edits in trunk/JavaScriptCore

[Qt] Fix the build on Symbian on Linux using the Makefile based mkspec

Patch by Thomas Zander <​t.zander@nokia.com> on 2010-04-27
Reviewed by Simon Hausmann.

  • JavaScriptCore.pri: It is necessary to specify the library search path

when linking against JavaScriptCore.

6:56 AM Changeset in webkit [58308] by jocelyn.turcotte@nokia.com
  • 4 edits in trunk/JavaScriptCore

Compile fix for Visual Studio 2010
​https://bugs.webkit.org/show_bug.cgi?id=37867

Reviewed by Simon Hausmann.

Patch by Prasanth Ullattil <​prasanth.ullattil@nokia.com>

  • runtime/Structure.cpp:

(JSC::Structure::transitionTableAdd):

  • wtf/MathExtras.h:
  • wtf/Platform.h:
6:56 AM Changeset in webkit [58307] by jocelyn.turcotte@nokia.com
  • 9 edits in trunk/JavaScriptCore

Rename COMPILER(MSVC7) to COMPILER(MSVC7_OR_LOWER)

Reviewed by Simon Hausmann.

  • config.h:

(JSC::Structure::transitionTableAdd):

  • wtf/Assertions.h:
  • wtf/Atomics.h:
  • wtf/CurrentTime.h:

(WTF::getLocalTime):

  • wtf/Platform.h:
  • wtf/StaticConstructors.h:
  • wtf/StringExtras.h:
  • wtf/Vector.h:

(WTF::::append):

6:55 AM Changeset in webkit [58306] by jocelyn.turcotte@nokia.com
  • 3 edits in trunk/JavaScriptCore

[Qt] Fix Mac build break.

Reviewed by Tor Arne Vestbø.

​https://bugs.webkit.org/show_bug.cgi?id=37867

  • Make sure JavaScriptCore's debug_and_release config follows that of WebCore.
  • Use different name for JavaScriptCore target in debug and release since they might be written in the same path at the same time on parallel builds
  • Consolidate the DESTDIR determination logic in JavaScriptCore.pri
6:55 AM Changeset in webkit [58305] by jocelyn.turcotte@nokia.com
  • 4 edits in trunk

[Qt] Make sure WebKit is not compiled using C++0x.
​https://bugs.webkit.org/show_bug.cgi?id=37867

Reviewed by Kenneth Rohde Christiansen.

As the rest of Qt compiles in the C++0x mode, people might start
compiling it in this mode. WebKit don't support this yet.

Patch by Thiago Macieira <​thiago.macieira@nokia.com>

JavaScriptCore:

WebCore:

  • WebCore.pro:
5:56 AM Changeset in webkit [58304] by jorlow@chromium.org
  • 2 edits in trunk/LayoutTests

2010-04-27 Jeremy Orlow <​jorlow@chromium.org>

Unreviewed. Previous disabling only did so via
TIMEOUT failures. Needs to ignore TEXT failures
on quota-tracking.html as well.

  • platform/chromium/test_expectations.txt:
5:05 AM Changeset in webkit [58303] by jorlow@chromium.org
  • 2 edits in trunk/LayoutTests

2010-04-27 Jeremy Orlow <​jorlow@chromium.org>

Unreviewed. Disable quota-tracking in Chromium
until Dumi can take a look.

  • platform/chromium/test_expectations.txt:
4:18 AM Changeset in webkit [58302] by jorlow@chromium.org
  • 10 edits in trunk

2010-04-27 Jeremy Orlow <​jorlow@chromium.org>

Unreviewed build fix.

Revert 58274 and 58269 (WebSQLDatabase changes)
​https://bugs.webkit.org/show_bug.cgi?id=38191

  • storage/quota-tracking-expected.txt:
  • storage/quota-tracking.html:

2010-04-27 Jeremy Orlow <​jorlow@chromium.org>

Unreviewed build fix.

Revert 58274 and 58269 (WebSQLDatabase changes)
​https://bugs.webkit.org/show_bug.cgi?id=38191

Chromium bots are hitting ASSERTS when running layout tests.

  • platform/sql/SQLiteDatabase.cpp: (WebCore::SQLiteDatabase::maximumSize): (WebCore::SQLiteDatabase::freeSpaceSize):
  • platform/sql/SQLiteDatabase.h:
  • platform/sql/SQLiteStatement.cpp: (WebCore::SQLiteStatement::prepare):
  • storage/Database.cpp: (WebCore::Database::performOpenAndVerify):
  • storage/Database.h:
  • storage/SQLTransaction.cpp: (WebCore::SQLTransaction::postflightAndCommit):
3:54 AM Changeset in webkit [58301] by yuzo@google.com
  • 8 edits
    2 deletes in trunk

2010-04-27 Yuzo Fujishima <​yuzo@google.com>

Unreviewed, fix build breakage by reverting r58299.

​https://bugs.webkit.org/show_bug.cgi?id=35329

  • fast/css/parsing-page-rule-expected.txt: Removed.
  • fast/css/parsing-page-rule.html: Removed.

2010-04-27 Yuzo Fujishima <​yuzo@google.com>

Unreviewed, fix build breakage by reverting r58299.

  • css/CSSGrammar.y:
  • css/CSSParser.cpp: (WebCore::CSSParser::CSSParser): (WebCore::CSSParser::clearProperties):
  • css/CSSParser.h:
  • css/CSSSelector.cpp: (WebCore::CSSSelector::pseudoId): (WebCore::nameToPseudoTypeMap): (WebCore::CSSSelector::extractPseudoType):
  • css/CSSSelector.h: (WebCore::CSSSelector::):
  • css/tokenizer.flex:
2:53 AM Changeset in webkit [58300] by yuzo@google.com
  • 2 edits in trunk/WebCore

2010-04-27 Yuzo Fujishima <​yuzo@google.com>

Reviewed by Shinichiro Hamaji.

WebCore::CSSSelector::RareData::parseNth doesn't check whether the search for '-' in the argument was successful.
This results in incorrect parsing.
For example, '3n' is parsed as if it were '3n-3'. The code has been working OK just accidentally.

​https://bugs.webkit.org/show_bug.cgi?id=37787

No new tests are added because the original behavior is accidentally OK.

  • css/CSSSelector.cpp: (WebCore::CSSSelector::RareData::parseNth):
2:38 AM QtWebKitTableOfFeatures20 edited by Henry Haverinen
(diff)
2:35 AM Changeset in webkit [58299] by yuzo@google.com
  • 8 edits
    2 adds in trunk

2010-04-27 Yuzo Fujishima <​yuzo@google.com>

Reviewed by David Hyatt.

Enhance CSS parser for Paged Media (Iteration 1)

In this change, the grammar is extended and skeletal methods for creating page rules and margin at-rules are defined.
The contents of the methods should be implemented by other changes.

​https://bugs.webkit.org/show_bug.cgi?id=35329

  • fast/css/parsing-page-rule-expected.txt: Copied from LayoutTests/editing/selection/doubleclick-whitespace-img-crash-expected.txt.
  • fast/css/parsing-page-rule.html: Added.

2010-04-27 Yuzo Fujishima <​yuzo@google.com>

Reviewed by David Hyatt.

Enhance CSS parser for Paged Media (Iteration 1)

In this change, the grammar is extended and skeletal methods for creating page rules and margin at-rules are defined.
The contents of the methods should be implemented by other changes.

​https://bugs.webkit.org/show_bug.cgi?id=35329

Test: fast/css/parsing-page-rule.html

  • css/CSSGrammar.y:
  • css/CSSParser.cpp: (WebCore::CSSParser::CSSParser): (WebCore::CSSParser::clearProperties): (WebCore::CSSParser::lex): (WebCore::CSSParser::text): (WebCore::CSSParser::createPageRule): (WebCore::CSSParser::createMarginAtRule): (WebCore::CSSParser::startDeclarationsForMarginBox): (WebCore::CSSParser::endDeclarationsForMarginBox):
  • css/CSSParser.h:
  • css/CSSSelector.cpp: (WebCore::CSSSelector::extractPseudoType):
  • css/CSSSelector.h: (WebCore::CSSSelector::):
  • css/tokenizer.flex:
2:32 AM QtWebKitTableOfFeatures20 edited by Henry Haverinen
(diff)
2:29 AM QtWebKitTableOfFeatures20 edited by Henry Haverinen
(diff)
2:27 AM QtWebKitTableOfFeatures20 edited by Henry Haverinen
(diff)
2:26 AM QtWebKitTableOfFeatures20 edited by Henry Haverinen
(diff)
2:12 AM Changeset in webkit [58298] by abarth@webkit.org
  • 14 edits
    1 delete in trunk/WebCore

2010-04-27 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Remove custom bindings for TreeWalker
​https://bugs.webkit.org/show_bug.cgi?id=38182

This custom code is just CallWith=ScriptState.

  • WebCore.gypi:
  • bindings/js/JSTreeWalkerCustom.cpp: (WebCore::JSTreeWalker::markChildren):
  • bindings/scripts/CodeGeneratorJS.pm:
  • bindings/scripts/CodeGeneratorV8.pm:
  • bindings/scripts/test/TestObj.idl:
  • bindings/v8/custom/V8TreeWalkerCustom.cpp: Removed.
  • dom/TreeWalker.idl:
2:10 AM Changeset in webkit [58297] by abarth@webkit.org
  • 3 edits in trunk/WebKitTools

2010-04-27 Adam Barth <​abarth@webkit.org>

Reviewed by Maciej Stachowiak.

REGRESSION(r58261): webkit-patch upload does not work in an SVN checkout.
​https://bugs.webkit.org/show_bug.cgi?id=38186

Unfortunately, we don't have a good way of testing this change because
our test coverage of the scm.py API is poor...

  • Scripts/webkitpy/common/checkout/scm.py:
  • Scripts/webkitpy/tool/steps/preparechangelog.py:
1:44 AM QtWebKitTableOfFeatures20 edited by Henry Haverinen
(diff)
1:02 AM Changeset in webkit [58296] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-04-27 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Move code out of GenerateImplementation to make it more smaller
​https://bugs.webkit.org/show_bug.cgi?id=38176

  • bindings/scripts/CodeGeneratorJS.pm:
    • Move some code into a new GenerateAttributesHashTable method.
12:15 AM Changeset in webkit [58295] by abarth@webkit.org
  • 14 edits in trunk/WebCore

2010-04-26 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Add CallWith=DynamicFrame to CodeGenerator
​https://bugs.webkit.org/show_bug.cgi?id=38174

I've only used this in one instance, but this is infrastructure that I
think will help remove a bunch of custom bindings code. Also, added a
few tests of tricky argument cases.

  • bindings/js/JSHTMLFormElementCustom.cpp:
  • bindings/scripts/CodeGeneratorJS.pm:
  • bindings/scripts/CodeGeneratorV8.pm:
  • bindings/scripts/test/GObject/WebKitDOMTestObj.cpp: (webkit_dom_test_obj_with_dynamic_frame): (webkit_dom_test_obj_with_dynamic_frame_and_arg): (webkit_dom_test_obj_with_dynamic_frame_and_optional_arg): (webkit_dom_test_obj_with_dynamic_frame_and_user_gesture): (webkit_dom_test_obj_with_dynamic_frame_and_user_gesture_asad):
  • bindings/scripts/test/GObject/WebKitDOMTestObj.h:
  • bindings/scripts/test/JS/JSTestObj.cpp: (WebCore::): (WebCore::jsTestObjPrototypeFunctionWithDynamicFrame): (WebCore::jsTestObjPrototypeFunctionWithDynamicFrameAndArg): (WebCore::jsTestObjPrototypeFunctionWithDynamicFrameAndOptionalArg): (WebCore::jsTestObjPrototypeFunctionWithDynamicFrameAndUserGesture): (WebCore::jsTestObjPrototypeFunctionWithDynamicFrameAndUserGestureASAD):
  • bindings/scripts/test/JS/JSTestObj.h:
  • bindings/scripts/test/ObjC/DOMTestObj.h:
  • bindings/scripts/test/ObjC/DOMTestObj.mm: (-[DOMTestObj withDynamicFrame]): (-[DOMTestObj withDynamicFrameAndArg:]): (-[DOMTestObj withDynamicFrameAndOptionalArg:optionalArg:]): (-[DOMTestObj withDynamicFrameAndUserGesture:]): (-[DOMTestObj withDynamicFrameAndUserGestureASAD:optionalArg:]):
  • bindings/scripts/test/TestObj.idl:
  • bindings/scripts/test/V8/V8TestObj.cpp: (WebCore::TestObjInternal::withDynamicFrameCallback): (WebCore::TestObjInternal::withDynamicFrameAndArgCallback): (WebCore::TestObjInternal::withDynamicFrameAndOptionalArgCallback): (WebCore::TestObjInternal::withDynamicFrameAndUserGestureCallback): (WebCore::TestObjInternal::withDynamicFrameAndUserGestureASADCallback): (WebCore::):
  • bindings/v8/custom/V8HTMLFormElementCustom.cpp:
  • html/HTMLFormElement.idl:

Apr 26, 2010:

11:28 PM Changeset in webkit [58294] by jam@chromium.org
  • 3 edits
    1 add in trunk/WebKit/chromium

2010-04-26 John Abd-El-Malek <​jam@chromium.org>

Reviewed by Darin Fisher.

[chromium] Prepare to making WebThemeEngine cross-platform
​https://bugs.webkit.org/show_bug.cgi?id=38077

  • WebKit.gyp:
  • public/WebThemeEngine.h: Added.
  • public/win/WebThemeEngine.h:
11:19 PM Changeset in webkit [58293] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2010-04-26 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Remove unused code from text_diff.py
​https://bugs.webkit.org/show_bug.cgi?id=38170

  • Scripts/webkitpy/layout_tests/test_types/text_diff.py:
    • Remove is_render_tree_dump which appears unused.
11:10 PM Changeset in webkit [58292] by darin@chromium.org
  • 2 edits in trunk/WebKit/chromium

2010-04-26 Darin Fisher <​darin@chromium.org>

Reviewed by Adam Barth.

[Chromium] Crash after calling window.print() on a window object that has been closed.
​https://bugs.webkit.org/show_bug.cgi?id=38148

It is unfortunately not possible to write a layout test for this as the
crash occurs in an API that is only called by Chrome while showing a
print dialog.

  • src/WebViewImpl.cpp: (WebKit::WebView::willEnterModalLoop): (WebKit::WebView::didExitModalLoop):
10:56 PM Changeset in webkit [58291] by abarth@webkit.org
  • 2 edits in trunk/WebKitTools

2010-04-26 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

webkit-patch pretty-diff is broken
​https://bugs.webkit.org/show_bug.cgi?id=38172

We need to register for these options because they're used when we look
up the diff.

  • Scripts/webkitpy/tool/steps/confirmdiff.py:
10:30 PM Changeset in webkit [58290] by abarth@webkit.org
  • 2 edits in trunk/WebCore

2010-04-26 Adam Barth <​abarth@webkit.org>

Unreviewed. Update comment to better reflect reality.

  • bindings/scripts/test/TestObj.idl:
10:01 PM Changeset in webkit [58289] by abarth@webkit.org
  • 3 edits
    8 adds in trunk

2010-04-26 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Add ObjC and GObject to run-bindings-test
​https://bugs.webkit.org/show_bug.cgi?id=38168

Added expected results.

  • bindings/scripts/test/GObject/WebKitDOMTestObj.cpp: Added. (WebKit::kit): (webkit_dom_test_obj_void_method): (webkit_dom_test_obj_void_method_with_args): (webkit_dom_test_obj_int_method): (webkit_dom_test_obj_int_method_with_args): (webkit_dom_test_obj_obj_method): (webkit_dom_test_obj_obj_method_with_args): (webkit_dom_test_obj_method_with_exception): (webkit_dom_test_obj_method_with_optional_arg): (webkit_dom_test_obj_method_with_non_optional_arg_and_optional_arg): (webkit_dom_test_obj_method_with_non_optional_arg_and_two_optional_args): (webkit_dom_test_obj_get_read_only_int_attr): (webkit_dom_test_obj_get_read_only_string_attr): (webkit_dom_test_obj_get_read_only_test_obj_attr): (webkit_dom_test_obj_get_int_attr): (webkit_dom_test_obj_set_int_attr): (webkit_dom_test_obj_get_string_attr): (webkit_dom_test_obj_set_string_attr): (webkit_dom_test_obj_get_test_obj_attr): (webkit_dom_test_obj_set_test_obj_attr): (webkit_dom_test_obj_get_attr_with_exception): (webkit_dom_test_obj_set_attr_with_exception): (webkit_dom_test_obj_get_attr_with_setter_exception): (webkit_dom_test_obj_set_attr_with_setter_exception): (webkit_dom_test_obj_get_attr_with_getter_exception): (webkit_dom_test_obj_set_attr_with_getter_exception): (WebKit::wrapTestObj): (WebKit::core): (webkit_dom_test_obj_finalize): (webkit_dom_test_obj_set_property): (webkit_dom_test_obj_get_property): (webkit_dom_test_obj_class_init): (webkit_dom_test_obj_init):
  • bindings/scripts/test/GObject/WebKitDOMTestObj.h: Added.
  • bindings/scripts/test/GObject/WebKitDOMTestObjPrivate.h: Added.
  • bindings/scripts/test/ObjC/DOMTestObj.h: Added.
  • bindings/scripts/test/ObjC/DOMTestObj.mm: Added. (-[DOMTestObj dealloc]): (-[DOMTestObj finalize]): (-[DOMTestObj readOnlyIntAttr]): (-[DOMTestObj readOnlyStringAttr]): (-[DOMTestObj readOnlyTestObjAttr]): (-[DOMTestObj intAttr]): (-[DOMTestObj setIntAttr:]): (-[DOMTestObj stringAttr]): (-[DOMTestObj setStringAttr:]): (-[DOMTestObj testObjAttr]): (-[DOMTestObj setTestObjAttr:]): (-[DOMTestObj attrWithException]): (-[DOMTestObj setAttrWithException:]): (-[DOMTestObj attrWithSetterException]): (-[DOMTestObj setAttrWithSetterException:]): (-[DOMTestObj attrWithGetterException]): (-[DOMTestObj setAttrWithGetterException:]): (-[DOMTestObj customAttr]): (-[DOMTestObj setCustomAttr:]): (-[DOMTestObj voidMethod]): (-[DOMTestObj voidMethodWithArgs:strArg:objArg:]): (-[DOMTestObj intMethod]): (-[DOMTestObj intMethodWithArgs:strArg:objArg:]): (-[DOMTestObj objMethod]): (-[DOMTestObj objMethodWithArgs:strArg:objArg:]): (-[DOMTestObj methodWithException]): (-[DOMTestObj customMethod]): (-[DOMTestObj customMethodWithArgs:strArg:objArg:]): (-[DOMTestObj methodWithOptionalArg:]): (-[DOMTestObj methodWithNonOptionalArgAndOptionalArg:opt:]): (-[DOMTestObj methodWithNonOptionalArgAndTwoOptionalArgs:opt1:opt2:]): (core): (kit):
  • bindings/scripts/test/ObjC/DOMTestObjInternal.h: Added.

2010-04-26 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Add ObjC and GObject to run-bindings-test
​https://bugs.webkit.org/show_bug.cgi?id=38168

  • Scripts/run-bindings-tests:
9:49 PM Changeset in webkit [58288] by abarth@webkit.org
  • 4 edits
    2 moves
    4 adds in trunk

2010-04-26 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Add testing infrastructure for JSC bindings generator
​https://bugs.webkit.org/show_bug.cgi?id=38167

This required moving the test files around a bit more.

  • bindings/scripts/test/JS/JSTestObj.cpp: Added. (WebCore::): (WebCore::JSTestObjConstructor::JSTestObjConstructor): (WebCore::JSTestObjConstructor::classInfo): (WebCore::JSTestObjConstructor::createStructure): (WebCore::JSTestObjConstructor::getOwnPropertySlot): (WebCore::JSTestObjConstructor::getOwnPropertyDescriptor): (WebCore::JSTestObjPrototype::self): (WebCore::JSTestObjPrototype::getOwnPropertySlot): (WebCore::JSTestObjPrototype::getOwnPropertyDescriptor): (WebCore::JSTestObj::JSTestObj): (WebCore::JSTestObj::~JSTestObj): (WebCore::JSTestObj::createPrototype): (WebCore::JSTestObj::getOwnPropertySlot): (WebCore::JSTestObj::getOwnPropertyDescriptor): (WebCore::jsTestObjReadOnlyIntAttr): (WebCore::jsTestObjReadOnlyStringAttr): (WebCore::jsTestObjReadOnlyTestObjAttr): (WebCore::jsTestObjIntAttr): (WebCore::jsTestObjStringAttr): (WebCore::jsTestObjTestObjAttr): (WebCore::jsTestObjAttrWithException): (WebCore::jsTestObjAttrWithSetterException): (WebCore::jsTestObjAttrWithGetterException): (WebCore::jsTestObjCustomAttr): (WebCore::jsTestObjConstructor): (WebCore::JSTestObj::put): (WebCore::setJSTestObjIntAttr): (WebCore::setJSTestObjStringAttr): (WebCore::setJSTestObjTestObjAttr): (WebCore::setJSTestObjAttrWithException): (WebCore::setJSTestObjAttrWithSetterException): (WebCore::setJSTestObjAttrWithGetterException): (WebCore::setJSTestObjCustomAttr): (WebCore::JSTestObj::getConstructor): (WebCore::jsTestObjPrototypeFunctionVoidMethod): (WebCore::jsTestObjPrototypeFunctionVoidMethodWithArgs): (WebCore::jsTestObjPrototypeFunctionIntMethod): (WebCore::jsTestObjPrototypeFunctionIntMethodWithArgs): (WebCore::jsTestObjPrototypeFunctionObjMethod): (WebCore::jsTestObjPrototypeFunctionObjMethodWithArgs): (WebCore::jsTestObjPrototypeFunctionMethodWithException): (WebCore::jsTestObjPrototypeFunctionCustomMethod): (WebCore::jsTestObjPrototypeFunctionCustomMethodWithArgs): (WebCore::jsTestObjPrototypeFunctionMethodWithOptionalArg): (WebCore::jsTestObjPrototypeFunctionMethodWithNonOptionalArgAndOptionalArg): (WebCore::jsTestObjPrototypeFunctionMethodWithNonOptionalArgAndTwoOptionalArgs): (WebCore::toJS): (WebCore::toTestObj):
  • bindings/scripts/test/JS/JSTestObj.h: Added. (WebCore::JSTestObj::classInfo): (WebCore::JSTestObj::createStructure): (WebCore::JSTestObj::impl): (WebCore::JSTestObjPrototype::classInfo): (WebCore::JSTestObjPrototype::createStructure): (WebCore::JSTestObjPrototype::JSTestObjPrototype):
  • bindings/scripts/test/TestObj.idl:
  • bindings/scripts/test/V8/V8TestObj.cpp: Renamed from WebCore/bindings/scripts/test/V8TestObj.cpp. (WebCore::): (WebCore::TestObjInternal::V8_USE): (WebCore::TestObjInternal::readOnlyIntAttrAttrGetter): (WebCore::TestObjInternal::readOnlyStringAttrAttrGetter): (WebCore::TestObjInternal::readOnlyTestObjAttrAttrGetter): (WebCore::TestObjInternal::intAttrAttrGetter): (WebCore::TestObjInternal::intAttrAttrSetter): (WebCore::TestObjInternal::stringAttrAttrGetter): (WebCore::TestObjInternal::stringAttrAttrSetter): (WebCore::TestObjInternal::testObjAttrAttrGetter): (WebCore::TestObjInternal::testObjAttrAttrSetter): (WebCore::TestObjInternal::attrWithExceptionAttrGetter): (WebCore::TestObjInternal::attrWithExceptionAttrSetter): (WebCore::TestObjInternal::attrWithSetterExceptionAttrGetter): (WebCore::TestObjInternal::attrWithSetterExceptionAttrSetter): (WebCore::TestObjInternal::attrWithGetterExceptionAttrGetter): (WebCore::TestObjInternal::attrWithGetterExceptionAttrSetter): (WebCore::TestObjInternal::voidMethodCallback): (WebCore::TestObjInternal::voidMethodWithArgsCallback): (WebCore::TestObjInternal::intMethodCallback): (WebCore::TestObjInternal::intMethodWithArgsCallback): (WebCore::TestObjInternal::objMethodCallback): (WebCore::TestObjInternal::objMethodWithArgsCallback): (WebCore::TestObjInternal::methodWithExceptionCallback): (WebCore::TestObjInternal::methodWithOptionalArgCallback): (WebCore::TestObjInternal::methodWithNonOptionalArgAndOptionalArgCallback): (WebCore::TestObjInternal::methodWithNonOptionalArgAndTwoOptionalArgsCallback): (WebCore::TestObjInternal::overloadedMethod1Callback): (WebCore::TestObjInternal::overloadedMethod2Callback): (WebCore::TestObjInternal::overloadedMethod3Callback): (WebCore::TestObjInternal::overloadedMethod4Callback): (WebCore::TestObjInternal::overloadedMethodCallback): (WebCore::ConfigureV8TestObjTemplate): (WebCore::V8TestObj::GetRawTemplate): (WebCore::V8TestObj::GetTemplate): (WebCore::V8TestObj::toNative): (WebCore::V8TestObj::HasInstance): (WebCore::V8TestObj::wrap): (WebCore::toV8): (WebCore::V8TestObj::derefObject):
  • bindings/scripts/test/V8/V8TestObj.h: Renamed from WebCore/bindings/scripts/test/V8TestObj.h.

2010-04-26 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Add testing infrastructure for JSC bindings generator
​https://bugs.webkit.org/show_bug.cgi?id=38167

Add support for testing more than one bindings. Also, converted the
script to PEP8 style.

  • Scripts/run-bindings-tests:
9:39 PM Changeset in webkit [58287] by oliver@apple.com
  • 2 edits in trunk/JavaScriptCore

Fix windows

9:22 PM Changeset in webkit [58286] by oliver@apple.com
  • 21 edits
    3 adds in trunk

2010-04-26 Oliver Hunt <​oliver@apple.com>

Reviewed by Gavin Barraclough.

Need to support more efficient dispatch of lightweight builtins
​https://bugs.webkit.org/show_bug.cgi?id=38155

The problem with calling lightweight builtins is that marshalling
the call from the nitro calling convention to the system calling
convention is very expensive relative to the cost of the actually
evaluating the function. To work around this problem this patch
adds the ability to define a custom thunk for a builtin.

This allows us to use high performance custom implementations of
the common and sensible versions of simple builtins. This patch
includes a simple (use of which is currently hardcoded) thunk for
charCodeAt.

This adds a JSInterfaceJIT subclass called SpecializedThunkJIT
that has helper functions to remove (or at least reduce) the need
to have separate thunk implementations for each JSValue encoding.

  • create_hash_table: Add thunk generation callbacks to the hash tables, currently we hardcode the script to only support charCodeAt
  • jit/JITStubCall.h:
  • jit/JITStubs.cpp: (JSC::JITThunks::~JITThunks): (JSC::JITThunks::specializedThunk):
  • jit/JITStubs.h:
  • jit/SpecializedThunkJIT.h: Added. (JSC::SpecializedThunkJIT::SpecializedThunkJIT): (JSC::SpecializedThunkJIT::loadCellArgument): (JSC::SpecializedThunkJIT::loadJSStringArgument): (JSC::SpecializedThunkJIT::loadInt32Argument): (JSC::SpecializedThunkJIT::appendFailure): (JSC::SpecializedThunkJIT::returnInt32): (JSC::SpecializedThunkJIT::finalize): (JSC::SpecializedThunkJIT::argumentToVirtualRegister): (JSC::SpecializedThunkJIT::tagReturnAsInt32):
  • jit/ThunkGenerators.cpp: Added. (JSC::ThunkHelpers::stringImplDataOffset): (JSC::ThunkHelpers::jsStringLengthOffset): (JSC::ThunkHelpers::jsStringValueOffset): (JSC::charCodeAtThunkGenerator):
  • jit/ThunkGenerators.h: Added.
  • runtime/Executable.h: (JSC::NativeExecutable::NativeExecutable):
  • runtime/JSFunction.cpp: (JSC::JSFunction::JSFunction):
  • runtime/JSFunction.h:
  • runtime/JSGlobalData.h: (JSC::JSGlobalData::getThunk):
  • runtime/JSString.h: (JSC::):
  • runtime/JSValue.h: Protect some of the JSVALUE32 and JSVALUE32_64 only constants and function behind appropriate USE() guards to make it harder to use the wrong flags for the target build.
  • runtime/Lookup.cpp: (JSC::HashTable::createTable): (JSC::setUpStaticFunctionSlot):
  • runtime/Lookup.h: (JSC::HashEntry::initialize): (JSC::HashEntry::generator): (JSC::HashEntry::): Make the lookup tables use a specialized thunkGenerator if present
  • wtf/text/StringImpl.h:

2010-04-26 Oliver Hunt <​oliver@apple.com>

Reviewed by Gavin Barraclough.

Need to support more efficient dispatch of lightweight builtins
​https://bugs.webkit.org/show_bug.cgi?id=38155

Update bindings generation to include new thunk generator field
in the property map hash tables.

  • bindings/scripts/CodeGeneratorJS.pm:
9:21 PM Changeset in webkit [58285] by eric@webkit.org
  • 3 edits in trunk/WebKitTools

2010-04-26 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Refactor results.html generation out into a new method and test it
​https://bugs.webkit.org/show_bug.cgi?id=38164

Hopefully this results in no change in functionality.

  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
9:12 PM Changeset in webkit [58284] by oliver@apple.com
  • 3 edits in trunk/JavaScriptCore

Build fix

8:45 PM Changeset in webkit [58283] by oliver@apple.com
  • 4 edits
    1 add in trunk/JavaScriptCore

2010-04-26 Oliver Hunt <​oliver@apple.com>

Reviewed by Gavin Barraclough.

Factor some basic JS interface logic out of JIT and into a superclass
​https://bugs.webkit.org/show_bug.cgi?id=38163

Create JSInterfaceJIT to hold some common low level functions for
interacting with the JS RegisterFile. Doing this separately from
​https://bugs.webkit.org/show_bug.cgi?id=38155 to ease reviewing.

  • JavaScriptCore.xcodeproj/project.pbxproj:
  • jit/JIT.h:
  • jit/JITInlineMethods.h: (JSC::JIT::emitJumpSlowCaseIfNotJSCell):
  • jit/JSInterfaceJIT.h: Added. (JSC::JSInterfaceJIT::emitLoadJSCell): (JSC::JSInterfaceJIT::emitJumpIfNotJSCell): (JSC::JSInterfaceJIT::emitLoadInt32): (JSC::JSInterfaceJIT::tagFor): (JSC::JSInterfaceJIT::payloadFor): (JSC::JSInterfaceJIT::addressFor):
8:36 PM Changeset in webkit [58282] by abarth@webkit.org
  • 2 edits in trunk/WebKitTools

2010-04-26 Adam Barth <​abarth@webkit.org>

Unreviewed, rolling out r58265.
​http://trac.webkit.org/changeset/58265
​https://bugs.webkit.org/show_bug.cgi?id=38021

This change prevents me from uploading patches. It also breaks sheriff-bot.

  • Scripts/webkitpy/tool/steps/options.py:
8:35 PM Changeset in webkit [58281] by abarth@webkit.org
  • 3 edits
    3 moves
    1 add in trunk

2010-04-26 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Move bindings test directory into the scripts directory
​https://bugs.webkit.org/show_bug.cgi?id=38161

This test is really of the bindings scripts not of the bindings
themselves. By moving the files into the scripts directory, we'll be
able to test JSC as well.

  • bindings/scripts/test/TestObj.idl: Renamed from WebCore/bindings/v8/test/TestObj.idl.
  • bindings/scripts/test/V8TestObj.cpp: Renamed from WebCore/bindings/v8/test/V8TestObj.cpp. (WebCore::): (WebCore::TestObjInternal::V8_USE): (WebCore::TestObjInternal::readOnlyIntAttrAttrGetter): (WebCore::TestObjInternal::readOnlyStringAttrAttrGetter): (WebCore::TestObjInternal::readOnlyTestObjAttrAttrGetter): (WebCore::TestObjInternal::intAttrAttrGetter): (WebCore::TestObjInternal::intAttrAttrSetter): (WebCore::TestObjInternal::stringAttrAttrGetter): (WebCore::TestObjInternal::stringAttrAttrSetter): (WebCore::TestObjInternal::testObjAttrAttrGetter): (WebCore::TestObjInternal::testObjAttrAttrSetter): (WebCore::TestObjInternal::attrWithExceptionAttrGetter): (WebCore::TestObjInternal::attrWithExceptionAttrSetter): (WebCore::TestObjInternal::attrWithSetterExceptionAttrGetter): (WebCore::TestObjInternal::attrWithSetterExceptionAttrSetter): (WebCore::TestObjInternal::attrWithGetterExceptionAttrGetter): (WebCore::TestObjInternal::attrWithGetterExceptionAttrSetter): (WebCore::TestObjInternal::voidMethodCallback): (WebCore::TestObjInternal::voidMethodWithArgsCallback): (WebCore::TestObjInternal::intMethodCallback): (WebCore::TestObjInternal::intMethodWithArgsCallback): (WebCore::TestObjInternal::objMethodCallback): (WebCore::TestObjInternal::objMethodWithArgsCallback): (WebCore::TestObjInternal::methodWithExceptionCallback): (WebCore::TestObjInternal::methodWithOptionalArgCallback): (WebCore::TestObjInternal::methodWithNonOptionalArgAndOptionalArgCallback): (WebCore::TestObjInternal::methodWithNonOptionalArgAndTwoOptionalArgsCallback): (WebCore::TestObjInternal::overloadedMethod1Callback): (WebCore::TestObjInternal::overloadedMethod2Callback): (WebCore::TestObjInternal::overloadedMethod3Callback): (WebCore::TestObjInternal::overloadedMethod4Callback): (WebCore::TestObjInternal::overloadedMethodCallback): (WebCore::ConfigureV8TestObjTemplate): (WebCore::V8TestObj::GetRawTemplate): (WebCore::V8TestObj::GetTemplate): (WebCore::V8TestObj::toNative): (WebCore::V8TestObj::HasInstance): (WebCore::V8TestObj::wrap): (WebCore::toV8): (WebCore::V8TestObj::derefObject):
  • bindings/scripts/test/V8TestObj.h: Renamed from WebCore/bindings/v8/test/V8TestObj.h.

2010-04-26 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Move bindings test directory into the scripts directory
​https://bugs.webkit.org/show_bug.cgi?id=38161

Change script to point to the new location of these data files.

  • Scripts/run-bindings-tests:
8:07 PM Changeset in webkit [58280] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-04-26 Daniel Cheng <​dcheng@chromium.org>

Reviewed by Jian Li.

[chromium] Fix ChromiumDataObject::setURL to not populate its internal URL list with empty URLs.
​https://bugs.webkit.org/show_bug.cgi?id=38159

No new tests.

  • platform/chromium/ChromiumDataObject.h: (WebCore::ChromiumDataObject::setURL):
7:33 PM Changeset in webkit [58279] by eric@webkit.org
  • 10 edits
    2 adds in trunk/WebKitTools

2010-04-26 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

[chromium] new-run-webkit-tests hangs on Chromium Bots (OS X and Linux)
​https://bugs.webkit.org/show_bug.cgi?id=37987

Rolled out:
​http://trac.webkit.org/changeset/58062
​http://trac.webkit.org/changeset/58060
​http://trac.webkit.org/changeset/58059
​http://trac.webkit.org/changeset/58055
​http://trac.webkit.org/changeset/58054
and parts of:
​http://trac.webkit.org/changeset/58050

I also wrote some new comments and a tiny amount of new
code to help make ChromiumDriver.run_test easier to read.

In order to unit-test my new code, I had to change ChromiumDriver
to not automatically start itself when created. That ended up
being a lot of plumbing, but is hopefully easier to understand now.

There are no tests for the (restored) wdiff code. wdiff does not
exist on all systems, so for now we will assume it worked since
it is just old code being reverted.

  • Scripts/webkitpy/layout_tests/driver_test.py:
    • Use create_driver instead of start_driver, and be sure to call .stop()
  • Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
    • Use create_driver instead of start_driver
  • Scripts/webkitpy/layout_tests/port/base.py:
    • Added a comment to explain that diffs are binary files.
    • Various patch reverts relating to wdiff
    • Add Driver._command_wrapper to share code between WebKitDriver and ChromiumDriver.
    • Made _command_wrapper use shlex.split to get rid of the FIXME.
  • Scripts/webkitpy/layout_tests/port/base_unittest.py: Added.
    • test the new _command_wrapper
  • Scripts/webkitpy/layout_tests/port/chromium.py:
  • Use _command_wrapper to get rid of a bunch of ugly code.
  • Make init stop auto-starting.
  • Rename create_driver to start_driver.
  • Added _write_command_and_read_line to make it possible to put a FIXME next to read_line() w/o having to put it in two places.
  • Moved test_shell command building into _test_shell_command and tested it.
  • Fix comments to say test_shell since ChromiumDriver is test_shell only.
  • Scripts/webkitpy/layout_tests/port/chromium_unittest.py: Added.
    • Test the new test_shell_command method.
  • Scripts/webkitpy/layout_tests/port/dryrun.py:
    • Rename create_driver to start_driver.
  • Scripts/webkitpy/layout_tests/port/test.py:
    • Rename create_driver to start_driver.
  • Scripts/webkitpy/layout_tests/port/webkit.py:
    • Rename create_driver to start_driver.
    • Treat output as binary arrays.
  • Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
    • Treat diff files as binary.
  • Scripts/webkitpy/layout_tests/test_types/text_diff.py:
    • Treat diff files as binary.
7:22 PM Changeset in webkit [58278] by abarth@webkit.org
  • 2 edits in trunk/WebKitTools

2010-04-26 Adam Barth <​abarth@webkit.org>

Unreviewed. Mark run-bindings-tests executable so we can execute it.

  • Scripts/run-bindings-tests:
7:12 PM Changeset in webkit [58277] by yuzo@google.com
  • 1 edit
    1 move
    1 add
    1 delete in trunk/LayoutTests

2010-04-26 Yuzo Fujishima <​yuzo@google.com>

Unreviewed, Chromium test expectation change.

To keep up with the change that turned on HTML5 DB AUTO_VACUUM.
​https://bugs.webkit.org/show_bug.cgi?id=36251

  • platform/chromium-mac/storage/quota-tracking-expected.txt: Removed.
  • platform/chromium-win/storage/quota-tracking-expected.txt: Removed.
  • platform/chromium/storage/quota-tracking-expected.txt: Added.
6:32 PM Changeset in webkit [58276] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-04-26 Daniel Cheng <​dcheng@chromium.org>

Reviewed by Jian Li.

[Chromium] Don't make file paths available in text/uri-list when dragging files.
​https://bugs.webkit.org/show_bug.cgi?id=25882

Test will be checked in with WebCore/platform/mac fix.

  • platform/chromium/ClipboardChromium.cpp: (WebCore::ClipboardChromium::getData): (WebCore::ClipboardChromium::types):
6:26 PM Changeset in webkit [58275] by tony@chromium.org
  • 4 edits in trunk/WebKitTools

2010-04-26 Tony Chang <​tony@chromium.org>

Reviewed by David Levin.

[chromium] build-webkit --chromium should build release by default
​https://bugs.webkit.org/show_bug.cgi?id=38028

  • Scripts/build-dumprendertree: Also should build release by default
  • Scripts/build-webkit: Make sure to pass command line args through
  • Scripts/webkitdirs.pm: Build the right configuration
5:37 PM Changeset in webkit [58274] by dumi@chromium.org
  • 3 edits in trunk/LayoutTests

Unreviewed, fixing the build breakage introduced by r58269.

Turning on AUTO_VACUUM has increased the amount of space used by databases.

  • storage/quota-tracking-expected.txt:
  • storage/quota-tracking.html:
5:09 PM Changeset in webkit [58273] by mjs@apple.com
  • 9 edits in trunk/WebCore

2010-04-26 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Darin Adler.

REGRESSION (r57292): 1.5% page load speed regression from visited link information leak fix
​https://bugs.webkit.org/show_bug.cgi?id=38131

I did a number of separate optimizations which speed up style
resolution enough to more than make up for the regression. This
measures as a total PLT speedup of somewhere between 1.5% and
3.7%.


Optimizations done:

  • Cache determineLinkState results, to avoid the need to repeatedly compute the visited link hash for the same element. This directly addresses much of the slowdown, since all elements get their style computed twice now.
  • Added a fast way to get the length of a CSSMutableStyleDeclaration, and use in CSSStyleSelector::matchRulesForList, since it was hot there.
  • Hoist some loop invariant code that's not detected by the compiler out of the main loop in matchRulesForList
  • inline CSSStyleSelector::initElement and locateSharedStyle, since there is only one call site in each case
  • Inline the common non-line fast case of determineLinkState, and split the rest into out-of-line determineLinkStateSlowCase.
  • Added inline versions of the functions called by visitedLinkHash (the version called by determineLinkState).
  • css/CSSMutableStyleDeclaration.cpp: (WebCore::CSSMutableStyleDeclaration::length): Implemented in terms of new inline nonvirtual mutableLength().
  • css/CSSMutableStyleDeclaration.h: (WebCore::CSSMutableStyleDeclaration::mutableLength): Added new nonvirtual inline way to get the length if you know you have a mutable style decl.
  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::init): Clear cached link state. (WebCore::CSSStyleSelector::matchRulesForList): hoist some code out of the main loop and get style decl length more efficiently. (WebCore::CSSStyleSelector::initElement): inline (only one call site) (WebCore::CSSStyleSelector::SelectorChecker::determineLinkState): Inline fast case, call slow case. (WebCore::CSSStyleSelector::SelectorChecker::determineLinkStateSlowCase): Split most of the above function into this slow case helper. (WebCore::CSSStyleSelector::canShareStyleWithElement): Use the cache-enabled way to get the current link state. (WebCore::CSSStyleSelector::locateSharedStyle): inline (WebCore::CSSStyleSelector::styleForElement): Use the cache-enabled way to get the current link state.
  • css/CSSStyleSelector.h: (WebCore::CSSStyleSelector::currentElementLinkState): inline way to get link state for the current element; manages the cache
  • platform/LinkHash.cpp: (WebCore::visitedLinkHashInline): inline version of below function (WebCore::visitedLinkHash): call the inline version (WebCore::visitedURLInline): inline version of below function (WebCore::visitedURL): call the inline version (WebCore::visitedURL): call inline versions of above two functions
4:30 PM Changeset in webkit [58272] by weinig@apple.com
  • 2 edits in trunk/WebCore

Remove last use of WEB_THREAD.

Reviewed by Alexey Proskuryakov.

  • platform/mac/WebCoreObjCExtras.mm:

(WebCoreObjCScheduleDeallocateOnMainThread): This can always use
isMainThread().

4:10 PM Changeset in webkit [58271] by crogers@google.com
  • 2 adds in branches/audio/WebCore/audio

initial commit test

3:58 PM Changeset in webkit [58270] by dumi@chromium.org
  • 7 edits in trunk/WebCore

Turn on AUTO_VACUUM = INCREMENTAL for all HTML5 databases, and
vacuum all databases when the number of free pages is at least 10%
of the number of total pages. Also, adding a guard against a bug
that was fixed in SQLite only starting with version 3.6.16.

Reviewed by Dimitri Glazkov.

​https://bugs.webkit.org/show_bug.cgi?id=36251

  • platform/sql/SQLiteDatabase.cpp:

(WebCore::SQLiteDatabase::totalSize):
(WebCore::SQLiteDatabase::runIncrementalVacuumCommand):
(WebCore::SQLiteDatabase::turnOnIncrementalAutoVacuum):

  • platform/sql/SQLiteDatabase.h:
  • platform/sql/SQLiteStatement.cpp:

(WebCore::SQLiteStatement::prepare):

  • storage/Database.cpp:

(WebCore::Database::performOpenAndVerify):
(WebCore::Database::incrementalVacuumIfNeeded):

  • storage/Database.h:
  • storage/SQLTransaction.cpp:

(WebCore::SQLTransaction::postflightAndCommit):

3:45 PM Changeset in webkit [58269] by crogers@google.com
  • 1 copy in branches/audio

creating private audio branch to implement new audio features with javascript API

3:45 PM Changeset in webkit [58268] by weinig@apple.com
  • 2 edits in trunk/JavaScriptCore

Fix Tiger build.

  • wtf/mac/MainThreadMac.mm:

(WTF::isMainThread):

3:44 PM Changeset in webkit [58267] by ggaren@apple.com
  • 9 edits in trunk

<rdar://problem/7766413>

Reviewed by Sam Weinig.

Fixed a crash seen when using the JavaScriptCore API with WebKit.

No layout test because DumpRenderTree doesn't use the JavaScriptCore API
in this way.

JavaScriptCore:

  • interpreter/RegisterFile.cpp:

(JSC::RegisterFile::setGlobalObject):
(JSC::RegisterFile::clearGlobalObject):
(JSC::RegisterFile::globalObject):

  • interpreter/RegisterFile.h:

(JSC::RegisterFile::RegisterFile): Use WeakGCPtr for managing m_globalObject,
since it's a weak pointer. (We never noticed this error before because,
in WebKit, global objects always have a self-reference in a global variable,
so marking the register file's global variables would keep m_globalObject
alive. In the JavaScriptCore API, you can allocate a global object with
no self-reference.)

  • runtime/JSActivation.h: Removed unneeded #include.
  • runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::~JSGlobalObject): Don't use ==, since a weak
pointer is 0 when the object it points to runs its destructor.

  • runtime/WeakGCPtr.h:

(JSC::WeakGCPtr::clear): Changed to return a bool indicating whether the
clear actually happened.
(JSC::WeakGCPtr::assign): Changed to forbid assignment of 0 as a shorthand
for calling clear(). A client should never clear by assigning 0, since
clear() should be conditional on whether the object doing the clearing
is still pointed to by the weak pointer. (Otherwise, a zombie object might
clear a pointer to a new, valid object.)

WebCore:

  • bindings/js/JSEventListener.cpp:

(WebCore::JSEventListener::JSEventListener): Don't assign 0 to a WeakGCPtr.
JavaScriptCore no longer allows this.

  • bindings/js/ScriptWrappable.h:

(WebCore::ScriptWrappable::setWrapper): No need to initialize a WeakGCPtr
to 0, or ASSERT a non-0 value before assigning to a WeakGCPtr -- both are
default behaviors.

3:38 PM Changeset in webkit [58266] by weinig@apple.com
  • 56 edits in trunk

Fix for ​https://bugs.webkit.org/show_bug.cgi?id=38097
Disentangle initializing the main thread from initializing threading

Reviewed by Maciej Stachowiak.

JavaScriptCore:

This is the first step in getting rid of the WEB_THREAD #define and
paving the way to allowing mac both WebKit and WebKit2 to use the same
WebCore.

  • JavaScriptCore.exp: Export initializeMainThread and initializeMainThreadToProcessMainThread.
  • JavaScriptCore.xcodeproj/project.pbxproj: Sort files.
  • wtf/MainThread.cpp:

(WTF::mainThreadInitializationMutex):
(WTF::mainThreadFunctionQueueMutex):
(WTF::initializeMainThread):
(WTF::deprecatedInitializeMainThread):

  • wtf/MainThread.h:

Added Mac only initializeMainThreadToProcessMainThread which sets up callOnMainThread
and isMainThead calls to assume that WebCore's main thread is also the
process's main thread. Since it is possible that both initializeMainThread
and initializeMainThreadToProcessMainThread could be called, the first one called
wins (either will work).

  • wtf/Threading.h: Moved to top of file.
  • wtf/ThreadingPthreads.cpp:

(WTF::initializeThreading): Remove call to initializeMainThread.

  • wtf/ThreadingWin.cpp:

(WTF::initializeThreading): Ditto.

  • wtf/gtk/ThreadingGtk.cpp:

(WTF::initializeThreading): Ditto.

  • wtf/mac/MainThreadMac.mm:

(WTF::initializeMainThreadPlatform):
(WTF::initializeMainThreadToProcessMainThread):
(WTF::scheduleDispatchFunctionsOnMainThread):
(WTF::isMainThread):
Add runtime switch between the old behavior of using the system's main
thread and a stored pointer to the main thread. Tiger always uses the
system's main thread.

  • wtf/qt/ThreadingQt.cpp:

(WTF::initializeThreading): Remove call to initializeMainThread.

  • wtf/win/MainThreadWin.cpp:

(WTF::initializeMainThreadPlatform): Add call to initializeCurrentThreadInternal
removed from initializeThreading.

WebCore:

  • WebCore.xcodeproj/project.pbxproj: Sort files.
  • accessibility/mac/AccessibilityObjectWrapper.mm: Remove unnessary

+initialize method. The AccessibilityObjectWrapper has no data members
that need to be derefed, so it does not need to be finalized on the main
thread.

  • bindings/js/ScriptController.cpp:

(WebCore::ScriptController::initializeThreading): Add call to initializeMainThread.

  • bindings/objc/WebScriptObject.mm:

(+[WebScriptObject initialize]): Add call to initializeMainThreadToProcessMainThread.

  • bindings/v8/ScriptController.cpp:

(WebCore::ScriptController::initializeThreading): Add call to initializeMainThread.

  • platform/mac/SharedBufferMac.mm:

(+[WebCoreSharedBufferData initialize]): Add call to initializeMainThreadToProcessMainThread.

WebKit/chromium:

  • src/WebKit.cpp:

(WebKit::initialize): Add call to initializeMainThread.

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::WebViewImpl): Ditto.

WebKit/gtk:

  • webkit/webkitprivate.cpp:

(webkit_init): Add call to initializeMainThread.

WebKit/mac:

Calls initializeMainThreadToProcessMainThread since there is no way to ensure
that the initialize method will be called on the main thread.

  • Carbon/CarbonWindowAdapter.mm:

(+[CarbonWindowAdapter initialize]): Add call to initializeMainThreadToProcessMainThread.

  • History/WebBackForwardList.mm:

(+[WebBackForwardList initialize]): Ditto.

  • History/WebHistoryItem.mm:

(+[WebHistoryItem initialize]): Ditto.

  • Misc/WebElementDictionary.mm:

(+[WebElementDictionary initialize]): Ditto.

  • Misc/WebIconDatabase.mm:

(+[WebIconDatabase initialize]): Ditto.

  • Plugins/Hosted/WebHostedNetscapePluginView.mm:

(+[WebHostedNetscapePluginView initialize]): Ditto.

  • Plugins/WebBaseNetscapePluginView.mm:

(+[WebBaseNetscapePluginView initialize]): Ditto.

  • Plugins/WebBasePluginPackage.mm:

(+[WebBasePluginPackage initialize]): Ditto.

  • Plugins/WebNetscapePluginView.mm:

(+[WebNetscapePluginView initialize]): Ditto.

  • WebCoreSupport/WebEditorClient.mm:

(+[WebEditCommand initialize]): Ditto.

  • WebCoreSupport/WebFrameLoaderClient.mm:

(+[WebFramePolicyListener initialize]): Ditto.

  • WebView/WebArchive.mm:

(+[WebArchivePrivate initialize]): Ditto.

  • WebView/WebDataSource.mm:

(+[WebDataSourcePrivate initialize]): Ditto.

  • WebView/WebHTMLView.mm:

(+[WebHTMLViewPrivate initialize]): Ditto.
(+[WebHTMLView initialize]): Ditto.

  • WebView/WebResource.mm:

(+[WebResourcePrivate initialize]): Ditto.

  • WebView/WebTextIterator.mm:

(+[WebTextIteratorPrivate initialize]): Ditto.

  • WebView/WebView.mm:
  • WebView/WebViewData.mm: Ditto.

(+[WebViewPrivate initialize]): Ditto.

WebKit/qt:

  • Api/qwebpage.cpp:

(QWebPagePrivate::QWebPagePrivate): Add call to initializeMainThread.

WebKit/win:

  • WebKitClassFactory.cpp:

(WebKitClassFactory::WebKitClassFactory): Add call to initializeMainThread.

  • WebView.cpp:

(WebView::WebView): Ditto.

WebKit/wx:

  • WebView.cpp:

(wxWebView::Create): Add call to initializeMainThread.

WebKit2:

  • UIProcess/Launcher/mac/WebProcessLauncher.mm:

(WebKit::webThreadBody): Add call to initializeMainThread.

  • UIProcess/Launcher/win/WebProcessLauncher.cpp:

(WebKit::webThreadBody): Ditto.

  • WebProcess/Launching/mac/WebProcessMain.mm:

(main): Ditto.

  • WebProcess/win/WebProcessMain.cpp:

(WebKit::WebProcessMain): Ditto.

2:52 PM Changeset in webkit [58265] by ojan@chromium.org
  • 2 edits in trunk/WebKitTools

2010-04-26 Ojan Vafai <​ojan@chromium.org>

Reviewed by Eric Seidel.

complete rietveld bugzilla integration
​https://bugs.webkit.org/show_bug.cgi?id=38021

Makes --fancy-review the default. All this means is that the patch will
be uploaded to rietveld in addition to bugs.webkit.org.

  • Scripts/webkitpy/tool/steps/options.py:
2:43 PM Changeset in webkit [58264] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-04-26 Yongjun Zhang <​yongjun_zhang@apple.com>

Reviewed by Alexey Proskuryakov.

​https://bugs.webkit.org/show_bug.cgi?id=38128
Don't add empty credential to CredentialStorage.

An empty credential is currently regarded as a invalid login because it means a missing value in
protectionSpaceToCredentialMap. This change makes it consistent with current WebCore's behavior
by ignoring empty credentials.

No new tests added since this only affects credential entered by user from credential dialog,
which is not testable in DRT.

  • platform/network/mac/ResourceHandleMac.mm: (WebCore::ResourceHandle::receivedCredential):
2:01 PM Changeset in webkit [58263] by Chris Jerdonek
  • 3 edits
    1 move in trunk/WebKitTools

For check-webkit-style, renamed the style/processors/ directory
to style/checkers/.

Reviewed by Shinichiro Hamaji.

​https://bugs.webkit.org/show_bug.cgi?id=38122

  • Scripts/webkitpy/style/checker.py:
    • Updated import statements.
  • Scripts/webkitpy/style/checker_unittest.py:
    • Updated import statements.
  • Scripts/webkitpy/style/checkers: Copied from WebKitTools/Scripts/webkitpy/style/processors.
  • Scripts/webkitpy/style/processors: Removed.
  • Scripts/webkitpy/style/processors/init.py: Removed.
  • Scripts/webkitpy/style/processors/common.py: Removed.
  • Scripts/webkitpy/style/processors/common_unittest.py: Removed.
  • Scripts/webkitpy/style/processors/cpp.py: Removed.
  • Scripts/webkitpy/style/processors/cpp_unittest.py: Removed.
  • Scripts/webkitpy/style/processors/python.py: Removed.
  • Scripts/webkitpy/style/processors/python_unittest.py: Removed.
  • Scripts/webkitpy/style/processors/python_unittest_input.py: Removed.
  • Scripts/webkitpy/style/processors/text.py: Removed.
  • Scripts/webkitpy/style/processors/text_unittest.py: Removed.
12:26 PM Changeset in webkit [58262] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-04-26 Laszlo Gombos <Laszlo Gombos>

Reviewed by Simon Hausmann.

[Qt] Clean-up WebCore.pro after now that JavaScriptCore is built separately
​https://bugs.webkit.org/show_bug.cgi?id=38123

HAVE_STDINT_H, and HAVE_PTHREAD_NP_H no longer needs to be defined
for QtWebKit as JavaScriptCore is built separately. These defines are only
used by JavaScriptCore and for JavaScriptCore these are already
properly defined in JavaScriptCore/config.h.

No new tests, no new functionality.

  • WebCore.pro:
10:48 AM Changeset in webkit [58261] by ojan@chromium.org
  • 26 edits in trunk/WebKitTools

2010-04-06 Ojan Vafai <​ojan@chromium.org>

Reviewed by Adam Barth.

Include git commits in the diff for webkit-patch upload/land.
​https://bugs.webkit.org/show_bug.cgi?id=36394

Adds --squash, --no-squash and --git-commit.

--git-commit will use a specific local commit for land/upload.
If a commit-range is specified, then that range is treated as
a single squashed commit.

--squash will squash all local changes including working copy changes
into a single patch.

--no-squash is the legacy behavior (upload only considers the working copy,
land commits the working copy and then each local commit separately to SVN)

If neither is specified, then an informative error is raised if there is
more than one local commit or when there are local commit(s) and working
copy changes.

If the webkit-patch.squash git config parameter is set, then
that will be respected instead of raising an error.

  • Scripts/check-webkit-style:
  • Scripts/webkitpy/common/checkout/api.py:
  • Scripts/webkitpy/common/checkout/api_unittest.py:
  • Scripts/webkitpy/common/checkout/scm.py:
  • Scripts/webkitpy/common/checkout/scm_unittest.py:
  • Scripts/webkitpy/style/optparser.py: --git-since is removed and --git-commit no longer implies commit_id.. Instead, it treats that individual commit, but also supports commit ranges (e.g. commit_id..) as arguments.
  • Scripts/webkitpy/style/optparser_unittest.py:
  • Scripts/webkitpy/style_references.py:
  • Scripts/webkitpy/tool/commands/download.py:
  • Scripts/webkitpy/tool/commands/upload.py:
  • Scripts/webkitpy/tool/main.py:
  • Scripts/webkitpy/tool/mocktool.py:
  • Scripts/webkitpy/tool/steps/abstractstep.py:
  • Scripts/webkitpy/tool/steps/applypatchwithlocalcommit.py:
  • Scripts/webkitpy/tool/steps/checkstyle.py:
  • Scripts/webkitpy/tool/steps/commit.py:
  • Scripts/webkitpy/tool/steps/options.py:
  • Scripts/webkitpy/tool/steps/postdiff.py:
  • Scripts/webkitpy/tool/steps/preparechangelog.py:
  • Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
  • Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py:
  • Scripts/webkitpy/tool/steps/validatereviewer.py:
10:03 AM Changeset in webkit [58260] by evan@chromium.org
  • 1 edit
    1 add in trunk/WebCore

2010-04-26 Roman Gershman <​romange@google.com>

Reviewed by Adam Barth.

[Chromium] Font size in suggestions popup menu should be correlated with the font size of its text field.
The following manual test checks for desired behavior.

​https://bugs.webkit.org/show_bug.cgi?id=37977

  • manual-tests/chromium/suggestions-popup-font-change.html: Added.
9:56 AM Changeset in webkit [58259] by evan@chromium.org
  • 2 edits in trunk/WebKit/chromium

2010-04-26 Roman Gershman <​romange@google.com>

Reviewed by Adam Barth.

[Chromium] Font size in suggestions popup menu should be correlated with the font size of its text field.

​https://bugs.webkit.org/show_bug.cgi?id=37977

  • src/SuggestionsPopupMenuClient.cpp: (WebKit::SuggestionsPopupMenuClient::initialize):
9:21 AM Changeset in webkit [58258] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-04-26 Luiz Agostini <​luiz.agostini@openbossa.org>

Reviewed by Kenneth Rohde Christiansen.

View modes names in CSSValueKeywords.in
​https://bugs.webkit.org/show_bug.cgi?id=38125

View mode names has changed in previous patch but CSSValueKeywords.in file was
not updated.

  • css/CSSValueKeywords.in:
8:16 AM QtWebKitBackportingFixes edited by Simon Hausmann
(diff)
8:10 AM Changeset in webkit [58257] by Simon Hausmann
  • 2 edits in trunk/WebCore

[Qt] Fix compilation with RVCT 4
​https://bugs.webkit.org/show_bug.cgi?id=37727

Reviewed by Kenneth Rohde Christiansen.

Swap extern and declspec to fix visibility of symbol imported from QtGui.

  • page/qt/EventHandlerQt.cpp:
7:58 AM Changeset in webkit [58256] by eric@webkit.org
  • 8 edits in trunk/WebCore

2010-04-26 Ruben Van Boxem <​vanboxem.ruben@gmail.com>

Reviewed by Adam Roben.

Fixes for Win64 compilation under gcc (mingw-w64)

  • WebCore/bridge/npapi.h: for win64 compatibility, mirroring mozilla-central, see Mozilla bug 560298
  • WebCore/platform/Arena.h: uword is used to cast from pointers here. unsigned long is 32-bit on Windows (but 64-bit on mac), and too small to hold a pointer. uintptr_t is 32-bit on 32-bit systems (mac, linux and windows) and 64-bit on all 64-bit systems
  • WebCore/platform/graphics/transforms/TransformationMatrix.h: let mingw-w64/w32 use MSVC codepath
  • WebCore/platform/text/TextStream.cpp: let mingw-w64 use MSVC codepath
  • WebCore/platform/text/TextStream.h: let mingw-w64 use MSVC codepath
  • WebCore/plugins/PluginView.cpp: fix pointer casts on WIN64 and let mingw-w64 use MSVC codepath
  • WebCore/plugins/win/PluginViewWin.cpp: fix pointer casts on WIN64
7:54 AM Changeset in webkit [58255] by Simon Hausmann
  • 2 edits in trunk/WebKit/qt

[Qt] Fix the include header <qstring.h> -> <QtCore/qstring.h>

Patch by Thiago Macieira <​thiago.macieira@nokia.com> on 2010-04-26
Reviewed by Simon Hausmann.

The module/header.h style inclusion removes the need to have -I$QTDIR/include/depending-module
in the include search path for the application.

  • Api/qwebkitversion.h:
7:37 AM QtWebKitBackportingFixes edited by Simon Hausmann
(diff)
7:33 AM Changeset in webkit [58254] by Simon Hausmann
  • 2 edits in trunk/WebCore

[Qt] HTTP pipelining efficiency increase
​https://bugs.webkit.org/show_bug.cgi?id=38062

Patch by Markus Goetz <​Markus.Goetz@nokia.com> on 2010-04-26
Reviewed by Simon Hausmann.

Increase number of network requests that are fed into
QNetworkAccessManager.

  • platform/network/qt/ResourceRequestQt.cpp:

(WebCore::initializeMaximumHTTPConnectionCountPerHost):

6:56 AM Changeset in webkit [58253] by pfeldman@chromium.org
  • 9 edits
    5 deletes in trunk/WebKit/chromium

2010-04-26 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Chromium Dev Tools: brush up images.

​https://bugs.webkit.org/show_bug.cgi?id=38124

  • WebKit.gypi:
  • src/js/DevTools.js: (WebInspector.setToolbarColors):
  • src/js/Images/segmentChromium.png:
  • src/js/Images/segmentChromium2.png: Removed.
  • src/js/Images/segmentHoverChromium2.png: Removed.
  • src/js/Images/segmentSelectedChromium2.png: Removed.
  • src/js/Images/statusbarBackgroundChromium.png:
  • src/js/Images/statusbarBackgroundChromium2.png: Removed.
  • src/js/Images/statusbarBottomBackgroundChromium.png:
  • src/js/Images/statusbarButtonsChromium.png:
  • src/js/Images/statusbarMenuButtonChromium.png:
  • src/js/Images/statusbarMenuButtonChromium2.png: Removed.
  • src/js/devTools.css: (.section > .header): (.console-group-messages .section > .header): (#resources-filter): (.crumbs .crumb): (.crumbs .crumb.end): (.crumbs .crumb.selected): (.crumbs .crumb.selected:hover): (.crumbs .crumb.selected.end, .crumbs .crumb.selected.end:hover): (.crumbs .crumb:hover): (.crumbs .crumb.dimmed:hover): (.crumbs .crumb.end:hover): (body.drawer-visible #main-status-bar): (.status-bar): (button.status-bar-item): (select.status-bar-item:active): (#drawer): (select.status-bar-item):
6:37 AM Changeset in webkit [58252] by eric@webkit.org
  • 3 edits in trunk/WebCore

2010-04-26 Ilya Tikhonovsky <​loislo@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: undefined shows up on inspector.
​https://bugs.webkit.org/show_bug.cgi?id=38120

  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype.hide):
  • inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype.set visible):
6:31 AM QtWebKitRelease20 edited by Simon Hausmann
(diff)
6:01 AM Changeset in webkit [58251] by Chris Jerdonek
  • 3 edits in trunk/WebKitTools

2010-04-26 Chris Jerdonek <Chris Jerdonek>

Reviewed by Shinichiro Hamaji.

Deleted the StyleChecker-related classes that are no longer
being used.

​https://bugs.webkit.org/show_bug.cgi?id=38118

  • Scripts/webkitpy/style/checker.py:
    • Deleted the DeprecatedStyleChecker class.
  • Scripts/webkitpy/style/checker_unittest.py:
    • Deleted the StyleCheckerTest, StyleCheckerCheckFileBase, StyleCheckerCheckFileTest, and StyleCheckerCheckPathsTest classes.
5:47 AM Changeset in webkit [58250] by eric@webkit.org
  • 4 edits in trunk

2010-04-26 Bruno Schmidt <​bruno.schmidt@gmail.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Exposing an QVariantMap containing QObjectStar to Javascript
causes Segmentation Fault
​https://bugs.webkit.org/show_bug.cgi?id=34729

If an QVariantMap containing QObjectStar is added to the to QtWebkit
Javascript, it's use causes Segmentation Fault.
It happens because, in the case QMetaType::QVariantMap, the "root"
object that is inside of a PassRefPtr is passed recursively inside a
loop to recover the content of the map, but the PassRefPtr semantics
prohibit its use inside a loop, so the "root" object mus be passed
using the method "PassRefPtr::get" in order to keep the current
reference.

  • bridge/qt/qt_runtime.cpp: (JSC::Bindings::convertValueToQVariant): (JSC::Bindings::convertQVariantToValue): change to root.get()

2010-04-26 Bruno Schmidt <​bruno.schmidt@gmail.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Exposing an QVariantMap containing QObjectStar to Javascript
causes Segmentation Fault
​https://bugs.webkit.org/show_bug.cgi?id=34729

If an QVariantMap containing QObjectStar is added to the to QtWebkit
Javascript, it's use causes Segmentation Fault.
It happens because, in the case QMetaType::QVariantMap, the "root"
object that is inside of a PassRefPtr is passed recursively inside a
loop to recover the content of the map, but the PassRefPtr semantics
prohibit its use inside a loop, so the "root" object mus be passed
using the method "PassRefPtr::get" in order to keep the current
reference.

  • tests/qwebframe/tst_qwebframe.cpp: (MyQObject::MyQObject): new property variantMapProperty (MyQObject::variantMapProperty): read variantMapProperty (MyQObject::setVariantMapProperty): write variantMapProperty
5:28 AM Changeset in webkit [58249] by Chris Jerdonek
  • 6 edits in trunk/WebKitTools

2010-04-26 Chris Jerdonek <Chris Jerdonek>

Reviewed by Shinichiro Hamaji.

Changed the StyleChecker class to use the new TextFileReader class.

​https://bugs.webkit.org/show_bug.cgi?id=37066

This revision separates the code responsible for reading and iterating
over text files from the rest of check-webkit-style.

  • Scripts/check-webkit-style:
    • Changed the script to use the new StyleProcessor and TextFileReader classes instead of the StyleChecker class.
  • Scripts/webkitpy/style/checker.py:
    • Added a FIXME to rename many of uses of the word "processor" to "checker". We did this to clarify the difference between ProcessorBase instances passed to the TextFileReader and classes that process and check lines for style.
    • Added a FIXME to remove FileType.NONE as a possible return value of ProcessorDispatcher._file_type(). This will better consolidate the logic of which files should be skipped.
    • Added a FIXME to delete the StyleChecker class.
    • Added the StyleProcessor class which implements ProcessorBase. This class is responsible for processing lines to check style (but not for reading files). For each file, this class creates creates both a carriage-return checker and a format-specific style checker (e.g. one of C++, Python, etc).
    • Updated the PatchChecker class to use a TextFileReader instance instead of a StyleChecker.
  • Scripts/webkitpy/style/checker_unittest.py:
    • Added the StyleProcessor_EndToEndTest class to do "end-to-end" tests of the StyleProcessor class.
    • Added the StyleProcessor_CodeCoverageTest to test the StyleProcessor class with more complete code coverage. Unlike the StyleProcessor_EndToEndTest class, this class makes heavy use of mock parameters.
    • Added FIXME's to delete the unit test classes that are no longer needed.
    • Updated the PatchCheckerTest class to use a MockTextFileReader instead of a MockStyleChecker.
  • Scripts/webkitpy/style/filereader.py:
  • Scripts/webkitpy/style/filereader_unittest.py:
    • In the TextFileReaderTest class:
      • Moved the test_process_fileshould_not_process() method.
      • Added a test_process_filefile_stdin() method to test the file path "-".
5:28 AM Changeset in webkit [58248] by eric@webkit.org
  • 2 edits in trunk/JavaScriptCore

2010-04-26 Jedrzej Nowacki <​jedrzej.nowacki@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

Fix a memory leak in the QScriptString.

QScriptStringPrivate's constructor shouldn't call JSStringRetain as
QScriptConverter implicitly pass a JSStringRef ownership.

[Qt] QScriptStringPrivate c'tor problem
​https://bugs.webkit.org/show_bug.cgi?id=38110

  • qt/api/qscriptstring_p.h: (QScriptStringPrivate::QScriptStringPrivate):
4:36 AM Changeset in webkit [58247] by pfeldman@chromium.org
  • 3 edits in trunk

2010-04-26 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: Render clip in summary bar using "arc", not "quadraticCurveTo".

​https://bugs.webkit.org/show_bug.cgi?id=38107

  • inspector/front-end/SummaryBar.js: (WebInspector.SummaryBar.prototype._drawSummaryGraph.drawPill): (WebInspector.SummaryBar.prototype._drawSummaryGraph):
4:32 AM Changeset in webkit [58246] by eric@webkit.org
  • 3 edits in trunk/WebCore

2010-04-26 Andreas Kling <​andreas.kling@nokia.com>

Reviewed by Tor Arne Vestbø.

[Qt] Fix compilation against Qt 4.7

Some QtMultimedia things have been moved into QtMediaServices
​https://bugs.webkit.org/show_bug.cgi?id=38111

  • WebCore.pro:
  • platform/graphics/qt/MediaPlayerPrivateQt.cpp: (WebCore::MediaPlayerPrivate::supportsType): (WebCore::MediaPlayerPrivate::totalBytes):
4:23 AM Changeset in webkit [58245] by eric@webkit.org
  • 2 edits
    3 adds in trunk/LayoutTests

2010-04-26 Yael Aharon <​yael.aharon@nokia.com>

Reviewed by Laszlo Gombos.

[Qt] Add expected results after r58228
​https://bugs.webkit.org/show_bug.cgi?id=38098

  • platform/qt/Skipped:
  • platform/qt/fast/dom/HTMLProgressElement/progress-bar-value-pseudo-element-expected.checksum: Added.
  • platform/qt/fast/dom/HTMLProgressElement/progress-bar-value-pseudo-element-expected.png: Added.
  • platform/qt/fast/dom/HTMLProgressElement/progress-bar-value-pseudo-element-expected.txt: Added.
4:01 AM Changeset in webkit [58244] by jorlow@chromium.org
  • 2 edits in trunk/LayoutTests

c

3:25 AM QtWebKitBugs edited by jocelyn.turcotte@nokia.com
(diff)
3:23 AM QtWebKitBugs edited by jocelyn.turcotte@nokia.com
Triaging should now use the Triaged keyword instead of the assignee (diff)
3:07 AM QtWebKitJournal edited by Simon Hausmann
(diff)
3:05 AM Changeset in webkit [58243] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-04-26 Zoltan Herczeg <​zherczeg@webkit.org>

Reviewed by Dirk Schulze.

Call setStrokeStyle in applyStrokeStyleToContext
​https://bugs.webkit.org/show_bug.cgi?id=37849

Not all platforms set the stroke style to solid if they
get an empty line dash array. Some just ignore the operation.

  • rendering/SVGRenderSupport.cpp: (WebCore::applyStrokeStyleToContext):
2:35 AM Changeset in webkit [58242] by loislo@chromium.org
  • 5 edits in trunk/WebCore

2010-04-23 Ilya Tikhonovsky <​loislo@chromium.org>

Reviewed by Pavel Feldman.

WebInspector: Aggregated stats of time spent in children records should be visible
in the popup panel of parent record. Crash in pushGCEventRecord also was fixed.
​https://bugs.webkit.org/show_bug.cgi?id=37820

  • English.lproj/localizedStrings.js:
  • inspector/InspectorTimelineAgent.cpp: (WebCore::InspectorTimelineAgent::pushGCEventRecords):
  • inspector/front-end/TimelinePanel.js: (WebInspector.TimelinePanel.prototype._innerAddRecordToTimeline): (WebInspector.TimelinePanel.prototype._createRootRecord): (WebInspector.TimelinePanel.prototype._showPopover): (WebInspector.TimelineCalculator.prototype.computeBarGraphPercentages): (WebInspector.TimelineCalculator.prototype.computeBarGraphWindowPosition): (WebInspector.TimelineRecordGraphRow): (WebInspector.TimelineRecordGraphRow.prototype.update): (WebInspector.TimelinePanel.FormattedRecord): (WebInspector.TimelinePanel.FormattedRecord.prototype._generateAggregatedInfo): (WebInspector.TimelinePanel.FormattedRecord.prototype._generatePopupContent): (WebInspector.TimelinePanel.FormattedRecord.prototype._getRecordDetails): (WebInspector.TimelinePanel.FormattedRecord.prototype._calculateAggregatedStats):
  • inspector/front-end/inspector.css: (.timeline-graph-bar.with-children): (.timeline-graph-bar.cpu): (.timeline-aggregated-category): (.timeline-loading): (.timeline-scripting): (.timeline-rendering): (.popover .timeline-aggregated-category.timeline-loading): (.timeline-details-title):
1:23 AM Changeset in webkit [58241] by tony@chromium.org
  • 2 edits in trunk/LayoutTests

2010-04-26 Tony Chang <​tony@chromium.org>

Not reviewed, removing duplicate expectations.

[chromium] Check and rebaseline SVG test expectations for Chromium
​https://bugs.webkit.org/show_bug.cgi?id=38106

  • platform/chromium/test_expectations.txt:
1:23 AM Changeset in webkit [58240] by tkent@chromium.org
  • 3 edits in trunk/WebKit/chromium

Unreviewed. Roll out r58237 and r58238 because of Chromium/Linux build break.

1:21 AM QtWebKitTableOfFeatures20 edited by Henry Haverinen
(diff)
1:21 AM QtWebKitTableOfFeatures20 edited by Henry Haverinen
(diff)
1:19 AM QtWebKitTableOfFeatures20 edited by Henry Haverinen
(diff)
1:11 AM QtWebKitTableOfFeatures20 edited by Henry Haverinen
(diff)
1:06 AM QtWebKitTableOfFeatures20 edited by Henry Haverinen
(diff)
1:02 AM Changeset in webkit [58239] by yuzo@google.com
  • 2 edits in trunk/LayoutTests

2010-04-26 Yuzo Fujishima <​yuzo@google.com>

Unreviewed, Chromium test expectation change.

Change SVG test expectations for Chromium.
​https://bugs.webkit.org/show_bug.cgi?id=38106

  • platform/chromium/test_expectations.txt:
1:01 AM QtWebKitTableOfFeatures20 edited by Henry Haverinen
(diff)
12:56 AM Changeset in webkit [58238] by tkent@chromium.org
  • 1 edit in trunk/WebKit/chromium/DEPS

Unreviewd. Chromium build fix for r58237.

  • DEPS: Add third_party/mesa
12:33 AM Changeset in webkit [58237] by tkent@chromium.org
  • 3 edits in trunk/WebKit/chromium

2010-04-26 Kent Tamura <​tkent@chromium.org>

Reviewed by Shinichiro Hamaji.

[DRT/Chromium] Enable Windows project generation
​https://bugs.webkit.org/show_bug.cgi?id=38103

  • Bump the Chromium revision to r45515 to have GYP r818, which fixes a Windows project generation bug.
  • Avoid platform.system(), which causes a crash with python.exe in depot_tools. Use sys.platform instead.
  • Process DumpRenderTree.gyp on all platforms.
  • DEPS:
  • gyp_webkit:
12:07 AM Changeset in webkit [58236] by tkent@chromium.org
  • 10 edits
    4 adds in trunk

2010-04-25 Kent Tamura <​tkent@chromium.org>

Reviewed by Darin Adler.

WebKit crashes with deeply nested divs.
​https://bugs.webkit.org/show_bug.cgi?id=18282

Add a test for deeply nested <span> elements like block-nesting-cap.html.

  • fast/parser/element-nesting-cap-expected.txt: Added.
  • fast/parser/element-nesting-cap.html: Added.
  • fast/parser/script-tests/element-nesting-cap.js: Added.

2010-04-25 Kent Tamura <​tkent@chromium.org>

Reviewed by Darin Adler.

WebKit crashes with deeply nested divs
​https://bugs.webkit.org/show_bug.cgi?id=18282

The HTML parser caps a tree depth by MAX_DOM_TREE_DEPTH defined in
TreeDepthLimit.h. This is performance-efficient, but does not work for
DOM operations such as Node.appendChild().

Test: fast/parser/element-nesting-cap.html

  • dom/Node.h:
  • dom/XMLTokenizer.cpp: (WebCore::XMLTokenizer::pushCurrentNode):
  • html/HTMLParser.cpp:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/TreeDepthLimit.h: Added. Define MAX_DOM_TREE_DEPTH. The default value is 5000.
  • dom/XMLTokenizer.cpp: Use maxDOMTreeDepth. (WebCore::XMLTokenizer::pushCurrentNode):
  • html/HTMLParser.cpp: Introduce m_treeDepth, which counts the depth of the tree. Unlike m_blocksInStack, it contains the number of non-block nodes. (WebCore::HTMLParser::HTMLParser): (WebCore::HTMLParser::reset): (WebCore::HTMLParser::limitDepth): Renamed from limitBlockDepth. Add check for m_nodeDepth. (WebCore::HTMLParser::insertNodeAfterLimitDepth): Renamed from insertNodeAfterLimitBlockDepth. (WebCore::HTMLParser::parseToken): (WebCore::HTMLParser::handleResidualStyleCloseTagAcrossBlocks): (WebCore::HTMLParser::pushBlock): (WebCore::HTMLParser::popOneBlockCommon): (WebCore::HTMLParser::freeBlock):
  • html/HTMLParser.h:
Note: See TracTimeline for information about the timeline view.