Timeline
May 6, 2010:
- 11:42 PM Changeset in webkit [58940] by
-
- 2 edits in trunk/WebKitTools
Exclude leaks due to <rdar://problem/7815391> from the output.
Rubber-stamped by Dan Bernstein.
- Scripts/old-run-webkit-tests:
- 11:22 PM Changeset in webkit [58939] by
-
- 2 edits in trunk/JavaScriptCore
2010-05-06 Laszlo Gombos <Laszlo Gombos>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Enable YARR_JIT for X86 Mac for QtWebKit
https://bugs.webkit.org/show_bug.cgi?id=38668
- wtf/Platform.h:
- 11:18 PM Changeset in webkit [58938] by
-
- 2 edits in trunk/LayoutTests
Skip compositing/layer-creation/overflow-scroll-overlap.html from r58936, since hardware
compositing is disabled on the Leopard test bot.
- platform/mac-leopard/Skipped:
- 10:12 PM Changeset in webkit [58937] by
-
- 4 edits3 adds in trunk
2010-04-27 Tony Chang <tony@chromium.org>
Reviewed by Eric Seidel.
[chromium] clicking a scrollbar in an iframe shouldn't lose the selection
https://bugs.webkit.org/show_bug.cgi?id=38189
- fast/events/mousedown-in-subframe-scrollbar-expected.txt: Added.
- fast/events/mousedown-in-subframe-scrollbar.html: Added.
- fast/events/resources/mousedown-in-subframe-scrollbar.html: Added.
- platform/win/Skipped:
2010-04-27 Tony Chang <tony@chromium.org>
Reviewed by Eric Seidel.
[chromium] clicking a scrollbar in an iframe shouldn't lose the selection
https://bugs.webkit.org/show_bug.cgi?id=38189
Test: fast/events/mousedown-in-subframe-scrollbar.html
- page/chromium/EventHandlerChromium.cpp: (WebCore::EventHandler::passMousePressEventToSubframe): If clicking on
a scrollbar, pass the event directly to the scrollbar. This matches
mac which passes the event to the NSScroller.
- 10:04 PM Changeset in webkit [58936] by
-
- 3 edits3 adds in trunk
2010-05-06 Simon Fraser <Simon Fraser>
Reviewed by Dan Bernstein.
Compositing layers that are clipped out by an overflow:scroll parent fail to get created on reveal
https://bugs.webkit.org/show_bug.cgi?id=38712
When compositing layer creation is testing layer overlap, we need to re-run the
algorithm when an overflow:scroll element scrolls, to create new layers for revealed
elements.
Test: compositing/layer-creation/overflow-scroll-overlap.html
- rendering/RenderLayer.cpp: (WebCore::RenderLayer::scrollToOffset): First, move the compositing updates until after the call to updateWidgetPositions(), so that this order is similar to what we done when a FrameView scrolls. This change has no known side effects. Second, if compositingConsultsOverlap() is true, we need to actually do a compositing layer update to compute whether revealed/hidden layers should be created/destroyed.
- 9:58 PM Changeset in webkit [58935] by
-
- 5 edits1 add in trunk/JavaScriptCore
Bug 38714 - Add result caching for Math.sin
Reviewed by Geoff Garen.
Math.sin is frequently called with the same operand, caching the result should
improve performance. CachedTranscendentalFunction adds a generic mechanism to
cache results for pure functions with the signature "double func(double)", and
where NaN maps to NaN.
CachedTranscendentalFunction uses a very simple hash function designed to be
fast to execute since we cannot cache the result, and trivial to JIT generate,
should we wish to do so.
- JavaScriptCore.xcodeproj/project.pbxproj:
- runtime/CachedTranscendentalFunction.h: Added.
(JSC::CachedTranscendentalFunction::CachedTranscendentalFunction):
(JSC::CachedTranscendentalFunction::~CachedTranscendentalFunction):
(JSC::CachedTranscendentalFunction::operator()):
(JSC::CachedTranscendentalFunction::initialize):
(JSC::CachedTranscendentalFunction::hash):
- runtime/JSGlobalData.h:
- runtime/MathObject.cpp:
(JSC::mathProtoFuncSin):
- wtf/Platform.h:
- 9:51 PM Changeset in webkit [58934] by
-
- 6 edits5 copies30 adds in trunk/WebKitTools
2010-05-06 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r58933.
http://trac.webkit.org/changeset/58933
https://bugs.webkit.org/show_bug.cgi?id=38717
"Broke all websocket tests on Tiger" (Requested by eseidel on
#webkit).
- Scripts/new-run-webkit-websocketserver:
- Scripts/old-run-webkit-tests:
- Scripts/run-webkit-websocketserver:
- Scripts/webkitpy/layout_tests/port/websocket_server.py:
- Scripts/webkitpy/thirdparty/init.py:
- Scripts/webkitpy/thirdparty/pywebsocket/COPYING: Added.
- Scripts/webkitpy/thirdparty/pywebsocket/MANIFEST.in: Added.
- Scripts/webkitpy/thirdparty/pywebsocket/README: Added.
- Scripts/webkitpy/thirdparty/pywebsocket/README.webkit: Added.
- Scripts/webkitpy/thirdparty/pywebsocket/example/echo_client.py: Added.
- Scripts/webkitpy/thirdparty/pywebsocket/example/echo_wsh.py: Added.
- Scripts/webkitpy/thirdparty/pywebsocket/example/handler_map.txt: Added.
- Scripts/webkitpy/thirdparty/pywebsocket/mod_pywebsocket/init.py: Added.
- Scripts/webkitpy/thirdparty/pywebsocket/mod_pywebsocket/dispatch.py: Added.
- Scripts/webkitpy/thirdparty/pywebsocket/mod_pywebsocket/handshake.py: Added.
- Scripts/webkitpy/thirdparty/pywebsocket/mod_pywebsocket/headerparserhandler.py: Added.
- Scripts/webkitpy/thirdparty/pywebsocket/mod_pywebsocket/memorizingfile.py: Added.
- Scripts/webkitpy/thirdparty/pywebsocket/mod_pywebsocket/msgutil.py: Added.
- Scripts/webkitpy/thirdparty/pywebsocket/mod_pywebsocket/standalone.py: Added.
- Scripts/webkitpy/thirdparty/pywebsocket/mod_pywebsocket/util.py: Added.
- Scripts/webkitpy/thirdparty/pywebsocket/setup.py: Added.
- Scripts/webkitpy/thirdparty/pywebsocket/test/config.py: Added.
- Scripts/webkitpy/thirdparty/pywebsocket/test/mock.py: Added.
- Scripts/webkitpy/thirdparty/pywebsocket/test/run_all.py: Added.
- Scripts/webkitpy/thirdparty/pywebsocket/test/test_dispatch.py: Added.
- Scripts/webkitpy/thirdparty/pywebsocket/test/test_handshake.py: Added.
- Scripts/webkitpy/thirdparty/pywebsocket/test/test_memorizingfile.py: Added.
- Scripts/webkitpy/thirdparty/pywebsocket/test/test_mock.py: Added.
- Scripts/webkitpy/thirdparty/pywebsocket/test/test_msgutil.py: Added.
- Scripts/webkitpy/thirdparty/pywebsocket/test/test_util.py: Added.
- Scripts/webkitpy/thirdparty/pywebsocket/test/testdata/README: Added.
- Scripts/webkitpy/thirdparty/pywebsocket/test/testdata/handlers/blank_wsh.py: Added.
- Scripts/webkitpy/thirdparty/pywebsocket/test/testdata/handlers/origin_check_wsh.py: Added.
- Scripts/webkitpy/thirdparty/pywebsocket/test/testdata/handlers/sub/exception_in_transfer_wsh.py: Added.
- Scripts/webkitpy/thirdparty/pywebsocket/test/testdata/handlers/sub/no_wsh_at_the_end.py: Added.
- Scripts/webkitpy/thirdparty/pywebsocket/test/testdata/handlers/sub/non_callable_wsh.py: Added.
- Scripts/webkitpy/thirdparty/pywebsocket/test/testdata/handlers/sub/plain_wsh.py: Added.
- Scripts/webkitpy/thirdparty/pywebsocket/test/testdata/handlers/sub/wrong_handshake_sig_wsh.py: Added.
- Scripts/webkitpy/thirdparty/pywebsocket/test/testdata/handlers/sub/wrong_transfer_sig_wsh.py: Added.
- Scripts/webkitpy/thirdparty/pywebsocket/test/testdata/hello.pl: Added.
- 8:56 PM Changeset in webkit [58933] by
-
- 6 edits35 deletes in trunk/WebKitTools
2010-05-06 Fumitoshi Ukai <ukai@chromium.org>
Reviewed by David Levin.
WebSocket: pywebsocket 0.5
https://bugs.webkit.org/show_bug.cgi?id=38034
Remove pywebsocket from webkitpy/thirdparty.
Make pywebsocket autoinstalled.
- Scripts/new-run-webkit-websocketserver: Add --output-dir option.
- Scripts/old-run-webkit-tests: Use new-run-webkit-websocketserver, rather than directly run pywebsocket's standalone.py
- Scripts/run-webkit-websocketserver: Ditto.
- Scripts/webkitpy/layout_tests/port/websocket_server.py: Use autoinstalled pywebsocket.
- Scripts/webkitpy/thirdparty/init.py: Autoinstall pywebsocket
- Scripts/webkitpy/thirdparty/pywebsocket: Removed.
- 8:13 PM Changeset in webkit [58932] by
-
- 4 edits in trunk/WebKitTools
svn-apply now understands the Git diff "copy from" syntax when the
similarity index is 100%.
Reviewed by Daniel Bates.
https://bugs.webkit.org/show_bug.cgi?id=38628
- Scripts/VCSUtils.pm:
- Adjusted parseGitDiffHeader() to parse the "copy from" and "similarity index" lines.
- Scripts/svn-unapply:
- Adjusted the patch() subroutine so that copies are recognized as file additions.
- Scripts/webkitperl/VCSUtils_unittest/parseGitDiffHeader.pl:
- Added unit tests for the cases of a copy with similarity index 100% and less than 100%.
- 7:58 PM Changeset in webkit [58931] by
-
- 5 edits in trunk
Versioning.
- 7:58 PM Changeset in webkit [58930] by
-
- 1 copy in tags/Safari-533.8
New tag.
- 7:54 PM Changeset in webkit [58929] by
-
- 8 edits in trunk/WebKitTools
2010-05-06 Chris Jerdonek <Chris Jerdonek>
Reviewed by Daniel Bates.
Removed the need for svn-apply and -unapply to re-parse whether
a diff is binary or not.
- Scripts/VCSUtils.pm:
- Adjusted parseGitDiffHeader() to set the isBinary key.
- Adjusted parseSvnDiffHeader() to set the isBinary key.
- Adjusted parseDiffHeader() to set the isBinary key.
- Changed the scmFormat key set by parseDiffHeader() to isGit and isSvn keys.
- Adjusted parseDiff() to set the isBinary, isGit, and isSvn keys.
- Scripts/svn-apply:
- Updated the patch() method to use the isBinary, isGit, and isSvn keys.
- Scripts/svn-unapply:
- Updated the patch() method to use the isBinary and isSvn keys.
- Scripts/webkitperl/VCSUtils_unittest/parseDiff.pl:
- Updated the unit tests as necessary.
- Added a test case to test that the isBinary key is getting set properly.
- Scripts/webkitperl/VCSUtils_unittest/parseDiffHeader.pl:
- Updated the unit tests as necessary.
- Scripts/webkitperl/VCSUtils_unittest/parseGitDiffHeader.pl:
- Updated the unit tests as necessary.
- Scripts/webkitperl/VCSUtils_unittest/parseSvnDiffHeader.pl:
- Updated the unit tests as necessary.
- 7:37 PM Changeset in webkit [58928] by
-
- 6 edits2 moves2 adds in trunk/LayoutTests
2010-05-06 Dirk Pranke <dpranke@chromium.org>
Unreviewed, rebaseline and expectation changes from WK roll from a
few days ago.
- platform/chromium-linux/http/tests/loading/bad-scheme-subframe-expected.txt: Copied from LayoutTests/platform/chromium-mac/http/tests/loading/bad-scheme-subframe-expected.txt.
- platform/chromium-linux/svg/W3C-SVG-1.1/fonts-kern-01-t-expected.checksum:
- platform/chromium-linux/svg/W3C-SVG-1.1/fonts-kern-01-t-expected.png:
- platform/chromium-linux/svg/text/kerning-expected.checksum:
- platform/chromium-linux/svg/text/kerning-expected.png:
- platform/chromium-mac/editing/selection/caret-rtl-2-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/editing/selection/caret-rtl-2-actual.checksum.
- platform/chromium-mac/editing/selection/caret-rtl-2-expected.png: Renamed from LayoutTests/platform/chromium-mac/editing/selection/caret-rtl-2-actual.png.
- platform/chromium-mac/svg/text/kerning-expected.checksum: Added.
- platform/chromium/test_expectations.txt:
- 6:56 PM Changeset in webkit [58927] by
-
- 4 edits in trunk
2010-05-06 Kent Tamura <tkent@chromium.org>
Reviewed by Dimitri Glazkov.
[DRT/Chromium] Add support for resources on Mac
https://bugs.webkit.org/show_bug.cgi?id=38637
- DEPS: Check out tools/data_pack.
2010-05-06 Kent Tamura <tkent@chromium.org>
Reviewed by Dimitri Glazkov.
[DRT/Chromium] Add support for resources on Mac
https://bugs.webkit.org/show_bug.cgi?id=38637
Repack webkit_chromium_resources.pak, webkit_strings_en-US.pak,
and webkit_resources.pak, and put them as Mac bundle resource.
The 'actions' section is almost same as a part of test_shell.gypi.
- DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
- 6:29 PM Changeset in webkit [58926] by
-
- 1 edit2 adds in trunk/LayoutTests
2010-05-06 Dirk Pranke <dpranke@chromium.org>
Unreviewed, rebaseline a chromium test.
Need a linux baseline for fast/notifications/notifications-replace-expected.txt to override the windows version.
- platform/chromium-linux/fast/notifications/notifications-replace-expected.txt: Added.
- 5:47 PM Changeset in webkit [58925] by
-
- 2 edits in trunk/WebCore
Not reviewed, build fix.
Try again - with quotes this time. *facepalm*
- dom/Notation.cpp:
- 5:39 PM Changeset in webkit [58924] by
-
- 2 edits in trunk/WebCore
Not reviewed, build fix.
Speculative fix for Qt and Gtk.
- dom/Notation.cpp:
- 5:34 PM BuildingQtOnWindows edited by
- few words on how to generate MSVC project files (diff)
- 5:25 PM Changeset in webkit [58923] by
-
- 2 edits in trunk/WebCore
Not reviewed, build fix.
Fix an assert that I failed to update in my earlier change.
- dom/CharacterData.h:
(WebCore::CharacterData::CharacterData):
- 5:03 PM Changeset in webkit [58922] by
-
- 4 edits2 adds in trunk
Reviewed by Geoff Garen.
https://bugs.webkit.org/show_bug.cgi?id=38697
REGRESSION (r58299): Replying on reddit.com no longer works
- css/CSSSelector.cpp: (WebCore::CSSSelector::extractPseudoType): Don't recognize :first, :left and :right. The aren't allowed in all contexts, and properly implementing them is out of scope for this regression fix.
- 5:01 PM Changeset in webkit [58921] by
-
- 11 edits in trunk/WebCore
Improve code generator scripts to support converting ScriptString.
https://bugs.webkit.org/show_bug.cgi?id=38699
Reviewed by Adam Barth.
Change both JSC and V8 generators to introduce "ConvertScriptString"
attribute to allow converting from ScriptString. Also updated the
bindings test result.
These changes are necessary in order to avoid adding custom binding codes
when we add the FileReader interface.
- bindings/scripts/CodeGeneratorJS.pm:
- bindings/scripts/CodeGeneratorV8.pm:
- bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:
(webkit_dom_test_obj_get_script_string_attr):
(webkit_dom_test_obj_get_property):
(webkit_dom_test_obj_class_init):
- bindings/scripts/test/GObject/WebKitDOMTestObj.h:
- bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore::):
(WebCore::jsTestObjScriptStringAttr):
- bindings/scripts/test/JS/JSTestObj.h:
- bindings/scripts/test/ObjC/DOMTestObj.h:
- bindings/scripts/test/ObjC/DOMTestObj.mm:
(-[DOMTestObj scriptStringAttr]):
- bindings/scripts/test/TestObj.idl:
- bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::TestObjInternal::scriptStringAttrAttrGetter):
(WebCore::):
- 4:45 PM Changeset in webkit [58920] by
-
- 2 edits in trunk/WebKitTools
[Qt] Unreviewed buildfix after r58917.
- DumpRenderTree/qt/LayoutTestControllerQt.h: Missing function declaration added.
- 4:33 PM Changeset in webkit [58919] by
-
- 4 edits11 adds in trunk/WebCore
Improve code generator scripts to pass additional ScriptExecutionContext
argument to the constructor.
https://bugs.webkit.org/show_bug.cgi?id=38687
Reviewed by Adam Barth.
Change both JSC and V8 generators to introduce "CallWith=ScriptExecutionContext"
attribute to allow passing the additional ScriptExecutionContext argument to
the constructor. Also add another test IDL file to test interface-level
features.
These changes are necessary in order to avoid adding custom binding codes
when we add the FileReader interface.
- bindings/scripts/CodeGeneratorJS.pm:
- bindings/scripts/CodeGeneratorV8.pm:
- bindings/scripts/test/GObject/WebKitDOMTestInterface.cpp: Added.
- bindings/scripts/test/GObject/WebKitDOMTestInterface.h: Added.
- bindings/scripts/test/GObject/WebKitDOMTestInterfacePrivate.h: Added.
- bindings/scripts/test/JS/JSTestInterface.cpp: Added.
- bindings/scripts/test/JS/JSTestInterface.h: Added.
- bindings/scripts/test/ObjC/DOMTestInterface.h: Added.
- bindings/scripts/test/ObjC/DOMTestInterface.mm: Added.
- bindings/scripts/test/ObjC/DOMTestInterfaceInternal.h: Added.
- bindings/scripts/test/TestInterface.idl: Added.
- bindings/scripts/test/V8/V8TestInterface.cpp: Added.
- bindings/scripts/test/V8/V8TestInterface.h: Added.
- bindings/v8/V8Proxy.h:
(WebCore::V8Proxy::constructDOMObjectWithScriptExecutionContext):
- 4:23 PM Changeset in webkit [58918] by
-
- 2 edits in trunk/WebCore
Build fix, not reviewed.
Speculative Windows and Debug build fixes for the last change.
- dom/Node.h:
(WebCore::Node::inDocument):
(WebCore::Node::setFlag):
- 4:23 PM Changeset in webkit [58917] by
-
- 14 edits2 adds in trunk
2010-05-06 Anders Carlsson <andersca@apple.com>
Reviewed by Darin Adler and Dan Bernstein..
REGRESSION (r51617): when plugins are disabled, plugins show up as garbage characters
https://bugs.webkit.org/show_bug.cgi?id=38698
<rdar://problem/7942075>
When the plug-in database is initialized, we will register all the MIME types it supports with the global
WebView dictionary. When plug-ins are disabled for a single web view, the MIME types still need to be
in the global mapping (because other web views might still have plug-ins enabled).
Prior to r51617 we would always look at the plug-in database to determine that the MIME type belongs to a
plug-in, but now we won't even touch the plug-in database when plug-ins are disabled.
In order to fix this, a new set of registered MIME types that are known to be plug-ins is added. When
+[WebView _viewClass:andRepresentationClass:forMIMEType:allowingPlugins:] is called and allowingPlugins is FALSE
we check if the MIME type is a known plug-in MIME type and return false in that case.
- Plugins/WebPluginDatabase.mm: (-[WebPluginDatabase refresh]): (-[WebPluginDatabase _removePlugin:]):
- WebView/WebView.mm: (knownPluginMIMETypes): (+[WebView _registerPluginMIMEType:]): (+[WebView _unregisterPluginMIMEType:]): (+[WebView _viewClass:andRepresentationClass:forMIMEType:allowingPlugins:]):
- WebView/WebViewInternal.h:
2010-05-06 Anders Carlsson <andersca@apple.com>
Reviewed by Darin Adler and Dan Bernstein..
REGRESSION (r51617): when plugins are disabled, plugins show up as garbage characters
https://bugs.webkit.org/show_bug.cgi?id=38698
<rdar://problem/7942075>
Add tests.
- platform/mac/plugins/disable-plugins-expected.txt: Added.
- platform/mac/plugins/disable-plugins.html: Added.
2010-05-06 Anders Carlsson <andersca@apple.com>
Reviewed by Darin Adler and Dan Bernstein..
REGRESSION (r51617): when plugins are disabled, plugins show up as garbage characters
https://bugs.webkit.org/show_bug.cgi?id=38698
<rdar://problem/7942075>
Add a 'setPluginsEnabled' layoutTestController function for disabling plug-ins. This is only implemented on Mac currently
because the bug that needs this functionality is mac specific.
- DumpRenderTree/LayoutTestController.cpp: (setPluginsEnabledCallback): (LayoutTestController::staticFunctions):
- DumpRenderTree/LayoutTestController.h:
- DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::setPluginsEnabled):
- DumpRenderTree/mac/DumpRenderTree.mm: (resetDefaultsToConsistentValues):
- DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::setPluginsEnabled):
- DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::setPluginsEnabled):
- DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::setPluginsEnabled):
- DumpRenderTree/wx/LayoutTestControllerWx.cpp: (LayoutTestController::setPluginsEnabled):
- 4:18 PM Changeset in webkit [58916] by
-
- 10 edits in trunk/WebCore
2010-05-06 James Robinson <jamesr@chromium.org>
Reviewed by Eric Seidel.
Fix warnings emitted by gcc 4.4.1 on linux in chromium-specific platform graphics files.
https://bugs.webkit.org/show_bug.cgi?id=38158
Fixes:
- replace NULL with 0
- remove unusued locals
add parens around ambiguous looking compound predicates like (a b && c) This also adds a check for x >= 0 to FontLinux.cpp's in this statement:
if (x < walker.width())
This is more documentation than anything else since walker.width() returns
an unsigned the current behavior is that x is promoted to unsigned and as
long as x + walker.width() is less than 231 all negative values of x
end up wrapping around and not being < walker.width(). This behavior is
tested by fast/text/international/khmer-selection.html
- platform/graphics/chromium/FontLinux.cpp: (WebCore::adjustTextRenderMode): (WebCore::TextRunWalker::TextRunWalker): (WebCore::TextRunWalker::length): (WebCore::TextRunWalker::width): (WebCore::TextRunWalker::getTextRun): (WebCore::TextRunWalker::getNormalizedTextRun): (WebCore::Font::offsetForPositionForComplexText):
- platform/graphics/chromium/FontPlatformDataLinux.cpp: (WebCore::FontPlatformData::setupPaint):
- platform/graphics/chromium/HarfbuzzSkia.cpp: (WebCore::getOutlinePoint):
- platform/graphics/skia/GraphicsContext3DSkia.cpp: (WebCore::GraphicsContext3D::getImageData):
- platform/graphics/skia/GraphicsContextSkia.cpp: (WebCore::isCoordinateSkiaSafe): (WebCore::GraphicsContext::fillRect): (WebCore::GraphicsContext::strokePath): (WebCore::GraphicsContext::strokeRect):
- 3:53 PM Changeset in webkit [58915] by
-
- 2 edits in trunk/WebCore
https://bugs.webkit.org/show_bug.cgi?id=38695
Reviewed by David Kilzer.
Check the result from widget() for NULL before accessing it.
- rendering/RenderIFrame.cpp:
(WebCore::RenderIFrame::calcHeight):
(WebCore::RenderIFrame::calcWidth):
- 3:41 PM Changeset in webkit [58914] by
-
- 44 edits in trunk/WebCore
2010-05-06 Maciej Stachowiak <mjs@apple.com>
Reviewed by Darin Adler.
further fixes towards REGRESSION (r57292): 1% PLT regression from visited link information leak fix
https://bugs.webkit.org/show_bug.cgi?id=38682
<rdar://problem/7859794>
Looks like a 1-2% speedup on PLT.
- Reorder CSS properties.
- Remove short circuit tag check in matchRulesForList which costs more than it saves.
- Inline initForStyleResolve.
- Optimize applyDeclarations to avoid switch and take fewer branches in the inner loop.
- Change the way Node handles flags - replace bitfield with a uint32_t and explicit masking, to make it cheaper to initialize the bits and give faster access.
- Added new Node flags to check for isStyledElement, isHTMLElement, isSVGElement, isComment, and devirtualize those methods.
- Inline constructors for Node, Element, Text, CharacterData, StyledElement, etc since they are very simple and lots of nodes get constructed.
- css/CSSPropertyNames.in: Move a few of the properties up front so we can check for them with < instead of switch statements
- css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::matchRulesForList): Remove unnecessary preflight check for tag match before checking selector. This check very rarely short circuits anything, since most rules with a tag end up in the appropriate tag bucket. So doing the check cost more time than the time saved. (WebCore::CSSStyleSelector::initForStyleResolve): Inline. Create RenderStyle in a better way. (WebCore::CSSStyleSelector::applyDeclarations): Get rid of switch statement and use <= to check for the high priority properties. Convert to template to avoid checking "applyFirst" each time through the loop. (WebCore::CSSStyleSelector::styleForElement): Adjust for new applyDeclarations() signature. (WebCore::CSSStyleSelector::keyframeStylesForAnimation): ditto (WebCore::CSSStyleSelector::pseudoStyleForElement): ditto
- css/CSSStyleSelector.h: Adjust for new applyDeclarations() signature.
- rendering/style/RenderStyle.cpp: (WebCore::RenderStyle::RenderStyle): Inline constructor.
- rendering/style/RenderStyle.h: Make constructor private so it can be inline.
- dom/Node.h: (WebCore::): See high-level description of changes above. Redid the way boolean flags work. (WebCore::Node::isElementNode): (WebCore::Node::isContainerNode): (WebCore::Node::isTextNode): (WebCore::Node::isHTMLElement): (WebCore::Node::isSVGElement): (WebCore::Node::isStyledElement): (WebCore::Node::isCommentNode): (WebCore::Node::hasID): (WebCore::Node::hasClass): (WebCore::Node::active): (WebCore::Node::inActiveChain): (WebCore::Node::inDetach): (WebCore::Node::hovered): (WebCore::Node::attached): (WebCore::Node::setAttached): (WebCore::Node::needsStyleRecalc): (WebCore::Node::styleChangeType): (WebCore::Node::childNeedsStyleRecalc): (WebCore::Node::isLink): (WebCore::Node::setHasID): (WebCore::Node::setHasClass): (WebCore::Node::setChildNeedsStyleRecalc): (WebCore::Node::clearChildNeedsStyleRecalc): (WebCore::Node::setInDocument): (WebCore::Node::clearInDocument): (WebCore::Node::setInActiveChain): (WebCore::Node::clearInActiveChain): (WebCore::Node::setIsLink): (WebCore::Node::clearIsLink): (WebCore::Node::setActive): (WebCore::Node::setHovered): (WebCore::Node::inDocument): (WebCore::Node::): (WebCore::Node::getFlag): (WebCore::Node::setFlag): (WebCore::Node::clearFlag): (WebCore::Node::hasRareData): (WebCore::Node::isParsingChildrenFinished): (WebCore::Node::setIsParsingChildrenFinished): (WebCore::Node::clearIsParsingChildrenFinished): (WebCore::Node::isStyleAttributeValid): (WebCore::Node::setIsStyleAttributeValid): (WebCore::Node::clearIsStyleAttributeValid): (WebCore::Node::isSynchronizingStyleAttribute): (WebCore::Node::setIsSynchronizingStyleAttribute): (WebCore::Node::clearIsSynchronizingStyleAttribute): (WebCore::Node::areSVGAttributesValid): (WebCore::Node::setAreSVGAttributesValid): (WebCore::Node::clearAreSVGAttributesValid): (WebCore::Node::isSynchronizingSVGAttributes): (WebCore::Node::setIsSynchronizingSVGAttributes): (WebCore::Node::clearIsSynchronizingSVGAttributes): (WebCore::Node::hasRareSVGData): (WebCore::Node::setHasRareSVGData): (WebCore::Node::clearHasRareSVGData): (WebCore::Node::initialRefCount):
- dom/Node.cpp: (WebCore::Node::trackForDebugging): Adjusted for changes in flag handling. (WebCore::Node::ensureRareData): ditto (WebCore::Node::setStyleChange): ditto (WebCore::Node::setNeedsStyleRecalc): ditto (WebCore::Node::lazyAttach): ditto (WebCore::Node::attach): ditto (WebCore::Node::detach): ditto (WebCore::Node::insertedIntoDocument): ditto (WebCore::Node::removedFromDocument): ditto
- dom/CharacterData.cpp:
- dom/CharacterData.h: (WebCore::CharacterData::CharacterData): Inline the constructor (moved from .cpp)
- dom/Comment.cpp: (WebCore::Comment::Comment): Tell the base class that we're a comment.
- dom/Comment.h: Remove isCommentNode override.
- dom/ContainerNode.cpp: (WebCore::ContainerNode::detach): Adjusted for changes in flag handling. (WebCore::ContainerNode::removedFromDocument): ditto
- dom/Document.cpp: (WebCore::Document::Document): Adjusted for changes in flag handling. (WebCore::Document::recalcStyle): ditto (WebCore::Document::setFocusedNode): ditto
- dom/Document.h: (WebCore::Node::Node): Inline the Node constructor - goes here because it uses Document.
- dom/DocumentFragment.cpp: include Document.h due to above change
- dom/EditingText.cpp: ditto
- dom/EntityReference.cpp: ditto
- dom/Element.cpp: (WebCore::Element::getAttribute): Adjusted for changes in flag handling. (WebCore::Element::setAttribute): ditto (WebCore::Element::hasAttributes): ditto (WebCore::Element::recalcStyle): ditto (WebCore::Element::finishParsingChildren): ditto
- dom/Element.h: (WebCore::Element::Element): Inline (moved from .cpp) (WebCore::Element::isFinishedParsingChildren): (WebCore::Element::beginParsingChildren): (WebCore::Element::attributes): Adjusted for changes in flag handling.
- dom/StyledElement.cpp: (WebCore::StyledElement::updateStyleAttribute): Adjust for changes to flag handling. (WebCore::StyledElement::mapToEntry): ditto (WebCore::StyledElement::parseMappedAttribute): ditto (WebCore::StyledElement::copyNonAttributeProperties): ditto
- dom/StyledElement.h: (WebCore::StyledElement::StyledElement): Inline (moved from.cpp) (WebCore::StyledElement::invalidateStyleAttribute): Adjust for changes in flag handling.
- dom/Text.h: (WebCore::Text::Text): Inline (moved from .cpp)
- dom/Text.cpp:
- html/HTMLAnchorElement.cpp: (WebCore::HTMLAnchorElement::HTMLAnchorElement): Adjust for changes in flag handling. (WebCore::HTMLAnchorElement::parseMappedAttribute): ditto
- html/HTMLElement.cpp: (WebCore::HTMLElement::create): Tell base class we're an HTML element.
- html/HTMLElement.h: ditto above; remove isHTMLElement override.
- html/HTMLFormControlElement.h: Tell base class we're an HTML element.
- html/HTMLFrameOwnerElement.cpp: (WebCore::HTMLFrameOwnerElement::HTMLFrameOwnerElement): ditto
- html/HTMLProgressElement.cpp: (WebCore::HTMLProgressElement::HTMLProgressElement): ditto
- mathml/MathMLElement.cpp: (WebCore::MathMLElement::MathMLElement): Tell base class we're a styled element.
- rendering/MediaControlElements.cpp: (WebCore::MediaControlShadowRootElement::MediaControlShadowRootElement): Adjust for changes in flag handling. (WebCore::MediaControlElement::MediaControlElement): ditto (WebCore::MediaControlInputElement::MediaControlInputElement): ditto
- rendering/RenderFileUploadControl.cpp: (WebCore::RenderFileUploadControl::updateFromElement): ditto
- rendering/RenderLayer.cpp: (WebCore::RenderLayer::updateHoverActiveState): ditto
- rendering/RenderProgress.cpp: (WebCore::RenderProgress::updateValuePartState): ditto
- rendering/RenderSlider.cpp: (WebCore::RenderSlider::updateFromElement): ditto
- rendering/SVGShadowTreeElements.cpp: (WebCore::SVGShadowTreeRootElement::SVGShadowTreeRootElement): ditto
- rendering/TextControlInnerElements.cpp: (WebCore::TextControlInnerElement::attachInnerElement): ditto
- svg/SVGAnimatedProperty.h: (WebCore::SVGAnimatedPropertyTearOff::setBaseVal): ditto (WebCore::SVGAnimatedPropertyTearOff::setAnimVal): ditto
- svg/SVGElement.cpp: (WebCore::SVGElement::SVGElement): Tell base class we're an svg element. (WebCore::SVGElement::ensureRareSVGData): Adjust for flag handling changes. (WebCore::SVGElement::updateAnimatedSVGAttribute): ditto
- svg/SVGElement.h: (WebCore::SVGElement::invalidateSVGAttributes): ditto
- svg/SVGPolyElement.cpp: (WebCore::SVGPolyElement::svgAttributeChanged): ditto
- wml/WMLAnchorElement.cpp: (WebCore::WMLAnchorElement::WMLAnchorElement): ditto
- wml/WMLElement.cpp: (WebCore::WMLElement::WMLElement): Tell base class we're a styled element.
- 3:28 PM Changeset in webkit [58913] by
-
- 4 edits in trunk/WebKit/mac
<rdar://problem/7951285> REGRESSION (r58847): Composited iframe content obscures Safari's application chrome
Reviewed by Simon Fraser.
Fixed this other regression from r58847. The regression was caused by overriding -visibleRect to
return the WebClipView’s full bounds. AppKit uses -visibleRect to determine the geometry
of the surface for the child WebFrameView. The fix is to restrict the special behavior of
-[WebClipView visibleRect] to when AppKit is consulting it for the purpose of invalidating
areas while scrolling.
- WebView/WebClipView.h:
- WebView/WebClipView.mm:
(-[WebClipView visibleRect]): If the WebClipView is not scrolling, always return
[super visibleRect].
(-[WebClipView _immediateScrollToPoint:]): Override this internal NSClipView method
to set a flag telling -visibleRect that the view is scrolling.
- WebView/WebView.mm:
(layerSyncRunLoopObserverCallBack): Ensure that screen updates, disabled by AppKit
when it thinks an upcoming window flush will re-enable them, are enabled here in
case the -setNeedsDisplayInRect: override has prevented the window from needing to be
flushed.
- 3:28 PM Changeset in webkit [58912] by
-
- 1 edit2 adds in trunk/LayoutTests
2010-05-06 John Gregg <johnnyg@google.com>
Unreviewed, rebaseline for chromium test.
[chromium] Deal with different local path structure on windows.
- platform/chromium-win/fast/notifications: Added.
- platform/chromium-win/fast/notifications/notifications-replace-expected.txt: Added.
- 3:19 PM Changeset in webkit [58911] by
-
- 3 edits in trunk/JavaScriptCore
Windows build fix.
- bytecode/SamplingTool.cpp:
(JSC::SamplingFlags::sample): Use a cast, so Windows will be happy when
this code is enabled.
- wtf/Platform.h: Reverted last change to this file, which seems to have
been accidental.
- 3:12 PM Changeset in webkit [58910] by
-
- 2 edits in trunk/WebCore
2010-05-06 Adam Barth <abarth@webkit.org>
Unreviewed. Fix indent. Sorry, my OCD was acting up.
- page/EventHandler.cpp: (WebCore::EventHandler::handleMouseReleaseEvent):
- 3:09 PM Changeset in webkit [58909] by
-
- 2 edits in trunk/LayoutTests
2010-05-06 Dirk Pranke <dpranke@chromium.org>
Unreviewed, expectations fix.
Delete a line for a test that is no longer failing on chromium linux.
- platform/chromium/test_expectations.txt:
- 2:20 PM BuildingQtOnSymbian edited by
- (diff)
- 1:50 PM Changeset in webkit [58908] by
-
- 3 edits in trunk/WebCore
2010-05-06 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Joseph Pecoraro.
Web Inspector: store selected Headers / Content tab on explicit switch and/or explicit navigate only.
- inspector/front-end/ResourceView.js: (WebInspector.ResourceView): (WebInspector.ResourceView.prototype._selectHeadersTab): (WebInspector.ResourceView.prototype.selectContentTab):
- inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel.prototype.showResource):
- 1:47 PM Changeset in webkit [58907] by
-
- 4 edits in trunk/JavaScriptCore
Add compile switch to make debugger keyword plant breakpoint instructions.
Reviewed by Oliver Hunt.
- bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::emitDebugHook):
- jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_debug):
- wtf/Platform.h:
- 1:38 PM Changeset in webkit [58906] by
-
- 2 edits in trunk/WebCore
2010-05-06 Luiz Agostini <luiz.agostini@openbossa.org>
Rubber-stamped by Simon Hausmann.
[Qt] use QT_MOBILE_THEME in Symbian
https://bugs.webkit.org/show_bug.cgi?id=38440
Putting QT_MOBILE_THEME into use for Symbian.
- WebCore.pro:
- 1:26 PM Changeset in webkit [58905] by
-
- 3 edits1 move in trunk/WebCore
2010-05-06 Laszlo Gombos <Laszlo Gombos>
Unreviewed, build fix WinCE for QtWebKit.
[Qt] Compilation with Plugins disabled is broken
https://bugs.webkit.org/show_bug.cgi?id=31407
Rename platform/qt/TemporaryLinkStubs.cpp to avoid name collition on
Windows.
Thanks for Ismail "cartman" Donmez for help.
No new tests, as there is no new functionality.
- WebCore.gypi:
- WebCore.pro:
- platform/qt/TemporaryLinkStubs.cpp: Removed.
- platform/qt/TemporaryLinkStubsQt.cpp: Copied from WebCore/platform/qt/TemporaryLinkStubs.cpp.
- 1:04 PM Changeset in webkit [58904] by
-
- 3 edits in trunk/JavaScriptCore
Fix ARM builds
- 1:01 PM Changeset in webkit [58903] by
-
- 2 edits in trunk/WebCore
2010-05-06 Simon Hausmann <simon.hausmann@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] REGRESSION: Loading of external CSS and JS files over network fails in some cases
https://bugs.webkit.org/show_bug.cgi?id=36755
Enable the direct connection between QtNetwork and QtWebKit only for Qt versions
greater than 4.6.2, due to a bug in Qt that's been fixed after 4.6.2.
- platform/network/qt/QNetworkReplyHandler.cpp:
- 12:39 PM Changeset in webkit [58902] by
-
- 14 edits9 adds in trunk
2010-05-06 Oliver Hunt <oliver@apple.com>
Reviewed by Geoffrey Garen.
Improve performance of single character string compares
https://bugs.webkit.org/show_bug.cgi?id=38659
Add logic to the jit to identify comparisons to single character string literals
and then just perform the comparison inline, rather than ignoring the evidence
and attempting to perform an integer comparison.
Multiple changes required -- add jnlesseq opcode, add helper function to identify
single character string constants, add a helper to load single character strings.
Then add the 32_64 and normal codepaths to the JIT.
- assembler/MacroAssemblerX86Common.h: (JSC::MacroAssemblerX86Common::load16):
- bytecode/CodeBlock.cpp: (JSC::CodeBlock::dump):
- bytecode/Opcode.h:
- bytecompiler/BytecodeGenerator.cpp: (JSC::BytecodeGenerator::emitJumpIfTrue):
- interpreter/Interpreter.cpp: (JSC::Interpreter::privateExecute):
- jit/JIT.cpp: (JSC::JIT::privateCompileMainPass): (JSC::JIT::privateCompileSlowCases):
- jit/JIT.h:
- jit/JITArithmetic.cpp: (JSC::JIT::emit_op_jnless): (JSC::JIT::emitSlow_op_jnless): (JSC::JIT::emit_op_jless): (JSC::JIT::emitSlow_op_jless): (JSC::JIT::emit_op_jlesseq): (JSC::JIT::emit_op_jnlesseq): (JSC::JIT::emitSlow_op_jlesseq): (JSC::JIT::emitSlow_op_jnlesseq):
- jit/JITArithmetic32_64.cpp: (JSC::JIT::emit_op_jnless): (JSC::JIT::emitSlow_op_jnless): (JSC::JIT::emit_op_jless): (JSC::JIT::emitSlow_op_jless): (JSC::JIT::emit_op_jlesseq): (JSC::JIT::emit_op_jnlesseq): (JSC::JIT::emitSlow_op_jlesseq): (JSC::JIT::emitSlow_op_jnlesseq): (JSC::JIT::emitBinaryDoubleOp):
- jit/JITInlineMethods.h: (JSC::JIT::emitLoadCharacterString): (JSC::JIT::isOperandConstantImmediateChar):
- jit/JSInterfaceJIT.h: (JSC::ThunkHelpers::stringImplDataOffset): (JSC::ThunkHelpers::jsStringLengthOffset): (JSC::ThunkHelpers::jsStringValueOffset): Moved from ThunkGenerators to make it possible to share.
- jit/ThunkGenerators.cpp:
2010-05-06 Oliver Hunt <oliver@apple.com>
Reviewed by Geoffrey Garen.
Improve performance of single character string compares
https://bugs.webkit.org/show_bug.cgi?id=38659
Add many tests of <, >, <=, >=, ==, ===, !=, !== as the existing
tests were woefully inadequate.
- fast/js/comparison-operators-expected.txt: Added.
- fast/js/comparison-operators-greater-expected.txt: Added.
- fast/js/comparison-operators-greater.html: Added.
- fast/js/comparison-operators-less-expected.txt: Added.
- fast/js/comparison-operators-less.html: Added.
- fast/js/comparison-operators.html: Added.
- fast/js/script-tests/comparison-operators-greater.js: Added. (description.makeTest.func.f.toString): (description.makeTest): (doTest):
- fast/js/script-tests/comparison-operators-less.js: Added. (description.makeTest.func.f.toString): (description.makeTest): (doTest):
- fast/js/script-tests/comparison-operators.js: Added. (description.makeTest.func.f.toString): (description.makeTest): (doTest):
- 12:06 PM Changeset in webkit [58901] by
-
- 6 edits in trunk/WebKit/gtk
2010-05-06 Martin Robinson <Martin Robinson>
Reviewed by Xan Lopez.
Remove use of GOwnPtr to hold GObject types.
https://bugs.webkit.org/show_bug.cgi?id=38669
Change use of GOwnPtr to GRefPtr to types which are natively reference-counted.
- WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::dispatchWillSendRequest): Change GOwnPtr to GRefPtr in some places. (WebKit::FrameLoaderClient::dispatchDecidePolicyForMIMEType): Ditto.
- webkit/webkitnetworkrequest.cpp: (webkit_network_request_new_with_core_request): Ditto.
- webkit/webkitnetworkresponse.cpp: (webkit_network_response_new_with_core_response): Ditto.
- webkit/webkitprivate.cpp: Remove GOwnPtr reference counting template specialization.
- webkit/webkitprivate.h: Ditto.
- 11:50 AM Changeset in webkit [58900] by
-
- 2 edits in trunk/WebKit/win
2010-05-06 Adam Roben <Adam Roben>
Bail out of WebView::paint when there's nothing to paint
Fixes <http://webkit.org/b/38670> <rdar://problem/7947105> REGRESSION
(r58067): Crash in WebView::paint when Web Inspector is docked and
window is resized so small that WebView disappears
When the WebView is 0-sized, ensureBackingStore() bails out without
creating a bitmap, leaving m_backingStoreBitmap null. Before r58067,
m_backingStoreBitmap was an HBITMAP, so we were happily passing along
a null HBITMAP to various Windows APIs. These calls would fail but not
crash. r58067 changed m_backingStoreBitmap to a RefCountedHBITMAP, and
dereferencing a null RefCountedHBITMAP* of course crashes.
Reviewed by Steve Falkenburg.
- WebView.cpp: (WebView::paint): Bail if the rect to paint is empty.
- 11:47 AM Changeset in webkit [58899] by
-
- 2 edits in trunk/LayoutTests
2010-05-06 John Gregg <johnnyg@google.com>
Unreviewed. Updating test expectations.
[chromium] enabling notifications tests after test_shell change.
- platform/chromium/test_expectations.txt:
- 11:46 AM Changeset in webkit [58898] by
-
- 2 edits in trunk/WebCore
2010-05-06 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Reviewed by Xan Lopez.
Rework where we get page step and line step from, so we do not
depend on scrollbars existing. Caught by API test I forgot to run.
- platform/gtk/ScrollViewGtk.cpp: (WebCore::ScrollView::setGtkAdjustments):
- 10:47 AM Changeset in webkit [58897] by
-
- 2 edits in trunk/WebCore
2010-05-06 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Reviewed by Xan Lopez.
[GTK] Adjustment resetting uses wrong values, and misses page_size and steps
https://bugs.webkit.org/show_bug.cgi?id=38657
Fix resetting adjustment values. In the page cache case, we were
confusing page_size and upper, leading to stray scrollbars
sometimes.
- platform/gtk/ScrollViewGtk.cpp: (WebCore::ScrollView::setGtkAdjustments):
- 10:42 AM Changeset in webkit [58896] by
-
- 3 edits in trunk/LayoutTests
2010-05-06 Ojan Vafai <ojan@chromium.org>
Reviewed by Adam Barth.
editing/selection/shift-click.html fails on GTK and QT
https://bugs.webkit.org/show_bug.cgi?id=38656
r58892 added this test. It's the first test for shift+click behavior,
so it exposed bugs in GTK/QT. Skipping to green the bots.
- platform/gtk/Skipped:
- platform/qt/Skipped:
- 10:37 AM Changeset in webkit [58895] by
-
- 2 edits in trunk/WebKit/win
2010-05-06 Steve Falkenburg <sfalken@apple.com>
Reviewed by Adam Roben.
WebFrame::paintDocumentRectToContext paints content at the wrong location
https://bugs.webkit.org/show_bug.cgi?id=38651
- WebFrame.cpp: (WebFrame::paintDocumentRectToContext):
- 10:12 AM Changeset in webkit [58894] by
-
- 2 edits in trunk/WebCore
2010-05-06 Darin Adler <Darin Adler>
Reviewed by Beth Dakin.
Page::setCanStartMedia does not properly handle the case where a media listener is removed
https://bugs.webkit.org/show_bug.cgi?id=38602
We can't find any real case where this causes a crash at this time, but
we want to harden the code anyway. Thus there are no new regression tests.
- page/Page.cpp: (WebCore::Page::removeMediaCanStartListener): Removed incorrect assertion. (WebCore::Page::setCanStartMedia): Change algorithm so we notify listeners one at a time and don't notify any listener that has already been removed from the set.
- 10:05 AM Changeset in webkit [58893] by
-
- 9 edits in trunk/LayoutTests
2010-05-06 Evan Martin <evan@chromium.org>
Unreviewed. Updating test expectations.
[chromium] new baselines for r58886
https://bugs.webkit.org/show_bug.cgi?id=38652
- platform/chromium-linux/fast/lists/w3-css3-list-styles-numeric-expected.txt:
- platform/chromium-linux/fast/text/international/danda-space-expected.checksum:
- platform/chromium-linux/fast/text/international/danda-space-expected.png:
- platform/chromium-linux/fast/text/international/danda-space-expected.txt:
- platform/chromium-linux/fast/text/international/thai-baht-space-expected.checksum:
- platform/chromium-linux/fast/text/international/thai-baht-space-expected.png:
- platform/chromium-linux/fast/text/international/thai-baht-space-expected.txt:
- platform/chromium/test_expectations.txt:
- 9:58 AM Changeset in webkit [58892] by
-
- 3 edits4 adds in trunk
2010-05-05 Ojan Vafai <ojan@chromium.org>
Reviewed by Darin Adler.
shift+click on an existing selection doesn't work right
https://bugs.webkit.org/show_bug.cgi?id=36542
NSTextView behavior is to move the end of the selection
closest to the shift-click. Win/Linux behavior is to always
move the focus end of the selection.
- editing/selection/script-tests/shift-click.js: Added. (shiftClick): (assertSelectionString):
- editing/selection/shift-click-expected.txt: Added.
- editing/selection/shift-click.html: Added.
- platform/win/editing/selection/shift-click-expected.txt: Added.
2010-05-05 Ojan Vafai <ojan@chromium.org>
Reviewed by Darin Adler.
shift+click on an existing selection doesn't work right
https://bugs.webkit.org/show_bug.cgi?id=36542
NSTextView behavior is to move the end of the selection
closest to the shift-click. Win/Linux behavior is to always
move the focus end of the selection.
Test: editing/selection/shift-click.html
- page/EventHandler.cpp: (WebCore::textDistance): (WebCore::EventHandler::handleMousePressEventSingleClick):
- 9:53 AM Changeset in webkit [58891] by
-
- 2 edits in trunk/WebCore
2010-05-06 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: implement panels history traversal on Cmd+Left/Right.
- inspector/front-end/inspector.js: (WebInspector.set currentPanel): (WebInspector.loaded): (WebInspector.documentKeyDown): (WebInspector.PanelHistory): (WebInspector.PanelHistory.prototype.canGoBack): (WebInspector.PanelHistory.prototype.goBack): (WebInspector.PanelHistory.prototype.canGoForward): (WebInspector.PanelHistory.prototype.goForward): (WebInspector.PanelHistory.prototype.setPanel):
- 9:49 AM Changeset in webkit [58890] by
-
- 4 edits in trunk
2010-05-06 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Chromium Dev Tools: Large toolbar icons flash when dev
tools is opened in docked mode.
- src/js/DevTools.js: (devtools.domContentLoaded):
- 9:46 AM Changeset in webkit [58889] by
-
- 2 edits in trunk/WebKitTools
2010-05-06 Jochen Eisinger <jochen@chromium.org>
Reviewed by Dimitri Glazkov.
Make ImageDiff depend on WebKit. When compiled from within Chromium, WTF is not a standalone dynamic library but depends on WebKit.
https://bugs.webkit.org/show_bug.cgi?id=38632
- DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
- 9:43 AM Changeset in webkit [58888] by
-
- 4 edits4 deletes in trunk/LayoutTests
2010-05-05 Antonio Gomes <tonikitoo@webkit.org>
Rubber-stamped by Kenneth Christiansen.
Spatial Navigation: use data url in layout tests
https://bugs.webkit.org/show_bug.cgi?id=38584
In order to make Spatial Navigation layout tests more readable, patch
changes the use or src=resources/iframeXXX.html by inlined sources via
data uri schema.
It is a polishment.
- fast/events/spatial-navigation/resources/iframe.html: Removed.
- fast/events/spatial-navigation/resources/iframe2.html: Removed.
- fast/events/spatial-navigation/resources/iframe3.html: Removed.
- fast/events/spatial-navigation/resources/iframe4.html: Removed.
- fast/events/spatial-navigation/snav-iframe-no-focusable-content.html:
- fast/events/spatial-navigation/snav-iframe-no-scrollable-content.html:
- fast/events/spatial-navigation/snav-iframe-with-offscreen-focusable-element.html:
- 9:42 AM Changeset in webkit [58887] by
-
- 1 edit in trunk/LayoutTests/platform/gtk/Skipped
2010-05-06 Antonio Gomes <tonikitoo@webkit.org>
[Gtk] Skipped fast/events/spatial-navigation/snav-iframe-flattening-simple.html
DRT does not support frame flattening testing.
https://bugs.webkit.org/show_bug.cgi?id=38650
- platform/gtk/Skipped:
- 9:34 AM Changeset in webkit [58886] by
-
- 2 edits in trunk/WebCore
2010-05-03 Evan Martin <evan@chromium.org>
Reviewed by Eric Seidel.
[chromium] use glyphDataForCharacter so we hit the glyphdata cache
https://bugs.webkit.org/show_bug.cgi?id=38500
Calling fontDataForCharacters() while rendering text is expensive.
Examining the relevant Mac code in WebKit revealed that calling the
similarly-named glyphDataForCharacters() results in caching the font
data on a per-glyph basis.
Since we now choose a font based on the first character in a run, we
need to be careful that all the glyphs within the run use the same font.
This is also similar to the WebKit Mac code. We need to remove all of
the script run bits eventually and this is a step in that direction.
Tests: fast/text/international/danda-space.html spacing changes slightly
(now matches Firefox better) and fast/text/international/thai-baht-space.html
now picks the correct (serif) font for the digits.
- platform/graphics/chromium/FontLinux.cpp: (WebCore::TextRunWalker::nextScriptRun): (WebCore::TextRunWalker::setupFontForScriptRun):
- 9:32 AM Changeset in webkit [58885] by
-
- 11 edits in trunk
2010-05-06 Martin Robinson <Martin Robinson>
Reviewed by Gustavo Noronha Silva.
[GTK] Enable DOM clipboard and drag-and-drop access
https://bugs.webkit.org/show_bug.cgi?id=30623
Convert dragging portion of drag-and-drop to use DataObjectGtk.
- wtf/gobject/GRefPtr.h: Add forward declarations for GObject functions.
2010-05-06 Martin Robinson <Martin Robinson>
Reviewed by Gustavo Noronha Silva.
[GTK] Enable DOM clipboard and drag-and-drop access
https://bugs.webkit.org/show_bug.cgi?id=30623
Convert dragging portion of drag-and-drop to use DataObjectGtk.
No new tests, because functionality has not changed.
- page/gtk/EventHandlerGtk.cpp: (WebCore::EventHandler::createDraggingClipboard): Pass the DataObjectGtk as a parameter here.
- platform/gtk/ClipboardGtk.h: (WebCore::ClipboardGtk::create): Take the DataObject as a parameter instead of creating it here. (WebCore::ClipboardGtk::helper): Added. (WebCore::ClipboardGtk::dataObject): Added.
- platform/gtk/PasteboardHelper.h: Make targetListForDataObject a public method.
2010-05-06 Martin Robinson <Martin Robinson>
Reviewed by Gustavo Noronha Silva.
[GTK] Enable DOM clipboard and drag-and-drop access
https://bugs.webkit.org/show_bug.cgi?id=30623
Convert dragging portion of drag-and-drop to use DataObjectGtk.
- WebCoreSupport/DragClientGtk.cpp: (WebKit::DragClient::willPerformDragDestinationAction): Remove the notImplemented. It is implemented, it's just a no-op. (WebKit::DragClient::startDrag): Start the drag context via the ClipboardGtk and PasteboardHelper now.
- WebCoreSupport/DragClientGtk.h: Small style fix.
- webkit/webkitprivate.h: Add a HashMap of contexts and DataObjects here to to represent all current drag operations.
- webkit/webkitwebview.cpp: (webkit_web_view_dispose): Clear all data objects during disposal. (webkit_web_view_drag_end): When a drag is over, just remove it from the map. (webkit_web_view_drag_data_get): To get the drag data, just grab it from the DataObject.
- 9:30 AM Changeset in webkit [58884] by
-
- 6 edits in trunk/WebCore
2010-05-06 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: Do not show content tab for resources
not supporting content preview.
- English.lproj/localizedStrings.js:
- inspector/front-end/FontView.js: (WebInspector.FontView.prototype.hasContentTab):
- inspector/front-end/ImageView.js: (WebInspector.ImageView.prototype.hasContentTab):
- inspector/front-end/ResourceView.js: (WebInspector.ResourceView): (WebInspector.ResourceView.prototype._selectTab): (WebInspector.ResourceView.prototype.hasContentTab):
- inspector/front-end/SourceView.js: (WebInspector.SourceView.prototype.hasContentTab):
- 9:23 AM Changeset in webkit [58883] by
-
- 1 edit2 adds in trunk/LayoutTests
2010-05-05 Antonio Gomes <tonikitoo@webkit.org>
Reviewed by Kenneth Christiansen.
Spatial Navigation: Add LayoutTest with frame flattening feature on.
https://bugs.webkit.org/show_bug.cgi?id=38585
- fast/events/spatial-navigation/snav-iframe-flattening-simple-expected.txt: Added.
- fast/events/spatial-navigation/snav-iframe-flattening-simple.html: Added.
- 9:17 AM Changeset in webkit [58882] by
-
- 3 edits in trunk/WebCore
2010-05-06 Antonio Gomes <tonikitoo@webkit.org>
Reviewed by Kenneth Christiansen.
Spatial Navigation: adapt the logic of {deep}findFocusableNodeInDirection to do traversal starting from Node* not Document*
https://bugs.webkit.org/show_bug.cgi?id=37803
Instead of receiving a Document pointer as incoming parameter, patch modifies
findFocusableNodeInDirection and deepFindFocusableNodeInDirection methods to
receive a Node pointer as start for content traversal.
This way we can make good use of deepFindFocusableNodeInDirection to traverse
other scrollable container like scrollable div's, and not only frames or iframes.
Patch also makes use of 'while' instead of 'for' to loop control, that gives move
flexibility to the incremental step: e.g. if a scrollable div was processed, the incremental
step in the loop does not have to do node->traverseNextNode() but node->traverseNextSibling().
No behavior change. It is a preparation for supporting scrollable containers in Spatial
Navigation.
- page/FocusController.cpp: (WebCore::FocusController::advanceFocusDirectionally): (WebCore::FocusController::findFocusableNodeInDirection): (WebCore::FocusController::deepFindFocusableNodeInDirection):
- page/FocusController.h:
- 9:04 AM Changeset in webkit [58881] by
-
- 2 edits in trunk/WebCore
Unreviewed WinCE buildfix after r58842.
Preprocessor doesn't understand "true", changed to "1"
- platform/graphics/MediaPlayer.cpp:
- 8:31 AM Changeset in webkit [58880] by
-
- 2 edits in trunk/WebCore
2010-05-06 Mikhail Naganov <mnaganov@chromium.org>
Reviewed by Pavel Feldman.
Temporarily disable 'console.profiles' until we can distinguish
functions from different frames
- bindings/v8/custom/V8ConsoleCustom.cpp: (WebCore::V8Console::profilesAccessorGetter):
- 8:13 AM Changeset in webkit [58879] by
-
- 2 edits6 adds in trunk/LayoutTests
2010-05-06 Vitaly Repeshko <vitalyr@chromium.org>
[chromium] Unreviewed. Updating expectations.
- platform/chromium-linux/fast/url/segments-expected.txt: Added.
- platform/chromium-linux/fast/url/segments-from-data-url-expected.txt: Added.
- platform/chromium-mac/fast/url/segments-expected.txt: Added.
- platform/chromium-mac/fast/url/segments-from-data-url-expected.txt: Added.
- platform/chromium-win/fast/url/segments-expected.txt: Added.
- platform/chromium-win/fast/url/segments-from-data-url-expected.txt: Added.
- platform/chromium/test_expectations.txt:
- 7:12 AM QtWebKitTriageRoster edited by
- (diff)
- 7:09 AM Changeset in webkit [58878] by
-
- 26 edits in trunk
2010-05-06 Steve Block <steveblock@google.com>
Reviewed by Eric Seidel.
MAC_JAVA_BRIDGE should be renamed JAVA_BRIDGE
https://bugs.webkit.org/show_bug.cgi?id=38544
- wtf/Platform.h:
2010-05-06 Steve Block <steveblock@google.com>
Reviewed by Eric Seidel.
MAC_JAVA_BRIDGE should be renamed JAVA_BRIDGE
https://bugs.webkit.org/show_bug.cgi?id=38544
No new tests, build fix only.
- DerivedSources.make:
- bindings/js/ScriptController.cpp: (WebCore::ScriptController::ScriptController):
- bindings/js/ScriptController.h:
- bindings/js/ScriptControllerMac.mm: (WebCore::ScriptController::createScriptInstanceForWidget):
- bridge/jni/JNIBridge.cpp:
- bridge/jni/JNIBridge.h:
- bridge/jni/JNIUtility.cpp:
- bridge/jni/JNIUtility.h:
- bridge/jni/jni_jsobject.h:
- bridge/jni/jni_jsobject.mm:
- bridge/jni/jni_objc.mm:
- bridge/jni/jsc/JNIBridgeJSC.cpp:
- bridge/jni/jsc/JNIBridgeJSC.h:
- bridge/jni/jsc/JNIUtilityPrivate.cpp:
- bridge/jni/jsc/JNIUtilityPrivate.h:
- bridge/jni/jsc/JavaClassJSC.cpp:
- bridge/jni/jsc/JavaClassJSC.h:
- bridge/jni/jsc/JavaInstanceJSC.cpp:
- bridge/jni/jsc/JavaInstanceJSC.h:
- loader/FrameLoaderClient.h:
2010-05-06 Steve Block <steveblock@google.com>
Reviewed by Eric Seidel.
MAC_JAVA_BRIDGE should be renamed JAVA_BRIDGE
https://bugs.webkit.org/show_bug.cgi?id=38544
- WebCoreSupport/WebFrameLoaderClient.h:
- WebCoreSupport/WebFrameLoaderClient.mm:
- 6:12 AM Changeset in webkit [58877] by
-
- 2 edits in trunk/WebKit/qt
2010-05-06 Andreas Kling <andreas.kling@nokia.com>
Reviewed by Simon Hausmann.
[Qt] Patch to fix compilation warnings for QGraphicsWebView
https://bugs.webkit.org/show_bug.cgi?id=37428
Patch by Alexis Menard <alexis.menard@nokia.com>
- Api/qgraphicswebview.cpp: (QGraphicsWebView::itemChange):
- 6:00 AM Changeset in webkit [58876] by
-
- 8 edits in trunk
2010-05-06 Simon Hausmann <simon.hausmann@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Replace public inspector url with private property for QtLauncher
https://bugs.webkit.org/show_bug.cgi?id=35340
Replace the public API with a private dynamic property until this feature
is ready.
- Api/qwebsettings.cpp:
- Api/qwebsettings.h:
- WebCoreSupport/InspectorClientQt.cpp: (WebCore::InspectorClientQt::openInspectorFrontend):
- symbian/bwins/QtWebKitu.def:
- symbian/eabi/QtWebKitu.def:
2010-05-06 Simon Hausmann <simon.hausmann@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Replace public inspector url with private property for QtLauncher
https://bugs.webkit.org/show_bug.cgi?id=35340
Replace the public API with a private dynamic property until this feature
is ready.
- QtLauncher/main.cpp: (LauncherWindow::init):
- 2:44 AM Changeset in webkit [58875] by
-
- 4 edits in trunk
2010-05-05 Alejandro G. Castro <alex@igalia.com>
Reviewed by Xan Lopez.
Fixed the gobject introspection compilation with the new DOM
bindings, we needed to add DOM objects.
- GNUmakefile.am:
- 2:31 AM Changeset in webkit [58874] by
-
- 2 edits2 adds in trunk/JavaScriptCore
2010-05-06 Adam Barth <abarth@webkit.org>
Reviewed by Maciej Stachowiak.
[WTFURL] Add a class to represent the segments of a URL
https://bugs.webkit.org/show_bug.cgi?id=38566
When paired with a string, this class represents a parsed URL.
- wtf/url/src/URLSegments.cpp: Added. (WTF::URLSegments::length): (WTF::URLSegments::charactersBefore):
- wtf/url/src/URLSegments.h: Added. (WTF::URLSegments::): (WTF::URLSegments::URLSegments):
- wtf/url/wtfurl.gyp:
- 2:19 AM Changeset in webkit [58873] by
-
- 11 edits in trunk
2010-05-06 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
drop support for sessionStorage in sandbox iframes
https://bugs.webkit.org/show_bug.cgi?id=38151
Update test expectation. This test was originally created to show that
we complied with the letter of the spec, but our behavior is insecure.
In the future, we might revert this change and implement a separate
storage area for each unique origin.
- fast/frames/resources/sandboxed-iframe-storage-disallowed.html:
- fast/frames/sandboxed-iframe-storage-expected.txt:
2010-05-06 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
drop support for sessionStorage in sandbox iframes
https://bugs.webkit.org/show_bug.cgi?id=38151
This patch causes us to throw a security exception when a sandboxed
iframe attempts to access sessionStorage, matching our behavior for
localStorage. The letter of the spec asks us to create a separate
storage area for each unique origin. We might want to do that in a
future patch, but throwing a security error seems like a safe move now.
- page/DOMWindow.cpp: (WebCore::DOMWindow::sessionStorage): (WebCore::DOMWindow::localStorage):
- page/DOMWindow.h:
- page/DOMWindow.idl:
- page/SecurityOrigin.h: (WebCore::SecurityOrigin::canAccessSessionStorage):
- storage/StorageEventDispatcher.cpp: (WebCore::StorageEventDispatcher::dispatch):
2010-05-06 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
drop support for sessionStorage in sandbox iframes
https://bugs.webkit.org/show_bug.cgi?id=38151
Update client of sessionStorage to handle exceptions.
- src/StorageAreaProxy.cpp: (WebCore::StorageAreaProxy::storageEvent):
- 1:51 AM Changeset in webkit [58872] by
-
- 4 edits3 adds in trunk
WebCore: Allow forms submitting to target="_blank" to open popups if the submission
originated from a user gesture.
Reviewed by Maciej Stachowiak.
https://bugs.webkit.org/show_bug.cgi?id=37335
<rdar://problem/7884980>
Test: fast/events/popup-allowed-from-gesture-initiated-form-submit.html
- bindings/js/ScriptController.cpp:
(WebCore::ScriptController::processingUserGesture): If no DOM event is
being processed, consult UserGestureIndicator to determine return value.
- bindings/js/ScriptController.h: Moved the logic of processingUserGestureEvent()
into processingUserGesture().
LayoutTests: Add a test to ensure popups are allowed when the user submits a form with target="_blank".
Reviewed by Maciej Stachowiak.
https://bugs.webkit.org/show_bug.cgi?id=37335
<rdar://problem/7884980>
- fast/events/popup-allowed-from-gesture-initiated-form-submit-expected.txt: Added.
- fast/events/popup-allowed-from-gesture-initiated-form-submit.html: Added.
- fast/events/resources/popup-allowed-from-gesture-initiated-form-submit-target.html: Added.
- 1:10 AM Changeset in webkit [58871] by
-
- 3 edits in trunk/WebCore
2010-05-06 Xan Lopez <xlopez@igalia.com>
Rubber-stamped by Eric Seidel.
[GTK] Refactor GenerateProperties in CodeGenerationGObject.pm
https://bugs.webkit.org/show_bug.cgi?id=38577
Thinko caught while refactoring, $custom variable was not
initialized.
- bindings/scripts/CodeGeneratorGObject.pm:
- bindings/scripts/test/GObject/WebKitDOMTestObj.cpp: (webkit_dom_test_obj_set_property): (webkit_dom_test_obj_get_property): (webkit_dom_test_obj_class_init):
- 1:09 AM Changeset in webkit [58870] by
-
- 2 edits in trunk/WebCore
2010-05-06 Xan Lopez <xlopez@igalia.com>
Rubber-stamped by Eric Seidel.
[GTK] Refactor GenerateProperties in CodeGenerationGObject.pm
https://bugs.webkit.org/show_bug.cgi?id=38577
Refactor GenerateProperty out of GenerateProperties. This is in
preparation for EventListeren attributes, which won't generate
normal GObject properties.
- bindings/scripts/CodeGeneratorGObject.pm:
- 1:01 AM Changeset in webkit [58869] by
-
- 5 edits in trunk/WebCore
2010-05-06 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Joseph Pecoraro.
Web Inspector: follow up to linkify event listeners.
- bindings/js/ScriptEventListener.cpp: (WebCore::eventListenerHandlerLocation):
- bindings/v8/ScriptEventListener.cpp: (WebCore::eventListenerHandlerLocation):
- inspector/front-end/ElementsPanel.js: (WebInspector.ElementsPanel.prototype.linkifyNodeReference):
- inspector/front-end/EventListenersSidebarPane.js:
- 12:05 AM Changeset in webkit [58868] by
-
- 2 edits in trunk/WebKitTools
2010-05-05 Joseph Pecoraro <Joseph Pecoraro>
Reviewed by Pavel Feldman.
Web Inspector: build-webkit --inspector-frontend Should Exclude *.re2js
https://bugs.webkit.org/show_bug.cgi?id=38449
- Scripts/webkitdirs.pm:
May 5, 2010:
- 11:54 PM Changeset in webkit [58867] by
-
- 14 edits4 adds in trunk
2010-05-05 Charles Wei <charles.wei@torchmobile.com.cn>
Reviewed by George Staikos
https://bugs.webkit.org/show_bug.cgi?id=37848
Add test cases for -wap-input-format and -wap-input-required of WCSS
- fast/wcss/wap-input-format-expected.txt: Added.
- fast/wcss/wap-input-format.xhtml: Added.
- fast/wcss/wap-input-required-expected.txt: Added.
- fast/wcss/wap-input-required.xhtml: Added.
2010-05-05 Charles Wei <charles.wei@torchmobile.com.cn>
Reviewed by George Staikos
https://bugs.webkit.org/show_bug.cgi?id=37848
This patch adds WCSS -wap-input-format and -wap-input-required support to WebKit
Tests: fast/wcss/wap-input-format.xhtml
fast/wcss/wap-input-required.xhtml
- css/CSSParser.cpp: (WebCore::CSSParser::parseValue): (WebCore::CSSParser::parseWCSSInputProperty):
- css/CSSParser.h:
- css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty):
- css/WCSSPropertyNames.in:
- dom/InputElement.cpp: (WebCore::InputElement::sanitizeValue): (WebCore::InputElement::handleBeforeTextInsertedEvent): (WebCore::InputElementData::InputElementData): (WebCore::formatCodes): (WebCore::cursorPositionToMaskIndex): (WebCore::InputElement::isConformToInputMask): (WebCore::InputElement::validateInputMask):
- dom/InputElement.h: (WebCore::InputElementData::inputFormatMask): (WebCore::InputElementData::setInputFormatMask): (WebCore::InputElementData::maxInputCharsAllowed): (WebCore::InputElementData::setMaxInputCharsAllowed):
- html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::setWapInputFormat):
- html/HTMLInputElement.h: (WebCore::HTMLInputElement::data):
- wml/WMLInputElement.h: (WebCore::WMLInputElement::data):
2010-05-05 Charles Wei <charles.wei@torchmobile.com.cn>
Reviewed by George Staikos
This patch adds WCSS -wap-input-format and -wap-input-required support to WebKit
Make the test cases in fast/wcss optionional only when WCSS is enabled.
- Scripts/old-run-webkit-tests:
- Scripts/webkitperl/features.pm:
- 11:23 PM Changeset in webkit [58866] by
-
- 2 edits in trunk/LayoutTests
2010-05-05 Shinichiro Hamaji <hamaji@chromium.org>
Reviewed by Eric Seidel.
[GTK] Markup of copied non ASCII characters is broken
https://bugs.webkit.org/show_bug.cgi?id=37918
This test was fixed by http://trac.webkit.org/changeset/58468
- platform/gtk/Skipped:
- 11:06 PM Changeset in webkit [58865] by
-
- 2 edits in trunk/WebKit/mac
Fixed a crash when closing Top Sites after r58847.
Reviewed by Mark Rowe.
- WebView/WebFrameView.mm:
(-[WebFrameView webFrame]): Null-check _private.
- 11:02 PM Changeset in webkit [58864] by
-
- 6 edits in trunk/WebCore
2010-05-05 MORITA Hajime <morrita@google.com>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=38150
Refactoring: webkitEditableContentChangedEvent should be handled by the owner of appropriate the renderer.
Moved a part of code chunk in HTMLFormControlElementWithState::defaultEventHandler()
which accesses the renderer from foreign node,
to TextControlInnerTextElement::defaultEventHandler() which owns the renderer.
No new tests. No behavioral change.
- html/HTMLFormControlElement.cpp: (WebCore::HTMLFormControlElementWithState::defaultEventHandler):
- html/HTMLFormControlElement.h:
- html/HTMLInputElement.h:
- html/HTMLTextAreaElement.h:
- rendering/TextControlInnerElements.cpp: (WebCore::TextControlInnerTextElement::defaultEventHandler):
- 10:47 PM Changeset in webkit [58863] by
-
- 2 edits in trunk/LayoutTests
[Qt] Enable Sputnik tests.
https://bugs.webkit.org/show_bug.cgi?id=38457
Rubber-stamped by Alexey Proskuryakov.
- platform/qt/Skipped: Only skip tests that fail.
- 10:40 PM Changeset in webkit [58862] by
-
- 3 edits in trunk/WebKitTools
2010-05-05 Kent Tamura <tkent@chromium.org>
Reviewed by Eric Seidel.
[DRT/Chromium] Remove InitWebCoreSystemInterface() call
https://bugs.webkit.org/show_bug.cgi?id=38624
Chromium r45167 <http://src.chromium.org/viewvc/chrome?view=rev&revision=45167>
added InitWebCoreSystemInterface() to webkit/support/platform_support_mac.mm.
So we don't need to call it from DumpRenderTree.cpp anymore.
- DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
- DumpRenderTree/chromium/DumpRenderTree.cpp: (main): Remove InitWebCoreSystemInterface().
- 10:34 PM Changeset in webkit [58861] by
-
- 3 edits1 delete in trunk/LayoutTests
2010-05-05 Steven Lai <steven_lai@asia.apple.com>
Reviewed by Alexey Proskuryakov.
Remove platform specific test result
Don't print the formatted string of the z-index in the test case
since there's a risk that the output on different c stdlib implementations/platforms/locale could be different
https://bugs.webkit.org/show_bug.cgi?id=38617.
- fast/dom/clone-node-z-index-expected.txt:
- fast/dom/clone-node-z-index.html:
- platform/win/fast/dom/clone-node-z-index-expected.txt: Removed.
- 10:23 PM Changeset in webkit [58860] by
-
- 1 edit3 adds in trunk/LayoutTests
2010-05-05 Adam Barth <abarth@webkit.org>
Reviewed by Alexey Proskuryakov.
Add a test of URL segmentation from a data URL base
https://bugs.webkit.org/show_bug.cgi?id=38606
As requested by Alexey. These tests find some interesting behavior in
both KURL and GURL. We'll need to go through them in more detail later
to understand what the right behavior is.
- fast/url/script-tests/segments-from-data-url.js: Added.
- fast/url/segments-from-data-url-expected.txt: Added.
- fast/url/segments-from-data-url.html: Added.
- 10:11 PM Changeset in webkit [58859] by
-
- 2 edits6 adds in trunk/LayoutTests
2010-05-05 Adam Barth <abarth@webkit.org>
Reviewed by Alexey Proskuryakov.
Add a test of URL segmentation
https://bugs.webkit.org/show_bug.cgi?id=38600
These tests are based on URLParser.Standard from
http://code.google.com/p/google-url/source/browse/trunk/src/url_parse_unittest.cc
- fast/url/resources/utilities.js:
(canonicalize):
- I changed this to use deterministic IDs because (theoretically) the old way was flaky in case the IDs collided.
(segments):
- Here we're using HTMLAnchorElement's attributes to infer the internal segmentation. Unforunately, there don't seem to be accessors for usernames and passwords of URLs.
- fast/url/script-tests/segments.js: Added.
- I'm not 100% sure all the test cases here represent the intent of the original test author. The tricky bit is we don't have a good way to test absolute URL parsing from the web platform, which means a bunch of these become tests of how we handle relative URLs. However, I'm not one to turn down more test cases.
- fast/url/script-tests/trivial-segments.js: Added.
- This is more of a test of the testing harness to make sure its working properly when running on other browsers.
- fast/url/segments-expected.txt: Added.
- fast/url/trivial-segments-expected.txt: Added.
- As usual, these have their "PASS" expectations set to the Chromium behavior but have their -expected.txt set to the normal WebKit behavior, letting us track differences between the two.
- fast/url/segments.html: Added.
- fast/url/trivial-segments.html: Added.
- 9:50 PM Changeset in webkit [58858] by
-
- 2 edits in trunk/JavaScriptCore
2010-05-05 Tony Gentilcore <tonyg@chromium.org>
Reviewed by Adam Barth.
Adding comment with link to RefPtr documentation.
https://bugs.webkit.org/show_bug.cgi?id=38601
- wtf/RefPtr.h:
- 9:28 PM Changeset in webkit [58857] by
-
- 2 edits in trunk/WebCore
2010-05-05 Joseph Pecoraro <Joseph Pecoraro>
Reviewed by Timothy Hatcher.
Web Inspector: Line Numbers should be Aligned with the Source Code Line
https://bugs.webkit.org/show_bug.cgi?id=38593
If there is a message bubble, such as an error message, in a source view
the line number should be in line with the source code line, not centered
between the source and bubble.
- inspector/front-end/textViewer.css: (.webkit-line-number): added vertical-align: top
- 8:16 PM Changeset in webkit [58856] by
-
- 2 edits in trunk/WebKit/mac
Fixed test crashes after r58847.
Rubber-stamped by Mark Rowe.
- WebView/WebHTMLView.mm:
(setNeedsDisplayInRect): Null-check the frame.
- 6:51 PM Changeset in webkit [58855] by
-
- 2 edits in trunk/LayoutTests
2010-05-05 Dirk Pranke <dpranke@chromium.org>
Unreviewed, expectations change.
- platform/chromium/test_expectations.txt:
- 6:36 PM Changeset in webkit [58854] by
-
- 3 edits in trunk/WebCore
Fix the decelerated compositing build.
- page/FrameView.cpp:
(WebCore::FrameView::isEnclosedInCompositingLayer):
- page/FrameView.h:
- 6:33 PM Changeset in webkit [58853] by
-
- 6 edits3 adds in trunk/WebKitTools
2010-05-05 Dirk Pranke <dpranke@chromium.org>
Reviewed by Eric Seidel.
new-run-webkit-tests: clean up newline handling in printing
The new printing module seems to handle newlines somewhat
inconsistently, especially in --verbose mode. This change cleans up
the code to make things more consistent and adds a bunch of unit tests.
- Scripts/webkitpy/common/array_stream.py: Added.
- Scripts/webkitpy/common/array_stream_unittest.py: Added.
- Scripts/webkitpy/layout_tests/layout_package/metered_stream.py:
- Scripts/webkitpy/layout_tests/layout_package/metered_stream_unittest.py: Added.
- Scripts/webkitpy/layout_tests/layout_package/printing.py:
- Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
- Scripts/webkitpy/layout_tests/run_webkit_tests.py:
- Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
- 6:12 PM Changeset in webkit [58852] by
-
- 3 edits in trunk/WebKitTools
2010-05-05 James Robinson <jamesr@chromium.org>
Reviewed by Adam Barth.
Ban the single letter 'l' as an identifier name
http://trac.webkit.org/changeset/58844
Add a lint rule to ban the single letter 'l' as an identifier name
since it is very easy to confuse with the numeral '1', especially
in code like WebCore/css/CSSHelper.cpp.
See http://trac.webkit.org/changeset/58844 as an example of a bug
caused by confusing short variable names.
- Scripts/webkitpy/style/checkers/cpp.py:
- Scripts/webkitpy/style/checkers/cpp_unittest.py:
- 6:08 PM Changeset in webkit [58851] by
-
- 9 edits in trunk
Bug 38604 - workers-gc2 crashing on Qt
Reviewed by Darin Adler.
This appears to be due to a couple of issues.
(1) When the atomic string table is deleted it does not clear the 'inTable' bit
on AtomicStrings - it implicitly assumes that all AtomicStrings have already
been deleted at this point (otherwise they will crash in their destructor when
they try to remove themselves from the atomic string table).
(2) We don't fix the ordering in which WTF::WTFThreadData and
WebCore::ThreadGlobalData are destructed.
We should make sure that ThreadGlobalData is cleaned up before worker threads
terminate and WTF::WTFThreadData is destroyed, and we should clear the inTable
bit of members on atomic string table destruction.
WTF changes (fix issue 1, above) - ensure inTable property is cleared when the
atomic string table is destroyed (also, rename InTable to IsAtomic, to make it
clear which table we are refering to!)
- wtf/text/AtomicString.cpp:
(WebCore::AtomicStringTable::destroy):
(WebCore::CStringTranslator::translate):
(WebCore::UCharBufferTranslator::translate):
(WebCore::HashAndCharactersTranslator::translate):
(WebCore::AtomicString::add):
- wtf/text/StringImpl.cpp:
(WebCore::StringImpl::~StringImpl):
- wtf/text/StringImpl.h:
(WebCore::StringImpl::isAtomic):
(WebCore::StringImpl::setIsAtomic):
- wtf/text/StringImplBase.h:
WebCore:
WTF changes (fix issue 2, above) - clean up the thread data on worker termination.
- platform/ThreadGlobalData.cpp:
(WebCore::ThreadGlobalData::~ThreadGlobalData):
(WebCore::ThreadGlobalData::destroy):
- platform/ThreadGlobalData.h:
- workers/WorkerThread.cpp:
(WebCore::WorkerThread::workerThread):
- 6:05 PM Changeset in webkit [58850] by
-
- 1 edit1 add in trunk/LayoutTests
Add Windows-specific results for clone-node-z-index.html. The difference in results is harmless (the number is the same),
but the difference is being tracked by https://bugs.webkit.org/show_bug.cgi?id=38617.
Rubber-stamped by Mark Rowe.
- platform/win/fast/dom/clone-node-z-index-expected.txt: Added.
- 5:53 PM Changeset in webkit [58849] by
-
- 8 edits in branches/audio/WebCore/audio
Fix problems with node disconnection
- add notifyInputConnection() method to AudioNode
- 5:53 PM Changeset in webkit [58848] by
-
- 2 edits in branches/audio/WebCore/audio
Cleanup AudioContext - clarify memory management a little bit
- 5:37 PM Changeset in webkit [58847] by
-
- 10 edits1 move4 adds in trunk
<rdar://problem/7932072> Iframes in composited layers don’t repaint correctly (affects Yahoo! Mail with Flash Player 10.1)
https://bugs.webkit.org/show_bug.cgi?id=38427
Reviewed by Simon Fraser.
WebCore:
Test: compositing/iframes/iframe-in-composited-layer.html
- WebCore.base.exp: Export FrameView::isEnclosedInCompositingLayer().
- page/FrameView.cpp:
(WebCore::FrameView::isEnclosedInCompositingLayer): Added this predicate.
- page/FrameView.h:
WebKit:
- WebKit.xcodeproj/project.pbxproj: Renamed WebClipView.m to WebClipView.mm and changed it to
Objective-C++.
WebKit/mac:
- WebView/WebClipView.m: Renamed to WebClipView.mm.
- WebView/WebClipView.mm:
(-[WebClipView visibleRect]): Added this override, which for instances used for WebFrameViews in
composited layers, returns the clip view’s entire bounds. This prevents drawing from being clipped to
AppKit’s idea of what part of the view would be visible if it was drawn as part of the view hierarchy.
Since it is drawn into a compositing layer, that’s irrelevant, and we should not be clipping.
- WebView/WebHTMLView.mm:
(setCursor): Style tweak.
(setNeedsDisplayInRect): Added. Replaces the default implementation of -[NSView setNeedsDisplayInRect:],
so that if the receiver is a descendant of a WebFrameView that draws into a composited layer, the invalidation
is routed back through the WebCore FrameView, which propagates it to the layer.
(+[WebHTMLViewPrivate initialize]): Swizzle the setNeedsDisplayInRect: override in.
(-[WebHTMLView visibleRect]): Removed whitespace.
- WebView/WebView.mm:
(layerSyncRunLoopObserverCallBack): If we bailed out on syncing, due to pending layout, do an eager layout
in preparation for the displaying of compositing layers.
LayoutTests:
- compositing/iframes/iframe-in-composited-layer.html: Added.
- platform/mac/compositing/iframes/iframe-in-composited-layer-expected.checksum: Added.
- platform/mac/compositing/iframes/iframe-in-composited-layer-expected.png: Added.
- platform/mac/compositing/iframes/iframe-in-composited-layer-expected.txt: Added.
- 5:20 PM Changeset in webkit [58846] by
-
- 2 edits in trunk/WebKit/mac
<rdar://problem/7942606> Output appears in Console when exiting Safari with multiple windows opened
Reviewed by Mark Rowe.
- WebView/WebView.mm:
(+[WebView closeAllWebViews]):
Make copy of allWebViewsSet to avoid mutating it while iterating through it.
- 5:02 PM Changeset in webkit [58845] by
-
- 3 edits4 adds in trunk
2010-05-05 Chris Marrin <cmarrin@apple.com>
Reviewed by Simon Fraser.
Got composited iframes showing up on Mac again
https://bugs.webkit.org/show_bug.cgi?id=38565
This was broken by http://trac.webkit.org/changeset/58798. That
change connected iframes through the parent document to the root
of the layer tree. That is correct for Windows, but not for Mac.
So the places where the linkage is made were wrapped in
shouldPropagateCompositingToIFrameParent() calls, which is
always false for Mac.
Test: compositing/iframes/composited-iframe-alignment.html
- rendering/RenderLayerCompositor.cpp:Avoid doing composited iframe linkage on Mac (WebCore::RenderLayerCompositor::rebuildCompositingLayerTree): (WebCore::RenderLayerCompositor::didMoveOnscreen): (WebCore::RenderLayerCompositor::willMoveOffscreen): (WebCore::RenderLayerCompositor::ensureRootPlatformLayer):
- 4:24 PM Changeset in webkit [58844] by
-
- 3 edits2 adds in trunk
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=38260
<rdar://problem/7917548> Fix whitespace removing in deprecatedParseURL().
Broken all the way since r4 (yes, that's a revision number).
Test: http/tests/security/xss-DENIED-javascript-with-spaces.html
- css/CSSHelper.cpp: (WebCore::deprecatedParseURL): Fixed loop conditions for remaining length.
- 4:12 PM Changeset in webkit [58843] by
-
- 5 edits2 adds in trunk
Many AXUnknown showing up in the hierarchy
https://bugs.webkit.org/show_bug.cgi?id=38607
Reviewed by Beth Dakin.
WebCore:
The RenderTableSection should not be an accessible element.
Test: platform/mac/accessibility/parent-of-table-row-is-table.html
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::determineAccessibilityRole):
LayoutTests:
- platform/mac-leopard/Skipped:
- platform/mac-tiger/Skipped:
- platform/mac/accessibility/parent-of-table-row-is-table-expected.txt: Added.
- platform/mac/accessibility/parent-of-table-row-is-table.html: Added.
- 3:59 PM Changeset in webkit [58842] by
-
- 2 edits in trunk/WebCore
[Qt]Disable Qt Multimedia backend for HTML 5 Audio and Video elements
Fall back to the Phonon backend until the release situation has been cleared up.
Reviewed by Simon Hausmann.
https://bugs.webkit.org/show_bug.cgi?id=38612
Buildfix for QT_VERSION >= 0x040700 after r58810.
- platform/graphics/MediaPlayer.cpp:
- 3:42 PM Changeset in webkit [58841] by
-
- 9 edits3 adds in trunk
XMLHttpRequestUpload events do not fire when sending a raw file or FormData object.
https://bugs.webkit.org/show_bug.cgi?id=37771
Reviewed by David Levin.
WebCore:
Test: http/tests/local/formdata/upload-events.html
- xml/XMLHttpRequest.cpp:
(WebCore::XMLHttpRequest::createRequest):
LayoutTests:
Add a layout test to test upload events firing.
- http/tests/local/formdata/resources/send-form-data-common.js:
(dumpResponse):
(sendFormData):
(testSendingFormData):
- http/tests/local/formdata/script-tests/send-form-data-with-sliced-file.js:
- http/tests/local/formdata/script-tests/send-form-data.js:
- http/tests/local/formdata/script-tests/upload-events.js: Added.
- http/tests/local/formdata/upload-events-expected.txt: Added.
- http/tests/local/formdata/upload-events.html: Added.
- platform/gtk/Skipped: Skip the new test because eventSender.beginDragWithFiles is not supported in gtk platform.
- platform/qt/Skipped: Skip the new test because eventSender.beginDragWithFiles is not supported in qt platform.
- platform/win/Skipped: Skip the new test because eventSender.beginDragWithFiles is not supported in win platform.
- 3:28 PM Changeset in webkit [58840] by
-
- 2 edits in trunk/WebCore
[Qt] Qt port should use its own QUuid class to create UUID string.
https://bugs.webkit.org/show_bug.cgi?id=38581
Reviewed by Simon Hausmann.
- platform/UUID.cpp:
(WebCore::createCanonicalUUIDString): Added PLATFORM(QT) case.
- 2:51 PM Changeset in webkit [58839] by
-
- 11 edits in trunk/WebKit/chromium
2010-05-05 Darin Fisher <darin@chromium.org>
Reviewed by Dimitri Glazkov.
[chromium] clear out deprecated methods that are no longer used
https://bugs.webkit.org/show_bug.cgi?id=38610
- public/WebFormElement.h:
- public/WebInputElement.h:
- public/WebKitClient.h:
- public/WebView.h:
- public/WebViewClient.h: (WebKit::WebViewClient::createPopupMenu):
- src/ChromeClientImpl.cpp: (WebKit::ChromeClientImpl::popupOpened):
- src/WebFormElement.cpp:
- src/WebInputElement.cpp: (WebKit::WebInputElement::setSelectionRange):
- src/WebViewImpl.cpp: (WebKit::WebViewImpl::hideSuggestionsPopup):
- src/WebViewImpl.h:
- 2:16 PM QtWebKitTriageRoster edited by
- (diff)
- 1:16 PM Changeset in webkit [58838] by
-
- 2 edits in trunk/LayoutTests
2010-05-05 Dirk Pranke <dpranke@chromium.org>
Unreviewed, expectations fix.
Update expectations with tests that are now passing (possibly flaky?).
- platform/chromium/test_expectations.txt:
- 1:06 PM Changeset in webkit [58837] by
-
- 2 edits in trunk/LayoutTests
2010-05-05 Dirk Pranke <dpranke@chromium.org>
Unreviewed, expectations fix.
Mark svg/custom/mask-changes.svg and http/tests/loading/bad-scheme-subframe.html as failing on Chromium Linux until they can be triaged.
- platform/chromium/test_expectations.txt:
- 12:19 PM Changeset in webkit [58836] by
-
- 3 edits4 deletes in trunk
Roll out r58830 for breaking tests.
Was: https://bugs.webkit.org/show_bug.cgi?id=38546
Node.focus() fails to move focus from subframe properly
- 12:11 PM Changeset in webkit [58835] by
-
- 2 edits in branches/audio/WebCore/audio
Call to pull() must take return value into account for non-inplace case
- 12:11 PM Changeset in webkit [58834] by
-
- 1 edit in branches/audio/WebCore/audio/AudioBufferSourceNode.cpp
Audio buffer source node needs default number of channels
- 12:10 PM Changeset in webkit [58833] by
-
- 2 edits in branches/audio/WebCore/audio
Keep track of mixer input availability
- 11:52 AM Changeset in webkit [58832] by
-
- 12 edits2 adds in trunk/WebCore
Implement FileReader class.
https://bugs.webkit.org/show_bug.cgi?id=38157
Reviewed by Adam Barth.
This patch only contains the implementation of FileReader class as defined
in the File API spec: http://www.w3.org/TR/file-upload/#dfn-filereader.
New test will be added when a IDL is exposed and the FILE_READER is turned
on.
- GNUmakefile.am:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- dom/EventNames.h:
- dom/EventTarget.cpp:
(WebCore::EventTarget::toFileReader):
- dom/EventTarget.h:
- html/FileError.h:
(WebCore::FileError::FileError):
- html/FileReader.cpp: Added.
- html/FileReader.h: Added.
- html/FileStream.cpp:
(WebCore::FileStream::FileStream):
(WebCore::FileStream::openForRead):
(WebCore::FileStream::close):
(WebCore::FileStream::read):
- html/FileStream.h:
- 11:35 AM Changeset in webkit [58831] by
-
- 2 edits in trunk/WebCore
2010-05-05 Steve Falkenburg <sfalken@apple.com>
Reviewed by Maciej Stachowiak.
REGRESSION(r57969) Image decoder is repeatedly destroyed/created in CoreGraphics-based Windows WebKit
https://bugs.webkit.org/show_bug.cgi?id=38595
- platform/graphics/cg/ImageSourceCG.cpp: (WebCore::ImageSource::setData):
- 11:26 AM Changeset in webkit [58830] by
-
- 3 edits4 adds in trunk
Reviewed by Adele Peterson.
https://bugs.webkit.org/show_bug.cgi?id=38546
Node.focus() fails to move focus from subframe properly
Test: fast/frames/take-focus-from-iframe.html
- html/HTMLFrameElementBase.cpp: (WebCore::HTMLFrameElementBase::setFocus): Don't clear focus if this frame doesn't have it. This can happen if page's and HTMLFrameElement's ideas of focused frame get out of sync temporarily.
- 11:24 AM How to CC yourself on (or make other changes to) many bugs at once created by
- Initial version
- 11:20 AM WikiStart edited by
- (diff)
- 11:17 AM Changeset in webkit [58829] by
-
- 2 edits1 add in trunk/WebCore
Reviewed by Adele Peterson.
https://bugs.webkit.org/show_bug.cgi?id=26824
<rdar://problem/7018610> EventHandler can operate on a wrong frame if focus changes during
keyboard event dispatch.
EventHandler object is tied to a frame, so it's wrong for it to continue processing a keyboard
event if focused frame changes between keydown and keypress.
- manual-tests/focus-change-between-key-events.html: Added.
- page/EventHandler.cpp: (WebCore::EventHandler::keyEvent): Bail out early if focused frame changes while dispatching keydown. Also made similar changes for Windows to maintain matching behavior, even though EventHandler was re-entered anyway due to WM_KEYDOWN and WM_CHAR being separate events.
- 11:14 AM Changeset in webkit [58828] by
-
- 3 edits in trunk/WebKit/chromium
2010-05-05 Hans Wennborg <hans@chromium.org>
Reviewed by Jeremy Orlow.
[chromium] Add quota parameter to WebStorageNamespace::createSessionStorageNamespace
https://bugs.webkit.org/show_bug.cgi?id=38589
- public/WebStorageNamespace.h: (WebKit::WebStorageNamespace::createSessionStorageNamespace):
- src/WebStorageNamespaceImpl.cpp: (WebKit::WebStorageNamespace::createSessionStorageNamespace):
- 10:53 AM Changeset in webkit [58827] by
-
- 2 edits in trunk/WebKitSite
2010-05-05 Shinichiro Hamaji <hamaji@chromium.org>
Reviewed by Adam Barth.
Commit and Review policy should encourage unofficial reviews
https://bugs.webkit.org/show_bug.cgi?id=38517
- coding/commit-review-policy.html:
- 10:20 AM Changeset in webkit [58826] by
-
- 2 edits in trunk/WebCore
2010-05-05 Steve Block <steveblock@google.com>
Reviewed by Adam Barth.
MediaError.h is missing PassRefPtr.h include
https://bugs.webkit.org/show_bug.cgi?id=38575
No new tests, build fix only.
- html/MediaError.h:
- 10:06 AM Changeset in webkit [58825] by
-
- 2 edits in trunk/WebCore
2010-05-05 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: Audits panel: Resource counters get reset when switching panels while reloading page
https://bugs.webkit.org/show_bug.cgi?id=38579
- inspector/front-end/AuditLauncherView.js: (WebInspector.AuditLauncherView.prototype.updateResourceTrackingState): (WebInspector.AuditLauncherView.prototype._updateResourceProgress):
- 10:03 AM Changeset in webkit [58824] by
-
- 2 edits in trunk/JavaScriptCore
2010-05-05 Oliver Hunt <oliver@apple.com>
Reviewed by Geoffrey Garen.
Make Array.join specialised for actual arrays
https://bugs.webkit.org/show_bug.cgi?id=38592
Bring Array.join in line with the other array methods by specialising for
this === an array.
- runtime/ArrayPrototype.cpp: (JSC::arrayProtoFuncJoin):
- 9:48 AM Changeset in webkit [58823] by
-
- 2 edits in trunk/WebCore
2010-05-05 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Joseph Pecoraro.
Web Inspector: Doubleclick on line number should not trigger source editing.
- inspector/front-end/TextViewer.js: (WebInspector.TextViewer.prototype._handleDoubleClick):
- 9:30 AM Changeset in webkit [58822] by
-
- 2 edits in trunk/WebCore
2010-05-05 Martin Robinson <Martin Robinson>
Reviewed by Gustavo Noronha.
[GTK] Enable DOM clipboard and drag-and-drop access
https://bugs.webkit.org/show_bug.cgi?id=30623
Add support in the PasteboardHelper for images, in preparation for drag-and-drop data.
No new tests as functionality has not changed.
- platform/gtk/PasteboardHelper.cpp: (WebCore::PasteboardHelper::fillSelectionData): Add support for images here. (WebCore::PasteboardHelper::targetListForDataObject): Add support for images here.
- 9:22 AM Changeset in webkit [58821] by
-
- 26 edits in trunk
2010-05-05 Stuart Morgan <stuartmorgan@chromium.org>
Reviewed by Darin Fisher.
Add a "focused" parameter to Widget::setFocus, and updates Document
so that Widget is informed of focus loss as well as focus gain.
Changes all existing setFocus implementations so that they ignore
the 'false' case, so no behavior is changed until individual
platforms are updated to handle the new case (if they want to).
- dom/Document.cpp: (WebCore::Document::setFocusedNode):
- platform/Widget.h:
- platform/android/WidgetAndroid.cpp: (WebCore::Widget::setFocus):
- platform/chromium/WidgetChromium.cpp: (WebCore::Widget::setFocus):
- platform/efl/WidgetEfl.cpp: (WebCore::Widget::setFocus):
- platform/gtk/WidgetGtk.cpp: (WebCore::Widget::setFocus):
- platform/haiku/WidgetHaiku.cpp: (WebCore::Widget::setFocus):
- platform/mac/WidgetMac.mm: (WebCore::Widget::setFocus):
- platform/qt/WidgetQt.cpp: (WebCore::Widget::setFocus):
- platform/win/WidgetWin.cpp: (WebCore::Widget::setFocus):
- platform/wx/WidgetWx.cpp: (WebCore::Widget::setFocus):
- plugins/PluginView.h:
- plugins/PluginViewNone.cpp: (WebCore::PluginView::setFocus):
- plugins/gtk/PluginViewGtk.cpp: (WebCore::PluginView::setFocus):
- plugins/mac/PluginViewMac.cpp: (WebCore::PluginView::setFocus):
- plugins/qt/PluginViewQt.cpp: (WebCore::PluginView::setFocus):
- plugins/symbian/PluginViewSymbian.cpp: (WebCore::PluginView::setFocus):
- plugins/win/PluginViewWin.cpp: (WebCore::PluginView::setFocus):
2010-05-05 Stuart Morgan <stuartmorgan@chromium.org>
Reviewed by Darin Fisher.
Update the plugin container's setFocus implementation to pass the new
boolean argument to the next layer.
- src/WebPluginContainerImpl.cpp: (WebKit::WebPluginContainerImpl::setFocus):
- src/WebPluginContainerImpl.h:
2010-05-05 Stuart Morgan <stuartmorgan@chromium.org>
Reviewed by Darin Fisher.
Update setFocus for the new boolean argument; no behavioral change.
- WebCoreSupport/EmbeddedWidget.cpp: (EmbeddedWidget::setFocus):
- WebCoreSupport/EmbeddedWidget.h:
- 9:01 AM Changeset in webkit [58820] by
-
- 2 edits in trunk/LayoutTests
2010-05-05 Jeremy Moskovich <jeremy@chromium.org>
Unreviewed, updated baselines.
skia r561 broke a bunch of chromium image baselines.
Update test_expectations to include remaining failures.
- platform/chromium/test_expectations.txt:
- 8:18 AM Changeset in webkit [58819] by
-
- 4 edits2 adds in trunk/LayoutTests
2010-05-05 Jeremy Moskovich <jeremy@chromium.org>
Unreviewed, updated baselines.
skia r561 broke a bunch of chromium image baselines.
Rebase a few tests that were missed by previous passes.
- platform/chromium-linux/svg/W3C-SVG-1.1/filters-diffuse-01-f-expected.checksum:
- platform/chromium-linux/svg/W3C-SVG-1.1/filters-diffuse-01-f-expected.png:
- platform/chromium-linux/svg/custom/mask-changes-expected.checksum: Added.
- platform/chromium-linux/svg/custom/mask-changes-expected.png: Added.
- platform/chromium/test_expectations.txt:
- 8:08 AM Changeset in webkit [58818] by
-
- 5 edits in trunk/WebCore
2010-05-05 Steve Block <steveblock@google.com>
Reviewed by Pavel Feldman.
Move V8 ScriptDebugServer::topStackFrame() to ScriptCallStack
https://bugs.webkit.org/show_bug.cgi?id=38531
ScriptCallStack::create() uses ScriptDebugServer::topStackFrame(), but ScriptDebugServer
is guarded with ENABLE(JAVASCRIPT_DEBUGGER). This prevents ScriptCallStack from being
built on platforms that do not define ENABLE(JAVASCRIPT_DEBUGGER).
No new tests, build fix only.
- bindings/v8/ScriptCallStack.cpp: (WebCore::ScriptCallStack::callLocation): (WebCore::ScriptCallStack::createUtilityContext): Helper for topStackFrame, moved from ScriptDebugServer (WebCore::ScriptCallStack::topStackFrame): Moved from ScriptDebugServer
- bindings/v8/ScriptCallStack.h: (WebCore::ScriptCallStack::utilityContext): Helper for topStackFrame, moved from ScriptDebugServer
- bindings/v8/ScriptDebugServer.cpp:
- bindings/v8/ScriptDebugServer.h:
- 7:42 AM Changeset in webkit [58817] by
-
- 7 edits1 delete in trunk/LayoutTests
2010-05-05 Jeremy Moskovich <jeremy@chromium.org>
Unreviewed, updated baselines - 6th and final batch.
skia r561 broke a bunch of chromium image baselines.
<long list of new image baselines redacted>
- platform/chromium/test_expectations.txt:
- 7:18 AM Changeset in webkit [58816] by
-
- 671 edits10 adds62 deletes in trunk/LayoutTests
2010-05-05 Jeremy Moskovich <jeremy@chromium.org>
Unreviewed, updated baselines - 5th batch.
skia r561 broke a bunch of chromium image baselines.
<long list of new image baselines redacted>
- platform/chromium/test_expectations.txt:
- 7:01 AM BuildingQtOnWindows edited by
- (diff)
- 6:52 AM Changeset in webkit [58815] by
-
- 852 edits4 adds41 deletes in trunk/LayoutTests
2010-05-05 Jeremy Moskovich <jeremy@chromium.org>
Unreviewed, updated baselines - 4th batch.
skia r561 broke a bunch of chromium image baselines.
<long list of new image baselines redacted>
- platform/chromium/test_expectations.txt:
- 6:49 AM QtWebKitJournal edited by
- (diff)
- 6:31 AM Changeset in webkit [58814] by
-
- 820 edits2 adds69 deletes in trunk/LayoutTests
2010-05-05 Jeremy Moskovich <jeremy@chromium.org>
Unreviewed, updated baselines - 3rd batch.
skia r561 broke a bunch of chromium image baselines.
<long list of new image baselines redacted>
- platform/chromium/test_expectations.txt:
- 5:57 AM Changeset in webkit [58813] by
-
- 2 edits in trunk/WebCore
[Qt] REGRESSION(r56869): WinCE build is broken
https://bugs.webkit.org/show_bug.cgi?id=36929
Rubber-stamped by Simon Hausmann.
- WebCore.pro: LIBS += -lOle32 added.
- 5:44 AM BuildingQtOnWindows edited by
- Added python as a dependency (diff)
- 5:36 AM Changeset in webkit [58812] by
-
- 1080 edits8 adds111 deletes in trunk/LayoutTests
Unreviewed, updated baselines - 2nd batch.
skia r561 broke a bunch of chromium image baselines.
<long list of new image baselines redacted>
- platform/chromium/test_expectations.txt:
- 4:54 AM Changeset in webkit [58811] by
-
- 379 edits39 deletes in trunk/LayoutTests
Unreviewed, updated baselines - 1st batch.
skia r561 broke a bunch of chromium image baselines.
<long list of new image baselines redacted>
- platform/chromium/test_expectations.txt:
- 4:30 AM Changeset in webkit [58810] by
-
- 2 edits in trunk/WebCore
[Qt] Disable Qt Multimedia backend for HTML 5 Audio and Video elements
Reviewed by Tor Arne Vestbø.
Fall back to the Phonon backend until the release situation has been cleared up.
- WebCore.pro:
- 4:30 AM Changeset in webkit [58809] by
-
- 2 edits in trunk/WebCore
2010-05-05 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Pavel Feldman.
WebInspector: Clickable links to resources should be used as 'details' part for the all suitable kinds of records.
https://bugs.webkit.org/show_bug.cgi?id=38542
- inspector/front-end/TimelinePanel.js: (WebInspector.TimelinePanel.prototype._innerAddRecordToTimeline): (WebInspector.TimelineRecordListRow): (WebInspector.TimelineRecordListRow.prototype.update): (WebInspector.TimelinePanel.FormattedRecord): (WebInspector.TimelinePanel.FormattedRecord.prototype._generatePopupContent): (WebInspector.TimelinePanel.FormattedRecord.prototype._getRecordDetails): (WebInspector.TimelinePanel.PopupContentHelper): (WebInspector.TimelinePanel.PopupContentHelper.prototype._createCell): (WebInspector.TimelinePanel.PopupContentHelper.prototype._appendTextRow): (WebInspector.TimelinePanel.PopupContentHelper.prototype._appendElementRow): (WebInspector.TimelinePanel.PopupContentHelper.prototype._appendLinkRow):
- 2:33 AM Changeset in webkit [58808] by
-
- 1 edit6 adds in trunk/WebCore
2010-05-05 Nikolas Zimmermann <nzimmermann@rim.com>
Not reviewed. Add missing files generated by "run-bindings-test", after the DOMTestCallback.idl addition.
- bindings/scripts/test/GObject/WebKitDOMTestCallback.cpp: Added. (WebKit::kit): (webkit_dom_test_callback_callback_with_class1param): (webkit_dom_test_callback_callback_with_class2param): (webkit_dom_test_callback_callback_with_non_bool_return_type): (WebKit::wrapTestCallback): (WebKit::core): (webkit_dom_test_callback_finalize): (webkit_dom_test_callback_set_property): (webkit_dom_test_callback_get_property): (webkit_dom_test_callback_class_init): (webkit_dom_test_callback_init):
- bindings/scripts/test/GObject/WebKitDOMTestCallback.h: Added.
- bindings/scripts/test/GObject/WebKitDOMTestCallbackPrivate.h: Added.
- bindings/scripts/test/ObjC/DOMTestCallback.h: Added.
- bindings/scripts/test/ObjC/DOMTestCallback.mm: Added. (-[DOMTestCallback dealloc]): (-[DOMTestCallback finalize]): (-[DOMTestCallback callbackWithClass1Param:]): (-[DOMTestCallback callbackWithClass2Param:strArg:]): (-[DOMTestCallback callbackWithNonBoolReturnType:]): (-[DOMTestCallback customCallback:class6Param:]): (core): (kit):
- bindings/scripts/test/ObjC/DOMTestCallbackInternal.h: Added.
- 1:00 AM Changeset in webkit [58807] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, expectations change.
recommit r58747 - Preparing for chromium skia roll incorporating changes up to r561.
Add expected failures so bots don't turn red while rolling.
- platform/chromium/test_expectations.txt:
- 12:57 AM Changeset in webkit [58806] by
-
- 2 edits in trunk/LayoutTests
2010-05-05 Xan Lopez <xlopez@igalia.com>
Skip flakey workers test.
- platform/gtk/Skipped:
- 12:57 AM Changeset in webkit [58805] by
-
- 2 edits in trunk/WebCore
2010-05-05 Joseph Pecoraro <Joseph Pecoraro>
Reviewed by Pavel Feldman.
Web Inspector: FontView needs Cleanup
https://bugs.webkit.org/show_bug.cgi?id=38567
FontView was missing some of the newer practices for initialization
that other Resource Views had. Also its width calculations could
result in a single character wrapping. This is general cleanup.
- inspector/front-end/FontView.js: (WebInspector.FontView): move initialization into contentTabSelected (WebInspector.FontView.prototype.contentTabSelected): handle initialization like other Resource Views (WebInspector.FontView.prototype.updateFontPreviewSize): use a narrower width to prevent text from widowing
- 12:31 AM Changeset in webkit [58804] by
-
- 2 edits in trunk/WebCore
2010-05-05 Dirk Schulze <krit@webkit.org>
Reviewed by Nikolas Zimmermann.
SVG hit testing is *way* too slow
https://bugs.webkit.org/show_bug.cgi?id=19312
Use the cached stroke and fill boundaries in RenderPath as a heuristik to
speed up SVG's hit testing.
No new tests added.
- rendering/RenderPath.cpp: (WebCore::RenderPath::fillContains): (WebCore::RenderPath::strokeContains):
