⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



May 13, 2010:

11:35 PM Changeset in webkit [59445] by Simon Hausmann
  • 2 edits in trunk/WebKit/qt

Symbian build fix.

[Qt] Updated the def file with new exports.

  • symbian/eabi/QtWebKitu.def: Add missing gc symbol for QtLauncher
11:18 PM Changeset in webkit [59444] by Simon Fraser
  • 1 edit
    1 add in trunk/LayoutTests

2010-05-13 Simon Fraser <Simon Fraser>

Fixing test failure.

Adding resource that should have been added in r59443.

  • compositing/iframes/resources/subframe.html: Added.
10:32 PM Changeset in webkit [59443] by Simon Fraser
  • 3 edits
    4 adds in trunk

2010-05-13 Simon Fraser <Simon Fraser>

Reviewed by Dan Bernstein.

iframes in compositing layers don't redraw correctly on scrolling
​https://bugs.webkit.org/show_bug.cgi?id=39096

When an iframe ends up in a compositing layer (that is painting to its backing store), we need
to turn off blitting on scrolling. RenderView::paintBoxDecorations() already has code to do this
for transformed frames, so do the same thing when the frame is enclosed in a compositing layer.

Test: compositing/iframes/iframe-copy-on-scroll.html

  • rendering/RenderView.cpp: (WebCore::RenderView::paintBoxDecorations):
9:17 PM Changeset in webkit [59442] by tony@chromium.org
  • 2 edits in trunk/WebKit/chromium

2010-05-13 Tony Chang <​tony@chromium.org>

Reviewed by Kent Tamura.

[chromium] enable DRT build in chromium (for the last time)
​https://bugs.webkit.org/show_bug.cgi?id=39109

  • WebKit.gyp:
9:01 PM Changeset in webkit [59441] by tkent@chromium.org
  • 2 edits in trunk

Unreviewed. Move a ChangeLog entry inserted to a wrong file.

8:56 PM Changeset in webkit [59440] by tkent@chromium.org
  • 2 edits in trunk/LayoutTests

2010-05-13 Takeshi Yoshino <​tyoshino@google.com>

Reviewed by Kent Tamura.

Update text_expectations.txt for Chromium
fast/forms/input-text-paste-maxlength.html is flaky on Linux Debug
See ​http://code.google.com/p/chromium/issues/detail?id=44150 for detail.

  • platform/chromium/test_expectations.txt:
8:49 PM Changeset in webkit [59439] by tkent@chromium.org
  • 2 edits in trunk/LayoutTests

Update test_expectations.txt for Chromium.
fast/forms/implicit-submission.html is flaky on Linux.
See ​http://crbug.com/43890 for detail.

Patch by Takeshi Yoshino <​tyoshino@google.com> on 2010-05-13
Reviewed by Shinichiro Hamaji.

  • platform/chromium/test_expectations.txt:
7:25 PM Changeset in webkit [59438] by bweinstein@apple.com
  • 1 edit in trunk/WebKit/win/ChangeLog

Update the bug number in the ChangeLog that I just committed.

7:10 PM Changeset in webkit [59437] by mrowe@apple.com
  • 5 edits in branches/safari-533-branch

Versioning.

7:09 PM Changeset in webkit [59436] by Martin Robinson
  • 2 edits in trunk/LayoutTests

2010-05-13 Martin Robinson <​mrobinson@igalia.com>

No review.

[GTK] css1/color_and_background/background_attachment.html fails on the 32-bit debug bot
​https://bugs.webkit.org/show_bug.cgi?id=39101

  • platform/gtk/Skipped: Skip failing test.
7:09 PM Changeset in webkit [59435] by mrowe@apple.com
  • 1 copy in tags/Safari-533.9

New tag.

7:08 PM Changeset in webkit [59434] by bweinstein@apple.com
  • 5 edits in trunk/WebKit/win

<rdar://problem/7975410>

Reviewed by Tim Hatcher.

Allow reporting exceptions that occur when using JavaScriptCore APIs to the Web Inspector.

  • Interfaces/IWebViewPrivate.idl: Add a reportException function off of IWebViewPrivate.
  • Interfaces/WebKit.idl: Touch WebKit.idl to make sure Interfaces rebuild.
  • WebView.cpp:

(WebView::reportException): Make sure the function was called with a context from a WebView, and call

WebCore::reportException.

  • WebView.h:
7:08 PM Changeset in webkit [59433] by mrowe@apple.com
  • 5 edits in branches/safari-533-branch

Versioning.

6:52 PM Changeset in webkit [59432] by mrowe@apple.com
  • 5 edits in branches/safari-533-branch

Merge r59418.

6:51 PM Changeset in webkit [59431] by mrowe@apple.com
  • 3 edits in branches/safari-533-branch/WebCore

Merge r59330.

6:51 PM Changeset in webkit [59430] by mrowe@apple.com
  • 4 edits in branches/safari-533-branch/WebCore

Merge r59387.

6:51 PM Changeset in webkit [59429] by mrowe@apple.com
  • 2 edits in branches/safari-533-branch/WebCore

Merge r59417.

6:06 PM Changeset in webkit [59428] by Martin Robinson
  • 2 edits
    56 adds in trunk/LayoutTests

2010-05-13 Martin Robinson <​mrobinson@igalia.com>

No review. Finish adding css1 baselines for GTK+.

  • platform/gtk/Skipped: Unskip tests which now have baselines.
  • platform/gtk/css1/basic/class_as_selector-expected.txt:
  • platform/gtk/css1/box_properties/width-expected.txt: Added.
  • platform/gtk/css1/cascade/cascade_order-expected.txt: Added.
  • platform/gtk/css1/cascade/important-expected.txt: Added.
  • platform/gtk/css1/classification/display-expected.txt: Added.
  • platform/gtk/css1/classification/list_style-expected.txt: Added.
  • platform/gtk/css1/classification/list_style_image-expected.txt: Added.
  • platform/gtk/css1/classification/list_style_position-expected.txt: Added.
  • platform/gtk/css1/classification/list_style_type-expected.txt: Added.
  • platform/gtk/css1/classification/white_space-expected.txt: Added.
  • platform/gtk/css1/color_and_background/background-expected.txt: Added.
  • platform/gtk/css1/color_and_background/background_attachment-expected.txt: Added.
  • platform/gtk/css1/color_and_background/background_color-expected.txt: Added.
  • platform/gtk/css1/color_and_background/background_image-expected.txt: Added.
  • platform/gtk/css1/color_and_background/background_position-expected.txt: Added.
  • platform/gtk/css1/color_and_background/background_repeat-expected.txt: Added.
  • platform/gtk/css1/color_and_background/color-expected.txt: Added.
  • platform/gtk/css1/conformance/forward_compatible_parsing-expected.txt: Added.
  • platform/gtk/css1/font_properties/font-expected.txt: Added.
  • platform/gtk/css1/font_properties/font_family-expected.txt: Added.
  • platform/gtk/css1/font_properties/font_size-expected.txt: Added.
  • platform/gtk/css1/font_properties/font_style-expected.txt: Added.
  • platform/gtk/css1/font_properties/font_variant-expected.txt: Added.
  • platform/gtk/css1/font_properties/font_weight-expected.txt: Added.
  • platform/gtk/css1/formatting_model/canvas-expected.txt: Added.
  • platform/gtk/css1/formatting_model/floating_elements-expected.txt: Added.
  • platform/gtk/css1/formatting_model/height_of_lines-expected.txt: Added.
  • platform/gtk/css1/formatting_model/horizontal_formatting-expected.txt: Added.
  • platform/gtk/css1/formatting_model/inline_elements-expected.txt: Added.
  • platform/gtk/css1/formatting_model/replaced_elements-expected.txt: Added.
  • platform/gtk/css1/formatting_model/vertical_formatting-expected.txt: Added.
  • platform/gtk/css1/pseudo/anchor-expected.txt: Added.
  • platform/gtk/css1/pseudo/firstletter-expected.txt: Added.
  • platform/gtk/css1/pseudo/firstline-expected.txt: Added.
  • platform/gtk/css1/pseudo/multiple_pseudo_elements-expected.txt: Added.
  • platform/gtk/css1/pseudo/pseudo_elements_in_selectors-expected.txt: Added.
  • platform/gtk/css1/text_properties/letter_spacing-expected.txt: Added.
  • platform/gtk/css1/text_properties/line_height-expected.txt: Added.
  • platform/gtk/css1/text_properties/text_align-expected.txt: Added.
  • platform/gtk/css1/text_properties/text_decoration-expected.txt: Added.
  • platform/gtk/css1/text_properties/text_indent-expected.txt: Added.
  • platform/gtk/css1/text_properties/text_transform-expected.txt: Added.
  • platform/gtk/css1/text_properties/vertical_align-expected.txt: Added.
  • platform/gtk/css1/text_properties/word_spacing-expected.txt: Added.
  • platform/gtk/css1/units/color_units-expected.txt: Added.
  • platform/gtk/css1/units/length_units-expected.txt: Added.
  • platform/gtk/css1/units/percentage_units-expected.txt: Added.
  • platform/gtk/css1/units/urls-expected.txt: Added.
6:03 PM Changeset in webkit [59427] by mrowe@apple.com
  • 13 edits in branches/safari-533-branch/WebCore

Merge r59281.

6:03 PM Changeset in webkit [59426] by mrowe@apple.com
  • 7 edits
    1 copy
    1 add in branches/safari-533-branch

Merge r59381.

6:03 PM Changeset in webkit [59425] by mrowe@apple.com
  • 4 edits in branches/safari-533-branch/WebCore

Merge r59372.

6:03 PM Changeset in webkit [59424] by mrowe@apple.com
  • 2 edits in branches/safari-533-branch/WebKit/mac

Merge r59391.

6:03 PM Changeset in webkit [59423] by mrowe@apple.com
  • 3 edits in branches/safari-533-branch/WebCore

Merge r59374.

6:02 PM Changeset in webkit [59422] by mrowe@apple.com
  • 6 edits
    2 adds in branches/safari-533-branch

Merge r59384.

6:02 PM Changeset in webkit [59421] by mrowe@apple.com
  • 3 edits
    2 adds in branches/safari-533-branch

Merge r59351.

6:02 PM Changeset in webkit [59420] by mrowe@apple.com
  • 2 edits in branches/safari-533-branch/JavaScriptCore

Merge r59337.

5:04 PM Changeset in webkit [59419] by Martin Robinson
  • 2 edits in trunk/LayoutTests

2010-05-13 Martin Robinson <​mrobinson@igalia.com>

No review. Correcting baseline.

  • platform/gtk/css1/basic/class_as_selector-expected.txt: Correct baseline.
5:01 PM Changeset in webkit [59418] by timothy@apple.com
  • 5 edits in trunk

WebCore: Expose WebCore::reportException and WebCore::toJSDOMWindow symbols.

Reviewed by Sam Weinig.

  • WebCore.base.exp: Expose reportException and toJSDOMWindow.

WebKit/mac: Allow reporting exceptions that occur when using JavaScriptCore APIs
to the Web Inspector.

<rdar://problem/7975410>

Reviewed by Sam Weinig.

  • WebView/WebView.mm:

(+[WebView _reportException:inContext:]): Call WebCore::reportException after checking
that the global object is a DOMWindow.

  • WebView/WebViewPrivate.h: Added _reportException:inContext:.
4:59 PM Changeset in webkit [59417] by Joseph Pecoraro
  • 2 edits in trunk/WebCore

2010-05-13 Joseph Pecoraro <Joseph Pecoraro>

Reviewed by Timothy Hatcher.

Web Inspector: Clearing Breakpoints Too Often
​https://bugs.webkit.org/show_bug.cgi?id=39094

Minor resets should preserve both workers and breakpoints.

  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype.reset):
4:58 PM Changeset in webkit [59416] by Simon Hausmann
  • 2 edits in trunk/WebKit/qt

Symbian build fix.

[Qt] Updated the def file with new exports.

  • symbian/eabi/QtWebKitu.def:
4:46 PM Changeset in webkit [59415] by mrowe@apple.com
  • 2 edits in branches/safari-533-branch/WebCore

Merge r59025.

4:46 PM Changeset in webkit [59414] by mrowe@apple.com
  • 3 edits in branches/safari-533-branch/WebCore

Merge r58954.

4:46 PM Changeset in webkit [59413] by mrowe@apple.com
  • 13 edits
    4 adds in branches/safari-533-branch

Merge r59243.

4:46 PM Changeset in webkit [59412] by mrowe@apple.com
  • 2 edits in branches/safari-533-branch/WebCore

Merge r59210.

4:46 PM Changeset in webkit [59411] by mrowe@apple.com
  • 10 edits in branches/safari-533-branch

Merge r59232.

4:46 PM Changeset in webkit [59410] by mrowe@apple.com
  • 5 edits in branches/safari-533-branch/WebCore

Merge r59239.

4:46 PM Changeset in webkit [59409] by mrowe@apple.com
  • 6 edits in branches/safari-533-branch/WebCore

Merge r59189.

4:46 PM Changeset in webkit [59408] by mrowe@apple.com
  • 3 edits in branches/safari-533-branch/WebCore

Merge r59186.

4:45 PM Changeset in webkit [59407] by mrowe@apple.com
  • 3 edits
    4 adds in branches/safari-533-branch

Merge r59199.

4:45 PM Changeset in webkit [59406] by mrowe@apple.com
  • 2 edits
    1 add in branches/safari-533-branch/WebCore

Merge r59263.

4:45 PM Changeset in webkit [59405] by mrowe@apple.com
  • 1 edit in branches/safari-533-branch/WebCore/ChangeLog

Merge r59242.

4:45 PM Changeset in webkit [59404] by mrowe@apple.com
  • 5 edits
    2 adds in branches/safari-533-branch

Merge r59241.

4:45 PM Changeset in webkit [59403] by mrowe@apple.com
  • 2 edits in branches/safari-533-branch/WebCore

Merge r59247.

4:45 PM Changeset in webkit [59402] by mrowe@apple.com
  • 3 edits in branches/safari-533-branch/JavaScriptCore

Merge r59202.

4:45 PM Changeset in webkit [59401] by mrowe@apple.com
  • 8 edits in branches/safari-533-branch/JavaScriptCore

Merge r59196.

4:45 PM Changeset in webkit [59400] by mrowe@apple.com
  • 15 edits
    1 add in branches/safari-533-branch

Merge r59187.

4:44 PM Changeset in webkit [59399] by mrowe@apple.com
  • 7 edits in branches/safari-533-branch

Merge r59336.

4:41 PM Changeset in webkit [59398] by Martin Robinson
  • 2 edits in trunk/LayoutTests

2010-05-13 Martin Robinson <​mrobinson@igalia.com>

No review needed.

[GTK] Some test results are one pixel different on x86_64
​https://bugs.webkit.org/show_bug.cgi?id=39022

  • platform/gtk/Skipped: Skipping this test because of single-pixel difference.
4:22 PM Changeset in webkit [59397] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

Unreviewed.

[Qt] Platform specific expected file updated after r59385.

Adding block elements to a block and removing them changes the height of the element.
​https://bugs.webkit.org/show_bug.cgi?id=38874

  • platform/qt/editing/deleting/5408255-expected.txt: updated.
4:14 PM Changeset in webkit [59396] by Simon Fraser
  • 14 edits
    1 copy
    2 adds in trunk

2010-05-13 Simon Fraser <Simon Fraser>

Reviewed by Dave Hyatt.

Fix scrolling in composited iframes
​https://bugs.webkit.org/show_bug.cgi?id=39088
<rdar://problem/7980099>

When propagating compositing out of iframes, we have to update the position of the iframe content
layers on scrolling.

Test: compositing/iframes/scrolling-iframe.html

  • page/FrameView.cpp: (WebCore::FrameView::scrollPositionChanged): Call updateContentLayerScrollPosition() when scrolling.
  • rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::updateGraphicsLayerGeometry): Renamed setRootPlatformLayerClippingBox() to updateContentLayerOffset().
  • rendering/RenderLayerCompositor.h:
  • rendering/RenderLayerCompositor.cpp: Rename m_clippingLayer to m_clipLayer to go better with m_scrollLayer. (WebCore::RenderLayerCompositor::updateContentLayerOffset): Renamed from setRootPlatformLayerClippingBox().

Set the size of the clipping layer from the FrameView now, so that scrollbars are not clipped out.
Update the scroll layer position too.

(WebCore::RenderLayerCompositor::updateContentLayerScrollPosition): Set the position of the scroll layer

when the ScrollView is scrolled.

(WebCore::RenderLayerCompositor::rootPlatformLayer): m_clippingLayer rename.
(WebCore::RenderLayerCompositor::ensureRootPlatformLayer): m_clippingLayer rename. Also create m_scrollLayer at

the same time as the clip layer, and clean it up as necessary.

(WebCore::RenderLayerCompositor::destroyRootPlatformLayer): m_clippingLayer rename, and clean up the m_scrollLayer too.
(WebCore::RenderLayerCompositor::detachRootPlatformLayer): m_clippingLayer rename

4:14 PM Changeset in webkit [59395] by Martin Robinson
  • 2 edits
    62 adds in trunk/LayoutTests

2010-05-13 Martin Robinson <​mrobinson@igalia.com>

No review. Adding baselines for many of the css1 tests. I've checked these manually.

  • platform/gtk/Skipped: Unskipping tests.
  • platform/gtk/css1/basic/class_as_selector-expected.txt: Added.
  • platform/gtk/css1/basic/comments-expected.txt: Added.
  • platform/gtk/css1/basic/containment-expected.txt: Added.
  • platform/gtk/css1/basic/contextual_selectors-expected.txt: Added.
  • platform/gtk/css1/basic/grouping-expected.txt: Added.
  • platform/gtk/css1/basic/id_as_selector-expected.txt: Added.
  • platform/gtk/css1/basic/inheritance-expected.txt: Added.
  • platform/gtk/css1/box_properties/acid_test-expected.txt: Added.
  • platform/gtk/css1/box_properties/border-expected.txt: Added.
  • platform/gtk/css1/box_properties/border_bottom-expected.txt: Added.
  • platform/gtk/css1/box_properties/border_bottom_inline-expected.txt: Added.
  • platform/gtk/css1/box_properties/border_bottom_width-expected.txt: Added.
  • platform/gtk/css1/box_properties/border_bottom_width_inline-expected.txt: Added.
  • platform/gtk/css1/box_properties/border_color-expected.txt: Added.
  • platform/gtk/css1/box_properties/border_color_inline-expected.txt: Added.
  • platform/gtk/css1/box_properties/border_inline-expected.txt: Added.
  • platform/gtk/css1/box_properties/border_left-expected.txt: Added.
  • platform/gtk/css1/box_properties/border_left_inline-expected.txt: Added.
  • platform/gtk/css1/box_properties/border_left_width-expected.txt: Added.
  • platform/gtk/css1/box_properties/border_left_width_inline-expected.txt: Added.
  • platform/gtk/css1/box_properties/border_right-expected.txt: Added.
  • platform/gtk/css1/box_properties/border_right_inline-expected.txt: Added.
  • platform/gtk/css1/box_properties/border_right_width-expected.txt: Added.
  • platform/gtk/css1/box_properties/border_right_width_inline-expected.txt: Added.
  • platform/gtk/css1/box_properties/border_style-expected.txt: Added.
  • platform/gtk/css1/box_properties/border_style_inline-expected.txt: Added.
  • platform/gtk/css1/box_properties/border_top-expected.txt: Added.
  • platform/gtk/css1/box_properties/border_top_inline-expected.txt: Added.
  • platform/gtk/css1/box_properties/border_top_width-expected.txt: Added.
  • platform/gtk/css1/box_properties/border_top_width_inline-expected.txt: Added.
  • platform/gtk/css1/box_properties/border_width-expected.txt: Added.
  • platform/gtk/css1/box_properties/border_width_inline-expected.txt: Added.
  • platform/gtk/css1/box_properties/clear-expected.txt: Added.
  • platform/gtk/css1/box_properties/clear_float-expected.txt: Added.
  • platform/gtk/css1/box_properties/float-expected.txt: Added.
  • platform/gtk/css1/box_properties/float_elements_in_series-expected.txt: Added.
  • platform/gtk/css1/box_properties/float_margin-expected.txt: Added.
  • platform/gtk/css1/box_properties/float_on_text_elements-expected.txt: Added.
  • platform/gtk/css1/box_properties/height-expected.txt: Added.
  • platform/gtk/css1/box_properties/margin-expected.txt: Added.
  • platform/gtk/css1/box_properties/margin_bottom-expected.txt: Added.
  • platform/gtk/css1/box_properties/margin_bottom_inline-expected.txt: Added.
  • platform/gtk/css1/box_properties/margin_inline-expected.txt: Added.
  • platform/gtk/css1/box_properties/margin_left-expected.txt: Added.
  • platform/gtk/css1/box_properties/margin_left_inline-expected.txt: Added.
  • platform/gtk/css1/box_properties/margin_right-expected.txt: Added.
  • platform/gtk/css1/box_properties/margin_right_inline-expected.txt: Added.
  • platform/gtk/css1/box_properties/margin_top-expected.txt: Added.
  • platform/gtk/css1/box_properties/margin_top_inline-expected.txt: Added.
  • platform/gtk/css1/box_properties/padding-expected.txt: Added.
  • platform/gtk/css1/box_properties/padding_bottom-expected.txt: Added.
  • platform/gtk/css1/box_properties/padding_bottom_inline-expected.txt: Added.
  • platform/gtk/css1/box_properties/padding_inline-expected.txt: Added.
  • platform/gtk/css1/box_properties/padding_left-expected.txt: Added.
  • platform/gtk/css1/box_properties/padding_left_inline-expected.txt: Added.
  • platform/gtk/css1/box_properties/padding_right-expected.txt: Added.
  • platform/gtk/css1/box_properties/padding_right_inline-expected.txt: Added.
  • platform/gtk/css1/box_properties/padding_top-expected.txt: Added.
  • platform/gtk/css1/box_properties/padding_top_inline-expected.txt: Added.
3:56 PM Changeset in webkit [59394] by weinig@apple.com
  • 2 edits in trunk/WebCore

Follow up to:
Fix for ​https://bugs.webkit.org/show_bug.cgi?id=38221
Memory issues due to the changes in 36556 (increased CSSPrimitiveValue size).
Part of <rdar://problem/7921275>

Reviewed by Anders Carlsson.

Fix failing tests on Leopard.

Initialize m_hasCachedCSSText in CSSPrimitiveValue::init methods.

  • css/CSSPrimitiveValue.cpp:

(WebCore::CSSPrimitiveValue::init):
(WebCore::CSSPrimitiveValue::cssText): Add extra assertion.

3:45 PM Changeset in webkit [59393] by Martin Robinson
  • 2 edits in trunk/LayoutTests

2010-05-13 Martin Robinson <​mrobinson@igalia.com>

No review. Rebaselining test after r59385.

  • platform/gtk/editing/deleting/delete-select-all-001-expected.txt: Rebaseline
3:39 PM Changeset in webkit [59392] by beidson@apple.com
  • 3 edits in trunk/LayoutTests

Adding fast/loader/recursive-before-unload-crash-expected.html to the gtk skipped list
because it needs more logging in its DRT to pass:

  • platform/gtk/Skipped:

Adding fast/loader/recursive-before-unload-crash-expected.html to the qt skipped list
because it's hanging:

  • platform/qt/Skipped:
3:39 PM Changeset in webkit [59391] by ap@apple.com
  • 2 edits in trunk/WebKit/mac

Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=39089
<rdar://problem/7974044> Domain names in Russian '.рф' domain are displayed as punycode

Add a custom check for this domain. Currently, this is the only non-ASCII TLD, we'll
investigate a more extensible solution when there are more, and we know what the
typical restictions are.

  • Misc/WebNSURLExtras.mm: (allCharactersAllowedByTLDRules): (-[NSString _web_mapHostNameWithRange:encode:makeString:]):
3:33 PM Changeset in webkit [59390] by tkent@chromium.org
  • 3 edits
    2 adds in trunk

2010-05-13 Kent Tamura <​tkent@chromium.org>

Reviewed by Darin Adler.

Can't submit a form with <input type=checkbox required>
​https://bugs.webkit.org/show_bug.cgi?id=39065

  • fast/forms/interactive-validation-required-checkbox-expected.txt: Added.
  • fast/forms/interactive-validation-required-checkbox.html: Added.

2010-05-13 Kent Tamura <​tkent@chromium.org>

Reviewed by Darin Adler.

Can't submit a form with <input type=checkbox required>
​https://bugs.webkit.org/show_bug.cgi?id=39065

Test: fast/forms/interactive-validation-required-checkbox.html

  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::setChecked): Update the validity cache when a checkbox state is changed.
3:12 PM Changeset in webkit [59389] by beidson@apple.com
  • 1 edit
    1 copy in trunk/LayoutTests

​https://bugs.webkit.org/show_bug.cgi?id=38928

Reviewed by NOBODY (Layout test fix)

Add Tiger specific results for my new test.

  • platform/mac-tiger/fast/loader/recursive-before-unload-crash-expected.txt: Copied from fast/loader/recursive-before-unload-crash-expected.txt.
3:07 PM Changeset in webkit [59388] by kbr@google.com
  • 12 edits in trunk

2010-05-13 Kenneth Russell <​kbr@google.com>

Reviewed by Dimitri Glazkov.

Alias WebGLArray type names to TypedArray type names
​https://bugs.webkit.org/show_bug.cgi?id=39036

Exposed the existing WebGL<T>Array constructor functions on the
DOMWindow under the naming convention in the TypedArray spec. The
implementations will be renamed in a subsequent bug, and the
aliases to the WebGL<T>Array type names eventually removed. Ran
all layout tests (including WebGL) in Safari, and WebGL tests in
Chromium.

Test: revised array-unit-tests.html to test both type names.
Revised global prototype and constructor tests to ignore new types.

  • bindings/generic/RuntimeEnabledFeatures.h: (WebCore::RuntimeEnabledFeatures::arrayBufferEnabled): (WebCore::RuntimeEnabledFeatures::int8ArrayEnabled): (WebCore::RuntimeEnabledFeatures::uint8ArrayEnabled): (WebCore::RuntimeEnabledFeatures::int16ArrayEnabled): (WebCore::RuntimeEnabledFeatures::uint16ArrayEnabled): (WebCore::RuntimeEnabledFeatures::int32ArrayEnabled): (WebCore::RuntimeEnabledFeatures::uint32ArrayEnabled): (WebCore::RuntimeEnabledFeatures::floatArrayEnabled):
  • bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::arrayBuffer): (WebCore::JSDOMWindow::int8Array): (WebCore::JSDOMWindow::uint8Array): (WebCore::JSDOMWindow::int32Array): (WebCore::JSDOMWindow::uint32Array): (WebCore::JSDOMWindow::int16Array): (WebCore::JSDOMWindow::uint16Array): (WebCore::JSDOMWindow::floatArray):
  • bindings/v8/custom/V8DOMWindowCustom.cpp: (WebCore::V8DOMWindow::ArrayBufferAccessorGetter): (WebCore::V8DOMWindow::Int8ArrayAccessorGetter): (WebCore::V8DOMWindow::Uint8ArrayAccessorGetter): (WebCore::V8DOMWindow::Int16ArrayAccessorGetter): (WebCore::V8DOMWindow::Uint16ArrayAccessorGetter): (WebCore::V8DOMWindow::Int32ArrayAccessorGetter): (WebCore::V8DOMWindow::Uint32ArrayAccessorGetter): (WebCore::V8DOMWindow::FloatArrayAccessorGetter):
  • page/DOMWindow.idl:

2010-05-13 Kenneth Russell <​kbr@google.com>

Reviewed by Dimitri Glazkov.

Alias WebGLArray type names to TypedArray type names
​https://bugs.webkit.org/show_bug.cgi?id=39036

Exposed the existing WebGL<T>Array constructor functions on the
DOMWindow under the naming convention in the TypedArray spec. The
implementations will be renamed in a subsequent bug, and the
aliases to the WebGL<T>Array type names eventually removed. Ran
all layout tests (including WebGL) in Safari, and WebGL tests in
Chromium.

Test: revised array-unit-tests.html to test both type names.
Revised global prototype and constructor tests to ignore new types.

  • fast/canvas/webgl/array-unit-tests-expected.txt:
  • fast/canvas/webgl/array-unit-tests.html:
  • fast/dom/Window/script-tests/window-property-descriptors.js:
  • fast/dom/Window/window-properties.html:
  • fast/dom/script-tests/prototype-inheritance.js:
  • fast/js/script-tests/global-constructors.js:
2:51 PM Changeset in webkit [59387] by hyatt@apple.com
  • 4 edits in trunk/WebCore

​https://bugs.webkit.org/show_bug.cgi?id=39084

Reviewed by Anders Carlsson.

Improve :visited style resolution to reduce its memory footprint and to make some speed adjustments and
simplifications.

(1) Tie the caching of link state on CSSStyleSelector to the element. Just clear out the element when
style resolution finishes for the unvisited case to avoid caching across external calls. The internal
calls share the cache just fine by doing this.

(2) Delete the RenderStyle if the link is unvisited. This shouldn't take long enough to make us vulnerable
to timing attacks, and it makes sure the overall footprint stays the way it used to be for unvisited links.

(3) Limit the set of properties that can be applied to :visited links to only the colors it supports. This
stops images from being loadable from :visited rules.

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::init):
(WebCore::CSSStyleSelector::SelectorChecker::determineLinkState):
(WebCore::CSSStyleSelector::initElement):
(WebCore::CSSStyleSelector::canShareStyleWithElement):
(WebCore::CSSStyleSelector::styleForElement):
(WebCore::CSSStyleSelector::pseudoStyleForElement):
(WebCore::isValidVisitedLinkProperty):
(WebCore::CSSStyleSelector::applyProperty):

  • css/CSSStyleSelector.h:
  • rendering/style/RenderStyle.cpp:

(WebCore::colorIncludingFallback):

2:32 PM Changeset in webkit [59386] by weinig@apple.com
  • 4 edits in trunk/WebCore

Fix for ​https://bugs.webkit.org/show_bug.cgi?id=38221
Memory issues due to the changes in 36556 (increased CSSPrimitiveValue size).
Part of <rdar://problem/7921275>

Reviewed by Darin Adler.

  • Use an external cache to speedup cssText for CSSPrimitiveValue instead of an extra member variable.
  • css/CSSPrimitiveValue.cpp:

(WebCore::cssTextCache):
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::cleanup):
(WebCore::CSSPrimitiveValue::cssText):

  • css/CSSPrimitiveValue.h:

(WebCore::CSSPrimitiveValue::):

  • css/CSSPrimitiveValueMappings.h:

(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):

1:48 PM Changeset in webkit [59385] by enrica@apple.com
  • 8 edits
    2 adds in trunk

Adding block elements to a block and removing them changes the height of the element.
​https://bugs.webkit.org/show_bug.cgi?id=38874

Reviewed by Dave Hyatt.

WebCore:

The initial height of an empty editable block is different from the height of the same block after we add block elements
and remove them.

Test: editing/deleting/delete-block-contents-004.html

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::layoutBlock): resetting m_childrenInline flag to true when layout a block with no children.

LayoutTests:

The initial height of an empty editable block is different from the height of the same block after we add block elements
and remove them.

  • editing/deleting/delete-block-contents-004-expected.txt: Added.
  • editing/deleting/delete-block-contents-004.html: Added.

The following tests results have been updated to reflect the new renderer structure.

  • editing/deleting/in-visibly-empty-root-expected.txt:
  • platform/mac/editing/deleting/5408255-expected.txt:
  • platform/mac/editing/deleting/delete-select-all-001-expected.txt:
  • platform/mac/editing/selection/4895428-1-expected.txt:
  • platform/mac/editing/selection/4895428-4-expected.txt:
1:31 PM Changeset in webkit [59384] by beidson@apple.com
  • 6 edits
    2 adds in trunk

Repro crash at www.sears.com (infinite recursion in beforeunload handler)
<rdar://problem/7965182> and ​https://bugs.webkit.org/show_bug.cgi?id=38928

Reviewed by Darin Adler.

WebCore:

Test: fast/loader/recursive-before-unload-crash.html

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::shouldClose): Copied from Frame, with the pageDismissal flag set.

  • loader/FrameLoader.h:
  • page/Frame.cpp:

(WebCore::Frame::shouldClose): Forward to the new FrameLoader::shouldClose().

  • page/Frame.h:

(WebCore::Frame::existingDOMWindow):

LayoutTests:

  • fast/loader/recursive-before-unload-crash-expected.txt: Added.
  • fast/loader/recursive-before-unload-crash.html: Added.
1:06 PM Changeset in webkit [59383] by eric@webkit.org
  • 8 edits in trunk

2010-05-13 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r59376.
​http://trac.webkit.org/changeset/59376
​https://bugs.webkit.org/show_bug.cgi?id=39080

Broke window prototype tests (Requested by jamesr on #webkit).

  • fast/canvas/webgl/array-unit-tests-expected.txt:
  • fast/canvas/webgl/array-unit-tests.html:

2010-05-13 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r59376.
​http://trac.webkit.org/changeset/59376
​https://bugs.webkit.org/show_bug.cgi?id=39080

Broke window prototype tests (Requested by jamesr on #webkit).

  • bindings/generic/RuntimeEnabledFeatures.h:
  • bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::webGLFloatArray):
  • bindings/v8/custom/V8DOMWindowCustom.cpp:
  • page/DOMWindow.idl:
12:35 PM Changeset in webkit [59382] by diegohcg@webkit.org
  • 2 edits in trunk/WebKitTools

2010-05-13 Diego Gonzalez <​diegohcg@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Improve QtLauncher user agent dialog resize
​https://bugs.webkit.org/show_bug.cgi?id=39062

  • QtLauncher/main.cpp: (LauncherWindow::showUserAgentDialog):
12:24 PM Changeset in webkit [59381] by pfeldman@chromium.org
  • 7 edits
    1 copy
    1 add in trunk

2010-05-13 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: A disabled style property cannot be deleted.

​https://bugs.webkit.org/show_bug.cgi?id=39057

  • inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::applyStyleText):

2010-05-13 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: A disabled style property cannot be deleted.

​https://bugs.webkit.org/show_bug.cgi?id=39057

  • inspector/elements-tests.js: (frontend_getSelectedElementStyles):
  • inspector/styles-disable-then-delete-expected.txt: Added.
  • inspector/styles-disable-then-delete.html: Added.
  • inspector/styles-disable-then-enable.html:
12:15 PM Changeset in webkit [59380] by diegohcg@webkit.org
  • 2 edits in trunk/WebKit/qt

2010-05-11 Diego Gonzalez <​diegohcg@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] tst_QWebPage::inputMethods failing on Maemo5
​https://bugs.webkit.org/show_bug.cgi?id=38685

Check if the SIP (Software Input Panel) is triggered, which usually happens
in the case of a mobile platforms, an user input form receives a mouse click.

  • tests/qwebpage/tst_qwebpage.cpp: (tst_QWebPage::inputMethods):
12:08 PM Changeset in webkit [59379] by eric@webkit.org
  • 3 edits in trunk/WebKitTools

2010-05-13 Eric Seidel <​eric@webkit.org>

Reviewed by Ojan Vafai.

Disable compositing/iframes tests on the commit-queue as a workaround for bug 38912
​https://bugs.webkit.org/show_bug.cgi?id=39067

Fix yet another typo in my original hack.
I also added another unit test for this fix.

  • Scripts/webkitpy/common/config/ports.py:
  • Scripts/webkitpy/common/config/ports_unittest.py:
11:59 AM Changeset in webkit [59378] by tonikitoo@webkit.org
  • 2 edits in trunk/WebKit/qt

[Qt] REGRESSION(r58497) tst_QGraphicsWebView::crashOnViewlessWebPages() is failing
​https://bugs.webkit.org/show_bug.cgi?id=38655

Patch by Kenneth Rohde Christiansen <​kenneth@webkit.org> on 2010-05-11
Reviewed by Laszlo Gombos.

Fix double free by moving the connect till after the resize.

The bug is causes by the fact that a resize of an empty page causes a
layout, thus deleting the qgraphicswebview before setHtml is called,
which then deletes it again, causing a double free.

  • tests/qgraphicswebview/tst_qgraphicswebview.cpp:

(tst_QGraphicsWebView::crashOnViewlessWebPages):

11:54 AM Changeset in webkit [59377] by tonikitoo@webkit.org
  • 2 edits in trunk/WebKit/qt

Regression(r59152): QGraphicsPageClient is not forwarding scroll and update events to view ​https://bugs.webkit.org/show_bug.cgi?id=39016

Patch by Kenneth Rohde Christiansen <​kenneth@webkit.org> on 2010-05-12
Reviewed by Laszlo Gombos.

Some forward calls got lost during the refatory.

  • WebCoreSupport/PageClientQt.cpp:

(WebCore::PageClientQGraphicsWidget::scroll):
(WebCore::PageClientQGraphicsWidget::update):

11:51 AM Changeset in webkit [59376] by kbr@google.com
  • 8 edits in trunk

2010-05-12 Kenneth Russell <​kbr@google.com>

Reviewed by Dimitri Glazkov.

Alias WebGLArray type names to TypedArray type names
​https://bugs.webkit.org/show_bug.cgi?id=39036

Exposed the existing WebGL<T>Array constructor functions on the
DOMWindow under the naming convention in the TypedArray spec. The
implementations will be renamed in a subsequent bug, and the
aliases to the WebGL<T>Array type names eventually removed. Ran
all WebGL layout tests in Safari and Chromium.

Test: revised array-unit-tests.html to test both type names.

  • bindings/generic/RuntimeEnabledFeatures.h: (WebCore::RuntimeEnabledFeatures::arrayBufferEnabled): (WebCore::RuntimeEnabledFeatures::int8ArrayEnabled): (WebCore::RuntimeEnabledFeatures::uint8ArrayEnabled): (WebCore::RuntimeEnabledFeatures::int16ArrayEnabled): (WebCore::RuntimeEnabledFeatures::uint16ArrayEnabled): (WebCore::RuntimeEnabledFeatures::int32ArrayEnabled): (WebCore::RuntimeEnabledFeatures::uint32ArrayEnabled): (WebCore::RuntimeEnabledFeatures::floatArrayEnabled):
  • bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::arrayBuffer): (WebCore::JSDOMWindow::int8Array): (WebCore::JSDOMWindow::uint8Array): (WebCore::JSDOMWindow::int32Array): (WebCore::JSDOMWindow::uint32Array): (WebCore::JSDOMWindow::int16Array): (WebCore::JSDOMWindow::uint16Array): (WebCore::JSDOMWindow::floatArray):
  • bindings/v8/custom/V8DOMWindowCustom.cpp: (WebCore::V8DOMWindow::ArrayBufferAccessorGetter): (WebCore::V8DOMWindow::Int8ArrayAccessorGetter): (WebCore::V8DOMWindow::Uint8ArrayAccessorGetter): (WebCore::V8DOMWindow::Int16ArrayAccessorGetter): (WebCore::V8DOMWindow::Uint16ArrayAccessorGetter): (WebCore::V8DOMWindow::Int32ArrayAccessorGetter): (WebCore::V8DOMWindow::Uint32ArrayAccessorGetter): (WebCore::V8DOMWindow::FloatArrayAccessorGetter):
  • page/DOMWindow.idl:

2010-05-12 Kenneth Russell <​kbr@google.com>

Reviewed by Dimitri Glazkov.

Alias WebGLArray type names to TypedArray type names
​https://bugs.webkit.org/show_bug.cgi?id=39036

Exposed the existing WebGL<T>Array constructor functions on the
DOMWindow under the naming convention in the TypedArray spec. The
implementations will be renamed in a subsequent bug, and the
aliases to the WebGL<T>Array type names eventually removed. Ran
all WebGL layout tests in Safari and Chromium.

Test: revised array-unit-tests.html to test both type names.

  • fast/canvas/webgl/array-unit-tests-expected.txt:
  • fast/canvas/webgl/array-unit-tests.html:
11:44 AM BuildingQtOnLinux edited by ikipou@gmail.com
Update the minimal verison of Qt required to compile WebKit (diff)
11:33 AM Changeset in webkit [59375] by eric@webkit.org
  • 4 edits in trunk/WebKitTools

2010-05-13 Eric Seidel <​eric@webkit.org>

Reviewed by Ojan Vafai.

Disable compositing/iframes tests on the commit-queue as a workaround for bug 38912
​https://bugs.webkit.org/show_bug.cgi?id=39067

My previous (unreviewed) hack didn't actually work due to checking "mac" instead of "Mac".
This change fixes my hack, and unit tests it.

  • Scripts/webkitpy/tool/mocktool.py:
    • Make it possible to make run_command log too.
  • Scripts/webkitpy/tool/steps/runtests.py:
    • Fix my hack to actually work.
  • Scripts/webkitpy/tool/steps/steps_unittest.py:
    • Test my hack (and basic RunTests behavior as well).
11:17 AM Changeset in webkit [59374] by beidson@apple.com
  • 3 edits in trunk/WebCore

Part of <rdar://problem/7965182> and ​https://bugs.webkit.org/show_bug.cgi?id=38928

Reviewed by John Sullivan.

No new tests. (No change in behavior)

m_unloadEventBeingDispatched was already overloaded to include both unload and pagehide events.
In general, these are "page dismissal" events, and might also include beforeunload, so let's rename
the flag!

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::FrameLoader):
(WebCore::FrameLoader::stopLoading):
(WebCore::FrameLoader::loadURL):
(WebCore::FrameLoader::loadWithDocumentLoader):
(WebCore::FrameLoader::stopAllLoaders):
(WebCore::FrameLoader::continueLoadAfterNavigationPolicy):
(WebCore::FrameLoader::pageHidden):

  • loader/FrameLoader.h:
10:59 AM Changeset in webkit [59373] by tonikitoo@webkit.org
  • 8 edits in trunk

2010-05-13 Antonio Gomes <​tonikitoo@webkit.org>, Yi Shen <​yi.4.shen@nokia.com>

Reviewed by Kenneth Christiansen.

[Qt] Add LayoutTestController interface: computedStyleIncludingVisitedInfo
​https://bugs.webkit.org/show_bug.cgi?id=37759

WebKit/qt:

  • WebCoreSupport/DumpRenderTreeSupportQt.cpp: (DumpRenderTreeSupportQt::markerTextForListItem): (DumpRenderTreeSupportQt::computedStyleIncludingVisitedInfo):
  • WebCoreSupport/DumpRenderTreeSupportQt.h:

WebKitTools:

  • DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::computedStyleIncludingVisitedInfo):
  • DumpRenderTree/qt/LayoutTestControllerQt.h:

LayoutTests:

  • platform/qt/Skipped:
10:57 AM UsingGitWithWebKit edited by ojan@chromium.org
(diff)
10:55 AM UsingGitWithWebKit edited by ojan@chromium.org
(diff)
10:27 AM Changeset in webkit [59372] by Joseph Pecoraro
  • 4 edits in trunk/WebCore

2010-05-13 Joseph Pecoraro <Joseph Pecoraro>

Reviewed by Pavel Feldman.

Web Inspector: Event Markers should be hidden in Resource's "Size" Graph
​https://bugs.webkit.org/show_bug.cgi?id=39074

Added Show / Hide event dividers functionality to the timeline grid,
and included delegation functions in AbstractTimelinePanel.

  • inspector/front-end/AbstractTimelinePanel.js: delegate to the inner grid (WebInspector.AbstractTimelinePanel.prototype.hideEventDividers): (WebInspector.AbstractTimelinePanel.prototype.showEventDividers):
  • inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel.prototype.populateSidebar): save a reference to the size graph item to know when its selected (WebInspector.ResourcesPanel.prototype._graphSelected): if the size graph is selected hide the dividers, otherwise show them
  • inspector/front-end/TimelineGrid.js: (WebInspector.TimelineGrid.prototype.hideEventDividers): set the container to display: none (WebInspector.TimelineGrid.prototype.showEventDividers): set the container to display: block
10:08 AM Changeset in webkit [59371] by Adam Roben
  • 5 edits in trunk/WebKitTools

Convert status bar text to UTF-8 before logging it on Windows

We were previously logging the text using printf("%S", bstr). This
converts the UTF-16 BSTR to a multibyte string using wctomb, which
uses the codepage for the current locale to perform the conversion.
The conversion was failing, causing printf to bail and truncate the
string. By converting to UTF-8 manually before logging, we avoid this
issue (and also end up with UTF-8 output, which is what the expected
results contain). We may have to do this in other places in DRT,
eventually.

Fixes <​http://webkit.org/b/38849> REGRESSION (r59016):
plugins/set-status.html fails on Windows

Reviewed by Alexey Proskuryakov.

  • DumpRenderTree/win/DumpRenderTree.cpp:

(toUTF8): Moved this here from FrameLoadDelegate. Renamed from
BSTRtoString.

  • DumpRenderTree/win/DumpRenderTreeWin.h: Added declaration of toUTF8.
  • DumpRenderTree/win/FrameLoadDelegate.cpp: Removed BSTRtoString.

(descriptionSuitableForTestResult): Updated for rename.

  • DumpRenderTree/win/UIDelegate.cpp:

(UIDelegate::setStatusText): Convert the status bar text to UTF-8
before logging it so that Windows won't try (and fail) to convert it
to the current locale's codepage.

10:07 AM Changeset in webkit [59370] by Adam Roben
  • 2 edits in trunk/SunSpider

Fix typo in sunspider-compare-results.js that caused incorrect two-sample t statistics to be computed

Fixes <​http://webkit.org/b/38768> SunSpider computes incorrect
two-sample t statistics

Reviewed by Darin Adler.

  • resources/sunspider-compare-results.js:

(sunspiderCompareResults.resultLine): Fixed the calculation of the t
variable to match the definition of a two-sample t statistic. Looks
like this was just a simple typo.

8:35 AM Changeset in webkit [59369] by Martin Robinson
  • 2 edits in trunk/LayoutTests

2010-05-13 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Gustavo Noronha.

Events tests failing
​https://bugs.webkit.org/show_bug.cgi?id=31436

Unskip these two test which are now passing.

  • platform/gtk/Skipped: Unskip two tests.
8:34 AM Changeset in webkit [59368] by pfeldman@chromium.org
  • 2 edits in trunk/WebKit/chromium

2010-05-13 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: main inspector toolbar takes noticeable time to expand.

​https://bugs.webkit.org/show_bug.cgi?id=39013

  • src/js/DevTools.js: (devtools.domContentLoaded):
8:21 AM Changeset in webkit [59367] by Martin Robinson
  • 2 edits in trunk/LayoutTests

2010-05-13 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Gustavo Noronha.

Two forms tests failing
​https://bugs.webkit.org/show_bug.cgi?id=31435

Unskip passing tests.

  • platform/gtk/Skipped: Unskip these tests, because they are passing now.
7:56 AM Changeset in webkit [59366] by chang.shu@nokia.com
  • 2 edits in trunk/WebCore

2010-05-13 Chang Shu <​chang.shu@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

Based on the spec and Philip Taylor's test suite, strokeStyle and fillStyle attributes
must initially have the string value #000000.
The link to the spec:
​http://philip.html5.org/tests/canvas/suite/tests/spec.html#testrefs.2d.colours.default

​https://bugs.webkit.org/show_bug.cgi?id=39068

The complete test suite is in the process of checking in.
​https://bugs.webkit.org/show_bug.cgi?id=20553

  • html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::State::State):
7:41 AM Changeset in webkit [59365] by yurys@chromium.org
  • 17 edits
    3 deletes in trunk/WebCore

2010-05-13 Yury Semikhatsky <​yurys@chromium.org>

Unreviewed, rolling out r59360.
​http://trac.webkit.org/changeset/59360
​https://bugs.webkit.org/show_bug.cgi?id=38667

It broke Chromium Win build

  • English.lproj/localizedStrings.js:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/front-end/CallStackSidebarPane.js: (WebInspector.CallStackSidebarPane): (WebInspector.CallStackSidebarPane.prototype._placardSelected):
  • inspector/front-end/ConsoleView.js: (WebInspector.ConsoleView):
  • inspector/front-end/ElementsPanel.js: (WebInspector.ElementsPanel):
  • inspector/front-end/ElementsTreeOutline.js: (WebInspector.ElementsTreeOutline.prototype._keyDown):
  • inspector/front-end/HelpScreen.js: Removed.
  • inspector/front-end/KeyboardShortcut.js: (WebInspector.KeyboardShortcut._makeKeyFromCodeAndModifiers):
  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel): (WebInspector.ScriptsPanel.prototype.elementsToRestoreScrollPositionsFor):
  • inspector/front-end/ShortcutsHelp.js: Removed.
  • inspector/front-end/SidebarPane.js: (WebInspector.SidebarPane.prototype._onTitleKeyDown):
  • inspector/front-end/StylesSidebarPane.js: (WebInspector.StylesSidebarPane.prototype.removeSection):
  • inspector/front-end/TextViewer.js: (WebInspector.TextViewer.prototype._handleKeyDown):
  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/helpScreen.css: Removed.
  • inspector/front-end/inspector.html:
  • inspector/front-end/inspector.js: (WebInspector.loaded): (WebInspector.documentKeyDown): (WebInspector._searchKeyDown): (WebInspector.startEditing.keyDownEventListener): (WebInspector.startEditing):
  • inspector/front-end/utilities.js:
7:39 AM Changeset in webkit [59364] by eric@webkit.org
  • 3 edits in trunk/WebKitTools

2010-05-13 Eric Seidel <​eric@webkit.org>

Unreviewed hack, attempting to get the commit-queue running again.

Disable compositing/iframes tests on the commit-queue as a workaround for bug 38912
​https://bugs.webkit.org/show_bug.cgi?id=39067

I had this hack locally on the commit-queue, but it's fragile
and broke this morning. It will work much better if committed
to the repository. In either case it's temporary while we
work up a real fix for bug 38912.

  • Scripts/webkitpy/common/config/ports.py:
    • Expose an is_leopard() method.
  • Scripts/webkitpy/tool/steps/runtests.py:
    • Don't run compositing/iframes tests on the commit-queue under leopard.
7:35 AM Changeset in webkit [59363] by antti.j.koivisto@nokia.com
  • 2 edits in trunk/WebCore

​https://bugs.webkit.org/show_bug.cgi?id=39063
[Qt] Tiled backing store checker pattern does not paint correctly when scaling factor is not 1

Reviewed by Kenneth Rohde Christiansen.

Use the dirty rect that has been adjusted for scaling instead of the original one.

  • platform/graphics/TiledBackingStore.cpp:

(WebCore::TiledBackingStore::paint):

7:07 AM Changeset in webkit [59362] by chang.shu@nokia.com
  • 2 edits in trunk/WebCore

2010-05-13 Chang Shu <​chang.shu@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

Based on Philip Taylor's test suite, resetting the canvas
state resets the current path.
​https://bugs.webkit.org/show_bug.cgi?id=38934

The complete test suite is in the process of checking in.
​https://bugs.webkit.org/show_bug.cgi?id=20553

  • html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::reset):
6:48 AM Changeset in webkit [59361] by yurys@chromium.org
  • 8 edits
    1 delete in trunk/LayoutTests

2010-05-13 Yury Semikhatsky <​yurys@chromium.org>

Unreviewed. Chromium build fix. Partially rever r59277 which updated Chromium's expectations
after r59270. r59270 was reverted, so we need to revert Chromium's expectations.

  • platform/chromium-linux/editing/deleting/5408255-expected.checksum:
  • platform/chromium-mac/editing/deleting/5408255-expected.checksum: Removed.
  • platform/chromium-win/editing/deleting/5408255-expected.checksum:
  • platform/chromium-win/editing/deleting/5408255-expected.txt:
  • platform/chromium-win/editing/deleting/delete-select-all-001-expected.txt:
  • platform/chromium-win/editing/selection/4895428-1-expected.txt:
  • platform/chromium-win/editing/selection/4895428-4-expected.txt:
  • platform/chromium-win/fast/events/mouseout-dead-node-expected.txt:
6:42 AM Changeset in webkit [59360] by pfeldman@chromium.org
  • 17 edits
    3 adds in trunk/WebCore

2010-05-13 Andrey Kosyakov <​caseq@chromium.org>

Reviewed by Pavel Feldman.

Added help screen with keyboard shortcuts.
​https://bugs.webkit.org/show_bug.cgi?id=38667

  • English.lproj/localizedStrings.js:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/front-end/CallStackSidebarPane.js: (WebInspector.CallStackSidebarPane): (WebInspector.CallStackSidebarPane.prototype._placardSelected): (WebInspector.CallStackSidebarPane.prototype.registerShortcuts):
  • inspector/front-end/ConsoleView.js: (WebInspector.ConsoleView): (WebInspector.ConsoleView.prototype._registerShortcuts):
  • inspector/front-end/ElementsPanel.js: (WebInspector.ElementsPanel): (WebInspector.ElementsPanel.prototype._registerShortcuts):
  • inspector/front-end/HelpScreen.js: Added.
  • inspector/front-end/KeyboardShortcut.js: (WebInspector.KeyboardShortcut.makeDescriptor): (WebInspector.KeyboardShortcut.shortcutToString): (WebInspector.KeyboardShortcut._modifiersToString):
  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel): (WebInspector.ScriptsPanel.prototype.elementsToRestoreScrollPositionsFor): (WebInspector.ScriptsPanel.prototype._registerShortcuts):
  • inspector/front-end/ShortcutsHelp.js: Added.
  • inspector/front-end/StylesSidebarPane.js: (WebInspector.StylesSidebarPane.prototype.removeSection): (WebInspector.StylesSidebarPane.prototype.registerShortcuts):
  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/helpScreen.css: Added.
5:12 AM Changeset in webkit [59359] by hamaji@chromium.org
  • 2 edits in trunk

2010-05-13 Takeshi Yoshino <​tyoshino@google.com>

Reviewed by Shinichiro Hamaji.

Update test_expectations.txt for Chromium.
fast/forms/implicit-submission.html is flaky on Linux.
See ​http://crbug.com/43890 for detail.

  • platform/chromium/test_expectations.txt:
5:05 AM Changeset in webkit [59358] by mjs@apple.com
  • 2 edits in trunk/JavaScriptCore

No review, attempted build fix.

Try to fix Tiger build with some gratuitous initialization of
seemingly uninitialized variables.

  • wtf/text/StringImpl.h:

(WebCore::StringImpl::tryCreateUninitialized):

2:43 AM Changeset in webkit [59357] by hamaji@chromium.org
  • 3 edits
    2 adds in trunk

2010-05-13 Yoshiki Hayashi <​yhayashi@google.com>

Reviewed by Darin Adler.

Fix a bug in handleRunInChild where only the first child run-in block
is inserted because removeChildNode clears next sibling.
​https://bugs.webkit.org/show_bug.cgi?id=25047

  • fast/css/run-in-children-expected.txt: Added.
  • fast/css/run-in-children.html: Added.

2010-05-13 Yoshiki Hayashi <​yhayashi@google.com>

Reviewed by Darin Adler.

Fix a bug in handleRunInChild where only the first child run-in block
is inserted because removeChildNode clears next sibling.
​https://bugs.webkit.org/show_bug.cgi?id=25047

Test: fast/css/run-in-children.html

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::handleRunInChild):
2:37 AM Changeset in webkit [59356] by alex
  • 2 edits in trunk/WebCore

2010-05-13 Alejandro G. Castro <​alex@igalia.com>

Reviewed by Xan Lopez.

In case there is no expose event we render the theme in a pixmap
and copy it to the cairo context. This is slow but it is used just
in case we are printing nowadays.

[GTK] Theme does not render when printing
​https://bugs.webkit.org/show_bug.cgi?id=38896

  • platform/gtk/RenderThemeGtk.cpp: (WebCore::paintMozillaGtkWidget):
2:36 AM Changeset in webkit [59355] by mjs@apple.com
  • 5 edits in trunk/JavaScriptCore

2010-05-13 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Mark Rowe.

Various JavaScript string optimizations
​https://bugs.webkit.org/show_bug.cgi?id=39051

Approximately 1% SunSpider speedup.


  • runtime/ArrayPrototype.cpp: (JSC::arrayProtoFuncJoin): Remove branches from the hot code path by moving the first pass outside the loop, and duplicating the hot loop to extract the loop-invariant branch.
  • runtime/RegExp.cpp: (JSC::RegExp::match): resize ovector to 0 instead of clearing to avoid thrash in case of large matches.
  • runtime/RegExpConstructor.h: (JSC::RegExpConstructor::performMatch): Mark ALWAYS_INLINE to make the compiler respect our authority.
  • runtime/StringPrototype.cpp: (JSC::jsSpliceSubstringsWithSeparators): Inline. (JSC::stringProtoFuncSubstring): Rewrite boundary condition checks to reduce the number of floating point comparisons and branches.
1:52 AM Changeset in webkit [59354] by ukai@chromium.org
  • 3 edits in trunk

WebKitTools: Unreviewed fix. Revert previous change.

Even if with-statments are changed in websocket_server.py, it also claims syntax error for with statement in http_server.py.
Until python 2.5 is installed on tiger bot, skips websocket/tests on tiger.

  • Scripts/webkitpy/layout_tests/port/websocket_server.py: use with statement

LayoutTests: Unreviewed.

Skip websocket/tests on tiger, until Python 2.5 is installed on tiger bot.

  • platform/mac-tiger/Skipped: Add websocket/tests
1:52 AM Changeset in webkit [59353] by ukai@chromium.org
  • 2 edits in trunk/WebKitTools

WebSocket: pywebsocket 0.5
​https://bugs.webkit.org/show_bug.cgi?id=38034

Reviewed by David Levin.

Remove pywebsocket from webkitpy/thirdparty.
Make pywebsocket autoinstalled.

  • Scripts/new-run-webkit-websocketserver: Add --output-dir option.
  • Scripts/old-run-webkit-tests: Use new-run-webkit-websocketserver, rather than directly run pywebsocket's standalone.py
  • Scripts/run-webkit-websocketserver: Ditto.
  • Scripts/webkitpy/layout_tests/port/websocket_server.py: Use autoinstalled pywebsocket.
  • Scripts/webkitpy/thirdparty/init.py: Autoinstall pywebsocket
  • Scripts/webkitpy/thirdparty/pywebsocket: Removed.
1:21 AM Changeset in webkit [59352] by ukai@chromium.org
  • 2 edits in trunk/WebKitTools

Unreviewed fix.

On tiger bot, it claims syntax error for with statement.

  • Scripts/webkitpy/layout_tests/port/websocket_server.py: rewrite with statement with try-finally.
12:32 AM Changeset in webkit [59351] by yuzo@google.com
  • 3 edits
    2 adds in trunk

2010-05-12 Yuzo Fujishima <​yuzo@google.com>

Reviewed by Darin Adler.

Fix Bug 35014 - Modifying UA rules from page JS crashes
​https://bugs.webkit.org/show_bug.cgi?id=35014

  • fast/css/modify-ua-rules-from-javascript-expected.txt: Copied from LayoutTests/editing/selection/5136696-expected.txt.
  • fast/css/modify-ua-rules-from-javascript.html: Added.

2010-05-12 Yuzo Fujishima <​yuzo@google.com>

Reviewed by Darin Adler.

Fix Bug 35014 - Modifying UA rules from page JS crashes
Added a NULL check.
​https://bugs.webkit.org/show_bug.cgi?id=35014

Test: fast/css/modify-ua-rules-from-javascript.html

  • css/CSSMutableStyleDeclaration.cpp: (WebCore::CSSMutableStyleDeclaration::setNeedsStyleRecalc):
12:28 AM Changeset in webkit [59350] by ukai@chromium.org
  • 6 edits
    35 deletes in trunk/WebKitTools

2010-05-13 Fumitoshi Ukai <​ukai@chromium.org>

Reviewed by David Levin.

WebSocket: pywebsocket 0.5
​https://bugs.webkit.org/show_bug.cgi?id=38034

Remove pywebsocket from webkitpy/thirdparty.
Make pywebsocket autoinstalled.

  • Scripts/new-run-webkit-websocketserver: Add --output-dir option.
  • Scripts/old-run-webkit-tests: Use new-run-webkit-websocketserver, rather than directly run pywebsocket's standalone.py
  • Scripts/run-webkit-websocketserver: Ditto.
  • Scripts/webkitpy/layout_tests/port/websocket_server.py: Use autoinstalled pywebsocket.
  • Scripts/webkitpy/thirdparty/init.py: Autoinstall pywebsocket
  • Scripts/webkitpy/thirdparty/pywebsocket: Removed.

May 12, 2010:

11:44 PM Changeset in webkit [59349] by dumi@chromium.org
  • 6 edits
    2 adds in trunk/WebCore

Add the parent class for Database and DatabaseSync.
​https://bugs.webkit.org/show_bug.cgi?id=39041

Reviewed by Adam Barth.

  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • storage/AbstractDatabase.cpp: Added.
  • storage/AbstractDatabase.h: Added.
11:39 PM Changeset in webkit [59348] by eric@webkit.org
  • 3 edits in trunk/WebKit/chromium

2010-05-12 Hans Wennborg <​hans@chromium.org>

Reviewed by Jeremy Orlow.

[Chromium] Remove transitional functions from WebStorageNamespace and WebViewClient.
​https://bugs.webkit.org/show_bug.cgi?id=38985

These functions are no longer called as of Chromium revision 47020.
This is part of resolving ​http://crbug.com/42740

  • public/WebStorageNamespace.h:
  • public/WebViewClient.h: (WebKit::WebViewClient::createSessionStorageNamespace):
11:27 PM Changeset in webkit [59347] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-05-12 Noam Rosenthal <​noam.rosenthal@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] GraphicsLayer: depth-test causes flicker in certain situations

This patch removes the simplistic 2D depth test as it leads to flickering side effects.
​https://bugs.webkit.org/show_bug.cgi?id=38370

Tested by ​http://webkit.org/blog-files/3d-transforms/morphing-cubes.html

  • platform/graphics/qt/GraphicsLayerQt.cpp: (WebCore::GraphicsLayerQtImpl::updateTransform):
11:20 PM Changeset in webkit [59346] by tony@chromium.org
  • 2 edits in trunk/WebKit/chromium

2010-05-12 Tony Chang <​tony@chromium.org>

Reviewed by Kent Tamura.

[chromium] disable DRT in chromium again
​https://bugs.webkit.org/show_bug.cgi?id=39049

  • WebKit.gyp:
10:40 PM Changeset in webkit [59345] by eric@webkit.org
  • 2 edits in trunk/LayoutTests

2010-05-12 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r59272.
​http://trac.webkit.org/changeset/59272
​https://bugs.webkit.org/show_bug.cgi?id=39047

Original change (59270) was rolled out (Requested by smfr on
#webkit).

  • platform/qt/editing/deleting/5408255-expected.txt:
10:39 PM Changeset in webkit [59344] by Chris Jerdonek
  • 3 edits
    1 add in trunk/WebKitTools

Fixed a bug in svn-apply whereby the reviewer would not get set if
the portion of the patch for the ChangeLog contains "NOBODY (PS!)"
in the leading junk.

Reviewed by Daniel Bates.

​https://bugs.webkit.org/show_bug.cgi?id=38998

  • Scripts/VCSUtils.pm:
    • Added the $changeLogTimeZone variable from svn-apply.
    • Added setChangeLogDateAndReviewer() from svn-apply.
    • Added a localTimeInProjectTimeZone() subroutine.
    • In setChangeLogDateAndReviewer():
      • Added an $epochTime parameter to make the subroutine more testable.
      • Made the "NOBODY (PS!)" regular expression more specific so that it will not apply to text in the leading junk.
      • Updated to call localTimeInProjectTimeZone().
  • Scripts/svn-apply:
    • Removed the $changeLogTimeZone file variable.
    • Added an $epochTime file variable to represent the current time.
    • Removed the setChangeLogDateAndReviewer() subroutine.
    • Updated patch() to use the new setChangeLogDateAndReviewer() syntax.
  • Scripts/webkitperl/VCSUtils_unittest/setChangeLogDateAndReviewer.pl: Added.
    • Added unit tests.
10:38 PM Changeset in webkit [59343] by eric@webkit.org
  • 2 edits in trunk/LayoutTests

2010-05-12 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r59276.
​http://trac.webkit.org/changeset/59276
​https://bugs.webkit.org/show_bug.cgi?id=39046

Original change (59270) was rolled out (Requested by smfr on
#webkit).

  • platform/gtk/editing/deleting/delete-select-all-001-expected.txt:
10:28 PM Changeset in webkit [59342] by Simon Fraser
  • 13 edits
    5 deletes in trunk

2010-05-12 Simon Fraser <Simon Fraser>

Reviewed by Mark Rowe.

Fix layer dump to avoid spurious platform differences
​https://bugs.webkit.org/show_bug.cgi?id=39045

Only dump the children transform on layers that are not the root layer.
The children transform on the root layer is used on Leopard to implement
geometry flipping, so avoid this supurious difference in test output.

  • platform/graphics/GraphicsLayer.cpp: (WebCore::GraphicsLayer::dumpProperties):
9:45 PM Changeset in webkit [59341] by Simon Fraser
  • 9 edits
    2 deletes in trunk

2010-05-12 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r59270.
​http://trac.webkit.org/changeset/59270
​https://bugs.webkit.org/show_bug.cgi?id=39044

Caused a crash on some pages - bug 39042 (Requested by smfr on
#webkit).

  • editing/deleting/delete-block-contents-004-expected.txt: Removed.
  • editing/deleting/delete-block-contents-004.html: Removed.
  • editing/deleting/in-visibly-empty-root-expected.txt:
  • platform/mac/editing/deleting/5408255-expected.txt:
  • platform/mac/editing/deleting/delete-select-all-001-expected.txt:
  • platform/mac/editing/selection/4895428-1-expected.txt:
  • platform/mac/editing/selection/4895428-4-expected.txt:
  • platform/mac/fast/events/mouseout-dead-node-expected.txt:

2010-05-12 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r59270.
​http://trac.webkit.org/changeset/59270
​https://bugs.webkit.org/show_bug.cgi?id=39044

Caused a crash on some pages - bug 39042 (Requested by smfr on
#webkit).

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::removeChild):
9:12 PM Changeset in webkit [59340] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2010-05-12 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

test-webkitpy fails on windows due to lack of readline module
​https://bugs.webkit.org/show_bug.cgi?id=38884

Win32 Python does not have a readline module, so we should
not exit(1) if the import fails.

Also the failure message is mac-specific and doesn't need to be.
Only print the mac-specific install instructions on mac.

  • Scripts/webkitpy/common/system/user.py:
9:01 PM Changeset in webkit [59339] by barraclough@apple.com
  • 22 edits in trunk/JavaScriptCore

​https://bugs.webkit.org/show_bug.cgi?id=39039
Provide support for separate bytecode/JIT code translations for call/construct usage
This will allow us to produce code generated specifically for use as a constructor, not for general function use.

Reviewed by Oliver Hunt.

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::CodeBlock):
(JSC::CodeBlock::unlinkCallers):

  • bytecode/CodeBlock.h:

(JSC::CodeBlock::getBytecodeIndex):
(JSC::CodeBlock::getJITCode):
(JSC::CodeBlock::executablePool):
(JSC::GlobalCodeBlock::GlobalCodeBlock):
(JSC::FunctionCodeBlock::FunctionCodeBlock):

  • interpreter/Interpreter.cpp:

(JSC::Interpreter::executeCall):
(JSC::Interpreter::executeConstruct):
(JSC::Interpreter::prepareForRepeatCall):
(JSC::Interpreter::execute):
(JSC::Interpreter::privateExecute):

  • interpreter/Interpreter.h:
  • jit/JIT.cpp:

(JSC::JIT::unlinkCallOrConstruct):
(JSC::JIT::linkConstruct):

  • jit/JIT.h:
  • jit/JITCall.cpp:

(JSC::JIT::compileOpCall):
(JSC::JIT::compileOpCallSlowCase):

  • jit/JITOpcodes.cpp:

(JSC::JIT::privateCompileCTIMachineTrampolines):

  • jit/JITOpcodes32_64.cpp:

(JSC::JIT::privateCompileCTIMachineTrampolines):

  • jit/JITPropertyAccess.cpp:

(JSC::JIT::emitSlow_op_get_by_val):

  • jit/JITPropertyAccess32_64.cpp:

(JSC::JIT::emitSlow_op_get_by_val):

  • jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):

  • jit/JITStubs.h:

(JSC::JITThunks::ctiVirtualConstructLink):
(JSC::JITThunks::ctiVirtualConstruct):
(JSC::):

  • jit/SpecializedThunkJIT.h:

(JSC::SpecializedThunkJIT::finalize):

  • runtime/Arguments.h:

(JSC::JSActivation::copyRegisters):

  • runtime/ArrayPrototype.cpp:

(JSC::isNumericCompareFunction):

  • runtime/Executable.cpp:

(JSC::FunctionExecutable::~FunctionExecutable):
(JSC::FunctionExecutable::compileForCall):
(JSC::FunctionExecutable::compileForConstruct):
(JSC::EvalExecutable::generateJITCode):
(JSC::ProgramExecutable::generateJITCode):
(JSC::FunctionExecutable::generateJITCodeForCall):
(JSC::FunctionExecutable::generateJITCodeForConstruct):
(JSC::FunctionExecutable::markAggregate):
(JSC::FunctionExecutable::reparseExceptionInfo):
(JSC::EvalExecutable::reparseExceptionInfo):
(JSC::FunctionExecutable::recompile):

  • runtime/Executable.h:

(JSC::ExecutableBase::ExecutableBase):
(JSC::ExecutableBase::isHostFunction):
(JSC::ExecutableBase::generatedJITCodeForCall):
(JSC::ExecutableBase::generatedJITCodeForConstruct):
(JSC::NativeExecutable::NativeExecutable):
(JSC::EvalExecutable::jitCode):
(JSC::ProgramExecutable::jitCode):
(JSC::FunctionExecutable::bytecodeForCall):
(JSC::FunctionExecutable::isGeneratedForCall):
(JSC::FunctionExecutable::generatedBytecodeForCall):
(JSC::FunctionExecutable::bytecodeForConstruct):
(JSC::FunctionExecutable::isGeneratedForConstruct):
(JSC::FunctionExecutable::generatedBytecodeForConstruct):
(JSC::FunctionExecutable::symbolTable):
(JSC::FunctionExecutable::FunctionExecutable):
(JSC::FunctionExecutable::jitCodeForCall):
(JSC::FunctionExecutable::jitCodeForConstruct):

  • runtime/JSActivation.h:

(JSC::JSActivation::JSActivationData::JSActivationData):

  • runtime/JSFunction.cpp:

(JSC::JSFunction::~JSFunction):
(JSC::JSFunction::call):
(JSC::JSFunction::construct):

  • runtime/JSGlobalData.cpp:

(JSC::JSGlobalData::numericCompareFunction):

8:27 PM Changeset in webkit [59338] by Simon Fraser
  • 10 edits
    4 adds in trunk

2010-05-12 Simon Fraser <Simon Fraser>

Reviewed by David Hyatt.

Composited plug-ins can cause missed painting
​https://bugs.webkit.org/show_bug.cgi?id=39033
<rdar://problem/7972478>

Fixed missed painting (and assertions in debug builds) related to compositing
propagating out of iframes that contain plug-ins.

When an iframe enters or leaves compositing mode, RenderLayerCompositor uses
setNeedsStyleRecalc(SyntheticStyleChange) to trigger the parent document to re-evaluate
whether the iframe itself should be composited. However, for iframes containing plug-ins,
this can happen at inappropriate times. For example, when a browser tab is brought frontmost,
plug-ins are instantiated for the first time (via -viewDidMoveToWindow), which triggers a
setNeedsStyleRecalc() on the object element. Soon after, the -viewWillDraw machinery
does layout from the top down. During layout of the iframe, the iframe enters compositing mode,
and does a setNeedsStyleRecalc() on the iframe element in its parent document. This leaves the
FrameView as needsLayout(), so the FrameView::paintContents() asserts and bails.

The fix is to avoid doing a setNeedsStyleRecalc() on the root while inside a recalcStyle on
the iframe. We do this by switching the iframe into compositing mode eagerly as soon as we know
the plug-in needs it.

A secondary fix is to ensure that if a document has composited iframes, when that document becomes
composited, we connect compositing layers between the iframes and the parent document.

Tests: compositing/iframes/connect-compositing-iframe-delayed.html

compositing/iframes/iframe-src-change.html

  • WebCore.base.exp: Export FrameView::enterCompositingMode()
  • page/FrameView.h: New method, enterCompositingMode(), that we can call from WebKit plug-in code.
  • page/FrameView.cpp: (WebCore::FrameView::enterCompositingMode):
  • rendering/RenderLayerCompositor.h:
  • rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::enableCompositingMode): When we switch into compositing mode, we

force a style recaclc on any iframes to get them into compositing layers, so they can hook up
with their content layers if necessary.

(WebCore::RenderLayerCompositor::didMoveOnscreen): Only call attachRootPlatformLayer() if we really need to.
(WebCore::RenderLayerCompositor::willMoveOffscreen): Only call detachRootPlatformLayer() if we really need to.
(WebCore::RenderLayerCompositor::detachRootPlatformLayer): Whitespace.
(WebCore::RenderLayerCompositor::notifyIFramesOfCompositingChange): Fetch iframe elements, and send a

synthetic style recalc on them.

8:20 PM Changeset in webkit [59337] by oliver@apple.com
  • 2 edits in trunk/JavaScriptCore

Build fix

<rdar://problem/7977960> REGRESSION (r59282): Tiger PPC build broken

8:12 PM Changeset in webkit [59336] by oliver@apple.com
  • 7 edits in trunk

2010-05-12 Oliver Hunt <​oliver@apple.com>

Reviewed by Gavin Barraclough.

<rdar://7969718> Incorrect 32-bit codegen for op_jnlesseq
​https://bugs.webkit.org/show_bug.cgi?id=39038

Correct the use of incorrect comparison operators.

  • jit/JITArithmetic32_64.cpp: (JSC::JIT::emit_op_jlesseq): (JSC::JIT::emitBinaryDoubleOp):

2010-05-12 Oliver Hunt <​oliver@apple.com>

Reviewed by Gavin Barraclough.

<rdar://7969718> Incorrect 32-bit codegen for op_jnlesseq
​https://bugs.webkit.org/show_bug.cgi?id=39038

Add more tests for <=, <, >, and >=.

  • fast/js/comparison-operators-greater-expected.txt:
  • fast/js/comparison-operators-less-expected.txt:
  • fast/js/script-tests/comparison-operators-greater.js:
  • fast/js/script-tests/comparison-operators-less.js:
7:37 PM Changeset in webkit [59335] by eric@webkit.org
  • 2 edits in trunk/WebKit/qt

2010-05-12 Joe Ligman <​joseph.ligman@nokia.com>

Reviewed by Laszlo Gombos.

[Qt] Nested overflow div does not scroll
​https://bugs.webkit.org/show_bug.cgi?id=38641

Modify qtwebkit_webframe_scrollOverflow, if the current node's render layer
does not scroll it will try and scroll the parent's render layer. Also export
qtwebkit_webframe_scrollOverflow so we can use it independently of
qtwebkit_webframe_scrollRecursively

  • Api/qwebframe.cpp: (qtwebkit_webframe_scrollOverflow): (qtwebkit_webframe_scrollRecursively):
7:25 PM Changeset in webkit [59334] by eric@webkit.org
  • 3 edits in trunk/JavaScriptCore

2010-05-12 Caio Marcelo de Oliveira Filho <​caio.oliveira@openbossa.org>

Reviewed by Eric Seidel.

JavaScriptCore: fix build when some optimizations are disabled
​https://bugs.webkit.org/show_bug.cgi?id=38800

Remove outdated UNUSED_PARAMs when using JIT but with
ENABLE_JIT_OPTIMIZE_CALL and ENABLE_JIT_OPTIMIZE_PROPERTY_ACCESS
disabled.

  • jit/JITOpcodes.cpp:
  • jit/JITOpcodes32_64.cpp:
6:26 PM Changeset in webkit [59333] by tkent@chromium.org
  • 2 edits in trunk/WebKitTools

2010-05-12 Kent Tamura <​tkent@chromium.org>

Reviewed by Nate Chapin.

[DRT/Chromium] Add a missing Sans-serif font setting
​https://bugs.webkit.org/show_bug.cgi?id=38981

  • DumpRenderTree/chromium/TestShell.cpp: (TestShell::resetWebSettings): Set "Helvetica" for Sans-serif. It is the same as the default setting of test_shell.
5:46 PM Changeset in webkit [59332] by jam@chromium.org
  • 2 edits in trunk/WebKit/chromium

2010-05-12 John Abd-El-Malek <​jam@chromium.org>

Reviewed by Darin Fisher.

[chromium] Disable WebScrollbarImpl's scrollbar if it's not needed
​https://bugs.webkit.org/show_bug.cgi?id=39025

  • src/WebScrollbarImpl.cpp: (WebKit::WebScrollbarImpl::setLocation): (WebKit::WebScrollbarImpl::setDocumentSize):
5:41 PM Changeset in webkit [59331] by mrowe@apple.com
  • 5 edits in trunk

Versioning.

5:34 PM Changeset in webkit [59330] by andersca@apple.com
  • 3 edits in trunk/WebCore

2010-05-12 Anders Carlsson <​andersca@apple.com>

Reviewed by Simon Fraser.

Shrink the size of FillLayer by moving a member variable.
​https://bugs.webkit.org/show_bug.cgi?id=39035

  • rendering/style/FillLayer.cpp: (WebCore::FillLayer::FillLayer):
  • rendering/style/FillLayer.h:
5:32 PM Changeset in webkit [59329] by mrowe@apple.com
  • 2 edits in branches/safari-533-branch/WebCore

Merge r59192.

5:32 PM Changeset in webkit [59328] by mrowe@apple.com
  • 2 edits in branches/safari-533-branch/WebCore

Merge r59190.

5:32 PM WebKit Team edited by morrita@google.com
(diff)
5:32 PM Changeset in webkit [59327] by mrowe@apple.com
  • 8 edits in branches/safari-533-branch/WebKit/win

Merge r59175.

5:32 PM Changeset in webkit [59326] by mrowe@apple.com
  • 11 edits in branches/safari-533-branch

Merge r59173.

5:31 PM Changeset in webkit [59325] by mrowe@apple.com
  • 4 edits in branches/safari-533-branch/WebCore

Merge r59155.

5:31 PM Changeset in webkit [59324] by mrowe@apple.com
  • 3 edits in branches/safari-533-branch/WebKit/mac

Merge r59125.

5:31 PM Changeset in webkit [59323] by mrowe@apple.com
  • 5 edits
    2 adds in branches/safari-533-branch

Merge r59109.

5:31 PM Changeset in webkit [59322] by mrowe@apple.com
  • 7 edits
    3 adds in branches/safari-533-branch

Merge r59100.

5:31 PM Changeset in webkit [59321] by mrowe@apple.com
  • 7 edits
    2 adds in branches/safari-533-branch

Merge r59098.

5:31 PM Changeset in webkit [59320] by mrowe@apple.com
  • 1 edit in branches/safari-533-branch/JavaScriptCore/jit/JITOpcodes.cpp

Merge r59065.

5:31 PM Changeset in webkit [59319] by mrowe@apple.com
  • 14 edits
    2 moves
    1 add
    1 delete in branches/safari-533-branch

Merge r59064.

5:30 PM Changeset in webkit [59318] by mrowe@apple.com
  • 5 edits in branches/safari-533-branch/WebCore

Merge r59058.

5:30 PM Changeset in webkit [59317] by mrowe@apple.com
  • 2 edits in branches/safari-533-branch/WebCore

Merge r59009.

5:30 PM Changeset in webkit [59316] by mrowe@apple.com
  • 2 edits in branches/safari-533-branch/WebCore/platform/graphics/win

Merge r59008.

5:30 PM Changeset in webkit [59315] by mrowe@apple.com
  • 1 edit in branches/safari-533-branch/WebCore/platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.h

Merge r59007.

5:30 PM Changeset in webkit [59314] by mrowe@apple.com
  • 1 edit in branches/safari-533-branch/WebCore/platform/graphics/win/QTMovieVisualContext.cpp

Merge r59003.

5:30 PM Changeset in webkit [59313] by mrowe@apple.com
  • 14 edits
    3 copies
    2 moves
    11 adds in branches/safari-533-branch

Merge r59001.

5:30 PM Changeset in webkit [59312] by mrowe@apple.com
  • 2 edits in branches/safari-533-branch/WebCore

Merge r58983.

5:30 PM Changeset in webkit [59311] by mrowe@apple.com
  • 4 edits
    1 add in branches/safari-533-branch/WebCore

Merge r58950.

5:29 PM Changeset in webkit [59310] by mrowe@apple.com
  • 3 edits
    3 adds in branches/safari-533-branch

Merge r58936.

5:29 PM Changeset in webkit [59309] by mrowe@apple.com
  • 4 edits
    5 adds in branches/safari-533-branch

Merge r59147.

5:29 PM Changeset in webkit [59308] by mrowe@apple.com
  • 9 edits in branches/safari-533-branch/WebCore

Merge r59116.

5:29 PM Changeset in webkit [59307] by mrowe@apple.com
  • 4 edits
    2 adds in branches/safari-533-branch

Merge r59111.

5:29 PM Changeset in webkit [59306] by mrowe@apple.com
  • 2 edits in branches/safari-533-branch/WebKit/mac

Merge r59093.

5:29 PM Changeset in webkit [59305] by mrowe@apple.com
  • 2 edits in branches/safari-533-branch/WebKit/mac

Merge r59086.

5:29 PM Changeset in webkit [59304] by mrowe@apple.com
  • 8 edits in branches/safari-533-branch/WebKit/mac

Merge r58982.

5:29 PM Changeset in webkit [59303] by mrowe@apple.com
  • 10 edits in branches/safari-533-branch

Merge r58965.

5:29 PM Changeset in webkit [59302] by mrowe@apple.com
  • 3 edits
    4 adds in branches/safari-533-branch

Merge r58961.

5:28 PM Changeset in webkit [59301] by mrowe@apple.com
  • 9 edits in branches/safari-533-branch

Merge r58960.

5:28 PM Changeset in webkit [59300] by mrowe@apple.com
  • 2 edits in branches/safari-533-branch/JavaScriptCore

Merge r59170.

5:28 PM Changeset in webkit [59299] by mrowe@apple.com
  • 7 edits in branches/safari-533-branch/JavaScriptCore

Merge r59161.

5:28 PM Changeset in webkit [59298] by mrowe@apple.com
  • 2 edits in branches/safari-533-branch/JavaScriptCore

Merge r59061.

5:28 PM Changeset in webkit [59297] by mrowe@apple.com
  • 7 edits in branches/safari-533-branch/JavaScriptCore

Merge r59056.

5:28 PM Changeset in webkit [59296] by mrowe@apple.com
  • 3 edits in branches/safari-533-branch/JavaScriptCore

Merge r59055.

5:28 PM Changeset in webkit [59295] by mrowe@apple.com
  • 7 edits
    1 add in branches/safari-533-branch/JavaScriptCore

Merge r59040.

5:28 PM Changeset in webkit [59294] by mrowe@apple.com
  • 3 edits
    3 adds in branches/safari-533-branch

Merge r58993.

5:28 PM Changeset in webkit [59293] by mrowe@apple.com
  • 2 edits in branches/safari-533-branch/JavaScriptCore

Merge r58991.

5:27 PM Changeset in webkit [59292] by mrowe@apple.com
  • 2 edits in branches/safari-533-branch/JavaScriptCore

Merge r58988.

5:27 PM Changeset in webkit [59291] by mrowe@apple.com
  • 2 edits in branches/safari-533-branch/JavaScriptCore

Merge r58987.

5:27 PM Changeset in webkit [59290] by mrowe@apple.com
  • 20 edits in branches/safari-533-branch/JavaScriptCore

Merge r58986.

5:27 PM Changeset in webkit [59289] by mrowe@apple.com
  • 2 edits in branches/safari-533-branch/JavaScriptCore

Merge r58974.

5:27 PM Changeset in webkit [59288] by mrowe@apple.com
  • 2 edits in branches/safari-533-branch/JavaScriptCore

Merge r58970.

5:27 PM Changeset in webkit [59287] by mrowe@apple.com
  • 2 edits in branches/safari-533-branch/JavaScriptCore

Merge r58964.

5:27 PM Changeset in webkit [59286] by mrowe@apple.com
  • 5 edits
    1 add in branches/safari-533-branch/JavaScriptCore

Merge r58935.

5:19 PM Changeset in webkit [59285] by mrowe@apple.com
  • 1 copy in branches/safari-533-branch

New branch.

4:55 PM Changeset in webkit [59284] by ojan@chromium.org
  • 5 edits in trunk/WebKitTools

2010-05-10 Ojan Vafai <​ojan@chromium.org>

Reviewed by Adam Barth.

webkit-patch upload --fancy-review now uses the bugzilla bug ID as the rietveld ID
​https://bugs.webkit.org/show_bug.cgi?id=38866

wkrietveld.appspot.com has already been updated to allow you to
pass --issue for the issue creation as well as subsequent uploads.

Also, remove the extra code for trying to read out the issue ID
from the changelog description since we just use the bugzilla ID now.

  • Scripts/webkitpy/common/config/init.py:
  • Scripts/webkitpy/common/net/rietveld.py:
  • Scripts/webkitpy/tool/steps/postcodereview.py:
  • Scripts/webkitpy/tool/steps/postdiff.py:
4:43 PM WebKit Team edited by ojan@chromium.org
(diff)
4:34 PM Changeset in webkit [59283] by ojan@chromium.org
  • 2 edits in trunk/WebKitTools

2010-05-12 Ojan Vafai <​ojan@chromium.org>

No review needed.

Marking myself as a reviewer.

  • Scripts/webkitpy/common/config/committers.py:
4:25 PM Changeset in webkit [59282] by oliver@apple.com
  • 5 edits in trunk/JavaScriptCore

Work around GCC stupidity by either explicitly inlining or by
using ALWAYS_INLINE

Reviewed by Gaving Barraclough.

  • runtime/StringPrototype.cpp:

(JSC::stringProtoFuncReplace):

  • runtime/UString.h:

(JSC::UString::~UString):

  • wtf/RefPtr.h:

(WTF::RefPtr::RefPtr):
(WTF::RefPtr::~RefPtr):

  • wtf/text/StringImpl.h:

(WebCore::StringImpl::create):
(WebCore::StringImpl::tryCreateUninitialized):

4:21 PM Changeset in webkit [59281] by weinig@apple.com
  • 13 edits in trunk/WebCore

A bunch of nice micro-optimizations for ~1% speedup on PLT.

  • Add fastGetAttribute. The same as getAttribute except can only be called when it is known not to be style attribute or one of the SVG animatable attributes.
  • Inline some functions from Font.
  • Return the same string from deprecatedParseURL if there is nothing to strip.
  • Use a member variable instead of a virtual function to determine whether a ScheduledNavigation is a location change.

Reviewed by Anders Carlsson.

  • WebCore.base.exp:
  • css/CSSHelper.cpp:

(WebCore::deprecatedParseURL):

  • css/CSSStyleSelector.cpp:

(WebCore::linkAttribute):
(WebCore::CSSStyleSelector::canShareStyleWithElement):
(WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector):

  • dom/Element.cpp:

(WebCore::Element::getAttribute):

  • dom/Element.h:

(WebCore::Element::fastHasAttribute):
(WebCore::Element::fastGetAttribute):

  • html/HTMLFormControlElement.cpp:

(WebCore::HTMLFormControlElement::formControlName):

  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::value):

  • loader/RedirectScheduler.cpp:

(WebCore::ScheduledNavigation::ScheduledNavigation):
(WebCore::ScheduledNavigation::isLocationChange):
(WebCore::ScheduledURLNavigation::ScheduledURLNavigation):
(WebCore::ScheduledRedirect::ScheduledRedirect):
(WebCore::ScheduledLocationChange::ScheduledLocationChange):
(WebCore::ScheduledRefresh::ScheduledRefresh):
(WebCore::ScheduledHistoryNavigation::ScheduledHistoryNavigation):
(WebCore::ScheduledFormSubmission::ScheduledFormSubmission):
(WebCore::RedirectScheduler::locationChangePending):

  • platform/graphics/Font.cpp:
  • platform/graphics/Font.h:

(WebCore::Font::~Font):
(WebCore::Font::primaryFont):
(WebCore::Font::fontDataAt):
(WebCore::Font::fontDataForCharacters):
(WebCore::Font::isFixedPitch):
(WebCore::Font::fontSelector):

  • platform/graphics/FontFallbackList.h:
  • rendering/RenderImage.cpp:

(WebCore::RenderImage::imageMap):

3:48 PM Changeset in webkit [59280] by dpranke@chromium.org
  • 2 edits in trunk/LayoutTests

2010-05-12 Dirk Pranke <​dpranke@chromium.org>

Unreviewed, build fix.

Change expectation from IMAGE to IMAGE+TEXT for Chromium Linux; I'm
not sure if this is flaky or not but it seems to be consistent on the
bot.

  • platform/chromium/test_expectations.txt:
3:36 PM Changeset in webkit [59279] by dpranke@chromium.org
  • 3 edits in trunk/WebKitTools

2010-05-12 Dirk Pranke <​dpranke@chromium.org>

Reviewed by Eric Seidel.

new-run-webkit-tests: add a --print default option so that you can
easily get the default output plus something (e.g., you can say
'--print default,config' instead of '--print misc,one-line-progress,
one-line-summary,unexpected,unexpected-results,updates,config'.

Also, add more unit tests for --verbose, --print everything, etc.

​https://bugs.webkit.org/show_bug.cgi?id=38877

  • Scripts/webkitpy/layout_tests/layout_package/printing.py:
  • Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
3:35 PM Changeset in webkit [59278] by dpranke@chromium.org
  • 8 edits
    2 adds in trunk/LayoutTests

2010-05-12 Dirk Pranke <​dpranke@chromium.org>

Reviewed by Nate Chapin.

Expectations fix and new chromium baselines resulting from the
input type=search change in r58313.

​https://bugs.webkit.org/show_bug.cgi?id=38965

  • platform/chromium-linux/fast/forms/placeholder-pseudo-style-expected.checksum:
  • platform/chromium-linux/fast/forms/placeholder-pseudo-style-expected.png:
  • platform/chromium-linux/fast/forms/search-vertical-alignment-expected.checksum:
  • platform/chromium-linux/fast/forms/search-vertical-alignment-expected.png: Added.
  • platform/chromium-win/fast/forms/search-vertical-alignment-expected.checksum:
  • platform/chromium-win/fast/forms/search-vertical-alignment-expected.png: Added.
  • platform/chromium/test_expectations.txt:
  • platform/mac/fast/forms/search-zoomed-expected.checksum:
  • platform/mac/fast/forms/search-zoomed-expected.png:
3:33 PM Changeset in webkit [59277] by jianli@chromium.org
  • 15 edits
    3 adds in trunk/LayoutTests

Unreviewed. Chromium: rebaseline layout tests.

  • platform/chromium-linux/editing/deleting/5408255-expected.checksum:
  • platform/chromium-linux/editing/deleting/5408255-expected.png:
  • platform/chromium-linux/fast/css/pseudo-cache-stale-expected.checksum:
  • platform/chromium-linux/fast/css/pseudo-cache-stale-expected.png:
  • platform/chromium-mac/editing/deleting/5408255-expected.checksum: Added.
  • platform/chromium-mac/editing/deleting/5408255-expected.png: Added.
  • platform/chromium-mac/fast/css/pseudo-cache-stale-expected.checksum: Added.
  • platform/chromium-win/editing/deleting/5408255-expected.checksum:
  • platform/chromium-win/editing/deleting/5408255-expected.png:
  • platform/chromium-win/editing/deleting/5408255-expected.txt:
  • platform/chromium-win/editing/deleting/delete-select-all-001-expected.txt:
  • platform/chromium-win/editing/selection/4895428-1-expected.txt:
  • platform/chromium-win/editing/selection/4895428-4-expected.txt:
  • platform/chromium-win/fast/css/pseudo-cache-stale-expected.checksum:
  • platform/chromium-win/fast/css/pseudo-cache-stale-expected.png:
  • platform/chromium-win/fast/css/pseudo-cache-stale-expected.txt:
  • platform/chromium-win/fast/events/mouseout-dead-node-expected.txt:
3:31 PM Changeset in webkit [59276] by Martin Robinson
  • 2 edits in trunk/LayoutTests

2010-05-12 Martin Robinson <​mrobinson@igalia.com>

No review. Updating the baseline for this test after r59270.

  • platform/gtk/editing/deleting/delete-select-all-001-expected.txt:
3:10 PM Changeset in webkit [59275] by Csaba Osztrogonác
  • 3 edits in trunk/WebKitTools

Qt build failures cause SheriffBot false positives
​https://bugs.webkit.org/show_bug.cgi?id=38969

Reviewed by Adam Barth.

Add Qt bots back to the core builders, because bug fixed by r59261.

  • Scripts/webkitpy/common/net/buildbot.py:
  • Scripts/webkitpy/common/net/buildbot_unittest.py:
3:07 PM Changeset in webkit [59274] by hyatt@apple.com
  • 23 edits
    1 delete in trunk/WebCore

Make InlineBoxes use an IntRect for dimensions, and eliminate the dynamic computation of height() every time.

Reviewed by Sam Weinig.

  • WebCore.xcodeproj/project.pbxproj:
  • editing/visible_units.cpp:

(WebCore::previousLinePosition):
(WebCore::nextLinePosition):

  • rendering/EllipsisBox.cpp:

(WebCore::EllipsisBox::paint):
(WebCore::EllipsisBox::selectionRect):
(WebCore::EllipsisBox::paintSelection):
(WebCore::EllipsisBox::nodeAtPoint):

  • rendering/EllipsisBox.h:

(WebCore::EllipsisBox::EllipsisBox):

  • rendering/InlineBox.cpp:

(WebCore::InlineBox::adjustPosition):
(WebCore::InlineBox::canAccommodateEllipsis):

  • rendering/InlineBox.h:

(WebCore::InlineBox::InlineBox):
(WebCore::InlineBox::isSVGRootInlineBox):
(WebCore::InlineBox::x):
(WebCore::InlineBox::y):
(WebCore::InlineBox::width):
(WebCore::InlineBox::height):
(WebCore::InlineBox::bottom):
(WebCore::InlineBox::right):
(WebCore::InlineBox::setX):
(WebCore::InlineBox::setY):
(WebCore::InlineBox::setWidth):
(WebCore::InlineBox::setHeight):
(WebCore::InlineBox::location):
(WebCore::InlineBox::size):
(WebCore::InlineBox::setLocation):
(WebCore::InlineBox::setSize):
(WebCore::InlineBox::move):
(WebCore::InlineBox::frameRect):
(WebCore::InlineBox::setFrameRect):
(WebCore::InlineBox::baselinePosition):
(WebCore::InlineBox::lineHeight):

  • rendering/InlineFlowBox.cpp:

(WebCore::InlineFlowBox::placeBoxesVertically):
(WebCore::InlineFlowBox::computeVerticalOverflow):
(WebCore::InlineFlowBox::nodeAtPoint):
(WebCore::InlineFlowBox::paintBoxDecorations):
(WebCore::InlineFlowBox::paintMask):
(WebCore::InlineFlowBox::paintTextDecorations):

  • rendering/InlineFlowBox.h:

(WebCore::InlineFlowBox::visibleOverflowRect):
(WebCore::InlineFlowBox::topLayoutOverflow):
(WebCore::InlineFlowBox::bottomLayoutOverflow):
(WebCore::InlineFlowBox::leftLayoutOverflow):
(WebCore::InlineFlowBox::rightLayoutOverflow):
(WebCore::InlineFlowBox::layoutOverflowRect):
(WebCore::InlineFlowBox::topVisualOverflow):
(WebCore::InlineFlowBox::bottomVisualOverflow):
(WebCore::InlineFlowBox::leftVisualOverflow):
(WebCore::InlineFlowBox::rightVisualOverflow):
(WebCore::InlineFlowBox::visualOverflowRect):
(WebCore::InlineFlowBox::setHorizontalOverflowPositions):
(WebCore::InlineFlowBox::setVerticalOverflowPositions):

  • rendering/InlineTextBox.cpp:

(WebCore::InlineTextBox::selectionRect):
(WebCore::InlineTextBox::placeEllipsisBox):
(WebCore::InlineTextBox::nodeAtPoint):
(WebCore::InlineTextBox::paint):
(WebCore::InlineTextBox::paintSelection):
(WebCore::InlineTextBox::paintCompositionBackground):
(WebCore::InlineTextBox::paintDecoration):
(WebCore::InlineTextBox::paintSpellingOrGrammarMarker):
(WebCore::InlineTextBox::paintTextMatchMarker):
(WebCore::InlineTextBox::computeRectForReplacementMarker):
(WebCore::InlineTextBox::paintCompositionUnderline):
(WebCore::InlineTextBox::offsetForPosition):
(WebCore::InlineTextBox::positionForOffset):

  • rendering/InlineTextBox.h:

(WebCore::InlineTextBox::setSpaceAdd):

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::positionForPointWithInlineChildren):

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::computeVerticalPositionsForLine):
(WebCore::RenderBlock::layoutInlineChildren):

  • rendering/RenderSVGInline.cpp:

(WebCore::RenderSVGInline::createInlineFlowBox):

  • rendering/RenderSVGInlineText.cpp:

(WebCore::RenderSVGInlineText::createTextBox):

  • rendering/RenderSVGText.cpp:

(WebCore::RenderSVGText::createRootInlineBox):

  • rendering/RenderText.cpp:

(WebCore::RenderText::positionForPoint):
(WebCore::RenderText::firstRunX):
(WebCore::RenderText::firstRunY):

  • rendering/RenderTreeAsText.cpp:

(WebCore::writeTextRun):

  • rendering/RootInlineBox.cpp:

(WebCore::RootInlineBox::placeEllipsis):
(WebCore::RootInlineBox::addHighlightOverflow):
(WebCore::RootInlineBox::closestLeafChildForXPos):

  • rendering/SVGInlineFlowBox.h:

(WebCore::SVGInlineFlowBox::SVGInlineFlowBox):

  • rendering/SVGInlineTextBox.h:

(WebCore::SVGInlineTextBox::selectionTop):
(WebCore::SVGInlineTextBox::selectionHeight):

  • rendering/SVGRootInlineBox.h:

(WebCore::SVGRootInlineBox::SVGRootInlineBox):
(WebCore::SVGRootInlineBox::isSVGRootInlineBox):

  • rendering/TrailingFloatsRootInlineBox.h: Removed.
2:52 PM Changeset in webkit [59273] by dumi@chromium.org
  • 6 edits in trunk

Removing the unnecessary dirfd parameter.
​https://bugs.webkit.org/show_bug.cgi?id=38869

Reviewed by Dimitri Glazkov.

WebCore:

  • platform/chromium/ChromiumBridge.h:
  • platform/sql/chromium/SQLiteFileSystemChromiumPosix.cpp:

WebKit/chromium:

  • public/WebKitClient.h:

(WebKit::WebKitClient::databaseOpenFile):

  • src/ChromiumBridge.cpp:

(WebCore::ChromiumBridge::databaseOpenFile):

2:47 PM Changeset in webkit [59272] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

Unreviewed fix after r59270.
Update Qt specific expected result based on IRC discussing with Enrica Casucci.

  • platform/qt/editing/deleting/5408255-expected.txt: updated.
2:34 PM Changeset in webkit [59271] by jparent@chromium.org
  • 2 edits
    1 copy in trunk/BugsSite

Hide the in-rietveld flag in the UI. It is only used only by tooling and shouldn't clutter the UI.
​https://bugs.webkit.org/show_bug.cgi?id=39024

Reviewed by Ojan Vafai.

  • template/en/custom/attachment/list.html.tmpl: Removes this flag entirely from the UI, not needed on this page.
  • template/en/custom/flag/list.html.tmpl: Added. Copied from template/en/default/flag/list.html.tmpl with only changes inside the if WEBKIT_CHANGES section. Hides the flag rather than removing it completely, so tools can still interact with it.
2:24 PM Changeset in webkit [59270] by enrica@apple.com
  • 9 edits
    2 adds in trunk

Adding block elements to a block and removing them changes the height of the element.
​https://bugs.webkit.org/show_bug.cgi?id=38874

Reviewed by Dave Hyatt.

WebCore:

The initial height of an empty editable block is different from the height of the same block after we add block elements
and remove them.

Test: editing/deleting/delete-block-contents-004.html

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::removeChild): m_childrenInline was set to true only when the Renderer is created
and never reset to true when all the block elements contained are removed.

LayoutTests:

  • editing/deleting/delete-block-contents-004-expected.txt: Added.
  • editing/deleting/delete-block-contents-004.html: Added.

The following tests have new results because of the height change and because we now have one less renderer after the DOM changes.

  • editing/deleting/in-visibly-empty-root-expected.txt:
  • platform/mac/editing/deleting/5408255-expected.txt:
  • platform/mac/editing/deleting/delete-select-all-001-expected.txt:
  • platform/mac/editing/selection/4895428-1-expected.txt:
  • platform/mac/editing/selection/4895428-4-expected.txt:
  • platform/mac/fast/events/mouseout-dead-node-expected.txt
2:21 PM Changeset in webkit [59269] by jianli@chromium.org
  • 14 edits
    15 adds in trunk/LayoutTests

Unreviewed. Chromium: rebaseline layout tests and mark one failed layout test.

  • platform/chromium-linux/fast/forms/placeholder-stripped-expected.checksum: Added.
  • platform/chromium-linux/fast/forms/placeholder-stripped-expected.png: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/filters-diffuse-01-f-expected.checksum:
  • platform/chromium-linux/svg/W3C-SVG-1.1/filters-diffuse-01-f-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/filters-light-01-f-expected.checksum:
  • platform/chromium-linux/svg/W3C-SVG-1.1/filters-light-01-f-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/filters-specular-01-f-expected.checksum:
  • platform/chromium-linux/svg/W3C-SVG-1.1/filters-specular-01-f-expected.png:
  • platform/chromium-linux/svg/custom/svg-fonts-with-no-element-reference-expected.checksum: Added.
  • platform/chromium-mac/fast/forms/placeholder-stripped-expected.checksum: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1/filters-diffuse-01-f-expected.checksum: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1/filters-diffuse-01-f-expected.png: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1/filters-light-01-f-expected.checksum: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1/filters-light-01-f-expected.png: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1/filters-specular-01-f-expected.checksum: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1/filters-specular-01-f-expected.png: Added.
  • platform/chromium-win/fast/forms/placeholder-stripped-expected.checksum: Added.
  • platform/chromium-win/fast/forms/placeholder-stripped-expected.png: Added.
  • platform/chromium-win/fast/forms/placeholder-stripped-expected.txt: Added.
  • platform/chromium-win/svg/W3C-SVG-1.1/filters-diffuse-01-f-expected.checksum:
  • platform/chromium-win/svg/W3C-SVG-1.1/filters-diffuse-01-f-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/filters-light-01-f-expected.checksum:
  • platform/chromium-win/svg/W3C-SVG-1.1/filters-light-01-f-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/filters-specular-01-f-expected.checksum:
  • platform/chromium-win/svg/W3C-SVG-1.1/filters-specular-01-f-expected.png:
  • platform/chromium-win/svg/custom/svg-fonts-with-no-element-reference-expected.checksum: Added.
  • platform/chromium-win/svg/custom/svg-fonts-with-no-element-reference-expected.png: Added.
  • platform/chromium/test_expectations.txt:
2:18 PM Changeset in webkit [59268] by agl@chromium.org
  • 2 edits
    8 adds in trunk/LayoutTests

2010-05-12 Adam Langley <​agl@chromium.org>

Expectations change. Unreviewed.

Add baselines for fast/css/font-face-woff.html.

  • platform/chromium-linux/fast/css/font-face-woff-expected.checksum: Added.
  • platform/chromium-linux/fast/css/font-face-woff-expected.png: Added.
  • platform/chromium-mac/fast/css/font-face-woff-expected.checksum: Added.
  • platform/chromium-mac/fast/css/font-face-woff-expected.png: Added.
  • platform/chromium-mac/fast/css/font-face-woff-expected.txt: Added.
  • platform/chromium-win/fast/css/font-face-woff-expected.checksum: Added.
  • platform/chromium-win/fast/css/font-face-woff-expected.png: Added.
  • platform/chromium-win/fast/css/font-face-woff-expected.txt: Added.
2:08 PM Changeset in webkit [59267] by dumi@chromium.org
  • 2 edits in trunk/WebCore

Do not check if a database needs to be vacuumed after a read-only transaction.
​https://bugs.webkit.org/show_bug.cgi?id=38972

Reviewed by Dimitri Glazkov.

  • storage/SQLTransaction.cpp:

(WebCore::SQLTransaction::postflightAndCommit):

2:04 PM Changeset in webkit [59266] by Csaba Osztrogonác
  • 2 edits in trunk

[Qt] Link error in debug mode without debug_and_release config
​https://bugs.webkit.org/show_bug.cgi?id=39006

Reviewed by Kenneth Rohde Christiansen.

  • WebKit.pri: Unnecessary build_pass guard removed.
1:57 PM Changeset in webkit [59265] by jparent@chromium.org
  • 4 edits
    1 add in trunk/BugsSite

Adds support for Rietveld reviews. When there is an associated
Rietveld id for a patch, adds a link to do a Rietveld review instead.

Reviewed by David Kilzer.

​https://bugs.webkit.org/show_bug.cgi?id=38143

  • attachment.cgi:

Added support for handling action=rietveldreview.

  • template/en/custom/attachment/list.html.tmpl:

Adds a link to use rietveld review iff the in_rietveld flag is set.

  • template/en/custom/attachment/reviewform.html.tmpl:

Detects if we are in rietveld review mode due to query string paramter,
and customizes the review form slightly:

  • Changes text describing comment field.
  • Comment field does not include quoted patch.
  • Submit button fetches from Rietveld instead of just submitting.
  • template/en/custom/attachment/rietveldreview.html.tmpl: Added.

New template for rietveldreview mode. Hosts the rietveld frame in the
top and the regular comments form in the bottom.
Uses postMessage to communicate with Rietveld frame.

1:56 PM Changeset in webkit [59264] by Csaba Osztrogonác
  • 9 edits in trunk

[Qt] Detect debug mode consistently
​https://bugs.webkit.org/show_bug.cgi?id=38863

Patch by Laszlo Gombos <Laszlo Gombos> on 2010-05-12
Reviewed by Kenneth Rohde Christiansen.

.:

  • WebKit.pri:

JavaScriptCore:

WebCore:

No new tests as there is no new functionality.

  • WebCore.pro:
1:51 PM Changeset in webkit [59263] by jamesr@google.com
  • 2 edits
    1 add in trunk/WebCore

2010-05-12 James Robinson <​jamesr@chromium.org>

Patch by Dan Bernstein.

Reviewed by David Hyatt.

Fix marking the layout root's parent as needing layout
​https://bugs.webkit.org/show_bug.cgi?id=37760

If an element gets marked as needing layout due to the recalcStyle()
call in FrameView::layout(), the m_layoutSchedulingEnabled flag will
be set to false. It's possible at this point that a parent of the
existing FrameView::m_layoutRoot will be marked as needing layout.

This patch updates FrameView::scheduleRelayoutOfSubtree to account
for this case.

Manual test only due to subtle timing issues.

  • manual-tests/layoutroot_detach.xml: Added.
  • page/FrameView.cpp: (WebCore::FrameView::scheduleRelayoutOfSubtree):
1:50 PM Changeset in webkit [59262] by Martin Robinson
  • 2 edits in trunk/LayoutTests

2010-05-12 Martin Robinson <​mrobinson@igalia.com>

Not reviewed.

[GTK] svg/custom/svg-fonts-with-no-element-reference.html is one pixel different on x86_64
​https://bugs.webkit.org/show_bug.cgi?id=39022

Skipping failing tests for GTK+.

  • platform/gtk/Skipped:
1:32 PM Changeset in webkit [59261] by Csaba Osztrogonác
  • 2 edits in trunk/WebKitTools

[Qt] Slave losts cause build break on bots
​https://bugs.webkit.org/show_bug.cgi?id=38980

Reviewed by Kenneth Rohde Christiansen.

  • Scripts/build-webkit: Remove 0 byte sized files from productDir before build.
1:24 PM Changeset in webkit [59260] by crogers@google.com
  • 4 edits in branches/audio/WebCore/audio

Add noteGrainOn() to AudioBufferSourceNode

  • this is a temporary name to get us going until final names determined
1:24 PM Changeset in webkit [59259] by crogers@google.com
  • 2 edits in branches/audio/WebCore

Add AudioPannerNode to DOMWindow so we can have panner constants

1:24 PM Changeset in webkit [59258] by crogers@google.com
  • 1 edit in branches/audio/WebCore/audio/EqualPowerPanner.cpp

Fix EqualPowerPanner to always process the correct number of frames

1:24 PM Changeset in webkit [59257] by crogers@google.com
  • 1 edit in branches/audio/.gitignore

Update .gitignore to ignore a gyp-generated file

1:10 PM Changeset in webkit [59256] by eric@webkit.org
  • 8 edits
    2 deletes in trunk

2010-05-12 Eric Seidel <​eric@webkit.org>

Unreviewed, rolling out r59245.
​http://trac.webkit.org/changeset/59245
​https://bugs.webkit.org/show_bug.cgi?id=38874

Broke at least one test on multiple platforms

  • editing/deleting/delete-block-contents-004-expected.txt: Removed.
  • editing/deleting/delete-block-contents-004.html: Removed.
  • editing/deleting/in-visibly-empty-root-expected.txt:
  • platform/mac/editing/deleting/5408255-expected.txt:
  • platform/mac/editing/deleting/delete-select-all-001-expected.txt:
  • platform/mac/editing/selection/4895428-1-expected.txt:
  • platform/mac/editing/selection/4895428-4-expected.txt:

2010-05-12 Eric Seidel <​eric@webkit.org>

Unreviewed, rolling out r59245.
​http://trac.webkit.org/changeset/59245
​https://bugs.webkit.org/show_bug.cgi?id=38874

Broke at least one test on multiple platforms

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::removeChild):
1:08 PM Changeset in webkit [59255] by Csaba Osztrogonác
  • 2 edits in trunk/WebKitTools

Unreviewed trivial fix after r59254.

  • Scripts/old-run-webkit-tests:
1:01 PM Changeset in webkit [59254] by Csaba Osztrogonác
  • 2 edits in trunk/WebKitTools

run-webkit-tests --exit-after-N-failures should not count new tests as failures
​https://bugs.webkit.org/show_bug.cgi?id=31829

Reviewed by Eric Seidel.

  • Scripts/old-run-webkit-tests:
12:48 PM Changeset in webkit [59253] by Martin Robinson
  • 3 edits in trunk/LayoutTests

2010-05-12 Martin Robinson <​mrobinson@igalia.com>

Not reviewed. Try number 3 to properly add new baselines and remove remaining
merge marker from this file.

  • platform/gtk/fast/css/input-search-padding-expected.txt:
  • platform/gtk/svg/custom/svg-fonts-with-no-element-reference-expected.txt:
12:41 PM Changeset in webkit [59252] by jamesr@google.com
  • 1 edit in trunk/LayoutTests/ChangeLog

Fix LayoutTest/ChangeLog bad merge

12:36 PM Changeset in webkit [59251] by jamesr@google.com
  • 3 edits in trunk/LayoutTests

2010-04-29 James Robinson <​jamesr@chromium.org>

Reviewed by Simon Fraser.

Test that when a frame with fixed position elements is scrolled via the
keyboard that the correct repaints happen.
​https://bugs.webkit.org/show_bug.cgi?id=38286


  • fast/repaint/fixed-move-after-keyboard-scroll.html: Added.
  • fast/repaint/resources/fixed-move-after-keyboard-scroll-iframe.html: Added.
  • platform/chromium/test_expectations.txt:
  • platform/mac/fast/repaint/fixed-move-after-keyboard-scroll-expected.checksum: Added.
  • platform/mac/fast/repaint/fixed-move-after-keyboard-scroll-expected.png: Added.
  • platform/mac/fast/repaint/fixed-move-after-keyboard-scroll-expected.txt: Added.
12:19 PM Changeset in webkit [59250] by ap@apple.com
  • 3 edits
    3 adds in trunk

Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=38752
Strange behaviour after js insertion into a page pointing directly to an object (image, swf, etc)

Test: fast/images/extra-image-in-image-document.html

  • loader/ImageLoader.cpp: (WebCore::ImageLoader::updateFromElement): Reset setAutoLoadImages after manually feeding an image - there may be more coming.
12:12 PM Changeset in webkit [59249] by Martin Robinson
  • 5 edits
    2 adds in trunk/LayoutTests

2010-05-12 Martin Robinson <Martin Robinson>

Not reviewed. Trying once more to generate baselines for GTK+.

  • platform/gtk/fast/css/input-search-padding-expected.txt:
  • platform/gtk/fast/forms/placeholder-stripped-expected.txt:
  • platform/gtk/fast/frames/take-focus-from-iframe-expected.txt:
  • platform/gtk/fast/images/svg-background-partial-redraw-expected.txt: Added.
  • platform/gtk/fast/repaint/fixed-move-after-keyboard-scroll-expected.txt:
  • platform/gtk/svg/custom/repaint-stroke-width-changes-expected.txt: Copied from LayoutTests/platform/mac/svg/custom/repaint-stroke-width-changes-expected.txt.
12:09 PM Changeset in webkit [59248] by yael.aharon@nokia.com
  • 3 edits in trunk/WebCore

HTMLLabelElement::control() should return HTMLFormControlElement, not HTMLElement
​https://bugs.webkit.org/show_bug.cgi?id=38991

Reviewed by Dan Bernstein.

No new tests since no new functionality was introduced.

  • html/HTMLLabelElement.cpp:

(WebCore::HTMLLabelElement::control):

  • html/HTMLLabelElement.h:
12:03 PM Changeset in webkit [59247] by hyatt@apple.com
  • 2 edits in trunk/WebCore

​https://bugs.webkit.org/show_bug.cgi?id=38891

Reviewed by Darin Adler.

First-letter had a number of bugs that were exposed by my attempt to optimize the setting of styles when updating first-letter.
The code that drills down to find the first-letter child stopped if it hit an element that didn't need layout. This means it could
return random incorrect results (and cause the first-letter object to not be found).

In addition when the first-letter was floated/positioned, the text child was not correctly returned, but the container itself was
returned instead.

Finally, the updating code was leaving the box that wrapped the first letter text with a stale style. The old code happened to work because
it made new styles for the text elements instead of using the enclosing box style. The regression was caused by my change to make the
text children simply share style with their parent (thus making the bug that the parent had the wrong style become more prominent).

No new tests, since there's a timing component to reproducing the issue.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::updateFirstLetter):

11:30 AM Changeset in webkit [59246] by jamesr@google.com
  • 2 edits in trunk/WebKitTools

2010-05-12 James Robinson <​jamesr@chromium.org>

Reviewed by Simon Fraser.

Disable smooth scrolling on OS X when running tests
​https://bugs.webkit.org/show_bug.cgi?id=38964

Some tests (like fast/repaint/fixed-move-after-keyboard-scroll.html)
depend on smooth scrolling behavior. Since this is off by default
in Leopard and on by default in Snow Leopard, DRT should turn it
off always to ensure a consistent test environment.

  • DumpRenderTree/mac/DumpRenderTree.mm: (resetDefaultsToConsistentValues):
11:29 AM Changeset in webkit [59245] by enrica@apple.com
  • 8 edits
    2 adds in trunk

Adding block elements to a block and removing them changes the height of the element.
​https://bugs.webkit.org/show_bug.cgi?id=38874

Reviewed by Dave Hyatt.

WebCore:

The initial height of an empty editable block is different from the height of the same block after we add block elements
and remove them.

Test: editing/deleting/delete-block-contents-004.html

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::removeChild): m_childrenInline was set to true only when the Renderer is created
and never reset to true when all the block elements contained are removed.

LayoutTests:

  • editing/deleting/delete-block-contents-004-expected.txt: Added.
  • editing/deleting/delete-block-contents-004.html: Added.

The following tests have new results because of the height change and because we now have one less renderer after the DOM changes.

  • editing/deleting/in-visibly-empty-root-expected.txt:
  • platform/mac/editing/deleting/5408255-expected.txt:
  • platform/mac/editing/deleting/delete-select-all-001-expected.txt:
  • platform/mac/editing/selection/4895428-1-expected.txt:
  • platform/mac/editing/selection/4895428-4-expected.txt:
11:26 AM Changeset in webkit [59244] by Martin Robinson
  • 1 edit
    22 adds in trunk/LayoutTests

2010-05-12 Martin Robinson <​mrobinson@igalia.com>

Not reviewed. Added baselines to these tests which are passing interactively.

  • platform/gtk/fast/css-generated-content/after-duplicated-after-split-expected.txt: Added.
  • platform/gtk/fast/css/input-search-padding-expected.txt: Added.
  • platform/gtk/fast/forms/placeholder-stripped-expected.txt: Added.
  • platform/gtk/fast/frames/take-focus-from-iframe-expected.txt: Added.
  • platform/gtk/fast/repaint/fixed-child-move-after-scroll-expected.txt: Added.
  • platform/gtk/fast/repaint/fixed-child-of-fixed-move-after-scroll-expected.txt: Added.
  • platform/gtk/fast/repaint/fixed-child-of-transformed-move-after-scroll-expected.txt: Added.
  • platform/gtk/fast/repaint/fixed-move-after-keyboard-scroll-expected.txt: Added.
  • platform/gtk/fast/repaint/fixed-move-after-scroll-expected.txt: Added.
  • platform/gtk/fast/repaint/fixed-tranformed-expected.txt: Added.
  • platform/gtk/fast/text/format-control-expected.txt: Added.
  • platform/gtk/fast/text/international/bold-bengali-expected.txt: Added.
  • platform/gtk/svg/custom/svg-fonts-with-no-element-reference-expected.txt: Copied from LayoutTests/platform/mac/svg/custom/svg-fonts-with-no-element-reference-expected.txt.
  • platform/gtk/svg/text/text-hkern-expected.txt: Copied from LayoutTests/platform/mac/svg/text/text-hkern-expected.txt.
  • platform/gtk/svg/text/text-hkern-on-vertical-text-expected.txt: Copied from LayoutTests/platform/mac/svg/text/text-hkern-on-vertical-text-expected.txt.
  • platform/gtk/svg/text/text-vkern-expected.txt: Copied from LayoutTests/platform/mac/svg/text/text-vkern-expected.txt.
  • platform/gtk/svg/text/text-vkern-on-horizontal-text-expected.txt: Copied from LayoutTests/platform/mac/svg/text/text-vkern-on-horizontal-text-expected.txt.
  • platform/gtk/transforms/svg-vs-css-expected.txt: Added.
11:24 AM Changeset in webkit [59243] by pfeldman@chromium.org
  • 13 edits
    4 adds in trunk

2010-05-12 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: disabling style property on container breaks styles inspection for given node.

​https://bugs.webkit.org/show_bug.cgi?id=39005

Tests: inspector/styles-disable-inherited.html

inspector/styles-disable-then-enable.html

  • inspector/front-end/StylesSidebarPane.js: (WebInspector.StylesSidebarPane.prototype._containsInherited): (WebInspector.StylesSidebarPane.prototype._arrayContainsInheritedProperty):
11:15 AM Changeset in webkit [59242] by Darin Adler
  • 1 edit in trunk/WebCore/ChangeLog

HTML Entity Escape the contents of a textarea node when accessed
via the innerHTML and outerHTML node properties.
​https://bugs.webkit.org/show_bug.cgi?id=38922

Patch by Abhishek Arya <​inferno@chromium.org> on 2010-05-12
Reviewed by Darin Adler.

Test: fast/innerHTML/innerHTML-special-elements.html

  • editing/markup.cpp:

(WebCore::appendStartMarkup):

11:13 AM Changeset in webkit [59241] by Darin Adler
  • 5 edits
    2 adds in trunk

2010-05-12 Abhishek Arya <​inferno@chromium.org>

Reviewed by Darin Adler.

HTML Entity Escape the contents of a textarea node when accessed via the innerHTML and outerHTML node properties.
​https://bugs.webkit.org/show_bug.cgi?id=38922

Test: fast/encoding/textnode-XSS.html

  • editing/markup.cpp: (WebCore::appendStartMarkup):

2010-05-12 Abhishek Arya <​inferno@chromium.org>

Reviewed by Darin Adler.

Tests that accessing the innerHTML property of a text node encodes
entities properly. Update existing test to fix the innerHTML result.
​https://bugs.webkit.org/show_bug.cgi?id=38922

  • fast/innerHTML/innerHTML-special-elements-expected.txt: Added.
  • fast/innerHTML/innerHTML-special-elements.html: Added.
  • fast/parser/comment-in-textarea-expected.txt: Update test expectation.
  • fast/parser/script-tests/comment-in-textarea.js: Update test by replacing with html entities of <, > chars in textarea innerHTML result.
10:11 AM Changeset in webkit [59240] by Martin Robinson
  • 6 edits in trunk/WebKit/gtk

2010-05-12 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Xan Lopez.

[Gtk] Use GOwnPtr for code that needs it
​https://bugs.webkit.org/show_bug.cgi?id=21594

Convert many uses of raw pointers to GRefPtr and GOwnPtr in WebKitWebView.

  • WebCoreSupport/ContextMenuClientGtk.cpp: (WebKit::inputMethodsMenuItem):
  • WebCoreSupport/EditorClientGtk.cpp: (WebKit::EditorClient::setInputMethodState): (WebKit::EditorClient::respondToChangedSelection): (WebKit::EditorClient::handleInputMethodKeydown): (WebKit::EditorClient::EditorClient): (WebKit::EditorClient::~EditorClient):
  • WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::postCommitFrameViewSetup):
  • webkit/webkitprivate.h:
  • webkit/webkitwebview.cpp: (destroy_menu_cb): (webkit_web_view_forward_context_menu_event): (webkit_web_view_key_release_event): (webkit_web_view_button_release_event): (webkit_web_view_focus_in_event): (webkit_web_view_focus_out_event): (webkit_web_view_realize): (webkit_web_view_set_scroll_adjustments): (webkit_web_view_dispose): (webkit_web_view_finalize): (webViewGetDPI): (webkit_web_view_screen_changed): (webkit_web_view_query_tooltip): (webkit_web_view_get_im_context): (webkit_web_view_update_settings): (webkit_web_view_init): (webkit_web_view_set_settings): (webkit_web_view_get_settings): (webkit_web_view_get_inspector): (webkit_web_view_set_window_features): (webkit_web_view_get_window_features): (webkit_web_view_get_back_forward_list): (webkit_web_view_zoom_in): (webkit_web_view_zoom_out): (webkit_web_view_get_encoding): (webkit_web_view_get_custom_encoding): (webkit_web_view_add_resource): (webkit_web_view_get_resource): (webkit_web_view_get_main_resource): (webkit_web_view_clear_resources): (webkit_web_view_get_subresources): (webkit_web_view_set_tooltip_text): (webkit_web_view_get_icon_uri):
9:52 AM Changeset in webkit [59239] by Beth Dakin
  • 5 edits in trunk/WebCore

Fix for ​https://bugs.webkit.org/show_bug.cgi?id=38871 REGRESSION:
Crash clicking background NPR tab after few minutes of sitting idle
-and corresponding-
<rdar://problem/7941504>

Reviewed by Darin Adler.

Move m_mediaCanStartListeners HashSet to Document away from Page.

  • dom/Document.cpp:

(WebCore::Document::Document):
(WebCore::Document::addMediaCanStartListener):
(WebCore::Document::removeMediaCanStartListener):
(WebCore::Document::takeAnyMediaCanStartListener):

  • dom/Document.h:
  • page/Page.cpp:

(WebCore::Page::takeAnyMediaCanStartListener):

  • page/Page.h:

(WebCore::Page::canStartMedia):

9:44 AM Changeset in webkit [59238] by jorlow@chromium.org
  • 5 edits in trunk/WebKit/chromium

2010-05-12 Jeremy Orlow <​jorlow@chromium.org>

Reviewed by Steve Block.

[Chromium] Pass the origin parameter for WebIndexedDatabase::open
​https://bugs.webkit.org/show_bug.cgi?id=38983

  • public/WebIndexedDatabase.h:
  • src/IndexedDatabaseProxy.cpp: (WebCore::IndexedDatabaseProxy::open):
  • src/WebIndexedDatabaseImpl.cpp: (WebKit::WebIndexedDatabaseImpl::open):
  • src/WebIndexedDatabaseImpl.h:
9:10 AM Changeset in webkit [59237] by loislo@chromium.org
  • 11 edits in trunk

2010-05-11 Ilya Tikhonovsky <​loislo@chromium.org>

Reviewed by Pavel Feldman.

WebInspector: Sometimes ResourceRequest records aren't connected to the initiator.
​https://bugs.webkit.org/show_bug.cgi?id=38925

  • inspector/InspectorTimelineAgent.cpp: (WebCore::InspectorTimelineAgent::didScheduleResourceRequest):
  • inspector/InspectorTimelineAgent.h: (WebCore::):
  • inspector/TimelineRecordFactory.cpp: (WebCore::TimelineRecordFactory::createScheduleResourceRequestData):
  • inspector/TimelineRecordFactory.h:
  • inspector/front-end/TimelineAgent.js:
  • inspector/front-end/TimelinePanel.js: (WebInspector.TimelinePanel): (WebInspector.TimelinePanel.prototype.get _recordStyles): (WebInspector.TimelinePanel.prototype._findParentRecord): (WebInspector.TimelinePanel.prototype._innerAddRecordToTimeline): (WebInspector.TimelinePanel.prototype._clearPanel): (WebInspector.TimelinePanel.FormattedRecord): (WebInspector.TimelinePanel.FormattedRecord.prototype._generatePopupContent): (WebInspector.TimelinePanel.FormattedRecord.prototype._getRecordDetails):
  • loader/loader.cpp: (WebCore::Loader::load):

2010-05-11 Ilya Tikhonovsky <​loislo@chromium.org>

Reviewed by Pavel Feldman.

WebInspector: Sometimes ResourceRequest records aren't connected to the initiator.
​https://bugs.webkit.org/show_bug.cgi?id=38925

  • inspector/timeline-enum-stability-expected.txt:
8:57 AM Changeset in webkit [59236] by tkent@chromium.org
  • 7 edits
    4 adds in trunk

2010-05-12 Kent Tamura <​tkent@chromium.org>

Reviewed by Darin Adler.

placeholder text should be stripped from line breaks
​https://bugs.webkit.org/show_bug.cgi?id=36291

Add a test for placeholder values with CR and LF.

  • fast/forms/placeholder-stripped.html: Added.
  • platform/mac/fast/forms/placeholder-stripped-expected.checksum: Added.
  • platform/mac/fast/forms/placeholder-stripped-expected.png: Added.
  • platform/mac/fast/forms/placeholder-stripped-expected.txt: Added.

2010-05-12 Kent Tamura <​tkent@chromium.org>

Reviewed by Darin Adler.

placeholder text should be stripped from line breaks
​https://bugs.webkit.org/show_bug.cgi?id=36291

According to ​http://dev.w3.org/html5/spec/forms.html#attr-input-placeholder ,
we need to remove CR and LF from the placeholder attribute values.
Introduce HTMLTextFormControlElement::strippedPlaceholder(), which
returns stripped value, and replace getAttribute(placeholderAttr) with it.

Test: fast/forms/placeholder-stripped.html

  • html/HTMLFormControlElement.cpp: (WebCore::HTMLTextFormControlElement::strippedPlaceholder): (WebCore::HTMLTextFormControlElement::isPlaceholderEmpty): (WebCore::HTMLTextFormControlElement::placeholderShouldBeVisible): Use strippedPlaceholder().
  • html/HTMLFormControlElement.h:
  • platform/text/CharacterNames.h: Add carriageReturn.
  • rendering/RenderTextControlMultiLine.cpp: (WebCore::RenderTextControlMultiLine::updateFromElement): Use strippedPlaceholder().
  • rendering/RenderTextControlSingleLine.cpp: (WebCore::RenderTextControlSingleLine::updateFromElement): Use strippedPlaceholder().
8:26 AM Changeset in webkit [59235] by tonikitoo@webkit.org
  • 5 edits in trunk

Allows build-webkit script to receive an install prefix as parameter ​https://bugs.webkit.org/show_bug.cgi?id=26224

Reviewed by Kenneth Christiansen , Simon Hausmann and Gustavo Noronha.
Patch by Rodrigo Belem <​rodrigo.belem@openbossa.org>

WebCore:

This patch adds the ability, in the QtWebkit build system, to change
the installation path.

  • WebCore.pro:

WebKitTools:

Added more parameters to build-webkit script, the --prefix for gkt
and --install-libs, --install-headers for qt. Now it is possible
to change the install prefix for gtk and install path for qt.

  • Scripts/build-webkit:
  • Scripts/webkitdirs.pm:
8:05 AM Changeset in webkit [59234] by tonikitoo@webkit.org
  • 2 edits in trunk/WebKit/qt

2010-05-12 Antonio Gomes <​tonikitoo@webkit.org>

Reviewed by Kenneth Christiansen.

[Qt] Remove the unneeded check for QWidgetPageClient @QGraphicsWebView::detachCurrentPage
​https://bugs.webkit.org/show_bug.cgi?id=38989

Reasons:

  • There is no need to check for a QWidgetPageClient-based in QGraphicsWebView.
  • The client has always to be deleted anyways.
  • Api/qgraphicswebview.cpp: (QGraphicsWebViewPrivate::detachPage):
8:04 AM Changeset in webkit [59233] by tonikitoo@webkit.org
  • 3 edits in trunk/WebKit/qt

[Qt] Implement a detachCurrentPage method for QGraphicsWebView and QWebView
​https://bugs.webkit.org/show_bug.cgi?id=38939

Reviewed by Kenneth Christiansen.
Patch by Antonio Gomes <​tonikitoo@webkit.org>

unsetPageIfExists method was renamed to detachCurrentPage method and is now responsible
for doing all the unset logic of page and pageClient references previously done by
the Q{Graphics}WebView destructor(s).

It is a code clean up, no behaviour change.

  • Api/qgraphicswebview.cpp:

(QGraphicsWebViewPrivate::~QGraphicsWebViewPrivate):
(QGraphicsWebView::~QGraphicsWebView):
(QGraphicsWebViewPrivate::detachCurrentPage):
(QGraphicsWebView::setPage):

  • Api/qwebview.cpp:

(QWebViewPrivate::~QWebViewPrivate):
(QWebView::~QWebView):
(QWebViewPrivate::detachCurrentPage):
(QWebView::setPage):

7:35 AM Changeset in webkit [59232] by jer.noble@apple.com
  • 10 edits in trunk

2010-05-12 Jer Noble <​jer.noble@apple.com>

Reviewed by Darin Adler.

Bug 38689: #34005 will break fullscreen video playback
​https://bugs.webkit.org/show_bug.cgi?id=38689

Use the new definition of PlatformMedia to check the actual type
returned by MediaPlayer.

  • FullscreenVideoController.cpp: (FullscreenVideoController::movie):

2010-05-12 Jer Noble <​jer.noble@apple.com>

Reviewed by Darin Adler.

Bug 38689: #34005 will break fullscreen video playback
​https://bugs.webkit.org/show_bug.cgi?id=38689

Use the new definition of PlatformMedia to check the actual type
returned by MediaPlayer.


  • WebView/WebVideoFullscreenController.mm: (-[WebVideoFullscreenController windowDidLoad]):

2010-05-12 Jer Noble <​jer.noble@apple.com>

Reviewed by Darin Adler.


Bug 38689: #34005 will break fullscreen video playback
​https://bugs.webkit.org/show_bug.cgi?id=38689


The PlatformMedia struct now contains a type field indicating which type
it contains. The struct now contains a union of all possible return types,
allowing the type of media returned by MediaPlayerPrivate instances to be
determined at runtime.

  • platform/graphics/MediaPlayer.h: (WebCore::PlatformMedia::): (WebCore::):
  • platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivate::platformMedia):
  • platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp: (WebCore::MediaPlayerPrivateQuickTimeVisualContext::platformMedia):
  • platform/graphics/win/MediaPlayerPrivateQuickTimeWin.cpp: (WebCore::MediaPlayerPrivate::platformMedia):
7:22 AM Changeset in webkit [59231] by Simon Hausmann
  • 2 edits in trunk/WebKit/qt

Add a comment to explain the web inspector dynamic property url hook
and that it's there on purpose :)

Reviewed by Laszlo Gombos.

​https://bugs.webkit.org/show_bug.cgi?id=35340

  • WebCoreSupport/InspectorClientQt.cpp:

(WebCore::InspectorClientQt::openInspectorFrontend):

6:52 AM Changeset in webkit [59230] by eric@webkit.org
  • 4 edits in trunk/WebCore

2010-05-12 Young Han Lee <​joybro@company100.net>

Reviewed by Darin Adler.

Add missing ENABLE(SVG) guards.
​https://bugs.webkit.org/show_bug.cgi?id=38892

  • rendering/RenderSVGResourceClipper.cpp:
  • rendering/RenderSVGResourceMarker.cpp:
  • rendering/RenderSVGResourceMasker.cpp:
6:08 AM Changeset in webkit [59229] by pfeldman@chromium.org
  • 3 edits in trunk/WebCore

2010-05-12 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: align sidebar checkboxes on windows.

​https://bugs.webkit.org/show_bug.cgi?id=38986

  • inspector/front-end/StylesSidebarPane.js:
  • inspector/front-end/inspector.css: (.sidebar-pane-subtitle): (body.platform-windows .sidebar-pane-subtitle):
6:05 AM Changeset in webkit [59228] by Philippe Normand
  • 2 edits in trunk/WebKitTools

2010-05-12 Philippe Normand <​pnormand@igalia.com>

Unreviewed, added my IRC nickname.

  • Scripts/webkitpy/common/config/committers.py:
6:02 AM Changeset in webkit [59227] by yael.aharon@nokia.com
  • 10 edits
    10 adds in trunk

Support control attribute of HTMLLabelElement
​https://bugs.webkit.org/show_bug.cgi?id=38688

Reviewed by Darin Adler.

WebCore:

Added support for the control attribute of HTMLLabelElement and changed the logic of determining
which control is associated with the label to conform to HTML5 spec.
Added a manual test for testing the logic of selecting the control to get focused, activated or hovered
when the label gets focused, activated or is hovered.

Test: fast/dom/HTMLLabelElement/click-label.html
Test: fast/dom/HTMLLabelElement/focus-label.html
Test: fast/dom/HTMLLabelElement/label-control.html

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::labelForElement):
(WebCore::AccessibilityRenderObject::correspondingControlForLabelElement):

  • html/HTMLFormControlElement.cpp:

(WebCore::HTMLFormControlElement::isLabelable):

  • html/HTMLFormControlElement.h:
  • html/HTMLLabelElement.cpp:

(WebCore::nodeAsLabelableFormControl):
(WebCore::HTMLLabelElement::control):
(WebCore::HTMLLabelElement::setActive):
(WebCore::HTMLLabelElement::setHovered):
(WebCore::HTMLLabelElement::defaultEventHandler):
(WebCore::HTMLLabelElement::focus):
(WebCore::HTMLLabelElement::accessKeyAction):

  • html/HTMLLabelElement.h:
  • html/HTMLLabelElement.idl:
  • manual-tests/dom/form-control-for-label.html: Added.

WebKit/chromium:

Renamed HTMLLabelElement::correspondingControl to HTMLLabelElement::control

  • src/WebLabelElement.cpp:

(WebKit::WebLabelElement::correspondingControl):

LayoutTests:

  • fast/dom/HTMLLabelElement/click-label-expected.txt: Added.
  • fast/dom/HTMLLabelElement/click-label.html: Added.
  • fast/dom/HTMLLabelElement/focus-label-expected.txt: Added.
  • fast/dom/HTMLLabelElement/focus-label.html: Added.
  • fast/dom/HTMLLabelElement/label-control-expected.txt: Added.
  • fast/dom/HTMLLabelElement/label-control.html: Added.
  • fast/dom/HTMLLabelElement/script-tests: Added.
  • fast/dom/HTMLLabelElement/script-tests/TEMPLATE.html: Added.
  • fast/dom/HTMLLabelElement/script-tests/label-control.js: Added.
5:51 AM Changeset in webkit [59226] by eric@webkit.org
  • 3 edits in trunk/WebCore

2010-05-12 Steve Block <​steveblock@google.com>

Reviewed by David Levin.

Android's writeToFile() is buggy
​https://bugs.webkit.org/show_bug.cgi?id=38908

No new tests, build fix only.

  • platform/android/FileSystemAndroid.cpp: Remove Android's version of writeToFile().
  • platform/posix/FileSystemPOSIX.cpp: Use POSIX version of writeToFile() on Android. (WebCore::writeToFile):
5:21 AM Changeset in webkit [59225] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

Unreviewed.

Other tests make http/tests/xmlhttprequest/null-auth.php fail
​https://bugs.webkit.org/show_bug.cgi?id=32961

http/tests/xmlhttprequest/basic-auth-default.html introduced in r59185,
and it made http/tests/xmlhttprequest/null-auth.php fail on Qt bot, as
http/tests/xmlhttprequest/failed-auth.html did it before.

  • platform/qt/Skipped: http/tests/xmlhttprequest/basic-auth-default.html skipped until fix.
5:11 AM Changeset in webkit [59224] by Philippe Normand
  • 2 edits in trunk/WebCore

2010-05-10 Philippe Normand <​pnormand@igalia.com>

Reviewed by David Levin.

[GStreamer] incoherent #ifdef in GOwnPtrGStreamer.h
​https://bugs.webkit.org/show_bug.cgi?id=38839

Fixed #ifdef/curly braces coherence.

  • platform/graphics/gstreamer/GOwnPtrGStreamer.cpp: (WTF::GstElement):
5:07 AM Changeset in webkit [59223] by Philippe Normand
  • 2 edits in trunk/WebCore

2010-05-10 Philippe Normand <​pnormand@igalia.com>

Reviewed by Dirk Schulze.

[GStreamer] un-needed cairo.h include
​https://bugs.webkit.org/show_bug.cgi?id=38837

Cairo not used in the sink anymore. So it's not needed to include
the header.

  • platform/graphics/gstreamer/VideoSinkGStreamer.h:
4:49 AM Changeset in webkit [59222] by zoltan@webkit.org
  • 2 edits in trunk/JavaScriptCore

2010-05-12 Peter Varga <​pvarga@inf.u-szeged.hu>

Reviewed by Gavin Barraclough.

Remove a direct jump in generatePatternCharacterGreedy() and
generatePatternCharacterClassGreedy() functions if quantityCount of the term
is unlimited.
​https://bugs.webkit.org/show_bug.cgi?id=38898

  • yarr/RegexJIT.cpp: (JSC::Yarr::RegexGenerator::generatePatternCharacterGreedy): (JSC::Yarr::RegexGenerator::generateCharacterClassGreedy):
3:58 AM Changeset in webkit [59221] by zherczeg@webkit.org
  • 4 edits in trunk/WebCore

Build fix for Windows and Chromium builds.

Reviewed by Nikolas Zimmermann.

  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • svg/graphics/filters/SVGFELighting.cpp:

(WebCore::FELighting::LightingData::upLeftPixelValue):
(WebCore::FELighting::LightingData::upPixelValue):
(WebCore::FELighting::LightingData::upRightPixelValue):
(WebCore::FELighting::LightingData::leftPixelValue):
(WebCore::FELighting::LightingData::centerPixelValue):
(WebCore::FELighting::LightingData::rightPixelValue):
(WebCore::FELighting::LightingData::downLeftPixelValue):
(WebCore::FELighting::LightingData::downPixelValue):
(WebCore::FELighting::LightingData::downRightPixelValue):
(WebCore::FELighting::setPixel):

3:18 AM Changeset in webkit [59220] by zherczeg@webkit.org
  • 23 edits
    2 adds in trunk

WebCore: Implementing SVG filters: feDiffuseLighting and feSpecularLighting
​https://bugs.webkit.org/show_bug.cgi?id=32197
​https://bugs.webkit.org/show_bug.cgi?id=32199

Reviewed by Nikolas Zimmermann.

The patch implements the SVG filters feDiffuseLighting and
feSpecularLighting including the impementation of their possible
light sources according to the Scalable Vector Graphics (SVG)
1.1 Specification. Only two features are missing: supporting images
with height or width set to 1, and kernelUnitLength other than (1,1).
Since the two lighting filters have a similar body, a common base
class called FELighting is introduced, and contains the code for
both filters. The implementation employs single precision floating
point arithmetic (fixed precision integer arithmetic seemed too difficult).

Indentation is removed of the modified header files in svg/graphics/filters

  • GNUmakefile.am:
  • WebCore.pro:
  • WebCore.xcodeproj/project.pbxproj:
  • platform/graphics/FloatPoint3D.cpp:
  • platform/graphics/FloatPoint3D.h:

(WebCore::FloatPoint3D::FloatPoint3D): constructors changed to inline
(WebCore::operator*): dot product

  • svg/SVGFESpotLightElement.cpp:

(WebCore::SVGFESpotLightElement::lightSource):

  • svg/graphics/filters/SVGDistantLightSource.h:

(WebCore::DistantLightSource::create):
(WebCore::DistantLightSource::azimuth):
(WebCore::DistantLightSource::elevation):
(WebCore::DistantLightSource::DistantLightSource):

  • svg/graphics/filters/SVGFEDiffuseLighting.cpp:

(WebCore::FEDiffuseLighting::FEDiffuseLighting):
(WebCore::FEDiffuseLighting::create):

  • svg/graphics/filters/SVGFEDiffuseLighting.h:
  • svg/graphics/filters/SVGFELighting.cpp: Added.

(WebCore::FELighting::FELighting):
(WebCore::FELighting::LightingData::upLeftPixelValue):
(WebCore::FELighting::LightingData::upPixelValue):
(WebCore::FELighting::LightingData::upRightPixelValue):
(WebCore::FELighting::LightingData::leftPixelValue):
(WebCore::FELighting::LightingData::centerPixelValue):
(WebCore::FELighting::LightingData::rightPixelValue):
(WebCore::FELighting::LightingData::downLeftPixelValue):
(WebCore::FELighting::LightingData::downPixelValue):
(WebCore::FELighting::LightingData::downRightPixelValue):
(WebCore::FELighting::setPixel):
(WebCore::FELighting::drawLighting):
(WebCore::FELighting::apply):

  • svg/graphics/filters/SVGFELighting.h: Added.

(WebCore::FELighting::uniteChildEffectSubregions):
(WebCore::FELighting::):

  • svg/graphics/filters/SVGFESpecularLighting.cpp:

(WebCore::FESpecularLighting::FESpecularLighting):
(WebCore::FESpecularLighting::create):

  • svg/graphics/filters/SVGFESpecularLighting.h:
  • svg/graphics/filters/SVGLightSource.cpp:

(WebCore::PointLightSource::initPaintingData):
(WebCore::PointLightSource::updatePaintingData):
(WebCore::SpotLightSource::initPaintingData):
(WebCore::SpotLightSource::updatePaintingData):
(WebCore::DistantLightSource::initPaintingData):
(WebCore::DistantLightSource::updatePaintingData):

  • svg/graphics/filters/SVGLightSource.h:

(WebCore::):
(WebCore::LightSource::LightSource):
(WebCore::LightSource::~LightSource):
(WebCore::LightSource::type):

  • svg/graphics/filters/SVGPointLightSource.h:

(WebCore::PointLightSource::create):
(WebCore::PointLightSource::position):
(WebCore::PointLightSource::PointLightSource):

  • svg/graphics/filters/SVGSpotLightSource.h:

(WebCore::SpotLightSource::create):
(WebCore::SpotLightSource::position):
(WebCore::SpotLightSource::direction):
(WebCore::SpotLightSource::specularExponent):
(WebCore::SpotLightSource::limitingConeAngle):
(WebCore::SpotLightSource::SpotLightSource):

LayoutTests: Updating the pixel tests for feDiffuseLighting and feSpecularLighting
​https://bugs.webkit.org/show_bug.cgi?id=32197
​https://bugs.webkit.org/show_bug.cgi?id=32199

Reviewed by Nikolas Zimmermann.

No new test were added, since SVG expected values cover
the features of the implementation

  • platform/mac/svg/W3C-SVG-1.1/filters-diffuse-01-f-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/filters-diffuse-01-f-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/filters-light-01-f-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/filters-light-01-f-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/filters-specular-01-f-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/filters-specular-01-f-expected.png:
2:35 AM Changeset in webkit [59219] by xan@webkit.org
  • 2 edits in trunk/WebCore

2010-05-12 Xan Lopez <​xlopez@igalia.com>

Reviewed by Nikolas Zimmermann.

Add missing AM_V_GEN directives to generation rules so that they
remain silent when requested.

  • GNUmakefile.am:
2:12 AM Changeset in webkit [59218] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-05-12 Lucas De Marchi <​lucas.demarchi@profusion.mobi>

Reviewed by Jeremy Orlow.

[EFL] It does not make sense to use ScrollbarEfl::ScrollbarEfl, so
use ScrollbarEfl (GCC 4.5 seems to be pickier about this). Revision 59030
fixed cases for RenderThemeEfl, but missed this for ScrollbarEfl.
​http://webkit.org/b/38904

No new tests required.

  • platform/efl/ScrollbarEfl.cpp: (scrollbarEflEdjeMessage):
1:51 AM Changeset in webkit [59217] by morrita@google.com
  • 9 edits in trunk

2010-05-12 MORITA Hajime <​morrita@google.com>

Reviewed by Kent Tamura.

[Chromium] Support HTML5 <progress> element on Windows.
​https://bugs.webkit.org/show_bug.cgi?id=37308

Extended ChromiumBridge to handle progress bar painting,
and added delegations to it.

No new tests. Test cases should be shared with existing ones for
progress element. Expectaions will be added after PROGRESS_TAG is
enabled on Chromium tree.

  • platform/chromium/ChromiumBridge.h:
  • rendering/RenderProgress.cpp: (WebCore::RenderProgress::animationProgress): (WebCore::RenderProgress::isDeterminate):
  • rendering/RenderProgress.h: (WebCore::RenderProgress::position):
  • rendering/RenderThemeChromiumWin.cpp: (WebCore::RenderThemeChromiumWin::animationRepeatIntervalForProgressBar): (WebCore::RenderThemeChromiumWin::animationDurationForProgressBar): (WebCore::RenderThemeChromiumWin::adjustProgressBarStyle): (WebCore::RenderThemeChromiumWin::paintProgressBar):
  • rendering/RenderThemeChromiumWin.h:

2010-05-12 MORITA Hajime <​morrita@google.com>

Reviewed by Kent Tamura.

[Chromium] Support HTML5 <progress> element on Windows.
​https://bugs.webkit.org/show_bug.cgi?id=37308

Extended ChromiumBridge to handle progress bar painting,
and added delegations to it.

No new tests. Test cases should be shared with existing ones for
progress element. Expectaions will be added after PROGRESS_TAG is
enabled on Chromium tree.

  • public/WebThemeEngine.h: (WebKit::WebThemeEngine::paintProgressBar):
  • src/ChromiumBridge.cpp: (WebCore::ChromiumBridge::paintProgressBar):
1:43 AM Changeset in webkit [59216] by eric@webkit.org
  • 5 edits in trunk/WebCore

2010-05-12 Marcus Bulach <​bulach@chromium.org>

Reviewed by Steve Block.

Removes Geolocation::setPosition and uses positionChanged() to capture lastPosition().
This brings CLIENT_BASED_GEOLOCATION more inline with the non-client based.
​https://bugs.webkit.org/show_bug.cgi?id=38195

  • page/Geolocation.cpp: (WebCore::Geolocation::lastPosition): (WebCore::Geolocation::requestPermission): (WebCore::Geolocation::positionChangedInternal): (WebCore::Geolocation::positionChanged): (WebCore::Geolocation::geolocationServicePositionChanged):
  • page/Geolocation.h:
  • page/GeolocationController.cpp: (WebCore::GeolocationController::positionChanged): (WebCore::GeolocationController::lastPosition):
  • page/GeolocationController.h:
1:31 AM Changeset in webkit [59215] by eric@webkit.org
  • 5 edits in trunk

2010-05-12 Marcus Bulach <​bulach@chromium.org>

Reviewed by Steve Block.

Attaches the geolocation bridge later on startUpdating().
This prevents a page requesting permission when it has just accessed navigator.geolocation (without calling navigator.geolocation.getCurrentPosition/watchPosition).
Note: when Geolocation::haveSuitableCachedPosition(), WebGeolocationServiceBridgeImpl::startUpdating() is not called,
so we attach the bridge if needed at requestGeolocationPermissionForFrame().
​https://bugs.webkit.org/show_bug.cgi?id=38323
​http://crbug.com/42789

  • platform/chromium/GeolocationServiceChromium.h:

2010-05-12 Marcus Bulach <​bulach@chromium.org>

Reviewed by Steve Block.

Attaches the geolocation bridge later on startUpdating().
This prevents a page requesting permission when it has just accessed navigator.geolocation (without calling navigator.geolocation.getCurrentPosition/watchPosition).
Note: when Geolocation::haveSuitableCachedPosition(), WebGeolocationServiceBridgeImpl::startUpdating() is not called,
so we attach the bridge if needed at requestGeolocationPermissionForFrame().
​https://bugs.webkit.org/show_bug.cgi?id=38323
​http://crbug.com/42789

  • src/ChromeClientImpl.cpp: (WebKit::ChromeClientImpl::requestGeolocationPermissionForFrame):
  • src/WebGeolocationServiceBridgeImpl.cpp: (WebKit::WebGeolocationServiceBridgeImpl::attachBridgeIfNeeded): (WebKit::WebGeolocationServiceBridgeImpl::setLastPosition):
1:28 AM Changeset in webkit [59214] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

Unreviewed fix.

[Qt] Platform specific expected result updated after r59211.

  • platform/qt/fast/css/pseudo-cache-stale-expected.txt: updated.
1:19 AM Changeset in webkit [59213] by eric@webkit.org
  • 3 edits
    3 adds in trunk

2010-05-12 Robin Qiu <​robin.qiu@torchmobile.com.cn>

Reviewed by Dirk Schulze.

Fix a bug in SVGPathSegList::getPathSegAtLength().
This bug is just a misktake: almost all of the code is OK, but the
parameter is not used at all, therefore, this function always returns
"1".
And make a modification to return the last path segment if the distance
exceeds the actual path length.
​https://bugs.webkit.org/show_bug.cgi?id=37515

  • svg/dom/svgpath-getPathSegAtLength-expected.txt: Added.
  • svg/dom/svgpath-getPathSegAtLength.html: Added.

2010-05-12 Robin Qiu <​robin.qiu@torchmobile.com.cn>

Reviewed by Dirk Schulze.

Fix a bug in SVGPathSegList::getPathSegAtLength().
This bug is just a misktake: almost all of the code is OK, but the
parameter is not used at all, therefore, this function always returns
"1".
And make a modification to return the last path segment if the distance
exceeds the actual path length.
​https://bugs.webkit.org/show_bug.cgi?id=37515

Test: svg/dom/svgpath-getPathSegAtLength.html

  • svg/SVGPathSegList.cpp: (WebCore::SVGPathSegList::getPathSegAtLength):
12:46 AM Changeset in webkit [59212] by tony@chromium.org
  • 2 edits in trunk/WebKit/chromium

2010-05-12 Tony Chang <​tony@chromium.org>

Reviewed by Kent Tamura.

[chromium] add DRT back to the chromium build
​https://bugs.webkit.org/show_bug.cgi?id=38978

  • WebKit.gyp:
12:01 AM Changeset in webkit [59211] by hyatt@apple.com
  • 3 edits in trunk

​https://bugs.webkit.org/show_bug.cgi?id=38976, fast/css/pseudo-cache-stale.html has incorrect results.

Reviewed by Maciej Stachowiak.

Make sure to trigger a relayout of any objects whose first-line styles change dynamically.

  • dom/Element.cpp:

(WebCore::Element::pseudoStyleCacheIsInvalid):

Note: See TracTimeline for information about the timeline view.