⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



May 17, 2010:

11:01 PM Changeset in webkit [59656] by atwilson@chromium.org
  • 1 edit
    4 adds in trunk/LayoutTests

Unreviewed test expectations update for chromium.

  • platform/chromium-mac/html5lib/runner-expected.txt: Added.
  • platform/chromium-win/html5lib/runner-expected.txt: Added.
10:56 PM Changeset in webkit [59655] by tkent@chromium.org
  • 8 edits in trunk

2010-05-17 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r59652.
​http://trac.webkit.org/changeset/59652
​https://bugs.webkit.org/show_bug.cgi?id=39268

file-input-files-access test is broken on Mac (Requested by
dcheng on #webkit).

  • editing/pasteboard/file-input-files-access-expected.txt:
  • editing/pasteboard/script-tests/file-input-files-access.js: (runTest):
  • http/tests/security/clipboard/script-tests/clipboard-file-access.js:

2010-05-17 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r59652.
​http://trac.webkit.org/changeset/59652
​https://bugs.webkit.org/show_bug.cgi?id=39268

file-input-files-access test is broken on Mac (Requested by
dcheng on #webkit).

  • platform/chromium/DragDataChromium.cpp: (WebCore::DragData::asURL):

2010-05-17 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r59652.
​http://trac.webkit.org/changeset/59652
​https://bugs.webkit.org/show_bug.cgi?id=39268

file-input-files-access test is broken on Mac (Requested by
dcheng on #webkit).

  • Misc/WebNSPasteboardExtras.mm: (-[NSPasteboard _web_bestURL]):
10:51 PM Changeset in webkit [59654] by abarth@webkit.org
  • 3 edits in trunk/WebCore

2010-05-17 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Implement RAWTEXT tokenizer states
​https://bugs.webkit.org/show_bug.cgi?id=39267

More tokenizer states. There's a bunch of functionality notImplemented
that we'll come back to.

  • html/HTML5Tokenizer.cpp: (WebCore::HTML5Tokenizer::tokenize):
  • html/HTML5Tokenizer.h:
10:17 PM Changeset in webkit [59653] by abarth@webkit.org
  • 3 edits in trunk/WebCore

2010-05-17 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Implement more parser states in HTML5Tokenizer
​https://bugs.webkit.org/show_bug.cgi?id=39265

This patch implements some easy states. I'll come back and do the
harder states later.

  • html/HTML5Tokenizer.cpp: (WebCore::HTML5Tokenizer::tokenize): (WebCore::HTML5Tokenizer::emitParseError):
  • html/HTML5Tokenizer.h:
10:11 PM Changeset in webkit [59652] by tkent@chromium.org
  • 8 edits in trunk

2010-05-17 Daniel Cheng <​dcheng@chromium.org>

DragData::asURL() shouldn't do file validity checks
​https://bugs.webkit.org/show_bug.cgi?id=38711

Several layout tests depended on the fact that dropping a file would
never trigger navigation. This never happened to occur in the past,
since it just so happened that the filenames used in the tests never
resolved to files that exist. Since DragData::asURL() no longer tries
to verify file existence, the layout tests were updated to either
suppress navigation or log any navigation that should occur as part of
the test.

  • editing/pasteboard/file-input-files-access-expected.txt:
  • editing/pasteboard/script-tests/file-input-files-access.js: (runTest.window.onbeforeunload): (runTest):
  • http/tests/security/clipboard/script-tests/clipboard-file-access.js:

2010-05-17 Daniel Cheng <​dcheng@chromium.org>

Reviewed by Darin Adler.

DragData::asURL() shouldn't do file validity checks
​https://bugs.webkit.org/show_bug.cgi?id=38711

There's no point to trying to make sure the file is valid in
DragData::asURL(). It's better to ask for forgiveness than to ask for
permission, since asking for permission is prone to race conditions
and results in unnecessary I/O. Consumers of this function either:

  • need to verify the file exists themselves (e.g. the loader)
  • don't care about file validity (rich text drag-and-drop)
  • platform/chromium/DragDataChromium.cpp: (WebCore::DragData::asURL):

2010-05-17 Daniel Cheng <​dcheng@chromium.org>

Reviewed by Darin Adler.

DragData::asURL() shouldn't do file validity checks
​https://bugs.webkit.org/show_bug.cgi?id=38711

Change [NSPasteboard _web_bestURL] to still return a file URL for paths
that don't exist. Callers who care about the existence of the file or
whether or not it is a directory should check themselves when they
want to use the file. The directory check has been left in for now,
since the Mac implementation of ResourceHandle, which uses this function
indirectly via DragController::performDrag) handles directories somewhat
non-intuitively: it opens the parent directory in the Finder, rather
than opening the directory itself.

  • Misc/WebNSPasteboardExtras.mm: (-[NSPasteboard _web_bestURL]):
10:05 PM Changeset in webkit [59651] by tkent@chromium.org
  • 6 edits in trunk

Unreviewed. Roll out r59650.
A workaround of a buildbot issue triggered by r59650 wasn't resolved by r59646.

9:56 PM Changeset in webkit [59650] by tkent@chromium.org
  • 6 edits in trunk

[DRT/Chromium] Fix repaint, WebGL, textarea tests
​https://bugs.webkit.org/show_bug.cgi?id=39054

Reviewed by Dimitri Glazkov.

WebKit/chromium:

  • DEPS: Update to Chromium r47248 to use a fix for CommandLine assertion and textAreaResizeCorner.png
  • WebKit.gyp: Add textAreaResizeCorner.png as a Mac resource
  • features.gypi: Enable ENABLE_3D_CANVAS.

WebKitTools:

  • DumpRenderTree/chromium/WebViewHost.cpp:

(WebViewHost::canvas): Remove m_paintRect initialization in canvas().

This line updated m_paintRect unexpectedly during paintRect().
We don't need to initialize m_paintRect because show() does it.

9:46 PM Changeset in webkit [59649] by yuzo@google.com
  • 1 edit
    2 adds in trunk/LayoutTests

2010-05-16 Yuzo Fujishima <​yuzo@google.com>

Reviewed by Darin Adler.

Add tests for Bug 31267 - :nth-child(-2n) should match no element.
​http://trac.webkit.org/changeset/58300 has fixed this already.
​https://bugs.webkit.org/show_bug.cgi?id=31267

  • fast/css/nth-child-negative-a-param-expected.txt: Added.
  • fast/css/nth-child-negative-a-param.html: Added.
9:27 PM Changeset in webkit [59648] by abarth@webkit.org
  • 3 edits in trunk/WebCore

2010-05-17 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Update states in HTML5Tokenizer to match HTML5 spec
​https://bugs.webkit.org/show_bug.cgi?id=39264

I've also implemented the DataState. More states to follow.

  • html/HTML5Tokenizer.cpp: (WebCore::HTML5Tokenizer::reset): (WebCore::HTML5Tokenizer::tokenize):
  • html/HTML5Tokenizer.h: (WebCore::HTML5Tokenizer::):
9:24 PM Changeset in webkit [59647] by tkent@chromium.org
  • 3 edits in trunk/LayoutTests

Unreviewed.

Update a test for the behavior change of r59645.
​https://bugs.webkit.org/show_bug.cgi?id=39162

  • fast/forms/script-tests/willvalidate.js:
  • fast/forms/willvalidate-expected.txt:
9:04 PM Changeset in webkit [59646] by tkent@chromium.org
  • 2 edits in trunk/WebKitTools

Chromium Windows build system does not rebuild correctly when
enabling/disabling a feature
​https://bugs.webkit.org/show_bug.cgi?id=38926

Reviewed by David Levin.

Add a workaround of this issue.

  • Scripts/update-webkit: Chromium-Windows only: If WebKit/chromium/features.gyp has been updated, remove WebKit/chromium/Debug and WebKit/chromium/Release.
8:57 PM Changeset in webkit [59645] by tkent@chromium.org
  • 7 edits in trunk

':valid' CSS selector should not be applied to some form controls
​https://bugs.webkit.org/show_bug.cgi?id=39162

Reviewed by Darin Adler.

WebCore:

  • html/HTMLElement.cpp:

(WebCore::inlineTagList): Always includes progressTag. This change is
needed in a case of no ENABLE_PROGRESS_TAG. Without this change and
ENABLE_PROGRESS_TAG, <progress> tags disappear.

  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::recalcWillValidate):

Return false for SUBMIT and IMAGE.

  • html/HTMLProgressElement.h:

(WebCore::HTMLProgressElement::recalcWillValidate):

Return false. This change is needed in a case of ENABLE_PROGRESS_TAG.

LayoutTests:

Add test cases for

  • <input type=submit>
  • <input type=image>
  • <progress>
  • <meter>
  • fast/css/pseudo-valid-unapplied-expected.txt:
  • fast/css/pseudo-valid-unapplied.html:
8:41 PM Changeset in webkit [59644] by abarth@webkit.org
  • 3 edits in trunk/WebCore

2010-05-17 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Remove load-related code from HTML5Tokenizer
​https://bugs.webkit.org/show_bug.cgi?id=39263

This code is related to reloading resources and not to tokenizing. In
the PreloadScanner, these concerns are coupled, but we want to decouple
them.

  • html/HTML5Tokenizer.cpp: (WebCore::HTML5Tokenizer::HTML5Tokenizer): (WebCore::HTML5Tokenizer::~HTML5Tokenizer): (WebCore::HTML5Tokenizer::begin): (WebCore::HTML5Tokenizer::end): (WebCore::HTML5Tokenizer::reset): (WebCore::HTML5Tokenizer::write): (WebCore::HTML5Tokenizer::consumeEntity): (WebCore::HTML5Tokenizer::tokenize): (WebCore::HTML5Tokenizer::processAttribute): (WebCore::HTML5Tokenizer::emitCharacter): (WebCore::HTML5Tokenizer::emitTag):
  • html/HTML5Tokenizer.h:
8:25 PM Changeset in webkit [59643] by abarth@webkit.org
  • 2 edits in trunk/WebCore

2010-05-17 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Add HTML5Tokenizer to the build system on Mac
​https://bugs.webkit.org/show_bug.cgi?id=39262

This file will be easier to work with if we're actually compiling it.
Hopefully we'll get this wired into the PreloadScanner soon. Once we
start actually calling the code, we'll add it to the build system on
other platforms.

  • WebCore.xcodeproj/project.pbxproj:
8:24 PM Changeset in webkit [59642] by barraclough@apple.com
  • 2 edits in trunk/JavaScriptCore

Oops, meant ebx not eax there. Fix Qt (and probably Win too).

Reviewed by Geoff Garen.

  • jit/JITOpcodes32_64.cpp:
8:21 PM Changeset in webkit [59641] by eric@webkit.org
  • 3 edits in trunk/WebCore

2010-05-17 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Copy PreloadScanner.* to HTML5Tokenizer.* to start work on the new HTML5 Tokenizer
​https://bugs.webkit.org/show_bug.cgi?id=39261

  • html/HTML5Tokenizer.cpp: Rename PreloadScanner to HTML5Tokenizer.
  • html/HTML5Tokenizer.h: ditto.
8:15 PM Changeset in webkit [59640] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-05-17 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Copy PreloadScanner.* to HTML5Tokenizer.* to start work on the new HTML5 Tokenizer
​https://bugs.webkit.org/show_bug.cgi?id=39261

This time copy the cpp from the right file.

  • html/HTML5Tokenizer.cpp: Copied from WebCore/html/PreloadScanner.cpp.
8:08 PM Changeset in webkit [59639] by eric@webkit.org
  • 1 edit
    2 adds in trunk/WebCore

2010-05-17 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Copy PreloadScanner.* to HTML5Tokenizer.* to start work on the new HTML5 Tokenizer
​https://bugs.webkit.org/show_bug.cgi?id=39261

  • html/HTML5Tokenizer.cpp: Copied from WebCore/html/PreloadScanner.h.
  • html/HTML5Tokenizer.h: Copied from WebCore/html/PreloadScanner.h.
8:06 PM Changeset in webkit [59638] by abarth@webkit.org
  • 1 edit
    21 adds in trunk/LayoutTests

2010-05-17 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Add the html5lib HTML parser tests
​https://bugs.webkit.org/show_bug.cgi?id=39260

We currently fail a bunch of these. Hopefully we'll get better as we
implement the HTML5 parser.

Source: ​http://gsnedders.html5.org/html5lib-tests/runner.html

  • html5lib/resources/dom2string.js: Added. (String.prototype.toAsciiLowerCase): (indent): (dom2string):
  • html5lib/resources/tests1.dat: Added.
  • html5lib/resources/tests10.dat: Added.
  • html5lib/resources/tests11.dat: Added.
  • html5lib/resources/tests12.dat: Added.
  • html5lib/resources/tests13.dat: Added.
  • html5lib/resources/tests14.dat: Added.
  • html5lib/resources/tests15.dat: Added.
  • html5lib/resources/tests16.dat: Added.
  • html5lib/resources/tests2.dat: Added.
  • html5lib/resources/tests3.dat: Added.
  • html5lib/resources/tests4.dat: Added.
  • html5lib/resources/tests5.dat: Added.
  • html5lib/resources/tests6.dat: Added.
  • html5lib/resources/tests7.dat: Added.
  • html5lib/resources/tests8.dat: Added.
  • html5lib/resources/tests9.dat: Added.
  • html5lib/runner-expected.txt: Added.
  • html5lib/runner.html: Added.
7:39 PM Changeset in webkit [59637] by barraclough@apple.com
  • 20 edits in trunk/JavaScriptCore

Bug 39252 - Move host/native JSFunction's NativeFunction onto NativeExecutable.

Reviewed by Geoff Garen.

Currently host functions reuse JSFunction's ScopeChain as storage for their
NativeFunction (the C function pointer to the host function implementation).
Instead, move this onto NativeExecutable. This will allow host functions to
have a scopechain (which will be implemented as a separate patch).

  • JavaScriptCore.xcodeproj/project.pbxproj:
  • jit/JIT.h:
  • jit/JITCall.cpp:

(JSC::JIT::compileOpCallInitializeCallFrame):
(JSC::JIT::compileOpCall):

  • jit/JITOpcodes.cpp:

(JSC::JIT::privateCompileCTIMachineTrampolines):

  • jit/JITOpcodes32_64.cpp:
  • jit/JITPropertyAccess.cpp:

(JSC::JIT::stringGetByValStubGenerator):
(JSC::JIT::emitSlow_op_get_by_val):

  • jit/JITPropertyAccess32_64.cpp:

(JSC::JIT::stringGetByValStubGenerator):
(JSC::JIT::emitSlow_op_get_by_val):

  • jit/JITStubs.cpp:

(JSC::JITThunks::specializedThunk):

  • jit/JITStubs.h:

(JSC::JITThunks::ctiNativeCall):

  • jit/SpecializedThunkJIT.h:

(JSC::SpecializedThunkJIT::finalize):

  • jit/ThunkGenerators.cpp:

(JSC::charCodeAtThunkGenerator):
(JSC::charAtThunkGenerator):
(JSC::fromCharCodeThunkGenerator):
(JSC::sqrtThunkGenerator):
(JSC::powThunkGenerator):

  • jit/ThunkGenerators.h:
  • runtime/Executable.h:

(JSC::NativeExecutable::create):
(JSC::NativeExecutable::function):
(JSC::NativeExecutable::NativeExecutable):
(JSC::JSFunction::nativeFunction):

  • runtime/JSFunction.cpp:

(JSC::JSFunction::JSFunction):
(JSC::JSFunction::~JSFunction):
(JSC::JSFunction::markChildren):
(JSC::JSFunction::getCallData):
(JSC::JSFunction::call):
(JSC::JSFunction::getOwnPropertySlot):
(JSC::JSFunction::getConstructData):
(JSC::JSFunction::construct):

  • runtime/JSFunction.h:

(JSC::JSFunction::scope):

  • runtime/JSGlobalData.h:

(JSC::JSGlobalData::getThunk):

  • runtime/Lookup.cpp:

(JSC::setUpStaticFunctionSlot):

  • runtime/StringConstructor.cpp:

(JSC::StringConstructor::StringConstructor):

6:38 PM Changeset in webkit [59636] by atwilson@chromium.org
  • 4 edits in trunk/WebKitTools

2010-05-17 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r59631.
​http://trac.webkit.org/changeset/59631
​https://bugs.webkit.org/show_bug.cgi?id=39255

chromium canaries can no longer run webkit_tests, suspect this
change. (Requested by atwilson on #webkit).

  • Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
6:28 PM Changeset in webkit [59635] by morrita@google.com
  • 2 edits in trunk/WebCore

2010-05-17 MORITA Hajime <​morrita@google.com>

Reviewed by Kent Tamura.

[Chromium] Windows: Speed of indeterminate progress bar should be constant
​https://bugs.webkit.org/show_bug.cgi?id=39211

No new tests, animation effect can be confirmed only manually.

  • rendering/RenderThemeChromiumWin.cpp: (WebCore::RenderThemeChromiumWin::animationDurationForProgressBar): (WebCore::RenderThemeChromiumWin::paintProgressBar):
5:58 PM Changeset in webkit [59634] by atwilson@chromium.org
  • 2 edits in trunk/WebCore

Unreviewed build fix for Qt and Chromium. Added missing #include in Frame.h.

​https://bugs.webkit.org/show_bug.cgi?id=39147

  • page/Frame.h: Now includes CSSMutableStyleDeclaration.h.
5:19 PM Changeset in webkit [59633] by Simon Fraser
  • 2 edits in trunk/WebCore

2010-05-17 Simon Fraser <Simon Fraser>

Reviewed by Darin Adler.

Remove unused member member from Document
​https://bugs.webkit.org/show_bug.cgi?id=39251

Remove m_associatedHistoryItems from Document; it is never used.

  • dom/Document.h:
5:15 PM Changeset in webkit [59632] by Darin Adler
  • 3 edits in trunk/WebCore

Fix Qt build.

  • page/Frame.cpp:

(WebCore::Frame::setTypingStyle): Move back to make non-inline.

  • page/Frame.h: Removed inline version of setTypingStyle.
5:15 PM Changeset in webkit [59631] by eric@webkit.org
  • 4 edits in trunk/WebKitTools

2010-05-17 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Attempt to make new-run-webkit-tests --help more sane
​https://bugs.webkit.org/show_bug.cgi?id=37836

  • Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
    • Add a FIXME about options.singly and options.batch_size being different.
  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
    • Add support for hidden options.
    • Add option groupings to attempt to simplify --help.
    • Fix a bunch of option helps to start with a capitalized verb.
    • Hide a bunch of options which make no sense to users.
    • Sort options in --help.
  • Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
    • Add tests for option sorting.
4:48 PM Changeset in webkit [59630] by Darin Adler
  • 4 edits in trunk/WebCore

2010-05-14 Darin Adler <Darin Adler>

Reviewed by Brady Eidson.

Frame has many trivial member functions that should be inlined
​https://bugs.webkit.org/show_bug.cgi?id=39147

  • WebCore.base.exp: Export the functions that are now inlined.
  • page/Frame.cpp: (WebCore::Frame::removeEditingStyleFromBodyElement): Removed the body of this function.
  • page/Frame.h: (WebCore::Frame::init): Moved here from .cpp. (WebCore::Frame::loader): Ditto. (WebCore::Frame::redirectScheduler): Ditto. (WebCore::Frame::view): Ditto. (WebCore::Frame::script): Ditto. (WebCore::Frame::document): Ditto. (WebCore::Frame::selection): Ditto. (WebCore::Frame::editor): Ditto. (WebCore::Frame::animation): Ditto. (WebCore::Frame::mark): Ditto. (WebCore::Frame::setMark): Ditto. (WebCore::Frame::zoomFactor): Ditto. (WebCore::Frame::jsStatusBarText): Ditto. (WebCore::Frame::jsDefaultStatusBarText): Ditto. (WebCore::Frame::needsReapplyStyles): Ditto. (WebCore::Frame::typingStyle): Ditto. (WebCore::Frame::setTypingStyle): Ditto. (WebCore::Frame::clearTypingStyle): Ditto. (WebCore::Frame::ownerElement): Ditto. (WebCore::Frame::isDisconnected): Ditto. (WebCore::Frame::setIsDisconnected): Ditto. (WebCore::Frame::excludeFromTextSearch): Ditto. (WebCore::Frame::setExcludeFromTextSearch): Ditto. (WebCore::Frame::inViewSourceMode): Ditto. (WebCore::Frame::setInViewSourceMode): Ditto. (WebCore::Frame::markedTextMatchesAreHighlighted): Ditto. (WebCore::Frame::tree): Ditto. (WebCore::Frame::page): Ditto. (WebCore::Frame::detachFromPage): Ditto. (WebCore::Frame::eventHandler): Ditto. (WebCore::Frame::shouldClose): Ditto.
4:03 PM Changeset in webkit [59629] by andersca@apple.com
  • 11 edits in trunk/WebCore

2010-05-17 Anders Carlsson <​andersca@apple.com>

Reviewed by Sam Weinig.

​https://bugs.webkit.org/show_bug.cgi?id=39247
<rdar://problem/7994707>
Move rarely used data members to the rare structures, thus saving memory.

Move rarely used member variables from StyleInheritedData and StyleVisualData to
StyleRareInheritedData and StyleRareNonInheritedData, namely:

indent, cursorData, m_effectiveZoom, widows and orphans move from StyleInheritedData to StyleRareInheritedData.
m_counterIncrement and m_counterReset move from StyleVisualData to StyleRareNonInheritedData.

  • rendering/style/RenderStyle.cpp: (WebCore::RenderStyle::diff): (WebCore::RenderStyle::addCursor): (WebCore::RenderStyle::setCursorList): (WebCore::RenderStyle::clearCursorList):
  • rendering/style/RenderStyle.h: (WebCore::InheritedFlags::textIndent): (WebCore::InheritedFlags::effectiveZoom): (WebCore::InheritedFlags::counterIncrement): (WebCore::InheritedFlags::counterReset): (WebCore::InheritedFlags::cursors): (WebCore::InheritedFlags::widows): (WebCore::InheritedFlags::orphans): (WebCore::InheritedFlags::setTextIndent): (WebCore::InheritedFlags::setEffectiveZoom): (WebCore::InheritedFlags::setCounterIncrement): (WebCore::InheritedFlags::setCounterReset): (WebCore::InheritedFlags::setWidows): (WebCore::InheritedFlags::setOrphans):
  • rendering/style/StyleInheritedData.cpp: (WebCore::StyleInheritedData::StyleInheritedData): (WebCore::StyleInheritedData::operator==):
  • rendering/style/StyleInheritedData.h:
  • rendering/style/StyleRareInheritedData.cpp: (WebCore::StyleRareInheritedData::StyleRareInheritedData): (WebCore::cursorDataEquivalent): (WebCore::StyleRareInheritedData::operator==):
  • rendering/style/StyleRareInheritedData.h:
  • rendering/style/StyleRareNonInheritedData.cpp: (WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData): (WebCore::StyleRareNonInheritedData::operator==):
  • rendering/style/StyleRareNonInheritedData.h:
  • rendering/style/StyleVisualData.cpp: (WebCore::StyleVisualData::StyleVisualData):
  • rendering/style/StyleVisualData.h: (WebCore::StyleVisualData::operator==):
3:25 PM Changeset in webkit [59628] by jamesr@google.com
  • 6 edits
    4 adds in trunk/LayoutTests

2010-05-17 James Robinson <​jamesr@chromium.org>

Reviewed by Darin Adler.

Rebaseline fast/multicol pixel results on mac
​https://bugs.webkit.org/show_bug.cgi?id=39241

  • fast/multicol/client-rects-expected.checksum:
  • fast/multicol/client-rects-expected.png:
  • platform/mac/fast/multicol/float-multicol-expected.png:
  • platform/mac/fast/multicol/layers-in-multicol-expected.checksum: Added.
  • platform/mac/fast/multicol/layers-in-multicol-expected.png: Added.
  • platform/mac/fast/multicol/nested-columns-expected.checksum: Added.
  • platform/mac/fast/multicol/nested-columns-expected.png: Added.
  • platform/mac/fast/multicol/positioned-with-constrained-height-expected.checksum:
  • platform/mac/fast/multicol/positioned-with-constrained-height-expected.png:
3:21 PM Changeset in webkit [59627] by atwilson@chromium.org
  • 8 edits
    6 adds in trunk/LayoutTests

Unreviewed. Update Chromium test expectations.

  • platform/chromium-linux/fast/multicol/layers-in-multicol-expected.checksum:
  • platform/chromium-linux/fast/multicol/layers-in-multicol-expected.png:
  • platform/chromium-linux/fast/multicol/nested-columns-expected.checksum: Added.
  • platform/chromium-linux/fast/multicol/nested-columns-expected.png: Added.
  • platform/chromium-mac/fast/multicol/layers-in-multicol-expected.checksum:
  • platform/chromium-mac/fast/multicol/layers-in-multicol-expected.png:
  • platform/chromium-mac/fast/multicol/nested-columns-expected.checksum: Added.
  • platform/chromium-mac/fast/multicol/nested-columns-expected.png: Added.
  • platform/chromium-win/fast/multicol/layers-in-multicol-expected.checksum:
  • platform/chromium-win/fast/multicol/layers-in-multicol-expected.png:
  • platform/chromium-win/fast/multicol/layers-in-multicol-expected.txt:
  • platform/chromium-win/fast/multicol/nested-columns-expected.checksum: Added.
  • platform/chromium-win/fast/multicol/nested-columns-expected.png: Added.
1:46 PM QtWebKitTableOfFeatures20 edited by noam.rosenthal@nokia.com
(diff)
1:45 PM Changeset in webkit [59626] by robert@webkit.org
  • 2 edits in trunk/WebCore

2010-05-17 Robert Hogan <​robert@webkit.org>

Rubber-stamped by Eric Seidel.

Fix --no-svg build.

I have no idea where the SVG-dependent include of this file is hidden, but
it is probably better to include it explicitly anyway like V8WorkerContextCustom.cpp.

  • bindings/js/JSWorkerContextCustom.cpp:
1:39 PM Changeset in webkit [59625] by atwilson@chromium.org
  • 1 edit
    1 add in trunk/LayoutTests

Unreviewd: Update Chromium test expectations.

  • platform/chromium-win/fast/multicol/nested-columns-expected.txt: Added.
1:29 PM Changeset in webkit [59624] by hyatt@apple.com
  • 3 edits in trunk

​https://bugs.webkit.org/show_bug.cgi?id=39231

Reviewed by Dan Bernstein.

Fix failures in the RTL portion of fast/multicol/layers-in-multicol.html. Make sure block children of RTL blocks are positioned using
the reduced column width instead of the total content width.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::determineHorizontalPosition):
(WebCore::RenderBlock::nodeAtPoint):
(WebCore::RenderBlock::hitTestContents):
(WebCore::RenderBlock::adjustForColumns):

12:36 PM Changeset in webkit [59623] by robert@webkit.org
  • 7 edits
    4 adds in trunk

2010-05-17 Robert Hogan <​robert@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Disable Icon Database by default in Qt DRT

Unskip:

http/tests/misc/favicon-loads-with-images-disabled.html
http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-in-body.html
http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-deny.html
http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag.html

Qt returns 5 (QNetworkReply::OperationCanceledError) instead of -999 for the XFrameOptions tests,
so update accordingly.

​https://bugs.webkit.org/show_bug.cgi?id=37382

  • platform/qt/Skipped:
  • platform/qt/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-expected.txt: Added. Qt returns 5 instead of -999.
  • platform/qt/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-in-body-expected.txt: Added. Qt returns 5 instead of -999.
  • platform/qt/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-deny-expected.txt: Added. Qt returns 5 instead of -999.

2010-05-17 Robert Hogan <​robert@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Disable Icon Database by default in Qt DRT

Unskip:

http/tests/misc/favicon-loads-with-images-disabled.html
http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-in-body.html
http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-deny.html
http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag.html

​https://bugs.webkit.org/show_bug.cgi?id=37382

Add support for layoutTestController.setIconDatabaseEnabled and layoutTestController.disableImageLoading().
The XFrameOptions tests were failing because of an extra resource load callback for favicon.ico requests.
These extra callbacks are removed by supporting both of the above layoutTestContoller commands.

  • DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::WebPage::resetSettings): (WebCore::DumpRenderTree::DumpRenderTree):
  • DumpRenderTree/qt/DumpRenderTreeQt.h: (WebCore::DumpRenderTree::drtStoragePath):
  • DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::reset): (LayoutTestController::disableImageLoading): (LayoutTestController::setIconDatabaseEnabled):
  • DumpRenderTree/qt/LayoutTestControllerQt.h:
12:33 PM Changeset in webkit [59622] by mrowe@apple.com
  • 12 edits in branches/safari-533-branch

<rdar://problem/7987585> Disable SVG filters.

JavaScriptCore:

  • Configurations/FeatureDefines.xcconfig:

WebCore:

  • Configurations/FeatureDefines.xcconfig:

WebKit/mac:

  • Configurations/FeatureDefines.xcconfig:

WebKit2:

  • Configurations/FeatureDefines.xcconfig:

WebKitLibraries:

  • win/tools/vsprops/FeatureDefines.vsprops:

WebKitTools:

  • Scripts/build-webkit:
12:32 PM Changeset in webkit [59621] by mrowe@apple.com
  • 9 edits in branches/safari-533-branch

<rdar://problem/7987743> Disable Blob.slice.

JavaScriptCore:

  • Configurations/FeatureDefines.xcconfig:

WebCore:

  • Configurations/FeatureDefines.xcconfig:

WebKit/mac:

  • Configurations/FeatureDefines.xcconfig:

WebKit2:

  • Configurations/FeatureDefines.xcconfig:
12:32 PM Changeset in webkit [59620] by mrowe@apple.com
  • 8 edits in branches/safari-533-branch

<rdar://problem/7987750> Disable progress element.

JavaScriptCore:

  • Configurations/FeatureDefines.xcconfig:

WebCore:

  • Configurations/FeatureDefines.xcconfig:

WebKit/mac:

  • Configurations/FeatureDefines.xcconfig:

WebKit2:

  • Configurations/FeatureDefines.xcconfig:
12:09 PM Changeset in webkit [59619] by jpetsovits@rim.com
  • 6 edits
    3 adds in trunk/WebCore

2010-05-17 Jakob Petsovits <​jpetsovits@rim.com>

Reviewed by George Staikos.

[OpenVG] Add support for decoding and drawing images
​https://bugs.webkit.org/show_bug.cgi?id=36072

OpenVG has a maximum image size (how large is
specific to the OpenVG implementation), so this
requires us to store them as separate image tiles.

Image decoding and initial drawing code by
Adam Treat <​atreat@rim.com>. Image decoder
downsampling support by Yong Li <​yoli@rim.com>.

  • platform/graphics/ImageSource.h:
  • platform/graphics/openvg/ImageOpenVG.cpp: Added. (WebCore::FrameData::clear): (WebCore::BitmapImage::BitmapImage): (WebCore::BitmapImage::checkForSolidColor): (WebCore::BitmapImage::initPlatformData): (WebCore::BitmapImage::invalidatePlatformData): (WebCore::adjustSourceRectForDownSampling): (WebCore::BitmapImage::draw): (WebCore::Image::drawPattern): (WebCore::Image::loadPlatformResource):
  • platform/graphics/openvg/PainterOpenVG.cpp: (WebCore::PainterOpenVG::drawImage): (WebCore::PainterOpenVG::asNewNativeImage):
  • platform/graphics/openvg/PainterOpenVG.h:
  • platform/graphics/openvg/TiledImageOpenVG.cpp: Added. (WebCore::TiledImageOpenVG::TiledImageOpenVG): (WebCore::TiledImageOpenVG::operator=): (WebCore::TiledImageOpenVG::~TiledImageOpenVG): (WebCore::TiledImageOpenVG::numTiles): (WebCore::TiledImageOpenVG::numColumns): (WebCore::TiledImageOpenVG::numRows): (WebCore::TiledImageOpenVG::setTile): (WebCore::TiledImageOpenVG::tilesInRect): (WebCore::TiledImageOpenVG::tile): (WebCore::TiledImageOpenVG::tileRect): (WebCore::TiledImageOpenVG::detachTiles): (WebCore::TiledImageOpenVG::destroyTiles):
  • platform/graphics/openvg/TiledImageOpenVG.h: Added. (WebCore::TiledImageOpenVG::size): (WebCore::TiledImageOpenVG::maxTileSize):
  • platform/graphics/openvg/VGUtils.cpp: (WebCore::VGUtils::bytesForImage): (WebCore::VGUtils::bytesForImageScanline): (WebCore::VGUtils::imageFormatBitsPerPixel): (WebCore::VGUtils::endianAwareImageFormat):
  • platform/graphics/openvg/VGUtils.h:
  • platform/image-decoders/openvg/ImageDecoderOpenVG.cpp: Added. (WebCore::RGBA32Buffer::asNewNativeImage):
11:42 AM Changeset in webkit [59618] by yaar@chromium.org
  • 3 edits in trunk/WebCore

2010-05-17 Yaar Schnitman <​yaar@chromium.org>

Reviewed by Darin Adler.

Fix JSC's generation of 'Optional' arguments. When a single 'Optional' extended attribute precedes multiple method arguments, all of these arguments are optional as a group (either all or non must be specified). This fix, which makes JSC compliant with V8 and with the Web IDL specs, is pretty harmless, since Optional is currently not being used anywhere in JSC, but it blocks further work on overloads.
​https://bugs.webkit.org/show_bug.cgi?id=39227

  • bindings/scripts/CodeGeneratorJS.pm:
  • bindings/scripts/test/JS/JSTestObj.cpp: (WebCore::jsTestObjPrototypeFunctionMethodWithNonOptionalArgAndTwoOptionalArgs):
11:05 AM Changeset in webkit [59617] by weinig@apple.com
  • 2 edits in trunk/WebCore

​https://bugs.webkit.org/show_bug.cgi?id=39192
Remove unused PERFECT_HASH code CodeGeneratorJS.

Reviewed by Adam Barth.

  • bindings/scripts/CodeGeneratorJS.pm:
10:57 AM Changeset in webkit [59616] by hyatt@apple.com
  • 1 edit
    2 adds in trunk/LayoutTests

Add a test of columns inside columns. The test also puts a RenderLayer in the 2nd column of the 2nd column
to make sure layer positioning works across nested columns.

Reviewed by Dan Bernstein.

  • fast/multicol/nested-columns.html: Added.
  • platform/mac/fast/multicol/nested-columns-expected.txt: Added.
10:54 AM Changeset in webkit [59615] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-05-17 Jeremy Moskovich <​jeremy@chromium.org>

Reviewed by Jeremy Orlow.

Remove debug code that was introduced to help narrow down the
source of a crash.
​https://bugs.webkit.org/show_bug.cgi?id=36426

No change in behavior, so no new tests.

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::finishedLoadingDocument):
10:43 AM Changeset in webkit [59614] by eric@webkit.org
  • 4 edits in trunk/WebKit/qt

2010-05-17 Tasuku Suzuki <​tasuku.suzuki@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Fix compilation with QT_NO_COMBOBOX
​https://bugs.webkit.org/show_bug.cgi?id=38324

  • WebCoreSupport/ChromeClientQt.cpp: (WebCore::ChromeClientQt::createSelectPopup):
  • WebCoreSupport/QtFallbackWebPopup.cpp:
  • WebCoreSupport/QtFallbackWebPopup.h:
10:32 AM Changeset in webkit [59613] by eric@webkit.org
  • 6 edits
    3 adds in trunk

2010-05-17 Andreas Kling <​andreas.kling@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

Add a test to verify proper behavior of createImageData(ImageData)
and createImageData(width, height) with negative arguments.
​https://bugs.webkit.org/show_bug.cgi?id=39189

Spec link:
​http://www.whatwg.org/specs/web-apps/current-work/#dom-context-2d-createimagedata

  • fast/canvas/canvas-createImageData-expected.txt: Added.
  • fast/canvas/canvas-createImageData.html: Added.
  • fast/canvas/script-tests/canvas-createImageData.js: Added.

2010-05-17 Andreas Kling <​andreas.kling@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

Bring CanvasRenderingContext2D's createImageData() in line with HTML5 spec
Added createImageData(ImageData) which returns a new ImageData with the same size as the one passed.
Changed createImageData(width, height) to use the absolute values of width and height.

​https://bugs.webkit.org/show_bug.cgi?id=39189

Spec link:
​http://www.whatwg.org/specs/web-apps/current-work/#dom-context-2d-createimagedata

Test: fast/canvas/canvas-createImageData.html

  • bindings/js/JSCanvasRenderingContext2DCustom.cpp: (WebCore::JSCanvasRenderingContext2D::createImageData):
  • html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::createImageData):
  • html/canvas/CanvasRenderingContext2D.h:
  • html/canvas/CanvasRenderingContext2D.idl:
8:37 AM Changeset in webkit [59612] by antti.j.koivisto@nokia.com
  • 2 edits in trunk/WebCore

This was missing from previous commit.

  • platform/qt/QWebPageClient.h:

(QWebPageClient::graphicsItemVisibleRect):

8:34 AM Changeset in webkit [59611] by antti.j.koivisto@nokia.com
  • 11 edits in trunk

​https://bugs.webkit.org/show_bug.cgi?id=39218
[Qt] Tiled backing store tiles sometimes flicker when exiting a zoom animation

Reviewed by Kenneth Rohde Christiansen.

WebCore:

Tiles sometimes flicker when exiting a zoom animation. This happens as a result
of the visible rectangle being momentarily out of sync.

Instead of updating the visible rect by explicitly setting it, pull it through
the client and recompute in the WebKit level.

  • page/ChromeClient.h:

(WebCore::ChromeClient::visibleRectForTiledBackingStore):

  • page/Frame.cpp:

(WebCore::Frame::tiledBackingStoreVisibleRect):

  • page/Frame.h:
  • platform/graphics/TiledBackingStore.cpp:

(WebCore::TiledBackingStore::checkVisibleRectChanged):
(WebCore::TiledBackingStore::createTiles):

  • platform/graphics/TiledBackingStore.h:
  • platform/graphics/TiledBackingStoreClient.h:

WebKit/qt:

Tiles sometimes flicker when exiting a zoom animation. This happens as a result
of the visible rectangle being momentarily out of sync.

Instead of updating the visible rect by explicitly setting it, pull it through
the client and recompute in WebKit the level.

  • Api/qgraphicswebview.cpp:

(QGraphicsWebView::paint):

  • WebCoreSupport/ChromeClientQt.cpp:

(WebCore::ChromeClientQt::visibleRectForTiledBackingStore):

  • WebCoreSupport/ChromeClientQt.h:
8:04 AM Changeset in webkit [59610] by Adam Roben
  • 3 edits
    1 add in trunk/WebCore

Periodically try to reset a lost IDirect3DDevice9 until we succeed

This is how MSDN says we must respond to a lost device (see
<​http://msdn.microsoft.com/en-us/library/bb174714(v=VS.85).aspx>).

Only testable by a manual test, unfortunately.

Fixes <rdar://problem/7986906> <​http://webkit.org/b/39139> Pages that
use hardware acceleration don't repaint after waking computer from
sleep

Reviewed by John Sullivan.

  • manual-tests/no-repaint-after-wake-from-sleep.html: Added. This is

the Poster Circle demo from webkit.org/blog, but with instructions for
putting the computer to sleep and waking it up again.

  • platform/graphics/win/WKCACFLayerRenderer.cpp:

(WebCore::WKCACFLayerRenderer::WKCACFLayerRenderer): Initialize new
member that tells us whether we need to try to reset the device before
rendering.
(WebCore::WKCACFLayerRenderer::resize): Changed to tell resetDevice
the reason why the device needs to be reset (which is because the
window's size has changed).
(WebCore::WKCACFLayerRenderer::render): Before we do anything else,
check if we need to reset the device before rendering. If we do, try
to reset it. If that fails, bail out and set a timer to try again
later. If we discover that the device is lost when calling
IDirect3DDevice9::Present and resetting the device fails, bail out and
set a timer to try again later.
(WebCore::WKCACFLayerRenderer::resetDevice): Changed to return a
boolean indicating whether resetting succeeded or not. Added a
ResetReason parameter so callers can specify whey the device needs to
be reset. Before trying to do anything, we call
IDirect3DDevice9::TestCooperativeLevel to find out whether the device
can be reset currently. If it can't, we set a flag to tell ourselves
that the device must be reset before we next render, and indicate to
the caller that the reset failed. If we thought the device was lost
but it turns out not to be, we don't have to do anything and can tell
the caller that the reset succeeded. Otherwise we go ahead and reset
the device as before, and indicate to the caller that the reset
succeeded.

  • platform/graphics/win/WKCACFLayerRenderer.h: Changed resetDevice to

return a boolean and take a ResetReason parameter. Added a comment
about when and why this function should be called. And added
m_mustResetLostDeviceBeforeRendering.

8:04 AM Changeset in webkit [59609] by Adam Roben
  • 2 edits in trunk/WebCore

Call CARenderOGLPurge whenever we call IDirect3DDevice9::Reset

MSDN says that all resoures allocated with D3DPOOL_DEFAULT must be
destroyed before calling IDirect3DDevice9::Reset. The only way to
guarantee this with Core Animation is to call CARenderOGLPurge.

Unfortunately this isn't testable at the moment, as we don't use any
features of Core Animation (e.g., mask layers) that actually make this
required. But it seems like a good idea to fix the code now so that
if/when we do start using those features we won't run into problems.

Fixes <​http://webkit.org/b/39159> WKCACFLayerRenderer::resetDevice
might fail due to failing to destroy all D3DPOOL_DEFAULT resources

Reviewed by John Sullivan.

  • platform/graphics/win/WKCACFLayerRenderer.cpp:

(WebCore::WKCACFLayerRenderer::render): Moved the call to
CARenderOGLPurge from here...
(WebCore::WKCACFLayerRenderer::resetDevice): ...to here, so that it
will be called whenever we reset the device (e.g., when resizing the
window).

7:42 AM Changeset in webkit [59608] by kov@webkit.org
  • 2 edits in trunk/WebCore

2010-05-17 Gustavo Noronha Silva <​gustavo.noronha@collabora.co.uk>

Rubber-stamped by Xan Lopez.

Build fix. Remove bashism from build system.

  • GNUmakefile.am:
7:25 AM Changeset in webkit [59607] by yurys@chromium.org
  • 3 edits in trunk/WebCore

2010-05-17 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r59483.
​http://trac.webkit.org/changeset/59483
​https://bugs.webkit.org/show_bug.cgi?id=39215

"page_cycler_intl1 regression on Linux" (Requested by yurys on
#webkit).

  • platform/chromium/ChromiumBridge.h:
  • platform/graphics/chromium/FontCacheLinux.cpp: (WebCore::FontCache::getFontDataForCharacters):
6:49 AM Changeset in webkit [59606] by kenneth@webkit.org
  • 2 edits in trunk/WebCore

REGRESSION(59563): [Qt] JSValue QtClass::fallbackObject can be optimized

Reviewed by Laszlo Gombos.

Patch declared a variable index, which shadowed an earlier declared
variable.

  • bridge/qt/qt_class.cpp:

(JSC::Bindings::QtClass::fallbackObject):

6:33 AM Changeset in webkit [59605] by jorlow@chromium.org
  • 3 edits in trunk/WebCore

2010-05-14 Andrei Popescu <​andreip@google.com>

Reviewed by Jeremy Orlow.

IDBRequest is not a proper ActiveDomObject
​https://bugs.webkit.org/show_bug.cgi?id=39001

Add IDBRequest interface to the IsActiveDomType
routine of the CodeGeneratorV8.pm.

Rename IDBRequest::m_stopped to m_suspended and reset
the flag when resume() is called.

No new tests, Indexed Database isn't yet testable.

  • bindings/scripts/CodeGeneratorV8.pm:
  • storage/IDBRequest.cpp: (WebCore::IDBRequest::suspend): (WebCore::IDBRequest::resume): (WebCore::IDBRequest::timerFired): (WebCore::IDBRequest::onEventCommon):
  • storage/IDBRequest.h:
6:22 AM Changeset in webkit [59604] by xan@webkit.org
  • 2 edits in trunk/WebCore

2010-05-17 Xan Lopez <​xlopez@igalia.com>

Do not include the indexed database headers if the feature is not
enabled. Should fix the build in GTK+.

  • bindings/js/JSEventCustom.cpp:
5:55 AM Changeset in webkit [59603] by xan@webkit.org
  • 2 edits in trunk/WebCore

2010-05-17 Xan Lopez <​xlopez@igalia.com>

Try to fix GTK+ build.

  • GNUmakefile.am:
4:20 AM Changeset in webkit [59602] by jorlow@chromium.org
  • 30 edits
    12 copies
    2 moves
    6 adds in trunk

2010-05-14 Jeremy Orlow <​jorlow@chromium.org>

Reviewed by Nate Chapin.

Finish up IndexedDB events
​https://bugs.webkit.org/show_bug.cgi?id=39117

Add the beginnings of a test for IndexedDB. It currently fails, but we'll
update this (and/or add other tests) as things start passing.

Disable it on all !Chromium platforms since none of them compile it
in. (Note that Chromium keeps it behind a runtime flag at the moment,
despite compiling it in...so don't worry.)

This also makes evalAndLog return the result of the evaluation. I think
this was just an oversight when I originally added it, and it's going to
come in useful for these tests.

  • fast/js/resources/js-test-pre.js: (evalAndLog):
  • platform/gtk/Skipped:
  • platform/mac-leopard/Skipped:
  • platform/mac-snowleopard/Skipped:
  • platform/mac-tiger/Skipped:
  • platform/mac/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:
  • storage/indexeddb/basics-expected.txt: Added.
  • storage/indexeddb/basics.html: Added.
  • storage/indexeddb/script-tests/TEMPLATE.html: Copied from LayoutTests/storage/domstorage/script-tests/TEMPLATE.html.
  • storage/indexeddb/script-tests/basics.js: Added. (eventShared): (successFunction): (errorFunction): (test):

2010-05-14 Jeremy Orlow <​jorlow@chromium.org>

Reviewed by Nate Chapin.

Finish up IndexedDB events
​https://bugs.webkit.org/show_bug.cgi?id=39117

Implement the indexed database event interfaces as proposed by Mozilla.
Refactor the run time type detection code that was in IDBRequest into its own
class named IDBAny. Use this new class within the new event classes and
IDBResults.

Test: storage/indexeddb/basics.html

  • DerivedSources.cpp:
  • DerivedSources.make:
  • GNUmakefile.am:
  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:
  • WebCore.pri:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSEventCustom.cpp: (WebCore::toJS):
  • bindings/js/JSEventTarget.cpp: (WebCore::toJS):
  • bindings/js/JSIDBAnyCustom.cpp: Added. (WebCore::toJS):
  • bindings/js/JSIDBRequestCustom.cpp: Removed.
  • bindings/v8/custom/V8EventCustom.cpp: (WebCore::toV8):
  • bindings/v8/custom/V8IDBAnyCustom.cpp: Added. (WebCore::toV8):
  • bindings/v8/custom/V8IDBRequestCustom.cpp: Removed.
  • dom/Event.cpp: (WebCore::Event::isIDBErrorEvent): (WebCore::Event::isIDBSuccessEvent):
  • dom/Event.h:
  • storage/IDBAny.cpp: Added. (WebCore::IDBAny::create): (WebCore::IDBAny::IDBAny): (WebCore::IDBAny::~IDBAny): (WebCore::IDBAny::idbDatabaseRequest): (WebCore::IDBAny::indexedDatabaseRequest): (WebCore::IDBAny::serializedScriptValue): (WebCore::IDBAny::set):
  • storage/IDBAny.h: Added. (WebCore::IDBAny::): (WebCore::IDBAny::type):
  • storage/IDBAny.idl: Added.
  • storage/IDBErrorEvent.cpp: Added. (WebCore::IDBErrorEvent::create): (WebCore::IDBErrorEvent::IDBErrorEvent): (WebCore::IDBErrorEvent::~IDBErrorEvent):
  • storage/IDBErrorEvent.h: Added. (WebCore::IDBErrorEvent::code): (WebCore::IDBErrorEvent::message): (WebCore::IDBErrorEvent::isIDBErrorEvent):
  • storage/IDBErrorEvent.idl: Added.
  • storage/IDBEvent.cpp: Added. (WebCore::IDBEvent::IDBEvent): (WebCore::IDBEvent::~IDBEvent): (WebCore::IDBEvent::source):
  • storage/IDBEvent.h: Added.
  • storage/IDBEvent.idl: Added.
  • storage/IDBRequest.cpp: (WebCore::IDBRequest::IDBRequest): (WebCore::IDBRequest::onSuccess): (WebCore::IDBRequest::timerFired): (WebCore::IDBRequest::onEventCommon):
  • storage/IDBRequest.h: (WebCore::IDBRequest::create): (WebCore::IDBRequest::result):
  • storage/IDBRequest.idl:
  • storage/IDBSuccessEvent.cpp: Added. (WebCore::IDBSuccessEvent::create): (WebCore::IDBSuccessEvent::IDBSuccessEvent): (WebCore::IDBSuccessEvent::~IDBSuccessEvent): (WebCore::IDBSuccessEvent::result):
  • storage/IDBSuccessEvent.h: Added. (WebCore::IDBSuccessEvent::isIDBSuccessEvent):
  • storage/IDBSuccessEvent.idl: Added.
  • storage/IndexedDatabaseImpl.cpp: (WebCore::IndexedDatabaseImpl::open):
  • storage/IndexedDatabaseRequest.cpp: (WebCore::IndexedDatabaseRequest::IndexedDatabaseRequest): (WebCore::IndexedDatabaseRequest::open):
  • storage/IndexedDatabaseRequest.h:
1:44 AM Changeset in webkit [59601] by yurys@chromium.org
  • 2 edits
    1 delete in trunk/LayoutTests

2010-05-17 Yury Semikhatsky <​yurys@chromium.org>

Unreviewed. Update Chromium test expectations.

  • platform/chromium-win-xp/fast/multicol/client-rects-expected.txt: Removed.
  • platform/chromium/test_expectations.txt:
1:11 AM Changeset in webkit [59600] by eric@webkit.org
  • 2 edits in trunk/JavaScriptCore

2010-05-17 Patrick Gansterer <​paroga@paroga.com>

Reviewed by Laszlo Gombos.

[Qt] Remove WinCE endian dedection.
​https://bugs.webkit.org/show_bug.cgi?id=38511

Windows CE supports little-endian format only.
Correct dedection was added in r57804.

  • wtf/Platform.h:
1:10 AM Changeset in webkit [59599] by mjs@apple.com
  • 2 edits in trunk/SunSpider

Browser-hosted version of SunSpider runs tests twice as many times as advertised
​https://bugs.webkit.org/show_bug.cgi?id=39201

Reviewed by Mark Rowe.

  • make-hosted: Make sure to reset test list after every test suite.
1:03 AM Changeset in webkit [59598] by Chris Jerdonek
  • 1 edit in trunk/WebCore/ChangeLog

Unreviewed.

Removed the stray equals sign from the reviewer's name in the
"Reviewed by" line of the ChangeLog entry for r59596:

​http://trac.webkit.org/changeset/59596

12:42 AM Changeset in webkit [59597] by yurys@chromium.org
  • 8 edits
    15 adds
    1 delete in trunk/LayoutTests

2010-05-17 Yury Semikhatsky <​yurys@chromium.org>

Unreviewed. Update Chromium test expectations.

  • platform/chromium-linux/fast/loader/recursive-before-unload-crash-expected.txt:
  • platform/chromium-linux/fast/multicol/client-rects-expected.txt: Removed.
  • platform/chromium-linux/fast/multicol/column-count-with-rules-expected.checksum: Added.
  • platform/chromium-linux/fast/multicol/column-count-with-rules-expected.png: Added.
  • platform/chromium-linux/fast/multicol/layers-in-multicol-expected.checksum: Added.
  • platform/chromium-linux/fast/multicol/layers-in-multicol-expected.png: Added.
  • platform/chromium-mac/fast/multicol/column-count-with-rules-expected.checksum: Added.
  • platform/chromium-mac/fast/multicol/column-count-with-rules-expected.png: Added.
  • platform/chromium-mac/fast/multicol/layers-in-multicol-expected.checksum: Added.
  • platform/chromium-mac/fast/multicol/layers-in-multicol-expected.png: Added.
  • platform/chromium-win/fast/canvas/canvas-toDataURL-case-insensitive-mimetype-expected.txt: Added.
  • platform/chromium-win/fast/multicol/client-rects-expected.txt:
  • platform/chromium-win/fast/multicol/column-count-with-rules-expected.checksum: Added.
  • platform/chromium-win/fast/multicol/column-count-with-rules-expected.png: Added.
  • platform/chromium-win/fast/multicol/column-count-with-rules-expected.txt: Added.
  • platform/chromium-win/fast/multicol/column-rules-expected.txt:
  • platform/chromium-win/fast/multicol/columns-shorthand-parsing-expected.txt:
  • platform/chromium-win/fast/multicol/float-avoidance-expected.txt:
  • platform/chromium-win/fast/multicol/float-multicol-expected.txt:
  • platform/chromium-win/fast/multicol/layers-in-multicol-expected.checksum: Added.
  • platform/chromium-win/fast/multicol/layers-in-multicol-expected.png: Added.
  • platform/chromium-win/fast/multicol/layers-in-multicol-expected.txt: Added.
  • platform/chromium-win/fast/multicol/single-line-expected.txt:
12:34 AM Changeset in webkit [59596] by Chris Jerdonek
  • 7 edits in trunk/WebCore

2010-05-16 Chris Jerdonek <Chris Jerdonek>

Reviewed by =Adam Barth.

Refactored FrameLoader::changeLocation() and urlSelected() to share more code.

​https://bugs.webkit.org/show_bug.cgi?id=38827

No change in behavior, so no new tests.

  • bindings/ScriptControllerBase.cpp: (WebCore::ScriptController::executeIfJavaScriptURL):
    • Changed a parameter from boolean to the ShouldReplaceDocumentIfJavaScriptURL enum.
  • bindings/js/ScriptController.h:
    • Changed a parameter from boolean to the ShouldReplaceDocumentIfJavaScriptURL enum.
  • bindings/v8/ScriptController.h:
    • Changed a parameter from boolean to the ShouldReplaceDocumentIfJavaScriptURL enum.
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::changeLocation):
    • Changed to call the new private overload of urlSelected().

(WebCore::FrameLoader::urlSelected):

  • Added a private overload of urlSelected().
  • Changed the public urlSelected() to call the private overload.

(WebCore::FrameLoader::submitForm):

  • loader/FrameLoader.h:
    • Added a private overload of urlSelected().
  • loader/FrameLoaderTypes.h:
    • Added a ShouldReplaceDocumentIfJavaScriptURL enum.
12:06 AM Changeset in webkit [59595] by ukai@chromium.org
  • 7 edits
    1 add in trunk/WebKitTools

2010-05-17 Fumitoshi Ukai <​ukai@chromium.org>

Reviewed by Eric Seidel.

Chromium: Add --chromium option to new-run-webkit-websocketserver
​https://bugs.webkit.org/show_bug.cgi?id=37664

os.environ setup and setup_mount for cygwin are moved in ChromiumWinPort.setup_environ_for_server.

  • Scripts/new-run-webkit-httpd: Remove passing register_cygwin.
  • Scripts/new-run-webkit-websocketserver: Add --chromium flag. Remove passing register_cygwin. Create port object using options.
  • Scripts/webkitpy/layout_tests/port/base.py: Add setup_environ_for_server().
  • Scripts/webkitpy/layout_tests/port/chromium_win.py: Ditto.
  • Scripts/webkitpy/layout_tests/port/factory_unittest.py: Added.
  • Scripts/webkitpy/layout_tests/port/http_server.py: Remove register_cygwin_parameter. Call setup_environ_for_server().
  • Scripts/webkitpy/layout_tests/port/websocket_server.py: Ditto.

May 16, 2010:

11:10 PM Changeset in webkit [59594] by ukai@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed

Patch by Takeshi Yoshino <​tyoshino@google.com> on 2010-05-16
Update test_expectations.txt for Chromium
fast/loader/recursive-before-unload-crash.html is flaky on Linux and Win
See ​http://code.google.com/p/chromium/issues/detail?id=44229 for detail.

  • platform/chromium/test_expectations.txt:
11:10 PM Changeset in webkit [59593] by dbates@webkit.org
  • 3 edits
    1 add in trunk/WebKitTools

2010-05-16 Daniel Bates <​dbates@rim.com>

Reviewed by Chris Jerdonek.

​https://bugs.webkit.org/show_bug.cgi?id=39184

Adds function VCSUtils::parseSvnProperty to parse an SVN property with
either a single-line or multi-line value change.

  • Scripts/VCSUtils.pm:
    • Added function parseSvnProperty. We will use this function towards resolving Bug #38885 <​https://bugs.webkit.org/show_bug.cgi?id=38885>.
    • Removed FIXME comment above function parseSvnPropertyValue, since it is being used by parseSvnProperty.
    • Modified function parseSvnPropertyValue to break out of "while (<$fileHandle>)" loop when it encounters the start of the next property so that it can be processed by its caller, parseSvnPropertyValue. We reference this bullet below by (*).
  • Scripts/webkitperl/VCSUtils_unittest/parseSvnProperty.pl: Added.
    • Added unit tests.
  • Scripts/webkitperl/VCSUtils_unittest/parseSvnPropertyValue.pl:
    • Changed the name of the unit test "simple multi-line '-' change" to "single-line '-' change followed by empty line" since the former was an incorrect description of this test.
    • Added unit test "single-line '-' change followed by the next property", and "multi-line '-' change followed by the next property" to test (*) above.
9:58 PM Changeset in webkit [59592] by dbates@webkit.org
  • 23 edits
    1 add in trunk/WebCore

2010-05-16 Daniel Bates <​dbates@rim.com>

Reviewed by David Hyatt.

​https://bugs.webkit.org/show_bug.cgi?id=39196

Rollout changeset 59274 <​http://trac.webkit.org/changeset/59274>.

Prepared on behalf of David Hyatt.

"Not worth the memory use." Just roll this out.

  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • editing/visible_units.cpp: (WebCore::previousLinePosition): (WebCore::nextLinePosition):
  • rendering/EllipsisBox.cpp: (WebCore::EllipsisBox::paint): (WebCore::EllipsisBox::selectionRect): (WebCore::EllipsisBox::paintSelection): (WebCore::EllipsisBox::nodeAtPoint):
  • rendering/EllipsisBox.h: (WebCore::EllipsisBox::EllipsisBox): (WebCore::EllipsisBox::height):
  • rendering/InlineBox.cpp: (WebCore::InlineBox::height): (WebCore::InlineBox::adjustPosition): (WebCore::InlineBox::canAccommodateEllipsis):
  • rendering/InlineBox.h: (WebCore::InlineBox::InlineBox): (WebCore::InlineBox::isInlineBox): (WebCore::InlineBox::hasVirtualHeight): (WebCore::InlineBox::setHasVirtualHeight): (WebCore::InlineBox::virtualHeight): (WebCore::InlineBox::setWidth): (WebCore::InlineBox::width): (WebCore::InlineBox::setX): (WebCore::InlineBox::x): (WebCore::InlineBox::setY): (WebCore::InlineBox::y): (WebCore::InlineBox::baselinePosition): (WebCore::InlineBox::lineHeight):
  • rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::placeBoxesVertically): (WebCore::InlineFlowBox::computeVerticalOverflow): (WebCore::InlineFlowBox::nodeAtPoint): (WebCore::InlineFlowBox::paintBoxDecorations): (WebCore::InlineFlowBox::paintMask): (WebCore::InlineFlowBox::paintTextDecorations):
  • rendering/InlineFlowBox.h: (WebCore::InlineFlowBox::visibleOverflowRect): (WebCore::InlineFlowBox::topLayoutOverflow): (WebCore::InlineFlowBox::bottomLayoutOverflow): (WebCore::InlineFlowBox::leftLayoutOverflow): (WebCore::InlineFlowBox::rightLayoutOverflow): (WebCore::InlineFlowBox::layoutOverflowRect): (WebCore::InlineFlowBox::topVisualOverflow): (WebCore::InlineFlowBox::bottomVisualOverflow): (WebCore::InlineFlowBox::leftVisualOverflow): (WebCore::InlineFlowBox::rightVisualOverflow): (WebCore::InlineFlowBox::visualOverflowRect): (WebCore::InlineFlowBox::setHorizontalOverflowPositions): (WebCore::InlineFlowBox::setVerticalOverflowPositions):
  • rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::selectionRect): (WebCore::InlineTextBox::placeEllipsisBox): (WebCore::InlineTextBox::nodeAtPoint): (WebCore::InlineTextBox::paint): (WebCore::InlineTextBox::paintSelection): (WebCore::InlineTextBox::paintCompositionBackground): (WebCore::InlineTextBox::paintDecoration): (WebCore::InlineTextBox::paintSpellingOrGrammarMarker): (WebCore::InlineTextBox::paintTextMatchMarker): (WebCore::InlineTextBox::computeRectForReplacementMarker): (WebCore::InlineTextBox::paintCompositionUnderline): (WebCore::InlineTextBox::offsetForPosition): (WebCore::InlineTextBox::positionForOffset):
  • rendering/InlineTextBox.h: (WebCore::InlineTextBox::setSpaceAdd):
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::positionForPointWithInlineChildren):
  • rendering/RenderBlockLineLayout.cpp: (WebCore::RenderBlock::computeVerticalPositionsForLine): (WebCore::RenderBlock::layoutInlineChildren):
  • rendering/RenderSVGInline.cpp: (WebCore::RenderSVGInline::createInlineFlowBox):
  • rendering/RenderSVGInlineText.cpp: (WebCore::RenderSVGInlineText::createTextBox):
  • rendering/RenderSVGText.cpp: (WebCore::RenderSVGText::createRootInlineBox):
  • rendering/RenderText.cpp: (WebCore::RenderText::positionForPoint): (WebCore::RenderText::firstRunX): (WebCore::RenderText::firstRunY):
  • rendering/RenderTreeAsText.cpp: (WebCore::writeTextRun):
  • rendering/RootInlineBox.cpp: (WebCore::RootInlineBox::placeEllipsis): (WebCore::RootInlineBox::addHighlightOverflow): (WebCore::RootInlineBox::closestLeafChildForXPos):
  • rendering/SVGInlineFlowBox.h: (WebCore::SVGInlineFlowBox::SVGInlineFlowBox): (WebCore::SVGInlineFlowBox::virtualHeight): (WebCore::SVGInlineFlowBox::setHeight):
  • rendering/SVGInlineTextBox.h: (WebCore::SVGInlineTextBox::virtualHeight): (WebCore::SVGInlineTextBox::setHeight): (WebCore::SVGInlineTextBox::selectionTop): (WebCore::SVGInlineTextBox::selectionHeight):
  • rendering/SVGRootInlineBox.h: (WebCore::SVGRootInlineBox::SVGRootInlineBox): (WebCore::SVGRootInlineBox::virtualHeight): (WebCore::SVGRootInlineBox::setHeight):
  • rendering/TrailingFloatsRootInlineBox.h: Added. (WebCore::TrailingFloatsRootInlineBox::TrailingFloatsRootInlineBox): (WebCore::TrailingFloatsRootInlineBox::virtualHeight):
9:08 PM Changeset in webkit [59591] by tony@chromium.org
  • 3 edits
    2 adds in trunk

2010-05-13 Tony Chang <​tony@chromium.org>

Reviewed by Darin Adler.

REGRESSION: Crash by pasting to a textarea with white-space:nowrap
​https://bugs.webkit.org/show_bug.cgi?id=38992

  • editing/pasteboard/paste-plaintext-nowrap-expected.txt: Added.
  • editing/pasteboard/paste-plaintext-nowrap.html: Added.

2010-05-13 Tony Chang <​tony@chromium.org>

Reviewed by Darin Adler.

REGRESSION: Crash by pasting to a textarea with white-space:nowrap
​https://bugs.webkit.org/show_bug.cgi?id=38992

Test: editing/pasteboard/paste-plaintext-nowrap.html

  • editing/InsertParagraphSeparatorCommand.cpp: (WebCore::highestVisuallyEquivalentDivBelowRoot): (WebCore::InsertParagraphSeparatorCommand::doApply):
8:34 PM Changeset in webkit [59590] by hyatt@apple.com
  • 2 edits
    2 adds in trunk

​https://bugs.webkit.org/show_bug.cgi?id=39194

Reviewed by Dan Bernstein.

Fix all of the multi-column painting and hit testing functions to properly account for RTL directionality.

Added fast/multicol/column-count-with-rules.html

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::paintColumnRules):
(WebCore::RenderBlock::paintColumnContents):
(WebCore::RenderBlock::hitTestColumns):
(WebCore::RenderBlock::adjustRectForColumns):

8:03 PM Changeset in webkit [59589] by mitz@apple.com
  • 5 edits in trunk/WebCore

Fix SVG test failures after r59588.

Reviewed by Dave Hyatt.

Updated SVG InlineBox virtual method overrides to match HTML ones. Removed
SVGInlineFlowBox::verticallyAlignBoxes() since InlineFlowBox no longer declares
verticallyAlignBoxes().

  • rendering/SVGInlineFlowBox.cpp:

(WebCore::SVGInlineFlowBox::placeBoxesHorizontally):

  • rendering/SVGInlineFlowBox.h:
  • rendering/SVGRootInlineBox.cpp:

(WebCore::SVGRootInlineBox::placeBoxesHorizontally):
(WebCore::SVGRootInlineBox::verticallyAlignBoxes):

  • rendering/SVGRootInlineBox.h:
6:43 PM Changeset in webkit [59588] by mitz@apple.com
  • 10 edits in trunk/WebCore

Move transient glyph overflow and fallback font data from a global to the stack
​https://bugs.webkit.org/show_bug.cgi?id=39050

Reviewed by Darin Adler.

  • rendering/InlineFlowBox.cpp:

(WebCore::InlineFlowBox::placeBoxesHorizontally): Added a GlyphOverflowAndFallbackFontsMap
parameter. Read glyph overflow from the map.
(WebCore::InlineFlowBox::computeLogicalBoxHeights): Added a GlyphOverflowAndFallbackFontsMap
parameter. Read fallback fonts from the map.
(WebCore::InlineFlowBox::computeVerticalOverflow): Added a GlyphOverflowAndFallbackFontsMap
parameter. Read glyph overflow from the map.

  • rendering/InlineFlowBox.h:
  • rendering/InlineTextBox.cpp: Removed setFallbackFonts(), fallbackFonts(), setGlyphOverflow(),

and glyphOverflow(). Removed s_glyphOverflowAndFallbackFontsMap.

  • rendering/InlineTextBox.h:
  • rendering/RenderBlock.h:
  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::computeHorizontalPositionsForLine): Added a GlyphOverflowAndFallbackFontsMap
parameter. Write fallback fonts and glyph overflow into the map.
(WebCore::RenderBlock::computeVerticalPositionsForLine): Added a GlyphOverflowAndFallbackFontsMap
parameter. Pass it down to verticallyAlignBoxes().
(WebCore::RenderBlock::layoutInlineChildren): Create a GlyphOverflowAndFallbackFontsMap on the
stack and pass it down to computeHorizontalPositionsForLine(), computeVerticalPositionsForLine(),
and verticallyAlignBoxes().

  • rendering/RootInlineBox.cpp:

(WebCore::RootInlineBox::verticallyAlignBoxes): Added a GlyphOverflowAndFallbackFontsMap parameter.
Pass it down to computeLogicalBoxHeights() and computeVerticalOverflow().

  • rendering/RootInlineBox.h:
  • rendering/SVGRootInlineBox.cpp:

(WebCore::SVGRootInlineBox::layoutInlineBoxes): Updated.

6:02 PM Changeset in webkit [59587] by Simon Fraser
  • 2 edits in trunk/JavaScriptCore

2010-05-16 Simon Fraser <Simon Fraser>

Reviewed by Darin Adler.

Reduce the size of FunctionExecutable
​https://bugs.webkit.org/show_bug.cgi?id=39180

Change m_numVariables from a size_t to 31 bits in a bitfield,
packed with another bit for m_forceUsesArguments (which in turn
get packed with the base class).

Reduces the size of FunctionExecutable from 160 to 152 bytes.

  • runtime/Executable.h: (JSC::FunctionExecutable::variableCount): (JSC::FunctionExecutable::FunctionExecutable):
6:00 PM Changeset in webkit [59586] by tony@chromium.org
  • 4 edits
    2 copies
    3 adds in trunk

2010-05-16 Tony Chang <​tony@chromium.org>

Not reviewed, fixing layout test.

Add tiger and SL results. Remove Inspect Element from leopard results.

  • platform/mac-leopard/editing/spelling/context-menu-suggestions-expected.txt:
  • platform/mac-snowleopard/editing/spelling/context-menu-suggestions-expected.txt: Added.
  • platform/mac-tiger/editing/spelling/context-menu-suggestions-expected.txt: Added.

2010-05-16 Tony Chang <​tony@chromium.org>

Not reviewed, fixing layout test.

Don't output Inspect Element since this is not enabled on the bots,
but most developers probably have it installed.

  • DumpRenderTree/mac/EventSendingController.mm: (-[EventSendingController contextClick:]):
5:26 PM Changeset in webkit [59585] by tony@chromium.org
  • 9 edits
    3 adds in trunk

2010-05-12 Tony Chang <​tony@chromium.org>

Reviewed by Darin Adler.

Spellcheck disabling does not disable context menu
​https://bugs.webkit.org/show_bug.cgi?id=25639

  • editing/spelling/context-menu-suggestions.html: Added.
  • platform/chromium/test_expectations.txt:
  • platform/gtk/Skipped:
  • platform/mac-leopard/editing/spelling/context-menu-suggestions-expected.txt: Added.
  • platform/qt/Skipped:
  • platform/win/Skipped:

2010-05-12 Tony Chang <​tony@chromium.org>

Reviewed by Darin Adler.

Spellcheck disabling does not disable context menu
​https://bugs.webkit.org/show_bug.cgi?id=25639

Test: editing/spelling/context-menu-suggestions.html

  • platform/ContextMenu.cpp: (WebCore::ContextMenu::populate):

2010-05-12 Tony Chang <​tony@chromium.org>

Reviewed by Darin Adler.

Spellcheck disabling does not disable context menu
​https://bugs.webkit.org/show_bug.cgi?id=25639

  • DumpRenderTree/mac/EventSendingController.mm: (+[EventSendingController isSelectorExcludedFromWebScript:]): (+[EventSendingController webScriptNameForSelector:]): (-[EventSendingController contextClick:]): add a bool parameter that

when true, dumps the context menu items to stdout.

4:48 PM Changeset in webkit [59584] by crogers@google.com
  • 6 edits in branches/audio/WebCore/audio

compile fixes for Snow Leopard

4:42 PM Changeset in webkit [59583] by weinig@apple.com
  • 2 edits in trunk/WebCore

​https://bugs.webkit.org/show_bug.cgi?id=39190
Shave a word off of GlyphPageTreeNode
<rdar://problem/7990428>

Reviewed by Dan Bernstein.

  • platform/graphics/GlyphPageTreeNode.h:

(WebCore::GlyphPageTreeNode::GlyphPageTreeNode):

2:46 PM Changeset in webkit [59582] by eric@webkit.org
  • 5 edits
    3 adds in trunk

2010-05-16 Andreas Kling <​andreas.kling@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

Add a test to verify proper handling of invalid arguments to getImageData().
Updated old putImageData() test with correct expectations.

​https://bugs.webkit.org/show_bug.cgi?id=39175

Spec link:
​http://www.whatwg.org/specs/web-apps/current-work/#pixel-manipulation

  • fast/canvas/canvas-getImageData-invalid-expected.txt: Added.
  • fast/canvas/canvas-getImageData-invalid.html: Added.
  • fast/canvas/canvas-putImageData-expected.txt:
  • fast/canvas/canvas-putImageData.js:
  • fast/canvas/script-tests/canvas-getImageData-invalid.js: Added.

2010-05-16 Andreas Kling <​andreas.kling@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

Properly handle invalid arguments to CanvasRenderingContext2D's getImageData() and putImageData().
Both should throw NOT_SUPPORTED_ERR when called with nonfinite arguments.
getImageData() should throw INDEX_SIZE_ERR if either width or height is 0.

​https://bugs.webkit.org/show_bug.cgi?id=39175

Spec link:
​http://www.whatwg.org/specs/web-apps/current-work/#pixel-manipulation

Test: fast/canvas/canvas-getImageData-invalid.html

  • html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::createImageData): (WebCore::CanvasRenderingContext2D::getImageData): (WebCore::CanvasRenderingContext2D::putImageData):
2:08 PM Changeset in webkit [59581] by eric@webkit.org
  • 3 edits
    4 adds in trunk

2010-05-16 Andreas Kling <​andreas.kling@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

Add a test to verify that Canvas's toDataURL() is case insensitive wrt the mimeType argument.
​https://bugs.webkit.org/show_bug.cgi?id=39153

Spec link:
​http://www.whatwg.org/specs/web-apps/current-work/#dom-canvas-todataurl

  • fast/canvas/canvas-toDataURL-case-insensitive-mimetype-expected.txt: Added.
  • fast/canvas/canvas-toDataURL-case-insensitive-mimetype.html: Added.
  • fast/canvas/script-tests/canvas-toDataURL-case-insensitive-mimetype.js: Added. (tryMimeType):
  • platform/gtk/fast/canvas/canvas-toDataURL-case-insensitive-mimetype-expected.txt: Added.

2010-05-16 Andreas Kling <​andreas.kling@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

Canvas's toDataURL() should be case insensitive wrt the mimeType argument.
​https://bugs.webkit.org/show_bug.cgi?id=39153

Spec link:
​http://www.whatwg.org/specs/web-apps/current-work/#dom-canvas-todataurl

Test: fast/canvas/canvas-toDataURL-case-insensitive-mimetype.html

  • dom/CanvasSurface.cpp: (WebCore::CanvasSurface::toDataURL):
1:13 PM Changeset in webkit [59580] by robert@webkit.org
  • 14 edits in trunk

[Qt] Fix FrameLoaderClientQt.cpp to print relative filename paths correctly.

2010-05-16 Robert Hogan <​robert@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

Fix FrameLoaderClientQt.cpp to print relative filename paths correctly.

Move qt_* functions in FrameLoaderClientQt, EditorClientQt, and NotificationPresenterClientQt
to DumpRenderTreeSupportQt. Create new functions to replace them in DumpRenderTreeSupportQt.
Support for the old function names is retained until confirmed that no one uses them outside
QtWebKit.

​https://bugs.webkit.org/show_bug.cgi?id=38867

  • WebCoreSupport/DumpRenderTreeSupportQt.cpp: (DumpRenderTreeSupportQt::dumpFrameLoader): (DumpRenderTreeSupportQt::dumpResourceLoadCallbacks): (DumpRenderTreeSupportQt::dumpResourceLoadCallbacksPath): (DumpRenderTreeSupportQt::setWillSendRequestReturnsNullOnRedirect): (DumpRenderTreeSupportQt::setWillSendRequestReturnsNull): (DumpRenderTreeSupportQt::setWillSendRequestClearHeaders): (DumpRenderTreeSupportQt::dumpEditingCallbacks): (DumpRenderTreeSupportQt::dumpSetAcceptsEditing): (DumpRenderTreeSupportQt::dumpNotification): (qt_dump_frame_loader): (qt_dump_resource_load_callbacks): (qt_dump_resource_load_callbacks_path): (qt_set_will_send_request_returns_null_on_redirect): (qt_set_will_send_request_returns_null): (qt_set_will_send_request_clear_headers): (qt_dump_editing_callbacks): (qt_dump_set_accepts_editing): (qt_dump_notification):
  • WebCoreSupport/DumpRenderTreeSupportQt.h:
  • WebCoreSupport/EditorClientQt.cpp:
  • WebCoreSupport/EditorClientQt.h:
  • WebCoreSupport/FrameLoaderClientQt.cpp: (drtDescriptionSuitableForTestResult):
  • WebCoreSupport/FrameLoaderClientQt.h:
  • WebCoreSupport/NotificationPresenterClientQt.cpp:
  • WebCoreSupport/NotificationPresenterClientQt.h:

Update Qt DRT to use frame loader, editor client and notificaiton presenter
functions in DumpRenderTreeSupportQt.

  • DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::DumpRenderTree::open): (WebCore::DumpRenderTree::dump):
  • DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::LayoutTestController): (LayoutTestController::reset): (LayoutTestController::dumpEditingCallbacks): (LayoutTestController::dumpFrameLoadCallbacks): (LayoutTestController::dumpResourceLoadCallbacks): (LayoutTestController::setWillSendRequestReturnsNullOnRedirect): (LayoutTestController::setWillSendRequestReturnsNull): (LayoutTestController::setWillSendRequestClearHeader):

Unskip fast/loader/main-document-url-for-non-http-loads.html

  • platform/qt/Skipped:
11:01 AM Changeset in webkit [59579] by eric@webkit.org
  • 4 edits in trunk

2010-05-16 Mike Belshe <​mbelshe@chromium.org>

Reviewed by Dimitri Glazkov.

Add a flag to the ResourceResponse for tracking if a request was
fetched via the TLS/Next-Protocol-Negotiation mechanism.

Also cleaned up the style in ResourceResponse to group the flags
together (and alphabetically) and hopefully improve readability of
the file.

​https://bugs.webkit.org/show_bug.cgi?id=39078

  • public/WebURLResponse.h:
  • src/WebURLResponse.cpp: (WebKit::WebURLResponse::wasNpnNegotiated): (WebKit::WebURLResponse::setWasNpnNegotiated):
10:50 AM Changeset in webkit [59578] by eric@webkit.org
  • 6 edits in trunk

2010-05-16 Eric Seidel <​eric@webkit.org>

Unreviewed, rolling out r59571.
​http://trac.webkit.org/changeset/59571
​https://bugs.webkit.org/show_bug.cgi?id=39054

Broke Cr Win, but we didn't notice immediately due to
​https://bugs.webkit.org/show_bug.cgi?id=38926. It's possible
that this didn't actually break Cr Win, but rather that bug
38926 necessitates a clean compile after this and sucessive
checkins only produced a partial recompile and thus failed to
build.

  • DEPS:
  • WebKit.gyp:
  • features.gypi:

2010-05-16 Eric Seidel <​eric@webkit.org>

Unreviewed, rolling out r59571.
​http://trac.webkit.org/changeset/59571
​https://bugs.webkit.org/show_bug.cgi?id=39054

Broke Cr Win, but we didn't notice immediately due to
​https://bugs.webkit.org/show_bug.cgi?id=38926. It's possible
that this didn't actually break Cr Win, but rather that bug
38926 necessitates a clean compile after this and sucessive
checkins only produced a partial recompile and thus failed to
build.

  • DumpRenderTree/chromium/WebViewHost.cpp: (WebViewHost::canvas):
10:24 AM Changeset in webkit [59577] by Simon Fraser
  • 2 edits in trunk/WebCore

2010-05-16 Simon Fraser <Simon Fraser>

Reviewed by Anders Carlsson.

Shrink SimpleFontData
​https://bugs.webkit.org/show_bug.cgi?id=39179

Change SimpleFontData to have a pointer to the m_glyphToBoundsMap,
and to allocate this lazily. This reduces the size of the class from
5632 to 1536 bytes.

  • platform/graphics/SimpleFontData.h: (WebCore::SimpleFontData::boundsForGlyph):
8:43 AM Changeset in webkit [59576] by Simon Fraser
  • 9 edits in trunk/WebCore

2010-05-15 Simon Fraser <Simon Fraser>

Reviewed by Maciej Stachowiak.

Reduce the size of CachedResource
​https://bugs.webkit.org/show_bug.cgi?id=39171

Make protected data members of CachedResource private, to allow for
easier rearrangement, and hide the fact that enums are in bitfields.

Rearrange the data members of CachedResource to save 32 bytes per instance
in 64-bit. Also modernized the constructor code.

  • loader/CachedCSSStyleSheet.cpp: (WebCore::CachedCSSStyleSheet::didAddClient): (WebCore::CachedCSSStyleSheet::data): (WebCore::CachedCSSStyleSheet::checkNotify): (WebCore::CachedCSSStyleSheet::error):
  • loader/CachedFont.cpp: (WebCore::CachedFont::load): (WebCore::CachedFont::didAddClient): (WebCore::CachedFont::data): (WebCore::CachedFont::ensureCustomFontData): (WebCore::CachedFont::ensureSVGFontData): (WebCore::CachedFont::checkNotify): (WebCore::CachedFont::error):
  • loader/CachedImage.cpp: (WebCore::CachedImage::CachedImage): (WebCore::CachedImage::load): (WebCore::CachedImage::didAddClient): (WebCore::CachedImage::allClientsRemoved): (WebCore::CachedImage::image): (WebCore::CachedImage::data): (WebCore::CachedImage::error): (WebCore::CachedImage::checkNotify): (WebCore::CachedImage::destroyDecodedData):
  • loader/CachedImage.h: (WebCore::CachedImage::stillNeedsLoad):
  • loader/CachedResource.cpp: (WebCore::CachedResource::CachedResource):
  • loader/CachedResource.h: (WebCore::CachedResource::type): (WebCore::CachedResource::preloadResult): (WebCore::CachedResource::status): (WebCore::CachedResource::setStatus): (WebCore::CachedResource::isLoaded): (WebCore::CachedResource::isLoading): (WebCore::CachedResource::setErrorOccurred):
  • loader/CachedScript.cpp: (WebCore::CachedScript::didAddClient): (WebCore::CachedScript::data): (WebCore::CachedScript::checkNotify): (WebCore::CachedScript::error):
  • loader/CachedXSLStyleSheet.cpp: (WebCore::CachedXSLStyleSheet::didAddClient): (WebCore::CachedXSLStyleSheet::data): (WebCore::CachedXSLStyleSheet::checkNotify): (WebCore::CachedXSLStyleSheet::error):
6:44 AM Changeset in webkit [59575] by eric@webkit.org
  • 5 edits in trunk

2010-05-16 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r59574.
​http://trac.webkit.org/changeset/59574
​https://bugs.webkit.org/show_bug.cgi?id=39176

Supposedly broke cr-win, but the errors seems somewhat
unrelated (Requested by abarth on #webkit).

  • platform/network/chromium/ResourceResponse.h: (WebCore::ResourceResponse::ResourceResponse): (WebCore::ResourceResponse::setSecurityInfo): (WebCore::ResourceResponse::isContentFiltered): (WebCore::ResourceResponse::setIsContentFiltered): (WebCore::ResourceResponse::setAppCacheID): (WebCore::ResourceResponse::setAppCacheManifestURL): (WebCore::ResourceResponse::setWasFetchedViaSPDY): (WebCore::ResourceResponse::setIsMultipartPayload): (WebCore::ResourceResponse::setResponseTime):

2010-05-16 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r59574.
​http://trac.webkit.org/changeset/59574
​https://bugs.webkit.org/show_bug.cgi?id=39176

Supposedly broke cr-win, but the errors seems somewhat
unrelated (Requested by abarth on #webkit).

  • public/WebURLResponse.h:
  • src/WebURLResponse.cpp:
1:58 AM Changeset in webkit [59574] by eric@webkit.org
  • 4 edits in trunk

2010-05-16 Mike Belshe <​mbelshe@chromium.org>

Reviewed by Dimitri Glazkov.

Add a flag to the ResourceResponse for tracking if a request was
fetched via the TLS/Next-Protocol-Negotiation mechanism.

Also cleaned up the style in ResourceResponse to group the flags
together (and alphabetically) and hopefully improve readability of
the file.

​https://bugs.webkit.org/show_bug.cgi?id=39078

  • public/WebURLResponse.h:
  • src/WebURLResponse.cpp: (WebKit::WebURLResponse::wasNpnNegotiated): (WebKit::WebURLResponse::setWasNpnNegotiated):
1:55 AM Changeset in webkit [59573] by robert@webkit.org
  • 8 edits in trunk

[Qt]Unskip security/set-form-autocomplete-attribute.html

2010-05-16 Robert Hogan <​robert@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt]Unskip security/set-form-autocomplete-attribute.html

Add support for layoutTestController.elementDoesAutoCompleteForElementWithId().

​https://bugs.webkit.org/show_bug.cgi?id=38859

  • DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::elementDoesAutoCompleteForElementWithId):
  • DumpRenderTree/qt/LayoutTestControllerQt.h:
  • WebCoreSupport/DumpRenderTreeSupportQt.cpp: (DumpRenderTreeSupportQt::elementDoesAutoCompleteForElementWithId):
  • WebCoreSupport/DumpRenderTreeSupportQt.h:
  • platform/qt/Skipped:
1:49 AM Changeset in webkit [59572] by Simon Hausmann
  • 2 edits in trunk/WebKit/qt

[Qt] Prospective Qt/Mac build fix.

The friend declaration of QGraphicsWidget confuses gcc and thinks that it's an implicit
forward declaration, moving the class into the WebCore namespace (WebCore::QGraphicsWidget).

The declaration seems useless as no method of QGraphicsWidget is going to call anything
in this class.

  • WebCoreSupport/PageClientQt.h:
1:47 AM Changeset in webkit [59571] by eric@webkit.org
  • 6 edits in trunk

2010-05-16 Kent Tamura <​tkent@chromium.org>

Reviewed by Dimitri Glazkov.

[DRT/Chromium] Fix repaint, WebGL, textarea tests
​https://bugs.webkit.org/show_bug.cgi?id=39054

  • DEPS: Update to Chromium r47248 to use a fix for CommandLine assertion and textAreaResizeCorner.png
  • WebKit.gyp: Add textAreaResizeCorner.png as a Mac resource
  • features.gypi: Enable ENABLE_3D_CANVAS.

2010-05-16 Kent Tamura <​tkent@chromium.org>

Reviewed by Dimitri Glazkov.

[DRT/Chromium] Fix repaint, WebGL, textarea tests
​https://bugs.webkit.org/show_bug.cgi?id=39054

  • DumpRenderTree/chromium/WebViewHost.cpp: (WebViewHost::canvas): Remove m_paintRect initialization in canvas(). This line updated m_paintRect unexpectedly during paintRect(). We don't need to initialize m_paintRect because show() does it.
1:10 AM Changeset in webkit [59570] by eric@webkit.org
  • 4 edits in trunk/WebCore

2010-05-16 Dan Bernstein <​mitz@apple.com>

Reviewed by Darin Adler.

Scalar types allocated on the heap due to misuse of DEFINE_STATIC_LOCAL
​https://bugs.webkit.org/show_bug.cgi?id=39086

Use global variables directly.

  • bindings/v8/ScriptCallStack.cpp: (WebCore::ScriptCallStack::createUtilityContext):
  • platform/ScrollView.cpp: (WebCore::ScrollView::wheelEvent):
  • platform/graphics/mac/ComplexTextController.cpp: (WebCore::shouldUseATSUIAPI):
12:58 AM Changeset in webkit [59569] by eric@webkit.org
  • 4 edits
    3 adds in trunk

2010-05-16 Andreas Kling <​andreas.kling@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

Add a test to check proper return value (null) from invalid canvas getContext() calls.

​https://bugs.webkit.org/show_bug.cgi?id=39150

  • fast/canvas/canvas-getContext-invalid-expected.txt: Added.
  • fast/canvas/canvas-getContext-invalid.html: Added.
  • fast/canvas/script-tests/canvas-getContext-invalid.js: Added.

2010-05-16 Andreas Kling <​andreas.kling@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

Canvas's getContext() must return null when called with an invalid/unsupported parameter.
(HTML5 spec 4.8.11): ​http://www.whatwg.org/specs/web-apps/current-work/multipage/the-canvas-element.html#dom-canvas-getcontext

​https://bugs.webkit.org/show_bug.cgi?id=39150

Test: fast/canvas/canvas-getContext-invalid.html

  • bindings/js/JSHTMLCanvasElementCustom.cpp: (WebCore::JSHTMLCanvasElement::getContext):
  • bindings/v8/custom/V8HTMLCanvasElementCustom.cpp: (WebCore::V8HTMLCanvasElement::getContextCallback):
12:44 AM Changeset in webkit [59568] by eric@webkit.org
  • 4 edits in trunk

2010-05-16 Sergio Villar Senin <​svillar@igalia.com>

Reviewed by Gustavo Noronha Silva.

Removed 5 http/history tests from Skipped file

[GTK] Improve reporting of frame loader callbacks in DRT
​https://bugs.webkit.org/show_bug.cgi?id=36454

  • platform/gtk/Skipped:

2010-05-16 Sergio Villar Senin <​svillar@igalia.com>

Reviewed by Gustavo Noronha Silva.

[GTK] Improve reporting of frame loader callbacks in DRT
​https://bugs.webkit.org/show_bug.cgi?id=36454

  • DumpRenderTree/gtk/DumpRenderTree.cpp: (webViewLoadStatusNotified): (createWebView): added connection to notify::load-status and signal callback
Note: See TracTimeline for information about the timeline view.