⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



May 18, 2010:

11:45 PM Changeset in webkit [59748] by alex
  • 2 edits in trunk/LayoutTests

2010-05-18 Alejandro G. Castro <​alex@igalia.com>

Unreviewed, skip test.

Skipping fast/workers/storage
​https://bugs.webkit.org/show_bug.cgi?id=39346

  • platform/gtk/Skipped:
11:30 PM Changeset in webkit [59747] by abarth@webkit.org
  • 5 edits in trunk/WebCore

2010-05-18 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Make the HTML5 parser correctly parse <div>Hello</div>
​https://bugs.webkit.org/show_bug.cgi?id=39345

Again, this patch is covered by a large number of LayoutTests.

  • html/HTML5Lexer.cpp: (WebCore::HTML5Lexer::HTML5Lexer): (WebCore::HTML5Lexer::reset): (WebCore::HTML5Lexer::nextToken): (WebCore::HTML5Lexer::emitCommentToken): (WebCore::HTML5Lexer::emitCharacter): (WebCore::HTML5Lexer::emitCurrentTagToken):
  • html/HTML5Lexer.h:
  • html/HTML5Token.h: (WebCore::HTML5Token::beginCharacter): (WebCore::HTML5Token::appendToCharacter): (WebCore::HTML5Token::characters):
  • html/HTML5Tokenizer.cpp: (WebCore::convertToOldStyle):
11:04 PM Changeset in webkit [59746] by barraclough@apple.com
  • 15 edits in trunk/JavaScriptCore

Bug 39343 - Dynamically generate a native call thunk per NativeFunction

Reviewed by Geoff Garen.

​https://bugs.webkit.org/show_bug.cgi?id=39252 regressed performance on i386,
by adding an extra indirection to making a native call. By introducing per-
NativeFunction thunks we can hard code the function pointer into the thunk
so that it need not be loaded from the callee.

  • jit/JIT.h:

(JSC::JIT::compileCTINativeCall):

  • jit/JITOpcodes.cpp:

(JSC::JIT::privateCompileCTINativeCall):

  • jit/JITOpcodes32_64.cpp:

(JSC::JIT::privateCompileCTINativeCall):

  • jit/JITPropertyAccess.cpp:

(JSC::JIT::emitSlow_op_get_by_val):

  • jit/JITPropertyAccess32_64.cpp:

(JSC::JIT::emitSlow_op_get_by_val):

  • jit/JITStubs.cpp:

(JSC::JITThunks::ctiStub):
(JSC::JITThunks::hostFunctionStub):

  • jit/JITStubs.h:
  • jit/SpecializedThunkJIT.h:

(JSC::SpecializedThunkJIT::finalize):

  • jit/ThunkGenerators.cpp:

(JSC::charCodeAtThunkGenerator):
(JSC::charAtThunkGenerator):
(JSC::fromCharCodeThunkGenerator):
(JSC::sqrtThunkGenerator):
(JSC::powThunkGenerator):

  • runtime/JSFunction.cpp:

(JSC::JSFunction::JSFunction):

  • runtime/JSGlobalData.cpp:

(JSC::JSGlobalData::getHostFunction):

  • runtime/JSGlobalData.h:

(JSC::JSGlobalData::getCTIStub):

  • runtime/Lookup.cpp:

(JSC::setUpStaticFunctionSlot):

  • runtime/StringConstructor.cpp:

(JSC::StringConstructor::StringConstructor):

  • wtf/Platform.h:
10:30 PM Changeset in webkit [59745] by abarth@webkit.org
  • 5 edits in trunk/WebCore

2010-05-18 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Make the HTML5 parser actually parse <div></div>
​https://bugs.webkit.org/show_bug.cgi?id=39342

This patch is covered by every LayoutTest. Yes. All of them. :)

  • html/HTML5Lexer.cpp: (WebCore::toLowerCase): (WebCore::HTML5Lexer::HTML5Lexer): (WebCore::HTML5Lexer::nextToken): (WebCore::HTML5Lexer::emitCharacter):
  • html/HTML5Lexer.h:
  • html/HTML5Token.h: (WebCore::HTML5Token::HTML5Token): (WebCore::HTML5Token::beginStartTag): (WebCore::HTML5Token::beginEndTag): (WebCore::HTML5Token::appendToName): (WebCore::HTML5Token::type): (WebCore::HTML5Token::name): (WebCore::HTML5Token::selfClosing): (WebCore::HTML5Token::attrs):
  • html/HTML5Tokenizer.cpp: (WebCore::convertToOldStyle): (WebCore::HTML5Tokenizer::write):
10:27 PM Changeset in webkit [59744] by tkent@chromium.org
  • 5 edits in trunk

[DRT/Chromium] Fix a repaint issue and textarea tests
​https://bugs.webkit.org/show_bug.cgi?id=39054

Reviewed by Dimitri Glazkov.

WebKit/chromium:

  • DEPS: Update to Chromium r47248 to use a fix for CommandLine assertion and textAreaResizeCorner.png
  • WebKit.gyp: Add textAreaResizeCorner.png as a Mac resource

WebKitTools:

  • DumpRenderTree/chromium/WebViewHost.cpp:

(WebViewHost::canvas): Remove m_paintRect initialization in canvas().

This line updated m_paintRect unexpectedly during paintRect().
We don't need to initialize m_paintRect because show() does it.

10:12 PM Changeset in webkit [59743] by tony@chromium.org
  • 6 edits in trunk/WebKitTools

2010-05-18 Tony Chang <​tony@chromium.org>

Reviewed by Kent Tamura.

[chromium] new-run-webkit-tests --use-drt should run on Linux
​https://bugs.webkit.org/show_bug.cgi?id=37845

  • Scripts/webkitpy/layout_tests/port/chromium.py:
  • Scripts/webkitpy/layout_tests/port/chromium_linux.py:
  • Scripts/webkitpy/layout_tests/port/chromium_mac.py:
  • Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
  • Scripts/webkitpy/layout_tests/port/chromium_win.py:
10:10 PM Changeset in webkit [59742] by ggaren@apple.com
  • 25 edits
    2 adds in trunk

JavaScriptCore: Simplified handling of 'arguments' -- 1.2% SunSpider speedup
​https://bugs.webkit.org/show_bug.cgi?id=39200

Reviewed by Darin Adler.

Removed the reserved OptionalCalleeArguments slot from the CallFrame.
Now, slots for 'arguments' are allocated and initialized only by
functions that might need them.

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::dump): Updated for new bytecode operands.

(JSC::CodeBlock::CodeBlock):

  • bytecode/CodeBlock.h:

(JSC::unmodifiedArgumentsRegister): Added a helper function for mapping
from the arguments register to its unmodified counterpart.

(JSC::CodeBlock::setArgumentsRegister):
(JSC::CodeBlock::argumentsRegister):
(JSC::CodeBlock::usesArguments): Changed from a "usesArguments" bool to
an optional int index representing the arguments register.

  • bytecode/Opcode.h: Updated for new bytecode operands.
  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::addVar): Factored out a helper function for
allocating an anonymous var.

(JSC::BytecodeGenerator::BytecodeGenerator): Merged / simplified some
arguments vs activation logic, and added code to allocate the arguments
registers when needed.

(JSC::BytecodeGenerator::createArgumentsIfNecessary): Updated for new bytecode operands.

(JSC::BytecodeGenerator::emitCallEval): No need to create the arguments
object before calling eval; the activation object will lazily create the
arguments object if eval resolves it.

(JSC::BytecodeGenerator::emitReturn): Updated for new bytecode operands.

(JSC::BytecodeGenerator::emitPushScope):
(JSC::BytecodeGenerator::emitPushNewScope): Ditto emitCallEval.

  • bytecompiler/BytecodeGenerator.h:

(JSC::BytecodeGenerator::addVar): Factored out a helper function for
allocating an anonymous var.

(JSC::BytecodeGenerator::registerFor): No more need for special handling
of the arguments registers; they're allocated just like normal registers
now.

  • interpreter/CallFrame.h:

(JSC::ExecState::callerFrame):
(JSC::ExecState::init):

  • interpreter/CallFrameClosure.h:

(JSC::CallFrameClosure::resetCallFrame): Nixed optionalCalleeArguments.

  • interpreter/Interpreter.cpp:

(JSC::Interpreter::dumpRegisters):
(JSC::Interpreter::unwindCallFrame):
(JSC::Interpreter::privateExecute):
(JSC::Interpreter::retrieveArguments): Opcodes accessing 'arguments' now
take operands specifying registers, just like all other opcodes.
JSActivation::copyRegisters is no longer responsible for tearing off the
arguments object; instead, the VM is responsible for both.

Also, a behavior change: Each access to f.arguments creates a new object,
unless f itself uses 'arguments'. This matches Chrome, and is necessary
for the optimization. f.arguments is a nonstandard, deprecated feature,
so high fidelity to a given implementation is not necessarily a goal.
Also, as illustrated by the new test case, the identity of f.arguments
has been broken since 2008, except in the case where f itself accesses
f.arguments -- but nobody seemed to notice. So, hopefully this change won't
break the web.

  • interpreter/Register.h: Nixed the special arguments accessor. It's no

longer needed.

  • interpreter/RegisterFile.h:

(JSC::RegisterFile::):

  • jit/JITCall.cpp:

(JSC::JIT::compileOpCallInitializeCallFrame):
(JSC::JIT::compileOpCall):

  • jit/JITOpcodes.cpp:

(JSC::JIT::emit_op_tear_off_activation):
(JSC::JIT::emit_op_tear_off_arguments):
(JSC::JIT::emit_op_create_arguments):
(JSC::JIT::emit_op_init_arguments):

  • jit/JITOpcodes32_64.cpp:

(JSC::JIT::emit_op_tear_off_activation):
(JSC::JIT::emit_op_tear_off_arguments):
(JSC::JIT::emit_op_create_arguments):
(JSC::JIT::emit_op_init_arguments): The actual optimization: Removed
OptionalCalleeArguments from the callframe slot. Now, it doesn't need
to be initialized for most calls.

  • jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):

  • jit/JITStubs.h:

(JSC::): Updated stubs to support arbitrary 'arguments' registers,
instead of hard-coding something in the call frame.

  • runtime/Arguments.h:

(JSC::JSActivation::copyRegisters): Removed some obfuscatory abstraction.

  • runtime/Executable.h:

(JSC::FunctionExecutable::generatedByteCode): Added a helper for accessing
the 'arguments' register. In a future patch, that kind of data should
probably move out of CodeBlock and into Executable.

  • runtime/JSActivation.cpp:

(JSC::JSActivation::getOwnPropertySlot):
(JSC::JSActivation::argumentsGetter):

  • runtime/JSActivation.h: Simplified / fixed access to 'arguments' via

the activation object. It now implements the same behavior implemented
by optimized variable access in the VM. This simplifies some other
things, too -- like eval code generation.

LayoutTests: Simplified handling of 'arguments' -- 1.2% SunSpider speedup
​https://bugs.webkit.org/show_bug.cgi?id=39200

Reviewed by Darin Adler.

  • fast/js/function-dot-arguments-expected.txt:
  • fast/js/script-tests/function-dot-arguments.js:

(argumentsIdentity): Updated to match new behavior.

  • fast/js/function-dot-arguments2-expected.txt:
  • fast/js/function-dot-arguments2.html: New tests for some things that

weren't covered before.

  • fast/js/global-recursion-on-full-stack.html: Rejiggered the stack

usage in this test. Since stack usage is more efficient now, you
need a slightly different usage pattern to hit the exact thing this
test wanted to test.

  • fast/js/kde/script-tests/function_arguments.js:

(f): Updated to more specifically test what this was trying to test,
to avoid just testing the identity of f.arguments.

9:24 PM Changeset in webkit [59741] by tkent@chromium.org
  • 4 edits in trunk/LayoutTests

Unreviewed test fix.

fast/css/pseudo-required-optional-unapplied.html failure with ENABLE_METER_TAG
​https://bugs.webkit.org/show_bug.cgi?id=39341

Remove test elements at the end of the test because dumpAsText() output
for <meter> depends on ENABLE_METER_TAG.

  • fast/css/pseudo-required-optional-unapplied-expected.txt:
  • fast/css/pseudo-required-optional-unapplied.html:
  • platform/qt/Skipped:
8:54 PM Changeset in webkit [59740] by tkent@chromium.org
  • 1 edit in trunk/LayoutTests/platform/qt/Skipped

Unreviewed. Add pseudo-required-optional-unapplied.html to qt/Skipped.
​https://bugs.webkit.org/show_bug.cgi?id=39341

8:30 PM Changeset in webkit [59739] by tony@chromium.org
  • 3 edits
    2 adds in trunk

2010-05-18 Tony Chang <​tony@chromium.org>

Reviewed by Ojan Vafai.

REGRESSION: crash in WebCore::CompositeEditCommand::splitTreeToNode when indenting in an empty li
​https://bugs.webkit.org/show_bug.cgi?id=38232

  • editing/execCommand/crash-indenting-list-item-expected.txt: Added.
  • editing/execCommand/crash-indenting-list-item.html: Added.

2010-05-18 Tony Chang <​tony@chromium.org>

Reviewed by Ojan Vafai.

REGRESSION: crash in WebCore::CompositeEditCommand::splitTreeToNode when indenting in an empty li
​https://bugs.webkit.org/show_bug.cgi?id=38232

Test: editing/execCommand/crash-indenting-list-item.html

  • editing/IndentOutdentCommand.cpp: (WebCore::IndentOutdentCommand::tryIndentingAsListItem): (WebCore::IndentOutdentCommand::indentIntoBlockquote):
8:15 PM Changeset in webkit [59738] by tkent@chromium.org
  • 4 edits
    2 adds in trunk

':optional' pseudo selector should not be applied to <keygen> and <progress>
​https://bugs.webkit.org/show_bug.cgi?id=39292

Reviewed by Darin Adler.

WebCore:

Test: fast/css/pseudo-required-optional-unapplied.html

  • html/HTMLKeygenElement.h:

(WebCore::HTMLKeygenElement::isOptionalFormControl):

Add isOptionalFormControl() returning false.
HTMLKeygenElement inherits HTMLSelectElement, which should return true
for isOptionalFormControl(). However, <keygen> is not :optional
according to the standard.

  • html/HTMLProgressElement.h: Remove isOptionalFormControl().

LayoutTests:

Add a test for non-optional form elements.

  • fast/css/pseudo-required-optional-unapplied-expected.txt: Added.
  • fast/css/pseudo-required-optional-unapplied.html: Added.
7:59 PM Changeset in webkit [59737] by tkent@chromium.org
  • 4 edits in trunk/WebKitTools

2010-05-18 Kent Tamura <​tkent@chromium.org>

Reviewed by Dimitri Glazkov.

[DRT/Chromium] Fix some initialization/reset issues
​https://bugs.webkit.org/show_bug.cgi?id=39281

  • DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::reset): Reset m_userStyleSheetLocation.
  • DumpRenderTree/chromium/LayoutTestController.h: Remove unused variable, m_workQueueFrozen. (LayoutTestController::WorkQueue::WorkQueue): Initialize m_frozen.
  • DumpRenderTree/chromium/TestShell.cpp: (TestShell::resetTestController): Reset WebSettings too.
7:57 PM Changeset in webkit [59736] by abarth@webkit.org
  • 3 edits in trunk/WebCore

2010-05-18 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Implement the DOCTYPE states for the HTML5 lexer
​https://bugs.webkit.org/show_bug.cgi?id=39335

  • html/HTML5Lexer.cpp: (WebCore::HTML5Lexer::nextToken): (WebCore::emitCurrentDoctypeToken):
  • html/HTML5Lexer.h:
7:33 PM Changeset in webkit [59735] by tony@chromium.org
  • 3 edits
    1 add in trunk

2010-05-18 Tony Chang <​tony@chromium.org>

Reviewed by Ojan Vafai.

[chromium] ignore IME events if the keydown event was prevented
​https://bugs.webkit.org/show_bug.cgi?id=37692

A manual test to verify the IME behavior since the existing methods of
textInputController test at a lower level than the fix.

  • manual-tests/ime-keydown-preventdefault.html: Added.

2010-05-18 Tony Chang <​tony@chromium.org>

Reviewed by Ojan Vafai.

[chromium] ignore IME events if the keydown event was prevented
​https://bugs.webkit.org/show_bug.cgi?id=37692

  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::handleCompositionEvent):
7:26 PM Changeset in webkit [59734] by weinig@apple.com
  • 2 edits in trunk/WebCore

Fix the build for platforms that don't always include UnusedParam.h

  • dom/Attribute.cpp:
7:24 PM Changeset in webkit [59733] by morrita@google.com
  • 7 edits in trunk

2010-05-18 MORITA Hajime <​morrita@google.com>

Reviewed by Kent Tamura.

[Chromium] Windows: Determinate progress bar should have glossy overlay
​https://bugs.webkit.org/show_bug.cgi?id=39269

  • Moved animation code from RenderThemeChromiumWin to chromium tree because it should be behind the theme implementation, which lives in chromium tree.
  • Passed current time to the bridge, which will be used to compute the state of the theme animation.

No new tests, animation effect can be confirmed only manually.

  • platform/chromium/ChromiumBridge.h:
  • rendering/RenderProgress.h: (WebCore::RenderProgress::animationStartTime): Added.
  • rendering/RenderThemeChromiumWin.cpp: (WebCore::RenderThemeChromiumWin::animationDurationForProgressBar): (WebCore::RenderThemeChromiumWin::paintProgressBar):

2010-05-18 MORITA Hajime <​morrita@google.com>

Reviewed by Kent Tamura.

[Chromium] Windows: Determinate progress bar should have glossy overlay
​https://bugs.webkit.org/show_bug.cgi?id=39269

Changed WebThemeEngine::drawProgressBar() signature to delegate
theme implementation detail to the engine.
Chromium side will come to ​http://crbug.com/44430.

No new tests, animation effect can be confirmed only manually.

  • public/WebThemeEngine.h: (WebKit::WebThemeEngine::paintProgressBar):
  • src/ChromiumBridge.cpp: (WebCore::ChromiumBridge::paintProgressBar):
7:18 PM QtWebKitBackportingFixes edited by Laszlo Gombos
(diff)
7:12 PM Changeset in webkit [59732] by weinig@apple.com
  • 2 edits in trunk/WebCore

Fix release build.

  • dom/Attribute.cpp:

(WebCore::Attribute::unbindAttr):

6:56 PM Changeset in webkit [59731] by weinig@apple.com
  • 4 edits in trunk/WebCore

Move Attr pointer from Attribute to a global HashMap.
​https://bugs.webkit.org/show_bug.cgi?id=39337
<rdar://problem/8001168>

Reviewed by Maciej Stachowiak.

Shaves another word off of Attribute.

  • dom/Attr.cpp:

(WebCore::Attr::Attr):
(WebCore::Attr::~Attr):

  • dom/Attribute.cpp:

(WebCore::attributeAttrMap):
(WebCore::Attribute::attr):
(WebCore::Attribute::createAttrIfNeeded):
(WebCore::Attribute::bindAttr):
(WebCore::Attribute::unbindAttr):

  • dom/Attribute.h:

(WebCore::Attribute::Attribute):

6:52 PM Changeset in webkit [59730] by jamesr@google.com
  • 5 edits
    52 adds in trunk/LayoutTests

2010-05-18 James Robinson <​jamesr@chromium.org>

Unreviewed.

Add leopard-specific pixel results for more tests that need them
​https://bugs.webkit.org/show_bug.cgi?id=39325

This adds new Leopard baselines for all tests that currently
pass with tolerance=0 on Snow Leopard but fail on Leopard
with an image diff of <= 0.1%. These tests previously had
expectations in platform/mac that were Snow Leopard specific.

  • platform/mac-leopard/animations: Added.
  • platform/mac-leopard/animations/3d: Added.
  • platform/mac-leopard/animations/3d/change-transform-in-end-event-expected.checksum: Added.
  • platform/mac-leopard/animations/3d/change-transform-in-end-event-expected.png: Added.
  • platform/mac-leopard/compositing/animation: Added.
  • platform/mac-leopard/compositing/animation/state-at-end-event-transform-layer-expected.checksum: Added.
  • platform/mac-leopard/compositing/animation/state-at-end-event-transform-layer-expected.png: Added.
  • platform/mac-leopard/compositing/compositing-visible-descendant-expected.checksum: Added.
  • platform/mac-leopard/compositing/compositing-visible-descendant-expected.png: Added.
  • platform/mac-leopard/compositing/geometry/abs-position-inside-opacity-expected.checksum: Added.
  • platform/mac-leopard/compositing/geometry/abs-position-inside-opacity-expected.png: Added.
  • platform/mac-leopard/compositing/geometry/fixed-position-expected.checksum: Added.
  • platform/mac-leopard/compositing/geometry/fixed-position-expected.png: Added.
  • platform/mac-leopard/compositing/geometry/horizontal-scroll-composited-expected.checksum: Added.
  • platform/mac-leopard/compositing/geometry/horizontal-scroll-composited-expected.png: Added.
  • platform/mac-leopard/compositing/geometry/partial-layout-update-expected.checksum: Added.
  • platform/mac-leopard/compositing/geometry/partial-layout-update-expected.png: Added.
  • platform/mac-leopard/compositing/geometry/transfrom-origin-on-zero-size-layer-expected.checksum: Added.
  • platform/mac-leopard/compositing/geometry/transfrom-origin-on-zero-size-layer-expected.png: Added.
  • platform/mac-leopard/compositing/geometry/vertical-scroll-composited-expected.checksum: Added.
  • platform/mac-leopard/compositing/geometry/vertical-scroll-composited-expected.png: Added.
  • platform/mac-leopard/compositing/iframes/iframe-copy-on-scroll-expected.checksum: Added.
  • platform/mac-leopard/compositing/iframes/iframe-copy-on-scroll-expected.png: Added.
  • platform/mac-leopard/compositing/masks: Added.
  • platform/mac-leopard/compositing/masks/direct-image-mask-expected.checksum: Added.
  • platform/mac-leopard/compositing/masks/direct-image-mask-expected.png: Added.
  • platform/mac-leopard/compositing/overflow/fixed-position-ancestor-clip-expected.checksum: Added.
  • platform/mac-leopard/compositing/overflow/fixed-position-ancestor-clip-expected.png: Added.
  • platform/mac-leopard/compositing/reflections/reflection-in-composited-expected.checksum: Added.
  • platform/mac-leopard/compositing/reflections/reflection-in-composited-expected.png: Added.
  • platform/mac-leopard/compositing/reflections/reflection-ordering-expected.checksum: Added.
  • platform/mac-leopard/compositing/reflections/reflection-ordering-expected.png: Added.
  • platform/mac-leopard/compositing/repaint/content-into-overflow-expected.checksum: Added.
  • platform/mac-leopard/compositing/repaint/content-into-overflow-expected.png: Added.
  • platform/mac-leopard/compositing/repaint/layer-repaint-expected.checksum: Added.
  • platform/mac-leopard/compositing/repaint/layer-repaint-expected.png: Added.
  • platform/mac-leopard/compositing/repaint/opacity-between-absolute-expected.checksum: Added.
  • platform/mac-leopard/compositing/repaint/opacity-between-absolute-expected.png: Added.
  • platform/mac-leopard/compositing/repaint/opacity-between-absolute2-expected.checksum: Added.
  • platform/mac-leopard/compositing/repaint/opacity-between-absolute2-expected.png: Added.
  • platform/mac-leopard/fast/borders: Added.
  • platform/mac-leopard/fast/borders/svg-as-border-image-2-expected.checksum: Added.
  • platform/mac-leopard/fast/borders/svg-as-border-image-2-expected.png: Added.
  • platform/mac-leopard/fast/borders/svg-as-border-image-expected.checksum: Added.
  • platform/mac-leopard/fast/borders/svg-as-border-image-expected.png: Added.
  • platform/mac-leopard/fast/forms/placeholder-stripped-expected.checksum: Added.
  • platform/mac-leopard/fast/forms/placeholder-stripped-expected.png: Added.
  • platform/mac-leopard/fast/multicol: Added.
  • platform/mac-leopard/fast/multicol/column-count-with-rules-expected.checksum: Added.
  • platform/mac-leopard/fast/multicol/column-count-with-rules-expected.png: Added.
  • platform/mac-leopard/media/controls-strict-expected.checksum:
  • platform/mac-leopard/media/controls-strict-expected.png:
  • platform/mac-leopard/media/video-display-toggle-expected.checksum:
  • platform/mac-leopard/media/video-display-toggle-expected.png:
  • platform/mac-leopard/media/video-replaces-poster-expected.checksum: Added.
  • platform/mac-leopard/media/video-replaces-poster-expected.png: Added.
6:32 PM Changeset in webkit [59729] by jpetsovits@rim.com
  • 1 edit
    2 adds in trunk/WebCore

2010-05-18 Jakob Petsovits <​jpetsovits@rim.com>

Unreviewed, forgot to svn add source file in r59619.
​http://trac.webkit.org/changeset/59619

  • platform/image-decoders/openvg: Added.
  • platform/image-decoders/openvg/ImageDecoderOpenVG.cpp: Added. (WebCore::RGBA32Buffer::asNewNativeImage):
6:16 PM Changeset in webkit [59728] by Martin Robinson
  • 2 edits in trunk/LayoutTests

2010-05-18 Martin Robinson <​mrobinson@igalia.com>

Not reviewed.

[GTK] fast/dom/Geolocation/enabled.html is crashing on the bots
​https://bugs.webkit.org/show_bug.cgi?id=39326

  • platform/gtk/Skipped: Skip another test causing crashes.
6:05 PM Changeset in webkit [59727] by yaar@chromium.org
  • 29 edits
    2 deletes in trunk

2010-05-18 Yaar Schnitman <​yaar@chromium.org>

Unreviewed, rolling out r59693.
​http://trac.webkit.org/changeset/59693
​https://bugs.webkit.org/show_bug.cgi?id=37815

Broke GTK Release

  • Android.jscbindings.mk:
  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSBindingsAllInOne.cpp:
  • bindings/js/JSCallbackData.cpp: (WebCore::JSCallbackData::invokeCallback):
  • bindings/js/JSEventListener.cpp: (WebCore::JSEventListener::handleEvent):
  • bindings/js/JSInjectedScriptHostCustom.cpp: (WebCore::InjectedScriptHost::createInjectedScript):
  • bindings/js/JSMainThreadExecState.cpp: Removed.
  • bindings/js/JSMainThreadExecState.h: Removed.
  • bindings/js/ScheduledAction.cpp: (WebCore::ScheduledAction::executeFunctionInContext): (WebCore::ScheduledAction::execute):
  • bindings/js/ScheduledAction.h:
  • bindings/js/ScriptController.cpp: (WebCore::ScriptController::evaluateInWorld):
  • bindings/js/ScriptController.h:
  • bindings/js/ScriptFunctionCall.cpp: (WebCore::ScriptFunctionCall::call):
  • bindings/objc/ObjCEventListener.mm:
  • bindings/objc/WebScriptObject.mm: (-[WebScriptObject callWebScriptMethod:withArguments:]): (-[WebScriptObject evaluateWebScript:]):
  • bindings/scripts/CodeGeneratorObjC.pm:
  • bindings/scripts/test/ObjC/DOMTestCallback.mm: (-[DOMTestCallback callbackWithClass1Param:]): (-[DOMTestCallback callbackWithClass2Param:strArg:]): (-[DOMTestCallback callbackWithNonBoolReturnType:]): (-[DOMTestCallback customCallback:class6Param:]):
  • bindings/scripts/test/ObjC/DOMTestInterface.mm:
  • bindings/scripts/test/ObjC/DOMTestObj.mm: (-[DOMTestObj readOnlyIntAttr]): (-[DOMTestObj readOnlyStringAttr]): (-[DOMTestObj readOnlyTestObjAttr]): (-[DOMTestObj intAttr]): (-[DOMTestObj setIntAttr:]): (-[DOMTestObj longLongAttr]): (-[DOMTestObj setLongLongAttr:]): (-[DOMTestObj unsignedLongLongAttr]): (-[DOMTestObj setUnsignedLongLongAttr:]): (-[DOMTestObj stringAttr]): (-[DOMTestObj setStringAttr:]): (-[DOMTestObj testObjAttr]): (-[DOMTestObj setTestObjAttr:]): (-[DOMTestObj attrWithException]): (-[DOMTestObj setAttrWithException:]): (-[DOMTestObj attrWithSetterException]): (-[DOMTestObj setAttrWithSetterException:]): (-[DOMTestObj attrWithGetterException]): (-[DOMTestObj setAttrWithGetterException:]): (-[DOMTestObj customAttr]): (-[DOMTestObj setCustomAttr:]): (-[DOMTestObj scriptStringAttr]): (-[DOMTestObj voidMethod]): (-[DOMTestObj voidMethodWithArgs:strArg:objArg:]): (-[DOMTestObj intMethod]): (-[DOMTestObj intMethodWithArgs:strArg:objArg:]): (-[DOMTestObj objMethod]): (-[DOMTestObj objMethodWithArgs:strArg:objArg:]): (-[DOMTestObj methodThatRequiresAllArgs:objArg:]): (-[DOMTestObj methodThatRequiresAllArgsAndThrows:objArg:]): (-[DOMTestObj serializedValue:]): (-[DOMTestObj methodWithException]): (-[DOMTestObj customMethod]): (-[DOMTestObj customMethodWithArgs:strArg:objArg:]): (-[DOMTestObj customArgsAndException:]): (-[DOMTestObj addEventListener:listener:useCapture:]): (-[DOMTestObj removeEventListener:listener:useCapture:]): (-[DOMTestObj withDynamicFrame]): (-[DOMTestObj withDynamicFrameAndArg:]): (-[DOMTestObj withDynamicFrameAndOptionalArg:optionalArg:]): (-[DOMTestObj withDynamicFrameAndUserGesture:]): (-[DOMTestObj withDynamicFrameAndUserGestureASAD:optionalArg:]): (-[DOMTestObj withScriptStateVoid]): (-[DOMTestObj withScriptStateObj]): (-[DOMTestObj withScriptStateVoidException]): (-[DOMTestObj withScriptStateObjException]): (-[DOMTestObj methodWithOptionalArg:]): (-[DOMTestObj methodWithNonOptionalArgAndOptionalArg:opt:]): (-[DOMTestObj methodWithNonOptionalArgAndTwoOptionalArgs:opt1:opt2:]):
  • bindings/v8/ScriptController.cpp:
  • bindings/v8/ScriptController.h:
  • html/HTMLFrameElementBase.cpp: (WebCore::HTMLFrameElementBase::isURLAllowed):

2010-05-18 Yaar Schnitman <​yaar@chromium.org>

Unreviewed, rolling out r59693.
​http://trac.webkit.org/changeset/59693
​https://bugs.webkit.org/show_bug.cgi?id=37815

Broke GTK Release

  • http/tests/security/xss-DENIED-iframe-src-alias-expected.txt:
  • http/tests/security/xss-DENIED-iframe-src-alias.html:
5:57 PM Changeset in webkit [59726] by abarth@webkit.org
  • 3 edits in trunk/WebCore

2010-05-18 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Implement comment states for HTML5 lexer
​https://bugs.webkit.org/show_bug.cgi?id=39334

  • html/HTML5Lexer.cpp: (WebCore::HTML5Lexer::nextToken):
5:52 PM Changeset in webkit [59725] by dpranke@chromium.org
  • 11 edits
    23 adds in trunk/WebKitTools

2010-05-18 Dirk Pranke <​dpranke@chromium.org>

Reviewed by Ojan Vafai.

new-run-webkit-tests: implement '--reset-results' flag to complement
the '--new-baseline' flag. '--new-baseline' will always write the
results into the platform directory; '--reset-results' will update the
existing baseline wherever it happens to be. Both sets of behavior
are useful in different circumstances.

​https://bugs.webkit.org/show_bug.cgi?id=38879

  • Scripts/webkitpy/layout_tests/data/image/canvas-bg.html: Added.
  • Scripts/webkitpy/layout_tests/data/image/canvas-zoom-expected.checksum: Added.
  • Scripts/webkitpy/layout_tests/data/image/canvas-zoom-expected.png: Added.
  • Scripts/webkitpy/layout_tests/data/image/canvas-zoom-expected.txt: Added.
  • Scripts/webkitpy/layout_tests/data/image/canvas-zoom.html: Added.
  • Scripts/webkitpy/layout_tests/data/misc/crash-expected.txt: Added.
  • Scripts/webkitpy/layout_tests/data/misc/crash.html: Added.
  • Scripts/webkitpy/layout_tests/data/misc/missing-expectation.html: Added.
  • Scripts/webkitpy/layout_tests/data/misc/passing-expected.txt: Added.
  • Scripts/webkitpy/layout_tests/data/misc/passing.html: Added.
  • Scripts/webkitpy/layout_tests/data/platform/test/image/canvas-bg-expected.checksum: Added.
  • Scripts/webkitpy/layout_tests/data/platform/test/image/canvas-bg-expected.png: Added.
  • Scripts/webkitpy/layout_tests/data/platform/test/image/canvas-bg-expected.txt: Added.
  • Scripts/webkitpy/layout_tests/data/platform/test/test_expectations.txt: Added.
  • Scripts/webkitpy/layout_tests/data/text/article-element-expected.txt: Added.
  • Scripts/webkitpy/layout_tests/data/text/article-element.html: Added.
  • Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
  • Scripts/webkitpy/layout_tests/port/test.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
  • Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
  • Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
  • Scripts/webkitpy/layout_tests/test_types/image_diff.py:
  • Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
  • Scripts/webkitpy/layout_tests/test_types/text_diff.py:
  • Scripts/webkitpy/layout_tests/port/test.py:
  • Scripts/webkitpy/layout_tests/port/dryrun.py:
5:50 PM QtWebKitBackportingFixes edited by Laszlo Gombos
(diff)
5:42 PM Changeset in webkit [59724] by andersca@apple.com
  • 15 edits
    1 delete in trunk/WebCore

2010-05-18 Anders Carlsson <​andersca@apple.com>

Reviewed by Sam Weinig.

Move all member variables from MappedAttribute to Attribute.
​https://bugs.webkit.org/show_bug.cgi?id=39336
<rdar://problem/8000853>

This saves one word because we no longer have any virtual member functions in Attribute, and
thus no vtable pointer.


I plan to remove MappedAttribute altogether in a subsequent commit.

  • Android.mk:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::styleForElement):
  • dom/Attribute.cpp: (WebCore::Attribute::clone):
  • dom/Attribute.h: (WebCore::Attribute::create): (WebCore::Attribute::style): (WebCore::Attribute::decl): (WebCore::Attribute::setDecl): (WebCore::Attribute::isMappedAttribute): (WebCore::Attribute::Attribute):
  • dom/MappedAttribute.cpp: Removed.
  • dom/MappedAttribute.h: (WebCore::MappedAttribute::create): (WebCore::MappedAttribute::MappedAttribute): (WebCore::toMappedAttribute):
  • dom/NamedMappedAttrMap.cpp: (WebCore::NamedMappedAttrMap::declCount): (WebCore::NamedMappedAttrMap::mapsEquivalent):
  • dom/StyledElement.cpp: (WebCore::StyledElement::attributeChanged):
  • svg/SVGSVGElement.cpp: (WebCore::updateCSSForAttribute):
  • svg/SVGStyledElement.cpp: (WebCore::SVGStyledElement::getPresentationAttribute):
5:36 PM Changeset in webkit [59723] by jamesr@google.com
  • 1 edit
    36 adds in trunk/LayoutTests

2010-05-18 James Robinson <​jamesr@chromium.org>

Unreviewed.

Add leopard-specific pixel results for tests that need them
​https://bugs.webkit.org/show_bug.cgi?id=39325

This adds new Leopard baselines for all tests that currently
pass with tolerance=0 on Snow Leopard but fail on Leopard
with an image diff of <= 0.01%. These tests previously had
expectations in platform/mac that were Snow Leopard specific.

  • platform/mac-leopard/compositing/color-matching: Added.
  • platform/mac-leopard/compositing/color-matching/pdf-image-match-expected.checksum: Added.
  • platform/mac-leopard/compositing/color-matching/pdf-image-match-expected.png: Added.
  • platform/mac-leopard/compositing/reflections: Added.
  • platform/mac-leopard/compositing/reflections/simple-composited-reflections-expected.checksum: Added.
  • platform/mac-leopard/compositing/reflections/simple-composited-reflections-expected.png: Added.
  • platform/mac-leopard/compositing/repaint/overflow-into-content-expected.checksum: Added.
  • platform/mac-leopard/compositing/repaint/overflow-into-content-expected.png: Added.
  • platform/mac-leopard/editing/pasteboard: Added.
  • platform/mac-leopard/editing/pasteboard/drag-image-to-contenteditable-in-iframe-expected.checksum: Added.
  • platform/mac-leopard/editing/pasteboard/drag-image-to-contenteditable-in-iframe-expected.png: Added.
  • platform/mac-leopard/fast/css: Added.
  • platform/mac-leopard/fast/css/pseudo-cache-stale-expected.checksum: Added.
  • platform/mac-leopard/fast/css/pseudo-cache-stale-expected.png: Added.
  • platform/mac-leopard/fast/frames: Added.
  • platform/mac-leopard/fast/frames/take-focus-from-iframe-expected.checksum: Added.
  • platform/mac-leopard/fast/frames/take-focus-from-iframe-expected.png: Added.
  • platform/mac-leopard/fast/repaint: Added.
  • platform/mac-leopard/fast/repaint/fixed-child-move-after-scroll-expected.checksum: Added.
  • platform/mac-leopard/fast/repaint/fixed-child-move-after-scroll-expected.png: Added.
  • platform/mac-leopard/fast/repaint/fixed-child-of-fixed-move-after-scroll-expected.checksum: Added.
  • platform/mac-leopard/fast/repaint/fixed-child-of-fixed-move-after-scroll-expected.png: Added.
  • platform/mac-leopard/fast/repaint/fixed-child-of-transformed-move-after-scroll-expected.checksum: Added.
  • platform/mac-leopard/fast/repaint/fixed-child-of-transformed-move-after-scroll-expected.png: Added.
  • platform/mac-leopard/fast/repaint/fixed-move-after-scroll-expected.checksum: Added.
  • platform/mac-leopard/fast/repaint/fixed-move-after-scroll-expected.png: Added.
  • platform/mac-leopard/fast/text/format-control-expected.checksum: Added.
  • platform/mac-leopard/fast/text/format-control-expected.png: Added.
  • platform/mac-leopard/plugins: Added.
  • platform/mac-leopard/plugins/qt-qwidget-plugin-expected.checksum: Added.
  • platform/mac-leopard/plugins/qt-qwidget-plugin-expected.png: Added.
  • platform/mac-leopard/transforms/svg-vs-css-expected.checksum: Added.
  • platform/mac-leopard/transforms/svg-vs-css-expected.png: Added.
  • platform/mac-leopard/transitions: Added.
  • platform/mac-leopard/transitions/move-after-transition-expected.checksum: Added.
  • platform/mac-leopard/transitions/move-after-transition-expected.png: Added.
5:36 PM Changeset in webkit [59722] by tony@chromium.org
  • 3 edits
    1 add in trunk

2010-05-18 Tony Chang <​tony@chromium.org>

Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=24943
Command-B and Command-I do not generate keydown events in contentEditable regions.

  • manual-tests/style-keypress-events.html: Added.

2010-05-18 Tony Chang <​tony@chromium.org>

Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=24943
Command-B and Command-I do not generate keydown events in contentEditable regions.

Manual test because performKeyEquivalent is not called by DRT.

Test: manual-tests/style-keypress-events.html

  • WebView/WebHTMLView.mm: (-[WebHTMLView performKeyEquivalent:]): Move style key handling until after webcore gets a chance to handle the event
5:31 PM Changeset in webkit [59721] by abarth@webkit.org
  • 3 edits in trunk/WebCore

2010-05-18 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Add more state to the HTML5 lexer
​https://bugs.webkit.org/show_bug.cgi?id=39333

This code is just transliteration from the spec.

  • html/HTML5Lexer.cpp: (WebCore::HTML5Lexer::HTML5Lexer): (WebCore::HTML5Lexer::nextToken):
  • html/HTML5Lexer.h:
4:55 PM Changeset in webkit [59720] by abarth@webkit.org
  • 3 edits in trunk/WebCore

2010-05-18 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Implement two more lexer states
​https://bugs.webkit.org/show_bug.cgi?id=39298

No tests because Eric is still working on wiring up the lexer to the
test harness.

  • html/HTML5Lexer.cpp: (WebCore::HTML5Lexer::nextToken): (WebCore::HTML5Lexer::emitParseError): (WebCore::HTML5Lexer::emitCurrentTagToken):
  • html/HTML5Lexer.h:
4:53 PM Changeset in webkit [59719] by beidson@apple.com
  • 10 edits
    1 copy
    4 adds in trunk

Repro crash with many Google image search results
<rdar://problem/7685669> and ​https://bugs.webkit.org/show_bug.cgi?id=39323

Reviewed by Maciej Stachowiak.

WebCore:

When an iframe has a plugin resource as its src, that case bypassed the plugin sandboxing checks and continued to load
the data for the plugin resource. It handed that data off to a nonexistent Widget, causing a null deref and the crash.

By replacing PluginDocuments in sandboxes iframes with a new "SinkDocument" that just acts as a data sink, we prevent the
crash and also prevent actually loading the plugin binaries.

I filed ​https://bugs.webkit.org/show_bug.cgi?id=39330 to follow up and let us cancel the load as soon as we know we should.

Test: fast/loader/sandboxed-plugin-crash.html

  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • loader/DocumentWriter.cpp:

(WebCore::DocumentWriter::begin): If the created document is a PluginDocument and the plugin sandbox flag is set,

replace it with a SinkDocument.

  • loader/PluginDocument.h:

(WebCore::PluginDocument::isPluginDocument): Make public (it was already public at the Document.h level).

Add a simple document/tokenizer pair that simply presents a blank HTML document and acts as a data sink for whatever
data is handed to it:

  • loader/SinkDocument.cpp: Added.

(WebCore::SinkTokenizer::SinkTokenizer):
(WebCore::SinkTokenizer::write):
(WebCore::SinkTokenizer::isWaitingForScripts):
(WebCore::SinkTokenizer::wantsRawData):
(WebCore::SinkTokenizer::writeRawData):
(WebCore::SinkTokenizer::stopParsing):
(WebCore::SinkTokenizer::finish):
(WebCore::SinkDocument::SinkDocument):
(WebCore::SinkDocument::createTokenizer):

  • loader/SinkDocument.h: Added.

(WebCore::SinkDocument::create):

LayoutTests:

  • fast/loader/resources/test.swf: Copied from LayoutTests/fast/replaced/resources/test.swf.
  • fast/loader/sandboxed-plugin-crash-expected.txt: Added.
  • fast/loader/sandboxed-plugin-crash.html: Added.
3:53 PM Changeset in webkit [59718] by Martin Robinson
  • 2 edits in trunk/LayoutTests

2010-05-18 Martin Robinson <​mrobinson@igalia.com>

No review necessary.

[GTK] fast/dom/Geolocation/enabled.html is crashing on the bots
​https://bugs.webkit.org/show_bug.cgi?id=39326

  • platform/gtk/Skipped: Skip the crashing tests.
3:47 PM Changeset in webkit [59717] by Laszlo Gombos
  • 2 edits in trunk/WebKit/qt

2010-05-18 Laszlo Gombos <Laszlo Gombos>

Symbian build fix.

[Qt] Updated the def file with new exports after r59335.

  • symbian/eabi/QtWebKitu.def:
3:38 PM Changeset in webkit [59716] by weinig@apple.com
  • 3 edits in trunk/WebCore

​https://bugs.webkit.org/show_bug.cgi?id=39321
Reduce the size of ListHashSets used by Document
<rdar://problem/7999388>

Reviewed by Anders Carlsson.

Reduce Membuster peak memory usage by ~450K by reducing the pool sizes
of the ListHashSets used by Document.

  • dom/Document.cpp:

(WebCore::Document::addStyleSheetCandidateNode):
(WebCore::Document::recalcStyleSelector):

  • dom/Document.h:
3:29 PM Changeset in webkit [59715] by jianli@chromium.org
  • 1 edit in trunk/WebCore/ChangeLog

Updated WebCore/Change to correct the bug link.

3:14 PM Changeset in webkit [59714] by Martin Robinson
  • 2 edits in trunk/WebKit/gtk

2010-05-18 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] DragClientGtk::startDrag leaks GdkEvents
​https://bugs.webkit.org/show_bug.cgi?id=39322

  • WebCoreSupport/DragClientGtk.cpp: (WebKit::DragClient::startDrag): Properly clean up allocated GdkEvent.
2:59 PM Changeset in webkit [59713] by kenneth@webkit.org
  • 2 edits in trunk/WebCore

Return null when creating an ImageBuffer failed, due to for
instance a nulled pixmap.

Rubberstamped by Simon Hausmann.

  • platform/graphics/qt/ImageBufferQt.cpp:

(WebCore::ImageBufferData::ImageBufferData):
(WebCore::ImageBuffer::ImageBuffer):

2:55 PM Changeset in webkit [59712] by jianli@chromium.org
  • 7 edits in trunk

Fix bug 39285: fast/files/file-reader.html is timing out on all mac bots.
​https://bugs.webkit.org/show_bug.cgi?id=39135

Reviewed by Dmitry Titov.

WebCore:

The timeout is caused by 59659 that changed the GC timer to 0 and thus
triggered a bug in FileReader code. The fix is to add more states so
that hasPendingActivity() can do the check correctly.

  • html/FileReader.cpp:

(WebCore::FileReader::FileReader):
(WebCore::FileReader::hasPendingActivity):
(WebCore::FileReader::readInternal):
(WebCore::FileReader::terminate):
(WebCore::FileReader::didStart):
(WebCore::FileReader::didGetSize):
(WebCore::FileReader::didRead):
(WebCore::FileReader::didFinish):
(WebCore::FileReader::didFail):
(WebCore::FileReader::readyState):
(WebCore::FileReader::result):

  • html/FileReader.h:

(WebCore::FileReader::):

LayoutTests:

Re-enale the file reader test.

  • fast/files/file-reader-expected.txt:
  • fast/files/file-reader.html:
  • platform/mac/Skipped:
2:37 PM Changeset in webkit [59711] by Simon Fraser
  • 3 edits in trunk/WebCore

2010-05-18 Simon Fraser <Simon Fraser>

Reviewed by Darin Adler.

Clean up GraphicsLayer naming code
​https://bugs.webkit.org/show_bug.cgi?id=39316

Move code that generates a name for the GraphicsLayer (used in debug builds only) into
a new nameForLayer() method. Use it when naming the foreground layer.

  • rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::createGraphicsLayer): (WebCore::RenderLayerBacking::updateForegroundLayer): (WebCore::RenderLayerBacking::nameForLayer):
  • rendering/RenderLayerBacking.h:
2:22 PM Changeset in webkit [59710] by mrowe@apple.com
  • 3 edits
    2 adds in branches/safari-533-branch

Merge r59556.

2:22 PM Changeset in webkit [59709] by mrowe@apple.com
  • 3 edits
    2 adds in branches/safari-533-branch

Merge r59495.

2:22 PM Changeset in webkit [59708] by mrowe@apple.com
  • 9 edits in branches/safari-533-branch/WebCore

Merge r59576.

2:22 PM Changeset in webkit [59707] by mrowe@apple.com
  • 3 edits
    2 adds in branches/safari-533-branch

Merge r59486.

2:22 PM Changeset in webkit [59706] by mrowe@apple.com
  • 2 edits in branches/safari-533-branch/WebCore

Merge r59577.

2:22 PM Changeset in webkit [59705] by mrowe@apple.com
  • 3 edits
    1 add in branches/safari-533-branch/WebCore

Merge r59610.

2:22 PM Changeset in webkit [59704] by mrowe@apple.com
  • 2 edits in branches/safari-533-branch/WebCore

Merge r59609.

2:22 PM Changeset in webkit [59703] by mrowe@apple.com
  • 3 edits
    2 adds in branches/safari-533-branch

Merge r59516.

2:21 PM Changeset in webkit [59702] by mrowe@apple.com
  • 1 edit
    1 add in branches/safari-533-branch/LayoutTests

Merge r59444.

2:21 PM Changeset in webkit [59701] by mrowe@apple.com
  • 3 edits
    4 adds in branches/safari-533-branch

Merge r59443.

2:21 PM Changeset in webkit [59700] by mrowe@apple.com
  • 3 edits
    2 adds in branches/safari-533-branch

Merge r59390.

2:21 PM Changeset in webkit [59699] by mrowe@apple.com
  • 3 edits
    2 adds in branches/safari-533-branch

Merge r59591.

2:21 PM Changeset in webkit [59698] by mrowe@apple.com
  • 11 edits in branches/safari-533-branch/WebCore

Merge r59629.

2:21 PM Changeset in webkit [59697] by mrowe@apple.com
  • 2 edits in branches/safari-533-branch/WebCore

Merge r59583.

2:21 PM Changeset in webkit [59696] by mrowe@apple.com
  • 6 edits in branches/safari-533-branch

Merge r59514.

2:21 PM Changeset in webkit [59695] by mrowe@apple.com
  • 2 edits in branches/safari-533-branch/JavaScriptCore

Merge r59587.

2:20 PM Changeset in webkit [59694] by mrowe@apple.com
  • 7 edits in branches/safari-533-branch

Merge r59547.

2:15 PM Changeset in webkit [59693] by yaar@chromium.org
  • 29 edits
    2 adds in trunk

2010-05-18 Justin Schuh <​jschuh@chromium.org>

Reviewed by Adam Barth.

Moving frame.src checks out of the bindings
​https://bugs.webkit.org/show_bug.cgi?id=37815

Moved JavaScript frame.src checks out of bindings and into
HTMLFrameElementBase. Added main thread state stack to JavaScriptCore
so ExecState is available inside core DOM. Updated affected bindings
(except for GObject, which will need to be updated to avoid origin
failures inside native code).

  • Android.jscbindings.mk:
  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSBindingsAllInOne.cpp:
  • bindings/js/JSCallbackData.cpp: (WebCore::JSCallbackData::invokeCallback):
  • bindings/js/JSEventListener.cpp: (WebCore::JSEventListener::handleEvent):
  • bindings/js/JSInjectedScriptHostCustom.cpp: (WebCore::InjectedScriptHost::createInjectedScript):
  • bindings/js/JSMainThreadExecState.cpp: Added.
  • bindings/js/JSMainThreadExecState.h: Added. (WebCore::JSMainThreadExecState::currentState): (WebCore::JSMainThreadExecState::call): (WebCore::JSMainThreadExecState::evaluate): (WebCore::JSMainThreadExecState::JSMainThreadExecState): (WebCore::JSMainThreadExecState::~JSMainThreadExecState): (WebCore::JSMainThreadNullState::JSMainThreadNullState):
  • bindings/js/ScheduledAction.cpp: (WebCore::ScheduledAction::executeFunctionInContext): (WebCore::ScheduledAction::execute):
  • bindings/js/ScheduledAction.h:
  • bindings/js/ScriptController.cpp: (WebCore::ScriptController::evaluateInWorld): (WebCore::ScriptController::canAccessFromCurrentOrigin):
  • bindings/js/ScriptController.h:
  • bindings/js/ScriptFunctionCall.cpp: (WebCore::ScriptFunctionCall::call):
  • bindings/objc/ObjCEventListener.mm:
  • bindings/objc/WebScriptObject.mm: (-[WebScriptObject callWebScriptMethod:withArguments:]): (-[WebScriptObject evaluateWebScript:]):
  • bindings/scripts/CodeGeneratorObjC.pm:
  • bindings/scripts/test/ObjC/DOMTestCallback.mm: (-[DOMTestCallback callbackWithClass1Param:]): (-[DOMTestCallback callbackWithClass2Param:strArg:]): (-[DOMTestCallback callbackWithNonBoolReturnType:]): (-[DOMTestCallback customCallback:class6Param:]):
  • bindings/scripts/test/ObjC/DOMTestInterface.mm:
  • bindings/scripts/test/ObjC/DOMTestObj.mm: (-[DOMTestObj readOnlyIntAttr]): (-[DOMTestObj readOnlyStringAttr]): (-[DOMTestObj readOnlyTestObjAttr]): (-[DOMTestObj intAttr]): (-[DOMTestObj setIntAttr:]): (-[DOMTestObj longLongAttr]): (-[DOMTestObj setLongLongAttr:]): (-[DOMTestObj unsignedLongLongAttr]): (-[DOMTestObj setUnsignedLongLongAttr:]): (-[DOMTestObj stringAttr]): (-[DOMTestObj setStringAttr:]): (-[DOMTestObj testObjAttr]): (-[DOMTestObj setTestObjAttr:]): (-[DOMTestObj attrWithException]): (-[DOMTestObj setAttrWithException:]): (-[DOMTestObj attrWithSetterException]): (-[DOMTestObj setAttrWithSetterException:]): (-[DOMTestObj attrWithGetterException]): (-[DOMTestObj setAttrWithGetterException:]): (-[DOMTestObj customAttr]): (-[DOMTestObj setCustomAttr:]): (-[DOMTestObj scriptStringAttr]): (-[DOMTestObj voidMethod]): (-[DOMTestObj voidMethodWithArgs:strArg:objArg:]): (-[DOMTestObj intMethod]): (-[DOMTestObj intMethodWithArgs:strArg:objArg:]): (-[DOMTestObj objMethod]): (-[DOMTestObj objMethodWithArgs:strArg:objArg:]): (-[DOMTestObj methodThatRequiresAllArgs:objArg:]): (-[DOMTestObj methodThatRequiresAllArgsAndThrows:objArg:]): (-[DOMTestObj serializedValue:]): (-[DOMTestObj methodWithException]): (-[DOMTestObj customMethod]): (-[DOMTestObj customMethodWithArgs:strArg:objArg:]): (-[DOMTestObj customArgsAndException:]): (-[DOMTestObj addEventListener:listener:useCapture:]): (-[DOMTestObj removeEventListener:listener:useCapture:]): (-[DOMTestObj withDynamicFrame]): (-[DOMTestObj withDynamicFrameAndArg:]): (-[DOMTestObj withDynamicFrameAndOptionalArg:optionalArg:]): (-[DOMTestObj withDynamicFrameAndUserGesture:]): (-[DOMTestObj withDynamicFrameAndUserGestureASAD:optionalArg:]): (-[DOMTestObj withScriptStateVoid]): (-[DOMTestObj withScriptStateObj]): (-[DOMTestObj withScriptStateVoidException]): (-[DOMTestObj withScriptStateObjException]): (-[DOMTestObj methodWithOptionalArg:]): (-[DOMTestObj methodWithNonOptionalArgAndOptionalArg:opt:]): (-[DOMTestObj methodWithNonOptionalArgAndTwoOptionalArgs:opt1:opt2:]):
  • bindings/v8/ScriptController.cpp: (WebCore::ScriptController::canAccessFromCurrentOrigin):
  • bindings/v8/ScriptController.h:
  • html/HTMLFrameElementBase.cpp: (WebCore::HTMLFrameElementBase::isURLAllowed):

2010-05-18 Justin Schuh <​jschuh@chromium.org>

Reviewed by Adam Barth.

Moving frame.src checks out of the bindings
​https://bugs.webkit.org/show_bug.cgi?id=37815

  • http/tests/security/xss-DENIED-iframe-src-alias-expected.txt:
  • http/tests/security/xss-DENIED-iframe-src-alias.html:
2:11 PM Changeset in webkit [59692] by crogers@google.com
  • 13 edits
    2 copies
    2 adds in branches/audio

Add initial implementation for JavascriptAudioSourceNode

  • this is very experimental to get us quickly up and running
  • fix AudioContext to not use static global for timing!
  • unfinished steps at getting V8 bindings working again
1:52 PM Changeset in webkit [59691] by atwilson@chromium.org
  • 2 edits in trunk/WebCore

Unreviewed: Speculative build fix for Chromium win.

  • platform/graphics/skia/SkiaFontWin.cpp: Properly set inlineCapacity.
1:39 PM Changeset in webkit [59690] by atwilson@chromium.org
  • 2 edits in trunk/WebCore

Unreviewed fix for Chromium build break.

  • platform/graphics/skia/SkiaFontWin.cpp: Now set inlineCapacity param.
1:22 PM Changeset in webkit [59689] by dimich@chromium.org
  • 8 edits in trunk

DragData::asURL() shouldn't do file validity checks
​https://bugs.webkit.org/show_bug.cgi?id=38711

Patch by Daniel Cheng <​dcheng@chromium.org> on 2010-05-18
Reviewed by Darin Adler, Jian Li.

WebCore:

There's no point to trying to make sure the file is valid in
DragData::asURL(). It's better to ask for forgiveness than to ask for
permission, since asking for permission is prone to race conditions
and results in unnecessary I/O. Consumers of this function either:

  • need to verify the file exists themselves (e.g. the loader)
  • don't care about file validity (rich text drag-and-drop)
  • platform/chromium/DragDataChromium.cpp:

(WebCore::DragData::asURL):

WebKit/mac:

Change [NSPasteboard _web_bestURL] to still return a file URL for paths
that don't exist. Callers who care about the existence of the file or
whether or not it is a directory should check themselves when they
want to use the file. The directory check has been left in for now,
since the Mac implementation of ResourceHandle, which uses this function
indirectly via DragController::performDrag) handles directories somewhat
non-intuitively: it opens the parent directory in the Finder, rather
than opening the directory itself.

  • Misc/WebNSPasteboardExtras.mm:

(-[NSPasteboard _web_bestURL]):

LayoutTests:

Several layout tests depended on the fact that dropping a file would
never trigger navigation. This never happened to occur in the past,
since it just so happened that the filenames used in the tests never
resolved to files that exist. Since DragData::asURL() no longer tries
to verify file existence, the layout tests were updated to either
suppress navigation or log any navigation that should occur as part of
the test.

  • editing/pasteboard/file-input-files-access-expected.txt:
  • editing/pasteboard/script-tests/file-input-files-access.js:

(runTest.window.onbeforeunload):
(runTest):

  • http/tests/security/clipboard/script-tests/clipboard-file-access.js:
1:21 PM Changeset in webkit [59688] by timothy@apple.com
  • 12 edits in trunk/WebCore

Fix a handful of various localization issues in the Web Inspector.

  • Localize strings that where not localized.
  • Make WebInspector.UIString work without bind.
  • Always pass WebInspector.UIString to Number.secondsToString and Number.bytesToString.
  • Never pass a variable to WebInspector.UIString, since that prevents auto-generation.
  • Use an ellipsis instead of three periods.

​https://webkit.org/b/39303
rdar://problem/7997101

Reviewed by Adam Roben.

  • English.lproj/localizedStrings.js:
  • inspector/front-end/AuditRules.js:

(WebInspector.AuditRules.GzipRule.prototype.doRun):
(WebInspector.AuditRules.CookieSizeRule.prototype.processCookies):
(WebInspector.AuditRules.StaticCookielessRule.prototype.processCookies):

  • inspector/front-end/ConsoleView.js:

(WebInspector.ConsoleView):

  • inspector/front-end/ImageView.js:

(WebInspector.ImageView.prototype.contentTabSelected):

  • inspector/front-end/ProfileDataGridTree.js:

(WebInspector.ProfileDataGridNode.prototype.get data.formatMilliseconds):
(WebInspector.ProfileDataGridNode.prototype.get data):

  • inspector/front-end/ResourcesPanel.js:

(WebInspector.ResourceTimeCalculator.prototype.formatValue):
(WebInspector.ResourceTransferTimeCalculator.prototype.formatValue):
(WebInspector.ResourceTransferDurationCalculator.prototype.formatValue):
(WebInspector.ResourceTransferSizeCalculator.prototype.formatValue):

  • inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel.prototype._registerShortcuts):

  • inspector/front-end/SourceFrame.js:

(WebInspector.SourceFrame.prototype._contextMenu):

  • inspector/front-end/TimelineOverviewPane.js:

(WebInspector.TimelineOverviewCalculator):
(WebInspector.TimelineOverviewCalculator.prototype.formatValue):

  • inspector/front-end/TimelinePanel.js:

(WebInspector.TimelinePanel):
(WebInspector.TimelineCalculator):
(WebInspector.TimelineCalculator.prototype.formatValue):
(WebInspector.TimelinePanel.FormattedRecord.prototype._generateAggregatedInfo):
(WebInspector.TimelinePanel.FormattedRecord.prototype._generatePopupContent):
(WebInspector.TimelinePanel.FormattedRecord.prototype._getRecordDetails):
(WebInspector.TimelinePanel.PopupContentHelper.prototype._appendTextRow):
(WebInspector.TimelinePanel.PopupContentHelper.prototype._appendElementRow):

  • inspector/front-end/inspector.js:

(WebInspector.loaded):
(WebInspector.setRecordingProfile):
(WebInspector.UIString):

1:16 PM Changeset in webkit [59687] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2010-05-18 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Roben.

Add an --html5-parser option to DumpRenderTree to allow testing the new HTML5Lexer
​https://bugs.webkit.org/show_bug.cgi?id=39311

This flag allows us to run the new HTML5Lexer code.
Right now all documents parse as empty documents, but
now that we're able to run the code we can fix that.

Once we're able to lex a few basic documents I'll add
an --html5-parser flag to run-webkit-tests so that we test
running all of the layout tests with the HTML5 parser.

  • DumpRenderTree/mac/DumpRenderTree.mm: (resetDefaultsToConsistentValues): (initializeGlobalsFromCommandLineOptions):
1:13 PM Changeset in webkit [59686] by weinig@apple.com
  • 2 edits in trunk/WebCore

Another attempt to fix the build.

  • css/CSSCursorImageValue.cpp:
12:48 PM QtWebKitTriageRoster edited by Simon Hausmann
(diff)
12:46 PM QtWebKitBugs edited by Simon Hausmann
(diff)
12:45 PM Changeset in webkit [59685] by weinig@apple.com
  • 2 edits in trunk/JavaScriptCore

Try to fix the windows build.

  • API/JSStringRefBSTR.cpp:
12:33 PM Changeset in webkit [59684] by Adam Roben
  • 2 edits in trunk/WebCore

Make accelerated compositing work on machines that don't support hardware vertex processing

Fixes <​http://webkit.org/b/39299> <rdar://problem/7997692> Accelerated
compositing on Windows doesn't work on machines that don't support
hardware vertex processing, but should

Reviewed by Eric Carlson.

  • platform/graphics/win/WKCACFLayerRenderer.cpp:

(WebCore::WKCACFLayerRenderer::createRenderer): Query the device
capabilities to decide whether to request hardware or software vertex
processing.

12:33 PM Changeset in webkit [59683] by Adam Roben
  • 3 edits
    1 move in trunk/WebCore

Make WKCACFLayerRenderer robust against temporary failure of Direct3DCreate9 and IDirect3D9::CreateDevice

For a short time after waking from sleep, Direct3DCreate9() will
return an IDirect3D9 for which IDirect3D9::CreateDevice will always
fail. Also during this time period, IDirect3D9::CreateDevice
will fail even for non-bad IDirect3D9s. (It will later start
succeeding.) WKCACFLayerRenderer now works around this behavior by
detecting when it might be in this situation and calling these
functions again later.

Fixes <​http://webkit.org/b/39297> <rdar://problem/7997431> WebView
doesn't repaint until page reloads when page using hardware
acceleration loads just after waking from sleep

Reviewed by John Sullivan.

  • manual-tests/crash-and-no-repaint-after-wake-from-sleep.html:

Renamed from WebCore/manual-tests/crash-after-wake-from-sleep.html.
Modified to also include instructions for reproducing this bug.

  • platform/graphics/win/WKCACFLayerRenderer.cpp:

(WebCore::WKCACFLayerRenderer::WKCACFLayerRenderer): Replaced
m_triedToCreateD3DRenderer with m_mightBeAbleToCreateDeviceLater. The
new member is initialized to true, since we haven't even tried to
create a device once yet.
(WebCore::WKCACFLayerRenderer::createRenderer): If we already have a
D3D device, or we don't have one and are sure that we won't be able to
create one later, just return the previously-created device, if any.
We assume that we won't be able to create a device later if this
function fails, unless the function fails due to CreateDevice failing.
As noted above, CreateDevice will sometimes temporarily fail and then
later start working again. When CreateDevice fails, we also assume
that we might have a bad IDirect3D9, so we get rid of the one we have
so a new (and hopefully non-bad) one will be allocated later.
(WebCore::WKCACFLayerRenderer::destroyRenderer): Reset
m_mightBeAbleToCreateDeviceLater to true, since we no longer have a
device.
(WebCore::WKCACFLayerRenderer::paint): Before trying to paint, try to
create our D3D device and renderer. If this fails, we bail out, but if
we think we might be able to create a device later we schedule another
paint (via renderSoon()) so that we'll try again soon.

  • platform/graphics/win/WKCACFLayerRenderer.h: Replaced

m_triedToCreateD3DRenderer with m_mightBeAbleToCreateDeviceLater.

12:32 PM Changeset in webkit [59682] by Adam Roben
  • 2 edits
    1 add in trunk/WebCore

Fix a crash when a page that uses accelerated compositing loads soon after the computer wakes from sleep

The set-up:

For a short time after waking from sleep, IDirect3D9::CreateDevice
will fail. This caused WKCACFLayerRenderer::createRenderer to fail,
and meant that WKCACFLayerRenderer never allocated a root layer.
WebView wouldn't notice that createRenderer failed, and would go ahead
and try to use the root layer anyway, resulting in a crash.

The fix:

We now allocate the root layer (and all the other members of
WKCACFLayerRenderer that aren't dependent on having an
IDirect3DDevice9) in WKCACFLayerRenderer's constructor. This way the
layers will always be present, even when creating the D3D device
fails.

There are two remaining problems:

1) This results in slightly more memory usage in the case where

CreateDevice fails.

2) Once we get into this bad state, the WebView doesn't repaint

until we navigate somewhere else.

(2) is covered by
<​http://webkit.org/b/39297>/<rdar://problem/7997431>. We'll fix it by
retrying CreateDevice later in hopes that it will succeed after more
time has passed. This will in turn fix (1). (We should never end up in
a case where CreateDevice fails forever because we already did some
preliminary checks in acceleratedCompositingAvailable().)

Fixes <​http://webkit.org/b/39295> <rdar://problem/7971319> Crash
(preceded by assertion) in WKCACFLayerRenderer::setNeedsDisplay when
computer wakes from sleep on particular page

Reviewed by John Sullivan.

  • manual-tests/crash-after-wake-from-sleep.html: Added. This

is the Poster Circle demo from webkit.org/blog, but modified to
automatically reload every 5 seconds and with instructions to put the
computer to sleep and wake it up again.

  • platform/graphics/win/WKCACFLayerRenderer.cpp:

(WebCore::WKCACFLayerRenderer::WKCACFLayerRenderer): Moved code to
initialize m_context, m_renderContext, and m_*Layer here...
(WebCore::WKCACFLayerRenderer::createRenderer): ...from here.

12:32 PM Changeset in webkit [59681] by Adam Roben
  • 2 edits in trunk/WebCore

Remove an unused member variable from WKCACFLayerRenderer

Rubber-stamped by Ada Chan.

  • platform/graphics/win/WKCACFLayerRenderer.h: Removed m_viewLayer,

which is unused.

12:25 PM Changeset in webkit [59680] by andersca@apple.com
  • 3 edits in trunk/WebCore

2010-05-18 Anders Carlsson <​andersca@apple.com>

Reviewed by Sam Weinig.

Allocate the m_preloads list hash set dynamically and free it when done.
​https://bugs.webkit.org/show_bug.cgi?id=39309
<rdar://problem/7998495>

This saves about 6000 bytes on a fully loaded document.

  • loader/DocLoader.cpp: (WebCore::DocLoader::requestPreload): (WebCore::DocLoader::clearPreloads):
  • loader/DocLoader.h:
12:16 PM Changeset in webkit [59679] by andersca@apple.com
  • 2 edits in trunk/WebCore

Revert unintended indentation and unnecessary nested name specifier.

  • rendering/RenderBlock.cpp:

(WebCore::clipOutPositionedObjects):
(WebCore::RenderBlock::insertPositionedObject):

11:58 AM Changeset in webkit [59678] by andersca@apple.com
  • 6 edits in trunk

2010-05-18 Anders Carlsson <​andersca@apple.com>

Reviewed by Sam Weinig.

Add an inlineCapacity template parameter to ListHashSet and use it to shrink the positioned object list hash set.
​https://bugs.webkit.org/show_bug.cgi?id=39304
<rdar://problem/7998366>

Add an inlineCapacity template parameter to ListHashSet.

  • wtf/ListHashSet.h: (WTF::::ListHashSet): (WTF::::operator): (WTF::::swap): (WTF::::~ListHashSet): (WTF::::size): (WTF::::capacity): (WTF::::isEmpty): (WTF::::begin): (WTF::::end): (WTF::::find): (WTF::::contains): (WTF::::add): (WTF::::insertBefore): (WTF::::remove): (WTF::::clear): (WTF::::unlinkAndDelete): (WTF::::appendNode): (WTF::::insertNodeBefore): (WTF::::deleteAllNodes): (WTF::::makeIterator): (WTF::::makeConstIterator): (WTF::deleteAllValues):

2010-05-18 Anders Carlsson <​andersca@apple.com>

Reviewed by Sam Weinig.

Add an inlineCapacity template parameter to ListHashSet and use it to shrink the positioned object list hash set.
​https://bugs.webkit.org/show_bug.cgi?id=39304
<rdar://problem/7998366>

Set the inlineCapacity for the positionedObjects ListHashSet to 4 instead of 256. Since a RenderBlock usually has
few positioned objects, this saves memory.

  • WebCore.base.exp:
  • rendering/RenderBlock.cpp: (WebCore::clipOutPositionedObjects): (WebCore::RenderBlock::insertPositionedObject):
  • rendering/RenderBlock.h: (WebCore::RenderBlock::positionedObjects):
11:43 AM Changeset in webkit [59677] by weinig@apple.com
  • 11 edits
    2 moves in trunk/WebCore

​https://bugs.webkit.org/show_bug.cgi?id=39258
Remove NamedAttrMap residual gunk

Reviewed by Darin Adler.

Replace NamedAttrMap.h/cpp with NamedNodeMap.h/cpp which was the class
it contained.

  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/v8/custom/V8NamedNodesCollection.cpp:
  • dom/NamedAttrMap.cpp: Removed.
  • dom/NamedAttrMap.h: Removed.
  • dom/NamedNodeMap.cpp: Copied from dom/NamedAttrMap.cpp.
  • dom/NamedNodeMap.h: Replaced with dom/NamedAttrMap.h.
  • editing/ReplaceNodeWithSpanCommand.cpp:
  • platform/chromium/ClipboardChromium.cpp:
11:32 AM Changeset in webkit [59676] by loki@webkit.org
  • 5 edits in trunk/JavaScriptCore

Fix the interpreter after r59637
​https://bugs.webkit.org/show_bug.cgi?id=39287

Reviewed by Darin Adler.

  • runtime/Executable.h:
  • runtime/JSFunction.cpp:

(JSC::JSFunction::JSFunction):
(JSC::JSFunction::getCallData):

  • runtime/JSGlobalData.cpp:
  • runtime/JSGlobalData.h:
11:28 AM Changeset in webkit [59675] by jianli@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed. Build fix. Disable file-reader.html for more investigation.

  • platform/mac/Skipped:
11:28 AM Changeset in webkit [59674] by beidson@apple.com
  • 3 edits in trunk/WebCore

<rdar://problem/7993468> REGRESSION (r58586): Audio doesn't play on first click of play button at NPR.org

Reviewed by Eric Carlson.

NPR swallows the first mouse click on the play button, calls load() on the element, then waits for the
canplay event to come in before calling play itself.

After the site specific hack added in r58586, we disallowed play() from within the canplay event handler.
By tracking whether a load() was triggered by a user gesture, we can differentiate between the original
canplay event that we meant to ignore and the one resulting from the first mouse click which we want to honor.

No new tests. (Currently no way to test such site specific hack behavior)

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::HTMLMediaElement):
(WebCore::HTMLMediaElement::load): Set the m_loadInitiatedByUserGesture flag
(WebCore::HTMLMediaElement::play): Only apply the site specific hack if the load wasn't initiated by a user gesture.

  • html/HTMLMediaElement.h:
11:09 AM Changeset in webkit [59673] by jpetsovits@rim.com
  • 3 edits in trunk/WebCore

2010-05-18 Jakob Petsovits <​jpetsovits@rim.com>

Reviewed by Dirk Schulze.

[OpenVG] Fix stupid build errors from the OpenVG Path commit
​https://bugs.webkit.org/show_bug.cgi?id=39228

  • platform/graphics/openvg/PainterOpenVG.cpp: (WebCore::PainterOpenVG::clipPath):
  • platform/graphics/openvg/PathOpenVG.cpp: (WebCore::Path::transform):
10:30 AM Changeset in webkit [59672] by jianli@chromium.org
  • 3 edits in trunk/LayoutTests

Unreviewed. Build fix. Disable test cases in file-reader.html that
cause time-out in mac bot for further investigation.

  • fast/files/file-reader-expected.txt:
  • fast/files/file-reader.html:
10:27 AM Changeset in webkit [59671] by jparent@chromium.org
  • 3 edits in trunk/BugsSite

Rietveld review page should dedicate more space to Rietveld, less to high level comments form.

Reviewed by Ojan Vafai.

​https://bugs.webkit.org/show_bug.cgi?id=39244

  • template/en/custom/attachment/reviewform.html.tmpl:

Delete a random BR amongst the hidden elements that was causing extra whitespace.

  • template/en/custom/attachment/rietveldreview.html.tmpl:

Increase size of Rietveld frame to 80%, from 60%.

9:18 AM Changeset in webkit [59670] by Chris Jerdonek
  • 3 edits in trunk/WebCore

2010-05-18 Chris Jerdonek <Chris Jerdonek>

Reviewed by Darin Adler.

Refactored FrameLoader::isDocumentSandboxed() from a private member function
to a static, non-member, non-friend function.

​https://bugs.webkit.org/show_bug.cgi?id=39157

Making this function non-private lets us make FrameLoader::createWindow()
a non-member function in a subsequent patch. We also made it non-member
rather than member to increase encapsulation and limit the number of
public functions with access to private FrameLoader data.

No new functionality, so no new tests.

  • loader/FrameLoader.cpp: (WebCore::isDocumentSandboxed):
    • Moved this function from a private member function of FrameLoader to a static, non-member, non-friend function.

(WebCore::FrameLoader::createWindow):

  • Updated the call to isDocumentSandboxed().

(WebCore::FrameLoader::submitForm):

  • Updated the call to isDocumentSandboxed().

(WebCore::FrameLoader::requestObject):

  • Updated the call to isDocumentSandboxed().

(WebCore::FrameLoader::shouldAllowNavigation):

  • Updated the call to isDocumentSandboxed().
  • loader/FrameLoader.h:
    • Removed isDocumentSandboxed() and added a FIXME to move createWindow() out of the FrameLoader class.
7:07 AM Changeset in webkit [59669] by Simon Hausmann
  • 5 edits in trunk

[Qt] Fix http/tests/xmlhttprequest/cross-origin-no-authorization.html

2010-05-08 Robert Hogan <​robert@roberthogan.net>

Reviewed by Simon Hausmann.

[Qt] Fix http/tests/xmlhttprequest/cross-origin-no-authorization.html

and http/tests/xmlhttprequest/cross-origin-authorization.html

QHttpNetworkRequest adds Authorization and Cookie headers to XHRs
without knowing if this is valid behaviour or not. In order to allow
Qt to decide whether Cookie/Authorization headers should be added
to an XHR QtWebKit needs to use an attribute added to QNetworkRequest.
These new attributes are: QNetworkRequest::CookieLoadControlAttribute,
QNetworkRequest::CookieSaveControlAttribute,and
QNetworkRequest::AuthenticationReuseControlAttribute.

QtWebKit will set QNetworkRequest::AuthenticationReuseControlAttribute to false
unless withCredentials is set to true in the XHR.

QtWebkit will set CookieLoad/SaveControlAttribute to false unless withCredentials
is set to true in the XHR.

Qt will pass the values onto QHttpNetworkRequest and this will permit
the Qt network access processing to decide whether or not to add either
or both of the Cookie/Authorisation headers, and whether to save cookies
returned from such requests. By default the attribute
will always be true so unless QtWebKit sets it to false normal
header processing is unaffected.

There are platform-specific results for cross-origin-no-authorization.html:

  1. Qt's DRT does not capture the final 'DONE'.
  2. QNetworkReplyHandler.cpp's ignoreHttpError() means that async requests do not execute didFail() when they receive a 401 HTTP response. This results in async tests passing with '401 Authorisation required' rather than 'received error event'.

The Qt part of these changes was merged at: ​http://gitorious.org/qt/qt/merge_requests/592

In order to properly support the tests, Qt's DRT needs to use one
NetworkAccessManager for all pages. This allows it to use cached
credentials where appropriate.

The tests now pass when run individually but there seems to be a problem with
leaking the results of requests across tests when run with the others in
http/tests. This will be addressed in a separate patch.

​https://bugs.webkit.org/show_bug.cgi?id=32967

  • DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::WebPage::WebPage): (WebCore::DumpRenderTree::DumpRenderTree):
  • DumpRenderTree/qt/DumpRenderTreeQt.h:
  • platform/network/qt/ResourceRequestQt.cpp: (WebCore::ResourceRequest::toNetworkRequest):
  • platform/qt/Skipped: Group together the tests that are waiting for 4.7 to be unskipped.
  • platform/qt/http/tests/xmlhttprequest/cross-origin-no-authorization-expected.txt: Added.
6:25 AM Changeset in webkit [59668] by zherczeg@webkit.org
  • 2 edits in trunk/WebCore

[Qt] Implementing clipToImageBuffer for Qt port.
​https://bugs.webkit.org/show_bug.cgi?id=24289

Reviewed by Kenneth Rohde Christiansen.

The implementation combines pixmap layers and destinationIn
composition mode.

  • platform/graphics/qt/GraphicsContextQt.cpp:

(WebCore::TransparencyLayer::TransparencyLayer):
(WebCore::GraphicsContextPlatformPrivate::GraphicsContextPlatformPrivate):
(WebCore::GraphicsContext::savePlatformState):
(WebCore::GraphicsContext::restorePlatformState):
(WebCore::GraphicsContext::inTransparencyLayer):
(WebCore::GraphicsContext::beginTransparencyLayer):
(WebCore::GraphicsContext::endTransparencyLayer):
(WebCore::GraphicsContext::clipToImageBuffer):

4:04 AM Changeset in webkit [59667] by eric@webkit.org
  • 3 edits in trunk/WebCore

2010-05-18 Eric Seidel <​eric@webkit.org>

Unreviewed build fix.

Make it possible to enable the new HTML5Tokenizer for testing
​https://bugs.webkit.org/show_bug.cgi?id=39275

  • WebCore.gypi:
    • Fix HTMLLexer.* -> HTML5Lexer.*
  • WebCore.vcproj/WebCore.vcproj:
    • Add HTML5Lexer and HTML5Tokenizer to project.
3:40 AM Changeset in webkit [59666] by ukai@chromium.org
  • 3 edits in trunk/WebKitTools

2010-05-18 Fumitoshi Ukai <​ukai@chromium.org>

Reviewed by Eric Seidel.

run_webkit_tests_unittest fails on SnowLeopard
​https://bugs.webkit.org/show_bug.cgi?id=39279

  • Scripts/webkitpy/layout_tests/port/base.py: Return copy of os.environ.
  • Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py: Check os.environ was not modified.
3:38 AM Changeset in webkit [59665] by eric@webkit.org
  • 4 edits in trunk/WebCore

2010-05-18 Eric Seidel <​eric@webkit.org>

Unreviewed build fix.

Make it possible to enable the new HTML5Tokenizer for testing
​https://bugs.webkit.org/show_bug.cgi?id=39275

  • dom/NamedAttrMap.cpp: (WebCore::NamedNodeMap::setNamedItemNS):
    • Move this to the .cpp file so as to avoid needing to include "Node.h" in the header.
  • dom/NamedAttrMap.h:
  • html/HTML5Token.h:
    • Remove #include "String.h" which was wrong. Adam meant "PlatformString.h"
    • Remove unneeded #include "Node.h", it was only needed because NamedAttrMap.h was incorrectly depending on Node.h but not including it. It didn't actually need Node.h except for one inlined method setNamedItemNS, so I moved setNamedItemNS into the .cpp to get rid of the Node.h requirement.
3:17 AM Changeset in webkit [59664] by eric@webkit.org
  • 20 edits
    2 copies in trunk

2010-05-18 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Make it possible to enable the new HTML5Tokenizer for testing
​https://bugs.webkit.org/show_bug.cgi?id=39275

I added html5ParserEnabled to Settings so that we can enable/disable
the HTML5 parser for testing.

I also ripped out a bunch of dead code from HTML5Lexer.

I had to add HTML5Lexer/HTML5Tokenizer to all build systems so that
the build wouldn't fail now that we reference these classes from HTMLDocument.

  • Android.mk:
  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.xcodeproj/project.pbxproj:
  • html/HTML5Lexer.cpp: (WebCore::HTML5Lexer::reset): (WebCore::isWhitespace): (WebCore::HTML5Lexer::nextToken):
  • html/HTML5Lexer.h:
  • html/HTML5Tokenizer.cpp: Added. (WebCore::HTML5Tokenizer::HTML5Tokenizer): (WebCore::HTML5Tokenizer::~HTML5Tokenizer): (WebCore::HTML5Tokenizer::begin): (WebCore::HTML5Tokenizer::write): (WebCore::HTML5Tokenizer::end): (WebCore::HTML5Tokenizer::finish): (WebCore::HTML5Tokenizer::isWaitingForScripts):
  • html/HTML5Tokenizer.h: Added.
  • html/HTMLDocument.cpp: (WebCore::HTMLDocument::createTokenizer):
  • html/HTMLTokenizer.h:
  • html/HTMLViewSourceDocument.cpp: (WebCore::HTMLViewSourceDocument::createTokenizer):
  • page/Settings.cpp: (WebCore::Settings::Settings):
  • page/Settings.h: (WebCore::Settings::setHTML5ParserEnabled): (WebCore::Settings::html5ParserEnabled):

2010-05-18 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth (and Maciej Stachowiak).

Make it possible to enable the new HTML5Tokenizer for testing
​https://bugs.webkit.org/show_bug.cgi?id=39275

Expose the WebCore::Settings::html5ParserEnabled as a private WebKit setting.

  • WebView/WebPreferenceKeysPrivate.h:
  • WebView/WebPreferences.mm: (-[WebPreferences html5ParserEnabled]): (-[WebPreferences setHTML5ParserEnabled:]):
  • WebView/WebPreferencesPrivate.h:
  • WebView/WebView.mm: (-[WebView _preferencesChangedNotification:]):
2:08 AM Changeset in webkit [59663] by abarth@webkit.org
  • 4 edits
    1 add in trunk/WebCore

2010-05-18 Maciej Stachowiak <​mjs@apple.com>

Not reviewed, build fix.

Attempt to fix build for v8 bindings (untested).

  • bindings/v8/ScriptController.cpp: (WebCore::ScriptController::clearWindowShell):
  • bindings/v8/ScriptController.h:
2:04 AM Changeset in webkit [59662] by mjs@apple.com
  • 3 edits in trunk/WebCore

Not reviewed, build fix.

Attempt to fix build for v8 bindings (untested).

  • bindings/v8/ScriptController.cpp:

(WebCore::ScriptController::clearWindowShell):

  • bindings/v8/ScriptController.h:
1:52 AM Changeset in webkit [59661] by ukai@chromium.org
  • 4 edits
    1 add in trunk/WebKitTools

2010-05-18 Fumitoshi Ukai <​ukai@chromium.org>

Reviewed by Eric Seidel.

Chromium: new-run-webkit-httpd fails to setup_mount
​https://bugs.webkit.org/show_bug.cgi?id=39257

  • Scripts/webkitpy/common/system/executive.py: Assert type of args in run_command.
  • Scripts/webkitpy/common/system/executive_unittest.py: Add test_run_command_args_type
  • Scripts/webkitpy/layout_tests/port/chromium_win.py: Executive.run_command takes array for command line.
  • Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py: Test if setup_environ_for_server() run setup_mount.bat.
1:42 AM Changeset in webkit [59660] by Simon Hausmann
  • 2 edits in trunk/WebKit/qt

Fix QWebHistory serialization.

Patch by Jedrzej Nowacki <​jedrzej.nowacki@nokia.com> on 2010-05-18
Reviewed by Simon Hausmann.

Regression was caused by bug 33224. The streaming function
should generate a documentSequenceNumber for all loaded values.

[Qt] tst_QWebHistory::serialize_2() fails
​https://bugs.webkit.org/show_bug.cgi?id=37322

  • Api/qwebhistory.cpp:

(operator>>):

1:09 AM Changeset in webkit [59659] by mjs@apple.com
  • 5 edits in trunk/WebCore

2010-05-17 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Oliver Hunt.

GC more promptly when navigating to a new inner window, but not at all when it went in the page cache
​https://bugs.webkit.org/show_bug.cgi?id=39254
<rdar://problem/7996370>

~1% PLT speedup
~4% iBench HTML speedup

  • bindings/js/GCController.cpp: (WebCore::GCController::garbageCollectSoon): Change back to a 0 delay timer instead of 0.5 second.
  • bindings/js/ScriptController.cpp: (WebCore::ScriptController::clearWindowShell): Add a new boolean parameter. Don't garbageColectSoon if the page is going into the page cache.
  • bindings/js/ScriptController.h: Prototype change for above.
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::clear): Indicate when the page is going into the page cache.
12:24 AM Changeset in webkit [59658] by abarth@webkit.org
  • 3 edits in trunk/WebCore

2010-05-18 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Implement ScriptData states for HTML5Lexer
​https://bugs.webkit.org/show_bug.cgi?id=39273

This patch implements more of the lexer states according to the HTML5
specification. Currently, this code is compiled by not tested. We're
working on bringing up a test harness in parallel with transliterating
the spec into code.

  • html/HTML5Lexer.cpp: (WebCore::HTML5Lexer::tokenize): (WebCore::HTML5Lexer::temporaryBufferIs):
  • html/HTML5Lexer.h: (WebCore::HTML5Lexer::):
12:00 AM Changeset in webkit [59657] by eric@webkit.org
  • 2 edits
    2 moves in trunk/WebCore

2010-05-17 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Rename HTML5Tokenzier to HTML5Lexer so that we can add a new HTML5Tokenizer which implements Tokenizer
​https://bugs.webkit.org/show_bug.cgi?id=39272

Strictly a rename, no functionality change.

  • WebCore.xcodeproj/project.pbxproj:
  • html/HTML5Lexer.cpp: Added.
  • html/HTML5Lexer.h: Added.
  • html/HTML5Tokenizer.cpp: Removed.
  • html/HTML5Tokenizer.h: Removed.

May 17, 2010:

11:01 PM Changeset in webkit [59656] by atwilson@chromium.org
  • 1 edit
    4 adds in trunk/LayoutTests

Unreviewed test expectations update for chromium.

  • platform/chromium-mac/html5lib/runner-expected.txt: Added.
  • platform/chromium-win/html5lib/runner-expected.txt: Added.
10:56 PM Changeset in webkit [59655] by tkent@chromium.org
  • 8 edits in trunk

2010-05-17 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r59652.
​http://trac.webkit.org/changeset/59652
​https://bugs.webkit.org/show_bug.cgi?id=39268

file-input-files-access test is broken on Mac (Requested by
dcheng on #webkit).

  • editing/pasteboard/file-input-files-access-expected.txt:
  • editing/pasteboard/script-tests/file-input-files-access.js: (runTest):
  • http/tests/security/clipboard/script-tests/clipboard-file-access.js:

2010-05-17 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r59652.
​http://trac.webkit.org/changeset/59652
​https://bugs.webkit.org/show_bug.cgi?id=39268

file-input-files-access test is broken on Mac (Requested by
dcheng on #webkit).

  • platform/chromium/DragDataChromium.cpp: (WebCore::DragData::asURL):

2010-05-17 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r59652.
​http://trac.webkit.org/changeset/59652
​https://bugs.webkit.org/show_bug.cgi?id=39268

file-input-files-access test is broken on Mac (Requested by
dcheng on #webkit).

  • Misc/WebNSPasteboardExtras.mm: (-[NSPasteboard _web_bestURL]):
10:51 PM Changeset in webkit [59654] by abarth@webkit.org
  • 3 edits in trunk/WebCore

2010-05-17 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Implement RAWTEXT tokenizer states
​https://bugs.webkit.org/show_bug.cgi?id=39267

More tokenizer states. There's a bunch of functionality notImplemented
that we'll come back to.

  • html/HTML5Tokenizer.cpp: (WebCore::HTML5Tokenizer::tokenize):
  • html/HTML5Tokenizer.h:
10:17 PM Changeset in webkit [59653] by abarth@webkit.org
  • 3 edits in trunk/WebCore

2010-05-17 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Implement more parser states in HTML5Tokenizer
​https://bugs.webkit.org/show_bug.cgi?id=39265

This patch implements some easy states. I'll come back and do the
harder states later.

  • html/HTML5Tokenizer.cpp: (WebCore::HTML5Tokenizer::tokenize): (WebCore::HTML5Tokenizer::emitParseError):
  • html/HTML5Tokenizer.h:
10:11 PM Changeset in webkit [59652] by tkent@chromium.org
  • 8 edits in trunk

2010-05-17 Daniel Cheng <​dcheng@chromium.org>

DragData::asURL() shouldn't do file validity checks
​https://bugs.webkit.org/show_bug.cgi?id=38711

Several layout tests depended on the fact that dropping a file would
never trigger navigation. This never happened to occur in the past,
since it just so happened that the filenames used in the tests never
resolved to files that exist. Since DragData::asURL() no longer tries
to verify file existence, the layout tests were updated to either
suppress navigation or log any navigation that should occur as part of
the test.

  • editing/pasteboard/file-input-files-access-expected.txt:
  • editing/pasteboard/script-tests/file-input-files-access.js: (runTest.window.onbeforeunload): (runTest):
  • http/tests/security/clipboard/script-tests/clipboard-file-access.js:

2010-05-17 Daniel Cheng <​dcheng@chromium.org>

Reviewed by Darin Adler.

DragData::asURL() shouldn't do file validity checks
​https://bugs.webkit.org/show_bug.cgi?id=38711

There's no point to trying to make sure the file is valid in
DragData::asURL(). It's better to ask for forgiveness than to ask for
permission, since asking for permission is prone to race conditions
and results in unnecessary I/O. Consumers of this function either:

  • need to verify the file exists themselves (e.g. the loader)
  • don't care about file validity (rich text drag-and-drop)
  • platform/chromium/DragDataChromium.cpp: (WebCore::DragData::asURL):

2010-05-17 Daniel Cheng <​dcheng@chromium.org>

Reviewed by Darin Adler.

DragData::asURL() shouldn't do file validity checks
​https://bugs.webkit.org/show_bug.cgi?id=38711

Change [NSPasteboard _web_bestURL] to still return a file URL for paths
that don't exist. Callers who care about the existence of the file or
whether or not it is a directory should check themselves when they
want to use the file. The directory check has been left in for now,
since the Mac implementation of ResourceHandle, which uses this function
indirectly via DragController::performDrag) handles directories somewhat
non-intuitively: it opens the parent directory in the Finder, rather
than opening the directory itself.

  • Misc/WebNSPasteboardExtras.mm: (-[NSPasteboard _web_bestURL]):
10:05 PM Changeset in webkit [59651] by tkent@chromium.org
  • 6 edits in trunk

Unreviewed. Roll out r59650.
A workaround of a buildbot issue triggered by r59650 wasn't resolved by r59646.

9:56 PM Changeset in webkit [59650] by tkent@chromium.org
  • 6 edits in trunk

[DRT/Chromium] Fix repaint, WebGL, textarea tests
​https://bugs.webkit.org/show_bug.cgi?id=39054

Reviewed by Dimitri Glazkov.

WebKit/chromium:

  • DEPS: Update to Chromium r47248 to use a fix for CommandLine assertion and textAreaResizeCorner.png
  • WebKit.gyp: Add textAreaResizeCorner.png as a Mac resource
  • features.gypi: Enable ENABLE_3D_CANVAS.

WebKitTools:

  • DumpRenderTree/chromium/WebViewHost.cpp:

(WebViewHost::canvas): Remove m_paintRect initialization in canvas().

This line updated m_paintRect unexpectedly during paintRect().
We don't need to initialize m_paintRect because show() does it.

9:46 PM Changeset in webkit [59649] by yuzo@google.com
  • 1 edit
    2 adds in trunk/LayoutTests

2010-05-16 Yuzo Fujishima <​yuzo@google.com>

Reviewed by Darin Adler.

Add tests for Bug 31267 - :nth-child(-2n) should match no element.
​http://trac.webkit.org/changeset/58300 has fixed this already.
​https://bugs.webkit.org/show_bug.cgi?id=31267

  • fast/css/nth-child-negative-a-param-expected.txt: Added.
  • fast/css/nth-child-negative-a-param.html: Added.
9:27 PM Changeset in webkit [59648] by abarth@webkit.org
  • 3 edits in trunk/WebCore

2010-05-17 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Update states in HTML5Tokenizer to match HTML5 spec
​https://bugs.webkit.org/show_bug.cgi?id=39264

I've also implemented the DataState. More states to follow.

  • html/HTML5Tokenizer.cpp: (WebCore::HTML5Tokenizer::reset): (WebCore::HTML5Tokenizer::tokenize):
  • html/HTML5Tokenizer.h: (WebCore::HTML5Tokenizer::):
9:24 PM Changeset in webkit [59647] by tkent@chromium.org
  • 3 edits in trunk/LayoutTests

Unreviewed.

Update a test for the behavior change of r59645.
​https://bugs.webkit.org/show_bug.cgi?id=39162

  • fast/forms/script-tests/willvalidate.js:
  • fast/forms/willvalidate-expected.txt:
9:04 PM Changeset in webkit [59646] by tkent@chromium.org
  • 2 edits in trunk/WebKitTools

Chromium Windows build system does not rebuild correctly when
enabling/disabling a feature
​https://bugs.webkit.org/show_bug.cgi?id=38926

Reviewed by David Levin.

Add a workaround of this issue.

  • Scripts/update-webkit: Chromium-Windows only: If WebKit/chromium/features.gyp has been updated, remove WebKit/chromium/Debug and WebKit/chromium/Release.
8:57 PM Changeset in webkit [59645] by tkent@chromium.org
  • 7 edits in trunk

':valid' CSS selector should not be applied to some form controls
​https://bugs.webkit.org/show_bug.cgi?id=39162

Reviewed by Darin Adler.

WebCore:

  • html/HTMLElement.cpp:

(WebCore::inlineTagList): Always includes progressTag. This change is
needed in a case of no ENABLE_PROGRESS_TAG. Without this change and
ENABLE_PROGRESS_TAG, <progress> tags disappear.

  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::recalcWillValidate):

Return false for SUBMIT and IMAGE.

  • html/HTMLProgressElement.h:

(WebCore::HTMLProgressElement::recalcWillValidate):

Return false. This change is needed in a case of ENABLE_PROGRESS_TAG.

LayoutTests:

Add test cases for

  • <input type=submit>
  • <input type=image>
  • <progress>
  • <meter>
  • fast/css/pseudo-valid-unapplied-expected.txt:
  • fast/css/pseudo-valid-unapplied.html:
8:41 PM Changeset in webkit [59644] by abarth@webkit.org
  • 3 edits in trunk/WebCore

2010-05-17 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Remove load-related code from HTML5Tokenizer
​https://bugs.webkit.org/show_bug.cgi?id=39263

This code is related to reloading resources and not to tokenizing. In
the PreloadScanner, these concerns are coupled, but we want to decouple
them.

  • html/HTML5Tokenizer.cpp: (WebCore::HTML5Tokenizer::HTML5Tokenizer): (WebCore::HTML5Tokenizer::~HTML5Tokenizer): (WebCore::HTML5Tokenizer::begin): (WebCore::HTML5Tokenizer::end): (WebCore::HTML5Tokenizer::reset): (WebCore::HTML5Tokenizer::write): (WebCore::HTML5Tokenizer::consumeEntity): (WebCore::HTML5Tokenizer::tokenize): (WebCore::HTML5Tokenizer::processAttribute): (WebCore::HTML5Tokenizer::emitCharacter): (WebCore::HTML5Tokenizer::emitTag):
  • html/HTML5Tokenizer.h:
8:25 PM Changeset in webkit [59643] by abarth@webkit.org
  • 2 edits in trunk/WebCore

2010-05-17 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Add HTML5Tokenizer to the build system on Mac
​https://bugs.webkit.org/show_bug.cgi?id=39262

This file will be easier to work with if we're actually compiling it.
Hopefully we'll get this wired into the PreloadScanner soon. Once we
start actually calling the code, we'll add it to the build system on
other platforms.

  • WebCore.xcodeproj/project.pbxproj:
8:24 PM Changeset in webkit [59642] by barraclough@apple.com
  • 2 edits in trunk/JavaScriptCore

Oops, meant ebx not eax there. Fix Qt (and probably Win too).

Reviewed by Geoff Garen.

  • jit/JITOpcodes32_64.cpp:
8:21 PM Changeset in webkit [59641] by eric@webkit.org
  • 3 edits in trunk/WebCore

2010-05-17 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Copy PreloadScanner.* to HTML5Tokenizer.* to start work on the new HTML5 Tokenizer
​https://bugs.webkit.org/show_bug.cgi?id=39261

  • html/HTML5Tokenizer.cpp: Rename PreloadScanner to HTML5Tokenizer.
  • html/HTML5Tokenizer.h: ditto.
8:15 PM Changeset in webkit [59640] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-05-17 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Copy PreloadScanner.* to HTML5Tokenizer.* to start work on the new HTML5 Tokenizer
​https://bugs.webkit.org/show_bug.cgi?id=39261

This time copy the cpp from the right file.

  • html/HTML5Tokenizer.cpp: Copied from WebCore/html/PreloadScanner.cpp.
8:08 PM Changeset in webkit [59639] by eric@webkit.org
  • 1 edit
    2 adds in trunk/WebCore

2010-05-17 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Copy PreloadScanner.* to HTML5Tokenizer.* to start work on the new HTML5 Tokenizer
​https://bugs.webkit.org/show_bug.cgi?id=39261

  • html/HTML5Tokenizer.cpp: Copied from WebCore/html/PreloadScanner.h.
  • html/HTML5Tokenizer.h: Copied from WebCore/html/PreloadScanner.h.
8:06 PM Changeset in webkit [59638] by abarth@webkit.org
  • 1 edit
    21 adds in trunk/LayoutTests

2010-05-17 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Add the html5lib HTML parser tests
​https://bugs.webkit.org/show_bug.cgi?id=39260

We currently fail a bunch of these. Hopefully we'll get better as we
implement the HTML5 parser.

Source: ​http://gsnedders.html5.org/html5lib-tests/runner.html

  • html5lib/resources/dom2string.js: Added. (String.prototype.toAsciiLowerCase): (indent): (dom2string):
  • html5lib/resources/tests1.dat: Added.
  • html5lib/resources/tests10.dat: Added.
  • html5lib/resources/tests11.dat: Added.
  • html5lib/resources/tests12.dat: Added.
  • html5lib/resources/tests13.dat: Added.
  • html5lib/resources/tests14.dat: Added.
  • html5lib/resources/tests15.dat: Added.
  • html5lib/resources/tests16.dat: Added.
  • html5lib/resources/tests2.dat: Added.
  • html5lib/resources/tests3.dat: Added.
  • html5lib/resources/tests4.dat: Added.
  • html5lib/resources/tests5.dat: Added.
  • html5lib/resources/tests6.dat: Added.
  • html5lib/resources/tests7.dat: Added.
  • html5lib/resources/tests8.dat: Added.
  • html5lib/resources/tests9.dat: Added.
  • html5lib/runner-expected.txt: Added.
  • html5lib/runner.html: Added.
7:39 PM Changeset in webkit [59637] by barraclough@apple.com
  • 20 edits in trunk/JavaScriptCore

Bug 39252 - Move host/native JSFunction's NativeFunction onto NativeExecutable.

Reviewed by Geoff Garen.

Currently host functions reuse JSFunction's ScopeChain as storage for their
NativeFunction (the C function pointer to the host function implementation).
Instead, move this onto NativeExecutable. This will allow host functions to
have a scopechain (which will be implemented as a separate patch).

  • JavaScriptCore.xcodeproj/project.pbxproj:
  • jit/JIT.h:
  • jit/JITCall.cpp:

(JSC::JIT::compileOpCallInitializeCallFrame):
(JSC::JIT::compileOpCall):

  • jit/JITOpcodes.cpp:

(JSC::JIT::privateCompileCTIMachineTrampolines):

  • jit/JITOpcodes32_64.cpp:
  • jit/JITPropertyAccess.cpp:

(JSC::JIT::stringGetByValStubGenerator):
(JSC::JIT::emitSlow_op_get_by_val):

  • jit/JITPropertyAccess32_64.cpp:

(JSC::JIT::stringGetByValStubGenerator):
(JSC::JIT::emitSlow_op_get_by_val):

  • jit/JITStubs.cpp:

(JSC::JITThunks::specializedThunk):

  • jit/JITStubs.h:

(JSC::JITThunks::ctiNativeCall):

  • jit/SpecializedThunkJIT.h:

(JSC::SpecializedThunkJIT::finalize):

  • jit/ThunkGenerators.cpp:

(JSC::charCodeAtThunkGenerator):
(JSC::charAtThunkGenerator):
(JSC::fromCharCodeThunkGenerator):
(JSC::sqrtThunkGenerator):
(JSC::powThunkGenerator):

  • jit/ThunkGenerators.h:
  • runtime/Executable.h:

(JSC::NativeExecutable::create):
(JSC::NativeExecutable::function):
(JSC::NativeExecutable::NativeExecutable):
(JSC::JSFunction::nativeFunction):

  • runtime/JSFunction.cpp:

(JSC::JSFunction::JSFunction):
(JSC::JSFunction::~JSFunction):
(JSC::JSFunction::markChildren):
(JSC::JSFunction::getCallData):
(JSC::JSFunction::call):
(JSC::JSFunction::getOwnPropertySlot):
(JSC::JSFunction::getConstructData):
(JSC::JSFunction::construct):

  • runtime/JSFunction.h:

(JSC::JSFunction::scope):

  • runtime/JSGlobalData.h:

(JSC::JSGlobalData::getThunk):

  • runtime/Lookup.cpp:

(JSC::setUpStaticFunctionSlot):

  • runtime/StringConstructor.cpp:

(JSC::StringConstructor::StringConstructor):

6:38 PM Changeset in webkit [59636] by atwilson@chromium.org
  • 4 edits in trunk/WebKitTools

2010-05-17 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r59631.
​http://trac.webkit.org/changeset/59631
​https://bugs.webkit.org/show_bug.cgi?id=39255

chromium canaries can no longer run webkit_tests, suspect this
change. (Requested by atwilson on #webkit).

  • Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
6:28 PM Changeset in webkit [59635] by morrita@google.com
  • 2 edits in trunk/WebCore

2010-05-17 MORITA Hajime <​morrita@google.com>

Reviewed by Kent Tamura.

[Chromium] Windows: Speed of indeterminate progress bar should be constant
​https://bugs.webkit.org/show_bug.cgi?id=39211

No new tests, animation effect can be confirmed only manually.

  • rendering/RenderThemeChromiumWin.cpp: (WebCore::RenderThemeChromiumWin::animationDurationForProgressBar): (WebCore::RenderThemeChromiumWin::paintProgressBar):
5:58 PM Changeset in webkit [59634] by atwilson@chromium.org
  • 2 edits in trunk/WebCore

Unreviewed build fix for Qt and Chromium. Added missing #include in Frame.h.

​https://bugs.webkit.org/show_bug.cgi?id=39147

  • page/Frame.h: Now includes CSSMutableStyleDeclaration.h.
5:19 PM Changeset in webkit [59633] by Simon Fraser
  • 2 edits in trunk/WebCore

2010-05-17 Simon Fraser <Simon Fraser>

Reviewed by Darin Adler.

Remove unused member member from Document
​https://bugs.webkit.org/show_bug.cgi?id=39251

Remove m_associatedHistoryItems from Document; it is never used.

  • dom/Document.h:
5:15 PM Changeset in webkit [59632] by Darin Adler
  • 3 edits in trunk/WebCore

Fix Qt build.

  • page/Frame.cpp:

(WebCore::Frame::setTypingStyle): Move back to make non-inline.

  • page/Frame.h: Removed inline version of setTypingStyle.
5:15 PM Changeset in webkit [59631] by eric@webkit.org
  • 4 edits in trunk/WebKitTools

2010-05-17 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Attempt to make new-run-webkit-tests --help more sane
​https://bugs.webkit.org/show_bug.cgi?id=37836

  • Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
    • Add a FIXME about options.singly and options.batch_size being different.
  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
    • Add support for hidden options.
    • Add option groupings to attempt to simplify --help.
    • Fix a bunch of option helps to start with a capitalized verb.
    • Hide a bunch of options which make no sense to users.
    • Sort options in --help.
  • Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
    • Add tests for option sorting.
4:48 PM Changeset in webkit [59630] by Darin Adler
  • 4 edits in trunk/WebCore

2010-05-14 Darin Adler <Darin Adler>

Reviewed by Brady Eidson.

Frame has many trivial member functions that should be inlined
​https://bugs.webkit.org/show_bug.cgi?id=39147

  • WebCore.base.exp: Export the functions that are now inlined.
  • page/Frame.cpp: (WebCore::Frame::removeEditingStyleFromBodyElement): Removed the body of this function.
  • page/Frame.h: (WebCore::Frame::init): Moved here from .cpp. (WebCore::Frame::loader): Ditto. (WebCore::Frame::redirectScheduler): Ditto. (WebCore::Frame::view): Ditto. (WebCore::Frame::script): Ditto. (WebCore::Frame::document): Ditto. (WebCore::Frame::selection): Ditto. (WebCore::Frame::editor): Ditto. (WebCore::Frame::animation): Ditto. (WebCore::Frame::mark): Ditto. (WebCore::Frame::setMark): Ditto. (WebCore::Frame::zoomFactor): Ditto. (WebCore::Frame::jsStatusBarText): Ditto. (WebCore::Frame::jsDefaultStatusBarText): Ditto. (WebCore::Frame::needsReapplyStyles): Ditto. (WebCore::Frame::typingStyle): Ditto. (WebCore::Frame::setTypingStyle): Ditto. (WebCore::Frame::clearTypingStyle): Ditto. (WebCore::Frame::ownerElement): Ditto. (WebCore::Frame::isDisconnected): Ditto. (WebCore::Frame::setIsDisconnected): Ditto. (WebCore::Frame::excludeFromTextSearch): Ditto. (WebCore::Frame::setExcludeFromTextSearch): Ditto. (WebCore::Frame::inViewSourceMode): Ditto. (WebCore::Frame::setInViewSourceMode): Ditto. (WebCore::Frame::markedTextMatchesAreHighlighted): Ditto. (WebCore::Frame::tree): Ditto. (WebCore::Frame::page): Ditto. (WebCore::Frame::detachFromPage): Ditto. (WebCore::Frame::eventHandler): Ditto. (WebCore::Frame::shouldClose): Ditto.
4:03 PM Changeset in webkit [59629] by andersca@apple.com
  • 11 edits in trunk/WebCore

2010-05-17 Anders Carlsson <​andersca@apple.com>

Reviewed by Sam Weinig.

​https://bugs.webkit.org/show_bug.cgi?id=39247
<rdar://problem/7994707>
Move rarely used data members to the rare structures, thus saving memory.

Move rarely used member variables from StyleInheritedData and StyleVisualData to
StyleRareInheritedData and StyleRareNonInheritedData, namely:

indent, cursorData, m_effectiveZoom, widows and orphans move from StyleInheritedData to StyleRareInheritedData.
m_counterIncrement and m_counterReset move from StyleVisualData to StyleRareNonInheritedData.

  • rendering/style/RenderStyle.cpp: (WebCore::RenderStyle::diff): (WebCore::RenderStyle::addCursor): (WebCore::RenderStyle::setCursorList): (WebCore::RenderStyle::clearCursorList):
  • rendering/style/RenderStyle.h: (WebCore::InheritedFlags::textIndent): (WebCore::InheritedFlags::effectiveZoom): (WebCore::InheritedFlags::counterIncrement): (WebCore::InheritedFlags::counterReset): (WebCore::InheritedFlags::cursors): (WebCore::InheritedFlags::widows): (WebCore::InheritedFlags::orphans): (WebCore::InheritedFlags::setTextIndent): (WebCore::InheritedFlags::setEffectiveZoom): (WebCore::InheritedFlags::setCounterIncrement): (WebCore::InheritedFlags::setCounterReset): (WebCore::InheritedFlags::setWidows): (WebCore::InheritedFlags::setOrphans):
  • rendering/style/StyleInheritedData.cpp: (WebCore::StyleInheritedData::StyleInheritedData): (WebCore::StyleInheritedData::operator==):
  • rendering/style/StyleInheritedData.h:
  • rendering/style/StyleRareInheritedData.cpp: (WebCore::StyleRareInheritedData::StyleRareInheritedData): (WebCore::cursorDataEquivalent): (WebCore::StyleRareInheritedData::operator==):
  • rendering/style/StyleRareInheritedData.h:
  • rendering/style/StyleRareNonInheritedData.cpp: (WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData): (WebCore::StyleRareNonInheritedData::operator==):
  • rendering/style/StyleRareNonInheritedData.h:
  • rendering/style/StyleVisualData.cpp: (WebCore::StyleVisualData::StyleVisualData):
  • rendering/style/StyleVisualData.h: (WebCore::StyleVisualData::operator==):
3:25 PM Changeset in webkit [59628] by jamesr@google.com
  • 6 edits
    4 adds in trunk/LayoutTests

2010-05-17 James Robinson <​jamesr@chromium.org>

Reviewed by Darin Adler.

Rebaseline fast/multicol pixel results on mac
​https://bugs.webkit.org/show_bug.cgi?id=39241

  • fast/multicol/client-rects-expected.checksum:
  • fast/multicol/client-rects-expected.png:
  • platform/mac/fast/multicol/float-multicol-expected.png:
  • platform/mac/fast/multicol/layers-in-multicol-expected.checksum: Added.
  • platform/mac/fast/multicol/layers-in-multicol-expected.png: Added.
  • platform/mac/fast/multicol/nested-columns-expected.checksum: Added.
  • platform/mac/fast/multicol/nested-columns-expected.png: Added.
  • platform/mac/fast/multicol/positioned-with-constrained-height-expected.checksum:
  • platform/mac/fast/multicol/positioned-with-constrained-height-expected.png:
3:21 PM Changeset in webkit [59627] by atwilson@chromium.org
  • 8 edits
    6 adds in trunk/LayoutTests

Unreviewed. Update Chromium test expectations.

  • platform/chromium-linux/fast/multicol/layers-in-multicol-expected.checksum:
  • platform/chromium-linux/fast/multicol/layers-in-multicol-expected.png:
  • platform/chromium-linux/fast/multicol/nested-columns-expected.checksum: Added.
  • platform/chromium-linux/fast/multicol/nested-columns-expected.png: Added.
  • platform/chromium-mac/fast/multicol/layers-in-multicol-expected.checksum:
  • platform/chromium-mac/fast/multicol/layers-in-multicol-expected.png:
  • platform/chromium-mac/fast/multicol/nested-columns-expected.checksum: Added.
  • platform/chromium-mac/fast/multicol/nested-columns-expected.png: Added.
  • platform/chromium-win/fast/multicol/layers-in-multicol-expected.checksum:
  • platform/chromium-win/fast/multicol/layers-in-multicol-expected.png:
  • platform/chromium-win/fast/multicol/layers-in-multicol-expected.txt:
  • platform/chromium-win/fast/multicol/nested-columns-expected.checksum: Added.
  • platform/chromium-win/fast/multicol/nested-columns-expected.png: Added.
1:46 PM QtWebKitTableOfFeatures20 edited by noam.rosenthal@nokia.com
(diff)
1:45 PM Changeset in webkit [59626] by robert@webkit.org
  • 2 edits in trunk/WebCore

2010-05-17 Robert Hogan <​robert@webkit.org>

Rubber-stamped by Eric Seidel.

Fix --no-svg build.

I have no idea where the SVG-dependent include of this file is hidden, but
it is probably better to include it explicitly anyway like V8WorkerContextCustom.cpp.

  • bindings/js/JSWorkerContextCustom.cpp:
1:39 PM Changeset in webkit [59625] by atwilson@chromium.org
  • 1 edit
    1 add in trunk/LayoutTests

Unreviewd: Update Chromium test expectations.

  • platform/chromium-win/fast/multicol/nested-columns-expected.txt: Added.
1:29 PM Changeset in webkit [59624] by hyatt@apple.com
  • 3 edits in trunk

​https://bugs.webkit.org/show_bug.cgi?id=39231

Reviewed by Dan Bernstein.

Fix failures in the RTL portion of fast/multicol/layers-in-multicol.html. Make sure block children of RTL blocks are positioned using
the reduced column width instead of the total content width.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::determineHorizontalPosition):
(WebCore::RenderBlock::nodeAtPoint):
(WebCore::RenderBlock::hitTestContents):
(WebCore::RenderBlock::adjustForColumns):

12:36 PM Changeset in webkit [59623] by robert@webkit.org
  • 7 edits
    4 adds in trunk

2010-05-17 Robert Hogan <​robert@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Disable Icon Database by default in Qt DRT

Unskip:

http/tests/misc/favicon-loads-with-images-disabled.html
http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-in-body.html
http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-deny.html
http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag.html

Qt returns 5 (QNetworkReply::OperationCanceledError) instead of -999 for the XFrameOptions tests,
so update accordingly.

​https://bugs.webkit.org/show_bug.cgi?id=37382

  • platform/qt/Skipped:
  • platform/qt/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-expected.txt: Added. Qt returns 5 instead of -999.
  • platform/qt/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-in-body-expected.txt: Added. Qt returns 5 instead of -999.
  • platform/qt/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-deny-expected.txt: Added. Qt returns 5 instead of -999.

2010-05-17 Robert Hogan <​robert@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Disable Icon Database by default in Qt DRT

Unskip:

http/tests/misc/favicon-loads-with-images-disabled.html
http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-in-body.html
http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-deny.html
http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag.html

​https://bugs.webkit.org/show_bug.cgi?id=37382

Add support for layoutTestController.setIconDatabaseEnabled and layoutTestController.disableImageLoading().
The XFrameOptions tests were failing because of an extra resource load callback for favicon.ico requests.
These extra callbacks are removed by supporting both of the above layoutTestContoller commands.

  • DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::WebPage::resetSettings): (WebCore::DumpRenderTree::DumpRenderTree):
  • DumpRenderTree/qt/DumpRenderTreeQt.h: (WebCore::DumpRenderTree::drtStoragePath):
  • DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::reset): (LayoutTestController::disableImageLoading): (LayoutTestController::setIconDatabaseEnabled):
  • DumpRenderTree/qt/LayoutTestControllerQt.h:
12:33 PM Changeset in webkit [59622] by mrowe@apple.com
  • 12 edits in branches/safari-533-branch

<rdar://problem/7987585> Disable SVG filters.

JavaScriptCore:

  • Configurations/FeatureDefines.xcconfig:

WebCore:

  • Configurations/FeatureDefines.xcconfig:

WebKit/mac:

  • Configurations/FeatureDefines.xcconfig:

WebKit2:

  • Configurations/FeatureDefines.xcconfig:

WebKitLibraries:

  • win/tools/vsprops/FeatureDefines.vsprops:

WebKitTools:

  • Scripts/build-webkit:
12:32 PM Changeset in webkit [59621] by mrowe@apple.com
  • 9 edits in branches/safari-533-branch

<rdar://problem/7987743> Disable Blob.slice.

JavaScriptCore:

  • Configurations/FeatureDefines.xcconfig:

WebCore:

  • Configurations/FeatureDefines.xcconfig:

WebKit/mac:

  • Configurations/FeatureDefines.xcconfig:

WebKit2:

  • Configurations/FeatureDefines.xcconfig:
12:32 PM Changeset in webkit [59620] by mrowe@apple.com
  • 8 edits in branches/safari-533-branch

<rdar://problem/7987750> Disable progress element.

JavaScriptCore:

  • Configurations/FeatureDefines.xcconfig:

WebCore:

  • Configurations/FeatureDefines.xcconfig:

WebKit/mac:

  • Configurations/FeatureDefines.xcconfig:

WebKit2:

  • Configurations/FeatureDefines.xcconfig:
12:09 PM Changeset in webkit [59619] by jpetsovits@rim.com
  • 6 edits
    3 adds in trunk/WebCore

2010-05-17 Jakob Petsovits <​jpetsovits@rim.com>

Reviewed by George Staikos.

[OpenVG] Add support for decoding and drawing images
​https://bugs.webkit.org/show_bug.cgi?id=36072

OpenVG has a maximum image size (how large is
specific to the OpenVG implementation), so this
requires us to store them as separate image tiles.

Image decoding and initial drawing code by
Adam Treat <​atreat@rim.com>. Image decoder
downsampling support by Yong Li <​yoli@rim.com>.

  • platform/graphics/ImageSource.h:
  • platform/graphics/openvg/ImageOpenVG.cpp: Added. (WebCore::FrameData::clear): (WebCore::BitmapImage::BitmapImage): (WebCore::BitmapImage::checkForSolidColor): (WebCore::BitmapImage::initPlatformData): (WebCore::BitmapImage::invalidatePlatformData): (WebCore::adjustSourceRectForDownSampling): (WebCore::BitmapImage::draw): (WebCore::Image::drawPattern): (WebCore::Image::loadPlatformResource):
  • platform/graphics/openvg/PainterOpenVG.cpp: (WebCore::PainterOpenVG::drawImage): (WebCore::PainterOpenVG::asNewNativeImage):
  • platform/graphics/openvg/PainterOpenVG.h:
  • platform/graphics/openvg/TiledImageOpenVG.cpp: Added. (WebCore::TiledImageOpenVG::TiledImageOpenVG): (WebCore::TiledImageOpenVG::operator=): (WebCore::TiledImageOpenVG::~TiledImageOpenVG): (WebCore::TiledImageOpenVG::numTiles): (WebCore::TiledImageOpenVG::numColumns): (WebCore::TiledImageOpenVG::numRows): (WebCore::TiledImageOpenVG::setTile): (WebCore::TiledImageOpenVG::tilesInRect): (WebCore::TiledImageOpenVG::tile): (WebCore::TiledImageOpenVG::tileRect): (WebCore::TiledImageOpenVG::detachTiles): (WebCore::TiledImageOpenVG::destroyTiles):
  • platform/graphics/openvg/TiledImageOpenVG.h: Added. (WebCore::TiledImageOpenVG::size): (WebCore::TiledImageOpenVG::maxTileSize):
  • platform/graphics/openvg/VGUtils.cpp: (WebCore::VGUtils::bytesForImage): (WebCore::VGUtils::bytesForImageScanline): (WebCore::VGUtils::imageFormatBitsPerPixel): (WebCore::VGUtils::endianAwareImageFormat):
  • platform/graphics/openvg/VGUtils.h:
  • platform/image-decoders/openvg/ImageDecoderOpenVG.cpp: Added. (WebCore::RGBA32Buffer::asNewNativeImage):
11:42 AM Changeset in webkit [59618] by yaar@chromium.org
  • 3 edits in trunk/WebCore

2010-05-17 Yaar Schnitman <​yaar@chromium.org>

Reviewed by Darin Adler.

Fix JSC's generation of 'Optional' arguments. When a single 'Optional' extended attribute precedes multiple method arguments, all of these arguments are optional as a group (either all or non must be specified). This fix, which makes JSC compliant with V8 and with the Web IDL specs, is pretty harmless, since Optional is currently not being used anywhere in JSC, but it blocks further work on overloads.
​https://bugs.webkit.org/show_bug.cgi?id=39227

  • bindings/scripts/CodeGeneratorJS.pm:
  • bindings/scripts/test/JS/JSTestObj.cpp: (WebCore::jsTestObjPrototypeFunctionMethodWithNonOptionalArgAndTwoOptionalArgs):
11:05 AM Changeset in webkit [59617] by weinig@apple.com
  • 2 edits in trunk/WebCore

​https://bugs.webkit.org/show_bug.cgi?id=39192
Remove unused PERFECT_HASH code CodeGeneratorJS.

Reviewed by Adam Barth.

  • bindings/scripts/CodeGeneratorJS.pm:
10:57 AM Changeset in webkit [59616] by hyatt@apple.com
  • 1 edit
    2 adds in trunk/LayoutTests

Add a test of columns inside columns. The test also puts a RenderLayer in the 2nd column of the 2nd column
to make sure layer positioning works across nested columns.

Reviewed by Dan Bernstein.

  • fast/multicol/nested-columns.html: Added.
  • platform/mac/fast/multicol/nested-columns-expected.txt: Added.
10:54 AM Changeset in webkit [59615] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-05-17 Jeremy Moskovich <​jeremy@chromium.org>

Reviewed by Jeremy Orlow.

Remove debug code that was introduced to help narrow down the
source of a crash.
​https://bugs.webkit.org/show_bug.cgi?id=36426

No change in behavior, so no new tests.

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::finishedLoadingDocument):
10:43 AM Changeset in webkit [59614] by eric@webkit.org
  • 4 edits in trunk/WebKit/qt

2010-05-17 Tasuku Suzuki <​tasuku.suzuki@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Fix compilation with QT_NO_COMBOBOX
​https://bugs.webkit.org/show_bug.cgi?id=38324

  • WebCoreSupport/ChromeClientQt.cpp: (WebCore::ChromeClientQt::createSelectPopup):
  • WebCoreSupport/QtFallbackWebPopup.cpp:
  • WebCoreSupport/QtFallbackWebPopup.h:
10:32 AM Changeset in webkit [59613] by eric@webkit.org
  • 6 edits
    3 adds in trunk

2010-05-17 Andreas Kling <​andreas.kling@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

Add a test to verify proper behavior of createImageData(ImageData)
and createImageData(width, height) with negative arguments.
​https://bugs.webkit.org/show_bug.cgi?id=39189

Spec link:
​http://www.whatwg.org/specs/web-apps/current-work/#dom-context-2d-createimagedata

  • fast/canvas/canvas-createImageData-expected.txt: Added.
  • fast/canvas/canvas-createImageData.html: Added.
  • fast/canvas/script-tests/canvas-createImageData.js: Added.

2010-05-17 Andreas Kling <​andreas.kling@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

Bring CanvasRenderingContext2D's createImageData() in line with HTML5 spec
Added createImageData(ImageData) which returns a new ImageData with the same size as the one passed.
Changed createImageData(width, height) to use the absolute values of width and height.

​https://bugs.webkit.org/show_bug.cgi?id=39189

Spec link:
​http://www.whatwg.org/specs/web-apps/current-work/#dom-context-2d-createimagedata

Test: fast/canvas/canvas-createImageData.html

  • bindings/js/JSCanvasRenderingContext2DCustom.cpp: (WebCore::JSCanvasRenderingContext2D::createImageData):
  • html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::createImageData):
  • html/canvas/CanvasRenderingContext2D.h:
  • html/canvas/CanvasRenderingContext2D.idl:
8:37 AM Changeset in webkit [59612] by antti.j.koivisto@nokia.com
  • 2 edits in trunk/WebCore

This was missing from previous commit.

  • platform/qt/QWebPageClient.h:

(QWebPageClient::graphicsItemVisibleRect):

8:34 AM Changeset in webkit [59611] by antti.j.koivisto@nokia.com
  • 11 edits in trunk

​https://bugs.webkit.org/show_bug.cgi?id=39218
[Qt] Tiled backing store tiles sometimes flicker when exiting a zoom animation

Reviewed by Kenneth Rohde Christiansen.

WebCore:

Tiles sometimes flicker when exiting a zoom animation. This happens as a result
of the visible rectangle being momentarily out of sync.

Instead of updating the visible rect by explicitly setting it, pull it through
the client and recompute in the WebKit level.

  • page/ChromeClient.h:

(WebCore::ChromeClient::visibleRectForTiledBackingStore):

  • page/Frame.cpp:

(WebCore::Frame::tiledBackingStoreVisibleRect):

  • page/Frame.h:
  • platform/graphics/TiledBackingStore.cpp:

(WebCore::TiledBackingStore::checkVisibleRectChanged):
(WebCore::TiledBackingStore::createTiles):

  • platform/graphics/TiledBackingStore.h:
  • platform/graphics/TiledBackingStoreClient.h:

WebKit/qt:

Tiles sometimes flicker when exiting a zoom animation. This happens as a result
of the visible rectangle being momentarily out of sync.

Instead of updating the visible rect by explicitly setting it, pull it through
the client and recompute in WebKit the level.

  • Api/qgraphicswebview.cpp:

(QGraphicsWebView::paint):

  • WebCoreSupport/ChromeClientQt.cpp:

(WebCore::ChromeClientQt::visibleRectForTiledBackingStore):

  • WebCoreSupport/ChromeClientQt.h:
8:04 AM Changeset in webkit [59610] by Adam Roben
  • 3 edits
    1 add in trunk/WebCore

Periodically try to reset a lost IDirect3DDevice9 until we succeed

This is how MSDN says we must respond to a lost device (see
<​http://msdn.microsoft.com/en-us/library/bb174714(v=VS.85).aspx>).

Only testable by a manual test, unfortunately.

Fixes <rdar://problem/7986906> <​http://webkit.org/b/39139> Pages that
use hardware acceleration don't repaint after waking computer from
sleep

Reviewed by John Sullivan.

  • manual-tests/no-repaint-after-wake-from-sleep.html: Added. This is

the Poster Circle demo from webkit.org/blog, but with instructions for
putting the computer to sleep and waking it up again.

  • platform/graphics/win/WKCACFLayerRenderer.cpp:

(WebCore::WKCACFLayerRenderer::WKCACFLayerRenderer): Initialize new
member that tells us whether we need to try to reset the device before
rendering.
(WebCore::WKCACFLayerRenderer::resize): Changed to tell resetDevice
the reason why the device needs to be reset (which is because the
window's size has changed).
(WebCore::WKCACFLayerRenderer::render): Before we do anything else,
check if we need to reset the device before rendering. If we do, try
to reset it. If that fails, bail out and set a timer to try again
later. If we discover that the device is lost when calling
IDirect3DDevice9::Present and resetting the device fails, bail out and
set a timer to try again later.
(WebCore::WKCACFLayerRenderer::resetDevice): Changed to return a
boolean indicating whether resetting succeeded or not. Added a
ResetReason parameter so callers can specify whey the device needs to
be reset. Before trying to do anything, we call
IDirect3DDevice9::TestCooperativeLevel to find out whether the device
can be reset currently. If it can't, we set a flag to tell ourselves
that the device must be reset before we next render, and indicate to
the caller that the reset failed. If we thought the device was lost
but it turns out not to be, we don't have to do anything and can tell
the caller that the reset succeeded. Otherwise we go ahead and reset
the device as before, and indicate to the caller that the reset
succeeded.

  • platform/graphics/win/WKCACFLayerRenderer.h: Changed resetDevice to

return a boolean and take a ResetReason parameter. Added a comment
about when and why this function should be called. And added
m_mustResetLostDeviceBeforeRendering.

8:04 AM Changeset in webkit [59609] by Adam Roben
  • 2 edits in trunk/WebCore

Call CARenderOGLPurge whenever we call IDirect3DDevice9::Reset

MSDN says that all resoures allocated with D3DPOOL_DEFAULT must be
destroyed before calling IDirect3DDevice9::Reset. The only way to
guarantee this with Core Animation is to call CARenderOGLPurge.

Unfortunately this isn't testable at the moment, as we don't use any
features of Core Animation (e.g., mask layers) that actually make this
required. But it seems like a good idea to fix the code now so that
if/when we do start using those features we won't run into problems.

Fixes <​http://webkit.org/b/39159> WKCACFLayerRenderer::resetDevice
might fail due to failing to destroy all D3DPOOL_DEFAULT resources

Reviewed by John Sullivan.

  • platform/graphics/win/WKCACFLayerRenderer.cpp:

(WebCore::WKCACFLayerRenderer::render): Moved the call to
CARenderOGLPurge from here...
(WebCore::WKCACFLayerRenderer::resetDevice): ...to here, so that it
will be called whenever we reset the device (e.g., when resizing the
window).

7:42 AM Changeset in webkit [59608] by kov@webkit.org
  • 2 edits in trunk/WebCore

2010-05-17 Gustavo Noronha Silva <​gustavo.noronha@collabora.co.uk>

Rubber-stamped by Xan Lopez.

Build fix. Remove bashism from build system.

  • GNUmakefile.am:
7:25 AM Changeset in webkit [59607] by yurys@chromium.org
  • 3 edits in trunk/WebCore

2010-05-17 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r59483.
​http://trac.webkit.org/changeset/59483
​https://bugs.webkit.org/show_bug.cgi?id=39215

"page_cycler_intl1 regression on Linux" (Requested by yurys on
#webkit).

  • platform/chromium/ChromiumBridge.h:
  • platform/graphics/chromium/FontCacheLinux.cpp: (WebCore::FontCache::getFontDataForCharacters):
6:49 AM Changeset in webkit [59606] by kenneth@webkit.org
  • 2 edits in trunk/WebCore

REGRESSION(59563): [Qt] JSValue QtClass::fallbackObject can be optimized

Reviewed by Laszlo Gombos.

Patch declared a variable index, which shadowed an earlier declared
variable.

  • bridge/qt/qt_class.cpp:

(JSC::Bindings::QtClass::fallbackObject):

6:33 AM Changeset in webkit [59605] by jorlow@chromium.org
  • 3 edits in trunk/WebCore

2010-05-14 Andrei Popescu <​andreip@google.com>

Reviewed by Jeremy Orlow.

IDBRequest is not a proper ActiveDomObject
​https://bugs.webkit.org/show_bug.cgi?id=39001

Add IDBRequest interface to the IsActiveDomType
routine of the CodeGeneratorV8.pm.

Rename IDBRequest::m_stopped to m_suspended and reset
the flag when resume() is called.

No new tests, Indexed Database isn't yet testable.

  • bindings/scripts/CodeGeneratorV8.pm:
  • storage/IDBRequest.cpp: (WebCore::IDBRequest::suspend): (WebCore::IDBRequest::resume): (WebCore::IDBRequest::timerFired): (WebCore::IDBRequest::onEventCommon):
  • storage/IDBRequest.h:
6:22 AM Changeset in webkit [59604] by xan@webkit.org
  • 2 edits in trunk/WebCore

2010-05-17 Xan Lopez <​xlopez@igalia.com>

Do not include the indexed database headers if the feature is not
enabled. Should fix the build in GTK+.

  • bindings/js/JSEventCustom.cpp:
5:55 AM Changeset in webkit [59603] by xan@webkit.org
  • 2 edits in trunk/WebCore

2010-05-17 Xan Lopez <​xlopez@igalia.com>

Try to fix GTK+ build.

  • GNUmakefile.am:
4:20 AM Changeset in webkit [59602] by jorlow@chromium.org
  • 30 edits
    12 copies
    2 moves
    6 adds in trunk

2010-05-14 Jeremy Orlow <​jorlow@chromium.org>

Reviewed by Nate Chapin.

Finish up IndexedDB events
​https://bugs.webkit.org/show_bug.cgi?id=39117

Add the beginnings of a test for IndexedDB. It currently fails, but we'll
update this (and/or add other tests) as things start passing.

Disable it on all !Chromium platforms since none of them compile it
in. (Note that Chromium keeps it behind a runtime flag at the moment,
despite compiling it in...so don't worry.)

This also makes evalAndLog return the result of the evaluation. I think
this was just an oversight when I originally added it, and it's going to
come in useful for these tests.

  • fast/js/resources/js-test-pre.js: (evalAndLog):
  • platform/gtk/Skipped:
  • platform/mac-leopard/Skipped:
  • platform/mac-snowleopard/Skipped:
  • platform/mac-tiger/Skipped:
  • platform/mac/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:
  • storage/indexeddb/basics-expected.txt: Added.
  • storage/indexeddb/basics.html: Added.
  • storage/indexeddb/script-tests/TEMPLATE.html: Copied from LayoutTests/storage/domstorage/script-tests/TEMPLATE.html.
  • storage/indexeddb/script-tests/basics.js: Added. (eventShared): (successFunction): (errorFunction): (test):

2010-05-14 Jeremy Orlow <​jorlow@chromium.org>

Reviewed by Nate Chapin.

Finish up IndexedDB events
​https://bugs.webkit.org/show_bug.cgi?id=39117

Implement the indexed database event interfaces as proposed by Mozilla.
Refactor the run time type detection code that was in IDBRequest into its own
class named IDBAny. Use this new class within the new event classes and
IDBResults.

Test: storage/indexeddb/basics.html

  • DerivedSources.cpp:
  • DerivedSources.make:
  • GNUmakefile.am:
  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:
  • WebCore.pri:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSEventCustom.cpp: (WebCore::toJS):
  • bindings/js/JSEventTarget.cpp: (WebCore::toJS):
  • bindings/js/JSIDBAnyCustom.cpp: Added. (WebCore::toJS):
  • bindings/js/JSIDBRequestCustom.cpp: Removed.
  • bindings/v8/custom/V8EventCustom.cpp: (WebCore::toV8):
  • bindings/v8/custom/V8IDBAnyCustom.cpp: Added. (WebCore::toV8):
  • bindings/v8/custom/V8IDBRequestCustom.cpp: Removed.
  • dom/Event.cpp: (WebCore::Event::isIDBErrorEvent): (WebCore::Event::isIDBSuccessEvent):
  • dom/Event.h:
  • storage/IDBAny.cpp: Added. (WebCore::IDBAny::create): (WebCore::IDBAny::IDBAny): (WebCore::IDBAny::~IDBAny): (WebCore::IDBAny::idbDatabaseRequest): (WebCore::IDBAny::indexedDatabaseRequest): (WebCore::IDBAny::serializedScriptValue): (WebCore::IDBAny::set):
  • storage/IDBAny.h: Added. (WebCore::IDBAny::): (WebCore::IDBAny::type):
  • storage/IDBAny.idl: Added.
  • storage/IDBErrorEvent.cpp: Added. (WebCore::IDBErrorEvent::create): (WebCore::IDBErrorEvent::IDBErrorEvent): (WebCore::IDBErrorEvent::~IDBErrorEvent):
  • storage/IDBErrorEvent.h: Added. (WebCore::IDBErrorEvent::code): (WebCore::IDBErrorEvent::message): (WebCore::IDBErrorEvent::isIDBErrorEvent):
  • storage/IDBErrorEvent.idl: Added.
  • storage/IDBEvent.cpp: Added. (WebCore::IDBEvent::IDBEvent): (WebCore::IDBEvent::~IDBEvent): (WebCore::IDBEvent::source):
  • storage/IDBEvent.h: Added.
  • storage/IDBEvent.idl: Added.
  • storage/IDBRequest.cpp: (WebCore::IDBRequest::IDBRequest): (WebCore::IDBRequest::onSuccess): (WebCore::IDBRequest::timerFired): (WebCore::IDBRequest::onEventCommon):
  • storage/IDBRequest.h: (WebCore::IDBRequest::create): (WebCore::IDBRequest::result):
  • storage/IDBRequest.idl:
  • storage/IDBSuccessEvent.cpp: Added. (WebCore::IDBSuccessEvent::create): (WebCore::IDBSuccessEvent::IDBSuccessEvent): (WebCore::IDBSuccessEvent::~IDBSuccessEvent): (WebCore::IDBSuccessEvent::result):
  • storage/IDBSuccessEvent.h: Added. (WebCore::IDBSuccessEvent::isIDBSuccessEvent):
  • storage/IDBSuccessEvent.idl: Added.
  • storage/IndexedDatabaseImpl.cpp: (WebCore::IndexedDatabaseImpl::open):
  • storage/IndexedDatabaseRequest.cpp: (WebCore::IndexedDatabaseRequest::IndexedDatabaseRequest): (WebCore::IndexedDatabaseRequest::open):
  • storage/IndexedDatabaseRequest.h:
1:44 AM Changeset in webkit [59601] by yurys@chromium.org
  • 2 edits
    1 delete in trunk/LayoutTests

2010-05-17 Yury Semikhatsky <​yurys@chromium.org>

Unreviewed. Update Chromium test expectations.

  • platform/chromium-win-xp/fast/multicol/client-rects-expected.txt: Removed.
  • platform/chromium/test_expectations.txt:
1:11 AM Changeset in webkit [59600] by eric@webkit.org
  • 2 edits in trunk/JavaScriptCore

2010-05-17 Patrick Gansterer <​paroga@paroga.com>

Reviewed by Laszlo Gombos.

[Qt] Remove WinCE endian dedection.
​https://bugs.webkit.org/show_bug.cgi?id=38511

Windows CE supports little-endian format only.
Correct dedection was added in r57804.

  • wtf/Platform.h:
1:10 AM Changeset in webkit [59599] by mjs@apple.com
  • 2 edits in trunk/SunSpider

Browser-hosted version of SunSpider runs tests twice as many times as advertised
​https://bugs.webkit.org/show_bug.cgi?id=39201

Reviewed by Mark Rowe.

  • make-hosted: Make sure to reset test list after every test suite.
1:03 AM Changeset in webkit [59598] by Chris Jerdonek
  • 1 edit in trunk/WebCore/ChangeLog

Unreviewed.

Removed the stray equals sign from the reviewer's name in the
"Reviewed by" line of the ChangeLog entry for r59596:

​http://trac.webkit.org/changeset/59596

12:42 AM Changeset in webkit [59597] by yurys@chromium.org
  • 8 edits
    15 adds
    1 delete in trunk/LayoutTests

2010-05-17 Yury Semikhatsky <​yurys@chromium.org>

Unreviewed. Update Chromium test expectations.

  • platform/chromium-linux/fast/loader/recursive-before-unload-crash-expected.txt:
  • platform/chromium-linux/fast/multicol/client-rects-expected.txt: Removed.
  • platform/chromium-linux/fast/multicol/column-count-with-rules-expected.checksum: Added.
  • platform/chromium-linux/fast/multicol/column-count-with-rules-expected.png: Added.
  • platform/chromium-linux/fast/multicol/layers-in-multicol-expected.checksum: Added.
  • platform/chromium-linux/fast/multicol/layers-in-multicol-expected.png: Added.
  • platform/chromium-mac/fast/multicol/column-count-with-rules-expected.checksum: Added.
  • platform/chromium-mac/fast/multicol/column-count-with-rules-expected.png: Added.
  • platform/chromium-mac/fast/multicol/layers-in-multicol-expected.checksum: Added.
  • platform/chromium-mac/fast/multicol/layers-in-multicol-expected.png: Added.
  • platform/chromium-win/fast/canvas/canvas-toDataURL-case-insensitive-mimetype-expected.txt: Added.
  • platform/chromium-win/fast/multicol/client-rects-expected.txt:
  • platform/chromium-win/fast/multicol/column-count-with-rules-expected.checksum: Added.
  • platform/chromium-win/fast/multicol/column-count-with-rules-expected.png: Added.
  • platform/chromium-win/fast/multicol/column-count-with-rules-expected.txt: Added.
  • platform/chromium-win/fast/multicol/column-rules-expected.txt:
  • platform/chromium-win/fast/multicol/columns-shorthand-parsing-expected.txt:
  • platform/chromium-win/fast/multicol/float-avoidance-expected.txt:
  • platform/chromium-win/fast/multicol/float-multicol-expected.txt:
  • platform/chromium-win/fast/multicol/layers-in-multicol-expected.checksum: Added.
  • platform/chromium-win/fast/multicol/layers-in-multicol-expected.png: Added.
  • platform/chromium-win/fast/multicol/layers-in-multicol-expected.txt: Added.
  • platform/chromium-win/fast/multicol/single-line-expected.txt:
12:34 AM Changeset in webkit [59596] by Chris Jerdonek
  • 7 edits in trunk/WebCore

2010-05-16 Chris Jerdonek <Chris Jerdonek>

Reviewed by =Adam Barth.

Refactored FrameLoader::changeLocation() and urlSelected() to share more code.

​https://bugs.webkit.org/show_bug.cgi?id=38827

No change in behavior, so no new tests.

  • bindings/ScriptControllerBase.cpp: (WebCore::ScriptController::executeIfJavaScriptURL):
    • Changed a parameter from boolean to the ShouldReplaceDocumentIfJavaScriptURL enum.
  • bindings/js/ScriptController.h:
    • Changed a parameter from boolean to the ShouldReplaceDocumentIfJavaScriptURL enum.
  • bindings/v8/ScriptController.h:
    • Changed a parameter from boolean to the ShouldReplaceDocumentIfJavaScriptURL enum.
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::changeLocation):
    • Changed to call the new private overload of urlSelected().

(WebCore::FrameLoader::urlSelected):

  • Added a private overload of urlSelected().
  • Changed the public urlSelected() to call the private overload.

(WebCore::FrameLoader::submitForm):

  • loader/FrameLoader.h:
    • Added a private overload of urlSelected().
  • loader/FrameLoaderTypes.h:
    • Added a ShouldReplaceDocumentIfJavaScriptURL enum.
12:06 AM Changeset in webkit [59595] by ukai@chromium.org
  • 7 edits
    1 add in trunk/WebKitTools

2010-05-17 Fumitoshi Ukai <​ukai@chromium.org>

Reviewed by Eric Seidel.

Chromium: Add --chromium option to new-run-webkit-websocketserver
​https://bugs.webkit.org/show_bug.cgi?id=37664

os.environ setup and setup_mount for cygwin are moved in ChromiumWinPort.setup_environ_for_server.

  • Scripts/new-run-webkit-httpd: Remove passing register_cygwin.
  • Scripts/new-run-webkit-websocketserver: Add --chromium flag. Remove passing register_cygwin. Create port object using options.
  • Scripts/webkitpy/layout_tests/port/base.py: Add setup_environ_for_server().
  • Scripts/webkitpy/layout_tests/port/chromium_win.py: Ditto.
  • Scripts/webkitpy/layout_tests/port/factory_unittest.py: Added.
  • Scripts/webkitpy/layout_tests/port/http_server.py: Remove register_cygwin_parameter. Call setup_environ_for_server().
  • Scripts/webkitpy/layout_tests/port/websocket_server.py: Ditto.
Note: See TracTimeline for information about the timeline view.