Context Navigation

← Previous Period
Next Period →

Timeline

May 20, 2010:

11:17 PM Changeset in webkit [59916] by dbates@webkit.org

2 edits in trunk/WebKitSite

2010-05-20 Daniel Bates <dbates@rim.com>

Rubber-stamped by Simon Fraser.

Spelling correction; change "acces" [sic] to "access".

quality/lifecycle.html:

11:10 PM Changeset in webkit [59915] by Philippe Normand

5 edits
2 adds in trunk/WebCore

2010-05-18 Philippe Normand <pnormand@igalia.com>

Reviewed by Eric Carlson.

[GStreamer] PlatformMedia support
https://bugs.webkit.org/show_bug.cgi?id=39300

Basic support for PlatformMedia in the gst player. The
PlatformMedia object contains a GStreamerGWorld object. That
object is empty for now. XOverlay features will be added later
on for easy review sake.

GNUmakefile.am:
platform/graphics/MediaPlayer.h: (WebCore::PlatformMedia::):
platform/graphics/gstreamer/GStreamerGWorld.cpp: Added. (WebCore::GStreamerGWorld::createGWorld): (WebCore::GStreamerGWorld::GStreamerGWorld): (WebCore::GStreamerGWorld::~GStreamerGWorld):
platform/graphics/gstreamer/GStreamerGWorld.h: Added.
platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivateGStreamer::platformMedia): (WebCore::MediaPlayerPrivateGStreamer::createGSTPlayBin):
platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:

10:58 PM Changeset in webkit [59914] by eric@webkit.org

1 edit
1 add in trunk/WebCore

2010-05-20 Kwang Yul Seo <skyul@company100.net>

Reviewed by Eric Seidel.

[BREWMP] Add dummy SSLKeyGenerator
https://bugs.webkit.org/show_bug.cgi?id=39403

Add dummy implementation of SSLKeyGenerator.

platform/brew/SSLKeyGeneratorBrew.cpp: Added. (WebCore::WebCore::getSupportedKeySizes): (WebCore::WebCore::signedPublicKeyAndChallengeString):

10:23 PM Changeset in webkit [59913] by mrowe@apple.com

4 edits in trunk

<rdar://problem/7848154> Remove the dependency on Foundation's private COCOA_FORMAL_PROTOCOLS_2 define.

Rubber-stamped by Dan Bernstein.

WebCore:

platform/mac/EmptyProtocolDefinitions.h:

WebKitTools:

DumpRenderTree/mac/LayoutTestControllerMac.mm:

10:15 PM Changeset in webkit [59912] by Simon Fraser

3 edits in trunk/WebKit/win

2010-05-20 Simon Fraser <Simon Fraser>

Build fix, no review.

Fix the non-accelerated-compositing Windows build with some
#if USE(ACCELERATED_COMPOSITING) loving.

WebView.cpp:
WebView.h:

10:09 PM Changeset in webkit [59911] by eric@webkit.org

1 edit
2 adds in trunk/WebCore

2010-05-20 Kwang Yul Seo <skyul@company100.net>

Reviewed by Eric Seidel.

[BREWMP] Add Editor
https://bugs.webkit.org/show_bug.cgi?id=39404

Implement Editor::newGeneralClipboard.

editing/brew/EditorBrew.cpp: Added. (WebCore::Editor::newGeneralClipboard):

9:49 PM Changeset in webkit [59910] by Simon Fraser

6 edits in trunk

2010-05-20 Simon Fraser <Simon Fraser>

Reviewed by Adam Roben.

Avoid flushing CA layers when a layout is pending
https://bugs.webkit.org/show_bug.cgi?id=39463
<rdar://problem/7999463>

Avoid rendering the compositing layers to the screen if there's a layout pending,
since the layer tree not in a state that should be presented to the user.

This fixes flashes in some types of content that dynamically add and remove layers.

Do this by adding a WKCACFLayerRendererClient for WKCACFLayerRenderer, which it can
call through to ask whether now is a good time to render. If not, it schedules
another render soon.

platform/graphics/win/WKCACFLayerRenderer.h: (WebCore::WKCACFLayerRendererClient::~WKCACFLayerRendererClient):
platform/graphics/win/WKCACFLayerRenderer.cpp: (WebCore::WKCACFLayerRenderer::acceleratedCompositingAvailable): (WebCore::WKCACFLayerRenderer::create): (WebCore::WKCACFLayerRenderer::WKCACFLayerRenderer): (WebCore::WKCACFLayerRenderer::render):

9:41 PM Changeset in webkit [59909] by eric@webkit.org

2 edits in trunk/WebCore

2010-05-20 Kwang Yul Seo <skyul@company100.net>

Reviewed by Eric Seidel.

[BREWMP] Don't include CoreFoundation.h when building for BREW MP
https://bugs.webkit.org/show_bug.cgi?id=39405

Add !defined(BUILDING_BREWMP) guard for CoreFoundation.h.

WebCorePrefix.h:

9:19 PM Changeset in webkit [59908] by eric@webkit.org

2 edits in trunk/JavaScriptCore

2010-05-20 Kwang Yul Seo <skyul@company100.net>

Reviewed by Eric Seidel.

[BREWMP] Use skia as BREW MP's graphics backend.
https://bugs.webkit.org/show_bug.cgi?id=39407

Define WTF_PLATFORM_SKIA=1 for BREW MP.

wtf/Platform.h:

8:56 PM Changeset in webkit [59907] by eric@webkit.org

1 edit
2 adds in trunk/WebCore

2010-05-20 Kwang Yul Seo <skyul@company100.net>

Reviewed by Eric Seidel.

[BREWMP] Add ScrollTheme
https://bugs.webkit.org/show_bug.cgi?id=39406

As BREW MP always uses frame flattening, there is no need to render scorllbars.
Use the default scrollbar theme with thickness 0.

platform/brew/ScrollbarThemeBrew.cpp: Added. (WebCore::ScrollbarTheme::nativeTheme): (WebCore::ScrollbarThemeBrew::~ScrollbarThemeBrew):
platform/brew/ScrollbarThemeBrew.h: Added.

8:42 PM Changeset in webkit [59906] by eric@webkit.org

2 edits in trunk/WebKitTools

2010-05-20 Tony Gentilcore <tonyg@chromium.org>

Reviewed by Daniel Bates.

Look in /proc/registry64 for the Platform SDK on 64-bit Windows.
https://bugs.webkit.org/show_bug.cgi?id=39296

The build-webkit script failed for me on Vista 64. A web search turned
up this blog post with a patch that worked for me:
http://www.nicholaswilson.me.uk/2010/04/hacking-webkit-fail/

Scripts/webkitdirs.pm:

8:39 PM Changeset in webkit [59905] by ggaren@apple.com

3 edits in trunk/JavaScriptCore

Fixed naming mixup: it's op_call_put_result, not ret_result.

Reviewed by Beth Dakin.

bytecode/CodeBlock.cpp:

(JSC::CodeBlock::dump):

interpreter/Interpreter.cpp:

(JSC::Interpreter::privateExecute):

8:20 PM Changeset in webkit [59904] by jhoneycutt@apple.com

4 edits
1 add in trunk/WebCore

REGRESSION(r53637): DivX plug-in fails to start until window is resized
https://bugs.webkit.org/show_bug.cgi?id=39457
<rdar://problem/8006102>

Before r53637, we called Widget::move() (which caused us to call
NPP_SetWindow) before painting a plug-in. r53637 removed the call to
Widget::move(), and we end up never calling NPP_SetWindow for plug-ins
with the "DeferFirstSetWindowCall" quirk, including the DivX plug-in.

Reviewed by Simon Fraser.

manual-tests/divx-plugin-fails-to-draw.html: Added.

plugins/PluginView.cpp:

(WebCore::PluginView::PluginView):
Initialize new member to false.

plugins/PluginView.h:

Added new member.

plugins/win/PluginViewWin.cpp:

(WebCore::PluginView::paint):
Call setNPWindowRect() before painting to ensure that NPP_SetWindow gets
called.
(WebCore::PluginView::setNPWindowRect):
Set m_haveCalledSetWindow.

8:06 PM Changeset in webkit [59903] by ukai@chromium.org

7 edits in trunk

2010-05-20 Fumitoshi Ukai <ukai@chromium.org>

Reviewed by Alexey Proskuryakov.

WebSocket handshake incompatible change in draft-hixie-thewebsocketprotocol-76
https://bugs.webkit.org/show_bug.cgi?id=35572

Fix LayoutTests for new WebSocket protocol.
It requires https://bugs.webkit.org/show_bug.cgi?id=38034 to pass websocket tests.

websocket/tests/handshake-error-expected.txt: Update expected data.
websocket/tests/handshake-error_wsh.py: Without CRLF, the wsh will sends "ThisWillCauseHandshakeErrorHTTP/1.1 101 WebSocket Protocol Handshake\r\n", which is legal for the first line of draft 76 WebSocket opening handshake. (4.1 Opening Handhshake, step 28 to 30). To fail handshake, it needs \r\n.
websocket/tests/long-invalid-header-expected.txt: Originally, it expects Upgrade header after status line. In draft 76, order is not important. But "pppp..\r\n" would fail because it misses ":" (end of name) before \r.

2010-05-20 Fumitoshi Ukai <ukai@chromium.org>

Reviewed by Alexey Proskuryakov.

WebSocket handshake incompatible change in draft-hixie-thewebsocketprotocol-76
https://bugs.webkit.org/show_bug.cgi?id=35572

WebSocket opening handshake is changed. New protocol draft could be found at http://www.whatwg.org/specs/web-socket-protocol/
It requires https://bugs.webkit.org/show_bug.cgi?id=38034 to pass websocket tests.

websockets/WebSocketHandshake.cpp: (WebCore::extractResponseCode): add lineLength parameter to return length of status line. (WebCore::hostName): Added. (WebCore::generateSecWebSocketKey): Added. (WebCore::generateKey3): Added. (WebCore::setChallengeNumber): Added. (WebCore::generateChallengeResponseExpected): Added. (WebCore::WebSocketHandshake::WebSocketHandshake): generate challenge response key and expected data. (WebCore::WebSocketHandshake::clientLocation): use hostName. (WebCore::WebSocketHandshake::clientHandshakeMessage): changed for draft 76 spec. (WebCore::WebSocketHandshake::clientHandshakeRequest): (WebCore::WebSocketHandshake::readServerHandshake): changed for draft 76 spec. m_mode is managed in this method. (WebCore::WebSocketHandshake::readHTTPHeaders): change error log messages. (WebCore::WebSocketHandshake::processHeaders): chagned for draft 76 spec. (WebCore::WebSocketHandshake::checkResponseHeaders): return boolean whether response header is ok or not and not change m_mode in it.
websockets/WebSocketHandshake.h:

8:04 PM Changeset in webkit [59902] by eric@webkit.org

2 edits in trunk/WebKitTools

2010-05-20 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

ThreadedMessageQueue should use with_statement for exception safety
https://bugs.webkit.org/show_bug.cgi?id=39233

Scripts/webkitpy/common/thread/threadedmessagequeue.py:

7:52 PM Changeset in webkit [59901] by eric@webkit.org

3 edits in trunk/WebKit/chromium

2010-05-20 Viet-Trung Luu <viettrungluu@chromium.org>

Reviewed by Darin Fisher.

[Chromium] Don't rely on focused node to route mouse events to plugins.
https://bugs.webkit.org/show_bug.cgi?id=39375
http://crbug.com/43935

On mouse down, do a hit test and check if a plugin was hit. If so, then
save the node for future mouse events (until mouse up or capture lost).

src/WebViewImpl.cpp: (WebKit::WebViewImpl::WebViewImpl): (WebKit::WebViewImpl::mouseDown): (WebKit::WebViewImpl::handleInputEvent): (WebKit::WebViewImpl::mouseCaptureLost):
src/WebViewImpl.h: Remove m_haveMouseCapture; add m_mouseCaptureNode.

7:44 PM Changeset in webkit [59900] by victorw@chromium.org

2 edits
4 adds in trunk/LayoutTests

2010-05-20 Victor Wang <victorw@chromium.org>

Unreviewed. Update test expectations for chromium.

platform/chromium-linux/fast/css/font-face-in-shadow-DOM-expected.checksum: Added.
platform/chromium-linux/fast/css/font-face-in-shadow-DOM-expected.png: Added.
platform/chromium-win/fast/css/font-face-in-shadow-DOM-expected.checksum: Added.
platform/chromium-win/fast/css/font-face-in-shadow-DOM-expected.png: Added.
platform/chromium/test_expectations.txt:

7:34 PM Changeset in webkit [59899] by eric@webkit.org

4 edits in trunk/LayoutTests

2010-05-20 Zhenyao Mo <zmo@google.com>

Reviewed by Dimitri Glazkov.

fast/canvas/webgl/texture-npot.html failed on leopard bot
https://bugs.webkit.org/show_bug.cgi?id=39128

fast/canvas/webgl/texture-npot-expected.txt: Adding the failed test cases back.
fast/canvas/webgl/texture-npot.html:
platform/mac-leopard/Skipped: Skip texture-npot.html on leopard for now.

7:19 PM Changeset in webkit [59898] by eric@webkit.org

3 edits in trunk/WebKit/chromium

2010-05-20 Dominic Mazzoni <dmazzoni@chromium.org>

Reviewed by Darin Fisher.

Add headingLevel and setFocused methods.

https://bugs.webkit.org/show_bug.cgi?id=39238

public/WebAccessibilityObject.h:
src/WebAccessibilityObject.cpp: (WebKit::WebAccessibilityObject::headingLevel): (WebKit::WebAccessibilityObject::setFocused):

7:14 PM Changeset in webkit [59897] by Adam Roben

2 edits in trunk/WebCore

Stop leaking all CACFContexts

Fixes <http://webkit.org/b/39466> <rdar://problem/8007141>.

Reviewed by Simon Fraser.

platform/graphics/win/WKCACFContextFlusher.cpp:

(WebCore::WKCACFContextFlusher::addContext): Only retain the context
when we first add it to the m_contexts set. Otherwise we'll retain the
same context multiple times, causing it to leak.

7:02 PM Changeset in webkit [59896] by eric@webkit.org

3 edits in trunk/WebKitTools

2010-05-20 Diego Gonzalez <diegohcg@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] QtTestBrowser does not support websites which requires HTTP Authentication via dialogs
https://bugs.webkit.org/show_bug.cgi?id=38456

QtTestBrowser/webpage.cpp: (WebPage::WebPage): (WebPage::authenticationRequired):
QtTestBrowser/webpage.h:

7:01 PM Changeset in webkit [59895] by ggaren@apple.com

6 edits in trunk/JavaScriptCore

2010-05-20 Geoffrey Garen <ggaren@apple.com>

Reviewed by Oliver Hunt.

Whittling away at CodeBlock use: Removed a little wonkiness in closure lookup
https://bugs.webkit.org/show_bug.cgi?id=39444

Calculate all lookup depths at compile time. I'm not sure why we couldn't
do this before, but whatever the reason, it seems to be gone now.

bytecompiler/BytecodeGenerator.cpp: (JSC::BytecodeGenerator::findScopedProperty):
bytecompiler/BytecodeGenerator.h:
interpreter/Interpreter.cpp: (JSC::Interpreter::resolveSkip): (JSC::Interpreter::resolveGlobalDynamic): (JSC::Interpreter::privateExecute):
jit/JITOpcodes.cpp: (JSC::JIT::emit_op_get_scoped_var): (JSC::JIT::emit_op_put_scoped_var): (JSC::JIT::emit_op_resolve_skip): (JSC::JIT::emit_op_resolve_global_dynamic): (JSC::JIT::emitSlow_op_resolve_global_dynamic):
jit/JITOpcodes32_64.cpp: (JSC::JIT::emit_op_get_scoped_var): (JSC::JIT::emit_op_put_scoped_var): (JSC::JIT::emit_op_resolve_skip):

6:45 PM Changeset in webkit [59894] by eric@webkit.org

2 edits
1 add in trunk/WebCore

2010-05-20 Young Han Lee <joybro@company100.net>

Reviewed by Darin Adler.

Create filenameFromString for all ports except GTK and EFL.
https://bugs.webkit.org/show_bug.cgi?id=39348

platform/FileSystem.cpp: Added. (WebCore::filenameFromString):
platform/FileSystem.h:

6:42 PM Changeset in webkit [59893] by mrowe@apple.com

5 edits in branches/safari-533-branch

Versioning.

6:41 PM Changeset in webkit [59892] by mrowe@apple.com

1 copy in tags/Safari-533.10

New tag.

6:40 PM Changeset in webkit [59891] by mthole@apple.com

2 edits in trunk/WebKit/mac

When using a scale factor > 1, scrollbars sometimes appear when not necessary
https://bugs.webkit.org/show_bug.cgi?id=39458

Reviewed by Dave Hyatt.

WebView/WebDynamicScrollBarsView.mm:

(-[WebDynamicScrollBarsView updateScrollers]): Round up non-integral sizes from AppKit
so that they can be compared against the integral document size.

6:19 PM Changeset in webkit [59890] by eric@webkit.org

1 edit
1 add in trunk/WebCore

2010-05-20 Young Han Lee <joybro@company100.net>

Reviewed by Darin Adler.

Port SharedBuffer to POSIX.
https://bugs.webkit.org/show_bug.cgi?id=39283

platform/posix/SharedBufferPOSIX.cpp: Added. (WebCore::SharedBuffer::createWithContentsOfFile):

6:19 PM Changeset in webkit [59889] by mrowe@apple.com

13 edits
4 adds in branches/safari-533-branch

Merge r59876.

6:06 PM Changeset in webkit [59888] by eric@webkit.org

7 edits in trunk

2010-05-20 Zhenyao Mo <zmo@google.com>

Reviewed by Dimitri Glazkov.

Map RGBA4/RGB5_A1 to RGBA and RGB565 to RGB in RenderbufferStorage
https://bugs.webkit.org/show_bug.cgi?id=39077

fast/canvas/webgl/framebuffer-object-attachment-expected.txt: Add the test cases for color renderbuffer creation and attachment to framebuffer.
fast/canvas/webgl/framebuffer-object-attachment.html: Ditto.

2010-05-20 Zhenyao Mo <zmo@google.com>

Reviewed by Dimitri Glazkov.

Map RGBA4/RGB5_A1 to RGBA and RGB565 to RGB in RenderbufferStorage
https://bugs.webkit.org/show_bug.cgi?id=39077

platform/graphics/mac/GraphicsContext3DMac.cpp: (WebCore::GraphicsContext3D::renderbufferStorage): Mapping the enums.

2010-05-20 Zhenyao Mo <zmo@google.com>

Reviewed by Dimitri Glazkov.

Map RGBA4/RGB5_A1 to RGBA and RGB565 to RGB in RenderbufferStorage
https://bugs.webkit.org/show_bug.cgi?id=39077

src/WebGraphicsContext3DDefaultImpl.cpp: (WebKit::WebGraphicsContext3DDefaultImpl::renderbufferStorage): Mapping the enums.

6:05 PM Changeset in webkit [59887] by mrowe@apple.com

3 edits in branches/safari-533-branch/WebKit/mac

Merge r59793.

6:05 PM Changeset in webkit [59886] by mrowe@apple.com

2 edits in branches/safari-533-branch/WebCore

Merge r59853.

6:05 PM Changeset in webkit [59885] by mrowe@apple.com

2 edits in branches/safari-533-branch/WebCore

Merge r59873.

6:04 PM Changeset in webkit [59884] by mrowe@apple.com

2 edits in branches/safari-533-branch/WebCore

Merge r59871.

6:04 PM Changeset in webkit [59883] by mrowe@apple.com

5 edits in branches/safari-533-branch/WebCore

Merge r59854.

6:04 PM Changeset in webkit [59882] by mrowe@apple.com

2 edits in branches/safari-533-branch/WebCore

Merge r59864.

6:04 PM Changeset in webkit [59881] by mrowe@apple.com

4 edits
2 adds in branches/safari-533-branch

Merge r59795.

6:04 PM Changeset in webkit [59880] by mrowe@apple.com

2 edits
3 adds in branches/safari-533-branch

Merge r59859.

6:04 PM Changeset in webkit [59879] by mrowe@apple.com

2 edits in branches/safari-533-branch/WebCore

Merge r59732.

6:04 PM Changeset in webkit [59878] by mrowe@apple.com

4 edits in branches/safari-533-branch/WebCore

Merge r59731.

6:04 PM Changeset in webkit [59877] by mrowe@apple.com

5 edits
3 adds in branches/safari-533-branch

Merge r59798.

5:37 PM Changeset in webkit [59876] by mitz@apple.com

13 edits
4 adds in trunk

<rdar://problem/8007953> Textarea using custom font appears blank

Reviewed by Dave Hyatt.

WebCore:

Test: fast/css/font-face-in-shadow-DOM.html

When a remote font is loaded, CSSFontSelector forces a style recalc, which replaces all
RenderSyles that have FontFallbackLists referencing the placeholder font with fresh
RenderStyles. However, it does not descend into shadow DOM trees, so those may end up with
styles that still reference the placeholder font.

The fix is to add RenderObject::requiresForcedStyleRecalcPropagation() and have it return
true from renderers that maintain shadow DOM trees or otherwise keep their own RenderStyles.

dom/Element.cpp:

(WebCore::Element::recalcStyle): Check if forced style recalc needs to propagated.

rendering/RenderButton.h:

(WebCore::RenderButton::requiresForcedStyleRecalcPropagation):

rendering/RenderDataGrid.h:

(WebCore::RenderDataGrid::requiresForcedStyleRecalcPropagation):

rendering/RenderFileUploadControl.h:

(WebCore::RenderFileUploadControl::requiresForcedStyleRecalcPropagation):

rendering/RenderListItem.h:

(WebCore::RenderListItem::requiresForcedStyleRecalcPropagation):

rendering/RenderMedia.h:

(WebCore::RenderMedia::requiresForcedStyleRecalcPropagation):

rendering/RenderMenuList.h:

(WebCore::RenderMenuList::RenderMenuList::requiresForcedStyleRecalcPropagation):

rendering/RenderObject.h:

(WebCore::RenderObject::requiresForcedStyleRecalcPropagation):

rendering/RenderProgress.h:

(WebCore::RenderProgress::requiresForcedStyleRecalcPropagation):

rendering/RenderSlider.h:

(WebCore::RenderSlider::requiresForcedStyleRecalcPropagation):

rendering/RenderTextControl.h:

(WebCore::RenderTextControl::requiresForcedStyleRecalcPropagation):

LayoutTests:

fast/css/font-face-in-shadow-DOM.html: Added.
platform/mac/fast/css/font-face-in-shadow-DOM-expected.checksum: Added.
platform/mac/fast/css/font-face-in-shadow-DOM-expected.png: Added.
platform/mac/fast/css/font-face-in-shadow-DOM-expected.txt: Added.

4:58 PM Changeset in webkit [59875] by mrowe@apple.com

10 edits in branches/safari-533-branch/WebCore

Merge r59776.

4:57 PM Changeset in webkit [59874] by mrowe@apple.com

11 edits
1 move
1 delete in branches/safari-533-branch/WebCore

Merge r59677.

4:02 PM Changeset in webkit [59873] by jer.noble@apple.com

2 edits in trunk/WebCore

No review; build fix only.

When WTF_USE_ACCELERATED_COMPOSITING is turned off, MediaPlayerPrivateQuickTimeVisualContext.cpp
must include CoreGraphics/CGContext.h.

platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp:

3:51 PM Changeset in webkit [59872] by Martin Robinson

2 edits in trunk/LayoutTests

2010-05-20 Martin Robinson <mrobinson@igalia.com>

Not reviewed.

Tests that use Geolocation.getCurrentPosition fail
https://bugs.webkit.org/show_bug.cgi?id=39454

platform/gtk/Skipped: Skip failing tests until this bug is resolved.

3:41 PM Changeset in webkit [59871] by jer.noble@apple.com

2 edits in trunk/WebCore

2010-05-20 Jer Noble <jer.noble@apple.com>

Reviewed by Sam Weinig.

Video elements show no video on Windows machines that do not support accelerated compositing
https://bugs.webkit.org/show_bug.cgi?id=39446
rdar://problem/7999794

Implement the paint() method in MediaPlayerPrivateQuickTimeVisualContext. The visual context should
be set up in load() and torn down in the destructor (as opposed to setUpVideoRendering and
tearDownVideoRendering, which won't get called in a non-accelerated compositing case).

platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp: (WebCore::MediaPlayerPrivateQuickTimeVisualContext::~MediaPlayerPrivateQuickTimeVisualContext): (WebCore::MediaPlayerPrivateQuickTimeVisualContext::load): (WebCore::MediaPlayerPrivateQuickTimeVisualContext::paint): (WebCore::MediaPlayerPrivateQuickTimeVisualContext::visualContextTimerFired): (WebCore::MediaPlayerPrivateQuickTimeVisualContext::retrieveCurrentImage): (WebCore::MediaPlayerPrivateQuickTimeVisualContext::setUpVideoRendering): (WebCore::MediaPlayerPrivateQuickTimeVisualContext::tearDownVideoRendering):

3:32 PM Changeset in webkit [59870] by victorw@chromium.org

5 edits in trunk

2010-05-20 Abhishek Arya <inferno@chromium.org>

Reviewed by Adam Barth.

Added method to WebSecurityOrigin for invoking
SecurityOrigin::canAccessPasswordManager.
https://bugs.webkit.org/show_bug.cgi?id=38916

public/WebSecurityOrigin.h:
src/WebSecurityOrigin.cpp: (WebKit::WebSecurityOrigin::canAccessPasswordManager):

2010-05-20 Abhishek Arya <inferno@chromium.org>

Reviewed by Adam Barth.

Added a method to check if the security origin can access
password manager.
https://bugs.webkit.org/show_bug.cgi?id=38916

page/SecurityOrigin.h: (WebCore::SecurityOrigin::canAccessPasswordManager):

3:27 PM Changeset in webkit [59869] by victorw@chromium.org

2 edits
4 adds in trunk/LayoutTests

2010-05-20 Victor Wang <victorw@chromium.org>

Unreviewed. Update test expectations for chromium.

platform/chromium-mac/svg/filters/feLighting-crash-expected.checksum: Added.
platform/chromium-mac/svg/filters/feLighting-crash-expected.png: Added.
platform/chromium-win/svg/filters/feLighting-crash-expected.checksum: Added.
platform/chromium-win/svg/filters/feLighting-crash-expected.png: Added.
platform/chromium/test_expectations.txt:

3:17 PM Changeset in webkit [59868] by Darin Adler

12 edits in trunk

2010-05-20 Darin Adler <Darin Adler>

Reviewed by Eric Seidel.

Fix warnings seen on the buildbots today
https://bugs.webkit.org/show_bug.cgi?id=39368

profiler/ProfileNode.cpp: (JSC::getCount): Removed unneeded initialization of global variable. These are all initialized to zero anyway, so no need to try to initialize it and get a warning.

wtf/CurrentTime.cpp: (WTF::currentTime): Removed unused global variable.

2010-05-20 Darin Adler <Darin Adler>

Reviewed by Eric Seidel.

Fix warnings seen on the buildbots today
https://bugs.webkit.org/show_bug.cgi?id=39368

loader/icon/IconDatabase.cpp: (WebCore::IconDatabase::pruneUnretainedIcons): Use the type "long long" for things being printed with "%lli". There is no guaranteed that int64_t is the same thing as long long.

page/EventHandler.cpp: (WebCore::EventHandler::handleMousePressEvent): Added parentheses as suggested by warnings in newer versions of GCC.

platform/ContextMenu.cpp: Fix #if around the functions to match the #if around the call sites to avoid unused function warning.

platform/graphics/gtk/ImageGtk.cpp: (WebCore::Image::loadPlatformResource): Use NULL to end a variable argument list rather than 0. This is a case where the WebKit "use 0 instead of NULL" guideline is incorrect and won't work properly.

platform/win/SystemTimeWin.cpp: (WebCore::userIdleTime): Removed unnecessary initialization of LASTINPUTINFO.

platform/win/WebCoreInstanceHandle.h: Added property svn:eol-style. Made functions inline instead of static. It's not correct to have functions with internal linkage in a header file. Marking them inline makes more sense.

plugins/win/PluginMessageThrottlerWin.cpp: (WebCore::PluginMessageThrottlerWin::PluginMessageThrottlerWin): Reordered the initializers to match the order of the data members from the class definition.

plugins/win/PluginViewWin.cpp: (WebCore::PluginView::paintIntoTransformedContext): Initialized all the fields of WINDOWPOS. I know this goes against the traditions of Windows programming, but it's correct and silences the warning. Also removed the unneeded separate code path for non-WinCE platforms that translates only the corner of the window rectangle; the WinCE version is correct for normal Windows as well. Not sure why this wasn't caught when the code was originally checked in.

3:05 PM Changeset in webkit [59867] by Martin Robinson

2 edits in trunk/LayoutTests

2010-05-20 Martin Robinson <mrobinson@igalia.com>

Not reviewed.

https://bugs.webkit.org/show_bug.cgi?id=39388
Re-enable geolocation tests on GTK+ now that this bug is closed.

platform/gtk/Skipped: Re-enable geolocation tests.

2:56 PM Changeset in webkit [59866] by yaar@chromium.org

29 edits
2 adds in trunk

2010-05-20 Justin Schuh <jschuh@chromium.org>

Reviewed by Adam Barth.

Moving frame.src checks out of the bindings
https://bugs.webkit.org/show_bug.cgi?id=37815

Moved JavaScript frame.src checks out of bindings and into
HTMLFrameElementBase. Added main thread state stack to JavaScriptCore
so ExecState is available inside core DOM. Updated affected bindings
(except for GObject, which will need to be updated to avoid origin
failures inside native code).

Android.jscbindings.mk:
CMakeLists.txt:
GNUmakefile.am:
WebCore.gypi:
WebCore.pro:
WebCore.vcproj/WebCore.vcproj:
WebCore.xcodeproj/project.pbxproj:
bindings/js/JSBindingsAllInOne.cpp:
bindings/js/JSCallbackData.cpp: (WebCore::JSCallbackData::invokeCallback):
bindings/js/JSEventListener.cpp: (WebCore::JSEventListener::handleEvent):
bindings/js/JSInjectedScriptHostCustom.cpp: (WebCore::InjectedScriptHost::createInjectedScript):
bindings/js/JSMainThreadExecState.cpp: Added.
bindings/js/JSMainThreadExecState.h: Added. (WebCore::JSMainThreadExecState::currentState): (WebCore::JSMainThreadExecState::call): (WebCore::JSMainThreadExecState::evaluate): (WebCore::JSMainThreadExecState::JSMainThreadExecState): (WebCore::JSMainThreadExecState::~JSMainThreadExecState): (WebCore::JSMainThreadNullState::JSMainThreadNullState):
bindings/js/ScheduledAction.cpp: (WebCore::ScheduledAction::executeFunctionInContext): (WebCore::ScheduledAction::execute):
bindings/js/ScheduledAction.h:
bindings/js/ScriptController.cpp: (WebCore::ScriptController::evaluateInWorld): (WebCore::ScriptController::canAccessFromCurrentOrigin):
bindings/js/ScriptController.h:
bindings/js/ScriptFunctionCall.cpp: (WebCore::ScriptFunctionCall::call):
bindings/objc/ObjCEventListener.mm:
bindings/objc/WebScriptObject.mm: (-[WebScriptObject callWebScriptMethod:withArguments:]): (-[WebScriptObject evaluateWebScript:]):
bindings/scripts/CodeGeneratorObjC.pm:
bindings/scripts/test/ObjC/DOMTestCallback.mm: (-[DOMTestCallback callbackWithClass1Param:]): (-[DOMTestCallback callbackWithClass2Param:strArg:]): (-[DOMTestCallback callbackWithNonBoolReturnType:]): (-[DOMTestCallback customCallback:class6Param:]):
bindings/scripts/test/ObjC/DOMTestInterface.mm:
bindings/scripts/test/ObjC/DOMTestObj.mm: (-[DOMTestObj readOnlyIntAttr]): (-[DOMTestObj readOnlyStringAttr]): (-[DOMTestObj readOnlyTestObjAttr]): (-[DOMTestObj intAttr]): (-[DOMTestObj setIntAttr:]): (-[DOMTestObj longLongAttr]): (-[DOMTestObj setLongLongAttr:]): (-[DOMTestObj unsignedLongLongAttr]): (-[DOMTestObj setUnsignedLongLongAttr:]): (-[DOMTestObj stringAttr]): (-[DOMTestObj setStringAttr:]): (-[DOMTestObj testObjAttr]): (-[DOMTestObj setTestObjAttr:]): (-[DOMTestObj attrWithException]): (-[DOMTestObj setAttrWithException:]): (-[DOMTestObj attrWithSetterException]): (-[DOMTestObj setAttrWithSetterException:]): (-[DOMTestObj attrWithGetterException]): (-[DOMTestObj setAttrWithGetterException:]): (-[DOMTestObj customAttr]): (-[DOMTestObj setCustomAttr:]): (-[DOMTestObj scriptStringAttr]): (-[DOMTestObj voidMethod]): (-[DOMTestObj voidMethodWithArgs:strArg:objArg:]): (-[DOMTestObj intMethod]): (-[DOMTestObj intMethodWithArgs:strArg:objArg:]): (-[DOMTestObj objMethod]): (-[DOMTestObj objMethodWithArgs:strArg:objArg:]): (-[DOMTestObj methodThatRequiresAllArgs:objArg:]): (-[DOMTestObj methodThatRequiresAllArgsAndThrows:objArg:]): (-[DOMTestObj serializedValue:]): (-[DOMTestObj methodWithException]): (-[DOMTestObj customMethod]): (-[DOMTestObj customMethodWithArgs:strArg:objArg:]): (-[DOMTestObj customArgsAndException:]): (-[DOMTestObj addEventListener:listener:useCapture:]): (-[DOMTestObj removeEventListener:listener:useCapture:]): (-[DOMTestObj withDynamicFrame]): (-[DOMTestObj withDynamicFrameAndArg:]): (-[DOMTestObj withDynamicFrameAndOptionalArg:optionalArg:]): (-[DOMTestObj withDynamicFrameAndUserGesture:]): (-[DOMTestObj withDynamicFrameAndUserGestureASAD:optionalArg:]): (-[DOMTestObj withScriptStateVoid]): (-[DOMTestObj withScriptStateObj]): (-[DOMTestObj withScriptStateVoidException]): (-[DOMTestObj withScriptStateObjException]): (-[DOMTestObj methodWithOptionalArg:]): (-[DOMTestObj methodWithNonOptionalArgAndOptionalArg:opt:]): (-[DOMTestObj methodWithNonOptionalArgAndTwoOptionalArgs:opt1:opt2:]):
bindings/v8/ScriptController.cpp: (WebCore::ScriptController::canAccessFromCurrentOrigin):
bindings/v8/ScriptController.h:
html/HTMLFrameElementBase.cpp: (WebCore::HTMLFrameElementBase::isURLAllowed):

2010-05-20 Justin Schuh <jschuh@chromium.org>

Reviewed by Adam Barth.

Moving frame.src checks out of the bindings
https://bugs.webkit.org/show_bug.cgi?id=37815

http/tests/security/xss-DENIED-iframe-src-alias-expected.txt:
http/tests/security/xss-DENIED-iframe-src-alias.html:

2:55 PM Changeset in webkit [59865] by kdecker@apple.com

3 edits in trunk/WebKit/mac

Reviewed by Anders Carlsson.

https://bugs.webkit.org/show_bug.cgi?id=39441
<rdar://problem/7985715> Flash context menu is both horizontally and vertically offset from point of click
<rdar://problem/7986109> Youtube video controller UI entirely missing
<rdar://problem/7986154> Flash content paints at horizontally and vertically shifted locations (within the plug-in region)

Plugins/Hosted/WebHostedNetscapePluginView.mm: (-[WebHostedNetscapePluginView updateAndSetWindow]): The base coordinates of a window and it's contentView happen to be the equal at a userSpaceScaleFactor of 1. For non-1.0 scale factors this assumption is false. Accordingly we now convert to the window contentView coordinate system when computing bounds in "window" and the visible rect.
Plugins/WebNetscapePluginView.mm: (-[WebNetscapePluginView saveAndSetNewPortStateForUpdate:]): Ditto.

2:30 PM Changeset in webkit [59864] by Adam Roben

2 edits in trunk/WebCore

Fix an HRGN leak in WKCACFLayerRenderer

Fixes <http://webkit.org/b/39312> <rdar://problem/7998728> REGRESSION
(r53686-r55990): Graphics corruption when watching video (affects
youtube.com)

Reviewed by Darin Adler.

platform/graphics/win/WKCACFLayerRenderer.cpp:

(WebCore::getDirtyRects): Use an OwnPtr to hold the HRGN we allocate.
That way we don't have to remember to destroy it (as we were
forgetting to do) when we bail out of this function early.

2:20 PM Changeset in webkit [59863] by ggaren@apple.com

2 edits in trunk/JavaScriptCore

2010-05-20 Geoffrey Garen <ggaren@apple.com>

Reviewed by Darin Adler.

Removed some reliance on callFame[CodeBlock] by storing CodeBlock in a
local variable in the Interpreter.
https://bugs.webkit.org/show_bug.cgi?id=39447

Small speedup on SunSpider in Interpreter mode.

interpreter/Interpreter.cpp: (JSC::Interpreter::privateExecute):
jsc.cpp:
wtf/Platform.h:

1:49 PM Changeset in webkit [59862] by darin@chromium.org

11 edits in trunk

2010-05-20 Darin Fisher <darin@chromium.org>

Reviewed by Nate Chapin.

[chromium] Provide a way to catch exceptions thrown while interacting
with a NPObject via WebBindings methods.
https://bugs.webkit.org/show_bug.cgi?id=39378

This change also includes a small bit of cleanup in V8NPObject and
friends. I moved code into the WebCore namespace where appropriate.

In _NPN_Invoke, I also moved the call to _NPN_Evaluate outside of the
context scope. I did this to avoid having nested ExceptionCatcher
objects, which is not strictly necessary, but it seemed cleaner.
_NPN_Evaluate already takes care of creating a context scope.

bindings/v8/NPV8Object.cpp: (WebCore::v8ObjectToNPObject): (WebCore::npCreateV8ScriptObject): (_NPN_Invoke): (_NPN_InvokeDefault): (_NPN_Evaluate): (_NPN_EvaluateHelper): (_NPN_GetProperty): (_NPN_SetProperty): (_NPN_RemoveProperty): (_NPN_HasProperty): (_NPN_HasMethod): (_NPN_SetException): (_NPN_Enumerate): (_NPN_Construct):
bindings/v8/NPV8Object.h:
bindings/v8/V8NPObject.cpp:
bindings/v8/V8NPObject.h:
bindings/v8/V8NPUtils.cpp: (WebCore::convertV8ObjectToNPVariant): (WebCore::pushExceptionHandler): (WebCore::popExceptionHandler): (WebCore::ExceptionCatcher::ExceptionCatcher): (WebCore::ExceptionCatcher::~ExceptionCatcher):
bindings/v8/V8NPUtils.h:
bindings/v8/npruntime.cpp:

1:20 PM Changeset in webkit [59861] by Martin Robinson

3 edits in trunk/WebKitTools

2010-05-20 Martin Robinson <mrobinson@igalia.com>

Reviewed by Eric Seidel.

editingBehavior settings needs to be set back to a reasonable default between tests
https://bugs.webkit.org/show_bug.cgi?id=39433

For now, hard code the default setting during reset, so that the serialized
version of the setting stays in sync with expectations.

DumpRenderTree/mac/DumpRenderTree.mm: (resetDefaultsToConsistentValues): Reset editing behavior to the appropriate platform default.
DumpRenderTree/win/DumpRenderTree.cpp: (resetDefaultsToConsistentValues): Ditto.

1:12 PM Changeset in webkit [59860] by barraclough@apple.com

12 edits in trunk/JavaScriptCore

Bug 39408 - Unify JIT/interpreter return behaviour.

Reviewed by Oliver Hunt.

Presently the JIT and the interpreter have differing implementations in how
they handle storing the result of a function call back to the register file.
In both cases the op_call ( / _eval / _varargs / op_construct) opcode has an
operand indicating the VM register in which the result should be stored.
The JIT plants code after the call to store the result, so the value will be
stored as soon as the callee has returned. In the interpreter the call
passes the return value register id into the callee via the callee callframe,
and the callee is responsible for writing the result back into its callers
register file after it has restored the parents callframe pointer, but before
returning.

Instead, move the task of writing the call result to the register file into a
new opcode (op_call_put_result), and after returning the callee should leave
the return value in a canonical location. In the case of the interpreter,
this canonical location is a local variable in privateExecute
(functionReturnValue), in the case of the JIT this is the normal return value
registers (regT0, or regT1:regT0 in JSVALUE32_64). op_call_put_result stores
the result from the canonical location to the registerfile.

In addition to unifying JIT & interpreter behaviour this change allows us to
remove a slot from the callframe, omit the write of the result where the
return value from the call is not used, and provides a 2% speedup on sunspider
in the interpreter.

bytecode/CodeBlock.cpp:

(JSC::CodeBlock::dump):

bytecode/Opcode.h:
bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::emitCall):
(JSC::BytecodeGenerator::emitCallVarargs):
(JSC::BytecodeGenerator::emitConstruct):

bytecompiler/BytecodeGenerator.h:

(JSC::BytecodeGenerator::finalDestinationOrIgnored):

bytecompiler/NodesCodegen.cpp:

(JSC::NewExprNode::emitBytecode):
(JSC::FunctionCallValueNode::emitBytecode):
(JSC::FunctionCallResolveNode::emitBytecode):
(JSC::FunctionCallBracketNode::emitBytecode):
(JSC::FunctionCallDotNode::emitBytecode):
(JSC::CallFunctionCallDotNode::emitBytecode):
(JSC::ApplyFunctionCallDotNode::emitBytecode):

interpreter/CallFrame.h:

(JSC::ExecState::init):
(JSC::ExecState::noCaller):

interpreter/Interpreter.cpp:

(JSC::Interpreter::dumpRegisters):
(JSC::Interpreter::throwException):
(JSC::Interpreter::privateExecute):

interpreter/RegisterFile.h:

(JSC::RegisterFile::):

jit/JIT.cpp:

(JSC::JIT::privateCompileMainPass):

jit/JIT.h:
jit/JITCall.cpp:

(JSC::JIT::compileOpCallSetupArgs):
(JSC::JIT::compileOpConstructSetupArgs):
(JSC::JIT::emit_op_call_put_result):
(JSC::JIT::compileOpCallVarargs):
(JSC::JIT::compileOpCallVarargsSlowCase):
(JSC::JIT::compileOpCall):
(JSC::JIT::compileOpCallSlowCase):
(JSC::JIT::compileOpCallVarargsSetupArgs):

1:10 PM Changeset in webkit [59859] by steveblock@google.com

2 edits
3 adds in trunk

2010-05-20 Marcus Bulach <bulach@chromium.org>

Reviewed by Steve Block.

Ensure timers are stopped on Geolocation::disconnectFrame()
https://bugs.webkit.org/show_bug.cgi?id=39388

fast/dom/Geolocation/notimer-after-unload.html, plus it should be possible to re-enable Gtk LayoutTests.

page/Geolocation.cpp: (WebCore::Geolocation::disconnectFrame):

12:44 PM Changeset in webkit [59858] by bfulgham@webkit.org

2 edits in trunk/WebKitTools

Build fix. No review.

The WebKitAPITest targets do not use the "_debug" suffix needed
by the WinCairo port. Added Debug_Cairo target to correct this.

WebKitAPITest/WebKitAPITest.vcproj:

12:32 PM Changeset in webkit [59857] by Martin Robinson

2 edits in trunk/LayoutTests

2010-05-20 Martin Robinson <mrobinson@igalia.com>

Unreviewed.

editingBehavior settings needs to be set back to a reasonable default between tests
https://bugs.webkit.org/show_bug.cgi?id=39433

I forgot to revert the expected results for this test after reverting it.

editing/selection/extend-selection-after-double-click-expected.txt:

12:18 PM Changeset in webkit [59856] by jamesr@google.com

3 edits
2 adds in trunk

2010-05-20 James Robinson <jamesr@chromium.org>

Reviewed by Eric Seidel.

Ensures styles are up-to-date before determining selection
https://bugs.webkit.org/show_bug.cgi?id=39389

This adds a call to document::updateStyleIfNeeded() to
Frame::notifyRendererOfSelectionChange(). Without this call, if there
is a pending style update that will detach part of the DOM and the
the selection is within that part of the DOM when
notifyRendererOfSeletionChange is called, the rootEditableElement
algorithm ends up walking through detached parts of the render tree.

Test: editing/selection/focus-and-display-none.html

page/Frame.cpp: (WebCore::Frame::notifyRendererOfSelectionChange):

2010-05-20 James Robinson <jamesr@chromium.org>

Reviewed by Eric Seidel.

Tests putting focus into a textarea and setting display:none
https://bugs.webkit.org/show_bug.cgi?id=39389

editing/selection/focus-and-display-none-expected.txt: Added.
editing/selection/focus-and-display-none.html: Added.

12:14 PM Changeset in webkit [59855] by bfulgham@webkit.org

2 edits in trunk/WebKit/win

[WinCairo] Correct scaling for print preview
https://bugs.webkit.org/show_bug.cgi?id=39329

Reviewed by Adam Roben.

Cairo does not properly deal with Windows HDCs that have been
scaled using MM_ANISOTROPIC mapping mode, and a WindowExt and
ViewportExt setting.
(see http://bugs.freedesktop.org/show_bug.cgi?id=28161)

Instead, reset the HDC's WorldTransform to be unscaled, then
scale the cairo context to the desired scaling, and perform
the drawing operation.

WebFrame.cpp:

(WebFrame::drawHeader): Use pre-positioned context to simplify

this method.

(WebFrame::drawFooter): Use pre-positioned context to simplify

this method.

(WebFrame::spoolPage): Revise scaling logic to turn off HDC

scaling, and scale using only Cairo. Revert scaling at end
so that user-defined GDI-based routines (e.g., header/footer)
will draw in the right position.

(WebFrame::spoolPages): Identify print preview case, and

retrieve scaling factors from preview context. Set the
Cairo context to use these factors during the spoolPage
operation.

11:51 AM Changeset in webkit [59854] by Adam Roben

5 edits in trunk/WebCore

Remove code that fetched, but did nothing useful with, a CFDictionary in MediaPlayerPrivateQuickTimeVisualContext

I also removed the code in QTPixelBuffer that vended the dictionary.

Fixes <http://webkit.org/b/39435> <rdar://problem/8009278>
QTPixelBuffer passes CFDictionaries across the DLL boundary, which can
lead to crashes

Reviewed by Darin Adler.

platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp:

(WebCore::MediaPlayerPrivateQuickTimeVisualContext::retrieveCurrentImage):
Deleted code that fetched the attachments dictionary, which was never
used other than to pass it to CFRetain/CFRelease, which could be
enough to cause a crash due to incompatible copies of
CoreFoundation.dll.

platform/graphics/win/QTMovieVisualContext.h: Added a now-needed

forward declaration.

platform/graphics/win/QTPixelBuffer.cpp:
platform/graphics/win/QTPixelBuffer.h:

Removed the now-unused attachments function.

11:51 AM Changeset in webkit [59853] by Adam Roben

2 edits in trunk/WebCore

Fix a CFData leak in MediaPlayerPrivateQuickTimeVisualContext

Fixes <http://webkit.org/b/39432> <rdar://problem/8008992>

Reviewed by Ada Chan

platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp:

(WebCore::QTCFDictionaryCreateWithDataCallback): Use a RetainPtr to
hold the CFData we allocate so it will get released when this function
is exited. Also pass kCFAllocatorNull as the bytes deallocator to
CFDataCreateWithBytesNoCopy so that CF doesn't try to deallocate the
bytes we pass to it.

11:36 AM Changeset in webkit [59852] by Martin Robinson

2 edits in trunk/LayoutTests

2010-05-20 Martin Robinson <mrobinson@igalia.com>

Reviewed by Ojan Vafai.

editingBehavior settings needs to be set back to a reasonable default between tests
https://bugs.webkit.org/show_bug.cgi?id=39433

Revert the changes from r59840 to this test until there is a method
in the WebKit APIs to consistently reset the editingBehavior setting
to a reasonable default.

11:32 AM Changeset in webkit [59851] by jianli@chromium.org

2 edits in trunk/WebCore

Rename GenericTask* to CrossThreadTask* in CrossThreadTask.h.
https://bugs.webkit.org/show_bug.cgi?id=39437

Reviewed by David Levin.

dom/CrossThreadTask.h:

(WebCore::):
(WebCore::CrossThreadTask1::create):
(WebCore::CrossThreadTask1::CrossThreadTask1):
(WebCore::CrossThreadTask2::create):
(WebCore::CrossThreadTask2::CrossThreadTask2):
(WebCore::CrossThreadTask3::create):
(WebCore::CrossThreadTask3::CrossThreadTask3):
(WebCore::CrossThreadTask4::create):
(WebCore::CrossThreadTask4::CrossThreadTask4):
(WebCore::CrossThreadTask5::create):
(WebCore::CrossThreadTask5::CrossThreadTask5):
(WebCore::CrossThreadTask6::create):
(WebCore::CrossThreadTask6::CrossThreadTask6):
(WebCore::CrossThreadTask7::create):
(WebCore::CrossThreadTask7::CrossThreadTask7):
(WebCore::CrossThreadTask8::create):
(WebCore::CrossThreadTask8::CrossThreadTask8):
(WebCore::createCallbackTask):

11:31 AM Changeset in webkit [59850] by victorw@chromium.org

2 edits in trunk/LayoutTests

2010-05-20 Victor Wang <victorw@chromium.org>

Unreviewed. Update test expectations from chromium.

platform/chromium/test_expectations.txt:

10:57 AM Changeset in webkit [59849] by jianli@chromium.org

16 edits
1 move in trunk

Rename GenericWorkerTask.h to CrossThreadTask.h and move it to dom directory.
https://bugs.webkit.org/show_bug.cgi?id=39135

Reviewed by David Levin.

WebCore:

GNUmakefile.am:
WebCore.gypi:
WebCore.vcproj/WebCore.vcproj:
WebCore.xcodeproj/project.pbxproj:
dom/CrossThreadTask.h: Renamed from WebCore/workers/GenericWorkerTask.h.
html/FileStreamProxy.cpp:
loader/WorkerThreadableLoader.cpp:
websockets/WorkerThreadableWebSocketChannel.cpp:
workers/DefaultSharedWorkerRepository.cpp:
workers/WorkerMessagingProxy.cpp:
workers/WorkerScriptLoader.cpp:

WebKit/chromium:

src/WebSharedWorkerImpl.cpp:
src/WebWorkerBase.cpp:
src/WebWorkerClientImpl.cpp:
src/WebWorkerImpl.cpp:

10:52 AM EFLWebKit edited by leandro@profusion.mobi

(diff)

10:44 AM Changeset in webkit [59848] by adele@apple.com

2 edits in trunk/WebCore

Remove the Safari welcome page site-specific quirk, since its no longer needed.

Reviewed by Mark Rowe.

css/CSSStyleSheet.cpp: (WebCore::CSSStyleSheet::cssRules):

10:37 AM Changeset in webkit [59847] by steveblock@google.com

34 edits
11 adds in trunk

2010-05-20 Steve Block <steveblock@google.com>

Reviewed by Jeremy Orlow.

Provide bindings for DeviceOrientation
https://bugs.webkit.org/show_bug.cgi?id=39210

Adds ENABLE_DEVICE_ORIENTATION to XCode project file, always disabled.

Configurations/FeatureDefines.xcconfig:

2010-05-20 Steve Block <steveblock@google.com>

Reviewed by Jeremy Orlow.

Provide bindings for DeviceOrientation
https://bugs.webkit.org/show_bug.cgi?id=39210

Adds ENABLE_DEVICE_ORIENTATION to VisualStudio project files, always disabled.

win/tools/vsprops/FeatureDefines.vsprops:
win/tools/vsprops/FeatureDefinesCairo.vsprops:

2010-05-20 Steve Block <steveblock@google.com>

Reviewed by Jeremy Orlow.

Provide bindings for DeviceOrientation
https://bugs.webkit.org/show_bug.cgi?id=39210

Adds ENABLE_DEVICE_ORIENTATION to XCode project file, always disabled.

Configurations/FeatureDefines.xcconfig:

2010-05-20 Steve Block <steveblock@google.com>

Reviewed by Jeremy Orlow.

Provide bindings for DeviceOrientation
https://bugs.webkit.org/show_bug.cgi?id=39210

Tests: fast/dom/DeviceOrientation/window-property.html

fast/dom/Window/window-properties-on-device-orientation.html

Adds bindings for DeviceOrientation as defined in
http://dev.w3.org/geo/api/spec-source-orientation.html
This is guarded by ENABLE(DEVICE_ORIENTATION) which is currently disabled on
all platforms but Android.

Android.derived.jscbindings.mk:
Android.derived.v8bindings.mk:
Android.mk:
Configurations/FeatureDefines.xcconfig:
DerivedSources.cpp:
DerivedSources.make:
GNUmakefile.am:
WebCore.gypi:
WebCore.pri:
WebCore.pro:
WebCore.xcodeproj/project.pbxproj:
bindings/js/JSEventCustom.cpp: (WebCore::toJS):
bindings/v8/custom/V8EventCustom.cpp: (WebCore::toV8):
dom/DeviceOrientationEvent.cpp: Added. (WebCore::DeviceOrientationEvent::DeviceOrientationEvent): (WebCore::DeviceOrientationEvent::initDeviceOrientationEvent):
dom/DeviceOrientationEvent.h: Added. (WebCore::DeviceOrientationEvent::create): (WebCore::DeviceOrientationEvent::alpha): (WebCore::DeviceOrientationEvent::beta): (WebCore::DeviceOrientationEvent::gamma): (WebCore::DeviceOrientationEvent::isDeviceOrientationEvent):
dom/DeviceOrientationEvent.idl: Added.
dom/Event.cpp: (WebCore::Event::isDeviceOrientationEvent):
dom/Event.h:
dom/EventNames.h:
page/DOMWindow.h:
page/DOMWindow.idl:

2010-05-20 Steve Block <steveblock@google.com>

Reviewed by Jeremy Orlow.

Provide bindings for DeviceOrientation
https://bugs.webkit.org/show_bug.cgi?id=39210

Modifies existing fast/dom/Window tests to skip window.ondeviceorientation until
it is widely supported.
Adds new fast/dom/Window/window-properties-on-device-orientation.html to test
type and presence of window.ondeviceorientation.
Adds new fast/dom/DeviceOrientation directory and initial test.
Adds all DeviceOrientation tests to all skipped lists.

fast/dom/DeviceOrientation: Added.
fast/dom/DeviceOrientation/script-tests: Added.
fast/dom/DeviceOrientation/script-tests/TEMPLATE.html: Added.
fast/dom/DeviceOrientation/script-tests/window-property.js: Added. (hasOnDeviceOrientationProperty):
fast/dom/DeviceOrientation/window-property-expected.txt: Added.
fast/dom/DeviceOrientation/window-property.html: Added.
fast/dom/Window/script-tests/window-property-descriptors.js:
fast/dom/Window/window-properties-on-device-orientation-expected.txt: Added.
fast/dom/Window/window-properties-on-device-orientation.html: Added.
fast/dom/Window/window-properties.html:
platform/chromium/test_expectations.txt:
platform/gtk/Skipped:
platform/mac/Skipped:
platform/qt/Skipped:
platform/win/Skipped:

10:26 AM Changeset in webkit [59846] by kenneth@webkit.org

2 edits in trunk/WebCore

Use 0.15 as text drag delay when Q_WS_MAC is defined, which is
consistent with the Mac OS X platform.

Rubberstamped by Antti Koivisto.

page/qt/EventHandlerQt.cpp:

10:24 AM Changeset in webkit [59845] by Martin Robinson

2 edits in trunk/WebKit/win

2010-05-20 Martin Robinson <mrobinson@igalia.com>

Unreviewed.

Touch WebKit.idl to ensure that interfaces rebuild.

Interfaces/WebKit.idl: Touched.

10:15 AM Changeset in webkit [59844] by Martin Robinson

2 edits in trunk/WebKitTools

2010-05-20 Martin Robinson <mrobinson@igalia.com>

Reviewed by Ojan Vafai.

editing/selection/extend-selection-after-double-click.html crashes on the Leopard Intel release bot
https://bugs.webkit.org/show_bug.cgi?id=39431

DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::setEditingBehavior): Prevent a double-free by not having this variable be in the auto-release pool.

9:48 AM Changeset in webkit [59843] by Martin Robinson

3 edits in trunk/WebKit/win

2010-05-20 Martin Robinson <mrobinson@igalia.com>

Reviewed by Adam Roben.

Fix the Windows build and move new IDL declarations to the bottom of the file.

Interfaces/IWebPreferences.idl: Move new API to the bottom of the IDL file to prevent vtable mismatch.
WebPreferences.cpp: (WebPreferences::setEditingBehavior): Change the type of the parameter to setEditingBehavior to the proper type.

9:19 AM Changeset in webkit [59842] by Martin Robinson

2 edits in trunk/WebKit/win

2010-05-20 Martin Robinson <mrobinson@igalia.com>

Unreviewed.

Fix the Windows build.

WebView.cpp: (WebView::notifyPreferencesChanged): Change behavior to 'editingBehavior'.

9:11 AM Changeset in webkit [59841] by tkent@chromium.org

1 edit in trunk/WebKit/win/Interfaces/WebKit.idl

Unreviewed. Touch WebKit.idl as usual.

8:48 AM Changeset in webkit [59840] by Martin Robinson

32 edits in trunk