⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



May 23, 2010:

11:22 PM Changeset in webkit [60063] by hamaji@chromium.org
  • 14 edits
    19 adds in trunk

2010-05-23 Shinichiro Hamaji <​hamaji@chromium.org>

Reviewed by Alexey Proskuryakov.

0x5C of EUC-JP is not Yen Sign but U+005C
​https://bugs.webkit.org/show_bug.cgi?id=24906

  • editing/selection/find-yensign-and-backslash-with-japanese-fonts-expected.txt: Added.
  • editing/selection/find-yensign-and-backslash-with-japanese-fonts.html: Added.
  • fast/text/backslash-to-yen-sign-dynamic.html: Added.
  • fast/text/backslash-to-yen-sign.html: Added.
  • platform/chromium/test_expectations.txt:
  • platform/gtk/fast/text/backslash-to-yen-sign-dynamic-expected.txt: Added.
  • platform/gtk/fast/text/backslash-to-yen-sign-expected.txt: Added.
  • platform/mac/fast/text/backslash-to-yen-sign-dynamic-expected.checksum: Added.
  • platform/mac/fast/text/backslash-to-yen-sign-dynamic-expected.png: Added.
  • platform/mac/fast/text/backslash-to-yen-sign-dynamic-expected.txt: Added.
  • platform/mac/fast/text/backslash-to-yen-sign-expected.checksum: Added.
  • platform/mac/fast/text/backslash-to-yen-sign-expected.png: Added.
  • platform/mac/fast/text/backslash-to-yen-sign-expected.txt: Added.
  • platform/qt/fast/text/backslash-to-yen-sign-dynamic-expected.txt: Added.
  • platform/qt/fast/text/backslash-to-yen-sign-expected.txt: Added.
  • platform/win/fast/text/backslash-to-yen-sign-dynamic-expected.txt: Added.
  • platform/win/fast/text/backslash-to-yen-sign-expected.txt: Added.

2010-05-23 Shinichiro Hamaji <​hamaji@chromium.org>

Reviewed by Alexey Proskuryakov.

0x5C of EUC-JP is not Yen Sign but U+005C
​https://bugs.webkit.org/show_bug.cgi?id=24906

Tests: editing/selection/find-yensign-and-backslash-with-japanese-fonts.html

fast/text/backslash-to-yen-sign-dynamic.html
fast/text/backslash-to-yen-sign.html

  • GNUmakefile.am:
  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.vcproj/WebCoreCommon.vsprops:
  • WebCore.xcodeproj/project.pbxproj:
  • platform/graphics/Font.cpp: (WebCore::Font::Font): (WebCore::Font::operator=):
  • platform/graphics/Font.h: (WebCore::Font::needsTranscoding):
  • platform/text/CharacterNames.h:
  • platform/text/transcoder/FontTranscoder.cpp: Added. (WebCore::FontTranscoder::FontTranscoder): (WebCore::FontTranscoder::converterType): (WebCore::FontTranscoder::convert): (WebCore::FontTranscoder::needsTranscoding): (WebCore::fontTranscoder):
  • platform/text/transcoder/FontTranscoder.h: Added. (WebCore::FontTranscoder::):
  • rendering/RenderText.cpp: (WebCore::RenderText::updateNeedsTranscoding): (WebCore::RenderText::styleDidChange): (WebCore::RenderText::setTextInternal):
10:22 PM Changeset in webkit [60062] by morrita@google.com
  • 3 edits
    3 deletes in trunk

2010-05-23 MORITA Hajime <​morrita@google.com>

Unreviewed, rolling out r60060.
​http://trac.webkit.org/changeset/60060
​https://bugs.webkit.org/show_bug.cgi?id=32077

Rollout, beucause it breaks pixel tests under repaint/.

  • fast/forms/script-tests/textarea-percentage-dimensions.js: Removed.
  • fast/forms/textarea-percentage-dimensions-expected.txt: Removed.
  • fast/forms/textarea-percentage-dimensions.html: Removed.

2010-05-23 MORITA Hajime <​morrita@google.com>

Unreviewed, rolling out r60060.
​http://trac.webkit.org/changeset/60060
​https://bugs.webkit.org/show_bug.cgi?id=32077

breaks chromium test

  • rendering/RenderObject.h: (WebCore::objectIsRelayoutBoundary):
10:16 PM Changeset in webkit [60061] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-05-23 Justin Schuh <​jschuh@chromium.org>

Reviewed by Shinichiro Hamaji.

Style cleanup for r56288
​https://bugs.webkit.org/show_bug.cgi?id=39554

Cleaning up style from a previous patch. No tests needed because no
logic is changed.

  • svg/SVGFEMorphologyElement.cpp: (WebCore::SVGFEMorphologyElement::build):
9:39 PM Changeset in webkit [60060] by morrita@google.com
  • 3 edits
    3 adds in trunk

2010-05-23 MORITA Hajime <​morrita@google.com>

Reviewed by Kent Tamura.

Textarea shouldn't grow when you type.
​https://bugs.webkit.org/show_bug.cgi?id=32077

Add test for the case with various type of properties for vertical box size.
including height, min-height, max-height, padding-top/bottom, margin-top/bottom.

  • fast/forms/script-tests/textarea-percentage-dimensions.js: Added. (heightChanged):
  • fast/forms/textarea-percentage-dimensions-expected.txt: Added.
  • fast/forms/textarea-percentage-dimensions.html: Added.

2010-05-23 MORITA Hajime <​morrita@google.com>

Reviewed by Kent Tamura.

Textarea shouldn't grow when you type.
​https://bugs.webkit.org/show_bug.cgi?id=32077

<textarea> with percent-specified, height-related properties did
cause partial-layout rooted from the renderer, that resulted
different box height between full-layout and partial-layout. This
is because calcHeight() assumes that the layout calculation of the
RenderBlock's parent is ongoing. But this assumption is violated
when the RenderBlock is root of the layout calculation.

So we prevent such <textarea>'s RenderObjects from being layout
root.

Test: fast/forms/textarea-percentage-dimensions.html

  • rendering/RenderObject.h: (WebCore::objectIsRelayoutBoundary):
8:50 PM Changeset in webkit [60059] by tony@chromium.org
  • 2 edits in trunk/LayoutTests

2010-05-23 Tony Chang <​tony@chromium.org>

Not reviewed, updating test_expectations.txt

[chromium] remove editing/pasteboard/drop-link.html from test_expectations.txt
​https://bugs.webkit.org/show_bug.cgi?id=39580

  • platform/chromium/test_expectations.txt:
7:28 PM Changeset in webkit [60058] by weinig@apple.com
  • 2 edits in trunk/JavaScriptCore

Fix windows build.

7:15 PM Changeset in webkit [60057] by weinig@apple.com
  • 9 edits in trunk

Fix for ​https://bugs.webkit.org/show_bug.cgi?id=39575
Make JS DOMObject inherit from JSObjectWithGlobalObject instead of JSObject

Reviewed by Oliver Hunt.

JavaScriptCore:

Expose the global object stored in JSObjectWithGlobalObject.

(JSC::JSObjectWithGlobalObject::JSObjectWithGlobalObject):
(JSC::JSObjectWithGlobalObject::globalObject):

  • runtime/JSObjectWithGlobalObject.h:

WebCore:

  • Changes JSDOMWindowShell to inherit from JSObject instead of DOMObject since it doesn't ever go into any DOMObject tables. In a separate change, we may want to make this inherit from JSObjectWithGlobalObject since JSDOMWindowShell does store a global object pointer.
  • Change DOMObject to inherit from JSObjectWithGlobalObject instead of JSObject. In this change I am keeping around DOMObjectWithGlobalPointer, which now just uses the capabilities of JSObjectWithGlobalObject instead of implementing them itself. DOMObjectWithGlobalPointer will go away in a subsequent patch.
  • bindings/js/JSDOMBinding.h:

(WebCore::DOMObjectWithGlobalPointer::globalObject):
(WebCore::DOMObjectWithGlobalPointer::DOMObjectWithGlobalPointer):

  • bindings/js/JSDOMWindowShell.h:
  • bindings/js/JSDOMWrapper.h:

(WebCore::DOMObject::DOMObject):

6:37 PM Changeset in webkit [60056] by eric@webkit.org
  • 7 edits in trunk/WebCore

2010-05-23 Eric Seidel <​eric@webkit.org>

Unreviewed, just being a copy/paste monkey. Oook, eeek.

Add new HTML5TreeBuilder class to hold the tree builder section of the HTML5 parsing spec
​https://bugs.webkit.org/show_bug.cgi?id=39572

Add HTML5TreeBuilder.* to each of WebKit's 85,324 build systems.

  • Android.mk:
  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
6:20 PM Changeset in webkit [60055] by eric@webkit.org
  • 4 edits
    2 copies in trunk/WebCore

2010-05-23 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Add new HTML5TreeBuilder class to hold the tree builder section of the HTML5 parsing spec
​https://bugs.webkit.org/show_bug.cgi?id=39572

We've been working on the tokenization (lexing) section of the HTML5
spec until now and leaning on the old HTMLParser for tree building.
We need to start writing more of the tree building sections of the spec,
but to do that we need a place to put the new code.

This patch moves our old-to-new conversion hacks out of HTML5Tokenizer
(our Tokenizer.h implementation) and into HTML5TreeBuilder.
Follow-up patches will add new HTML5 tree building code to this file
and will allow us to switch between old and new parser/treebuilder
implementations.

No change in behavior, thus no new tests.

  • WebCore.xcodeproj/project.pbxproj:
  • html/HTML5Tokenizer.cpp: (WebCore::HTML5Tokenizer::HTML5Tokenizer): (WebCore::HTML5Tokenizer::write):
    • Call the new HTML5TreeBuilder code.
  • html/HTML5Tokenizer.h:
  • html/HTML5TreeBuilder.cpp: Added.
  • html/HTML5TreeBuilder.h: Added.
6:14 PM Changeset in webkit [60054] by tony@chromium.org
  • 2 edits in trunk/WebKit/chromium

2010-05-21 Tony Chang <​tony@chromium.org>

Reviewed by Ojan Vafai.

[chromium] if keydown is prevented, don't update the IME and clear the IME state
​https://bugs.webkit.org/show_bug.cgi?id=39475

  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::handleCompositionEvent):
6:06 PM Changeset in webkit [60053] by eric@webkit.org
  • 5 edits
    2 adds in trunk/WebKitTools

2010-05-23 Eric Seidel <​eric@webkit.org>

Reviewed by Daniel Bates.

Split PatchReader out into its own file
​https://bugs.webkit.org/show_bug.cgi?id=39576

This is in preparation for making check-webkit-style
support being passed paths to patch files on the command line.

  • Scripts/check-webkit-style:
  • Scripts/webkitpy/style/checker.py:
  • Scripts/webkitpy/style/checker_unittest.py:
  • Scripts/webkitpy/style/patchreader.py: Added.
  • Scripts/webkitpy/style/patchreader_unittest.py: Added.
  • Scripts/webkitpy/style_references.py:
4:20 PM Changeset in webkit [60052] by weinig@apple.com
  • 20 edits
    2 deletes in trunk/WebCore

Fix for ​https://bugs.webkit.org/show_bug.cgi?id=39574
Complete the merge of NamedMappedAttrMap into NamedNodeMap.

Reviewed by Oliver Hunt.

  • Android.mk:
  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::canShareStyleWithElement):
(WebCore::CSSStyleSelector::styleForElement):

  • dom/Element.cpp:

(WebCore::Element::createAttributeMap):

  • dom/NamedMappedAttrMap.cpp: Removed.
  • dom/NamedMappedAttrMap.h: Removed.
  • dom/NamedNodeMap.cpp:

(WebCore::NamedNodeMap::setClass):
(WebCore::NamedNodeMap::declCount):
(WebCore::NamedNodeMap::mapsEquivalent):
(WebCore::NamedNodeMap::mappedMapsEquivalent):

  • dom/NamedNodeMap.h:

(WebCore::NamedNodeMap::create):
(WebCore::NamedNodeMap::clearClass):
(WebCore::NamedNodeMap::classNames):
(WebCore::NamedNodeMap::hasMappedAttributes):
(WebCore::NamedNodeMap::declRemoved):
(WebCore::NamedNodeMap::declAdded):
(WebCore::NamedNodeMap::NamedNodeMap):

  • dom/StyledElement.h:

(WebCore::StyledElement::mappedAttributes):

  • html/HTML5Token.h:
  • html/HTML5Tokenizer.cpp:

(WebCore::convertToOldStyle):

  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::setInputType):

  • html/HTMLParser.cpp:

(WebCore::HTMLParser::handleIsindex):

  • html/HTMLTokenizer.cpp:

(WebCore::Token::addAttribute):
(WebCore::HTMLTokenizer::processToken):

  • html/HTMLTokenizer.h:
  • html/HTMLViewSourceDocument.cpp:

(WebCore::HTMLViewSourceDocument::createContainingTable):
(WebCore::HTMLViewSourceDocument::addSpanWithClassName):
(WebCore::HTMLViewSourceDocument::addLine):
(WebCore::HTMLViewSourceDocument::addLink):

3:22 PM Changeset in webkit [60051] by eric@webkit.org
  • 9 edits
    1 add in trunk

2010-05-23 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Teach HTML5 parser how to lex comments correctly
​https://bugs.webkit.org/show_bug.cgi?id=39537

Added a new data file for testing comment parsing. There are some more
things we can test here once we implement the bogus comment state.

  • html5lib/resources/comments01.dat: Added.
  • html5lib/webkit-runner-expected.txt:
    • Some of these tests fail in our current parser because our current parser doesn't comply with HTML5. I've set these expectations to failing so the tests will "pass" in the current parser. I've double-checked the results in comments01.dat with a nightly build of Firefox to make sure we agree on our implementation of the spec.
  • html5lib/webkit-runner.html:

2010-05-23 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Teach HTML5 parser how to lex comments correctly
​https://bugs.webkit.org/show_bug.cgi?id=39537

Implement the non-bogus comment states for the lexer. There's more
work to do in some of these states (e.g., to handle doctype tokens and
bogus comments), but I'm trying to keep the patches small.

Tests: comments01.dat

  • html/HTML5Lexer.cpp: (WebCore::HTML5Lexer::nextToken):
  • html/HTML5Lexer.h:
  • html/HTML5Token.h: (WebCore::HTML5Token::beginComment): (WebCore::HTML5Token::appendToComment): (WebCore::HTML5Token::data):
  • html/HTML5Tokenizer.cpp: (WebCore::convertToOldStyle):
  • platform/text/SegmentedString.h: (WebCore::SegmentedString::): (WebCore::SegmentedString::peek):
    • Occationally, the HTML5 parsing algorithm looks ahead in the input stream. The implementation here is incomplete, but its enough to run the current HTML5 parsing tests. I'll eventually need to implement the slow case here.
3:08 PM Changeset in webkit [60050] by eric@webkit.org
  • 4 edits in trunk/WebKitTools

2010-05-23 Adam Barth <​abarth@webkit.org>

Reviewed by Daniel Bates.

webkit-patch should let you add a comment when uploading a patch
​https://bugs.webkit.org/show_bug.cgi?id=39552

As requested by Dan "the man" Bates.

  • Scripts/webkitpy/tool/steps/options.py:
  • Scripts/webkitpy/tool/steps/postdiff.py:
2:16 PM Changeset in webkit [60049] by eric@webkit.org
  • 4 edits in trunk/LayoutTests

2010-05-23 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Add tests for previous HTML5 parser patches
​https://bugs.webkit.org/show_bug.cgi?id=39534

Now that we have the test harness working, I've added tests for the
previous HTML5 parser patches. To run these tests, you need to pass
the --html5-parser flag to DumpRenderTree (of course, you can run them
with the old parser in the usual way).

  • html5lib/resources/webkit01.dat:
  • html5lib/webkit-runner-expected.txt:
  • html5lib/webkit-runner.html:
1:53 PM Changeset in webkit [60048] by eric@webkit.org
  • 3 edits
    3 adds in trunk

2010-05-23 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Make the html5lib parser tests run using the HTML5 parser
​https://bugs.webkit.org/show_bug.cgi?id=39533

This patch adds a version of runner.html that's easier to parse (e.g.,
no doctype or HTML comments) as well as a new test data file. The
exciting thing is that this test passes in the new HTML5 parser using
this runner.

Once the HTML5 parser is strong enough, we'll remove webkit-runner.html
and have runner.html run the new webkit*.dat files.

  • html5lib/resources/webkit01.dat: Added.
  • html5lib/webkit-runner-expected.txt: Added.
  • html5lib/webkit-runner.html: Added.

2010-05-23 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Make the html5lib parser tests run using the HTML5 parser
​https://bugs.webkit.org/show_bug.cgi?id=39533

Turns out we're just one small tweak away from running the html5lib
tests. After this patch lands, we should be able to introduce tests
for every change to the HTML5 parser.

Test: html5lib/webkit-runner.html

  • html/HTML5Lexer.cpp: (WebCore::HTML5Lexer::nextToken):
1:38 PM Changeset in webkit [60047] by eric@webkit.org
  • 5 edits in trunk/WebCore

2010-05-23 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Make HTML5 parser parse <script>alert("<hi>");</script>
​https://bugs.webkit.org/show_bug.cgi?id=39525

More progress towards getting the html5lib test harness running. We
need to parse script data in the ScriptDataState. The spec says the
parser should set the lexer's state to ScriptDataState, but we want to
keep using the existing parser for a while so I've added some temporary
logic to HTML5Tokenizer to set the state in the lexer.

To get this case running, I needed to flesh out a bunch of the
ScriptDataState logic. There's a bunch more to do, but this is a
start.

I'm not 100% happy with this patch, but it lets us execute a simplified
version of the test harness up to the point where it starts running the
first test.

  • html/HTML5Lexer.cpp: (WebCore::HTML5Lexer::nextToken): (WebCore::HTML5Lexer::isAppropriateEndTag): (WebCore::HTML5Lexer::emitCurrentTagToken):
  • html/HTML5Lexer.h: (WebCore::HTML5Lexer::setState):
  • html/HTML5Token.h: (WebCore::HTML5Token::beginEndTag): (WebCore::HTML5Token::appendToCharacter): (WebCore::HTML5Token::name):
  • html/HTML5Tokenizer.cpp: (WebCore::HTML5Tokenizer::write):
12:57 PM QtWebKit edited by Laszlo Gombos
(diff)
8:44 AM Changeset in webkit [60046] by jparent@chromium.org
  • 1 edit
    2 adds in trunk/LayoutTests

Unreviewed.

Adds Chromium expectations for new test added in ​http://trac.webkit.org/changeset/60026/.
Difference is in the line number printed for the exception.

  • platform/chromium-mac/fast/dom/nested-script-exceptions-expected.txt: Added.
  • platform/chromium-win/fast/dom/nested-script-exceptions-expected.txt: Added.
7:47 AM Changeset in webkit [60045] by cmarrin@apple.com
  • 3 edits in trunk/WebCore

Limit the number of tiles created for large tiled layers
​https://bugs.webkit.org/show_bug.cgi?id=39522


I added an algorithm to limit the number of tiles created to 512.
It tried to limit them in only one dimension and if that's not
possible it limits them in both dimensions according to the
ratio of width to height. This has the effect of rendering
tiles starting from the upper-left, which is often the part
that is visible. So it both prevents crashing and tried to do
the best job it can of displaying what the author intended.

The test LayoutTests/compositing/geometry/huge-layers.html was
crashing before this fix. Now it works correctly.

  • platform/graphics/win/WebTiledLayer.cpp: (WebCore::WebTiledLayer::WebTiledLayer): (WebCore::WebTiledLayer::setBounds): (WebCore::WebTiledLayer::constrainedSize): (WebCore::WebTiledLayer::updateTiles):
  • platform/graphics/win/WebTiledLayer.h:
6:32 AM Changeset in webkit [60044] by eric@webkit.org
  • 2 edits in trunk/WebKit/chromium

2010-05-23 Roman Gershman <​romange@google.com>

Reviewed by Darin Fisher.

[Chromium] Suggestion popup is not closed when the view is scrolled.
​https://bugs.webkit.org/show_bug.cgi?id=38640

This bug appears on both Windows and Linux platforms.
Mac OS, however handles window messages differently and
closes popup menu in RenderWidgetHostViewMac::Destroy().

No tests were added because test_shell does not support suggestion
popup.

  • src/ChromeClientImpl.cpp: (WebKit::ChromeClientImpl::invalidateContentsForSlowScroll): (WebKit::ChromeClientImpl::scroll):
5:44 AM Changeset in webkit [60043] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2010-05-23 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

webkit-patch should assign newly created bugs to their creator
​https://bugs.webkit.org/show_bug.cgi?id=39548

As requested on webkit-dev.

  • Scripts/webkitpy/common/net/bugzilla.py:
5:22 AM Changeset in webkit [60042] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2010-05-23 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Hide prepare and post commands for webkit-patch
​https://bugs.webkit.org/show_bug.cgi?id=39539

It turns out these commands aren't very popular and they confuse new
users. They'll still be there for advanced users, however.

  • Scripts/webkitpy/tool/commands/upload.py:
5:10 AM Changeset in webkit [60041] by eric@webkit.org
  • 2 edits in trunk/WebKit/qt

2010-05-23 Noam Rosenthal <​noam.rosenthal@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] GraphicsLayer: The rocket animation doesn't scroll together with the page
​https://bugs.webkit.org/show_bug.cgi?id=39517

A previous fix to this issue was overridden by the PageClientQt refactor. Reapplying.

  • WebCoreSupport/PageClientQt.cpp: (WebCore::PageClientQGraphicsWidget::update):
4:59 AM Changeset in webkit [60040] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-05-23 Noam Rosenthal <​noam.rosenthal@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Using Accelerated Composing the rocket back animation on ​http://www.the-art-of-web.com/css/css-animation/ works differently as when not using AC.
​https://bugs.webkit.org/show_bug.cgi?id=39513

The value of GraphicsLayer->transform() needs to be changed during the animation, regardless of m_fillsForward.
m_fillsForward should only apply at the end of the animation. Based on previous patch by Kenneth Christiansen.

  • platform/graphics/qt/GraphicsLayerQt.cpp: (WebCore::TransformAnimationQt::applyFrame): (WebCore::OpacityAnimationQt::applyFrame):
4:15 AM Changeset in webkit [60039] by tkent@chromium.org
  • 1 edit in trunk/WebCore/bindings/js/JSAttrCustom.cpp

Unreviewed. Fix a Qt build error caused by r60037.

3:21 AM Changeset in webkit [60038] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-05-23 Kenneth Rohde Christiansen <​kenneth@webkit.org>

Reviewed by Eric Seidel.

[Qt] GraphicsLayerQt: Coding style and comment fixes.

  • platform/graphics/qt/GraphicsLayerQt.cpp: (WebCore::MaskEffectQt::MaskEffectQt): (WebCore::MaskEffectQt::draw): (WebCore::GraphicsLayerQtImpl::ContentData::ContentData): (WebCore::GraphicsLayerQtImpl::State::State): (WebCore::GraphicsLayerQtImpl::GraphicsLayerQtImpl): (WebCore::GraphicsLayerQtImpl::~GraphicsLayerQtImpl): (WebCore::GraphicsLayerQtImpl::rootLayer): (WebCore::GraphicsLayerQtImpl::recache): (WebCore::GraphicsLayerQtImpl::updateTransform): (WebCore::GraphicsLayerQtImpl::opaqueArea): (WebCore::GraphicsLayerQtImpl::flushChanges): (WebCore::GraphicsLayerQtImpl::notifyAnimationStarted): (WebCore::GraphicsLayerQt::setNeedsDisplayInRect): (WebCore::GraphicsLayerQt::setContentsToImage): (WebCore::applyTimingFunction): (WebCore::AnimationQtBase::updateState): (WebCore::AnimationQt::AnimationQt): (WebCore::AnimationQt::updateCurrentTime): (WebCore::TransformAnimationQt::applyFrame): (WebCore::TransformAnimationQt::updateState): (WebCore::OpacityAnimationQt::OpacityAnimationQt): (WebCore::OpacityAnimationQt::applyFrame): (WebCore::GraphicsLayerQt::addAnimation): (WebCore::GraphicsLayerQt::removeAnimationsForProperty): (WebCore::GraphicsLayerQt::removeAnimationsForKeyframes): (WebCore::GraphicsLayerQt::pauseAnimation): (WebCore::GraphicsLayerQt::suspendAnimations): (WebCore::GraphicsLayerQt::resumeAnimations):
  • platform/graphics/qt/GraphicsLayerQt.h:
3:05 AM Changeset in webkit [60037] by eric@webkit.org
  • 7 edits
    1 delete in trunk

2010-05-23 Justin Schuh <​jschuh@chromium.org>

Reviewed by Darin Adler.

Remove custom binding for Attr.value
​https://bugs.webkit.org/show_bug.cgi?id=39499

Test now throws a JavaScript security exception instead of not
implemented.

  • http/tests/security/xss-DENIED-iframe-src-alias-expected.txt:

2010-05-23 Justin Schuh <​jschuh@chromium.org>

Reviewed by Darin Adler.

Remove custom binding for Attr.value
​https://bugs.webkit.org/show_bug.cgi?id=39499

Custom bindings are no longer needed because origin checks were moved
out of the bindings by: ​http://trac.webkit.org/changeset/59866

  • Android.v8bindings.mk:
  • WebCore.gypi:
  • bindings/js/JSAttrCustom.cpp:
  • bindings/v8/custom/V8AttrCustom.cpp: Removed.
  • dom/Attr.idl:
2:52 AM Changeset in webkit [60036] by eric@webkit.org
  • 3 edits in trunk/WebCore

2010-05-23 Grace Kloba <​klobag@gmail.com>

Reviewed by Nate Chapin.

Match the call of scheduleLocationChange() to its correct signature.
Fixes <​http://webkit.org/b/39452>

The call of scheduleLocationChange() in generic and v8 bindings assuming the
fourth parameter is "usergesture". But it is actually the fifth parameter.

No new features. No new tests.

  • bindings/generic/BindingDOMWindow.h: (WebCore::::createWindow):
  • bindings/v8/custom/V8DOMWindowCustom.cpp: (WebCore::V8DOMWindow::openCallback):
2:41 AM Changeset in webkit [60035] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2010-05-23 Jesus Sanchez-Palencia <​jesus@webkit.org>

Reviewed by Laszlo Gombos.

[Qt] QtTestBrowser has two graphicsview options that aren't enabled correctly
​https://bugs.webkit.org/show_bug.cgi?id=39491

Making toggleResizesToContents and toggleTiledBackingStore checkable when
QtTestBrowser is started on graphics view mode.

  • QtTestBrowser/main.cpp: (LauncherWindow::createChrome):
2:30 AM Changeset in webkit [60034] by eric@webkit.org
  • 4 edits in trunk/WebKitTools

2010-05-23 Jesus Sanchez-Palencia <​jesus@webkit.org>

Reviewed by Laszlo Gombos.

[Qt] QtTestBrowser is still called QtLauncher in the code
​https://bugs.webkit.org/show_bug.cgi?id=39488

Finish the name change of QtLauncher to QtTestBrowser.

  • QtTestBrowser/main.cpp: (LauncherApplication::LauncherApplication): (LauncherApplication::handleUserOptions):
  • QtTestBrowser/mainwindow.cpp: (MainWindow::MainWindow):
  • QtTestBrowser/useragentlist.txt:
2:18 AM Changeset in webkit [60033] by eric@webkit.org
  • 2 edits in trunk/LayoutTests

2010-05-23 Anton Muhin <​antonm@chromium.org>

Reviewed by Darin Fisher.

[Chromium] Consider implementing addOriginAccessWhitelistEntry method
​https://bugs.webkit.org/show_bug.cgi?id=37578

  • platform/chromium/test_expectations.txt: remove now unnecessary skips
2:07 AM Changeset in webkit [60032] by eric@webkit.org
  • 9 edits in trunk

2010-05-23 Marcus Bulach <​bulach@chromium.org>

Reviewed by Kent Tamura.

[chromium] Adds Geolocation support to DumpRenderTree.
​https://bugs.webkit.org/show_bug.cgi?id=39440

Existing LayoutTests/fast/dom/Geolocation/* should pass.

  • public/WebGeolocationServiceMock.h:
  • src/WebGeolocationServiceMock.cpp: (WebKit::WebGeolocationServiceMock::setMockGeolocationPermission): (WebKit::WebGeolocationServiceMock::requestPermissionForFrame): (WebKit::WebGeolocationServiceMock::attachBridge): (WebKit::WebGeolocationServiceMock::detachBridge):

2010-05-23 Marcus Bulach <​bulach@chromium.org>

Reviewed by Kent Tamura.

[chromium] Adds Geolocation support to DumpRenderTree.
​https://bugs.webkit.org/show_bug.cgi?id=39440

Existing LayoutTests/fast/dom/Geolocation/* should pass.

  • DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::LayoutTestController): (LayoutTestController::setGeolocationPermission): (LayoutTestController::setMockGeolocationPosition): (LayoutTestController::setMockGeolocationError):
  • DumpRenderTree/chromium/LayoutTestController.h:
  • DumpRenderTree/chromium/TestShell.cpp: (TestShell::TestShell):
  • DumpRenderTree/chromium/WebViewHost.cpp: (WebViewHost::geolocationService):
  • DumpRenderTree/chromium/WebViewHost.h:
1:55 AM Changeset in webkit [60031] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-05-23 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Reduce copy/paste code in HTMLParser using some template functions
​https://bugs.webkit.org/show_bug.cgi?id=39471

No functional changes, thus no tests.

  • html/HTMLParser.cpp: (WebCore::addTags):
    • New function which takes a set an an array of QualifiedNames and adds the localName().impl() to the set for each QualifiedName.

(WebCore::isTablePart):
(WebCore::isScopingTag):
(WebCore::mapTagToFunc):
(WebCore::mapTagsToFunc):

  • New functions which take QualifiedNames and a function and map from the localName().impl() to the function.

(WebCore::HTMLParser::getNode):
(WebCore::HTMLParser::isHeadingTag):
(WebCore::HTMLParser::isResidualStyleTag):
(WebCore::HTMLParser::isAffectedByResidualStyle):

1:42 AM Changeset in webkit [60030] by eric@webkit.org
  • 2 edits in trunk/WebKit/qt

2010-05-23 Laszlo Gombos <Laszlo Gombos>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Update the Symbian version for the user agent
​https://bugs.webkit.org/show_bug.cgi?id=38389

Fixes a regression introduced by r58648. Ensure that the "Symbian" string
is only listed one time in the User Agent string.

In addition make an effort to align the User Agent string to already
released WebKit based products for Symbian.

  • Api/qwebpage.cpp: (QWebPage::userAgentForUrl):

May 22, 2010:

11:59 PM Changeset in webkit [60029] by mjs@apple.com
  • 3 edits in trunk/LayoutTests

2010-05-22 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Mark Rowe.

Fix fast/js/global-recursion-on-full-stack.html to no longer depend on where exactly the stack overflow occurs.
​https://bugs.webkit.org/show_bug.cgi?id=39558

  • fast/js/global-recursion-on-full-stack-expected.txt:
  • fast/js/global-recursion-on-full-stack.html:
11:45 PM Changeset in webkit [60028] by jparent@chromium.org
  • 2 edits in trunk/WebCore

REGRESSION: xssAuditor tests failing in Chromium.
​https://bugs.webkit.org/show_bug.cgi?id=39560

Reviewed by Adam Barth.

Follow up to r0014. Make if statement in V8 bindings match the one from jsc version.

  • bindings/v8/ScriptController.cpp:

(WebCore::ScriptController::evaluate):

7:11 PM Changeset in webkit [60027] by mjs@apple.com
  • 1 edit
    2 deletes in trunk/LayoutTests

2010-05-22 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Dan Bernstein.

Remove recently added test "arobens-test" because it is invalid
​https://bugs.webkit.org/show_bug.cgi?id=39555


The test below was based on a false assuption (that document.write propagates exceptions)
and was testing for incorrect behavior. The newly added fast/dom/nested-script-exceptions.html
tests for the correct behavior.

  • inspector/arobens-test-expected.txt: Removed.
  • inspector/arobens-test.html: Removed.
5:34 PM Changeset in webkit [60026] by mjs@apple.com
  • 5 edits
    2 adds in trunk

REGRESSION(r59977): platform/mac/fast/AppleScript/001.html failure
​https://bugs.webkit.org/show_bug.cgi?id=39531

Reviewed by Mark Rowe.

Revert r59977 and r59943. These changes caused some exceptions to no longer be
reported in the inspector; I can't tell what they were originally trying to fix
so I am not sure how to fix them other than by reverting.

WebCore:

Covered by existing test platform/mac/fast/AppleScript/001.html, and
also added fast/dom/nested-script-exceptions.html to demonstrate the wider
consequences of the original change.

  • bindings/js/ScriptController.cpp:

(WebCore::ScriptController::ScriptController):
(WebCore::ScriptController::evaluateInWorld):

  • bindings/js/ScriptController.h:

LayoutTests:

Unskipped the test that was broken, and also added a new test.

  • fast/dom/nested-script-exceptions-expected.txt: Added.
  • fast/dom/nested-script-exceptions.html: Added. Shows that inspector functionality

would break in a meaningful way if the reverted change was allowed to stand.

  • platform/mac/Skipped:
5:27 PM Changeset in webkit [60025] by eric@webkit.org
  • 2 edits
    1 add in trunk/WebCore

2010-05-22 Kwang Yul Seo <​skyul@company100.net>

Reviewed by Eric Seidel.

[BREWMP] Add DragData
​https://bugs.webkit.org/show_bug.cgi?id=39469

As BREW MP does not support dragging, add dummy implementation of DragData.

  • platform/DragData.h:
  • platform/brew/DragDataBrew.cpp: Added. (WebCore::DragData::canSmartReplace): (WebCore::DragData::containsColor): (WebCore::DragData::containsPlainText): (WebCore::DragData::asPlainText): (WebCore::DragData::asColor): (WebCore::DragData::createClipboard): (WebCore::DragData::containsCompatibleContent): (WebCore::DragData::containsURL): (WebCore::DragData::asURL): (WebCore::DragData::asFragment): (WebCore::DragData::asFilenames): (WebCore::DragData::containsFiles):
5:13 PM Changeset in webkit [60024] by eric@webkit.org
  • 1 edit
    1 add in trunk/WebCore

2010-05-22 Kwang Yul Seo <​skyul@company100.net>

Reviewed by Eric Seidel.

[BREWMP] Add dummy Icon
​https://bugs.webkit.org/show_bug.cgi?id=39468

Add dummy implementation of Icon.

  • platform/graphics/brew/IconBrew.cpp: Added. (WebCore::Icon::~Icon): (WebCore::Icon::createIconForFiles): (WebCore::Icon::paint):
4:46 PM Changeset in webkit [60023] by eric@webkit.org
  • 6 edits in trunk

2010-05-22 Justin Schuh <​jschuh@chromium.org>

Reviewed by Nate Chapin.

Remove and simplify custom bindings for Node
​https://bugs.webkit.org/show_bug.cgi?id=39467

Child manipulation methods now throw security exception instead of
not implemented exception.

  • http/tests/security/xss-DENIED-iframe-src-alias-expected.txt:

2010-05-22 Justin Schuh <​jschuh@chromium.org>

Reviewed by Nate Chapin.

Remove and simplify custom bindings for Node
​https://bugs.webkit.org/show_bug.cgi?id=39467

Custom bindings for nodeValue and textContent are no longer needed,
and child manipulators are simplified because origin checks were moved
out of the bindings by: ​http://trac.webkit.org/changeset/59866

  • bindings/js/JSNodeCustom.cpp: (WebCore::JSNode::insertBefore): (WebCore::JSNode::replaceChild): (WebCore::JSNode::removeChild): (WebCore::JSNode::appendChild):
  • bindings/v8/custom/V8NodeCustom.cpp: (WebCore::V8Node::insertBeforeCallback): (WebCore::V8Node::replaceChildCallback): (WebCore::V8Node::removeChildCallback): (WebCore::V8Node::appendChildCallback):
  • dom/Node.idl:
4:26 PM Changeset in webkit [60022] by eric@webkit.org
  • 4 edits in trunk/WebCore

2010-05-22 Justin Schuh <​jschuh@chromium.org>

Reviewed by Nate Chapin.

Remove custom bindings for NamedNodeMap.setNamedItem and .setNamedItemNS
​https://bugs.webkit.org/show_bug.cgi?id=39462

Custom bindings are no longer needed because origin checks were moved
out of the bindings by: ​http://trac.webkit.org/changeset/59866

Behavior isn't changed and is covered by existing tests.

  • bindings/js/JSNamedNodeMapCustom.cpp:
  • bindings/v8/custom/V8NamedNodeMapCustom.cpp:
  • dom/NamedNodeMap.idl:
3:50 PM Changeset in webkit [60021] by dbates@webkit.org
  • 1 edit in trunk/WebCore/ChangeLog

2010-05-22 Daniel Bates <​dbates@rim.com>

Unreviewed; fix bug URL in change log.

Inadvertently referenced the wrong bug URL in the change log for change-set
60019 <​http://trac.webkit.org/changeset/60019>. The bug URL should have been
<​https://bugs.webkit.org/show_bug.cgi?id=39339> not <​https://bugs.webkit.org/show_bug.cgi?id=39448>.

3:44 PM Changeset in webkit [60020] by abarth@webkit.org
  • 2 edits in trunk/WebKitTools

2010-05-22 Adam Barth <​abarth@webkit.org>

Unreviewed.

Re-order Yong's email addresses because his gmail account is the one he
uses for bugs.webkit.org.

  • Scripts/webkitpy/common/config/committers.py:
3:42 PM Changeset in webkit [60019] by dbates@webkit.org
  • 8 edits
    1 delete in trunk/WebCore

2010-05-22 Daniel Bates <​dbates@rim.com>

No review, rolling out 60017.
​http://trac.webkit.org/changeset/60017
​https://bugs.webkit.org/show_bug.cgi?id=39448

Rolling out since this broke the build on the Windows and Qt bots.
Need to look into this some more.

  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/ScriptControllerBase.h: Removed.
  • bindings/js/ScriptController.h: (WebCore::):
  • bindings/v8/ScriptController.h: (WebCore::):
3:15 PM Changeset in webkit [60018] by dbates@webkit.org
  • 1 edit in trunk/WebCore/ChangeLog

2010-05-22 Daniel Bates <​dbates@rim.com>

Unreviewed; fix change log order.

Update-webkit failed to move my change log to the top of the file
before my commit in changeset 60017 <​http://trac.webkit.org/changeset/60017>,
so I am manually moving it to the correct place.

3:08 PM Changeset in webkit [60017] by dbates@webkit.org
  • 8 edits
    1 add in trunk/WebCore

2010-05-22 Yong Li <​yoli@rim.com>

Reviewed by Darin Adler.

Fix a crash when XHTMLMP is enabled. The frame pointer in Document
ctor can be null.
​https://bugs.webkit.org/show_bug.cgi?id=39448

No new tests because it is obvious and it must be reproduced with
XHTMLMP enabled.

  • dom/Document.cpp: (WebCore::Document::Document):
3:04 PM Changeset in webkit [60016] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-05-22 Yong Li <​yoli@rim.com>

Reviewed by Darin Adler.

Fix a crash when XHTMLMP is enabled. The frame pointer in Document
ctor can be null.
​https://bugs.webkit.org/show_bug.cgi?id=39448

No new tests because it is obvious and it must be reproduced with
XHTMLMP enabled.

  • dom/Document.cpp: (WebCore::Document::Document):
2:40 PM Changeset in webkit [60015] by dbates@webkit.org
  • 2 edits
    1 add in trunk/WebKitTools

2010-05-22 Daniel Bates <​dbates@rim.com>

Reviewed by Chris Jerdonek.

Add infrastructure to parse SVN property changes
​https://bugs.webkit.org/show_bug.cgi?id=38885

Adds function VCSUtils::parseSvnDiffFooter to parse an SVN footer
that consists of one or more properties.

Note, the first line of an SVN footer begins with "Property changes on".

  • Scripts/VCSUtils.pm:
    • Added function parseSvnDiffFooter. Will use this function towards resolving Bug #39409 <​https://bugs.webkit.org/show_bug.cgi?id=39409>.
    • Removed FIXME comment above function parseSvnProperty, since it is being used by parseSvnDiffFooter.
  • Scripts/webkitperl/VCSUtils_unittest/parseSvnDiffFooter.pl: Added.
    • Added unit tests.
1:50 PM Changeset in webkit [60014] by dbates@webkit.org
  • 8 edits
    3 adds in trunk

2010-05-22 Daniel Bates <​dbates@rim.com>

Reviewed by Adam Barth.

REGRESSION (r56295): Can't create a new wave on Google Wave
​https://bugs.webkit.org/show_bug.cgi?id=39249

Instead of just using the source code portion of a JavaScript URL to
detect an XSS attack, we now include the JavaScript URL schema. This
reduces the chance of a false positive by providing additional context.

Test: http/tests/security/xssAuditor/javascript-link-safe.html

  • WebCore.base.exp: Updated exported symbols as necessary.
  • bindings/ScriptControllerBase.cpp: (WebCore::ScriptController::executeScript): Added parameter shouldAllowXSS. (WebCore::ScriptController::executeIfJavaScriptURL): Ditto.
  • bindings/js/ScriptController.cpp: (WebCore::ScriptController::evaluateInWorld): Ditto. (WebCore::ScriptController::evaluate): Ditto. (WebCore::ScriptController::executeScriptInWorld): Ditto.
  • bindings/js/ScriptController.h: Added enum ShouldAllowXSS. (WebCore::):
  • bindings/v8/ScriptController.cpp: (WebCore::ScriptController::evaluate): Added parameter shouldAllowXSS.
  • bindings/v8/ScriptController.h: Added enum ShouldAllowXSS. (WebCore::):

2010-05-22 Daniel Bates <​dbates@rim.com>

Reviewed by Adam Barth.

REGRESSION (r56295): Can't create a new wave on Google Wave
​https://bugs.webkit.org/show_bug.cgi?id=39249

Added a test to ensure that we don't raise an alarm when the source code
portion of a JavaScript URL matches some substring of the page URL or
post data.

Our existing test coverage ensures that we raise an alarm when the entire
JavaScript URL matches some substring of the page URL or post data.

  • http/tests/security/xssAuditor/javascript-link-safe-expected.txt: Added.
  • http/tests/security/xssAuditor/javascript-link-safe.html: Added.
  • http/tests/security/xssAuditor/resources/javascript-link-safe.html: Added.
1:45 PM Changeset in webkit [60013] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-05-22 Jeremy Moskovich <​jeremy@chromium.org>

Reviewed by Eric Seidel.

Document RenderObject::m_hasOverflowClip.

​https://bugs.webkit.org/show_bug.cgi?id=39425

No new functionality, so no new tests.

  • rendering/RenderObject.h:
1:15 PM Changeset in webkit [60012] by eric@webkit.org
  • 1 edit
    1 add in trunk/WebCore

2010-05-22 Kwang Yul Seo <​skyul@company100.net>

Reviewed by Eric Seidel.

[BREWMP] Add DragController
​https://bugs.webkit.org/show_bug.cgi?id=39400

Add DragController for BREW MP.

  • page/brew/DragControllerBrew.cpp: Added. (WebCore::DragController::isCopyKeyDown): (WebCore::DragController::dragOperation): (WebCore::DragController::maxDragImageSize): (WebCore::DragController::cleanupAfterSystemDrag):
1:03 PM Changeset in webkit [60011] by eric@webkit.org
  • 6 edits in trunk

2010-05-22 Leandro Pereira <​leandro@profusion.mobi>

Reviewed by Eric Seidel.

[EFL] Build fix (always compile libraries with -fPIC when compiler
is gcc; always define WTF_USE_PTHREADS).
​http://webkit.org/b/39235

  • cmake/OptionsCommon.cmake:
  • cmake/OptionsEfl.cmake:
  • cmake/WebKitHelpers.cmake:

2010-05-22 Leandro Pereira <​leandro@profusion.mobi>

Reviewed by Eric Seidel.

[EFL] Build fix (update source code lists).
​http://webkit.org/b/39235

  • CMakeLists.txt:
12:12 PM Changeset in webkit [60010] by Martin Robinson
  • 5 edits in trunk

2010-05-22 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] webkit_web_view_drag_end should call EventHandler::dragSourceEndedAt
​https://bugs.webkit.org/show_bug.cgi?id=39465

Added a helper function for converting a GDK action bitmask into a DragOperation bitmask.

No new tests as behavior has not changed.

  • platform/gtk/ClipboardUtilitiesGtk.cpp: (WebCore::gdkDragActionToDragOperation): Added.
  • platform/gtk/ClipboardUtilitiesGtk.h:

2010-05-22 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] webkit_web_view_drag_end should call EventHandler::dragSourceEndedAt
​https://bugs.webkit.org/show_bug.cgi?id=39465

Properly call EventHandler::dragSourceEndedAt so that dragEnd events are processed in the DOM.
dragSourceEndedAt is responsible for calling the dragEnd DOM event as well as cleaning up assets
(such as the Clipboard) associated with the drag source.

  • webkit/webkitwebview.cpp: (webkit_web_view_drag_end): Remember to call dragSourceEndedAt here.
12:10 PM Changeset in webkit [60009] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-05-22 Patrick Gansterer <​paroga@paroga.com>

Reviewed by Eric Seidel.

[Qt] Cleanup SharedBuffer::createWithContentsOfFile
​https://bugs.webkit.org/show_bug.cgi?id=38917

  • platform/qt/SharedBufferQt.cpp: (WebCore::SharedBuffer::createWithContentsOfFile):
11:14 AM Changeset in webkit [60008] by Martin Robinson
  • 4 edits
    2 adds in trunk

2010-05-22 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] WebKit/gtk/WebCoreSupport/DragClientGtk::startDrag should use the Clipboard::sourceOperation
​https://bugs.webkit.org/show_bug.cgi?id=39459

Add ClipboardUtilitiesGtk, a container for GTK+/WebCore clipboard utility functions.
Initially add a function which converts a WebCore::DragOperation to a bitmask of
GdkDragActions.

No new tests, because behavior has not changed.

  • GNUmakefile.am:
  • platform/gtk/ClipboardUtilitiesGtk.cpp: Added. (WebCore::dragOperationToGdkDragActions): Added.
  • platform/gtk/ClipboardUtilitiesGtk.h: Added.

2010-05-22 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] WebKit/gtk/WebCoreSupport/DragClientGtk::startDrag should use the Clipboard::sourceOperation
​https://bugs.webkit.org/show_bug.cgi?id=39459

  • WebCoreSupport/DragClientGtk.cpp: (WebKit::DragClient::startDrag): Use Clipboard::sourceOperation instead of trying to figure out the GdkDragAction manually. The DOM may have changed the appropriate list of actions anyhow.
10:59 AM Changeset in webkit [60007] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2010-05-22 Eric Seidel <​eric@webkit.org>

Unreviewed, fixing test results only.

Disable compositing tests on the commit-queue as a workaround for bug 38912
​https://bugs.webkit.org/show_bug.cgi?id=39067

  • Scripts/webkitpy/tool/steps/steps_unittest.py:
    • Update test results after my previous change.
10:55 AM Changeset in webkit [60006] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2010-05-22 Eric Seidel <​eric@webkit.org>

Unreviewed.

Disable compositing tests on the commit-queue as a workaround for bug 38912
​https://bugs.webkit.org/show_bug.cgi?id=39067

  • Scripts/webkitpy/tool/steps/runtests.py:
    • Disable all of compositing, not just compositing/iframes
10:17 AM Changeset in webkit [60005] by tkent@chromium.org
  • 8 edits in trunk

2010-05-22 Kent Tamura <​tkent@chromium.org>

Reviewed by Dimitri Glazkov.

[DRT/Chromium] Link resources and load Ahem font for Windows
​https://bugs.webkit.org/show_bug.cgi?id=39473

  • WebKit.gyp: Add net and webkit resources for Windows. Copy AHEM.TTF to DumpRenderTree.exe directory.

2010-05-22 Kent Tamura <​tkent@chromium.org>

Reviewed by Dimitri Glazkov.

[DRT/Chromium] Link resources and load Ahem font for Windows
​https://bugs.webkit.org/show_bug.cgi?id=39473

  • DumpRenderTree/chromium/DumpRenderTree.cpp: (main): Call platformInit().
  • DumpRenderTree/chromium/TestShell.h: Declare platformInit(). It is not related to TestShell class, but the implementation of paltformInit() is placed at TestShell*.{cpp,mm}.
  • DumpRenderTree/chromium/TestShellGtk.cpp: (platformInit):
  • DumpRenderTree/chromium/TestShellMac.mm: (platformInit):
  • DumpRenderTree/chromium/TestShellWin.cpp: (platformInit):
    • Make stdout/stderr binary mode
    • Load Ahem font
8:58 AM Changeset in webkit [60004] by Simon Fraser
  • 1 edit
    10 moves
    1 add in trunk/LayoutTests

2010-05-22 Simon Fraser <Simon Fraser>

Add test results for Mac; no review.

Add platform-independent test results for new tiling tests, and move them into their own directory.

  • compositing/tiling/huge-layer-add-remove-child-expected.txt: Renamed from LayoutTests/platform/win/compositing/huge-layer-add-remove-child-expected.txt.
  • compositing/tiling/huge-layer-add-remove-child.html: Renamed from LayoutTests/compositing/huge-layer-add-remove-child.html.
  • compositing/tiling/huge-layer-expected.txt: Renamed from LayoutTests/platform/win/compositing/huge-layer-expected.txt.
  • compositing/tiling/huge-layer-resize-expected.txt: Renamed from LayoutTests/platform/win/compositing/huge-layer-resize-expected.txt.
  • compositing/tiling/huge-layer-resize.html: Renamed from LayoutTests/compositing/huge-layer-resize.html.
  • compositing/tiling/huge-layer-with-layer-children-expected.txt: Renamed from LayoutTests/platform/win/compositing/huge-layer-with-layer-children-expected.txt.
  • compositing/tiling/huge-layer-with-layer-children-resize-expected.txt: Renamed from LayoutTests/platform/win/compositing/huge-layer-with-layer-children-resize-expected.txt.
  • compositing/tiling/huge-layer-with-layer-children-resize.html: Renamed from LayoutTests/compositing/huge-layer-with-layer-children-resize.html.
  • compositing/tiling/huge-layer-with-layer-children.html: Renamed from LayoutTests/compositing/huge-layer-with-layer-children.html.
  • compositing/tiling/huge-layer.html: Renamed from LayoutTests/compositing/huge-layer.html.
8:48 AM Changeset in webkit [60003] by tkent@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed.

Skip platform/mac/fast/AppleScript/001.html
​https://bugs.webkit.org/show_bug.cgi?id=39531

  • platform/mac/Skipped:
2:46 AM Changeset in webkit [60002] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

Unreviewed. Update GTK specific expected file after r59968.

  • platform/gtk/svg/css/getComputedStyle-basic-expected.txt: updated.
12:43 AM Changeset in webkit [60001] by abarth@webkit.org
  • 5 edits in trunk/WebCore

2010-05-21 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Parse attributes with HTML5 lexer
​https://bugs.webkit.org/show_bug.cgi?id=39520

This patch lets the HTML5 lexer parse attributes, as in
<div attr="foo"></div>. This patch is on the critical path to running
the html5lib tests.

  • html/HTML5Lexer.cpp: (WebCore::HTML5Lexer::nextToken):
  • html/HTML5Lexer.h:
  • html/HTML5Token.h: (WebCore::HTML5Token::beginStartTag): (WebCore::HTML5Token::beginEndTag): (WebCore::HTML5Token::addNewAttribute): (WebCore::HTML5Token::appendToAttributeName): (WebCore::HTML5Token::appendToAttributeValue): (WebCore::HTML5Token::attributes):
  • html/HTML5Tokenizer.cpp: (WebCore::convertToOldStyle):
Note: See TracTimeline for information about the timeline view.