Context Navigation

← Previous Period
Next Period →

Timeline

May 27, 2010:

10:09 PM Changeset in webkit [60343] by morrita@google.com

2 edits in trunk/WebCore

2010-05-27 MORITA Hajime <morrita@google.com>

Not reviewed. Fixed typo

rendering/RenderTheme.cpp: (WebCore::RenderTheme::adjustStyle):

9:21 PM Changeset in webkit [60342] by Darin Adler

47 edits in trunk/WebCore

2010-05-27 Darin Adler <Darin Adler>

Reviewed by David Levin.

Make more HTML DOM members private, especially constructors
https://bugs.webkit.org/show_bug.cgi?id=39697

Refactoring, so no new tests needed.

Working my way through HTMLTagNames.in from top to bottom, skipping any
that are non-trivial for some reason.

html/HTMLTagNames.in: Removed createWithNew from audio, base, basefont, blockquote, body, br, button, canvas, caption, col, colgroup, datagrid, datalist, dcell, dcol, drow, del, dir, dl, and fieldset.

mathml/mathtags.in: Removed createWithNew from msub, and msup.

dom/Document.cpp: (WebCore::Document::implicitClose): Use create function instead of new. (WebCore::Document::getCSSCanvasElement): Ditto.
editing/IndentOutdentCommand.cpp: (WebCore::createIndentBlockquoteElement): Ditto.
editing/htmlediting.cpp: (WebCore::createBreakElement): Ditto.
html/HTMLTableElement.cpp: (WebCore::HTMLTableElement::createCaption): Ditto.
html/HTMLViewSourceDocument.cpp: (WebCore::HTMLViewSourceDocument::createContainingTable): Ditto.
rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::setInnerTextValue): Ditto.

html/HTMLParser.cpp: (WebCore::HTMLParser::handleError): Use create function instead of new. Required reordering the code slightly, but the new order works fine.

html/HTMLAudioElement.cpp: (WebCore::HTMLAudioElement::create):
html/HTMLAudioElement.h:
html/HTMLBRElement.cpp: (WebCore::HTMLBRElement::create):
html/HTMLBRElement.h:
html/HTMLBaseElement.cpp: (WebCore::HTMLBaseElement::create):
html/HTMLBaseElement.h:
html/HTMLBaseFontElement.cpp: (WebCore::HTMLBaseFontElement::create):
html/HTMLBaseFontElement.h:
html/HTMLBlockquoteElement.cpp: (WebCore::HTMLBlockquoteElement::create):
html/HTMLBlockquoteElement.h:
html/HTMLBodyElement.cpp: (WebCore::HTMLBodyElement::create):
html/HTMLBodyElement.h:
html/HTMLButtonElement.cpp: (WebCore::HTMLButtonElement::create):
html/HTMLButtonElement.h:
html/HTMLCanvasElement.cpp: (WebCore::HTMLCanvasElement::create):
html/HTMLCanvasElement.h:
html/HTMLDListElement.cpp: (WebCore::HTMLDListElement::create):
html/HTMLDListElement.h:
html/HTMLDataGridCellElement.cpp: (WebCore::HTMLDataGridCellElement::create):
html/HTMLDataGridCellElement.h:
html/HTMLDataGridColElement.cpp: (WebCore::HTMLDataGridColElement::create):
html/HTMLDataGridColElement.h:
html/HTMLDataGridElement.cpp: (WebCore::HTMLDataGridElement::create):
html/HTMLDataGridElement.h:
html/HTMLDataGridRowElement.cpp: (WebCore::HTMLDataGridRowElement::create):
html/HTMLDataGridRowElement.h:
html/HTMLDataListElement.cpp: (WebCore::HTMLDataListElement::create):
html/HTMLDataListElement.h:
html/HTMLElement.cpp: (WebCore::HTMLElement::setInnerText):
html/HTMLFieldSetElement.cpp: (WebCore::HTMLFieldSetElement::create):
html/HTMLFieldSetElement.h:
html/HTMLModElement.cpp: (WebCore::HTMLModElement::HTMLModElement): (WebCore::HTMLModElement::create):
html/HTMLModElement.h:
html/HTMLTableCaptionElement.cpp: (WebCore::HTMLTableCaptionElement::create):
html/HTMLTableCaptionElement.h: Made constructors and virtual function overrides private, added create functions. Made constructors inline in cases where they were called in only one place.

html/HTMLTableColElement.cpp: (WebCore::HTMLTableColElement::HTMLTableColElement): Changed data member name from _span to m_span. (WebCore::HTMLTableColElement::create): Added. (WebCore::HTMLTableColElement::parseMappedAttribute): Updated to use m_span.
html/HTMLTableColElement.h: Made constructor and virtual function overrides private, added create function. Renamed _span to m_span.

8:21 PM Changeset in webkit [60341] by eric@webkit.org

2 edits in trunk/WebCore

2010-05-27 Kwang Yul Seo <skyul@company100.net>

Reviewed by Darin Adler.

wx port: build fix for Linux
https://bugs.webkit.org/show_bug.cgi?id=39860

Use uint16_t instead of uint16.

plugins/PluginPackageNone.cpp: (WebCore::PluginPackage::NPVersion):

7:35 PM Changeset in webkit [60340] by rolandsteiner@chromium.org

3 edits in trunk/LayoutTests

2010-05-27 Roland Steiner <rolandsteiner@chromium.org>

Reviewed by Tamura Kent.

[Chromium] Update chromium test expectations for parseFloat & toNumber tests
https://bugs.webkit.org/show_bug.cgi?id=39861

Update expectation files.

platform/chromium/fast/js/ToNumber-expected.txt:
platform/chromium/fast/js/parseFloat-expected.txt:

6:37 PM Changeset in webkit [60339] by mrowe@apple.com

5 edits in branches/safari-533-branch

Versioning.

6:35 PM Changeset in webkit [60338] by mrowe@apple.com

1 copy in tags/Safari-533.13

New tag.

5:44 PM Changeset in webkit [60337] by eric@webkit.org

2 edits
1 add in trunk/WebCore

2010-05-27 Nathan Lawrence <nlawrence@apple.com>

Reviewed by Geoffrey Garen.

https://bugs.webkit.org/show_bug.cgi?id=39460

Fixes the issue where images prefetched by JavaScript do not report
their memory usage to the GC.

There is a new test manual-tests/image-prefetch-stress.html that loads
a new 4MB image every half a second.

html/HTMLImageLoader.cpp: (WebCore::HTMLImageLoader::notifyFinished):
manual-tests/image-prefetch-stress.html: Added.

5:39 PM Changeset in webkit [60336] by mrowe@apple.com

4 edits in branches/safari-533-branch/WebCore

Merge r60317.

5:39 PM Changeset in webkit [60335] by mrowe@apple.com

4 edits in branches/safari-533-branch/WebCore

Merge r60272.

5:38 PM Changeset in webkit [60334] by mrowe@apple.com

2 edits in branches/safari-533-branch/WebCore

Merge r60252.

5:38 PM Changeset in webkit [60333] by mrowe@apple.com

4 edits
2 adds in branches/safari-533-branch

Merge r60247.

4:43 PM Changeset in webkit [60332] by eric@webkit.org

8 edits in trunk/JavaScriptCore

2010-05-27 Luiz Agostini <luiz.agostini@openbossa.org>

Reviewed by Darin Adler.

UTF-16 code points compare() for String objects
https://bugs.webkit.org/show_bug.cgi?id=39701

Moving compare() implementation from UString to StringImpl for it to be shared
with String. Adding overloaded free functions codePointCompare() in StringImpl
and WTFString. Renaming function compare in UString to codePointCompare to be
consistent.

runtime/JSArray.cpp: (JSC::compareByStringPairForQSort):
runtime/UString.cpp:
runtime/UString.h: (JSC::codePointCompare):
wtf/text/StringImpl.cpp: (WebCore::codePointCompare):
wtf/text/StringImpl.h:
wtf/text/WTFString.cpp: (WebCore::codePointCompare):
wtf/text/WTFString.h:

4:40 PM Changeset in webkit [60331] by Beth Dakin

2 edits in trunk/WebKit/mac

Change z-component to 1.

Reviewed by Simon Fraser.

WebView/WebHTMLView.mm:

(-[WebHTMLView viewDidMoveToWindow]):
(-[WebHTMLView attachRootLayer:]):

4:21 PM Changeset in webkit [60330] by eric@webkit.org

17 edits in trunk

2010-05-27 Eric Uhrhane <ericu@chromium.org>

Reviewed by Adam Barth.

Add v8 bindings for async DB API in workers
https://bugs.webkit.org/show_bug.cgi?id=39145

No new tests. This should share layout tests with JSC.

Tweak the callback generation to switch lots of Frame* to ScriptExecutionContext*, and use the context passed in to handleEvent where possible.

bindings/scripts/CodeGeneratorV8.pm:

As with CodeGeneratorV8; these are pretty much all tiny tweaks.
We do have to use a slightly different patch for callback invocation in invokeCallback, as V8Proxy::retrieve() doesn't work in the worker context.

bindings/v8/custom/V8CustomPositionCallback.cpp: (WebCore::V8CustomPositionCallback::handleEvent):
bindings/v8/custom/V8CustomPositionErrorCallback.cpp: (WebCore::V8CustomPositionErrorCallback::handleEvent):
bindings/v8/custom/V8CustomSQLStatementErrorCallback.cpp: (WebCore::V8SQLStatementErrorCallback::handleEvent):
bindings/v8/custom/V8CustomVoidCallback.cpp: (WebCore::V8CustomVoidCallback::V8CustomVoidCallback): (WebCore::V8CustomVoidCallback::handleEvent): (WebCore::invokeCallback):
bindings/v8/custom/V8CustomVoidCallback.h: (WebCore::V8CustomVoidCallback::create):
bindings/v8/custom/V8DOMWindowCustom.cpp: (WebCore::V8DOMWindow::openDatabaseCallback):
bindings/v8/custom/V8DatabaseCustom.cpp: (WebCore::V8Database::changeVersionCallback): (WebCore::createTransaction):
bindings/v8/custom/V8DatabaseSyncCustom.cpp: (WebCore::V8DatabaseSync::changeVersionCallback): (WebCore::createTransaction):
bindings/v8/custom/V8NotificationCenterCustom.cpp: (WebCore::V8NotificationCenter::requestPermissionCallback):
bindings/v8/custom/V8SQLTransactionCustom.cpp: (WebCore::V8SQLTransaction::executeSqlCallback):

Add openDatabaseCallback.

bindings/v8/custom/V8WorkerContextCustom.cpp: (WebCore::V8WorkerContext::openDatabaseCallback): Remove an obsolete parameter. (WebCore::V8WorkerContext::openDatabaseSyncCallback):

2010-05-27 Eric Uhrhane <ericu@chromium.org>

Reviewed by Adam Barth.

Add v8 bindings for async DB API in workers
https://bugs.webkit.org/show_bug.cgi?id=39145

src/DatabaseObserver.cpp: We should check that we're on the context thread now, not the main thread. (WebCore::DatabaseObserver::databaseOpened): (WebCore::DatabaseObserver::databaseModified): (WebCore::DatabaseObserver::databaseClosed):

4:12 PM Changeset in webkit [60329] by crogers@google.com

12 edits in branches/audio/WebCore

preliminary changes to build on Windows

4:09 PM Changeset in webkit [60328] by Darin Adler

8 edits in trunk

2010-05-26 Darin Adler <Darin Adler>

Reviewed by Kent Tamura.

Null characters handled incorrectly in ToNumber conversion
https://bugs.webkit.org/show_bug.cgi?id=38088

runtime/JSGlobalObjectFunctions.cpp: (JSC::parseInt): Changed code to use UTF8String().data() instead of ascii() to fix the thread safety issue. Code path is covered by existing tests in run-javascriptcore-tests. (JSC::parseFloat): Moved comment to UString::toDouble since the issue affects all clients, not just parseFloat. Specifically, this also affects standard JavaScript numeric conversion, ToNumber.

runtime/UString.cpp: (JSC::UString::toDouble): Added a comment about incorrect space skipping. Changed trailing junk check to use the length of the CString instead of checking for a null character. Also got rid of a little unneeded logic in the case where we tolerate trailing junk.

2010-05-26 Darin Adler <Darin Adler>

Reviewed by Kent Tamura.

Null characters handled incorrectly in ToNumber conversion
https://bugs.webkit.org/show_bug.cgi?id=38088

fast/js/ToNumber-expected.txt: Updated for new tests and to expect PASS for two null character tests.
fast/js/ToNumber.js: Added more test cases.
fast/js/parseFloat-expected.txt: Updated for new test case.
fast/js/script-tests/parseFloat.js: Added a test case.

3:52 PM Changeset in webkit [60327] by eric@webkit.org

2 edits in trunk/WebCore

2010-05-27 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: [REGRESSION] Query parameters are not displayed in the resources headers section.

https://bugs.webkit.org/show_bug.cgi?id=39848

inspector/front-end/ResourceView.js: (WebInspector.ResourceView): (WebInspector.ResourceView.prototype._refreshRequestPayload):

3:41 PM Changeset in webkit [60326] by eric@webkit.org

11 edits
1 copy
2 adds in trunk/WebCore

2010-05-27 Nico Weber <thakis@chromium.org>

Reviewed by Eric Seidel

https://bugs.webkit.org/show_bug.cgi?id=39092

Add Yank support to chromium mac. Do this by moving WebKit Mac's
implementation of Editor::yankFromKillRing() into its own class and
then using that.

editing/Editor.cpp: Use new KillRing class.
editing/Editor.h: (WebCore::Editor::killRing): Use new KillRing class.
editing/EditorCommand.cpp: (WebCore::executeYankAndSelect): Use new KillRing class.
platform/KillRing.h: Add new KillRing class, which acts as null object. (WebCore::KillRing::~KillRing):
platform/mac/KillRingMac.h: Add new KillRingMac class, which writes to the mac's kill ring.
platform/mac/KillRingMac.mm: Add new KillRingMac class, which writes to the mac's kill ring.

3:26 PM Changeset in webkit [60325] by eric@webkit.org

2 edits in trunk/WebCore

2010-05-27 Ben Murdoch <benm@google.com>

Reviewed by Jian Li.

Build break in FileStream.cpp
https://bugs.webkit.org/show_bug.cgi?id=39841

When ENABLE_BLOB_SLICE is not defined, an undefined variable is used
in FileStream.cpp:114. Fix by using the correct variable.

Build fix so no new tests.

html/FileStream.cpp: (WebCore::FileStream::openForRead): Replace undefined variable with a defined one.

2:57 PM Changeset in webkit [60324] by eric@webkit.org

2 edits in trunk/WebCore

2010-05-27 Hans Wennborg <hans@chromium.org>

Reviewed by Jeremy Orlow.

[Chromium] Default popup window size should not depend on zoom level
https://bugs.webkit.org/show_bug.cgi?id=39835

V8DOMWindow::openCallback should not set width and height of new
window unless specified in the function's arguments.

There is already code to reset the new window's origin coordinates,
but the same thing should be done to its dimensions as well. Otherwise,
a new popup with unspecified size will have its size depending on the
parent's zoom level, which is not desirable.

This is the same as what is done in
bindings/js/JSDOMWindowCustom.cpp:826.

bindings/v8/custom/V8DOMWindowCustom.cpp: (WebCore::V8DOMWindow::openCallback):

2:45 PM Changeset in webkit [60323] by eric@webkit.org

3 edits in trunk/JavaScriptCore

2010-05-27 Nathan Lawrence <nlawrence@apple.com>

Reviewed by Geoffrey Garen.

Search for the new allocation one word at a time. Improves
performance on SunSpider by approximately 1%.
http://bugs.webkit.org/show_bug.cgi?id=39758

runtime/Collector.cpp: (JSC::Heap::allocate):
runtime/Collector.h: (JSC::CollectorBitmap::advanceToNextPossibleFreeCell):

1:26 PM Changeset in webkit [60322] by eric@webkit.org

2 edits in trunk/WebCore

2010-05-27 Anders Bakken <agbakken@gmail.com>

Reviewed by David Levin.

qt_instance.cpp has coding-style errors
https://bugs.webkit.org/show_bug.cgi?id=39744

Fix webkit coding style issues in qt_instance.cpp

bridge/qt/qt_instance.cpp: (JSC::Bindings::QtInstance::getQtInstance): (JSC::Bindings::QtInstance::removeCachedMethod): (JSC::Bindings::QtInstance::markAggregate): (JSC::Bindings::QtInstance::getPropertyNames): (JSC::Bindings::QtInstance::stringValue): (JSC::Bindings::QtField::name): (JSC::Bindings::QtField::valueFromInstance):

1:14 PM Changeset in webkit [60321] by jparent@chromium.org

3 edits in trunk/LayoutTests

Unreviewed.

Update Chromium expectations for runner.html after r60278.

platform/chromium-mac/html5lib/runner-expected.txt:
platform/chromium-win/html5lib/runner-expected.txt:

1:14 PM Changeset in webkit [60320] by eric@webkit.org

2 edits in trunk/WebCore

2010-05-27 Anders Bakken <agbakken@gmail.com>

Reviewed by David Levin.

qt_instance.h has coding-style errors
https://bugs.webkit.org/show_bug.cgi?id=39743

Fix webkit coding style issues in qt_instance.h

bridge/qt/qt_instance.h:

1:01 PM Changeset in webkit [60319] by eric@webkit.org

2 edits in trunk/WebCore

2010-05-27 Anders Bakken <agbakken@gmail.com>

Reviewed by David Levin.

qt_class.h has coding-style errors
https://bugs.webkit.org/show_bug.cgi?id=39742

Fix webkit coding style issues in qt_class.h

bridge/qt/qt_class.h:

12:50 PM Changeset in webkit [60318] by kov@webkit.org

1 copy in releases/WebKitGTK/webkit-1.3.1

Tagging 1.3.1.

12:22 PM Changeset in webkit [60317] by eric.carlson@apple.com

4 edits in trunk/WebCore

2010-05-27 Eric Carlson <eric.carlson@apple.com>

Reviewed by Darin Adler.

<rdar://problem/8016158> Crash in CVPixelBufferCreateResolvedAttributesDictionary with RLE
compressed movie.

Configure the visual context to generate Direct3D compatible pixel buffers when we are able to
use a CAImageQueue so there will be less conversion required before display. This change also
works around the issue that causes the RLE compressed movie to crash.

platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp: (WebCore::MediaPlayerPrivateQuickTimeVisualContext::load): Pass enum to QTMovieVisualContext constructor instead of CFDictionary.
platform/graphics/win/QTMovieVisualContext.cpp: (SetNumberValue): (getPixelBufferCreationOptions): New, create options dictionary appropriate for the visual context type. (pixelBufferCreationOptions): New, return options dictionary appropriate for the visual context type. (QTMovieVisualContextPriv::QTMovieVisualContextPriv): Get the options dictionary from getPixelBufferCreationOptions insteaad of taking it as a parameter. (QTMovieVisualContext::QTMovieVisualContext): Take enum instead of CFDictionary for visual context configuration type.
platform/graphics/win/QTMovieVisualContext.h:

12:07 PM Changeset in webkit [60316] by andersca@apple.com

4 edits in trunk

2010-05-27 Anders Carlsson <andersca@apple.com>

Reviewed by Adam Roben.

[Qt] REGRESSION(r60258): It broke 10 tests.
https://bugs.webkit.org/show_bug.cgi?id=39819

plugins/qt/PluginDataQt.cpp: (WebCore::PluginData::initPlugins): Append the MimeClassInfo object after it's been initialized.

2010-05-27 Anders Carlsson <andersca@apple.com>

Reviewed by Adam Roben.

[Qt] REGRESSION(r60258): It broke 10 tests.
https://bugs.webkit.org/show_bug.cgi?id=39819

Remove tests from the skipped list.

platform/qt/Skipped:

12:02 PM Changeset in webkit [60315] by kevino@webkit.org

8 edits in trunk

[wx] Build fixes for Windows after recent changes.

11:37 AM Changeset in webkit [60314] by ap@apple.com

2 edits in trunk/LayoutTests

https://bugs.webkit.org/show_bug.cgi?id=39852
[Qt] fast/encoding/yentest.html fails

platform/Qt/Skipped: Disabling the new tests for backslash transcoding.

11:34 AM Changeset in webkit [60313] by kov@webkit.org

5 edits in trunk/WebKit/gtk

2010-05-27 Gustavo Noronha Silva <Gustavo Noronha Silva>

Update documentation control files, and fix Since tags for 1.3.1.

docs/webkitgtk-docs.sgml:
docs/webkitgtk-sections.txt:
webkit/webkitwebbackforwardlist.cpp:
webkit/webkitwebview.cpp:

11:19 AM Changeset in webkit [60312] by kov@webkit.org

2 edits in trunk

2010-05-27 Gustavo Noronha Silva <Gustavo Noronha Silva>

Final make distcheck fix - clean up generated GDOM files on distclean.

GNUmakefile.am:

10:27 AM Changeset in webkit [60311] by ap@apple.com

1 edit
6 adds in trunk/LayoutTests

Reviewed by Shinichiro Hamaji.

https://bugs.webkit.org/show_bug.cgi?id=39606
Land tests for <rdar://problem/3277733>: \ in JavaScript mishandled when encoding is Japanese

fast/encoding/resources/yentestexternal.js: Added.
fast/encoding/resources/yentestexternal2.js: Added.
fast/encoding/yentest-expected.txt: Added.
fast/encoding/yentest.html: Added.
fast/encoding/yentest2-expected.txt: Added.
fast/encoding/yentest2.html: Added.

10:26 AM Changeset in webkit [60310] by Chris Fleizach

2 edits in trunk/WebCore

Bug 39324 - AX: WebKit doesn't call [super -accessibilityAttributeValue:attribute forParameter:] when it encounters a parameter$
https://bugs.webkit.org/show_bug.cgi?id=39324

No review, build fixage.

Rolling out change from r60307 until a better fix is ready.

accessibility/mac/AccessibilityObjectWrapper.mm:

(-[AccessibilityObjectWrapper accessibilityAttributeValue:forParameter:]):

10:12 AM Changeset in webkit [60309] by yurys@chromium.org

2 edits in trunk/WebCore

2010-05-27 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

[v8] Web Inspector: check that ScriptDebugListener was not removed
while messages were dispatched in the nested loop.
https://bugs.webkit.org/show_bug.cgi?id=39838

bindings/v8/ScriptDebugServer.cpp: (WebCore::ScriptDebugServer::handleV8DebugEvent):

9:26 AM Changeset in webkit [60308] by yurys@chromium.org

2 edits in trunk/WebCore

2010-05-27 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

[v8] Web Inspector: undefined script URL value should be converted to an emtpy
WebCore::String instead of "undefined" string. Otherwise it's shown
in the Scripts panel with "undefined:<line no>" URL.
https://bugs.webkit.org/show_bug.cgi?id=39845

bindings/v8/ScriptDebugServer.cpp: (WebCore::ScriptDebugServer::dispatchDidParseSource):

9:20 AM Changeset in webkit [60307] by Chris Fleizach

2 edits in trunk/WebCore

AX: WebKit doesn't call [super -accessibilityAttributeValue:attribute forParameter:] when it encounters a parameterized attribute that it doesn't handle.
https://bugs.webkit.org/show_bug.cgi?id=39324

Reviewed by Darin Adler.

Make sure that accessibilityAttributeValue:forParameter: will default to its super's implementation. This is how AppKit expects objects to behave.

accessibility/mac/AccessibilityObjectWrapper.mm:

(-[AccessibilityObjectWrapper accessibilityAttributeValue:forParameter:]):

9:18 AM Changeset in webkit [60306] by xan@webkit.org

4 edits in trunk

2010-05-27 Xan Lopez <xlopez@igalia.com>

More GTK+ distcheck fixes.

GNUmakefile.am:

9:16 AM Changeset in webkit [60305] by xan@webkit.org

4 edits in trunk

2010-05-27 Xan Lopez <xlopez@igalia.com>

Reviewed by Gustavo Noronha.

Bump for 1.3.1 release.

configure.ac:

WebKit/gtk:

2010-05-27 Xan Lopez <xlopez@igalia.com>

Reviewed by Gustavo Noronha.

Update for 1.3.1 release.

NEWS:

8:55 AM Changeset in webkit [60304] by kov@webkit.org

2 edits in trunk/JavaScriptCore

2010-05-27 Gustavo Noronha Silva <Gustavo Noronha Silva>

More build fixage for make dist.

GNUmakefile.am:

8:48 AM Changeset in webkit [60303] by yurys@chromium.org

2 edits in trunk/WebKit/chromium

2010-05-27 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Resume script execution if user tries to navigate to another URL
https://bugs.webkit.org/show_bug.cgi?id=39842

src/WebDevToolsAgentImpl.cpp: (WebKit::): (WebKit::WebDevToolsAgentImpl::didNavigate):

8:16 AM Changeset in webkit [60302] by yurys@chromium.org

2 edits in trunk/WebCore

2010-05-27 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

[v8] Web Inspector: notify ScriptDebugListener when execution is resumed
https://bugs.webkit.org/show_bug.cgi?id=39838

bindings/v8/ScriptDebugServer.cpp: (WebCore::ScriptDebugServer::handleV8DebugEvent):

8:05 AM Changeset in webkit [60301] by eric@webkit.org

2 edits in trunk/LayoutTests

2010-05-27 Tony Gentilcore <tonyg@chromium.org>

Reviewed by Ojan Vafai.

Mark some SVG tests as flaky on Windows
https://bugs.webkit.org/show_bug.cgi?id=39790

The following SVG tests have been failing intermittently on the
chromium console for the past 2+ days.

svg/clip-path/clip-path-childs-clipped.svg
svg/clip-path/clip-path-evenodd-nonzero.svg
svg/clip-path/clip-path-text-and-shape.svg
svg/text/text-text-04-t.svg
svg/text/text-text-05-t.svg

platform/chromium/test_expectations.txt:

7:36 AM Changeset in webkit [60300] by eric@webkit.org

2 edits in trunk/WebCore

2010-05-27 Anders Bakken <agbakken@gmail.com>

Reviewed by David Levin.

qt_pixmapruntime.cpp has coding-style errors
https://bugs.webkit.org/show_bug.cgi?id=39745

Fix webkit coding style issues in qt_pixmapruntime.cpp

bridge/qt/qt_pixmapruntime.cpp:

6:42 AM Changeset in webkit [60299] by jorlow@chromium.org

4 edits
2 copies
2 moves
4 adds
1 delete in trunk

2010-05-26 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Steve Block.

Clean up IndexedDB layout tests
https://bugs.webkit.org/show_bug.cgi?id=39748

Split basics.js into a common library plus 2 other tests. This
will make it easier to ensure good test coverage as we go forward
without too much cut and paste coding. For the most part, each
IndexedDB idl file should have its own test in the future (at a
minimum).

Also switching the 'description' portion of the test expectation
to reflect the build fix from last night (which breaks the feature).

storage/indexeddb/basics-expected.txt: Removed.
storage/indexeddb/basics.html: Removed.
storage/indexeddb/idb-database-request-expected.txt: Added.
storage/indexeddb/idb-database-request.html: Added.
storage/indexeddb/indexed-database-request-expected.txt: Added.
storage/indexeddb/indexed-database-request.html: Added.
storage/indexeddb/resources/shared.js: Added. (init): (done): (verifyEventCommon): (verifyErrorEvent): (verifySuccessEvent): (verifyResult): (unexpectedErrorCallback):
storage/indexeddb/script-tests/TEMPLATE.html:
storage/indexeddb/script-tests/basics.js: Removed.
storage/indexeddb/script-tests/idb-database-request.js: Added. (openSuccess): (test):
storage/indexeddb/script-tests/indexed-database-request.js: Added. (openCallback): (test):

2010-05-26 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Steve Block.

Clean up IndexedDB layout tests
https://bugs.webkit.org/show_bug.cgi?id=39748

Remove an assert that always fires.

Tests: storage/indexeddb/idb-database-request.html

storage/indexeddb/indexed-database-request.html

storage/IDBDatabaseImpl.cpp: (WebCore::IDBDatabaseImpl::objectStores):

6:35 AM Changeset in webkit [60298] by kov@webkit.org

2 edits in trunk

2010-05-27 Gustavo Noronha Silva <Gustavo Noronha Silva>

Reviewed by Xan Lopez.

Build fix for introspection support - make sure DOM headers are
included by the GI scanner.

GNUmakefile.am:

6:12 AM Changeset in webkit [60297] by pfeldman@chromium.org

3 edits
2 deletes in trunk

2010-05-27 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: Get CSS rule offsets lazily.

https://bugs.webkit.org/show_bug.cgi?id=39832

inspector/InspectorCSSStore.cpp: (WebCore::InspectorCSSStore::getStartEndOffsets):
inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::buildObjectForRule):

6:02 AM Changeset in webkit [60296] by eric@webkit.org

2 edits in trunk/WebCore

2010-05-27 Anders Bakken <agbakken@gmail.com>

Reviewed by David Levin.

qt_class.cpp has coding-style errors
https://bugs.webkit.org/show_bug.cgi?id=39741

Fix webkit coding style issues in qt_class.cpp

bridge/qt/qt_class.cpp: (JSC::Bindings::QtClass::fieldNamed):

5:48 AM Changeset in webkit [60295] by eric@webkit.org

1 edit
3 adds in trunk/LayoutTests

2010-05-27 Jedrzej Nowacki <jedrzej.nowacki@nokia.com>

Reviewed by Brady Eidson.

New Layout test for the history.pushState function.

The test checks if history.length property is correct after
a few pushState calls.

history.pushState doesn't work for the first page in a window.
https://bugs.webkit.org/show_bug.cgi?id=39418

fast/loader/stateobjects/pushstate-without-history-expected.txt: Added.
fast/loader/stateobjects/pushstate-without-history.html: Added.

5:36 AM Changeset in webkit [60294] by eric@webkit.org

2 edits in trunk/JavaScriptCore

2010-05-27 Kwang Yul Seo <skyul@company100.net>

Reviewed by Darin Adler.

RVCT does not have strnstr.
https://bugs.webkit.org/show_bug.cgi?id=39719

Add COMPILER(RVCT) guard to strnstr in StringExtras.h as RVCT does not provide strnstr.

wtf/StringExtras.h:

5:14 AM Changeset in webkit [60293] by Philippe Normand

3 edits in trunk/WebKitTools

2010-05-27 Philippe Normand <pnormand@igalia.com>

Reviewed by Shinichiro Hamaji.

check-webkit-style complains about use of NULL in GTK function calls that require sentinels
https://bugs.webkit.org/show_bug.cgi?id=39372

Don't warn about NULL in g_*() calls. Zero can't be used instead
for calls like g_build_filename and g_object_get/set.

Scripts/webkitpy/style/checkers/cpp.py:
Scripts/webkitpy/style/checkers/cpp_unittest.py:

5:12 AM Changeset in webkit [60292] by eric@webkit.org

2 edits in trunk/WebCore

2010-05-27 Eric Seidel <eric@webkit.org>

Reviewed by Darin Adler.

Remove bit-rotten INSTRUMENT_LAYOUT_SCHEDULING code from HTMLTokenizer
https://bugs.webkit.org/show_bug.cgi?id=39714

This came from a discussion on #webkit with Hyatt about this code
being old and no longer used to either of our knowledge.

No functional changes, thus no tests.

I also removed a bogus FIXME I had added in an earlier patch
before I understood what the HTMLTokenizer was trying to do.

html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::scriptHandler): (WebCore::HTMLTokenizer::scriptExecution): (WebCore::HTMLTokenizer::continueProcessing): (WebCore::HTMLTokenizer::willWriteHTML): (WebCore::HTMLTokenizer::didWriteHTML): (WebCore::HTMLTokenizer::timerFired): (WebCore::HTMLTokenizer::executeExternalScriptsIfReady):

5:01 AM Changeset in webkit [60291] by eric@webkit.org

6 edits in trunk/WebCore

2010-05-27 Anton Muhin <antonm@chromium.org>

Reviewed by Adam Barth.

Add callbacks to ScriptController to allow notifications on named items additions and removals
https://bugs.webkit.org/show_bug.cgi?id=39679

bindings/js/ScriptController.h: Callbacks with empty implementation added. (WebCore::ScriptController::namedItemAdded): (WebCore::ScriptController::namedItemRemoved):
bindings/v8/ScriptController.cpp: Empty implementation of callbacks. (WebCore::ScriptController::namedItemAdded): (WebCore::ScriptController::namedItemRemoved):
bindings/v8/ScriptController.h: Callbacks added.
html/HTMLDocument.cpp: Hooking in callbacks. (WebCore::HTMLDocument::addItemToMap): (WebCore::HTMLDocument::removeItemFromMap):
html/HTMLDocument.h:

4:43 AM Changeset in webkit [60290] by eric@webkit.org

10 edits
2 adds in trunk

2010-05-27 Zhenyao Mo <zmo@google.com>

Reviewed by Dimitri Glazkov.

Implement lazy clearing of renderbuffers
https://bugs.webkit.org/show_bug.cgi?id=36248

fast/canvas/webgl/renderbuffer-initialization-expected.txt: Added.
fast/canvas/webgl/renderbuffer-initialization.html: Added.

2010-05-27 Zhenyao Mo <zmo@google.com>

Reviewed by Dimitri Glazkov.

Implement lazy clearing of renderbuffers
https://bugs.webkit.org/show_bug.cgi?id=36248

Test: fast/canvas/webgl/renderbuffer-initialization.html

html/canvas/WebGLFramebuffer.cpp: (WebCore::WebGLFramebuffer::WebGLFramebuffer): Init added members. (WebCore::WebGLFramebuffer::setAttachment): Set attachment object. (WebCore::WebGLFramebuffer::onBind): Perform buffer clearing if needed. (WebCore::WebGLFramebuffer::onAttachedObjectChange): Ditto. (WebCore::WebGLFramebuffer::isUninitialized): Check whether an attached object is uninitialized renderbuffer. (WebCore::WebGLFramebuffer::setInitialized): After initialize a renderbuffer, set the flag. (WebCore::WebGLFramebuffer::initializeRenderbuffers): Clear un-initialized renderbuffers if framebuffer is complete.
html/canvas/WebGLFramebuffer.h: (WebCore::WebGLFramebuffer::isDepthAttached): Changed to check object. (WebCore::WebGLFramebuffer::isStencilAttached): Ditto. (WebCore::WebGLFramebuffer::isDepthStencilAttached): Ditto.
html/canvas/WebGLRenderbuffer.cpp: (WebCore::WebGLRenderbuffer::WebGLRenderbuffer): Init added members.
html/canvas/WebGLRenderbuffer.h: (WebCore::WebGLRenderbuffer::isInitialized): As the function name. (WebCore::WebGLRenderbuffer::setInitialized): Ditto.
html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::bindFramebuffer): Call onBind(). (WebCore::WebGLRenderingContext::copyTexImage2D): Call onAttachedObjectChange(). (WebCore::WebGLRenderingContext::deleteRenderbuffer): Ditto. (WebCore::WebGLRenderingContext::deleteTexture): Ditto. (WebCore::WebGLRenderingContext::framebufferRenderbuffer): Call setAttachment. (WebCore::WebGLRenderingContext::framebufferTexture2D): Call onAttachedObjectChange(). (WebCore::WebGLRenderingContext::renderbufferStorage): Ditto. (WebCore::WebGLRenderingContext::texImage2DBase): Ditto.
platform/graphics/mac/GraphicsContext3DMac.cpp: (WebCore::GraphicsContext3D::reshape): Initialize internal buffers.

2010-05-27 Zhenyao Mo <zmo@google.com>

Reviewed by Dimitri Glazkov.

Implement lazy clearing of renderbuffers
https://bugs.webkit.org/show_bug.cgi?id=36248

src/WebGraphicsContext3DDefaultImpl.cpp: (WebKit::WebGraphicsContext3DDefaultImpl::reshape): Clear WebGL internal buffers.

3:51 AM Changeset in webkit [60289] by eric@webkit.org

2 edits in trunk/WebCore

2010-05-27 Kristian Monsen <kristianm@google.com>

Reviewed by Darin Adler.

Compile fix for Android, added include for Refcounted.h, this did not get
included through Threading.h in Android.
https://bugs.webkit.org/show_bug.cgi?id=39678

Build fix only, no new tests.

storage/SQLTransactionSyncCallback.h:

3:39 AM Changeset in webkit [60288] by eric@webkit.org

2 edits in trunk/WebCore

2010-05-27 Joone Hur <joone@kldp.org>

Reviewed by Xan Lopez.

Add GtkVersioning.h in ScrollbackGtk.cpp for maintaining compatibility with the previous GTK+

https://bugs.webkit.org/show_bug.cgi?id=39567

platform/gtk/ScrollbarGtk.cpp:

3:28 AM Changeset in webkit [60287] by eric@webkit.org

6 edits
4 adds in trunk

2010-05-27 Hans Wennborg <hans@chromium.org>

Reviewed by Alexey Proskuryakov.

Increase limit on number of (i)frames from 200 to 1000.
https://bugs.webkit.org/show_bug.cgi?id=39427

Add layout tests that test the possibility of generating 1000 iframes.

compositing/iframes/lots-of-iframes-expected.txt: Added.
compositing/iframes/lots-of-iframes.html: Added.
compositing/iframes/lots-of-objects-expected.txt: Added.
compositing/iframes/lots-of-objects.html: Added.

2010-05-27 Hans Wennborg <hans@chromium.org>

Reviewed by Alexey Proskuryakov.

Increase limit on number of (i)frames from 200 to 1000.
https://bugs.webkit.org/show_bug.cgi?id=39427

The limit on number of iframes was introduced in r3707 back in 2003.
An example of a page that is broken because of this is:
http://vimcolorschemetest.googlecode.com/svn/html/index-c.html
Neither Firefox nor IE has such a limit.

It seems that WebKit can handle a significantly higher number of frames, and
the original reasons for imposing the limit are believed to be gone.

Tests: compositing/iframes/lots-of-iframes.html

compositing/iframes/lots-of-objects.html

html/HTMLFrameElementBase.cpp: (WebCore::HTMLFrameElementBase::isURLAllowed):
page/FrameTree.cpp: (WebCore::FrameTree::uniqueChildName):
page/Page.h:
rendering/RenderEmbeddedObject.cpp: (WebCore::isURLAllowed):

2:51 AM Changeset in webkit [60286] by eric@webkit.org

2 edits in trunk/WebCore

2010-05-27 Kwang Yul Seo <skyul@company100.net>

Reviewed by Xan Lopez.

[GTK] writeToFile fails when length is large
https://bugs.webkit.org/show_bug.cgi?id=39666

writeToFile forgot to increment data pointer.

platform/gtk/FileSystemGtk.cpp: (WebCore::writeToFile):

2:37 AM Changeset in webkit [60285] by eric@webkit.org

3 edits
7 adds in trunk

2010-05-27 Luiz Agostini <luiz.agostini@openbossa.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Platform plugin example
https://bugs.webkit.org/show_bug.cgi?id=39489

Adding a Qt platform plugin example to repository.

examples/platformplugin/README: Added.
examples/platformplugin/WebPlugin.cpp: Added. (Popup::populateList): (Popup::onItemSelected): (WebPopup::WebPopup): (WebPopup::~WebPopup): (WebPopup::createSingleSelectionPopup): (WebPopup::createMultipleSelectionPopup): (WebPopup::createPopup): (WebPopup::show): (WebPopup::hide): (WebPopup::popupClosed): (WebPopup::itemClicked): (SingleSelectionPopup::SingleSelectionPopup): (MultipleItemListDelegate::MultipleItemListDelegate): (MultipleItemListDelegate::paint): (MultipleSelectionPopup::MultipleSelectionPopup): (WebPlugin::supportsExtension):
examples/platformplugin/WebPlugin.h: Added. (Popup::Popup): (WebPlugin::createSelectInputMethod):
examples/platformplugin/platformplugin.pro: Added.
examples/platformplugin/qwebkitplatformplugin.h: Copied from WebKit/qt/Api/qwebkitplatformplugin.h. (QWebSelectData::~QWebSelectData): (QWebSelectData::): (QWebSelectMethod::~QWebSelectMethod): (QWebKitPlatformPlugin::~QWebKitPlatformPlugin): (QWebKitPlatformPlugin::):

2010-05-27 Luiz Agostini <luiz.agostini@openbossa.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Platform plugin example
https://bugs.webkit.org/show_bug.cgi?id=39489

Exempting directory WebKit/qt/examples/ from style guide.

Scripts/webkitpy/style/checker.py:

2:30 AM Changeset in webkit [60284] by Martin Robinson

2 edits in trunk/WebKit/gtk

[GTK] Dragging onto the desktop causes a critical GLib warning
https://bugs.webkit.org/show_bug.cgi?id=39718

Reviewed by Xan Lopez.

Only increment the window reference count if it is not null during drag-end
signal processing.

webkit/webkitwebview.cpp:

(webkit_web_view_drag_end): Guard against null window values.

2:21 AM Changeset in webkit [60283] by Philippe Normand

3 edits in trunk/WebKitTools

2010-05-26 Philippe Normand <pnormand@igalia.com>

Reviewed by David Levin.

[style] Allow usage of NULL in gst_*_many()
https://bugs.webkit.org/show_bug.cgi?id=39740

Don't warn if NULL is used by gst_*_many() functions. Zero can't
be used for the reason explained in Bug 32858.

Scripts/webkitpy/style/checkers/cpp.py:
Scripts/webkitpy/style/checkers/cpp_unittest.py:

1:30 AM Changeset in webkit [60282] by hyatt@apple.com

7 edits in trunk/WebCore

https://bugs.webkit.org/show_bug.cgi?id=39783, clean up the moveChild functions on RenderBlock.

Reviewed by Sam Weinig.

Eliminate the need to pass the toChildrenList to the moveChild functions by tightening up the type of the
|to| argument to be a RenderBlock.

Add a moveChildrenTo function that can move a range of children, and patch places that were doing this
by hand.

Make the append forms of the functions just use the insert forms with a beforeChild of 0.

Patch insertChildNode in RenderObjectChildList so that it passes the fullInsert parameter through in the
case where it does an append.

Add an assert to RenderLayer that catches bad structure built when the fullInsert/Remove parameters are
messed up when using append/insertChildNode.

rendering/RenderBlock.cpp:

(WebCore::RenderBlock::splitAnonymousBlocksAroundChild):
(WebCore::RenderBlock::makeChildrenAnonymousColumnBlocks):
(WebCore::RenderBlock::createAndAppendRootInlineBox):
(WebCore::RenderBlock::moveChildTo):
(WebCore::RenderBlock::moveChildrenTo):
(WebCore::RenderBlock::makeChildrenNonInline):
(WebCore::RenderBlock::removeChild):

rendering/RenderBlock.h:

(WebCore::RenderBlock::moveChildTo):
(WebCore::RenderBlock::moveAllChildrenTo):
(WebCore::RenderBlock::moveChildrenTo):

rendering/RenderLayer.cpp:

(WebCore::RenderLayer::addChild):

rendering/RenderObjectChildList.cpp:

(WebCore::RenderObjectChildList::insertChildNode):

rendering/RenderRubyBase.cpp:

(WebCore::RenderRubyBase::moveInlineChildren):

1:30 AM Changeset in webkit [60281] by Csaba Osztrogonác

2 edits in trunk/LayoutTests

Unreviewed. Add failing tests to the Skipped list temporarily.

[Qt] REGRESSION(r60258): It broke 10 tests.
https://bugs.webkit.org/show_bug.cgi?id=39819

platform/qt/Skipped:

1:17 AM Changeset in webkit [60280] by eric@webkit.org

6 edits in trunk

2010-05-27 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Add <pre>/<listing> hack to HTML5Lexer to fix the last remaining HTML5 test suite regressions
https://bugs.webkit.org/show_bug.cgi?id=39818

html5lib/runner-expected-html5.txt:

2010-05-27 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Add <pre>/<listing> hack to HTML5Lexer to fix the last remaining HTML5 test suite regressions
https://bugs.webkit.org/show_bug.cgi?id=39818

HTML parsers are supposed to ignore the first \n after a <pre> or <listing> tag
for authoring convenience. Our new HTML5Lexer didn't have this hack yet
so there were 4 HTML5 tests failing. Fixing this fixed the last of the HTML5
test suite regressions using the HTML5Lexer vs the old lexer.

html/HTML5Lexer.cpp: (WebCore::HTML5Lexer::reset): (WebCore::HTML5Lexer::nextToken):
html/HTML5Lexer.h: (WebCore::HTML5Lexer::skipLeadingNewLineForListing):
html/HTML5TreeBuilder.cpp: (WebCore::HTML5TreeBuilder::passTokenToLegacyParser):

1:00 AM Changeset in webkit [60279] by abarth@webkit.org

1 add in trunk/LayoutTests/html5lib/runner-expected-html5.txt

Add missing file from my last commit.

12:44 AM Changeset in webkit [60278] by abarth@webkit.org

5 edits
3 deletes in trunk

2010-05-27 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Remove custom webkit runner and update normal runner with our nifty
goodness.

html5lib/runner-expected.txt:
html5lib/runner.html:
html5lib/webkit-runner-expected-html5.txt: Removed.
html5lib/webkit-runner-expected.txt: Removed.
html5lib/webkit-runner.html: Removed.

2010-05-27 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Update script to run the normal version of the parser tests.

Scripts/test-html5-parser:

12:20 AM Changeset in webkit [60277] by abarth@webkit.org

2 edits in trunk/WebKitTools

2010-05-27 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Add HTML5 parser support to run-webkit-tests
https://bugs.webkit.org/show_bug.cgi?id=39815

Scripts/old-run-webkit-tests:

12:18 AM Changeset in webkit [60276] by rolandsteiner@chromium.org

2 edits in trunk/WebKit/chromium

2010-05-26 Roland Steiner <rolandsteiner@chromium.org>

Reviewed by NOBODY (layout test crashing fix).

Bug 39811 - WebPluginListBuilderImpl::addMediaTypeToLastPlugin does not initialize pluginIndex
https://bugs.webkit.org/show_bug.cgi?id=39811

Initialize the pluginIndex field (quick fix).

Tests: covered by fast/dom/prototype-inheritance-2.html
(crashed under Chromium Linux and Windows)

src/WebPluginListBuilderImpl.cpp: (WebKit::WebPluginListBuilderImpl::addMediaTypeToLastPlugin):

12:14 AM Changeset in webkit [60275] by eric@webkit.org

17 edits
1 copy
1 add in trunk

2010-05-26 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Update our expectations now that we're handling external scripts.

html5lib/webkit-runner-expected-html5.txt:

2010-05-26 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Teach the HTML5 parser how to handle external scripts
https://bugs.webkit.org/show_bug.cgi?id=39716

Make it possible for the HTML5Tokenizer to run external scripts.
I created a new class HTML5ScriptRunner to hold all of the
script-logic which is scattered throughout the old HTMLTokenizer.

The design is for the HTML5Tokenizer (the "controller") to hold
the Lexer, TreeBuilder and ScriptRunner. The Lexer returns back
to the controller, which passes tokens to the TreeBuilder. When the
treebuilder encounters a </script> tag it pauses itself and returns
back to the controller which calls the ScriptRunner. The TreeBuilder
is un-paused when the HTML5Tokenizer calls takeScriptToProcess().

The ScriptRunner attempts to process the passed script, and additionally
any blocked scripts it can. It returns to the controller indicating if
parsing should continue. If not, callbacks when external scripts load
or when stylesheets are finished parsing will cause the controller to
kick off script execution and parsing again at a later point.

WebCore.xcodeproj/project.pbxproj:
- Add HTML5ScriptRunner.*
bindings/js/CachedScriptSourceProvider.h:
- Add missing include discovered while building.
dom/ScriptElement.cpp: (WebCore::ScriptElement::finishParsingChildren):
- Remove previous hack for inline <script> execution.
dom/ScriptElement.h:
- Explain the HTML5 spec names for m_evaluated and m_createdByParser.
html/HTML5ScriptRunner.cpp: Added. (WebCore::HTML5ScriptRunner::HTML5ScriptRunner):
- The HTML5Tokenizer is passed to the HTML5ScriptRunner as a CachedResourceClient. The HTML5ScriptRunner will register the HTML5Tokenizer for notifyFinished callbacks when the scripts load. The HTML5Tokenizer is expected to call the HTML5ScriptRunner to execute any loaded scripts at that point.

(WebCore::HTML5ScriptRunner::~HTML5ScriptRunner):
(WebCore::HTML5ScriptRunner::frame): Helper method.
(WebCore::createScriptLoadEvent): Helper method.
(WebCore::createScriptErrorEvent): Helper method.
(WebCore::HTML5ScriptRunner::sourceFromPendingScript):

Helper method for dealing with both inline and external script types.

(WebCore::HTML5ScriptRunner::isPendingScriptReady):

Helper for dealing with both inline and external scripts.

(WebCore::HTML5ScriptRunner::executePendingScript):

Execute one script. Both external and inline scripts can become m_parsingBlockingScript if they can't be executed immediately after parsing.

(WebCore::HTML5ScriptRunner::execute):

Takes a script element from the tree builder and tries to process it.

(WebCore::HTML5ScriptRunner::executeParsingBlockingScripts):

Runs the current parsing blocking script if ready.
Running a script could add another parsing blocking script so we loop until there is no ready-to-run parsing blocking script.

(WebCore::HTML5ScriptRunner::executeScriptsWaitingForLoad):

Called by HTML5Tokenizer when a script loads.

(WebCore::HTML5ScriptRunner::executeScriptsWaitingForStylesheets):

Called by HTML5Tokenizer when stylesheets complete.

(WebCore::HTML5ScriptRunner::requestScript):

Transcription of the HTML5 spec.

(WebCore::HTML5ScriptRunner::runScript):

Transcription of the HTML5 spec.

html/HTML5ScriptRunner.h: Added.
- New class to handle script loading and execution for the HTML5 parser.
html/HTML5Tokenizer.cpp: (WebCore::HTML5Tokenizer::HTML5Tokenizer):
- Create a HTML5ScriptRunner and pass it "this" as the CachedResourceClient.

(WebCore::HTML5Tokenizer::pumpLexer):

When the parser is paused, try to run scripts.

(WebCore::HTML5Tokenizer::write):

Only pump the lexer when the parser is not paused.

(WebCore::HTML5Tokenizer::end):

finish() tells us that we've reached EOF, not end()
Only pump the lexer when the parser is not paused.

(WebCore::HTML5Tokenizer::finish):

Mark EOF, and end() if we're not waiting on scripts.

(WebCore::HTML5Tokenizer::isWaitingForScripts):

isPaused() seems to mean isPausedForExternalScripts().

(WebCore::HTML5Tokenizer::resumeParsingAfterScriptExecution):
(WebCore::HTML5Tokenizer::notifyFinished):
(WebCore::HTML5Tokenizer::executeScriptsWaitingForStylesheets):

html/HTML5Tokenizer.h:
html/HTML5TreeBuilder.cpp: (WebCore::HTML5TreeBuilder::HTML5TreeBuilder):
- Add an m_isPaused flag.

(WebCore::HTML5TreeBuilder::handleScriptStartTag):
(WebCore::HTML5TreeBuilder::handleScriptEndTag):
(WebCore::HTML5TreeBuilder::takeScriptToProcess):

Acknowledge that the caller has received the script element. It is the caller's responsibility to execute the script if necessary and re-pause the tree builder if necessary.

(WebCore::HTML5TreeBuilder::passTokenToLegacyParser):

Save off the current script tag so that it can be passed to the HTML5ScriptRunner when we're paused.

html/HTML5TreeBuilder.h: (WebCore::HTML5TreeBuilder::setPaused): (WebCore::HTML5TreeBuilder::isPaused):

May 26, 2010:

11:54 PM Changeset in webkit [60274] by abarth@webkit.org

3 edits in trunk/WebCore

2010-05-26 Adam Barth <abarth@webkit.org>

Reviewed by Darin Adler.

Implement SegmentedString::lookAheadSlowCase
https://bugs.webkit.org/show_bug.cgi?id=39802

The slow case is need by the resumer test suite. Sadly, the resumer
test suite is really slow and produces infinite errors (many of which
are false positives). I'll land more of the resumer test suite in a
future patch.

platform/text/SegmentedString.cpp: (WebCore::SegmentedString::advance):
platform/text/SegmentedString.h: (WebCore::SegmentedString::lookAhead): (WebCore::SegmentedString::lookAheadIgnoringCase): (WebCore::SegmentedString::equalsLiterally): (WebCore::SegmentedString::equalsIgnoringCase): (WebCore::SegmentedString::lookAheadInline): (WebCore::SegmentedString::lookAheadSlowCase):

11:25 PM Changeset in webkit [60273] by barraclough@apple.com

4 edits in trunk/JavaScriptCore

Bug 39795 - Add support for YARR JIT generation of greedy quantified parens at the end of the main disjunction.
(relanding r60267)

Reviewed by Oliver Hunt.

If the last item in a main disjunction is a quantified set of parentheses,
this is easier to code generate for than the general case for quantified
parentheses. This is because we never need to backtrack into the parentheses

the first match will be the final and accepted match.

This patch also somewhat reverts a recent change to when fallback to PCRE
occurs. At the minute the compiler is tracking on patterns which will
require JIT fallback. This is handy from a performance perspective (it saves
the failed attempt at JIT compilation), but it means introducing knowledge
of the JITs capabilities into the other layers of the regex compilers. For
the specific feature of back-references, add a flag tracking their presence
on the pattern, and make these expressions fallback without attempting to
JIT. For parentheses, return to detecting which cases are have or have not
been handled during JIT compilation.

18% progression on tagcloud, ~1.5% overall on sunspidey.

yarr/RegexCompiler.cpp:

(JSC::Yarr::RegexPatternConstructor::atomBackReference):
(JSC::Yarr::RegexPatternConstructor::quantifyAtom):

yarr/RegexJIT.cpp:

(JSC::Yarr::RegexGenerator::TermGenerationState::isLastTerm):
(JSC::Yarr::RegexGenerator::TermGenerationState::isMainDisjunction):
(JSC::Yarr::RegexGenerator::generateParenthesesGreedyNoBacktrack):
(JSC::Yarr::RegexGenerator::generateTerm):
(JSC::Yarr::RegexGenerator::RegexGenerator):
(JSC::Yarr::RegexGenerator::shouldFallBack):
(JSC::Yarr::jitCompileRegex):

yarr/RegexPattern.h:

(JSC::Yarr::RegexPattern::RegexPattern):
(JSC::Yarr::RegexPattern::reset):

10:56 PM Changeset in webkit [60272] by eric.carlson@apple.com

4 edits in trunk/WebCore

2010-05-26 Jer Noble <jer.noble@apple.com>

Patch edited by Adele Peterson and Mark Rowe.
Reviewed by Eric Carlson

Video elements show no video on Windows machines that do not support accelerated compositing
https://bugs.webkit.org/show_bug.cgi?id=39446
rdar://problem/7999794

Create the visual context in setUpVideoRendering (as opposed to in load), and destroy it in
tearDownVideoRendering (as opposed to in the destructor.)

platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp: (WebCore::MediaPlayerPrivateQuickTimeVisualContext::~MediaPlayerPrivateQuickTimeVisualContext): (WebCore::MediaPlayerPrivateQuickTimeVisualContext::load): Moved creation of the visual context to setUpVideoRendering. (WebCore::MediaPlayerPrivateQuickTimeVisualContext::paint): Return early if the visual context isn't set up. (WebCore::MediaPlayerPrivateQuickTimeVisualContext::currentRenderingMode): If the visual context isn't set up, return MediaRenderingNone. (WebCore::MediaPlayerPrivateQuickTimeVisualContext::setUpVideoRendering): Create the visual context. (WebCore::MediaPlayerPrivateQuickTimeVisualContext::tearDownVideoRendering): Destroy the visual context. (WebCore::MediaPlayerPrivateQuickTimeVisualContext::hasSetUpVideoRendering): For software rendering mode, make sure the visual context has been set up when saying the setup has been done.
platform/graphics/win/QTMovieVisualContext.cpp: (QTMovieVisualContextPriv::~QTMovieVisualContextPriv): Destruction moved to tearDownVideoRendering. Also, make sure to cancel the visual context's newImageAvailable callback in the visual context's destructor. (QTMovieVisualContext::create): Added.
platform/graphics/win/QTMovieVisualContext.h:

10:17 PM Changeset in webkit [60271] by barraclough@apple.com

4 edits in trunk/JavaScriptCore

Temporarily rolling out r60267, I appear to have hoesed perf at the last minute. :-/ Fixing.

Reviewed by NOBODY (revert).

yarr/RegexCompiler.cpp:

(JSC::Yarr::RegexPatternConstructor::atomBackReference):
(JSC::Yarr::RegexPatternConstructor::quantifyAtom):

yarr/RegexJIT.cpp:

(JSC::Yarr::RegexGenerator::TermGenerationState::term):
(JSC::Yarr::RegexGenerator::generateParenthesesSingle):
(JSC::Yarr::RegexGenerator::generateTerm):
(JSC::Yarr::RegexGenerator::RegexGenerator):
(JSC::Yarr::jitCompileRegex):

yarr/RegexPattern.h:

(JSC::Yarr::RegexPattern::RegexPattern):
(JSC::Yarr::RegexPattern::reset):

9:50 PM Changeset in webkit [60270] by kov@webkit.org

6 edits in trunk

2010-05-26 Gustavo Noronha Silva <Gustavo Noronha Silva>

Build fixes for make distcheck.

GNUmakefile.am:

9:48 PM Changeset in webkit [60269] by tony@chromium.org

2 edits in trunk/LayoutTests

2010-05-26 Tony Chang <tony@chromium.org>

Not reviewed, skipping new test on gtk.

[gtk] skip editing/input/scroll-viewport-page-up-down.html because of missing eventSender methods
https://bugs.webkit.org/show_bug.cgi?id=39808

platform/gtk/Skipped:

9:18 PM Changeset in webkit [60268] by tony@chromium.org

12 edits
3 adds in trunk

2010-05-26 Zelidrag Hornung <zelidrag@chromium.org>

Reviewed by Ojan Vafai.

Fixed frame page up/down scrolling calculation. Made sure that the
cursor moves with page up/down event. Please note that now for mac
editing behavior we will scroll the content to center the cursor on
page up/down while other platforms will align the cursor with the top of
displayed frame.
https://bugs.webkit.org/show_bug.cgi?id=38213

editing/input/option-page-up-down-expected.txt: Fixed page scroll calculation. Now scroll height is calculated only from the visible portion not the entire frame height.
editing/input/option-page-up-down.html: Ditto.
editing/input/scroll-viewport-page-up-down-expected.txt: Scrolling test of contenteditable iframe and div.
editing/input/scroll-viewport-page-up-down.html: Ditto.
editing/resources/contenteditable-iframe-fixed-size-src.html: Resource for the scrolling test above.
platform/mac/editing/selection/25228.html: Change the test to have the cursor on the right edge of the screen. The original test

wasn't testing the behavior anymore.

2010-05-26 Zelidrag Hornung <zelidrag@chromium.org>

Reviewed by Ojan Vafai.

Fixed frame page up/down scrolling calculation. Made sure that the
cursor moves with page up/down event. Please note that now for mac
editing behavior we will scroll the content to center the cursor on
page up/down while other platforms will align the cursor with the top of
displayed frame.
https://bugs.webkit.org/show_bug.cgi?id=38213

Tests: editing/input/option-page-up-down.html (fixed)

editing/input/scroll-viewport-page-up-down.html

WebCore.base.exp:
editing/EditorCommand.cpp: (WebCore::verticalScrollDistance): Fixed page scroll calculation. Now scroll height is calculated only from the visible portion not the entire frame height. (WebCore::executeMovePageDown): Now it can tell SelectionController to move the cursor with the page scroll up/down events. (WebCore::executeMovePageDownAndModifySelection): Ditto. (WebCore::executeMovePageUp): Ditto. (WebCore::executeMovePageUpAndModifySelection): Ditto.
editing/SelectionController.cpp:
editing/SelectionController.cpp: Exposed an enum param that lets EditorCommand.cpp control how cursor position will be aligned when page moves. (WebCore::SelectionController::setSelection): Ditto. (WebCore::SelectionController::modify): Ditto.
editing/SelectionController.h: Ditto. (WebCore::SelectionController::): Ditto. (WebCore::SelectionController::setSelection): Ditto.

8:44 PM Changeset in webkit [60267] by barraclough@apple.com

4 edits in trunk/JavaScriptCore

Bug 39795 - Add support for YARR JIT generation of greedy quantified parens at the end of the main disjunction.

Reviewed by Oliver Hunt.

the first match will be the final and accepted match.

18% progression on tagcloud, ~1.5% overall on sunspidey.

yarr/RegexCompiler.cpp:

(JSC::Yarr::RegexPatternConstructor::atomBackReference):
(JSC::Yarr::RegexPatternConstructor::quantifyAtom):

yarr/RegexJIT.cpp:

yarr/RegexPattern.h:

(JSC::Yarr::RegexPattern::RegexPattern):
(JSC::Yarr::RegexPattern::reset):

7:14 PM Changeset in webkit [60266] by tony@chromium.org

2 edits in trunk/WebCore

2010-05-26 Jaime Yap <jaimeyap@google.com>

Reviewed by Pavel Feldman.

ScriptCallStack::callLocation() sometimes passed an empty handle to
toWebCoreString() causing a null pointer deref.
https://bugs.webkit.org/show_bug.cgi?id=39681

bindings/v8/ScriptCallStack.cpp: (WebCore::ScriptCallStack::callLocation):

7:01 PM Changeset in webkit [60265] by bweinstein@apple.com

2 edits in trunk/WebCore

Web Inspector: Tooltip on Pause on Exceptions doesn't show up until it is clicked.
https://bugs.webkit.org/show_bug.cgi?id=39804

Reviewed by Mark Rowe.

Initialize the title attribute of the Pause on Exceptions button when we initialize other information
about it.

inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel):

6:37 PM Changeset in webkit [60264] by abarth@webkit.org

6 edits in trunk/WebCore

2010-05-26 Adam Barth <abarth@webkit.org>

Unreviewed, rolling out r60262.
http://trac.webkit.org/changeset/60262
https://bugs.webkit.org/show_bug.cgi?id=39783

Broke every build and is blocking me from working. :(

rendering/RenderBlock.cpp: (WebCore::RenderBlock::splitAnonymousBlocksAroundChild): (WebCore::RenderBlock::makeChildrenAnonymousColumnBlocks): (WebCore::RenderBlock::moveChildTo): (WebCore::RenderBlock::moveAllChildrenTo): (WebCore::RenderBlock::makeChildrenNonInline): (WebCore::RenderBlock::removeChild):
rendering/RenderBlock.h:
rendering/RenderLayer.cpp: (WebCore::RenderLayer::addChild):
rendering/RenderObjectChildList.cpp: (WebCore::RenderObjectChildList::insertChildNode):
rendering/RenderRubyBase.cpp: (WebCore::RenderRubyBase::moveInlineChildren): (WebCore::RenderRubyBase::moveBlockChildren): (WebCore::RenderRubyBase::mergeBlockChildren):

6:03 PM Changeset in webkit [60263] by andersca@apple.com

7 edits in trunk/WebCore

2010-05-26 Anders Carlsson <andersca@apple.com>

Unreviewed, rolling out r60256.
http://trac.webkit.org/changeset/60256
https://bugs.webkit.org/show_bug.cgi?id=39382

Causes fast/dom/prototype-inheritance-2.html to start
crashing.

history/PageCache.cpp: (WebCore::PageCache::PageCache): (WebCore::PageCache::add):
history/PageCache.h: (WebCore::PageCache::get):
loader/DocumentLoader.cpp: (WebCore::DocumentLoader::commitIfReady):
loader/FrameLoader.cpp: (WebCore::FrameLoader::canCachePageContainingThisFrame): (WebCore::FrameLoader::canCachePage): (WebCore::pageCacheLogPrefix): (WebCore::pageCacheLog): (WebCore::FrameLoader::logCanCachePageDecision): (WebCore::FrameLoader::logCanCacheFrameDecision): (WebCore::FrameLoader::commitProvisionalLoad): (WebCore::FrameLoader::open): (WebCore::FrameLoader::continueLoadAfterNavigationPolicy): (WebCore::FrameLoader::loadProvisionalItemFromCachedPage): (WebCore::FrameLoader::cachePageForHistoryItem): (WebCore::FrameLoader::navigateToDifferentDocument):
loader/FrameLoader.h:
svg/graphics/SVGImage.cpp: (WebCore::SVGImage::dataChanged):

5:40 PM Changeset in webkit [60262] by hyatt@apple.com

6 edits in trunk/WebCore

https://bugs.webkit.org/show_bug.cgi?id=39783, clean up the moveChild functions on RenderBlock.

Reviewed by Sam Weinig.

rendering/RenderBlock.cpp:

rendering/RenderBlock.h:

(WebCore::RenderBlock::moveChildTo):
(WebCore::RenderBlock::moveAllChildrenTo):
(WebCore::RenderBlock::moveChildrenTo):

rendering/RenderLayer.cpp:

(WebCore::RenderLayer::addChild):

rendering/RenderObjectChildList.cpp:

(WebCore::RenderObjectChildList::insertChildNode):

rendering/RenderRubyBase.cpp:

(WebCore::RenderRubyBase::moveInlineChildren):

5:17 PM Changeset in webkit [60261] by ggaren@apple.com

2 edits in trunk/JavaScriptCore

Fixed a crash seen on the Leopard bot, caused by merge.

Reviewed by Sam Weinig.

jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION): Get the return address from the callframe,
since it's no longer passed to us as an argument.

5:16 PM Changeset in webkit [60260] by andersca@apple.com

3 edits in trunk/WebCore

Fix GTK+ test failures.

plugins/gtk/PluginDataGtk.cpp:

(WebCore::PluginData::initPlugins):

plugins/win/PluginDataWin.cpp:

(WebCore::PluginData::initPlugins):

4:27 PM Changeset in webkit [60259] by Beth Dakin

2 edits in trunk/WebKit/mac

Fix for <rdar://problem/7464703> HiDPI: [Layers] Compositing layers
do not scale properly when running with a resolution independent
scale

Patch by Simon Fraser <Simon Fraser> on 2010-05-26
Reviewed by Beth Dakin and Darin Adler.

Apply the userSpaceScaleFactor as a scale on the layerHostingView.

WebView/WebHTMLView.mm:

(-[WebHTMLView viewDidMoveToWindow]):
(-[WebHTMLView attachRootLayer:]):

4:20 PM Changeset in webkit [60258] by andersca@apple.com

22 edits in trunk

2010-05-26 Anders Carlsson <andersca@apple.com>

Reviewed by Darin Adler.

Clean up MimeClassInfo and PluginInfo
https://bugs.webkit.org/show_bug.cgi?id=39700

Update for WebCore changes.

src/WebPluginListBuilderImpl.cpp: (WebKit::WebPluginListBuilderImpl::addPlugin): (WebKit::WebPluginListBuilderImpl::addMediaTypeToLastPlugin): (WebKit::WebPluginListBuilderImpl::addFileExtensionToLastMediaType):
src/WebPluginListBuilderImpl.h: (WebKit::WebPluginListBuilderImpl::WebPluginListBuilderImpl):

2010-05-25 Anders Carlsson <andersca@apple.com>

Reviewed by Darin Adler.

Clean up MimeClassInfo and PluginInfo
https://bugs.webkit.org/show_bug.cgi?id=39700

This gets rid of all the heap allocation from MimeClassInfo and PluginInfo.

It also changes the m_plugins and m_mimes vectors in PluginData to not hold heap allocated MimeClassInfo
and PluginClassInfo objects.

page/Page.cpp: (WebCore::Page::refreshPlugins):
plugins/MimeType.cpp: (WebCore::MimeType::type): (WebCore::MimeType::suffixes): (WebCore::MimeType::description): (WebCore::MimeType::enabledPlugin):
plugins/MimeType.h: (WebCore::MimeType::mimeClassInfo):
plugins/MimeTypeArray.cpp: (WebCore::MimeTypeArray::item): (WebCore::MimeTypeArray::canGetItemsForName): (WebCore::MimeTypeArray::namedItem):
plugins/Plugin.cpp: (WebCore::Plugin::name): (WebCore::Plugin::filename): (WebCore::Plugin::description): (WebCore::Plugin::length): (WebCore::Plugin::item): (WebCore::Plugin::canGetItemsForName): (WebCore::Plugin::namedItem):
plugins/Plugin.h: (WebCore::Plugin::pluginInfo):
plugins/PluginArray.cpp: (WebCore::PluginArray::length): (WebCore::PluginArray::item): (WebCore::PluginArray::canGetItemsForName): (WebCore::PluginArray::namedItem): (WebCore::PluginArray::pluginData):
plugins/PluginArray.h:
plugins/PluginData.cpp: (WebCore::PluginData::PluginData): (WebCore::PluginData::~PluginData): (WebCore::PluginData::supportsMimeType): (WebCore::PluginData::pluginNameForMimeType):
plugins/PluginData.h: (WebCore::operator==): (WebCore::PluginData::create): (WebCore::PluginData::disconnectPage): (WebCore::PluginData::page): (WebCore::PluginData::plugins): (WebCore::PluginData::mimes):
plugins/chromium/PluginDataChromium.cpp: (WebCore::PluginCache::reset): (WebCore::PluginCache::plugins): (WebCore::PluginData::initPlugins): (WebCore::getPluginMimeTypeFromExtension):
plugins/gtk/PluginDataGtk.cpp: (WebCore::PluginData::initPlugins):
plugins/mac/PluginDataMac.mm: (WebCore::PluginData::initPlugins):
plugins/qt/PluginDataQt.cpp: (WebCore::PluginData::initPlugins):
plugins/win/PluginDataWin.cpp: (WebCore::PluginData::initPlugins):
plugins/wx/PluginDataWx.cpp: (WebCore::PluginData::initPlugins):

4:06 PM Changeset in webkit [60257] by abarth@webkit.org

9 edits in trunk

2010-05-26 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Fix webkit01.dat resumer tests in HTML5 parser
https://bugs.webkit.org/show_bug.cgi?id=39796

Update expectations to show massive passage.

html5lib/webkit-resumer-expected-html5.txt:

2010-05-26 Nate Chapin <Nate Chapin>

Reviewed by Adam Barth.

Factor PageCache functionality out of FrameLoader and into
PageCache.

https://bugs.webkit.org/show_bug.cgi?id=39382

Refactor only, so no new tests.

history/PageCache.cpp: (WebCore::pageCacheLogPrefix): (WebCore::pageCacheLog): (WebCore::logCanCacheFrameDecision): (WebCore::logCanCachePageDecision): (WebCore::PageCache::canCachePageContainingThisFrame): (WebCore::PageCache::canCache): (WebCore::PageCache::add): (WebCore::PageCache::get):
history/PageCache.h:
loader/DocumentLoader.cpp:
loader/FrameLoader.cpp: (WebCore::FrameLoader::commitProvisionalLoad): (WebCore::FrameLoader::prepareForCachedPageRestore): (WebCore::FrameLoader::continueLoadAfterNavigationPolicy): (WebCore::FrameLoader::loadProvisionalItemFromCachedPage): (WebCore::FrameLoader::navigateToDifferentDocument):
loader/FrameLoader.h: (WebCore::FrameLoader::quickRedirectComing):
svg/graphics/SVGImage.cpp:

4:00 PM Changeset in webkit [60256] by Nate Chapin

7 edits in trunk/WebCore

2010-05-26 Nate Chapin <Nate Chapin>

Reviewed by Adam Barth.

Factor PageCache functionality out of FrameLoader and into
PageCache.

https://bugs.webkit.org/show_bug.cgi?id=39382

Refactor only, so no new tests.

history/PageCache.cpp: (WebCore::pageCacheLogPrefix): (WebCore::pageCacheLog): (WebCore::logCanCacheFrameDecision): (WebCore::logCanCachePageDecision): (WebCore::PageCache::canCachePageContainingThisFrame): (WebCore::PageCache::canCache): (WebCore::PageCache::add): (WebCore::PageCache::get):
history/PageCache.h:
loader/DocumentLoader.cpp:
loader/FrameLoader.cpp: (WebCore::FrameLoader::commitProvisionalLoad): (WebCore::FrameLoader::prepareForCachedPageRestore): (WebCore::FrameLoader::continueLoadAfterNavigationPolicy): (WebCore::FrameLoader::loadProvisionalItemFromCachedPage): (WebCore::FrameLoader::navigateToDifferentDocument):
loader/FrameLoader.h: (WebCore::FrameLoader::quickRedirectComing):
svg/graphics/SVGImage.cpp:

3:26 PM Changeset in webkit [60255] by pkasting@chromium.org

2 edits in trunk/WebCore

https://bugs.webkit.org/show_bug.cgi?id=39786
Properly reset |bytes_to_consume| when reaching the "gif_done" state in
the open-source GIF decoder.

Reviewed by Adam Barth.

No tests, since there's no test harness support for checking the
internal ImageDecoder state values.

platform/image-decoders/gif/GIFImageReader.cpp:

(GIFImageReader::read): Use a macro to perform the state change, like we do everywhere else in the file. Also correctly return "failure" for certain corrupt GIFs, since that doesn't prevent their display (due to WebKit's different use of this code compared to Mozilla).

3:14 PM Changeset in webkit [60254] by eric@webkit.org

5 edits in trunk/WebCore

2010-05-26 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r60251.
http://trac.webkit.org/changeset/60251
https://bugs.webkit.org/show_bug.cgi?id=39788

broke tests (Requested by dhyatt on #webkit).

rendering/RenderBlock.cpp: (WebCore::RenderBlock::moveChildTo): (WebCore::RenderBlock::moveAllChildrenTo): (WebCore::RenderBlock::makeChildrenNonInline): (WebCore::RenderBlock::removeChild):
rendering/RenderBlock.h:
rendering/RenderRubyBase.cpp: (WebCore::RenderRubyBase::moveInlineChildren): (WebCore::RenderRubyBase::moveBlockChildren): (WebCore::RenderRubyBase::mergeBlockChildren):
rendering/RenderRubyRun.cpp: (WebCore::RenderRubyRun::removeChild):

2:51 PM Changeset in webkit [60253] by abarth@webkit.org

8 edits
3 adds in trunk

2010-05-26 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Make HTML5 lexer not ASSERT when resuming partial parses
https://bugs.webkit.org/show_bug.cgi?id=39755

Add a test suite for partial parsing. This test runs all our parsing
test cases, but stops and starts the parser at every character in the
parse stream to make sure we resume parsing properly. Currently, a
bunch of the test cases are commented out, but I'll comment them back
in as I get them running.

html5lib/webkit-resumer-expected-html5.txt: Added.
html5lib/webkit-resumer-expected.txt: Added.
html5lib/webkit-resumer.html: Added.

2010-05-26 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Make HTML5 lexer not ASSERT when resuming partial parses
https://bugs.webkit.org/show_bug.cgi?id=39755

I'm working through a variation of the webkit-runner.html test suite
that stops the parser at every character to make sure we can resume
parsing correctly. This patch fixes some errors caught by ASSERTs,
which prevent the basic tests from running to completion. There's a
bunch more work to do, however.

Test: html5lib/webkit-resumer.html

html/HTML5Lexer.cpp: (WebCore::HTMLNames::isEndTagBufferingState): (WebCore::HTML5Lexer::nextToken): (WebCore::HTML5Lexer::addToPossibleEndTag):
html/HTML5Lexer.h:
html/HTML5Tokenizer.cpp: (WebCore::HTML5Tokenizer::write):
html/HTML5Tokenizer.h:

2010-05-26 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Make HTML5 lexer not ASSERT when resuming partial parses
https://bugs.webkit.org/show_bug.cgi?id=39755

Add webkit-resumer.html to the HTML5 parser test suite.

Scripts/test-html5-parser:

2:38 PM Changeset in webkit [60252] by ap@apple.com

2 edits in trunk/WebCore

Mac 32 bit build fix.

platform/graphics/mac/SimpleFontDataMac.mm: (WebCore::SimpleFontData::platformInit): Use static_cast instead of narrowPrecisionToFloat - the latter can't convert from float to float.

2:25 PM Changeset in webkit [60251] by hyatt@apple.com

5 edits in trunk/WebCore

https://bugs.webkit.org/show_bug.cgi?id=39783, clean up moveChild functions in RenderBlock.

Reviewed by Ojan.

Cut out the need to pass the to block's child list by tightening up the type of the to object
from RenderObject to RenderBlock.

Implement the "append" versions of the move functions using their "insert" counterparts, since
insertChildNode just calls appendChildNode when beforeChild is 0 anyway.

Add comments explaining why the default for fullRemoveInsert is false, and make sure all forms
of the move functions have the optional parameter for consistency.

rendering/RenderBlock.cpp:

(WebCore::RenderBlock::createAndAppendRootInlineBox):
(WebCore::RenderBlock::moveChildTo):
(WebCore::RenderBlock::moveAllChildrenTo):
(WebCore::RenderBlock::makeChildrenNonInline):
(WebCore::RenderBlock::removeChild):

rendering/RenderBlock.h:

(WebCore::RenderBlock::moveChildTo):
(WebCore::RenderBlock::moveAllChildrenTo):

rendering/RenderRubyBase.cpp:

(WebCore::RenderRubyBase::moveInlineChildren):
(WebCore::RenderRubyBase::moveBlockChildren):
(WebCore::RenderRubyBase::mergeBlockChildren):

rendering/RenderRubyRun.cpp:

(WebCore::RenderRubyRun::removeChild):

2:17 PM Changeset in webkit [60250] by ap@apple.com

2 edits in trunk/LayoutTests

Make the test pass on chromium by weakening expectations. It's probably a chromium bug, but
the test only practically checks that the height is non-zero, so chromium's 198 is fine
for now.

fast/css/custom-font-xheight.html:

2:13 PM QtWebKitTriageRoster edited by Simon Hausmann

(diff)

2:04 PM Changeset in webkit [60249] by ap@apple.com

1 edit in trunk/LayoutTests/platform/mac-tiger/Skipped

Added a newline at the end of file.

2:03 PM Changeset in webkit [60248] by ap@apple.com

1 edit in trunk/WebCore/ChangeLog

Removing a duplicate/obsolete ChangeLog entry.

1:53 PM Changeset in webkit [60247] by ap@apple.com

4 edits
2 adds in trunk

2010-05-26 Dan Bernstein <mitz@apple.com>

Typed and reviewed by Alexey Proskuryakov.

https://bugs.webkit.org/show_bug.cgi?id=39682
<rdar://problem/8026774> REGRESSION: WebKit nightly adding insane height to div at random

Test: fast/css/custom-font-xheight.html

platform/graphics/mac/SimpleFontDataMac.mm: (WebCore::SimpleFontData::platformInit): Calling an Objective C method that returns a structure with a null object can leave garbage in returned value. Custom fonts don't have an NSFont, they only have a CGFont. Call platformBoundsForGlyph() function instead, which works with CGFont. (WebCore::SimpleFontData::platformBoundsForGlyph): Fixed to work on Tiger (for fonts that have an NSFont), since this is now used in more cases.

1:43 PM Changeset in webkit [60246] by Beth Dakin

2 edits in trunk/WebCore

Build fix for Mac clean builds.

storage/IDBDatabaseRequest.idl:

12:07 PM Changeset in webkit [60245] by eric.carlson@apple.com

2 edits in trunk/WebCore

2010-05-26 Eric Carlson <eric.carlson@apple.com>

Reviewed by Dan Bernstein.

Must not cast between CFNumberRef and CFBooleanRef.
<rdar://problem/8030739>
https://bugs.webkit.org/show_bug.cgi?id=39756

platform/graphics/win/QTMovieVisualContext.cpp: (QTMovieVisualContext::getCGImageOptions): QuickTime assumes the value associated with kCVPixelBufferCGImageCompatibilityKey is a CFBoolean, so add one.

11:09 AM Changeset in webkit [60244] by kevino@webkit.org

2 edits in trunk/WebKit/wx

Build fix after new client added to Page constructor.

10:51 AM Changeset in webkit [60243] by xan@webkit.org

2 edits in trunk/WebCore

2010-05-26 Xan Lopez <xlopez@igalia.com>

GTK+ build fix, strike two.

bindings/gobject/WebKitDOMEventTarget.cpp: (webkit_dom_event_target_get_type): (webkit_dom_event_target_default_init):

10:05 AM Changeset in webkit [60242] by mitz@apple.com

1 edit in trunk/WebCore/ChangeLog

Fixed typos in the change log

9:01 AM Changeset in webkit [60241] by jorlow@chromium.org

3 edits in trunk/WebCore

2010-05-26 Jeremy Orlow <jorlow@chromium.org>

Unreviewed build fix for Windows + clean up the xcode project.

WebCore.gypi:
WebCore.vcproj/WebCore.vcproj:

8:39 AM Changeset in webkit [60240] by jorlow@chromium.org

14 edits
2 copies
3 adds in trunk/WebCore

2010-05-26 Andrei Popescu <andreip@google.com>

Reviewed by Jeremy Orlow.

Indexed Database component is missing IDBObjectStoreRequest interface
https://bugs.webkit.org/show_bug.cgi?id=39490

Adding IDL and stub implementation for IDBObjectStoreRequest.

No new tests, indexed database isn't yet testable.

DerivedSources.cpp:
DerivedSources.make:
GNUmakefile.am:
WebCore.gypi:
WebCore.pri:
WebCore.pro:
WebCore.xcodeproj/project.pbxproj:
bindings/js/JSIDBObjectStoreRequestCustom.cpp: Added. (WebCore::JSIDBObjectStoreRequest::remove): (WebCore::JSIDBObjectStoreRequest::addOrModify): (WebCore::JSIDBObjectStoreRequest::modify): (WebCore::JSIDBObjectStoreRequest::add): (WebCore::JSIDBObjectStoreRequest::get):
bindings/v8/custom/V8IDBObjectStoreRequestCustom.cpp: Added. (WebCore::V8IDBObjectStoreRequest::removeCallback): (WebCore::V8IDBObjectStoreRequest::addOrModifyCallback): (WebCore::V8IDBObjectStoreRequest::modifyCallback): (WebCore::V8IDBObjectStoreRequest::addCallback): (WebCore::V8IDBObjectStoreRequest::getCallback):
storage/IDBObjectStore.cpp: Added.
storage/IDBObjectStore.h: Added. (WebCore::IDBObjectStore::~IDBObjectStore):
storage/IDBObjectStoreRequest.cpp: Added. (WebCore::IDBObjectStoreRequest::name): (WebCore::IDBObjectStoreRequest::keyPath): (WebCore::IDBObjectStoreRequest::IDBObjectStoreRequest):
storage/IDBObjectStoreRequest.h: Added. (WebCore::IDBObjectStoreRequest::create): (WebCore::IDBObjectStoreRequest::~IDBObjectStoreRequest):
storage/IDBObjectStoreRequest.idl: Added.

8:26 AM Changeset in webkit [60239] by jorlow@chromium.org

2 edits in trunk/WebKit/chromium

2010-05-26 Jeremy Orlow <jorlow@chromium.org>

Unreviewed chromium build fix
https://bugs.webkit.org/show_bug.cgi?id=39739

The backwards compat function needs to take in a WebSecurityOrigin
instead of a WebString.

public/WebIndexedDatabase.h: (WebKit::WebIndexedDatabase::open):

7:34 AM Changeset in webkit [60238] by xan@webkit.org

2 edits in trunk/WebCore

2010-05-26 Xan Lopez <xlopez@igalia.com>

Unreviewed GTK+ build fix.

Use G_DEFINE_INTERFACE only if it's available.

bindings/gobject/WebKitDOMEventTarget.cpp: (webkit_dom_event_target_get_type): (webkit_dom_event_target_default_init):

7:30 AM Changeset in webkit [60237] by Csaba Osztrogonác

2 edits in trunk/LayoutTests

Unreviewed fix, Qt specific expected file updated after r60235.

platform/qt/fast/dom/Window/window-properties-expected.txt: updated.

7:18 AM Changeset in webkit [60236] by Csaba Osztrogonác

2 edits in trunk/LayoutTests

Unreviewed.

[Qt] media/media-can-play-ogg.html crashes intermittently on the bot
https://bugs.webkit.org/show_bug.cgi?id=39481

platform/qt/Skipped: the culprit media/audio-only-video-intrinsic-size.html skipped until fix.

7:14 AM Changeset in webkit [60235] by jorlow@chromium.org

8 edits
2 adds in trunk

2010-05-26 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Darin Fisher.

Implement WebDOMStorageList and make WebIDBDatabase use it
https://bugs.webkit.org/show_bug.cgi?id=39731

Remove unused function.

dom/DOMStringList.h:

2010-05-26 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Darin Fisher.

Implement WebDOMStorageList and make WebIDBDatabase use it
https://bugs.webkit.org/show_bug.cgi?id=39731

WebKit.gyp:
public/WebDOMStringList.h: Added. (WebKit::WebDOMStringList::~WebDOMStringList): (WebKit::WebDOMStringList::WebDOMStringList): (WebKit::WebDOMStringList::operator=):
public/WebIDBDatabase.h: (WebKit::WebIDBDatabase::objectStores):
src/IDBDatabaseProxy.cpp: (WebCore::IDBDatabaseProxy::objectStores):
src/WebDOMStringList.cpp: Added. (WebKit::WebDOMStringList::reset): (WebKit::WebDOMStringList::assign): (WebKit::WebDOMStringList::append): (WebKit::WebDOMStringList::length): (WebKit::WebDOMStringList::item): (WebKit::WebDOMStringList::WebDOMStringList): (WebKit::WebDOMStringList::operator=): (WebKit::WebDOMStringList::operator WTF::PassRefPtr<WebCore::DOMStringList>):
src/WebIDBDatabaseImpl.cpp: (WebKit::WebIDBDatabaseImpl::objectStores):
src/WebIDBDatabaseImpl.h:

6:44 AM Changeset in webkit [60234] by jberlin@webkit.org

11 edits in trunk

Bug 31296 - Web Inspector: Should support console.groupCollapsed
https://bugs.webkit.org/show_bug.cgi?id=31296

Reviewed by Pavel Feldman

WebCore:

inspector/InspectorController.cpp:

(WebCore::InspectorController::startGroup):
Set the message type based on whether or not it should be initially collapsed.

inspector/InspectorController.h:

inspector/front-end/ConsoleView.js:

Treat a StartGroupCollapsed message the same way as a StartGroup message, but display the tree for the group as collapsed.
(WebInspector.ConsoleView.prototype.addMessage):
(WebInspector.ConsoleMessage.prototype.toMessageElement):
(WebInspector.ConsoleMessage.prototype.toString):
(WebInspector.ConsoleGroup.prototype.addMessage):

page/Console.cpp:

(WebCore::Console::groupCollapsed):
Create a group and indicate that it should be collapsed.

page/Console.h:

Add the StartGroupCollapsed message type.

(WebCore::):

page/Console.idl:

Create the JS bindings for groupCollapsed.

LayoutTests:

fast/dom/Window/window-properties-expected.txt:

Update results to take into account added groupCollapsed function.

inspector/console-tests-expected.txt:
inspector/console-tests.html:

Add test for groupCollapsed and its results.

6:34 AM Changeset in webkit [60233] by Nikolas Zimmermann

1 edit
2 adds in trunk/LayoutTests

2010-05-26 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed. Add results for svg/hixie/links/003-broken.xml for mac-leopard. All SVG tests pass with --tolerance 0 again for me on Leopard.

platform/mac-leopard/svg/hixie/links/003-broken-expected.checksum: Added.
platform/mac-leopard/svg/hixie/links/003-broken-expected.png: Added.

6:12 AM Changeset in webkit [60232] by yael.aharon@nokia.com

23 edits
26 adds in trunk

Support the labels attribute in labelable form controls
https://bugs.webkit.org/show_bug.cgi?id=38713

Reviewed by Kent Tamura.

WebCore:

Added a new cache type in NodeRareData to store the new cache type.
This cache is created on demand.

Added the "labels" attribute to all form controls that support this attribute.

Tests: fast/forms/labels-add-htmlFor-label.html

fast/forms/labels-add-parent-label.html
fast/forms/labels-change-htmlFor-attribute.html
fast/forms/labels-item-index.html
fast/forms/labels-remove-htmlFor-attribute.html
fast/forms/labels-remove-htmlFor-label.html
fast/forms/labels-remove-parent-label.html
fast/forms/labels-set-htmlFor-attribute.html

CMakeLists.txt:
GNUmakefile.am:
WebCore.gypi:
WebCore.pro:
WebCore.vcproj/WebCore.vcproj:
WebCore.xcodeproj/project.pbxproj:
dom/Node.cpp:

(WebCore::Node::notifyLocalNodeListsLabelChanged):
(WebCore::Node::removeCachedLabelsNodeList):
(WebCore::NodeListsNodeData::invalidateCaches):
(WebCore::NodeListsNodeData::invalidateCachesThatDependOnAttributes):
(WebCore::NodeListsNodeData::isEmpty):

dom/Node.h:
dom/NodeRareData.h:

(WebCore::NodeListsNodeData::NodeListsNodeData):

html/HTMLButtonElement.idl:
html/HTMLFormControlElement.cpp:

(WebCore::HTMLFormControlElement::isLabelable):
(WebCore::HTMLFormControlElement::labels):

html/HTMLFormControlElement.h:
html/HTMLInputElement.idl:
html/HTMLLabelElement.cpp:

(WebCore::HTMLLabelElement::parseMappedAttribute):

html/HTMLLabelElement.h:
html/HTMLMeterElement.idl:
html/HTMLProgressElement.idl:
html/HTMLSelectElement.idl:
html/HTMLTextAreaElement.idl:
html/LabelsNodeList.cpp: Added.

(WebCore::LabelsNodeList::LabelsNodeList):
(WebCore::LabelsNodeList::~LabelsNodeList):
(WebCore::LabelsNodeList::nodeMatches):

html/LabelsNodeList.h: Added.

(WebCore::LabelsNodeList::create):

LayoutTests:

Update result for HTMLSelectElement, since it now includes the new attribute "labels"

fast/dom/domListEnumeration-expected.txt:
fast/dom/script-tests/domListEnumeration.js:

fast/forms/labels-add-htmlFor-label-expected.txt: Added.
fast/forms/labels-add-htmlFor-label.html: Added.
fast/forms/labels-add-parent-label-expected.txt: Added.
fast/forms/labels-add-parent-label.html: Added.
fast/forms/labels-change-htmlFor-attribute-expected.txt: Added.
fast/forms/labels-change-htmlFor-attribute.html: Added.
fast/forms/labels-item-index-expected.txt: Added.
fast/forms/labels-item-index.html: Added.
fast/forms/labels-remove-htmlFor-attribute-expected.txt: Added.
fast/forms/labels-remove-htmlFor-attribute.html: Added.
fast/forms/labels-remove-htmlFor-label-expected.txt: Added.
fast/forms/labels-remove-htmlFor-label.html: Added.
fast/forms/labels-remove-parent-label-expected.txt: Added.
fast/forms/labels-remove-parent-label.html: Added.
fast/forms/labels-set-htmlFor-attribute-expected.txt: Added.
fast/forms/labels-set-htmlFor-attribute.html: Added.
fast/forms/script-tests/labels-add-htmlFor-label.js: Added.
fast/forms/script-tests/labels-add-parent-label.js: Added.
fast/forms/script-tests/labels-change-htmlFor-attribute.js: Added.
fast/forms/script-tests/labels-item-index.js: Added.
fast/forms/script-tests/labels-remove-htmlFor-attribute.js: Added.
fast/forms/script-tests/labels-remove-htmlFor-label.js: Added.
fast/forms/script-tests/labels-remove-parent-label.js: Added.
fast/forms/script-tests/labels-set-htmlFor-attribute.js: Added.

5:18 AM QtWebKitBackportingFixes edited by Laszlo Gombos

(diff)

4:54 AM Changeset in webkit [60231] by xan@webkit.org

2 edits in trunk/WebCore

2010-05-26 Xan Lopez <xlopez@igalia.com>

Reviewed by Jeremy Orlow.

Style fix in JSEventCustom.cpp
https://bugs.webkit.org/show_bug.cgi?id=39727

Conditional includes should be all together after the
unconditional includes.

bindings/js/JSEventCustom.cpp:

4:43 AM Changeset in webkit [60230] by jorlow@chromium.org

30 edits
1 copy
1 move in trunk

2010-05-24 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Steve Block.

Flesh out IDBDatabase
https://bugs.webkit.org/show_bug.cgi?id=39602

Update the test expectations now that this succeeds.

storage/indexeddb/basics-expected.txt:

2010-05-24 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Steve Block.

Add IDBDatabase's attributes
https://bugs.webkit.org/show_bug.cgi?id=39602

Add the attributes (like name, description, etc) for
IDBDatabaseRequest. Plumb that back to the IDBDatabase
object which stores the data.

CMake and Android build changes in another CL (that
fixes other stuff too).

Updated the layout test, but there's some further testing
that needs to be added once the Chromium side of this lands.

GNUmakefile.am
WebCore.gypi:
WebCore.pro
WebCore.vcproj/WebCore.vcproj
WebCore.xcodeproj/project.pbxproj
dom/DOMStringList.h: (WebCore::DOMStringList::strings):
storage/IDBDatabase.cpp: Removed.
storage/IDBDatabase.h:
storage/IDBDatabaseImpl.cpp: Added. (WebCore::IDBDatabaseImpl::IDBDatabaseImpl): (WebCore::IDBDatabaseImpl::~IDBDatabaseImpl): (WebCore::IDBDatabaseImpl::objectStores):
storage/IDBDatabaseImpl.h: Added. (WebCore::IDBDatabaseImpl::create): (WebCore::IDBDatabaseImpl::name): (WebCore::IDBDatabaseImpl::description): (WebCore::IDBDatabaseImpl::version):
storage/IDBDatabaseRequest.h: (WebCore::IDBDatabaseRequest::name): (WebCore::IDBDatabaseRequest::description): (WebCore::IDBDatabaseRequest::version): (WebCore::IDBDatabaseRequest::objectStores):
storage/IDBDatabaseRequest.idl:
storage/IDBSuccessEvent.cpp: (WebCore::IDBSuccessEvent::IDBSuccessEvent):
storage/IndexedDatabaseImpl.cpp: (WebCore::IndexedDatabaseImpl::open):
storage/IndexedDatabaseImpl.h:

2010-05-24 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Steve Block.

Add IDBDatabase's attributes
https://bugs.webkit.org/show_bug.cgi?id=39602

Plumbing to hook up the synchronous attribute requests
on IDBDatabase.

public/WebIDBDatabase.h: (WebKit::WebIDBDatabase::name): (WebKit::WebIDBDatabase::description): (WebKit::WebIDBDatabase::version): (WebKit::WebIDBDatabase::objectStores):
src/IDBDatabaseProxy.cpp: (WebCore::IDBDatabaseProxy::name): (WebCore::IDBDatabaseProxy::description): (WebCore::IDBDatabaseProxy::version): (WebCore::IDBDatabaseProxy::objectStores):
src/IDBDatabaseProxy.h:
src/WebIDBDatabaseImpl.cpp: (WebKit::WebIDBDatabaseImpl::WebIDBDatabaseImpl): (WebKit::WebIDBDatabaseImpl::name): (WebKit::WebIDBDatabaseImpl::description): (WebKit::WebIDBDatabaseImpl::version): (WebKit::WebIDBDatabaseImpl::objectStores):
src/WebIDBDatabaseImpl.h:

4:11 AM QtWebKit edited by jocelyn.turcotte@nokia.com

typo (diff)

3:51 AM Changeset in webkit [60229] by xan@webkit.org

9 edits
3 adds in trunk

2010-05-26 Xan Lopez <xlopez@igalia.com>

Reviewed by Gustavo Noronha.

[GTK] Add support for DOM events in the GObject DOM bindings
https://bugs.webkit.org/show_bug.cgi?id=38844

Add new test to the build.

GNUmakefile.am:

WebCore:

2010-05-26 Xan Lopez <xlopez@igalia.com>

Reviewed by NOBODY Gustavo Noronha.

[GTK] Add support for DOM events in the GObject DOM bindings
https://bugs.webkit.org/show_bug.cgi?id=38844

Add actual GObject event objects to the DOM event signals.

GNUmakefile.am:
bindings/gobject/GObjectEventListener.cpp: (WebCore::GObjectEventListener::handleEvent):
bindings/gobject/WebKitDOMBinding.cpp: (WebKit::wrapEventTarget): (WebKit::kit):
bindings/gobject/WebKitDOMBinding.h:
bindings/gobject/WebKitDOMEventTarget.cpp: Added. (webkit_dom_event_target_default_init): (webkit_dom_event_target_dispatch_event):
bindings/gobject/WebKitDOMEventTarget.h: Added.
bindings/scripts/CodeGeneratorGObject.pm:

WebKit/gtk:

2010-05-26 Xan Lopez <xlopez@igalia.com>

Reviewed by Gustavo Noronha.

[GTK] Add support for DOM events in the GObject DOM bindings
https://bugs.webkit.org/show_bug.cgi?id=38844

Test DOMWindow signals.

tests/testdomdomwindow.c: Added. (finish_loading): (dom_domview_fixture_setup): (dom_domview_fixture_teardown): (loadedCallback): (clickedCallback): (map_event_cb): (load_event_callback): (test_dom_domview_signals): (main):

3:35 AM Changeset in webkit [60228] by jorlow@chromium.org

5 edits in trunk/WebCore

2010-05-24 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Steve Block.

[Android] Add IndexedDB to the build
https://bugs.webkit.org/show_bug.cgi?id=39593

Add the current list of build files to Android's make files. From now on,
I'll try to be sure to update these along with the rest.
Also, fix a nit in the gypi file.

No tests..just changing build files.

Android.derived.jscbindings.mk:
Android.derived.v8bindings.mk:
Android.mk:
WebCore.gypi:

3:33 AM Changeset in webkit [60227] by apavlov@chromium.org

12 edits
3 adds in trunk

2010-05-26 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Pavel Feldman.

Expose CSS rule body start/end offsets in the parent stylesheet
https://bugs.webkit.org/show_bug.cgi?id=38906

CSSParser::parseSheet() accepts an optional external Vector where the start/end offsets
of the CSSStyleRule bodies, relative to the beginning of the stylesheet, will be stored.
This Vector is only used when the Web Inspector needs the body ranges, thus there is no
memory overhead until the user starts editing styles via the Web Inspector.
Additionally, fixed an issue with a single inspectorStyleSheet for all frames in the page.

Test: inspector/styles-source-offsets.html

WebCore:

css/CSSGrammar.y:
css/CSSParser.cpp: (WebCore::CSSParser::CSSParser): (WebCore::CSSParser::setupParser): (WebCore::CSSParser::parseSheet): (WebCore::CSSParser::createStyleRule): (WebCore::CSSParser::updateLastSelectorLineAndPosition): (WebCore::CSSParser::markRuleBodyStart): (WebCore::CSSParser::markRuleBodyEnd):
css/CSSParser.h: (WebCore::CSSParser::resetRuleBodyMarks):
inspector/InspectorCSSStore.cpp: (WebCore::InspectorCSSStore::InspectorCSSStore): (WebCore::InspectorCSSStore::reset): (WebCore::InspectorCSSStore::removeDocument): (WebCore::InspectorCSSStore::inspectorStyleSheet): (WebCore::InspectorCSSStore::getStartEndOffsets): (WebCore::InspectorCSSStore::getIndexInStyleRules): (WebCore::InspectorCSSStore::disabledStyleForId): (WebCore::InspectorCSSStore::styleForId): (WebCore::InspectorCSSStore::ruleForId): (WebCore::InspectorCSSStore::bindStyle): (WebCore::InspectorCSSStore::bindStyleSheet): (WebCore::InspectorCSSStore::bindRule):
inspector/InspectorCSSStore.h:
inspector/InspectorController.cpp: (WebCore::InspectorController::InspectorController): (WebCore::InspectorController::resourceForURL):
inspector/InspectorController.h: (WebCore::InspectorController::inspectorFrontend):
inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::InspectorDOMAgent): (WebCore::InspectorDOMAgent::unbind): (WebCore::InspectorDOMAgent::getStyles): (WebCore::InspectorDOMAgent::getAllStyles): (WebCore::InspectorDOMAgent::buildArrayForCSSRules): (WebCore::InspectorDOMAgent::buildArrayForPseudoElements): (WebCore::InspectorDOMAgent::applyStyleText): (WebCore::InspectorDOMAgent::setStyleText): (WebCore::InspectorDOMAgent::setStyleProperty): (WebCore::InspectorDOMAgent::toggleStyleEnabled): (WebCore::InspectorDOMAgent::setRuleSelector): (WebCore::InspectorDOMAgent::addRule): (WebCore::InspectorDOMAgent::buildObjectForStyle): (WebCore::InspectorDOMAgent::buildArrayForDisabledStyleProperties): (WebCore::InspectorDOMAgent::buildObjectForStyleSheet): (WebCore::InspectorDOMAgent::buildObjectForRule):
inspector/InspectorDOMAgent.h:
inspector/front-end/DOMAgent.js: (WebInspector.CSSStyleDeclaration):

LayoutTests:

inspector/resources/styles-source-offsets.css: Added. (body): (/* comment before selector */body.main1/* comment after selector */): (body.main2):
inspector/styles-source-offsets-expected.txt: Added.
inspector/styles-source-offsets.html: Added.

3:23 AM Changeset in webkit [60226] by xan@webkit.org

2 edits in trunk/WebCore

2010-05-26 Xan Lopez <xlopez@igalia.com>

Reviewed by Gustavo Noronha.

[GTK] Add support for DOM events in the GObject DOM bindings
https://bugs.webkit.org/show_bug.cgi?id=38844

Use GObject-like names for the DOM event signals. Basically go
from 'mousewheel' to 'mouse-wheel-event'.

bindings/scripts/CodeGeneratorGObject.pm:

3:16 AM Changeset in webkit [60225] by xan@webkit.org

7 edits
2 adds in trunk/WebCore

2010-05-26 Xan Lopez <xlopez@igalia.com>

Reviewed by Gustavo Noronha.

[GTK] Add support for DOM events in the GObject DOM bindings
https://bugs.webkit.org/show_bug.cgi?id=38844

First step towards DOM events support. We create one signal per
event supported in the DOM classes, and create a custom
GObjectEventListener that will emit a GObject signal when an event
is dispatched to the object. There is no event object at the
moment (we just pass NULL), and no support for hooking into the
capture phase.

GNUmakefile.am:
bindings/gobject/GObjectEventListener.cpp: Added. (WebCore::GObjectEventListener::handleEvent): (WebCore::GObjectEventListener::operator==):
bindings/gobject/GObjectEventListener.h: Added. (WebCore::GObjectEventListener::create): (WebCore::GObjectEventListener::cast): (WebCore::GObjectEventListener::GObjectEventListener):
bindings/scripts/CodeGeneratorGObject.pm:
bindings/scripts/test/GObject/WebKitDOMTestCallback.cpp: (WebKit::core): (webkit_dom_test_callback_finalize): (webkit_dom_test_callback_class_init): (WebKit::wrapTestCallback):
bindings/scripts/test/GObject/WebKitDOMTestInterface.cpp: (WebKit::core): (webkit_dom_test_interface_finalize): (webkit_dom_test_interface_class_init): (WebKit::wrapTestInterface):
bindings/scripts/test/GObject/WebKitDOMTestObj.cpp: (WebKit::core): (webkit_dom_test_obj_finalize): (webkit_dom_test_obj_class_init): (WebKit::wrapTestObj):
dom/EventListener.h: (WebCore::EventListener::):

3:08 AM Changeset in webkit [60224] by Nikolas Zimmermann

2 edits in trunk/WebCore

2010-05-26 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed. Sort XCode project file.

WebCore.xcodeproj/project.pbxproj:

2:18 AM Changeset in webkit [60223] by xan@webkit.org

2 edits in trunk/WebCore

2010-05-26 Xan Lopez <xlopez@igalia.com>

Reviewed by Gustavo Noronha.

[GTK] GObject DOM bindings
https://bugs.webkit.org/show_bug.cgi?id=33590

We need to protect the body of some methods with #ifdefs, since
the availability of the code they call into is decided at compile
time.

bindings/scripts/CodeGeneratorGObject.pm:

1:41 AM Changeset in webkit [60222] by tkent@chromium.org

3 edits in trunk/WebCore

2010-05-26 Kent Tamura <tkent@chromium.org>

Reviewed by Shinichiro Hamaji.

Move date/time limit values to DateComponents.h from HTMLInputElement.cpp
https://bugs.webkit.org/show_bug.cgi?id=39423

The minimum and maximum values for date, datetime, datetime-local,
month, time, and week types depend on the implementation of
DateComponents. So move them to DateComponents.

html/DateComponents.h:
html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::minimum): (WebCore::HTMLInputElement::maximum):

12:58 AM Changeset in webkit [60221] by Csaba Osztrogonác

2 edits in trunk/WebCore

Buildfix for build without ENABLE(RUBY) after r60201.

Reviewed by Simon Hausmann.

rendering/RenderBlock.cpp:

(WebCore::canMergeContiguousAnonymousBlocks): Missing #if ENABLE(RUBY) guard added.

12:35 AM Changeset in webkit [60220] by Nikolas Zimmermann

5 edits in trunk/WebCore

2010-05-26 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed. Update test expectations for JS generator, when using run-webkit-tests. This has been forgotten.

bindings/scripts/test/JS/JSTestInterface.cpp: (WebCore::JSTestInterfaceConstructor::JSTestInterfaceConstructor): (WebCore::JSTestInterface::createPrototype):
bindings/scripts/test/JS/JSTestInterface.h: (WebCore::JSTestInterfacePrototype::JSTestInterfacePrototype):
bindings/scripts/test/JS/JSTestObj.cpp: (WebCore::JSTestObjConstructor::JSTestObjConstructor): (WebCore::JSTestObj::createPrototype):
bindings/scripts/test/JS/JSTestObj.h: (WebCore::JSTestObjPrototype::JSTestObjPrototype):

12:18 AM Changeset in webkit [60219] by Philippe Normand

2 edits in trunk/WebCore

2010-05-25 Philippe Normand <pnormand@igalia.com>

Reviewed by Gustavo Noronha Silva.

[GStreamer] Apple trailers not playing
https://bugs.webkit.org/show_bug.cgi?id=37390

Set the AppleTrailer User-Agent workaround after
FrameLoader::addExtraFieldsToSubresourceRequest has been called
because that method sets the global User-Agent.

platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp: (webKitWebSrcStart):

Note: See TracTimeline for information about the timeline view.

Download in other formats:

RSS Feed