Context Navigation

platform/chromium-linux/editing/selection/range-between-block-and-inline-expected.checksum: Added.
platform/chromium-linux/editing/selection/range-between-block-and-inline-expected.png: Added.
platform/chromium-linux/editing/selection/range-between-block-and-inline-expected.txt: Added.
platform/chromium-win/editing/selection/range-between-block-and-inline-expected.checksum: Added.
platform/chromium-win/editing/selection/range-between-block-and-inline-expected.png: Added.
platform/chromium-win/editing/selection/range-between-block-and-inline-expected.txt: Added.

10:11 PM Changeset in webkit [60428] by rolandsteiner@chromium.org

1 edit
1 move
2 deletes in trunk/LayoutTests

2010-05-30 Roland Steiner <rolandsteiner@chromium.org>

Unreviewed: fix Chromium test expectations.

Fix Chromium test expectations for html5lib/runner.html

platform/chromium-mac/html5lib/runner-expected.txt: Removed.
platform/chromium-win/html5lib/runner-expected.txt: Removed.
platform/chromium/html5lib/runner-expected.txt: Added.
platform/chromium/html5lib/webkit-runner-expected.txt: Removed.

9:07 PM Changeset in webkit [60427] by tkent@chromium.org

8 edits
2 adds in trunk/WebKitTools

2010-05-30 Kent Tamura <tkent@chromium.org>

Reviewed by Dimitri Glazkov.

new-run-webkit-tests: Support DRT on Chromium-win
https://bugs.webkit.org/show_bug.cgi?id=39810

Add --test-shell flag to DRT/Chromium, and it changes DRT so that
it behaves like test_shell about command analysis, printing
format, pixel dumping, and timeout handling.

chromium.py and chromium_win.py supports the --test-shell flag and
DRT/Chromium-win binary names.

DumpRenderTree/DumpRenderTree.gypi: Add new files.
DumpRenderTree/chromium/DumpRenderTree.cpp: (runTest): Support for test_shell-style command. (main): Introduce --test-shell.
DumpRenderTree/chromium/TestEventPrinter.cpp: Added.
DumpRenderTree/chromium/TestEventPrinter.h: Added. TestEventPrinter class manages stdio output and image output. TestEventPrinter.cpp has two implementations; DRTPrinter and TestShellPrinter.
DumpRenderTree/chromium/TestShell.cpp: Some changes for TestEventPrinter. (TestShell::TestShell): (TestShell::runFileTest): (TestShell::testTimedOut): (TestShell::dump): (TestShell::dumpImage):
DumpRenderTree/chromium/TestShell.h: (TestShell::printer): (TestShell::layoutTestTimeout): (TestShell::layoutTestTimeoutForWatchDog): (TestShell::setLayoutTestTimeout):
DumpRenderTree/chromium/TestShellWin.cpp: (watchDogThread): Use TestShell::layoutTestTimeoutForWatchDog().
Scripts/webkitpy/layout_tests/port/chromium.py:
Scripts/webkitpy/layout_tests/port/chromium_win.py:

6:25 PM Changeset in webkit [60426] by mrowe@apple.com

5 edits in branches/safari-533-branch

Versioning.

6:24 PM Changeset in webkit [60425] by mrowe@apple.com

1 copy in tags/Safari-533.14

New tag.

6:23 PM Changeset in webkit [60424] by mrowe@apple.com

3 edits in branches/safari-533-branch/WebKit/win

Merge r59912.

6:23 PM Changeset in webkit [60423] by mrowe@apple.com

7 edits in branches/safari-533-branch

Merge r59910.

6:04 PM Changeset in webkit [60422] by eric@webkit.org

2 edits in trunk/WebCore

2010-05-30 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

fast/tokenizer/write-partial-entity.html hits ASSERT SegmentedString in the HTML5 Parser
https://bugs.webkit.org/show_bug.cgi?id=39935

Test: fast/tokenizer/write-partial-entity.html

html/HTML5Tokenizer.cpp: (WebCore::HTML5Tokenizer::executeScript):
- Use m_source.append(oldInsertionPoint) instead of oldInsertionPoint.prepend(m_source) because m_source may have had characters pushed onto it and prepend() does not handle that case.

5:51 PM Changeset in webkit [60421] by eric@webkit.org

12 edits in trunk

2010-05-30 Lyon Chen <liachen@rim.com>

Reviewed by Kent Tamura.

This is a coding style cleanup before fixing to bug 35530.

Enum value FORWARD, BACKWARD, RIGHT, LEFT are causing macro conflicts.
https://bugs.webkit.org/show_bug.cgi?id=35530

editing/Editor.cpp: (WebCore::Editor::deleteWithDirection): (WebCore::Editor::fontForSelection): (WebCore::Editor::applyStyle): (WebCore::Editor::applyParagraphStyle): (WebCore::Editor::applyStyleToSelection): (WebCore::Editor::applyParagraphStyleToSelection): (WebCore::triStateOfStyleInComputedStyle): (WebCore::Editor::selectionStartHasStyle): (WebCore::Editor::selectionHasStyle): (WebCore::Editor::paste): (WebCore::Editor::ignoreSpelling): (WebCore::Editor::learnSpelling): (WebCore::findFirstMisspellingInRange): (WebCore::findFirstGrammarDetailInRange): (WebCore::findFirstBadGrammarInRange): (WebCore::findFirstMisspellingOrBadGrammarInRange): (WebCore::Editor::advanceToNextMisspelling): (WebCore::Editor::isSelectionMisspelled): (WebCore::isRangeUngrammatical): (WebCore::Editor::guessesForMisspelledSelection): (WebCore::guessesForMisspelledOrUngrammaticalRange): (WebCore::Editor::markMisspellingsAfterTypingToPosition): (WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges):
editing/EditorCommand.cpp: (WebCore::applyCommandToFrame): (WebCore::executeToggleStyleInList): (WebCore::executeApplyParagraphStyle): (WebCore::executeDelete): (WebCore::executeForwardDelete): (WebCore::executeInsertLineBreak): (WebCore::supportedCopyCut): (WebCore::supportedPaste): (WebCore::enabledDelete):
editing/SelectionController.cpp: (WebCore::SelectionController::modifyExtendingRight): (WebCore::SelectionController::modifyExtendingForward): (WebCore::SelectionController::modifyMovingRight): (WebCore::SelectionController::modifyMovingForward): (WebCore::SelectionController::modifyExtendingLeft): (WebCore::SelectionController::modifyExtendingBackward): (WebCore::SelectionController::modifyMovingLeft): (WebCore::SelectionController::modifyMovingBackward): (WebCore::SelectionController::modify): (WebCore::SelectionController::xPosForVerticalArrowNavigation): (WebCore::SelectionController::debugRenderer):
editing/TypingCommand.cpp: (WebCore::TypingCommand::deleteKeyPressed): (WebCore::TypingCommand::forwardDeleteKeyPressed): (WebCore::TypingCommand::insertLineBreak): (WebCore::TypingCommand::insertParagraphSeparatorInQuotedContent): (WebCore::TypingCommand::insertParagraphSeparator): (WebCore::TypingCommand::doApply): (WebCore::TypingCommand::insertText): (WebCore::TypingCommand::updatePreservesTypingStyle):
page/EventHandler.cpp: (WebCore::EventHandler::handleMousePressEvent): (WebCore::EventHandler::handleMouseReleaseEvent): (WebCore::EventHandler::selectCursor): (WebCore::EventHandler::canHandleDragAndDropForTarget): (WebCore::EventHandler::dispatchMouseEvent): (WebCore::EventHandler::sendContextMenuEvent): (WebCore::EventHandler::handleKeyboardSelectionMovement): (WebCore::EventHandler::handleDrag):

2010-05-30 Lyon Chen <liachen@rim.com>

Reviewed by Kent Tamura.

This is a coding style cleanup before fixing to bug 35530.

Enum value FORWARD, BACKWARD, RIGHT, LEFT are causing macro conflicts.
https://bugs.webkit.org/show_bug.cgi?id=35530

src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::find): (WebKit::WebFrameImpl::scopeStringMatches): (WebKit::WebFrameImpl::createChildFrame): (WebKit::WebFrameImpl::shouldScopeMatches):

2010-05-30 Lyon Chen <liachen@rim.com>

Reviewed by Kent Tamura.

This is a coding style cleanup before fixing to bug 35530.

Enum value FORWARD, BACKWARD, RIGHT, LEFT are causing macro conflicts.
https://bugs.webkit.org/show_bug.cgi?id=35530

WebCoreSupport/EditorClientHaiku.cpp: (WebCore::EditorClientHaiku::handleKeyboardEvent):

2010-05-30 Lyon Chen <liachen@rim.com>

Reviewed by Kent Tamura.

This is a coding style cleanup before fixing to bug 35530.

Enum value FORWARD, BACKWARD, RIGHT, LEFT are causing macro conflicts.
https://bugs.webkit.org/show_bug.cgi?id=35530

WebCoreSupport/EditorClientQt.cpp: (WebCore::EditorClientQt::registerCommandForUndo): (WebCore::EditorClientQt::handleKeyboardEvent):

5:16 PM Changeset in webkit [60420] by dbates@webkit.org

1 edit in trunk/WebKit/chromium/src/WebSearchableFormData.cpp

2010-05-30 Daniel Bates <dbates@rim.com>

Unreviewed, attempt to fix the build after http://trac.webkit.org/changeset/60418.

I missed a few call sites in the Chromium source when I
landed http://trac.webkit.org/changeset/60419.

Credit to Chris Jerdonek for looking over both this patch and the patch
committed in r60419.

src/WebSearchableFormData.cpp: (WebCore::GetButtonToActivate): (WebCore::HasSuitableTextElement):

4:55 PM Changeset in webkit [60419] by dbates@webkit.org

7 edits in trunk

2010-05-30 Daniel Bates <dbates@rim.com>

Unreviewed, attempt to fix the build after http://trac.webkit.org/changeset/60418.

html/HTMLFormControlElement.h: (WebCore::HTMLFormControlElement::isEnabledFormControl): (WebCore::HTMLFormControlElement::isReadOnlyFormControl): (WebCore::HTMLFormControlElement::isFormControlElement):
html/HTMLInputElement.h: (WebCore::HTMLInputElement::isPasswordField):

2010-05-30 Daniel Bates <dbates@rim.com>

Unreviewed, attempt to fix the build after http://trac.webkit.org/changeset/60418.

src/EditorClientImpl.cpp: (WebKit::EditorClientImpl::autofill):
src/WebFormControlElement.cpp: (WebKit::WebFormControlElement::formControlName): (WebKit::WebFormControlElement::formControlType):
src/WebFormElement.cpp: (WebKit::WebFormElement::getFormControlElements):
src/WebPasswordFormUtils.cpp: (WebKit::findPasswordFormFields):

2010-05-30 Daniel Bates <dbates@rim.com>

Unreviewed, attempt to fix the build after http://trac.webkit.org/changeset/60418.

WebFrame.cpp: (WebFrame::elementWithName): (WebFrame::controlsInForm):

2:49 PM QtWebKitBackportingFixes edited by Simon Hausmann

(diff)

2:22 PM Changeset in webkit [60418] by Darin Adler

57 edits in trunk

2010-05-30 Darin Adler <Darin Adler>

Reviewed by Sam Weinig.

Make more HTML DOM members private, especially constructors, third and final batch
https://bugs.webkit.org/show_bug.cgi?id=39916

WebView/WebHTMLRepresentation.mm: (-[WebHTMLRepresentation elementWithName:inForm:]): Use the new HTMLFormElement function, associatedElements, rather than getting directly at a data member named formElements. (-[WebHTMLRepresentation controlsInForm:]): Ditto.

2010-05-30 Darin Adler <Darin Adler>

Reviewed by Sam Weinig.

Make more HTML DOM members private, especially constructors, third and final batch
https://bugs.webkit.org/show_bug.cgi?id=39916

dom/Document.cpp: (WebCore::Document::implicitClose):
editing/DeleteButtonController.cpp: (WebCore::DeleteButtonController::createDeletionUI):
editing/EditorCommand.cpp: (WebCore::executeInsertHorizontalRule): (WebCore::executeInsertImage):
editing/htmlediting.cpp: (WebCore::createDefaultParagraphElement): (WebCore::createListItemElement):
html/HTMLParser.cpp: (WebCore::HTMLParser::handleError): (WebCore::HTMLParser::headCreateErrorCheck): (WebCore::HTMLParser::formCreateErrorCheck): (WebCore::HTMLParser::createHead): (WebCore::HTMLParser::handleIsindex): (WebCore::HTMLParser::finished):
html/HTMLViewSourceDocument.cpp: (WebCore::HTMLViewSourceDocument::createContainingTable):
rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::createSubtreeIfNeeded):
rendering/RenderTextControlSingleLine.cpp: (WebCore::RenderTextControlSingleLine::createSubtreeIfNeeded): Use create instead of new to create HTML elements.

html/HTMLFormCollection.cpp: (WebCore::HTMLFormCollection::formCollectionInfo): (WebCore::HTMLFormCollection::item): (WebCore::HTMLFormCollection::getNamedFormItem): (WebCore::HTMLFormCollection::updateNameCache):
html/HTMLFormControlElement.h: Updated for name and privacy changes in HTMLFormElement.

html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::HTMLFormElement): (WebCore::HTMLFormElement::create): (WebCore::HTMLFormElement::~HTMLFormElement): (WebCore::HTMLFormElement::length): (WebCore::HTMLFormElement::submitImplicitly): (WebCore::HTMLFormElement::createFormData): (WebCore::HTMLFormElement::submit): (WebCore::HTMLFormElement::reset): (WebCore::HTMLFormElement::formElementIndex): (WebCore::HTMLFormElement::registerFormElement): (WebCore::HTMLFormElement::removeFormElement): (WebCore::HTMLFormElement::registerImgElement): (WebCore::HTMLFormElement::removeImgElement): (WebCore::HTMLFormElement::defaultButton): (WebCore::HTMLFormElement::collectUnhandledInvalidControls): (WebCore::HTMLFormElement::addElementAlias): (WebCore::HTMLFormElement::documentDidBecomeActive):
html/HTMLFormElement.h: Added create functions. Made constructors and other members private. Used an OwnPtr for m_elementAliases. Renamed collectionInfo to m_collectionCache and used an OwnPtr for it. Renamed formElements to m_associatedElements (since its contents are what HTML5 calls "form-associated element", not form elements). Renamed imgElements to m_imageElements.

html/HTMLFrameSetElement.cpp: (WebCore::HTMLFrameSetElement::HTMLFrameSetElement): (WebCore::HTMLFrameSetElement::create): (WebCore::HTMLFrameSetElement::parseMappedAttribute):
html/HTMLFrameSetElement.h: Added create functions. Made constructors and other members private. Renamed m_rows and m_cols to m_rowLengths and m_colLengths and used OwnArrayPtr for both.

html/HTMLLabelElement.cpp: (WebCore::nodeAsLabelableFormControl): Made this cast to Element instead of HTMLElement, since isFormControlElement is available on Element. (WebCore::HTMLLabelElement::HTMLLabelElement): (WebCore::HTMLLabelElement::create):
html/HTMLLabelElement.h: Added create functions. Made constructors and other members private.

html/HTMLLegendElement.cpp: (WebCore::HTMLLegendElement::HTMLLegendElement): (WebCore::HTMLLegendElement::create): (WebCore::HTMLLegendElement::associatedControl): (WebCore::HTMLLegendElement::focus): (WebCore::HTMLLegendElement::accessKeyAction):
html/HTMLLegendElement.h: Added create functions. Made constructors and other members private. Renamed formElement to associatedControl since hte control associated with this legend is not a "form element".

editing/DeleteButton.cpp: (WebCore::DeleteButton::DeleteButton): (WebCore::DeleteButton::create):
editing/DeleteButton.h:
html/HTMLDivElement.cpp: (WebCore::HTMLDivElement::HTMLDivElement): (WebCore::HTMLDivElement::create):
html/HTMLDivElement.h:
html/HTMLFontElement.cpp: (WebCore::HTMLFontElement::create):
html/HTMLFontElement.h:
html/HTMLHRElement.cpp: (WebCore::HTMLHRElement::HTMLHRElement): (WebCore::HTMLHRElement::create):
html/HTMLHRElement.h:
html/HTMLHeadElement.cpp: (WebCore::HTMLHeadElement::HTMLHeadElement): (WebCore::HTMLHeadElement::create):
html/HTMLHeadElement.h:
html/HTMLHeadingElement.cpp: (WebCore::HTMLHeadingElement::HTMLHeadingElement): (WebCore::HTMLHeadingElement::create):
html/HTMLHeadingElement.h:
html/HTMLHtmlElement.cpp: (WebCore::HTMLHtmlElement::HTMLHtmlElement): (WebCore::HTMLHtmlElement::create):
html/HTMLHtmlElement.h:
html/HTMLImageElement.cpp: (WebCore::HTMLImageElement::HTMLImageElement): (WebCore::HTMLImageElement::create):
html/HTMLImageElement.h:
html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::HTMLInputElement): (WebCore::HTMLInputElement::create): (WebCore::HTMLInputElement::createTemporaryFormForIsIndex):
html/HTMLInputElement.h:
html/HTMLIsIndexElement.cpp: (WebCore::HTMLIsIndexElement::HTMLIsIndexElement): (WebCore::HTMLIsIndexElement::create):
html/HTMLIsIndexElement.h:
html/HTMLLIElement.cpp: (WebCore::HTMLLIElement::HTMLLIElement): (WebCore::HTMLLIElement::create):
html/HTMLLIElement.h:
html/HTMLLinkElement.cpp: (WebCore::HTMLLinkElement::HTMLLinkElement): (WebCore::HTMLLinkElement::create):
html/HTMLLinkElement.h: Added create functions. Made constructors and other members private.

html/HTMLTagNames.in: Removed the createWithNew flag from all the tags that were still using it: div, font, form, frameset, h1, h2, h3, h4, h5, h6, head, hr, html, image, img, input, ins, isindex, label, legend, li, and link.

html/HTMLTextAreaElement.h: Removed unneeded definition of the readOnly function, since the one in HTMLFormElement does the same thing.

loader/ImageDocument.cpp: (WebCore::ImageDocumentElement::ImageDocumentElement): (WebCore::ImageDocumentElement::create): (WebCore::ImageDocument::createDocumentStructure): Added create functions. Made constructors and other members private.

page/DragController.cpp: (WebCore::DragController::concludeEditDrag): Use the non-virtual disabled function instead of the virtual isEnabledFormControl function, which just turns around and calls the disabled function.

rendering/MediaControlElements.cpp: (WebCore::MediaControlShadowRootElement::MediaControlShadowRootElement): (WebCore::MediaControlShadowRootElement::create): (WebCore::MediaControlElement::MediaControlElement): (WebCore::MediaControlElement::create): (WebCore::MediaControlTimelineContainerElement::MediaControlTimelineContainerElement): (WebCore::MediaControlTimelineContainerElement::create): (WebCore::MediaControlTimelineContainerElement::rendererIsNeeded): (WebCore::MediaControlVolumeSliderContainerElement::MediaControlVolumeSliderContainerElement): (WebCore::MediaControlVolumeSliderContainerElement::create): (WebCore::MediaControlStatusDisplayElement::MediaControlStatusDisplayElement): (WebCore::MediaControlStatusDisplayElement::create): (WebCore::MediaControlStatusDisplayElement::update): (WebCore::MediaControlStatusDisplayElement::rendererIsNeeded): (WebCore::MediaControlInputElement::MediaControlInputElement): (WebCore::MediaControlInputElement::styleForElement): (WebCore::MediaControlInputElement::rendererIsNeeded): (WebCore::MediaControlInputElement::attach): (WebCore::MediaControlInputElement::updateStyle): (WebCore::MediaControlMuteButtonElement::MediaControlMuteButtonElement): (WebCore::MediaControlMuteButtonElement::create): (WebCore::MediaControlMuteButtonElement::defaultEventHandler): (WebCore::MediaControlMuteButtonElement::updateDisplayType): (WebCore::MediaControlPlayButtonElement::MediaControlPlayButtonElement): (WebCore::MediaControlPlayButtonElement::create): (WebCore::MediaControlPlayButtonElement::defaultEventHandler): (WebCore::MediaControlPlayButtonElement::updateDisplayType): (WebCore::MediaControlSeekButtonElement::MediaControlSeekButtonElement): (WebCore::MediaControlSeekButtonElement::create): (WebCore::MediaControlSeekButtonElement::isForwardButton): (WebCore::MediaControlSeekButtonElement::defaultEventHandler): (WebCore::MediaControlSeekButtonElement::seekTimerFired): (WebCore::MediaControlRewindButtonElement::MediaControlRewindButtonElement): (WebCore::MediaControlRewindButtonElement::create): (WebCore::MediaControlRewindButtonElement::defaultEventHandler): (WebCore::MediaControlReturnToRealtimeButtonElement::MediaControlReturnToRealtimeButtonElement): (WebCore::MediaControlReturnToRealtimeButtonElement::create): (WebCore::MediaControlReturnToRealtimeButtonElement::defaultEventHandler): (WebCore::MediaControlToggleClosedCaptionsButtonElement::MediaControlToggleClosedCaptionsButtonElement): (WebCore::MediaControlToggleClosedCaptionsButtonElement::create): (WebCore::MediaControlToggleClosedCaptionsButtonElement::defaultEventHandler): (WebCore::MediaControlToggleClosedCaptionsButtonElement::updateDisplayType): (WebCore::MediaControlTimelineElement::MediaControlTimelineElement): (WebCore::MediaControlTimelineElement::create): (WebCore::MediaControlTimelineElement::defaultEventHandler): (WebCore::MediaControlTimelineElement::update): (WebCore::MediaControlVolumeSliderElement::MediaControlVolumeSliderElement): (WebCore::MediaControlVolumeSliderElement::create): (WebCore::MediaControlVolumeSliderElement::defaultEventHandler): (WebCore::MediaControlVolumeSliderElement::update): (WebCore::MediaControlFullscreenButtonElement::MediaControlFullscreenButtonElement): (WebCore::MediaControlFullscreenButtonElement::create): (WebCore::MediaControlFullscreenButtonElement::defaultEventHandler): (WebCore::MediaControlTimeDisplayElement::MediaControlTimeDisplayElement): (WebCore::MediaControlTimeDisplayElement::create):
rendering/MediaControlElements.h: Added create functions. Made constructors and other members private.

rendering/RenderFileUploadControl.cpp: (WebCore::ShadowInputElement::ShadowInputElement): (WebCore::ShadowInputElement::create): (WebCore::RenderFileUploadControl::updateFromElement): Added create functions. Made constructors and other members private.

rendering/RenderMedia.cpp: (WebCore::RenderMedia::createControlsShadowRoot): (WebCore::RenderMedia::createPanel): (WebCore::RenderMedia::createMuteButton): (WebCore::RenderMedia::createPlayButton): (WebCore::RenderMedia::createSeekBackButton): (WebCore::RenderMedia::createSeekForwardButton): (WebCore::RenderMedia::createRewindButton): (WebCore::RenderMedia::createReturnToRealtimeButton): (WebCore::RenderMedia::createToggleClosedCaptionsButton): (WebCore::RenderMedia::createStatusDisplay): (WebCore::RenderMedia::createTimelineContainer): (WebCore::RenderMedia::createTimeline): (WebCore::RenderMedia::createVolumeSliderContainer): (WebCore::RenderMedia::createVolumeSlider): (WebCore::RenderMedia::createCurrentTimeDisplay): (WebCore::RenderMedia::createTimeRemainingDisplay): (WebCore::RenderMedia::createFullscreenButton): Use create instead of new.

rendering/RenderProgress.cpp: (WebCore::ProgressValueElement::ProgressValueElement): (WebCore::ProgressValueElement::create): (WebCore::RenderProgress::updateValuePartState):
rendering/RenderSlider.cpp: (WebCore::SliderThumbElement::SliderThumbElement): (WebCore::SliderThumbElement::create): (WebCore::RenderSlider::updateFromElement): Added create functions. Made constructors and other members private.

rendering/TextControlInnerElements.cpp: (WebCore::TextControlInnerElement::TextControlInnerElement): (WebCore::TextControlInnerElement::create): (WebCore::TextControlInnerTextElement::TextControlInnerTextElement): (WebCore::TextControlInnerTextElement::create): (WebCore::TextControlInnerTextElement::defaultEventHandler): (WebCore::SearchFieldResultsButtonElement::SearchFieldResultsButtonElement): (WebCore::SearchFieldResultsButtonElement::create): (WebCore::SearchFieldResultsButtonElement::defaultEventHandler): (WebCore::SearchFieldCancelButtonElement::SearchFieldCancelButtonElement): (WebCore::SearchFieldCancelButtonElement::create): (WebCore::SearchFieldCancelButtonElement::defaultEventHandler): (WebCore::SpinButtonElement::SpinButtonElement): (WebCore::SpinButtonElement::create): (WebCore::SpinButtonElement::defaultEventHandler):
rendering/TextControlInnerElements.h: Added create functions. Made constructors and other members private.

11:27 AM Changeset in webkit [60417] by Darin Adler

2 edits in trunk/JavaScriptCore

wtf/OwnArrayPtr.h:

(WTF::OwnArrayPtr::set): Fix the assertion in here to match the one in OwnPtr.
At some point someone fixed the "asserts when assigning to 0 and the pointer is
already 0" issue in OwnPtr but forgot to do it here.

Reviewed by Sam Weinig.

11:10 AM Changeset in webkit [60416] by xan@webkit.org

2 edits in trunk/WebCore

2010-05-30 Xan Lopez <xlopez@igalia.com>

Reviewed by Darin Adler.

Incorrect build dependencies for GObject DOM Bindings
https://bugs.webkit.org/show_bug.cgi?id=39932

-include does not execute the implicit % expansion, we have to do
it manually.

GNUmakefile.am:

10:53 AM Changeset in webkit [60415] by eric@webkit.org

7 edits
2 adds in trunk

2010-05-30 Robert Hogan <robert@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Enhance Qt DRT implementation to support platform scroll wheel events.

https://bugs.webkit.org/show_bug.cgi?id=36004

Unskip:

fast/events/remove-child-onscroll.html
fast/events/platform-wheelevent-in-scrolling-div.html
fast/events/continuous-platform-wheelevent-in-scrolling-div.html

Add platform-specific results for Qt. Required because QWheelEvent only supports sending an event
for scrolling movement one axis at a time. Naturally the test's check for the axis the event does
not pertain to will 'fail' in such cases. So we get 6 lines of output in total, i.e.:

FAIL event.wheelDeltaY should be -24000. Was 0.
PASS event.wheelDeltaX is window.expectedScrollLeft*-120
PASS event.wheelDelta is window.expectedScrollLeft*-120

and then:

PASS event.wheelDeltaY is window.expectedScrollTop*-120
FAIL event.wheelDeltaX should be -12000. Was 0.
PASS event.wheelDelta is window.expectedScrollTop*-120

instead of just 3 like Mac:

PASS event.wheelDeltaY is window.expectedScrollTop*-120
PASS event.wheelDeltaX is window.expectedScrollLeft*-120
PASS event.wheelDelta is window.expectedScrollTop*-120

platform/qt-linux/fast/events/continuous-platform-wheelevent-in-scrolling-div-expected.txt: Added.
platform/qt-linux/fast/events/platform-wheelevent-in-scrolling-div-expected.txt: Added.
platform/qt/Skipped:

2010-05-30 Robert Hogan <robert@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Enhance Qt DRT implementation to support platform scroll wheel events.

https://bugs.webkit.org/show_bug.cgi?id=36004

Fix the bug in webkit.org/b/29601 for Qt. A delta not divisible by 120
indicates a device that is sending fine-resolution scroll events, so
use the delta as the number of pixels to scroll.

platform/qt/WheelEventQt.cpp: (WebCore::PlatformWheelEvent::applyDelta):

2010-05-30 Robert Hogan <robert@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Enhance Qt DRT implementation to support platform scroll wheel events.

https://bugs.webkit.org/show_bug.cgi?id=36004

DumpRenderTree/qt/EventSenderQt.cpp: (EventSender::EventSender): QApplication::setWheelScrollLines(2) in order to match

Scrollbar::pixelsPerLineStep() for DRT testing.

(EventSender::mouseScrollBy): Added
(EventSender::continuousMouseScrollBy): Added

DumpRenderTree/qt/EventSenderQt.h:

6:16 AM Changeset in webkit [60414] by jberlin@webkit.org

19 edits in trunk

https://bugs.webkit.org/show_bug.cgi?id=39224
Bug 39224 - Web Inspector: There should be a way to clean up profiles

Reviewed by Pavel Feldman.

WebCore:

Adds a button to clear the profiles from the profiles panel like that
used for the console, the audits panel, and the timeline panel.
Consolidates the css rules, since they all use the same image.
Also allows for individual profiles to be deleted via the keyboard
(U+0008 or U+007F) and uses this new schema for the Elements Tree.

English.lproj/localizedStrings.js:

Add tooltip text for the button to clear the profiles pane.

inspector/InspectorBackend.idl:

Add ability to remove the profiles from the backend when they are
deleted or cleared in the frontend.

inspector/InspectorBackend.cpp:

(WebCore::InspectorBackend::removeProfile):
(WebCore::InspectorBackend::clearProfiles):

inspector/InspectorBackend.h:
inspector/InspectorController.cpp:

(WebCore::InspectorController::removeProfile):
(WebCore::InspectorController::clearProfiles):

inspector/InspectorController.h:

inspector/front-end/AuditsPanel.js:

(WebInspector.AuditsPanel):
Use the 'clear-status-bar-item' class.

inspector/front-end/ChangesView.js:

(WebInspector.ChangesView):

inspector/front-end/TimelinePanel.js:

(WebInspector.TimelinePanel.prototype._createStatusbarButtons):

inspector/front-end/audits.css:
inspector/front-end/inspector.css:

(.clear-status-bar-item .glyph):

inspector/front-end/inspector.html:

inspector/front-end/ElementsTreeOutline.js:

Replace the keyDown handler on the Outline with specific methods to
handle delete and enter on the TreeElements.
(WebInspector.ElementsTreeOutline):
(WebInspector.ElementsTreeOutline.prototype.get editing):
Return whether or not an element in the tree is currently being edited.
(WebInspector.ElementsTreeElement.prototype.ondelete):
(WebInspector.ElementsTreeElement.prototype.onenter):

inspector/front-end/Panel.js:

(WebInspector.Panel.prototype.createSidebar):
Make the TreeOutline for a Panel's sidebar aware of its enclosing Panel.

inspector/front-end/ProfilesPanel.js:

(WebInspector.ProfilesPanel):
Add the clear button.
(WebInspector.ProfilesPanel.prototype.get statusBarItems):
(WebInspector.ProfilesPanel.prototype._clearProfiles):
Remove the profiles from the backend, the reset the frontend interface.
(WebInspector.ProfilesPanel.prototype.removeProfileHeader):
Remove the profile from both the frontend and the backend, and clear the
view when the last profile is removed.
(WebInspector.ProfilesPanel.prototype._updateInterface):
Hide the clear button when profiling is disabled.
(WebInspector.ProfileSidebarTreeElement.prototype.onselect):
Replace access to global variable with reference to the Panel held by the
TreeOutline.
(WebInspector.ProfileSidebarTreeElement.prototype.ondelete):
Remove the profile corresponding the tree element when the user deletes
that tree element.

inspector/front-end/treeoutline.js:

(TreeOutline.prototype._treeKeyDown):
Allow the selected tree element to handle the user pressing a delete
key or enter key.

WebKit/chromium:

src/js/InspectorControllerImpl.js:

(devtools.InspectorBackendImpl):

May 29, 2010:

8:49 PM Changeset in webkit [60413] by eric@webkit.org

4 edits in trunk/WebCore

2010-05-29 Lucas De Marchi <lucas.demarchi@profusion.mobi>

Reviewed by Darin Adler.

Check if a CC environment variable is defined before hard-coding gcc's
path. Simply hard-coding it breaks cross-compilation and Linux
distributions with more than one gcc installed (or not in the default
path).
https://bugs.webkit.org/show_bug.cgi?id=35551

No new functionality, so no new tests.

bindings/scripts/CodeGeneratorObjC.pm:
bindings/scripts/IDLParser.pm:
dom/make_names.pl:

3:16 PM Changeset in webkit [60412] by eric@webkit.org

2 edits in trunk/WebCore

2010-05-29 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: [REGRESSION] caller locations are not shown on Timeline Panel.

https://bugs.webkit.org/show_bug.cgi?id=39923

inspector/front-end/TimelinePanel.js: (WebInspector.TimelinePanel.FormattedRecord): (WebInspector.TimelinePanel.FormattedRecord.prototype._generatePopupContent): (WebInspector.TimelinePanel.FormattedRecord.prototype._getRecordDetails):

1:52 PM Changeset in webkit [60411] by eric@webkit.org

4 edits in trunk/WebKit/chromium

2010-05-29 Vangelis Kokkevis <vangelis@chromium.org>

Reviewed by Darin Fisher.

Adding support for a runtime flag to enable accelerated
compositing in chromium.
https://bugs.webkit.org/show_bug.cgi?id=39917

public/WebSettings.h:
src/WebSettingsImpl.cpp: (WebKit::WebSettingsImpl::setAcceleratedCompositingEnabled):
src/WebSettingsImpl.h:

11:18 AM Changeset in webkit [60410] by eric@webkit.org

4 edits in trunk/WebKit/qt

2010-05-29 Dawit Alemayehu <adawit@kde.org>

Reviewed by Kenneth Rohde Christiansen.

Added a WebAction to stop all pending page refresh/redirect
requests set through the <meta http-equiv="refresh"...> tag.

https://bugs.webkit.org/show_bug.cgi?id=29899

Api/qwebpage.cpp: (QWebPage::triggerAction):
Api/qwebpage.h:
tests/qwebpage/tst_qwebpage.cpp: (tst_QWebPage::testStopScheduledPageRefresh):

9:12 AM Changeset in webkit [60409] by eric@webkit.org

5 edits in trunk/WebCore

2010-05-29 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

HTML5 parser should block script execution until stylesheets load
https://bugs.webkit.org/show_bug.cgi?id=39903

All <script> tag execution now blocks on stylesheet load, including
inline <script> content which the old parser doesn't support blocking.

Hyatt says we could now get rid of updateLayoutIgnorePendingStylesheets
once our primary parser knows how to wait for stylesheets
before executing inline <script> content.

All of http/tests/local passes in --html5-parser mode now.
Also fixed fast/parser/tokenizer-close-during-document-write.html.

html/HTML5ScriptRunner.cpp: (WebCore::HTML5ScriptRunner::HTML5ScriptRunner):
- Added a m_hasScriptsWaitingForStylesheets bool so that we can detect when we're actually waiting on stylesheets or not. If we're not waiting on stylesheets then we're still parsing and executing scripts would cause parser/script reentrancy and bad news bears.

(WebCore::HTML5ScriptRunner::isPendingScriptReady):

Re-enable the check that the stylesheets have loaded.

(WebCore::HTML5ScriptRunner::executePendingScript):

ASSERT that stylesheets have loaded.

(WebCore::HTML5ScriptRunner::executeScriptsWaitingForLoad):

ASSERT that this is never called reentrantly.

(WebCore::HTML5ScriptRunner::executeScriptsWaitingForStylesheets):

Execute any scripts which were blocked on stylesheet loads.
ASSERT (in two ways) that this is never called reentrantly.

html/HTML5ScriptRunner.h: (WebCore::HTML5ScriptRunner::hasScriptsWaitingForStylesheets):
- Callers need to check this before calling executeScriptsWaitingForLoad.

(WebCore::HTML5ScriptRunner::inScriptExecution):

Used by callers to ASSERT that we're not called re-entrantly.

html/HTML5Tokenizer.cpp: (WebCore::HTML5Tokenizer::HTML5Tokenizer):
- Add m_hasScriptsWaitingForStylesheets for tracking if we've paused due to stylesheets or not. Callers need to know this to know if they should ignore executeScriptsWaitingForStylesheets calls from Document (which may be generated when parsing </script> tags). We only care about executeScriptsWaitingForStylesheets calls when we've actually blocked the parser due to waiting on a stylesheet load.

(WebCore::HTML5Tokenizer::end):

Move m_source.close() back to this method now that I understand more about when finish() is called. This should fix several layout test ASSERTS.

(WebCore::HTML5Tokenizer::finish):

This should not close m_source since scripts may still write to the document. Set m_wasWaitingOnScriptsDuringFinish to indicate that we were not able to end parsing during finish.

(WebCore::HTML5Tokenizer::resumeParsingAfterScriptExecution):

ASSERT that this is never caller re-entrantly.

(WebCore::HTML5Tokenizer::executeScript):

ASSERT that the ScriptRunner always thinks we're running scripts when this is called.

(WebCore::HTML5Tokenizer::executingScript):

Added implementation to fix fast/parser/tokenizer-close-during-document-write.html

(WebCore::HTML5Tokenizer::notifyFinished):

ASSERT that this is never called re-entrantly.

(WebCore::HTML5Tokenizer::executeScriptsWaitingForStylesheets):

Call the ScriptRunner to tell it that stylesheets have loaded if it is blocked on stylesheet loads.
ASSERT(m_hasScriptsWaitingForStylesheets). We can't just assert isPaused() since we may be paused for script loads.

html/HTML5Tokenizer.h:

8:30 AM Changeset in webkit [60408] by eric@webkit.org

12 edits in trunk/WebCore

2010-05-29 Laszlo Gombos <Laszlo Gombos>

Reviewed by Darin Adler.

Remove set but never used variables
https://bugs.webkit.org/show_bug.cgi?id=35252

No new tests as there is no new functionality.

accessibility/AccessibilityRenderObject.cpp: (WebCore::lastChildConsideringContinuation):
css/CSSFontSelector.cpp: (WebCore::CSSFontSelector::addFontFaceRule):
css/CSSParser.cpp: (WebCore::CSSParser::parseFontFaceUnicodeRange):
editing/InsertParagraphSeparatorCommand.cpp: (WebCore::InsertParagraphSeparatorCommand::doApply):
loader/appcache/ApplicationCacheStorage.cpp: (WebCore::ApplicationCacheStorage::loadManifestHostHashes):
page/EventHandler.cpp: (WebCore::EventHandler::handleWheelEvent):
page/animation/AnimationBase.cpp: (WebCore::AnimationBase::getTimeToNextEvent):
rendering/AutoTableLayout.cpp: (WebCore::AutoTableLayout::recalcColumn): (WebCore::AutoTableLayout::layout):
rendering/RenderBlock.cpp: (WebCore::RenderBlock::calcInlinePrefWidths):
rendering/RenderSVGResourceClipper.cpp: (WebCore::RenderSVGResourceClipper::createClipData):
storage/DatabaseTracker.cpp: (WebCore::DatabaseTracker::canEstablishDatabase):

8:18 AM Changeset in webkit [60407] by eric@webkit.org

2 edits in trunk/WebKitSite

2010-05-29 Sterling Swigart <sswigart@google.com>

Reviewed by David Levin.

Adding tests to canvas.html performance test
https://bugs.webkit.org/show_bug.cgi?id=39883

demos/canvas-perf/canvas.html: Added tests for:

strokeText
fillText
strokeLine

6:52 AM Changeset in webkit [60406] by eric@webkit.org

3 edits in trunk/WebCore

2010-05-29 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r60405.
http://trac.webkit.org/changeset/60405
https://bugs.webkit.org/show_bug.cgi?id=39921

It broke GTK build. (Requested by Ossy on #webkit).

dom/Node.cpp: (WebCore::Node::getElementsByTagName): (WebCore::Node::getElementsByTagNameNS):
dom/Node.h:

4:18 AM Changeset in webkit [60405] by eric@webkit.org

3 edits in trunk/WebCore

2010-05-29 Anton Muhin <antonm@chromium.org>

Reviewed by Darin Adler.

Make NodeList getters take AtomicString instead of plain String
https://bugs.webkit.org/show_bug.cgi?id=39892

Those methods turn String into AtomicString later. And this conversion
is faster if underlying string is already atomic.
That buys small (~2-3%) speed up for Chromium on Dromaeo DOM Core.
I don't know if Safari benefits from it.

dom/Node.cpp: (WebCore::Node::getElementsByTagName): (WebCore::Node::getElementsByTagNameNS):
dom/Node.h:

3:58 AM Changeset in webkit [60404] by eric@webkit.org

3 edits
4 adds in trunk

2010-05-29 Justin Schuh <jschuh@chromium.org>

Reviewed by Adam Barth.

Allow descendant frame navigation for file URLs when allowFileAccessFromFileURLs is false
https://bugs.webkit.org/show_bug.cgi?id=39750

Check that descendant file: frames can navigate each other.

fast/frames/location-change-no-file-access-expected.txt: Added.
fast/frames/location-change-no-file-access.html: Added.
fast/frames/resources/no-file-access-frame-1.html: Added.
fast/frames/resources/no-file-access-frame-2.html: Added.

2010-05-29 Justin Schuh <jschuh@chromium.org>

Reviewed by Adam Barth.

Allow descendant frame navigation for file URLs when allowFileAccessFromFileURLs is false
https://bugs.webkit.org/show_bug.cgi?id=39750

Fix for local HTML package breakage when each file is its own origin.
In this case we should allow descendant file: frames to navigate each
other when they share the same top frame.

Test: fast/frames/location-change-no-file-access.html

loader/FrameLoader.cpp: (WebCore::FrameLoader::shouldAllowNavigation):

3:07 AM Changeset in webkit [60403] by ggaren@apple.com

2 edits in trunk/JavaScriptCore

Windows build fix: Updated exported symbols.

JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:

1:13 AM Changeset in webkit [60402] by ggaren@apple.com

2 edits in trunk/JavaScriptCore

Disabled ENABLE_JIT_OPTIMIZE_NATIVE_CALL on Windows for now, until I
can figure out why it's crashing.

wtf/Platform.h:

12:46 AM Changeset in webkit [60401] by ggaren@apple.com

2 edits in trunk/JavaScriptCore

Fixed Windows crash seen on buildbot.

jit/JITOpcodes32_64.cpp:

(JSC::JIT::privateCompileCTINativeCall): fastcall puts the first
argument in ecx.

12:33 AM Changeset in webkit [60400] by ggaren@apple.com

2 edits in trunk/WebCore

Qt build fix: Updated for ArgList changes.

bridge/qt/qt_runtime.cpp:

(JSC::Bindings::QtRuntimeConnectionMethod::call):

12:27 AM Changeset in webkit [60399] by ggaren@apple.com

2 edits in trunk/WebCore

Qt build fix: Updated for ArgList changes.

bridge/qt/qt_runtime.cpp:

(JSC::Bindings::QtRuntimeMetaMethod::call):
(JSC::Bindings::QtRuntimeConnectionMethod::call):

12:21 AM Changeset in webkit [60398] by ggaren@apple.com

4 edits in trunk/WebCore

Qt build fix: Updated for ArgList changes.

bridge/qt/qt_pixmapruntime.cpp:

(JSC::Bindings::QtPixmapInstance::invokeMethod):

bridge/qt/qt_runtime.cpp:

(JSC::Bindings::findMethodIndex):
(JSC::Bindings::QtRuntimeMetaMethod::call):
(JSC::Bindings::QtRuntimeConnectionMethod::call):

bridge/qt/qt_runtime.h:

12:14 AM Changeset in webkit [60397] by ggaren@apple.com

3 edits in trunk/WebCore

Qt build fix: Updated for ArgList changes.

bridge/qt/qt_pixmapruntime.cpp:

(JSC::Bindings::QtPixmapAssignToElementMethod::invoke):
(JSC::Bindings::QtPixmapToDataUrlMethod::invoke):
(JSC::Bindings::QtPixmapToStringMethod::invoke):
(JSC::Bindings::QtPixmapInstance::invokeMethod):

bridge/qt/qt_pixmapruntime.h:

12:01 AM Changeset in webkit [60396] by ggaren@apple.com

3 edits in trunk/WebCore

Qt build fix: Keep this borken class limping along.

bridge/qt/qt_instance.cpp:

(JSC::Bindings::QtInstance::invokeMethod):

bridge/qt/qt_instance.h:

Note: See TracTimeline for information about the timeline view.

Download in other formats:

RSS Feed