Context Navigation

← Previous Period
Next Period →

Timeline

May 31, 2010:

11:21 PM Changeset in webkit [60464] by jamesr@google.com

4 edits in trunk/WebKit/chromium

2010-05-31 James Robinson <jamesr@chromium.org>

Reviewed by Darin Fisher.

Expose html5 parser enabled flag in WebSettings
https://bugs.webkit.org/show_bug.cgi?id=39913

public/WebSettings.h:
src/WebSettingsImpl.cpp: (WebKit::WebSettingsImpl::setHTML5ParserEnabled):
src/WebSettingsImpl.h:

11:13 PM Changeset in webkit [60463] by tkent@chromium.org

18 edits in trunk

2010-05-31 Lyon Chen <liachen@rim.com>

Reviewed by Kent Tamura.

Enum value FORWARD, BACKWARD, RIGHT, LEFT are causing macro conflicts.
https://bugs.webkit.org/show_bug.cgi?id=35530

Change enum EAlteration from { MOVE, EXTEND } to { AlterationMove, AlterationExtend } and enum EDirection { FORWARD, BACKWARD, RIGHT, LEFT} to { DirectionForward, DirectionBackward, DirectionRight, DirectionLeft } to avoid macro conflict, and also better coding style conformance.

accessibility/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::visiblePositionRangeForLine): (WebCore::AccessibilityRenderObject::doAXRangeForLine):
editing/Editor.cpp: (WebCore::Editor::deleteWithDirection): (WebCore::Editor::markMisspellingsAfterTypingToPosition): (WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges):
editing/EditorCommand.cpp: (WebCore::executeDeleteBackward): (WebCore::executeDeleteBackwardByDecomposingPreviousCharacter): (WebCore::executeDeleteForward): (WebCore::executeDeleteToBeginningOfLine): (WebCore::executeDeleteToBeginningOfParagraph): (WebCore::executeDeleteToEndOfLine): (WebCore::executeDeleteToEndOfParagraph): (WebCore::executeDeleteWordBackward): (WebCore::executeDeleteWordForward): (WebCore::executeForwardDelete): (WebCore::executeMoveBackward): (WebCore::executeMoveBackwardAndModifySelection): (WebCore::executeMoveDown): (WebCore::executeMoveDownAndModifySelection): (WebCore::executeMoveForward): (WebCore::executeMoveForwardAndModifySelection): (WebCore::executeMoveLeft): (WebCore::executeMoveLeftAndModifySelection): (WebCore::executeMovePageDown): (WebCore::executeMovePageDownAndModifySelection): (WebCore::executeMovePageUp): (WebCore::executeMovePageUpAndModifySelection): (WebCore::executeMoveRight): (WebCore::executeMoveRightAndModifySelection): (WebCore::executeMoveToBeginningOfDocument): (WebCore::executeMoveToBeginningOfDocumentAndModifySelection): (WebCore::executeMoveToBeginningOfLine): (WebCore::executeMoveToBeginningOfLineAndModifySelection): (WebCore::executeMoveToBeginningOfParagraph): (WebCore::executeMoveToBeginningOfParagraphAndModifySelection): (WebCore::executeMoveToBeginningOfSentence): (WebCore::executeMoveToBeginningOfSentenceAndModifySelection): (WebCore::executeMoveToEndOfDocument): (WebCore::executeMoveToEndOfDocumentAndModifySelection): (WebCore::executeMoveToEndOfSentence): (WebCore::executeMoveToEndOfSentenceAndModifySelection): (WebCore::executeMoveToEndOfLine): (WebCore::executeMoveToEndOfLineAndModifySelection): (WebCore::executeMoveToEndOfParagraph): (WebCore::executeMoveToEndOfParagraphAndModifySelection): (WebCore::executeMoveParagraphBackwardAndModifySelection): (WebCore::executeMoveParagraphForwardAndModifySelection): (WebCore::executeMoveUp): (WebCore::executeMoveUpAndModifySelection): (WebCore::executeMoveWordBackward): (WebCore::executeMoveWordBackwardAndModifySelection): (WebCore::executeMoveWordForward): (WebCore::executeMoveWordForwardAndModifySelection): (WebCore::executeMoveWordLeft): (WebCore::executeMoveWordLeftAndModifySelection): (WebCore::executeMoveWordRight): (WebCore::executeMoveWordRightAndModifySelection): (WebCore::executeMoveToLeftEndOfLine): (WebCore::executeMoveToLeftEndOfLineAndModifySelection): (WebCore::executeMoveToRightEndOfLine): (WebCore::executeMoveToRightEndOfLineAndModifySelection):
editing/SelectionController.cpp: (WebCore::SelectionController::willBeModified): (WebCore::SelectionController::modify):
editing/SelectionController.h: (WebCore::SelectionController::):
editing/TypingCommand.cpp: (WebCore::TypingCommand::deleteKeyPressed): (WebCore::TypingCommand::forwardDeleteKeyPressed):
page/DOMSelection.cpp: (WebCore::DOMSelection::modify): (WebCore::DOMSelection::deleteFromDocument):
page/EventHandler.cpp: (WebCore::EventHandler::handleKeyboardSelectionMovement):

2010-05-31 Lyon Chen <liachen@rim.com>

Reviewed by Kent Tamura.

Enum value FORWARD, BACKWARD, RIGHT, LEFT are causing macro conflicts.
https://bugs.webkit.org/show_bug.cgi?id=35530

Change enum EAlteration from { MOVE, EXTEND } to { AlterationMove, AlterationExtend } and enum EDirection { FORWARD, BACKWARD, RIGHT, LEFT} to { DirectionForward, DirectionBackward, DirectionRight, DirectionLeft } to avoid macro conflict, and also better coding style conformance.

efl/WebCoreSupport/EditorClientEfl.cpp: (WebCore::EditorClientEfl::handleEditingKeyboardEvent):

2010-05-31 Lyon Chen <liachen@rim.com>

Reviewed by Kent Tamura.

Enum value FORWARD, BACKWARD, RIGHT, LEFT are causing macro conflicts.
https://bugs.webkit.org/show_bug.cgi?id=35530

Change enum EAlteration from { MOVE, EXTEND } to { AlterationMove, AlterationExtend } and enum EDirection { FORWARD, BACKWARD, RIGHT, LEFT} to { DirectionForward, DirectionBackward, DirectionRight, DirectionLeft } to avoid macro conflict, and also better coding style conformance.

src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::executeCommand):

2010-05-31 Lyon Chen <liachen@rim.com>

Reviewed by Kent Tamura.

Enum value FORWARD, BACKWARD, RIGHT, LEFT are causing macro conflicts.
https://bugs.webkit.org/show_bug.cgi?id=35530

Change enum EAlteration from { MOVE, EXTEND } to { AlterationMove, AlterationExtend } and enum EDirection { FORWARD, BACKWARD, RIGHT, LEFT} to { DirectionForward, DirectionBackward, DirectionRight, DirectionLeft } to avoid macro conflict, and also better coding style conformance.

WebCoreSupport/EditorClientHaiku.cpp: (WebCore::EditorClientHaiku::handleKeyboardEvent):

2010-05-31 Lyon Chen <liachen@rim.com>

Reviewed by Kent Tamura.

Enum value FORWARD, BACKWARD, RIGHT, LEFT are causing macro conflicts.
https://bugs.webkit.org/show_bug.cgi?id=35530

Change enum EAlteration from { MOVE, EXTEND } to { AlterationMove, AlterationExtend } and enum EDirection { FORWARD, BACKWARD, RIGHT, LEFT} to { DirectionForward, DirectionBackward, DirectionRight, DirectionLeft } to avoid macro conflict, and also better coding style conformance.

WebCoreSupport/EditorClientQt.cpp: (WebCore::EditorClientQt::handleKeyboardEvent):

10:55 PM Changeset in webkit [60462] by rolandsteiner@chromium.org

1 edit
6 adds in trunk/LayoutTests

2010-05-31 Roland Steiner <rolandsteiner@chromium.org>

Unreviewed: land new Chromium baselines to unblock WebKit roll

Bug 39980 - Add Chromium baselines for svg/filters/parent-children-with-same-filter
https://bugs.webkit.org/show_bug.cgi?id=39980

Add new baselines

platform/chromium-linux/svg/filters/parent-children-with-same-filter-expected.checksum: Added.
platform/chromium-linux/svg/filters/parent-children-with-same-filter-expected.png: Added.
platform/chromium-mac/svg/filters/parent-children-with-same-filter-expected.checksum: Added.
platform/chromium-mac/svg/filters/parent-children-with-same-filter-expected.png: Added.
platform/chromium-win/svg/filters/parent-children-with-same-filter-expected.checksum: Added.
platform/chromium-win/svg/filters/parent-children-with-same-filter-expected.png: Added.

9:50 PM Changeset in webkit [60461] by abarth@webkit.org

5 edits in trunk

2010-05-31 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

REGRESSION(60409): window.onload never fires when using HTML5 parser
https://bugs.webkit.org/show_bug.cgi?id=39981

html/HTML5Tokenizer.cpp: (WebCore::HTML5Tokenizer::finish):
- The logic was just wrong here. We should only be setting m_wasWaitingOnScriptsDuringFinish if isWaitingForScripts() is true, and we should be calling end() when it is not.

(WebCore::HTML5Tokenizer::resumeParsingAfterScriptExecution):

Add another ASSERT to catch cases like this.

html/HTML5TreeBuilder.cpp: (WebCore::HTML5TreeBuilder::finished):
- Add a comment about why we don't need to call m_document->finishedParsing()

2010-05-31 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

REGRESSION(60409): window.onload never fires when using HTML5 parser
https://bugs.webkit.org/show_bug.cgi?id=39981

Now that we can actually run the tests again we pass 6 more.

html5lib/runner-expected-html5.txt:

8:25 PM Changeset in webkit [60460] by rolandsteiner@chromium.org

2 edits in trunk/WebKit/chromium

2010-05-31 Roland Steiner <rolandsteiner@chromium.org>

Bug 39977 - Missing Chromium bindings for InspectorController methods introduced in r60443
https://bugs.webkit.org/show_bug.cgi?id=39977

add missing InspectorController JS bindings:

getStyleSheet
getRuleRangesForStyleSheetId

Tests: inspector/styles-source-offsets.html

src/js/InspectorControllerImpl.js: (devtools.InspectorBackendImpl):

7:16 PM Changeset in webkit [60459] by tony@chromium.org

3 edits
2 adds in trunk

2010-05-31 Tony Chang <tony@chromium.org>

Reviewed by Dan Bernstein.

REGRESSION (r58665): Infinite recursion in Position::getInlineBoxAndOffset()
https://bugs.webkit.org/show_bug.cgi?id=39946

editing/selection/mixed-editability-12-expected.txt: Added.
editing/selection/mixed-editability-12.html: Added.

2010-05-31 Tony Chang <tony@chromium.org>

Reviewed by Dan Bernstein.

REGRESSION (r58665): Infinite recursion in Position::getInlineBoxAndOffset()
https://bugs.webkit.org/show_bug.cgi?id=39946

r58665 added an infinite recursion check, but didn't take into consideration recursion between two
Positions. This adds a check for when
downstreamIgnoringEditingBoundaries(p1) == p2 and upstreamIgnoringEditingBoundaries(p2) == p1

Test: editing/selection/mixed-editability-12.html

dom/Position.cpp: (WebCore::Position::getInlineBoxAndOffset):

6:23 PM Changeset in webkit [60458] by weinig@apple.com

15 edits
11 adds in trunk

Fix canvas.toDataURL(type, quality, ...) to let it support quality parameter.
And implement it in Qt port.
https://bugs.webkit.org/show_bug.cgi?id=37304

Patch by Leo Yang <leo.yang@torchmobile.com.cn> on 2010-05-31
Reviewed by George Staikos.

WebCore:

Tests: platform/qt/fast/canvas/toDataURL-jpeg-alpha.html

platform/qt/fast/canvas/toDataURL-jpeg-primarycolors.html
platform/qt/fast/canvas/toDataURL-jpeg-quality-basic.html
platform/qt/fast/canvas/toDataURL-jpeg-quality-notnumber.html
platform/qt/fast/canvas/toDataURL-jpeg-quality-outsiderange.html

bindings/js/JSHTMLCanvasElementCustom.cpp:

(WebCore::JSHTMLCanvasElement::toDataURL):

bindings/v8/custom/V8HTMLCanvasElementCustom.cpp:

(WebCore::V8HTMLCanvasElement::toDataURLCallback):

dom/CanvasSurface.cpp:

(WebCore::CanvasSurface::toDataURL):

dom/CanvasSurface.h:

(WebCore::CanvasSurface::toDataURL):

html/HTMLCanvasElement.idl:
platform/graphics/ImageBuffer.h:
platform/graphics/cairo/ImageBufferCairo.cpp: