⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Jun 1, 2010:

11:16 PM Changeset in webkit [60541] by krit@webkit.org
  • 25 edits in trunk

2010-06-01 Dirk Schulze <​krit@webkit.org>

Reviewed by Nikolas Zimmermann.

SVG repaintRect should be empty if content got clipped away
​https://bugs.webkit.org/show_bug.cgi?id=39965


The SVG repaintRect of the renderer was not empty, if the content got clipped away.
The MaskerData/ClipperData <-> RenderObject mapping is set up during the layout phase now, to be able to
relayout a RenderObject, if it's repaintRect is empty. This has the following reason:
We apply the object to the resource on painting at the moment.
With an empty repaintRect, paint() quits earlier and therefore the object doesn't get applied to the resource.
This can cause problems, if the resource get changed by animations or scripts.
On a change, the resource tells all it's callers to relayout.
If the reference to the caller (our RenderObject) is missing, the object won't ever update
and therefore won't get drawn.
We already have LayoutTests that cover this problem. The complete repaintRect calculation
(including the smallest clipping area and shadow size calculation) moved from the renderers to SVGRenderSupport.
This eliminates redundant code.

  • rendering/RenderPath.cpp: (WebCore::RenderPath::updateCachedBoundaries):
  • rendering/RenderSVGContainer.cpp: (WebCore::RenderSVGContainer::repaintRectInLocalCoordinates):
  • rendering/RenderSVGImage.cpp: (WebCore::RenderSVGImage::repaintRectInLocalCoordinates):
  • rendering/RenderSVGResource.h:
  • rendering/RenderSVGResourceClipper.cpp: (WebCore::RenderSVGResourceClipper::resourceBoundingBox):
  • rendering/RenderSVGResourceClipper.h:
  • rendering/RenderSVGResourceFilter.cpp: (WebCore::RenderSVGResourceFilter::resourceBoundingBox):
  • rendering/RenderSVGResourceFilter.h:
  • rendering/RenderSVGResourceGradient.h: (WebCore::RenderSVGResourceGradient::resourceBoundingBox):
  • rendering/RenderSVGResourceMarker.h: (WebCore::RenderSVGResourceMarker::resourceBoundingBox):
  • rendering/RenderSVGResourceMasker.cpp: (WebCore::RenderSVGResourceMasker::resourceBoundingBox):
  • rendering/RenderSVGResourceMasker.h:
  • rendering/RenderSVGResourcePattern.h: (WebCore::RenderSVGResourcePattern::resourceBoundingBox):
  • rendering/RenderSVGResourceSolidColor.h: (WebCore::RenderSVGResourceSolidColor::resourceBoundingBox):
  • rendering/RenderSVGText.cpp: (WebCore::RenderSVGText::strokeBoundingBox): (WebCore::RenderSVGText::repaintRectInLocalCoordinates):
  • rendering/SVGRenderSupport.cpp: (WebCore::SVGRenderBase::intersectRepaintRectWithResources):
  • rendering/SVGRenderSupport.h:
  • rendering/SVGRenderTreeAsText.cpp: (WebCore::writeResources):
  • rendering/style/SVGRenderStyle.h: (WebCore::SVGRenderStyle::hasClipper): (WebCore::SVGRenderStyle::hasMasker): (WebCore::SVGRenderStyle::hasFilter):


2010-06-01 Dirk Schulze <​krit@webkit.org>

Reviewed by Nikolas Zimmermann.

SVG repaintRect should be empty if content got clipped away
​https://bugs.webkit.org/show_bug.cgi?id=39965


New repaintRect calculation causes updates of tests, where the content gets
clipped away.

  • platform/mac/svg/clip-path/clip-path-with-container-expected.txt:
  • platform/mac/svg/clip-path/clip-path-with-invisibile-child-expected.txt:
  • platform/mac/svg/custom/empty-clip-path-expected.txt:
  • platform/mac/svg/custom/empty-mask-expected.txt:
11:13 PM Changeset in webkit [60540] by krit@webkit.org
  • 26 edits in trunk

2010-06-01 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r60539.
​http://trac.webkit.org/changeset/60539
​https://bugs.webkit.org/show_bug.cgi?id=40043

Accidentally added an unreviewed and invalid change to the
patch. (Requested by krit on #webkit).

  • rendering/RenderPath.cpp: (WebCore::RenderPath::updateCachedBoundaries):
  • rendering/RenderSVGContainer.cpp: (WebCore::RenderSVGContainer::repaintRectInLocalCoordinates):
  • rendering/RenderSVGImage.cpp: (WebCore::RenderSVGImage::repaintRectInLocalCoordinates):
  • rendering/RenderSVGResource.h:
  • rendering/RenderSVGResourceClipper.cpp: (WebCore::RenderSVGResourceClipper::resourceBoundingBox):
  • rendering/RenderSVGResourceClipper.h:
  • rendering/RenderSVGResourceFilter.cpp: (WebCore::RenderSVGResourceFilter::resourceBoundingBox):
  • rendering/RenderSVGResourceFilter.h:
  • rendering/RenderSVGResourceGradient.h: (WebCore::RenderSVGResourceGradient::resourceBoundingBox):
  • rendering/RenderSVGResourceMarker.h: (WebCore::RenderSVGResourceMarker::resourceBoundingBox):
  • rendering/RenderSVGResourceMasker.cpp: (WebCore::RenderSVGResourceMasker::resourceBoundingBox):
  • rendering/RenderSVGResourceMasker.h:
  • rendering/RenderSVGResourcePattern.h: (WebCore::RenderSVGResourcePattern::resourceBoundingBox):
  • rendering/RenderSVGResourceSolidColor.h: (WebCore::RenderSVGResourceSolidColor::resourceBoundingBox):
  • rendering/RenderSVGText.cpp: (WebCore::RenderSVGText::strokeBoundingBox): (WebCore::RenderSVGText::repaintRectInLocalCoordinates):
  • rendering/SVGRenderSupport.cpp: (WebCore::SVGRenderBase::filterBoundingBoxForRenderer): (WebCore::SVGRenderBase::clipperBoundingBoxForRenderer): (WebCore::SVGRenderBase::maskerBoundingBoxForRenderer):
  • rendering/SVGRenderSupport.h:
  • rendering/SVGRenderTreeAsText.cpp: (WebCore::writeResources):
  • rendering/style/SVGRenderStyle.h:
  • svg/SVGColor.cpp: (WebCore::SVGColor::colorFromRGBColorString):

2010-06-01 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r60539.
​http://trac.webkit.org/changeset/60539
​https://bugs.webkit.org/show_bug.cgi?id=40043

Accidentally added an unreviewed and invalid change to the
patch. (Requested by krit on #webkit).

  • platform/mac/svg/clip-path/clip-path-with-container-expected.txt:
  • platform/mac/svg/clip-path/clip-path-with-invisibile-child-expected.txt:
  • platform/mac/svg/custom/empty-clip-path-expected.txt:
  • platform/mac/svg/custom/empty-mask-expected.txt:
11:04 PM Changeset in webkit [60539] by krit@webkit.org
  • 26 edits in trunk

2010-06-01 Dirk Schulze <​krit@webkit.org>

Reviewed by Nikolas Zimmermann.

SVG repaintRect should be empty if content got clipped away
​https://bugs.webkit.org/show_bug.cgi?id=39965


The SVG repaintRect of the renderer was not empty, if the content got clipped away.
The MaskerData/ClipperData <-> RenderObject mapping is set up during the layout phase now, to be able to
relayout a RenderObject, if it's repaintRect is empty. This has the following reason:
We apply the object to the resource on painting at the moment.
With an empty repaintRect, paint() quits earlier and therefore the object doesn't get applied to the resource.
This can cause problems, if the resource get changed by animations or scripts.
On a change, the resource tells all it's callers to relayout.
If the reference to the caller (our RenderObject) is missing, the object won't ever update
and therefore won't get drawn.
We already have LayoutTests that cover this problem. The complete repaintRect calculation
(including the smallest clipping area and shadow size calculation) moved from the renderers to SVGRenderSupport.
This eliminates redundant code.

  • rendering/RenderPath.cpp: (WebCore::RenderPath::updateCachedBoundaries):
  • rendering/RenderSVGContainer.cpp: (WebCore::RenderSVGContainer::repaintRectInLocalCoordinates):
  • rendering/RenderSVGImage.cpp: (WebCore::RenderSVGImage::repaintRectInLocalCoordinates):
  • rendering/RenderSVGResource.h:
  • rendering/RenderSVGResourceClipper.cpp: (WebCore::RenderSVGResourceClipper::resourceBoundingBox):
  • rendering/RenderSVGResourceClipper.h:
  • rendering/RenderSVGResourceFilter.cpp: (WebCore::RenderSVGResourceFilter::resourceBoundingBox):
  • rendering/RenderSVGResourceFilter.h:
  • rendering/RenderSVGResourceGradient.h: (WebCore::RenderSVGResourceGradient::resourceBoundingBox):
  • rendering/RenderSVGResourceMarker.h: (WebCore::RenderSVGResourceMarker::resourceBoundingBox):
  • rendering/RenderSVGResourceMasker.cpp: (WebCore::RenderSVGResourceMasker::resourceBoundingBox):
  • rendering/RenderSVGResourceMasker.h:
  • rendering/RenderSVGResourcePattern.h: (WebCore::RenderSVGResourcePattern::resourceBoundingBox):
  • rendering/RenderSVGResourceSolidColor.h: (WebCore::RenderSVGResourceSolidColor::resourceBoundingBox):
  • rendering/RenderSVGText.cpp: (WebCore::RenderSVGText::strokeBoundingBox): (WebCore::RenderSVGText::repaintRectInLocalCoordinates):
  • rendering/SVGRenderSupport.cpp: (WebCore::SVGRenderBase::intersectRepaintRectWithResources):
  • rendering/SVGRenderSupport.h:
  • rendering/SVGRenderTreeAsText.cpp: (WebCore::writeResources):
  • rendering/style/SVGRenderStyle.h: (WebCore::SVGRenderStyle::hasClipper): (WebCore::SVGRenderStyle::hasMasker): (WebCore::SVGRenderStyle::hasFilter):


2010-06-01 Dirk Schulze <​krit@webkit.org>

Reviewed by Nikolas Zimmermann.

SVG repaintRect should be empty if content got clipped away
​https://bugs.webkit.org/show_bug.cgi?id=39965


New repaintRect calculation causes updates of tests, where the content gets
clipped away.

  • platform/mac/svg/clip-path/clip-path-with-container-expected.txt:
  • platform/mac/svg/clip-path/clip-path-with-invisibile-child-expected.txt:
  • platform/mac/svg/custom/empty-clip-path-expected.txt:
  • platform/mac/svg/custom/empty-mask-expected.txt:
10:57 PM Changeset in webkit [60538] by tkent@chromium.org
  • 2 edits in trunk/WebKit/chromium

Unreviewed, build fix.

Roll our r60536. The change was not wrong, but not good for Chromium bots status.

10:49 PM Changeset in webkit [60537] by eric@webkit.org
  • 2 edits
    2 adds in trunk/WebKit/qt

2010-06-01 Noam Rosenthal <​noam.rosenthal@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Add documentation to the QtWebkit bridge
​https://bugs.webkit.org/show_bug.cgi?id=35861

This patch includes comprehensive qdoc documentation for the QtWebkit bridge.

  • docs/qtwebkit-bridge.qdoc: Added.
  • docs/qtwebkit.qdoc:
  • docs/webkitsnippets/doc_src_qtscript.qdoc: Added.
  • docs/webkitsnippets/qtwebkit_bridge_snippets.cpp: Added. (wrapInFunction):
10:47 PM Changeset in webkit [60536] by tkent@chromium.org
  • 2 edits in trunk/WebKit/chromium

2010-06-01 Kent Tamura <​tkent@chromium.org>

Reviewed by Dimitri Glazkov.

[DRT/Chromium] Checking out lighttpd
​https://bugs.webkit.org/show_bug.cgi?id=39948

  • Add lighttpd only on Windows. It is used by new-run-webkit-tests.
  • Add libvpx.
  • Remove pthreads-win32 from DEPS. It has not been used since Chromium r28642.
  • Update Chromium revision to use Windows resource query code and webkit_glue dependency fix.
  • DEPS:
10:04 PM Changeset in webkit [60535] by eric@webkit.org
  • 9 edits
    3 deletes in trunk

2010-06-01 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r60530.
​http://trac.webkit.org/changeset/60530
​https://bugs.webkit.org/show_bug.cgi?id=40041

resource-har-conversion failed on GTK (Requested by abarth on
#webkit).

  • http/tests/inspector/inspector-test.js:
  • http/tests/inspector/resource-har-conversion-expected.txt: Removed.
  • http/tests/inspector/resource-har-conversion.html: Removed.

2010-06-01 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r60530.
​http://trac.webkit.org/changeset/60530
​https://bugs.webkit.org/show_bug.cgi?id=40041

resource-har-conversion failed on GTK (Requested by abarth on
#webkit).

  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/front-end/HAREntry.js: Removed.
  • inspector/front-end/Resource.js: (WebInspector.Resource): (WebInspector.Resource.prototype.set url):
  • inspector/front-end/ResourceView.js: (WebInspector.ResourceView.prototype._refreshQueryString): (WebInspector.ResourceView.prototype._refreshFormData): (WebInspector.ResourceView.prototype._refreshParms):
  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/inspector.html:
8:52 PM Changeset in webkit [60534] by tkent@chromium.org
  • 2 edits
    12 adds in trunk/LayoutTests

Unreviewed. Test expectation update.

Add Chromium-win Chromium-linux results for backslash-to-yen-sign*.html tests.

  • platform/chromium-linux/fast/text/backslash-to-yen-sign-dynamic-expected.checksum: Added.
  • platform/chromium-linux/fast/text/backslash-to-yen-sign-dynamic-expected.png: Added.
  • platform/chromium-linux/fast/text/backslash-to-yen-sign-dynamic-expected.txt: Added.
  • platform/chromium-linux/fast/text/backslash-to-yen-sign-expected.checksum: Added.
  • platform/chromium-linux/fast/text/backslash-to-yen-sign-expected.png: Added.
  • platform/chromium-linux/fast/text/backslash-to-yen-sign-expected.txt: Added.
  • platform/chromium-win/fast/text/backslash-to-yen-sign-dynamic-expected.checksum: Added.
  • platform/chromium-win/fast/text/backslash-to-yen-sign-dynamic-expected.png: Added.
  • platform/chromium-win/fast/text/backslash-to-yen-sign-dynamic-expected.txt: Added.
  • platform/chromium-win/fast/text/backslash-to-yen-sign-expected.checksum: Added.
  • platform/chromium-win/fast/text/backslash-to-yen-sign-expected.png: Added.
  • platform/chromium-win/fast/text/backslash-to-yen-sign-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
8:42 PM Changeset in webkit [60533] by pkasting@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed. Update test expectations.

  • platform/chromium/test_expectations.txt: moving-shadow-on-path has been rebaselined. input-search-padding may or may not be flaky.
8:40 PM Changeset in webkit [60532] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-06-01 No'am Rosenthal <​noam.rosenthal@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] GraphicsLayer: warnings when reloading page
​https://bugs.webkit.org/show_bug.cgi?id=39694

Made sure recaching and masks aren't attempted on zero-size layers.

No new tests. Old tests (e.g. LayoutTests/compositing/masks) show the problem.

  • platform/graphics/qt/GraphicsLayerQt.cpp: (WebCore::MaskEffectQt::draw): (WebCore::GraphicsLayerQtImpl::recache):
8:28 PM Changeset in webkit [60531] by eric@webkit.org
  • 4 edits in trunk/WebCore

2010-06-01 anton muhin <​antonm@google.com>

Reviewed by Nate Chapin.

[Chromium] enforce presence of named property query callback if named property enumerator is present
​https://bugs.webkit.org/show_bug.cgi?id=40006
We need to be able to distinguish between enumerable and not enumerable properties
in the presence of named interceptor. V8 is migrating to use query
callback to report enumerable properties and fallback check---
using getter callback---would report properties as not enumerable.
Thus if there is an enumerator callback, there should be query callback as well.
(see V8's r4751).

  • bindings/scripts/CodeGeneratorV8.pm:
  • bindings/v8/V8NPObject.cpp: (WebCore::npObjectQueryProperty): (WebCore::createV8ObjectForNPObject):
  • bindings/v8/custom/V8StorageCustom.cpp: (WebCore::V8Storage::namedPropertyQuery):
8:15 PM Changeset in webkit [60530] by eric@webkit.org
  • 9 edits
    3 adds in trunk

2010-06-01 Andrey Kosyakov <​caseq@chromium.org>

Reviewed by Pavel Feldman.

WebInspector: Added test for contents of resource record and HAR conversion results.
Added generic object dumper to inspector-tests.js.
​https://bugs.webkit.org/show_bug.cgi?id=30567

  • http/tests/inspector/inspector-test.js: (dumpObject):
  • http/tests/inspector/resource-har-conversion-expected.txt: Added.
  • http/tests/inspector/resource-har-conversion.html: Added.

2010-06-01 Andrey Kosyakov <​caseq@chromium.org>

Reviewed by Pavel Feldman.

WebInspector: Added conversion of inspector's resource representation into HAR.
Moved common resource accessors from ResourceView to Resource.
​https://bugs.webkit.org/show_bug.cgi?id=30567

Test: http/tests/inspector/resource-har-conversion.html

8:03 PM Changeset in webkit [60529] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-06-01 Laszlo Gombos <Laszlo Gombos>

Reviewed by Kenneth Rohde Christiansen.

Fix "variable may be used before being set" warning in TextResourceDecoder::checkForHeadCharset
​https://bugs.webkit.org/show_bug.cgi?id=40001

No new tests as there is no new functionality.

Initialize len to 0 just to eliminate the compiler warning.

  • loader/TextResourceDecoder.cpp: (WebCore::TextResourceDecoder::checkForHeadCharset):
7:52 PM Changeset in webkit [60528] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-06-01 Ilya Tikhonovsky <​loislo@chromium.org>

Reviewed by Pavel Feldman.

WebInspector: Safari specific files InspectorFrontendClientLocal were removed from chromium project.
​https://bugs.webkit.org/show_bug.cgi?id=39993

  • WebCore.gypi:
7:38 PM Changeset in webkit [60527] by eric@webkit.org
  • 3 edits in trunk/WebCore

2010-06-01 Andreas Kling <​andreas.kling@nokia.com>

Reviewed by Darin Adler.

Fix broken code generation in GenerateParametersCheckExpression.
​https://bugs.webkit.org/show_bug.cgi?id=39960

  • bindings/scripts/CodeGeneratorJS.pm:
  • bindings/scripts/test/JS/JSTestObj.cpp: Updated baseline.
7:27 PM Changeset in webkit [60526] by tkent@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed. Update test expectations.

  • Mark input-search-padding.html flaky on Mac
  • Remove function_arguments.html, styles-disable-then-enable.html, notifications-replace.html and notifications-rtl.html. They pass recently.
  • platform/chromium/test_expectations.txt:
7:07 PM Changeset in webkit [60525] by eric@webkit.org
  • 6 edits in trunk

2010-06-01 Raine Makelainen <​raine.makelainen@nokia.com>

Reviewed by Simon Hausmann.

[Qt]: REGRESSION(r58703): QWebSettings::JavascriptCanAccessClipboard has wrong case in "Javascript" part.
​https://bugs.webkit.org/show_bug.cgi?id=39878

QWebSettings::JavaScriptCanAccessClipboard reverted back to
QWebSettings::JavascriptCanAccessClipboard. QWebSettings::DOMPasteAllowed enum removed.

Value of QWebSettings::JavascriptCanAccessClipboard to setDOMPasteAllowed and
setJavaScriptCanAccessClipboard of WebCore::Settings.

  • Api/qwebsettings.cpp: (QWebSettingsPrivate::apply):
  • Api/qwebsettings.h:

2010-06-01 Raine Makelainen <​raine.makelainen@nokia.com>

Reviewed by Simon Hausmann.

Fixed tests to use QWebSettings::JavascriptCanAccessClipboard instead of QWebSettings::JavaScriptCanAccessClipboard.

  • DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::WebPage::WebPage): (WebCore::WebPage::resetSettings):
  • DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::setJavaScriptCanAccessClipboard):
6:24 PM Changeset in webkit [60524] by jamesr@google.com
  • 19 edits
    14 adds
    1 delete in trunk/LayoutTests

2010-06-01 James Robinson <​jamesr@chromium.org>

Unreviewed. Update the chromium baselines.

  • platform/chromium-linux/fast/multicol/span/span-as-nested-columns-child-dynamic-expected.checksum: Added.
  • platform/chromium-linux/fast/multicol/span/span-as-nested-columns-child-dynamic-expected.png: Added.
  • platform/chromium-linux/fast/multicol/span/span-as-nested-columns-child-expected.checksum: Added.
  • platform/chromium-linux/fast/multicol/span/span-as-nested-columns-child-expected.png: Added.
  • platform/chromium-linux/fast/repaint/moving-shadow-on-path-expected.checksum:
  • platform/chromium-linux/fast/repaint/moving-shadow-on-path-expected.png:
  • platform/chromium-linux/svg/css/group-with-shadow-expected.checksum:
  • platform/chromium-linux/svg/css/group-with-shadow-expected.png:
  • platform/chromium-linux/svg/css/stars-with-shadow-expected.checksum:
  • platform/chromium-linux/svg/css/stars-with-shadow-expected.png:
  • platform/chromium-mac/fast/multicol/span/span-as-nested-columns-child-dynamic-expected.checksum: Added.
  • platform/chromium-mac/fast/multicol/span/span-as-nested-columns-child-dynamic-expected.png: Added.
  • platform/chromium-mac/fast/multicol/span/span-as-nested-columns-child-expected.checksum: Added.
  • platform/chromium-mac/fast/multicol/span/span-as-nested-columns-child-expected.png: Added.
  • platform/chromium-mac/fast/repaint/moving-shadow-on-path-expected.checksum:
  • platform/chromium-mac/fast/repaint/moving-shadow-on-path-expected.png:
  • platform/chromium-mac/svg/css/stars-with-shadow-expected.checksum:
  • platform/chromium-mac/svg/css/stars-with-shadow-expected.png: Removed.
  • platform/chromium-win/fast/multicol/span/span-as-nested-columns-child-dynamic-expected.checksum: Added.
  • platform/chromium-win/fast/multicol/span/span-as-nested-columns-child-dynamic-expected.png: Added.
  • platform/chromium-win/fast/multicol/span/span-as-nested-columns-child-dynamic-expected.txt: Added.
  • platform/chromium-win/fast/multicol/span/span-as-nested-columns-child-expected.checksum: Added.
  • platform/chromium-win/fast/multicol/span/span-as-nested-columns-child-expected.png: Added.
  • platform/chromium-win/fast/multicol/span/span-as-nested-columns-child-expected.txt: Added.
  • platform/chromium-win/fast/repaint/moving-shadow-on-path-expected.checksum:
  • platform/chromium-win/fast/repaint/moving-shadow-on-path-expected.png:
  • platform/chromium-win/svg/css/group-with-shadow-expected.checksum:
  • platform/chromium-win/svg/css/group-with-shadow-expected.png:
  • platform/chromium-win/svg/css/group-with-shadow-expected.txt:
  • platform/chromium-win/svg/css/stars-with-shadow-expected.checksum:
  • platform/chromium-win/svg/css/stars-with-shadow-expected.png:
  • platform/chromium-win/svg/custom/use-modify-target-symbol-expected.txt:
  • platform/chromium/test_expectations.txt:
5:34 PM Changeset in webkit [60523] by mrowe@apple.com
  • 1 edit
    1 delete in trunk/WebCore

Remove Breakpoint.js. It was emptied in r60450 but for some reason it was not
deleted at that time. The presence of empty files within the inspector's resource
folder causes Mac OS X production builds to fail.

Rubber-stamped by Adam Roben.

  • inspector/front-end/Breakpoint.js: Removed.
5:30 PM Changeset in webkit [60522] by ap@apple.com
  • 3 edits in trunk/LayoutTests

Fixes Gtk buildbot. Suggested by Gavin Barraclough.

​https://bugs.webkit.org/show_bug.cgi?id=40012
Callable objects created via JavaScriptCore API cannot be used as Geolocation callbacks

Disable subtests that check Math.abs - JS host objects are still InternalFunctions in
interpreter, so they behave differently from JIT. The bug tracks deciding what's the best
solution here.

  • fast/dom/Geolocation/argument-types-expected.txt:
  • fast/dom/Geolocation/script-tests/argument-types.js:
5:23 PM Changeset in webkit [60521] by mrowe@apple.com
  • 5 edits in branches/safari-533-branch

Versioning.

5:22 PM Changeset in webkit [60520] by mrowe@apple.com
  • 1 copy in tags/Safari-533.15

New tag.

5:04 PM Changeset in webkit [60519] by mrowe@apple.com
  • 2 edits in branches/safari-533-branch/WebKit/mac

Merge r60504.

5:04 PM Changeset in webkit [60518] by mrowe@apple.com
  • 2 edits in branches/safari-533-branch/WebCore

Merge r60502.

5:04 PM Changeset in webkit [60517] by alice.liu@apple.com
  • 2 edits in trunk/WebKit2

Build fix. Not reviewed

  • win/WebKit2Generated.make: Added WKRetainPtr.h
4:58 PM Changeset in webkit [60516] by jamesr@google.com
  • 2 edits in trunk/LayoutTests

2010-06-01 James Robinson <​jamesr@chromium.org>

Unreviewed. Update expected results for r60503
​https://bugs.webkit.org/show_bug.cgi?id=38851

  • platform/mac/fast/repaint/moving-shadow-on-path-expected.txt:
4:58 PM Changeset in webkit [60515] by jhawkins@chromium.org
  • 2 edits in trunk/WebKit/chromium

2010-06-01 James Hawkins <​jhawkins@chromium.org>

UNREVIEWED: build fix.

Implement the added virtual methods from PopupMenuClient to
TestPopupMenuClient.

  • tests/PopupMenuTest.cpp: (WebKit::TestPopupMenuClient::selectionChanged): (WebKit::TestPopupMenuClient::selectionCleared):
4:29 PM Changeset in webkit [60514] by jhawkins@chromium.org
  • 12 edits in trunk

2010-05-24 James Hawkins <​jhawkins@chromium.org>

Reviewed by Darin Fisher.

[Chromium] Implement new PopupMenuClient methods selectionChanged()
and selectionCleared(). Expose placeHolder methods and isAutoFilled()
in WebInputElement.

​https://bugs.webkit.org/show_bug.cgi?id=39639

  • public/WebInputElement.h:
  • public/WebViewClient.h: (WebKit::WebViewClient::didSelectAutoFillSuggestion): (WebKit::WebViewClient::didClearAutoFillSelection):
  • src/AutoFillPopupMenuClient.cpp: (WebKit::AutoFillPopupMenuClient::selectionChanged): (WebKit::AutoFillPopupMenuClient::selectionCleared): (WebKit::AutoFillPopupMenuClient::popupDidHide):
  • src/AutoFillPopupMenuClient.h:
  • src/SuggestionsPopupMenuClient.h: (WebKit::SuggestionsPopupMenuClient::selectionChanged): (WebKit::SuggestionsPopupMenuClient::selectionCleared):
  • src/WebInputElement.cpp: (WebKit::WebInputElement::setPlaceholder): (WebKit::WebInputElement::placeholder): (WebKit::WebInputElement::isAutofilled):

2010-05-24 James Hawkins <​jhawkins@chromium.org>

Reviewed by Darin Fisher.

Added ability for PopupMenuClient to signal when

  • selection changed, and
  • selection cleared.

​https://bugs.webkit.org/show_bug.cgi?id=39639

No new tests because this functionality is intentionally hidden from
everything other than renderer.

  • platform/PopupMenuClient.h:
  • platform/chromium/PopupMenuChromium.cpp: (WebCore::PopupListBox::selectIndex): (WebCore::PopupListBox::clearSelection):
  • rendering/RenderMenuList.h: (WebCore::RenderMenuList::RenderMenuList::selectionChanged): (WebCore::RenderMenuList::RenderMenuList::selectionCleared):
  • rendering/RenderTextControlSingleLine.h: (WebCore::RenderTextControlSingleLine::selectionChanged): (WebCore::RenderTextControlSingleLine::selectionCleared):
4:25 PM Changeset in webkit [60513] by dumi@chromium.org
  • 6 edits in trunk/WebCore

Check if a database needs to be auto-vacuumed only after transactions that have deleted something.
​https://bugs.webkit.org/show_bug.cgi?id=39688

Reviewed by Dimitri Glazkov.

  • storage/Database.cpp:

(WebCore::Database::resetDeletes):
(WebCore::Database::hadDeletes):

  • storage/Database.h:
  • storage/DatabaseAuthorizer.cpp:

(WebCore::DatabaseAuthorizer::resetDeletes):
(WebCore::DatabaseAuthorizer::dropTable):
(WebCore::DatabaseAuthorizer::dropTempTable):
(WebCore::DatabaseAuthorizer::dropIndex):
(WebCore::DatabaseAuthorizer::dropTempIndex):
(WebCore::DatabaseAuthorizer::dropTrigger):
(WebCore::DatabaseAuthorizer::dropTempTrigger):
(WebCore::DatabaseAuthorizer::dropView):
(WebCore::DatabaseAuthorizer::dropTempView):
(WebCore::DatabaseAuthorizer::dropVTable):
(WebCore::DatabaseAuthorizer::allowDelete):
(WebCore::DatabaseAuthorizer::updateDeletesBasedOnTableName): Added.

  • storage/DatabaseAuthorizer.h:

(WebCore::DatabaseAuthorizer::hadDeletes):

  • storage/SQLTransaction.cpp:

(WebCore::SQLTransaction::openTransactionAndPreflight):
(WebCore::SQLTransaction::postflightAndCommit):

4:13 PM Changeset in webkit [60512] by barraclough@apple.com
  • 4 edits in trunk/JavaScriptCore

Bug 40021 - Refactor bytecode generation for calls so that register for this & args are allocated together

Reviewed by Sam Weinig.

This is a useful stepping stone towards reversing argument order.

  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::BytecodeGenerator):
(JSC::BytecodeGenerator::addParameter):
(JSC::BytecodeGenerator::emitCall):
(JSC::BytecodeGenerator::emitCallEval):
(JSC::BytecodeGenerator::emitConstruct):

  • bytecompiler/BytecodeGenerator.h:

(JSC::CallArguments::thisRegister):
(JSC::CallArguments::argumentRegister):
(JSC::CallArguments::callFrame):
(JSC::CallArguments::count):
(JSC::BytecodeGenerator::shouldEmitProfileHooks):

  • bytecompiler/NodesCodegen.cpp:

(JSC::NewExprNode::emitBytecode):
(JSC::CallArguments::CallArguments):
(JSC::EvalFunctionCallNode::emitBytecode):
(JSC::FunctionCallValueNode::emitBytecode):
(JSC::FunctionCallResolveNode::emitBytecode):
(JSC::FunctionCallBracketNode::emitBytecode):
(JSC::FunctionCallDotNode::emitBytecode):
(JSC::CallFunctionCallDotNode::emitBytecode):
(JSC::ApplyFunctionCallDotNode::emitBytecode):

3:47 PM Changeset in webkit [60511] by ap@apple.com
  • 3 edits in trunk/WebKitTools

Reviewed by Mark Rowe.

A nicer Tiger build fix.

  • DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
  • DumpRenderTree/mac/Configurations/Base.xcconfig: Enable GCC_OBJC_CALL_CXX_CDTORS via .xcconfig.
3:37 PM Changeset in webkit [60510] by sullivan@apple.com
  • 3 edits in trunk/WebKit2

Added _WKRetainPtr to .exp file, and added .exp file to Xcode project.

Rubber-stamped by Anders Carlsson.

  • WebKit2.xcodeproj/project.pbxproj:

Added mac/WebKit2.exp.

  • mac/WebKit2.exp:

Added _WKRetainPtr.

2:41 PM Changeset in webkit [60509] by hyatt@apple.com
  • 8 edits in trunk

Add a preference for paginating during layout (the new model for computing page breaks).

Reviewed by Anders Carlsson.

WebCore:

  • page/Settings.cpp:

(WebCore::Settings::Settings):

  • page/Settings.h:

(WebCore::Settings::setPaginateDuringLayoutEnabled):
(WebCore::Settings::paginateDuringLayoutEnabled):

WebKit/mac:

  • WebView/WebPreferenceKeysPrivate.h:
  • WebView/WebPreferences.mm:

(-[WebPreferences paginateDuringLayoutEnabled]):
(-[WebPreferences setPaginateDuringLayoutEnabled:]):

  • WebView/WebPreferencesPrivate.h:
  • WebView/WebView.mm:

(-[WebView _preferencesChangedNotification:]):

2:39 PM Changeset in webkit [60508] by dumi@chromium.org
  • 11 edits in trunk/WebCore

Clean up the DB classes in preparation for a bigger refactoring.
​https://bugs.webkit.org/show_bug.cgi?id=39041

Reviewed by Adam Barth.

  • storage/ChangeVersionWrapper.cpp:
  • storage/ChangeVersionWrapper.h:
  • storage/Database.cpp:

(WebCore::Database::Database):
(WebCore::Database::lastActionChangedDatabase):
(WebCore::Database::lastActionWasInsert):
(WebCore::Database::inProgressTransactionCompleted):
(WebCore::Database::securityOrigin):

  • storage/Database.h:

(WebCore::Database::sqliteDatabase):
(WebCore::Database::databaseDebugName):

  • storage/DatabaseTask.cpp:

(WebCore::DatabaseTransactionTask::doPerformTask):

  • storage/DatabaseTask.h:
  • storage/SQLStatement.cpp:

(WebCore::SQLStatement::execute):

  • storage/SQLStatement.h:
  • storage/SQLTransaction.cpp:

(WebCore::SQLTransaction::SQLTransaction):
(WebCore::SQLTransaction::openTransactionAndPreflight):
(WebCore::SQLTransaction::runStatements):
(WebCore::SQLTransaction::runCurrentStatement):
(WebCore::SQLTransaction::postflightAndCommit):
(WebCore::SQLTransaction::cleanupAfterSuccessCallback):
(WebCore::SQLTransaction::cleanupAfterTransactionErrorCallback):

  • storage/SQLTransaction.h:
2:26 PM Changeset in webkit [60507] by Csaba Osztrogonác
  • 4 edits in trunk/LayoutTests

[Qt] Update expected results after r60503.

Reviewed by Laszlo Gombos.

  • platform/qt/fast/repaint/moving-shadow-on-path-expected.txt:
  • platform/qt/svg/css/arrow-with-shadow-expected.txt:
  • platform/qt/svg/css/stars-with-shadow-expected.txt:
2:26 PM Changeset in webkit [60506] by sullivan@apple.com
  • 2 edits in trunk/WebKit2

Fixed typo/wordo that prevented a certain flavor of constructor from compiling.

Rubber-stamped by Anders Carlsson.

  • UIProcess/API/cpp/WKRetainPtr.h:

(WebKit::WKRetainPtr::WKRetainPtr):
Changed the mysterious "retainWKPtr" to "WKRetain".

2:21 PM Changeset in webkit [60505] by ap@apple.com
  • 2 edits in trunk/WebKitTools

A real Tiger build fix.

  • DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Enable GCC_OBJC_CALL_CXX_CDTORS for all configurations, not just debug.
2:15 PM Changeset in webkit [60504] by kdecker@apple.com
  • 2 edits in trunk/WebKit/mac

Reviewed by Simon Fraser.

​https://bugs.webkit.org/show_bug.cgi?id=40025
<rdar://problem/8046273> All Flash content crashes after installing CS5 Design Premium.


  • Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView supportsSnapshotting]): Do not support snapshotting Flash 10.1 if the version is less than 10.1.53.60.
1:33 PM Changeset in webkit [60503] by rwlbuis@webkit.org
  • 19 edits
    3 adds in trunk

2010-06-01 Rob Buis <​rwlbuis@gmail.com>

Reviewed by Nikolas Zimmermann.

Large SVG rect with shadow fails to render
​https://bugs.webkit.org/show_bug.cgi?id=38851

Store intermediate shadow calculation in floats to prevent integer overflow.

Test: svg/filters/shadow-on-rect-large.svg

  • rendering/style/SVGRenderStyle.cpp: (WebCore::getSVGShadowExtent): (WebCore::SVGRenderStyle::inflateForShadow):
1:15 PM Changeset in webkit [60502] by jer.noble@apple.com
  • 2 edits in trunk/WebCore

QuickTime 7.6.4 + Safari Nightly = Crash
​https://bugs.webkit.org/show_bug.cgi?id=40019
rdar://problem/8035443

Reviewed by Sam Weinig.

Check the return value of QTCFPropertyListCreateXMLData before calling CFDataGetLength().

  • platform/graphics/win/QTCFDictionary.cpp:

(QTCFDictionaryCreateCopyWithDataCallback):

1:06 PM Changeset in webkit [60501] by rwlbuis@webkit.org
  • 6 edits
    3 adds in trunk

2010-06-01 Rob Buis <​rwlbuis@gmail.com>

Reviewed by Dirk Schulze.

Manipulating SVG element attributes in Javascript does not work as expected
​https://bugs.webkit.org/show_bug.cgi?id=34328

Reset the viewBox to be empty when removing the viewBox attribute.

Test: svg/custom/svg-viewBox-dynamic.html

1:03 PM Changeset in webkit [60500] by jer.noble@apple.com
  • 2 edits in branches/safari-533-branch/WebCore

Rolling back change made on wrong branch.

12:42 PM Changeset in webkit [60499] by jer.noble@apple.com
  • 2 edits in branches/safari-533-branch/WebCore

QuickTime 7.6.4 + Safari Nightly = Crash
​https://bugs.webkit.org/show_bug.cgi?id=40019
rdar://problem/8035443

Reviewed by Sam Weinig.

Check the return value of QTCFPropertyListCreateXMLData before calling CFDataGetLength().

  • platform/graphics/win/QTCFDictionary.cpp:

(QTCFDictionaryCreateCopyWithDataCallback):

12:21 PM Changeset in webkit [60498] by xan@webkit.org
  • 2 edits in trunk/WebKit/gtk

2010-06-01 Xan Lopez <​xlopez@igalia.com>

Reviewed by Gustavo Noronha.

Memory Leak: The main resource of page is not free.
​https://bugs.webkit.org/show_bug.cgi?id=39973

Fix refcount tracking of the main resource. Patch by Genhua Liu.

  • WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::dispatchDidFinishLoading):
12:12 PM Changeset in webkit [60497] by ap@apple.com
  • 2 edits in trunk/WebKitTools

Tiger build fix.

  • DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Enable GCC_OBJC_CALL_CXX_CDTORS.
12:09 PM Changeset in webkit [60496] by Chris Fleizach
  • 2 edits in trunk/WebCore

AX: WebKit doesn't call [super -accessibilityAttributeValue:attribute forParameter:] when it encounters a parameterized attribute that it doesn't handle.
​https://bugs.webkit.org/show_bug.cgi?id=39324

Reviewed by Beth Dakin.

There are some parameters that super handles that are not explicitly returned by the list of the element's attributes.
In those cases, super should handle.

  • accessibility/mac/AccessibilityObjectWrapper.mm:

(-[AccessibilityObjectWrapper accessibilityAttributeValue:forParameter:]):

12:01 PM Changeset in webkit [60495] by eric@webkit.org
  • 2 edits in trunk/WebKit/chromium

2010-06-01 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r60483.
​http://trac.webkit.org/changeset/60483
​https://bugs.webkit.org/show_bug.cgi?id=40013

Breaks Mac and Linux builds (Requested by antonm on #webkit).

  • DEPS:
11:58 AM Changeset in webkit [60494] by hyatt@apple.com
  • 3 edits
    8 adds in trunk

​https://bugs.webkit.org/show_bug.cgi?id=15550, complete implementation of column-span. Add support for nested column
spans. When a column span is nested inside multiple enclosing blocks, the blocks have to be split around the column-span.
We do this using block element continuations, the same kind of solution we employed for blocks inside inlines.

Reviewed by Beth Dakin.

The code for block continuations is very similar to the code for inline continuations. It may be possible to refactor the
code into RenderBoxModelObject so that more of it can be shared, but this first pass avoids that so as not to risk
causing any regressions in core rendering.

Note also that - just as with inline continuations - you can't unsplit block continuations yet. There is no technical limitation
here... the functions just need to be written to handle it.

Added new tests in fast/multicol/span.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::styleDidChange):
(WebCore::RenderBlock::continuationBefore):
(WebCore::RenderBlock::addChildToContinuation):
(WebCore::RenderBlock::containingColumnsBlock):
(WebCore::RenderBlock::clone):
(WebCore::RenderBlock::splitBlocks):
(WebCore::RenderBlock::splitFlow):
(WebCore::RenderBlock::splitAnonymousBlocksAroundChild):
(WebCore::RenderBlock::makeChildrenAnonymousColumnBlocks):
(WebCore::RenderBlock::columnsBlockForSpanningElement):
(WebCore::RenderBlock::addChildIgnoringAnonymousColumnBlocks):
(WebCore::RenderBlock::addChild):
(WebCore::RenderBlock::addChildIgnoringContinuation):
(WebCore::RenderBlock::blockElementContinuation):
(WebCore::RenderBlock::layoutColumns):

  • rendering/RenderBlock.h:
11:51 AM Changeset in webkit [60493] by ap@apple.com
  • 3 edits in trunk/WebCore

Build fix.

Hopefully, touching WebCore.base.exp will actually rebuild the export file.

  • WebCore.Geolocation.exp:
  • WebCore.base.exp:
11:50 AM Changeset in webkit [60492] by dumi@chromium.org
  • 5 edits in trunk

WebCore: Execute void callbacks in the context they were created in.
​https://bugs.webkit.org/show_bug.cgi?id=39145

Reviewed by Adam Barth.

  • bindings/v8/custom/V8CustomVoidCallback.cpp:

(WebCore::V8CustomVoidCallback::V8CustomVoidCallback):
(WebCore::V8CustomVoidCallback::handleEvent):

  • bindings/v8/custom/V8CustomVoidCallback.h:

LayoutTests: storage/transaction-success-callback-isolated-world.html is being fixed.
​https://bugs.webkit.org/show_bug.cgi?id=39145

Reviewed by Adam Barth.

  • platform/chromium/test_expectations.txt:
11:40 AM Changeset in webkit [60491] by xan@webkit.org
  • 3 edits in trunk/WebKit/gtk

2010-06-01 Xan Lopez <​xlopez@igalia.com>

Reviewed by Gustavo Noronha.

Fix-up for previous leak fix, the identifier was not always duped.

  • webkit/webkitprivate.h:
  • webkit/webkitwebview.cpp: (webkit_web_view_add_resource):
11:08 AM Changeset in webkit [60490] by xan@webkit.org
  • 2 edits in trunk/WebKit/gtk

2010-06-01 Xan Lopez <​xlopez@igalia.com>

Reviewed by Gustavo Noronha.

Plug a small leak.

  • WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::assignIdentifierToInitialRequest):
11:04 AM Changeset in webkit [60489] by Martin Robinson
  • 4 edits
    2 adds in trunk

2010-05-12 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] Get more mouse tests passing
​https://bugs.webkit.org/show_bug.cgi?id=39040

Unskip tests that are now passing.

  • platform/gtk/Skipped:

2010-06-01 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] Get more mouse tests passing
​https://bugs.webkit.org/show_bug.cgi?id=39040

Reproduce the logic from the Windows EventSender for mapping
button numbers to GDK button numbers. Move this logic to the
prepareMouseButtonEvent helper.

  • DumpRenderTree/gtk/EventSender.cpp: (prepareMouseButtonEvent): Reproduce Windows logic. (contextClickCallback): Move mapping logic to prepareMouseButtonEvent. (mouseDownCallback): Ditto. (mouseUpCallback): Ditto.
10:48 AM Changeset in webkit [60488] by ap@apple.com
  • 22 edits
    2 adds
    2 deletes in trunk

Reviewed by Sam Weinig.

​https://bugs.webkit.org/show_bug.cgi?id=39434
REGRESSION (r59811): Geolocation callbacks cannot be created

  • DerivedSources.make: Don't append both WebCore.Geolocation.exp and WebCore.ClientBasedGeolocation.exp, they are mutually exclusive.
  • WebCore.Geolocation.exp: Touched to force .exp file rebuild.
  • WebCore.xcodeproj/project.pbxproj: Removed GeolocationService related files.
  • bindings/js/JSGeolocationCustom.cpp: (WebCore::createPositionCallback): Functions defined in JavaScript code no longer inherit from InternalFunction, they inherit from JSFunction. This check is still imperfect, because it's not clear what definition of "function" should really be used, if any - other bindings code never checks callback type. (WebCore::createPositionErrorCallback): Ditto.
  • page/Geolocation.h: Don't include GeolocationService.h unless it's going to be used.
10:46 AM Changeset in webkit [60487] by eric@webkit.org
  • 2 edits in trunk/JavaScriptCore

2010-06-01 Yong Li <​yoli@rim.com>

Reviewed by Darin Adler.

Explicitly use PTHREAD_MUTEX_NORMAL to create pthread mutex.
​https://bugs.webkit.org/show_bug.cgi?id=39893

  • wtf/ThreadingPthreads.cpp: (WTF::Mutex::Mutex):
10:26 AM Changeset in webkit [60486] by eric@webkit.org
  • 2 edits in trunk/JavaScriptCore

2010-06-01 Kwang Yul Seo <​skyul@company100.net>

Reviewed by Xan Lopez.

[GTK] Use DEFINE_STATIC_LOCAL for threadMapMutex and threadMap
​https://bugs.webkit.org/show_bug.cgi?id=39831

Use DEFINE_STATIC_LOCAL for static local variables.

  • wtf/gtk/ThreadingGtk.cpp: (WTF::threadMapMutex): (WTF::threadMap): (WTF::identifierByGthreadHandle):
10:26 AM Changeset in webkit [60485] by Martin Robinson
  • 1 edit in trunk/LayoutTests/ChangeLog

Unreviewed. Fix ChangeLog reordering from my last commit.

10:24 AM Changeset in webkit [60484] by jorlow@chromium.org
  • 15 edits in trunk

2010-06-01 Jeremy Orlow <​jorlow@chromium.org>

Reviewed by Darin Fisher.

IndexedDB cleanup
​https://bugs.webkit.org/show_bug.cgi?id=40007

Remove the exception code parameter since this function can no longer
cause an exception.

  • storage/IDBObjectStoreRequest.idl:
  • storage/IndexedDatabase.h:
  • storage/IndexedDatabaseImpl.cpp: (WebCore::IndexedDatabaseImpl::open):
  • storage/IndexedDatabaseImpl.h:
  • storage/IndexedDatabaseRequest.cpp: (WebCore::IndexedDatabaseRequest::open):
  • storage/IndexedDatabaseRequest.h:
  • storage/IndexedDatabaseRequest.idl:

2010-06-01 Jeremy Orlow <​jorlow@chromium.org>

Reviewed by Darin Fisher.

IndexedDB cleanup
​https://bugs.webkit.org/show_bug.cgi?id=40007

Remove the exception code paramter (that hasn't been used for a while).
Add asserts to default implementations.

  • public/WebIDBDatabase.h: (WebKit::WebIDBDatabase::name): (WebKit::WebIDBDatabase::description): (WebKit::WebIDBDatabase::version): (WebKit::WebIDBDatabase::objectStores):
  • public/WebIndexedDatabase.h: (WebKit::WebIndexedDatabase::open):
  • src/WebIndexedDatabaseImpl.cpp: (WebKit::WebIndexedDatabaseImpl::open):
  • src/WebIndexedDatabaseImpl.h:
10:21 AM Changeset in webkit [60483] by antonm@chromium.org
  • 2 edits in trunk/WebKit/chromium

2010-06-01 Anton Muhin <​antonm@chromium.org>

Reviewed by Dimitri Glazkov.

Rolling Chromium revision to bring recent changes to V8.

  • DEPS:
10:18 AM Changeset in webkit [60482] by Martin Robinson
  • 10 edits
    2 adds in trunk

2010-06-01 Sergio Villar Senin <​svillar@igalia.com>

Unskipping tests. No review necessary.

[GTK] unskip some editing tests that are actually working
​https://bugs.webkit.org/show_bug.cgi?id=39999

  • platform/gtk/Skipped:

2010-06-01 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] Double clicks cause three button press events
​https://bugs.webkit.org/show_bug.cgi?id=38853

Add GOwnPtr wrapper for GdkEvent and expose a setter for
PlatformMouseEvent::m_clickCount.

  • GNUmakefile.am: Add GOwnPtrGtk.{cpp,h} to the sources list.
  • platform/PlatformMouseEvent.h: (WebCore::PlatformMouseEvent::setClickCount): Added.
  • platform/gtk/GOwnPtrGtk.cpp: Added. (WTF::GdkEvent):
  • platform/gtk/GOwnPtrGtk.h: Added.

2010-06-01 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] Double clicks cause three button press events
​https://bugs.webkit.org/show_bug.cgi?id=38853

Handle click counting much like the Windows port. GTK+ only
counts triple-clicks natively, so use GTK+ double-click settings
to count clicks with even larger click counts. Also filter the
extra GDK_BUTTON_PRESS before GDK_{2,3}BUTTON_PRESS events using
gdk_event_peek().

  • webkit/webkitwebview.cpp: (webkit_web_view_button_press_event): Count clicks manually. Filter extra events.

2010-06-01 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] Double clicks cause three button press events
​https://bugs.webkit.org/show_bug.cgi?id=38853

WebKit now filters the extra GDK_BUTTON_PRESS before GDK_2BUTTON_PRESS
and GDK_3BUTTON_PRESS via gdk_event_peek(). Since EventSender bypasses
the GDK event queue entirely, we simply do not send the extra event.

  • DumpRenderTree/gtk/EventSender.cpp: (mouseDownCallback): Do not send extra event. Send GDK_3BUTTON_PRESS appropriately. (dispatchEvent): Properly handle GDK_3BUTTON_PRESS.
10:02 AM Changeset in webkit [60481] by Martin Robinson
  • 2 edits in trunk/LayoutTests

2010-06-01 Sergio Villar Senin <​svillar@igalia.com>

Unskipping tests. No review necessary.

[GTK] unskip some editing tests that are actually working
​https://bugs.webkit.org/show_bug.cgi?id=39999

  • platform/gtk/Skipped:
9:06 AM Changeset in webkit [60480] by Martin Robinson
  • 2 edits in trunk/WebKitTools

2010-06-01 Martin Robinson <​mrobinson@igalia.com>

Not reviewed. Build fix.

Fix GTK+ build caused by a bad merge.

  • DumpRenderTree/gtk/EventSender.cpp: (prepareMouseButtonEvent): Use the GdkEvent union as a pointer here.
8:47 AM Changeset in webkit [60479] by Martin Robinson
  • 2 edits in trunk/WebKitTools

2010-06-01 Martin Robinson <Martin Robinson>

Reviewed by Xan Lopez.

[GTK] Double clicks cause three button press events
​https://bugs.webkit.org/show_bug.cgi?id=38853

Small EventSender cleanups. Consolidate some common code. Style fixes.

  • DumpRenderTree/gtk/EventSender.cpp: (prepareMouseButtonEvent): Added. (contextClickCallback): Use prepareMouseButtonEvent. (mouseDownCallback): Use prepareMouseButtonEvent. (mouseUpCallback): Use prepareMouseButtonEvent. (mouseMoveToCallback): Small style fix.
8:04 AM QtWebKitTriageRoster edited by Csaba Osztrogonác
bbandix <=> Ossy (diff)
7:58 AM Changeset in webkit [60478] by Martin Robinson
  • 4 edits in trunk/WebKitTools

2010-06-01 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] Double clicks cause three button press events
​https://bugs.webkit.org/show_bug.cgi?id=38853

Add rudimentary leapForward support to the GTK+ DRT. leapForward allows a test
to pause for a specified amount of time. It is used in the processing of drag-
-and-drop data as well as to separate distinct mouse double-clicks in some tests.
This patch enables tests that rely on the latter behavior to pass.

  • DumpRenderTree/gtk/DumpRenderTree.cpp: (webViewWindowObjectCleared): Only initialize the EventSender when loading the top frame.
  • DumpRenderTree/gtk/EventSender.cpp: (leapForwardCallback): Add support for adjusting the time offset on leapForward(). (contextClickCallback): Use sendOrQueueEvent. (updateClickCount): Take the time offset into account when counting clicks. (mouseDownCallback): Use sendOrQueueEvent. (getStateFlags): Change down/currentEventButton into buttonCurrentlyDown/lastClickButton. (mouseUpCallback): Use sendOrQueueEvent. (mouseMoveToCallback): Ditto. (mouseWheelToCallback): Ditto. (sendOrQueueEvent): Added. (dispatchEvent): Added. (replaySavedEvents): Pause when an event has a delay and defer to dispatchEvent. (makeEventSender): Only initialize the EventSender when loading the top frame.
  • DumpRenderTree/gtk/EventSender.h: Ditto.
7:52 AM Changeset in webkit [60477] by agl@chromium.org
  • 2 edits in trunk/WebCore

2010-06-01 Adam Langley <​agl@chromium.org>

Reviewed by Eric Seidel.

[chromium] respect the user's embedded bitmap settings on Linux.

We plumbed everything through Skia and Chrome, but forgot to connect
the two wires inside WebCore.

(Note: no layout test because test_shell forces this option off. Also,

the test font which triggers this behaviour is 32MB.)

​https://bugs.webkit.org/show_bug.cgi?id=39894
​http://code.google.com/p/chromium/issues/detail?id=21149

  • platform/graphics/chromium/FontPlatformDataLinux.cpp: (WebCore::FontPlatformData::setupPaint):
7:33 AM Changeset in webkit [60476] by Simon Hausmann
  • 2 edits in trunk/WebCore

[Qt] Fix installation of the QtWebKit module .pri file when building inside of Qt

Reviewed by Laszlo Gombos.

  • WebCore.pro:
6:26 AM Changeset in webkit [60475] by Simon Hausmann
  • 2 edits in trunk/WebCore

[Qt] Fix a QtWebKit.pc corruption problem.
​https://bugs.webkit.org/show_bug.cgi?id=36826

Patch by Jocelyn Turcotte <​jocelyn.turcotte@nokia.com> on 2010-06-01
Reviewed by Simon Hausmann.

The problem occurs while installing QtWebKit from trunk
or a source package.

  • WebCore.pro:
6:24 AM Changeset in webkit [60474] by Simon Hausmann
  • 3 edits
    1 move in trunk

WebCore: [Qt] Fix Symbian package dependencies of apps against QtWebKit when installing into Qt

Reviewed by Laszlo Gombos.

Install the versioning qt_webkit_version.pri into $$[QMAKE_MKSPECS]/modules, which is
where mkspecs/features/qt.prf expects it.

  • WebCore.pro:

WebKit/qt: [Qt] Rename versioning .pri file to what Qt's mkspecs/features/qt.pri expects.

Reviewed by Laszlo Gombos.

  • qt_webkit_version.pri: Renamed from WebKit/qt/qtwebkit_version.pri.
6:12 AM Changeset in webkit [60473] by eric@webkit.org
  • 9 edits in trunk

2010-06-01 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r60470.
​http://trac.webkit.org/changeset/60470
​https://bugs.webkit.org/show_bug.cgi?id=39990

Need to rollout until bot can be updated (Requested by jorlow
on #webkit).

  • bindings/scripts/CodeGeneratorV8.pm:
  • bindings/v8/ScriptController.cpp: (WebCore::ScriptController::namedItemAdded): (WebCore::ScriptController::namedItemRemoved):
  • bindings/v8/V8DOMWindowShell.cpp: (WebCore::V8DOMWindowShell::updateDocumentWrapperCache):
  • bindings/v8/V8DOMWindowShell.h:
  • bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::instantiateV8Object):
  • bindings/v8/custom/V8HTMLDocumentCustom.cpp: (WebCore::V8HTMLDocument::namedPropertyDeleter): (WebCore::V8HTMLDocument::namedPropertyGetter): (WebCore::V8HTMLDocument::indexedPropertyGetter): (WebCore::V8HTMLDocument::allAccessorSetter): (WebCore::toV8):

2010-06-01 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r60470.
​http://trac.webkit.org/changeset/60470
​https://bugs.webkit.org/show_bug.cgi?id=39990

Need to rollout until bot can be updated (Requested by jorlow
on #webkit).

  • DEPS:
5:44 AM Changeset in webkit [60472] by kov@webkit.org
  • 4 edits in trunk/WebKit/gtk

2010-05-31 Gustavo Noronha Silva <​gustavo.noronha@collabora.co.uk>

Reviewed by Xan Lopez.

[GTK] Missing links to documentation of general functions
​https://bugs.webkit.org/show_bug.cgi?id=39964

Add global functions section, and move those functions that are
currently in WebKitWebView's source file to the bottom, along with
the description.

  • docs/webkitgtk-docs.sgml:
  • docs/webkitgtk-sections.txt:
  • webkit/webkitwebview.cpp: (webkit_web_view_get_dom_document): (webkit_get_default_session):
4:59 AM Changeset in webkit [60471] by Martin Robinson
  • 85 edits
    1 delete in trunk

2010-06-01 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] css1/color_and_background/background_attachment.html fails on the 32-bit debug bot
​https://bugs.webkit.org/show_bug.cgi?id=39101

The timing fix changed expected results for many tests, so regenerate
results for these tests.

  • platform/gtk/Skipped: Unskip tests that should be passing now.
  • platform/gtk/css1/basic/class_as_selector-expected.txt:
  • platform/gtk/css1/basic/comments-expected.txt:
  • platform/gtk/css1/basic/containment-expected.txt:
  • platform/gtk/css1/basic/id_as_selector-expected.txt:
  • platform/gtk/css1/basic/inheritance-expected.txt:
  • platform/gtk/css1/box_properties/acid_test-expected.txt: Removed.
  • platform/gtk/css1/box_properties/border-expected.txt:
  • platform/gtk/css1/box_properties/border_bottom-expected.txt:
  • platform/gtk/css1/box_properties/border_bottom_width-expected.txt:
  • platform/gtk/css1/box_properties/border_left-expected.txt:
  • platform/gtk/css1/box_properties/border_left_width-expected.txt:
  • platform/gtk/css1/box_properties/border_right_inline-expected.txt:
  • platform/gtk/css1/box_properties/border_right_width-expected.txt:
  • platform/gtk/css1/box_properties/border_style-expected.txt:
  • platform/gtk/css1/box_properties/border_top-expected.txt:
  • platform/gtk/css1/box_properties/border_top_width-expected.txt:
  • platform/gtk/css1/box_properties/border_width-expected.txt:
  • platform/gtk/css1/box_properties/clear-expected.txt:
  • platform/gtk/css1/box_properties/clear_float-expected.txt:
  • platform/gtk/css1/box_properties/float_elements_in_series-expected.txt:
  • platform/gtk/css1/box_properties/float_margin-expected.txt:
  • platform/gtk/css1/box_properties/float_on_text_elements-expected.txt:
  • platform/gtk/css1/box_properties/height-expected.txt:
  • platform/gtk/css1/box_properties/margin-expected.txt:
  • platform/gtk/css1/box_properties/margin_bottom-expected.txt:
  • platform/gtk/css1/box_properties/margin_inline-expected.txt:
  • platform/gtk/css1/box_properties/margin_left-expected.txt:
  • platform/gtk/css1/box_properties/margin_right-expected.txt:
  • platform/gtk/css1/box_properties/margin_top-expected.txt:
  • platform/gtk/css1/box_properties/padding-expected.txt:
  • platform/gtk/css1/box_properties/padding_bottom-expected.txt:
  • platform/gtk/css1/box_properties/padding_inline-expected.txt:
  • platform/gtk/css1/box_properties/padding_left-expected.txt:
  • platform/gtk/css1/box_properties/padding_right-expected.txt:
  • platform/gtk/css1/box_properties/padding_top-expected.txt:
  • platform/gtk/css1/box_properties/width-expected.txt:
  • platform/gtk/css1/cascade/cascade_order-expected.txt:
  • platform/gtk/css1/classification/display-expected.txt:
  • platform/gtk/css1/classification/list_style_type-expected.txt:
  • platform/gtk/css1/classification/white_space-expected.txt:
  • platform/gtk/css1/color_and_background/background-expected.txt:
  • platform/gtk/css1/color_and_background/background_attachment-expected.txt:
  • platform/gtk/css1/color_and_background/background_position-expected.txt:
  • platform/gtk/css1/color_and_background/background_repeat-expected.txt:
  • platform/gtk/css1/conformance/forward_compatible_parsing-expected.txt:
  • platform/gtk/css1/font_properties/font-expected.txt:
  • platform/gtk/css1/font_properties/font_family-expected.txt:
  • platform/gtk/css1/font_properties/font_size-expected.txt:
  • platform/gtk/css1/font_properties/font_weight-expected.txt:
  • platform/gtk/css1/formatting_model/floating_elements-expected.txt:
  • platform/gtk/css1/formatting_model/height_of_lines-expected.txt:
  • platform/gtk/css1/formatting_model/horizontal_formatting-expected.txt:
  • platform/gtk/css1/formatting_model/inline_elements-expected.txt:
  • platform/gtk/css1/formatting_model/replaced_elements-expected.txt:
  • platform/gtk/css1/formatting_model/vertical_formatting-expected.txt:
  • platform/gtk/css1/pseudo/anchor-expected.txt:
  • platform/gtk/css1/pseudo/firstletter-expected.txt:
  • platform/gtk/css1/pseudo/firstline-expected.txt:
  • platform/gtk/css1/pseudo/multiple_pseudo_elements-expected.txt:
  • platform/gtk/css1/pseudo/pseudo_elements_in_selectors-expected.txt:
  • platform/gtk/css1/text_properties/letter_spacing-expected.txt:
  • platform/gtk/css1/text_properties/line_height-expected.txt:
  • platform/gtk/css1/text_properties/text_decoration-expected.txt:
  • platform/gtk/css1/text_properties/text_indent-expected.txt:
  • platform/gtk/css1/text_properties/text_transform-expected.txt:
  • platform/gtk/css1/text_properties/vertical_align-expected.txt:
  • platform/gtk/css1/text_properties/word_spacing-expected.txt:
  • platform/gtk/css1/units/color_units-expected.txt:
  • platform/gtk/css1/units/length_units-expected.txt:
  • platform/gtk/css1/units/percentage_units-expected.txt:
  • platform/gtk/editing/deleting/delete-line-end-ws-001-expected.txt:
  • platform/gtk/editing/deleting/delete-line-end-ws-002-expected.txt:
  • platform/gtk/fast/multicol/layers-in-multicol-expected.txt:
  • platform/gtk/fast/multicol/layers-split-across-columns-expected.txt:
  • platform/gtk/fast/multicol/nested-columns-expected.txt:
  • platform/gtk/fast/repaint/fixed-child-move-after-scroll-expected.txt:
  • platform/gtk/fast/repaint/fixed-child-of-fixed-move-after-scroll-expected.txt:
  • platform/gtk/fast/repaint/fixed-child-of-transformed-move-after-scroll-expected.txt:
  • platform/gtk/fast/repaint/fixed-move-after-scroll-expected.txt:
  • platform/gtk/fast/repaint/fixed-tranformed-expected.txt:
  • platform/gtk/fast/repaint/repaint-during-scroll-expected.txt:
  • platform/gtk/fast/text/format-control-expected.txt:

2010-06-01 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] css1/color_and_background/background_attachment.html fails on the 32-bit debug bot
​https://bugs.webkit.org/show_bug.cgi?id=39101

Work around timing issues for render tree dumps by pumping the
main loop before doing the dump. Resize events are asynchronous
in GTK+, so sometimes resize requests are still pending when DRT
dumps the tree.

  • DumpRenderTree/gtk/DumpRenderTree.cpp: (dump): Pump the main loop before dumping the render tree.
4:30 AM Changeset in webkit [60470] by eric@webkit.org
  • 8 edits in trunk

2010-06-01 Anton Muhin <​antonm@chromium.org>

Reviewed by Nate Chapin.

[Chromium] get rid of named interceptor on HTMLDocument and introduce/remove accessors when named items get deleted/removed
​https://bugs.webkit.org/show_bug.cgi?id=39877

This patch makes callbacks invoked on named items addition/removal
install API accessors and thus there is no more need in
named and indexed interceptors on HTMLDocument which
speeds up invocation of methods on document.

  • bindings/scripts/CodeGeneratorV8.pm:
  • bindings/v8/ScriptController.cpp: (WebCore::ScriptController::namedItemAdded): (WebCore::ScriptController::namedItemRemoved):
  • bindings/v8/V8DOMWindowShell.cpp: (WebCore::checkDocumentWrapper): (WebCore::V8DOMWindowShell::updateDocumentWrapperCache): (WebCore::getter): (WebCore::V8DOMWindowShell::namedItemAdded): (WebCore::V8DOMWindowShell::namedItemRemoved):
  • bindings/v8/V8DOMWindowShell.h:
  • bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::instantiateV8Object):
  • bindings/v8/custom/V8HTMLDocumentCustom.cpp: (WebCore::V8HTMLDocument::WrapInShadowObject): (WebCore::V8HTMLDocument::GetNamedProperty): (WebCore::V8HTMLDocument::allAccessorSetter): (WebCore::toV8):
2:05 AM Changeset in webkit [60469] by pfeldman@chromium.org
  • 7 edits in trunk/WebKit/chromium

2010-05-31 Pavel Podivilov <​podivilov@chromium.org>

Reviewed by Pavel Feldman.

Chromium: save inspector settings as dictionary, not as string.
​https://bugs.webkit.org/show_bug.cgi?id=32118

  • public/WebView.h:
  • public/WebViewClient.h: (WebKit::WebViewClient::didUpdateInspectorSetting):
  • src/InspectorClientImpl.cpp: (WebKit::InspectorClientImpl::populateSetting): (WebKit::InspectorClientImpl::storeSetting):
  • src/InspectorClientImpl.h:
  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::WebViewImpl): (WebKit::WebViewImpl::inspectorSetting): (WebKit::WebViewImpl::setInspectorSetting):
  • src/WebViewImpl.h:
1:57 AM Changeset in webkit [60468] by eric@webkit.org
  • 3 edits in trunk/JavaScriptCore

2010-06-01 Kent Tamura <​tkent@chromium.org>

Reviewed by Shinichiro Hamaji.

Fix style errors of dtoa
​https://bugs.webkit.org/show_bug.cgi?id=39972

Fix all errors reported by check-webkit-style.

  • wtf/dtoa.cpp:
  • wtf/dtoa.h:
1:55 AM Changeset in webkit [60467] by pfeldman@chromium.org
  • 8 edits
    7 adds in trunk/LayoutTests

2010-06-01 Pavel Feldman <​pfeldman@chromium.org>

Not reviewed: Chromium: rebaseline some svg tests.

  • platform/chromium-linux/svg/W3C-SVG-1.1/filters-light-01-f-expected.checksum:
  • platform/chromium-linux/svg/W3C-SVG-1.1/filters-light-01-f-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/filters-light-04-f-expected.checksum: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/filters-light-04-f-expected.png: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1/filters-light-01-f-expected.checksum:
  • platform/chromium-mac/svg/W3C-SVG-1.1/filters-light-01-f-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/filters-light-04-f-expected.checksum: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1/filters-light-04-f-expected.png: Added.
  • platform/chromium-win/svg/W3C-SVG-1.1/filters-light-01-f-expected.checksum:
  • platform/chromium-win/svg/W3C-SVG-1.1/filters-light-01-f-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/filters-light-04-f-expected.checksum: Added.
  • platform/chromium-win/svg/W3C-SVG-1.1/filters-light-04-f-expected.png: Added.
  • platform/chromium-win/svg/W3C-SVG-1.1/filters-light-04-f-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
12:44 AM QtWebKitTriageRoster edited by Simon Hausmann
(diff)
12:29 AM Changeset in webkit [60466] by zherczeg@webkit.org
  • 7 edits
    5 adds in trunk

WebCore: Make the spot light anti-alias effect look similar to SVG expected values.
​https://bugs.webkit.org/show_bug.cgi?id=39477

Reviewed by Dirk Schulze.

The W3 standard only mention, that the edge of the spotlight should be
anti-aliased but it does not specify how. The provided expected values
gives some hint about their intentions. The algorithm uses a fixed
range, which computed as follows: let a = cos(spot light cutoff range)
the light fades off in the [a-0.016, a] range.

Test: svg/W3C-SVG-1.1/filters-light-04-f.svg
Updated pixel test: svg/W3C-SVG-1.1/filters-light-01-f.svg

  • svg/graphics/filters/SVGLightSource.cpp:

(WebCore::SpotLightSource::initPaintingData):

LayoutTests: Testing the anti-aliasing effect of the spot light edge
​https://bugs.webkit.org/show_bug.cgi?id=39477

Reviewed by Dirk Schulze.

  • platform/gtk/Skipped:
  • platform/mac/svg/W3C-SVG-1.1/filters-light-01-f-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/filters-light-01-f-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/filters-light-04-f-expected.checksum: Added.
  • platform/mac/svg/W3C-SVG-1.1/filters-light-04-f-expected.png: Added.
  • platform/mac/svg/W3C-SVG-1.1/filters-light-04-f-expected.txt: Added.
  • platform/qt/Skipped:
  • svg/W3C-SVG-1.1/filters-light-04-f.png: Added.
  • svg/W3C-SVG-1.1/filters-light-04-f.svg: Added.
12:06 AM Changeset in webkit [60465] by eric@webkit.org
  • 8 edits in trunk

2010-05-31 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Fix default action for EndTagOpenState
​https://bugs.webkit.org/show_bug.cgi?id=39982

Add a test for a bogus end tag to webkit01.dat and update expected
results now that we pass some more tests.

Adding this test revealed a bug in resuming the bogus comment state.
I've left these broken expectations, but I'll fix the bug in a future
patch. (The bug existed prior to this patch, just not the test.)

  • html5lib/resources/webkit01.dat:
  • html5lib/runner-expected-html5.txt:
  • html5lib/webkit-resumer-expected-html5.txt:

2010-05-31 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Fix default action for EndTagOpenState
​https://bugs.webkit.org/show_bug.cgi?id=39982

Add a test for a bogus end tag to webkit01.dat and update expected
results now that we pass some more tests.

Adding this test revealed a bug in resuming the bogus comment state.
I've left these broken expectations, but I'll fix the bug in a future
patch. (The bug existed prior to this patch, just not the test.)

  • html5lib/resources/webkit01.dat:
  • html5lib/runner-expected-html5.txt:
  • html5lib/webkit-resumer-expected-html5.txt:

May 31, 2010:

11:21 PM Changeset in webkit [60464] by jamesr@google.com
  • 4 edits in trunk/WebKit/chromium

2010-05-31 James Robinson <​jamesr@chromium.org>

Reviewed by Darin Fisher.

Expose html5 parser enabled flag in WebSettings
​https://bugs.webkit.org/show_bug.cgi?id=39913

  • public/WebSettings.h:
  • src/WebSettingsImpl.cpp: (WebKit::WebSettingsImpl::setHTML5ParserEnabled):
  • src/WebSettingsImpl.h:
11:13 PM Changeset in webkit [60463] by tkent@chromium.org
  • 18 edits in trunk

2010-05-31 Lyon Chen <​liachen@rim.com>

Reviewed by Kent Tamura.

Enum value FORWARD, BACKWARD, RIGHT, LEFT are causing macro conflicts.
​https://bugs.webkit.org/show_bug.cgi?id=35530

Change enum EAlteration from { MOVE, EXTEND } to { AlterationMove, AlterationExtend } and enum EDirection { FORWARD, BACKWARD, RIGHT, LEFT} to { DirectionForward, DirectionBackward, DirectionRight, DirectionLeft } to avoid macro conflict, and also better coding style conformance.

  • accessibility/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::visiblePositionRangeForLine): (WebCore::AccessibilityRenderObject::doAXRangeForLine):
  • editing/Editor.cpp: (WebCore::Editor::deleteWithDirection): (WebCore::Editor::markMisspellingsAfterTypingToPosition): (WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges):
  • editing/EditorCommand.cpp: (WebCore::executeDeleteBackward): (WebCore::executeDeleteBackwardByDecomposingPreviousCharacter): (WebCore::executeDeleteForward): (WebCore::executeDeleteToBeginningOfLine): (WebCore::executeDeleteToBeginningOfParagraph): (WebCore::executeDeleteToEndOfLine): (WebCore::executeDeleteToEndOfParagraph): (WebCore::executeDeleteWordBackward): (WebCore::executeDeleteWordForward): (WebCore::executeForwardDelete): (WebCore::executeMoveBackward): (WebCore::executeMoveBackwardAndModifySelection): (WebCore::executeMoveDown): (WebCore::executeMoveDownAndModifySelection): (WebCore::executeMoveForward): (WebCore::executeMoveForwardAndModifySelection): (WebCore::executeMoveLeft): (WebCore::executeMoveLeftAndModifySelection): (WebCore::executeMovePageDown): (WebCore::executeMovePageDownAndModifySelection): (WebCore::executeMovePageUp): (WebCore::executeMovePageUpAndModifySelection): (WebCore::executeMoveRight): (WebCore::executeMoveRightAndModifySelection): (WebCore::executeMoveToBeginningOfDocument): (WebCore::executeMoveToBeginningOfDocumentAndModifySelection): (WebCore::executeMoveToBeginningOfLine): (WebCore::executeMoveToBeginningOfLineAndModifySelection): (WebCore::executeMoveToBeginningOfParagraph): (WebCore::executeMoveToBeginningOfParagraphAndModifySelection): (WebCore::executeMoveToBeginningOfSentence): (WebCore::executeMoveToBeginningOfSentenceAndModifySelection): (WebCore::executeMoveToEndOfDocument): (WebCore::executeMoveToEndOfDocumentAndModifySelection): (WebCore::executeMoveToEndOfSentence): (WebCore::executeMoveToEndOfSentenceAndModifySelection): (WebCore::executeMoveToEndOfLine): (WebCore::executeMoveToEndOfLineAndModifySelection): (WebCore::executeMoveToEndOfParagraph): (WebCore::executeMoveToEndOfParagraphAndModifySelection): (WebCore::executeMoveParagraphBackwardAndModifySelection): (WebCore::executeMoveParagraphForwardAndModifySelection): (WebCore::executeMoveUp): (WebCore::executeMoveUpAndModifySelection): (WebCore::executeMoveWordBackward): (WebCore::executeMoveWordBackwardAndModifySelection): (WebCore::executeMoveWordForward): (WebCore::executeMoveWordForwardAndModifySelection): (WebCore::executeMoveWordLeft): (WebCore::executeMoveWordLeftAndModifySelection): (WebCore::executeMoveWordRight): (WebCore::executeMoveWordRightAndModifySelection): (WebCore::executeMoveToLeftEndOfLine): (WebCore::executeMoveToLeftEndOfLineAndModifySelection): (WebCore::executeMoveToRightEndOfLine): (WebCore::executeMoveToRightEndOfLineAndModifySelection):
  • editing/SelectionController.cpp: (WebCore::SelectionController::willBeModified): (WebCore::SelectionController::modify):
  • editing/SelectionController.h: (WebCore::SelectionController::):
  • editing/TypingCommand.cpp: (WebCore::TypingCommand::deleteKeyPressed): (WebCore::TypingCommand::forwardDeleteKeyPressed):
  • page/DOMSelection.cpp: (WebCore::DOMSelection::modify): (WebCore::DOMSelection::deleteFromDocument):
  • page/EventHandler.cpp: (WebCore::EventHandler::handleKeyboardSelectionMovement):

2010-05-31 Lyon Chen <​liachen@rim.com>

Reviewed by Kent Tamura.

Enum value FORWARD, BACKWARD, RIGHT, LEFT are causing macro conflicts.
​https://bugs.webkit.org/show_bug.cgi?id=35530

Change enum EAlteration from { MOVE, EXTEND } to { AlterationMove, AlterationExtend } and enum EDirection { FORWARD, BACKWARD, RIGHT, LEFT} to { DirectionForward, DirectionBackward, DirectionRight, DirectionLeft } to avoid macro conflict, and also better coding style conformance.

  • efl/WebCoreSupport/EditorClientEfl.cpp: (WebCore::EditorClientEfl::handleEditingKeyboardEvent):

2010-05-31 Lyon Chen <​liachen@rim.com>

Reviewed by Kent Tamura.

Enum value FORWARD, BACKWARD, RIGHT, LEFT are causing macro conflicts.
​https://bugs.webkit.org/show_bug.cgi?id=35530

Change enum EAlteration from { MOVE, EXTEND } to { AlterationMove, AlterationExtend } and enum EDirection { FORWARD, BACKWARD, RIGHT, LEFT} to { DirectionForward, DirectionBackward, DirectionRight, DirectionLeft } to avoid macro conflict, and also better coding style conformance.

  • src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::executeCommand):

2010-05-31 Lyon Chen <​liachen@rim.com>

Reviewed by Kent Tamura.

Enum value FORWARD, BACKWARD, RIGHT, LEFT are causing macro conflicts.
​https://bugs.webkit.org/show_bug.cgi?id=35530

Change enum EAlteration from { MOVE, EXTEND } to { AlterationMove, AlterationExtend } and enum EDirection { FORWARD, BACKWARD, RIGHT, LEFT} to { DirectionForward, DirectionBackward, DirectionRight, DirectionLeft } to avoid macro conflict, and also better coding style conformance.

  • WebCoreSupport/EditorClientHaiku.cpp: (WebCore::EditorClientHaiku::handleKeyboardEvent):

2010-05-31 Lyon Chen <​liachen@rim.com>

Reviewed by Kent Tamura.

Enum value FORWARD, BACKWARD, RIGHT, LEFT are causing macro conflicts.
​https://bugs.webkit.org/show_bug.cgi?id=35530

Change enum EAlteration from { MOVE, EXTEND } to { AlterationMove, AlterationExtend } and enum EDirection { FORWARD, BACKWARD, RIGHT, LEFT} to { DirectionForward, DirectionBackward, DirectionRight, DirectionLeft } to avoid macro conflict, and also better coding style conformance.

  • WebCoreSupport/EditorClientQt.cpp: (WebCore::EditorClientQt::handleKeyboardEvent):
10:55 PM Changeset in webkit [60462] by rolandsteiner@chromium.org
  • 1 edit
    6 adds in trunk/LayoutTests

2010-05-31 Roland Steiner <​rolandsteiner@chromium.org>

Unreviewed: land new Chromium baselines to unblock WebKit roll

Bug 39980 - Add Chromium baselines for svg/filters/parent-children-with-same-filter
​https://bugs.webkit.org/show_bug.cgi?id=39980

Add new baselines

  • platform/chromium-linux/svg/filters/parent-children-with-same-filter-expected.checksum: Added.
  • platform/chromium-linux/svg/filters/parent-children-with-same-filter-expected.png: Added.
  • platform/chromium-mac/svg/filters/parent-children-with-same-filter-expected.checksum: Added.
  • platform/chromium-mac/svg/filters/parent-children-with-same-filter-expected.png: Added.
  • platform/chromium-win/svg/filters/parent-children-with-same-filter-expected.checksum: Added.
  • platform/chromium-win/svg/filters/parent-children-with-same-filter-expected.png: Added.
9:50 PM Changeset in webkit [60461] by abarth@webkit.org
  • 5 edits in trunk

2010-05-31 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

REGRESSION(60409): window.onload never fires when using HTML5 parser
​https://bugs.webkit.org/show_bug.cgi?id=39981

  • html/HTML5Tokenizer.cpp: (WebCore::HTML5Tokenizer::finish):
    • The logic was just wrong here. We should only be setting m_wasWaitingOnScriptsDuringFinish if isWaitingForScripts() is true, and we should be calling end() when it is not.

(WebCore::HTML5Tokenizer::resumeParsingAfterScriptExecution):

  • Add another ASSERT to catch cases like this.
  • html/HTML5TreeBuilder.cpp: (WebCore::HTML5TreeBuilder::finished):
    • Add a comment about why we don't need to call m_document->finishedParsing()

2010-05-31 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

REGRESSION(60409): window.onload never fires when using HTML5 parser
​https://bugs.webkit.org/show_bug.cgi?id=39981

Now that we can actually run the tests again we pass 6 more.

  • html5lib/runner-expected-html5.txt:
8:25 PM Changeset in webkit [60460] by rolandsteiner@chromium.org
  • 2 edits in trunk/WebKit/chromium

2010-05-31 Roland Steiner <​rolandsteiner@chromium.org>

Bug 39977 - Missing Chromium bindings for InspectorController methods introduced in r60443
​https://bugs.webkit.org/show_bug.cgi?id=39977

add missing InspectorController JS bindings:

  • getStyleSheet
  • getRuleRangesForStyleSheetId

Tests: inspector/styles-source-offsets.html

  • src/js/InspectorControllerImpl.js: (devtools.InspectorBackendImpl):
7:16 PM Changeset in webkit [60459] by tony@chromium.org
  • 3 edits
    2 adds in trunk

2010-05-31 Tony Chang <​tony@chromium.org>

Reviewed by Dan Bernstein.

REGRESSION (r58665): Infinite recursion in Position::getInlineBoxAndOffset()
​https://bugs.webkit.org/show_bug.cgi?id=39946

  • editing/selection/mixed-editability-12-expected.txt: Added.
  • editing/selection/mixed-editability-12.html: Added.

2010-05-31 Tony Chang <​tony@chromium.org>

Reviewed by Dan Bernstein.

REGRESSION (r58665): Infinite recursion in Position::getInlineBoxAndOffset()
​https://bugs.webkit.org/show_bug.cgi?id=39946

r58665 added an infinite recursion check, but didn't take into consideration recursion between two
Positions. This adds a check for when
downstreamIgnoringEditingBoundaries(p1) == p2 and upstreamIgnoringEditingBoundaries(p2) == p1

Test: editing/selection/mixed-editability-12.html

  • dom/Position.cpp: (WebCore::Position::getInlineBoxAndOffset):
6:23 PM Changeset in webkit [60458] by weinig@apple.com
  • 15 edits
    11 adds in trunk

Fix canvas.toDataURL(type, quality, ...) to let it support quality parameter.
And implement it in Qt port.
​https://bugs.webkit.org/show_bug.cgi?id=37304

Patch by Leo Yang <​leo.yang@torchmobile.com.cn> on 2010-05-31
Reviewed by George Staikos.

WebCore:

Tests: platform/qt/fast/canvas/toDataURL-jpeg-alpha.html

platform/qt/fast/canvas/toDataURL-jpeg-primarycolors.html
platform/qt/fast/canvas/toDataURL-jpeg-quality-basic.html
platform/qt/fast/canvas/toDataURL-jpeg-quality-notnumber.html
platform/qt/fast/canvas/toDataURL-jpeg-quality-outsiderange.html

  • bindings/js/JSHTMLCanvasElementCustom.cpp:

(WebCore::JSHTMLCanvasElement::toDataURL):

  • bindings/v8/custom/V8HTMLCanvasElementCustom.cpp:

(WebCore::V8HTMLCanvasElement::toDataURLCallback):

  • dom/CanvasSurface.cpp:

(WebCore::CanvasSurface::toDataURL):

  • dom/CanvasSurface.h:

(WebCore::CanvasSurface::toDataURL):

  • html/HTMLCanvasElement.idl:
  • platform/graphics/ImageBuffer.h:
  • platform/graphics/cairo/ImageBufferCairo.cpp:

(WebCore::ImageBuffer::toDataURL):

  • platform/graphics/cg/ImageBufferCG.cpp:

(WebCore::ImageBuffer::toDataURL):

  • platform/graphics/haiku/ImageBufferHaiku.cpp:

(WebCore::ImageBuffer::toDataURL):

  • platform/graphics/qt/ImageBufferQt.cpp:

(WebCore::ImageBuffer::toDataURL):

  • platform/graphics/skia/ImageBufferSkia.cpp:

(WebCore::ImageBuffer::toDataURL):

  • platform/graphics/wince/ImageBufferWince.cpp:

(WebCore::ImageBuffer::toDataURL):

  • platform/graphics/wx/ImageBufferWx.cpp:

(WebCore::ImageBuffer::toDataURL):

LayoutTests:

  • platform/qt/fast/canvas/toDataURL-jpeg-alpha-expected.txt: Added.
  • platform/qt/fast/canvas/toDataURL-jpeg-alpha.html: Added.
  • platform/qt/fast/canvas/toDataURL-jpeg-primarycolors-expected.txt: Added.
  • platform/qt/fast/canvas/toDataURL-jpeg-primarycolors.html: Added.
  • platform/qt/fast/canvas/toDataURL-jpeg-quality-basic-expected.txt: Added.
  • platform/qt/fast/canvas/toDataURL-jpeg-quality-basic.html: Added.
  • platform/qt/fast/canvas/toDataURL-jpeg-quality-notnumber-expected.txt: Added.
  • platform/qt/fast/canvas/toDataURL-jpeg-quality-notnumber.html: Added.
  • platform/qt/fast/canvas/toDataURL-jpeg-quality-outsiderange-expected.txt: Added.
  • platform/qt/fast/canvas/toDataURL-jpeg-quality-outsiderange.html: Added.
  • platform/qt/fast/canvas/toDataURL-jpeg.js: Added.
6:21 PM Changeset in webkit [60457] by tkent@chromium.org
  • 2 edits in trunk/WebKit/chromium

2010-05-31 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r60456.
​http://trac.webkit.org/changeset/60456
​https://bugs.webkit.org/show_bug.cgi?id=39974

Broke Chromium Linux/Max build (Requested by tkent on
#webkit).

  • DEPS:
5:44 PM Changeset in webkit [60456] by tkent@chromium.org
  • 2 edits in trunk/WebKit/chromium

2010-05-31 Kent Tamura <​tkent@chromium.org>

Reviewed by Dimitri Glazkov.

[DRT/Chromium] Checking out lighttpd
​https://bugs.webkit.org/show_bug.cgi?id=39948

  • Checking out lighttpd only on Windows. It is used by new-run-webkit-tests.
  • Update Chromium revision to use Windows resource query code
  • DEPS:
5:42 PM Changeset in webkit [60455] by tkent@chromium.org
  • 2 edits in trunk/WebKitTools

2010-05-31 Kent Tamura <​tkent@chromium.org>

Reviewed by Dimitri Glazkov.

[DRT/Chromium] Fix crash of a test after another test with multiple windows
​https://bugs.webkit.org/show_bug.cgi?id=39942

If a test opens multiple windows, focuses on non-main window, and
the focused window is closed, TestShell::m_focusedWidget points a
deleted object.

  • DumpRenderTree/chromium/TestShell.cpp: (TestShell::closeWindow): Clear m_focusedWidget.
3:58 PM Changeset in webkit [60454] by eric@webkit.org
  • 13 edits
    2 adds in trunk

2010-05-31 Lucas De Marchi <​lucas.demarchi@profusion.mobi>

Reviewed by Kenneth Rohde Christiansen.

[EFL] Add Context Menu implementation
​https://bugs.webkit.org/show_bug.cgi?id=39821

  • platform/ContextMenu.h: add port-specific attributes.
  • platform/ContextMenuItem.h: create PlatformMenuItemDescription as in other ports (WebCore::PlatformMenuItemDescription::PlatformMenuItemDescription):
  • platform/efl/ContextMenuEfl.cpp:implement needed methods for this port. (WebCore::ContextMenu::ContextMenu): (WebCore::ContextMenu::~ContextMenu): (WebCore::ContextMenu::appendItem): (WebCore::ContextMenu::setPlatformDescription): (WebCore::ContextMenu::releasePlatformDescription):
  • platform/efl/ContextMenuItemEfl.cpp: implement needed methods for this port. (WebCore::ContextMenuItem::ContextMenuItem): (WebCore::ContextMenuItem::~ContextMenuItem): (WebCore::ContextMenuItem::releasePlatformDescription): (WebCore::ContextMenuItem::type): (WebCore::ContextMenuItem::setType): (WebCore::ContextMenuItem::action): (WebCore::ContextMenuItem::setAction): (WebCore::ContextMenuItem::title): (WebCore::ContextMenuItem::setTitle): (WebCore::ContextMenuItem::platformSubMenu): (WebCore::ContextMenuItem::setSubMenu): (WebCore::ContextMenuItem::checked): (WebCore::ContextMenuItem::setChecked): (WebCore::ContextMenuItem::enabled): (WebCore::ContextMenuItem::setEnabled):

2010-05-31 Lucas De Marchi <​lucas.demarchi@profusion.mobi>

Reviewed by Kenneth Rohde Christiansen.

[EFL] Add Context Menu implementation
​https://bugs.webkit.org/show_bug.cgi?id=39821

  • CMakeListsEfl.txt: add context menu files.
  • efl/WebCoreSupport/ContextMenuClientEfl.cpp: (WebCore::ContextMenuClientEfl::getCustomMenuFromDefaultItems): (WebCore::ContextMenuClientEfl::newPlatformDescription): (WebCore::ContextMenuClientEfl::freePlatformDescription): (WebCore::ContextMenuClientEfl::appendItem): (WebCore::ContextMenuClientEfl::show):
  • efl/WebCoreSupport/ContextMenuClientEfl.h:
  • efl/ewk/EWebKit.h:
  • efl/ewk/ewk_contextmenu.cpp: Added. Implement the API used by browser for manipulating context menus. (ewk_context_menu_ref): (ewk_context_menu_unref): (ewk_context_menu_destroy): (ewk_context_menu_item_list_get): (ewk_context_menu_item_new): (ewk_context_menu_item_select): (ewk_context_menu_item_free): (ewk_context_menu_item_type_get): (ewk_context_menu_item_type_set): (ewk_context_menu_item_action_get): (ewk_context_menu_item_action_set): (ewk_context_menu_item_title_get): (ewk_context_menu_item_title_set): (ewk_context_menu_item_checked_get): (ewk_context_menu_item_checked_set): (ewk_context_menu_item_enabled_get): (ewk_context_menu_item_enabled_set): (ewk_context_menu_new): (ewk_context_menu_free): (ewk_context_menu_item_append): (ewk_context_menu_custom_get): (ewk_context_menu_show):
  • efl/ewk/ewk_contextmenu.h: Added.
  • efl/ewk/ewk_private.h:
  • efl/ewk/ewk_view.cpp: (ewk_view_context_menu_forward_event): inform browser a new context menu was created. (ewk_view_exceeded_database_quota): small fix to previous changed function.
  • efl/ewk/ewk_view.h:
3:40 PM Changeset in webkit [60453] by eric@webkit.org
  • 27 edits
    2 deletes in trunk/LayoutTests

2010-05-31 Stephen White <​senorblanco@chromium.org>

Reviewed by Dimitri Glazkov.

New Chromium Win+Linux baselines for background image resize layout tests.
​https://bugs.webkit.org/show_bug.cgi?id=38686

  • platform/chromium-linux/fast/backgrounds/size/backgroundSize15-expected.checksum:
  • platform/chromium-linux/fast/backgrounds/size/backgroundSize15-expected.png:
  • platform/chromium-linux/fast/backgrounds/size/contain-and-cover-expected.checksum:
  • platform/chromium-linux/fast/backgrounds/size/contain-and-cover-expected.png:
  • platform/chromium-linux/fast/borders/svg-as-border-image-expected.checksum:
  • platform/chromium-linux/fast/repaint/backgroundSizeRepaint-expected.checksum:
  • platform/chromium-linux/fast/repaint/backgroundSizeRepaint-expected.png: Removed.
  • platform/chromium-linux/scrollbars/listbox-scrollbar-combinations-expected.checksum:
  • platform/chromium-linux/scrollbars/listbox-scrollbar-combinations-expected.png: Removed.
  • platform/chromium-linux/scrollbars/overflow-scrollbar-combinations-expected.checksum:
  • platform/chromium-linux/scrollbars/overflow-scrollbar-combinations-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/coords-viewattr-02-b-expected.checksum:
  • platform/chromium-linux/svg/W3C-SVG-1.1/coords-viewattr-02-b-expected.png:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize15-expected.checksum:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize15-expected.png:
  • platform/chromium-win/fast/backgrounds/size/contain-and-cover-expected.checksum:
  • platform/chromium-win/fast/backgrounds/size/contain-and-cover-expected.png:
  • platform/chromium-win/fast/borders/svg-as-border-image-expected.checksum:
  • platform/chromium-win/fast/borders/svg-as-border-image-expected.png:
  • platform/chromium-win/fast/repaint/backgroundSizeRepaint-expected.checksum:
  • platform/chromium-win/fast/repaint/backgroundSizeRepaint-expected.png:
  • platform/chromium-win/scrollbars/listbox-scrollbar-combinations-expected.checksum:
  • platform/chromium-win/scrollbars/listbox-scrollbar-combinations-expected.png:
  • platform/chromium-win/scrollbars/overflow-scrollbar-combinations-expected.checksum:
  • platform/chromium-win/scrollbars/overflow-scrollbar-combinations-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/coords-viewattr-02-b-expected.checksum:
  • platform/chromium-win/svg/W3C-SVG-1.1/coords-viewattr-02-b-expected.png:
  • platform/chromium/test_expectations.txt:
3:28 PM Changeset in webkit [60452] by eric@webkit.org
  • 6 edits
    2 adds in trunk/WebCore

2010-05-31 Ilya Tikhonovsky <​loislo@chromium.org>

Reviewed by Pavel Feldman.

WebInspector: Classes for native serialization to JSON were implemented.
​https://bugs.webkit.org/show_bug.cgi?id=34204

  • GNUmakefile.am:
  • WebCore.Inspector.exp:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • inspector/InspectorValues.cpp: Added. (WebCore::escapeChar): (WebCore::doubleQuoteString): (WebCore::InspectorBaseValue::toJSONString): (WebCore::InspectorBaseValue::writeJSON): (WebCore::InspectorValue::writeJSON): (WebCore::InspectorString::writeJSON): (WebCore::InspectorObject::writeJSON): (WebCore::InspectorArray::writeJSON):
  • inspector/InspectorValues.h: Added. (WebCore::InspectorBaseValue::InspectorBaseValue): (WebCore::InspectorBaseValue::~InspectorBaseValue): (WebCore::InspectorBaseValue::null): (WebCore::InspectorBaseValue::): (WebCore::InspectorBaseValue::type): (WebCore::InspectorValue::create): (WebCore::InspectorValue::InspectorValue): (WebCore::InspectorValue::): (WebCore::InspectorString::create): (WebCore::InspectorString::InspectorString): (WebCore::InspectorObject::create): (WebCore::InspectorObject::~InspectorObject): (WebCore::InspectorObject::InspectorObject): (WebCore::InspectorArray::create): (WebCore::InspectorArray::~InspectorArray): (WebCore::InspectorArray::length): (WebCore::InspectorArray::InspectorArray): (WebCore::InspectorObject::setBool): (WebCore::InspectorObject::setNumber): (WebCore::InspectorObject::setString): (WebCore::InspectorObject::set): (WebCore::InspectorArray::pushBool): (WebCore::InspectorArray::pushNumber): (WebCore::InspectorArray::pushString): (WebCore::InspectorArray::push):
3:16 PM Changeset in webkit [60451] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-05-31 Olivier Goffart <​olivier.goffart@nokia.com>

Reviewed by Oliver Hunt.

[PATCH] compilation error with clang in JSDOMBinding.h
​https://bugs.webkit.org/show_bug.cgi?id=39945

JSNode is only forward declared at this point. And since neither
"wrapper" nor JSValue are type-dependent. Compilers should report errors
at the first compilation pass.

The fix is to move the conversion the line above, as the call to the
function getCachedDOMNodeWrapper is type-dependent, the conversion will
happen at template-instantiation time.

See also ​http://llvm.org/bugs/show_bug.cgi?id=7244

  • bindings/js/JSDOMBinding.h: (WebCore::getDOMNodeWrapper):
12:46 PM Changeset in webkit [60450] by pfeldman@chromium.org
  • 13 edits
    1 add in trunk/WebCore

2010-05-31 Pavel Podivilov <​podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Moved breakpoints add/remove logic to the BreakpointManager.

​https://bugs.webkit.org/show_bug.cgi?id=14190

  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/front-end/Breakpoint.js:
  • inspector/front-end/BreakpointManager.js: Added.
  • inspector/front-end/BreakpointsSidebarPane.js: (WebInspector.BreakpointsSidebarPane): (WebInspector.BreakpointsSidebarPane.prototype.reset): (WebInspector.BreakpointsSidebarPane.prototype._breakpointAdded): (WebInspector.BreakpointsSidebarPane.prototype._breakpointRemoved): (WebInspector.BreakpointsSidebarPane.prototype._breakpointEnableChanged):
  • inspector/front-end/Object.js: (WebInspector.Object.prototype.dispatchEventToListeners):
  • inspector/front-end/ScriptView.js: (WebInspector.ScriptView.prototype._addBreakpoint):
  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel): (WebInspector.ScriptsPanel.prototype._breakpointAdded): (WebInspector.ScriptsPanel.prototype._breakpointRemoved): (WebInspector.ScriptsPanel.prototype.editScriptSource.mycallback): (WebInspector.ScriptsPanel.prototype.editScriptSource): (WebInspector.ScriptsPanel.prototype._showScriptOrResource):
  • inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype._contextMenu):
  • inspector/front-end/SourceView.js: (WebInspector.SourceView.prototype._addBreakpoint): (WebInspector.SourceView.prototype._removeBreakpoint):
  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/inspector.html:
  • inspector/front-end/inspector.js: (WebInspector.loaded): (WebInspector.restoredBreakpoint): (WebInspector.reset):
11:46 AM Changeset in webkit [60449] by apavlov@chromium.org
  • 4 edits in trunk/WebCore

2010-05-31 Alexander Pavlov <​apavlov@chromium.org>

Unreviewed, build fix.

Add references to inspector/front-end/TabbedPane.js wherever applicable.

  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/front-end/WebKit.qrc:
11:06 AM Changeset in webkit [60448] by apavlov@chromium.org
  • 1 edit
    1 add in trunk/WebCore

2010-05-31 Alexander Pavlov <​apavlov@chromium.org>

Unreviewed, add a file not added in r60445.

  • inspector/front-end/TabbedPane.js: Added
10:31 AM Changeset in webkit [60447] by Martin Robinson
  • 4 edits
    1 add in trunk

2010-05-31 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Gustavo Noronha Silva.

[GTK] Text copied from a WebView cannot be pasted into gnome-terminal
​https://bugs.webkit.org/show_bug.cgi?id=39827

Switch all methods in Pasteboard to use the PasteboardHelper + DataObjectGtk
approach used in other parts of WebKit GTK+.

  • platform/gtk/PasteboardGtk.cpp: (WebCore::Pasteboard::writeSelection): Switch to using PasteboardHelper. (WebCore::Pasteboard::writePlainText): Ditto. (WebCore::Pasteboard::writeURL): Ditto. (WebCore::Pasteboard::writeImage): Ditto. (WebCore::Pasteboard::clear): Small cleanup. (WebCore::Pasteboard::documentFragment): Switch to using PasteboardHelper. (WebCore::Pasteboard::plainText): Ditto.

2010-05-31 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Gustavo Noronha Silva.

[GTK] Text copied from a WebView cannot be pasted into gnome-terminal
​https://bugs.webkit.org/show_bug.cgi?id=39827

Add a test to prevent regressions for this issue.

  • tests/testcopyandpaste.c: Added. (test_info_new): (test_info_destroy): (copy_and_paste_fixture_setup): (copy_and_paste_fixture_teardown): (load_status_cb): (map_event_cb): (test_copy_and_paste): (main):
10:23 AM Changeset in webkit [60446] by Darin Adler
  • 3 edits in trunk/WebCore

Updated bindings test results for change in JavaScript host calling convention change
from 2 days ago.

  • bindings/scripts/test/JS/JSTestObj.cpp: Regenerated and inspected to see that the new

result is correct.

  • bindings/scripts/test/JS/JSTestObj.h: Ditto.
10:18 AM Changeset in webkit [60445] by apavlov@chromium.org
  • 5 edits in trunk/WebCore

2010-05-31 Alexander Pavlov <​apavlov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Implement additional tabs support in ResourceView
​https://bugs.webkit.org/show_bug.cgi?id=39822

  • inspector/front-end/ResourceView.js: (WebInspector.ResourceView): (WebInspector.ResourceView.prototype._selectHeadersTab): (WebInspector.ResourceView.prototype._innerSelectContentTab):
  • inspector/front-end/SourceView.js: (WebInspector.SourceView.prototype.show): (WebInspector.SourceView.prototype.hide): (WebInspector.SourceView.prototype.resize): (WebInspector.SourceView.prototype.updateLocalContent): (WebInspector.SourceView.prototype.selectLocalContentTab):
  • inspector/front-end/TabbedPane.js: Added. (WebInspector.TabbedPane): (WebInspector.TabbedPane.prototype.appendTab): (WebInspector.TabbedPane.prototype.tabObjectForId): (WebInspector.TabbedPane.prototype.hideTab): (WebInspector.TabbedPane.prototype.selectTabById):
  • inspector/front-end/TextViewer.js: (WebInspector.TextViewer.prototype._getSelection):
  • inspector/front-end/inspector.html:
9:51 AM Changeset in webkit [60444] by dbates@webkit.org
  • 3 edits in trunk

2010-05-31 Daniel Bates <​dbates@rim.com>

Unreviewed, add change log entries for change-set 60419 <​http://trac.webkit.org/changeset/60419>
and change-set 60420 <​http://trac.webkit.org/changeset/60420>.

I inadvertently didn't update the change log files when I committed
change-set 60419 and change-set 60420

9:45 AM Changeset in webkit [60443] by apavlov@chromium.org
  • 14 edits
    2 adds in trunk

2010-05-31 Alexander Pavlov <​apavlov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Implement retrieval of CSS stylesheets for source editing
​https://bugs.webkit.org/show_bug.cgi?id=39833

Test: inspector/styles-source-offsets.html

WebCore:

  • css/CSSParser.cpp: (WebCore::CSSParser::CSSParser): (WebCore::CSSParser::parseSheet): (WebCore::CSSParser::createStyleRule):
  • css/CSSParser.h:
  • inspector/InspectorBackend.cpp: (WebCore::InspectorBackend::getStyleSheet): (WebCore::InspectorBackend::getRuleRangesForStyleSheetId):
  • inspector/InspectorBackend.h:
  • inspector/InspectorBackend.idl:
  • inspector/InspectorCSSStore.cpp: (WebCore::InspectorCSSStore::getRuleRangesForStyleSheet): (WebCore::InspectorCSSStore::asCSSStyleRule): (WebCore::InspectorCSSStore::styleSheetForId):
  • inspector/InspectorCSSStore.h:
  • inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::getStyleSheet): (WebCore::InspectorDOMAgent::getRuleRangesForStyleSheetId): (WebCore::InspectorDOMAgent::buildObjectForStyle): (WebCore::InspectorDOMAgent::populateObjectWithStyleProperties): (WebCore::InspectorDOMAgent::buildObjectForStyleSheet): (WebCore::InspectorDOMAgent::buildObjectForRule): (WebCore::InspectorDOMAgent::getParentStyleSheet):
  • inspector/InspectorDOMAgent.h:
  • inspector/InspectorFrontend.cpp: (WebCore::InspectorFrontend::didGetStyleSheet):
  • inspector/InspectorFrontend.h:
  • inspector/front-end/DOMAgent.js: (WebInspector.CSSStyleDeclaration):

LayoutTests:

  • inspector/styles-source-offsets-expected.txt: Added.
  • inspector/styles-source-offsets.html: Added.
9:36 AM Changeset in webkit [60442] by Philippe Normand
  • 2 edits in trunk/WebCore

2010-05-31 Philippe Normand <​pnormand@igalia.com>

Reviewed by Xan Lopez.

[GStreamer] float variables misused
​https://bugs.webkit.org/show_bug.cgi?id=38842

Use 0.0f for float variables instead of 0.0. Also added some
missing casts around GST_SECOND.

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: (WebCore::playbackPosition): (WebCore::MediaPlayerPrivateGStreamer::duration): (WebCore::MediaPlayerPrivateGStreamer::currentTime): (WebCore::MediaPlayerPrivateGStreamer::seek): (WebCore::MediaPlayerPrivateGStreamer::naturalSize): (WebCore::MediaPlayerPrivateGStreamer::setRate): (WebCore::MediaPlayerPrivateGStreamer::maxTimeSeekable): (WebCore::MediaPlayerPrivateGStreamer::maxTimeLoaded): (WebCore::MediaPlayerPrivateGStreamer::totalBytes):
9:12 AM Changeset in webkit [60441] by steveblock@google.com
  • 6 edits
    3 deletes in trunk

Unreviewed, rolling out r60069.
​http://trac.webkit.org/changeset/60069
​https://bugs.webkit.org/show_bug.cgi?id=39288

Roll out r60069 while the need for Geolocation::stop() is
investigated.

WebCore:

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::stopLoading):

  • page/Geolocation.cpp:

(WebCore::Geolocation::disconnectFrame):

  • page/Geolocation.h:

LayoutTests:

  • fast/dom/Geolocation/ongoing-request-leak-expected.txt: Removed.
  • fast/dom/Geolocation/ongoing-request-leak.html: Removed.
  • fast/dom/Geolocation/script-tests/ongoing-request-leak.js: Removed.
  • platform/gtk/Skipped:
9:04 AM Changeset in webkit [60440] by eric@webkit.org
  • 3 edits in trunk/WebCore

2010-05-31 Olivier Tilloy <​olivier@tilloy.net>

Reviewed by Gustavo Noronha Silva.

[Gtk] Implement RenderThemeGtk::systemColor to apply the correct colors
from the current GTK theme.
​https://bugs.webkit.org/show_bug.cgi?id=37779

  • platform/gtk/RenderThemeGtk.cpp: (WebCore::RenderThemeGtk::RenderThemeGtk): (WebCore::RenderThemeGtk::systemColor): (WebCore::RenderThemeGtk::gtkButton):
  • platform/gtk/RenderThemeGtk.h:
8:25 AM Changeset in webkit [60439] by krit@webkit.org
  • 4 edits
    4 adds in trunk

2010-05-31 Dirk Schulze <​krit@webkit.org>

Reviewed by Nikolas Zimmermann.

SVG Filter: Crash if parent and child elements use the same filter
​https://bugs.webkit.org/show_bug.cgi?id=39536

If a parent and a child used the same filter, the temporary saved
context reference got overwritten by the child. The reference is
stored in FilterData now. FilterData depends to the target object
and avoids overwriting any reference.

Test: svg/filters/parent-children-with-same-filter.svg

  • rendering/RenderSVGResourceFilter.cpp: (WebCore::RenderSVGResourceFilter::RenderSVGResourceFilter): (WebCore::RenderSVGResourceFilter::applyResource): (WebCore::RenderSVGResourceFilter::postApplyResource):
  • rendering/RenderSVGResourceFilter.h:

2010-05-31 Dirk Schulze <​krit@webkit.org>

Reviewed by Nikolas Zimmermann.

SVG Filter: Crash if parent and child elements use the same filter
​https://bugs.webkit.org/show_bug.cgi?id=39536

Check, that parent and child nodes can take the same filter without
crashing webkit.

  • platform/mac/svg/filters/parent-children-with-same-filter-expected.checksum: Added.
  • platform/mac/svg/filters/parent-children-with-same-filter-expected.png: Added.
  • platform/mac/svg/filters/parent-children-with-same-filter-expected.txt: Added.
  • svg/filters/parent-children-with-same-filter.svg: Added.
8:12 AM Changeset in webkit [60438] by xan@webkit.org
  • 2 edits in trunk/WebCore

2010-05-31 Xan Lopez <​xlopez@igalia.com>

Reviewed by Gustavo Noronha.

Fix all compiler warnings.

  • plugins/gtk/gtk2xtbin.c: (xt_event_dispatch): (gtk_xtbin_get_type): (gtk_xtbin_set_position): (xt_add_focus_listener): (xt_remove_focus_listener):
8:10 AM Changeset in webkit [60437] by xan@webkit.org
  • 2 edits in trunk

2010-05-31 Xan Lopez <​xlopez@igalia.com>

Reviewed by Gustavo Noronha.

Copy the NEWS file to the toplevel when creating the release
tarballs, otherwise it's a bit hard to find.

  • GNUmakefile.am:
7:36 AM Changeset in webkit [60436] by yurys@chromium.org
  • 7 edits in trunk/WebKit/chromium

2010-05-31 Yury Semikhatsky <​yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: allow hiding Scripts panel from Chromium code. This
is needed to support v8 debugging protocol which has an implementation
that conflicts with debugger provided by the inspector.
​https://bugs.webkit.org/show_bug.cgi?id=39952

  • public/WebDevToolsAgentClient.h: (WebKit::WebDevToolsAgentClient::exposeV8DebuggerProtocol):
  • public/WebDevToolsFrontendClient.h: (WebKit::WebDevToolsFrontendClient::WebDevToolsFrontendClient): (WebKit::WebDevToolsFrontendClient::sendMessageToAgent): (WebKit::WebDevToolsFrontendClient::sendDebuggerCommandToAgent): (WebKit::WebDevToolsFrontendClient::sendDebuggerPauseScript): (WebKit::WebDevToolsFrontendClient::activateWindow): (WebKit::WebDevToolsFrontendClient::closeWindow): (WebKit::WebDevToolsFrontendClient::requestDockWindow): (WebKit::WebDevToolsFrontendClient::requestUndockWindow): (WebKit::WebDevToolsFrontendClient::hideScriptsPanel):
  • src/DebuggerAgentManager.cpp: (WebKit::DebuggerAgentManager::debugAttach): (WebKit::DebuggerAgentManager::debugDetach): (WebKit::DebuggerAgentManager::setExposeV8DebuggerProtocol):
  • src/DebuggerAgentManager.h:
  • src/InspectorFrontendClientImpl.cpp: (WebKit::InspectorFrontendClientImpl::hiddenPanels):
  • src/WebDevToolsAgentImpl.cpp: (WebKit::WebDevToolsAgentImpl::WebDevToolsAgentImpl): (WebKit::WebDevToolsAgentImpl::attach):
6:52 AM Changeset in webkit [60435] by Simon Hausmann
  • 5 edits in trunk

[Qt] Escape backslashes in the .pro files

Patch by Oswald Buddenhagen <​oswald.buddenhagen@nokia.com> on 2010-05-31
Reviewed by Simon Hausmann.

qmake in Qt 4.7 warns about unescaped backspaces and deprecates them.

WebCore:

  • WebCore.pro:

WebKit/qt:

  • Api/DerivedSources.pro:
  • docs/docs.pri:
6:34 AM Changeset in webkit [60434] by eric@webkit.org
  • 3 edits in trunk/WebCore

2010-05-31 Anton Muhin <​antonm@chromium.org>

Reviewed by Darin Adler.

Make NodeList getters take AtomicString instead of plain String
​https://bugs.webkit.org/show_bug.cgi?id=39892

Those methods turn String into AtomicString later. And this conversion
is faster if underlying string is already atomic.
That buys small (~2-3%) speed up for Chromium on Dromaeo DOM Core.
I don't know if Safari benefits from it.

  • dom/Node.cpp: (WebCore::Node::getElementsByTagName): (WebCore::Node::getElementsByTagNameNS):
  • dom/Node.h:
6:08 AM QtWebKitBackportingFixes edited by Simon Hausmann
(diff)
1:05 AM Changeset in webkit [60433] by rolandsteiner@chromium.org
  • 2 edits in trunk/LayoutTests

2010-05-31 Roland Steiner <​rolandsteiner@chromium.org>

Unreviewed: update Chromium expectations for html5lib/runner.html

Update the Chromium version of runner-expected.txt after r60430

  • platform/chromium/html5lib/runner-expected.txt:
12:16 AM Changeset in webkit [60432] by eric@webkit.org
  • 4 edits in trunk/LayoutTests

2010-05-31 Adam Barth <​abarth@webkit.org>

Reviewed by Darin Adler.

Accessibility tests shouldn't rely on crazy <title> parsing
​https://bugs.webkit.org/show_bug.cgi?id=39940

We have a separate test for crazy <title> parsing already in
fast/tokenizer. Also, this patch makes these tests pass with the HTML5
parser (and run in Firefox).

  • accessibility/image-link-inline-cont.html:
  • accessibility/image-link.html:
  • accessibility/inline-continuations.html:
Note: See TracTimeline for information about the timeline view.