Timeline
Jun 3, 2010:
- 11:35 PM Changeset in webkit [60658] by
-
- 5 edits in trunk/WebCore
2010-06-03 Abhishek Arya <inferno@chromium.org>
Reviewed by Eric Carlson.
Fix a crash when trying to use an invalid media src url by
moving the isValid url checks to a central location in
isSafeToLoadURL function. Also added an empty string check
in DocumentLoader::didTellClientAboutLoad.
Test: media/invalid-media-url-crash.html
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::isSafeToLoadURL): (WebCore::HTMLMediaElement::selectNextSourceChild): (WebCore::HTMLMediaElement::getPluginProxyParams):
- loader/DocumentLoader.h: (WebCore::DocumentLoader::didTellClientAboutLoad):
- 11:16 PM Changeset in webkit [60657] by
-
- 6 edits2 adds in trunk
2010-06-03 Abhishek Arya <inferno@chromium.org>
Reviewed by Eric Carlson.
Tests that invalid media src url does not result in crash.
- media/invalid-media-url-crash-expected.txt: Added.
- media/invalid-media-url-crash.html: Added.
- platform/gtk/Skipped:
- platform/qt/Skipped:
2010-06-03 Abhishek Arya <inferno@chromium.org>
Reviewed by Eric Carlson.
Fix a crash when trying to use an invalid media src url by
moving the isValid url checks to a central location in
isSafeToLoadURL function. Also added an empty string check
in DocumentLoader::didTellClientAboutLoad.
Test: media/invalid-media-url-crash.html
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::isSafeToLoadURL): (WebCore::HTMLMediaElement::selectNextSourceChild): (WebCore::HTMLMediaElement::getPluginProxyParams):
- loader/DocumentLoader.h: (WebCore::DocumentLoader::didTellClientAboutLoad):
- 11:09 PM Changeset in webkit [60656] by
-
- 3 edits in trunk/WebKitTools
2010-06-03 Tony Gentilcore <tonyg@chromium.org>
Reviewed by David Levin.
Add dependencies required to link with VS Express 2005.
https://bugs.webkit.org/show_bug.cgi?id=40038
Visual Studio implicitly links against these libs.
VC++ Express does not.
- WebKitAPITest/WebKitAPITestCommon.vsprops:
- WinLauncher/WinLauncher.vcproj:
- 10:57 PM Changeset in webkit [60655] by
-
- 2 edits in trunk/JavaScriptCore
2010-06-03 Jedrzej Nowacki <jedrzej.nowacki@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
New states in QScriptValuePrivate.
The CSpecial state was divided into CNull and CUndefined. It simplify
the QScriptValue code by avoiding a few "cast" and "if".
Moreover the MSVS compiler didn't like casting between a double and an
enum which is avoided now.
[Qt] The QScriptValuePrivate::CSpecial is too generic.
https://bugs.webkit.org/show_bug.cgi?id=40067
- qt/api/qscriptvalue_p.h: (QScriptValuePrivate::): (QScriptValuePrivate::QScriptValuePrivate): (QScriptValuePrivate::isNull): (QScriptValuePrivate::isUndefined): (QScriptValuePrivate::toString): (QScriptValuePrivate::toNumber): (QScriptValuePrivate::toBool): (QScriptValuePrivate::toObject): (QScriptValuePrivate::assignEngine): (QScriptValuePrivate::isNumberBased):
- 10:14 PM Changeset in webkit [60654] by
-
- 2 edits in trunk/WebKitTools
2010-06-03 Fumitoshi Ukai <ukai@chromium.org>
Reviewed by David Levin.
bad codecs.open in webkitpy/layout_tests/ports/websocket_server.py
https://bugs.webkit.org/show_bug.cgi?id=40105
- Scripts/webkitpy/layout_tests/port/websocket_server.py:
- kill pywebsocket process when url is not alive and the process is not terminated, not to leave pywebsocket server running.
- fix codecs.open parameters.
- 9:28 PM Changeset in webkit [60653] by
-
- 2 edits in trunk/LayoutTests
Unreviewed. Test expectation fix.
Skip fast/dom/Geolocation/callback-to-remote-context.html on GTK.
https://bugs.webkit.org/show_bug.cgi?id=40153
- platform/gtk/Skipped:
- 9:22 PM Changeset in webkit [60652] by
-
- 5 edits in trunk
2010-06-03 Fumitoshi Ukai <ukai@chromium.org>
Reviewed by Alexey Proskuryakov.
old-run-webkit-tests should use ensure-valid-python to check if it can run the websockets tests
https://bugs.webkit.org/show_bug.cgi?id=39058
- platform/mac-tiger/Skipped:
- remove websocket/tests from skipped list.
2010-06-03 Fumitoshi Ukai <ukai@chromium.org>
Reviewed by Alexey Proskuryakov.
old-run-webkit-tests should use ensure-valid-python to check if it can run the websockets tests
https://bugs.webkit.org/show_bug.cgi?id=39058
- Scripts/ensure-valid-python:
- Perl 5.8 doesn't have File::Temp->newdir(). Use File::Temp->tempdir() instead.
- Add --check-only and --help option.
- --check-only option only checks python version and don't try to install Python 2.5.
- Set executable bit.
- Scripts/old-run-webkit-tests:
- Check if it can run the websocket tests by calling ensure-valid-python --check-only.
- 6:57 PM Changeset in webkit [60651] by
-
- 4 edits in trunk/WebKit/chromium
2010-05-26 MORITA Hajime <morrita@google.com>
Reviewed by Jian Li.
[Chromium] Dragging over an element with scrollbars should scroll the element when dragging near edges
https://bugs.webkit.org/show_bug.cgi?id=39725
Added WebViewImpl::scrollForDragging() to handle scroll-on-drag.
Note that this change handes both source and destination cases.
- public/WebView.h:
- src/WebViewImpl.cpp: (WebKit::WebViewImpl::dragSourceMovedTo): (WebKit::WebViewImpl::dragTargetDragEnterOrOver): (WebKit::WebViewImpl::scrollForDragging):
- src/WebViewImpl.h:
- 6:44 PM Changeset in webkit [60650] by
-
- 2 edits in trunk/JavaScriptCore
- wtf/Platform.h:
Reviewed by NOBODY (Qt build fix).
- 6:31 PM Changeset in webkit [60649] by
-
- 4 edits in trunk/WebCore
2010-06-03 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r60642.
http://trac.webkit.org/changeset/60642
https://bugs.webkit.org/show_bug.cgi?id=40151
Broke rendering of border images on rotated elements
(Requested by jamesr on #webkit).
- platform/graphics/GraphicsContext.cpp: (WebCore::GraphicsContext::drawImage): (WebCore::GraphicsContext::drawTiledImage):
- platform/graphics/GraphicsContext.h:
- rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelObject::paintNinePieceImage):
- 6:18 PM Changeset in webkit [60648] by
-
- 2 edits in trunk/LayoutTests
Unreviewed. Add exceptions for some newly-passing tests in Chromium.
- platform/chromium/test_expectations.txt:
- 5:45 PM Changeset in webkit [60647] by
-
- 3 edits in trunk/WebKit2
Reviewed by Anders Carlsson.
Add UIProcess\API\cpp to the list of additional include directories.
Allow WKViewRef to work with WKRetainPtr on Windows.
- UIProcess/API/cpp/WKRetainPtr.h:
- win/WebKit2.vcproj:
- 5:34 PM Changeset in webkit [60646] by
-
- 3 edits in trunk/JavaScriptCore
Bug 40150 - ENABLE_JIT_OPTIMIZE_NATIVE_CALL on all x86/x86_64 platforms
This was fixed in bug #40094.
Reviewed by Mark Rowe.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
- wtf/Platform.h:
- 4:46 PM Changeset in webkit [60645] by
-
- 1 edit5 adds in trunk/LayoutTests
2010-06-03 Steve Block <steveblock@google.com>
Reviewed by Alexey Proskuryakov.
Geolocation needs LayoutTest to test making callbacks to remote frames
https://bugs.webkit.org/show_bug.cgi?id=40129
- fast/dom/Geolocation/callback-to-remote-context-expected.txt: Added.
- fast/dom/Geolocation/callback-to-remote-context.html: Added.
- fast/dom/Geolocation/resources: Added.
- fast/dom/Geolocation/resources/callback-to-remote-context-inner.html: Added.
- fast/dom/Geolocation/script-tests/callback-to-remote-context.js: Added.
- 4:39 PM Changeset in webkit [60644] by
-
- 1 edit18 adds in trunk/LayoutTests
2010-06-03 James Robinson <jamesr@chromium.org>
Unreviewed. Add chromium-specific baselines for new tests added by 60640
- platform/chromium-linux/fast/repaint/layout-state-scrolloffset-expected.checksum: Added.
- platform/chromium-linux/fast/repaint/layout-state-scrolloffset2-expected.checksum: Added.
- platform/chromium-linux/fast/repaint/layout-state-scrolloffset3-expected.checksum: Added.
- platform/chromium-mac/fast/repaint/layout-state-scrolloffset-expected.checksum: Added.
- platform/chromium-mac/fast/repaint/layout-state-scrolloffset-expected.png: Added.
- platform/chromium-mac/fast/repaint/layout-state-scrolloffset2-expected.checksum: Added.
- platform/chromium-mac/fast/repaint/layout-state-scrolloffset2-expected.png: Added.
- platform/chromium-mac/fast/repaint/layout-state-scrolloffset3-expected.checksum: Added.
- platform/chromium-mac/fast/repaint/layout-state-scrolloffset3-expected.png: Added.
- platform/chromium-win/fast/repaint/layout-state-scrolloffset-expected.checksum: Added.
- platform/chromium-win/fast/repaint/layout-state-scrolloffset-expected.png: Added.
- platform/chromium-win/fast/repaint/layout-state-scrolloffset-expected.txt: Added.
- platform/chromium-win/fast/repaint/layout-state-scrolloffset2-expected.checksum: Added.
- platform/chromium-win/fast/repaint/layout-state-scrolloffset2-expected.png: Added.
- platform/chromium-win/fast/repaint/layout-state-scrolloffset2-expected.txt: Added.
- platform/chromium-win/fast/repaint/layout-state-scrolloffset3-expected.checksum: Added.
- platform/chromium-win/fast/repaint/layout-state-scrolloffset3-expected.png: Added.
- platform/chromium-win/fast/repaint/layout-state-scrolloffset3-expected.txt: Added.
- 4:19 PM Changeset in webkit [60643] by
-
- 3 edits in trunk/LayoutTests
2010-06-03 John Gregg <johnnyg@google.com>
Reviewed by David Levin.
notifications: in display+close layout test, don't close the notification
until the display event has been received asynchronously; also don't use
an invalid icon URL, since that should generate an error event.
https://bugs.webkit.org/show_bug.cgi?id=39782
- fast/notifications/notifications-display-close-events.html:
- 4:13 PM Changeset in webkit [60642] by
-
- 4 edits in trunk/WebCore
Reviewed by Beth Dakin.
Pixel cracks in border images when drawing with a scale factor > 1
<rdar://problem/7994266>pixel cracks in border images
https://bugs.webkit.org/show_bug.cgi?id=15720
- platform/graphics/GraphicsContext.cpp: (WebCore::GraphicsContext::drawImage): (WebCore::GraphicsContext::drawTiledImage):
- platform/graphics/GraphicsContext.h: Added two new methods to support drawing using FloatRect. If the boolean flag roundToPixels is true, the pixels are adjusted with the pixel boundaries.
- rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelObject::paintNinePieceImage):
- 3:49 PM Changeset in webkit [60641] by
-
- 3 edits in trunk/WebKit/gtk
2010-06-03 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r60632.
http://trac.webkit.org/changeset/60632
https://bugs.webkit.org/show_bug.cgi?id=40143
This change broke the 64-bit bots. (Requested by mrobinson on
#webkit).
- WebCoreSupport/DragClientGtk.cpp: (WebKit::DragClient::DragClient): (WebKit::DragClient::startDrag):
- WebCoreSupport/DragClientGtk.h:
- 3:07 PM Changeset in webkit [60640] by
-
- 3 edits18 adds in trunk
2010-06-03 James Robinson <jamesr@chromium.org>
Reviewed by Dan Bernstein.
Take container's scroll offset and clip into account when initializing LayoutState
https://bugs.webkit.org/show_bug.cgi?id=38506
When doing a subtree layout, the initial LayoutState creation needs to
take the layout root container's offset and its scroll offset into account
to create the initial offset. Otherwise if a subtree layout occurs
for a layout root whose container has a non-zero scroll offset
the LayoutState's offset and clip are wrong, resulting in a mispaint.
See the test cases for examples.
Tests: fast/repaint/layout-state-scrolloffset.html
fast/repaint/layout-state-scrolloffset2.html
fast/repaint/layout-state-scrolloffset3.html
- rendering/LayoutState.cpp: (WebCore::LayoutState::LayoutState):
2010-06-03 James Robinson <jamesr@chromium.org>
Reviewed by Dan Bernstein.
Tests repainting a layout subtree with scroll offsets
https://bugs.webkit.org/show_bug.cgi?id=38506
Has to be run as a pixel test to be useful.
- layout-state-scrolloffset.html tests the layout root having a non-zero scroll offset.
- layout-state-scrolloffset2.html tests the layout root and its container having
non-zero scroll offsets.
- layout-state-scrolloffset3.html tests the layout root having non-zero a scroll offset
and clipping its descendants.
- fast/repaint/layout-state-scrolloffset.html: Added.
- fast/repaint/layout-state-scrolloffset2.html: Added.
- fast/repaint/layout-state-scrolloffset3.html: Added.
- platform/mac/fast/repaint/layout-state-scrolloffset-expected.checksum: Added.
- platform/mac/fast/repaint/layout-state-scrolloffset-expected.png: Added.
- platform/mac/fast/repaint/layout-state-scrolloffset-expected.txt: Added.
- platform/mac/fast/repaint/layout-state-scrolloffset2-expected.checksum: Added.
- platform/mac/fast/repaint/layout-state-scrolloffset2-expected.png: Added.
- platform/mac/fast/repaint/layout-state-scrolloffset2-expected.txt: Added.
- platform/mac/fast/repaint/layout-state-scrolloffset3-expected.checksum: Added.
- platform/mac/fast/repaint/layout-state-scrolloffset3-expected.png: Added.
- platform/mac/fast/repaint/layout-state-scrolloffset3-expected.txt: Added.
- platform/mac-leopard/fast/repaint/layout-state-scrolloffset-expected.checksum: Added.
- platform/mac-leopard/fast/repaint/layout-state-scrolloffset-expected.png: Added.
- platform/mac-leopard/fast/repaint/layout-state-scrolloffset2-expected.checksum: Added.
- platform/mac-leopard/fast/repaint/layout-state-scrolloffset2-expected.png: Added.
- platform/mac-leopard/fast/repaint/layout-state-scrolloffset3-expected.checksum: Added.
- platform/mac-leopard/fast/repaint/layout-state-scrolloffset3-expected.png: Added.
- 2:45 PM Changeset in webkit [60639] by
-
- 3 edits in trunk/WebCore
- bridge/qt/qt_runtime.cpp:
(JSC::Bindings::QtRuntimeMetaMethod::call):
(JSC::Bindings::QtRuntimeConnectionMethod::call):
Reviewed by NOBODY (speculative Qt build fix II).
- 2:36 PM Changeset in webkit [60638] by
-
- 2 edits in trunk/WebCore
- bridge/qt/qt_runtime.cpp:
(JSC::Bindings::QtRuntimeMetaMethod::call):
(JSC::Bindings::QtRuntimeConnectionMethod::call):
Reviewed by NOBODY (speculative Qt build fix).
- 2:29 PM Changeset in webkit [60637] by
-
- 5 edits in trunk/JavaScriptCore
- JavaScriptCore.JSVALUE32_64only.exp:
- JavaScriptCore.JSVALUE32only.exp:
- JavaScriptCore.JSVALUE64only.exp:
- interpreter/Interpreter.cpp:
(JSC::Interpreter::privateExecute):
Reviewed by NOBODY (Interpreter build fix).
- 2:10 PM Changeset in webkit [60636] by
-
- 2 edits in trunk/JavaScriptCore
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
Reviewed by NOBODY (windows build fix II).
- 1:49 PM Changeset in webkit [60635] by
-
- 14 edits in trunk/WebKitTools
2010-05-14 Ojan Vafai <ojan@chromium.org>
Reviewed by Adam Barth.
add a RietveldUploadQueue to upload in-rietveld? patches to rietveld
https://bugs.webkit.org/show_bug.cgi?id=38918
Patches with in-rietveld? get uploaded to rietveld and get marked
in-rietveld+. If the upload fails, they are marked in-rietveld-
and an error is logged to the bug, like the commit-queue.
Also, get rid of --fancy-review and the ability to upload to rietveld
using webkit-patch upload/post.
- Scripts/webkitpy/common/net/bugzilla.py:
- Scripts/webkitpy/common/net/bugzilla_unittest.py:
- Scripts/webkitpy/tool/commands/download.py:
- Scripts/webkitpy/tool/commands/download_unittest.py:
- Scripts/webkitpy/tool/commands/queues.py:
- Scripts/webkitpy/tool/commands/queues_unittest.py:
- Scripts/webkitpy/tool/commands/upload.py:
- Scripts/webkitpy/tool/commands/upload_unittest.py:
- Scripts/webkitpy/tool/mocktool.py:
- Scripts/webkitpy/tool/steps/options.py:
- Scripts/webkitpy/tool/steps/postcodereview.py:
- 1:48 PM Changeset in webkit [60634] by
-
- 2 edits in trunk/JavaScriptCore
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
Reviewed by NOBODY (windows build fix).
- 1:20 PM Changeset in webkit [60633] by
-
- 3 edits in trunk/WebKitTools
2010-05-24 Ojan Vafai <ojan@chromium.org>
Reviewed by Chris Jerdonek.
many webkit-patch commands fail in a non-svn tracking git checkout
https://bugs.webkit.org/show_bug.cgi?id=38156
If the svn-tracking-branch (trunk) doesn't exist, fallback to the git remote-tracking-branch (master).
If neither exists, then error out. This makes webkit-patch work
for anyone that follows the intructions at http://trac.webkit.org/wiki/UsingGitWithWebKit
to checkout webkit. The fallback to master is for people who don't
do the steps on that page for tracking svn.
- Scripts/webkitpy/common/checkout/scm.py:
- Scripts/webkitpy/common/checkout/scm_unittest.py:
- 1:08 PM Changeset in webkit [60632] by
-
- 3 edits in trunk/WebKit/gtk
2010-06-03 Martin Robinson <mrobinson@igalia.com>
Reviewed by Xan Lopez.
[GTK] Drag gesture can take mouse grab indefinitely
https://bugs.webkit.org/show_bug.cgi?id=32840
Start GTK+ drags with the previous mouse button down event instead of
synthesizing the event. The synthesized event was not completely valid
and froze some drags indefinitely.
- WebCoreSupport/DragClientGtk.cpp: (WebKit::buttonPressEvent): Added. (WebKit::DragClient::DragClient): Connect to the 'button-press-event' signal of the WebView. (WebKit::DragClient::startDrag): Instead of synthesizing a button press event use the last real one.
- WebCoreSupport/DragClientGtk.h: (WebKit::DragClient::setLastButtonPressEvent): Added.
- 1:00 PM Changeset in webkit [60631] by
-
- 71 edits in trunk
Bug 40094 - The return type of NativeFunction should be EncodedJSValue
On Windows & Linux, using JSVALUE32_64, EncodedJSValue is returned in registers, but JSValue is not.
Reviewed by Oliver Hunt.
- API/JSCallbackFunction.cpp:
(JSC::JSCallbackFunction::call):
- API/JSCallbackFunction.h:
- API/JSCallbackObject.h:
- API/JSCallbackObjectFunctions.h:
(JSC::::call):
- JavaScriptCore.exp:
- interpreter/Interpreter.cpp:
(JSC::Interpreter::executeCall):
- jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
- jit/JITStubs.h:
- jsc.cpp:
(functionPrint):
(functionDebug):
(functionGC):
(functionVersion):
(functionRun):
(functionLoad):
(functionCheckSyntax):
(functionSetSamplingFlags):
(functionClearSamplingFlags):
(functionReadline):
(functionQuit):
- runtime/ArrayConstructor.cpp:
(JSC::callArrayConstructor):
(JSC::arrayConstructorIsArray):
- runtime/ArrayPrototype.cpp:
(JSC::arrayProtoFuncToString):
(JSC::arrayProtoFuncToLocaleString):
(JSC::arrayProtoFuncJoin):
(JSC::arrayProtoFuncConcat):
(JSC::arrayProtoFuncPop):
(JSC::arrayProtoFuncPush):
(JSC::arrayProtoFuncReverse):
(JSC::arrayProtoFuncShift):
(JSC::arrayProtoFuncSlice):
(JSC::arrayProtoFuncSort):
(JSC::arrayProtoFuncSplice):
(JSC::arrayProtoFuncUnShift):
(JSC::arrayProtoFuncFilter):
(JSC::arrayProtoFuncMap):
(JSC::arrayProtoFuncEvery):
(JSC::arrayProtoFuncForEach):
(JSC::arrayProtoFuncSome):
(JSC::arrayProtoFuncReduce):
(JSC::arrayProtoFuncReduceRight):
(JSC::arrayProtoFuncIndexOf):
(JSC::arrayProtoFuncLastIndexOf):
- runtime/BooleanConstructor.cpp:
(JSC::callBooleanConstructor):
- runtime/BooleanPrototype.cpp:
(JSC::booleanProtoFuncToString):
(JSC::booleanProtoFuncValueOf):
- runtime/CallData.h:
- runtime/DateConstructor.cpp:
(JSC::callDate):
(JSC::dateParse):
(JSC::dateNow):
(JSC::dateUTC):
- runtime/DatePrototype.cpp:
(JSC::dateProtoFuncToString):
(JSC::dateProtoFuncToUTCString):
(JSC::dateProtoFuncToISOString):
(JSC::dateProtoFuncToDateString):
(JSC::dateProtoFuncToTimeString):
(JSC::dateProtoFuncToLocaleString):
(JSC::dateProtoFuncToLocaleDateString):
(JSC::dateProtoFuncToLocaleTimeString):
(JSC::dateProtoFuncGetTime):
(JSC::dateProtoFuncGetFullYear):
(JSC::dateProtoFuncGetUTCFullYear):
(JSC::dateProtoFuncToGMTString):
(JSC::dateProtoFuncGetMonth):
(JSC::dateProtoFuncGetUTCMonth):
(JSC::dateProtoFuncGetDate):
(JSC::dateProtoFuncGetUTCDate):
(JSC::dateProtoFuncGetDay):
(JSC::dateProtoFuncGetUTCDay):
(JSC::dateProtoFuncGetHours):
(JSC::dateProtoFuncGetUTCHours):
(JSC::dateProtoFuncGetMinutes):
(JSC::dateProtoFuncGetUTCMinutes):
(JSC::dateProtoFuncGetSeconds):
(JSC::dateProtoFuncGetUTCSeconds):
(JSC::dateProtoFuncGetMilliSeconds):
(JSC::dateProtoFuncGetUTCMilliseconds):
(JSC::dateProtoFuncGetTimezoneOffset):
(JSC::dateProtoFuncSetTime):
(JSC::dateProtoFuncSetMilliSeconds):
(JSC::dateProtoFuncSetUTCMilliseconds):
(JSC::dateProtoFuncSetSeconds):
(JSC::dateProtoFuncSetUTCSeconds):
(JSC::dateProtoFuncSetMinutes):
(JSC::dateProtoFuncSetUTCMinutes):
(JSC::dateProtoFuncSetHours):
(JSC::dateProtoFuncSetUTCHours):
(JSC::dateProtoFuncSetDate):
(JSC::dateProtoFuncSetUTCDate):
(JSC::dateProtoFuncSetMonth):
(JSC::dateProtoFuncSetUTCMonth):
(JSC::dateProtoFuncSetFullYear):
(JSC::dateProtoFuncSetUTCFullYear):
(JSC::dateProtoFuncSetYear):
(JSC::dateProtoFuncGetYear):
(JSC::dateProtoFuncToJSON):
- runtime/ErrorConstructor.cpp:
(JSC::callErrorConstructor):
- runtime/ErrorPrototype.cpp:
(JSC::errorProtoFuncToString):
- runtime/FunctionConstructor.cpp:
(JSC::callFunctionConstructor):
- runtime/FunctionPrototype.cpp:
(JSC::callFunctionPrototype):
(JSC::functionProtoFuncToString):
(JSC::functionProtoFuncApply):
(JSC::functionProtoFuncCall):
- runtime/JSCell.h:
(JSC::getCallData):
(JSC::getConstructData):
- runtime/JSFunction.cpp:
(JSC::callHostFunctionAsConstructor):
- runtime/JSFunction.h:
- runtime/JSGlobalObjectFunctions.cpp:
(JSC::globalFuncEval):
(JSC::globalFuncParseInt):
(JSC::globalFuncParseFloat):
(JSC::globalFuncIsNaN):
(JSC::globalFuncIsFinite):
(JSC::globalFuncDecodeURI):
(JSC::globalFuncDecodeURIComponent):
(JSC::globalFuncEncodeURI):
(JSC::globalFuncEncodeURIComponent):
(JSC::globalFuncEscape):
(JSC::globalFuncUnescape):
(JSC::globalFuncJSCPrint):
- runtime/JSGlobalObjectFunctions.h:
- runtime/JSONObject.cpp:
(JSC::JSONProtoFuncParse):
(JSC::JSONProtoFuncStringify):
- runtime/JSObject.cpp:
(JSC::callDefaultValueFunction):
- runtime/JSValue.h:
- runtime/MathObject.cpp:
(JSC::mathProtoFuncAbs):
(JSC::mathProtoFuncACos):
(JSC::mathProtoFuncASin):
(JSC::mathProtoFuncATan):
(JSC::mathProtoFuncATan2):
(JSC::mathProtoFuncCeil):
(JSC::mathProtoFuncCos):
(JSC::mathProtoFuncExp):
(JSC::mathProtoFuncFloor):
(JSC::mathProtoFuncLog):
(JSC::mathProtoFuncMax):
(JSC::mathProtoFuncMin):
(JSC::mathProtoFuncPow):
(JSC::mathProtoFuncRandom):
(JSC::mathProtoFuncRound):
(JSC::mathProtoFuncSin):
(JSC::mathProtoFuncSqrt):
(JSC::mathProtoFuncTan):
- runtime/NativeErrorConstructor.cpp:
(JSC::callNativeErrorConstructor):
- runtime/NumberConstructor.cpp:
(JSC::callNumberConstructor):
- runtime/NumberPrototype.cpp:
(JSC::numberProtoFuncToString):
(JSC::numberProtoFuncToLocaleString):
(JSC::numberProtoFuncValueOf):
(JSC::numberProtoFuncToFixed):
(JSC::numberProtoFuncToExponential):
(JSC::numberProtoFuncToPrecision):
- runtime/ObjectConstructor.cpp:
(JSC::callObjectConstructor):
(JSC::objectConstructorGetPrototypeOf):
(JSC::objectConstructorGetOwnPropertyDescriptor):
(JSC::objectConstructorGetOwnPropertyNames):
(JSC::objectConstructorKeys):
(JSC::toPropertyDescriptor):
(JSC::objectConstructorDefineProperty):
(JSC::objectConstructorDefineProperties):
(JSC::objectConstructorCreate):
- runtime/ObjectPrototype.cpp:
(JSC::objectProtoFuncValueOf):
(JSC::objectProtoFuncHasOwnProperty):
(JSC::objectProtoFuncIsPrototypeOf):
(JSC::objectProtoFuncDefineGetter):
(JSC::objectProtoFuncDefineSetter):
(JSC::objectProtoFuncLookupGetter):
(JSC::objectProtoFuncLookupSetter):
(JSC::objectProtoFuncPropertyIsEnumerable):
(JSC::objectProtoFuncToLocaleString):
(JSC::objectProtoFuncToString):
- runtime/ObjectPrototype.h:
- runtime/RegExpConstructor.cpp:
(JSC::callRegExpConstructor):
- runtime/RegExpObject.cpp:
(JSC::callRegExpObject):
- runtime/RegExpPrototype.cpp:
(JSC::regExpProtoFuncTest):
(JSC::regExpProtoFuncExec):
(JSC::regExpProtoFuncCompile):
(JSC::regExpProtoFuncToString):
- runtime/StringConstructor.cpp:
(JSC::stringFromCharCode):
(JSC::callStringConstructor):
- runtime/StringPrototype.cpp:
(JSC::stringProtoFuncReplace):
(JSC::stringProtoFuncToString):
(JSC::stringProtoFuncCharAt):
(JSC::stringProtoFuncCharCodeAt):
(JSC::stringProtoFuncConcat):
(JSC::stringProtoFuncIndexOf):
(JSC::stringProtoFuncLastIndexOf):
(JSC::stringProtoFuncMatch):
(JSC::stringProtoFuncSearch):
(JSC::stringProtoFuncSlice):
(JSC::stringProtoFuncSplit):
(JSC::stringProtoFuncSubstr):
(JSC::stringProtoFuncSubstring):
(JSC::stringProtoFuncToLowerCase):
(JSC::stringProtoFuncToUpperCase):
(JSC::stringProtoFuncLocaleCompare):
(JSC::stringProtoFuncBig):
(JSC::stringProtoFuncSmall):
(JSC::stringProtoFuncBlink):
(JSC::stringProtoFuncBold):
(JSC::stringProtoFuncFixed):
(JSC::stringProtoFuncItalics):
(JSC::stringProtoFuncStrike):
(JSC::stringProtoFuncSub):
(JSC::stringProtoFuncSup):
(JSC::stringProtoFuncFontcolor):
(JSC::stringProtoFuncFontsize):
(JSC::stringProtoFuncAnchor):
(JSC::stringProtoFuncLink):
(JSC::stringProtoFuncTrim):
(JSC::stringProtoFuncTrimLeft):
(JSC::stringProtoFuncTrimRight):
JavaScriptGlue:
- JSObject.cpp:
(nativeCallFunction):
WebCore:
- bindings/js/JSCallbackData.cpp:
(WebCore::JSCallbackData::invokeCallback):
- bindings/js/JSCustomXPathNSResolver.cpp:
(WebCore::JSCustomXPathNSResolver::lookupNamespaceURI):
- bindings/js/JSEventListener.cpp:
(WebCore::JSEventListener::handleEvent):
- bindings/js/JSHTMLAllCollectionCustom.cpp:
(WebCore::callHTMLAllCollection):
- bindings/js/JSHTMLCollectionCustom.cpp:
(WebCore::callHTMLCollection):
- bindings/js/JSHTMLDocumentCustom.cpp:
(WebCore::JSHTMLDocument::open):
- bindings/js/JSInjectedScriptHostCustom.cpp:
(WebCore::InjectedScriptHost::createInjectedScript):
- bindings/js/JSNodeFilterCondition.cpp:
(WebCore::JSNodeFilterCondition::acceptNode):
- bindings/js/JSNodeListCustom.cpp:
(WebCore::callNodeList):
- bindings/js/JSPluginElementFunctions.cpp:
(WebCore::callPlugin):
- bindings/js/ScheduledAction.cpp:
(WebCore::ScheduledAction::create):
(WebCore::ScheduledAction::executeFunctionInContext):
- bindings/js/ScriptFunctionCall.cpp:
(WebCore::ScriptFunctionCall::call):
- bindings/js/SerializedScriptValue.cpp:
(WebCore::SerializingTreeWalker::convertIfTerminal):
- bindings/objc/WebScriptObject.mm:
(-[WebScriptObject callWebScriptMethod:withArguments:]):
- bindings/scripts/CodeGeneratorJS.pm:
- bridge/NP_jsobject.cpp:
(_NPN_InvokeDefault):
(_NPN_Invoke):
(_NPN_Construct):
- bridge/jni/jni_jsobject.mm:
(JavaJSObject::call):
- bridge/objc/objc_runtime.mm:
(JSC::Bindings::callObjCFallbackObject):
- bridge/runtime_method.cpp:
(JSC::callRuntimeMethod):
- bridge/runtime_object.cpp:
(JSC::Bindings::callRuntimeObject):
WebKit/mac:
- Plugins/Hosted/NetscapePluginInstanceProxy.h:
- Plugins/Hosted/NetscapePluginInstanceProxy.mm:
(WebKit::NetscapePluginInstanceProxy::invoke):
- 11:59 AM HackingGtk edited by
- (diff)
- 11:56 AM HackingGtk edited by
- (diff)
- 11:38 AM HackingGtk edited by
- Update source module locations and put the directory first (diff)
- 10:34 AM Changeset in webkit [60630] by
-
- 2 edits in trunk/WebKit/qt
[Qt] Don't send notifications event after the page was navigated away
https://bugs.webkit.org/show_bug.cgi?id=40127
Reviewed by Laszlo Gombos.
Added a check before sending events to the notification and before logging.
- WebCoreSupport/NotificationPresenterClientQt.cpp:
(WebCore::NotificationPresenterClientQt::cancel):
(WebCore::NotificationPresenterClientQt::sendEvent):
- 10:33 AM Changeset in webkit [60629] by
-
- 5 edits in branches/safari-533-branch
Versioning.
- 10:30 AM Changeset in webkit [60628] by
-
- 1 copy in tags/Safari-533.16
New tag.
- 10:30 AM Changeset in webkit [60627] by
-
- 2 edits in branches/safari-533-branch/WebCore
Merge r59498.
- 9:42 AM Changeset in webkit [60626] by
-
- 2 edits in trunk/LayoutTests
fast/events/transformaction removed from expectations,
because these tests were rolled-out by r60624.
Rubber-stamped by Simon Hausmann.
- platform/chromium/test_expectations.txt:
- 9:29 AM Changeset in webkit [60625] by
-
- 5 edits in trunk/LayoutTests
Unreviewed, rolling out r60617.
http://trac.webkit.org/changeset/60617
https://bugs.webkit.org/show_bug.cgi?id=40124
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2010-06-03
Followup patch for rolled-out r60614 (Requested by Ossy on
#webkit).
- platform/qt/fast/dom/Window/window-properties-expected.txt:
- platform/qt/fast/dom/Window/window-property-descriptors-expected.txt:
- platform/qt/fast/dom/prototype-inheritance-expected.txt:
- platform/qt/fast/js/global-constructors-expected.txt:
- 9:25 AM Changeset in webkit [60624] by
-
- 31 edits6 deletes in trunk
Unreviewed, rolling out r60614.
http://trac.webkit.org/changeset/60614
https://bugs.webkit.org/show_bug.cgi?id=40123
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2010-06-03
It made fast/dom/Window/window-postmessage-clone.html fail on
Mac bots (Requested by Ossy on #webkit).
WebCore:
- Android.derived.jscbindings.mk:
- Android.derived.v8bindings.mk:
- Android.mk:
- CMakeLists.txt:
- DerivedSources.cpp:
- DerivedSources.make:
- GNUmakefile.am:
- WebCore.gypi:
- WebCore.pri:
- WebCore.pro:
- bindings/generic/RuntimeEnabledFeatures.cpp:
- bindings/generic/RuntimeEnabledFeatures.h:
- bindings/js/JSEventCustom.cpp:
(WebCore::toJS):
- bindings/v8/custom/V8EventCustom.cpp:
(WebCore::toV8):
- dom/Document.cpp:
(WebCore::Document::createEvent):
(WebCore::Document::addListenerTypeIfNeeded):
- dom/Document.h:
(WebCore::Document::):
- dom/Document.idl:
- dom/Element.h:
- dom/Element.idl:
- dom/Event.cpp:
(WebCore::Event::fromUserGesture):
- dom/Event.h:
- dom/EventNames.h:
- dom/TransformActionEvent.cpp: Removed.
- dom/TransformActionEvent.h: Removed.
- dom/TransformActionEvent.idl: Removed.
- html/HTMLAttributeNames.in:
- html/HTMLElement.cpp:
(WebCore::HTMLElement::parseMappedAttribute):
- page/DOMWindow.h:
- page/DOMWindow.idl:
LayoutTests:
- fast/events/transformaction/create-transformaction-event-expected.txt: Removed.
- fast/events/transformaction/create-transformaction-event.html: Removed.
- fast/events/transformaction/resources/create-transformaction-event.js: Removed.
- platform/gtk/Skipped:
- platform/mac/Skipped:
- platform/win/Skipped:
- 9:03 AM Changeset in webkit [60623] by
-
- 4 edits in trunk
2010-06-03 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
[v8] Web Inspector: show "Object" as description for values with anonymous constructor
https://bugs.webkit.org/show_bug.cgi?id=40121
- inspector/front-end/InjectedScript.js: (injectedScriptConstructor):
2010-06-03 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
[v8] Web Inspector: show "Object" as description for values with anonymous constructor
https://bugs.webkit.org/show_bug.cgi?id=40121
- src/js/DevTools.js: don't call DebuggerAgent methods if ScriptDebugServer is used.
- 8:56 AM Changeset in webkit [60622] by
-
- 2 edits in trunk/WebKit/chromium
[DRT/Chromium] Checking out lighttpd
https://bugs.webkit.org/show_bug.cgi?id=39948
Patch by Kent Tamura <tkent@chromium.org> on 2010-06-03
Reviewed by Dimitri Glazkov.
- Add lighttpd only on Windows. It is used by new-run-webkit-tests.
- Add libvpx.
- Remove pthreads-win32 from DEPS. It has not been used since Chromium r28642.
- Update Chromium revision to use Windows resource query code and webkit_glue dependency fix.
- DEPS:
- 6:38 AM Changeset in webkit [60621] by
-
- 4 edits1 move in trunk/WebCore
[Qt] Fix NPAPI support on Mac OS X/Cocoa-32
Reviewed by Simon Hausmann.
qt_mac_window_for() returns a NSWindow on Cocoa, so we were
passing in a NSWindow instead of a WindowRef as part of the
NP_CGContext.
https://bugs.webkit.org/show_bug.cgi?id=38762
- WebCore.gypi: Reflect rename
- WebCore.pro: Reflect rename
- plugins/mac/PluginViewMac.cpp: Renamed to PluginViewMac.mm
and fix bug by getting the Carbon windowRef from the NSWindow.
- wscript: Reflect rename
- 6:02 AM Changeset in webkit [60620] by
-
- 2 edits in trunk/WebKitTools
2010-06-03 Mike Fenton <mifenton@rim.com>
Unreviewed.
Reverse e-mail for myself in committers.py to correspond with bugzilla account.
- Scripts/webkitpy/common/config/committers.py:
- 4:11 AM Changeset in webkit [60619] by
-
- 2 edits in trunk/LayoutTests
Unreviewed. Test expectation update.
- platform/chromium/test_expectations.txt: Restore Mac expectation of fixed-move-after-keyboard-scroll.html.
- 3:04 AM Changeset in webkit [60618] by
-
- 6 edits in trunk
2010-06-03 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: a number of fixes that make InspectorController
happy with null redirects.
- inspector/InspectorController.cpp: (WebCore::InspectorController::willSendRequest): (WebCore::InspectorController::didReceiveResponse): (WebCore::InspectorController::didReceiveContentLength): (WebCore::InspectorController::didFinishLoading): (WebCore::InspectorController::didFailLoading):
2010-06-03 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: a number of fixes that make InspectorController
happy with null redirects.
- DumpRenderTree/gtk/DumpRenderTree.cpp: (runTest):
- DumpRenderTree/mac/DumpRenderTree.mm: (runTest):
- DumpRenderTree/win/DumpRenderTree.cpp: (runTest):
- 2:58 AM Changeset in webkit [60617] by
-
- 5 edits in trunk/LayoutTests
Not reviewed: Add TransformActionEvent to the window object tests, after r60614.
- platform/qt/fast/dom/Window/window-properties-expected.txt:
- platform/qt/fast/dom/Window/window-property-descriptors-expected.txt:
- platform/qt/fast/dom/prototype-inheritance-expected.txt:
- platform/qt/fast/js/global-constructors-expected.txt:
- 2:37 AM Changeset in webkit [60616] by
-
- 3 edits in trunk/LayoutTests
Unreviewed. Test expectation update.
Rebaseline fixed-move-after-keyboard-scroll for Chromium-Linux
https://bugs.webkit.org/show_bug.cgi?id=40101
- platform/chromium-linux/fast/repaint/fixed-move-after-keyboard-scroll-expected.checksum:
- platform/chromium-linux/fast/repaint/fixed-move-after-keyboard-scroll-expected.png:
- 2:24 AM Changeset in webkit [60615] by
-
- 6 edits in trunk/LayoutTests
Unreviewed. Test expectation update.
Rebaseline fixed-move-after-keyboard-scroll, and add an entry for
fast/events/transformaction.
https://bugs.webkit.org/show_bug.cgi?id=40101
- platform/chromium-mac/fast/repaint/fixed-move-after-keyboard-scroll-expected.checksum:
- platform/chromium-mac/fast/repaint/fixed-move-after-keyboard-scroll-expected.png:
- platform/chromium-win/fast/repaint/fixed-move-after-keyboard-scroll-expected.checksum:
- platform/chromium-win/fast/repaint/fixed-move-after-keyboard-scroll-expected.png:
- platform/chromium/test_expectations.txt:
- 1:38 AM Changeset in webkit [60614] by
-
- 31 edits8 adds in trunk
Add TransformActionEvent support
https://bugs.webkit.org/show_bug.cgi?id=39757
Patch by Kim Grönholm <kim.1.gronholm@nokia.com> on 2010-06-03
Reviewed by Simon Hausmann.
WebCore:
Added only the necessary TransformAction event interfaces and not e.g.
any eventhandler hooks that generate and dispatch them.
Test: fast/events/transformaction/create-transformaction-event.html
More tests will be added with the machinery that generates and
dispatches these events.
- Android.derived.jscbindings.mk:
- Android.derived.v8bindings.mk:
- Android.mk:
- CMakeLists.txt:
- DerivedSources.cpp:
- DerivedSources.make:
- GNUmakefile.am:
- WebCore.gypi:
- WebCore.pri:
- WebCore.pro:
- bindings/generic/RuntimeEnabledFeatures.cpp:
- bindings/generic/RuntimeEnabledFeatures.h:
(WebCore::RuntimeEnabledFeatures::transformactionEnabled):
(WebCore::RuntimeEnabledFeatures::setTransformActionEnabled):
(WebCore::RuntimeEnabledFeatures::ontransformactionstartEnabled):
(WebCore::RuntimeEnabledFeatures::ontransformactionupdateEnabled):
(WebCore::RuntimeEnabledFeatures::ontransformactionendEnabled):
- bindings/js/JSEventCustom.cpp:
(WebCore::toJS):
- bindings/v8/custom/V8EventCustom.cpp:
(WebCore::toV8):
- dom/Document.cpp:
(WebCore::Document::createEvent):
(WebCore::Document::addListenerTypeIfNeeded):
- dom/Document.h:
(WebCore::Document::):
- dom/Document.idl:
- dom/Element.h:
- dom/Element.idl:
- dom/Event.cpp:
(WebCore::Event::isTransformActionEvent):
(WebCore::Event::fromUserGesture):
- dom/Event.h:
- dom/EventNames.h:
- dom/TransformActionEvent.cpp: Added.
(WebCore::TransformActionEvent::TransformActionEvent):
(WebCore::TransformActionEvent::initTransformActionEvent):
- dom/TransformActionEvent.h: Added.
(WebCore::TransformActionEvent::create):
(WebCore::TransformActionEvent::translateX):
(WebCore::TransformActionEvent::translateY):
(WebCore::TransformActionEvent::translateSpeedX):
(WebCore::TransformActionEvent::translateSpeedY):
(WebCore::TransformActionEvent::scale):
(WebCore::TransformActionEvent::scaleSpeed):
(WebCore::TransformActionEvent::rotate):
(WebCore::TransformActionEvent::rotateSpeed):
(WebCore::TransformActionEvent::TransformActionEvent):
(WebCore::TransformActionEvent::isTransformActionEvent):
- dom/TransformActionEvent.idl: Added.
- html/HTMLAttributeNames.in:
- html/HTMLElement.cpp:
(WebCore::HTMLElement::parseMappedAttribute):
- page/DOMWindow.h:
- page/DOMWindow.idl:
LayoutTests:
- fast/events/transformaction/create-transformaction-event-expected.txt: Added.
- fast/events/transformaction/create-transformaction-event.html: Added.
- fast/events/transformaction/resources/create-transformaction-event.js: Added.
- platform/gtk/Skipped:
- platform/mac/Skipped:
- platform/win/Skipped:
- 1:21 AM Changeset in webkit [60613] by
-
- 19 edits in trunk/LayoutTests
2010-06-03 Pavel Feldman <pfeldman@chromium.org>
Not reviewed: Rebaseline chromium tests as a follow up to r60611.
- platform/chromium-linux/fast/backgrounds/size/backgroundSize15-expected.checksum:
- platform/chromium-linux/fast/backgrounds/size/backgroundSize15-expected.png:
- platform/chromium-linux/fast/borders/svg-as-border-image-expected.checksum:
- platform/chromium-linux/scrollbars/listbox-scrollbar-combinations-expected.checksum:
- platform/chromium-linux/scrollbars/overflow-scrollbar-combinations-expected.checksum:
- platform/chromium-linux/scrollbars/overflow-scrollbar-combinations-expected.png:
- platform/chromium-linux/svg/W3C-SVG-1.1/coords-viewattr-02-b-expected.checksum:
- platform/chromium-linux/svg/W3C-SVG-1.1/coords-viewattr-02-b-expected.png:
- platform/chromium-win/fast/backgrounds/size/backgroundSize15-expected.checksum:
- platform/chromium-win/fast/backgrounds/size/backgroundSize15-expected.png:
- platform/chromium-win/fast/borders/svg-as-border-image-expected.checksum:
- platform/chromium-win/fast/borders/svg-as-border-image-expected.png:
- platform/chromium-win/scrollbars/listbox-scrollbar-combinations-expected.checksum:
- platform/chromium-win/scrollbars/listbox-scrollbar-combinations-expected.png:
- platform/chromium-win/scrollbars/overflow-scrollbar-combinations-expected.checksum:
- platform/chromium-win/scrollbars/overflow-scrollbar-combinations-expected.png:
- platform/chromium-win/svg/W3C-SVG-1.1/coords-viewattr-02-b-expected.checksum:
- platform/chromium-win/svg/W3C-SVG-1.1/coords-viewattr-02-b-expected.png:
- 12:52 AM Changeset in webkit [60612] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, test expectation update.
4 websocket tests don't fail now.
- platform/chromium/test_expectations.txt:
- remove websocket/tests/unicode.html, websocket/tests/send.html, websocket/tests/handshake-error.html and websocket/tests/long-invalid-header.html
- 12:22 AM Changeset in webkit [60611] by
-
- 2 edits in trunk/WebCore
2010-06-03 Pavel Feldman <pfeldman@chromium.org>
Not reviewed. Rolling out aggressive cache part of the r60391
described in the bug below. It was orthogonal to the rest of
the patch and caused regression.
- platform/graphics/skia/ImageSkia.cpp: (WebCore::drawResampledBitmap):
- 12:07 AM Changeset in webkit [60610] by
-
- 2 edits in trunk/WebKit/chromium
2010-06-02 Tony Chang <tony@chromium.org>
Reviewed by Kent Tamura.
[chromium] refactor WebKit.gyp's DRT section so the conditions are less messy
https://bugs.webkit.org/show_bug.cgi?id=40104
- WebKit.gyp:
- 12:03 AM Changeset in webkit [60609] by
-
- 6 edits in trunk
2010-06-02 Tasuku Suzuki <tasuku.suzuki@nokia.com>
Reviewed by Shinichiro Hamaji.
[Qt] Fix compilation with QT_NO_PROPERTIES
https://bugs.webkit.org/show_bug.cgi?id=38324
- Api/qwebpage.cpp: (QWebPage::event):
- Api/qwebpage_p.h:
- WebCoreSupport/InspectorClientQt.cpp: (WebCore::InspectorClientQt::openInspectorFrontend):
2010-06-02 Tasuku Suzuki <tasuku.suzuki@nokia.com>
Reviewed by Shinichiro Hamaji.
[Qt] Fix compilation with QT_NO_PROPERTIES
https://bugs.webkit.org/show_bug.cgi?id=38324
- QtTestBrowser/main.cpp: (LauncherWindow::init):
Jun 2, 2010:
- 10:38 PM Changeset in webkit [60608] by
-
- 5 edits9 adds in trunk
2010-06-02 Darin Fisher <darin@chromium.org>
Reviewed by Brady Eidson.
location.href and outgoing referrer not updated properly by
pushState/replaceState
https://bugs.webkit.org/show_bug.cgi?id=40027
- fast/loader/stateobjects/document-destroyed-navigate-back-with-fragment-scroll.html: Updated this test to account for location being modified by replaceState.
- fast/loader/stateobjects/pushstate-updates-location-expected.txt: Added.
- fast/loader/stateobjects/pushstate-updates-location.html: Added.
- fast/loader/stateobjects/replacestate-updates-location-expected.txt: Added.
- fast/loader/stateobjects/replacestate-updates-location.html: Added.
- http/tests/navigation/pushstate-updates-referrer-expected.txt: Added.
- http/tests/navigation/pushstate-updates-referrer.html: Added.
- http/tests/navigation/replacestate-updates-referrer-expected.txt: Added.
- http/tests/navigation/replacestate-updates-referrer.html: Added.
- http/tests/navigation/resources/check-referrer.html: Added.
2010-06-02 Darin Fisher <darin@chromium.org>
Reviewed by Brady Eidson.
location.href and outgoing referrer not updated properly by
pushState/replaceState
https://bugs.webkit.org/show_bug.cgi?id=40027
Tests: fast/loader/stateobjects/pushstate-updates-location.html
fast/loader/stateobjects/replacestate-updates-location.html
http/tests/navigation/pushstate-updates-referrer.html
http/tests/navigation/replacestate-updates-referrer.html
- dom/Document.cpp: (WebCore::Document::updateURLForPushOrReplaceState): Update the FrameLoader's notion of the current URL as well!
- loader/FrameLoader.cpp: (WebCore::FrameLoader::loadInSameDocument): Use the 'url' parameter instead of m_URL since m_URL might have changed during the handling of the PopState event. Eventually, this will become irrelevant since the PopState event should be dispatched asynchronously, but just in case we patch HashChange to be asynchronous before PopState, this change would be needed.
- 10:25 PM Changeset in webkit [60607] by
-
- 2 edits in trunk/WebKit/chromium
2010-06-02 Tony Chang <tony@chromium.org>
Not reviewed, build fix in downstream chromium.
Fix the path to repack.py so it works in a chromium checkout too.
- WebKit.gyp:
- 10:25 PM Changeset in webkit [60606] by
-
- 2 edits in trunk/WebCore
2010-06-02 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
REGRESSION(60409): document.write is not synchronous when using the HTML5 parser
https://bugs.webkit.org/show_bug.cgi?id=40047
The HTML5 spec states that we should "spin the event loop" while
waiting for stylesheets to load. Currently we do that by yielding
out of the parser when stylesheets are loading. Because it was easy
we made inline <scripts> yield for stylesheet loads as well. However,
this caused document.write() to return after encountering the first
inline <script> tag in many cases which is incorrect. document.write
is supposed to block until the entire document is parsed (including)
executing inline script tags. To match the exiting parser, we'll just
make inline <script> tags not block on stylesheets for now.
This is tested by WebCore/benchmarks/html-parser.html as well
as likely several other tests in LayoutTests which we haven't
triaged yet.
- html/HTML5ScriptRunner.cpp:
(WebCore::HTML5ScriptRunner::executeScript):
- ASSERT that either stylesheets have loaded or we're executing an inline <script> tag.
(WebCore::HTML5ScriptRunner::runScript):
- Remove the code to block inline <script> tags on stylesheet loads.
- 10:00 PM Changeset in webkit [60605] by
-
- 2 edits in trunk/WebCore
2010-06-02 MORITA Hajime <morrita@google.com>
Unreviewd, Chromium windows build fix.
- rendering/RenderThemeChromiumWin.cpp: (WebCore::RenderThemeChromiumWin::paintProgressBar):
- 9:45 PM Changeset in webkit [60604] by
-
- 4 edits in trunk/WebCore
2010-06-02 MORITA Hajime <morrita@google.com>
Reviewed by Kent Tamura.
[Chromium] Support HTML5 <progress> element on Linux.
https://bugs.webkit.org/show_bug.cgi?id=37310
Implemented RenderThemeChromiumSkia::paintProgressBar(), extracing
determinateProgressValueRectFor() from RenderThemeChromiumWin to
RenderThemeChromiumSkia
No new tests. Expectations will come after ENABLE_PROGRESS_BAR get
enabled on chromium.
- rendering/RenderThemeChromiumSkia.cpp: (WebCore::RenderThemeChromiumSkia::determinateProgressValueRectFor): (WebCore::RenderThemeChromiumSkia::indeterminateProgressValueRectFor): (WebCore::RenderThemeChromiumSkia::animationRepeatIntervalForProgressBar): (WebCore::RenderThemeChromiumSkia::animationDurationForProgressBar): (WebCore::RenderThemeChromiumSkia::paintProgressBar): (WebCore::RenderThemeChromiumSkia::progressValueRectFor):
- rendering/RenderThemeChromiumSkia.h:
- rendering/RenderThemeChromiumWin.cpp: (WebCore::RenderThemeChromiumWin::paintProgressBar):
- 9:40 PM Changeset in webkit [60603] by
-
- 2 edits in tags/Safari-534.0.1/JavaScriptCore
Merge r60595.
- 9:40 PM Changeset in webkit [60602] by
-
- 5 edits in tags/Safari-534.0.1
Versioning.
- 9:32 PM Changeset in webkit [60601] by
-
- 1 copy in tags/Safari-534.0.1
New tag.
- 9:28 PM Changeset in webkit [60600] by
-
- 2 edits in trunk/LayoutTests
Unreviewed. Test expectation update.
- platform/qt/Skipped: Add editing/input/page-up-down-scrolls.html
- 9:21 PM Changeset in webkit [60599] by
-
- 1 edit in trunk/LayoutTests/platform/chromium/test_expectations.txt
Unreviewed. Fix a tes_expectation error.
- 9:10 PM Changeset in webkit [60598] by
-
- 4 edits3 adds in trunk/JavaScriptCore
Add value-representation specific sections to the mac export file.
Patch by Mark Rowe <mrowe@apple.com> on 2010-06-02
Reviewed by Gavin Barraclough.
- Configurations/JavaScriptCore.xcconfig:
- DerivedSources.make:
- JavaScriptCore.JSVALUE32_64only.exp: Added.
- JavaScriptCore.JSVALUE32only.exp: Added.
- JavaScriptCore.JSVALUE64only.exp: Added.
- JavaScriptCore.xcodeproj/project.pbxproj:
- 8:36 PM Changeset in webkit [60597] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, test expectation update.
Add fixed-move-after-keyboard-scroll.html temporarily
https://bugs.webkit.org/show_bug.cgi?id=40101
- platform/chromium/test_expectations.txt:
- 8:22 PM Changeset in webkit [60596] by
-
- 2 edits in trunk/WebKit/chromium
2010-06-02 Tony Chang <tony@chromium.org>
Reviewed by Kent Tamura.
[chromium] generate DumpRenderTree.pak on DRT linux
https://bugs.webkit.org/show_bug.cgi?id=40098
- WebKit.gyp:
- 8:15 PM Changeset in webkit [60595] by
-
- 2 edits in trunk/JavaScriptCore
<rdar://problem/8054988> Work around an LLVM GCC code generation bug that results in crashes inside PCRE.
Reviewed by Gavin Barraclough.
- pcre/pcre_exec.cpp:
(repeatInformationFromInstructionOffset): Change the type of instructionOffset to int. There's no good
reason for it to be a short, and using int prevents this code from triggering the LLVM GCC bug.
- 7:53 PM Changeset in webkit [60594] by
-
- 3 edits in trunk/WebKit/chromium
2010-06-02 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r60592.
http://trac.webkit.org/changeset/60592
https://bugs.webkit.org/show_bug.cgi?id=40099
broke the build, need to coordiate updating DEPS (Requested by
tonywork on #webkit).
- DEPS:
- public/WebMediaPlayer.h:
- 7:37 PM Changeset in webkit [60593] by
-
- 5 edits in trunk/WebKit/qt
2010-06-02 Luiz Agostini <luiz.agostini@openbossa.org>
Reviewed by Simon Hausmann.
[Qt] Shared platform plugin
https://bugs.webkit.org/show_bug.cgi?id=39968
Allow several instances of class QtPlatformPlugin to share the QWebKitPlatformPlugin
object provided by a plugin.
Updated plugin interface version number due to ABI breaking change.
- Api/qwebkitplatformplugin.h: (QWebKitPlatformPlugin::~QWebKitPlatformPlugin):
- WebCoreSupport/QtPlatformPlugin.cpp: (WebCore::QtPlatformPlugin::load): (WebCore::QtPlatformPlugin::~QtPlatformPlugin): (WebCore::QtPlatformPlugin::plugin):
- WebCoreSupport/QtPlatformPlugin.h:
- examples/platformplugin/qwebkitplatformplugin.h: (QWebKitPlatformPlugin::~QWebKitPlatformPlugin):
- 7:23 PM Changeset in webkit [60592] by
-
- 3 edits in trunk/WebKit/chromium
2010-06-02 Victoria Kirst <vrk@google.com>
Reviewed by David Levin.
Modifying the WebMediaPlayer interface to be compatible with
a change in chrome.
This is a part 2 of 3 one-sided changes to chrome and WebKit. Chrome
has been updated, so this commit should NOT break chromium anymore.
https://bugs.webkit.org/show_bug.cgi?id=39445
- DEPS: Updated to a newer chrome revision number.
- public/WebMediaPlayer.h: Changed buffered() to be non-const.
- 7:10 PM Changeset in webkit [60591] by
-
- 6 edits2 adds in trunk
2010-06-02 Nico Weber <thakis@chromium.org>
Reviewed by Simon Fraser.
Scroll events are sent twice per keypress for ports that don't have a platformWidget scrollbar.
This was regressed by http://trac.webkit.org/changeset/58615 . Fix this by slightly tweaking
that patch, add a layout test.
- editing/input/page-up-down-scrolls-expected.txt: Added.
- editing/input/page-up-down-scrolls.html: Added.
2010-06-02 Nico Weber <thakis@chromium.org>
Reviewed by Simon Fraser.
Scroll events are sent twice per keypress for ports that don't have a platformWidget scrollbar
https://bugs.webkit.org/show_bug.cgi?id=39918
This was regressed by http://trac.webkit.org/changeset/58615 . Fix this by slightly tweaking
that patch.
Test: editing/input/page-up-down-scrolls.html
- page/FrameView.cpp: (WebCore::FrameView::scrollPositionChanged):
- page/FrameView.h:
- platform/ScrollView.cpp: (WebCore::ScrollView::valueChanged):
- platform/ScrollView.h: (WebCore::ScrollView::repaintFixedElementsAfterScrolling):
- 7:00 PM Changeset in webkit [60590] by
-
- 2 edits in trunk/WebKit/chromium
Unreviewed, emergency fix for test crashes (verbal r+ beforehand from
John Gregg).
Temporarily make notificationObjectDestroyed() a no-op to avoid an
ASSERT failure.
https://bugs.webkit.org/show_bug.cgi?id=40097
- src/NotificationPresenterImpl.cpp:
(WebKit::NotificationPresenterImpl::notificationObjectDestroyed):
- 6:54 PM Changeset in webkit [60589] by
-
- 2 edits in trunk/WebKit/qt
2010-06-02 Raine Makelainen <raine.makelainen@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] On Maemo6 platform auto upper case and predictive text input method hints are not disabled for password field.
https://bugs.webkit.org/show_bug.cgi?id=40062
Introducing Q_WS_MAEMO_6 for Maemo6 specific code. Enabling code that sets input
method hints Qt::ImhNoAutoUppercase and Qt::ImhNoPredictiveText true for Maemo6.
- WebCoreSupport/EditorClientQt.cpp: (WebCore::EditorClientQt::setInputMethodState):
- 6:35 PM Changeset in webkit [60588] by
-
- 1 edit in branches/audio/WebCore/audio/Cone.cpp
Fix build
- 6:35 PM Changeset in webkit [60587] by
-
- 1 edit2 adds in branches/audio/WebCore
For performance/debugging purposes add PerformanceTimer class (mac-only)
- also fixed WebCore xcode project path problems
- 6:33 PM Changeset in webkit [60586] by
-
- 4 edits in trunk/WebKitTools
2010-06-02 Diego Gonzalez <diegohcg@webkit.org>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Make possible run DRT with QGraphicsWebView
https://bugs.webkit.org/show_bug.cgi?id=40016
Make possible to use a environment variable for switching backend.
Usage: QT_DRT_WEBVIEW_MODE=graphics WebKitTools/Scripts/run-webkit-tests --qt
- DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::WebViewGraphicsBased::WebViewGraphicsBased): (WebCore::DumpRenderTree::DumpRenderTree):
- DumpRenderTree/qt/DumpRenderTreeQt.h: (WebCore::DumpRenderTree::setGraphicsBased): (WebCore::DumpRenderTree::isGraphicsBased): (WebCore::WebViewGraphicsBased::graphicsView): (WebCore::WebViewGraphicsBased::setPage):
- Scripts/old-run-webkit-tests:
- 6:19 PM Changeset in webkit [60585] by
-
- 5 edits1 add in trunk/JavaScriptCore
2010-06-02 Jedrzej Nowacki <jedrzej.nowacki@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
Fix the QScriptValue::strictlyEquals function.
Handling for a few edge cases was added.
New autotest that covers the QScriptValue::strictlyEquals function.
[Qt] QScriptValue::strictlyEquals is broken
https://bugs.webkit.org/show_bug.cgi?id=36600
- qt/api/qscriptvalue.cpp: (QScriptValue::strictlyEquals):
- qt/api/qscriptvalue_p.h: (QScriptValuePrivate::strictlyEquals):
- qt/tests/qscriptvalue/qscriptvalue.pro:
- qt/tests/qscriptvalue/tst_qscriptvalue.h:
- qt/tests/qscriptvalue/tst_qscriptvalue_generated_comparison.cpp: Added. (tst_QScriptValue::strictlyEquals_initData): (tst_QScriptValue::strictlyEquals_makeData): (tst_QScriptValue::strictlyEquals_test):
- 6:05 PM Changeset in webkit [60584] by
-
- 3 edits in trunk/WebCore
2010-06-02 Andrey Kosyakov <caseq@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: use platform-specific key designations in shortcuts help for mac
https://bugs.webkit.org/show_bug.cgi?id=39158
- inspector/front-end/KeyboardShortcut.js: (WebInspector.KeyboardShortcut.shortcutToString): (WebInspector.KeyboardShortcut._keyName): (WebInspector.KeyboardShortcut._modifiersToString):
- inspector/front-end/inspector.js: (WebInspector._registerShortcuts):
- 5:27 PM Changeset in webkit [60583] by
-
- 6 edits in trunk/JavaScriptCore
2010-06-02 Jedrzej Nowacki <jedrzej.nowacki@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
New function QScriptEngine::newObject.
The function creates a object of class Object and returns it
as a QScriptValue.
[Qt] QScriptEngine API should contain a newObject function
https://bugs.webkit.org/show_bug.cgi?id=39114
- qt/api/qscriptengine.cpp: (QScriptEngine::newObject):
- qt/api/qscriptengine.h:
- qt/api/qscriptengine_p.cpp: (QScriptEnginePrivate::newObject):
- qt/api/qscriptengine_p.h:
- qt/tests/qscriptengine/tst_qscriptengine.cpp: (tst_QScriptEngine::newObject):
- 4:57 PM Changeset in webkit [60582] by
-
- 2 edits in trunk/WebCore
2010-06-02 Kenneth Russell <kbr@google.com>
Reviewed by Darin Fisher.
Enable WebGL on more platforms even if accelerated compositing is disabled
https://bugs.webkit.org/show_bug.cgi?id=40085
Conditionalize the code which prevents a WebGL rendering context
from being created if accelerated compositing is disabled.
Currently Chromium is the only port which will create a context if
accelerated compositing is disabled; other ports may opt in to
this code path if desired.
Tested with existing WebGL layout tests in Safari and Chromium on
Mac OS X.
- html/HTMLCanvasElement.cpp: (WebCore::HTMLCanvasElement::getContext):
- 4:41 PM Changeset in webkit [60581] by
-
- 3 edits3 deletes in trunk
2010-06-02 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r60580.
http://trac.webkit.org/changeset/60580
https://bugs.webkit.org/show_bug.cgi?id=40087
This broke dragging links if the selection was in a
contentEditable element. (Requested by arv on #webkit).
- editing/selection/click-in-focusable-link-should-not-clear-selection-expected.txt: Removed.
- editing/selection/click-in-focusable-link-should-not-clear-selection.html: Removed.
- editing/selection/script-tests/click-in-focusable-link-should-not-clear-selection.js: Removed.
2010-06-02 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r60580.
http://trac.webkit.org/changeset/60580
https://bugs.webkit.org/show_bug.cgi?id=40087
This broke dragging links if the selection was in a
contentEditable element. (Requested by arv on #webkit).
- page/FocusController.cpp: (WebCore::clearSelectionIfNeeded):
- 2:38 PM Changeset in webkit [60580] by
-
- 3 edits3 adds in trunk
2010-06-02 Erik Arvidsson <arv@chromium.org>
Reviewed by ojan@chromium.org.
REGRESSION: Weird focus behavior affects quoting on University of Washington message board system
https://bugs.webkit.org/show_bug.cgi?id=38548
- editing/selection/click-in-focusable-link-should-not-clear-selection-expected.txt: Added.
- editing/selection/click-in-focusable-link-should-not-clear-selection.html: Added.
- editing/selection/script-tests/click-in-focusable-link-should-not-clear-selection.js: Added. (description.getElementCenter): (doubleClickOnElement): (mouseDownOnElement): (selectionShouldBe):
2010-06-02 Erik Arvidsson <arv@chromium.org>
Reviewed by ojan@chromium.org.
REGRESSION: Weird focus behavior affects quoting on University of Washington message board system
https://bugs.webkit.org/show_bug.cgi?id=38548
Test: editing/selection/click-in-focusable-link-should-not-clear-selection.html
- page/FocusController.cpp: (WebCore::clearSelectionIfNeeded):
- 2:33 PM Changeset in webkit [60579] by
-
- 7 edits8 adds in branches/audio/WebCore
windows build changes to get us compiling and linking (courtesy of Ian Lewis)
- 2:19 PM Changeset in webkit [60578] by
-
- 2 edits in trunk/LayoutTests
2010-06-02 Pavel Feldman <pfeldman@chromium.org>
Not reviewed, layout test fix.
Web Inspector: disable resource tracking on exiting the inspector layout test.
This is a short-term fix while I am working on making sure DRT disables it
automatically on the test exit.
- http/tests/inspector/resource-parameters.html:
- 1:56 PM Changeset in webkit [60577] by
-
- 2 edits in trunk/JavaScriptCore
https://bugs.webkit.org/show_bug.cgi?id=40011
Reviewed by Gavin Barraclough.
Thumb-2 build fix: The offset parameter of ldrh should be encoded as an
imm12 immediate constant in load16. If it is not fit in the instruction
a temporary register has to be used.
- assembler/MacroAssemblerARMv7.h:
(JSC::MacroAssemblerARMv7::load16):
- 1:44 PM Changeset in webkit [60576] by
-
- 2 edits in trunk/LayoutTests
2010-06-02 Eric Seidel <eric@webkit.org>
Unreviewed. Just reverting part of r60556 as requested by Dave Hyatt on webkit-commits@list.webkit.org.
Several layout tests needlessly use invalid HTML
https://bugs.webkit.org/show_bug.cgi?id=39985
css1/box_properties/float_elements_in_series.html
remains invalid HTML, but we can't change it because
css1/ is meant to be a pristine copy of the CSS1 test suite.
- css1/box_properties/float_elements_in_series.html:
- Revert changes to this test. Dave Hyatt points out that although undocumented, this directory is meant to contain a pristine copy of the CSS1 test suite. It really should be documented and/or moved somewhere special, but for now we'll just revert the changes.
- 1:41 PM Changeset in webkit [60575] by
-
- 3 edits in trunk/WebKitTools
Slave lost shouldn't be recognized as build failed.
https://bugs.webkit.org/show_bug.cgi?id=39282
Reviewed by Eric Seidel.
- Scripts/webkitpy/common/net/buildbot.py: Treat slave lost as green.
- Scripts/webkitpy/common/net/buildbot_unittest.py: Add unit test for slave lost.
- 1:11 PM Changeset in webkit [60574] by
-
- 2 edits in trunk/WebCore
Just disable the current version of multi-column layout completely when the new
pagination model is in effect.
Reviewed by Anders Carlsson.
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::setDesiredColumnCountAndWidth):
- 12:37 PM Changeset in webkit [60573] by
-
- 2 edits in trunk/LayoutTests
2010-06-02 Pavel Feldman <pfeldman@chromium.org>
Not reviewed: added new inspector test to Skipped in Tiger for
its loader not reporting the resource size right.
- platform/mac-tiger/Skipped:
- 12:28 PM Changeset in webkit [60572] by
-
- 2 edits in trunk/WebCore
Turn off unforced page breaking at paint time when the new page breaking model is being used.
Reviewed by Anders Carlsson.
- rendering/RenderLineBoxList.cpp:
(WebCore::RenderLineBoxList::paint):
- 12:20 PM Changeset in webkit [60571] by
-
- 2 edits in trunk/WebCore
Don't check page break properties at paint time if we're using the new page breaking model.
Reviewed by Anders Carlsson.
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::paintChildren):
- 11:24 AM Changeset in webkit [60570] by
-
- 2 edits in trunk/WebCore
2010-06-02 Nate Chapin <Nate Chapin>
Reviewed by Dimitri Glazkov.
[V8] Fix an infinite recursion crash when trying to wrap
media elements without a media player.
No test because there isn't a good way to ensure the media player
is off.
- dom/make_names.pl: Call, e.g., V8HTMLElement::wrap(HTMLElement*) instead of toV8(HTMLElement*).
- 10:14 AM Changeset in webkit [60569] by
-
- 3 edits in trunk/WebCore
Notification object ref counting is not correct.
https://bugs.webkit.org/show_bug.cgi?id=39998
Reviewed by Darin Adler.
Return PassRefPtr<Notification> instead of a raw pointer from the create methods
for Web Notifications.
No new tests are needed, as existing tests show the problem when sending the
"display" event asynchronously.
- notifications/Notification.h:
(WebCore::Notification::create):
- notifications/NotificationCenter.h:
(WebCore::NotificationCenter::createHTMLNotification):
(WebCore::NotificationCenter::createNotification):
- 9:21 AM Changeset in webkit [60568] by
-
- 21 edits3 copies in trunk
2010-06-02 Mikhail Naganov <mnaganov@chromium.org>
Reviewed by Yuri Semikhatsky.
Web Inspector: add Console API for retrieving memory stats
Add 'console.memory' property which returns an object. Currently
it has two fields: totalJSHeapSize and usedJSHeapSize. Later, it can be
extended for reporting total browser's memory consumption.
- CMakeLists.txt:
- DerivedSources.cpp:
- DerivedSources.make:
- GNUmakefile.am:
- WebCore.gypi:
- WebCore.pri:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/JSBindingsAllInOne.cpp:
- bindings/js/JSConsoleCustom.cpp: (WebCore::JSConsole::memory):
- bindings/v8/custom/V8ConsoleCustom.cpp: (WebCore::V8Console::memoryAccessorGetter):
- page/Console.h:
- page/Console.idl:
- page/MemoryInfo.cpp: Added. (WebCore::MemoryInfo::MemoryInfo):
- page/MemoryInfo.h: Added. (WebCore::MemoryInfo::create): (WebCore::MemoryInfo::totalJSHeapSize): (WebCore::MemoryInfo::usedJSHeapSize):
- page/MemoryInfo.idl: Added.
- fast/dom/Window/window-properties-expected.txt:
- fast/dom/prototype-inheritance-2-expected.txt:
- platform/gtk/fast/dom/Window/window-properties-expected.txt:
- platform/qt/fast/dom/Window/window-properties-expected.txt:
- platform/win/fast/dom/prototype-inheritance-2-expected.txt:
- 8:20 AM Changeset in webkit [60567] by
-
- 7 edits in trunk/WebCore
2010-06-02 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: support "Continue to Here" in debugger
https://bugs.webkit.org/show_bug.cgi?id=39953
- English.lproj/localizedStrings.js:
- inspector/front-end/BreakpointManager.js: (WebInspector.BreakpointManager.prototype.setOneTimeBreakpoint): (WebInspector.BreakpointManager.prototype.removeOneTimeBreakpoint): (WebInspector.BreakpointManager.prototype.addBreakpoint):
- inspector/front-end/ScriptView.js: (WebInspector.ScriptView): (WebInspector.ScriptView.prototype._continueToLine):
- inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype.continueToLine): (WebInspector.ScriptsPanel.prototype.debuggerPaused):
- inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame):
- inspector/front-end/SourceView.js: (WebInspector.SourceView): (WebInspector.SourceView.prototype._continueToLine): (WebInspector.SourceView.prototype.updateLocalContent):
- 7:31 AM Changeset in webkit [60566] by
-
- 12 edits in trunk
[Qt] Fix the lifecycle of notification objects
https://bugs.webkit.org/show_bug.cgi?id=40003
Reviewed by Kenneth Rohde Christiansen.
WebKit/qt:
Notification objects are not tightly related to the page that created them,
and should be decoupled from the page.
Create one NotificationPresenter that handles all notifications.
Add ref/deref to the notification objects when they are added/removed from
the queue of active notifications. The same technique is used for XMLHttpRequest.
Instead of deleting all notifications associated with a page when the page is navigated,
delete them on a timer, using the same timeout that QSystemTrayIcon is using.
Break up the show() method into smaller methods.
Use OwnPtr instead of raw pointer for QSystemTrayIcon.
Move creating the QIcon to just before showing it in the QSyetemTrayIcon.
No new tests as this is just a refactoring. Existing notifications test cover the code.
- Api/qwebpage.cpp:
(QWebPagePrivate::QWebPagePrivate):
(QWebPagePrivate::~QWebPagePrivate):
- Api/qwebpage_p.h:
- WebCoreSupport/ChromeClientQt.cpp:
(WebCore::ChromeClientQt::notificationPresenter):
- WebCoreSupport/DumpRenderTreeSupportQt.cpp:
(DumpRenderTreeSupportQt::setNotificationsReceiver):
(DumpRenderTreeSupportQt::allowNotificationForOrigin):
- WebCoreSupport/DumpRenderTreeSupportQt.h:
- WebCoreSupport/FrameLoaderClientQt.cpp:
(WebCore::FrameLoaderClientQt::dispatchDidClearWindowObjectInWorld):
- WebCoreSupport/NotificationPresenterClientQt.cpp:
(WebCore::NotificationPresenterClientQt::notificationPresenter):
(WebCore::NotificationIconWrapper::NotificationIconWrapper):
(WebCore::NotificationIconWrapper::~NotificationIconWrapper):
(WebCore::NotificationIconWrapper::close):
(WebCore::NotificationPresenterClientQt::NotificationPresenterClientQt):
(WebCore::NotificationPresenterClientQt::removeClient):
(WebCore::NotificationPresenterClientQt::show):
(WebCore::NotificationPresenterClientQt::displayNotification):
(WebCore::NotificationPresenterClientQt::cancel):
(WebCore::NotificationPresenterClientQt::notificationObjectDestroyed):
(WebCore::NotificationPresenterClientQt::requestPermission):
(WebCore::NotificationPresenterClientQt::sendEvent):
(WebCore::NotificationPresenterClientQt::removeReplacedNotificationFromQueue):
(WebCore::NotificationPresenterClientQt::dumpReplacedIdText):
(WebCore::NotificationPresenterClientQt::dumpShowText):
- WebCoreSupport/NotificationPresenterClientQt.h:
(WebCore::NotificationPresenterClientQt::addClient):
WebKitTools:
Remove the dependency of notifications on QWebPage.
- DumpRenderTree/qt/DumpRenderTreeQt.cpp:
(WebCore::requestPermissionCallback):
(WebCore::WebPage::WebPage):
(WebCore::DumpRenderTree::requestPermission):
- DumpRenderTree/qt/DumpRenderTreeQt.h:
- 7:30 AM Changeset in webkit [60565] by
-
- 18 edits3 deletes in trunk
2010-06-02 Mikhail Naganov <mnaganov@chromium.org>
Unreviewed, rolling out r60563.
http://trac.webkit.org/changeset/60563
https://bugs.webkit.org/show_bug.cgi?id=39646
windows build failed
- fast/dom/Window/window-properties-expected.txt:
- platform/gtk/fast/dom/Window/window-properties-expected.txt:
- platform/qt/fast/dom/Window/window-properties-expected.txt:
2010-06-02 Mikhail Naganov <mnaganov@chromium.org>
Unreviewed, rolling out r60563.
http://trac.webkit.org/changeset/60563
https://bugs.webkit.org/show_bug.cgi?id=39646
windows build failed
- CMakeLists.txt:
- DerivedSources.cpp:
- DerivedSources.make:
- GNUmakefile.am:
- WebCore.gypi:
- WebCore.pri:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/JSConsoleCustom.cpp:
- bindings/v8/custom/V8ConsoleCustom.cpp:
- page/Console.h:
- page/Console.idl:
- page/MemoryInfo.cpp: Removed.
- page/MemoryInfo.h: Removed.
- page/MemoryInfo.idl: Removed.
- 7:14 AM Changeset in webkit [60564] by
-
- 2 edits in trunk/LayoutTests
2010-06-02 Pavel Feldman <pfeldman@chromium.org>
Not reviewed: adding new inspector test into GTK's Skipped.
- platform/gtk/Skipped:
- 7:12 AM Changeset in webkit [60563] by
-
- 18 edits3 copies in trunk
2010-06-02 Mikhail Naganov <mnaganov@chromium.org>
Reviewed by NOBODY (OOPS!).
Web Inspector: add Console API for retrieving memory stats
Add 'console.memory' property which returns an object. Currently
it has two fields: totalJSHeapSize and usedJSHeapSize. Later, it can be
extended for reporting total browser's memory consumption.
- CMakeLists.txt:
- DerivedSources.cpp:
- DerivedSources.make:
- GNUmakefile.am:
- WebCore.gypi:
- WebCore.pri:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/JSConsoleCustom.cpp: (WebCore::JSConsole::memory):
- bindings/v8/custom/V8ConsoleCustom.cpp: (WebCore::V8Console::memoryAccessorGetter):
- page/Console.h:
- page/Console.idl:
- page/MemoryInfo.cpp: Added. (WebCore::MemoryInfo::MemoryInfo):
- page/MemoryInfo.h: Added. (WebCore::MemoryInfo::create): (WebCore::MemoryInfo::totalJSHeapSize): (WebCore::MemoryInfo::usedJSHeapSize):
- page/MemoryInfo.idl: Added.
- fast/dom/Window/window-properties-expected.txt:
- platform/gtk/fast/dom/Window/window-properties-expected.txt:
- platform/qt/fast/dom/Window/window-properties-expected.txt:
- 6:55 AM Changeset in webkit [60562] by
-
- 34 edits4 adds1 delete in trunk
2010-06-02 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: add test for resource parameters.
Test: http/tests/inspector/resource-parameters.html
- inspector/front-end/HAREntry.js: (WebInspector.HAREntry.prototype._buildParameters):
- inspector/front-end/Resource.js: (WebInspector.Resource.prototype._parseParameters):
- inspector/front-end/ResourceView.js: (WebInspector.ResourceView.prototype._refreshParms):
2010-06-02 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: add test for resource parameters.
- http/tests/inspector/inspector-test.js: (onload): (dumpObject): (dumpArray):
- http/tests/inspector/resource-har-conversion-expected.txt:
- http/tests/inspector/resource-har-conversion.html:
- http/tests/inspector/resource-parameters-expected.txt: Added.
- http/tests/inspector/resource-parameters.html: Added.
- http/tests/inspector/resource-tests.js: Added. (resourceURLComparer):
- http/tests/inspector/resources/resource-form-data-receiver-iframe.html:
- inspector/console-format-collections-expected.txt:
- inspector/console-format-expected.txt:
- inspector/console-log-before-inspector-open-expected.txt:
- inspector/console-tests-expected.txt:
- inspector/elements-panel-structure-expected.txt:
- inspector/elements-panel-styles-expected.txt:
- inspector/elements-panel-xhtml-structure-expected.txt:
- inspector/evaluate-in-frontend-expected.txt:
- inspector/styles-source-offsets-expected.txt:
- inspector/syntax-highlight-javascript-expected.txt:
- inspector/timeline-event-dispatch-expected.txt:
- inspector/timeline-layout-expected.txt:
- inspector/timeline-mark-timeline-expected.txt:
- inspector/timeline-network-resource-expected.txt:
- inspector/timeline-paint-expected.txt:
- inspector/timeline-parse-html-expected.txt:
- inspector/timeline-recalculate-styles-expected.txt:
- inspector/timeline-script-tag-1-expected.txt:
- inspector/timeline-script-tag-2-expected.txt:
- inspector/timeline-test.js: (printTimelineRecordProperties):
- platform/chromium-win/inspector/console-log-before-inspector-open-expected.txt: Removed.
- platform/chromium-win/inspector/timeline-event-dispatch-expected.txt:
- platform/chromium-win/inspector/timeline-mark-timeline-expected.txt:
- platform/chromium-win/inspector/timeline-network-resource-expected.txt:
- platform/chromium-win/inspector/timeline-paint-expected.txt:
- platform/chromium-win/inspector/timeline-parse-html-expected.txt:
- 5:48 AM Changeset in webkit [60561] by
-
- 2 edits in trunk/WebCore
[Qt] Fix make install on Symbian for headers in package builds when INSTALL_HEADERS is not defined
Patch by Jocelyn Turcotte <jocelyn.turcotte@nokia.com> on 2010-06-02
Reviewed by Simon Hausmann.
First we wrote inst_headers.output with $$[QT_INSTALL_HEADERS] and then
overwrote it with the $$INSTALL_HEADERS variant without checking if the
variable was set.
Fixed and cleaned up the logic of falling back to $$[QT_INSTALL_HEADERS].
- WebCore.pro:
- 5:31 AM Changeset in webkit [60560] by
-
- 2 edits in trunk/WebKitTools
2010-06-02 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r60559.
http://trac.webkit.org/changeset/60559
https://bugs.webkit.org/show_bug.cgi?id=40055
It broke python unit test (Requested by Ossy on #webkit).
- Scripts/webkitpy/common/net/buildbot.py:
- 5:12 AM Changeset in webkit [60559] by
-
- 2 edits in trunk/WebKitTools
Slave lost shouldn't be recognized as build failed.
https://bugs.webkit.org/show_bug.cgi?id=39282
Reviewed by Eric Seidel.
- Scripts/webkitpy/common/net/buildbot.py:
- 4:14 AM Changeset in webkit [60558] by
-
- 7 edits in trunk/WebCore
2010-06-02 Xan Lopez <xlopez@igalia.com>
Reviewed by Gustavo Noronha.
[GTK] Style fixes for the generated code in DOM bindings
https://bugs.webkit.org/show_bug.cgi?id=39949
Get rid of extra spaces and wrong indentation in the generated
code.
- bindings/scripts/CodeGeneratorGObject.pm:
- bindings/scripts/test/GObject/WebKitDOMTestCallback.cpp: (webkit_dom_test_callback_callback_with_class1param): (webkit_dom_test_callback_callback_with_class2param): (webkit_dom_test_callback_callback_with_non_bool_return_type): (webkit_dom_test_callback_set_property): (webkit_dom_test_callback_get_property):
- bindings/scripts/test/GObject/WebKitDOMTestCallback.h:
- bindings/scripts/test/GObject/WebKitDOMTestInterface.cpp: (webkit_dom_test_interface_set_property): (webkit_dom_test_interface_get_property):
- bindings/scripts/test/GObject/WebKitDOMTestObj.cpp: (webkit_dom_test_obj_void_method): (webkit_dom_test_obj_void_method_with_args): (webkit_dom_test_obj_int_method): (webkit_dom_test_obj_int_method_with_args): (webkit_dom_test_obj_obj_method): (webkit_dom_test_obj_obj_method_with_args): (webkit_dom_test_obj_method_that_requires_all_args): (webkit_dom_test_obj_method_that_requires_all_args_and_throws): (webkit_dom_test_obj_serialized_value): (webkit_dom_test_obj_method_with_exception): (webkit_dom_test_obj_with_dynamic_frame): (webkit_dom_test_obj_with_dynamic_frame_and_arg): (webkit_dom_test_obj_with_dynamic_frame_and_optional_arg): (webkit_dom_test_obj_with_dynamic_frame_and_user_gesture): (webkit_dom_test_obj_with_dynamic_frame_and_user_gesture_asad): (webkit_dom_test_obj_with_script_state_void): (webkit_dom_test_obj_with_script_state_obj): (webkit_dom_test_obj_with_script_state_void_exception): (webkit_dom_test_obj_with_script_state_obj_exception): (webkit_dom_test_obj_method_with_optional_arg): (webkit_dom_test_obj_method_with_non_optional_arg_and_optional_arg): (webkit_dom_test_obj_method_with_non_optional_arg_and_two_optional_args): (webkit_dom_test_obj_get_read_only_int_attr): (webkit_dom_test_obj_get_read_only_string_attr): (webkit_dom_test_obj_get_read_only_test_obj_attr): (webkit_dom_test_obj_get_int_attr): (webkit_dom_test_obj_set_int_attr): (webkit_dom_test_obj_get_long_long_attr): (webkit_dom_test_obj_set_long_long_attr): (webkit_dom_test_obj_get_unsigned_long_long_attr): (webkit_dom_test_obj_set_unsigned_long_long_attr): (webkit_dom_test_obj_get_string_attr): (webkit_dom_test_obj_set_string_attr): (webkit_dom_test_obj_get_test_obj_attr): (webkit_dom_test_obj_set_test_obj_attr): (webkit_dom_test_obj_get_attr_with_exception): (webkit_dom_test_obj_set_attr_with_exception): (webkit_dom_test_obj_get_attr_with_setter_exception): (webkit_dom_test_obj_set_attr_with_setter_exception): (webkit_dom_test_obj_get_attr_with_getter_exception): (webkit_dom_test_obj_set_attr_with_getter_exception): (webkit_dom_test_obj_get_script_string_attr): (webkit_dom_test_obj_set_property): (webkit_dom_test_obj_get_property): (webkit_dom_test_obj_class_init):
- bindings/scripts/test/GObject/WebKitDOMTestObj.h:
- 4:10 AM Changeset in webkit [60557] by
-
- 2 edits in trunk/LayoutTests
2010-06-02 Sergio Villar Senin <svillar@igalia.com>
Reviewed by Xan Lopez.
[GTK] tests failing with leftover unload handlers
https://bugs.webkit.org/show_bug.cgi?id=30585
- platform/gtk/Skipped:
- 3:45 AM Changeset in webkit [60556] by
-
- 7 edits in trunk/LayoutTests
2010-06-02 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Several layout tests needlessly use invalid HTML
https://bugs.webkit.org/show_bug.cgi?id=39985
This change does not change behavior or reduce test coverage.
It only makes our test suite more clear by making our non-parser
tests not bother to test parser quirks which are already covered
by our parsing test suites.
Two invalid cases which are already tested by
the html5lib tests as well as others.
- Unclosed <title> swallowing the document is covered by <!doctype html><title>foo/title><link></head><body>X and other subtests in html5lib/resources/tests16.dat Missing </title> is also covered by the (invalid) test: fast/js/missing-title-end-tag-js.html
- Unclosed <tag swallowing the next tag is covered by: fast/invalid/016.html. I suspect it's also covered by various html5lib tests but proved difficult to grep for.
- css1/box_properties/float_elements_in_series.html:
- Unclosed <td> tags swallow the following <img> tags. This parser quirk is tested by the HTML5 tests and is an intentional behavior change as part of HTML5. No need for this test to depend on WebKit's old parser behavior.
- editing/selection/inactive-selection.html:
- Same as above. Here <div swallows the <script> tag.
- editing/selection/select-text-overflow-ellipsis.html:
- An unclosed <title> will swallow the whole document. Intentional HTML5 change, tested by HTML5 test suite and no need to depend on the old title behavior here.
- fast/dom/title-content-write-set.html:
- Again, no need to leave an unclosed title.
- fast/forms/select-set-inner.html:
- Unclosed <body swallows <p>
- fast/js/exception-linenums-in-html-2.html:
- Unclosed <title> swallows the document.
- html5lib/resources/webkit01.dat:
- Added a test for <img<img> to make sure it's covered.
- 3:16 AM Changeset in webkit [60555] by
-
- 10 edits3 adds in trunk
2010-06-02 Andrey Kosyakov <caseq@chromium.org>
Reviewed by Pavel Feldman.
WebInspector: Added conversion of inspector's resource representation into HAR.
Moved common resource accessors from ResourceView to Resource.
https://bugs.webkit.org/show_bug.cgi?id=30567
Test: http/tests/inspector/resource-har-conversion.html
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- inspector/front-end/HAREntry.js: Added. (WebInspector.HAREntry): (WebInspector.HAREntry.prototype.build): (WebInspector.HAREntry.prototype._buildRequest): (WebInspector.HAREntry.prototype._buildResponse): (WebInspector.HAREntry.prototype._buildContent): (WebInspector.HAREntry.prototype._buildTimings): (WebInspector.HAREntry.prototype._buildHeaders): (WebInspector.HAREntry.prototype._buildPostData): (WebInspector.HAREntry.prototype._buildParameters): (WebInspector.HAREntry.prototype._buildParameter): (WebInspector.HAREntry.prototype._toMilliseconds):
- inspector/front-end/Resource.js: (WebInspector.Resource): (WebInspector.Resource.prototype.set url): (WebInspector.Resource.prototype.get receiveDuration): (WebInspector.Resource.prototype.requestHeaderValue): (WebInspector.Resource.prototype.get requestFormData): (WebInspector.Resource.prototype.set requestFormData): (WebInspector.Resource.prototype.responseHeaderValue): (WebInspector.Resource.prototype.get queryParameters): (WebInspector.Resource.prototype.get formParameters): (WebInspector.Resource.prototype._parseParameters): (WebInspector.Resource.prototype._headerValue):
- inspector/front-end/ResourceView.js: (WebInspector.ResourceView.prototype._refreshQueryString): (WebInspector.ResourceView.prototype._refreshFormData): (WebInspector.ResourceView.prototype._refreshParms):
- inspector/front-end/WebKit.qrc:
- inspector/front-end/inspector.html:
- 3:10 AM Changeset in webkit [60554] by
-
- 3 edits in trunk/WebCore
2010-06-02 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r60547.
http://trac.webkit.org/changeset/60547
https://bugs.webkit.org/show_bug.cgi?id=40051
It made fast/overflow/overflow-with-local-background-
attachment.html crash (Requested by Ossy on #webkit).
- notifications/Notification.h: (WebCore::Notification::create):
- notifications/NotificationCenter.h: (WebCore::NotificationCenter::createHTMLNotification): (WebCore::NotificationCenter::createNotification):
- 3:07 AM Changeset in webkit [60553] by
-
- 12 edits in trunk
2010-06-02 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
HTML5 parser does not track line numbers
https://bugs.webkit.org/show_bug.cgi?id=39984
Update our expectations to show the proper line numbers.
These new line numbers match what the old parser produces.
- html5lib/runner-expected-html5.txt:
- html5lib/webkit-resumer-expected-html5.txt:
2010-06-02 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
HTML5 parser does not track line numbers
https://bugs.webkit.org/show_bug.cgi?id=39984
This adds rudimentary line-number tracking to the HTML5Lexer.
We'll still need to handle \r\n cases eventually, but this
fixes the vast majority of our line-number related failures.
Fixes 268 layout tests. :)
- html/HTML5Lexer.cpp:
(WebCore::HTML5Lexer::reset):
- Reset m_lineNumber to 0.
(WebCore::HTML5Lexer::consumeEntity):
- Pass m_lineNumber to advance().
(WebCore::HTML5Lexer::nextToken):
- Pass m_lineNumber to advance().
- html/HTML5Lexer.h:
(WebCore::HTML5Lexer::lineNumber):
- Expose m_lineNumber for HTML5Tokenizer.
(WebCore::HTML5Lexer::columnNumber):
- Mirrors the implementation in the old HTMLTokenizer. we might some day support column number tracking in the Lexer. It certainly would be possible.
- html/HTML5ScriptRunner.cpp:
(WebCore::HTML5ScriptRunner::HTML5ScriptRunner):
- ASSERT we're passed a host.
(WebCore::HTML5ScriptRunner::sourceFromPendingScript):
- Use PendingScript.startingLineNumber when PendingScript is an inline script.
(WebCore::HTML5ScriptRunner::execute):
- Now expects a start line number passed from the TreeBuilder.
(WebCore::HTML5ScriptRunner::runScript):
- Now expects a start line number.
- html/HTML5ScriptRunner.h:
(WebCore::HTML5ScriptRunner::PendingScript::PendingScript):
- Track startingLineNumber for any inline script.
- html/HTML5Tokenizer.cpp:
(WebCore::HTML5Tokenizer::begin):
- Add a FIXME. The old HTMLTokenizer resets its "lexer" state here.
(WebCore::HTML5Tokenizer::pumpLexer):
- Pass scriptStartLine to the HTML5ScriptRunner
(WebCore::HTML5Tokenizer::lineNumber):
- Implementation for Tokenizer.h
(WebCore::HTML5Tokenizer::columnNumber):
- Implementation for Tokenizer.h
- html/HTML5Tokenizer.h:
- html/HTML5TreeBuilder.cpp:
(WebCore::HTML5TreeBuilder::HTML5TreeBuilder):
- Initialize the new line number tracking variables.
(WebCore::HTML5TreeBuilder::handleScriptEndTag):
- Save off the line number from the start tag to pass to the ScriptRunner.
(WebCore::HTML5TreeBuilder::takeScriptToProcess):
- Return the line number from the start tag.
(WebCore::HTML5TreeBuilder::passTokenToLegacyParser):
- Save off the line number of ever script start tag we see.
- html/HTML5TreeBuilder.h:
- Keep both the line number of the last start tag, and the line number of the script we know we're expecting our caller to run before resuming parsing. These are separate to keep the code clean, especially since the last script start tag line number is a hack specific to using the old HTMLParser.
- 2:54 AM Changeset in webkit [60552] by
-
- 2 edits in trunk/WebCore
2010-06-02 Joseph Pecoraro <Joseph Pecoraro>
Reviewed by Pavel Feldman.
Web Inspector: Timeline should nicely format the Timer timeout
https://bugs.webkit.org/show_bug.cgi?id=40040
- inspector/front-end/TimelinePanel.js: (WebInspector.TimelinePanel.FormattedRecord.prototype._generatePopupContent): Format the Timer's timeout time.
- 2:49 AM Changeset in webkit [60551] by
-
- 1 edit2 deletes in trunk/LayoutTests
Unreviewed. Test expectation update.
Remove Chromium-Mac expectation of mask-changes.html. The results
is now identical to platform/mac.
- platform/chromium-mac/svg/custom/mask-changes-expected.checksum: Removed.
- platform/chromium-mac/svg/custom/mask-changes-expected.png: Removed.
- 2:30 AM Changeset in webkit [60550] by
-
- 3 edits1 delete in trunk/LayoutTests
Unreviewed. Test expectation update.
Update Windows and Linux results of empty-clip-path.html and
empty-mask.html for r60541.
- platform/chromium-linux/svg/custom/empty-mask-expected.txt: Removed.
- platform/chromium-win/svg/custom/empty-clip-path-expected.txt:
- platform/chromium-win/svg/custom/empty-mask-expected.txt:
- 2:14 AM Changeset in webkit [60549] by
-
- 2 edits in trunk/WebKitTools
2010-06-02 Tony Gentilcore <tonyg@chromium.org>
Reviewed by Eric Seidel.
Fix crash caused when assigned_to is disabled
https://bugs.webkit.org/show_bug.cgi?id=40039
- Scripts/webkitpy/common/net/bugzilla.py:
- 2:01 AM Changeset in webkit [60548] by
-
- 2 edits in trunk/WebCore
2010-06-02 Vangelis Kokkevis <vangelis@chromium.org>
Reviewed by Dimitri Glazkov.
[Chromium] Clamp dirtyRect updates of composited layer contents to the size
of the layer to avoid writing outside texture bounds.
https://bugs.webkit.org/show_bug.cgi?id=40030
- platform/graphics/chromium/LayerChromium.cpp: (WebCore::LayerChromium::updateTextureContents):
- 1:45 AM Changeset in webkit [60547] by
-
- 3 edits in trunk/WebCore
2010-06-02 Yael Aharon <yael.aharon@nokia.com>
Reviewed by Darin Adler.
Notification object ref counting is not correct.
https://bugs.webkit.org/show_bug.cgi?id=39998
Return PassRefPtr<Notification> instead of a raw pointer from the create methods
for Web Notifications.
No new tests are needed, as existing tests show the problem when sending the
"display" event asynchronously.
- notifications/Notification.h: (WebCore::Notification::create):
- notifications/NotificationCenter.h: (WebCore::NotificationCenter::createHTMLNotification): (WebCore::NotificationCenter::createNotification):
- 1:30 AM Changeset in webkit [60546] by
-
- 4 edits in trunk
2010-06-02 Qi Zhang <qi.2.zhang@nokia.com>
Reviewed by Dirk Schulze.
[Qt] Image shadow doesn't work
https://bugs.webkit.org/show_bug.cgi?id=37804
Enable image shadow basic test and disable image shadow transparent test case, that failed
because of the Qt known issue on transparent image.
- platform/qt/Skipped:
2010-06-02 Qi Zhang <qi.2.zhang@nokia.com>
Reviewed by Dirk Schulze.
[Qt] Image shadow doesn't work
https://bugs.webkit.org/show_bug.cgi?id=37804
Implement the code for image shadow
- platform/graphics/qt/ImageQt.cpp: (WebCore::BitmapImage::draw):
- 1:18 AM Changeset in webkit [60545] by
-
- 2 edits in trunk/WebCore
2010-06-02 Vangelis Kokkevis <vangelis@chromium.org>
Reviewed by Darin Fisher.
Adding the precision qualifier to fragment shaders used by the GL
compositor in chromium to turn them into valid GLSL ES.
https://bugs.webkit.org/show_bug.cgi?id=40022
- platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::initializeSharedGLObjects):
- 1:04 AM Changeset in webkit [60544] by
-
- 2 edits in trunk/WebCore
2010-06-02 Laszlo Gombos <Laszlo Gombos>
Reviewed by David Levin.
Fix type qualifier is meaningless on cast type in SVGFEColorMatrixElement::build
https://bugs.webkit.org/show_bug.cgi?id=40015
No new tests as there is no new functionality.
Remove const from the cast type.
- svg/SVGFEColorMatrixElement.cpp: (WebCore::SVGFEColorMatrixElement::build):
- 12:50 AM Changeset in webkit [60543] by
-
- 17 edits in trunk
2010-06-02 Sterling Swigart <sswigart@google.com>
Reviewed by David Levin.
Image Resizer Patch 0: Added compilation argument to conditionally compile pending patches.
https://bugs.webkit.org/show_bug.cgi?id=39906
- configure.ac:
2010-06-02 Sterling Swigart <sswigart@google.com>
Reviewed by David Levin.
Image Resizer Patch 0: Added compilation argument to conditionally compile pending patches.
https://bugs.webkit.org/show_bug.cgi?id=39906
- Configurations/FeatureDefines.xcconfig:
2010-06-02 Sterling Swigart <sswigart@google.com>
Reviewed by David Levin.
Image Resizer Patch 0: Added compilation argument to conditionally compile pending patches.
https://bugs.webkit.org/show_bug.cgi?id=39906
- Configurations/FeatureDefines.xcconfig:
- GNUmakefile.am:
- WebCore.pri:
2010-06-02 Sterling Swigart <sswigart@google.com>
Reviewed by David Levin.
Image Resizer Patch 0: Added compilation argument to conditionally compile pending patches.
https://bugs.webkit.org/show_bug.cgi?id=39906
- features.gypi:
2010-06-02 Sterling Swigart <sswigart@google.com>
Reviewed by David Levin.
Image Resizer Patch 0: Added compilation argument to conditionally compile pending patches.
https://bugs.webkit.org/show_bug.cgi?id=39906
- Configurations/FeatureDefines.xcconfig:
2010-06-02 Sterling Swigart <sswigart@google.com>
Reviewed by David Levin.
Image Resizer Patch 0: Added compilation argument to conditionally compile pending patches.
https://bugs.webkit.org/show_bug.cgi?id=39906
- win/tools/vsprops/FeatureDefines.vsprops:
- win/tools/vsprops/FeatureDefinesCairo.vsprops:
2010-06-02 Sterling Swigart <sswigart@google.com>
Reviewed by David Levin.
Image Resizer Patch 0: Added compilation argument to conditionally compile pending patches.
https://bugs.webkit.org/show_bug.cgi?id=39906
- Scripts/build-webkit:
- 12:18 AM Changeset in webkit [60542] by
-
- 2 edits in trunk/LayoutTests
2010-06-02 Dirk Schulze <krit@webkit.org>
Uneviewed.
SVG repaintRect should be empty if content got clipped away
https://bugs.webkit.org/show_bug.cgi?id=39965
Baseline update for Qt.
- platform/qt/svg/custom/empty-mask-expected.txt:
