Timeline
Jun 11, 2010:
- 11:21 PM Changeset in webkit [61053] by
-
- 3 edits2 deletes in trunk
2010-06-11 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r61052.
http://trac.webkit.org/changeset/61052
https://bugs.webkit.org/show_bug.cgi?id=40517
"Broke fast/forms/caret-rtl.html on Mac bots" (Requested by
eseidel on #webkit).
- fast/html/hidden-attr-expected.txt: Removed.
- fast/html/hidden-attr.html: Removed.
2010-06-11 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r61052.
http://trac.webkit.org/changeset/61052
https://bugs.webkit.org/show_bug.cgi?id=40517
"Broke fast/forms/caret-rtl.html on Mac bots" (Requested by
eseidel on #webkit).
- html/HTMLElement.cpp: (WebCore::HTMLElement::mapToEntry): (WebCore::HTMLElement::parseMappedAttribute):
- 9:54 PM Applications using WebKit edited by
- (diff)
- 6:28 PM Changeset in webkit [61052] by
-
- 3 edits2 adds in trunk
2010-06-11 Maciej Stachowiak <mjs@apple.com>
Reviewed by Ojan Vafai.
Implement HTML5 hidden attribute
https://bugs.webkit.org/show_bug.cgi?id=40511
Test: fast/html/hidden-attr.html
Note: I used the mapped attribute mechanism for this instead of a rule in the UA stylesheet
to avoid a performance hit from adding a global attribute rule to the UA stylesheet.
- html/HTMLElement.cpp: (WebCore::HTMLElement::mapToEntry): Pick up hidden as a global mapped attribute. (WebCore::HTMLElement::parseMappedAttribute): Map hidden attribute to display: none.
2010-06-11 Maciej Stachowiak <mjs@apple.com>
Reviewed by Ojan Vafai.
Implement HTML5 hidden attribute
https://bugs.webkit.org/show_bug.cgi?id=40511
- fast/html/hidden-attr-expected.txt: Added.
- fast/html/hidden-attr.html: Added. Test static and dynamic cases of hidden attribute.
- 5:54 PM Changeset in webkit [61051] by
-
- 1 edit1 add in trunk/LayoutTests
2010-06-11 Simon Fraser <Simon Fraser>
Add expected result missing from the previous commit.
- svg/text/text-style-invalid-expected.txt: Added.
- 5:52 PM Changeset in webkit [61050] by
-
- 4 edits1 add in trunk
2010-06-10 Abhishek Arya <inferno@chromium.org>
Reviewed by Dave Hyatt.
Do not render CSS Styles :first-letter and :first-line in a SVG text element context.
https://bugs.webkit.org/show_bug.cgi?id=40031
Test: svg/text/text-style-invalid.svg
- rendering/RenderSVGText.cpp: (WebCore::RenderSVGText::firstLineBlock): (WebCore::RenderSVGText::updateFirstLetter):
- rendering/RenderSVGText.h:
- 5:24 PM Changeset in webkit [61049] by
-
- 2 edits in trunk/WebKit2
Use -Os for optimized builds instead of -02. -02 wasn't giving the
right trade off at this time.
Reviewed by Mark Rowe.
- Configurations/Base.xcconfig:
- 5:17 PM Changeset in webkit [61048] by
-
- 13 edits in trunk/WebKit2
Move WKRetain and WKRelease overloaded functions out of WKRetainPtr
and into the files of the type they overload (eg, WKRetain(WKFrameRef
moves to WKFrame.h)).
Reviewed by Anders Carlsson.
- UIProcess/API/C/WKBase.h:
- UIProcess/API/C/WKContext.h:
- UIProcess/API/C/WKFrame.h:
- UIProcess/API/C/WKFramePolicyListener.h:
- UIProcess/API/C/WKNavigationData.h:
- UIProcess/API/C/WKPage.h:
- UIProcess/API/C/WKPageNamespace.h:
- UIProcess/API/C/WKPreferences.h:
- UIProcess/API/C/WKString.h:
- UIProcess/API/C/WKURL.h:
- UIProcess/API/cpp/WKRetainPtr.h:
- UIProcess/API/win/WKView.h:
- 4:55 PM Changeset in webkit [61047] by
-
- 2 edits in trunk/WebKitTools
2010-06-10 Ojan Vafai <ojan@chromium.org>
Reviewed by Eric Seidel.
upload all patches that lack in-rietveld to rietveld
https://bugs.webkit.org/show_bug.cgi?id=40444
If it's a patch, then we'll try to upload it as long as it
doesn't have in-rietveld set. No longer set in-rietveld? since
it's not needed.
- Scripts/webkitpy/common/net/bugzilla.py:
- 4:44 PM Changeset in webkit [61046] by
-
- 5 edits in trunk
2010-06-11 Kenneth Russell <kbr@google.com>
Reviewed by Dimitri Glazkov.
getParameter with UNPACK_FLIP_Y_WEBGL and UNPACK_PREMULTIPLY_ALPHA_WEBGL is buggy
https://bugs.webkit.org/show_bug.cgi?id=40506
Return the data members of WebGLRenderingContext for these
parameter queries rather than asking OpenGL, which knows nothing
about them.
- html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::getParameter):
2010-06-11 Kenneth Russell <kbr@google.com>
Reviewed by Dimitri Glazkov.
getParameter with UNPACK_FLIP_Y_WEBGL and UNPACK_PREMULTIPLY_ALPHA_WEBGL is buggy
https://bugs.webkit.org/show_bug.cgi?id=40506
Return the data members of WebGLRenderingContext for these
parameter queries rather than asking OpenGL, which knows nothing
about them.
- fast/canvas/webgl/gl-get-calls-expected.txt:
- fast/canvas/webgl/gl-get-calls.html:
- 4:38 PM Changeset in webkit [61045] by
-
- 3 edits2 adds in trunk
2010-06-11 Simon Fraser <Simon Fraser>
Reviewed by Dr Dan Bernstein.
REGRESSION: crash when unloading an iFrame with Flash from the DOM
https://bugs.webkit.org/show_bug.cgi?id=40161
<rdar://problem/7994710>
Null-check the ownerElement of the RenderView's document when unhooking the compositing
root of an iframe whose layers are parented via the enclosing document. Fixes a crash when
dynamically removing such an iframe.
Test: compositing/iframes/remove-iframe-crash.html
- rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::detachRootPlatformLayer):
- 4:33 PM Changeset in webkit [61044] by
-
- 3 edits2 adds in trunk
2010-06-11 Abhishek Arya <inferno@chromium.org>
Reviewed by David Hyatt.
Don't process floats if parent node is not a RenderBlock.
https://bugs.webkit.org/show_bug.cgi?id=40033
Test: svg/text/clear-floats-crash.svg
- rendering/RenderBlock.cpp: (WebCore::RenderBlock::clearFloats):
2010-06-11 Abhishek Arya <inferno@chromium.org>
Reviewed by David Hyatt.
Tests that we do not crash when clearing floats during SVG load.
https://bugs.webkit.org/show_bug.cgi?id=40033
- svg/text/clear-floats-crash-expected.txt: Added.
- svg/text/clear-floats-crash.svg: Added.
- 3:50 PM Changeset in webkit [61043] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, fixing Chromium test bots.
- platform/chromium/test_expectations.txt:
Adding MISSING expectation for the fast/css/nested-rounded-corners.html
- 3:41 PM Changeset in webkit [61042] by
-
- 3 edits in trunk/LayoutTests
2010-06-11 Kenneth Russell <kbr@google.com>
Unreviewed, test fix.
gl-get-calls failing apparently due to UNPACK_ALIGNMENT test
https://bugs.webkit.org/show_bug.cgi?id=40502
Disabled new test of UNPACK_ALIGNMENT which appears to be failing
on some of the bots.
- fast/canvas/webgl/gl-get-calls-expected.txt:
- fast/canvas/webgl/gl-get-calls.html:
- 3:10 PM Changeset in webkit [61041] by
-
- 3 edits in trunk/WebCore
2010-06-11 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r61036.
http://trac.webkit.org/changeset/61036
https://bugs.webkit.org/show_bug.cgi?id=40499
broke chromium compile (Requested by jamesr on #webkit).
- bindings/v8/SerializedScriptValue.cpp:
- bindings/v8/SerializedScriptValue.h: (WebCore::SerializedScriptValue::deserializeAndSetProperty): (WebCore::SerializedScriptValue::create): (WebCore::SerializedScriptValue::createFromWire): (WebCore::SerializedScriptValue::release): (WebCore::SerializedScriptValue::SerializedScriptValue):
- 3:08 PM Changeset in webkit [61040] by
-
- 1 edit2 adds in trunk/LayoutTests
2010-06-11 James Robinson <jamesr@chromium.org>
Unreviewed baselines for new test on Qt/Gtk.
Qt and Gtk appear to produce layers of slightly different sizes
for blocks with rounded corners, probably due to roundoff difference
in the graphics layers. Since the diffs are +/- 1 pixel, just
rebaselining.
- platform/gtk/fast/css/nested-rounded-corners-expected.txt: Added.
- platform/qt/fast/css/nested-rounded-corners-expected.txt: Added.
- 3:03 PM Changeset in webkit [61039] by
-
- 20 edits in trunk
2010-06-11 Kenneth Russell <kbr@google.com>
Reviewed by Dimitri Glazkov.
Add texImage2D and texSubImage2D signatures with internal format, etc.
https://bugs.webkit.org/show_bug.cgi?id=40318
Added new texImage2D and texSubImage2D entry points following
WebGL specification changes. Added UNPACK_FLIP_Y_WEBGL and
UNPACK_PREMULTIPLY_ALPHA_WEBGL pixelStorei parameters, honored
them for the new entry points taking HTML elements, and added
support to getParameter. Added warnings to the console for calls
to the obsolete entry points, which will be removed in a few
weeks. Updated all layout tests to use the new entry points and
pixelStorei parameters, and associated expectations. No other new
tests.
- html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::WebGLRenderingContext): (WebCore::WebGLRenderingContext::getParameter): (WebCore::WebGLRenderingContext::pixelStorei): (WebCore::WebGLRenderingContext::texImage2DImpl): (WebCore::WebGLRenderingContext::texImage2D): (WebCore::WebGLRenderingContext::texSubImage2DImpl): (WebCore::WebGLRenderingContext::texSubImage2D): (WebCore::WebGLRenderingContext::printWarningToConsole):
- html/canvas/WebGLRenderingContext.h:
- html/canvas/WebGLRenderingContext.idl:
- platform/graphics/GraphicsContext3D.h: (WebCore::GraphicsContext3D::):
2010-06-11 Kenneth Russell <kbr@google.com>
Reviewed by Dimitri Glazkov.
Add texImage2D and texSubImage2D signatures with internal format, etc.
https://bugs.webkit.org/show_bug.cgi?id=40318
Added new texImage2D and texSubImage2D entry points following
WebGL specification changes. Added UNPACK_FLIP_Y_WEBGL and
UNPACK_PREMULTIPLY_ALPHA_WEBGL pixelStorei parameters, honored
them for the new entry points taking HTML elements, and added
support to getParameter. Added warnings to the console for calls
to the obsolete entry points, which will be removed in a few
weeks. Updated all layout tests to use the new entry points and
pixelStorei parameters, and associated expectations. No other new
tests.
- fast/canvas/webgl/bug-32364-expected.txt:
- fast/canvas/webgl/bug-32364.html:
- fast/canvas/webgl/bug-32888.html:
- fast/canvas/webgl/gl-get-calls-expected.txt:
- fast/canvas/webgl/gl-get-calls.html:
- fast/canvas/webgl/resources/utils3d.js: (doLoadImageTexture):
- fast/canvas/webgl/script-tests/texImageTest.js:
- fast/canvas/webgl/tex-image-and-sub-image-2d-with-image-data-expected.txt:
- fast/canvas/webgl/tex-image-and-sub-image-2d-with-image-data.html:
- fast/canvas/webgl/tex-image-and-sub-image-2d-with-image-expected.txt:
- fast/canvas/webgl/tex-image-and-sub-image-2d-with-image.html:
- fast/canvas/webgl/texImage2DImageDataTest.html:
- fast/canvas/webgl/texImageTest-expected.txt:
- fast/canvas/webgl/texture-npot.html:
- 2:43 PM Fixing page breaking edited by
- (diff)
- 2:42 PM WikiStart edited by
- (diff)
- 2:42 PM Fixing page breaking created by
- 2:33 PM Changeset in webkit [61038] by
-
- 3 edits in trunk/LayoutTests
Roll out the failing part of fast/canvas/webgl/get-active-test.html (failed in Chrome in Mac)
- 2:24 PM QtWebKitContrib edited by
- Added more details on how to track QtWebKit release staging branches (diff)
- 2:08 PM Changeset in webkit [61037] by
-
- 4 edits4 adds in trunk
2010-06-11 James Robinson <jamesr@chromium.org>
Reviewed by Dimitri Glazkov.
[chromium] Skia mispaints pages with border-radius
https://bugs.webkit.org/show_bug.cgi?id=40456
Skia mispaints pages that have border radius set in some cases. The bug is in the anti aliased
clip path logic used to implement anti aliased curves in Skia. Since Skia internally only supports
1-bit clips, anti aliased clipping is emulated by creating a new alpha layer, storing a set of
clip paths on the side, and then 'erasing' the regions outside the clip. See r49641.
PlatformContextSkia maintains a stack of PlatformContextSkia::State objects that preserve information
like fill color, drawing mode, etc that is manipulated by GraphicsContext::save() /
GraphicsContext::restore() calls as well some internal functions. Whenever a new State object is pushed
a new copy of the current State object is pushed onto the top of this stack using the copy c'tor. The
set of anti alias clip paths is also stored on the State object, but not copied when new entries are
added as the paths only apply to that entry on the stack.
The bug is that the state stack is stored in a WTF::Vector. When this vector exceeds its capacity
(by default at 16 elements) all of the existing State entries are copied into the new buffer using
State's copy constructor. This does not preserve the anti alias clip paths, so when the State entries
are popped the anti aliasing info is lost. This corrupts all further paint operations since it results
in inbalanced save/restore calls to the underlying SkCanvas.
The fix is to make the PlatformContextSkia::State copy constructor copy all fields and to add a new
function PlatformContextSkia::State::cloneInheritedProperties to use when pushing new State entries
that copies everything except for the anti aliased clip paths.
Test: fast/css/nested-rounded-corners.html
- platform/graphics/skia/PlatformContextSkia.cpp: (PlatformContextSkia::State::State): (PlatformContextSkia::State::cloneInheritedProperties): (PlatformContextSkia::save):
2010-06-11 James Robinson <jamesr@chromium.org>
Reviewed by Dimitri Glazkov.
[chromium] Skia mispaints pages with border-radius
https://bugs.webkit.org/show_bug.cgi?id=40456
Tests deeply nested divs with border-radius.
- fast/css/nested-rounded-corners-expected.txt: Added.
- fast/css/nested-rounded-corners.html: Added.
- platform/chromium/test_expectations.txt
- platform/chromium-linux/fast/css/nested-rounded-corners-expected.checksum: Added.
- platform/chromium-linux/fast/css/nested-rounded-corners-expected.png: Added.
- 1:41 PM Changeset in webkit [61036] by
-
- 3 edits in trunk/WebCore
2010-06-11 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Darin Fisher.
[V8] Clean up SerializedScriptValue
https://bugs.webkit.org/show_bug.cgi?id=40482
SerializedScriptValue doesn't follow WebKit's style guidelines very well
and needlessly inlines quite a bit within the .h file. This change cleans
things up. No funcitonal changes.
No change in behavior.
- bindings/v8/SerializedScriptValue.cpp: (WebCore::SerializedScriptValue::deserializeAndSetProperty): (WebCore::SerializedScriptValue::create): (WebCore::SerializedScriptValue::createFromWire): (WebCore::SerializedScriptValue::release): (WebCore::SerializedScriptValue::SerializedScriptValue):
- bindings/v8/SerializedScriptValue.h:
- 1:20 PM Changeset in webkit [61035] by
-
- 2 edits in trunk/WebKit/chromium
2010-06-11 James Hawkins <jhawkins@chromium.org>
Reviewed by Darin Fisher.
[Chromium] Notify the WebView when the AutoFill popup hides.
- src/AutoFillPopupMenuClient.cpp: (WebKit::AutoFillPopupMenuClient::selectionCleared):
- 12:57 PM Changeset in webkit [61034] by
-
- 2 edits in trunk/WebKit/qt
2010-06-11 Jesus Sanchez-Palencia <jesus@webkit.org>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Typo error in QWebPluginFactory Documentation
https://bugs.webkit.org/show_bug.cgi?id=40490
- Api/qwebpluginfactory.cpp:
- 12:37 PM Changeset in webkit [61033] by
-
- 3 edits in trunk/LayoutTests
2010-06-11 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
tables/mozilla/bugs/bug1188.html needlessly depends on HTML Parser text node handling
https://bugs.webkit.org/show_bug.cgi?id=40485
The old HTMLTokenizer handled invalid close tags like "< /A>" as part
of the lexing step. The HTML5 parser specification dictates that
the tokenization/lexing step is to output each character token in sequence
and that the parser is to insert emitted character tokens into the last
parser-created text node. In our current HTML5Lexer-with-old-HTMLParser
setup, we gather up character tokens and output them all in one bunch
(to match the expectations of the old parser).
In the case of "foo< /A>" the HTML5Lexer sees the '<', switched out of the
"data" state and emits all pending characters assuming the start of a close tag.
When it sees the ' ' it switches back to the "data" state. The HTML5Lexer
expects that the parser will coalesce the separate characters it emitted
into one text node. Since we haven't implemented the parser side of the
HTML5 spec, for now we don't. This is a known issue we will address after
enabling the HTML5Lexer, as we start to write an HTML5-compliant parser.
This text-node-coalescing behavior is already tested by numerous html5lib
tests, however this was the only layout test which hit this quirk. I've
added yet another html5lib test of this exact case just for good measure.
- html5lib/resources/webkit01.dat:
- Add a test of this exact case to make sure we don't miss it when implementing an HTML5-compliant parser.
- tables/mozilla/bugs/bug1188.html:
- Replace "< /A>" with "< /A>" to avoid hitting this lexing quirk.
- 12:23 PM Changeset in webkit [61032] by
-
- 2 edits in trunk/WebKit/chromium
2010-06-11 Tony Gentilcore <tonyg@chromium.org>
Reviewed by Dimitri Glazkov.
Roll chromium DEPS 49376:49521
https://bugs.webkit.org/show_bug.cgi?id=40488
- DEPS:
- 12:11 PM Changeset in webkit [61031] by
-
- 3 edits in trunk/WebCore
2010-06-11 Anton Muhin <antonm@chromium.org>
Reviewed by Adam Barth.
[v8] Introduce single element caches for WebCore::String to v8::String conversions
https://bugs.webkit.org/show_bug.cgi?id=40435
Measurements show that for some web apps (GMail, Wave) and some scenarios
(intensive reading and/or keeping a tab open for a long time),
hit rate lies in 30--50% interval.
Inlining fast case gives another minor performance win.
- bindings/v8/V8Binding.cpp: (WebCore::getStringCache): (WebCore::v8ExternalStringSlow):
- bindings/v8/V8Binding.h: (WebCore::v8ExternalString):
- 12:00 PM Changeset in webkit [61030] by
-
- 3 edits in trunk/WebCore
2010-06-11 Leandro Pereira <leandro@profusion.mobi>
Reviewed by Gustavo Noronha Silva.
[EFL] Build fix: remove unneeded file (npapi.cpp) and add
other files that got added to the tree.
http://webkit.org/b/40331
- CMakeLists.txt:
- CMakeListsEfl.txt:
- 11:48 AM Changeset in webkit [61029] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, update Chromium test expectations.
- platform/chromium/test_expectations.txt:
http://trac.webkit.org/changeset/60999 regressed acid3.html image match on Chromium Mac.
http://trac.webkit.org/changeset/61020 modified get-active-test.html that now fails on Chromium Mac.
- 11:46 AM Changeset in webkit [61028] by
-
- 7 edits in trunk/WebCore
2010-06-11 Tony Gentilcore <tonyg@chromium.org>
Reviewed by Eric Seidel.
Fix fast/forms/preserveFormDuringResidualStyle.html for HTML5 Parser.
https://bugs.webkit.org/show_bug.cgi?id=40454
This required exposing the HTMLParser which we definitely don't want to
do, but the good news is that it can go away when the HTMLParser goes
away.
No new tests because covered by fast/forms/preserve/FormDuringResidualStyle.html.
- dom/Tokenizer.h: (WebCore::Tokenizer::htmlParser):
- html/HTML5Tokenizer.cpp: (WebCore::HTML5Tokenizer::htmlParser):
- html/HTML5Tokenizer.h:
- html/HTML5TreeBuilder.h: (WebCore::HTML5TreeBuilder::htmlParser):
- html/HTMLFormControlElement.cpp: (WebCore::HTMLFormControlElement::removedFromTree):
- html/HTMLTokenizer.h: (WebCore::HTMLTokenizer::htmlParser):
- 11:22 AM Changeset in webkit [61027] by
-
- 10 edits in trunk
2010-06-11 Kenneth Russell <kbr@google.com>
Reviewed by Dimitri Glazkov.
Delete custom JSC bindings for bufferData, texImage2D and texSubImage2D
https://bugs.webkit.org/show_bug.cgi?id=40443
Deleted custom JSC bindings for bufferData, texImage2D and
texSubImage2D and fixed minor associated issues in code generator
and IDL. Updated fast/canvas/webgl/texImageTest-expected.txt,
which now runs as intended. Ran all layout tests, including WebGL
tests, in Safari.
- bindings/js/JSWebGLRenderingContextCustom.cpp:
- Deleted custom bindings.
- bindings/scripts/CodeGeneratorJS.pm:
- Made overload helper functions static to fix compiler warnings.
- Added needed isObject check for overloads between object and non-object arguments.
- Added JSValue::encode to exception return path, needed on Leopard in particular.
- html/HTMLCanvasElement.idl:
- html/HTMLImageElement.idl:
- html/HTMLVideoElement.idl:
- Added GenerateNativeConverter extended attribute.
- html/canvas/WebGLRenderingContext.idl:
- Deleted #ifdefs for custom JSC bindings.
2010-06-11 Kenneth Russell <kbr@google.com>
Reviewed by Dimitri Glazkov.
Delete custom JSC bindings for bufferData, texImage2D and texSubImage2D
https://bugs.webkit.org/show_bug.cgi?id=40443
Deleted custom JSC bindings for bufferData, texImage2D and
texSubImage2D and fixed minor associated issues in code generator
and IDL. Updated fast/canvas/webgl/texImageTest-expected.txt,
which now runs as intended. Ran all layout tests, including WebGL
tests, in Safari.
- fast/canvas/webgl/script-tests/texImageTest.js:
- fast/canvas/webgl/texImageTest-expected.txt:
- 10:54 AM Changeset in webkit [61026] by
-
- 1 edit2 adds in trunk/LayoutTests
Written by Dave Moore <davemoore@google.com>.
https://bugs.webkit.org/show_bug.cgi?id=22741
innerHTML, forms and images don't play well together
This was fixed already (in bug 34076), just landing an additional test.
- fast/forms/form-image-access-by-name-expected.txt: Added.
- fast/forms/form-image-access-by-name.html: Added.
- 10:42 AM Changeset in webkit [61025] by
-
- 2 edits in trunk/WebCore
[wx] Build fix, add KillRingNone.cpp until we can implement it.
- 9:49 AM Changeset in webkit [61024] by
-
- 2 edits in trunk/WebKitTools
2010-06-10 Ojan Vafai <ojan@chromium.org>
Reviewed by Darin Fisher.
Fix rietveld upload when message length > 100 characters
https://bugs.webkit.org/show_bug.cgi?id=40457
- Scripts/webkitpy/common/net/rietveld.py:
- 9:17 AM Changeset in webkit [61023] by
-
- 3 edits1 add in trunk/WebCore
2010-06-11 Hans Wennborg <hans@chromium.org>
Reviewed by Jeremy Orlow.
DOM storage should only create databases when needed
https://bugs.webkit.org/show_bug.cgi?id=40301
As soon as a page attempts to use localstorage, StorageAreaSync will
create an empty database if one doesn't already exist. This can lead to
lots of unnecessary database files. In particular, they are created
even when the privacy settings or private browsing mode disallow
localstorage data, which may seem odd to the user.
Database creation should be put off in StorageAreaSync until it is time
to actually write something to the database.
Tests:
manual-tests/localstorage-empty-database.html
- manual-tests/localstorage-empty-database.html: Added.
- storage/StorageAreaSync.cpp: (WebCore::StorageAreaSync::StorageAreaSync): (WebCore::StorageAreaSync::openDatabase): (WebCore::StorageAreaSync::performImport): (WebCore::StorageAreaSync::sync):
- storage/StorageAreaSync.h: (WebCore::StorageAreaSync::):
- 9:04 AM Changeset in webkit [61022] by
-
- 4 edits in trunk/WebCore
2010-06-11 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Eric Seidel.
Perl scripts for bindings don't use strict keyword.
As result some problems in the script code were not detected at compile stage.
https://bugs.webkit.org/show_bug.cgi?id=40468
- bindings/scripts/CodeGenerator.pm:
- bindings/scripts/IDLParser.pm:
- bindings/scripts/IDLStructure.pm:
- 8:28 AM Changeset in webkit [61021] by
-
- 2 edits in trunk/WebCore
2010-06-11 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
HTML5Tokenizer should not delete itself while running scripts
https://bugs.webkit.org/show_bug.cgi?id=40458
Tested by fast/dom/document-clear.html
- html/HTML5Tokenizer.cpp:
(WebCore::HTML5Tokenizer::attemptToEnd):
- Don't ever end() while running scripts. This matches the old HTMLTokenizer.cpp
- 8:16 AM Changeset in webkit [61020] by
-
- 3 edits1 move3 adds2 deletes in trunk
2010-06-11 Zhenyao Mo <zmo@google.com>
Reviewed by Dimitri Glazkov.
getActiveUniform must ensure names of arrays end in "[0]"
https://bugs.webkit.org/show_bug.cgi?id=38709
- fast/canvas/webgl/get-active-test-expected.txt: Copied from LayoutTests/fast/canvas/webgl/getActiveTest-expected.txt, modified to test array names.
- fast/canvas/webgl/get-active-test.html: Copied from LayoutTests/fast/canvas/webgl/getActiveTest.html.
- fast/canvas/webgl/getActiveTest-expected.txt: Removed.
- fast/canvas/webgl/getActiveTest.html: Removed.
- fast/canvas/webgl/resources/intArrayUniformShader.vert: Added, with array uniform.
- fast/canvas/webgl/script-tests/get-active-test.js: Copied from LayoutTests/fast/canvas/webgl/script-tests/getActiveTest.js, modified to test array names.
- fast/canvas/webgl/script-tests/getActiveTest.js: Removed.
2010-06-11 Zhenyao Mo <zmo@google.com>
Reviewed by Dimitri Glazkov.
getActiveUniform must ensure names of arrays end in "[0]"
https://bugs.webkit.org/show_bug.cgi?id=38709
Test: fast/canvas/webgl/get-active-test.html
- html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::getActiveAttrib): Append "[0]" to the name if needed.
- 8:03 AM Changeset in webkit [61019] by
-
- 7 edits in trunk
2010-06-11 Zhenyao Mo <zmo@google.com>
Reviewed by Dimitri Glazkov.
readPixels with negative width/height should generate INVALID_VALUE and return
https://bugs.webkit.org/show_bug.cgi?id=39704
- fast/canvas/webgl/read-pixels-expected.txt: Add test cases for non-positive width/height.
- fast/canvas/webgl/read-pixels.html: Ditto.
2010-06-11 Zhenyao Mo <zmo@google.com>
Reviewed by Dimitri Glazkov.
readPixels with negative width/height should generate INVALID_VALUE and return
https://bugs.webkit.org/show_bug.cgi?id=39704
- html/canvas/WebGLRenderingContext.cpp: Deal with negative width/height. (WebCore::WebGLRenderingContext::readPixels):
- html/canvas/WebGLRenderingContext.h: Change width/height type from unsigned long to long.
- html/canvas/WebGLRenderingContext.idl: Ditto.
- 7:50 AM Changeset in webkit [61018] by
-
- 7 edits in trunk
2010-06-11 Zhenyao Mo <zmo@google.com>
Reviewed by Dimitri Glazkov.
uniform* entry points must ignore the call if a null WebGLUniformLocation is passed
https://bugs.webkit.org/show_bug.cgi?id=38707
- fast/canvas/webgl/null-uniform-location-expected.txt: No error is generated if a null WebGLUniformLocation is passed to uniform*().
- fast/canvas/webgl/script-tests/null-uniform-location.js: Ditto.
- fast/canvas/webgl/script-tests/uniform-location.js: Ditto.
- fast/canvas/webgl/uniform-location-expected.txt: Ditto.
2010-06-11 Zhenyao Mo <zmo@google.com>
Reviewed by Dimitri Glazkov.
uniform* entry points must ignore the call if a null WebGLUniformLocation is passed
https://bugs.webkit.org/show_bug.cgi?id=38707
- html/canvas/WebGLRenderingContext.cpp: uniform* entry points ignore the call if a null WebGLUniformLocation is passed. (WebCore::WebGLRenderingContext::uniform1f): (WebCore::WebGLRenderingContext::uniform1fv): (WebCore::WebGLRenderingContext::uniform1i): (WebCore::WebGLRenderingContext::uniform1iv): (WebCore::WebGLRenderingContext::uniform2f): (WebCore::WebGLRenderingContext::uniform2fv): (WebCore::WebGLRenderingContext::uniform2i): (WebCore::WebGLRenderingContext::uniform2iv): (WebCore::WebGLRenderingContext::uniform3f): (WebCore::WebGLRenderingContext::uniform3fv): (WebCore::WebGLRenderingContext::uniform3i): (WebCore::WebGLRenderingContext::uniform3iv): (WebCore::WebGLRenderingContext::uniform4f): (WebCore::WebGLRenderingContext::uniform4fv): (WebCore::WebGLRenderingContext::uniform4i): (WebCore::WebGLRenderingContext::uniform4iv): (WebCore::WebGLRenderingContext::uniformMatrix2fv): (WebCore::WebGLRenderingContext::uniformMatrix3fv): (WebCore::WebGLRenderingContext::uniformMatrix4fv):
- 7:38 AM Changeset in webkit [61017] by
-
- 6 edits4 adds4 deletes in trunk
2010-06-11 Zhenyao Mo <zmo@google.com>
Reviewed by Dimitri Glazkov.
drawElements/drawArrays should validate input parameters according to GLES2 spec
https://bugs.webkit.org/show_bug.cgi?id=38700
- fast/canvas/webgl/draw-arrays-out-of-bounds-expected.txt: Copied from LayoutTests/fast/canvas/webgl/drawArraysOutOfBounds-expected.txt, and fix a few test cases.
- fast/canvas/webgl/draw-arrays-out-of-bounds.html: Copied from LayoutTests/fast/canvas/webgl/drawArraysOutOfBounds.html, and fix a few test cases.
- fast/canvas/webgl/draw-elements-out-of-bounds-expected.txt: Copied from LayoutTests/fast/canvas/webgl/drawElementssOutOfBounds-expected.txt, and fix a few test cases.
- fast/canvas/webgl/draw-elements-out-of-bounds.html: Copied from LayoutTests/fast/canvas/webgl/drawElementssOutOfBounds.html, and fix a few test cases.
- fast/canvas/webgl/drawArraysOutOfBounds-expected.txt: Removed.
- fast/canvas/webgl/drawArraysOutOfBounds.html: Removed.
- fast/canvas/webgl/drawElementssOutOfBounds-expected.txt: Removed.
- fast/canvas/webgl/drawElementssOutOfBounds.html: Removed.
- fast/canvas/webgl/resources/webgl-test.js: Add helper functions for easy test of gl function errors. (getGLErrorAsString): (shouldGenerateGLError):
2010-06-11 Zhenyao Mo <zmo@google.com>
Reviewed by Dimitri Glazkov.
drawElements/drawArrays should validate input parameters according to GLES2 spec
https://bugs.webkit.org/show_bug.cgi?id=38700
Tests: fast/canvas/webgl/draw-arrays-out-of-bounds.html
fast/canvas/webgl/draw-elements-out-of-bounds.html
- html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::drawArrays): Validate input parameters. (WebCore::WebGLRenderingContext::drawElements): Ditto. (WebCore::WebGLRenderingContext::validateDrawMode): Validate mode for draw{Arrays/Elements}.
- html/canvas/WebGLRenderingContext.h: Add validateDrawMode, fix incorrect parameter types.
- html/canvas/WebGLRenderingContext.idl: Fix incorrect parameter types.
- 7:25 AM Changeset in webkit [61016] by
-
- 10 edits2 adds in trunk
2010-06-11 Luiz Agostini <luiz.agostini@openbossa.org>, Kenneth Rohde Christiansen <kenneth@webkit.org>
Reviewed by Antti Koivisto.
CSS3 Media Queries are not serialized according to CSSOM
https://bugs.webkit.org/show_bug.cgi?id=39220
Added test for testing the serialization, plus updated current
tests to take serialization into account.
- fast/css/insertRule-media-expected.txt:
- fast/css/insertRule-media.html:
- fast/css/resources/insertRule-media.js:
- fast/media/media-query-serialization-expected.txt: Added.
- fast/media/media-query-serialization.html: Added.
2010-06-11 Luiz Agostini <luiz.agostini@openbossa.org>
Reviewed by Antti Koivisto.
CSS3 Media Queries are not serialized according to CSSOM
https://bugs.webkit.org/show_bug.cgi?id=39220
MediaQuery serialization according to specification
http://dev.w3.org/csswg/cssom/#serializing-media-queries.
MediaQuery objects now ignore duplicated expressions. MediaQueryEvaluator::eval()
now does not proccess MediaQuery objects that are known to be invalid.
Test: fast/media/media-query-serialization.html
- css/MediaQuery.cpp: (WebCore::stringCompare): (WebCore::MediaQuery::serialize): (WebCore::MediaQuery::MediaQuery): (WebCore::MediaQuery::~MediaQuery): (WebCore::MediaQuery::operator==): (WebCore::MediaQuery::cssText): (WebCore::MediaQuery::append):
- css/MediaQuery.h: (WebCore::MediaQuery::ignored): (WebCore::MediaQuery::begin): (WebCore::MediaQuery::end):
- css/MediaQueryExp.cpp: (WebCore::MediaQueryExp::serialize):
- css/MediaQueryExp.h:
- css/MediaQueryEvaluator.cpp: (WebCore::MediaQueryEvaluator::eval):
- 7:02 AM Changeset in webkit [61015] by
-
- 23 edits in trunk
2010-06-10 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Steve Block.
Implement more of IndexedDB's Indexes and ObjectStores
https://bugs.webkit.org/show_bug.cgi?id=40424
Clean up both of these classes a bit and add create/open/remove
methods as needed.
Tests in a future patch (promise).
- storage/IDBDatabase.h:
- storage/IDBDatabaseImpl.cpp: (WebCore::IDBDatabaseImpl::objectStores): (WebCore::IDBDatabaseImpl::createObjectStore): (WebCore::IDBDatabaseImpl::objectStore): (WebCore::IDBDatabaseImpl::removeObjectStore):
- storage/IDBDatabaseImpl.h: (WebCore::IDBDatabaseImpl::name): (WebCore::IDBDatabaseImpl::description): (WebCore::IDBDatabaseImpl::version):
- storage/IDBDatabaseRequest.cpp: (WebCore::IDBDatabaseRequest::IDBDatabaseRequest): (WebCore::IDBDatabaseRequest::createObjectStore): (WebCore::IDBDatabaseRequest::objectStore): (WebCore::IDBDatabaseRequest::removeObjectStore):
- storage/IDBDatabaseRequest.h: (WebCore::IDBDatabaseRequest::create): (WebCore::IDBDatabaseRequest::name): (WebCore::IDBDatabaseRequest::description): (WebCore::IDBDatabaseRequest::version): (WebCore::IDBDatabaseRequest::objectStores):
- storage/IDBDatabaseRequest.idl:
- storage/IDBObjectStore.h:
- storage/IDBObjectStoreImpl.h:
- storage/IDBObjectStoreRequest.cpp: (WebCore::IDBObjectStoreRequest::get): (WebCore::IDBObjectStoreRequest::add): (WebCore::IDBObjectStoreRequest::modify): (WebCore::IDBObjectStoreRequest::addOrModify): (WebCore::IDBObjectStoreRequest::remove): (WebCore::IDBObjectStoreRequest::createIndex): (WebCore::IDBObjectStoreRequest::index): (WebCore::IDBObjectStoreRequest::removeIndex):
- storage/IDBObjectStoreRequest.h:
- storage/IDBObjectStoreRequest.idl:
2010-06-10 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Steve Block.
Implement more of IndexedDB's Indexes and ObjectStores
https://bugs.webkit.org/show_bug.cgi?id=40424
Add plumbing for both of these classes.
- public/WebIDBDatabase.h: (WebKit::WebIDBDatabase::name): (WebKit::WebIDBDatabase::description): (WebKit::WebIDBDatabase::version): (WebKit::WebIDBDatabase::objectStores): (WebKit::WebIDBDatabase::objectStore): (WebKit::WebIDBDatabase::removeObjectStore):
- public/WebIDBObjectStore.h: (WebKit::WebIDBObjectStore::indexNames): (WebKit::WebIDBObjectStore::createIndex): (WebKit::WebIDBObjectStore::index): (WebKit::WebIDBObjectStore::removeIndex):
- src/IDBDatabaseProxy.cpp: (WebCore::IDBDatabaseProxy::name): (WebCore::IDBDatabaseProxy::description): (WebCore::IDBDatabaseProxy::version): (WebCore::IDBDatabaseProxy::objectStores): (WebCore::IDBDatabaseProxy::objectStore): (WebCore::IDBDatabaseProxy::removeObjectStore):
- src/IDBDatabaseProxy.h:
- src/IDBObjectStoreProxy.cpp: (WebCore::IDBObjectStoreProxy::indexNames): (WebCore::IDBObjectStoreProxy::createIndex): (WebCore::IDBObjectStoreProxy::index): (WebCore::IDBObjectStoreProxy::removeIndex):
- src/IDBObjectStoreProxy.h:
- src/WebIDBDatabaseImpl.cpp: (WebKit::WebIDBDatabaseImpl::WebIDBDatabaseImpl): (WebKit::WebIDBDatabaseImpl::name): (WebKit::WebIDBDatabaseImpl::description): (WebKit::WebIDBDatabaseImpl::version): (WebKit::WebIDBDatabaseImpl::objectStores): (WebKit::WebIDBDatabaseImpl::createObjectStore): (WebKit::WebIDBDatabaseImpl::objectStore): (WebKit::WebIDBDatabaseImpl::removeObjectStore):
- src/WebIDBDatabaseImpl.h:
- src/WebIDBObjectStoreImpl.cpp: (WebKit::WebIDBObjectStoreImpl::WebIDBObjectStoreImpl): (WebKit::WebIDBObjectStoreImpl::name): (WebKit::WebIDBObjectStoreImpl::keyPath): (WebKit::WebIDBObjectStoreImpl::indexNames): (WebKit::WebIDBObjectStoreImpl::createIndex): (WebKit::WebIDBObjectStoreImpl::index): (WebKit::WebIDBObjectStoreImpl::removeIndex):
- src/WebIDBObjectStoreImpl.h:
- 6:47 AM Changeset in webkit [61014] by
-
- 20 edits in trunk
2010-06-11 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: Enable serialization/deserialization of the frontend state
https://bugs.webkit.org/show_bug.cgi?id=40228
WebCore:
- inspector/InspectorBackend.cpp: (WebCore::InspectorBackend::saveApplicationSettings): (WebCore::InspectorBackend::saveSessionSettings):
- inspector/InspectorBackend.h:
- inspector/InspectorBackend.idl:
- inspector/InspectorController.cpp: (WebCore::InspectorController::InspectorController): (WebCore::InspectorController::setSessionSettings): (WebCore::InspectorController::populateScriptObjects): (WebCore::InspectorController::didCommitLoad):
- inspector/InspectorController.h:
- inspector/InspectorFrontend.cpp: (WebCore::InspectorFrontend::populateApplicationSettings): (WebCore::InspectorFrontend::populateSessionSettings):
- inspector/InspectorFrontend.h:
- inspector/front-end/ConsoleView.js: (WebInspector.ConsoleView.prototype._settingsLoaded): (WebInspector.ConsoleView.prototype._enterKeyPressed.printResult): (WebInspector.ConsoleView.prototype._enterKeyPressed):
- inspector/front-end/EventListenersSidebarPane.js: (WebInspector.EventListenersSidebarPane.prototype._settingsLoaded): (WebInspector.EventListenersSidebarPane.prototype): ():
- inspector/front-end/InspectorBackendStub.js: (.WebInspector.InspectorBackendStub.prototype.saveApplicationSettings): (.WebInspector.InspectorBackendStub.prototype.saveSessionSettings):
- inspector/front-end/ResourceView.js: (WebInspector.ResourceView.prototype._selectTab): (WebInspector.ResourceView.prototype._selectHeadersTab): (WebInspector.ResourceView.prototype.selectContentTab):
- inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel.prototype._createStatusbarButtons): (WebInspector.ResourcesPanel.prototype._settingsLoaded): (WebInspector.ResourcesPanel.prototype._toggleLargerResources):
- inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype._showScriptOrResource): (WebInspector.ScriptsPanel.prototype._addScriptToFilesMenu):
- inspector/front-end/Settings.js: (WebInspector.populateApplicationSettings): (WebInspector.populateSessionSettings): (WebInspector.Settings): (WebInspector.Settings.prototype.reset): (WebInspector.Settings.prototype._load): (WebInspector.Settings.prototype._set):
- inspector/front-end/StylesSidebarPane.js: (WebInspector.StylesSidebarPane.prototype._settingsLoaded): (WebInspector.StylesSidebarPane.prototype.update): (WebInspector.StylesSidebarPane.prototype._changeSetting): (WebInspector.StylesSidebarPane.prototype._changeColorFormat): (WebInspector.ComputedStyleSidebarPane.settingsLoaded): (WebInspector.ComputedStyleSidebarPane.showInheritedToggleFunction): (WebInspector.ComputedStyleSidebarPane):
- inspector/front-end/WatchExpressionsSidebarPane.js: (WebInspector.WatchExpressionsSidebarPane): (WebInspector.WatchExpressionsSidebarPane.prototype._settingsLoaded): (WebInspector.WatchExpressionsSection): (WebInspector.WatchExpressionsSection.prototype.saveExpressions):
- inspector/front-end/inspector.js: (WebInspector.loaded): (WebInspector.reset):
Webkit/chromium:
- src/js/InspectorControllerImpl.js: (devtools.InspectorBackendImpl):
- 6:37 AM Changeset in webkit [61013] by
-
- 2 edits in trunk/WebKit/chromium
2010-06-10 S√∏ren Gjesse <sgjesse@chromium.org>
Reviewed by Pavel Feldman.
V8: Chromium test expectations not matching improved V8 JavaScript stepping
https://bugs.webkit.org/show_bug.cgi?id=40419
Update test expetations to match chaged V8 break locations.
- src/js/Tests.js:
- 6:31 AM Changeset in webkit [61012] by
-
- 20 edits in trunk
2010-06-10 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: Port performSearch from InjectedScript to InspectorDOMAgent.
- inspector/InjectedScriptHost.cpp: (WebCore::InjectedScriptHost::addNodesToSearchResult):
- inspector/InspectorBackend.cpp: (WebCore::InspectorBackend::performSearch): (WebCore::InspectorBackend::searchCanceled):
- inspector/InspectorBackend.h:
- inspector/InspectorBackend.idl:
- inspector/InspectorDOMAgent.cpp: (WebCore::): (WebCore::InspectorDOMAgent::InspectorDOMAgent): (WebCore::InspectorDOMAgent::~InspectorDOMAgent): (WebCore::InspectorDOMAgent::performSearch): (WebCore::InspectorDOMAgent::searchCanceled): (WebCore::InspectorDOMAgent::onMatchJobsTimer): (WebCore::InspectorDOMAgent::reportNodesAsSearchResults):
- inspector/InspectorDOMAgent.h: (WebCore::MatchJob::~MatchJob): (WebCore::MatchJob::MatchJob): (WebCore::MatchJob::addNodesToResults):
- inspector/InspectorFrontend.cpp: (WebCore::InspectorFrontend::addNodesToSearchResult):
- inspector/InspectorFrontend.h:
- inspector/InspectorResource.cpp: (WebCore::InspectorResource::updateScriptObject):
- inspector/front-end/ElementsPanel.js: (WebInspector.ElementsPanel.prototype.searchCanceled): (WebInspector.ElementsPanel.prototype.performSearch): (WebInspector.ElementsPanel.prototype.addNodesToSearchResult):
- inspector/front-end/InjectedScript.js: (injectedScriptConstructor):
- inspector/front-end/InjectedScriptAccess.js:
2010-06-10 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: Port performSearch from InjectedScript to InspectorDOMAgent.
- src/js/InspectorControllerImpl.js: (devtools.InspectorBackendImpl):
2010-06-10 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: Port performSearch from InjectedScript to InspectorDOMAgent.
- inspector/elements-panel-search.html:
- 6:17 AM Changeset in webkit [61011] by
-
- 4 edits in trunk/WebCore
2010-06-11 Mikhail Naganov <mnaganov@chromium.org>
Reviewed by Pavel Feldman.
[Chromium] Restore 'console.profiles' access.
- bindings/v8/ScriptProfiler.cpp: (WebCore::ScriptProfiler::stop):
- bindings/v8/custom/V8ConsoleCustom.cpp: (WebCore::V8Console::profilesAccessorGetter):
- inspector/InspectorController.cpp: (WebCore::InspectorController::stopUserInitiatedProfiling):
- 5:53 AM Changeset in webkit [61010] by
-
- 4 edits2 adds in trunk/LayoutTests
2010-06-07 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: add a test for dumping global object in the console.
- http/tests/inspector/inspector-test.js: (frontend_dumpTreeOutline): (frontend_dumpTreeItem):
- inspector/console-dir-global-expected.txt: Added.
- inspector/console-dir-global.html: Added.
- inspector/elements-tests.js: (frontend_dumpStyleTreeItem):
- 5:48 AM Changeset in webkit [61009] by
-
- 2 edits in trunk/WebCore
2010-06-10 Nikita Vasilyev <me@elv1s.ru>
Reviewed by Pavel Feldman.
Web Inspector: Make a close brace in Styles pane selectable.
https://bugs.webkit.org/show_bug.cgi?id=40157
- inspector/front-end/inspector.css: (.styles-selector): (.styles-section .properties li): (.styles-section):
- 5:39 AM Changeset in webkit [61008] by
-
- 3 edits in trunk/WebCore
2010-06-11 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: localize missing script source message
https://bugs.webkit.org/show_bug.cgi?id=40467
- English.lproj/localizedStrings.js:
- inspector/InspectorController.cpp: (WebCore::InspectorController::didParseSource): fixed typo in comment.
- 5:28 AM Changeset in webkit [61007] by
-
- 2 edits in trunk/WebKit/chromium
2010-06-11 Vangelis Kokkevis <vangelis@chromium.org>
Reviewed by David Levin.
[chromium] Adding a build dependency to the gles2 C library to the webkit_unit_tests
project to allow it to link when WebCore is compiled with the ACCELERATED_COMPOSITING
flag.
https://bugs.webkit.org/show_bug.cgi?id=40341
- WebKit.gyp:
- 5:16 AM Changeset in webkit [61006] by
-
- 6 edits in trunk
2010-06-11 Zhenyao Mo <zmo@google.com>
Reviewed by Dimitri Glazkov.
Vertex attributes enabled as arrays but not bound to buffers must generate INVALID_OPERATION
https://bugs.webkit.org/show_bug.cgi?id=40315
- fast/canvas/webgl/index-validation-expected.txt: Generate INVALID_ERROR when an enabled vertex attrib is not bound to any buffer in drawElements().
- fast/canvas/webgl/script-tests/index-validation.js: Ditto.
2010-06-11 Zhenyao Mo <zmo@google.com>
Reviewed by Dimitri Glazkov.
Vertex attributes enabled as arrays but not bound to buffers must generate INVALID_OPERATION
https://bugs.webkit.org/show_bug.cgi?id=40315
- html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::validateRenderingState): Check if an enabled vertext attribs is bound to a buffer. (WebCore::WebGLRenderingContext::vertexAttribPointer): Set bound buffer in vertex attrib state.
- html/canvas/WebGLRenderingContext.h: Add a member in vertex attrib state to track bound buffer.
- 5:01 AM QtWebKitJournal edited by
- (diff)
- 5:00 AM QtWebKitJournal edited by
- (diff)
- 4:47 AM Changeset in webkit [61005] by
-
- 2 edits in trunk/WebKit/qt
[Qt] Second fix attempt for the build break introduced by r61002.
Reviewed by nobody, build fix.
- Api/qwebpage.cpp:
(QWebPagePrivate::QWebPagePrivate):
- 3:42 AM Changeset in webkit [61004] by
-
- 2 edits in trunk/WebKit/qt
[Qt] Fix build break introduced by r61002.
Reviewed by nobody, build fix.
- Api/qwebpage.cpp:
(QWebPagePrivate::QWebPagePrivate):
- 3:36 AM Changeset in webkit [61003] by
-
- 6 edits in trunk/JavaScriptCore
[Qt] Explicit conversions from QtScript types to JSC opaque types were removed.
https://bugs.webkit.org/show_bug.cgi?id=40412
Patch by Jedrzej Nowacki <jedrzej.nowacki@nokia.com> on 2010-06-11
Reviewed by Simon Hausmann.
Conversion between a JSC C types and a QtScript private types, takes
main part of the source code. In most cases a mapping between the types
is one to one. New cast operators were added to simplify the code.
The QScriptValuePrivate could be casted to the JSValueRef and the JSObjectRef.
The QScriptEnginePrivate could be casted to the JSGlobalContext.
The QScriptProgramPrivate could be casted to the JSStringRef.
- qt/api/qscriptengine_p.cpp:
(QScriptEnginePrivate::evaluate):
(QScriptEnginePrivate::newObject):
(QScriptEnginePrivate::globalObject):
- qt/api/qscriptengine_p.h:
(QScriptEnginePrivate::operator JSGlobalContextRef):
- qt/api/qscriptprogram_p.h:
(QScriptProgramPrivate::operator JSStringRef):
- qt/api/qscriptsyntaxcheckresult.cpp:
(QScriptSyntaxCheckResultPrivate::~QScriptSyntaxCheckResultPrivate):
(QScriptSyntaxCheckResultPrivate::errorMessage):
(QScriptSyntaxCheckResultPrivate::errorLineNumber):
- qt/api/qscriptvalue_p.h:
(QScriptValuePrivate::~QScriptValuePrivate):
(QScriptValuePrivate::QScriptValuePrivate):
(QScriptValuePrivate::isBool):
(QScriptValuePrivate::isNumber):
(QScriptValuePrivate::isNull):
(QScriptValuePrivate::isString):
(QScriptValuePrivate::isUndefined):
(QScriptValuePrivate::isFunction):
(QScriptValuePrivate::toString):
(QScriptValuePrivate::toNumber):
(QScriptValuePrivate::toBool):
(QScriptValuePrivate::toObject):
(QScriptValuePrivate::equals):
(QScriptValuePrivate::strictlyEquals):
(QScriptValuePrivate::instanceOf):
(QScriptValuePrivate::call):
(QScriptValuePrivate::operator JSValueRef):
(QScriptValuePrivate::operator JSObjectRef):
(QScriptValuePrivate::setValue):
(QScriptValuePrivate::inherits):
(QScriptValuePrivate::refinedJSValue):
- 2:59 AM Changeset in webkit [61002] by
-
- 8 edits in trunk
[Qt] Implement the simple text code path.
https://bugs.webkit.org/show_bug.cgi?id=40077
Reviewed by Simon Hausmann.
Remove the FONT_FAST_PATH macro and use the Qt's
fast text implementation instead of the one of WebKit.
The Qt::TextBypassShaping flag is used to tell Qt to
only use the glyph advances.
Qt 4.7 is needed to get this flag thus the complex path is always
used if QtWebKit is compiled against an earlier version.
Contrary to the WebKit's implementation, the complex code path
is taken if the text is RightToLeft, justified or is formatted
with non-zero letter or word spacing.
- wtf/Platform.h:
WebCore:
- platform/graphics/Font.cpp:
(WebCore::Font::drawText):
(WebCore::Font::floatWidth):
(WebCore::Font::selectionRectForText):
(WebCore::Font::offsetForPosition):
- platform/graphics/Font.h:
(WebCore::Font::isRoundingHackCharacter):
- platform/graphics/qt/FontQt.cpp:
(WebCore::fromRawDataWithoutRef):
(WebCore::needComplexCodePath):
(WebCore::setupPlatformContext):
(WebCore::Font::canReturnFallbackFontsForComplexText):
(WebCore::Font::drawSimpleText):
(WebCore::Font::drawComplexText):
(WebCore::Font::floatWidthForSimpleText):
(WebCore::Font::offsetForPositionForSimpleText):
(WebCore::Font::selectionRectForSimpleText):
WebKit\qt:
- Api/qwebpage.cpp:
(QWebPagePrivate::QWebPagePrivate):
- 2:58 AM Changeset in webkit [61001] by
-
- 4 edits in trunk/WebCore
Move the text code path detection code from FontFastPath.cpp to Font.cpp.
https://bugs.webkit.org/show_bug.cgi?id=40077
Reviewed by Simon Hausmann.
This is a patch preliminary to the implementation of the
simple font code path for the Qt port.
- platform/graphics/Font.cpp:
(WebCore::Font::setCodePath):
(WebCore::Font::codePath):
- platform/graphics/Font.h:
- platform/graphics/FontFastPath.cpp:
- 2:36 AM Changeset in webkit [61000] by
-
- 8 edits4 adds in trunk/WebCore
2010-06-11 Sterling Swigart <sswigart@google.com>
Reviewed by Dmitry Titov.
Added AsyncImageResizer and ImageResizerThread classes, which after further
patches will be capable of resizing images.
https://bugs.webkit.org/show_bug.cgi?id=40018
- Android.mk:
- CMakeLists.txt:
- GNUmakefile.am:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- html/AsyncImageResizer.cpp: Added. (WebCore::AsyncImageResizer::create): (WebCore::AsyncImageResizer::AsyncImageResizer): (WebCore::AsyncImageResizer::~AsyncImageResizer): (WebCore::AsyncImageResizer::notifyFinished):
- html/AsyncImageResizer.h: Added. (WebCore::AsyncImageResizer::CallbackInfo::CallbackInfo): (WebCore::AsyncImageResizer::): (WebCore::AsyncImageResizer::resizeComplete): (WebCore::AsyncImageResizer::resizeError):
- html/ImageResizerThread.cpp: Added. (WebCore::returnBlobOrError): (WebCore::ImageResizerThread::start): (WebCore::ImageResizerThread::ImageResizerThread): (WebCore::ImageResizerThread::~ImageResizerThread): (WebCore::ImageResizerThread::imageResizerThreadStart): (WebCore::ImageResizerThread::imageResizerThread):
- html/ImageResizerThread.h: Added.
- 2:10 AM Changeset in webkit [60999] by
-
- 5 edits in trunk/LayoutTests
2010-06-11 Tony Gentilcore <tonyg@chromium.org>
Reviewed by Adam Barth.
Update acid3 test with latest from acid3.acidtests.org
https://bugs.webkit.org/show_bug.cgi?id=40428
This is a straight copy from "curl http://acid3.acidtests.org/" with
LayoutTest specific bits reapplied:
- Rename resources to resources/acid3/...
- Add window.layoutTestController bits to start and end.
We still fail the same link test. The difference is that its error
changed from "LINKTEST FAILED" to "YOU SHOULD NOT SEE THIS AT ALL".
- http/tests/misc/acid3-expected.checksum:
- http/tests/misc/acid3-expected.png:
- http/tests/misc/acid3-expected.txt:
- http/tests/misc/acid3.html:
- 1:50 AM Changeset in webkit [60998] by
-
- 6 edits3 adds in trunk
2010-06-11 Steve Block <steveblock@google.com>
Reviewed by Alexey Proskuryakov.
Client-based Geolocation does not handle multiple simultaneous requests
https://bugs.webkit.org/show_bug.cgi?id=40148
Test: fast/dom/Geolocation/multiple-requests.html
The Geolocation must handle multiple calls to addObserver() from the same Geolocation object.
- page/GeolocationController.cpp: (WebCore::GeolocationController::addObserver):
2010-06-11 Steve Block <steveblock@google.com>
Reviewed by Alexey Proskuryakov.
Client-based Geolocation does not handle multiple simultaneous requests
https://bugs.webkit.org/show_bug.cgi?id=40148
The change to the GeolocationController is explicitly tested with multiple-requests.html.
This change also fixes reentrant-error.html and reentrant-success.html which were previously
on the mac skipped list. reentrant-error.html required a minor tweak as the mac
GeolocationController can only provide an error code of 2 (POSITION_UNAVAILABLE).
Added to GTK skipped list.
- fast/dom/Geolocation/multiple-requests-expected.txt: Added.
- fast/dom/Geolocation/multiple-requests.html: Added.
- fast/dom/Geolocation/script-tests/multiple-requests.js: Added.
- fast/dom/Geolocation/script-tests/reentrant-error.js:
- platform/mac/Skipped:
- platform/gtk/Skipped:
- 1:41 AM Changeset in webkit [60997] by
-
- 2 edits in trunk/WebKitTools
2010-06-11 Yael Aharon <yael.aharon@nokia.com>
Reviewed by Laszlo Gombos.
[Qt] There should be a way to enable popups in QtTestBrowser
https://bugs.webkit.org/show_bug.cgi?id=40427
- QtTestBrowser/main.cpp: (LauncherWindow::toggleJavascriptCanOpenWindows): (LauncherWindow::createChrome):
- 1:27 AM Changeset in webkit [60996] by
-
- 2 edits in trunk/JavaScriptCore
2010-06-11 Luiz Agostini <luiz.agostini@openbossa.org>
Reviewed by Kenneth Rohde Christiansen.
add codePointCompare to JavaScriptCore.exp
https://bugs.webkit.org/show_bug.cgi?id=40426
- JavaScriptCore.exp:
- 1:12 AM Changeset in webkit [60995] by
-
- 2 edits in trunk/WebCore
2010-06-11 Nikita Vasilyev <me@elv1s.ru>
Reviewed by Pavel Feldman.
Web Inspector: When completing using a tab key, select very first value, not a second.
https://bugs.webkit.org/show_bug.cgi?id=40409
- inspector/front-end/TextPrompt.js: (WebInspector.TextPrompt.prototype._completionsReady):
- 12:47 AM Changeset in webkit [60994] by
-
- 2 edits in trunk/LayoutTests
2010-06-11 Shinichiro Hamaji <hamaji@chromium.org>
Unreviewed.
Skip re-enabled SVG test (svg/W3C-SVG-1.1/fonts-glyph-02-t)
- platform/chromium/test_expectations.txt:
Jun 10, 2010:
- 11:56 PM Changeset in webkit [60993] by
-
- 5 edits1 add in trunk/WebKitTools
2010-06-10 Adam Barth <abarth@webkit.org>
Reviewed by Daniel Bates.
Make SheriffBot more chatty
https://bugs.webkit.org/show_bug.cgi?id=40463
People seem to like to talk to SheriffBot, so let's make him chat back.
- Scripts/webkitpy/thirdparty/init.py:
- Scripts/webkitpy/tool/bot/irc_command.py:
- Scripts/webkitpy/tool/bot/irc_command_unittest.py: Added.
- Scripts/webkitpy/tool/bot/sheriffircbot.py:
- Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
- 10:51 PM Changeset in webkit [60992] by
-
- 4 edits4 adds in trunk
2010-06-10 Yuzo Fujishima <yuzo@google.com>
Reviewed by Shinichiro Hamaji.
Fix Bug 40452: REGRESSION: printing is broken if stylesheet has @page
https://bugs.webkit.org/show_bug.cgi?id=40452
- platform/chromium/test_expectations.txt:
- platform/mac/printing/page-rule-in-media-query-expected.checksum: Added.
- platform/mac/printing/page-rule-in-media-query-expected.png: Added.
- platform/mac/printing/page-rule-in-media-query-expected.txt: Added.
- printing/page-rule-in-media-query.html: Added.
2010-06-10 Yuzo Fujishima <yuzo@google.com>
Reviewed by Shinichiro Hamaji.
Fix Bug 40452: REGRESSION: printing is broken if stylesheet has @page
https://bugs.webkit.org/show_bug.cgi?id=40452
Test: printing/page-rule-in-media-query.html
- css/CSSStyleSelector.cpp: (WebCore::CSSRuleSet::addRulesFromSheet): (WebCore::CSSRuleSet::addStyleRule):
- 10:47 PM Changeset in webkit [60991] by
-
- 7 edits in trunk/WebCore
2010-06-10 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r60989.
http://trac.webkit.org/changeset/60989
https://bugs.webkit.org/show_bug.cgi?id=40462
It makes things crash (Requested by abarth on #webkit).
- dom/Tokenizer.h: (WebCore::Tokenizer::isHTMLTokenizer):
- html/HTML5Tokenizer.cpp:
- html/HTML5Tokenizer.h:
- html/HTML5TreeBuilder.h:
- html/HTMLFormControlElement.cpp: (WebCore::HTMLFormControlElement::removedFromTree):
- html/HTMLTokenizer.h: (WebCore::HTMLTokenizer::isHTMLTokenizer): (WebCore::HTMLTokenizer::htmlParser):
- 10:36 PM Changeset in webkit [60990] by
-
- 3 edits3 adds in trunk
2010-06-10 Oliver Hunt <oliver@apple.com>
Reviewed by Maciej Stachowiak.
Math Javascript Bug on Safari 5 (webkit 533.16) under "32bit" mode
https://bugs.webkit.org/show_bug.cgi?id=40367
If we're in the slow case of right shift we must write the type tag as
the only reason we hit this code path is because we know we're working
with a double. eg. we are guaranteed that the tag cannot be reused.
- jit/JITArithmetic32_64.cpp: (JSC::JIT::emitRightShiftSlowCase):
2010-06-10 Oliver Hunt <oliver@apple.com>
Reviewed by Maciej Stachowiak.
Math Javascript Bug on Safari 5 (webkit 533.16) under "32bit" mode
https://bugs.webkit.org/show_bug.cgi?id=40367
Add some tests to ensure correct behaviour of right shift.
- fast/js/bitops-type-tag.html: Added.
- fast/js/script-tests/bitops-type-tag.js: Added.
- 10:28 PM Changeset in webkit [60989] by
-
- 7 edits in trunk/WebCore
2010-06-10 Tony Gentilcore <tonyg@chromium.org>
Reviewed by Eric Seidel.
Fix fast/forms/preserveFormDuringResidualStyle.html for HTML5 Parser.
https://bugs.webkit.org/show_bug.cgi?id=40454
This required exposing the HTMLParser which we definitely don't want to
do, but the good news is that it can go away when the HTMLParser goes
away.
No new tests because covered by fast/forms/preserve/FormDuringResidualStyle.html.
- dom/Tokenizer.h: (WebCore::Tokenizer::htmlParser):
- html/HTML5Tokenizer.cpp: (WebCore::HTML5Tokenizer::htmlParser):
- html/HTML5Tokenizer.h:
- html/HTML5TreeBuilder.h: (WebCore::HTML5TreeBuilder::htmlParser):
- html/HTMLFormControlElement.cpp: (WebCore::HTMLFormControlElement::removedFromTree):
- html/HTMLTokenizer.h: (WebCore::HTMLTokenizer::htmlParser):
- 9:58 PM Changeset in webkit [60988] by
-
- 2 edits in trunk/WebKitTools
Fix the Windows buildbot when WebKitAuxiliaryLibs.zip cannot be found on our server.
Reviewed by Darin Adler.
Robustify update-webkit-auxiliary-libs to be able to handle the case when WebKitAuxiliaryLibs.zip doesn't exist,
and allow the script to fall back to an existing file, only failing if there is no fallback file. Also switch to checking
WEXITSTATUS on $result instead of just comparing $result to 0.
- Scripts/update-webkit-auxiliary-libs:
- 9:05 PM Changeset in webkit [60987] by
-
- 3 edits in trunk/WebKit/chromium
[DRT/Chromium] Support plugin tests
https://bugs.webkit.org/show_bug.cgi?id=40413
Reviewed by Dimitri Glazkov.
- 6:40 PM Changeset in webkit [60986] by
-
- 2 edits in trunk/WebKit/chromium
2010-06-10 James Hawkins <jhawkins@chromium.org>
Not reviwed.
Build fix for Chromium Mac Release.
- src/AutoFillPopupMenuClient.cpp: (WebKit::AutoFillPopupMenuClient::getSuggestion): (WebKit::AutoFillPopupMenuClient::valueChanged): (WebKit::AutoFillPopupMenuClient::selectionChanged): (WebKit::AutoFillPopupMenuClient::itemIsSeparator):
- 5:51 PM Changeset in webkit [60985] by
-
- 6 edits in trunk/WebKit/chromium
2010-06-09 James Hawkins <jhawkins@chromium.org>
Reviewed by Darin Fisher.
[Chromium] Add the ability to specify a separator in
AutoFillPopupMenuClient.
- public/WebViewClient.h: (WebKit::WebViewClient::didAcceptAutoFillSuggestion):
- src/AutoFillPopupMenuClient.cpp: (WebKit::AutoFillPopupMenuClient::getSuggestionsCount): (WebKit::AutoFillPopupMenuClient::getSuggestion): (WebKit::AutoFillPopupMenuClient::valueChanged): (WebKit::AutoFillPopupMenuClient::selectionChanged): (WebKit::AutoFillPopupMenuClient::itemIsSeparator): (WebKit::AutoFillPopupMenuClient::initialize): (WebKit::AutoFillPopupMenuClient::setSuggestions):
- src/AutoFillPopupMenuClient.h:
- src/WebViewImpl.cpp: (WebKit::WebViewImpl::applyAutoFillSuggestions):
- src/WebViewImpl.h:
- 5:49 PM Changeset in webkit [60984] by
-
- 3 edits2 adds in trunk
2010-06-10 Tony Chang <tony@chromium.org>
Reviewed by Kent Tamura.
crash when focus is changed while trying to focus next element
https://bugs.webkit.org/show_bug.cgi?id=40407
- fast/events/focus-change-crash-expected.txt: Added.
- fast/events/focus-change-crash.html: Added.
2010-06-10 Tony Chang <tony@chromium.org>
Reviewed by Kent Tamura.
crash when focus is changed while trying to focus next element
https://bugs.webkit.org/show_bug.cgi?id=40407
Test: fast/events/focus-change-crash.html
- dom/Element.cpp: (WebCore::Element::focus):
- 5:45 PM Changeset in webkit [60983] by
-
- 3 edits1 move in trunk/LayoutTests
Rubber-stamped by Sam Weinig.
https://bugs.webkit.org/show_bug.cgi?id=18830
Assertion failure (using HashMap empty value) in svg/W3C-SVG-1.1/fonts-glyph-02-t.svg
This doesn't happen any more, the code has changed a lot since 2008. Re-enabling the test.
- platform/mac/svg/W3C-SVG-1.1/fonts-glyph-02-t-expected.checksum:
- platform/mac/svg/W3C-SVG-1.1/fonts-glyph-02-t-expected.png:
- platform/mac/svg/W3C-SVG-1.1/fonts-glyph-02-t-expected.txt:
- svg/W3C-SVG-1.1/fonts-glyph-02-t.svg: Copied from LayoutTests/svg/W3C-SVG-1.1/fonts-glyph-02-t.svg-disabled.
- svg/W3C-SVG-1.1/fonts-glyph-02-t.svg-disabled: Removed.
- 5:27 PM Changeset in webkit [60982] by
-
- 2 edits in trunk/WebKitTools
2010-06-10 Ojan Vafai <ojan@chromium.org>
Reviewed by Alexey Proskuryakov.
don't use Exception.message as it's deprecated in python 2.6+
https://bugs.webkit.org/show_bug.cgi?id=40449
- Scripts/webkitpy/tool/commands/queues.py:
- 4:05 PM Changeset in webkit [60981] by
-
- 2 edits in trunk/WebKit/qt
[Qt] Support for loading notification icons
https://bugs.webkit.org/show_bug.cgi?id=40004
Reviewed by Kenneth Rohde Christiansen.
Take into use the icon that was loaded for the notification.
- WebCoreSupport/NotificationPresenterClientQt.cpp:
(WebCore::NotificationPresenterClientQt::show):
- 4:05 PM Changeset in webkit [60980] by
-
- 10 edits in trunk
2010-06-10 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r60979.
http://trac.webkit.org/changeset/60979
https://bugs.webkit.org/show_bug.cgi?id=40450
Broke build on Leopard (Requested by kbr_google on #webkit).
- bindings/js/JSWebGLRenderingContextCustom.cpp: (WebCore::JSWebGLRenderingContext::bufferData): (WebCore::JSWebGLRenderingContext::bufferSubData): (WebCore::JSWebGLRenderingContext::texImage2D): (WebCore::JSWebGLRenderingContext::texSubImage2D):
- bindings/scripts/CodeGeneratorJS.pm:
- html/HTMLCanvasElement.idl:
- html/HTMLImageElement.idl:
- html/HTMLVideoElement.idl:
- html/canvas/WebGLRenderingContext.idl:
2010-06-10 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r60979.
http://trac.webkit.org/changeset/60979
https://bugs.webkit.org/show_bug.cgi?id=40450
Broke build on Leopard (Requested by kbr_google on #webkit).
- fast/canvas/webgl/script-tests/texImageTest.js:
- fast/canvas/webgl/texImageTest-expected.txt:
- 3:44 PM Changeset in webkit [60979] by
-
- 10 edits in trunk
2010-06-10 Kenneth Russell <kbr@google.com>
Reviewed by Dimitri Glazkov.
Delete custom JSC bindings for bufferData, texImage2D and texSubImage2D
https://bugs.webkit.org/show_bug.cgi?id=40443
Deleted custom JSC bindings for bufferData, texImage2D and
texSubImage2D and fixed minor associated issues in code generator
and IDL. Updated fast/canvas/webgl/texImageTest-expected.txt,
which now runs as intended. Ran all layout tests, including WebGL
tests, in Safari.
- bindings/js/JSWebGLRenderingContextCustom.cpp:
- Deleted custom bindings.
- bindings/scripts/CodeGeneratorJS.pm:
- Made overload helper functions static to fix compiler warnings.
- Added needed isObject check for overloads between object and non-object arguments.
- html/HTMLCanvasElement.idl:
- html/HTMLImageElement.idl:
- html/HTMLVideoElement.idl:
- Added GenerateNativeConverter extended attribute.
- html/canvas/WebGLRenderingContext.idl:
- Deleted #ifdefs for custom JSC bindings.
2010-06-10 Kenneth Russell <kbr@google.com>
Reviewed by Dimitri Glazkov.
Delete custom JSC bindings for bufferData, texImage2D and texSubImage2D
https://bugs.webkit.org/show_bug.cgi?id=40443
Deleted custom JSC bindings for bufferData, texImage2D and
texSubImage2D and fixed minor associated issues in code generator
and IDL. Updated fast/canvas/webgl/texImageTest-expected.txt,
which now runs as intended. Ran all layout tests, including WebGL
tests, in Safari.
- fast/canvas/webgl/script-tests/texImageTest.js:
- fast/canvas/webgl/texImageTest-expected.txt:
- 3:03 PM Changeset in webkit [60978] by
-
- 4 edits in trunk/WebKitLibraries
Update WebKitSystemInterface to fix build.
- 2:56 PM Changeset in webkit [60977] by
-
- 2 edits in trunk/WebKit/chromium
Not reviewed, Chromium build fix from Abhishek Arya.
- src/WebImageCG.cpp:
(WebKit::WebImage::WebImage):
(WebKit::WebImage::operator=):
- 2:55 PM Changeset in webkit [60976] by
-
- 7 edits in trunk/WebKitTools
2010-06-10 Ojan Vafai <ojan@chromium.org>
Reviewed by Adam Barth.
fix handle_script_error in rietveld upload queue and add testing for handle_script_error
https://bugs.webkit.org/show_bug.cgi?id=40436
- Scripts/webkitpy/common/system/outputcapture.py:
- Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
- Scripts/webkitpy/tool/commands/queues.py:
- Scripts/webkitpy/tool/commands/queues_unittest.py:
- Scripts/webkitpy/tool/commands/queuestest.py:
- Scripts/webkitpy/tool/mocktool.py:
- 2:40 PM Changeset in webkit [60975] by
-
- 1 edit in trunk/LayoutTests/fast/events/continuous-platform-wheelevent-in-scrolling-div-expected.txt
Reset layout test results for continuous wheeling.
- 2:31 PM Changeset in webkit [60974] by
-
- 6 edits in trunk
https://bugs.webkit.org/show_bug.cgi?id=40441, back out the original fix for 29601, since it has broken continuous
wheel delta values.
Reviewed by John Sullivan.
WebCore:
- platform/mac/WebCoreSystemInterface.h:
- platform/mac/WebCoreSystemInterface.mm:
- platform/mac/WheelEventMac.mm:
(WebCore::PlatformWheelEvent::PlatformWheelEvent):
WebKit/mac:
- WebView/WebDynamicScrollBarsView.mm:
(-[WebDynamicScrollBarsView scrollWheel:]):
- 2:29 PM Changeset in webkit [60973] by
-
- 6 edits in trunk
2010-06-10 Abhishek Arya <inferno@chromium.org>
Reviewed by Dimitri Glazkov.
Add null pointer checks for nativeImageForCurrentFrame
function calls.
https://bugs.webkit.org/show_bug.cgi?id=39797
- platform/chromium/PasteboardChromium.cpp: (WebCore::Pasteboard::writeImage):
- platform/graphics/qt/GraphicsContext3DQt.cpp: (WebCore::GraphicsContext3D::getImageData):
- platform/qt/PasteboardQt.cpp: (WebCore::Pasteboard::writeImage):
2010-06-10 Abhishek Arya <inferno@chromium.org>
Reviewed by Dimitri Glazkov.
Add null pointer checks for nativeImageForCurrentFrame
function calls.
https://bugs.webkit.org/show_bug.cgi?id=39797
- src/WebImageCG.cpp: (WebKit::WebImage::WebImage): (WebKit::WebImage::operator=):
- 2:01 PM Changeset in webkit [60972] by
-
- 2 edits in trunk/WebKit2
- mac/WebKit2.exp:
Added another symbol needed by Mac clients.
Reviewed by Dan Bernstein.
- 1:41 PM Changeset in webkit [60971] by
-
- 2 edits in trunk/WebKitTools
2010-06-10 Jarkko Sakkinen <jarkko.j.sakkinen@gmail.com>
Reviewed by Simon Hausmann.
[Qt] *All* WebGL layout tests fail!
https://bugs.webkit.org/show_bug.cgi?id=40296
Added test for WebKitWebGLEnabled to
LayoutTestController::overridePreference().
- DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::overridePreference):
- 12:34 PM Changeset in webkit [60970] by
-
- 3 edits2 adds in trunk/LayoutTests
2010-06-10 Robert Hogan <robert@webkit.org>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Fix Qt-specific event-sender-keydown-frame.html test
It looks like this test was added without elements required for it work.
- platform/qt/Skipped:
- platform/qt/fast/events/event-sender-keydown-frame.html:
- platform/qt/fast/events/resources/divs.html: Added.
- 12:13 PM Changeset in webkit [60969] by
-
- 3 edits in trunk/WebKitExamplePlugins
Fix build.
- NetscapeCocoaPlugin/NetscapeCocoaPlugin.xcodeproj/project.pbxproj:
- NetscapeCocoaPlugin/main.m:
(NPP_New):
(NPP_NewStream):
(NPP_WriteReady):
(NPP_Write):
(NPP_HandleEvent):
- 11:57 AM Changeset in webkit [60968] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, update Chromium test expectations.
- platform/chromium/test_expectations.txt:
Disable fast/text/international/khmer-selection.html on Windows regressed by http://trac.webkit.org/changeset/60953
Skip fast/dom/Window/window-properties-geolocation.html unnecessarily enabled by http://trac.webkit.org/changeset/60956
- 11:53 AM Changeset in webkit [60967] by
-
- 24 edits in trunk
2010-06-09 Kenneth Russell <kbr@google.com>
Reviewed by Dimitri Glazkov.
Implement TypedArray BYTES_PER_ELEMENT
https://bugs.webkit.org/show_bug.cgi?id=39100
Implemented BYTES_PER_ELEMENT on all ArrayBufferView subclasses.
Required bug fixes to JSC bindings' custom constructors. Updated
fast/canvas/webgl/array-unit-tests.html to verify. Ran all WebGL
layout tests in Safari and Chromium.
- bindings/js/JSFloat32ArrayConstructor.cpp: (WebCore::JSFloat32ArrayConstructor::JSFloat32ArrayConstructor): (WebCore::JSFloat32ArrayConstructor::getOwnPropertySlot): (WebCore::JSFloat32ArrayConstructor::getOwnPropertyDescriptor):
- bindings/js/JSFloat32ArrayConstructor.h: (WebCore::JSFloat32ArrayConstructor::createStructure):
- bindings/js/JSInt16ArrayConstructor.cpp: (WebCore::JSInt16ArrayConstructor::JSInt16ArrayConstructor): (WebCore::JSInt16ArrayConstructor::getOwnPropertySlot): (WebCore::JSInt16ArrayConstructor::getOwnPropertyDescriptor):
- bindings/js/JSInt16ArrayConstructor.h: (WebCore::JSInt16ArrayConstructor::createStructure):
- bindings/js/JSInt32ArrayConstructor.cpp: (WebCore::JSInt32ArrayConstructor::JSInt32ArrayConstructor): (WebCore::JSInt32ArrayConstructor::getOwnPropertySlot): (WebCore::JSInt32ArrayConstructor::getOwnPropertyDescriptor):
- bindings/js/JSInt32ArrayConstructor.h: (WebCore::JSInt32ArrayConstructor::createStructure):
- bindings/js/JSInt8ArrayConstructor.cpp: (WebCore::JSInt8ArrayConstructor::JSInt8ArrayConstructor): (WebCore::JSInt8ArrayConstructor::getOwnPropertySlot): (WebCore::JSInt8ArrayConstructor::getOwnPropertyDescriptor):
- bindings/js/JSInt8ArrayConstructor.h: (WebCore::JSInt8ArrayConstructor::createStructure):
- bindings/js/JSUint16ArrayConstructor.cpp: (WebCore::JSUint16ArrayConstructor::JSUint16ArrayConstructor): (WebCore::JSUint16ArrayConstructor::getOwnPropertySlot): (WebCore::JSUint16ArrayConstructor::getOwnPropertyDescriptor):
- bindings/js/JSUint16ArrayConstructor.h: (WebCore::JSUint16ArrayConstructor::createStructure):
- bindings/js/JSUint32ArrayConstructor.cpp: (WebCore::JSUint32ArrayConstructor::JSUint32ArrayConstructor): (WebCore::JSUint32ArrayConstructor::getOwnPropertySlot): (WebCore::JSUint32ArrayConstructor::getOwnPropertyDescriptor):
- bindings/js/JSUint32ArrayConstructor.h: (WebCore::JSUint32ArrayConstructor::createStructure):
- bindings/js/JSUint8ArrayConstructor.cpp: (WebCore::JSUint8ArrayConstructor::JSUint8ArrayConstructor): (WebCore::JSUint8ArrayConstructor::getOwnPropertySlot): (WebCore::JSUint8ArrayConstructor::getOwnPropertyDescriptor):
- bindings/js/JSUint8ArrayConstructor.h: (WebCore::JSUint8ArrayConstructor::createStructure):
- html/canvas/Float32Array.idl:
- html/canvas/Int16Array.idl:
- html/canvas/Int32Array.idl:
- html/canvas/Int8Array.idl:
- html/canvas/Uint16Array.idl:
- html/canvas/Uint32Array.idl:
- html/canvas/Uint8Array.idl:
2010-06-09 Kenneth Russell <kbr@google.com>
Reviewed by Dimitri Glazkov.
Implement TypedArray BYTES_PER_ELEMENT
https://bugs.webkit.org/show_bug.cgi?id=39100
Implemented BYTES_PER_ELEMENT on all ArrayBufferView subclasses.
Required bug fixes to JSC bindings' custom constructors. Updated
fast/canvas/webgl/array-unit-tests.html to verify. Ran all WebGL
layout tests in Safari and Chromium.
- fast/canvas/webgl/array-unit-tests.html:
- 11:17 AM Changeset in webkit [60966] by
-
- 4 edits2 adds in trunk
2010-06-10 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
HTML5 Parser should continue parsing after script execution
https://bugs.webkit.org/show_bug.cgi?id=40416
The previous code was just wrong. We were always blocking
the parser after any script execution. Now we correctly continue
parsing after a successful script execution and only block the
parser when we weren't able to execute the script immediately.
Added a new haveParsingBlockingScript() function to HTML5ScriptRunner
to make some of the code more self-documenting.
Test: fast/tokenizer/write-multiple-scripts.html
fast/js/implicit-call-with-global-reentry.html
- html/HTML5ScriptRunner.cpp:
(WebCore::HTML5ScriptRunner::execute):
- Remove some old (now bogus) FIXMEs and notImplemented() calls.
- Fix the logic to match the HTML5 spec by continuing parsing after script execution and only blocking the parser when the script wasn't able to immediately run.
(WebCore::HTML5ScriptRunner::haveParsingBlockingScript):
- New function to make some of the code read better.
(WebCore::HTML5ScriptRunner::executeParsingBlockingScripts):
- Use haveParsingBlockingScript().
(WebCore::HTML5ScriptRunner::executeScriptsWaitingForLoad):
- Use haveParsingBlockingScript().
(WebCore::HTML5ScriptRunner::runScript):
- Use haveParsingBlockingScript().
- html/HTML5ScriptRunner.h:
2010-06-10 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
HTML5 Parser should continue parsing after script execution
https://bugs.webkit.org/show_bug.cgi?id=40416
Test the ordering of script execution with multiple calls to
document.write().
- fast/tokenizer/write-multiple-scripts-expected.txt: Added.
- fast/tokenizer/write-multiple-scripts.html: Added.
- 10:59 AM Changeset in webkit [60965] by
-
- 13 edits in trunk
2010-06-10 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: to reduce the front end start up time don't push script
sources to frontend if debugger is always enabled, instead request
script content lazily at the moment it should be displyed. It is critical for
always enabled debugger because in that case lots of script may have
already been parsed when the front end is opening and pushing all
of them at once may slow things down(even though the script sources will never
be used if scripts panel isn't open).
https://bugs.webkit.org/show_bug.cgi?id=40364
- inspector/InspectorBackend.cpp: (WebCore::InspectorBackend::getScriptSource):
- inspector/InspectorBackend.h:
- inspector/InspectorBackend.idl:
- inspector/InspectorController.cpp: (WebCore::InspectorController::didCommitLoad): (WebCore::InspectorController::getScriptSource): (WebCore::InspectorController::didParseSource):
- inspector/InspectorController.h:
- inspector/InspectorFrontend.cpp: (WebCore::InspectorFrontend::didGetScriptSource):
- inspector/InspectorFrontend.h:
- inspector/front-end/InspectorBackendStub.js: (.WebInspector.InspectorBackendStub.prototype.editScriptSource): (.WebInspector.InspectorBackendStub.prototype.getScriptSource):
- inspector/front-end/ScriptView.js: (WebInspector.ScriptView.prototype.setupSourceFrameIfNeeded): (WebInspector.ScriptView.prototype._didGetScriptSource): (WebInspector.ScriptView.prototype._sourceFrameSetupFinished):
2010-06-10 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: to reduce the front end start up time don't push script
sources to frontend if debugger is always enabled, instead request
script content lazily at the moment it should be displyed. It is critical for
always enabled debugger because in that case lots of script may have
already been parsed when the front end is opening and pushing all
of them at once may slow things down(even though the script sources will never
be used if scripts panel isn't open).
https://bugs.webkit.org/show_bug.cgi?id=40364
- src/js/DevTools.js:
- src/js/InspectorControllerImpl.js: (devtools.InspectorBackendImpl): (.devtools.InspectorBackendImpl.prototype.getScriptSource):
- 10:39 AM Changeset in webkit [60964] by
-
- 5 edits in trunk/WebCore
2010-06-10 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Use allowRequestIfNoIllegalURICharacters instead of context for XSSAuditor::canLoadExternalScriptFromSrc
https://bugs.webkit.org/show_bug.cgi?id=40404
We originally added the context parameter to
canLoadExternalScriptFromSrc to work around some false positives caused
by folks checking external script URLs on the server. Our thought was
that we could tell these were not real XSS attacks because the
surrounding context wouldn't match in the URL and the document.
Implementing this feature in the HTML5 parser is hard because it
pierces a layer of abstraction (the token abstraction of the input
stream). We could hack this into the new parser, but instead I think
it's better to switch to using the allowRequestIfNoIllegalURICharacters
heuristic.
We designed the allowRequestIfNoIllegalURICharacters after the context
heuristic to deal with other cases where the server was validating
input before echoing it. However, we never tried applying it to
canLoadExternalScriptFromSrc.
It's possible that this will cause false positives and will need to be
reverted, which is why I've left in some of the infrustructure for
computing context. We don't have a good way to know if that will
happen except to try. We do know, however, that this heuristic will
work for the original false positives we saw.
- html/HTML5Tokenizer.cpp: (WebCore::HTML5Tokenizer::shouldLoadExternalScriptFromSrc):
- html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::parseTag):
- page/XSSAuditor.cpp: (WebCore::XSSAuditor::canLoadExternalScriptFromSrc):
- page/XSSAuditor.h:
- 10:24 AM Changeset in webkit [60963] by
-
- 2 edits in trunk/WebKit/qt
2010-06-10 Mahesh Kulkarni <mahesh.kulkarni@nokia.com>
Reviewed by Simon Hausmann.
[Qt] Memory leak in qwebpage unit test cases
https://bugs.webkit.org/show_bug.cgi?id=40405
- tests/qwebpage/tst_qwebpage.cpp: (tst_QWebPage::infiniteLoopJS):
- 10:10 AM Changeset in webkit [60962] by
-
- 2 edits in trunk/WebCore
2010-06-10 Kwang Yul Seo <skyul@company100.net>
Reviewed by Kent Tamura.
Add ENABLE(DATABASE) guard for DatabaseAuthorizer.cpp
https://bugs.webkit.org/show_bug.cgi?id=40399
Build fix for ENABLE(DATABASE)=0.
- storage/DatabaseAuthorizer.cpp:
- 9:49 AM Changeset in webkit [60961] by
-
- 23 edits in trunk
2010-06-10 Chang Shu <chang.shu@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Unskip canvas/philip/tests/2d.shadow.enable.blur.html.
- platform/qt/Skipped:
2010-06-10 Shu Chang <chang.shu@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
Change the type of ShadowBlur from int to float in GraphicsContext.
Using int for ShadowBlur loses precision and fails the test.
Note: This code change fixes Qt port but Mac is still failing due to
platform issue. Function CGContextSetShadowWithColor() does not take
a blur value less than 0.5.
- platform/graphics/GraphicsContext.cpp: (WebCore::GraphicsContext::setShadow): (WebCore::GraphicsContext::getShadow):
- platform/graphics/GraphicsContext.h:
- platform/graphics/GraphicsContextPrivate.h:
- platform/graphics/cairo/FontCairo.cpp: (WebCore::Font::drawGlyphs):
- platform/graphics/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContext::calculateShadowBufferDimensions): (WebCore::drawPathShadow): (WebCore::drawBorderlessRectShadow): (WebCore::GraphicsContext::setPlatformShadow):
- platform/graphics/cairo/ImageCairo.cpp: (WebCore::BitmapImage::draw):
- platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::setPlatformShadow):
- platform/graphics/chromium/FontChromiumWin.cpp: (WebCore::TransparencyAwareFontPainter::TransparencyAwareGlyphPainter::drawGlyphs): (WebCore::Font::drawComplexText):
- platform/graphics/gtk/FontGtk.cpp: (WebCore::Font::drawComplexText):
- platform/graphics/haiku/GraphicsContextHaiku.cpp: (WebCore::GraphicsContext::setPlatformShadow):
- platform/graphics/mac/FontMac.mm: (WebCore::Font::drawGlyphs):
- platform/graphics/openvg/GraphicsContextOpenVG.cpp: (WebCore::GraphicsContext::setPlatformShadow):
- platform/graphics/qt/FontQt.cpp: (WebCore::Font::drawComplexText):
- platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::drawRect): (WebCore::GraphicsContext::drawLine): (WebCore::GraphicsContext::strokeArc): (WebCore::GraphicsContext::drawConvexPolygon): (WebCore::drawFilledShadowPath): (WebCore::GraphicsContext::strokePath): (WebCore::drawBorderlessRectShadow): (WebCore::GraphicsContext::setPlatformShadow):
- platform/graphics/qt/ImageQt.cpp: (WebCore::BitmapImage::draw):
- platform/graphics/skia/GraphicsContextSkia.cpp: (WebCore::GraphicsContext::setPlatformShadow):
- platform/graphics/skia/SkiaFontWin.cpp: (WebCore::windowsCanHandleDrawTextShadow):
- platform/graphics/win/FontCGWin.cpp: (WebCore::drawGDIGlyphs): (WebCore::Font::drawGlyphs):
- platform/graphics/wince/GraphicsContextWince.cpp: (WebCore::GraphicsContext::fillRoundedRect): (WebCore::GraphicsContext::setPlatformShadow): (WebCore::GraphicsContext::drawText):
- platform/graphics/wx/GraphicsContextWx.cpp: (WebCore::GraphicsContext::setPlatformShadow):
- 9:32 AM Changeset in webkit [60960] by
-
- 8 edits14 adds in trunk
2010-06-10 Yael Aharon <yael.aharon@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
Support for loading notification icons
https://bugs.webkit.org/show_bug.cgi?id=40396
- http/tests/notifications: Added.
- http/tests/notifications/icon-does-not-exist-expected.txt: Added.
- http/tests/notifications/icon-does-not-exist.html: Added.
- http/tests/notifications/icon-exists-cancel-expected.txt: Added.
- http/tests/notifications/icon-exists-cancel.html: Added.
- http/tests/notifications/icon-exists-expected.txt: Added.
- http/tests/notifications/icon-exists-show-alert-during-load-expected.txt: Added.
- http/tests/notifications/icon-exists-show-alert-during-load.html: Added.
- http/tests/notifications/icon-exists.html: Added.
- http/tests/notifications/icon-requires-auth-expected.txt: Added.
- http/tests/notifications/icon-requires-auth.html: Added.
- http/tests/notifications/resources: Added.
- http/tests/notifications/resources/icon-exists.png: Added.
- http/tests/notifications/resources/icon-requires-auth.php: Added.
- platform/chromium/test_expectations.txt:
- platform/gtk/Skipped:
- platform/mac/Skipped:
- platform/win/Skipped:
2010-06-10 Yael Aharon <yael.aharon@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
Support for loading notification icons
https://bugs.webkit.org/show_bug.cgi?id=40396
Make notification objects download the icon needed for displaying the
notification before calling the NotificationPresenter to display the
notification.
An error during the download would cause the notification to be displayed
without an icon.
If a notification is in the process of download, and a new notification
is created with the same ReplaceId, the download is not cancelled
immediately and the notification is removed only after the download is
complete.
Tests: http/tests/notifications/icon-does-not-exist.html
http/tests/notifications/icon-exists-cancel.html
http/tests/notifications/icon-exists-show-alert-during-load.html
http/tests/notifications/icon-exists.html
http/tests/notifications/icon-requires-auth.html
- notifications/Notification.cpp: (WebCore::Notification::Notification): (WebCore::Notification::~Notification): (WebCore::Notification::show): (WebCore::Notification::cancel): (WebCore::Notification::startLoading): (WebCore::Notification::stopLoading): (WebCore::Notification::didReceiveResponse): (WebCore::Notification::didReceiveData): (WebCore::Notification::didFinishLoading): (WebCore::Notification::didFail): (WebCore::Notification::didFailRedirectCheck): (WebCore::Notification::didReceiveAuthenticationCancellation): (WebCore::Notification::finishLoading):
- notifications/Notification.h: (WebCore::Notification::iconData): (WebCore::Notification::releaseIconData): (WebCore::Notification::):
- 8:45 AM Changeset in webkit [60959] by
-
- 3 edits in trunk/WebKitTools
2010-06-10 Diego Gonzalez <diegohcg@webkit.org>
Reviewed by Kenneth Rohde Christiansen.
[Qt] DRT EventSender support to graphics mouse events activation
https://bugs.webkit.org/show_bug.cgi?id=40017
- DumpRenderTree/qt/EventSenderQt.cpp: (EventSender::mouseDown): (EventSender::mouseUp): (EventSender::mouseMoveTo): (EventSender::keyDown): (EventSender::contextClick): (EventSender::sendTouchEvent): (EventSender::sendOrQueueEvent): (EventSender::eventFilter): (EventSender::createGraphicsSceneMouseEvent): (EventSender::sendEvent):
- DumpRenderTree/qt/EventSenderQt.h: (EventSender::isGraphicsBased):
- 8:34 AM Changeset in webkit [60958] by
-
- 7 edits4 adds in trunk
2010-06-10 Raine Makelainen <raine.makelainen@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
Impossible to set input method hints based HTML5 input types
https://bugs.webkit.org/show_bug.cgi?id=40107
Helper methods for checking "tel", "number", "email",
and "url" input element types.
- html/HTMLInputElement.h: (WebCore::HTMLInputElement::isTelephoneField): (WebCore::HTMLInputElement::isNumberField): (WebCore::HTMLInputElement::isEmailField): (WebCore::HTMLInputElement::isUrlField):
2010-06-10 Raine Makelainen <raine.makelainen@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
Impossible to set input method hints based HTML5 input types
https://bugs.webkit.org/show_bug.cgi?id=40107
EditorClientQt to set input method hints for "number", "tel",
"email", and "url" HTML input elements.
Tests for HTML input elements and input method hints added for
QGraphicsWebView and QWebView.
- WebCoreSupport/EditorClientQt.cpp: (WebCore::EditorClientQt::setInputMethodState):
- tests/qgraphicswebview/resources/input_types.html: Added.
- tests/qgraphicswebview/tst_qgraphicswebview.cpp: (GraphicsWebView::GraphicsWebView): (GraphicsWebView::fireMouseClick): (tst_QGraphicsWebView::focusInputTypes):
- tests/qgraphicswebview/tst_qgraphicswebview.qrc: Added.
- tests/qwebview/resources/input_types.html: Added.
- tests/qwebview/tst_qwebview.cpp: (WebView::fireMouseClick): (tst_QWebView::focusInputTypes):
- tests/qwebview/tst_qwebview.qrc:
- 7:31 AM Changeset in webkit [60957] by
-
- 21 edits3 adds in trunk
2010-06-10 Daniel Cheng <dcheng@chromium.org>
Reviewed by Jian Li.
Don't convert filenames to URLs in edit drags.
https://bugs.webkit.org/show_bug.cgi?id=38826
For security reasons, we don't want to expose file system paths to web
content, so we filter them out of edit drags.
- editing/pasteboard/file-drag-to-editable-expected.txt: Added.
- editing/pasteboard/file-drag-to-editable.html: Added.
- editing/pasteboard/script-tests/file-drag-to-editable.js: Added.
- platform/gtk/Skipped:
- platform/mac/Skipped:
- platform/qt/Skipped:
- platform/win/Skipped:
2010-06-10 Daniel Cheng <dcheng@chromium.org>
Reviewed by Jian Li.
Don't convert filenames to URLs in edit drags.
https://bugs.webkit.org/show_bug.cgi?id=38826
For security reasons, we don't want to expose file system paths to web
content, so we filter them out of edit drags.
Test: editing/pasteboard/file-drag-to-editable.html
- page/DragController.cpp: (WebCore::documentFragmentFromDragData):
- platform/DragData.h: (WebCore::DragData::):
- platform/android/DragDataAndroid.cpp: (WebCore::DragData::containsURL): (WebCore::DragData::asURL):
- platform/chromium/DragDataChromium.cpp: (WebCore::DragData::containsURL): (WebCore::DragData::asURL):
- platform/efl/DragDataEfl.cpp: (WebCore::DragData::containsURL): (WebCore::DragData::asURL):
- platform/gtk/DragDataGtk.cpp: (WebCore::DragData::containsURL): (WebCore::DragData::asURL):
- platform/haiku/DragDataHaiku.cpp: (WebCore::DragData::containsURL): (WebCore::DragData::asURL):
- platform/mac/DragDataMac.mm: (WebCore::DragData::containsURL): (WebCore::DragData::asURL):
- platform/qt/DragDataQt.cpp: (WebCore::DragData::asPlainText): (WebCore::DragData::containsURL): (WebCore::DragData::asURL):
- platform/win/ClipboardUtilitiesWin.cpp: (WebCore::getURL): (WebCore::getPlainText):
- platform/win/ClipboardUtilitiesWin.h:
- platform/win/ClipboardWin.cpp: (WebCore::ClipboardWin::getData):
- platform/win/DragDataWin.cpp: (WebCore::DragData::containsURL): (WebCore::DragData::asURL):
- platform/wince/DragDataWince.cpp: (WebCore::DragData::containsURL): (WebCore::DragData::asURL):
- platform/wx/DragDataWx.cpp: (WebCore::DragData::containsURL): (WebCore::DragData::asURL):
- 7:16 AM Changeset in webkit [60956] by
-
- 2 edits2 adds in trunk/LayoutTests
2010-06-10 Marcus Bulach <bulach@google.com>
Reviewed by Jeremy Orlow.
[chromium] Upstream layout tests expectations for Geolocation.
Rebaseline fast/dom/Geolocation/callback-exception-expected.html due to JSC x V8 messages.
https://bugs.webkit.org/show_bug.cgi?id=39721
- platform/chromium/fast/dom/Geolocation/callback-exception-expected.txt: Added.
- platform/chromium/test_expectations.txt:
- 6:56 AM Changeset in webkit [60955] by
-
- 5 edits in trunk
2010-06-10 Mike Belshe <mbelshe@chromium.org>
Reviewed by David Levin
Track whether a resource is loaded via a proxy.
- platform/network/chromium/ResourceResponse.h: (WebCore::ResourceResponse::wasFetchedViaProxy): (WebCore::ResourceResponse::setWasFetchedViaProxy):
2010-06-10 Mike Belshe <mbelshe@google.com>
Reviewed by David Levin
Track whether a resource is loaded via a proxy.
- public/WebURLResponse.h:
- src/WebURLResponse.cpp: (WebKit::WebURLResponse::wasFetchedViaProxy): (WebKit::WebURLResponse::setWasFetchedViaProxy):
- 6:44 AM Changeset in webkit [60954] by
-
- 2 edits in trunk/WebKit/chromium
2010-06-10 Vangelis Kokkevis <vangelis@chromium.org>
Reviewed by Dimitri Glazkov.
[chromium] Adding the ANGLE project to the DEPS file as it's required
by the gpu-accelerated compositor.
https://bugs.webkit.org/show_bug.cgi?id=40379
- DEPS:
- 6:31 AM Changeset in webkit [60953] by
-
- 2 edits in trunk/WebCore
2010-06-10 Jungshik Shin <jshin@chromium.org>
Reviewed by Kent Tamura
Bug 38224 - [chromium] Enable rendering of Ethiopic, Lao, Tibetan
and a few other scripts on Win XP
Make it possible to specify a list of fonts for per-script
fallback instead of a single font per script. This is
necessary for Malayalam (for which Windows font doesn't
support Unicode 5.x fully on Vista or earlier), Ethiopic
(we want to support on XP with a 3rd party font because XP
doesn't have any Ethiopic font out of the box) and some other
scripts. This is a short-term 'fix' until we have per-script
font preferences.
No layout test is added because the test results would be
dependent on which fonts are present.
- platform/graphics/chromium/FontUtilsChromiumWin.cpp: (WebCore::): (WebCore::FontMap::ScriptToFontFamilies::):
- 4:23 AM Changeset in webkit [60952] by
-
- 6 edits3 adds in trunk
2010-06-09 Andrei Popescu <andreip@google.com>
Reviewed by Adam Barth.
CodeGeneratorJS.pm incorrectly increments $paramIndex when a method is declared with [CallWith]
https://bugs.webkit.org/show_bug.cgi?id=40372
Use two variables to keep track of the number of arguments passed from JavaScript vs the number
of arguments passed to the corresponding C++ method. These numbers can be different since
the parameter declared via [CallWith] is generated in the bindings instead of being passed
from JavaScript.
The layout tests added here test both that the parameters are read correctly as well as
tests some basic indexed database functionality. There are also bindings specific
tests added in TestObj.idl.
- storage/indexeddb/idb-objectstore-request-expected.txt: Added.
- storage/indexeddb/idb-objectstore-request.html: Added.
- storage/indexeddb/script-tests/idb-objectstore-request.js: Added. (openSuccess): (createSuccess): (createObjectStore): (doCreateOrOpen): (test):
2010-06-09 Andrei Popescu <andreip@google.com>
Reviewed by Adam Barth.
CodeGeneratorJS.pm incorrectly increments $paramIndex when a method is declared with [CallWith]
https://bugs.webkit.org/show_bug.cgi?id=40372
Use two variables to keep track of the number of arguments passed from JavaScript vs the number
of arguments passed to the corresponding C++ method. These numbers can be different since
the parameter declared via [CallWith] is generated in the bindings instead of being passed
from JavaScript.
Test: storage/indexeddb/idb-objectstore-request.html
- bindings/scripts/CodeGeneratorJS.pm:
- bindings/scripts/test/CPP/WebDOMTestObj.cpp: (WebDOMTestObj::withScriptExecutionContext):
- bindings/scripts/test/CPP/WebDOMTestObj.h:
- bindings/scripts/test/JS/JSTestObj.cpp: (WebCore::jsTestObjPrototypeFunctionWithDynamicFrameAndArg): (WebCore::jsTestObjPrototypeFunctionWithDynamicFrameAndOptionalArg): (WebCore::jsTestObjPrototypeFunctionWithDynamicFrameAndUserGesture): (WebCore::jsTestObjPrototypeFunctionWithDynamicFrameAndUserGestureASAD):
- 3:34 AM Changeset in webkit [60951] by
-
- 11 edits2 adds in trunk/WebCore
2010-06-09 MORITA Hajime <morrita@google.com>
Reviewed by Kent Tamura.
Refactoring: Simple shadow elements should be factored out .
https://bugs.webkit.org/show_bug.cgi?id=40400
Pulled ShadowElement class up from SliderThumbElement,
ProgressValueElement, ShadowInputElement.
And renamed ProgressValueElement to ShadowBlockElement.
No new tests. Because there is no functional change.
- CMakeLists.txt:
- GNUmakefile.am:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- rendering/RenderFileUploadControl.cpp:
- rendering/RenderProgress.cpp: (WebCore::RenderProgress::updateValuePartState):
- rendering/RenderProgress.h:
- rendering/RenderSlider.cpp: (WebCore::SliderThumbElement::SliderThumbElement): (WebCore::SliderThumbElement::defaultEventHandler): (WebCore::SliderThumbElement::detach):
- rendering/ShadowElement.cpp: Added. (WebCore::ShadowBlockElement::create): (WebCore::ShadowBlockElement::ShadowBlockElement): (WebCore::ShadowInputElement::create): (WebCore::ShadowInputElement::ShadowInputElement):
- rendering/ShadowElement.h: Added. (WebCore::ShadowElement::ShadowElement): (WebCore::ShadowElement::isShadowNode): (WebCore::ShadowElement::shadowParentNode):
- 2:31 AM Changeset in webkit [60950] by
-
- 3 edits in trunk/WebKit
2010-06-10 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Reduce FrameView.h includes to speed up build times
https://bugs.webkit.org/show_bug.cgi?id=40408
Another fix for Windows.
- WebView.cpp:
- 2:21 AM Changeset in webkit [60949] by
-
- 2 edits in trunk/WebKit/qt
2010-06-10 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Reduce FrameView.h includes to speed up build times
https://bugs.webkit.org/show_bug.cgi?id=40408
- Api/qwebframe.cpp:
- Include RenderLayer.h since it's used in this file.
- 2:14 AM Changeset in webkit [60948] by
-
- 2 edits in trunk/WebCore
2010-06-10 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Reduce FrameView.h includes to speed up build times
https://bugs.webkit.org/show_bug.cgi?id=40408
Another fix for Qt.
- page/Frame.h:
- Include CSSMutableStyleDeclaration.h since it's used by m_typingStyle = 0;
- 2:06 AM Changeset in webkit [60947] by
-
- 5 edits in trunk
2010-06-10 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Reduce FrameView.h includes to speed up build times
https://bugs.webkit.org/show_bug.cgi?id=40408
More attempted build fixes for Tiger and Qt.
- page/Frame.cpp:
- page/Frame.h:
2010-06-10 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Reduce FrameView.h includes to speed up build times
https://bugs.webkit.org/show_bug.cgi?id=40408
- webkit/webkitwebinspector.cpp:
- Include RenderLayer.h
- 1:58 AM Changeset in webkit [60946] by
-
- 4 edits in trunk/WebCore
2010-06-10 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Reduce FrameView.h includes to speed up build times
https://bugs.webkit.org/show_bug.cgi?id=40408
Add a few more RenderLayer.h includes to fix non-mac builds.
- page/FrameView.cpp:
- rendering/RenderObject.cpp:
- rendering/RenderTreeAsText.cpp:
- 1:49 AM Changeset in webkit [60945] by
-
- 3 edits in trunk/JavaScriptCore
2010-06-10 Kwang Yul Seo <skyul@company100.net>
Reviewed by Eric Seidel.
Remove weakRandomNumber
https://bugs.webkit.org/show_bug.cgi?id=40291
weakRandomNumber is used nowhere. Currently, WeakRandom is used instead.
- wtf/RandomNumber.cpp:
- wtf/RandomNumber.h:
- 1:35 AM Changeset in webkit [60944] by
-
- 7 edits in trunk/LayoutTests
2010-06-10 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
fast/repaint/opacity-change-on-overflow-float.html depends on invalid HTML parsing
https://bugs.webkit.org/show_bug.cgi?id=40262
See comment in opacity-change-on-overflow-float.html to understand why
we made this goofy change.
- fast/repaint/opacity-change-on-overflow-float.html:
- html5lib/resources/webkit01.dat:
- html5lib/runner-expected.txt:
- html5lib/webkit-resumer-expected.txt:
- platform/chromium-win/fast/repaint/opacity-change-on-overflow-float-expected.txt:
- platform/mac/fast/repaint/opacity-change-on-overflow-float-expected.txt:
- 1:33 AM Changeset in webkit [60943] by
-
- 25 edits in trunk/WebCore
2010-06-10 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Reduce FrameView.h includes to speed up build times
https://bugs.webkit.org/show_bug.cgi?id=40408
Cleaned up FrameView.h includes and then propagated the
cascade of includes to the necessary .cpp files.
This should reduce the set of files rebuilt every
time FrameView.h changes, and should also reduce the size
of some .o files.
No functional changes, thus no tests.
- accessibility/AccessibilityRenderObject.cpp:
- dom/ContainerNode.cpp:
- dom/Document.cpp:
- dom/Element.cpp:
- dom/EventTarget.h:
- dom/Node.cpp:
- editing/EditorCommand.cpp:
- editing/SelectionController.cpp:
- html/HTML5Tokenizer.cpp:
(WebCore::HTML5Tokenizer::script):
- No need for this to be inline. Being inline required Frame.h in the header, which causes huge include cascade.
- html/HTML5Tokenizer.h:
- page/DragController.cpp:
- page/EventHandler.cpp:
- page/Frame.h:
- page/FrameView.h:
- page/PrintContext.cpp:
- page/SpatialNavigation.cpp:
- rendering/RenderBlock.cpp:
- rendering/RenderBlockLineLayout.cpp:
- rendering/RenderImage.cpp:
- rendering/RenderInline.cpp:
- rendering/RenderObject.h:
- rendering/RenderTextControlSingleLine.cpp:
- rendering/RenderWidget.cpp:
- rendering/SVGRenderSupport.cpp:
- 1:15 AM QtWebKitBackportingFixes edited by
- (diff)
- 12:59 AM Changeset in webkit [60942] by
-
- 2 edits in trunk/WebKit/qt
REGRESSION: [Qt] When dragging onto a page that handles the drag in Javascript it will be a move and not a copy by default
https://bugs.webkit.org/show_bug.cgi?id=40401
Patch by Andy Shaw <andy.shaw@nokia.com> on 2010-06-10
Reviewed by Simon Hausmann.
The correct pattern in Qt for Dnd events is to use acceptProposedAction() instead
of accept().
- Api/qwebpage.cpp:
(QWebPagePrivate::dragEnterEvent):
(QWebPagePrivate::dragMoveEvent):
(QWebPagePrivate::dropEvent):
- 12:48 AM Changeset in webkit [60941] by
-
- 10 edits2 copies in trunk/WebCore
2010-06-10 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Move HTML5 entity parser to its own file
https://bugs.webkit.org/show_bug.cgi?id=40406
Moving this algorithm to its own file better encapsulates its
dependencies and makes it callable from other parts of WebCore.
- Android.mk:
- CMakeLists.txt:
- GNUmakefile.am:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- html/HTML5EntityParser.cpp: Copied from WebCore/html/HTML5Lexer.cpp. (WebCore::): (WebCore::consumeHTML5Entity):
- html/HTML5EntityParser.h: Copied from WebCore/html/HTML5Lexer.h.
- html/HTML5Lexer.cpp: (WebCore::HTML5Lexer::processEntity): (WebCore::HTML5Lexer::nextToken):
- html/HTML5Lexer.h:
