⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Jun 13, 2010:

11:32 PM Changeset in webkit [61110] by eric@webkit.org
  • 3 edits
    3 adds in trunk

2010-06-13 Charles Wei <​charles.wei@torchmobile.com.cn>

Reviewed by George Staikos.

Test case to verify that MIME type in uppercase (TEXT/HTML) is supported.
​https://bugs.webkit.org/show_bug.cgi?id=39492

  • http/tests/mime/resources/uppercase-mime-type.php: Added.
  • http/tests/mime/uppercase-mime-type-expected.txt: Added.
  • http/tests/mime/uppercase-mime-type.html: Added.

2010-06-13 Charles Wei <​charles.wei@torchmobile.com.cn>

Reviewed by George Staikos.

Fix the QtWebKit which doesn't recognize the MIME type of HTML/TEXT in uppercase
​https://bugs.webkit.org/show_bug.cgi?id=39492

  • WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::canShowMIMEType):
11:20 PM Changeset in webkit [61109] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-06-13 Anders Bakken <​agbakken@gmail.com>

Reviewed by Eric Seidel.

[Qt] ScreenQt.cpp has coding-style errors
​https://bugs.webkit.org/show_bug.cgi?id=39766

  • platform/qt/ScreenQt.cpp:
10:58 PM Changeset in webkit [61108] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2010-06-13 Nathan Lawrence <​nlawrence@apple.com>

Reviewed by Darin Adler.

Outside of Xcode (make or WebKitTools/Scripts), there doesn't seem to
be a way of overwriting the Xcode system path. Making
$WEBKITOUTPUTDIR take precedence over the system default would make
this possible.

  • Scripts/webkitdirs.pm:
10:19 PM Changeset in webkit [61107] by eric@webkit.org
  • 23 edits
    2 moves in trunk/WebCore

2010-06-13 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Rename HTMLParser to LegacyHTMLTreeConstructor
​https://bugs.webkit.org/show_bug.cgi?id=40554

This makes our old HTML parsing system closer match the
HTML5 spec, and thus easier to compare to the new HTML5
parsing system.

This rename was entirely automatic. Done by do-webcore-rename.

  • Android.mk:
  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/Document.cpp:
  • dom/DocumentParser.h: (WebCore::DocumentParser::htmlTreeConstructor):
  • html/HTML5DocumentParser.cpp: (WebCore::HTML5DocumentParser::htmlTreeConstructor):
  • html/HTML5DocumentParser.h:
  • html/HTML5TreeBuilder.cpp: (WebCore::HTML5TreeBuilder::HTML5TreeBuilder):
  • html/HTML5TreeBuilder.h: (WebCore::HTML5TreeBuilder::legacyTreeConstructor):
  • html/HTMLDocumentParser.cpp: (WebCore::HTMLDocumentParser::HTMLDocumentParser):
  • html/HTMLDocumentParser.h: (WebCore::HTMLDocumentParser::htmlTreeConstructor):
  • html/HTMLFormControlElement.cpp: (WebCore::HTMLFormControlElement::removedFromTree):
  • html/HTMLInputElement.cpp:
  • html/HTMLMeterElement.cpp:
  • html/HTMLProgressElement.cpp:
  • html/LegacyHTMLTreeConstructor.cpp: Renamed from WebCore/html/HTMLParser.cpp. (WebCore::addTags): (WebCore::HTMLStackElem::HTMLStackElem): (WebCore::HTMLStackElem::derefNode): (WebCore::LegacyHTMLTreeConstructor::LegacyHTMLTreeConstructor): (WebCore::LegacyHTMLTreeConstructor::~LegacyHTMLTreeConstructor): (WebCore::LegacyHTMLTreeConstructor::reset): (WebCore::LegacyHTMLTreeConstructor::setCurrent): (WebCore::tagPriorityOfNode): (WebCore::LegacyHTMLTreeConstructor::limitDepth): (WebCore::LegacyHTMLTreeConstructor::insertNodeAfterLimitDepth): (WebCore::LegacyHTMLTreeConstructor::parseToken): (WebCore::LegacyHTMLTreeConstructor::parseDoctypeToken): (WebCore::isTableSection): (WebCore::isTablePart): (WebCore::isTableRelated): (WebCore::isScopingTag): (WebCore::LegacyHTMLTreeConstructor::insertNode): (WebCore::LegacyHTMLTreeConstructor::handleError): (WebCore::LegacyHTMLTreeConstructor::textCreateErrorCheck): (WebCore::LegacyHTMLTreeConstructor::commentCreateErrorCheck): (WebCore::LegacyHTMLTreeConstructor::headCreateErrorCheck): (WebCore::LegacyHTMLTreeConstructor::bodyCreateErrorCheck): (WebCore::LegacyHTMLTreeConstructor::framesetCreateErrorCheck): (WebCore::LegacyHTMLTreeConstructor::formCreateErrorCheck): (WebCore::LegacyHTMLTreeConstructor::isindexCreateErrorCheck): (WebCore::LegacyHTMLTreeConstructor::selectCreateErrorCheck): (WebCore::LegacyHTMLTreeConstructor::ddCreateErrorCheck): (WebCore::LegacyHTMLTreeConstructor::dtCreateErrorCheck): (WebCore::LegacyHTMLTreeConstructor::rpCreateErrorCheck): (WebCore::LegacyHTMLTreeConstructor::rtCreateErrorCheck): (WebCore::LegacyHTMLTreeConstructor::nestedCreateErrorCheck): (WebCore::LegacyHTMLTreeConstructor::nestedPCloserCreateErrorCheck): (WebCore::LegacyHTMLTreeConstructor::nestedStyleCreateErrorCheck): (WebCore::LegacyHTMLTreeConstructor::tableCellCreateErrorCheck): (WebCore::LegacyHTMLTreeConstructor::tableSectionCreateErrorCheck): (WebCore::LegacyHTMLTreeConstructor::noembedCreateErrorCheck): (WebCore::LegacyHTMLTreeConstructor::noframesCreateErrorCheck): (WebCore::LegacyHTMLTreeConstructor::noscriptCreateErrorCheck): (WebCore::LegacyHTMLTreeConstructor::pCloserCreateErrorCheck): (WebCore::LegacyHTMLTreeConstructor::pCloserStrictCreateErrorCheck): (WebCore::LegacyHTMLTreeConstructor::mapCreateErrorCheck): (WebCore::mapTagToFunc): (WebCore::mapTagsToFunc): (WebCore::LegacyHTMLTreeConstructor::getNode): (WebCore::LegacyHTMLTreeConstructor::allowNestedRedundantTag): (WebCore::LegacyHTMLTreeConstructor::processCloseTag): (WebCore::LegacyHTMLTreeConstructor::isHeadingTag): (WebCore::LegacyHTMLTreeConstructor::isInline): (WebCore::LegacyHTMLTreeConstructor::isResidualStyleTag): (WebCore::LegacyHTMLTreeConstructor::isAffectedByResidualStyle): (WebCore::LegacyHTMLTreeConstructor::handleResidualStyleCloseTagAcrossBlocks): (WebCore::LegacyHTMLTreeConstructor::reopenResidualStyleTags): (WebCore::LegacyHTMLTreeConstructor::pushBlock): (WebCore::LegacyHTMLTreeConstructor::popBlock): (WebCore::LegacyHTMLTreeConstructor::popOneBlockCommon): (WebCore::LegacyHTMLTreeConstructor::popOneBlock): (WebCore::LegacyHTMLTreeConstructor::moveOneBlockToStack): (WebCore::LegacyHTMLTreeConstructor::checkIfHasPElementInScope): (WebCore::LegacyHTMLTreeConstructor::popInlineBlocks): (WebCore::LegacyHTMLTreeConstructor::freeBlock): (WebCore::LegacyHTMLTreeConstructor::createHead): (WebCore::LegacyHTMLTreeConstructor::handleIsindex): (WebCore::LegacyHTMLTreeConstructor::startBody): (WebCore::LegacyHTMLTreeConstructor::finished): (WebCore::LegacyHTMLTreeConstructor::reportErrorToConsole): (WebCore::shouldCreateImplicitHead): (WebCore::serializeForNumberType): (WebCore::parseToDoubleForNumberType):
  • html/LegacyHTMLTreeConstructor.h: Renamed from WebCore/html/HTMLParser.h. (WebCore::LegacyHTMLTreeConstructor::skipMode): (WebCore::LegacyHTMLTreeConstructor::isHandlingResidualStyleAcrossBlocks): (WebCore::LegacyHTMLTreeConstructor::setSkipMode): (WebCore::LegacyHTMLTreeConstructor::popBlock): (WebCore::LegacyHTMLTreeConstructor::hasPElementInScope): (WebCore::LegacyHTMLTreeConstructor::reportError): (WebCore::LegacyHTMLTreeConstructor::): (WebCore::shouldCreateImplicitHead):
  • html/StepRange.cpp:
  • html/ValidityState.cpp:
  • rendering/RenderSlider.cpp:
9:48 PM Changeset in webkit [61106] by abarth@webkit.org
  • 9 edits in trunk/WebCore

2010-06-13 Eric Seidel <​eric@webkit.org>

Reviewed by Darin Adler.

Rename m_parser, htmlParser() to m_treeConstructor, htmlTreeConstructor() in preparation for renaming HTMLParser
​https://bugs.webkit.org/show_bug.cgi?id=40514

This rename was done by hand. I realize now I should have
renamed HTMLParser to HTMLTreeConstructor before renaming HTMLTokenizer.

No functional changes, thus no tests.

  • dom/DocumentParser.h: (WebCore::DocumentParser::htmlTreeConstructor):
  • html/HTML5DocumentParser.cpp: (WebCore::HTML5DocumentParser::HTML5DocumentParser): (WebCore::HTML5DocumentParser::pumpLexerIfPossible): (WebCore::HTML5DocumentParser::pumpLexer): (WebCore::HTML5DocumentParser::end): (WebCore::HTML5DocumentParser::htmlTreeConstructor): (WebCore::HTML5DocumentParser::isWaitingForScripts): (WebCore::HTML5DocumentParser::resumeParsingAfterScriptExecution): (WebCore::HTML5DocumentParser::notifyFinished): (WebCore::HTML5DocumentParser::executeScriptsWaitingForStylesheets):
  • html/HTML5DocumentParser.h:
  • html/HTML5TreeBuilder.cpp: (WebCore::HTML5TreeBuilder::HTML5TreeBuilder): (WebCore::HTML5TreeBuilder::passTokenToLegacyParser): (WebCore::HTML5TreeBuilder::finished):
  • html/HTML5TreeBuilder.h: (WebCore::HTML5TreeBuilder::legacyTreeConstructor):
  • html/HTMLDocumentParser.cpp: (WebCore::HTMLDocumentParser::HTMLDocumentParser): (WebCore::HTMLDocumentParser::scriptHandler): (WebCore::HTMLDocumentParser::parseTag): (WebCore::HTMLDocumentParser::end): (WebCore::HTMLDocumentParser::processToken): (WebCore::HTMLDocumentParser::processDoctypeToken):
  • html/HTMLDocumentParser.h: (WebCore::HTMLDocumentParser::htmlTreeConstructor):
  • html/HTMLFormControlElement.cpp: (WebCore::HTMLFormControlElement::removedFromTree):
9:44 PM Changeset in webkit [61105] by abarth@webkit.org
  • 6 edits in trunk/WebCore

2010-06-13 Eric Seidel <​eric@webkit.org>

Reviewed by Darin Adler.

Rename tok, asHTMLTokenizer to parser, asHTMLDocumentParser
​https://bugs.webkit.org/show_bug.cgi?id=40513

Last set of Tokenizer related renames, also done via do-webcore-rename:
asHTMLTokenizer => asHTMLDocumentParser
tok => parser

No functional changes, thus no tests.

  • dom/Document.cpp: (WebCore::Document::write):
  • dom/DocumentParser.h: (WebCore::DocumentParser::asHTMLDocumentParser):
  • html/HTMLDocumentParser.cpp: (WebCore::parseHTMLDocumentFragment):
  • html/HTMLDocumentParser.h: (WebCore::HTMLDocumentParser::asHTMLDocumentParser):
  • loader/DocumentLoader.cpp: (WebCore::DocumentLoader::isLoadingInAPISense):
9:40 PM Changeset in webkit [61104] by abarth@webkit.org
  • 37 edits in trunk/WebCore

2010-06-13 Eric Seidel <​eric@webkit.org>

Reviewed by Darin Adler.

Fix the rest of the references to the old Tokenizer class (now DocumentParser)
​https://bugs.webkit.org/show_bug.cgi?id=40512

No functional changes, thus no new tests.
This was mostly done by do-webcore-rename:
tokenizer => parser
m_tokenizer => m_parser
createTextTokenizer => createTextDocumentParser
createTokenizer => createParser
getTokenizer => getParser

However had to be careful to avoid renaming things related to
css/tokenizer.flex (which we should later rename to CSSTokenizer.flex)

Still a couple references with "tok" and "asHTMLTokenizer" which I'll
get in the next patch.

  • accessibility/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::isLoaded):
  • bindings/v8/ScriptEventListener.cpp: (WebCore::createAttributeEventListener):
  • dom/Document.cpp: (WebCore::Document::removedLastRef): (WebCore::Document::~Document): (WebCore::Document::createParser): (WebCore::Document::open): (WebCore::Document::cancelParsing): (WebCore::Document::implicitOpen): (WebCore::Document::implicitClose): (WebCore::Document::write): (WebCore::Document::finishParsing): (WebCore::Document::removePendingSheet):
  • dom/Document.h: (WebCore::Document::parser):
  • dom/DocumentParser.h:
  • dom/ViewportArguments.cpp: (WebCore::reportViewportWarning):
  • dom/XMLDocumentParserLibxml2.cpp: (WebCore::PendingCallbacks::callAndRemoveFirstCallback): (WebCore::PendingCallbacks::PendingStartElementNSCallback::call): (WebCore::PendingCallbacks::PendingEndElementNSCallback::call): (WebCore::PendingCallbacks::PendingCharactersCallback::call): (WebCore::PendingCallbacks::PendingProcessingInstructionCallback::call): (WebCore::PendingCallbacks::PendingCDATABlockCallback::call): (WebCore::PendingCallbacks::PendingCommentCallback::call): (WebCore::PendingCallbacks::PendingInternalSubsetCallback::call): (WebCore::PendingCallbacks::): (WebCore::getParser): (WebCore::startElementNsHandler): (WebCore::endElementNsHandler): (WebCore::charactersHandler): (WebCore::processingInstructionHandler): (WebCore::cdataBlockHandler): (WebCore::commentHandler): (WebCore::warningHandler): (WebCore::fatalErrorHandler): (WebCore::normalErrorHandler): (WebCore::getEntityHandler): (WebCore::startDocumentHandler): (WebCore::endDocumentHandler): (WebCore::internalSubsetHandler): (WebCore::externalSubsetHandler): (WebCore::parseXMLDocumentFragment):
  • dom/XMLDocumentParserQt.cpp: (WebCore::parseXMLDocumentFragment):
  • html/HTML5EntityParser.cpp:
  • html/HTMLDocument.cpp: (WebCore::HTMLDocument::createParser):
  • html/HTMLDocument.h:
  • html/HTMLDocumentParser.cpp: (WebCore::HTMLDocumentParser::write): (WebCore::HTMLDocumentParser::stopParsing):
  • html/HTMLFormControlElement.cpp: (WebCore::HTMLFormControlElement::removedFromTree):
  • html/HTMLParser.cpp: (WebCore::HTMLParser::finished): (WebCore::HTMLParser::reportErrorToConsole):
  • html/HTMLViewSourceDocument.cpp: (WebCore::HTMLViewSourceDocument::createParser): (WebCore::HTMLViewSourceDocument::addLine):
  • html/HTMLViewSourceDocument.h:
  • loader/DocumentLoader.cpp: (WebCore::DocumentLoader::isLoadingInAPISense):
  • loader/DocumentWriter.cpp: (WebCore::DocumentWriter::begin): (WebCore::DocumentWriter::addData):
  • loader/FTPDirectoryDocument.cpp: (WebCore::FTPDirectoryDocument::createParser):
  • loader/FTPDirectoryDocument.h:
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::stopLoading): (WebCore::FrameLoader::stop):
  • loader/ImageDocument.cpp: (WebCore::ImageDocument::createParser):
  • loader/ImageDocument.h:
  • loader/MediaDocument.cpp: (WebCore::MediaDocument::createParser):
  • loader/MediaDocument.h:
  • loader/PluginDocument.cpp: (WebCore::PluginDocument::createParser):
  • loader/PluginDocument.h:
  • loader/SinkDocument.cpp: (WebCore::SinkDocument::createParser):
  • loader/SinkDocument.h:
  • loader/TextDocument.cpp: (WebCore::TextDocument::createParser): (WebCore::createTextDocumentParser):
  • loader/TextDocument.h:
  • svg/SVGDocumentExtensions.cpp: (WebCore::SVGDocumentExtensions::reportWarning): (WebCore::SVGDocumentExtensions::reportError):
  • wml/WMLDocument.cpp: (WebCore::WMLDocument::finishedParsing):
  • wml/WMLErrorHandling.cpp: (WebCore::reportWMLError):
  • wml/WMLTemplateElement.cpp: (WebCore::WMLTemplateElement::registerTemplatesInDocument):
9:00 PM Changeset in webkit [61103] by Chris Fleizach
  • 9 edits
    2 adds in trunk

AX: link won't return linked element if URL contains #
​https://bugs.webkit.org/show_bug.cgi?id=40192

WebCore:

Reviewed by Darin Adler.

Test: platform/mac/accessibility/internal-link-when-document-has-fragment.html

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::internalLinkElement):

WebKitTools:

Reviewed by Darin Adler.

  • DumpRenderTree/AccessibilityUIElement.cpp:

(linkedUIElementAtIndexCallback):
(AccessibilityUIElement::getJSClass):

  • DumpRenderTree/AccessibilityUIElement.h:
  • DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:

(AccessibilityUIElement::linkedUIElementAtIndex):

  • DumpRenderTree/mac/AccessibilityUIElementMac.mm:

(AccessibilityUIElement::linkedUIElementAtIndex):

  • DumpRenderTree/win/AccessibilityUIElementWin.cpp:

(AccessibilityUIElement::linkedUIElementAtIndex):

LayoutTests:

Reviewed by Darin Alder.

  • platform/mac/accessibility/internal-link-when-document-has-fragment-expected.txt: Added.
  • platform/mac/accessibility/internal-link-when-document-has-fragment.html: Added.
8:37 PM Changeset in webkit [61102] by Simon Fraser
  • 3 edits in trunk/LayoutTests

2010-06-13 Simon Fraser <Simon Fraser>

Fix GTK bots; don't include the offsetWidth in the results
since it can differ between platforms.

  • transitions/font-family-during-transition-expected.txt:
  • transitions/font-family-during-transition.html:
7:42 PM Changeset in webkit [61101] by weinig@apple.com
  • 3 edits in trunk/WebCore

Try and fix the chrome build.

  • bindings/scripts/CodeGeneratorV8.pm:
  • xml/XMLHttpRequest.idl:
7:27 PM Changeset in webkit [61100] by weinig@apple.com
  • 16 edits
    3 adds
    2 deletes in trunk

WebCore: Fix for ​https://bugs.webkit.org/show_bug.cgi?id=40550
XMLHttpRequest constructor object should expose the constants from the IDL.

Reviewed by Anders Carlsson.

Test: fast/dom/XMLHttpRequest-constants.html

  • Android.jscbindings.mk:
  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSBindingsAllInOne.cpp:
  • bindings/js/JSDOMWindowCustom.cpp:
  • bindings/js/JSWorkerContextCustom.cpp:
  • bindings/js/JSXMLHttpRequestConstructor.cpp: Removed.
  • bindings/js/JSXMLHttpRequestConstructor.h: Removed.
  • bindings/js/JSXMLHttpRequestCustom.cpp:

(WebCore::JSXMLHttpRequestConstructor::constructJSXMLHttpRequest):

  • bindings/scripts/CodeGeneratorJS.pm:
  • xml/XMLHttpRequest.idl:

LayoutTests: Update tests for ​https://bugs.webkit.org/show_bug.cgi?id=40550
XMLHttpRequest constructor object should expose the constants from the IDL.

Reviewed by Anders Carlsson.

  • fast/dom/Window/window-properties-expected.txt:
  • fast/dom/XMLHttpRequest-constants-expected.txt: Added.
  • fast/dom/XMLHttpRequest-constants.html: Added.
  • fast/dom/script-tests/XMLHttpRequest-constants.js: Added.
6:47 PM Changeset in webkit [61099] by Simon Fraser
  • 4 edits
    2 adds in trunk

2010-06-13 Simon Fraser <Simon Fraser>

Reviewed by Dan Bernstein.

-webkit-transition font-size and font-family
​https://bugs.webkit.org/show_bug.cgi?id=33429

When animating font-size, update the font with a saved
version of the font selector to ensure that we don't clobber
the font family.

Test: transitions/font-family-during-transition.html

  • rendering/style/RenderStyle.cpp: (WebCore::RenderStyle::setBlendedFontSize):
6:37 PM Changeset in webkit [61098] by eric@webkit.org
  • 6 edits
    1 add in trunk/WebKitTools

2010-06-13 Adam Barth <​abarth@webkit.org>

Reviewed by Darin Adler.

webkit-patch should add a bug URL to ChangeLogs if they don't have one yet
​https://bugs.webkit.org/show_bug.cgi?id=39550

This can cause an extra request to bugs.webkit.org durig upload, but it
shouldn't be too bad. Also, this won't work if you remove the
boilerplate created by prepare-ChangeLog.

  • Scripts/webkitpy/common/checkout/changelog.py:
  • Scripts/webkitpy/common/checkout/changelog_unittest.py:
  • Scripts/webkitpy/common/net/bugzilla.py:
  • Scripts/webkitpy/tool/steps/abstractstep.py:
  • Scripts/webkitpy/tool/steps/preparechangelog.py:
  • Scripts/webkitpy/tool/steps/preparechangelog_unittest.py: Added.
5:58 PM Changeset in webkit [61097] by tony@chromium.org
  • 5 edits in trunk

2010-06-13 Tony Chang <​tony@chromium.org>

Build fix, not reviewed.

fix chromium compile after r61094 (id attribute refactor)
​https://bugs.webkit.org/show_bug.cgi?id=40553

  • bindings/v8/custom/V8NamedNodesCollection.cpp: (WebCore::V8NamedNodesCollection::itemWithName):

2010-06-13 Tony Chang <​tony@chromium.org>

Build fix, not reviewed.

fix chromium compile after r61094 (id attribute refactor)
​https://bugs.webkit.org/show_bug.cgi?id=40553

  • src/ChromeClientImpl.cpp:
  • src/WebFormControlElement.cpp: (WebKit::WebFormControlElement::nameForAutofill):
12:01 PM Changeset in webkit [61096] by Darin Adler
  • 5 edits in trunk/LayoutTests

Updated Windows-platform results for the fix for bug 40394.
The patch fixed the cross-platform results, GTK results, and Qt results,
but there were Windows results too.

  • platform/win/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/win/fast/dom/prototype-inheritance-2-expected.txt:
  • platform/win/fast/dom/prototype-inheritance-expected.txt:
  • platform/win/fast/js/global-constructors-expected.txt:
10:50 AM Changeset in webkit [61095] by Darin Adler
  • 1 edit in trunk/WebCore/ChangeLog

Partly done support for alternate ID attributes should be removed
​https://bugs.webkit.org/show_bug.cgi?id=39692

Reviewed by Alexey Proskuryakov.

Removed the include of "HTMLNames.h" from "Element.h". This prevents
near-world-rebuilds every time you change HTMLTagNames.in.

Renamed the getIDAttribute function in the Element class to
idForStyleResolution, since it returns a value of the id attribute
that has been lowercased as appropriate for style matching, not the
actual value of the attribute. With the old name it was easy to
misuse it in non-style contexts.

Got rid of the idAttributeName function on Element, since it is
easy to use it wrong. Replace it with isIdAttributeName, getIdAttribute,
and setIdAttribute functions, which are a good fit for the needs of
most call sites that were dealing with the id attribute.

Added an idAttributeName function to Document. This is for a future
where a document can have a custom id attribute name specified in its
doctype. It's possible this will be insufficient because the same
document might have XHTML or SVG elements in it, and it's possible
that on those elements we will want the attribute named "id" with
no namespace to still work. We can deal with that when we implement
the actual feature, though. For now, it seems OK to fetch the name
of the id attribute from the document.

  • dom/DynamicNodeList.cpp:

(WebCore::DynamicNodeList::itemWithName):

  • dom/StaticNodeList.cpp:

(WebCore::StaticNodeList::itemWithName):

  • rendering/RenderSVGResourceContainer.h:

(WebCore::RenderSVGResourceContainer::RenderSVGResourceContainer):
(WebCore::RenderSVGResourceContainer::idChanged):

  • svg/SVGUseElement.cpp:

(WebCore::SVGUseElement::handleDeepUseReferencing):

  • svg/animation/SMILTimeContainer.cpp:

(WebCore::SMILTimeContainer::updateAnimations):
Use the new idForStyleResolution function, which is the new name of
the getIDAttribute function. There's a good chance these call sites are
incorrect, which is something we should investigate later, so there's
a FIXME at each call site.

  • dom/Document.cpp:

(WebCore::Document::Document): Initialize m_idAttributeName to the
standard id attribute from HTML.
(WebCore::Document::getElementById): Use Element::getIdAttribute.

  • dom/Document.h: Added Document::idAttributeName.
  • dom/Element.cpp:

(WebCore::Element::setAttribute): Use Document::idAttributeName.
(WebCore::Element::setAttributeMap): Use Element::isIdAttributeName.
(WebCore::Element::insertedIntoDocument): Use Document::idAttributeName.
(WebCore::Element::removedFromDocument): Ditto.
(WebCore::Element::formatForDebugger): Use Element::getIdAttribute.

  • dom/Element.h: Added isIdAttributeName, getIdAttribute, setIdAttribute,

idForStyleResolution. Removed rareIDAttributeName.

  • dom/ElementRareData.h: Removed m_idAttributeName.
  • dom/NamedNodeMap.cpp:

(WebCore::NamedNodeMap::setAttributes): Use Document::idAttributeName.

  • dom/NamedNodeMap.h: Renamed id, setID, and m_id to idForStyleResolution,

setIdForStyleResolution, and m_idForStyleResolution since this is not the
value of the id attribute because it gets lowercased for compatibility-mode
documents.

  • rendering/RenderIFrame.cpp:
  • rendering/RenderLayerCompositor.cpp:
  • rendering/RenderProgress.cpp:

Added include of HTMLNames.h now that Element.h no longer includes it.

  • editing/SetNodeAttributeCommand.h:
  • editing/markup.cpp:
  • html/HTMLParser.cpp:

Removed unneeded includes.

  • html/HTMLParser.h: Sorted includes.
  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::matchRules): Use idForStyleResolution.
(WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector): Use idForStyleResolution.

  • dom/Attr.cpp:

(WebCore::Attr::isId): Use Document::idAttributeName.

  • dom/StyledElement.cpp:

(WebCore::StyledElement::parseMappedAttribute): Use isIdAttributeName,
and setIdForStyleResolution.

  • editing/DeleteButtonController.cpp:

(WebCore::DeleteButtonController::createDeletionUI): Use setIdAttribute.

  • editing/EditorCommand.cpp:

(WebCore::executeInsertHorizontalRule): Ditto.

  • html/HTMLAppletElement.cpp:

(WebCore::HTMLAppletElement::parseMappedAttribute): Use isIdAttributeName.
(WebCore::HTMLAppletElement::createRenderer): Use getIdAttribute.

  • html/HTMLCollection.cpp:

(WebCore::HTMLCollection::checkForNameMatch): Use getIdAttribute.
(WebCore::HTMLCollection::updateNameCache): Use getIdAttribute.

  • html/HTMLDataGridColElement.cpp:

(WebCore::HTMLDataGridColElement::ensureColumn): Use getIdAttribute.
(WebCore::HTMLDataGridColElement::parseMappedAttribute): Use isIdAttributeName.

  • html/HTMLElement.cpp:

(WebCore::HTMLElement::parseMappedAttribute): Use isIdAttributeName.

  • html/HTMLFormCollection.cpp:

(WebCore::HTMLFormCollection::nextNamedItem): Added missing braces.
(WebCore::HTMLFormCollection::updateNameCache): Use getIdAttribute.

  • html/HTMLFrameElementBase.cpp:

(WebCore::HTMLFrameElementBase::parseMappedAttribute): Use isIdAttributeName.
(WebCore::HTMLFrameElementBase::setName): Use getIdAttribute.

  • html/HTMLImageElement.cpp:

(WebCore::HTMLImageElement::parseMappedAttribute): Use isIdAttributeName.

  • html/HTMLMapElement.cpp:

(WebCore::HTMLMapElement::parseMappedAttribute): Use isIdAttributeName.
Also restructured the function a bit to make its structure clearer and added
a comment pointing out that it can't be quite right.

  • html/HTMLNameCollection.cpp:

(WebCore::HTMLNameCollection::itemAfter): Use getIdAttribute.

  • html/HTMLObjectElement.cpp:

(WebCore::HTMLObjectElement::parseMappedAttribute): Use isIdAttributeName.

  • html/HTMLParamElement.cpp:

(WebCore::HTMLParamElement::parseMappedAttribute): Use isIdAttributeName.

  • loader/CachedFont.cpp:

(WebCore::CachedFont::getSVGFontById): Use getIdAttribute.

  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::nameForLayer): Use getIdAttribute.

  • rendering/SVGRenderTreeAsText.cpp:

(WebCore::writeSVGPaintingResource): Use getIdAttribute.
(WebCore::writeSVGResourceContainer): Ditto.

  • svg/SVGElement.cpp:

(WebCore::SVGElement::insertedIntoDocument): Use getIdAttribute.

  • svg/SVGStyledElement.cpp:

(WebCore::SVGStyledElement::isKnownAttribute): Use isIdAttributeName.
(WebCore::SVGStyledElement::svgAttributeChanged): Use isIdAttributeName.

  • wml/WMLElement.cpp:

(WebCore::WMLElement::parseMappedAttribute): Use isIdAttributeName.

10:29 AM Changeset in webkit [61094] by Darin Adler
  • 45 edits in trunk/WebCore

2010-06-12 Darin Adler <Darin Adler>

Reviewed by Alexey Proskuryakov.

Partly done support for alternate ID attributes should be removed
​https://bugs.webkit.org/show_bug.cgi?id=39692

Removed the include of "HTMLNames.h" from "Element.h". This prevents
near-world-rebuilds every time you change HTMLTagNames.in.

Renamed the getIDAttribute function in the Element class to
idForStyleResolution, since it returns a value of the id attribute
that has been lowercased as appropriate for style matching, not the
actual value of the attribute. With the old name it was easy to
misuse it in non-style contexts.

Got rid of the idAttributeName function on Element, since it is
easy to use it wrong. Replace it with isIdAttributeName, getIdAttribute,
and setIdAttribute functions, which are a good fit for the needs of
most call sites that were dealing with the id attribute.

Added an idAttributeName function to Document. This is for a future
where a document can have a custom id attribute name specified in its
doctype. It's possible this will be insufficient because the same
document might have XHTML or SVG elements in it, and it's possible
that on those elements we will want the attribute named "id" with
no namespace to still work. We can deal with that when we implement
the actual feature, though. For now, it seems OK to fetch the name
of the id attribute from the document.

  • dom/DynamicNodeList.cpp: (WebCore::DynamicNodeList::itemWithName):
  • dom/StaticNodeList.cpp: (WebCore::StaticNodeList::itemWithName):
  • rendering/RenderSVGResourceContainer.h: (WebCore::RenderSVGResourceContainer::RenderSVGResourceContainer): (WebCore::RenderSVGResourceContainer::idChanged):
  • svg/SVGUseElement.cpp: (WebCore::SVGUseElement::handleDeepUseReferencing):
  • svg/animation/SMILTimeContainer.cpp: (WebCore::SMILTimeContainer::updateAnimations): Use the new idForStyleResolution function, which is the new name of the getIDAttribute function. There's a good chance these call sites are incorrect, which is something we should investigate later, so there's a FIXME at each call site.
  • dom/Document.cpp: (WebCore::Document::Document): Initialize m_idAttributeName to the standard id attribute from HTML. (WebCore::Document::getElementById): Use Element::getIdAttribute.
  • dom/Document.h: Added Document::idAttributeName.
  • dom/Element.cpp: (WebCore::Element::setAttribute): Use Document::idAttributeName. (WebCore::Element::setAttributeMap): Use Element::isIdAttributeName. (WebCore::Element::insertedIntoDocument): Use Document::idAttributeName. (WebCore::Element::removedFromDocument): Ditto. (WebCore::Element::formatForDebugger): Use Element::getIdAttribute.
  • dom/Element.h: Added isIdAttributeName, getIdAttribute, setIdAttribute, idForStyleResolution. Removed rareIDAttributeName.
  • dom/ElementRareData.h: Removed m_idAttributeName.
  • dom/NamedNodeMap.cpp: (WebCore::NamedNodeMap::setAttributes): Use Document::idAttributeName.
  • dom/NamedNodeMap.h: Renamed id, setID, and m_id to idForStyleResolution, setIdForStyleResolution, and m_idForStyleResolution since this is not the value of the id attribute because it gets lowercased for compatibility-mode documents.
  • rendering/RenderIFrame.cpp:
  • rendering/RenderLayerCompositor.cpp:
  • rendering/RenderProgress.cpp: Added include of HTMLNames.h now that Element.h no longer includes it.
  • editing/SetNodeAttributeCommand.h:
  • editing/markup.cpp:
  • html/HTMLParser.cpp: Removed unneeded includes.
  • html/HTMLParser.h: Sorted includes.
  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::matchRules): Use idForStyleResolution. (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector): Use idForStyleResolution.
  • dom/Attr.cpp: (WebCore::Attr::isId): Use Document::idAttributeName.
  • dom/StyledElement.cpp: (WebCore::StyledElement::parseMappedAttribute): Use isIdAttributeName, and setIdForStyleResolution.
  • editing/DeleteButtonController.cpp: (WebCore::DeleteButtonController::createDeletionUI): Use setIdAttribute.
  • editing/EditorCommand.cpp: (WebCore::executeInsertHorizontalRule): Ditto.
  • html/HTMLAppletElement.cpp: (WebCore::HTMLAppletElement::parseMappedAttribute): Use isIdAttributeName. (WebCore::HTMLAppletElement::createRenderer): Use getIdAttribute.
  • html/HTMLCollection.cpp: (WebCore::HTMLCollection::checkForNameMatch): Use getIdAttribute. (WebCore::HTMLCollection::updateNameCache): Use getIdAttribute.
  • html/HTMLDataGridColElement.cpp: (WebCore::HTMLDataGridColElement::ensureColumn): Use getIdAttribute. (WebCore::HTMLDataGridColElement::parseMappedAttribute): Use isIdAttributeName.
  • html/HTMLElement.cpp: (WebCore::HTMLElement::parseMappedAttribute): Use isIdAttributeName.
  • html/HTMLFormCollection.cpp: (WebCore::HTMLFormCollection::nextNamedItem): Added missing braces. (WebCore::HTMLFormCollection::updateNameCache): Use getIdAttribute.
  • html/HTMLFrameElementBase.cpp: (WebCore::HTMLFrameElementBase::parseMappedAttribute): Use isIdAttributeName. (WebCore::HTMLFrameElementBase::setName): Use getIdAttribute.
  • html/HTMLImageElement.cpp: (WebCore::HTMLImageElement::parseMappedAttribute): Use isIdAttributeName.
  • html/HTMLMapElement.cpp: (WebCore::HTMLMapElement::parseMappedAttribute): Use isIdAttributeName. Also restructured the function a bit to make its structure clearer and added a comment pointing out that it can't be quite right.
  • html/HTMLNameCollection.cpp: (WebCore::HTMLNameCollection::itemAfter): Use getIdAttribute.
  • html/HTMLObjectElement.cpp: (WebCore::HTMLObjectElement::parseMappedAttribute): Use isIdAttributeName.
  • html/HTMLParamElement.cpp: (WebCore::HTMLParamElement::parseMappedAttribute): Use isIdAttributeName.
  • loader/CachedFont.cpp: (WebCore::CachedFont::getSVGFontById): Use getIdAttribute.
  • rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::nameForLayer): Use getIdAttribute.
  • rendering/SVGRenderTreeAsText.cpp: (WebCore::writeSVGPaintingResource): Use getIdAttribute. (WebCore::writeSVGResourceContainer): Ditto.
  • svg/SVGElement.cpp: (WebCore::SVGElement::insertedIntoDocument): Use getIdAttribute.
  • svg/SVGStyledElement.cpp: (WebCore::SVGStyledElement::isKnownAttribute): Use isIdAttributeName. (WebCore::SVGStyledElement::svgAttributeChanged): Use isIdAttributeName.
  • wml/WMLElement.cpp: (WebCore::WMLElement::parseMappedAttribute): Use isIdAttributeName.
10:22 AM Changeset in webkit [61093] by mitz@apple.com
  • 2 edits in trunk/LayoutTests

Updated results after r61092.

  • fast/events/continuous-platform-wheelevent-in-scrolling-div-expected.txt:
9:40 AM Changeset in webkit [61092] by mitz@apple.com
  • 2 edits in trunk/WebCore

<rdar://problem/8087385> REGRESSION (r60974): Continuous wheel scrolling is too fast in list boxes and in Safari Reader
​https://bugs.webkit.org/show_bug.cgi?id=40537

Reviewed by Darin Adler.

  • platform/mac/WheelEventMac.mm:

(WebCore::PlatformWheelEvent::PlatformWheelEvent): Only multiply by pixelsPerLineStep() if the
event is not continuous, as was before r56012.

6:54 AM Changeset in webkit [61091] by abecsi@webkit.org
  • 18 edits
    1 add
    1 delete in trunk

Centralize the gperf code generation commands into make-hash-tools.pl
to avoid redundancy across multiple build systems.
Do this in preparation of refactoring the usage of these generated
sources to fix the debug linking error on Linux with gcc >= 4.4.0.

WebCore:

Reviewed by Darin Adler.

webkit.org/b/29244

No functionality change, so no new tests needed.

  • DerivedSources.make:
  • GNUmakefile.am:
  • WebCore.gyp/WebCore.gyp:
  • WebCore.gyp/scripts/rule_gperf.py: Removed.
  • WebCore.pri:
  • WebCore.xcodeproj/project.pbxproj:
  • css/CSSParser.cpp:

(WebCore::cssPropertyID):
(WebCore::cssValueKeywordID):

  • css/makeprop.pl:
  • css/makevalues.pl:
  • html/DocTypeStrings.gperf:
  • html/HTML5EntityParser.cpp:
  • html/HTMLDocumentParser.cpp:
  • html/HTMLEntityNames.gperf:
  • html/PreloadScanner.cpp:
  • make-hash-tools.pl: Added.
  • platform/ColorData.gperf:
  • platform/graphics/Color.cpp:

WebKit/chromium:

Patch by Andras Becsi <​abecsi@inf.u-szeged.hu> on 2010-06-13
Reviewed by Darin Adler.

webkit.org/b/29244

  • src/WebEntities.cpp:
6:29 AM Changeset in webkit [61090] by robert@webkit.org
  • 8 edits in trunk

2010-06-08 Robert Hogan <​robert@webkit.org>

Reviewed by Eric Seidel.

[Qt] Add support for callShouldCloseOnWebView() to DRT
​https://bugs.webkit.org/show_bug.cgi?id=40330

  • platform/qt/Skipped: Unskip fast/events/onbeforeunload-focused-iframe.html

2010-06-08 Robert Hogan <​robert@webkit.org>

Reviewed by Eric Seidel.

[Qt] Add support for callShouldCloseOnWebView() to DRT
​https://bugs.webkit.org/show_bug.cgi?id=40330

  • WebCoreSupport/DumpRenderTreeSupportQt.cpp: (DumpRenderTreeSupportQt::shouldClose):
  • WebCoreSupport/DumpRenderTreeSupportQt.h:

2010-06-08 Robert Hogan <​robert@webkit.org>

Reviewed by Eric Seidel.

[Qt] Add support for callShouldCloseOnWebView() to DRT
​https://bugs.webkit.org/show_bug.cgi?id=40330

  • DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::callShouldCloseOnWebView):
  • DumpRenderTree/qt/LayoutTestControllerQt.h: (LayoutTestController::setCallCloseOnWebViews):
6:05 AM Changeset in webkit [61089] by eric@webkit.org
  • 4 edits in trunk/WebCore

2010-06-13 Noam Rosenthal <​noam.rosenthal@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] tests/hybridPixmap fails
​https://bugs.webkit.org/show_bug.cgi?id=37316

The problem was that JSC::Instance::createRuntimeObject was never called.
This is fixed by overloading newRuntimeObject and calling Instance::createRuntimeObject
in between, instead of creating the runtime object directly inside the static function
QtPixmapInstance::createRuntimeObject, which had to be renamed as to not overshadow the virtual function.

This fixes an existing test, tests/hybridPixmap

  • bridge/qt/qt_pixmapruntime.cpp: (JSC::Bindings::QtPixmapInstance::newRuntimeObject): (JSC::Bindings::QtPixmapInstance::createPixmapRuntimeObject):
  • bridge/qt/qt_pixmapruntime.h:
  • bridge/qt/qt_runtime.cpp: (JSC::Bindings::convertQVariantToValue):
2:11 AM Changeset in webkit [61088] by adachan@apple.com
  • 3 edits in trunk/WebKit2

Unreviewed fix for a linking error with WebKit2LocalizableStringsBundle for Windows release build.

  • WebProcess/win/WebLocalizableStrings.cpp: (findCachedString):
1:33 AM Changeset in webkit [61087] by eric@webkit.org
  • 3 edits in trunk/WebCore

2010-06-13 Noam Rosenthal <​noam.rosenthal@nokia.com>

Reviewed by Darin Adler.

GraphicsContext3D.h in the Qt port includes too many unnecessary files
​https://bugs.webkit.org/show_bug.cgi?id=40536

Removed unncessary includes.

No new tests; Compilation improvement.

  • platform/graphics/GraphicsContext3D.h:
  • platform/graphics/qt/GraphicsContext3DQt.cpp:
1:20 AM Changeset in webkit [61086] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-06-13 Noam Rosenthal <​noam.rosenthal@nokia.com>

Reviewed by Eric Seidel.

[Qt] GraphicsLayer: recaching images creates an unnecessary deep copy
​https://bugs.webkit.org/show_bug.cgi?id=40535

Made sure the painter ends its operation before copying the pixmap.

No new tests: this is an optimization.

  • platform/graphics/qt/GraphicsLayerQt.cpp: (WebCore::GraphicsLayerQtImpl::recache):
12:54 AM Changeset in webkit [61085] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-06-13 Clemmitt Sigler <​cmsigler@gmail.com>

Reviewed by Eric Seidel.

Patch to fix missing references to RenderMathMLRoot,
RenderMathMLSquareRoot when building GtkLauncher.
​https://bugs.webkit.org/show_bug.cgi?id=40326

No change in functionality so no new tests.

  • GNUmakefile.am:

Jun 12, 2010:

10:50 PM Changeset in webkit [61084] by dimich@chromium.org
  • 2 edits in trunk/LayoutTests

Not reviewed, update Chromium expected result following r61071.

  • platform/chromium/fast/dom/prototype-inheritance-expected.txt:
10:49 PM Changeset in webkit [61083] by adachan@apple.com
  • 2 edits
    1 add in trunk/WebCore

2010-06-12 Brian Weinstein <​bweinstein@apple.com>

Reviewed by Dan Bernstein.


​https://bugs.webkit.org/show_bug.cgi?id=40538


Some machines have started to see the return of the dreaded: WebCore.lib : fatal error LNK1106: invalid
file or disk full. Since we don't have the hotfix for VS2005, work around this in the meantime
by creating an EditingAllInOne file, that includes all of the cpp files in the editing subdirectory.


  • WebCore.vcproj/WebCore.vcproj: Prevnt the editing cpp from building, so we only compile EditingAllInOne.
  • editing/EditingAllInOne.cpp: Added. Includes all of the editing cpp files.
10:39 PM Changeset in webkit [61082] by eric@webkit.org
  • 3 edits in trunk/WebCore

2010-06-12 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r61031.
​http://trac.webkit.org/changeset/61031
​https://bugs.webkit.org/show_bug.cgi?id=40539

Crashes Dromaeo jslib test in Release Chromium (Requested by
dimich_ on #webkit).

  • bindings/v8/V8Binding.cpp: (WebCore::v8ExternalString):
  • bindings/v8/V8Binding.h:
10:36 PM Changeset in webkit [61081] by eric@webkit.org
  • 8 edits in trunk/WebCore

2010-06-12 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Rename the last few *Tokenizer classes (which don't have their own files) to *DocumentParser
​https://bugs.webkit.org/show_bug.cgi?id=40508

This was a very simple do-webcore-rename-generated patch.

PluginTokenizer => PluginDocumentParser
TextTokenizer => TextDocumentParser
SinkTokenizer => SinkDocumentParser
MediaTokenizer => MediaDocumentParser
FTPDirectoryTokenizer => FTPDirectoryDocumentParser

No functional changes, thus no tests.

  • html/HTMLViewSourceDocument.cpp: (WebCore::HTMLViewSourceDocument::createTokenizer):
  • html/HTMLViewSourceDocument.h:
  • loader/FTPDirectoryDocument.cpp: (WebCore::FTPDirectoryDocumentParser::FTPDirectoryDocumentParser): (WebCore::FTPDirectoryDocumentParser::appendEntry): (WebCore::FTPDirectoryDocumentParser::createTDForFilename): (WebCore::FTPDirectoryDocumentParser::parseAndAppendOneLine): (WebCore::FTPDirectoryDocumentParser::loadDocumentTemplate): (WebCore::FTPDirectoryDocumentParser::createBasicDocument): (WebCore::FTPDirectoryDocumentParser::write): (WebCore::FTPDirectoryDocumentParser::finish): (WebCore::FTPDirectoryDocument::createTokenizer):
  • loader/MediaDocument.cpp: (WebCore::MediaDocumentParser::MediaDocumentParser): (WebCore::MediaDocumentParser::write): (WebCore::MediaDocumentParser::createDocumentStructure): (WebCore::MediaDocumentParser::writeRawData): (WebCore::MediaDocumentParser::finish): (WebCore::MediaDocumentParser::isWaitingForScripts): (WebCore::MediaDocument::createTokenizer):
  • loader/PluginDocument.cpp: (WebCore::PluginDocumentParser::PluginDocumentParser): (WebCore::PluginDocumentParser::pluginWidgetFromDocument): (WebCore::PluginDocumentParser::write): (WebCore::PluginDocumentParser::createDocumentStructure): (WebCore::PluginDocumentParser::writeRawData): (WebCore::PluginDocumentParser::finish): (WebCore::PluginDocumentParser::isWaitingForScripts): (WebCore::PluginDocument::createTokenizer): (WebCore::PluginDocument::pluginWidget):
  • loader/SinkDocument.cpp: (WebCore::SinkDocumentParser::SinkDocumentParser): (WebCore::SinkDocumentParser::finish): (WebCore::SinkDocument::createTokenizer):
  • loader/TextDocument.cpp: (WebCore::TextDocumentParser::TextDocumentParser): (WebCore::TextDocumentParser::~TextDocumentParser): (WebCore::TextDocumentParser::write): (WebCore::TextDocumentParser::finish): (WebCore::TextDocumentParser::isWaitingForScripts): (WebCore::TextDocument::createTokenizer): (WebCore::createTextTokenizer):
10:19 PM Changeset in webkit [61080] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2010-06-12 Eric Seidel <​eric@webkit.org>

Reviewed by Daniel Bates.

do-webcore-rename should have a --verbose option
​https://bugs.webkit.org/show_bug.cgi?id=40497

  • Scripts/do-webcore-rename:
    • Unified how we handle skipping files/directories this will allow us to "black list" certain files and directories when performing renames.
    • Made do-webcore-rename log what it's skipping when passed --verbose.
9:52 PM Changeset in webkit [61079] by Darin Adler
  • 2 edits in trunk/WebKitTools
  • Scripts/run-bindings-tests: Fixed a typo in a message.
9:46 PM Changeset in webkit [61078] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-06-12 Anders Bakken <​agbakken@gmail.com>

Reviewed by Eric Seidel.

[Qt] EventHandlerQt.cpp has coding-style errors
​https://bugs.webkit.org/show_bug.cgi?id=40259

Coding style change only.

  • page/qt/EventHandlerQt.cpp: (WebCore::EventHandler::eventActivatedView):
9:29 PM Changeset in webkit [61077] by eric@webkit.org
  • 8 edits
    1 delete in trunk/WebCore

2010-06-12 Kwang Yul Seo <​skyul@company100.net>

Reviewed by Darin Adler.

Unify fileSystemRepresentation and filenameFromString
​https://bugs.webkit.org/show_bug.cgi?id=40201

Remove filenameFromString and use fileSystemRepresentation instead
as they do the same job.

  • platform/FileSystem.cpp: Removed.
  • platform/FileSystem.h:
  • platform/efl/FileSystemEfl.cpp: (WebCore::fileSystemRepresentation):
  • platform/gtk/FileChooserGtk.cpp: (WebCore::FileChooser::basenameForWidth):
  • platform/gtk/FileSystemGtk.cpp: (WebCore::fileSystemRepresentation): (WebCore::filenameForDisplay): (WebCore::fileExists): (WebCore::deleteFile): (WebCore::deleteEmptyDirectory): (WebCore::getFileSize): (WebCore::getFileModificationTime): (WebCore::makeAllDirectories): (WebCore::pathGetFileName): (WebCore::directoryName): (WebCore::listDirectory):
  • platform/gtk/SharedBufferGtk.cpp: (WebCore::SharedBuffer::createWithContentsOfFile):
  • platform/network/soup/ResourceHandleSoup.cpp: (WebCore::startHttp):
  • platform/posix/SharedBufferPOSIX.cpp: (WebCore::SharedBuffer::createWithContentsOfFile):
9:15 PM Changeset in webkit [61076] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-06-12 Patrick Gansterer <​paroga@paroga.com>

Reviewed by Eric Seidel.

[Haiku] Cleanup SharedBuffer::createWithContentsOfFile
​https://bugs.webkit.org/show_bug.cgi?id=39003

  • platform/haiku/SharedBufferHaiku.cpp: (WebCore::SharedBuffer::createWithContentsOfFile):
9:04 PM Changeset in webkit [61075] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-06-12 Anders Bakken <​agbakken@gmail.com>

Reviewed by Eric Seidel.

[Qt] WheelEventQt.cpp has coding-style errors
​https://bugs.webkit.org/show_bug.cgi?id=39760

  • platform/qt/WheelEventQt.cpp: (WebCore::PlatformWheelEvent::PlatformWheelEvent):
8:41 PM Changeset in webkit [61074] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-06-12 Kwang Yul Seo <​skyul@company100.net>

Reviewed by Kent Tamura.

[BREWMP] Don't include POSIX headers in WebCorePrefix.h
​https://bugs.webkit.org/show_bug.cgi?id=39411

When building for BREW MP, don't include POSIX headers:
<fcntl.h>, <pthread.h> and <sys/types.h>.

  • WebCorePrefix.h:
7:16 PM Changeset in webkit [61073] by eric@webkit.org
  • 40 edits
    10 moves in trunk

2010-06-11 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Rename the rest of the *Tokenizer classes to *DocumentParser
​https://bugs.webkit.org/show_bug.cgi?id=40507

  • wtf/Platform.h:
    • fixed a comment to match new names.

2010-06-11 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Rename the rest of the *Tokenizer classes to *DocumentParser
​https://bugs.webkit.org/show_bug.cgi?id=40507

This search/replace was done by do-webcore-rename.
Just looking for a rubber stamp.

XMLTokenizer => XMLDocumentParser
XMLTokenizerLibxml2 => XMLDocumentParserLibxml2
XMLTokenizerQt => XMLDocumentParserQt
XMLTokenizerScope => XMLDocumentParserScope
HTML5Tokenizer => HTML5DocumentParser
HTMLTokenizer => HTMLDocumentParser

No functional change, thus no tests.

  • Android.mk:
  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • css/CSSStyleSheet.cpp: (WebCore::CSSStyleSheet::checkLoaded):
  • dom/Document.cpp: (WebCore::Document::createTokenizer): (WebCore::Document::write):
  • dom/Document.h: (WebCore::Document::setXMLEncoding):
  • dom/DocumentParser.h: (WebCore::DocumentParser::asHTMLTokenizer):
  • dom/Element.cpp:
  • dom/ProcessingInstruction.cpp:
  • dom/XMLDocumentParser.cpp: Added. (WebCore::XMLDocumentParser::isWMLDocument): (WebCore::XMLDocumentParser::pushCurrentNode): (WebCore::XMLDocumentParser::popCurrentNode): (WebCore::XMLDocumentParser::clearCurrentNodeStack): (WebCore::XMLDocumentParser::write): (WebCore::XMLDocumentParser::handleError): (WebCore::XMLDocumentParser::enterText): (WebCore::toString): (WebCore::XMLDocumentParser::exitText): (WebCore::XMLDocumentParser::end): (WebCore::XMLDocumentParser::finish): (WebCore::createXHTMLParserErrorHeader): (WebCore::XMLDocumentParser::insertErrorMessageBlock): (WebCore::XMLDocumentParser::notifyFinished): (WebCore::XMLDocumentParser::isWaitingForScripts): (WebCore::XMLDocumentParser::pauseParsing):
  • dom/XMLDocumentParser.h: Added. (WebCore::XMLParserContext::context): (WebCore::XMLParserContext::XMLParserContext): (WebCore::XMLDocumentParser::): (WebCore::XMLDocumentParser::setIsXHTMLDocument): (WebCore::XMLDocumentParser::isXHTMLDocument): (WebCore::XMLDocumentParser::setIsXHTMLMPDocument): (WebCore::XMLDocumentParser::isXHTMLMPDocument): (WebCore::XMLDocumentParser::wellFormed): (WebCore::XMLDocumentParser::context):
  • dom/XMLDocumentParserLibxml2.cpp: Added. (WebCore::PendingCallbacks::~PendingCallbacks): (WebCore::PendingCallbacks::appendStartElementNSCallback): (WebCore::PendingCallbacks::appendEndElementNSCallback): (WebCore::PendingCallbacks::appendCharactersCallback): (WebCore::PendingCallbacks::appendProcessingInstructionCallback): (WebCore::PendingCallbacks::appendCDATABlockCallback): (WebCore::PendingCallbacks::appendCommentCallback): (WebCore::PendingCallbacks::appendInternalSubsetCallback): (WebCore::PendingCallbacks::appendErrorCallback): (WebCore::PendingCallbacks::callAndRemoveFirstCallback): (WebCore::PendingCallbacks::isEmpty): (WebCore::PendingCallbacks::PendingCallback::~PendingCallback): (WebCore::PendingCallbacks::PendingStartElementNSCallback::~PendingStartElementNSCallback): (WebCore::PendingCallbacks::PendingStartElementNSCallback::call): (WebCore::PendingCallbacks::PendingEndElementNSCallback::call): (WebCore::PendingCallbacks::PendingCharactersCallback::~PendingCharactersCallback): (WebCore::PendingCallbacks::PendingCharactersCallback::call): (WebCore::PendingCallbacks::PendingProcessingInstructionCallback::~PendingProcessingInstructionCallback): (WebCore::PendingCallbacks::PendingProcessingInstructionCallback::call): (WebCore::PendingCallbacks::PendingCDATABlockCallback::~PendingCDATABlockCallback): (WebCore::PendingCallbacks::PendingCDATABlockCallback::call): (WebCore::PendingCallbacks::PendingCommentCallback::~PendingCommentCallback): (WebCore::PendingCallbacks::PendingCommentCallback::call): (WebCore::PendingCallbacks::PendingInternalSubsetCallback::~PendingInternalSubsetCallback): (WebCore::PendingCallbacks::PendingInternalSubsetCallback::call): (WebCore::PendingCallbacks::): (WebCore::matchFunc): (WebCore::OffsetBuffer::OffsetBuffer): (WebCore::OffsetBuffer::readOutBytes): (WebCore::shouldAllowExternalLoad): (WebCore::openFunc): (WebCore::readFunc): (WebCore::writeFunc): (WebCore::closeFunc): (WebCore::errorFunc): (WebCore::XMLParserContext::createStringParser): (WebCore::XMLParserContext::createMemoryParser): (WebCore::XMLDocumentParser::XMLDocumentParser): (WebCore::XMLParserContext::~XMLParserContext): (WebCore::XMLDocumentParser::~XMLDocumentParser): (WebCore::XMLDocumentParser::doWrite): (WebCore::toString): (WebCore::handleElementNamespaces): (WebCore::handleElementAttributes): (WebCore::XMLDocumentParser::startElementNs): (WebCore::XMLDocumentParser::endElementNs): (WebCore::XMLDocumentParser::characters): (WebCore::XMLDocumentParser::error): (WebCore::XMLDocumentParser::processingInstruction): (WebCore::XMLDocumentParser::cdataBlock): (WebCore::XMLDocumentParser::comment): (WebCore::XMLDocumentParser::startDocument): (WebCore::XMLDocumentParser::endDocument): (WebCore::XMLDocumentParser::internalSubset): (WebCore::getTokenizer): (WebCore::hackAroundLibXMLEntityBug): (WebCore::startElementNsHandler): (WebCore::endElementNsHandler): (WebCore::charactersHandler): (WebCore::processingInstructionHandler): (WebCore::cdataBlockHandler): (WebCore::commentHandler): (WebCore::warningHandler): (WebCore::fatalErrorHandler): (WebCore::normalErrorHandler): (WebCore::): (WebCore::sharedXHTMLEntity): (WebCore::getXHTMLEntity): (WebCore::getEntityHandler): (WebCore::startDocumentHandler): (WebCore::endDocumentHandler): (WebCore::internalSubsetHandler): (WebCore::externalSubsetHandler): (WebCore::ignorableWhitespaceHandler): (WebCore::XMLDocumentParser::initializeParserContext): (WebCore::XMLDocumentParser::doEnd): (WebCore::xmlDocPtrForString): (WebCore::XMLDocumentParser::lineNumber): (WebCore::XMLDocumentParser::columnNumber): (WebCore::XMLDocumentParser::stopParsing): (WebCore::XMLDocumentParser::resumeParsing): (WebCore::parseXMLDocumentFragment): (WebCore::attributesStartElementNsHandler): (WebCore::parseAttributes):
  • dom/XMLDocumentParserQt.cpp: Added. (WebCore::EntityResolver::resolveUndeclaredEntity): (WebCore::XMLDocumentParser::XMLDocumentParser): (WebCore::XMLDocumentParser::~XMLDocumentParser): (WebCore::XMLDocumentParser::doWrite): (WebCore::XMLDocumentParser::initializeParserContext): (WebCore::XMLDocumentParser::doEnd): (WebCore::XMLDocumentParser::lineNumber): (WebCore::XMLDocumentParser::columnNumber): (WebCore::XMLDocumentParser::stopParsing): (WebCore::XMLDocumentParser::resumeParsing): (WebCore::parseXMLDocumentFragment): (WebCore::attributesStartElementNsHandler): (WebCore::parseAttributes): (WebCore::prefixFromQName): (WebCore::handleElementNamespaces): (WebCore::handleElementAttributes): (WebCore::XMLDocumentParser::parse): (WebCore::XMLDocumentParser::startDocument): (WebCore::XMLDocumentParser::parseStartElement): (WebCore::XMLDocumentParser::parseEndElement): (WebCore::XMLDocumentParser::parseCharacters): (WebCore::XMLDocumentParser::parseProcessingInstruction): (WebCore::XMLDocumentParser::parseCdata): (WebCore::XMLDocumentParser::parseComment): (WebCore::XMLDocumentParser::endDocument): (WebCore::XMLDocumentParser::hasError): (WebCore::XMLDocumentParser::parseDtd):
  • dom/XMLDocumentParserScope.cpp: Added. (WebCore::XMLDocumentParserScope::XMLDocumentParserScope): (WebCore::XMLDocumentParserScope::~XMLDocumentParserScope):
  • dom/XMLDocumentParserScope.h: Added.
  • dom/XMLTokenizer.cpp: Removed.
  • dom/XMLTokenizer.h: Removed.
  • dom/XMLTokenizerLibxml2.cpp: Removed.
  • dom/XMLTokenizerQt.cpp: Removed.
  • dom/XMLTokenizerScope.cpp: Removed.
  • dom/XMLTokenizerScope.h: Removed.
  • html/HTML5DocumentParser.cpp: Added. (WebCore::): (WebCore::HTML5DocumentParser::HTML5DocumentParser): (WebCore::HTML5DocumentParser::~HTML5DocumentParser): (WebCore::HTML5DocumentParser::begin): (WebCore::HTML5DocumentParser::pumpLexerIfPossible): (WebCore::HTML5DocumentParser::pumpLexer): (WebCore::HTML5DocumentParser::write): (WebCore::HTML5DocumentParser::end): (WebCore::HTML5DocumentParser::attemptToEnd): (WebCore::HTML5DocumentParser::endIfDelayed): (WebCore::HTML5DocumentParser::finish): (WebCore::HTML5DocumentParser::executingScript): (WebCore::HTML5DocumentParser::lineNumber): (WebCore::HTML5DocumentParser::columnNumber): (WebCore::HTML5DocumentParser::htmlParser): (WebCore::HTML5DocumentParser::isWaitingForScripts): (WebCore::HTML5DocumentParser::resumeParsingAfterScriptExecution): (WebCore::HTML5DocumentParser::watchForLoad): (WebCore::HTML5DocumentParser::stopWatchingForLoad): (WebCore::HTML5DocumentParser::shouldLoadExternalScriptFromSrc): (WebCore::HTML5DocumentParser::executeScript): (WebCore::HTML5DocumentParser::notifyFinished): (WebCore::HTML5DocumentParser::executeScriptsWaitingForStylesheets): (WebCore::HTML5DocumentParser::script):
  • html/HTML5DocumentParser.h: Added. (WebCore::HTML5DocumentParser::InputStream::InputStream): (WebCore::HTML5DocumentParser::InputStream::appendToEnd): (WebCore::HTML5DocumentParser::InputStream::insertAtCurrentInsertionPoint): (WebCore::HTML5DocumentParser::InputStream::close): (WebCore::HTML5DocumentParser::InputStream::current): (WebCore::HTML5DocumentParser::InputStream::splitInto): (WebCore::HTML5DocumentParser::InputStream::mergeFrom): (WebCore::HTML5DocumentParser::InsertionPointRecord::InsertionPointRecord): (WebCore::HTML5DocumentParser::InsertionPointRecord::~InsertionPointRecord): (WebCore::HTML5DocumentParser::inWrite):
  • html/HTML5Lexer.h: (WebCore::HTML5Lexer::columnNumber):
  • html/HTML5Tokenizer.cpp: Removed.
  • html/HTML5Tokenizer.h: Removed.
  • html/HTML5TreeBuilder.cpp:
  • html/HTMLDocument.cpp: (WebCore::HTMLDocument::createTokenizer):
  • html/HTMLDocumentParser.cpp: Added. (WebCore::): (WebCore::fixUpChar): (WebCore::tagMatch): (WebCore::Token::addAttribute): (WebCore::HTMLDocumentParser::HTMLDocumentParser): (WebCore::HTMLDocumentParser::reset): (WebCore::HTMLDocumentParser::begin): (WebCore::HTMLDocumentParser::setForceSynchronous): (WebCore::HTMLDocumentParser::processListing): (WebCore::HTMLDocumentParser::parseNonHTMLText): (WebCore::HTMLDocumentParser::scriptHandler): (WebCore::HTMLDocumentParser::scriptExecution): (WebCore::HTMLDocumentParser::parseComment): (WebCore::HTMLDocumentParser::parseServer): (WebCore::HTMLDocumentParser::parseProcessingInstruction): (WebCore::HTMLDocumentParser::parseText): (WebCore::HTMLDocumentParser::parseEntity): (WebCore::HTMLDocumentParser::parseDoctype): (WebCore::HTMLDocumentParser::parseTag): (WebCore::HTMLDocumentParser::continueProcessing): (WebCore::HTMLDocumentParser::advance): (WebCore::HTMLDocumentParser::willWriteHTML): (WebCore::HTMLDocumentParser::didWriteHTML): (WebCore::HTMLDocumentParser::write): (WebCore::HTMLDocumentParser::stopParsing): (WebCore::HTMLDocumentParser::processingData): (WebCore::HTMLDocumentParser::timerFired): (WebCore::HTMLDocumentParser::end): (WebCore::HTMLDocumentParser::finish): (WebCore::HTMLDocumentParser::processToken): (WebCore::HTMLDocumentParser::processDoctypeToken): (WebCore::HTMLDocumentParser::~HTMLDocumentParser): (WebCore::HTMLDocumentParser::enlargeBuffer): (WebCore::HTMLDocumentParser::enlargeScriptBuffer): (WebCore::HTMLDocumentParser::executeScriptsWaitingForStylesheets): (WebCore::HTMLDocumentParser::notifyFinished): (WebCore::HTMLDocumentParser::executeExternalScriptsIfReady): (WebCore::HTMLDocumentParser::executeExternalScriptsTimerFired): (WebCore::HTMLDocumentParser::continueExecutingExternalScripts): (WebCore::HTMLDocumentParser::isWaitingForScripts): (WebCore::HTMLDocumentParser::setSrc): (WebCore::parseHTMLDocumentFragment): (WebCore::decodeNamedEntity):
  • html/HTMLDocumentParser.h: Added. (WebCore::Token::Token): (WebCore::Token::~Token): (WebCore::Token::isOpenTag): (WebCore::Token::isCloseTag): (WebCore::Token::reset): (WebCore::Token::addViewSourceChar): (WebCore::): (WebCore::DoctypeToken::DoctypeToken): (WebCore::DoctypeToken::reset): (WebCore::DoctypeToken::state): (WebCore::DoctypeToken::setState): (WebCore::HTMLDocumentParser::forceSynchronous): (WebCore::HTMLDocumentParser::executingScript): (WebCore::HTMLDocumentParser::lineNumber): (WebCore::HTMLDocumentParser::columnNumber): (WebCore::HTMLDocumentParser::processingContentWrittenByScript): (WebCore::HTMLDocumentParser::htmlParser): (WebCore::HTMLDocumentParser::asHTMLTokenizer): (WebCore::HTMLDocumentParser::checkBuffer): (WebCore::HTMLDocumentParser::checkScriptBuffer): (WebCore::HTMLDocumentParser::): (WebCore::HTMLDocumentParser::State::State): (WebCore::HTMLDocumentParser::State::tagState): (WebCore::HTMLDocumentParser::State::setTagState): (WebCore::HTMLDocumentParser::State::entityState): (WebCore::HTMLDocumentParser::State::setEntityState): (WebCore::HTMLDocumentParser::State::inScript): (WebCore::HTMLDocumentParser::State::setInScript): (WebCore::HTMLDocumentParser::State::inStyle): (WebCore::HTMLDocumentParser::State::setInStyle): (WebCore::HTMLDocumentParser::State::inXmp): (WebCore::HTMLDocumentParser::State::setInXmp): (WebCore::HTMLDocumentParser::State::inTitle): (WebCore::HTMLDocumentParser::State::setInTitle): (WebCore::HTMLDocumentParser::State::inIFrame): (WebCore::HTMLDocumentParser::State::setInIFrame): (WebCore::HTMLDocumentParser::State::inPlainText): (WebCore::HTMLDocumentParser::State::setInPlainText): (WebCore::HTMLDocumentParser::State::inProcessingInstruction): (WebCore::HTMLDocumentParser::State::setInProcessingInstruction): (WebCore::HTMLDocumentParser::State::inComment): (WebCore::HTMLDocumentParser::State::setInComment): (WebCore::HTMLDocumentParser::State::inDoctype): (WebCore::HTMLDocumentParser::State::setInDoctype): (WebCore::HTMLDocumentParser::State::inTextArea): (WebCore::HTMLDocumentParser::State::setInTextArea): (WebCore::HTMLDocumentParser::State::escaped): (WebCore::HTMLDocumentParser::State::setEscaped): (WebCore::HTMLDocumentParser::State::inServer): (WebCore::HTMLDocumentParser::State::setInServer): (WebCore::HTMLDocumentParser::State::skipLF): (WebCore::HTMLDocumentParser::State::setSkipLF): (WebCore::HTMLDocumentParser::State::startTag): (WebCore::HTMLDocumentParser::State::setStartTag): (WebCore::HTMLDocumentParser::State::discardLF): (WebCore::HTMLDocumentParser::State::setDiscardLF): (WebCore::HTMLDocumentParser::State::allowYield): (WebCore::HTMLDocumentParser::State::setAllowYield): (WebCore::HTMLDocumentParser::State::loadingExtScript): (WebCore::HTMLDocumentParser::State::setLoadingExtScript): (WebCore::HTMLDocumentParser::State::forceSynchronous): (WebCore::HTMLDocumentParser::State::setForceSynchronous): (WebCore::HTMLDocumentParser::State::inAnyNonHTMLText): (WebCore::HTMLDocumentParser::State::hasTagState): (WebCore::HTMLDocumentParser::State::hasEntityState): (WebCore::HTMLDocumentParser::State::needsSpecialWriteHandling): (WebCore::HTMLDocumentParser::State::): (WebCore::HTMLDocumentParser::State::setBit): (WebCore::HTMLDocumentParser::State::testBit):
  • html/HTMLElement.cpp:
  • html/HTMLFormControlElement.cpp:
  • html/HTMLParser.cpp: (WebCore::HTMLParser::reportErrorToConsole):
  • html/HTMLParser.h:
  • html/HTMLTokenizer.cpp: Removed.
  • html/HTMLTokenizer.h: Removed.
  • html/HTMLViewSourceDocument.cpp: (WebCore::HTMLViewSourceDocument::createTokenizer): (WebCore::HTMLViewSourceDocument::addViewSourceToken):
  • html/HTMLViewSourceDocument.h:
  • loader/DocumentLoader.cpp:
  • loader/FTPDirectoryDocument.cpp: (WebCore::FTPDirectoryTokenizer::FTPDirectoryTokenizer): (WebCore::FTPDirectoryTokenizer::loadDocumentTemplate): (WebCore::FTPDirectoryTokenizer::finish):
  • loader/FrameLoader.cpp:
  • loader/ImageDocument.cpp:
  • loader/MediaDocument.cpp:
  • loader/PluginDocument.cpp:
  • loader/TextDocument.cpp:
  • page/XSSAuditor.h:
  • svg/SVGDocumentExtensions.cpp:
  • wml/WMLErrorHandling.cpp: (WebCore::reportWMLError):
  • xml/XSLStyleSheetLibxslt.cpp: (WebCore::XSLStyleSheet::parseString):
  • xml/XSLTProcessor.cpp:
  • xml/XSLTProcessorLibxslt.cpp:

2010-06-11 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Rename the rest of the *Tokenizer classes to *DocumentParser
​https://bugs.webkit.org/show_bug.cgi?id=40507

  • src/WebEntities.cpp:
    • Fix a comment to match new class names.
7:09 PM Changeset in webkit [61072] by eric@webkit.org
  • 2 edits in trunk/WebKit/chromium

2010-06-12 Evan Stade <​estade@chromium.org>

Reviewed by Eric Seidel.

[chromium] Menu key should act on current selection even if it is not editable
​https://bugs.webkit.org/show_bug.cgi?id=40348

Allow the menu key to act on non-editable selections.

  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::sendContextMenuEvent):
6:03 PM Changeset in webkit [61071] by eric@webkit.org
  • 23 edits in trunk

2010-06-12 Andreas Kling <​andreas.kling@nokia.com>

Reviewed by Darin Adler.

Window object should have CanvasGradient and CanvasPattern
​https://bugs.webkit.org/show_bug.cgi?id=40394

Unskipped 2 tests that are now working properly.

  • canvas/philip/tests/2d.gradient.object.return-expected.txt:
  • canvas/philip/tests/2d.pattern.basic.type-expected.txt:
  • fast/dom/Window/window-properties-expected.txt:
  • fast/dom/Window/window-property-descriptors-expected.txt:
  • fast/dom/dom-constructors-expected.txt:
  • fast/dom/prototype-inheritance-2-expected.txt:
  • fast/dom/prototype-inheritance-expected.txt:
  • fast/js/global-constructors-expected.txt:
  • platform/gtk/fast/dom/Window/window-properties-expected.txt:
  • platform/gtk/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/gtk/fast/dom/prototype-inheritance-expected.txt:
  • platform/gtk/fast/js/global-constructors-expected.txt:
  • platform/mac/Skipped:
  • platform/qt/Skipped:
  • platform/qt/fast/dom/Window/window-properties-expected.txt:
  • platform/qt/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/qt/fast/dom/prototype-inheritance-expected.txt:
  • platform/qt/fast/js/global-constructors-expected.txt:

2010-06-12 Andreas Kling <​andreas.kling@nokia.com>

Reviewed by Darin Adler.

Window object should have CanvasGradient and CanvasPattern
​https://bugs.webkit.org/show_bug.cgi?id=40394

This fixes the following tests:

  • canvas/philip/tests/2d.gradient.object.return.html
  • canvas/philip/tests/2d.pattern.basic.type.html
  • html/canvas/CanvasGradient.idl:
  • html/canvas/CanvasPattern.idl:
  • page/DOMWindow.idl:
4:35 PM Changeset in webkit [61070] by mitz@apple.com
  • 3 edits
    2 adds in trunk

<rdar://problem/8025267> REGRESSION (Safari 4-TOT): Crash when a frame’s resize handler removes the frame
​https://bugs.webkit.org/show_bug.cgi?id=40534

Reviewed by Oliver Hunt.

WebCore:

Test: fast/replaced/frame-removed-during-resize.html

  • rendering/RenderWidget.cpp:

(WebCore::RenderWidget::updateWidgetPosition): Null-check m_widget, since resizing the widget
may trigger an iframe’s resize handler, which may destroy the widget.

LayoutTests:

  • fast/replaced/frame-removed-during-resize-expected.txt: Added.
  • fast/replaced/frame-removed-during-resize.html: Added.
3:34 PM Changeset in webkit [61069] by dimich@chromium.org
  • 2 edits in trunk/LayoutTests

Not reviewed, update for Chromium test expectations.

  • platform/chromium/test_expectations.txt:
3:16 PM Changeset in webkit [61068] by Simon Fraser
  • 5 edits
    4 adds in trunk

2010-06-12 Dean Jackson <​dino@apple.com>

Reviewed by Darin Adler.

Animation keyframe timing functions are applying incorrectly
​https://bugs.webkit.org/show_bug.cgi?id=38963

When copying RenderStyles, we have to clone the AnimationList so that each keyframe
can have its own timing function.

Tests: animations/keyframe-timing-functions-transform.html

animations/keyframe-timing-functions2.html

  • platform/animation/Animation.h: (WebCore::Animation::create):
  • platform/animation/AnimationList.cpp: (WebCore::AnimationList::AnimationList):
  • platform/animation/AnimationList.h: (WebCore::AnimationList::AnimationList):
2:08 PM Changeset in webkit [61067] by bweinstein@apple.com
  • 2 edits
    1 delete in branches/safari-533-branch/WebCore

Roll out r61066, it was meant to be made on the trunk, not the branch.

2:00 PM Changeset in webkit [61066] by bweinstein@apple.com
  • 2 edits
    1 add in branches/safari-533-branch/WebCore

Some machines have started to see the return of the dreaded: WebCore.lib : fatal error LNK1106:
invalid file or disk full. Since we don't have the hotfix for VS2005, work around this in the meantime
by creating an EditingAllInOne file, that includes all of the cpp files in the editing subdirectory.

Rubber-stamped by Darin Adler.

  • WebCore.vcproj/WebCore.vcproj: Prevnt the editing cpp from building, so we only compile EditingAllInOne.
  • editing/EditingAllInOne.cpp: Added. Includes all of the editing cpp files.
1:05 PM Changeset in webkit [61065] by mitz@apple.com
  • 3 edits
    2 adds in trunk

<rdar://problem/7882140> -webkit-column-break-* properties don’t do anything
​https://bugs.webkit.org/show_bug.cgi?id=40531

Reviewed by Dave Hyatt.

WebCore:

Test: fast/multicol/break-properties.html

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::paintChildren): Check for -webkit-column-break-{before,after}: always
and -webkit-column-break-inside: avoid when doing column layout.

LayoutTests:

  • fast/multicol/break-properties-expected.txt: Added.
  • fast/multicol/break-properties.html: Added.
11:06 AM ApplicationsGtk edited by patternjake@hotmail.com
(diff)
11:05 AM Applications using WebKit edited by patternjake@hotmail.com
(diff)
11:05 AM Changeset in webkit [61064] by eric@webkit.org
  • 3 edits in trunk/WebKit/qt

2010-06-12 Dawit Alemayehu <​adawit@kde.org>

Reviewed by Kenneth Rohde Christiansen.

Added an attribute to enable/disable site specific quirks mode in WebKit.
The attribute is enabled by default.

​https://bugs.webkit.org/show_bug.cgi?id=40073

  • Api/qwebsettings.cpp: (QWebSettingsPrivate::apply): (QWebSettings::QWebSettings):
  • Api/qwebsettings.h:
9:45 AM Changeset in webkit [61063] by robert@webkit.org
  • 2 edits in trunk/WebKit/qt

2010-06-12 Robert Hogan <​robert@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Fix tst_qwebframe regression from ​http://trac.webkit.org/changeset/61062

Only use cacheableBindingRootObject() if the object has QtOwnership.

​https://bugs.webkit.org/show_bug.cgi?id=40527

  • Api/qwebframe.cpp: (QWebFrame::addToJavaScriptWindowObject):
6:41 AM Changeset in webkit [61062] by robert@webkit.org
  • 7 edits in trunk

2010-06-13 Robert Hogan <​robert@webkit.org>

Reviewed by Alexey Proskuryakov.

FrameLoader::clear() clears JS objects that cached pages later rely on

​https://bugs.webkit.org/show_bug.cgi?id=37725
​https://bugs.webkit.org/show_bug.cgi?id=31626

Fix the following tests for Qt:

fast/events/pageshow-pagehide-on-back-cached.html
fast/events/pageshow-pagehide-on-back-cached-with-frames.html
fast/loader/input-element-page-cache-crash.html
fast/dom/Window/timer-resume-on-navigation-back.html
loader/go-back-to-different-window-size.html
fast/dom/javascript-url-crash-function.html
fast/dom/location-new-window-no-crash.html
http/tests/security/javascriptURL/xss-ALLOWED-from-javascript-url-window-open.html

which currently fail because the page's Qt-bindings runtime objects are
cleared when navigating away from the page containing them.

Track Qt-bindings objects in a separate ScriptController::cacheableRootBindingObject().
RuntimeObjects tracked by this root object will not get invalidated on page navigations,
so they will still be available when the pages containing them are retrieved from the
b/f cache.

This means the Qt bindings objects will only get cleared on Frame::pageDestroyed().

  • Api/qwebframe.cpp: (QWebFrame::addToJavaScriptWindowObject):
  • bindings/js/ScriptController.cpp: (WebCore::ScriptController::~ScriptController): (WebCore::ScriptController::cacheableBindingRootObject):
  • bindings/js/ScriptController.h:
  • platform/qt/Skipped:
5:44 AM Changeset in webkit [61061] by tkent@chromium.org
  • 4 edits in trunk/WebKitTools

2010-06-12 Kent Tamura <​tkent@chromium.org>

Reviewed by Dimitri Glazkov.

[Chromium] new-run-webkit-tests --use-drt should work with Chromium checkout
​https://bugs.webkit.org/show_bug.cgi?id=40402

_build_path() of each Chromium port check existence of build path
of Chromium checkout first, then check existence of build path of
WebKit-only checkout.

  • Scripts/webkitpy/layout_tests/port/chromium_linux.py:
  • Scripts/webkitpy/layout_tests/port/chromium_mac.py:
  • Scripts/webkitpy/layout_tests/port/chromium_win.py:
4:33 AM Changeset in webkit [61060] by tkent@chromium.org
  • 5 edits
    2 adds in trunk

REGRESSION: Can't submit a form with <input type=radio required>
​https://bugs.webkit.org/show_bug.cgi?id=40429

Reviewed by Darin Adler.

WebCore:

Validity state was not updated correctly for radio buttons, and it
prevents form submission even if a radio button group has a
checked radio button.

Test: fast/forms/interactive-validation-required-radio.html

  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::updateCheckedRadioButtons):

Call setNeedsValidityCheck() for all of radio buttons in the same group
to update validity state.

(WebCore::HTMLInputElement::setChecked):

Remove setNeedsValidityCheck() call because it is called in
updateCheckedRadioButtons().

LayoutTests:

  • fast/forms/ValidityState-valueMissing-radio-expected.txt:
  • fast/forms/interactive-validation-required-radio-expected.txt: Added.
  • fast/forms/interactive-validation-required-radio.html: Added.
  • fast/forms/script-tests/ValidityState-valueMissing-radio.js: We need to test against a radio group with at least three radio buttons because we should test behaviors of
    • checked
    • unchecked
    • neither checked nor unchecked
4:19 AM Changeset in webkit [61059] by tkent@chromium.org
  • 3 edits
    4 adds in trunk

Disable interactive form validation in non-strict modes
​https://bugs.webkit.org/show_bug.cgi?id=40218

Reviewed by Dimitri Glazkov.

WebCore:

The interactive validation feature of HTML5 is not compatible with
HTML4, and users and page authors don't expect existing sites work
differently in WebKit. For example, maxlength and required attributes
in existing sites unexpectedly prevented form submission.
So, we disable the interactive validation feature in non-strict
modes to improve compatibility.

Test: fast/forms/interactive-validation-compat-mode.html

fast/forms/interactive-validation-html4.html

  • html/HTMLFormElement.cpp:

(WebCore::HTMLFormElement::validateInteractively):

Process interactive validation only in the strict mode.

LayoutTests:

  • fast/forms/interactive-validation-compat-mode-expected.txt: Added.
  • fast/forms/interactive-validation-compat-mode.html: Added.
  • fast/forms/interactive-validation-html4-expected.txt: Added.
  • fast/forms/interactive-validation-html4.html: Added.
1:21 AM Changeset in webkit [61058] by eric@webkit.org
  • 3 edits in trunk/WebKit/qt

2010-06-12 No'am Rosenthal <​noam.rosenthal@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Add documentation to the QtWebkit bridge
​https://bugs.webkit.org/show_bug.cgi?id=35861

The previous accepted patch was actually a faulty one; It was hard to trace since it's just a documentation
change. The new patch amends that, with the correct snippets and grammar fixes.

  • docs/qtwebkit-bridge.qdoc:
  • docs/webkitsnippets/qtwebkit_bridge_snippets.cpp: (wrapInFunction):
1:10 AM Changeset in webkit [61057] by eric@webkit.org
  • 37 edits
    1 move in trunk/WebCore

2010-06-12 Eric Seidel <​eric@webkit.org>

Reviewed by David Levin.

Rename Tokenizer to DocumentParser to match what it actually does
​https://bugs.webkit.org/show_bug.cgi?id=40504

The rename was entirely done by do-webcore-rename.
The only manual changes were removing out-dated comments
and fixing Tokenizer_h to DocumentParser_h in the header guards.

I'll do all the rest of the renames (like the tokenizer subclasses
and the tokenizer() createTokenizer() methods) in separate changes.

No functional change, thus no tests.

  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSHTMLDocumentCustom.cpp:
  • bindings/v8/ScriptEventListener.cpp:
  • dom/Document.cpp: (WebCore::Document::createTokenizer):
  • dom/Document.h: (WebCore::Document::tokenizer):
  • dom/DocumentParser.h: Added. (WebCore::DocumentParser::~DocumentParser): (WebCore::DocumentParser::stopParsing): (WebCore::DocumentParser::processingData): (WebCore::DocumentParser::executingScript): (WebCore::DocumentParser::wantsRawData): (WebCore::DocumentParser::writeRawData): (WebCore::DocumentParser::inViewSourceMode): (WebCore::DocumentParser::setInViewSourceMode): (WebCore::DocumentParser::wellFormed): (WebCore::DocumentParser::lineNumber): (WebCore::DocumentParser::columnNumber): (WebCore::DocumentParser::executeScriptsWaitingForStylesheets): (WebCore::DocumentParser::htmlParser): (WebCore::DocumentParser::asHTMLTokenizer): (WebCore::DocumentParser::xssAuditor): (WebCore::DocumentParser::setXSSAuditor): (WebCore::DocumentParser::DocumentParser):
  • dom/Tokenizer.h: Removed.
  • dom/ViewportArguments.cpp: (WebCore::reportViewportWarning):
  • dom/XMLTokenizer.h:
  • dom/XMLTokenizerLibxml2.cpp: (WebCore::XMLTokenizer::stopParsing):
  • dom/XMLTokenizerQt.cpp: (WebCore::XMLTokenizer::stopParsing):
  • html/HTML5Tokenizer.cpp: (WebCore::HTML5Tokenizer::HTML5Tokenizer):
  • html/HTML5Tokenizer.h:
  • html/HTMLDocument.cpp: (WebCore::HTMLDocument::createTokenizer):
  • html/HTMLDocument.h:
  • html/HTMLFormControlElement.cpp: (WebCore::HTMLFormControlElement::removedFromTree):
  • html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::HTMLTokenizer): (WebCore::HTMLTokenizer::stopParsing):
  • html/HTMLTokenizer.h:
  • html/HTMLViewSourceDocument.cpp: (WebCore::HTMLViewSourceDocument::createTokenizer):
  • html/HTMLViewSourceDocument.h:
  • loader/DocumentLoader.cpp: (WebCore::DocumentLoader::isLoadingInAPISense):
  • loader/DocumentWriter.cpp: (WebCore::DocumentWriter::addData):
  • loader/FTPDirectoryDocument.cpp: (WebCore::FTPDirectoryDocument::createTokenizer):
  • loader/FTPDirectoryDocument.h:
  • loader/ImageDocument.cpp: (WebCore::ImageDocument::createTokenizer):
  • loader/ImageDocument.h:
  • loader/MediaDocument.cpp: (WebCore::MediaDocument::createTokenizer):
  • loader/MediaDocument.h:
  • loader/PluginDocument.cpp: (WebCore::PluginDocument::createTokenizer):
  • loader/PluginDocument.h:
  • loader/SinkDocument.cpp: (WebCore::SinkDocument::createTokenizer):
  • loader/SinkDocument.h:
  • loader/TextDocument.cpp: (WebCore::TextTokenizer::TextTokenizer): (WebCore::TextDocument::createTokenizer): (WebCore::createTextTokenizer):
  • loader/TextDocument.h:
  • wml/WMLDocument.cpp: (WebCore::WMLDocument::finishedParsing):
12:36 AM Changeset in webkit [61056] by eric@webkit.org
  • 10 edits in trunk

2010-06-12 Robert Hogan <​robert@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Back-forward list dumping is incorrect

​https://bugs.webkit.org/show_bug.cgi?id=36392

Support dumping child history items in DRT.

Unskip:

fast/loader/frame-src-change-added-to-history.html
fast/loader/frame-src-change-not-added-to-history.html
fast/loader/frame-location-change-not-added-to-history.html

  • platform/qt/Skipped:

2010-06-12 Robert Hogan <​robert@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Back-forward list dumping is incorrect

​https://bugs.webkit.org/show_bug.cgi?id=36392

Support dumping child history items in DRT.

Unskip:

fast/loader/frame-src-change-added-to-history.html
fast/loader/frame-src-change-not-added-to-history.html
fast/loader/frame-location-change-not-added-to-history.html

  • Api/qwebhistory.cpp: (QWebHistoryItemPrivate::core):
  • Api/qwebhistory.h:
  • Api/qwebhistory_p.h:
  • WebCoreSupport/DumpRenderTreeSupportQt.cpp: (DumpRenderTreeSupportQt::isTargetItem): (DumpRenderTreeSupportQt::historyItemTarget): (DumpRenderTreeSupportQt::getChildHistoryItems):
  • WebCoreSupport/DumpRenderTreeSupportQt.h:

2010-06-12 Robert Hogan <​robert@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Back-forward list dumping is incorrect

​https://bugs.webkit.org/show_bug.cgi?id=36392

Support dumping child history items in DRT.

Unskip:

fast/loader/frame-src-change-added-to-history.html
fast/loader/frame-src-change-not-added-to-history.html
fast/loader/frame-location-change-not-added-to-history.html

  • DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::dumpHistoryItem):
12:23 AM Changeset in webkit [61055] by eric@webkit.org
  • 4 edits in trunk/WebCore

2010-06-12 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

HTML5Tokenizer needs to tell the InspectorTimelineAgent before and after it writes
​https://bugs.webkit.org/show_bug.cgi?id=40417

This "fixes" inspector/timeline-script-tag-1.html. HTML5 results
differ from the old parser for expected reasons.

HTML5Tokenizer calls InspectorTimelineAgent::will/didWriteHTML every
time we pump the lexer instead of every write() call.
We end up pumping the lexer slightly more often than the old code called
write() in order to cleanly handle unclosed-entities, unclosed tags,
buffered characters, etc. at the end of a document.

I discussed this extensively with James Robinson in #webkit and we decided
that it was better for the HTML5Tokenizer to call for every pump and
that the Inspector should later filter out empty pumps.

We can't filter out empty pumps yet, because the number of parsed
characters is passed in willWrite instead of didWrite and thus is
speculative (and wrong). This is a problem independent of this change
as willWrite's "length" argument is wrong in different ways for the old
parser, including always being 0 when the old parser resumes.

Tested by inspector/timeline-script-tag-1.html

  • html/HTML5Tokenizer.cpp: (WebCore::HTML5Tokenizer::willPumpLexer):
    • Notify the InspectorTimelineAgent we're about to process input.

(WebCore::HTML5Tokenizer::didPumpLexer):

  • Notify the InspectorTimelineAgent we did process tokens.

(WebCore::HTML5Tokenizer::pumpLexer):

  • Call willPump and didPump
  • html/HTML5Tokenizer.h:
  • inspector/InspectorTimelineAgent.h:
    • Add a FIXME about passing length to didWrite instead of willWrite.
12:09 AM Changeset in webkit [61054] by eric@webkit.org
  • 3 edits in trunk/LayoutTests

2010-06-11 Eric Seidel <​eric@webkit.org>

Unreviewed. Just updating expectations.

tables/mozilla/bugs/bug1188.html needlessly depends on HTML Parser text node handling
​https://bugs.webkit.org/show_bug.cgi?id=40485

The current HTML5 parser is expected to fail the new webkit01 test.
It will be fixed when we fix text-node coalescing as discussed in
the previous commit.

  • html5lib/runner-expected-html5.txt:
  • html5lib/webkit-resumer-expected-html5.txt:
Note: See TracTimeline for information about the timeline view.