Context Navigation

Allow MIMETypeRegistry to have more than one MIME type for a
media file extension, and have the QTKit media engine register
all MIME types it can find for each file type QTKit supports.

Test: media/media-can-play-mp3.html

platform/MIMETypeRegistry.cpp: (WebCore::mediaMIMETypeMap): Update for new HashMap format. (WebCore::TypeExtensionPair::): Store String+Vector<String> (WebCore::MIMETypeRegistry::getMediaMIMETypeForExtension): Only consult mediaMIMETypeMap(), it has the canonical answer. (WebCore::MIMETypeRegistry::getMediaMIMETypesForExtension): New, return a Vector of all MIME types for an extension.
platform/MIMETypeRegistry.h:
platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::addFileTypesToCache): Add all MIME types returned in the getMediaMIMETypesForExtension Vector.

2010-06-14 Eric Carlson <eric.carlson@apple.com>

Reviewed by Oliver Hunt.

audio/x-mp3 MIME type not recognized
https://bugs.webkit.org/show_bug.cgi?id=40594

media/media-can-play-mp3-expected.txt: Added.
media/media-can-play-mp3.html: Added.

6:50 PM Changeset in webkit [61171] by mrowe@apple.com

2 edits in trunk/WebCore

<rdar://problem/8071866> REGRESSION: Crash on launch on Tiger and Leopard with network home folder

Reviewed by Brady Eidson.

platform/sql/SQLiteStatement.cpp:

(WebCore::SQLiteStatement::prepare): Don't assume that tail is always non-null, since that may
not be the case with some versions of SQLite. Instead we must null-check before dereferencing.

6:41 PM Changeset in webkit [61170] by andersca@apple.com

2 edits in trunk/WebKit/chromium

Fix Chromium build.

src/WebPluginListBuilderImpl.cpp:

(WebKit::WebPluginListBuilderImpl::addFileExtensionToLastMediaType):

6:37 PM Changeset in webkit [61169] by andersca@apple.com

2 edits in trunk/WebCore

Fix Tiger build.

plugins/mac/PluginDataMac.mm:

6:30 PM Changeset in webkit [61168] by andersca@apple.com

10 edits in trunk/WebCore

2010-06-14 Anders Carlsson <andersca@apple.com>

Reviewed by Darin Adler.

Use an array for extensions in MimeClassInfo
https://bugs.webkit.org/show_bug.cgi?id=40602

Get rid of MimeClassInfo::suffixes and replace it with an array of extensions.

plugins/MimeType.cpp: (WebCore::MimeType::suffixes): Create a string of joined extensions.

plugins/MimeType.h:
plugins/PluginData.h: (WebCore::operator==):
plugins/chromium/PluginDataChromium.cpp: (WebCore::getPluginMimeTypeFromExtension):
plugins/gtk/PluginDataGtk.cpp: (WebCore::PluginData::initPlugins):
plugins/mac/PluginDataMac.mm: (WebCore::PluginData::initPlugins):
plugins/qt/PluginDataQt.cpp: (WebCore::PluginData::initPlugins):
plugins/win/PluginDataWin.cpp: (WebCore::PluginData::initPlugins):
plugins/wx/PluginDataWx.cpp: (WebCore::PluginData::initPlugins):

5:52 PM Changeset in webkit [61167] by abarth@webkit.org

2 edits in trunk/WebCore

2010-06-14 Adam Barth <abarth@webkit.org>

Unreviewed.

Add an include to try to fix Chromium build.

html/HTML5DocumentParser.cpp:

5:35 PM Changeset in webkit [61166] by sfalken@apple.com

2 edits in trunk/WebKit2

Windows build fix.
Reorder build event to fix cygwin path issue.

win/WebKit2Generated.vcproj:

5:25 PM Changeset in webkit [61165] by abarth@webkit.org

5 edits in trunk/WebCore

2010-06-14 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Safari beach-balls loading large pages with HTML5 parser
https://bugs.webkit.org/show_bug.cgi?id=40596

Implement parser yielding, similar to how the old
HTMLDocumentParser yields.

This implementation re-uses the tokenizerTimeDelay and
tokenizerChunkSize settings even though they don't map exactly
to the token loop that the HTML5 parser uses.

dom/DocumentParser.h:
- Add a FIXME for processingData() and clarify how the appendData flag is used by renaming it to isFromNetwork.
html/HTML5DocumentParser.cpp: (WebCore::parserTimeLimit):
- Defaults accessor, probably belongs on Page.

(WebCore::parserChunkSize):

Defaults accessor, probably belongs on Page.

(WebCore::HTML5DocumentParser::HTML5DocumentParser):
(WebCore::HTML5DocumentParser::stopParsing):

Stop the continue-parsing timer if active.

(WebCore::HTML5DocumentParser::processingData):

Implement this poorly understood accessor to match the old parser's behavior. It's unclear what this does and it does not affect any layout tests to my knowledge but likely affects the WebKit API in some way.

(WebCore::HTML5DocumentParser::pumpLexerIfPossible):

Pass SynchronousMode.
Do not ever pump if we've yielded to the timer.

(WebCore::HTML5DocumentParser::PumpSession::PumpSession):

A struct for storing the yield counters.

(WebCore::HTML5DocumentParser::shouldContinueParsing):

Mostly matches HTMLDocumentParser::shouldContinueParsing.

(WebCore::HTML5DocumentParser::pumpLexer):

Respect SynchronousMode.
ASSERT that a timer is not scheduled if we're pumping.

(WebCore::isLayoutTimerActive):

This belongs on Document.

(WebCore::HTML5DocumentParser::continueNextChunkTimerFired):
(WebCore::HTML5DocumentParser::write):
(WebCore::HTML5DocumentParser::end):

We should never end() if a timer is still outstanding.

(WebCore::HTML5DocumentParser::attemptToEnd):
(WebCore::HTML5DocumentParser::endIfDelayed):
(WebCore::HTML5DocumentParser::resumeParsingAfterScriptExecution):

html/HTML5DocumentParser.h: (WebCore::HTML5DocumentParser::):
html/HTMLDocumentParser.cpp:
- Clarify the old TimeDelay and ChunkSize constants.

5:20 PM Changeset in webkit [61164] by sfalken@apple.com

2 edits in trunk/WebKit2

Windows build fix.
Add build failure stopping code.

win/WebKit2WebProcess.vcproj:

5:07 PM Changeset in webkit [61163] by abarth@webkit.org

10 edits
2 adds in trunk/WebCore

2010-06-14 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Add a preload scanner for the HTML5 parser
https://bugs.webkit.org/show_bug.cgi?id=40557

This patch adds a simple preload scanner for the HTML5 parser. This
preload scanner is not as awesome as the old one because it doesn't
scan CSS, but it's much simpler.

Android.mk:
CMakeLists.txt:
GNUmakefile.am:
WebCore.gypi:
WebCore.pro:
WebCore.vcproj/WebCore.vcproj:
WebCore.xcodeproj/project.pbxproj:
- Build file torture.
html/HTML5DocumentParser.cpp: (WebCore::HTML5DocumentParser::write):
- Call into the preload scanner when waiting for a script.
html/HTML5DocumentParser.h:
html/HTML5PreloadScanner.cpp: Copied from WebCore/html/PreloadScanner.cpp. (WebCore::HTML5PreloadScanner::HTML5PreloadScanner): (WebCore::HTML5PreloadScanner::scan):
- A simple loop to pump the preload scanner's lexer.

(WebCore::HTML5PreloadScanner::processToken):

Preload interesting resources. Stolen from the old preload scanner.

(WebCore::HTML5PreloadScanner::scanningBody):

html/HTML5PreloadScanner.h: Copied from WebCore/html/PreloadScanner.h.

5:00 PM Changeset in webkit [61162] by tony@chromium.org

4 edits in trunk

2010-06-14 Tony Chang <tony@chromium.org>

Reviewed by Darin Fisher.

Chromium shouldn't build inside the source directory
https://bugs.webkit.org/show_bug.cgi?id=40489

Ignore directories fetched by chromium and chromium mac output dir.

chromium: Added property svn:ignore.

2010-06-13 Tony Chang <tony@chromium.org>

Reviewed by Darin Fisher.

Chromium shouldn't build inside the source directory
https://bugs.webkit.org/show_bug.cgi?id=40489

Ignore Chromium Linux build files.

.: Added property svn:ignore. Modified property svn:ignore.

4:58 PM Changeset in webkit [61161] by abarth@webkit.org

5 edits in trunk/WebCore

2010-06-14 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Constify some HTML5Token methods
https://bugs.webkit.org/show_bug.cgi?id=40592

I keep wanting these methods to be const. Eric wanted this in a
separate patch.

html/HTML5Lexer.h: (WebCore::HTML5Lexer::state):
html/HTML5Token.h: (WebCore::HTML5Token::attributes): (WebCore::HTML5Token::name): (WebCore::HTML5Token::characters): (WebCore::HTML5Token::comment): (WebCore::HTML5Token::publicIdentifier): (WebCore::HTML5Token::systemIdentifier):
html/HTML5TreeBuilder.cpp: (WebCore::convertToOldStyle): (WebCore::HTML5TreeBuilder::adjustedLexerState):
- Technically, this might belong in the other patch, but I think it's fine here.

(WebCore::HTML5TreeBuilder::passTokenToLegacyParser):

html/HTML5TreeBuilder.h:

4:47 PM Changeset in webkit [61160] by sfalken@apple.com

2 edits in trunk/WebKit2

Windows build fix.
Add build failure stopping code.

win/WebKit2Generated.vcproj:

4:11 PM Changeset in webkit [61159] by dimich@chromium.org

2 edits in trunk/LayoutTests

Unreviewed, more Chromium expectations updates.

platform/chromium/test_expectations.txt:

3:31 PM Changeset in webkit [61158] by dumi@chromium.org

2 edits in trunk/WebCore

Unreviewed, build fix.

WebCore.xcodeproj/project.pbxproj:

3:27 PM Changeset in webkit [61157] by ap@apple.com

2 edits in trunk/WebKitTools

Chromium build fix.

DumpRenderTree/chromium/EventSender.cpp: (EventSender::keyDown): Chromium uses differently named constants for Windows virtual key codes, replacing VK_DELETE with VKEY_DELETE.

3:27 PM Changeset in webkit [61156] by Dimitri Glazkov

2 edits in trunk/WebCore

Unreviewed, build fix.

Remove accidental specifying of the class name twice.

html/HTMLFormElement.cpp:

(WebCore::HTMLFormElement::prepareFormData): Removed my ghastly typo.

3:08 PM Changeset in webkit [61155] by adachan@apple.com

3 edits in trunk/WebKit2

Rubber-stamped by Steve Falkenburg.

Fix the release configuration to use release.vsprops.
Add Debug_Internal and Debug_All configurations to the WebKit2WebProcess project.
Fix launchWebProcess() to get the right path to the WebKit2WebProcess executable.

UIProcess/Launcher/win/WebProcessLauncher.cpp: (WebKit::launchWebProcess):
win/WebKit2WebProcess.vcproj:

3:07 PM Changeset in webkit [61154] by dumi@chromium.org

15 edits in trunk

Get DatabaseTracker ready for sync DBs.
https://bugs.webkit.org/show_bug.cgi?id=39041

Reviewed by Adam Barth.

WebCore:

storage/AbstractDatabase.cpp:

(WebCore::AbstractDatabase::~AbstractDatabase):

storage/AbstractDatabase.h:
storage/Database.cpp:

(WebCore::Database::closeImmediately):

storage/Database.h:

(WebCore::Database::scriptExecutionContext):

storage/DatabaseTracker.cpp:

(WebCore::DatabaseTracker::getMaxSizeForDatabase):
(WebCore::DatabaseTracker::databaseChanged):
(WebCore::DatabaseTracker::addOpenDatabase):
(WebCore::DatabaseTracker::removeOpenDatabase):
(WebCore::DatabaseTracker::getOpenDatabases):
(WebCore::DatabaseTracker::deleteDatabaseFile):

storage/DatabaseTracker.h:
storage/OriginQuotaManager.cpp:

(WebCore::OriginQuotaManager::markDatabase):

storage/OriginQuotaManager.h:
storage/chromium/DatabaseObserver.h:
storage/chromium/DatabaseTrackerChromium.cpp:

(WebCore::DatabaseTracker::addOpenDatabase):
(WebCore::TrackerRemoveOpenDatabaseTask::create):
(WebCore::TrackerRemoveOpenDatabaseTask::TrackerRemoveOpenDatabaseTask):
(WebCore::DatabaseTracker::removeOpenDatabase):
(WebCore::DatabaseTracker::getOpenDatabases):
(WebCore::DatabaseTracker::getMaxSizeForDatabase):

WebKit/chromium:

public/WebDatabase.h:
src/DatabaseObserver.cpp:

(WebCore::DatabaseObserver::databaseOpened):
(WebCore::DatabaseObserver::databaseModified):
(WebCore::DatabaseObserver::databaseClosed):

src/WebDatabase.cpp:

(WebKit::WebDatabase::closeDatabaseImmediately):
(WebKit::WebDatabase::WebDatabase):
(WebKit::WebDatabase::operator=):
(WebKit::WebDatabase::operator WTF::PassRefPtr<AbstractDatabase>):

2:58 PM Changeset in webkit [61153] by ap@apple.com

11 edits
2 adds in trunk

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=40529
eventSender.keyDown("delete") incorrectly sends a backspace on some platforms

WebCore:

platform/mac/KeyEventMac.mm: (WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent): Use virtual key code to force correct character code for clarity. Also, reworded comment, since saying that "backspace needs to always be 8" misleadingly implied that it could "sometimes" be such without this code.

WebKitTools:

DumpRenderTree/mac/EventSendingController.mm: (-[EventSendingController keyDown:withModifiers:withLocation:]): We were sending a broken event for "delete" - it had virtual key code from forward delete, and text from backspace. Fixed "delete" to mean forward delete.

DumpRenderTree/chromium/EventSender.cpp: (EventSender::keyDown):
DumpRenderTree/gtk/EventSender.cpp: (keyDownCallback):
DumpRenderTree/win/EventSender.cpp: (keyDownCallback): Mac DRT confusion has propagated to other platforms, fixing those.

LayoutTests:

editing/deleting/forward-delete-key-expected.txt: Added.
editing/deleting/forward-delete-key.html: Added. Added a test for forward delete key working (particularly in DRT, since there was a lot of confusion between platform maintainers about it).

fast/forms/resources/input-live-pseudo-selectors.js:
fast/forms/resources/textarea-live-pseudo-selectors.js: These two tests expected that keyDown("delete") executed backward delete, changed them to send "\x08" for backspace.

2:51 PM Changeset in webkit [61152] by Dimitri Glazkov

3 edits in trunk/WebCore

2010-06-14 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Darin Adler.

Refactor form submission code in HTMLFormElement to add clarity.
https://bugs.webkit.org/show_bug.cgi?id=39430

Covered by existing tests in fast/forms/mailto.

html/HTMLFormElement.cpp: (WebCore::appendMailtoPostFormDataToURL): Renamed from transferMailtoPostFormDataToUrl,

removed clearing out of the FormData and moved it to a new place (next to the call site).

(WebCore::HTMLFormElement::prepareFormData): Renamed from createFormData, moved the logic of

prepareing FormData here, including the use of appendMailtoPostFormDataToURL.

(WebCore::HTMLFormElement::submit): Consolidated multiple invocations of submitForm().

html/HTMLFormElement.h: Renamed createFormData to prepareFormData.

2:48 PM Changeset in webkit [61151] by Chris Fleizach

8 edits in trunk

AX: need ListItemRole and PresentationalRole
https://bugs.webkit.org/show_bug.cgi?id=40133

Reviewed by Darin Adler.

WebCore:

accessibility/AccessibilityObject.cpp:

(WebCore::createARIARoleMap):

accessibility/AccessibilityObject.h:

(WebCore::AccessibilityObject::isListItem):

accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::accessibilityIsIgnored):
(WebCore::AccessibilityRenderObject::determineAccessibilityRole):

accessibility/mac/AccessibilityObjectWrapper.mm:

(-[AccessibilityObjectWrapper accessibilityAttributeNames]):

WebKit/chromium:

public/WebAccessibilityRole.h:
src/AssertMatchingEnums.cpp:

2:45 PM Changeset in webkit [61150] by andersca@apple.com

9 edits in trunk

2010-06-14 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Remove pluginIndex from MimeClassInfo
https://bugs.webkit.org/show_bug.cgi?id=40588

src/WebPluginListBuilderImpl.cpp: (WebKit::WebPluginListBuilderImpl::addMediaTypeToLastPlugin):

2010-06-14 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Remove pluginIndex from MimeClassInfo
https://bugs.webkit.org/show_bug.cgi?id=40588

plugins/PluginData.h:
plugins/gtk/PluginDataGtk.cpp: (WebCore::PluginData::initPlugins):
plugins/mac/PluginDataMac.mm: (WebCore::PluginData::initPlugins):
plugins/qt/PluginDataQt.cpp: (WebCore::PluginData::initPlugins):
plugins/win/PluginDataWin.cpp: (WebCore::PluginData::initPlugins):
plugins/wx/PluginDataWx.cpp: (WebCore::PluginData::initPlugins):

2:41 PM Changeset in webkit [61149] by kinuko@chromium.org

11 edits
2 adds in trunk/WebCore

2010-06-14 Kinuko Yasuda <kinuko@chromium.org>

Reviewed by Jian Li.

Implement BlobBuilder internal class for BlobBuilder support as defined in FileWriter
https://bugs.webkit.org/show_bug.cgi?id=36903

No new tests; they will be added when we add jsc bindings.

CMakeLists.txt:
GNUmakefile.am:
WebCore.gypi:
WebCore.pro:
WebCore.vcproj/WebCore.vcproj:
WebCore.xcodeproj/project.pbxproj:
html/BlobBuilder.cpp: Added.
html/BlobBuilder.h: Added. (WebCore::BlobBuilder::create):
platform/BlobItem.cpp: (WebCore::StringBlobItem::convertToCString): Added EndingNative support.
platform/BlobItem.h: Added EndingNative line-ending type. (WebCore::):

2:37 PM Changeset in webkit [61148] by dimich@chromium.org

2 edits in trunk/LayoutTests

Unreviewed, temporary update Chromium expectations after http://trac.webkit.org/changeset/61128

platform/chromium/test_expectations.txt:

2:13 PM Changeset in webkit [61147] by andersca@apple.com

5 edits in trunk/WebCore

2010-06-14 Anders Carlsson <andersca@apple.com>

Reviewed by Darin Adler.

Stop using MimeClassInfo::pluginIndex
https://bugs.webkit.org/show_bug.cgi?id=40582

Add a pluginIndicies vector to PluginData and use it instead of MimeClassInfo::pluginIndex.

plugins/MimeType.cpp: (WebCore::MimeType::enabledPlugin): Get the plug-in index from the mimePluginIndices vector.

plugins/Plugin.cpp: (WebCore::Plugin::item): Compare the mime plugin index as well.

plugins/PluginData.cpp: (WebCore::PluginData::PluginData): Populate the m_mimePluginIndices vector.

(WebCore::PluginData::pluginNameForMimeType):
Get the plug-in index from the m_mimePluginIndices vector.

plugins/PluginData.h: (WebCore::operator==): Don't check for pluginIndex.

(WebCore::PluginData::mimePluginIndices):
Add getter for m_mimePluginIndices.

2:08 PM Changeset in webkit [61146] by weinig@apple.com

2 edits in trunk/WebCore

Better build fix.

bindings/js/JSBindingsAllInOne.cpp:

2:06 PM Changeset in webkit [61145] by weinig@apple.com

2 edits in trunk/WebCore

Another windows build fix.

bindings/js/JSBindingsAllInOne.cpp:

2:03 PM Changeset in webkit [61144] by Martin Robinson

2 edits in trunk/WebKitTools

2010-06-14 Martin Robinson <mrobinson@igalia.com>

Reviewed by Xan Lopez.

Small GtkLauncher build fix for some systems.

GtkLauncher/main.c: Add <limit.h> include.

1:54 PM Changeset in webkit [61143] by weinig@apple.com

2 edits in trunk/WebCore

Another build fix.

bindings/js/JSDOMWindowCustom.cpp:

1:45 PM Changeset in webkit [61142] by Csaba Osztrogonác

4 edits in trunk/LayoutTests

[Qt] Unreviewed fix. Platform specific expected results updated after r61136.

platform/qt/fast/dom/Window/window-lookup-precedence-expected.txt:
platform/qt/fast/dom/Window/window-properties-expected.txt:
platform/qt/fast/js/global-constructors-expected.txt:

1:09 PM Changeset in webkit [61141] by crogers@google.com

1 edit in branches/audio/WebCore/audio/RealtimeAnalyser.cpp

A little cleanup in realtime analyser code

1:09 PM Changeset in webkit [61140] by crogers@google.com

1 edit in branches/audio/WebCore/audio/Reverb.cpp

Handle edge case of reverb 1 -> 4 -> 2 matrixing

1:09 PM Changeset in webkit [61139] by crogers@google.com

2 edits in branches/audio/WebCore/audio

include config.h in MidSide

1:05 PM Changeset in webkit [61138] by Csaba Osztrogonác

2 edits in trunk/LayoutTests

Unreviewed.

[Qt] fast/text/justify-padding-distribution.html fails
https://bugs.webkit.org/show_bug.cgi?id=40584

platform/qt/Skipped: fast/text/justify-padding-distribution.html skipped until fix.

12:51 PM Changeset in webkit [61137] by weinig@apple.com

2 edits in trunk/WebCore

Add missing comma to fix GTK build.

xml/XSLTProcessor.idl:

12:46 PM Changeset in webkit [61136] by weinig@apple.com

47 edits
4 moves
28 deletes in trunk

Fix for https://bugs.webkit.org/show_bug.cgi?id=40581
Auto-generate most of the JS constructors

Reviewed by Alexey Proskuryakov.

WebCore:

Auto-generates all the JS constructors that don't have custom names (eg, Not Image(), Audio() or Option())
Fixes two typos.

(new XSLTConstructor()).toString() [object XSLTProcessorConsructor] -> [object XSLTProcessorConstructor])
(new EventSource()).toString() [object EventSourceContructor] -> [object EventSourceConstructor])

Android.jscbindings.mk:
CMakeLists.txt:
GNUmakefile.am:
WebCore.gypi:
WebCore.pro:
WebCore.vcproj/WebCore.vcproj:
WebCore.xcodeproj/project.pbxproj:
bindings/js/JSArrayBufferConstructor.cpp: Removed.
bindings/js/JSArrayBufferConstructor.h: Removed.
bindings/js/JSArrayBufferCustom.cpp: Copied from WebCore/bindings/js/JSArrayBufferConstructor.cpp.

(WebCore::JSArrayBufferConstructor::constructJSArrayBuffer):

bindings/js/JSArrayBufferViewHelper.h:

(WebCore::constructArrayBufferView):

bindings/js/JSBindingsAllInOne.cpp:
bindings/js/JSDOMWindowCustom.cpp:
bindings/js/JSEventSourceConstructor.cpp: Removed.
bindings/js/JSEventSourceConstructor.h: Removed.
bindings/js/JSEventSourceCustom.cpp: Copied from WebCore/bindings/js/JSEventSourceConstructor.cpp.

(WebCore::JSEventSourceConstructor::constructJSEventSource):

bindings/js/JSFloat32ArrayConstructor.cpp: Removed.
bindings/js/JSFloat32ArrayConstructor.h: Removed.
bindings/js/JSFloat32ArrayCustom.cpp:

(WebCore::JSFloat32ArrayConstructor::constructJSFloat32Array):

bindings/js/JSInt16ArrayConstructor.cpp: Removed.
bindings/js/JSInt16ArrayConstructor.h: Removed.
bindings/js/JSInt16ArrayCustom.cpp:

(WebCore::JSInt16ArrayConstructor::constructJSInt16Array):

bindings/js/JSInt32ArrayConstructor.cpp: Removed.
bindings/js/JSInt32ArrayConstructor.h: Removed.
bindings/js/JSInt32ArrayCustom.cpp:

(WebCore::JSInt32ArrayConstructor::constructJSInt32Array):

bindings/js/JSInt8ArrayConstructor.cpp: Removed.
bindings/js/JSInt8ArrayConstructor.h: Removed.
bindings/js/JSInt8ArrayCustom.cpp:

(WebCore::JSInt8ArrayConstructor::constructJSInt8Array):

bindings/js/JSMessageChannelConstructor.cpp: Removed.
bindings/js/JSMessageChannelConstructor.h: Removed.
bindings/js/JSMessageChannelCustom.cpp:

(WebCore::JSMessageChannelConstructor::constructJSMessageChannel):

bindings/js/JSSharedWorkerConstructor.cpp: Removed.
bindings/js/JSSharedWorkerConstructor.h: Removed.
bindings/js/JSSharedWorkerCustom.cpp:

(WebCore::JSSharedWorkerConstructor::constructJSSharedWorker):

bindings/js/JSUint16ArrayConstructor.cpp: Removed.
bindings/js/JSUint16ArrayConstructor.h: Removed.
bindings/js/JSUint16ArrayCustom.cpp:

(WebCore::JSUint16ArrayConstructor::constructJSUint16Array):

bindings/js/JSUint32ArrayConstructor.cpp: Removed.
bindings/js/JSUint32ArrayConstructor.h: Removed.
bindings/js/JSUint32ArrayCustom.cpp:

(WebCore::JSUint32ArrayConstructor::constructJSUint32Array):

bindings/js/JSUint8ArrayConstructor.cpp: Removed.
bindings/js/JSUint8ArrayConstructor.h: Removed.
bindings/js/JSUint8ArrayCustom.cpp:

(WebCore::JSUint8ArrayConstructor::constructJSUint8Array):

bindings/js/JSWebKitCSSMatrixConstructor.cpp: Removed.
bindings/js/JSWebKitCSSMatrixConstructor.h: Removed.
bindings/js/JSWebKitCSSMatrixCustom.cpp: Copied from WebCore/bindings/js/JSWebKitCSSMatrixConstructor.cpp.

(WebCore::JSWebKitCSSMatrixConstructor::constructJSWebKitCSSMatrix):

bindings/js/JSWebKitPointConstructor.cpp: Removed.
bindings/js/JSWebKitPointConstructor.h: Removed.
bindings/js/JSWebKitPointCustom.cpp: Copied from WebCore/bindings/js/JSWebKitPointConstructor.cpp.

(WebCore::JSWebKitPointConstructor::constructJSWebKitPoint):

bindings/js/JSWebSocketConstructor.cpp: Removed.
bindings/js/JSWebSocketConstructor.h: Removed.
bindings/js/JSWebSocketCustom.cpp:

(WebCore::JSWebSocketConstructor::constructJSWebSocket):

bindings/js/JSWorkerConstructor.cpp: Removed.
bindings/js/JSWorkerConstructor.h: Removed.
bindings/js/JSWorkerContextCustom.cpp:
bindings/js/JSWorkerCustom.cpp:

(WebCore::JSWorkerConstructor::constructJSWorker):

bindings/js/JSXSLTProcessorConstructor.cpp: Removed.
bindings/js/JSXSLTProcessorConstructor.h: Removed.
bindings/js/JSXSLTProcessorCustom.cpp:

(WebCore::JSXSLTProcessorConstructor::constructJSXSLTProcessor):

bindings/scripts/CodeGeneratorJS.pm:
css/WebKitCSSMatrix.idl:
dom/MessageChannel.idl:
html/canvas/ArrayBuffer.idl:
html/canvas/Float32Array.idl:
html/canvas/Int16Array.idl:
html/canvas/Int32Array.idl:
html/canvas/Int8Array.idl:
html/canvas/Uint16Array.idl:
html/canvas/Uint32Array.idl:
html/canvas/Uint8Array.idl:
page/EventSource.idl:
page/WebKitPoint.idl:
websockets/WebSocket.idl:
workers/SharedWorker.idl:
workers/Worker.idl:
xml/XSLTProcessor.idl:

LayoutTests:

fast/dom/Window/window-lookup-precedence-expected.txt:
fast/dom/Window/window-properties-expected.txt:
fast/dom/constructed-objects-prototypes-expected.txt:
fast/dom/prototype-inheritance-2-expected.txt:
fast/js/global-constructors-expected.txt:

12:11 PM Changeset in webkit [61135] by tonikitoo@webkit.org

2 edits in trunk/WebCore

2010-05-16 Antonio Gomes <tonikitoo@webkit.org>

Unreviewed naming fixes of local variables used in Spatial Navigation methods.

Summary:

"candidate" renamed to "node";
"currentFocusCandidate" renamed to "candidate"
"closestFocusCandidate" renamed to "closest"

That way naming is more consistent in the various Spatial Navigation methods.

page/FocusController.cpp: (WebCore::FocusController::findFocusableNodeInDirection): (WebCore::FocusController::deepFindFocusableNodeInDirection):

12:10 PM Changeset in webkit [61134] by tonikitoo@webkit.org

5 edits
4 adds in trunk

Spatial Navigation: make it work with focusable elements in overflow content
https://bugs.webkit.org/show_bug.cgi?id=36463

Reviewed by Simon Fraser and Kenneth Christiansen.
Patch by Antonio Gomes <tonikitoo@webkit.org>

WebCore:

This patch addresses the problem with Spatial Navigation. It currently does not
properly traverse scrollable contents, including scrollable div's. For this to work,
a new class member called scrollableEnclosingBox was introduced to FocusCandidate class which
keeps track of the current scrollable box Node wrapping a FocusCandidate.

To make use of enclosingScrollableBox of FocusCandidate, the DOM traversal routine
(FocusController::findNextFocusableInDirection) was changed as follows: when it
encounters a scrollable Node, each focusable node which is 'inner' keeps track of
the container reference. By the time a sibling of the scrollable Node is encountered,
there is no need to track this reference any more and the traversal algorithm continues
normally.

The common case is obviously that there is no scrollable container wrapping it.

updateFocusCandiditeIfCloser logic was also adapted to fit the need of the
newly introduced enclosingScrollableBox class member, getting simpler and more
easily maintainable.

Tests: fast/events/spatial-navigation/snav-div-scrollable-but-without-focusable-content.html

fast/events/spatial-navigation/snav-clipped-overflow-content.html

page/FocusController.cpp:

(WebCore::updateFocusCandidateInSameContainer):
(WebCore::updateFocusCandidateIfCloser):
(WebCore::FocusController::findFocusableNodeInDirection):
(WebCore::FocusController::deepFindFocusableNodeInDirection):

page/SpatialNavigation.cpp:

(WebCore::isScrollableContainerNode):

page/SpatialNavigation.h:

(WebCore::FocusCandidate::FocusCandidate):
(WebCore::FocusCandidate::inScrollableContainer):

LayoutTests:

fast/events/spatial-navigation/snav-div-scrollable-but-without-focusable-content-expected.txt: Added.
fast/events/spatial-navigation/snav-div-scrollable-but-without-focusable-content.html: Added.
fast/events/spatial-navigation/snav-clipped-overflow-content-expected.txt: Added.
fast/events/spatial-navigation/snav-clipped-overflow-content.html: Added.

11:59 AM Changeset in webkit [61133] by jianli@chromium.org

7 edits in trunk/WebCore

Unreviewed. Fix build break in GTK.

bindings/scripts/CodeGeneratorGObject.pm:
bindings/scripts/test/GObject/WebKitDOMTestCallback.h:
bindings/scripts/test/GObject/WebKitDOMTestCallbackPrivate.h:
bindings/scripts/test/GObject/WebKitDOMTestInterface.h:
bindings/scripts/test/GObject/WebKitDOMTestInterfacePrivate.h:
bindings/scripts/test/GObject/WebKitDOMTestObj.h:

11:43 AM Changeset in webkit [61132] by Chris Fleizach

3 edits
2 adds in trunk

AX: AXUnknown objects are being returned
https://bugs.webkit.org/show_bug.cgi?id=40574

Reviewed by Beth Dakin.

WebCore:

Test: platform/mac/accessibility/no-unknown-objects-when-title-attribute-present.html

accessibility/mac/AccessibilityObjectMac.mm:

(WebCore::AccessibilityObject::accessibilityPlatformIncludesObject):

LayoutTests:

platform/mac/accessibility/no-unknown-objects-when-title-attribute-present-expected.txt: Added.
platform/mac/accessibility/no-unknown-objects-when-title-attribute-present.html: Added.

11:34 AM Changeset in webkit [61131] by jianli@chromium.org

29 edits in trunk/WebCore

Fix code generators to better support Conditional attribute and add test
coverage for it.
https://bugs.webkit.org/show_bug.cgi?id=39512

Reviewed by Darin Adler.

bindings/scripts/CodeGeneratorGObject.pm:
bindings/scripts/CodeGeneratorObjC.pm:
bindings/scripts/CodeGeneratorV8.pm:
bindings/scripts/test/GObject/WebKitDOMTestCallback.cpp:
bindings/scripts/test/GObject/WebKitDOMTestCallback.h:
bindings/scripts/test/GObject/WebKitDOMTestInterface.cpp:
bindings/scripts/test/GObject/WebKitDOMTestInterface.h:
bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:

(webkit_dom_test_obj_get_conditional_attr1):
(webkit_dom_test_obj_set_conditional_attr1):
(webkit_dom_test_obj_get_conditional_attr2):
(webkit_dom_test_obj_set_conditional_attr2):
(webkit_dom_test_obj_get_conditional_attr3):
(webkit_dom_test_obj_set_conditional_attr3):
(webkit_dom_test_obj_set_property):
(webkit_dom_test_obj_get_property):
(webkit_dom_test_obj_class_init):

bindings/scripts/test/GObject/WebKitDOMTestObj.h:
bindings/scripts/test/JS/JSTestInterface.cpp:
bindings/scripts/test/JS/JSTestInterface.h:
bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore::):
(WebCore::jsTestObjConditionalAttr1):
(WebCore::jsTestObjConditionalAttr2):
(WebCore::jsTestObjConditionalAttr3):
(WebCore::setJSTestObjConditionalAttr1):
(WebCore::setJSTestObjConditionalAttr2):
(WebCore::setJSTestObjConditionalAttr3):

bindings/scripts/test/JS/JSTestObj.h:
bindings/scripts/test/ObjC/DOMTestInterface.mm:
bindings/scripts/test/ObjC/DOMTestObj.h:
bindings/scripts/test/ObjC/DOMTestObj.mm:

(-[DOMTestObj conditionalAttr1]):
(-[DOMTestObj setConditionalAttr1:]):
(-[DOMTestObj conditionalAttr2]):
(-[DOMTestObj setConditionalAttr2:]):
(-[DOMTestObj conditionalAttr3]):
(-[DOMTestObj setConditionalAttr3:]):

bindings/scripts/test/TestInterface.idl:
bindings/scripts/test/TestObj.idl:
bindings/scripts/test/V8/V8TestInterface.cpp:
bindings/scripts/test/V8/V8TestInterface.h:
bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::TestObjInternal::conditionalAttr1AttrGetter):
(WebCore::TestObjInternal::conditionalAttr1AttrSetter):
(WebCore::TestObjInternal::conditionalAttr2AttrGetter):
(WebCore::TestObjInternal::conditionalAttr2AttrSetter):
(WebCore::TestObjInternal::conditionalAttr3AttrGetter):
(WebCore::TestObjInternal::conditionalAttr3AttrSetter):
(WebCore::):

11:30 AM Changeset in webkit [61130] by Chris Fleizach

3 edits in trunk/LayoutTests

Bug 40576 - AX: need to update iframe-bastardization.html LayoutTest to be more modern
https://bugs.webkit.org/show_bug.cgi?id=40576

10:29 AM Changeset in webkit [61129] by eric@webkit.org

26 edits in trunk

2010-06-14 Chang Shu <chang.shu@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Unskip canvas/philip/tests/2d.shadow.enable.x.html
and canvas/philip/tests/2d.shadow.enable.y.html.

https://bugs.webkit.org/show_bug.cgi?id=40434

platform/qt/Skipped:

2010-06-14 Chang Shu <chang.shu@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

Change the type of ShadowSize from IntSize to FloatSize in GraphicsContext.
Using IntSize loses precision and fails the test.
Note: This code change fixes Qt port but Mac is still failing due to
platform issue.

https://bugs.webkit.org/show_bug.cgi?id=40434

html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::applyShadow):
platform/graphics/GraphicsContext.cpp: (WebCore::GraphicsContext::setShadow): (WebCore::GraphicsContext::getShadow):
platform/graphics/GraphicsContext.h:
platform/graphics/GraphicsContextPrivate.h:
platform/graphics/cairo/FontCairo.cpp: (WebCore::Font::drawGlyphs):
platform/graphics/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContext::calculateShadowBufferDimensions): (WebCore::drawPathShadow): (WebCore::drawBorderlessRectShadow): (WebCore::GraphicsContext::setPlatformShadow):
platform/graphics/cairo/ImageCairo.cpp: (WebCore::BitmapImage::draw):
platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::setPlatformShadow):
platform/graphics/chromium/FontChromiumWin.cpp: (WebCore::TransparencyAwareFontPainter::TransparencyAwareGlyphPainter::drawGlyphs): (WebCore::Font::drawComplexText):
platform/graphics/gtk/FontGtk.cpp: (WebCore::Font::drawComplexText):
platform/graphics/haiku/GraphicsContextHaiku.cpp: (WebCore::GraphicsContext::setPlatformShadow):
platform/graphics/mac/FontMac.mm: (WebCore::Font::drawGlyphs):
platform/graphics/openvg/GraphicsContextOpenVG.cpp: (WebCore::GraphicsContext::setPlatformShadow):
platform/graphics/qt/FontQt.cpp: (WebCore::drawTextCommon):
platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::drawRect): (WebCore::GraphicsContext::drawLine): (WebCore::GraphicsContext::strokeArc): (WebCore::GraphicsContext::drawConvexPolygon): (WebCore::drawFilledShadowPath): (WebCore::GraphicsContext::strokePath): (WebCore::drawBorderlessRectShadow): (WebCore::GraphicsContext::setPlatformShadow):
platform/graphics/qt/ImageQt.cpp: (WebCore::BitmapImage::draw):
platform/graphics/skia/GraphicsContextSkia.cpp: (WebCore::GraphicsContext::setPlatformShadow):
platform/graphics/skia/SkiaFontWin.cpp: (WebCore::windowsCanHandleDrawTextShadow):
platform/graphics/win/FontCGWin.cpp: (WebCore::drawGDIGlyphs): (WebCore::Font::drawGlyphs):
platform/graphics/wince/GraphicsContextWince.cpp: (WebCore::GraphicsContext::fillRoundedRect): (WebCore::GraphicsContext::setPlatformShadow): (WebCore::GraphicsContext::drawText):
platform/graphics/wx/GraphicsContextWx.cpp: (WebCore::GraphicsContext::setPlatformShadow):

2010-06-14 Chang Shu <chang.shu@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[win] Make windows compile after API changes.

https://bugs.webkit.org/show_bug.cgi?id=40434

WebKitGraphics.cpp: (WebDrawText):

10:06 AM Changeset in webkit [61128] by mitz@apple.com

58 edits
4 adds in trunk

<rdar://problem/7752961> Unevenly distributed space in justified text
https://bugs.webkit.org/show_bug.cgi?id=36105

Reviewed by Simon Fraser.

WebCore:

Test: fast/text/justify-padding-distribution.html

platform/graphics/WidthIterator.cpp:

(WebCore::WidthIterator::WidthIterator): Initialize m_padPerSpace to the quotient of the total
padding and the number of spaces rather than truncating it.
(WebCore::WidthIterator::advance): Subtract m_padPerSpace from m_padding and add the difference
between its old and new values, when rounded, to the advance.

platform/graphics/mac/ComplexTextController.cpp:

(WebCore::ComplexTextController::ComplexTextController):
(WebCore::ComplexTextController::adjustGlyphsAndAdvances):

platform/graphics/win/UniscribeController.cpp:

(WebCore::UniscribeController::UniscribeController):
(WebCore::UniscribeController::shapeAndPlaceItem):

platform/graphics/win/UniscribeController.h:

LayoutTests:

fast/text/justify-padding-distribution-expected.checksum: Added.
fast/text/justify-padding-distribution-expected.png: Added.
fast/text/justify-padding-distribution-expected.txt: Added.
fast/text/justify-padding-distribution.html: Added.
platform/mac/css1/box_properties/clear_float-expected.checksum:
platform/mac/css1/box_properties/clear_float-expected.png:
platform/mac/css1/box_properties/float_elements_in_series-expected.checksum:
platform/mac/css1/box_properties/float_elements_in_series-expected.png:
platform/mac/css1/box_properties/float_on_text_elements-expected.checksum:
platform/mac/css1/box_properties/float_on_text_elements-expected.png:
platform/mac/css1/text_properties/text_align-expected.checksum:
platform/mac/css1/text_properties/text_align-expected.png:
platform/mac/css2.1/t0905-c5525-fltcont-00-d-g-expected.checksum:
platform/mac/css2.1/t0905-c5525-fltcont-00-d-g-expected.png:
platform/mac/css2.1/t0905-c5525-fltwidth-00-c-g-expected.checksum:
platform/mac/css2.1/t0905-c5525-fltwidth-00-c-g-expected.png:
platform/mac/css2.1/t1602-c546-txt-align-00-b-expected.checksum:
platform/mac/css2.1/t1602-c546-txt-align-00-b-expected.png:
platform/mac/fast/multicol/float-avoidance-expected.checksum:
platform/mac/fast/multicol/float-avoidance-expected.png:
platform/mac/fast/repaint/line-flow-with-floats-1-expected.checksum:
platform/mac/fast/repaint/line-flow-with-floats-1-expected.png:
platform/mac/fast/repaint/line-flow-with-floats-10-expected.checksum:
platform/mac/fast/repaint/line-flow-with-floats-10-expected.png:
platform/mac/fast/repaint/line-flow-with-floats-2-expected.checksum:
platform/mac/fast/repaint/line-flow-with-floats-2-expected.png:
platform/mac/fast/repaint/line-flow-with-floats-3-expected.checksum:
platform/mac/fast/repaint/line-flow-with-floats-3-expected.png:
platform/mac/fast/repaint/line-flow-with-floats-4-expected.checksum:
platform/mac/fast/repaint/line-flow-with-floats-4-expected.png:
platform/mac/fast/repaint/line-flow-with-floats-5-expected.checksum:
platform/mac/fast/repaint/line-flow-with-floats-5-expected.png:
platform/mac/fast/repaint/line-flow-with-floats-6-expected.checksum:
platform/mac/fast/repaint/line-flow-with-floats-6-expected.png:
platform/mac/fast/repaint/line-flow-with-floats-7-expected.checksum:
platform/mac/fast/repaint/line-flow-with-floats-7-expected.png:
platform/mac/fast/repaint/line-flow-with-floats-8-expected.checksum:
platform/mac/fast/repaint/line-flow-with-floats-8-expected.png:
platform/mac/fast/repaint/line-flow-with-floats-9-expected.checksum:
platform/mac/fast/repaint/line-flow-with-floats-9-expected.png:
platform/mac/fast/text/atsui-spacing-features-expected.checksum:
platform/mac/fast/text/atsui-spacing-features-expected.png:
platform/mac/fast/text/justified-selection-at-edge-expected.checksum:
platform/mac/fast/text/justified-selection-at-edge-expected.png:
platform/mac/tables/mozilla/marvin/x_tbody_align_justify-expected.checksum:
platform/mac/tables/mozilla/marvin/x_tbody_align_justify-expected.png:
platform/mac/tables/mozilla/marvin/x_td_align_justify-expected.checksum:
platform/mac/tables/mozilla/marvin/x_td_align_justify-expected.png:
platform/mac/tables/mozilla/marvin/x_tfoot_align_justify-expected.checksum:
platform/mac/tables/mozilla/marvin/x_tfoot_align_justify-expected.png:
platform/mac/tables/mozilla/marvin/x_th_align_justify-expected.checksum:
platform/mac/tables/mozilla/marvin/x_th_align_justify-expected.png:
platform/mac/tables/mozilla/marvin/x_thead_align_justify-expected.checksum:
platform/mac/tables/mozilla/marvin/x_thead_align_justify-expected.png:
platform/mac/tables/mozilla/marvin/x_tr_align_justify-expected.checksum:
platform/mac/tables/mozilla/marvin/x_tr_align_justify-expected.png:

9:38 AM Changeset in webkit [61127] by eric@webkit.org

2 edits in trunk/WebCore

2010-06-14 Andreas Kling <andreas.kling@nokia.com>

Reviewed by Tor Arne Vestbø.

[Qt] Stack overflow when converting navigator object to QVariant
https://bugs.webkit.org/show_bug.cgi?id=40572

Protect against infinite recursion in JSValue->QVariant conversion.
This fixes a crash when trying to convert MimeType objects (they
recurse infinitely and on-the-fly via the enabledPlugin property.)

bridge/qt/qt_runtime.cpp: (JSC::Bindings::convertValueToQVariant):

9:27 AM Changeset in webkit [61126] by eric@webkit.org

4 edits
2 adds in trunk/WebCore

2010-06-14 Yong Li <yoli@rim.com>

Test cases created by: Robin Cao <robin.cao@torchmobile.com.cn>

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=38910

Suspend Document::m_executeScriptSoonTimer objects when the page is deferred.
There's no reason why we suspend all active DOM timers on the page but not suspend
this one. Document::m_executeScriptSoonTimer can run JS and schedule more DOM Timers.

It can only be tested manually.

manual-tests/load-deferrer-script-element.html: Added.
manual-tests/resources/load-deferrer-script-element.js: Added.

dom/Document.cpp: (WebCore::Document::executeScriptSoon): (WebCore::Document::suspendExecuteScriptSoonTimer): Added. (WebCore::Document::resumeExecuteScriptSoonTimer): Added.
dom/Document.h:
page/PageGroupLoadDeferrer.cpp: (WebCore::PageGroupLoadDeferrer::PageGroupLoadDeferrer): (WebCore::PageGroupLoadDeferrer::~PageGroupLoadDeferrer):

8:23 AM Changeset in webkit [61125] by bulach@chromium.org

2 edits in trunk/LayoutTests

2010-06-14 Marcus Bulach <bulach@chromium.org>

Reviewed by Jeremy Orlow.

Rebaseline LayoutTests/platform/chromium/fast/dom/Geolocation/callback-exception-expected.txt.
https://bugs.webkit.org/show_bug.cgi?id=40568

https://bugs.webkit.org/show_bug.cgi?id=39994 changed the test expectations, and we need to rebaseline.

platform/chromium/fast/dom/Geolocation/callback-exception-expected.txt:

8:13 AM Changeset in webkit [61124] by loislo@chromium.org

2 edits in trunk/WebKit/gtk

2010-06-14 Ilya Tikhonovsky <loislo@chromium.org>

Unreviewed build fix.

This is a fix for flaky inspector tests at gtk-debug bots.

WebCoreSupport/InspectorClientGtk.cpp: (WebKit::InspectorFrontendClient::destroyInspectorWindow):

8:07 AM Changeset in webkit [61123] by Laszlo Gombos

2 edits in trunk/WebKit/qt

2010-06-14 Laszlo Gombos <Laszlo Gombos>

Unreviewed, Symbian build fix.

[Qt] Update the def file with recent new exports.

symbian/eabi/QtWebKitu.def:

7:31 AM Changeset in webkit [61122] by mitz@apple.com

2 edits in trunk

Fixed a typo and reviewr information in ChangeLog files

7:09 AM Changeset in webkit [61121] by yael.aharon@nokia.com

13 edits
2 adds in trunk

[Qt] Platform plugin support for Notifications UI
https://bugs.webkit.org/show_bug.cgi?id=40005

Reviewed by Kenneth Rohde Christiansen.

WebCore:

To avoid race condition when GC is run during shutdown,
disconnect the Notification from the NotificationPresenter
when the presenter deletes itself.
This cannot be tested by a layout test, the race condition happens only
when GC is run during shutdown. It can be tested manually by loading
manually any notification test and closing the browser.

notifications/Notification.cpp:

(WebCore::Notification::~Notification):

notifications/Notification.h:

(WebCore::Notification::detachPresenter):

WebKit/qt:

Add an interface to the platform plugin to display notifications.
Implemented the notification in the example platform plugin.
This interface is enabled by default, but could be turned off with
a build flag. The platform plugin should control its own lifecycle,
so now the close timer applies only when using the QSystemTrayIcon.
That's because QSystemTrayIcon does not inform its caller when it
is closed.

Changed the way NotificationPresenterClientQt is deleted because it
is being accessed when GC is deleting the Notification objects.
NotificationPresenterClientQt is now detaching itself from the
Notifications before it is deleted.

Api/qwebkitplatformplugin.h:

(QWebNotificationPresenter::QWebNotificationPresenter):
(QWebNotificationPresenter::~QWebNotificationPresenter):
(QWebKitPlatformPlugin::):

WebCoreSupport/NotificationPresenterClientQt.cpp:

(WebCore::NotificationIconWrapper::NotificationIconWrapper):
(WebCore::NotificationIconWrapper::title):
(WebCore::NotificationIconWrapper::message):
(WebCore::NotificationIconWrapper::iconData):
(WebCore::NotificationPresenterClientQt::~NotificationPresenterClientQt):
(WebCore::NotificationIconWrapper::notificationClosed):
(WebCore::NotificationPresenterClientQt::displayNotification):
(WebCore::NotificationPresenterClientQt::cancel):
(WebCore::NotificationPresenterClientQt::notificationForWrapper):
(WebCore::NotificationPresenterClientQt::removeReplacedNotificationFromQueue):
(WebCore::NotificationPresenterClientQt::detachNotification):

WebCoreSupport/NotificationPresenterClientQt.h:
WebCoreSupport/QtPlatformPlugin.cpp:

(WebCore::QtPlatformPlugin::createNotificationPresenter):

WebCoreSupport/QtPlatformPlugin.h:
examples/platformplugin/WebNotificationPresenter.cpp: Added.

(WebNotificationWidget::WebNotificationWidget):
(WebNotificationWidget::~WebNotificationWidget):
(WebNotificationWidget::showNotification):
(WebNotificationWidget::event):

examples/platformplugin/WebNotificationPresenter.h: Added.

(WebNotificationPresenter::WebNotificationPresenter):
(WebNotificationPresenter::~WebNotificationPresenter):
(WebNotificationPresenter::showNotification):

examples/platformplugin/WebPlugin.cpp:

(WebPlugin::supportsExtension):

examples/platformplugin/WebPlugin.h:

(WebPlugin::createNotificationPresenter):

examples/platformplugin/platformplugin.pro:
examples/platformplugin/qwebkitplatformplugin.h:

(QWebNotificationPresenter::QWebNotificationPresenter):
(QWebNotificationPresenter::~QWebNotificationPresenter):
(QWebKitPlatformPlugin::):

6:42 AM Changeset in webkit [61120] by bulach@chromium.org

17 edits
3 copies
3 adds in trunk

2010-06-08 Marcus Bulach <bulach@chromium.org>

Reviewed by Jeremy Orlow.

Adds IndexedDB's KeyRange.
https://bugs.webkit.org/show_bug.cgi?id=40250

storage/indexeddb/idb-keyrange-expected.txt: Added.
storage/indexeddb/idb-keyrange.html: Added.
storage/indexeddb/script-tests/idb-keyrange.js: Added. (checkSingleKeyRange): (checkLeftBoundKeyRange): ():

2010-06-08 Marcus Bulach <bulach@chromium.org>

Reviewed by Jeremy Orlow.

Adds IndexedDB's KeyRange.
https://bugs.webkit.org/show_bug.cgi?id=40250

Test: storage/indexeddb/idb-keyrange.html

Android.derived.jscbindings.mk:
Android.derived.v8bindings.mk:
Android.mk:
CMakeLists.txt:
DerivedSources.cpp:
DerivedSources.make:
GNUmakefile.am:
WebCore.gypi:
WebCore.pri:
WebCore.pro:
WebCore.vcproj/WebCore.vcproj:
WebCore.xcodeproj/project.pbxproj:
storage/IDBKeyRange.cpp: Added. (WebCore::IDBKeyRange::IDBKeyRange):
storage/IDBKeyRange.h: Added. (WebCore::IDBKeyRange::): (WebCore::IDBKeyRange::create): (WebCore::IDBKeyRange::~IDBKeyRange): (WebCore::IDBKeyRange::left): (WebCore::IDBKeyRange::right): (WebCore::IDBKeyRange::flags):
storage/IDBKeyRange.idl: Added.
storage/IndexedDatabaseRequest.cpp: (WebCore::IndexedDatabaseRequest::makeSingleKeyRange): (WebCore::IndexedDatabaseRequest::makeLeftBoundKeyRange): (WebCore::IndexedDatabaseRequest::makeRightBoundKeyRange): (WebCore::IndexedDatabaseRequest::makeBoundKeyRange):
storage/IndexedDatabaseRequest.h:
storage/IndexedDatabaseRequest.idl:

6:28 AM Changeset in webkit [61119] by jorlow@chromium.org

2 edits in trunk/WebCore

2010-06-14 Jeremy Orlow <jorlow@chromium.org>

And another.

storage/IndexedDatabaseRequest.h:

6:21 AM Changeset in webkit [61118] by jorlow@chromium.org

4 edits in trunk

2010-06-14 Jeremy Orlow <jorlow@chromium.org>

More build fixes.

storage/IndexedDatabaseRequest.h:

2010-06-14 Jeremy Orlow <jorlow@chromium.org>

Build fix.

src/IDBCallbacksProxy.h:

6:05 AM Changeset in webkit [61117] by Csaba Osztrogonác

17 edits
2 adds in trunk

[Qt] navigator.geolocation support for Qt port
https://bugs.webkit.org/show_bug.cgi?id=39724

Patch by Mahesh Kulkarni <mahesh.kulkarni@nokia.com> on 2010-06-14
Reviewed by Laszlo Gombos.

WebCore:

Implemetion for Qt port of navigator.gelocation. Using qtmobility location service.

WebCore.pri:
WebCore.pro:
platform/qt/GeolocationServiceQt.cpp: Added.

(WebCore::GeolocationServiceQt::create):
(WebCore::GeolocationServiceQt::GeolocationServiceQt):
(WebCore::GeolocationServiceQt::~GeolocationServiceQt):
(WebCore::GeolocationServiceQt::positionUpdated):
(WebCore::GeolocationServiceQt::startUpdating):
(WebCore::GeolocationServiceQt::stopUpdating):

platform/qt/GeolocationServiceQt.h: Added.

(WebCore::GeolocationServiceQt::lastPosition):
(WebCore::GeolocationServiceQt::lastError):

WebKit/qt:

Implement ChromeClientQt::requestGeolocationPermissionForFrame() which delegates call to QWebPage::allowGeolocationRequest
Layout and unit test cases for the are also added.

Api/qwebpage.cpp:

(QWebPage::allowGeolocationRequest):

Api/qwebpage.h:
WebCoreSupport/ChromeClientQt.cpp:

(WebCore::ChromeClientQt::requestGeolocationPermissionForFrame):

WebCoreSupport/DumpRenderTreeSupportQt.cpp:

(DumpRenderTreeSupportQt::setMockGeolocationPosition):
(DumpRenderTreeSupportQt::setMockGeolocationError):

WebCoreSupport/DumpRenderTreeSupportQt.h:
tests/qwebpage/tst_qwebpage.cpp:

(JSTestPage::shouldInterruptJavaScript):
(JSTestPage::allowGeolocationRequest):
(JSTestPage::setGeolocationPermission):
(tst_QWebPage::geolocationRequestJS):

WebKitTools:

Implementation for geolocation cases to DumpRenderTreeQt

DumpRenderTree/qt/DumpRenderTreeQt.cpp:

(WebCore::WebPage::allowGeolocationRequest):

DumpRenderTree/qt/DumpRenderTreeQt.h:
DumpRenderTree/qt/LayoutTestControllerQt.cpp:

(LayoutTestController::setGeolocationPermission):
(LayoutTestController::setMockGeolocationError):
(LayoutTestController::setMockGeolocationPosition):

DumpRenderTree/qt/LayoutTestControllerQt.h:

(LayoutTestController::isGeolocationPermissionSet):
(LayoutTestController::geolocationPermission):

LayoutTests:

Uncommenting gelocation cases from Qt. Skipped one case: fast/dom/Geolocation/callback-to-remote-context2.html

platform/qt/Skipped:

5:57 AM Changeset in webkit [61116] by jorlow@chromium.org

3 edits in trunk/WebCore

2010-06-14 Jeremy Orlow <jorlow@chromium.org>

2 more build fixes.

storage/IDBDatabaseImpl.h:
storage/IndexedDatabaseRequest.h:

5:48 AM Changeset in webkit [61115] by jorlow@chromium.org

2 edits in trunk/WebCore

2010-06-14 Jeremy Orlow <jorlow@chromium.org>

Unreviewed build fix for my last.

workers/WorkerScriptLoaderClient.h:

5:35 AM Changeset in webkit [61114] by jorlow@chromium.org

3 edits in trunk/WebCore

2010-06-14 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Darin Fisher.

[V8] Clean up SerializedScriptValue
https://bugs.webkit.org/show_bug.cgi?id=40482

SerializedScriptValue doesn't follow WebKit's style guidelines very well
and needlessly inlines quite a bit within the .h file. This change cleans
things up. No funcitonal changes.

No change in behavior.

bindings/v8/SerializedScriptValue.cpp: (WebCore::SerializedScriptValue::deserializeAndSetProperty): (WebCore::SerializedScriptValue::create): (WebCore::SerializedScriptValue::createFromWire): (WebCore::SerializedScriptValue::release): (WebCore::SerializedScriptValue::SerializedScriptValue):
bindings/v8/SerializedScriptValue.h:

5:32 AM Changeset in webkit [61113] by loislo@chromium.org

37 edits in trunk

2010-06-14 Ilya Tikhonovsky <loislo@chromium.org>

Reviewed by Pavel Feldman.

WebInspector: On the way to Remote Debugging we want to transfer dom/timeline/etc
data from inspected page to WebInspector as JSON string via http. The native
serialization to JSON string is supported by InspectorValue's classes. This patch
has the implementation of sendMessageToFrontend function. WebKit version of it still
uses ScriptFunctionCall and will be switched to another transport a little bit later.
https://bugs.webkit.org/show_bug.cgi?id=40134

inspector/InspectorClient.h:
inspector/InspectorController.cpp: (WebCore::InspectorController::connectFrontend): (WebCore::InspectorController::disconnectFrontend):
inspector/InspectorController.h:
inspector/InspectorFrontend.cpp: (WebCore::InspectorFrontend::InspectorFrontend):
inspector/InspectorFrontend.h:
inspector/InspectorFrontendClientLocal.cpp: (WebCore::InspectorFrontendClientLocal::frontendLoaded):
inspector/InspectorValues.cpp: (WebCore::InspectorObject::writeJSON):
inspector/front-end/inspector.js: (WebInspector.dispatchMessageToFrontend):
loader/EmptyClients.h: (WebCore::EmptyInspectorClient::sendMessageToFrontend):

5:09 AM Changeset in webkit [61112] by eric@webkit.org

13 edits in trunk

2010-06-14 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Darin Adler.

Reenable IDBDatabaseRequest's description attribute
https://bugs.webkit.org/show_bug.cgi?id=39826

Existing test now fixed.

storage/indexeddb/idb-database-request-expected.txt:

2010-06-14 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Darin Adler.

Reenable IDBDatabaseRequest's description attribute
https://bugs.webkit.org/show_bug.cgi?id=39826

On the 26th, Beth commented out the description attribute in
IDBDatabaseRequest because it was causing problems with the
objective c bindings. Turns out that this is the same bug as
in http://trac.webkit.org/changeset/19486. (Thanks for the
pointer, Mark!)

The solution is to change the objective C bindings generator
to change the name in the generated code. id and hash both
just appended "Name" to them in the past. I couldn't think
of anything else particularly better to append, so I just
went with name as well.

Test: building the world works on the first try. Layout

test verifies description works again.

bindings/scripts/CodeGeneratorObjC.pm:
bindings/scripts/test/GObject/WebKitDOMTestObj.cpp: (webkit_dom_test_obj_get_description): (webkit_dom_test_obj_get_id): (webkit_dom_test_obj_set_id): (webkit_dom_test_obj_get_hash): (webkit_dom_test_obj_set_property): (webkit_dom_test_obj_get_property): (webkit_dom_test_obj_class_init):
bindings/scripts/test/GObject/WebKitDOMTestObj.h:
bindings/scripts/test/JS/JSTestObj.cpp: (WebCore::): (WebCore::jsTestObjDescription): (WebCore::jsTestObjId): (WebCore::jsTestObjHash): (WebCore::setJSTestObjId):
bindings/scripts/test/JS/JSTestObj.h:
bindings/scripts/test/ObjC/DOMTestObj.h:
bindings/scripts/test/ObjC/DOMTestObj.mm: (-[DOMTestObj descriptionName]): (-[DOMTestObj idName]): (-[DOMTestObj setIdName:]): (-[DOMTestObj hashName]):
bindings/scripts/test/TestObj.idl:
bindings/scripts/test/V8/V8TestObj.cpp: (WebCore::TestObjInternal::descriptionAttrGetter): (WebCore::TestObjInternal::idAttrGetter): (WebCore::TestObjInternal::idAttrSetter): (WebCore::TestObjInternal::hashAttrGetter): (WebCore::):
storage/IDBDatabaseRequest.idl:

12:55 AM Changeset in webkit [61111] by Csaba Osztrogonác

2 edits in trunk/LayoutTests

Unreviewed trivial fix.

[Qt] Update platform specific expected file after r61100.

platform/qt/fast/dom/Window/window-properties-expected.txt: updated.

Jun 13, 2010:

11:32 PM Changeset in webkit [61110] by eric@webkit.org

3 edits
3 adds in trunk

2010-06-13 Charles Wei <charles.wei@torchmobile.com.cn>

Reviewed by George Staikos.

Test case to verify that MIME type in uppercase (TEXT/HTML) is supported.
https://bugs.webkit.org/show_bug.cgi?id=39492

http/tests/mime/resources/uppercase-mime-type.php: Added.
http/tests/mime/uppercase-mime-type-expected.txt: Added.
http/tests/mime/uppercase-mime-type.html: Added.

2010-06-13 Charles Wei <charles.wei@torchmobile.com.cn>

Reviewed by George Staikos.

Fix the QtWebKit which doesn't recognize the MIME type of HTML/TEXT in uppercase
https://bugs.webkit.org/show_bug.cgi?id=39492

WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::canShowMIMEType):

11:20 PM Changeset in webkit [61109] by eric@webkit.org

2 edits in trunk/WebCore

2010-06-13 Anders Bakken <agbakken@gmail.com>

Reviewed by Eric Seidel.

[Qt] ScreenQt.cpp has coding-style errors
https://bugs.webkit.org/show_bug.cgi?id=39766

platform/qt/ScreenQt.cpp:

10:58 PM Changeset in webkit [61108] by eric@webkit.org

2 edits in trunk/WebKitTools

2010-06-13 Nathan Lawrence <nlawrence@apple.com>

Reviewed by Darin Adler.

Outside of Xcode (make or WebKitTools/Scripts), there doesn't seem to
be a way of overwriting the Xcode system path. Making
$WEBKITOUTPUTDIR take precedence over the system default would make
this possible.

Scripts/webkitdirs.pm:

10:19 PM Changeset in webkit [61107] by eric@webkit.org

23 edits
2 moves in trunk/WebCore

2010-06-13 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Rename HTMLParser to LegacyHTMLTreeConstructor
https://bugs.webkit.org/show_bug.cgi?id=40554

This makes our old HTML parsing system closer match the
HTML5 spec, and thus easier to compare to the new HTML5
parsing system.

This rename was entirely automatic. Done by do-webcore-rename.

Android.mk:
CMakeLists.txt:
GNUmakefile.am:
WebCore.gypi:
WebCore.pro:
WebCore.vcproj/WebCore.vcproj:
WebCore.xcodeproj/project.pbxproj:
dom/Document.cpp:
dom/DocumentParser.h: (WebCore::DocumentParser::htmlTreeConstructor):
html/HTML5DocumentParser.cpp: (WebCore::HTML5DocumentParser::htmlTreeConstructor):
html/HTML5DocumentParser.h:
html/HTML5TreeBuilder.cpp: (WebCore::HTML5TreeBuilder::HTML5TreeBuilder):
html/HTML5TreeBuilder.h: (WebCore::HTML5TreeBuilder::legacyTreeConstructor):
html/HTMLDocumentParser.cpp: (WebCore::HTMLDocumentParser::HTMLDocumentParser):
html/HTMLDocumentParser.h: (WebCore::HTMLDocumentParser::htmlTreeConstructor):
html/HTMLFormControlElement.cpp: (WebCore::HTMLFormControlElement::removedFromTree):
html/HTMLInputElement.cpp:
html/HTMLMeterElement.cpp:
html/HTMLProgressElement.cpp:
html/LegacyHTMLTreeConstructor.cpp: Renamed from WebCore/html/HTMLParser.cpp. (WebCore::addTags): (WebCore::HTMLStackElem::HTMLStackElem): (WebCore::HTMLStackElem::derefNode): (WebCore::LegacyHTMLTreeConstructor::LegacyHTMLTreeConstructor): (WebCore::LegacyHTMLTreeConstructor::~LegacyHTMLTreeConstructor): (WebCore::LegacyHTMLTreeConstructor::reset): (WebCore::LegacyHTMLTreeConstructor::setCurrent): (WebCore::tagPriorityOfNode): (WebCore::LegacyHTMLTreeConstructor::limitDepth): (WebCore::LegacyHTMLTreeConstructor::insertNodeAfterLimitDepth): (WebCore::LegacyHTMLTreeConstructor::parseToken): (WebCore::LegacyHTMLTreeConstructor::parseDoctypeToken): (WebCore::isTableSection): (WebCore::isTablePart): (WebCore::isTableRelated): (WebCore::isScopingTag): (WebCore::LegacyHTMLTreeConstructor::insertNode): (WebCore::LegacyHTMLTreeConstructor::handleError): (WebCore::LegacyHTMLTreeConstructor::textCreateErrorCheck): (WebCore::LegacyHTMLTreeConstructor::commentCreateErrorCheck): (WebCore::LegacyHTMLTreeConstructor::headCreateErrorCheck): (WebCore::LegacyHTMLTreeConstructor::bodyCreateErrorCheck): (WebCore::LegacyHTMLTreeConstructor::framesetCreateErrorCheck): (WebCore::LegacyHTMLTreeConstructor::formCreateErrorCheck): (WebCore::LegacyHTMLTreeConstructor::isindexCreateErrorCheck): (WebCore::LegacyHTMLTreeConstructor::selectCreateErrorCheck): (WebCore::LegacyHTMLTreeConstructor::ddCreateErrorCheck): (WebCore::LegacyHTMLTreeConstructor::dtCreateErrorCheck): (WebCore::LegacyHTMLTreeConstructor::rpCreateErrorCheck): (WebCore::LegacyHTMLTreeConstructor::rtCreateErrorCheck): (WebCore::LegacyHTMLTreeConstructor::nestedCreateErrorCheck): (WebCore::LegacyHTMLTreeConstructor::nestedPCloserCreateErrorCheck): (WebCore::LegacyHTMLTreeConstructor::nestedStyleCreateErrorCheck): (WebCore::LegacyHTMLTreeConstructor::tableCellCreateErrorCheck): (WebCore::LegacyHTMLTreeConstructor::tableSectionCreateErrorCheck): (WebCore::LegacyHTMLTreeConstructor::noembedCreateErrorCheck): (WebCore::LegacyHTMLTreeConstructor::noframesCreateErrorCheck): (WebCore::LegacyHTMLTreeConstructor::noscriptCreateErrorCheck): (WebCore::LegacyHTMLTreeConstructor::pCloserCreateErrorCheck): (WebCore::LegacyHTMLTreeConstructor::pCloserStrictCreateErrorCheck): (WebCore::LegacyHTMLTreeConstructor::mapCreateErrorCheck): (WebCore::mapTagToFunc): (WebCore::mapTagsToFunc): (WebCore::LegacyHTMLTreeConstructor::getNode): (WebCore::LegacyHTMLTreeConstructor::allowNestedRedundantTag): (WebCore::LegacyHTMLTreeConstructor::processCloseTag): (WebCore::LegacyHTMLTreeConstructor::isHeadingTag): (WebCore::LegacyHTMLTreeConstructor::isInline): (WebCore::LegacyHTMLTreeConstructor::isResidualStyleTag): (WebCore::LegacyHTMLTreeConstructor::isAffectedByResidualStyle): (WebCore::LegacyHTMLTreeConstructor::handleResidualStyleCloseTagAcrossBlocks): (WebCore::LegacyHTMLTreeConstructor::reopenResidualStyleTags): (WebCore::LegacyHTMLTreeConstructor::pushBlock): (WebCore::LegacyHTMLTreeConstructor::popBlock): (WebCore::LegacyHTMLTreeConstructor::popOneBlockCommon): (WebCore::LegacyHTMLTreeConstructor::popOneBlock): (WebCore::LegacyHTMLTreeConstructor::moveOneBlockToStack): (WebCore::LegacyHTMLTreeConstructor::checkIfHasPElementInScope): (WebCore::LegacyHTMLTreeConstructor::popInlineBlocks): (WebCore::LegacyHTMLTreeConstructor::freeBlock): (WebCore::LegacyHTMLTreeConstructor::createHead): (WebCore::LegacyHTMLTreeConstructor::handleIsindex): (WebCore::LegacyHTMLTreeConstructor::startBody): (WebCore::LegacyHTMLTreeConstructor::finished): (WebCore::LegacyHTMLTreeConstructor::reportErrorToConsole): (WebCore::shouldCreateImplicitHead): (WebCore::serializeForNumberType): (WebCore::parseToDoubleForNumberType):
html/LegacyHTMLTreeConstructor.h: Renamed from WebCore/html/HTMLParser.h. (WebCore::LegacyHTMLTreeConstructor::skipMode): (WebCore::LegacyHTMLTreeConstructor::isHandlingResidualStyleAcrossBlocks): (WebCore::LegacyHTMLTreeConstructor::setSkipMode): (WebCore::LegacyHTMLTreeConstructor::popBlock): (WebCore::LegacyHTMLTreeConstructor::hasPElementInScope): (WebCore::LegacyHTMLTreeConstructor::reportError): (WebCore::LegacyHTMLTreeConstructor::): (WebCore::shouldCreateImplicitHead):
html/StepRange.cpp:
html/ValidityState.cpp:
rendering/RenderSlider.cpp:

9:48 PM Changeset in webkit [61106] by abarth@webkit.org

9 edits in trunk/WebCore

2010-06-13 Eric Seidel <eric@webkit.org>

Reviewed by Darin Adler.

Rename m_parser, htmlParser() to m_treeConstructor, htmlTreeConstructor() in preparation for renaming HTMLParser
https://bugs.webkit.org/show_bug.cgi?id=40514

This rename was done by hand. I realize now I should have
renamed HTMLParser to HTMLTreeConstructor before renaming HTMLTokenizer.

No functional changes, thus no tests.

dom/DocumentParser.h: (WebCore::DocumentParser::htmlTreeConstructor):
html/HTML5DocumentParser.cpp: (WebCore::HTML5DocumentParser::HTML5DocumentParser): (WebCore::HTML5DocumentParser::pumpLexerIfPossible): (WebCore::HTML5DocumentParser::pumpLexer): (WebCore::HTML5DocumentParser::end): (WebCore::HTML5DocumentParser::htmlTreeConstructor): (WebCore::HTML5DocumentParser::isWaitingForScripts): (WebCore::HTML5DocumentParser::resumeParsingAfterScriptExecution): (WebCore::HTML5DocumentParser::notifyFinished): (WebCore::HTML5DocumentParser::executeScriptsWaitingForStylesheets):
html/HTML5DocumentParser.h:
html/HTML5TreeBuilder.cpp: (WebCore::HTML5TreeBuilder::HTML5TreeBuilder): (WebCore::HTML5TreeBuilder::passTokenToLegacyParser): (WebCore::HTML5TreeBuilder::finished):
html/HTML5TreeBuilder.h: (WebCore::HTML5TreeBuilder::legacyTreeConstructor):
html/HTMLDocumentParser.cpp: (WebCore::HTMLDocumentParser::HTMLDocumentParser): (WebCore::HTMLDocumentParser::scriptHandler): (WebCore::HTMLDocumentParser::parseTag): (WebCore::HTMLDocumentParser::end): (WebCore::HTMLDocumentParser::processToken): (WebCore::HTMLDocumentParser::processDoctypeToken):
html/HTMLDocumentParser.h: (WebCore::HTMLDocumentParser::htmlTreeConstructor):
html/HTMLFormControlElement.cpp: (WebCore::HTMLFormControlElement::removedFromTree):

9:44 PM Changeset in webkit [61105] by abarth@webkit.org

6 edits in trunk/WebCore

2010-06-13 Eric Seidel <eric@webkit.org>

Reviewed by Darin Adler.

Rename tok, asHTMLTokenizer to parser, asHTMLDocumentParser
https://bugs.webkit.org/show_bug.cgi?id=40513

Last set of Tokenizer related renames, also done via do-webcore-rename:
asHTMLTokenizer => asHTMLDocumentParser
tok => parser

No functional changes, thus no tests.

dom/Document.cpp: (WebCore::Document::write):
dom/DocumentParser.h: (WebCore::DocumentParser::asHTMLDocumentParser):
html/HTMLDocumentParser.cpp: (WebCore::parseHTMLDocumentFragment):
html/HTMLDocumentParser.h: (WebCore::HTMLDocumentParser::asHTMLDocumentParser):
loader/DocumentLoader.cpp: (WebCore::DocumentLoader::isLoadingInAPISense):

9:40 PM Changeset in webkit [61104] by abarth@webkit.org

37 edits in trunk/WebCore

2010-06-13 Eric Seidel <eric@webkit.org>

Reviewed by Darin Adler.

Fix the rest of the references to the old Tokenizer class (now DocumentParser)
https://bugs.webkit.org/show_bug.cgi?id=40512

No functional changes, thus no new tests.
This was mostly done by do-webcore-rename:
tokenizer => parser
m_tokenizer => m_parser
createTextTokenizer => createTextDocumentParser
createTokenizer => createParser
getTokenizer => getParser

However had to be careful to avoid renaming things related to
css/tokenizer.flex (which we should later rename to CSSTokenizer.flex)

Still a couple references with "tok" and "asHTMLTokenizer" which I'll
get in the next patch.

accessibility/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::isLoaded):
bindings/v8/ScriptEventListener.cpp: (WebCore::createAttributeEventListener):
dom/Document.cpp: (WebCore::Document::removedLastRef): (WebCore::Document::~Document): (WebCore::Document::createParser): (WebCore::Document::open): (WebCore::Document::cancelParsing): (WebCore::Document::implicitOpen): (WebCore::Document::implicitClose): (WebCore::Document::write): (WebCore::Document::finishParsing): (WebCore::Document::removePendingSheet):
dom/Document.h: (WebCore::Document::parser):
dom/DocumentParser.h:
dom/ViewportArguments.cpp: (WebCore::reportViewportWarning):
dom/XMLDocumentParserLibxml2.cpp: (WebCore::PendingCallbacks::callAndRemoveFirstCallback): (WebCore::PendingCallbacks::PendingStartElementNSCallback::call): (WebCore::PendingCallbacks::PendingEndElementNSCallback::call): (WebCore::PendingCallbacks::PendingCharactersCallback::call): (WebCore::PendingCallbacks::PendingProcessingInstructionCallback::call): (WebCore::PendingCallbacks::PendingCDATABlockCallback::call): (WebCore::PendingCallbacks::PendingCommentCallback::call): (WebCore::PendingCallbacks::PendingInternalSubsetCallback::call): (WebCore::PendingCallbacks::): (WebCore::getParser): (WebCore::startElementNsHandler): (WebCore::endElementNsHandler): (WebCore::charactersHandler): (WebCore::processingInstructionHandler): (WebCore::cdataBlockHandler): (WebCore::commentHandler): (WebCore::warningHandler): (WebCore::fatalErrorHandler): (WebCore::normalErrorHandler): (WebCore::getEntityHandler): (WebCore::startDocumentHandler): (WebCore::endDocumentHandler): (WebCore::internalSubsetHandler): (WebCore::externalSubsetHandler): (WebCore::parseXMLDocumentFragment):
dom/XMLDocumentParserQt.cpp: (WebCore::parseXMLDocumentFragment):
html/HTML5EntityParser.cpp:
html/HTMLDocument.cpp: (WebCore::HTMLDocument::createParser):
html/HTMLDocument.h:
html/HTMLDocumentParser.cpp: (WebCore::HTMLDocumentParser::write): (WebCore::HTMLDocumentParser::stopParsing):
html/HTMLFormControlElement.cpp: (WebCore::HTMLFormControlElement::removedFromTree):
html/HTMLParser.cpp: (WebCore::HTMLParser::finished): (WebCore::HTMLParser::reportErrorToConsole):
html/HTMLViewSourceDocument.cpp: (WebCore::HTMLViewSourceDocument::createParser): (WebCore::HTMLViewSourceDocument::addLine):
html/HTMLViewSourceDocument.h:
loader/DocumentLoader.cpp: (WebCore::DocumentLoader::isLoadingInAPISense):
loader/DocumentWriter.cpp: (WebCore::DocumentWriter::begin): (WebCore::DocumentWriter::addData):
loader/FTPDirectoryDocument.cpp: (WebCore::FTPDirectoryDocument::createParser):
loader/FTPDirectoryDocument.h:
loader/FrameLoader.cpp: (WebCore::FrameLoader::stopLoading): (WebCore::FrameLoader::stop):
loader/ImageDocument.cpp: (WebCore::ImageDocument::createParser):
loader/ImageDocument.h:
loader/MediaDocument.cpp: (WebCore::MediaDocument::createParser):
loader/MediaDocument.h:
loader/PluginDocument.cpp: (WebCore::PluginDocument::createParser):
loader/PluginDocument.h:
loader/SinkDocument.cpp: (WebCore::SinkDocument::createParser):
loader/SinkDocument.h:
loader/TextDocument.cpp: (WebCore::TextDocument::createParser): (WebCore::createTextDocumentParser):
loader/TextDocument.h:
svg/SVGDocumentExtensions.cpp: (WebCore::SVGDocumentExtensions::reportWarning): (WebCore::SVGDocumentExtensions::reportError):
wml/WMLDocument.cpp: (WebCore::WMLDocument::finishedParsing):
wml/WMLErrorHandling.cpp: (WebCore::reportWMLError):
wml/WMLTemplateElement.cpp: (WebCore::WMLTemplateElement::registerTemplatesInDocument):

9:00 PM Changeset in webkit [61103] by Chris Fleizach

9 edits
2 adds in trunk

AX: link won't return linked element if URL contains #
https://bugs.webkit.org/show_bug.cgi?id=40192

WebCore:

Reviewed by Darin Adler.

Test: platform/mac/accessibility/internal-link-when-document-has-fragment.html

accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::internalLinkElement):

WebKitTools:

Reviewed by Darin Adler.

DumpRenderTree/AccessibilityUIElement.cpp:

(linkedUIElementAtIndexCallback):
(AccessibilityUIElement::getJSClass):

DumpRenderTree/AccessibilityUIElement.h:
DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:

(AccessibilityUIElement::linkedUIElementAtIndex):

DumpRenderTree/mac/AccessibilityUIElementMac.mm:

(AccessibilityUIElement::linkedUIElementAtIndex):

DumpRenderTree/win/AccessibilityUIElementWin.cpp:

(AccessibilityUIElement::linkedUIElementAtIndex):

LayoutTests:

Reviewed by Darin Alder.

platform/mac/accessibility/internal-link-when-document-has-fragment-expected.txt: Added.
platform/mac/accessibility/internal-link-when-document-has-fragment.html: Added.

8:37 PM Changeset in webkit [61102] by Simon Fraser

3 edits in trunk/LayoutTests

2010-06-13 Simon Fraser <Simon Fraser>

Fix GTK bots; don't include the offsetWidth in the results
since it can differ between platforms.

transitions/font-family-during-transition-expected.txt:
transitions/font-family-during-transition.html:

7:42 PM Changeset in webkit [61101] by weinig@apple.com

3 edits in trunk/WebCore

Try and fix the chrome build.

bindings/scripts/CodeGeneratorV8.pm:
xml/XMLHttpRequest.idl:

7:27 PM Changeset in webkit [61100] by weinig@apple.com

16 edits
3 adds
2 deletes in trunk

WebCore: Fix for https://bugs.webkit.org/show_bug.cgi?id=40550
XMLHttpRequest constructor object should expose the constants from the IDL.

Reviewed by Anders Carlsson.

Test: fast/dom/XMLHttpRequest-constants.html

Android.jscbindings.mk:
CMakeLists.txt:
GNUmakefile.am:
WebCore.gypi:
WebCore.pro:
WebCore.vcproj/WebCore.vcproj:
WebCore.xcodeproj/project.pbxproj:
bindings/js/JSBindingsAllInOne.cpp:
bindings/js/JSDOMWindowCustom.cpp:
bindings/js/JSWorkerContextCustom.cpp:
bindings/js/JSXMLHttpRequestConstructor.cpp: Removed.
bindings/js/JSXMLHttpRequestConstructor.h: Removed.
bindings/js/JSXMLHttpRequestCustom.cpp:

(WebCore::JSXMLHttpRequestConstructor::constructJSXMLHttpRequest):

bindings/scripts/CodeGeneratorJS.pm:
xml/XMLHttpRequest.idl:

LayoutTests: Update tests for https://bugs.webkit.org/show_bug.cgi?id=40550
XMLHttpRequest constructor object should expose the constants from the IDL.

Reviewed by Anders Carlsson.

fast/dom/Window/window-properties-expected.txt:
fast/dom/XMLHttpRequest-constants-expected.txt: Added.
fast/dom/XMLHttpRequest-constants.html: Added.
fast/dom/script-tests/XMLHttpRequest-constants.js: Added.

6:47 PM Changeset in webkit [61099] by Simon Fraser

4 edits
2 adds in trunk

2010-06-13 Simon Fraser <Simon Fraser>

Reviewed by Dan Bernstein.

-webkit-transition font-size and font-family
https://bugs.webkit.org/show_bug.cgi?id=33429

When animating font-size, update the font with a saved
version of the font selector to ensure that we don't clobber
the font family.

Test: transitions/font-family-during-transition.html

rendering/style/RenderStyle.cpp: (WebCore::RenderStyle::setBlendedFontSize):

6:37 PM Changeset in webkit [61098] by eric@webkit.org

6 edits
1 add in trunk/WebKitTools

2010-06-13 Adam Barth <abarth@webkit.org>

Reviewed by Darin Adler.

webkit-patch should add a bug URL to ChangeLogs if they don't have one yet
https://bugs.webkit.org/show_bug.cgi?id=39550

This can cause an extra request to bugs.webkit.org durig upload, but it
shouldn't be too bad. Also, this won't work if you remove the
boilerplate created by prepare-ChangeLog.

Scripts/webkitpy/common/checkout/changelog.py:
Scripts/webkitpy/common/checkout/changelog_unittest.py:
Scripts/webkitpy/common/net/bugzilla.py:
Scripts/webkitpy/tool/steps/abstractstep.py:
Scripts/webkitpy/tool/steps/preparechangelog.py:
Scripts/webkitpy/tool/steps/preparechangelog_unittest.py: Added.

5:58 PM Changeset in webkit [61097] by tony@chromium.org

5 edits in trunk

2010-06-13 Tony Chang <tony@chromium.org>

Build fix, not reviewed.

fix chromium compile after r61094 (id attribute refactor)
https://bugs.webkit.org/show_bug.cgi?id=40553

bindings/v8/custom/V8NamedNodesCollection.cpp: (WebCore::V8NamedNodesCollection::itemWithName):

2010-06-13 Tony Chang <tony@chromium.org>

Build fix, not reviewed.

fix chromium compile after r61094 (id attribute refactor)
https://bugs.webkit.org/show_bug.cgi?id=40553

src/ChromeClientImpl.cpp:
src/WebFormControlElement.cpp: (WebKit::WebFormControlElement::nameForAutofill):

12:01 PM Changeset in webkit [61096] by Darin Adler

5 edits in trunk/LayoutTests

Updated Windows-platform results for the fix for bug 40394.
The patch fixed the cross-platform results, GTK results, and Qt results,
but there were Windows results too.

platform/win/fast/dom/Window/window-property-descriptors-expected.txt:
platform/win/fast/dom/prototype-inheritance-2-expected.txt:
platform/win/fast/dom/prototype-inheritance-expected.txt:
platform/win/fast/js/global-constructors-expected.txt:

10:50 AM Changeset in webkit [61095] by Darin Adler

1 edit in trunk/WebCore/ChangeLog

Partly done support for alternate ID attributes should be removed
https://bugs.webkit.org/show_bug.cgi?id=39692

Reviewed by Alexey Proskuryakov.

Removed the include of "HTMLNames.h" from "Element.h". This prevents
near-world-rebuilds every time you change HTMLTagNames.in.

Renamed the getIDAttribute function in the Element class to
idForStyleResolution, since it returns a value of the id attribute
that has been lowercased as appropriate for style matching, not the
actual value of the attribute. With the old name it was easy to
misuse it in non-style contexts.

Got rid of the idAttributeName function on Element, since it is
easy to use it wrong. Replace it with isIdAttributeName, getIdAttribute,
and setIdAttribute functions, which are a good fit for the needs of
most call sites that were dealing with the id attribute.

Added an idAttributeName function to Document. This is for a future
where a document can have a custom id attribute name specified in its
doctype. It's possible this will be insufficient because the same
document might have XHTML or SVG elements in it, and it's possible
that on those elements we will want the attribute named "id" with
no namespace to still work. We can deal with that when we implement
the actual feature, though. For now, it seems OK to fetch the name
of the id attribute from the document.

dom/DynamicNodeList.cpp:

(WebCore::DynamicNodeList::itemWithName):

dom/StaticNodeList.cpp:

(WebCore::StaticNodeList::itemWithName):

rendering/RenderSVGResourceContainer.h:

(WebCore::RenderSVGResourceContainer::RenderSVGResourceContainer):
(WebCore::RenderSVGResourceContainer::idChanged):

svg/SVGUseElement.cpp:

(WebCore::SVGUseElement::handleDeepUseReferencing):

svg/animation/SMILTimeContainer.cpp:

(WebCore::SMILTimeContainer::updateAnimations):
Use the new idForStyleResolution function, which is the new name of
the getIDAttribute function. There's a good chance these call sites are
incorrect, which is something we should investigate later, so there's
a FIXME at each call site.

dom/Document.cpp:

(WebCore::Document::Document): Initialize m_idAttributeName to the
standard id attribute from HTML.
(WebCore::Document::getElementById): Use Element::getIdAttribute.

dom/Document.h: Added Document::idAttributeName.

dom/Element.cpp:

(WebCore::Element::setAttribute): Use Document::idAttributeName.
(WebCore::Element::setAttributeMap): Use Element::isIdAttributeName.
(WebCore::Element::insertedIntoDocument): Use Document::idAttributeName.
(WebCore::Element::removedFromDocument): Ditto.
(WebCore::Element::formatForDebugger): Use Element::getIdAttribute.

dom/Element.h: Added isIdAttributeName, getIdAttribute, setIdAttribute,

idForStyleResolution. Removed rareIDAttributeName.

dom/ElementRareData.h: Removed m_idAttributeName.

dom/NamedNodeMap.cpp:

(WebCore::NamedNodeMap::setAttributes): Use Document::idAttributeName.

dom/NamedNodeMap.h: Renamed id, setID, and m_id to idForStyleResolution,

setIdForStyleResolution, and m_idForStyleResolution since this is not the
value of the id attribute because it gets lowercased for compatibility-mode
documents.

rendering/RenderIFrame.cpp:
rendering/RenderLayerCompositor.cpp:
rendering/RenderProgress.cpp:

Added include of HTMLNames.h now that Element.h no longer includes it.

editing/SetNodeAttributeCommand.h:
editing/markup.cpp:
html/HTMLParser.cpp:

Removed unneeded includes.

html/HTMLParser.h: Sorted includes.

css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::matchRules): Use idForStyleResolution.
(WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector): Use idForStyleResolution.

dom/Attr.cpp:

(WebCore::Attr::isId): Use Document::idAttributeName.

dom/StyledElement.cpp:

(WebCore::StyledElement::parseMappedAttribute): Use isIdAttributeName,
and setIdForStyleResolution.

editing/DeleteButtonController.cpp:

(WebCore::DeleteButtonController::createDeletionUI): Use setIdAttribute.

editing/EditorCommand.cpp:

(WebCore::executeInsertHorizontalRule): Ditto.

html/HTMLAppletElement.cpp:

(WebCore::HTMLAppletElement::parseMappedAttribute): Use isIdAttributeName.
(WebCore::HTMLAppletElement::createRenderer): Use getIdAttribute.

html/HTMLCollection.cpp:

(WebCore::HTMLCollection::checkForNameMatch): Use getIdAttribute.
(WebCore::HTMLCollection::updateNameCache): Use getIdAttribute.

html/HTMLDataGridColElement.cpp:

(WebCore::HTMLDataGridColElement::ensureColumn): Use getIdAttribute.
(WebCore::HTMLDataGridColElement::parseMappedAttribute): Use isIdAttributeName.

html/HTMLElement.cpp:

(WebCore::HTMLElement::parseMappedAttribute): Use isIdAttributeName.

html/HTMLFormCollection.cpp:

(WebCore::HTMLFormCollection::nextNamedItem): Added missing braces.
(WebCore::HTMLFormCollection::updateNameCache): Use getIdAttribute.

html/HTMLFrameElementBase.cpp:

(WebCore::HTMLFrameElementBase::parseMappedAttribute): Use isIdAttributeName.
(WebCore::HTMLFrameElementBase::setName): Use getIdAttribute.

html/HTMLImageElement.cpp:

(WebCore::HTMLImageElement::parseMappedAttribute): Use isIdAttributeName.

html/HTMLMapElement.cpp:

(WebCore::HTMLMapElement::parseMappedAttribute): Use isIdAttributeName.
Also restructured the function a bit to make its structure clearer and added
a comment pointing out that it can't be quite right.

html/HTMLNameCollection.cpp:

(WebCore::HTMLNameCollection::itemAfter): Use getIdAttribute.

html/HTMLObjectElement.cpp:

(WebCore::HTMLObjectElement::parseMappedAttribute): Use isIdAttributeName.

html/HTMLParamElement.cpp:

(WebCore::HTMLParamElement::parseMappedAttribute): Use isIdAttributeName.

loader/CachedFont.cpp:

(WebCore::CachedFont::getSVGFontById): Use getIdAttribute.

rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::nameForLayer): Use getIdAttribute.

rendering/SVGRenderTreeAsText.cpp:

(WebCore::writeSVGPaintingResource): Use getIdAttribute.
(WebCore::writeSVGResourceContainer): Ditto.

svg/SVGElement.cpp:

(WebCore::SVGElement::insertedIntoDocument): Use getIdAttribute.

svg/SVGStyledElement.cpp:

(WebCore::SVGStyledElement::isKnownAttribute): Use isIdAttributeName.
(WebCore::SVGStyledElement::svgAttributeChanged): Use isIdAttributeName.

wml/WMLElement.cpp:

(WebCore::WMLElement::parseMappedAttribute): Use isIdAttributeName.

10:29 AM Changeset in webkit [61094] by Darin Adler

45 edits in trunk/WebCore

2010-06-12 Darin Adler <Darin Adler>

Reviewed by Alexey Proskuryakov.

Partly done support for alternate ID attributes should be removed
https://bugs.webkit.org/show_bug.cgi?id=39692

Removed the include of "HTMLNames.h" from "Element.h". This prevents
near-world-rebuilds every time you change HTMLTagNames.in.

Renamed the getIDAttribute function in the Element class to
idForStyleResolution, since it returns a value of the id attribute
that has been lowercased as appropriate for style matching, not the
actual value of the attribute. With the old name it was easy to
misuse it in non-style contexts.

Got rid of the idAttributeName function on Element, since it is
easy to use it wrong. Replace it with isIdAttributeName, getIdAttribute,
and setIdAttribute functions, which are a good fit for the needs of
most call sites that were dealing with the id attribute.

Added an idAttributeName function to Document. This is for a future
where a document can have a custom id attribute name specified in its
doctype. It's possible this will be insufficient because the same
document might have XHTML or SVG elements in it, and it's possible
that on those elements we will want the attribute named "id" with
no namespace to still work. We can deal with that when we implement
the actual feature, though. For now, it seems OK to fetch the name
of the id attribute from the document.

dom/DynamicNodeList.cpp: (WebCore::DynamicNodeList::itemWithName):
dom/StaticNodeList.cpp: (WebCore::StaticNodeList::itemWithName):
rendering/RenderSVGResourceContainer.h: (WebCore::RenderSVGResourceContainer::RenderSVGResourceContainer): (WebCore::RenderSVGResourceContainer::idChanged):
svg/SVGUseElement.cpp: (WebCore::SVGUseElement::handleDeepUseReferencing):
svg/animation/SMILTimeContainer.cpp: (WebCore::SMILTimeContainer::updateAnimations): Use the new idForStyleResolution function, which is the new name of the getIDAttribute function. There's a good chance these call sites are incorrect, which is something we should investigate later, so there's a FIXME at each call site.

dom/Document.cpp: (WebCore::Document::Document): Initialize m_idAttributeName to the standard id attribute from HTML. (WebCore::Document::getElementById): Use Element::getIdAttribute.
dom/Document.h: Added Document::idAttributeName.

dom/Element.cpp: (WebCore::Element::setAttribute): Use Document::idAttributeName. (WebCore::Element::setAttributeMap): Use Element::isIdAttributeName. (WebCore::Element::insertedIntoDocument): Use Document::idAttributeName. (WebCore::Element::removedFromDocument): Ditto. (WebCore::Element::formatForDebugger): Use Element::getIdAttribute.
dom/Element.h: Added isIdAttributeName, getIdAttribute, setIdAttribute, idForStyleResolution. Removed rareIDAttributeName.

dom/ElementRareData.h: Removed m_idAttributeName.

dom/NamedNodeMap.cpp: (WebCore::NamedNodeMap::setAttributes): Use Document::idAttributeName.
dom/NamedNodeMap.h: Renamed id, setID, and m_id to idForStyleResolution, setIdForStyleResolution, and m_idForStyleResolution since this is not the value of the id attribute because it gets lowercased for compatibility-mode documents.

rendering/RenderIFrame.cpp:
rendering/RenderLayerCompositor.cpp:
rendering/RenderProgress.cpp: Added include of HTMLNames.h now that Element.h no longer includes it.

editing/SetNodeAttributeCommand.h:
editing/markup.cpp:
html/HTMLParser.cpp: Removed unneeded includes.

html/HTMLParser.h: Sorted includes.

css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::matchRules): Use idForStyleResolution. (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector): Use idForStyleResolution.
dom/Attr.cpp: (WebCore::Attr::isId): Use Document::idAttributeName.
dom/StyledElement.cpp: (WebCore::StyledElement::parseMappedAttribute): Use isIdAttributeName, and setIdForStyleResolution.
editing/DeleteButtonController.cpp: (WebCore::DeleteButtonController::createDeletionUI): Use setIdAttribute.
editing/EditorCommand.cpp: (WebCore::executeInsertHorizontalRule): Ditto.
html/HTMLAppletElement.cpp: (WebCore::HTMLAppletElement::parseMappedAttribute): Use isIdAttributeName. (WebCore::HTMLAppletElement::createRenderer): Use getIdAttribute.
html/HTMLCollection.cpp: (WebCore::HTMLCollection::checkForNameMatch): Use getIdAttribute. (WebCore::HTMLCollection::updateNameCache): Use getIdAttribute.
html/HTMLDataGridColElement.cpp: (WebCore::HTMLDataGridColElement::ensureColumn): Use getIdAttribute. (WebCore::HTMLDataGridColElement::parseMappedAttribute): Use isIdAttributeName.
html/HTMLElement.cpp: (WebCore::HTMLElement::parseMappedAttribute): Use isIdAttributeName.
html/HTMLFormCollection.cpp: (WebCore::HTMLFormCollection::nextNamedItem): Added missing braces. (WebCore::HTMLFormCollection::updateNameCache): Use getIdAttribute.
html/HTMLFrameElementBase.cpp: (WebCore::HTMLFrameElementBase::parseMappedAttribute): Use isIdAttributeName. (WebCore::HTMLFrameElementBase::setName): Use getIdAttribute.
html/HTMLImageElement.cpp: (WebCore::HTMLImageElement::parseMappedAttribute): Use isIdAttributeName.
html/HTMLMapElement.cpp: (WebCore::HTMLMapElement::parseMappedAttribute): Use isIdAttributeName. Also restructured the function a bit to make its structure clearer and added a comment pointing out that it can't be quite right.
html/HTMLNameCollection.cpp: (WebCore::HTMLNameCollection::itemAfter): Use getIdAttribute.
html/HTMLObjectElement.cpp: (WebCore::HTMLObjectElement::parseMappedAttribute): Use isIdAttributeName.
html/HTMLParamElement.cpp: (WebCore::HTMLParamElement::parseMappedAttribute): Use isIdAttributeName.
loader/CachedFont.cpp: (WebCore::CachedFont::getSVGFontById): Use getIdAttribute.
rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::nameForLayer): Use getIdAttribute.
rendering/SVGRenderTreeAsText.cpp: (WebCore::writeSVGPaintingResource): Use getIdAttribute. (WebCore::writeSVGResourceContainer): Ditto.
svg/SVGElement.cpp: (WebCore::SVGElement::insertedIntoDocument): Use getIdAttribute.
svg/SVGStyledElement.cpp: (WebCore::SVGStyledElement::isKnownAttribute): Use isIdAttributeName. (WebCore::SVGStyledElement::svgAttributeChanged): Use isIdAttributeName.
wml/WMLElement.cpp: (WebCore::WMLElement::parseMappedAttribute): Use isIdAttributeName.

10:22 AM Changeset in webkit [61093] by mitz@apple.com

2 edits in trunk/LayoutTests

Updated results after r61092.

fast/events/continuous-platform-wheelevent-in-scrolling-div-expected.txt:

9:40 AM Changeset in webkit [61092] by mitz@apple.com

2 edits in trunk/WebCore

<rdar://problem/8087385> REGRESSION (r60974): Continuous wheel scrolling is too fast in list boxes and in Safari Reader
https://bugs.webkit.org/show_bug.cgi?id=40537

Reviewed by Darin Adler.

platform/mac/WheelEventMac.mm:

(WebCore::PlatformWheelEvent::PlatformWheelEvent): Only multiply by pixelsPerLineStep() if the
event is not continuous, as was before r56012.

6:54 AM Changeset in webkit [61091] by abecsi@webkit.org

18 edits
1 add
1 delete in trunk

Centralize the gperf code generation commands into make-hash-tools.pl
to avoid redundancy across multiple build systems.
Do this in preparation of refactoring the usage of these generated
sources to fix the debug linking error on Linux with gcc >= 4.4.0.

WebCore:

Reviewed by Darin Adler.

webkit.org/b/29244

No functionality change, so no new tests needed.

DerivedSources.make:
GNUmakefile.am:
WebCore.gyp/WebCore.gyp:
WebCore.gyp/scripts/rule_gperf.py: Removed.
WebCore.pri:
WebCore.xcodeproj/project.pbxproj:
css/CSSParser.cpp:

(WebCore::cssPropertyID):
(WebCore::cssValueKeywordID):

css/makeprop.pl:
css/makevalues.pl:
html/DocTypeStrings.gperf:
html/HTML5EntityParser.cpp:
html/HTMLDocumentParser.cpp:
html/HTMLEntityNames.gperf:
html/PreloadScanner.cpp:
make-hash-tools.pl: Added.
platform/ColorData.gperf:
platform/graphics/Color.cpp:

WebKit/chromium:

Patch by Andras Becsi <abecsi@inf.u-szeged.hu> on 2010-06-13
Reviewed by Darin Adler.

webkit.org/b/29244

src/WebEntities.cpp:

6:29 AM Changeset in webkit [61090] by robert@webkit.org

8 edits in trunk

2010-06-08 Robert Hogan <robert@webkit.org>

Reviewed by Eric Seidel.

[Qt] Add support for callShouldCloseOnWebView() to DRT
https://bugs.webkit.org/show_bug.cgi?id=40330

platform/qt/Skipped: Unskip fast/events/onbeforeunload-focused-iframe.html

2010-06-08 Robert Hogan <robert@webkit.org>

Reviewed by Eric Seidel.

[Qt] Add support for callShouldCloseOnWebView() to DRT
https://bugs.webkit.org/show_bug.cgi?id=40330

WebCoreSupport/DumpRenderTreeSupportQt.cpp: (DumpRenderTreeSupportQt::shouldClose):
WebCoreSupport/DumpRenderTreeSupportQt.h:

2010-06-08 Robert Hogan <robert@webkit.org>

Reviewed by Eric Seidel.

[Qt] Add support for callShouldCloseOnWebView() to DRT
https://bugs.webkit.org/show_bug.cgi?id=40330

DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::callShouldCloseOnWebView):
DumpRenderTree/qt/LayoutTestControllerQt.h: (LayoutTestController::setCallCloseOnWebViews):

6:05 AM Changeset in webkit [61089] by eric@webkit.org

4 edits in trunk/WebCore

2010-06-13 Noam Rosenthal <noam.rosenthal@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] tests/hybridPixmap fails
https://bugs.webkit.org/show_bug.cgi?id=37316

The problem was that JSC::Instance::createRuntimeObject was never called.
This is fixed by overloading newRuntimeObject and calling Instance::createRuntimeObject
in between, instead of creating the runtime object directly inside the static function
QtPixmapInstance::createRuntimeObject, which had to be renamed as to not overshadow the virtual function.

This fixes an existing test, tests/hybridPixmap

bridge/qt/qt_pixmapruntime.cpp: (JSC::Bindings::QtPixmapInstance::newRuntimeObject): (JSC::Bindings::QtPixmapInstance::createPixmapRuntimeObject):
bridge/qt/qt_pixmapruntime.h:
bridge/qt/qt_runtime.cpp: (JSC::Bindings::convertQVariantToValue):

2:11 AM Changeset in webkit [61088] by adachan@apple.com

3 edits in trunk/WebKit2

Unreviewed fix for a linking error with WebKit2LocalizableStringsBundle for Windows release build.

WebProcess/win/WebLocalizableStrings.cpp: (findCachedString):

1:33 AM Changeset in webkit [61087] by eric@webkit.org

3 edits in trunk/WebCore

2010-06-13 Noam Rosenthal <noam.rosenthal@nokia.com>

Reviewed by Darin Adler.

GraphicsContext3D.h in the Qt port includes too many unnecessary files
https://bugs.webkit.org/show_bug.cgi?id=40536

Removed unncessary includes.

No new tests; Compilation improvement.

platform/graphics/GraphicsContext3D.h:
platform/graphics/qt/GraphicsContext3DQt.cpp:

1:20 AM Changeset in webkit [61086] by eric@webkit.org

2 edits in trunk/WebCore

2010-06-13 Noam Rosenthal <noam.rosenthal@nokia.com>

Reviewed by Eric Seidel.

[Qt] GraphicsLayer: recaching images creates an unnecessary deep copy
https://bugs.webkit.org/show_bug.cgi?id=40535

Made sure the painter ends its operation before copying the pixmap.

No new tests: this is an optimization.

platform/graphics/qt/GraphicsLayerQt.cpp: (WebCore::GraphicsLayerQtImpl::recache):

12:54 AM Changeset in webkit [61085] by eric@webkit.org

2 edits in trunk/WebCore

2010-06-13 Clemmitt Sigler <cmsigler@gmail.com>

Reviewed by Eric Seidel.

Patch to fix missing references to RenderMathMLRoot,
RenderMathMLSquareRoot when building GtkLauncher.
https://bugs.webkit.org/show_bug.cgi?id=40326

Context Navigation

Timeline

Jun 14, 2010:

Jun 13, 2010:

Download in other formats: