⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Jun 15, 2010:

11:51 PM Changeset in webkit [61235] by abarth@webkit.org
  • 7 edits in trunk/LayoutTests

2010-06-15 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Enable HTML5 lexer
​https://bugs.webkit.org/show_bug.cgi?id=40650

Change some tests not to rely upon <script/>. We already cover that
case in parsing tests.

  • fast/lists/ol-nested-items-dynamic-insert.html:
  • fast/lists/ol-nested-items-dynamic-remove.html:
  • fast/lists/ol-nested-items.html:
  • fast/lists/ol-nested-list-dynamic-insert.html:
  • fast/lists/ol-nested-list-dynamic-remove.html:
  • fast/lists/ol-nested-list.html:
11:27 PM Changeset in webkit [61234] by abarth@webkit.org
  • 47 edits in trunk

2010-06-15 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Enable HTML5 lexer
​https://bugs.webkit.org/show_bug.cgi?id=40650

  • page/Settings.cpp: (WebCore::Settings::Settings):

2010-06-15 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Enable HTML5 lexer
​https://bugs.webkit.org/show_bug.cgi?id=40650

This patch updates the expected results for tests that conflict with
the HTML5 specification. In a later patch, I'll update the tests
themselves to fix pass/fail messages.

  • fast/doctypes/005-case-preserving-expected.txt:
    • HTML5 specifies case normalization for DOCTYPEs.
  • fast/js/missing-title-end-tag-js-expected.txt:
    • HTML5 requires us to swallow the entire document when <title> is unterminated.
  • fast/parser/comment-in-iframe-expected.txt:
  • fast/parser/comment-in-script-tricky-expected.txt:
  • fast/parser/comment-in-title-expected.txt:
  • fast/parser/comments-expected.txt:
    • Differences due to HTML5 comment parsing.
  • fast/parser/eightdigithexentity-expected.txt:
    • HTML5 specifies a different behavior for &#x00FFFFFF;
  • fast/parser/entity-end-iframe-tag-expected.txt:
    • HTML5 specifies a different behavior for &lt;/iframe>
  • fast/parser/entity-surrogate-pairs-expected.txt:
    • HTML5 doesn't allow entities to create surrogate pairs.
  • fast/parser/html-whitespace-expected.txt:
    • HTML5 has a different handling of CR in this case.
  • fast/parser/script-tag-with-trailing-slash-expected.txt:
    • HTML5 does not allow self-closing <script/> tags.
  • fast/parser/tag-with-exclamation-point-expected.txt:
    • HTML5 treats bogus DOCTYPEs as comments.
  • fast/parser/xml-directive-in-dom-expected.txt:
    • HTML5 attaches <?xml?> processing directives to the DOM as comments.
  • fast/xpath/xpath-functional-test-expected.txt:
    • I don't fully understand this test, but our new behavior matches the Firefox nightly builds (which have an HTML5 parser).
  • html5lib/runner-expected.txt:
  • html5lib/webkit-resumer-expected.txt:
    • Massive progressions on HTML5 conformance.
  • http/tests/loading/gmail-assert-on-load-expected.txt:
    • I don't fully understand this behavior change. It might represent a bug. We're still investigating.
  • http/tests/security/xssAuditor/embed-tag-null-char-expected.txt:
    • Update expected results for change in NULL char handling.
  • http/tests/security/xssAuditor/img-onerror-tricky-expected.txt:
    • This exploit no longer works in the HTML5 parser, so it's not blocked.
  • http/tests/security/xssAuditor/javascript-link-HTML-entities-null-char-expected.txt:
    • This a real regression. We need to update the XSSAuditor to use the HTML5 parser's HTML entity decoder. I'll do that in a followup patch because there doesn't appear to be an easy way to key the choice off of the WebCore::Setting.
  • http/tests/security/xssAuditor/malformed-HTML-expected.txt:
    • Slightly different handling of malformed HTML. The exploit is still blocked.
  • http/tests/security/xssAuditor/object-embed-tag-null-char-expected.txt:
    • Update expected result due to different NULL character handling.
  • inspector/audits-panel-functional-expected.txt:
  • inspector/timeline-script-tag-1-expected.txt:
    • Slightly different semantics around document.write.
  • inspector/elements-panel-structure-expected.txt:
    • HTML5 specifies case normalization for DOCTYPEs.
  • platform/mac/css1/box_properties/float_elements_in_series-expected.txt:
    • HTML5 specifies different handling of "<foo<bar"
  • platform/mac/fast/doctypes/003-expected.txt:
    • HTML5 specifies case normalization for DOCTYPEs.
  • platform/mac/fast/dom/stripNullFromTextNodes-expected.txt:
    • HTML5 specifies different handling of NULL characters.
  • platform/mac/fast/invalid/016-expected.txt:
    • HTML5 specifies different handling of "<foo<bar"
  • platform/mac/fast/parser/broken-comments-vs-parsing-mode-expected.txt:
    • HTML5 specifies different handling of HTML comments.
  • platform/mac/fast/parser/comment-in-style-expected.txt:
    • HTML5 specifies different handling of HTML comments.
  • platform/mac/fast/parser/parseCommentsInTitles-expected.txt:
    • HTML5 specifies different handling of HTML comments.
  • platform/mac/fast/text/international/bidi-linebreak-001-expected.txt:
  • platform/mac/fast/text/international/bidi-linebreak-002-expected.txt:
  • platform/mac/fast/text/international/bidi-linebreak-003-expected.txt:
  • platform/mac/fast/text/international/hindi-whitespace-expected.txt:
    • HTML5 specifies different handling CR. I don't fully understand the consequences of this change, but our new behavior matches the Firefox nightly.
  • platform/mac/fast/text/stripNullFromText-expected.txt:
    • HTML5 specifies different handling of NULL characters.
  • platform/mac/fast/tokenizer/missing-title-end-tag-1-expected.txt:
  • platform/mac/fast/tokenizer/missing-title-end-tag-2-expected.txt:
    • HTML5 requires us to swallow the entire document when <title> is unterminated.
  • platform/mac/fast/tokenizer/script_extra_close-expected.txt:
    • We're coalescing text nodes slightly different in the new parser. We're going to get this up to spec when we work on the TreeConstructor (which is where the spec handles text node coalescing).
  • platform/mac/tables/mozilla/images/adforce_imgis_com-expected.txt:
    • Different handling of crazy unicode characters (replaced with FFFD). Still investigating whether this is a real bug.
  • webarchive/archive-empty-frame-dom-expected.webarchive:
    • HTML5 specifies case normalization for DOCTYPEs.

2010-06-15 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Enable HTML5 lexer
​https://bugs.webkit.org/show_bug.cgi?id=40650

  • DumpRenderTree/mac/DumpRenderTree.mm: (initializeGlobalsFromCommandLineOptions):
9:50 PM Changeset in webkit [61233] by mrowe@apple.com
  • 2 edits in trunk/WebKit/mac

Don't leak WebGeolocationPositionInternal and GeolocationPosition instances for every WebGeolocationPosition created.

Reviewed by Sam Weinig.

  • WebView/WebGeolocationPosition.mm:

(-[WebGeolocationPosition dealloc]): Implement -dealloc and release our WebGeolocationPositionInternal instance.

8:23 PM Changeset in webkit [61232] by yuzo@google.com
  • 26 edits
    2 adds in trunk

2010-06-15 Dmitry Titov <​dimich@chromium.org>

Not reviewed, updating Chromium test expectations.

  • platform/chromium/test_expectations.txt:

2010-06-15 Mark Rowe <​mrowe@apple.com>

Rubber-stamped by David Harrison.

sqlite3_prepare16_v2 is not documented as always setting "tail" during error cases.
Explicitly initialize it to null, just to be safe.

  • platform/sql/SQLiteStatement.cpp: (WebCore::SQLiteStatement::prepare):

2010-06-10 Yuzo Fujishima <​yuzo@google.com>

Reviewed by Shinichiro Hamaji.

Implement render style selection for pages to support CSS3 Paged Media.
​https://bugs.webkit.org/show_bug.cgi?id=35961

  • Misc/WebCoreStatistics.h:
  • Misc/WebCoreStatistics.mm: (-[WebFrame pageProperty:propertyName:]):

2010-06-10 Yuzo Fujishima <​yuzo@google.com>

Reviewed by Shinichiro Hamaji.

Implement render style selection for pages to support CSS3 Paged Media.
​https://bugs.webkit.org/show_bug.cgi?id=35961

  • DumpRenderTree/LayoutTestController.cpp: (parsePagePropertyParameters): (pagePropertyCallback): (LayoutTestController::staticFunctions):
  • DumpRenderTree/LayoutTestController.h:
  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::pageProperty):
  • DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::pageProperty):
  • DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::pageProperty):
7:27 PM Changeset in webkit [61231] by mrowe@apple.com
  • 2 edits in trunk/WebCore

sqlite3_prepare16_v2 is not documented as always setting "tail" during error cases.
Explicitly initialize it to null, just to be safe.

Rubber-stamped by David Harrison.

  • platform/sql/SQLiteStatement.cpp:

(WebCore::SQLiteStatement::prepare):

7:23 PM Changeset in webkit [61230] by mrowe@apple.com
  • 4 edits in trunk/WebCore

<rdar://problem/8091103> URLs not added to history when initial load happens via back/forward navigation

Reviewed by Brady Eidson.

Back/forward navigation currently does not create or update items in the global history. This is usually
desirable, except for in the event where the back/forward list was created programmatically and attached
to the WebView and the initial load in that WebView is being performed as a result of a back/forward
navigation. In that situation it is preferable to ensure that global history item is created or updated.

No test case is added because DumpRenderTree is not able to test the scenario where the initial
load in a WebView occurs via a back/forward navigation.

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::transitionToCommitted): If we're committing the first load in this frame as a
back/forward navigation then we should update the history as if it were a standard load, with the
exception of updating the back/forward list.

  • loader/HistoryController.cpp:

(WebCore::HistoryController::updateForStandardLoad): Add a parameter to allow callers to skip updating
the back/forward list.

  • loader/HistoryController.h:

(WebCore::HistoryController::):

6:07 PM Changeset in webkit [61229] by dimich@chromium.org
  • 2 edits in trunk/LayoutTests

Not reviewed, updating Chromium test expectations.

  • platform/chromium/test_expectations.txt:
5:45 PM Changeset in webkit [61228] by weinig@apple.com
  • 4 edits in trunk/WebKit2

Fix for <rdar://problem/8010805>
Assertion failure ("mainThreadPthread") in isMainThread() mousing over cnn.com in Mini Browser

Reviewed by Anders Carlsson.

Don't use WebCore::String::operator NSString*() from the UIProcess, since it uses
StringImpl::createCFString() which expects to be called from WebCore's main thread.

  • UIProcess/API/mac/PageClientImpl.h:
  • UIProcess/API/mac/PageClientImpl.mm:

(WebKit::nsStringFromWebCoreString):
(WebKit::PageClientImpl::toolTipChanged):

  • UIProcess/API/mac/WKView.mm:

(-[WKView view:stringForToolTip:point:userData:]):

5:19 PM Changeset in webkit [61227] by dimich@chromium.org
  • 2 edits in trunk/LayoutTests

Not reviewed, updating Chromium test expectations.

  • platform/chromium/test_expectations.txt:
4:42 PM Changeset in webkit [61226] by Simon Fraser
  • 2 edits in trunk/WebCore

2010-06-15 Simon Fraser <Simon Fraser>

Fix crashing tests; need to check for null documentElement().

  • rendering/RenderView.cpp: (WebCore::RenderView::paintBoxDecorations):
4:36 PM Changeset in webkit [61225] by kinuko@chromium.org
  • 3 edits in trunk/WebCore

2010-06-15 Kinuko Yasuda <​kinuko@chromium.org>

Reviewed by David Levin.

Fix compilation errors in BlobBuilder with FILE_WRITER enabled
​https://bugs.webkit.org/show_bug.cgi?id=40606

No functionality change so no new tests.

  • html/BlobBuilder.cpp:
  • html/BlobBuilder.h:
4:35 PM Changeset in webkit [61224] by xan@webkit.org
  • 2 edits in trunk/WebKit/gtk

2010-06-15 Xan Lopez <​xlopez@igalia.com>

Fix compilation with older GTK+.

  • WebCoreSupport/ChromeClientGtk.cpp: (WebKit::ChromeClient::pageRect):
4:29 PM Changeset in webkit [61223] by jianli@chromium.org
  • 3 edits in trunk/WebCore

Move type attribute from File.idl to Blob.idl per latest File API spec.
​https://bugs.webkit.org/show_bug.cgi?id=40642

Reviewed by David Levin.

  • html/Blob.idl:
  • html/File.idl:
4:17 PM Changeset in webkit [61222] by weinig@apple.com
  • 24 edits
    17 adds in trunk

Fix for ​https://bugs.webkit.org/show_bug.cgi?id=40630
WebKit2: Add mechanism to inject code into the WebProcess on startup

Reviewed by Anders Carlsson.

Add initial InjectedBundle support.

WebKit2:

  • Shared/CoreIPCSupport/WebProcessMessageKinds.h:

(WebProcessMessage::):
Add new LoadInjectedBundle message kind.

  • UIProcess/API/C/WKContext.cpp:

(toWK):
(WKContextCreate):
(WKContextCreateWithInjectedBundlePath):

  • UIProcess/API/C/WKContext.h:

Rename WKContextCreateWithProcessModel to WKContextCreate and add
WKContextCreateWithInjectedBundlePath for creating a context with
a bundle.

  • UIProcess/WebContext.cpp:

(WebKit::WebContext::WebContext):

  • UIProcess/WebContext.h:

(WebKit::WebContext::create):
(WebKit::WebContext::processModel):
(WebKit::WebContext::bundlePath):

  • UIProcess/WebPageNamespace.cpp:

(WebKit::WebPageNamespace::ensureWebProcess):
(WebKit::WebPageNamespace::reviveIfNecessary):

  • UIProcess/WebProcessManager.cpp:

(WebKit::WebProcessManager::getWebProcess):

  • UIProcess/WebProcessManager.h:
  • UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::create):
(WebKit::WebProcessProxy::WebProcessProxy):

  • UIProcess/WebProcessProxy.h:

Thread the bundle path through process creation.

  • WebProcess/InjectedBundle: Added.
  • WebProcess/InjectedBundle/API: Added.
  • WebProcess/InjectedBundle/API/c: Added.
  • WebProcess/InjectedBundle/API/c/WKBundle.cpp: Added.

(WKBundleSetClient):

  • WebProcess/InjectedBundle/API/c/WKBundle.h: Added.
  • WebProcess/InjectedBundle/API/c/WKBundleAPICast.h: Added.

(WebKit::):
(toWK):
(toRef):

  • WebProcess/InjectedBundle/API/c/WKBundleBase.h: Added.
  • WebProcess/InjectedBundle/API/c/WKBundleInitialize.h: Added.
  • WebProcess/InjectedBundle/InjectedBundle.cpp: Added.

(WebKit::InjectedBundle::InjectedBundle):
(WebKit::InjectedBundle::~InjectedBundle):
(WebKit::InjectedBundle::initializeClient):
(WebKit::InjectedBundle::didCreatePage):

  • WebProcess/InjectedBundle/InjectedBundle.h: Added.

(WebKit::InjectedBundle::create):
Add bundle boilerplate.

  • WebProcess/InjectedBundle/mac: Added.
  • WebProcess/InjectedBundle/mac/InjectedBundleMac.cpp: Added.

(WebKit::InjectedBundle::load):
Load the InjectedBundle using CFBundle.

  • WebProcess/InjectedBundle/win: Added.
  • WebProcess/InjectedBundle/win/InjectedBundleWin.cpp: Added.

(WebKit::pathGetFileName):
(WebKit::directoryName):
(WebKit::InjectedBundle::load):
Load the InjectedBundle using HMODULE.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::WebPage):
Add initial bundle callback for page creation. More to come.

  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::loadInjectedBundle):
(WebKit::WebProcess::didReceiveMessage):

  • WebProcess/WebProcess.h:

(WebKit::WebProcess::injectedBundle):
Load the InjectedBundle on LoadInjectedBundle message.

  • WebKit2.xcodeproj/project.pbxproj:
  • mac/WebKit2.exp:
  • win/WebKit2.vcproj:
  • win/WebKit2Generated.make:

Add the new files.

WebKitTools:

  • MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
  • MiniBrowser/WebBundle-Info.plist: Added.

Add test InjectedBundle to the project.

  • MiniBrowser/mac/AppDelegate.m:

(-[BrowserAppDelegate init]):
Get the path to the WebBundle from the the main bundle and pass it to the new
WKContextCreateWithInjectedBundlePath function.

  • MiniBrowser/mac/BrowserWindowController.m:

(_didChangeProgress):
Fix the build. This has been broken for a while.

  • MiniBrowser/mac/WebBundle: Added.
  • MiniBrowser/mac/WebBundle/WebBundleMain.c: Added.

(_didCreatePage):
(WKBundleInitialize):
Add really basic InjectedBundle.

  • MiniBrowser/win/BrowserView.cpp:

(BrowserView::create):
Switch from WKContextCreateWithProcessModel to WKContextCreate and remove commented out code.

3:47 PM Changeset in webkit [61221] by dumi@chromium.org
  • 2 edits in trunk/WebKitTools

Adding myself to the reviewers list.
​https://bugs.webkit.org/show_bug.cgi?id=40693

Reviewed by Darin Adler.

  • Scripts/webkitpy/common/config/committers.py:
3:44 PM Changeset in webkit [61220] by scherkus@chromium.org
  • 2 edits in trunk/LayoutTests

2010-06-15 Andrew Scherkus <​scherkus@chromium.org>

Unreviewed, updating Chromium test expectations for media layout tests.

  • platform/chromium/test_expectations.txt:
3:33 PM Changeset in webkit [61219] by Darin Adler
  • 2 edits in trunk/WebKit/qt

Fix build.

  • WebCoreSupport/DumpRenderTreeSupportQt.cpp:

(DumpRenderTreeSupportQt::shouldClose): Call loader()->shouldClose().

3:30 PM Changeset in webkit [61218] by dimich@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed, updating Chromium test expectations.

Mark following tests SLOW so they won't fail on TIMEOUT in Debug:
fast/frames/lots-of-iframes.html
fast/frames/lots-of-objects.html

  • platform/chromium/test_expectations.txt:
3:20 PM Changeset in webkit [61217] by Darin Adler
  • 16 edits in trunk

2010-06-15 Darin Adler <Darin Adler>

Reviewed by Adam Barth.

Move functions out of Frame class that were marked "move to Chrome"
​https://bugs.webkit.org/show_bug.cgi?id=39636

  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::dispatchBeforeUnloadEvent): Call shouldClose on FrameLoader instead of going through Frame.

2010-06-15 Darin Adler <Darin Adler>

Reviewed by Adam Barth.

Move functions out of Frame class that were marked "move to Chrome"
​https://bugs.webkit.org/show_bug.cgi?id=39636

  • WebView.cpp: (WebView::shouldClose): Call shouldClose on FrameLoader instead of going through Frame.

2010-06-15 Darin Adler <Darin Adler>

Reviewed by Adam Barth.

Move functions out of Frame class that were marked "move to Chrome"
​https://bugs.webkit.org/show_bug.cgi?id=39636

  • WebFrame.cpp: (wxWebFrame::ShouldClose): Call shouldClose on FrameLoader instead of going through Frame.

2010-06-15 Darin Adler <Darin Adler>

Reviewed by Adam Barth.

Move functions out of Frame class that were marked "move to Chrome"
​https://bugs.webkit.org/show_bug.cgi?id=39636

  • WebView/WebView.mm: (-[WebView shouldClose]): Call shouldClose on FrameLoader instead of going through Frame.

2010-06-15 Darin Adler <Darin Adler>

Reviewed by Adam Barth.

Move functions out of Frame class that were marked "move to Chrome"
​https://bugs.webkit.org/show_bug.cgi?id=39636

Refactoring that does not require new tests.

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::didOpenURL): Call setStatus and setDefaultStatus on DOMWindow rather than going through Frame. (WebCore::FrameLoader::open): Ditto. (WebCore::FrameLoader::continueLoadAfterNavigationPolicy): Call shouldClose on this object instead of going through Frame.
  • page/DOMWindow.cpp: (WebCore::DOMWindow::dispatchAllPendingBeforeUnloadEvents): Call shouldClose on FrameLoader instead of going through Frame. (WebCore::DOMWindow::focus): Moved the code from Frame::focusWindow in here. (WebCore::DOMWindow::blur): Moved the code from Frame::unfocusWindow in here. (WebCore::DOMWindow::close): Moved the code from Frame::scheduleClose in here. (WebCore::DOMWindow::setStatus): Moved the code from Frame::setJSStatusBarText in here. (WebCore::DOMWindow::setDefaultStatus): Moved the code from Frame::setJSDefaultStatusBarText in here.
  • page/DOMWindow.h: Added m_status and m_defaultStatus members to store the status messages being set by the DOM.
  • page/Frame.cpp: Removed all the functions that were marked "to be moved into Chrome".
  • page/Frame.h: Ditto.

2010-06-15 Darin Adler <Darin Adler>

Reviewed by Adam Barth.

Move functions out of Frame class that were marked "move to Chrome"
​https://bugs.webkit.org/show_bug.cgi?id=39636

  • WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::tryClose): Call shouldClose on FrameLoader instead of going through Frame.
3:04 PM Changeset in webkit [61216] by darin@chromium.org
  • 3 edits in trunk/LayoutTests

2010-06-15 Darin Fisher <​darin@chromium.org>

Fix whitespace error in expected results.

Looks like Chromium's TestShell and DRT do not agree in how whitespace
is generated in some cases.

  • fast/history/history-back-within-subframe-expected.txt:
  • platform/chromium/test_expectations.txt:
3:00 PM Changeset in webkit [61215] by Simon Fraser
  • 3 edits
    4 adds in trunk

2010-06-15 Simon Fraser <Simon Fraser>

Reviewed by Dave Hyatt.

Garbage shown outside HTML if HTML is absolutely positioned
​https://bugs.webkit.org/show_bug.cgi?id=36163

Add a check that the root renderer (the document element's renderer) covers
the entire viewport before deciding that we don't need the RenderView
to paint its background. Fixes lack of painting with positioned, floated, and
display: table html elements.

Test: fast/repaint/positioned-document-element.html

  • rendering/RenderView.cpp: (WebCore::RenderView::paintBoxDecorations):
3:00 PM Changeset in webkit [61214] by Simon Fraser
  • 3 edits
    4 adds in trunk

2010-06-15 Simon Fraser <Simon Fraser>

Reviewed by Dan Bernstein.

Safari 5 does not clear background with transformed html element
​https://bugs.webkit.org/show_bug.cgi?id=40498

When the document element is composited, ensure that the FrameView
paints the background, because the composited layer may be transparent,
or might get moved via animation.

Test: compositing/repaint/composited-document-element.html

  • rendering/RenderView.cpp: (WebCore::isComposited): (WebCore::rendererObscuresBackground):
2:48 PM Changeset in webkit [61213] by andersca@apple.com
  • 2 edits in trunk/WebKit/mac

Remove getPluginInfoFromBundleAndMIMEDictionary:

Reviewed by Dan Bernstein.

  • Plugins/WebBasePluginPackage.mm:
2:40 PM Changeset in webkit [61212] by andersca@apple.com
  • 2 edits in trunk/WebKit/mac

Fold getPluginInfoFromBundleAndMIMEDictionary: into its sole caller.

Reviewed by Dan Bernstein.

  • Plugins/WebBasePluginPackage.mm:

(-[WebBasePluginPackage getPluginInfoFromPLists]):

1:57 PM Changeset in webkit [61211] by Martin Robinson
  • 2 edits in trunk/WebKitTools

2010-06-15 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Xan Lopez.

Switch to using GIO methods instead of realpath in GtkLauncher to determine
the file URI. This should remove warnings about realpath being undefined
when compiling with '-ansi'.

  • GtkLauncher/main.c: (filenameToURL): Use GIO instead of realpath to determine file URI.
1:48 PM WebKit Team edited by dumi@chromium.org
(diff)
1:41 PM Changeset in webkit [61210] by darin@chromium.org
  • 1 edit
    1 add in trunk/LayoutTests

2010-06-15 Darin Fisher <​darin@chromium.org>

Adding missing test results.

  • fast/history/history-back-within-subframe-expected.txt: Added.
12:49 PM Changeset in webkit [61209] by xan@webkit.org
  • 2 edits in trunk

2010-06-15 Xan Lopez <​xlopez@igalia.com>

Unreviewed build fix.

Remove GSEAL from the debug config since the bots have a GTK+
version too old, duh.

  • GNUmakefile.am:
12:32 PM Changeset in webkit [61208] by xan@webkit.org
  • 2 edits in trunk/WebCore

2010-06-15 Xan Lopez <​xlopez@igalia.com>

Try to fix GTK+ build.

  • platform/gtk/GtkVersioning.h:
12:31 PM Changeset in webkit [61207] by darin@chromium.org
  • 10 edits
    5 adds in trunk

2010-06-15 Darin Fisher <​darin@chromium.org>

Reviewed by Brady Eidson.

Introduce HistoryItem::itemSequenceNumber and use it to identify
HistoryItems that are clones of one another.

Changes HistoryController::recursiveGoToItem to use itemSequenceNumber
equality instead of isTargetItem as the pre-requisite for not calling
FrameLoader::loadItem.

Changes FrameLoader::loadItem to require equivalent
documentSequenceNumber before initiating a same document navigation.
This alone would appear to fix the bug, but it does not go far enough
since without the itemSequenceNumber equality check, we'd re-load more
often than we should.

Moves documentSequenceNumber assignment into createItemTree as cleanup
and to ensure that it gets called properly whenever we create a cloned
HistoryItem. (createItemTree's mission is to create clones up until
or including the target frame depending on the value of the doClip
parameter.)

Removes the now unused HistoryController::urlsMatchItem.

​https://bugs.webkit.org/show_bug.cgi?id=40451

Test: fast/history/history-back-within-subframe.html

http/tests/navigation/history-back-across-form-submission-to-fragment.html

  • history/HistoryItem.cpp: (WebCore::generateSequenceNumber): (WebCore::HistoryItem::HistoryItem):
  • history/HistoryItem.h: (WebCore::HistoryItem::setItemSequenceNumber): (WebCore::HistoryItem::itemSequenceNumber):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::loadItem):
  • loader/HistoryController.cpp: (WebCore::HistoryController::updateBackForwardListForFragmentScroll): (WebCore::HistoryController::createItemTree): (WebCore::HistoryController::recursiveGoToItem): (WebCore::HistoryController::pushState):
  • loader/HistoryController.h:
12:14 PM Changeset in webkit [61206] by xan@webkit.org
  • 12 edits in trunk

2010-06-15 Xan Lopez <​xlopez@igalia.com>

Reviewed by Gustavo Noronha.

[GTK] Does not compile with -DGSEAL_ENABLE
​https://bugs.webkit.org/show_bug.cgi?id=37851

Add GSEAL_ENABLE flag when doing debug builds.

  • GNUmakefile.am:

WebCore:

2010-06-15 Xan Lopez <​xlopez@igalia.com>

Reviewed by Gustavo Noronha.

[GTK] Does not compile with -DGSEAL_ENABLE
​https://bugs.webkit.org/show_bug.cgi?id=37851

Fix compilation with GSEAL_ENABLE.

  • platform/gtk/GtkVersioning.h:
  • platform/gtk/PlatformScreenGtk.cpp: (WebCore::screenDepth): (WebCore::screenDepthPerComponent):
  • platform/gtk/PopupMenuGtk.cpp: (WebCore::PopupMenu::show):
  • platform/gtk/ScrollbarGtk.cpp: (ScrollbarGtk::detachAdjustment): (ScrollbarGtk::updateThumbPosition): (ScrollbarGtk::updateThumbProportion):
  • plugins/gtk/PluginViewGtk.cpp: (WebCore::PluginView::paint): (WebCore::PluginView::initXEvent): (WebCore::PluginView::platformGetValue): (WebCore::PluginView::platformStart):
  • plugins/gtk/gtk2xtbin.c: (gtk_xtbin_realize): (gtk_xtbin_new): (gtk_xtbin_set_position): (gtk_xtbin_unrealize):

WebKit/gtk:

2010-06-15 Xan Lopez <​xlopez@igalia.com>

Reviewed by Gustavo Noronha.

[GTK] Does not compile with -DGSEAL_ENABLE
​https://bugs.webkit.org/show_bug.cgi?id=37851

Fix compilation with GSEAL_ENABLE.

  • WebCoreSupport/ChromeClientGtk.cpp: (WebKit::ChromeClient::pageRect): (WebKit::ChromeClient::contentsSizeChanged):
  • tests/testdomnode.c: (test_dom_node_insertion):
  • webkit/webkitwebview.cpp: (webkit_web_view_realize): (webkit_web_view_script_dialog): (webkit_web_view_drag_end): (webkit_web_view_init):
11:59 AM Changeset in webkit [61205] by ap@apple.com
  • 1 edit
    4 moves in trunk/LayoutTests

Increase limit on number of (i)frames from 200 to 1000.
​https://bugs.webkit.org/show_bug.cgi?id=39427

Move the right test this time, move remove-iframe-crash back. Oops.

  • compositing/iframes/lots-of-iframes-expected.txt: Removed.
  • compositing/iframes/lots-of-iframes.html: Removed.
  • compositing/iframes/remove-iframe-crash-expected.txt: Copied from fast/frames/remove-iframe-crash-expected.txt.
  • compositing/iframes/remove-iframe-crash.html: Copied from fast/frames/remove-iframe-crash.html.
  • fast/frames/lots-of-iframes-expected.txt: Copied from compositing/iframes/lots-of-iframes-expected.txt.
  • fast/frames/lots-of-iframes.html: Copied from compositing/iframes/lots-of-iframes.html.
  • fast/frames/remove-iframe-crash-expected.txt: Removed.
  • fast/frames/remove-iframe-crash.html: Removed.
11:54 AM Changeset in webkit [61204] by Simon Fraser
  • 2 edits in trunk/WebKit/mac

2010-06-11 Simon Fraser <Simon Fraser>

Reviewed by Darin Adler.

<rdar://problem/8084721> Pages using accelerated compositing fail to update correctly in Carbon apps

The run loop observer used to commit compositing layer changes does not do
updates if [window viewsNeedDisplay] is true, because this indicates that a delayed window
update is pending (added in r58623).

However, Carbon apps don't use the NSWindow updating mechanism, so [window viewsNeedDisplay] always returns YES.
This caused us to never sync compositing layers.

So detect if the current window is wrapping a carbon window, and in that case consult the root
HIView to detect if display is pending.

  • WebView/WebView.mm: (layerSyncRunLoopObserverCallBack):
11:52 AM Changeset in webkit [61203] by andersca@apple.com
  • 3 edits in trunk/JavaScriptCore

Make JavaScriptCore build with clang++.

Reviewed by Sam Weinig.

  • jit/JITInlineMethods.h:

(JSC::JIT::emitPutVirtualRegister):
Explicitly cast to an int.

  • yarr/RegexCompiler.cpp:

(JSC::Yarr::compileRegex):
Return 0 instead of false.

11:48 AM Changeset in webkit [61202] by kbr@google.com
  • 2 edits in trunk/LayoutTests

2010-06-15 Kenneth Russell <​kbr@google.com>

Unreviewed, test fix.

Fix test breakage from 40175
​https://bugs.webkit.org/show_bug.cgi?id=40631

  • fast/canvas/webgl/texture-npot.html:
11:40 AM Changeset in webkit [61201] by xan@webkit.org
  • 2 edits in trunk/WebCore

2010-06-15 Xan Lopez <​xlopez@igalia.com>

Unreviewed build fix.

Fix the build when WebSockets are disabled.

  • bindings/js/JSWorkerContextCustom.cpp:
11:37 AM Changeset in webkit [61200] by Simon Fraser
  • 3 edits
    2 adds in trunk

2010-06-15 Simon Fraser <Simon Fraser>

Reviewed by Dan Bernstein.

YouTube thumbnail borders vanish during transition
​https://bugs.webkit.org/show_bug.cgi?id=40551

Turn off the direct image optimization if the image has a clip style, so that is is
correctly rendered with the clip.

Test: compositing/images/clip-on-directly-composited-image.html

  • rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::isDirectlyCompositedImage):
11:31 AM Changeset in webkit [61199] by ap@apple.com
  • 1 edit
    4 moves in trunk/LayoutTests

Not reviewed, just moving tests.

Increase limit on number of (i)frames from 200 to 1000.
​https://bugs.webkit.org/show_bug.cgi?id=39427

Move the new tests out of compositing directory.

  • compositing/iframes/lots-of-objects-expected.txt: Removed.
  • compositing/iframes/lots-of-objects.html: Removed.
  • compositing/iframes/remove-iframe-crash-expected.txt: Removed.
  • compositing/iframes/remove-iframe-crash.html: Removed.
  • fast/frames/lots-of-objects-expected.txt: Copied from LayoutTests/compositing/iframes/lots-of-objects-expected.txt.
  • fast/frames/lots-of-objects.html: Copied from LayoutTests/compositing/iframes/lots-of-objects.html.
  • fast/frames/remove-iframe-crash-expected.txt: Copied from LayoutTests/compositing/iframes/remove-iframe-crash-expected.txt.
  • fast/frames/remove-iframe-crash.html: Copied from LayoutTests/compositing/iframes/remove-iframe-crash.html.
10:50 AM Changeset in webkit [61198] by yurys@chromium.org
  • 8 edits in trunk

2010-06-15 Yury Semikhatsky <​yurys@chromium.org>

Reviewed by Pavel Feldman.

[v8] Web Inspector: make ui tests pass when ScriptDebugServer is used
​https://bugs.webkit.org/show_bug.cgi?id=40623

  • bindings/v8/JavaScriptCallFrame.cpp: (WebCore::JavaScriptCallFrame::functionName): return empty string for anonymous functions instead of [anonymous].
  • bindings/v8/ScriptDebugServer.cpp: (WebCore::ScriptDebugServer::handleV8DebugEvent): autocontinue on syntax errors since there is no stack trace and not much to inspect.

2010-06-15 Yury Semikhatsky <​yurys@chromium.org>

Reviewed by Pavel Feldman.

[v8] Web Inspector: make ui tests pass when ScriptDebugServer is used
​https://bugs.webkit.org/show_bug.cgi?id=40623

  • src/js/DebuggerAgent.js: (devtools.DebuggerAgent.prototype.formatCallFrame_): return empty function name for anonymous functions.
  • src/js/DebuggerScript.js:
  • src/js/Tests.js: (.TestSuite.prototype.testProfilerTab.findVisibleView): (.TestSuite.prototype.testProfilerTab): (.TestSuite.prototype.testScriptsTabIsPopulatedOnInspectedPageRefresh.waitUntilScriptIsParsed): (.TestSuite.prototype.testSetBreakpoint.this): (.TestSuite.prototype.testSetBreakpoint): (.TestSuite.prototype.testEvalOnCallFrame.waitForBreakpointHit): (.TestSuite.prototype._executeCodeWhenScriptsAreParsed.executeFunctionInInspectedPage): (.TestSuite.prototype.testExpandScope.examineScopes): (.TestSuite.prototype.testExpandScope): (.TestSuite.prototype.testDebugIntrinsicProperties):
10:25 AM Changeset in webkit [61197] by yael.aharon@nokia.com
  • 3 edits in trunk/WebKit/qt

[Qt] Rename NotificatioIconWrapper to NotificationWrapper
​https://bugs.webkit.org/show_bug.cgi?id=40571

Reviewed by Kenneth Rohde Christiansen.

  • WebCoreSupport/NotificationPresenterClientQt.cpp:

(WebCore::NotificationWrapper::NotificationWrapper):
(WebCore::NotificationWrapper::close):
(WebCore::NotificationWrapper::title):
(WebCore::NotificationWrapper::message):
(WebCore::NotificationWrapper::iconData):
(WebCore::NotificationWrapper::notificationClosed):
(WebCore::NotificationPresenterClientQt::displayNotification):
(WebCore::NotificationPresenterClientQt::cancel):
(WebCore::NotificationPresenterClientQt::notificationForWrapper):

  • WebCoreSupport/NotificationPresenterClientQt.h:

(WebCore::NotificationWrapper::~NotificationWrapper):

9:55 AM Changeset in webkit [61196] by Adam Roben
  • 3 edits
    1 delete in trunk

Remove some unnecessary steps for setting up the debugger on Windows

Apparently update-webkit does this for you now.

WebKitSite:

Rubber-stamped by Steve Falkenburg.

  • building/debug.html: Removed the first two Windows steps, which are

now unnecessary, and updated the third to reflect reality.

WebKitTools:

Remove the redundant set-apple-windows-environment-variables script

Apparently update-webkit does this for you these days.

Rubber-stamped by Steve Falkenburg.

  • Scripts/set-apple-windows-environment-variables: Removed.
9:40 AM Changeset in webkit [61195] by Adam Roben
  • 4 edits in trunk

Make WebCore's and JavaScriptCore's DerivedSources available for debugging in production builds

Fixes <​http://webkit.org/b/40626> <rdar://problem/8094205>.

Reviewed by Sam Weinig.

JavaScriptCore:

JavaScriptCore's DerivedSources directory to
AppleInternal/Sources/JavaScriptCore.

WebCore:

  • WebCore.vcproj/WebCore.make: Copy the contents of WebCore's

DerivedSources directory to AppleInternal/Sources/WebCore.

9:40 AM Changeset in webkit [61194] by Adam Roben
  • 2 edits
    3 adds
    2 deletes in trunk/WebKitSite

Improve instructions for debugging on Windows

Fixes <​http://webkit.org/b/40585>.

Reviewed by Steve Falkenburg.

  • building/debug.html: Improved the Windows instructions. We now

instruct users to set things up so that hitting F5 from WebKit.sln
will launch Safari with the WEBKITNIGHTLY environment variable
pointing to the location of the built WebKit.dll.

  • building/console_vs2005.jpg: Removed.
  • building/debug_vs2005.jpg: Removed.
  • building/launch-debugger-vs2005.png: Added.
  • building/set-as-startup-project-vs2005.png: Added.
  • building/set-debugging-properties-vs2005.png: Added.
9:39 AM Changeset in webkit [61193] by Adam Roben
  • 1 edit
    1 add in trunk/WebKitTools

Add a script to set the WebKitOutputDir and WebKitLibrariesDir environment variables

Fixes <​http://webkit.org/b/40595>.

Reviewed by Steve Falkenburg.

  • Scripts/set-apple-windows-environment-variables: Added.

(to_windows_path): Passes the passed-in path through cygpath to
generate a Windows-style path.
(main): Sets the WebKitOutputDir and WebKitLibrariesDir environment
variables to their defaults, if they aren't already set.

9:39 AM Changeset in webkit [61192] by Adam Roben
  • 2 edits in trunk/WebKitTools

Speed up run-safari/debug-safari on Windows

Fixes <​http://webkit.org/b/40586>.

Reviewed by Steve Falkenburg.

  • Scripts/webkitdirs.pm:

(runSafari): When debugging, set up the environment to run Safari
using the built WebKit.dll, then use "devenv /debugexe Safari.exe" to
actually launch the debugger. When not debugging, just run WebKit.exe
and it will do the rest for us.

9:39 AM Changeset in webkit [61191] by Adam Roben
  • 2 edits in trunk/WebKit/win

Add WebKitLauncherWin to WebKit.sln

Fixes <​http://webkit.org/b/40583>.

Reviewed by Darin Adler.

  • WebKit.vcproj/WebKit.sln: Added WebKitLauncherWin.vcproj. It depends

on WebKitAPITest, so is the last project to build. (Also removed
QTMovieWin's direct dependency on JavaScriptCore, since it already has
an indirect dependency on it.)

9:18 AM Changeset in webkit [61190] by Laszlo Gombos
  • 2 edits in trunk/WebKit/qt

2010-06-15 Laszlo Gombos <Laszlo Gombos>

Unreviewed, Symbian build fix.

[Qt] Update the def file with recent new exports.

  • symbian/eabi/QtWebKitu.def:
9:18 AM Changeset in webkit [61189] by mitz@apple.com
  • 3 edits
    2 adds in trunk

WebKit/mac: <rdar://problem/8077032> REGRESSION (r50796): Black background on AppleScript generated email

Reviewed by John Sullivan.

Test: platform/mac/editing/input/NSBackgroundColor-transparent.html

r50796 changed the initial background color from invalid to transparent. As a result,
NSAttributedStrings returned from +_web_attributedStringFromRange started including the
NSBackgroundColor attribute, with a transparent color as the value. This caused problems for
components in the system that ignore the alpha component, turning the color into opaque black.

  • Misc/WebNSAttributedStringExtras.mm:

(+[NSAttributedString _web_attributedStringFromRange:]): Change to not include the background
and foreground color attributes if the color are transparent.

LayoutTests: Test for <rdar://problem/8077032> REGRESSION (r50796): Black background on AppleScript generated email

Reviewed by John Sullivan.

  • platform/mac/editing/input/NSBackgroundColor-transparent-expected.txt: Added.
  • platform/mac/editing/input/NSBackgroundColor-transparent.html: Added.
9:15 AM Changeset in webkit [61188] by yael.aharon@nokia.com
  • 1 edit in trunk/WebKit/qt/ChangeLog

Unreviewed.

Fix typo in reviewer name in r61187

9:10 AM Changeset in webkit [61187] by yael.aharon@nokia.com
  • 3 edits in trunk/WebKit/qt

[Qt] Build fix for Qt minimal after r61121
​https://bugs.webkit.org/show_bug.cgi?id=40624

Reviewed by Somon Fraser.

  • WebCoreSupport/NotificationPresenterClientQt.cpp:

(WebCore::NotificationIconWrapper::NotificationIconWrapper):
(WebCore::NotificationIconWrapper::close):
(WebCore::NotificationIconWrapper::title):
(WebCore::NotificationIconWrapper::message):
(WebCore::NotificationIconWrapper::iconData):
(WebCore::NotificationIconWrapper::notificationClosed):

  • WebCoreSupport/NotificationPresenterClientQt.h:

(WebCore::NotificationIconWrapper::~NotificationIconWrapper):

6:57 AM Changeset in webkit [61186] by kov@webkit.org
  • 2 edits in trunk/WebKit

2010-06-15 Gustavo Noronha Silva <Gustavo Noronha Silva>

Unreviewed EFL build fix. Simple typo.

  • efl/WebCoreSupport/InspectorClientEfl.cpp: (WebCore::InspectorClientEfl::sendMessageToFrontend):
6:38 AM Changeset in webkit [61185] by eric@webkit.org
  • 6 edits
    2 adds in trunk

2010-06-15 Zhenyao Mo <​zmo@google.com>

Reviewed by Dimitri Glazkov.

Bring framebuffer functions to GLES2 conformance
​https://bugs.webkit.org/show_bug.cgi?id=40175

  • fast/canvas/webgl/framebuffer-test-expected.txt: Added.
  • fast/canvas/webgl/framebuffer-test.html: Added.
  • fast/canvas/webgl/resources/webgl-test.js: (assertMsg): Function added.
  • fast/canvas/webgl/texture-npot.html: Remove assertMsg function.

2010-06-15 Zhenyao Mo <​zmo@google.com>

Reviewed by Dimitri Glazkov.

Bring framebuffer functions to GLES2 conformance
​https://bugs.webkit.org/show_bug.cgi?id=40175

Test: fast/canvas/webgl/framebuffer-test.html

  • html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::checkFramebufferStatus): Check input parameters and deal with default framebuffer situation. (WebCore::WebGLRenderingContext::framebufferRenderbuffer): Check input parameters. (WebCore::WebGLRenderingContext::framebufferTexture2D): Ditto. (WebCore::WebGLRenderingContext::getFramebufferAttachmentParameter): Ditto. (WebCore::WebGLRenderingContext::validateFramebufferFuncParameters): Check input parameters.
  • html/canvas/WebGLRenderingContext.h: Add validateFramebufferFuncParameters.
6:21 AM Changeset in webkit [61184] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2010-06-15 Diego Gonzalez <​diegohcg@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] DRT EventSender support to graphics context events
​https://bugs.webkit.org/show_bug.cgi?id=40324

  • DumpRenderTree/qt/EventSenderQt.cpp: (EventSender::contextClick):
6:08 AM Changeset in webkit [61183] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-06-15 Patrick Gansterer <​paroga@paroga.com>

Reviewed by David Levin.

Buildfix for ResourceHandleWin after r24202 and r55542.
​https://bugs.webkit.org/show_bug.cgi?id=32963

  • platform/network/win/ResourceHandleWin.cpp: (WebCore::ResourceHandle::onHandleCreated): (WebCore::ResourceHandle::onRequestComplete): (WebCore::transferJobStatusCallback): (WebCore::ResourceHandle::start):
4:41 AM Changeset in webkit [61182] by alex
  • 2 edits in trunk/LayoutTests

2010-06-15 Alejandro G. Castro <​alex@igalia.com>

Unreviewed.

Add expected results changes requiered for the patch in the review
60961.
​https://bugs.webkit.org/show_bug.cgi?id=40581

  • platform/gtk/fast/js/global-constructors-expected.txt:
  • platform/gtk/fast/js/global-constructors-expected.txt:
4:38 AM Changeset in webkit [61181] by pfeldman@chromium.org
  • 2 edits in trunk/WebCore

2010-06-12 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Joe Pecoraro.

Web Inspector: Should not expose window.console._inspectorCommandLineAPI to the web.

​https://bugs.webkit.org/show_bug.cgi?id=40500

  • inspector/front-end/InjectedScript.js: (injectedScriptConstructor): (injectedScriptConstructor.):
2:14 AM Changeset in webkit [61180] by loki@webkit.org
  • 2 edits in trunk/JavaScriptCore

Fix invalid access to non-static data member warning in JITPropertyAccess32_64 on ARM
​https://bugs.webkit.org/show_bug.cgi?id=40423

Rubber-stamped by Eric Seidel.

Using OBJECT_OFFSETOF macro instead of objectof to bypass access to
non-static data member warning.

  • jit/JITPropertyAccess32_64.cpp:

(JSC::JIT::privateCompilePutByIdTransition):

1:15 AM Changeset in webkit [61179] by Simon Hausmann
  • 2 edits in trunk/WebCore

[Qt] The qt_webkit_version.pri file gets overwritten on install
​https://bugs.webkit.org/show_bug.cgi?id=40487

Patch by Jocelyn Turcotte <​jocelyn.turcotte@nokia.com> on 2010-06-15
Reviewed by Simon Hausmann.

Don't install qt_webkit_version.pri when building WebKit inside of Qt.
The import of WebKit into Qt will take care of providing the file
in mkspecs/modules and it'll be installed through projects.pro.

  • WebCore.pro:
1:09 AM QtWebKitTableOfFeatures20 edited by Henry Haverinen
(diff)
1:06 AM QtWebKitTableOfFeatures20 edited by Henry Haverinen
(diff)
1:04 AM QtWebKitTableOfFeatures20 edited by Henry Haverinen
(diff)
1:03 AM Changeset in webkit [61178] by tony@chromium.org
  • 15 edits
    4 adds
    2 deletes in trunk

2010-06-15 Tony Chang <​tony@chromium.org>

Reviewed by Ojan Vafai.

resolve urls in text/html clipboard data
​https://bugs.webkit.org/show_bug.cgi?id=40044

  • editing/pasteboard/copy-resolves-urls-expected.txt: Added.
  • editing/pasteboard/copy-resolves-urls.html: Added.
  • editing/pasteboard/paste-noscript-expected.txt:
  • editing/pasteboard/paste-noscript.html: Updated to no longer throw a JS exception so the results are the same

with V8 and JSC

  • http/tests/misc/copy-resolves-urls-expected.txt: Added.
  • http/tests/misc/copy-resolves-urls.html: Added.
  • platform/chromium-mac/editing/pasteboard/paste-noscript-expected.txt: No longer needed since results should match JSC
  • platform/chromium-win/editing/pasteboard/paste-noscript-expected.txt: No longer needed since results should match JSC

2010-06-15 Tony Chang <​tony@chromium.org>

Reviewed by Ojan Vafai.

resolve urls in text/html clipboard data
​https://bugs.webkit.org/show_bug.cgi?id=40044

Allow text/html data copied from a page to contain full URLs when
dragging or copy/pasting.

Tests: editing/pasteboard/copy-resolves-urls.html

http/tests/misc/copy-resolves-urls.html

  • WebCore.base.exp:
  • editing/markup.cpp: (WebCore::appendStartMarkup): (WebCore::getStartMarkup): (WebCore::MarkupAccumulator::appendMarkup): (WebCore::createMarkup):
  • editing/markup.h: (WebCore::):
  • platform/chromium/ClipboardChromium.cpp: (WebCore::ClipboardChromium::writeRange):
  • platform/chromium/PasteboardChromium.cpp: (WebCore::Pasteboard::writeSelection):
  • platform/gtk/ClipboardGtk.cpp: (WebCore::ClipboardGtk::writeRange):
  • platform/gtk/DataObjectGtk.cpp: (WebCore::DataObjectGtk::markup):
  • platform/gtk/PasteboardGtk.cpp: (WebCore::Pasteboard::writeSelection):
  • platform/haiku/PasteboardHaiku.cpp: (WebCore::Pasteboard::writeSelection):
  • platform/qt/ClipboardQt.cpp: (WebCore::ClipboardQt::writeRange):
  • platform/qt/PasteboardQt.cpp: (WebCore::Pasteboard::writeSelection):
12:36 AM QtWebKitTriageRoster edited by kent.hansen@nokia.com
(diff)
12:01 AM Changeset in webkit [61177] by dimich@chromium.org
  • 2 edits in trunk/LayoutTests

Not reviewed, update Chromium expectations for a new test.

  • platform/chromium/test_expectations.txt:

Jun 14, 2010:

11:17 PM Changeset in webkit [61176] by Chris Fleizach
  • 2 edits in trunk/WebCore

No review. GTK build fix.

AX: need ListItemRole and PresentationalRole
​https://bugs.webkit.org/show_bug.cgi?id=40133

Mostly speculative fix to make GTK unit tests work.

  • accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:

(atkRole):
(webkit_accessible_get_role):

9:31 PM Changeset in webkit [61175] by tony@chromium.org
  • 4 edits in trunk

2010-06-14 Anders Carlsson <​andersca@apple.com>

Fix Chromium build.

  • src/WebPluginListBuilderImpl.cpp: (WebKit::WebPluginListBuilderImpl::addFileExtensionToLastMediaType):

2010-06-14 Tony Chang <​tony@chromium.org>

Reviewed by Darin Fisher.

[chromium] checkout chromium third_party directly
​https://bugs.webkit.org/show_bug.cgi?id=40556

  • Scripts/update-webkit-chromium: some migration code for the bots
8:55 PM Changeset in webkit [61174] by eric.carlson@apple.com
  • 2 edits in trunk/WebCore

2010-06-14 Eric Carlson <​eric.carlson@apple.com>

Reviewed by Dan Bernstein.

<rdar://problem/8090895> Update http streaming MIME types.

  • platform/MIMETypeRegistry.cpp: (WebCore::TypeExtensionPair::): Add http streaming MIME synonyms.
7:55 PM Changeset in webkit [61173] by eric.carlson@apple.com
  • 3 edits in trunk/LayoutTests

2010-06-14 Eric Carlson <​eric.carlson@apple.com>

Unreviewed, fix GTK and Qt builds.

  • platform/gtk/Skipped:
  • platform/qt/Skipped:
7:29 PM Changeset in webkit [61172] by eric.carlson@apple.com
  • 5 edits
    2 adds in trunk

2010-06-14 Eric Carlson <​eric.carlson@apple.com>

Reviewed by Oliver Hunt.

audio/x-mp3 MIME type not recognized
<rdar://problem/7875393>
​https://bugs.webkit.org/show_bug.cgi?id=40594


Allow MIMETypeRegistry to have more than one MIME type for a
media file extension, and have the QTKit media engine register
all MIME types it can find for each file type QTKit supports.

Test: media/media-can-play-mp3.html

  • platform/MIMETypeRegistry.cpp: (WebCore::mediaMIMETypeMap): Update for new HashMap format. (WebCore::TypeExtensionPair::): Store String+Vector<String> (WebCore::MIMETypeRegistry::getMediaMIMETypeForExtension): Only consult mediaMIMETypeMap(), it has the canonical answer. (WebCore::MIMETypeRegistry::getMediaMIMETypesForExtension): New, return a Vector of all MIME types for an extension.
  • platform/MIMETypeRegistry.h:
  • platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::addFileTypesToCache): Add all MIME types returned in the getMediaMIMETypesForExtension Vector.

2010-06-14 Eric Carlson <​eric.carlson@apple.com>

Reviewed by Oliver Hunt.

audio/x-mp3 MIME type not recognized
​https://bugs.webkit.org/show_bug.cgi?id=40594

  • media/media-can-play-mp3-expected.txt: Added.
  • media/media-can-play-mp3.html: Added.
6:50 PM Changeset in webkit [61171] by mrowe@apple.com
  • 2 edits in trunk/WebCore

<rdar://problem/8071866> REGRESSION: Crash on launch on Tiger and Leopard with network home folder

Reviewed by Brady Eidson.

  • platform/sql/SQLiteStatement.cpp:

(WebCore::SQLiteStatement::prepare): Don't assume that tail is always non-null, since that may
not be the case with some versions of SQLite. Instead we must null-check before dereferencing.

6:41 PM Changeset in webkit [61170] by andersca@apple.com
  • 2 edits in trunk/WebKit/chromium

Fix Chromium build.

  • src/WebPluginListBuilderImpl.cpp:

(WebKit::WebPluginListBuilderImpl::addFileExtensionToLastMediaType):

6:37 PM Changeset in webkit [61169] by andersca@apple.com
  • 2 edits in trunk/WebCore

Fix Tiger build.

  • plugins/mac/PluginDataMac.mm:
6:30 PM Changeset in webkit [61168] by andersca@apple.com
  • 10 edits in trunk/WebCore

2010-06-14 Anders Carlsson <​andersca@apple.com>

Reviewed by Darin Adler.

Use an array for extensions in MimeClassInfo
​https://bugs.webkit.org/show_bug.cgi?id=40602

Get rid of MimeClassInfo::suffixes and replace it with an array of extensions.

  • plugins/MimeType.cpp: (WebCore::MimeType::suffixes): Create a string of joined extensions.
  • plugins/MimeType.h:
  • plugins/PluginData.h: (WebCore::operator==):
  • plugins/chromium/PluginDataChromium.cpp: (WebCore::getPluginMimeTypeFromExtension):
  • plugins/gtk/PluginDataGtk.cpp: (WebCore::PluginData::initPlugins):
  • plugins/mac/PluginDataMac.mm: (WebCore::PluginData::initPlugins):
  • plugins/qt/PluginDataQt.cpp: (WebCore::PluginData::initPlugins):
  • plugins/win/PluginDataWin.cpp: (WebCore::PluginData::initPlugins):
  • plugins/wx/PluginDataWx.cpp: (WebCore::PluginData::initPlugins):
5:52 PM Changeset in webkit [61167] by abarth@webkit.org
  • 2 edits in trunk/WebCore

2010-06-14 Adam Barth <​abarth@webkit.org>

Unreviewed.

Add an include to try to fix Chromium build.

  • html/HTML5DocumentParser.cpp:
5:35 PM Changeset in webkit [61166] by sfalken@apple.com
  • 2 edits in trunk/WebKit2

Windows build fix.
Reorder build event to fix cygwin path issue.

  • win/WebKit2Generated.vcproj:
5:25 PM Changeset in webkit [61165] by abarth@webkit.org
  • 5 edits in trunk/WebCore

2010-06-14 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Safari beach-balls loading large pages with HTML5 parser
​https://bugs.webkit.org/show_bug.cgi?id=40596

Implement parser yielding, similar to how the old
HTMLDocumentParser yields.

This implementation re-uses the tokenizerTimeDelay and
tokenizerChunkSize settings even though they don't map exactly
to the token loop that the HTML5 parser uses.

  • dom/DocumentParser.h:
    • Add a FIXME for processingData() and clarify how the appendData flag is used by renaming it to isFromNetwork.
  • html/HTML5DocumentParser.cpp: (WebCore::parserTimeLimit):
    • Defaults accessor, probably belongs on Page.

(WebCore::parserChunkSize):

  • Defaults accessor, probably belongs on Page.

(WebCore::HTML5DocumentParser::HTML5DocumentParser):
(WebCore::HTML5DocumentParser::stopParsing):

  • Stop the continue-parsing timer if active.

(WebCore::HTML5DocumentParser::processingData):

  • Implement this poorly understood accessor to match the old parser's behavior. It's unclear what this does and it does not affect any layout tests to my knowledge but likely affects the WebKit API in some way.

(WebCore::HTML5DocumentParser::pumpLexerIfPossible):

  • Pass SynchronousMode.
  • Do not ever pump if we've yielded to the timer.

(WebCore::HTML5DocumentParser::PumpSession::PumpSession):

  • A struct for storing the yield counters.

(WebCore::HTML5DocumentParser::shouldContinueParsing):

  • Mostly matches HTMLDocumentParser::shouldContinueParsing.

(WebCore::HTML5DocumentParser::pumpLexer):

  • Respect SynchronousMode.
  • ASSERT that a timer is not scheduled if we're pumping.

(WebCore::isLayoutTimerActive):

  • This belongs on Document.

(WebCore::HTML5DocumentParser::continueNextChunkTimerFired):
(WebCore::HTML5DocumentParser::write):
(WebCore::HTML5DocumentParser::end):

  • We should never end() if a timer is still outstanding.

(WebCore::HTML5DocumentParser::attemptToEnd):
(WebCore::HTML5DocumentParser::endIfDelayed):
(WebCore::HTML5DocumentParser::resumeParsingAfterScriptExecution):

  • html/HTML5DocumentParser.h: (WebCore::HTML5DocumentParser::):
  • html/HTMLDocumentParser.cpp:
    • Clarify the old TimeDelay and ChunkSize constants.
5:20 PM Changeset in webkit [61164] by sfalken@apple.com
  • 2 edits in trunk/WebKit2

Windows build fix.
Add build failure stopping code.

  • win/WebKit2WebProcess.vcproj:
5:07 PM Changeset in webkit [61163] by abarth@webkit.org
  • 10 edits
    2 adds in trunk/WebCore

2010-06-14 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Add a preload scanner for the HTML5 parser
​https://bugs.webkit.org/show_bug.cgi?id=40557

This patch adds a simple preload scanner for the HTML5 parser. This
preload scanner is not as awesome as the old one because it doesn't
scan CSS, but it's much simpler.

  • Android.mk:
  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
    • Build file torture.
  • html/HTML5DocumentParser.cpp: (WebCore::HTML5DocumentParser::write):
    • Call into the preload scanner when waiting for a script.
  • html/HTML5DocumentParser.h:
  • html/HTML5PreloadScanner.cpp: Copied from WebCore/html/PreloadScanner.cpp. (WebCore::HTML5PreloadScanner::HTML5PreloadScanner): (WebCore::HTML5PreloadScanner::scan):
    • A simple loop to pump the preload scanner's lexer.

(WebCore::HTML5PreloadScanner::processToken):

  • Preload interesting resources. Stolen from the old preload scanner.

(WebCore::HTML5PreloadScanner::scanningBody):

  • html/HTML5PreloadScanner.h: Copied from WebCore/html/PreloadScanner.h.
5:00 PM Changeset in webkit [61162] by tony@chromium.org
  • 4 edits in trunk

2010-06-14 Tony Chang <​tony@chromium.org>

Reviewed by Darin Fisher.

Chromium shouldn't build inside the source directory
​https://bugs.webkit.org/show_bug.cgi?id=40489

Ignore directories fetched by chromium and chromium mac output dir.

  • chromium: Added property svn:ignore.

2010-06-13 Tony Chang <​tony@chromium.org>

Reviewed by Darin Fisher.

Chromium shouldn't build inside the source directory
​https://bugs.webkit.org/show_bug.cgi?id=40489

Ignore Chromium Linux build files.

  • .: Added property svn:ignore. Modified property svn:ignore.
4:58 PM Changeset in webkit [61161] by abarth@webkit.org
  • 5 edits in trunk/WebCore

2010-06-14 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Constify some HTML5Token methods
​https://bugs.webkit.org/show_bug.cgi?id=40592

I keep wanting these methods to be const. Eric wanted this in a
separate patch.

  • html/HTML5Lexer.h: (WebCore::HTML5Lexer::state):
  • html/HTML5Token.h: (WebCore::HTML5Token::attributes): (WebCore::HTML5Token::name): (WebCore::HTML5Token::characters): (WebCore::HTML5Token::comment): (WebCore::HTML5Token::publicIdentifier): (WebCore::HTML5Token::systemIdentifier):
  • html/HTML5TreeBuilder.cpp: (WebCore::convertToOldStyle): (WebCore::HTML5TreeBuilder::adjustedLexerState):
    • Technically, this might belong in the other patch, but I think it's fine here.

(WebCore::HTML5TreeBuilder::passTokenToLegacyParser):

  • html/HTML5TreeBuilder.h:
4:47 PM Changeset in webkit [61160] by sfalken@apple.com
  • 2 edits in trunk/WebKit2

Windows build fix.
Add build failure stopping code.

  • win/WebKit2Generated.vcproj:
4:11 PM Changeset in webkit [61159] by dimich@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed, more Chromium expectations updates.

  • platform/chromium/test_expectations.txt:
3:31 PM Changeset in webkit [61158] by dumi@chromium.org
  • 2 edits in trunk/WebCore

Unreviewed, build fix.

  • WebCore.xcodeproj/project.pbxproj:
3:27 PM Changeset in webkit [61157] by ap@apple.com
  • 2 edits in trunk/WebKitTools

Chromium build fix.

  • DumpRenderTree/chromium/EventSender.cpp: (EventSender::keyDown): Chromium uses differently named constants for Windows virtual key codes, replacing VK_DELETE with VKEY_DELETE.
3:27 PM Changeset in webkit [61156] by Dimitri Glazkov
  • 2 edits in trunk/WebCore

Unreviewed, build fix.

Remove accidental specifying of the class name twice.

  • html/HTMLFormElement.cpp:

(WebCore::HTMLFormElement::prepareFormData): Removed my ghastly typo.

3:08 PM Changeset in webkit [61155] by adachan@apple.com
  • 3 edits in trunk/WebKit2

Rubber-stamped by Steve Falkenburg.

  • Fix the release configuration to use release.vsprops.
  • Add Debug_Internal and Debug_All configurations to the WebKit2WebProcess project.
  • Fix launchWebProcess() to get the right path to the WebKit2WebProcess executable.
  • UIProcess/Launcher/win/WebProcessLauncher.cpp: (WebKit::launchWebProcess):
  • win/WebKit2WebProcess.vcproj:
3:07 PM Changeset in webkit [61154] by dumi@chromium.org
  • 15 edits in trunk

Get DatabaseTracker ready for sync DBs.
​https://bugs.webkit.org/show_bug.cgi?id=39041

Reviewed by Adam Barth.

WebCore:

  • storage/AbstractDatabase.cpp:

(WebCore::AbstractDatabase::~AbstractDatabase):

  • storage/AbstractDatabase.h:
  • storage/Database.cpp:

(WebCore::Database::closeImmediately):

  • storage/Database.h:

(WebCore::Database::scriptExecutionContext):

  • storage/DatabaseTracker.cpp:

(WebCore::DatabaseTracker::getMaxSizeForDatabase):
(WebCore::DatabaseTracker::databaseChanged):
(WebCore::DatabaseTracker::addOpenDatabase):
(WebCore::DatabaseTracker::removeOpenDatabase):
(WebCore::DatabaseTracker::getOpenDatabases):
(WebCore::DatabaseTracker::deleteDatabaseFile):

  • storage/DatabaseTracker.h:
  • storage/OriginQuotaManager.cpp:

(WebCore::OriginQuotaManager::markDatabase):

  • storage/OriginQuotaManager.h:
  • storage/chromium/DatabaseObserver.h:
  • storage/chromium/DatabaseTrackerChromium.cpp:

(WebCore::DatabaseTracker::addOpenDatabase):
(WebCore::TrackerRemoveOpenDatabaseTask::create):
(WebCore::TrackerRemoveOpenDatabaseTask::TrackerRemoveOpenDatabaseTask):
(WebCore::DatabaseTracker::removeOpenDatabase):
(WebCore::DatabaseTracker::getOpenDatabases):
(WebCore::DatabaseTracker::getMaxSizeForDatabase):

WebKit/chromium:

  • public/WebDatabase.h:
  • src/DatabaseObserver.cpp:

(WebCore::DatabaseObserver::databaseOpened):
(WebCore::DatabaseObserver::databaseModified):
(WebCore::DatabaseObserver::databaseClosed):

  • src/WebDatabase.cpp:

(WebKit::WebDatabase::closeDatabaseImmediately):
(WebKit::WebDatabase::WebDatabase):
(WebKit::WebDatabase::operator=):
(WebKit::WebDatabase::operator WTF::PassRefPtr<AbstractDatabase>):

2:58 PM Changeset in webkit [61153] by ap@apple.com
  • 11 edits
    2 adds in trunk

Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=40529
eventSender.keyDown("delete") incorrectly sends a backspace on some platforms

WebCore:

  • platform/mac/KeyEventMac.mm: (WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent): Use virtual key code to force correct character code for clarity. Also, reworded comment, since saying that "backspace needs to always be 8" misleadingly implied that it could "sometimes" be such without this code.

WebKitTools:

  • DumpRenderTree/mac/EventSendingController.mm: (-[EventSendingController keyDown:withModifiers:withLocation:]): We were sending a broken event for "delete" - it had virtual key code from forward delete, and text from backspace. Fixed "delete" to mean forward delete.
  • DumpRenderTree/chromium/EventSender.cpp: (EventSender::keyDown):
  • DumpRenderTree/gtk/EventSender.cpp: (keyDownCallback):
  • DumpRenderTree/win/EventSender.cpp: (keyDownCallback): Mac DRT confusion has propagated to other platforms, fixing those.

LayoutTests:

  • editing/deleting/forward-delete-key-expected.txt: Added.
  • editing/deleting/forward-delete-key.html: Added. Added a test for forward delete key working (particularly in DRT, since there was a lot of confusion between platform maintainers about it).
  • fast/forms/resources/input-live-pseudo-selectors.js:
  • fast/forms/resources/textarea-live-pseudo-selectors.js: These two tests expected that keyDown("delete") executed backward delete, changed them to send "\x08" for backspace.
2:51 PM Changeset in webkit [61152] by Dimitri Glazkov
  • 3 edits in trunk/WebCore

2010-06-14 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Darin Adler.

Refactor form submission code in HTMLFormElement to add clarity.
​https://bugs.webkit.org/show_bug.cgi?id=39430

Covered by existing tests in fast/forms/mailto.

  • html/HTMLFormElement.cpp: (WebCore::appendMailtoPostFormDataToURL): Renamed from transferMailtoPostFormDataToUrl,

removed clearing out of the FormData and moved it to a new place (next to the call site).

(WebCore::HTMLFormElement::prepareFormData): Renamed from createFormData, moved the logic of

prepareing FormData here, including the use of appendMailtoPostFormDataToURL.

(WebCore::HTMLFormElement::submit): Consolidated multiple invocations of submitForm().

  • html/HTMLFormElement.h: Renamed createFormData to prepareFormData.
2:48 PM Changeset in webkit [61151] by Chris Fleizach
  • 8 edits in trunk

AX: need ListItemRole and PresentationalRole
​https://bugs.webkit.org/show_bug.cgi?id=40133

Reviewed by Darin Adler.

WebCore:

  • accessibility/AccessibilityObject.cpp:

(WebCore::createARIARoleMap):

  • accessibility/AccessibilityObject.h:

(WebCore::AccessibilityObject::isListItem):

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::accessibilityIsIgnored):
(WebCore::AccessibilityRenderObject::determineAccessibilityRole):

  • accessibility/mac/AccessibilityObjectWrapper.mm:

(-[AccessibilityObjectWrapper accessibilityAttributeNames]):

WebKit/chromium:

  • public/WebAccessibilityRole.h:
  • src/AssertMatchingEnums.cpp:
2:45 PM Changeset in webkit [61150] by andersca@apple.com
  • 9 edits in trunk

2010-06-14 Anders Carlsson <​andersca@apple.com>

Reviewed by Sam Weinig.

Remove pluginIndex from MimeClassInfo
​https://bugs.webkit.org/show_bug.cgi?id=40588

  • src/WebPluginListBuilderImpl.cpp: (WebKit::WebPluginListBuilderImpl::addMediaTypeToLastPlugin):

2010-06-14 Anders Carlsson <​andersca@apple.com>

Reviewed by Sam Weinig.

Remove pluginIndex from MimeClassInfo
​https://bugs.webkit.org/show_bug.cgi?id=40588

  • plugins/PluginData.h:
  • plugins/gtk/PluginDataGtk.cpp: (WebCore::PluginData::initPlugins):
  • plugins/mac/PluginDataMac.mm: (WebCore::PluginData::initPlugins):
  • plugins/qt/PluginDataQt.cpp: (WebCore::PluginData::initPlugins):
  • plugins/win/PluginDataWin.cpp: (WebCore::PluginData::initPlugins):
  • plugins/wx/PluginDataWx.cpp: (WebCore::PluginData::initPlugins):
2:41 PM Changeset in webkit [61149] by kinuko@chromium.org
  • 11 edits
    2 adds in trunk/WebCore

2010-06-14 Kinuko Yasuda <​kinuko@chromium.org>

Reviewed by Jian Li.

Implement BlobBuilder internal class for BlobBuilder support as defined in FileWriter
​https://bugs.webkit.org/show_bug.cgi?id=36903

No new tests; they will be added when we add jsc bindings.

  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • html/BlobBuilder.cpp: Added.
  • html/BlobBuilder.h: Added. (WebCore::BlobBuilder::create):
  • platform/BlobItem.cpp: (WebCore::StringBlobItem::convertToCString): Added EndingNative support.
  • platform/BlobItem.h: Added EndingNative line-ending type. (WebCore::):
2:37 PM Changeset in webkit [61148] by dimich@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed, temporary update Chromium expectations after ​http://trac.webkit.org/changeset/61128

  • platform/chromium/test_expectations.txt:
2:13 PM Changeset in webkit [61147] by andersca@apple.com
  • 5 edits in trunk/WebCore

2010-06-14 Anders Carlsson <​andersca@apple.com>

Reviewed by Darin Adler.

Stop using MimeClassInfo::pluginIndex
​https://bugs.webkit.org/show_bug.cgi?id=40582

Add a pluginIndicies vector to PluginData and use it instead of MimeClassInfo::pluginIndex.

  • plugins/MimeType.cpp: (WebCore::MimeType::enabledPlugin): Get the plug-in index from the mimePluginIndices vector.


  • plugins/Plugin.cpp: (WebCore::Plugin::item): Compare the mime plugin index as well.


  • plugins/PluginData.cpp: (WebCore::PluginData::PluginData): Populate the m_mimePluginIndices vector.

(WebCore::PluginData::pluginNameForMimeType):
Get the plug-in index from the m_mimePluginIndices vector.

  • plugins/PluginData.h: (WebCore::operator==): Don't check for pluginIndex.

(WebCore::PluginData::mimePluginIndices):
Add getter for m_mimePluginIndices.

2:08 PM Changeset in webkit [61146] by weinig@apple.com
  • 2 edits in trunk/WebCore

Better build fix.

  • bindings/js/JSBindingsAllInOne.cpp:
2:06 PM Changeset in webkit [61145] by weinig@apple.com
  • 2 edits in trunk/WebCore

Another windows build fix.

  • bindings/js/JSBindingsAllInOne.cpp:
2:03 PM Changeset in webkit [61144] by Martin Robinson
  • 2 edits in trunk/WebKitTools

2010-06-14 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Xan Lopez.

Small GtkLauncher build fix for some systems.

  • GtkLauncher/main.c: Add <limit.h> include.
1:54 PM Changeset in webkit [61143] by weinig@apple.com
  • 2 edits in trunk/WebCore

Another build fix.

  • bindings/js/JSDOMWindowCustom.cpp:
1:45 PM Changeset in webkit [61142] by Csaba Osztrogonác
  • 4 edits in trunk/LayoutTests

[Qt] Unreviewed fix. Platform specific expected results updated after r61136.

  • platform/qt/fast/dom/Window/window-lookup-precedence-expected.txt:
  • platform/qt/fast/dom/Window/window-properties-expected.txt:
  • platform/qt/fast/js/global-constructors-expected.txt:
1:09 PM Changeset in webkit [61141] by crogers@google.com
  • 1 edit in branches/audio/WebCore/audio/RealtimeAnalyser.cpp

A little cleanup in realtime analyser code

1:09 PM Changeset in webkit [61140] by crogers@google.com
  • 1 edit in branches/audio/WebCore/audio/Reverb.cpp

Handle edge case of reverb 1 -> 4 -> 2 matrixing

1:09 PM Changeset in webkit [61139] by crogers@google.com
  • 2 edits in branches/audio/WebCore/audio

include config.h in MidSide

1:05 PM Changeset in webkit [61138] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

Unreviewed.

[Qt] fast/text/justify-padding-distribution.html fails
​https://bugs.webkit.org/show_bug.cgi?id=40584

  • platform/qt/Skipped: fast/text/justify-padding-distribution.html skipped until fix.
12:51 PM Changeset in webkit [61137] by weinig@apple.com
  • 2 edits in trunk/WebCore

Add missing comma to fix GTK build.

  • xml/XSLTProcessor.idl:
12:46 PM Changeset in webkit [61136] by weinig@apple.com
  • 47 edits
    4 moves
    28 deletes in trunk

Fix for ​https://bugs.webkit.org/show_bug.cgi?id=40581
Auto-generate most of the JS constructors

Reviewed by Alexey Proskuryakov.

WebCore:

  • Auto-generates all the JS constructors that don't have custom names (eg, Not Image(), Audio() or Option())
  • Fixes two typos.

(new XSLTConstructor()).toString() [object XSLTProcessorConsructor] -> [object XSLTProcessorConstructor])
(new EventSource()).toString() [object EventSourceContructor] -> [object EventSourceConstructor])

  • Android.jscbindings.mk:
  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSArrayBufferConstructor.cpp: Removed.
  • bindings/js/JSArrayBufferConstructor.h: Removed.
  • bindings/js/JSArrayBufferCustom.cpp: Copied from WebCore/bindings/js/JSArrayBufferConstructor.cpp.

(WebCore::JSArrayBufferConstructor::constructJSArrayBuffer):

  • bindings/js/JSArrayBufferViewHelper.h:

(WebCore::constructArrayBufferView):

  • bindings/js/JSBindingsAllInOne.cpp:
  • bindings/js/JSDOMWindowCustom.cpp:
  • bindings/js/JSEventSourceConstructor.cpp: Removed.
  • bindings/js/JSEventSourceConstructor.h: Removed.
  • bindings/js/JSEventSourceCustom.cpp: Copied from WebCore/bindings/js/JSEventSourceConstructor.cpp.

(WebCore::JSEventSourceConstructor::constructJSEventSource):

  • bindings/js/JSFloat32ArrayConstructor.cpp: Removed.
  • bindings/js/JSFloat32ArrayConstructor.h: Removed.
  • bindings/js/JSFloat32ArrayCustom.cpp:

(WebCore::JSFloat32ArrayConstructor::constructJSFloat32Array):

  • bindings/js/JSInt16ArrayConstructor.cpp: Removed.
  • bindings/js/JSInt16ArrayConstructor.h: Removed.
  • bindings/js/JSInt16ArrayCustom.cpp:

(WebCore::JSInt16ArrayConstructor::constructJSInt16Array):

  • bindings/js/JSInt32ArrayConstructor.cpp: Removed.
  • bindings/js/JSInt32ArrayConstructor.h: Removed.
  • bindings/js/JSInt32ArrayCustom.cpp:

(WebCore::JSInt32ArrayConstructor::constructJSInt32Array):

  • bindings/js/JSInt8ArrayConstructor.cpp: Removed.
  • bindings/js/JSInt8ArrayConstructor.h: Removed.
  • bindings/js/JSInt8ArrayCustom.cpp:

(WebCore::JSInt8ArrayConstructor::constructJSInt8Array):

  • bindings/js/JSMessageChannelConstructor.cpp: Removed.
  • bindings/js/JSMessageChannelConstructor.h: Removed.
  • bindings/js/JSMessageChannelCustom.cpp:

(WebCore::JSMessageChannelConstructor::constructJSMessageChannel):

  • bindings/js/JSSharedWorkerConstructor.cpp: Removed.
  • bindings/js/JSSharedWorkerConstructor.h: Removed.
  • bindings/js/JSSharedWorkerCustom.cpp:

(WebCore::JSSharedWorkerConstructor::constructJSSharedWorker):

  • bindings/js/JSUint16ArrayConstructor.cpp: Removed.
  • bindings/js/JSUint16ArrayConstructor.h: Removed.
  • bindings/js/JSUint16ArrayCustom.cpp:

(WebCore::JSUint16ArrayConstructor::constructJSUint16Array):

  • bindings/js/JSUint32ArrayConstructor.cpp: Removed.
  • bindings/js/JSUint32ArrayConstructor.h: Removed.
  • bindings/js/JSUint32ArrayCustom.cpp:

(WebCore::JSUint32ArrayConstructor::constructJSUint32Array):

  • bindings/js/JSUint8ArrayConstructor.cpp: Removed.
  • bindings/js/JSUint8ArrayConstructor.h: Removed.
  • bindings/js/JSUint8ArrayCustom.cpp:

(WebCore::JSUint8ArrayConstructor::constructJSUint8Array):

  • bindings/js/JSWebKitCSSMatrixConstructor.cpp: Removed.
  • bindings/js/JSWebKitCSSMatrixConstructor.h: Removed.
  • bindings/js/JSWebKitCSSMatrixCustom.cpp: Copied from WebCore/bindings/js/JSWebKitCSSMatrixConstructor.cpp.

(WebCore::JSWebKitCSSMatrixConstructor::constructJSWebKitCSSMatrix):

  • bindings/js/JSWebKitPointConstructor.cpp: Removed.
  • bindings/js/JSWebKitPointConstructor.h: Removed.
  • bindings/js/JSWebKitPointCustom.cpp: Copied from WebCore/bindings/js/JSWebKitPointConstructor.cpp.

(WebCore::JSWebKitPointConstructor::constructJSWebKitPoint):

  • bindings/js/JSWebSocketConstructor.cpp: Removed.
  • bindings/js/JSWebSocketConstructor.h: Removed.
  • bindings/js/JSWebSocketCustom.cpp:

(WebCore::JSWebSocketConstructor::constructJSWebSocket):

  • bindings/js/JSWorkerConstructor.cpp: Removed.
  • bindings/js/JSWorkerConstructor.h: Removed.
  • bindings/js/JSWorkerContextCustom.cpp:
  • bindings/js/JSWorkerCustom.cpp:

(WebCore::JSWorkerConstructor::constructJSWorker):

  • bindings/js/JSXSLTProcessorConstructor.cpp: Removed.
  • bindings/js/JSXSLTProcessorConstructor.h: Removed.
  • bindings/js/JSXSLTProcessorCustom.cpp:

(WebCore::JSXSLTProcessorConstructor::constructJSXSLTProcessor):

  • bindings/scripts/CodeGeneratorJS.pm:
  • css/WebKitCSSMatrix.idl:
  • dom/MessageChannel.idl:
  • html/canvas/ArrayBuffer.idl:
  • html/canvas/Float32Array.idl:
  • html/canvas/Int16Array.idl:
  • html/canvas/Int32Array.idl:
  • html/canvas/Int8Array.idl:
  • html/canvas/Uint16Array.idl:
  • html/canvas/Uint32Array.idl:
  • html/canvas/Uint8Array.idl:
  • page/EventSource.idl:
  • page/WebKitPoint.idl:
  • websockets/WebSocket.idl:
  • workers/SharedWorker.idl:
  • workers/Worker.idl:
  • xml/XSLTProcessor.idl:

LayoutTests:

  • fast/dom/Window/window-lookup-precedence-expected.txt:
  • fast/dom/Window/window-properties-expected.txt:
  • fast/dom/constructed-objects-prototypes-expected.txt:
  • fast/dom/prototype-inheritance-2-expected.txt:
  • fast/js/global-constructors-expected.txt:
12:11 PM Changeset in webkit [61135] by tonikitoo@webkit.org
  • 2 edits in trunk/WebCore

2010-05-16 Antonio Gomes <​tonikitoo@webkit.org>

Unreviewed naming fixes of local variables used in Spatial Navigation methods.

Summary:

  • "candidate" renamed to "node";
  • "currentFocusCandidate" renamed to "candidate"
  • "closestFocusCandidate" renamed to "closest"

That way naming is more consistent in the various Spatial Navigation methods.

  • page/FocusController.cpp: (WebCore::FocusController::findFocusableNodeInDirection): (WebCore::FocusController::deepFindFocusableNodeInDirection):
12:10 PM Changeset in webkit [61134] by tonikitoo@webkit.org
  • 5 edits
    4 adds in trunk

Spatial Navigation: make it work with focusable elements in overflow content
​https://bugs.webkit.org/show_bug.cgi?id=36463

Reviewed by Simon Fraser and Kenneth Christiansen.
Patch by Antonio Gomes <​tonikitoo@webkit.org>

WebCore:

This patch addresses the problem with Spatial Navigation. It currently does not
properly traverse scrollable contents, including scrollable div's. For this to work,
a new class member called scrollableEnclosingBox was introduced to FocusCandidate class which
keeps track of the current scrollable box Node wrapping a FocusCandidate.

To make use of enclosingScrollableBox of FocusCandidate, the DOM traversal routine
(FocusController::findNextFocusableInDirection) was changed as follows: when it
encounters a scrollable Node, each focusable node which is 'inner' keeps track of
the container reference. By the time a sibling of the scrollable Node is encountered,
there is no need to track this reference any more and the traversal algorithm continues
normally.

The common case is obviously that there is no scrollable container wrapping it.

updateFocusCandiditeIfCloser logic was also adapted to fit the need of the
newly introduced enclosingScrollableBox class member, getting simpler and more
easily maintainable.

Tests: fast/events/spatial-navigation/snav-div-scrollable-but-without-focusable-content.html

fast/events/spatial-navigation/snav-clipped-overflow-content.html

  • page/FocusController.cpp:

(WebCore::updateFocusCandidateInSameContainer):
(WebCore::updateFocusCandidateIfCloser):
(WebCore::FocusController::findFocusableNodeInDirection):
(WebCore::FocusController::deepFindFocusableNodeInDirection):

  • page/SpatialNavigation.cpp:

(WebCore::isScrollableContainerNode):

  • page/SpatialNavigation.h:

(WebCore::FocusCandidate::FocusCandidate):
(WebCore::FocusCandidate::inScrollableContainer):

LayoutTests:

  • fast/events/spatial-navigation/snav-div-scrollable-but-without-focusable-content-expected.txt: Added.
  • fast/events/spatial-navigation/snav-div-scrollable-but-without-focusable-content.html: Added.
  • fast/events/spatial-navigation/snav-clipped-overflow-content-expected.txt: Added.
  • fast/events/spatial-navigation/snav-clipped-overflow-content.html: Added.
11:59 AM Changeset in webkit [61133] by jianli@chromium.org
  • 7 edits in trunk/WebCore

Unreviewed. Fix build break in GTK.

  • bindings/scripts/CodeGeneratorGObject.pm:
  • bindings/scripts/test/GObject/WebKitDOMTestCallback.h:
  • bindings/scripts/test/GObject/WebKitDOMTestCallbackPrivate.h:
  • bindings/scripts/test/GObject/WebKitDOMTestInterface.h:
  • bindings/scripts/test/GObject/WebKitDOMTestInterfacePrivate.h:
  • bindings/scripts/test/GObject/WebKitDOMTestObj.h:
11:43 AM Changeset in webkit [61132] by Chris Fleizach
  • 3 edits
    2 adds in trunk

AX: AXUnknown objects are being returned
​https://bugs.webkit.org/show_bug.cgi?id=40574

Reviewed by Beth Dakin.

WebCore:

Test: platform/mac/accessibility/no-unknown-objects-when-title-attribute-present.html

  • accessibility/mac/AccessibilityObjectMac.mm:

(WebCore::AccessibilityObject::accessibilityPlatformIncludesObject):

LayoutTests:

  • platform/mac/accessibility/no-unknown-objects-when-title-attribute-present-expected.txt: Added.
  • platform/mac/accessibility/no-unknown-objects-when-title-attribute-present.html: Added.
11:34 AM Changeset in webkit [61131] by jianli@chromium.org
  • 29 edits in trunk/WebCore

Fix code generators to better support Conditional attribute and add test
coverage for it.
​https://bugs.webkit.org/show_bug.cgi?id=39512

Reviewed by Darin Adler.

  • bindings/scripts/CodeGeneratorGObject.pm:
  • bindings/scripts/CodeGeneratorObjC.pm:
  • bindings/scripts/CodeGeneratorV8.pm:
  • bindings/scripts/test/GObject/WebKitDOMTestCallback.cpp:
  • bindings/scripts/test/GObject/WebKitDOMTestCallback.h:
  • bindings/scripts/test/GObject/WebKitDOMTestInterface.cpp:
  • bindings/scripts/test/GObject/WebKitDOMTestInterface.h:
  • bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:

(webkit_dom_test_obj_get_conditional_attr1):
(webkit_dom_test_obj_set_conditional_attr1):
(webkit_dom_test_obj_get_conditional_attr2):
(webkit_dom_test_obj_set_conditional_attr2):
(webkit_dom_test_obj_get_conditional_attr3):
(webkit_dom_test_obj_set_conditional_attr3):
(webkit_dom_test_obj_set_property):
(webkit_dom_test_obj_get_property):
(webkit_dom_test_obj_class_init):

  • bindings/scripts/test/GObject/WebKitDOMTestObj.h:
  • bindings/scripts/test/JS/JSTestInterface.cpp:
  • bindings/scripts/test/JS/JSTestInterface.h:
  • bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore::):
(WebCore::jsTestObjConditionalAttr1):
(WebCore::jsTestObjConditionalAttr2):
(WebCore::jsTestObjConditionalAttr3):
(WebCore::setJSTestObjConditionalAttr1):
(WebCore::setJSTestObjConditionalAttr2):
(WebCore::setJSTestObjConditionalAttr3):

  • bindings/scripts/test/JS/JSTestObj.h:
  • bindings/scripts/test/ObjC/DOMTestInterface.mm:
  • bindings/scripts/test/ObjC/DOMTestObj.h:
  • bindings/scripts/test/ObjC/DOMTestObj.mm:

(-[DOMTestObj conditionalAttr1]):
(-[DOMTestObj setConditionalAttr1:]):
(-[DOMTestObj conditionalAttr2]):
(-[DOMTestObj setConditionalAttr2:]):
(-[DOMTestObj conditionalAttr3]):
(-[DOMTestObj setConditionalAttr3:]):

  • bindings/scripts/test/TestInterface.idl:
  • bindings/scripts/test/TestObj.idl:
  • bindings/scripts/test/V8/V8TestInterface.cpp:
  • bindings/scripts/test/V8/V8TestInterface.h:
  • bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::TestObjInternal::conditionalAttr1AttrGetter):
(WebCore::TestObjInternal::conditionalAttr1AttrSetter):
(WebCore::TestObjInternal::conditionalAttr2AttrGetter):
(WebCore::TestObjInternal::conditionalAttr2AttrSetter):
(WebCore::TestObjInternal::conditionalAttr3AttrGetter):
(WebCore::TestObjInternal::conditionalAttr3AttrSetter):
(WebCore::):

11:30 AM Changeset in webkit [61130] by Chris Fleizach
  • 3 edits in trunk/LayoutTests

Bug 40576 - AX: need to update iframe-bastardization.html LayoutTest to be more modern
​https://bugs.webkit.org/show_bug.cgi?id=40576

10:29 AM Changeset in webkit [61129] by eric@webkit.org
  • 26 edits in trunk

2010-06-14 Chang Shu <​chang.shu@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Unskip canvas/philip/tests/2d.shadow.enable.x.html
and canvas/philip/tests/2d.shadow.enable.y.html.

​https://bugs.webkit.org/show_bug.cgi?id=40434

  • platform/qt/Skipped:

2010-06-14 Chang Shu <​chang.shu@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

Change the type of ShadowSize from IntSize to FloatSize in GraphicsContext.
Using IntSize loses precision and fails the test.
Note: This code change fixes Qt port but Mac is still failing due to
platform issue.

​https://bugs.webkit.org/show_bug.cgi?id=40434

  • html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::applyShadow):
  • platform/graphics/GraphicsContext.cpp: (WebCore::GraphicsContext::setShadow): (WebCore::GraphicsContext::getShadow):
  • platform/graphics/GraphicsContext.h:
  • platform/graphics/GraphicsContextPrivate.h:
  • platform/graphics/cairo/FontCairo.cpp: (WebCore::Font::drawGlyphs):
  • platform/graphics/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContext::calculateShadowBufferDimensions): (WebCore::drawPathShadow): (WebCore::drawBorderlessRectShadow): (WebCore::GraphicsContext::setPlatformShadow):
  • platform/graphics/cairo/ImageCairo.cpp: (WebCore::BitmapImage::draw):
  • platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::setPlatformShadow):
  • platform/graphics/chromium/FontChromiumWin.cpp: (WebCore::TransparencyAwareFontPainter::TransparencyAwareGlyphPainter::drawGlyphs): (WebCore::Font::drawComplexText):
  • platform/graphics/gtk/FontGtk.cpp: (WebCore::Font::drawComplexText):
  • platform/graphics/haiku/GraphicsContextHaiku.cpp: (WebCore::GraphicsContext::setPlatformShadow):
  • platform/graphics/mac/FontMac.mm: (WebCore::Font::drawGlyphs):
  • platform/graphics/openvg/GraphicsContextOpenVG.cpp: (WebCore::GraphicsContext::setPlatformShadow):
  • platform/graphics/qt/FontQt.cpp: (WebCore::drawTextCommon):
  • platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::drawRect): (WebCore::GraphicsContext::drawLine): (WebCore::GraphicsContext::strokeArc): (WebCore::GraphicsContext::drawConvexPolygon): (WebCore::drawFilledShadowPath): (WebCore::GraphicsContext::strokePath): (WebCore::drawBorderlessRectShadow): (WebCore::GraphicsContext::setPlatformShadow):
  • platform/graphics/qt/ImageQt.cpp: (WebCore::BitmapImage::draw):
  • platform/graphics/skia/GraphicsContextSkia.cpp: (WebCore::GraphicsContext::setPlatformShadow):
  • platform/graphics/skia/SkiaFontWin.cpp: (WebCore::windowsCanHandleDrawTextShadow):
  • platform/graphics/win/FontCGWin.cpp: (WebCore::drawGDIGlyphs): (WebCore::Font::drawGlyphs):
  • platform/graphics/wince/GraphicsContextWince.cpp: (WebCore::GraphicsContext::fillRoundedRect): (WebCore::GraphicsContext::setPlatformShadow): (WebCore::GraphicsContext::drawText):
  • platform/graphics/wx/GraphicsContextWx.cpp: (WebCore::GraphicsContext::setPlatformShadow):

2010-06-14 Chang Shu <​chang.shu@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[win] Make windows compile after API changes.

​https://bugs.webkit.org/show_bug.cgi?id=40434

  • WebKitGraphics.cpp: (WebDrawText):
10:06 AM Changeset in webkit [61128] by mitz@apple.com
  • 58 edits
    4 adds in trunk

<rdar://problem/7752961> Unevenly distributed space in justified text
​https://bugs.webkit.org/show_bug.cgi?id=36105

Reviewed by Simon Fraser.

WebCore:

Test: fast/text/justify-padding-distribution.html

  • platform/graphics/WidthIterator.cpp:

(WebCore::WidthIterator::WidthIterator): Initialize m_padPerSpace to the quotient of the total
padding and the number of spaces rather than truncating it.
(WebCore::WidthIterator::advance): Subtract m_padPerSpace from m_padding and add the difference
between its old and new values, when rounded, to the advance.

  • platform/graphics/mac/ComplexTextController.cpp:

(WebCore::ComplexTextController::ComplexTextController):
(WebCore::ComplexTextController::adjustGlyphsAndAdvances):

  • platform/graphics/win/UniscribeController.cpp:

(WebCore::UniscribeController::UniscribeController):
(WebCore::UniscribeController::shapeAndPlaceItem):

  • platform/graphics/win/UniscribeController.h:

LayoutTests:

  • fast/text/justify-padding-distribution-expected.checksum: Added.
  • fast/text/justify-padding-distribution-expected.png: Added.
  • fast/text/justify-padding-distribution-expected.txt: Added.
  • fast/text/justify-padding-distribution.html: Added.
  • platform/mac/css1/box_properties/clear_float-expected.checksum:
  • platform/mac/css1/box_properties/clear_float-expected.png:
  • platform/mac/css1/box_properties/float_elements_in_series-expected.checksum:
  • platform/mac/css1/box_properties/float_elements_in_series-expected.png:
  • platform/mac/css1/box_properties/float_on_text_elements-expected.checksum:
  • platform/mac/css1/box_properties/float_on_text_elements-expected.png:
  • platform/mac/css1/text_properties/text_align-expected.checksum:
  • platform/mac/css1/text_properties/text_align-expected.png:
  • platform/mac/css2.1/t0905-c5525-fltcont-00-d-g-expected.checksum:
  • platform/mac/css2.1/t0905-c5525-fltcont-00-d-g-expected.png:
  • platform/mac/css2.1/t0905-c5525-fltwidth-00-c-g-expected.checksum:
  • platform/mac/css2.1/t0905-c5525-fltwidth-00-c-g-expected.png:
  • platform/mac/css2.1/t1602-c546-txt-align-00-b-expected.checksum:
  • platform/mac/css2.1/t1602-c546-txt-align-00-b-expected.png:
  • platform/mac/fast/multicol/float-avoidance-expected.checksum:
  • platform/mac/fast/multicol/float-avoidance-expected.png:
  • platform/mac/fast/repaint/line-flow-with-floats-1-expected.checksum:
  • platform/mac/fast/repaint/line-flow-with-floats-1-expected.png:
  • platform/mac/fast/repaint/line-flow-with-floats-10-expected.checksum:
  • platform/mac/fast/repaint/line-flow-with-floats-10-expected.png:
  • platform/mac/fast/repaint/line-flow-with-floats-2-expected.checksum:
  • platform/mac/fast/repaint/line-flow-with-floats-2-expected.png:
  • platform/mac/fast/repaint/line-flow-with-floats-3-expected.checksum:
  • platform/mac/fast/repaint/line-flow-with-floats-3-expected.png:
  • platform/mac/fast/repaint/line-flow-with-floats-4-expected.checksum:
  • platform/mac/fast/repaint/line-flow-with-floats-4-expected.png:
  • platform/mac/fast/repaint/line-flow-with-floats-5-expected.checksum:
  • platform/mac/fast/repaint/line-flow-with-floats-5-expected.png:
  • platform/mac/fast/repaint/line-flow-with-floats-6-expected.checksum:
  • platform/mac/fast/repaint/line-flow-with-floats-6-expected.png:
  • platform/mac/fast/repaint/line-flow-with-floats-7-expected.checksum:
  • platform/mac/fast/repaint/line-flow-with-floats-7-expected.png:
  • platform/mac/fast/repaint/line-flow-with-floats-8-expected.checksum:
  • platform/mac/fast/repaint/line-flow-with-floats-8-expected.png:
  • platform/mac/fast/repaint/line-flow-with-floats-9-expected.checksum:
  • platform/mac/fast/repaint/line-flow-with-floats-9-expected.png:
  • platform/mac/fast/text/atsui-spacing-features-expected.checksum:
  • platform/mac/fast/text/atsui-spacing-features-expected.png:
  • platform/mac/fast/text/justified-selection-at-edge-expected.checksum:
  • platform/mac/fast/text/justified-selection-at-edge-expected.png:
  • platform/mac/tables/mozilla/marvin/x_tbody_align_justify-expected.checksum:
  • platform/mac/tables/mozilla/marvin/x_tbody_align_justify-expected.png:
  • platform/mac/tables/mozilla/marvin/x_td_align_justify-expected.checksum:
  • platform/mac/tables/mozilla/marvin/x_td_align_justify-expected.png:
  • platform/mac/tables/mozilla/marvin/x_tfoot_align_justify-expected.checksum:
  • platform/mac/tables/mozilla/marvin/x_tfoot_align_justify-expected.png:
  • platform/mac/tables/mozilla/marvin/x_th_align_justify-expected.checksum:
  • platform/mac/tables/mozilla/marvin/x_th_align_justify-expected.png:
  • platform/mac/tables/mozilla/marvin/x_thead_align_justify-expected.checksum:
  • platform/mac/tables/mozilla/marvin/x_thead_align_justify-expected.png:
  • platform/mac/tables/mozilla/marvin/x_tr_align_justify-expected.checksum:
  • platform/mac/tables/mozilla/marvin/x_tr_align_justify-expected.png:
9:38 AM Changeset in webkit [61127] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-06-14 Andreas Kling <​andreas.kling@nokia.com>

Reviewed by Tor Arne Vestbø.

[Qt] Stack overflow when converting navigator object to QVariant
​https://bugs.webkit.org/show_bug.cgi?id=40572

Protect against infinite recursion in JSValue->QVariant conversion.
This fixes a crash when trying to convert MimeType objects (they
recurse infinitely and on-the-fly via the enabledPlugin property.)

  • bridge/qt/qt_runtime.cpp: (JSC::Bindings::convertValueToQVariant):
9:27 AM Changeset in webkit [61126] by eric@webkit.org
  • 4 edits
    2 adds in trunk/WebCore

2010-06-14 Yong Li <​yoli@rim.com>

Test cases created by: Robin Cao <​robin.cao@torchmobile.com.cn>

Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=38910

Suspend Document::m_executeScriptSoonTimer objects when the page is deferred.
There's no reason why we suspend all active DOM timers on the page but not suspend
this one. Document::m_executeScriptSoonTimer can run JS and schedule more DOM Timers.

It can only be tested manually.

  • manual-tests/load-deferrer-script-element.html: Added.
  • manual-tests/resources/load-deferrer-script-element.js: Added.
  • dom/Document.cpp: (WebCore::Document::executeScriptSoon): (WebCore::Document::suspendExecuteScriptSoonTimer): Added. (WebCore::Document::resumeExecuteScriptSoonTimer): Added.
  • dom/Document.h:
  • page/PageGroupLoadDeferrer.cpp: (WebCore::PageGroupLoadDeferrer::PageGroupLoadDeferrer): (WebCore::PageGroupLoadDeferrer::~PageGroupLoadDeferrer):
8:23 AM Changeset in webkit [61125] by bulach@chromium.org
  • 2 edits in trunk/LayoutTests

2010-06-14 Marcus Bulach <​bulach@chromium.org>

Reviewed by Jeremy Orlow.

Rebaseline LayoutTests/platform/chromium/fast/dom/Geolocation/callback-exception-expected.txt.
​https://bugs.webkit.org/show_bug.cgi?id=40568

​https://bugs.webkit.org/show_bug.cgi?id=39994 changed the test expectations, and we need to rebaseline.

  • platform/chromium/fast/dom/Geolocation/callback-exception-expected.txt:
8:13 AM Changeset in webkit [61124] by loislo@chromium.org
  • 2 edits in trunk/WebKit/gtk

2010-06-14 Ilya Tikhonovsky <​loislo@chromium.org>

Unreviewed build fix.

This is a fix for flaky inspector tests at gtk-debug bots.

  • WebCoreSupport/InspectorClientGtk.cpp: (WebKit::InspectorFrontendClient::destroyInspectorWindow):
8:07 AM Changeset in webkit [61123] by Laszlo Gombos
  • 2 edits in trunk/WebKit/qt

2010-06-14 Laszlo Gombos <Laszlo Gombos>

Unreviewed, Symbian build fix.

[Qt] Update the def file with recent new exports.

  • symbian/eabi/QtWebKitu.def:
7:31 AM Changeset in webkit [61122] by mitz@apple.com
  • 2 edits in trunk

Fixed a typo and reviewr information in ChangeLog files

7:09 AM Changeset in webkit [61121] by yael.aharon@nokia.com
  • 13 edits
    2 adds in trunk

[Qt] Platform plugin support for Notifications UI
​https://bugs.webkit.org/show_bug.cgi?id=40005

Reviewed by Kenneth Rohde Christiansen.

WebCore:

To avoid race condition when GC is run during shutdown,
disconnect the Notification from the NotificationPresenter
when the presenter deletes itself.
This cannot be tested by a layout test, the race condition happens only
when GC is run during shutdown. It can be tested manually by loading
manually any notification test and closing the browser.

  • notifications/Notification.cpp:

(WebCore::Notification::~Notification):

  • notifications/Notification.h:

(WebCore::Notification::detachPresenter):

WebKit/qt:

Add an interface to the platform plugin to display notifications.
Implemented the notification in the example platform plugin.
This interface is enabled by default, but could be turned off with
a build flag. The platform plugin should control its own lifecycle,
so now the close timer applies only when using the QSystemTrayIcon.
That's because QSystemTrayIcon does not inform its caller when it
is closed.

Changed the way NotificationPresenterClientQt is deleted because it
is being accessed when GC is deleting the Notification objects.
NotificationPresenterClientQt is now detaching itself from the
Notifications before it is deleted.

  • Api/qwebkitplatformplugin.h:

(QWebNotificationPresenter::QWebNotificationPresenter):
(QWebNotificationPresenter::~QWebNotificationPresenter):
(QWebKitPlatformPlugin::):

  • WebCoreSupport/NotificationPresenterClientQt.cpp:

(WebCore::NotificationIconWrapper::NotificationIconWrapper):
(WebCore::NotificationIconWrapper::title):
(WebCore::NotificationIconWrapper::message):
(WebCore::NotificationIconWrapper::iconData):
(WebCore::NotificationPresenterClientQt::~NotificationPresenterClientQt):
(WebCore::NotificationIconWrapper::notificationClosed):
(WebCore::NotificationPresenterClientQt::displayNotification):
(WebCore::NotificationPresenterClientQt::cancel):
(WebCore::NotificationPresenterClientQt::notificationForWrapper):
(WebCore::NotificationPresenterClientQt::removeReplacedNotificationFromQueue):
(WebCore::NotificationPresenterClientQt::detachNotification):

  • WebCoreSupport/NotificationPresenterClientQt.h:
  • WebCoreSupport/QtPlatformPlugin.cpp:

(WebCore::QtPlatformPlugin::createNotificationPresenter):

  • WebCoreSupport/QtPlatformPlugin.h:
  • examples/platformplugin/WebNotificationPresenter.cpp: Added.

(WebNotificationWidget::WebNotificationWidget):
(WebNotificationWidget::~WebNotificationWidget):
(WebNotificationWidget::showNotification):
(WebNotificationWidget::event):

  • examples/platformplugin/WebNotificationPresenter.h: Added.

(WebNotificationPresenter::WebNotificationPresenter):
(WebNotificationPresenter::~WebNotificationPresenter):
(WebNotificationPresenter::showNotification):

  • examples/platformplugin/WebPlugin.cpp:

(WebPlugin::supportsExtension):

  • examples/platformplugin/WebPlugin.h:

(WebPlugin::createNotificationPresenter):

  • examples/platformplugin/platformplugin.pro:
  • examples/platformplugin/qwebkitplatformplugin.h:

(QWebNotificationPresenter::QWebNotificationPresenter):
(QWebNotificationPresenter::~QWebNotificationPresenter):
(QWebKitPlatformPlugin::):

6:42 AM Changeset in webkit [61120] by bulach@chromium.org
  • 17 edits
    3 copies
    3 adds in trunk

2010-06-08 Marcus Bulach <​bulach@chromium.org>

Reviewed by Jeremy Orlow.

Adds IndexedDB's KeyRange.
​https://bugs.webkit.org/show_bug.cgi?id=40250

  • storage/indexeddb/idb-keyrange-expected.txt: Added.
  • storage/indexeddb/idb-keyrange.html: Added.
  • storage/indexeddb/script-tests/idb-keyrange.js: Added. (checkSingleKeyRange): (checkLeftBoundKeyRange): ():

2010-06-08 Marcus Bulach <​bulach@chromium.org>

Reviewed by Jeremy Orlow.

Adds IndexedDB's KeyRange.
​https://bugs.webkit.org/show_bug.cgi?id=40250

Test: storage/indexeddb/idb-keyrange.html

  • Android.derived.jscbindings.mk:
  • Android.derived.v8bindings.mk:
  • Android.mk:
  • CMakeLists.txt:
  • DerivedSources.cpp:
  • DerivedSources.make:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pri:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • storage/IDBKeyRange.cpp: Added. (WebCore::IDBKeyRange::IDBKeyRange):
  • storage/IDBKeyRange.h: Added. (WebCore::IDBKeyRange::): (WebCore::IDBKeyRange::create): (WebCore::IDBKeyRange::~IDBKeyRange): (WebCore::IDBKeyRange::left): (WebCore::IDBKeyRange::right): (WebCore::IDBKeyRange::flags):
  • storage/IDBKeyRange.idl: Added.
  • storage/IndexedDatabaseRequest.cpp: (WebCore::IndexedDatabaseRequest::makeSingleKeyRange): (WebCore::IndexedDatabaseRequest::makeLeftBoundKeyRange): (WebCore::IndexedDatabaseRequest::makeRightBoundKeyRange): (WebCore::IndexedDatabaseRequest::makeBoundKeyRange):
  • storage/IndexedDatabaseRequest.h:
  • storage/IndexedDatabaseRequest.idl:
6:28 AM Changeset in webkit [61119] by jorlow@chromium.org
  • 2 edits in trunk/WebCore

2010-06-14 Jeremy Orlow <​jorlow@chromium.org>

And another.

  • storage/IndexedDatabaseRequest.h:
6:21 AM Changeset in webkit [61118] by jorlow@chromium.org
  • 4 edits in trunk

2010-06-14 Jeremy Orlow <​jorlow@chromium.org>

More build fixes.

  • storage/IndexedDatabaseRequest.h:

2010-06-14 Jeremy Orlow <​jorlow@chromium.org>

Build fix.

  • src/IDBCallbacksProxy.h:
6:05 AM Changeset in webkit [61117] by Csaba Osztrogonác
  • 17 edits
    2 adds in trunk

[Qt] navigator.geolocation support for Qt port
​https://bugs.webkit.org/show_bug.cgi?id=39724

Patch by Mahesh Kulkarni <​mahesh.kulkarni@nokia.com> on 2010-06-14
Reviewed by Laszlo Gombos.

WebCore:

Implemetion for Qt port of navigator.gelocation. Using qtmobility location service.

  • WebCore.pri:
  • WebCore.pro:
  • platform/qt/GeolocationServiceQt.cpp: Added.

(WebCore::GeolocationServiceQt::create):
(WebCore::GeolocationServiceQt::GeolocationServiceQt):
(WebCore::GeolocationServiceQt::~GeolocationServiceQt):
(WebCore::GeolocationServiceQt::positionUpdated):
(WebCore::GeolocationServiceQt::startUpdating):
(WebCore::GeolocationServiceQt::stopUpdating):

  • platform/qt/GeolocationServiceQt.h: Added.

(WebCore::GeolocationServiceQt::lastPosition):
(WebCore::GeolocationServiceQt::lastError):

WebKit/qt:

Implement ChromeClientQt::requestGeolocationPermissionForFrame() which delegates call to QWebPage::allowGeolocationRequest
Layout and unit test cases for the are also added.

  • Api/qwebpage.cpp:

(QWebPage::allowGeolocationRequest):

  • Api/qwebpage.h:
  • WebCoreSupport/ChromeClientQt.cpp:

(WebCore::ChromeClientQt::requestGeolocationPermissionForFrame):

  • WebCoreSupport/DumpRenderTreeSupportQt.cpp:

(DumpRenderTreeSupportQt::setMockGeolocationPosition):
(DumpRenderTreeSupportQt::setMockGeolocationError):

  • WebCoreSupport/DumpRenderTreeSupportQt.h:
  • tests/qwebpage/tst_qwebpage.cpp:

(JSTestPage::shouldInterruptJavaScript):
(JSTestPage::allowGeolocationRequest):
(JSTestPage::setGeolocationPermission):
(tst_QWebPage::geolocationRequestJS):

WebKitTools:

Implementation for geolocation cases to DumpRenderTreeQt

  • DumpRenderTree/qt/DumpRenderTreeQt.cpp:

(WebCore::WebPage::allowGeolocationRequest):

  • DumpRenderTree/qt/DumpRenderTreeQt.h:
  • DumpRenderTree/qt/LayoutTestControllerQt.cpp:

(LayoutTestController::setGeolocationPermission):
(LayoutTestController::setMockGeolocationError):
(LayoutTestController::setMockGeolocationPosition):

  • DumpRenderTree/qt/LayoutTestControllerQt.h:

(LayoutTestController::isGeolocationPermissionSet):
(LayoutTestController::geolocationPermission):

LayoutTests:

Uncommenting gelocation cases from Qt. Skipped one case: fast/dom/Geolocation/callback-to-remote-context2.html

  • platform/qt/Skipped:
5:57 AM Changeset in webkit [61116] by jorlow@chromium.org
  • 3 edits in trunk/WebCore

2010-06-14 Jeremy Orlow <​jorlow@chromium.org>

2 more build fixes.

  • storage/IDBDatabaseImpl.h:
  • storage/IndexedDatabaseRequest.h:
5:48 AM Changeset in webkit [61115] by jorlow@chromium.org
  • 2 edits in trunk/WebCore

2010-06-14 Jeremy Orlow <​jorlow@chromium.org>

Unreviewed build fix for my last.

  • workers/WorkerScriptLoaderClient.h:
5:35 AM Changeset in webkit [61114] by jorlow@chromium.org
  • 3 edits in trunk/WebCore

2010-06-14 Jeremy Orlow <​jorlow@chromium.org>

Reviewed by Darin Fisher.

[V8] Clean up SerializedScriptValue
​https://bugs.webkit.org/show_bug.cgi?id=40482

SerializedScriptValue doesn't follow WebKit's style guidelines very well
and needlessly inlines quite a bit within the .h file. This change cleans
things up. No funcitonal changes.

No change in behavior.

  • bindings/v8/SerializedScriptValue.cpp: (WebCore::SerializedScriptValue::deserializeAndSetProperty): (WebCore::SerializedScriptValue::create): (WebCore::SerializedScriptValue::createFromWire): (WebCore::SerializedScriptValue::release): (WebCore::SerializedScriptValue::SerializedScriptValue):
  • bindings/v8/SerializedScriptValue.h:
5:32 AM Changeset in webkit [61113] by loislo@chromium.org
  • 37 edits in trunk

2010-06-14 Ilya Tikhonovsky <​loislo@chromium.org>

Reviewed by Pavel Feldman.

WebInspector: On the way to Remote Debugging we want to transfer dom/timeline/etc
data from inspected page to WebInspector as JSON string via http. The native
serialization to JSON string is supported by InspectorValue's classes. This patch
has the implementation of sendMessageToFrontend function. WebKit version of it still
uses ScriptFunctionCall and will be switched to another transport a little bit later.
​https://bugs.webkit.org/show_bug.cgi?id=40134

  • inspector/InspectorClient.h:
  • inspector/InspectorController.cpp: (WebCore::InspectorController::connectFrontend): (WebCore::InspectorController::disconnectFrontend):
  • inspector/InspectorController.h:
  • inspector/InspectorFrontend.cpp: (WebCore::InspectorFrontend::InspectorFrontend):
  • inspector/InspectorFrontend.h:
  • inspector/InspectorFrontendClientLocal.cpp: (WebCore::InspectorFrontendClientLocal::frontendLoaded):
  • inspector/InspectorValues.cpp: (WebCore::InspectorObject::writeJSON):
  • inspector/front-end/inspector.js: (WebInspector.dispatchMessageToFrontend):
  • loader/EmptyClients.h: (WebCore::EmptyInspectorClient::sendMessageToFrontend):
5:09 AM Changeset in webkit [61112] by eric@webkit.org
  • 13 edits in trunk

2010-06-14 Jeremy Orlow <​jorlow@chromium.org>

Reviewed by Darin Adler.

Reenable IDBDatabaseRequest's description attribute
​https://bugs.webkit.org/show_bug.cgi?id=39826

Existing test now fixed.

  • storage/indexeddb/idb-database-request-expected.txt:

2010-06-14 Jeremy Orlow <​jorlow@chromium.org>

Reviewed by Darin Adler.

Reenable IDBDatabaseRequest's description attribute
​https://bugs.webkit.org/show_bug.cgi?id=39826

On the 26th, Beth commented out the description attribute in
IDBDatabaseRequest because it was causing problems with the
objective c bindings. Turns out that this is the same bug as
in ​http://trac.webkit.org/changeset/19486. (Thanks for the
pointer, Mark!)

The solution is to change the objective C bindings generator
to change the name in the generated code. id and hash both
just appended "Name" to them in the past. I couldn't think
of anything else particularly better to append, so I just
went with name as well.

Test: building the world works on the first try. Layout

test verifies description works again.

  • bindings/scripts/CodeGeneratorObjC.pm:
  • bindings/scripts/test/GObject/WebKitDOMTestObj.cpp: (webkit_dom_test_obj_get_description): (webkit_dom_test_obj_get_id): (webkit_dom_test_obj_set_id): (webkit_dom_test_obj_get_hash): (webkit_dom_test_obj_set_property): (webkit_dom_test_obj_get_property): (webkit_dom_test_obj_class_init):
  • bindings/scripts/test/GObject/WebKitDOMTestObj.h:
  • bindings/scripts/test/JS/JSTestObj.cpp: (WebCore::): (WebCore::jsTestObjDescription): (WebCore::jsTestObjId): (WebCore::jsTestObjHash): (WebCore::setJSTestObjId):
  • bindings/scripts/test/JS/JSTestObj.h:
  • bindings/scripts/test/ObjC/DOMTestObj.h:
  • bindings/scripts/test/ObjC/DOMTestObj.mm: (-[DOMTestObj descriptionName]): (-[DOMTestObj idName]): (-[DOMTestObj setIdName:]): (-[DOMTestObj hashName]):
  • bindings/scripts/test/TestObj.idl:
  • bindings/scripts/test/V8/V8TestObj.cpp: (WebCore::TestObjInternal::descriptionAttrGetter): (WebCore::TestObjInternal::idAttrGetter): (WebCore::TestObjInternal::idAttrSetter): (WebCore::TestObjInternal::hashAttrGetter): (WebCore::):
  • storage/IDBDatabaseRequest.idl:
12:55 AM Changeset in webkit [61111] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

Unreviewed trivial fix.

[Qt] Update platform specific expected file after r61100.

  • platform/qt/fast/dom/Window/window-properties-expected.txt: updated.
Note: See TracTimeline for information about the timeline view.