⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Jun 18, 2010:

11:54 PM Changeset in webkit [61466] by aa@chromium.org
  • 5 edits in trunk

2010-06-18 Aaron Boodman <​aa@chromium.org>

WebKit API: Undo static hooks into V8 when WebKit is shut down.
​https://bugs.webkit.org/show_bug.cgi?id=40816

  • bindings/v8/V8DOMWindowShell.cpp: (WebCore::V8DOMWindowShell::initContextIfNeeded): (WebCore::V8DOMWindowShell::initializeV8IfNeeded): (WebCore::V8DOMWindowShell::uninitializeV8IfNeeded):
  • bindings/v8/V8DOMWindowShell.h:

2010-06-18 Aaron Boodman <​aa@chromium.org>

WebKit API: Undo static hooks into V8 when WebKit is shut downm
​https://bugs.webkit.org/show_bug.cgi?id=40816

  • src/WebKit.cpp: (WebKit::shutdown): Call new WebCore::V8DOMWindowShell::uninitializeV8IfNeeded().
9:33 PM Changeset in webkit [61465] by rwlbuis@webkit.org
  • 1 edit
    1 move
    3 adds in trunk/LayoutTests

2010-06-18 Rob Buis <​rwlbuis@gmail.com>

Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=19575
layout test svg/batik/text/textDecoration.svg hangs

Reenable this test since crash is gone (tested on OS X 10.5.8).

  • platform/mac/svg/batik/text/textDecoration-expected.checksum: Added.
  • platform/mac/svg/batik/text/textDecoration-expected.png: Added.
  • platform/mac/svg/batik/text/textDecoration-expected.txt: Added.
  • svg/batik/text/textDecoration.svg: Renamed from LayoutTests/svg/batik/text/textDecoration.svg-disabled.
8:35 PM Changeset in webkit [61464] by abarth@webkit.org
  • 6 edits in trunk/WebKit/mac

2010-06-18 Adam Barth <​abarth@webkit.org>

Unreviewed, rolling out r61459.
​http://trac.webkit.org/changeset/61459
​https://bugs.webkit.org/show_bug.cgi?id=40869

Seems to have broken two tests on the Tiger buildbot:

dom/html/level2/html/AppletsCollection.html
plugins/qt-qwidget-plugin.html

Anders wasn't on #webkit...

  • Plugins/Hosted/NetscapePluginHostManager.mm: (WebKit::NetscapePluginHostManager::spawnPluginHost):
  • Plugins/WebBasePluginPackage.h:
  • Plugins/WebBasePluginPackage.mm: (-[WebBasePluginPackage initWithPath:]): (-[WebBasePluginPackage getPluginInfoFromPLists]): (-[WebBasePluginPackage dealloc]): (-[WebBasePluginPackage name]): (-[WebBasePluginPackage path]): (-[WebBasePluginPackage filename]): (-[WebBasePluginPackage pluginDescription]): (-[WebBasePluginPackage setName:]): (-[WebBasePluginPackage setPath:]): (-[WebBasePluginPackage setPluginDescription:]): (-[WebBasePluginPackage description]): (-[WebBasePluginPackage isJavaPlugIn]):
  • Plugins/WebNetscapePluginPackage.mm: (-[WebNetscapePluginPackage getPluginInfoFromResources]): (-[WebNetscapePluginPackage _tryLoad]): (-[WebNetscapePluginPackage _unloadWithShutdown:]):
  • Plugins/WebPluginPackage.mm: (-[WebPluginPackage load]):
8:23 PM Changeset in webkit [61463] by jberlin@webkit.org
  • 2 edits in trunk/WebCore

Bug 19509 - Database Tables in the Inspector should be sortable
​https://bugs.webkit.org/show_bug.cgi?id=19509

Reviewed by Darin Adler.

  • inspector/front-end/StoragePanel.js:

(WebInspector.StoragePanel.prototype.dataGridForResult):
Make each column in the DataGrid sortable.
(WebInspector.StoragePanel.prototype._sortDataGrid.comparator):
Make sure to sort numeric columns by their numeric values, instead of lexicographically.
(WebInspector.StoragePanel.prototype._sortDataGrid):
Sort the entries in the DataGrid based on the selected column.

8:18 PM Changeset in webkit [61462] by Dimitri Glazkov
  • 2 edits in trunk/WebCore

2010-06-18 Dimitri Glazkov <Dimitri Glazkov>

Unreviewed, build fix.

  • WebCore.gyp/WebCore.gyp: Modified inclusion rule in to actually add WebSystemInterface.mm.
6:15 PM Changeset in webkit [61461] by andersca@apple.com
  • 2 edits in trunk/WebKit/mac

Fix Tiger build.

  • Plugins/WebBasePluginPackage.mm:

(-[WebBasePluginPackage isJavaPlugIn]):

6:07 PM Changeset in webkit [61460] by andersca@apple.com
  • 4 edits in trunk/WebCore

More clang++ warning fixes.

Reviewed by Oliver Hunt.

  • inspector/InspectorFrontendClientLocal.cpp:

(WebCore::InspectorFrontendClientLocal::restoreAttachedWindowHeight):

  • platform/graphics/mac/FontPlatformData.h:
  • platform/graphics/mac/WebLayer.mm:

(-[CALayer _descriptionWithPrefix:]):

5:35 PM Changeset in webkit [61459] by andersca@apple.com
  • 6 edits in trunk/WebKit/mac

2010-06-18 Anders Carlsson <​andersca@apple.com>

Reviewed by Sam Weinig.

Change some WebPluginDabase ivars to use WebCore::String instead of NSString.
​https://bugs.webkit.org/show_bug.cgi?id=40869

  • Plugins/Hosted/NetscapePluginHostManager.mm: (WebKit::NetscapePluginHostManager::spawnPluginHost):
  • Plugins/WebBasePluginPackage.h:
  • Plugins/WebBasePluginPackage.mm: (-[WebBasePluginPackage initWithPath:]): (-[WebBasePluginPackage getPluginInfoFromPLists]): (-[WebBasePluginPackage dealloc]): (-[WebBasePluginPackage name]): (-[WebBasePluginPackage path]): (-[WebBasePluginPackage filename]): (-[WebBasePluginPackage pluginDescription]): (-[WebBasePluginPackage description]): (-[WebBasePluginPackage isJavaPlugIn]):
  • Plugins/WebNetscapePluginPackage.mm: (-[WebNetscapePluginPackage getPluginInfoFromResources]): (-[WebNetscapePluginPackage _tryLoad]): (-[WebNetscapePluginPackage _unloadWithShutdown:]):
  • Plugins/WebPluginPackage.mm: (-[WebPluginPackage load]):
5:15 PM Changeset in webkit [61458] by atwilson@chromium.org
  • 6 edits in trunk

[Chromium] Plumbing for top-level frame names
​https://bugs.webkit.org/show_bug.cgi?id=40430

Reviewed by Darin Fisher.

WebKit/chromium:

  • public/WebFrame.h:

Removed obsolete clearName() API and added better documentation for
setName().

  • src/WebFrameImpl.cpp:

Removed clearName() API.

  • src/WebFrameImpl.h:

Removed clearName() API.

WebKitTools:

  • DumpRenderTree/chromium/WebViewHost.cpp:

(WebViewHost::reset):
Changed obsolete call to clearName() to use setName(WebString()) instead.

5:15 PM Changeset in webkit [61457] by ap@apple.com
  • 1 edit
    2 adds in trunk/LayoutTests

Test by Chris Brichford.

​https://bugs.webkit.org/show_bug.cgi?id=19759
ChildNodeList for an attribute node is not properly invalidated after appending a child

This issue has been fixed in another bug, just landing an additional test.

  • fast/dom/Attr/child-nodes-length-cache-expected.txt: Added.
  • fast/dom/Attr/child-nodes-length-cache.html: Added.
5:01 PM Changeset in webkit [61456] by andersca@apple.com
  • 3 edits
    1 move in trunk/WebKit

WebKit: Rename WebPluginPackage.m to make it an Objective-C++ file.

Reviewed by Sam Weinig.

  • WebKit.xcodeproj/project.pbxproj:

WebKit/mac: Rename WebPluginPackage.m to make it an Objective-C++ file.

Reviewed by Sam Weinig.

  • Plugins/WebPluginPackage.m: Removed.
  • Plugins/WebPluginPackage.mm: Copied from Plugins/WebPluginPackage.m.
4:56 PM Changeset in webkit [61455] by Dimitri Glazkov
  • 2 edits in trunk/WebCore

2010-06-18 Dimitri Glazkov <Dimitri Glazkov>

Unreviewed, build fix.

  • WebCore.gyp/WebCore.gyp: Renamed WebSystemInterface.m to WebSystemInterface.mm.
4:51 PM Changeset in webkit [61454] by andersca@apple.com
  • 5 edits in trunk/WebKit/mac

2010-06-18 Anders Carlsson <​andersca@apple.com>

Reviewed by Sam Weinig.

Get rid of the NSEnumerators from WebBasePluginPackage
​https://bugs.webkit.org/show_bug.cgi?id=40868

  • Plugins/WebBasePluginPackage.h:
  • Plugins/WebBasePluginPackage.mm: (-[WebBasePluginPackage MIMETypes]): (-[WebBasePluginPackage supportsExtension:]): (-[WebBasePluginPackage supportsMIMEType:]):
  • Plugins/WebPluginDatabase.mm: (-[WebPluginDatabase pluginForMIMEType:]): (-[WebPluginDatabase pluginForExtension:]): (-[WebPluginDatabase refresh]): (-[WebPluginDatabase _removePlugin:]):
  • WebCoreSupport/WebPlatformStrategies.mm: (WebPlatformStrategies::getPluginInfo):
4:23 PM Changeset in webkit [61453] by andersca@apple.com
  • 10 edits
    2 moves in trunk

2010-06-18 Anders Carlsson <​andersca@apple.com>

Reviewed by Sam Weinig.

Make WebCoreSystemInterface.h a C++ only header
​https://bugs.webkit.org/show_bug.cgi?id=40867

  • WebKit.xcodeproj/project.pbxproj:

2010-06-18 Anders Carlsson <​andersca@apple.com>

Reviewed by Sam Weinig.

Make WebCoreSystemInterface.h a C++ only header
​https://bugs.webkit.org/show_bug.cgi?id=40867

  • WebCoreSupport/WebSystemInterface.h:
  • WebCoreSupport/WebSystemInterface.m: Removed.
  • WebCoreSupport/WebSystemInterface.mm: Copied from WebKit/mac/WebCoreSupport/WebSystemInterface.m.

2010-06-18 Anders Carlsson <​andersca@apple.com>

Reviewed by Sam Weinig.

Make WebCoreSystemInterface.h a C++ only header
​https://bugs.webkit.org/show_bug.cgi?id=40867

  • platform/mac/WebCoreSystemInterface.h:

2010-06-18 Anders Carlsson <​andersca@apple.com>

Reviewed by Sam Weinig.

Make WebCoreSystemInterface.h a C++ only header
​https://bugs.webkit.org/show_bug.cgi?id=40867

  • WebKit2.xcodeproj/project.pbxproj:
  • WebProcess/WebCoreSupport/mac/WebSystemInterface.h:
  • WebProcess/WebCoreSupport/mac/WebSystemInterface.m: Removed.
  • WebProcess/WebCoreSupport/mac/WebSystemInterface.mm: Copied from WebKit2/WebProcess/WebCoreSupport/mac/WebSystemInterface.m.
  • mac/WebKit2.exp:
4:17 PM Changeset in webkit [61452] by andersca@apple.com
  • 4 edits in trunk/WebKit/mac

2010-06-18 Anders Carlsson <​andersca@apple.com>

Reviewed by Sam Weinig.

Clean up WebPluginDatabase.mm
​https://bugs.webkit.org/show_bug.cgi?id=40866

  • Plugins/WebBasePluginPackage.h:
  • Plugins/WebBasePluginPackage.mm: (pathByResolvingSymlinksAndAliases): (-[WebBasePluginPackage initWithPath:]): Change an instance method into a static function.


  • Plugins/WebPluginDatabase.mm: (PluginPackageCandidates::PluginPackageCandidates): (PluginPackageCandidates::update): (PluginPackageCandidates::bestCandidate): Add a new PluginPackageCandidates class.


(-[WebPluginDatabase pluginForKey:withEnumeratorSelector:]):
Use PluginPackageCandidates here.

4:13 PM Changeset in webkit [61451] by levin@chromium.org
  • 4 edits
    2 adds in trunk

WebCore: Convert column span from an unsigned short type to an unsigned int
type. Fixes a divide-by-zero crash arising from using a zero colspan
value coming from a narrow cast of an int to an unsigned short.
​https://bugs.webkit.org/show_bug.cgi?id=40812

Patch by Abhishek Arya <​inferno@chromium.org> on 2010-06-18
Reviewed by Adam Barth.

Test: fast/table/zero-colspan-crash.html

  • rendering/RenderTable.h: Change span from unsigned short to unsigned int.
  • rendering/RenderTableSection.cpp: Fix a compiler warning with comparing unsigned int with signed int. Value of an unsigned int here cannot be greater than maximum positive value of a signed int.

(WebCore::RenderTableSection::addCell):

LayoutTests: Tests that we do not crash while rendering a fixed table layout.
​https://bugs.webkit.org/show_bug.cgi?id=40812

Patch by Abhishek Arya <​inferno@chromium.org> on 2010-06-18
Reviewed by Adam Barth.

  • fast/table/zero-colspan-crash-expected.txt: Added.
  • fast/table/zero-colspan-crash.html: Added.
4:09 PM Changeset in webkit [61450] by oliver@apple.com
  • 4 edits in trunk

2010-06-18 Oliver Hunt <​oliver@apple.com>

Reviewed by Geoffrey Garen.

Incorrect handling of multiple BOMs scattered through a file.
​https://bugs.webkit.org/show_bug.cgi?id=40865

When determining the offset of open and close braces in a source
with BOMs we were finishing our count early as we failed to account
for BOMs prior to the open/close brace positions effecting those
positions.

  • parser/Lexer.cpp: (JSC::Lexer::sourceCode):

2010-06-18 Oliver Hunt <​oliver@apple.com>

Reviewed by Geoffrey Garen.

Incorrect handling of multiple BOMs scattered through a file.
​https://bugs.webkit.org/show_bug.cgi?id=40865

Put a few more BOMs into this testcase so that it hits the other cases
that were missed before.

  • fast/js/resources/bom-in-file-retains-correct-offset.js: (g.f): (g):
4:01 PM Changeset in webkit [61449] by andersca@apple.com
  • 2 edits in trunk/WebKit/mac

Fix Tiger build.

  • WebCoreSupport/WebPlatformStrategies.mm:
3:30 PM Changeset in webkit [61448] by Dimitri Glazkov
  • 11 edits
    2 deletes in trunk/LayoutTests

2010-06-18 Dimitri Glazkov <Dimitri Glazkov>

Unreviewed, expectations update.

Update a few more chromium-win baselines after ​http://trac.webkit.org/changeset/61393.

3:20 PM Changeset in webkit [61447] by andersca@apple.com
  • 3 edits
    2 adds in trunk/WebKit2

2010-06-18 Anders Carlsson <​andersca@apple.com>

Reviewed by Sam Weinig.

Add platform strategies for WebKit2.
​https://bugs.webkit.org/show_bug.cgi?id=40863

  • WebKit2.xcodeproj/project.pbxproj:
  • WebProcess/WebCoreSupport/WebPlatformStrategies.cpp: Added. (WebKit::WebPlatformStrategies::initialize): (WebKit::WebPlatformStrategies::WebPlatformStrategies): (WebKit::WebPlatformStrategies::createPluginStrategy): (WebKit::WebPlatformStrategies::refreshPlugins): (WebKit::WebPlatformStrategies::getPluginInfo):
  • WebProcess/WebCoreSupport/WebPlatformStrategies.h: Added.
  • WebProcess/WebProcess.cpp: (WebKit::WebProcess::WebProcess):
3:16 PM Changeset in webkit [61446] by Dimitri Glazkov
  • 3 edits
    1 add
    1 delete in trunk/LayoutTests

2010-06-18 Dimitri Glazkov <Dimitri Glazkov>

Unreviewed, expectations update.

Update a few more chromium-mac baselines after ​http://trac.webkit.org/changeset/61393.

3:11 PM Changeset in webkit [61445] by Simon Hausmann
  • 2 edits in trunk/WebCore

[Qt] Text spacing miscalculation when using wordSpacing.
​https://bugs.webkit.org/show_bug.cgi?id=40483

Patch by Ananth Jasty <​ext-ananth.jasty@nokia.com> on 2010-06-18
Reviewed by Simon Hausmann.

Removed wordSpacing compensation in FontQt whitespace width
calculation. The QFontMetrics::width() overload that takes
a character does not take QFont's word spacing into account.

  • platform/graphics/qt/FontQt.cpp:

(WebCore::Font::floatWidthForComplexText):

3:08 PM Changeset in webkit [61444] by andersca@apple.com
  • 10 edits
    1 delete in trunk

2010-06-18 Anders Carlsson <​andersca@apple.com>

Reviewed by Darin Adler.

Get rid of PluginDataMac.mm and use the plug-in strategy instead
​https://bugs.webkit.org/show_bug.cgi?id=40860

  • Plugins/WebBasePluginPackage.h:
  • WebCoreSupport/WebPlatformStrategies.h:
  • WebCoreSupport/WebPlatformStrategies.mm: (WebPlatformStrategies::createPluginStrategy): (WebPlatformStrategies::refreshPlugins): (WebPlatformStrategies::getPluginInfo):
  • WebCoreSupport/WebViewFactory.mm:

2010-06-18 Anders Carlsson <​andersca@apple.com>

Reviewed by Darin Adler.

Get rid of PluginDataMac.mm and use the plug-in strategy instead
​https://bugs.webkit.org/show_bug.cgi?id=40860

  • WebCore.xcodeproj/project.pbxproj:
  • page/mac/WebCoreViewFactory.h:
  • plugins/PluginData.cpp: (WebCore::PluginData::refresh): (WebCore::PluginData::initPlugins):
  • plugins/PluginStrategy.h:
  • plugins/mac/PluginDataMac.mm: Removed.
2:52 PM Changeset in webkit [61443] by weinig@apple.com
  • 9 edits
    5 adds
    1 delete in trunk
2:50 PM Changeset in webkit [61442] by Dimitri Glazkov
  • 18 edits in trunk/LayoutTests

2010-06-18 Dimitri Glazkov <Dimitri Glazkov>

Unreviewed, expectations update.

Update chromium baselines after ​http://trac.webkit.org/changeset/61418.

2:48 PM Changeset in webkit [61441] by andersca@apple.com
  • 7 edits in trunk/WebCore

Fix some (not all) clang++ warnings.

Reviewed by Dan Bernstein.

  • dom/Position.h:

(WebCore::lastOffsetInNode):

  • editing/CompositeEditCommand.cpp:

(WebCore::CompositeEditCommand::deleteInsignificantText):

  • loader/appcache/ApplicationCache.cpp:

(WebCore::ApplicationCache::resourceForRequest):

  • platform/graphics/mac/ComplexTextController.cpp:

(WebCore::ComplexTextController::offsetForPosition):
(WebCore::ComplexTextController::collectComplexTextRuns):

  • platform/network/CredentialStorage.cpp:

(WebCore::protectionSpaceMapKeyFromURL):

  • rendering/style/StyleRareNonInheritedData.h:
2:44 PM Changeset in webkit [61440] by Martin Robinson
  • 2 edits in trunk/LayoutTests

2010-06-18 Martin Robinson <​mrobinson@igalia.com>

Unreviewed.

Skipped some failing tests and conglomerated a skipped test into another group.

  • platform/gtk/Skipped: Cleanups and three more skipped tests.
2:40 PM Changeset in webkit [61439] by Dimitri Glazkov
  • 285 edits
    58 adds
    44 deletes in trunk/LayoutTests

2010-06-18 Dimitri Glazkov <Dimitri Glazkov>

Unreviewed, expectations update.

Update chromium-linux baselines after ​http://trac.webkit.org/changeset/61393.

2:23 PM Changeset in webkit [61438] by andersca@apple.com
  • 8 edits
    2 adds in trunk

2010-06-18 Anders Carlsson <​andersca@apple.com>

Reviewed by Dan Bernstein.

Add stubbed out WebPlatformStrategies class to WebKit.
​https://bugs.webkit.org/show_bug.cgi?id=40851

  • WebKit.xcodeproj/project.pbxproj:

2010-06-18 Anders Carlsson <​andersca@apple.com>

Reviewed by Dan Bernstein.

Add stubbed out WebPlatformStrategies class to WebKit.
​https://bugs.webkit.org/show_bug.cgi?id=40851

  • WebCoreSupport/WebPlatformStrategies.h: Added.
  • WebCoreSupport/WebPlatformStrategies.mm: Added. (WebPlatformStrategies::initialize): (WebPlatformStrategies::WebPlatformStrategies): (WebPlatformStrategies::createPluginStrategy):
  • WebView/WebView.mm: (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]):

2010-06-18 Anders Carlsson <​andersca@apple.com>

Reviewed by Dan Bernstein.

Add stubbed out WebPlatformStrategies class to WebKit.
​https://bugs.webkit.org/show_bug.cgi?id=40851

  • WebCore.base.exp:
  • platform/PlatformStrategies.cpp:
  • platform/PlatformStrategies.h: (WebCore::PlatformStrategies::~PlatformStrategies):
2:19 PM Changeset in webkit [61437] by Dimitri Glazkov
  • 798 edits
    73 adds in trunk/LayoutTests

2010-06-18 Dimitri Glazkov <Dimitri Glazkov>

Unreviewed, expectations update.

Update chromium-win baselines after ​http://trac.webkit.org/changeset/61393.

2:09 PM Changeset in webkit [61436] by andersca@apple.com
  • 4 edits in trunk/WebCore

Fix build errors when building with clang++.

Reviewed by Darin Adler.

  • loader/archive/cf/LegacyWebArchiveMac.mm:

Move the const qualifier to the right place.

  • page/EditorClient.h:
  • platform/Pasteboard.h:

Use @class when forward declaring Objective-C classes in Objective-C.

2:05 PM Changeset in webkit [61435] by ap@apple.com
  • 2 edits in trunk/WebCore

Reviewed by Geoff Garen.

​https://bugs.webkit.org/show_bug.cgi?id=40852
<rdar://problem/8105498> Limit simultaneous DNS prefetch request number (40852)

No change in functionality, so no tests.

We still queue up to 64 names, but only make up to 8 requests at once. If there are names
remaining in queue, we retry after a short timeout (which is easier than posting
notifications from client callback).

  • platform/network/cf/DNSCFNet.cpp: (WebCore::DNSResolveQueue::add): (WebCore::DNSResolveQueue::fired):
2:03 PM Changeset in webkit [61434] by Martin Robinson
  • 2 edits
    27 adds in trunk/LayoutTests

2010-06-18 Martin Robinson <​mrobinson@igalia.com>

Unreviewed.

Adding baselines for new tests and correcting one incorrect baseline.

  • platform/gtk/media/video-replaces-poster-expected.txt: Correting this incorrect baseline.
  • platform/gtk/svg/hixie/text/001-expected.txt: Added.
  • platform/gtk/svg/text/select-textLength-spacing-squeeze-1-expected.txt: Added.
  • platform/gtk/svg/text/select-textLength-spacing-squeeze-2-expected.txt: Added.
  • platform/gtk/svg/text/select-textLength-spacing-squeeze-3-expected.txt: Added.
  • platform/gtk/svg/text/select-textLength-spacing-squeeze-4-expected.txt: Added.
  • platform/gtk/svg/text/select-textLength-spacing-stretch-1-expected.txt: Added.
  • platform/gtk/svg/text/select-textLength-spacing-stretch-2-expected.txt: Added.
  • platform/gtk/svg/text/select-textLength-spacing-stretch-3-expected.txt: Added.
  • platform/gtk/svg/text/select-textLength-spacing-stretch-4-expected.txt: Added.
  • platform/gtk/svg/text/select-textLength-spacingAndGlyphs-squeeze-1-expected.txt: Added.
  • platform/gtk/svg/text/select-textLength-spacingAndGlyphs-squeeze-2-expected.txt: Added.
  • platform/gtk/svg/text/select-textLength-spacingAndGlyphs-squeeze-3-expected.txt: Added.
  • platform/gtk/svg/text/select-textLength-spacingAndGlyphs-squeeze-4-expected.txt: Added.
  • platform/gtk/svg/text/select-textLength-spacingAndGlyphs-stretch-1-expected.txt: Added.
  • platform/gtk/svg/text/select-textLength-spacingAndGlyphs-stretch-2-expected.txt: Added.
  • platform/gtk/svg/text/select-textLength-spacingAndGlyphs-stretch-3-expected.txt: Added.
  • platform/gtk/svg/text/select-textLength-spacingAndGlyphs-stretch-4-expected.txt: Added.
  • platform/gtk/svg/text/select-x-list-1-expected.txt: Added.
  • platform/gtk/svg/text/select-x-list-2-expected.txt: Added.
  • platform/gtk/svg/text/select-x-list-3-expected.txt: Added.
  • platform/gtk/svg/text/select-x-list-4-expected.txt: Added.
  • platform/gtk/svg/text/select-x-list-with-tspans-1-expected.txt: Added.
  • platform/gtk/svg/text/select-x-list-with-tspans-2-expected.txt: Added.
  • platform/gtk/svg/text/select-x-list-with-tspans-3-expected.txt: Added.
  • platform/gtk/svg/text/select-x-list-with-tspans-4-expected.txt: Added.
2:01 PM Changeset in webkit [61433] by robert@webkit.org
  • 4 edits in trunk

2010-06-18 Robert Hogan <​robert@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] pass plugins/open-and-close-window-with-plugin.html on Qt

Capture logDestroy messages from the test plugin. DRT's WebPage
is already destroyed by the time they are emitted.

​https://bugs.webkit.org/show_bug.cgi?id=33333

Unskip:
plugins/open-and-close-window-with-plugin.html
plugins/geturlnotify-during-document-teardown.html

  • platform/qt/Skipped:

2010-06-18 Robert Hogan <​robert@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] pass plugins/open-and-close-window-with-plugin.html on Qt

Capture logDestroy messages from the test plugin. DRT's WebPage
is already destroyed by the time they are emitted.

​https://bugs.webkit.org/show_bug.cgi?id=33333

Unskip:
plugins/open-and-close-window-with-plugin.html
plugins/geturlnotify-during-document-teardown.html

  • Api/qwebpage.cpp: (QWebPage::javaScriptConsoleMessage):
1:44 PM Changeset in webkit [61432] by zmo@google.com
  • 2 edits in trunk/WebCore

WebGL demos show bad flicker
​https://bugs.webkit.org/show_bug.cgi?id=38560

1:41 PM Changeset in webkit [61431] by Martin Robinson
  • 2 edits
    74 adds in trunk/LayoutTests

2010-06-18 Martin Robinson <​mrobinson@igalia.com>

Unreviewed.

Adding baselines for new tests. Some tests that fail have been labeled
with bug numbers. Also removed a newly defunct test from the skipped list.

  • platform/gtk/Skipped: Removed newly baselined tests and one defunct test.
  • platform/gtk/editing/selection/select-text-overflow-ellipsis-expected.txt: Added.
  • platform/gtk/fast/backgrounds/quirks-mode-line-box-backgrounds-expected.txt: Added.
  • platform/gtk/fast/css/css3-space-in-nth-and-lang-expected.txt: Added.
  • platform/gtk/fast/css/inline-element-line-break-expected.txt: Added.
  • platform/gtk/fast/css/non-standard-checkbox-size-expected.txt: Added.
  • platform/gtk/fast/css/pseudo-element-line-break-expected.txt: Added.
  • platform/gtk/fast/lists/w3-css3-list-styles-alphabetic-expected.txt: Added.
  • platform/gtk/fast/multicol/single-line-expected.txt: Added.
  • platform/gtk/fast/repaint/block-no-inflow-children-expected.txt: Added.
  • platform/gtk/fast/repaint/moving-shadow-on-container-expected.txt: Added.
  • platform/gtk/fast/repaint/moving-shadow-on-path-expected.txt: Added.
  • platform/gtk/fast/table/fixed-table-with-percent-inside-percent-table-expected.txt: Added.
  • platform/gtk/fast/table/fixed-table-with-percent-width-inside-auto-table-expected.txt: Added.
  • platform/gtk/fast/table/fixed-table-with-percent-width-inside-div-expected.txt: Added.
  • platform/gtk/fast/table/fixed-table-with-percent-width-inside-extra-large-div-expected.txt: Added.
  • platform/gtk/fast/table/fixed-table-with-percent-width-inside-fixed-width-table-expected.txt: Added.
  • platform/gtk/fast/table/fixed-table-with-small-percent-width-expected.txt: Added.
  • platform/gtk/media/video-replaces-poster-expected.txt: Added.
  • platform/gtk/svg/css/shadow-and-opacity-expected.txt: Copied from LayoutTests/platform/mac/svg/css/shadow-and-opacity-expected.txt.
  • platform/gtk/svg/custom/empty-mask-expected.txt: Added.
  • platform/gtk/svg/custom/js-repaint-rect-on-path-with-stroke-expected.txt: Copied from LayoutTests/platform/mac/svg/custom/js-repaint-rect-on-path-with-stroke-expected.txt.
  • platform/gtk/svg/custom/marker-opacity-expected.txt: Added.
  • platform/gtk/svg/custom/marker-referencePoint-expected.txt: Copied from LayoutTests/platform/mac/svg/custom/marker-referencePoint-expected.txt.
  • platform/gtk/svg/custom/mask-invalidation-expected.txt: Added.
  • platform/gtk/svg/custom/pattern-excessive-malloc-expected.txt: Added.
  • platform/gtk/svg/custom/pattern-size-bigger-than-target-size-expected.txt: Copied from LayoutTests/platform/mac/svg/custom/pattern-size-bigger-than-target-size-expected.txt.
  • platform/gtk/svg/custom/pattern-skew-transformed-expected.txt: Copied from LayoutTests/platform/mac/svg/custom/pattern-skew-transformed-expected.txt.
  • platform/gtk/svg/custom/relative-sized-content-expected.txt: Added.
  • platform/gtk/svg/custom/relative-sized-deep-shadow-tree-content-expected.txt: Added.
  • platform/gtk/svg/custom/relative-sized-shadow-tree-content-expected.txt: Added.
  • platform/gtk/svg/custom/stroke-width-large-expected.txt: Added.
  • platform/gtk/svg/custom/text-xy-updates-SVGList-expected.txt: Added.
  • platform/gtk/svg/filters/feDisplacementMap-expected.txt: Copied from LayoutTests/platform/mac/svg/filters/feDisplacementMap-expected.txt.
  • platform/gtk/svg/overflow/overflow-on-foreignObject-expected.txt: Copied from LayoutTests/platform/mac/svg/overflow/overflow-on-foreignObject-expected.txt.
  • platform/gtk/svg/overflow/overflow-on-inner-svg-element-defaults-expected.txt: Copied from LayoutTests/platform/mac/svg/overflow/overflow-on-inner-svg-element-defaults-expected.txt.
  • platform/gtk/svg/overflow/overflow-on-inner-svg-element-expected.txt: Copied from LayoutTests/platform/mac/svg/overflow/overflow-on-inner-svg-element-expected.txt.
  • platform/gtk/svg/overflow/overflow-on-outermost-svg-element-defaults-expected.txt: Added.
  • platform/gtk/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-1-expected.txt: Added.
  • platform/gtk/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-2-expected.txt: Added.
  • platform/gtk/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-3-expected.txt: Added.
  • platform/gtk/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-auto-expected.txt: Added.
  • platform/gtk/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-defaults-expected.txt: Added.
  • platform/gtk/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-hidden-expected.txt: Added.
  • platform/gtk/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-scroll-expected.txt: Added.
  • platform/gtk/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-visible-expected.txt: Added.
  • platform/gtk/svg/text/foreignObject-text-clipping-bug-expected.txt: Added.
  • platform/gtk/svg/text/selection-background-color-expected.txt: Added.
  • platform/gtk/svg/text/selection-doubleclick-expected.txt: Added.
  • platform/gtk/svg/text/selection-styles-expected.txt: Added.
  • platform/gtk/svg/text/selection-tripleclick-expected.txt: Added.
  • platform/gtk/svg/zoom/page/absolute-sized-document-no-scrollbars-expected.txt: Copied from LayoutTests/platform/mac/svg/zoom/page/absolute-sized-document-no-scrollbars-expected.txt.
  • platform/gtk/svg/zoom/page/absolute-sized-document-scrollbars-expected.txt: Added.
  • platform/gtk/svg/zoom/page/relative-sized-document-scrollbars-expected.txt: Added.
  • platform/gtk/svg/zoom/page/zoom-coords-viewattr-01-b-expected.txt: Added.
  • platform/gtk/svg/zoom/page/zoom-foreignObject-expected.txt: Added.
  • platform/gtk/svg/zoom/page/zoom-hixie-mixed-008-expected.txt: Added.
  • platform/gtk/svg/zoom/page/zoom-hixie-mixed-009-expected.txt: Added.
  • platform/gtk/svg/zoom/page/zoom-hixie-rendering-model-004-expected.txt: Added.
  • platform/gtk/svg/zoom/page/zoom-svg-float-border-padding-expected.txt: Added.
  • platform/gtk/svg/zoom/text/absolute-sized-document-no-scrollbars-expected.txt: Copied from LayoutTests/platform/mac/svg/zoom/text/absolute-sized-document-no-scrollbars-expected.txt.
  • platform/gtk/svg/zoom/text/absolute-sized-document-scrollbars-expected.txt: Copied from LayoutTests/platform/mac/svg/zoom/text/absolute-sized-document-scrollbars-expected.txt.
  • platform/gtk/svg/zoom/text/relative-sized-document-scrollbars-expected.txt: Copied from LayoutTests/platform/mac/svg/zoom/text/relative-sized-document-scrollbars-expected.txt.
  • platform/gtk/svg/zoom/text/zoom-coords-viewattr-01-b-expected.txt: Added.
  • platform/gtk/svg/zoom/text/zoom-foreignObject-expected.txt: Added.
  • platform/gtk/svg/zoom/text/zoom-hixie-mixed-008-expected.txt: Added.
  • platform/gtk/svg/zoom/text/zoom-hixie-rendering-model-004-expected.txt: Added.
  • platform/gtk/svg/zoom/text/zoom-svg-float-border-padding-expected.txt: Added.
  • platform/gtk/transforms/2d/hindi-rotated-expected.txt: Added.
1:14 PM Changeset in webkit [61430] by oliver@apple.com
  • 4 edits in trunk/JavaScriptCore

2010-06-17 Oliver Hunt <​oliver@apple.com>

Reviewed by Sam Weinig.

Don't throw away exception information for functions that use exceptions
​https://bugs.webkit.org/show_bug.cgi?id=40786

Simple patch to stop JSC from throwing away the exception information
of a function that uses "exceptiony" features like try and throw. This
is a speed up for catching expressions but it's difficult to quantify as
the old cost of reparsing is amortised over all exceptions caught in the
effected function.

  • bytecode/CodeBlock.cpp: (JSC::CodeBlock::reparseForExceptionInfoIfNecessary):
  • bytecompiler/BytecodeGenerator.cpp: (JSC::BytecodeGenerator::generate): (JSC::BytecodeGenerator::emitCatch):
  • bytecompiler/BytecodeGenerator.h: (JSC::BytecodeGenerator::emitThrow):
1:08 PM Changeset in webkit [61429] by andersca@apple.com
  • 5 edits
    3 adds in trunk

2010-06-18 Anders Carlsson <​andersca@apple.com>

Reviewed by Sam Weinig.

Add PlatformStrategies and PluginStrategy classes.
​https://bugs.webkit.org/show_bug.cgi?id=40850

  • wtf/Platform.h:

2010-06-18 Anders Carlsson <​andersca@apple.com>

Reviewed by Sam Weinig.

Add PlatformStrategies and PluginStrategy classes.
​https://bugs.webkit.org/show_bug.cgi?id=40850

  • WebCore.xcodeproj/project.pbxproj:
  • platform/PlatformStrategies.cpp: Added. (WebCore::PlatformStrategies::~PlatformStrategies): (WebCore::platformStrategies): (WebCore::setPlatformStrategies):
  • platform/PlatformStrategies.h: Added. (WebCore::PlatformStrategies::pluginStrategy): (WebCore::PlatformStrategies::PlatformStrategies):
  • plugins/PluginData.cpp:
  • plugins/PluginStrategy.h: Added. (WebCore::PluginStrategy::~PluginStrategy):
1:01 PM Changeset in webkit [61428] by Martin Robinson
  • 3 edits in trunk/WebCore

2010-06-18 Martin Robinson <​mrobinson@igalia.com>

Unreviewed.

Fix the GTK+ build after r61413 and 61379.

  • bindings/scripts/CodeGeneratorGObject.pm: Produce a g_value_set that uses getterExpressionPrefix instead of the raw getter.
  • bindings/scripts/test/GObject/WebKitDOMTestObj.cpp: (webkit_dom_test_obj_get_property): Update expected test results.
12:45 PM Changeset in webkit [61427] by Chris Fleizach
  • 3 edits in trunk/LayoutTests

No review. Fix Tiger and Leopards tests.

AX: presentational role needs to be inherited by required elements
​https://bugs.webkit.org/show_bug.cgi?id=40132

  • platform/mac-leopard/Skipped:
  • platform/mac-tiger/Skipped:
12:16 PM Changeset in webkit [61426] by leandro@webkit.org
  • 4 edits in trunk

2010-06-18 Leandro Pereira <​leandro@profusion.mobi>

[EFL] Unreviewed build fix.

  • wtf/CMakeLists.txt: Add MD5.cpp.

2010-06-18 Leandro Pereira <​leandro@profusion.mobi>

[EFL] Unreviewed build fix.

  • CMakeLists.txt: Add inspector/ScriptBreakpoint.cpp.
12:11 PM Changeset in webkit [61425] by aestes@apple.com
  • 2 edits in trunk/WebCore

Update copyright header.

Rubber-stamped by Sam Weinig.

  • html/HTMLLinkElement.h:
12:03 PM Changeset in webkit [61424] by aestes@apple.com
  • 4 edits
    2 adds in trunk

WebCore: <rdar://problem/8091385> Prevent a crash in WebCore when removing a stylesheet link element in
in a listener to its beforeload event.
​https://bugs.webkit.org/show_bug.cgi?id=40742

Reviewed by Dan Bernstein.

Postpone loading of link elements until after they have been inserted into the DOM and
attached. This prevents DOM mutations triggered by beforeload handlers from firing in the
midst of DOM insertion, which can lead to assertion failures and crashes.

Test: fast/dom/beforeload/remove-link-in-beforeload-listener.html

  • html/HTMLLinkElement.cpp:

(WebCore::HTMLLinkElement::HTMLLinkElement): Initialize m_shouldProcessAfterAttach to false.
(WebCore::HTMLLinkElement::processCallback): Add a static callback function which calls
HTMLLinkElement::process().
(WebCore::HTMLLinkElement::insertedIntoDocument): Instead of calling process() directly, set
m_shouldProcessAfterAttach to true to indicate that process() should be called after attach().
(WebCore::HTMLLinkElement::removedFromDocument): Set m_shouldProcessAfterAttach to false.
(WebCore::HTMLLinkElement::attach): If m_shouldProcessAfterAttach is true, register
HTMLLinkElement::processCallback() as a post-attach callback.

  • html/HTMLLinkElement.h: Add m_shouldProcessAfterAttach.

(WebCore::HTMLLinkElement::canLazyAttach): Override canLazyAttach() to return false to
indicate that a full attach should be performed. This ensures the post-attach callbacks are
fired.

LayoutTests: <rdar://problem/8091385> Test that removing a stylesheet link element in a listener to its
beforeload event does not crash WebCore.
​https://bugs.webkit.org/show_bug.cgi?id=40742

Reviewed by Dan Bernstein.

  • fast/dom/beforeload/remove-link-in-beforeload-listener-expected.txt: Added.
  • fast/dom/beforeload/remove-link-in-beforeload-listener.html: Added.
11:40 AM Changeset in webkit [61423] by Csaba Osztrogonác
  • 5 edits in trunk/LayoutTests

Unreviewed. Update Qt specific expected files after r61418.

  • platform/qt/editing/pasteboard/paste-text-005-expected.txt:
  • platform/qt/editing/pasteboard/paste-text-006-expected.txt:
  • platform/qt/editing/pasteboard/paste-text-007-expected.txt:
  • platform/qt/editing/pasteboard/paste-text-014-expected.txt:
11:20 AM WebKit Team edited by luiz@webkit.org
(diff)
11:18 AM Changeset in webkit [61422] by Chris Fleizach
  • 2 edits in trunk/WebCore

Unreviewed. Windows build fix.

AX: presentational role needs to be inherited by required elements
​https://bugs.webkit.org/show_bug.cgi?id=40132

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::inheritsPresentationalRole):

10:58 AM Changeset in webkit [61421] by Chris Fleizach
  • 4 edits
    2 adds in trunk

AX: presentational role needs to be inherited by required elements
​https://bugs.webkit.org/show_bug.cgi?id=40132

Reviewed by David Kilzer.

WebCore:

Test: platform/mac/accessibility/inherited-presentational-lists.html

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::accessibilityIsIgnored):
(WebCore::AccessibilityRenderObject::inheritsPresentationalRole):

  • accessibility/AccessibilityRenderObject.h:

(WebCore::AccessibilityRenderObject::node):

LayoutTests:

  • platform/mac/accessibility/inherited-presentational-lists-expected.txt: Added.
  • platform/mac/accessibility/inherited-presentational-lists.html: Added.
10:54 AM Changeset in webkit [61420] by Darin Adler
  • 3 edits in trunk/WebCore

Fix GTK build after reflection change.

  • bindings/scripts/CodeGeneratorGObject.pm: Changed code

that emits setters to convey the correct type of the attribute.
The GObject code generator takes a different approach to attributes
than the others, so it's hacked a bit to make it more like them.
We should find a way to share more code between the different generators.

  • bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:

Updated to expect correct results.

10:42 AM Changeset in webkit [61419] by yurys@chromium.org
  • 2 edits in trunk/WebCore

2010-06-18 Yury Semikhatsky <​yurys@chromium.org>

Unreviewed: Qt build fix.

  • inspector/InspectorController.cpp:
10:35 AM Changeset in webkit [61418] by justin.garcia@apple.com
  • 21 edits in trunk

​https://bugs.webkit.org/show_bug.cgi?id=39798
No selection change notification for editing operation that doesn't change the selection's DOM position

Reviewed by Ojan Vafai.

WebCore:

Some editing operations change the selection visually without affecting its position within
the DOM. This was previously known to occur for certain typing commands, but it can also
occur for some Pastes and changes to block style.

  • editing/Editor.cpp:

(WebCore::Editor::appliedEditing):
(WebCore::Editor::unappliedEditing):
(WebCore::Editor::reappliedEditing):
(WebCore::Editor::changeSelectionAfterCommand):

  • editing/Editor.h:

LayoutTests:

block-style-001.html demonstrated the bug, so no new tests have been added.

  • platform/mac/editing/execCommand/format-block-expected.txt:
  • platform/mac/editing/execCommand/outdent-selection-expected.txt:
  • platform/mac/editing/pasteboard/paste-text-005-expected.txt:
  • platform/mac/editing/pasteboard/paste-text-006-expected.txt:
  • platform/mac/editing/pasteboard/paste-text-007-expected.txt:
  • platform/mac/editing/pasteboard/paste-text-014-expected.txt:
  • platform/mac/editing/style/apple-style-editable-mix-expected.txt:
  • platform/mac/editing/style/block-style-001-expected.txt:
  • platform/mac/editing/style/block-style-002-expected.txt:
  • platform/mac/editing/style/block-style-003-expected.txt:
  • platform/mac/editing/style/create-block-for-style-005-expected.txt:
  • platform/mac/editing/style/create-block-for-style-006-expected.txt:
  • platform/mac/editing/style/create-block-for-style-008-expected.txt:
  • platform/mac/editing/style/relative-font-size-change-002-expected.txt:
  • platform/mac/editing/style/relative-font-size-change-003-expected.txt:
  • platform/mac/editing/style/relative-font-size-change-004-expected.txt:
  • platform/mac/editing/style/table-selection-expected.txt:
10:22 AM Changeset in webkit [61417] by atwilson@chromium.org
  • 2 edits in trunk/WebKit/chromium

Roll chromium DEPS 50089:50171
​https://bugs.webkit.org/show_bug.cgi?id=40842

Reviewed by Dumitru Daniliuc.

  • DEPS:

Update chromium_rev to r50171 to remove downstream reference to WebFrame::clearName().

10:12 AM Changeset in webkit [61416] by leandro@webkit.org
  • 2 edits in trunk/WebCore

2010-06-18 Gyuyoung Kim <​gyuyoung.kim@samsung.com>

Unreviewed build fix.

[EFL] Build break on Debug build.
​https://bugs.webkit.org/show_bug.cgi?id=40810

  • CMakeLists.txt: Add CSSPreloadScanner.cpp
9:59 AM Changeset in webkit [61415] by ap@apple.com
  • 3 edits
    2 adds in trunk

Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=40803
TestNetscapePlugin has an incorrect implementation of "property" property

  • DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: (pluginGetProperty): Don't pass a static string back, it's going to be released by NPAPI implementation.
9:51 AM Changeset in webkit [61414] by yurys@chromium.org
  • 13 edits
    1 add in trunk/WebCore

2010-06-18 Pavel Podivilov <​podivilov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: persist breakpoints in inspector settings.
​https://bugs.webkit.org/show_bug.cgi?id=14190

  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • inspector/InspectorController.cpp: (WebCore::InspectorController::InspectorController): (WebCore::InspectorController::setSessionSettings): (WebCore::InspectorController::didCommitLoad): (WebCore::InspectorController::setBreakpoint): (WebCore::InspectorController::removeBreakpoint): (WebCore::InspectorController::didParseSource): (WebCore::InspectorController::breakpointsSettingKey): (WebCore::InspectorController::loadBreakpoints): (WebCore::InspectorController::saveBreakpoints):
  • inspector/InspectorController.h:
  • inspector/InspectorValues.cpp: (WebCore::InspectorValue::parseJSON):
  • inspector/InspectorValues.h:
  • inspector/ScriptBreakpoint.cpp: Added. (WebCore::ScriptBreakpoint::sourceBreakpointsFromInspectorObject): (WebCore::ScriptBreakpoint::inspectorObjectFromSourceBreakpoints):
  • inspector/ScriptBreakpoint.h:
  • inspector/front-end/BreakpointManager.js: (WebInspector.BreakpointManager.prototype.addBreakpoint): (WebInspector.BreakpointManager.prototype.restoredBreakpoint): (WebInspector.BreakpointManager.prototype.breakpointsForSourceID): (WebInspector.BreakpointManager.prototype.breakpointsForURL): (WebInspector.BreakpointManager.prototype._addBreakpoint):
  • inspector/front-end/inspector.js: (WebInspector.restoredBreakpoint):
9:47 AM Changeset in webkit [61413] by Darin Adler
  • 78 edits in trunk/WebCore

2010-06-18 Darin Adler <Darin Adler>

Reviewed by Sam Weinig.

Implement additional DOM attribute reflection for bindings
​https://bugs.webkit.org/show_bug.cgi?id=39936

  • Added support for [Reflect] for long, unsigned long, and boolean attributes.
  • Fixed code that set attributes like this: <video controls="controls"> to instead set them like this: <video controls>.
  • Added lots more uses of [Reflect].
  • Removed now-unneeded [ConvertFromString].
  • Made [Reflect] imply [ConvertNullToNullString] so we can get rid of most uses of the latter.
  • Made [Reflect] automatically lowercase the name of the reflected content attribute to minimize the need to specify a custom content attribute name.

One thing this patch does *not* do is remove the unneeded functions
in the various DOM classes that are no longer used by the bindings.
We should do that in a followup.

  • bindings/scripts/CodeGenerator.pm: Added new functions so code can be shared across bindings, GetterExpressionPrefix and SetterExpressionPrefix. We can do a lot more refactoring like this in the future.
  • bindings/scripts/CodeGeneratorCPP.pm: Removed unneeded ConvertFromString handling, changed to use the new GetterExpressionPrefix and SetterExpressionPrefix functions to better handle reflected DOM attributes.
  • bindings/scripts/CodeGeneratorGObject.pm: Removed unneeded ConvertFromString handling, changed to use the new GetterExpressionPrefix and SetterExpressionPrefix functions to better handle reflected DOM attributes. Fixed a few things in the output so the .cpp file will have more WebKit style. The .h file should be GTK style, but the .cpp file can be the standard WebKit style eventually.
  • bindings/scripts/CodeGeneratorJS.pm: Changed to use the new GetterExpressionPrefix and SetterExpressionPrefix functions and removed a now-unneeded IsSVGAnimatedType special case since the new functions take care of it. Made reflected attributes automatically convert null to the null string without a separate ConvertNullToNullString attribute.
  • bindings/scripts/CodeGeneratorObjC.pm: Changed to use the new GetterExpressionPrefix and SetterExpressionPrefix functions and removed a now-unneeded IsSVGAnimatedType special case since the new functions take care of it. Redid the special cases for ownerDocument and for operator to fit better with the new code paths. Removed unneeded ConvertFromString handling.
  • bindings/scripts/CodeGeneratorV8.pm: Changed to use the new GetterExpressionPrefix and SetterExpressionPrefix functions and removed a now-unneeded IsSVGAnimatedType special case since the new functions take care of it. Made reflected attributes automatically convert null to the null string without a separate ConvertNullToNullString attribute.
  • bindings/scripts/test/TestObj.idl: Added some test cases for content attribute reflection and for exceptions in string-typed attributes.
  • bindings/scripts/test/CPP/WebKitDOMTestObj.cpp: Updated.
  • bindings/scripts/test/CPP/WebKitDOMTestObj.h: Ditto.
  • bindings/scripts/test/GObject/WebKitDOMTestObj.cpp: Ditto.
  • bindings/scripts/test/GObject/WebKitDOMTestObj.h: Ditto.
  • bindings/scripts/test/JS/JSTestObj.cpp: Ditto.
  • bindings/scripts/test/JS/JSTestObj.h: Ditto.
  • bindings/scripts/test/ObjC/DOMTestObj.h: Ditto.
  • bindings/scripts/test/ObjC/DOMTestObj.mm: Ditto.
  • bindings/scripts/test/V8/V8TestObj.cpp: Ditto.
  • dom/Element.cpp: (WebCore::Element::getIntegralAttribute): Added. (WebCore::Element::setIntegralAttribute): Added. (WebCore::Element::getUnsignedIntegralAttribute): Added. (WebCore::Element::setUnsignedIntegralAttribute): Added.
  • dom/Element.h: Added new attribute get/set functions for bindings.
  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::isURLAttribute): Added. Returns true for srcAttr.
  • html/HTMLMediaElement.h: Added isURLAttribute.
  • html/HTMLVideoElement.cpp: (WebCore::HTMLVideoElement::isURLAttribute): Changed to call HTMLMediaElement::isURLAttribute before checking for posterAttr.
  • html/HTMLAnchorElement.idl:
  • html/HTMLAppletElement.idl:
  • html/HTMLAreaElement.idl:
  • html/HTMLBRElement.idl:
  • html/HTMLBaseElement.idl:
  • html/HTMLBaseFontElement.idl:
  • html/HTMLBlockquoteElement.idl:
  • html/HTMLBodyElement.idl:
  • html/HTMLButtonElement.idl:
  • html/HTMLDListElement.idl:
  • html/HTMLDirectoryElement.idl:
  • html/HTMLDivElement.idl:
  • html/HTMLElement.idl:
  • html/HTMLEmbedElement.idl:
  • html/HTMLFontElement.idl:
  • html/HTMLFormElement.idl:
  • html/HTMLFrameElement.idl:
  • html/HTMLFrameSetElement.idl:
  • html/HTMLHRElement.idl:
  • html/HTMLHeadElement.idl:
  • html/HTMLHeadingElement.idl:
  • html/HTMLHtmlElement.idl:
  • html/HTMLIFrameElement.idl:
  • html/HTMLImageElement.idl:
  • html/HTMLInputElement.idl:
  • html/HTMLIsIndexElement.idl:
  • html/HTMLLIElement.idl:
  • html/HTMLLabelElement.idl:
  • html/HTMLLegendElement.idl:
  • html/HTMLLinkElement.idl:
  • html/HTMLMapElement.idl:
  • html/HTMLMediaElement.idl:
  • html/HTMLMenuElement.idl:
  • html/HTMLMetaElement.idl:
  • html/HTMLModElement.idl:
  • html/HTMLOListElement.idl:
  • html/HTMLObjectElement.idl:
  • html/HTMLOptGroupElement.idl:
  • html/HTMLOptionElement.idl:
  • html/HTMLParagraphElement.idl:
  • html/HTMLParamElement.idl:
  • html/HTMLPreElement.idl:
  • html/HTMLQuoteElement.idl:
  • html/HTMLScriptElement.idl:
  • html/HTMLStyleElement.idl:
  • html/HTMLTableCaptionElement.idl:
  • html/HTMLTableCellElement.idl:
  • html/HTMLTableColElement.idl:
  • html/HTMLTableElement.idl:
  • html/HTMLTableRowElement.idl:
  • html/HTMLTableSectionElement.idl:
  • html/HTMLTextAreaElement.idl:
  • html/HTMLUListElement.idl:
  • html/HTMLVideoElement.idl:
  • svg/SVGElement.idl: Added more uses of [Reflect]. Got rid of uses of [ConvertNullToNullString] that are now unneeded since [Reflect] now implies that. Changed formatting to be simpler and consistent without all the lining up and multiple lines.
9:39 AM Changeset in webkit [61412] by dumi@chromium.org
  • 3 edits in trunk/WebCore

Remove some unnecessary checks that cause compiler warnings.
​https://bugs.webkit.org/show_bug.cgi?id=40772

Reviewed by Dimitri Glazkov.

  • bindings/v8/custom/V8SQLResultSetRowListCustom.cpp:

(WebCore::V8SQLResultSetRowList::itemCallback):

  • bindings/v8/npruntime.cpp:
9:11 AM Changeset in webkit [61411] by mnaganov@chromium.org
  • 13 edits in trunk

2010-06-18 Mikhail Naganov <​mnaganov@chromium.org>

Reviewed by Yury Semikhatsky.

WebInspector: Implement 'takeHeapSnapshot' in InspectorController.

​https://bugs.webkit.org/show_bug.cgi?id=40834

  • bindings/js/ScriptProfiler.h: (WebCore::ScriptProfiler::takeHeapSnapshot):
  • bindings/v8/ScriptProfiler.cpp: (WebCore::ScriptProfiler::takeHeapSnapshot):
  • bindings/v8/ScriptProfiler.h:
  • inspector/InspectorBackend.cpp: (WebCore::InspectorBackend::takeHeapSnapshot):
  • inspector/InspectorBackend.h:
  • inspector/InspectorBackend.idl:
  • inspector/InspectorController.cpp: (WebCore::InspectorController::takeHeapSnapshot):
  • inspector/InspectorController.h:
  • src/js/HeapProfilerPanel.js: (WebInspector.HeapSnapshotProfileType.prototype.buttonClicked):
  • src/js/InspectorControllerImpl.js: (devtools.InspectorBackendImpl):
  • src/js/ProfilerAgent.js: (devtools.ProfilerAgent.prototype.startProfiling):
8:55 AM Changeset in webkit [61410] by mitz@apple.com
  • 3 edits
    2 adds in trunk

REGRESSION (r61379?): Assertion failure in Element::getURLAttribute() when accessing the src attribute of a script element
​https://bugs.webkit.org/show_bug.cgi?id=40831

Reviewed by Anders Carlsson.

WebCore:

Test: fast/dom/HTMLScriptElement/isURLAttribute.html

  • html/HTMLScriptElement.cpp:

(WebCore::HTMLScriptElement::isURLAttribute): Check for the 'src' attribute.

LayoutTests:

  • fast/dom/HTMLScriptElement/isURLAttribute-expected.txt: Added.
  • fast/dom/HTMLScriptElement/isURLAttribute.html: Added.
8:54 AM Changeset in webkit [61409] by Dimitri Glazkov
  • 33 edits
    29 adds
    23 deletes in trunk/LayoutTests

2010-06-18 Dimitri Glazkov <Dimitri Glazkov>

Unreviewed, expectations update.

New baselines after ​http://trac.webkit.org/changeset/61393.

8:46 AM Changeset in webkit [61408] by eric@webkit.org
  • 5 edits
    3 deletes in trunk

2010-06-18 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r61405.
​http://trac.webkit.org/changeset/61405
​https://bugs.webkit.org/show_bug.cgi?id=40838

broke chromium mac compile (Requested by tonyg-cr1 on
#webkit).

  • fast/js/parser-high-byte-character-expected.txt: Removed.
  • fast/js/parser-high-byte-character.html: Removed.
  • fast/js/script-tests/parser-high-byte-character.js: Removed.

2010-06-18 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r61405.
​http://trac.webkit.org/changeset/61405
​https://bugs.webkit.org/show_bug.cgi?id=40838

broke chromium mac compile (Requested by tonyg-cr1 on
#webkit).

  • bindings/v8/ScriptSourceCode.h: (WebCore::ScriptSourceCode::ScriptSourceCode):
  • bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::compileScript): (WebCore::V8Proxy::evaluate):
  • bindings/v8/V8Proxy.h:
8:44 AM Changeset in webkit [61407] by leandro@webkit.org
  • 2 edits in trunk/WebKitTools

2010-06-18 Leandro Pereira <​leandro@profusion.mobi>

Unreviewed.

Adding myself to the committers list.

  • Scripts/webkitpy/common/config/committers.py:
8:40 AM QtWebKitJournal edited by Simon Hausmann
(diff)
8:14 AM Changeset in webkit [61406] by eric@webkit.org
  • 8 edits in trunk

2010-06-18 Zhenyao Mo <​zmo@google.com>

Reviewed by Dimitri Glazkov.

Fix WebGLRenderingContext helper functions find{Texture/Renderbuffer/Buffer}
​https://bugs.webkit.org/show_bug.cgi?id=40176

  • fast/canvas/webgl/gl-object-get-calls-expected.txt: Test name == 0 cases, and test getVertexAttrib return original WebGLBuffer object.
  • fast/canvas/webgl/script-tests/gl-object-get-calls.js: Ditto.

2010-06-18 Zhenyao Mo <​zmo@google.com>

Reviewed by Dimitri Glazkov.

Fix WebGLRenderingContext helper functions find{Texture/Renderbuffer/Buffer}
​https://bugs.webkit.org/show_bug.cgi?id=40176

  • html/canvas/WebGLBuffer.cpp: Remove constructor with existing name.
  • html/canvas/WebGLBuffer.h: Ditto.
  • html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::getVertexAttrib): Use findBuffer instead of creating a new WebGLBuffer. (WebCore::WebGLRenderingContext::findTexture): Deal with name == 0 case and return raw pointer. (WebCore::WebGLRenderingContext::findRenderbuffer): Ditto. (WebCore::WebGLRenderingContext::findBuffer): Find WebGLBuffer object using given name.
  • html/canvas/WebGLRenderingContext.h: Add findBuffer function declaration, change return type to raw pointer.
8:00 AM Changeset in webkit [61405] by eric@webkit.org
  • 5 edits
    3 adds in trunk

2010-06-18 Tony Gentilcore <​tonyg@chromium.org>

Reviewed by David Levin.

Persist V8's ScriptData to the memory cache.
​https://bugs.webkit.org/show_bug.cgi?id=38661

When V8 ScriptData caching was originally submitted it causes crashes
in external scripts with high-byte characters. This new test crashes on
the original code, but now passes.

  • fast/js/parser-high-byte-character-expected.txt: Added.
  • fast/js/parser-high-byte-character.html: Added.
  • fast/js/script-tests/parser-high-byte-character.js: Added. (runTest):

2010-06-18 Tony Gentilcore <​tonyg@chromium.org>

Reviewed by David Levin.

Persist V8's ScriptData to the memory cache.
​https://bugs.webkit.org/show_bug.cgi?id=38661

This stores V8's ScriptData in the memory cache and also causes the
network platform layer to be notified of the available cacheable
metadata.

Chromium's morejs benchmark showed a ~7% improvement when this was
originally submitted (before it had to be rolled back).

Test: fast/js/parser-high-byte-character.html

  • bindings/v8/ScriptSourceCode.h: (WebCore::ScriptSourceCode::ScriptSourceCode): (WebCore::ScriptSourceCode::cachedScript):
  • bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::compileScript): (WebCore::V8Proxy::precompileScript): (WebCore::V8Proxy::evaluate):
  • bindings/v8/V8Proxy.h:
6:35 AM Changeset in webkit [61404] by Simon Hausmann
  • 2 edits in trunk/WebKit/qt

[Qt] Fix documentation for the declarative module import.

Patch by Alexis Menard <​alexis.menard@nokia.com> on 2010-06-18
Reviewed by Simon Hausmann.

  • declarative/qdeclarativewebview.cpp:
6:09 AM Changeset in webkit [61403] by krit@webkit.org
  • 9 edits in trunk/LayoutTests

2010-06-18 Dirk Schulze <​krit@webkit.org>

Not reviewed. Rebaseline gtk results.

  • platform/gtk/Skipped:
  • platform/gtk/svg/custom/broken-internal-references-expected.txt:
  • platform/gtk/svg/filters/filter-on-filter-for-text-expected.txt:
  • platform/gtk/svg/filters/filter-on-tspan-expected.txt:
  • platform/gtk/svg/text/text-hkern-expected.txt:
  • platform/gtk/svg/text/text-hkern-on-vertical-text-expected.txt:
  • platform/gtk/svg/text/text-vkern-expected.txt:
  • platform/gtk/svg/text/text-vkern-on-horizontal-text-expected.txt:
5:50 AM Changeset in webkit [61402] by antonm@chromium.org
  • 4 edits in trunk

2010-06-18 Anton Muhin <​antonm@chromium.org>

Reviewed by Dimitri Glazkov.

[v8] Finish migration to new named property query API
​https://bugs.webkit.org/show_bug.cgi?id=40771
Remove definition which allowed gradual transition to new API.
See ​https://bugs.webkit.org/show_bug.cgi?id=40303 for first phase.
Requires V8 roll.

  • DEPS:

2010-06-18 Anton Muhin <​antonm@chromium.org>

Reviewed by Dimitri Glazkov.

[v8] Finish migration to new named property query API
​https://bugs.webkit.org/show_bug.cgi?id=40771
Remove definition which allowed gradual transition to new API.
See ​https://bugs.webkit.org/show_bug.cgi?id=40303 for first phase.

  • config.h:
5:50 AM Changeset in webkit [61401] by Nikolas Zimmermann
  • 6 edits
    3 adds in trunk/LayoutTests

2010-06-18 Nikolas Zimmermann <​nzimmermann@rim.com>

Not reviewed. Rebaseline win results.

  • platform/win/svg/W3C-SVG-1.1/animate-elem-82-t-expected.txt: Added.
  • platform/win/svg/W3C-SVG-1.1/coords-trans-01-b-expected.txt:
  • platform/win/svg/custom/broken-internal-references-expected.txt:
  • platform/win/svg/custom/clip-path-referencing-use2-expected.txt:
  • platform/win/svg/custom/image-with-transform-clip-filter-expected.txt:
  • platform/win/svg/custom/junk-data-expected.txt: Added.
  • platform/win/svg/custom/missing-xlink-expected.txt: Added.
  • platform/win/svg/filters/feColorMatrix-values-expected.txt:
5:38 AM Changeset in webkit [61400] by Simon Hausmann
  • 3 edits in trunk/WebKit/qt

Fix documentation issue on the onAlert handler.
Fix compilation issue with QT_NO_ACTION.

Patch by Alexis Menard <​alexis.menard@nokia.com> on 2010-06-18
Reviewed by Simon Hausmann.

  • declarative/qdeclarativewebview.cpp:
  • declarative/qdeclarativewebview_p.h:
5:34 AM Changeset in webkit [61399] by Nikolas Zimmermann
  • 5 edits in trunk/LayoutTests

2010-06-18 Nikolas Zimmermann <​nzimmermann@rim.com>

Not reviewed. Rebaseline mac-snowleopard results.

  • platform/mac/svg/W3C-SVG-1.1/text-intro-05-t-expected.txt:
  • platform/mac/svg/custom/junk-data-expected.txt:
  • platform/mac/svg/custom/missing-xlink-expected.txt:
  • platform/mac/svg/text/text-intro-05-t-expected.txt:
5:28 AM Changeset in webkit [61398] by Nikolas Zimmermann
  • 6 edits in trunk/LayoutTests

2010-06-18 Nikolas Zimmermann <​nzimmermann@rim.com>

Not reviewed. Rebaseline mac-tiger test results.

  • platform/mac-tiger/svg/W3C-SVG-1.1/metadata-example-01-b-expected.txt:
  • platform/mac-tiger/svg/hixie/text/003-expected.txt:
  • platform/mac-tiger/svg/hixie/text/003a-expected.txt:
  • platform/mac-tiger/svg/hixie/viewbox/preserveAspectRatio/001-expected.txt:
  • platform/mac-tiger/svg/hixie/viewbox/preserveAspectRatio/002-expected.txt:
5:27 AM QtWebKitBackportingFixes edited by Simon Hausmann
(diff)
5:27 AM Changeset in webkit [61397] by pfeldman@chromium.org
  • 15 edits in trunk

2010-06-17 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: bring XHR console records back.

  • adds "Enable XHR Monitor" / "Disable XHR Monitor" actions to the console's context menu
  • make the chosen option persist in the settings.

​https://bugs.webkit.org/show_bug.cgi?id=40799

  • English.lproj/localizedStrings.js:
  • inspector/InspectorBackend.cpp: (WebCore::InspectorBackend::disableSearchingForNode): (WebCore::InspectorBackend::enableMonitoringXHR): (WebCore::InspectorBackend::disableMonitoringXHR):
  • inspector/InspectorBackend.h:
  • inspector/InspectorBackend.idl:
  • inspector/InspectorController.cpp: (WebCore::InspectorController::InspectorController): (WebCore::InspectorController::setMonitoringXHR): (WebCore::InspectorController::didLoadResourceFromMemoryCache): (WebCore::InspectorController::identifierForInitialRequest): (WebCore::InspectorController::resourceRetrievedByXMLHttpRequest): (WebCore::InspectorController::ensureSettingsLoaded):
  • inspector/InspectorController.h:
  • inspector/InspectorFrontend.cpp: (WebCore::InspectorFrontend::monitoringXHRWasEnabled): (WebCore::InspectorFrontend::monitoringXHRWasDisabled):
  • inspector/InspectorFrontend.h:
  • inspector/front-end/ConsoleView.js: (WebInspector.ConsoleView.prototype._handleContextMenuEvent): (WebInspector.ConsoleView.prototype._registerShortcuts):
  • inspector/front-end/InjectedScript.js: (injectedScriptConstructor.):
  • inspector/front-end/InspectorBackendStub.js: (.WebInspector.InspectorBackendStub): (.WebInspector.InspectorBackendStub.prototype.enableMonitoringXHR): (.WebInspector.InspectorBackendStub.prototype.disableMonitoringXHR):
  • inspector/front-end/inspector.js: (WebInspector.monitoringXHRWasEnabled): (WebInspector.monitoringXHRWasDisabled):
  • xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::didFinishLoading):
5:25 AM Changeset in webkit [61396] by Nikolas Zimmermann
  • 17 edits
    2 adds in trunk/LayoutTests

2010-06-18 Nikolas Zimmermann <​nzimmermann@rim.com>

Not reviewed. Rebaselined Qt test results.

  • platform/qt/svg/custom/broken-internal-references-expected.txt:
  • platform/qt/svg/custom/empty-mask-expected.txt:
  • platform/qt/svg/custom/mask-invalidation-expected.txt:
  • platform/qt/svg/custom/stroke-width-large-expected.txt:
  • platform/qt/svg/custom/text-xy-updates-SVGList-expected.txt:
  • platform/qt/svg/custom/use-on-symbol-inside-pattern-expected.txt:
  • platform/qt/svg/dom/altGlyph-dom-expected.txt: Added.
  • platform/qt/svg/filters/feColorMatrix-values-expected.txt:
  • platform/qt/svg/filters/feComposite-expected.txt:
  • platform/qt/svg/filters/filter-on-tspan-expected.txt:
  • platform/qt/svg/filters/sourceAlpha-expected.txt:
  • platform/qt/svg/text/lengthAdjust-text-metrics-expected.txt: Added.
  • platform/qt/svg/text/selection-background-color-expected.txt:
  • platform/qt/svg/text/selection-doubleclick-expected.txt:
  • platform/qt/svg/text/selection-styles-expected.txt:
  • platform/qt/svg/text/selection-tripleclick-expected.txt:
  • platform/qt/svg/zoom/page/zoom-coords-viewattr-01-b-expected.txt:
  • platform/qt/svg/zoom/text/zoom-coords-viewattr-01-b-expected.txt:
5:23 AM Changeset in webkit [61395] by Simon Hausmann
  • 2 edits in trunk/WebKit/qt

REGRESSION(r60958) [Qt] qwebpage::inputMethods auto-test fails
​https://bugs.webkit.org/show_bug.cgi?id=40830

Reviewed by Antti Koivisto.

When activating a regular input method field, always set or unset the ImhHiddenText
input method hint.

  • WebCoreSupport/EditorClientQt.cpp:

(WebCore::EditorClientQt::setInputMethodState):

4:37 AM Changeset in webkit [61394] by tkent@chromium.org
  • 2 edits in trunk/LayoutTests

2010-06-18 Kent Tamura <​tkent@chromium.org>

Unreviewed, test expectation update.

  • platform/chromium/test_expectations.txt: Merge text_expectations.txt of Chromium tree. Mainly for <progress> and <meter>.
4:18 AM Changeset in webkit [61393] by Nikolas Zimmermann
  • 759 edits
    4 moves
    102 adds in trunk

2010-06-18 Nikolas Zimmermann <​nzimmermann@rim.com>

Reviewed by Dirk Schulze.

Modernize SVG Text code, following the HTML design
​https://bugs.webkit.org/show_bug.cgi?id=40663

SVG Text does not support subpixel positioning
​https://bugs.webkit.org/show_bug.cgi?id=12172

RenderSVGText can't do partial repaints
​https://bugs.webkit.org/show_bug.cgi?id=15386

HTML and SVG need to share more text painting code
​https://bugs.webkit.org/show_bug.cgi?id=15644

Rewrite SVG Text rendering, only keeping the layout of the actual characters/chunks as it was.
We're now drawing SVG Text very similar to HTML Text, utilizing the SVGInlineFlowBox/SVGInlineTextBox structure,
instead of painting all text content of a <text> element from the SVGRootInlineBox, as it was the last years.

Rough overview of the changes:

  • Partial repainting support for text selections (startPos/endPos are respected), no more redrawing of the whole <text> content while selecting
  • Subpixel positioning (near pixel-perfect rendering for all W3C tests that contain text, finally!) -> much better textPath results, characters now align as expected, as all rounding hacks are disabled for SVG text runs, and subpixel precision is used while painting
  • No more custom handling of selection, the standard methods offsetFromPosition() / selectionRectForText() are used instead.
  • Selection works as expected on stretched/squeezed text (lengthAdjust="spacingAndGlyphs"), takes 'includePartialGlyphs' into account - just like HTML text
  • Correct text decoration drawing (proper with and positions and rendering-order, underline/overline before text, strike-through afterwards)
  • Proper sizing of all InlineBoxes, starting from the SVGRootInlineBox, down to every single flow & text box -> correct DRT results, no more weird negative offsets of text runs, etc. Looks exactly like the HTML text test results.
  • Rewritten SVGTextContentElement API to take per-character / per-chunk transformations into account.
  • Speeeeeed! Drawing is much faster now.

Add 24 new testcases covering basic selection features and the SVGTextContentElement API. Each test draws a half-opaque red rectangle, calculated using
SVGTextContentElement API to highlight the area that is supposed to be selected. Then eventSender API is utilized to move the mouse to the calculated
start origin, holding it down and moving it to the end position.

A detailed list of tests that show progression, can be found in the corresponding LayoutTests/ChangeLog.
Note that this requires a rebaselining of all SVG tests containing text elements.

Tests: svg/hixie/text/001.xml (moved from svg/hixie/text/001-broken.xml)

svg/text/lengthAdjust-text-metrics.html
svg/text/select-textLength-spacing-squeeze-1.svg
svg/text/select-textLength-spacing-squeeze-2.svg
svg/text/select-textLength-spacing-squeeze-3.svg
svg/text/select-textLength-spacing-squeeze-4.svg
svg/text/select-textLength-spacing-stretch-1.svg
svg/text/select-textLength-spacing-stretch-2.svg
svg/text/select-textLength-spacing-stretch-3.svg
svg/text/select-textLength-spacing-stretch-4.svg
svg/text/select-textLength-spacingAndGlyphs-squeeze-1.svg
svg/text/select-textLength-spacingAndGlyphs-squeeze-2.svg
svg/text/select-textLength-spacingAndGlyphs-squeeze-3.svg
svg/text/select-textLength-spacingAndGlyphs-squeeze-4.svg
svg/text/select-textLength-spacingAndGlyphs-stretch-1.svg
svg/text/select-textLength-spacingAndGlyphs-stretch-2.svg
svg/text/select-textLength-spacingAndGlyphs-stretch-3.svg
svg/text/select-textLength-spacingAndGlyphs-stretch-4.svg
svg/text/select-x-list-1.svg
svg/text/select-x-list-2.svg
svg/text/select-x-list-3.svg
svg/text/select-x-list-4.svg
svg/text/select-x-list-with-tspans-1.svg
svg/text/select-x-list-with-tspans-2.svg
svg/text/select-x-list-with-tspans-3.svg
svg/text/select-x-list-with-tspans-4.svg

  • rendering/InlineBox.h: Remove not needed isInlineBox() method. (WebCore::InlineBox::isInlineTextBox): Constify this method. (WebCore::InlineBox::isSVGInlineTextBox): Added, with ENABLE(SVG) guards, just like the existing isSVGRootInlineBox(). (WebCore::InlineBox::isSVGRootInlineBox): Constify this method. (WebCore::InlineBox::calculateBoundaries): Added, with ENABLE(SVG) guards, used to calculate the whole boundaries of a InlineText/FlowBox, only used in SVG text.
  • rendering/InlineFlowBox.h: Devirtualize placeBoxesHorizontally(), SVG no more overrides it.
  • rendering/InlineTextBox.h: Virtualize selectionStartEnd() - SVGInlineTextBox needs to change start/endPositions based on the current text chunk part that it's rendering.

SVGTextChunkLayoutInfo.h contains a detailed documentation what a SVGTextChunk/SVGTextChunkPart is, and why they are necessary.

(WebCore::InlineTextBox::isInlineTextBox): Constify this method.

  • rendering/RenderBlock.h: (WebCore::RenderBlock::forceLayoutInlineChildren): Add helper method, used only by RenderSVGText, to use a simplified layout strategy, which is a big speed win.
  • rendering/RenderBlockLineLayout.cpp: (WebCore::RenderBlock::computeHorizontalPositionsForLine): Remove all isSVGText() special cases, as this function is not called anymore for SVG text. (WebCore::RenderBlock::layoutInlineChildren): Don't call computeHorizontalPositionsForLine() for SVG text. computePerCharacterLayoutInformation() overrides it anyway.
  • rendering/RenderSVGInline.cpp: Remove custom absoluteRects/absoluteQuads code, all shared with RenderInline now. (WebCore::RenderSVGInline::clippedOverflowRectForRepaint): Added, forward to SVGRenderBase, just like all other non-text SVG renderers do. (WebCore::RenderSVGInline::computeRectForRepaint): Ditto. (WebCore::RenderSVGInline::mapLocalToContainer): Ditto
  • rendering/RenderSVGInline.h:
  • rendering/RenderSVGInlineText.cpp: Remove destroy() hack, which called setNeedsLayoutAndPrefWidthsRecalc/repaint on destruction.

As repaint rects work properly now, this hack is no longer necessary, it was only hiding the real problem.

(WebCore::RenderSVGInlineText::styleDidChange): Don't skip RenderText::styleDidChange() anymore, which automatically schedules layout changes for us.
(WebCore::RenderSVGInlineText::localCaretRect): Remove outdated comment, localCaretRect() is not yet needed in SVG text code.

  • rendering/RenderSVGInlineText.h: Remove custom absoluteRects/absoluteQuads/selectionRectForRepaint/positionForPoint/destroy/computeRectForRepaint* code, all shared with RenderText now.
  • rendering/RenderSVGText.cpp: (WebCore::RenderSVGText::mapLocalToContainer): Take x/y translation into account, but do NOT include in localToParentTransform(), as that would affect rendering. (WebCore::RenderSVGText::layout): Use super-simplified layout strategy, removing a lot of uncessary stuff done by RenderBlock, that SVG does not need. (WebCore::RenderSVGText::absoluteRects): Remove dead-code, retreving the RenderSVGRoot* object, not necessary since a longer time. (WebCore::RenderSVGText::absoluteQuads): Ditto. (WebCore::RenderSVGText::paint): Early exit if we're not in PaintPhaseForeground/PaintPhaseSelfOutline. We're not interessted in other phases. (WebCore::RenderSVGText::strokeBoundingBox): Fix stroke width calculation, no need to special case SVGFonts.
  • rendering/RenderSVGText.h: Remove updateFirstLineBlock/updateFirstLetter overrides, the new RenderSVGText::layout() code, doesn't use these methods at all.

We asked RenderBlock to layout before, which was calling updateFirstLetter & co, this is gone now, as it was all not needed.

(WebCore::RenderSVGText::objectBoundingBox): Directly return the frameRect here, inlined for speed.

  • rendering/RootInlineBox.cpp: (WebCore::RootInlineBox::verticallyAlignBoxes): Early-exit if we're a SVGRootInlineBox. SVG handles this on its own.
  • rendering/RootInlineBox.h: Devirtualize verticallyAlignBoxes(), SVG no longer overrides it. Remove virtual computePerCharacterLayoutInformation() method, only lives in SVGRootInlineBox now.
  • rendering/SVGCharacterData.h: Remove no longer needed SVGTextDecorationInfo.
  • rendering/SVGCharacterLayoutInfo.cpp: Don't pass a reference to a Vector<SVGChar> to SVGCharacterLayoutInfo, let it create it. (WebCore::SVGCharacterLayoutInfo::SVGCharacterLayoutInfo):
  • rendering/SVGCharacterLayoutInfo.h:
  • rendering/SVGInlineFlowBox.cpp: (WebCore::SVGInlineFlowBox::paint): Ask children to paint. (WebCore::SVGInlineFlowBox::calculateBoundaries): Calculate boundaries by uniting all direct children boundaries.
  • rendering/SVGInlineFlowBox.h: Remove placeBoxesHorizontally, which does not get called anymore, and does not need to be overriden.
  • rendering/SVGInlineTextBox.cpp: (WebCore::SVGInlineTextBox::SVGInlineTextBox): Don't use abbrevations for variable names, initialize new member variables. (WebCore::SVGInlineTextBox::measureCharacter): New helper function extracted from buildLayoutInformation, replacing calculateGlyphWidth/Height. (WebCore::SVGInlineTextBox::offsetForPosition): Implement this method by utilizing Font::offsetForPosition(), but respecting the text chunk parts. (WebCore::SVGInlineTextBox::positionForOffset): No change here, still not used. (WebCore::SVGInlineTextBox::selectionRect): Rewritten, utilizing Font::selectionRectForText(), taking text chunk parts into account, and the supplied startPos/endPos. (WebCore::SVGInlineTextBox::paint): Rewritten, to handle paint servers much more elegant, than the old solution. See code for details, too much to explain here. (WebCore::SVGInlineTextBox::acquirePaintingResource): Helper function, used from paint(). (WebCore::SVGInlineTextBox::releasePaintingResource): Ditto. (WebCore::SVGInlineTextBox::prepareGraphicsContextForTextPainting): Ditto. (WebCore::SVGInlineTextBox::restoreGraphicsContextAfterTextPainting): Ditto. (WebCore::SVGInlineTextBox::constructTextRun): Helper function centralizing the creation of a TextRun object, used to draw/measure SVG text. (WebCore::SVGInlineTextBox::mapStartEndPositionsIntoChunkPartCoordinates): Important helper function, mapping a startPos/endPos from InlineTextBox

coordinate space to the SVGInlineTextBox, respecting the current text chunk part.

(WebCore::SVGInlineTextBox::selectionStartEnd): Call InlineTextBox::selectionStartEnd(), and apply post fixes when m_currentChunkPart is set. (called when painting a selected chunk part)
(WebCore::positionOffsetForDecoration): Refactored from old paintDecoration() code.
(WebCore::thicknessForDecoration): Ditto.
(WebCore::findRenderObjectDefininingTextDecoration): Ditto.
(WebCore::SVGInlineTextBox::paintDecoration): Ditto. (Can not share the code with HTML, as we need floating point precision, and directly call fillRect, instead of drawHighlightForText.)
(WebCore::SVGInlineTextBox::paintDecorationWithStyle): Ditto.
(WebCore::SVGInlineTextBox::paintSelection): New method, painting text selections with floating-point precision.
(WebCore::SVGInlineTextBox::paintText): New method, painting text with floating-point precision, correctly handling selected text, removing the need for special SVG text sub-paint phases.

(GlyphFill/StrokeSelectionPhase, GlyphFill/StrokePhase)

(WebCore::SVGInlineTextBox::buildLayoutInformation): Use new measureCharacter() helper function, renamed some variables, to avoid abbrevations.
(WebCore::SVGInlineTextBox::calculateGlyphBoundaries): Rewritten to use new measureCharacter() helper function.
(WebCore::SVGInlineTextBox::calculateBoundaries): Rewritten to take text chunk parts into account, serves as central method used to layout InlineBoxes (see SVGRootInlineBox.)

  • rendering/SVGInlineTextBox.h: (WebCore::SVGInlineTextBox::isSVGInlineTextBox): Added. (WebCore::SVGInlineTextBox::setHeight): Rename variable, to avoid abbrevations. (WebCore::SVGInlineTextBox::chunkTransformation): New helper function, returning the transformation, that gets applied to the complete text chunk, if any. (WebCore::SVGInlineTextBox::setChunkTransformation): New helper function used by SVGRrootInlineBox, to set the chunk transformation, during text chunk part propagation phase. (WebCore::SVGInlineTextBox::addChunkPartInformation): Ditto. (WebCore::SVGInlineTextBox::svgTextChunkParts): Ditto.
  • rendering/SVGRootInlineBox.cpp: Virtually rewritten, to be designed more like HTMLs RootInlineBox, diving into children for painting. (WebCore::SVGRootInlineBox::paint): Ask children to paint, nothing more. No more traversing through the SVGTextChunks, figuring out which part to render, this is done in layout phase now. (WebCore::SVGRootInlineBox::computePerCharacterLayoutInformation): Completly redesigned, see SVGTextChunkLayoutInfo.h for a high-level overview. (WebCore::SVGRootInlineBox::buildLayoutInformation): Just small cleanups, nothing changed here. (WebCore::SVGRootInlineBox::layoutChildBoxes): New helper function, extracted from old layoutInlineBoxes(). (WebCore::SVGRootInlineBox::layoutRootBox): Ditto. (WebCore::SVGRootInlineBox::propagateTextChunkPartInformation): Key-concept of the new design, builds "text chunk parts" and propagates that knownledge to all child SVGInlineTextBoxes.
  • rendering/SVGRootInlineBox.h: (WebCore::SVGRootInlineBox::isSVGRootInlineBox): Constified method. (WebCore::SVGRootInlineBox::setHeight): Change variable name, to avoid abbrevations.
  • rendering/SVGTextChunkLayoutInfo.cpp: Remove if 0, enable compilation.
  • rendering/SVGTextChunkLayoutInfo.h: Add large comment explaining text chunk parts, the key concept of the new design. Remove SVGTextChunkWalker & friends, no longer used. (WebCore::SVGTextChunkPart::SVGTextChunkPart): (WebCore::SVGTextChunkPart::isValid): (WebCore::SVGTextChunk::SVGTextChunk): (WebCore::SVGTextChunkLayoutInfo::SVGTextChunkLayoutInfo): (WebCore::SVGTextChunkLayoutInfo::textChunks):
  • rendering/SVGTextLayoutUtilities.cpp: (WebCore::cummulatedWidthOfInlineBoxCharacterRange): (WebCore::cummulatedHeightOfInlineBoxCharacterRange): (WebCore::svgTextRunForInlineTextBox): Disable rounding hacks, explain parameters with comments, why they have which values.
  • rendering/SVGTextLayoutUtilities.h: Remove SVGTextPaintSubphase and SVGTextPaintInfo.
  • rendering/SVGTextQuery.cpp: Remove if 0, enable compilation.
  • rendering/SVGTextQuery.h: Ditto.
  • svg/SVGStyledElement.cpp: Very important change! Do not treat CSS attributes as recognized attributes, that would lead to setNeedsLayout() calls, reducing performance!

This hack existed, as we were not dealing with text updates correctly, now that RenderSVGInlineText::styleDidChange is fixed, it's no longer necessary.

(WebCore::SVGStyledElement::isKnownAttribute):

  • svg/SVGTextContentElement.cpp: Completely remove the SVGTextContentElement API, that manually traversed all text chunks, instead use the new SVGTextQuery API. (WebCore::SVGTextContentElement::getNumberOfChars): (WebCore::SVGTextContentElement::getComputedTextLength): (WebCore::SVGTextContentElement::getSubStringLength): (WebCore::SVGTextContentElement::getStartPositionOfChar): (WebCore::SVGTextContentElement::getEndPositionOfChar): (WebCore::SVGTextContentElement::getExtentOfChar): (WebCore::SVGTextContentElement::getRotationOfChar): (WebCore::SVGTextContentElement::getCharNumAtPosition):
  • svg/SVGTextElement.cpp: Very important change! Do not calls setNeedsLayout() on RenderSVGText, if childrenChanged() has been called.
  • svg/SVGTextElement.h: Completly remove childrenChanged() - no longer necessary, updates work as expected without it now.
3:41 AM Changeset in webkit [61392] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-06-18 Lucas De Marchi <​lucas.demarchi@profusion.mobi>

Reviewed by David Levin.

Fix compilation when filters are disabled. Revision r60689
changed the signature of SVGRenderBase::prepareToRenderSVGContent()
but didn't change the unsused parameters when filters are disabled.
​https://bugs.webkit.org/show_bug.cgi?id=40625

No new tests. Compilation fix.

  • rendering/SVGRenderSupport.cpp: (WebCore::SVGRenderBase::prepareToRenderSVGContent):
3:28 AM Changeset in webkit [61391] by eric@webkit.org
  • 3 edits
    2 adds in trunk

2010-06-18 Adam Barth <​abarth@webkit.org>

Reviewed by Darin Adler.

noAccess url schemes block access to inline stylesheets
​https://bugs.webkit.org/show_bug.cgi?id=32309

Test that data URLs can access their inline style sheets.

  • http/tests/security/data-url-inline.css-expected.txt: Added.
  • http/tests/security/data-url-inline.css.html: Added.

2010-06-18 Adam Barth <​abarth@webkit.org>

Reviewed by Darin Adler.

noAccess url schemes block access to inline stylesheets
​https://bugs.webkit.org/show_bug.cgi?id=32309

Instead of using baseURL() to grab the security context we should just
use finalURL directly. When I wrote the original patch that added this
security check, finalURL didn't exist yet.

If finalURL is an empty URL, that means we generated the style sheet
from text that didn't have a URL. It would be slightly safer to store
a bit on CSSStyleSheet indicating whether it came from an inline style
sheet, but I think this check is fairly accurate.

Test: http/tests/security/data-url-inline.css.html

  • css/CSSStyleSheet.cpp: (WebCore::CSSStyleSheet::cssRules):
3:04 AM QtWebKitBackportingFixes edited by Simon Hausmann
(diff)
2:31 AM Changeset in webkit [61390] by abarth@webkit.org
  • 5 edits
    3 adds in trunk

2010-06-18 Adam Barth <​abarth@webkit.org>

Reviewed by Darin Adler.

Remove unneeded custom code for WebSocket.send
​https://bugs.webkit.org/show_bug.cgi?id=38180

We don't appear to require a custom binding here. The old function was
wacky in two ways:

1) It required all of its arguments.

2) If the toString of its argument threw, it would catch the exception

and re-throw a different exception.

I've kept the first behavior but changed the second (and documented it
with a test).

Test: websocket/tests/send-throw.html

  • bindings/js/JSWebSocketCustom.cpp:
  • bindings/v8/custom/V8WebSocketCustom.cpp:
  • websockets/WebSocket.idl:

2010-06-18 Adam Barth <​abarth@webkit.org>

Reviewed by Darin Adler.

Remove unneeded custom code for WebSocket.send
​https://bugs.webkit.org/show_bug.cgi?id=38180

Test what happens when you pass an object to WebSocket.send that throws
when you convert it to a string.

  • websocket/tests/script-tests/send-throw.js: Added. (endTest): (FIRST_MESSAGE_TO_SEND.toString): (ws.onopen): (ws.onclose): (timeOutCallback):
  • websocket/tests/send-throw-expected.txt: Added.
  • websocket/tests/send-throw.html: Added.
2:18 AM Changeset in webkit [61389] by Simon Hausmann
  • 4 edits in trunk

WebKit: [qt] Better check for the declarative plugin inclusion.

Patch by Alexis Menard <​alexis.menard@nokia.com> on 2010-06-18
Reviewed by Simon Hausmann.

  • WebKit.pro:

WebKit/qt: [Qt] Change the target path to QtWebKit.

Patch by Alexis Menard <​alexis.menard@nokia.com> on 2010-06-18
Reviewed by Simon Hausmann.

  • declarative/declarative.pro:
2:16 AM Changeset in webkit [61388] by dumi@chromium.org
  • 25 edits in trunk

Move isAvailable()/setIsAvailable() from Database/DatabaseSync to AbstractDatabase.
​https://bugs.webkit.org/show_bug.cgi?id=39041

Reviewed by Adam Barth.

WebCore:

  • WebCore.base.exp
  • bindings/generic/RuntimeEnabledFeatures.cpp:

(WebCore::RuntimeEnabledFeatures::openDatabaseEnabled):
(WebCore::RuntimeEnabledFeatures::openDatabaseSyncEnabled):

  • page/DOMWindow.cpp:

(WebCore::DOMWindow::openDatabase):

  • storage/AbstractDatabase.cpp:

(WebCore::AbstractDatabase::isAvailable):
(WebCore::AbstractDatabase::setIsAvailable):

  • storage/AbstractDatabase.h:
  • storage/Database.cpp:
  • storage/Database.h:
  • storage/DatabaseSync.cpp:
  • storage/DatabaseSync.h:
  • workers/WorkerContext.cpp:

(WebCore::WorkerContext::openDatabase):
(WebCore::WorkerContext::openDatabaseSync):

  • workers/WorkerContext.h:

WebKit/chromium:

  • src/WebRuntimeFeatures.cpp:

(WebKit::WebRuntimeFeatures::enableDatabase):
(WebKit::WebRuntimeFeatures::isDatabaseEnabled):

WebKit/gtk:

  • webkit/webkitwebview.cpp:

(webkit_web_view_update_settings):
(webkit_web_view_settings_notify):
(webkit_get_cache_model):

WebKit/mac:

  • WebView/WebView.mm:

(-[WebView _preferencesChangedNotification:]):

WebKit/qt:

  • Api/qwebsettings.cpp:

(QWebSettingsPrivate::apply):

WebKit/win:

  • WebView.cpp:

(WebView::notifyPreferencesChanged):

WebKit/wx:

  • WebView.cpp:

(wxWebView::SetDatabasesEnabled):
(wxWebView::AreDatabasesEnabled):

2:01 AM Changeset in webkit [61387] by Nikolas Zimmermann
  • 2 edits in trunk/LayoutTests

2010-06-18 Nikolas Zimmermann <​nzimmermann@rim.com>

Not reviewed. Try to turn Gtk 32-bit Linux Debug green again.

  • platform/gtk/Skipped:
1:58 AM Changeset in webkit [61386] by abarth@webkit.org
  • 2 edits in trunk/WebCore

2010-06-18 Adam Barth <​abarth@webkit.org>

Rubber-stamped by Eric Seidel.

Fix the namespace indent for HTML5Lexer. This patch changes
white-space only.

  • html/HTML5Lexer.h: (WebCore::HTML5Lexer::): (WebCore::HTML5Lexer::lineNumber): (WebCore::HTML5Lexer::columnNumber): (WebCore::HTML5Lexer::state): (WebCore::HTML5Lexer::setState): (WebCore::HTML5Lexer::skipLeadingNewLineForListing): (WebCore::HTML5Lexer::InputStreamPreprocessor::InputStreamPreprocessor): (WebCore::HTML5Lexer::InputStreamPreprocessor::nextInputCharacter): (WebCore::HTML5Lexer::InputStreamPreprocessor::peek): (WebCore::HTML5Lexer::InputStreamPreprocessor::advance):
1:28 AM Changeset in webkit [61385] by ukai@chromium.org
  • 2 edits in trunk/WebCore

Unreviewed test breakage fix.

WebSocket: resume should not process buffer if already processing.
​https://bugs.webkit.org/show_bug.cgi?id=39340

MessageLoop runs in main thread, so we don't need to use timer in worker thread.
Also, we should not use Timer in worker thread.

  • websockets/ThreadableWebSocketChannelClientWrapper.h:

(WebCore::ThreadableWebSocketChannelClientWrapper::resume):
(WebCore::ThreadableWebSocketChannelClientWrapper::ThreadableWebSocketChannelClientWrapper):

12:22 AM QtWebKitWebGL edited by jarkko.j.sakkinen@gmail.com
(diff)

Jun 17, 2010:

11:58 PM Changeset in webkit [61384] by eric@webkit.org
  • 75 edits in trunk/WebCore

2010-06-17 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r61379.
​http://trac.webkit.org/changeset/61379
​https://bugs.webkit.org/show_bug.cgi?id=40813

Broke multiple tests on all platforms (Requested by tkent on
#webkit).

  • bindings/scripts/CodeGenerator.pm:
  • bindings/scripts/CodeGeneratorCPP.pm:
  • bindings/scripts/CodeGeneratorGObject.pm:
  • bindings/scripts/CodeGeneratorJS.pm:
  • bindings/scripts/CodeGeneratorObjC.pm:
  • bindings/scripts/CodeGeneratorV8.pm:
  • bindings/scripts/test/CPP/WebDOMTestObj.cpp: (WebDOMTestObj::attrWithException): (WebDOMTestObj::setAttrWithException): (WebDOMTestObj::attrWithSetterException): (WebDOMTestObj::attrWithGetterException): (WebDOMTestObj::setAttrWithGetterException):
  • bindings/scripts/test/CPP/WebDOMTestObj.h:
  • bindings/scripts/test/GObject/WebKitDOMTestCallback.cpp: (webkit_dom_test_callback_callback_with_class1param): (webkit_dom_test_callback_callback_with_class2param): (webkit_dom_test_callback_callback_with_non_bool_return_type):
  • bindings/scripts/test/GObject/WebKitDOMTestObj.cpp: (webkit_dom_test_obj_void_method): (webkit_dom_test_obj_void_method_with_args): (webkit_dom_test_obj_int_method): (webkit_dom_test_obj_int_method_with_args): (webkit_dom_test_obj_obj_method): (webkit_dom_test_obj_obj_method_with_args): (webkit_dom_test_obj_method_that_requires_all_args): (webkit_dom_test_obj_method_that_requires_all_args_and_throws): (webkit_dom_test_obj_serialized_value): (webkit_dom_test_obj_method_with_exception): (webkit_dom_test_obj_with_dynamic_frame): (webkit_dom_test_obj_with_dynamic_frame_and_arg): (webkit_dom_test_obj_with_dynamic_frame_and_optional_arg): (webkit_dom_test_obj_with_dynamic_frame_and_user_gesture): (webkit_dom_test_obj_with_dynamic_frame_and_user_gesture_asad): (webkit_dom_test_obj_with_script_state_void): (webkit_dom_test_obj_with_script_state_obj): (webkit_dom_test_obj_with_script_state_void_exception): (webkit_dom_test_obj_with_script_state_obj_exception): (webkit_dom_test_obj_with_script_execution_context): (webkit_dom_test_obj_method_with_optional_arg): (webkit_dom_test_obj_method_with_non_optional_arg_and_optional_arg): (webkit_dom_test_obj_method_with_non_optional_arg_and_two_optional_args): (webkit_dom_test_obj_get_read_only_int_attr): (webkit_dom_test_obj_get_read_only_string_attr): (webkit_dom_test_obj_get_read_only_test_obj_attr): (webkit_dom_test_obj_get_int_attr): (webkit_dom_test_obj_set_int_attr): (webkit_dom_test_obj_get_long_long_attr): (webkit_dom_test_obj_set_long_long_attr): (webkit_dom_test_obj_get_unsigned_long_long_attr): (webkit_dom_test_obj_set_unsigned_long_long_attr): (webkit_dom_test_obj_get_string_attr): (webkit_dom_test_obj_set_string_attr): (webkit_dom_test_obj_get_test_obj_attr): (webkit_dom_test_obj_set_test_obj_attr): (webkit_dom_test_obj_get_attr_with_exception): (webkit_dom_test_obj_set_attr_with_exception): (webkit_dom_test_obj_get_attr_with_setter_exception): (webkit_dom_test_obj_set_attr_with_setter_exception): (webkit_dom_test_obj_get_attr_with_getter_exception): (webkit_dom_test_obj_set_attr_with_getter_exception): (webkit_dom_test_obj_get_script_string_attr): (webkit_dom_test_obj_get_conditional_attr1): (webkit_dom_test_obj_set_conditional_attr1): (webkit_dom_test_obj_get_conditional_attr2): (webkit_dom_test_obj_set_conditional_attr2): (webkit_dom_test_obj_get_conditional_attr3): (webkit_dom_test_obj_set_conditional_attr3): (webkit_dom_test_obj_get_description): (webkit_dom_test_obj_get_id): (webkit_dom_test_obj_set_id): (webkit_dom_test_obj_get_hash): (webkit_dom_test_obj_set_property): (webkit_dom_test_obj_get_property): (webkit_dom_test_obj_class_init):
  • bindings/scripts/test/GObject/WebKitDOMTestObj.h:
  • bindings/scripts/test/JS/JSTestObj.cpp: (WebCore::): (WebCore::jsTestObjAttrWithException): (WebCore::jsTestObjAttrWithSetterException): (WebCore::jsTestObjAttrWithGetterException): (WebCore::setJSTestObjAttrWithException): (WebCore::setJSTestObjAttrWithGetterException): (WebCore::jsTestObjPrototypeFunctionOverloadedMethod):
  • bindings/scripts/test/JS/JSTestObj.h:
  • bindings/scripts/test/ObjC/DOMTestObj.h:
  • bindings/scripts/test/ObjC/DOMTestObj.mm: (-[DOMTestObj attrWithException]): (-[DOMTestObj setAttrWithException:]): (-[DOMTestObj attrWithSetterException]): (-[DOMTestObj attrWithGetterException]): (-[DOMTestObj setAttrWithGetterException:]):
  • bindings/scripts/test/TestObj.idl:
  • bindings/scripts/test/V8/V8TestObj.cpp: (WebCore::TestObjInternal::attrWithExceptionAttrGetter): (WebCore::TestObjInternal::attrWithExceptionAttrSetter): (WebCore::TestObjInternal::attrWithSetterExceptionAttrGetter): (WebCore::TestObjInternal::attrWithGetterExceptionAttrGetter): (WebCore::TestObjInternal::attrWithGetterExceptionAttrSetter): (WebCore::TestObjInternal::overloadedMethodCallback): (WebCore::):
  • dom/Element.cpp:
  • dom/Element.h:
  • html/HTMLAnchorElement.idl:
  • html/HTMLAppletElement.idl:
  • html/HTMLAreaElement.idl:
  • html/HTMLBRElement.idl:
  • html/HTMLBaseElement.idl:
  • html/HTMLBaseFontElement.idl:
  • html/HTMLBlockquoteElement.idl:
  • html/HTMLBodyElement.idl:
  • html/HTMLButtonElement.idl:
  • html/HTMLDListElement.idl:
  • html/HTMLDirectoryElement.idl:
  • html/HTMLDivElement.idl:
  • html/HTMLElement.idl:
  • html/HTMLEmbedElement.idl:
  • html/HTMLFontElement.idl:
  • html/HTMLFormElement.idl:
  • html/HTMLFrameElement.idl:
  • html/HTMLFrameSetElement.idl:
  • html/HTMLHRElement.idl:
  • html/HTMLHeadElement.idl:
  • html/HTMLHeadingElement.idl:
  • html/HTMLHtmlElement.idl:
  • html/HTMLIFrameElement.idl:
  • html/HTMLImageElement.idl:
  • html/HTMLInputElement.idl:
  • html/HTMLIsIndexElement.idl:
  • html/HTMLLIElement.idl:
  • html/HTMLLabelElement.idl:
  • html/HTMLLegendElement.idl:
  • html/HTMLLinkElement.idl:
  • html/HTMLMapElement.idl:
  • html/HTMLMediaElement.idl:
  • html/HTMLMenuElement.idl:
  • html/HTMLMetaElement.idl:
  • html/HTMLModElement.idl:
  • html/HTMLOListElement.idl:
  • html/HTMLObjectElement.idl:
  • html/HTMLOptGroupElement.idl:
  • html/HTMLOptionElement.idl:
  • html/HTMLParagraphElement.idl:
  • html/HTMLParamElement.idl:
  • html/HTMLPreElement.idl:
  • html/HTMLQuoteElement.idl:
  • html/HTMLScriptElement.idl:
  • html/HTMLStyleElement.idl:
  • html/HTMLTableCaptionElement.idl:
  • html/HTMLTableCellElement.idl:
  • html/HTMLTableColElement.idl:
  • html/HTMLTableElement.idl:
  • html/HTMLTableRowElement.idl:
  • html/HTMLTableSectionElement.idl:
  • html/HTMLTextAreaElement.idl:
  • html/HTMLUListElement.idl:
  • html/HTMLVideoElement.idl:
  • svg/SVGElement.idl:
11:42 PM Changeset in webkit [61383] by rwlbuis@webkit.org
  • 5 edits
    2 adds in trunk

2010-06-17 Rob Buis <​rwlbuis@gmail.com>

Reviewed by Dave Hyatt.

CSS3 "Property is declared twice in rule" test fails
​https://bugs.webkit.org/show_bug.cgi?id=36282

Filter out duplicate properties in style declaration.

Test: fast/css/duplicate-property-in-rule.html

  • css/CSSMutableStyleDeclaration.cpp: Filter out duplicate properties (WebCore::CSSMutableStyleDeclaration::CSSMutableStyleDeclaration):
  • css/CSSParser.cpp: (WebCore::CSSParser::parseValue): Discard negative padding values
  • css/CSSStyleSelector.cpp: Remove negative padding check (WebCore::CSSStyleSelector::applyProperty):
11:11 PM Changeset in webkit [61382] by morrita@google.com
  • 2 edits in trunk/LayoutTests

2010-06-17 MORITA Hajime <​morrita@google.com>

Unreviewed. Fixed a path of meter-element.html on Skipped list.

  • platform/qt/Skipped:
11:05 PM Changeset in webkit [61381] by dumi@chromium.org
  • 2 edits in trunk/LayoutTests

Adding a test case to change-version.html + minor clean-ups.
​https://bugs.webkit.org/show_bug.cgi?id=40604

Reviewed by Adam Barth.

  • storage/change-version.html:
11:00 PM Changeset in webkit [61380] by tkent@chromium.org
  • 2 edits in trunk/LayoutTests

2010-06-17 Kent Tamura <​tkent@chromium.org>

Unreviewed, test expectation update.

  • platform/chromium/test_expectations.txt: Update <meter> tests.
10:57 PM Changeset in webkit [61379] by Darin Adler
  • 75 edits in trunk/WebCore

2010-06-17 Darin Adler <Darin Adler>

Reviewed by Sam Weinig.

Implement additional DOM attribute reflection for bindings
​https://bugs.webkit.org/show_bug.cgi?id=39936

  • Added support for [Reflect] for long, unsigned long, and boolean attributes.
  • Fixed code that set attributes like this: <video controls="controls"> to instead set them like this: <video controls>.
  • Added lots more uses of [Reflect].
  • Removed now-unneeded [ConvertFromString].
  • Made [Reflect] imply [ConvertNullToNullString] so we can get rid of most uses of the latter.
  • Made [Reflect] automatically lowercase the name of the reflected content attribute to minimize the need to specify a custom content attribute name.

One thing this patch does *not* do is remove the unneeded functions
in the various DOM classes that are no longer used by the bindings.
We should do that in a followup.

  • bindings/scripts/CodeGenerator.pm: Added new functions so code can be shared across bindings, GetterExpressionPrefix and SetterExpressionPrefix. We can do a lot more refactoring like this in the future.
  • bindings/scripts/CodeGeneratorCPP.pm: Removed unneeded ConvertFromString handling, changed to use the new GetterExpressionPrefix and SetterExpressionPrefix functions to better handle reflected DOM attributes.
  • bindings/scripts/CodeGeneratorGObject.pm: Removed unneeded ConvertFromString handling, changed to use the new GetterExpressionPrefix and SetterExpressionPrefix functions to better handle reflected DOM attributes. Fixed a few things in the output so the .cpp file will have more WebKit style. The .h file should be GTK style, but the .cpp file can be the standard WebKit style eventually.
  • bindings/scripts/CodeGeneratorJS.pm: Changed to use the new GetterExpressionPrefix and SetterExpressionPrefix functions and removed a now-unneeded IsSVGAnimatedType special case since the new functions take care of it. Made reflected attributes automatically convert null to the null string without a separate ConvertNullToNullString attribute.
  • bindings/scripts/CodeGeneratorObjC.pm: Changed to use the new GetterExpressionPrefix and SetterExpressionPrefix functions and removed a now-unneeded IsSVGAnimatedType special case since the new functions take care of it. Redid the special cases for ownerDocument and for operator to fit better with the new code paths. Removed unneeded ConvertFromString handling.
  • bindings/scripts/CodeGeneratorV8.pm: Changed to use the new GetterExpressionPrefix and SetterExpressionPrefix functions and removed a now-unneeded IsSVGAnimatedType special case since the new functions take care of it. Made reflected attributes automatically convert null to the null string without a separate ConvertNullToNullString attribute.
  • bindings/scripts/test/TestObj.idl: Added some test cases for content attribute reflection and for exceptions in string-typed attributes.
  • bindings/scripts/test/CPP/WebKitDOMTestObj.cpp: Updated.
  • bindings/scripts/test/CPP/WebKitDOMTestObj.h: Ditto.
  • bindings/scripts/test/GObject/WebKitDOMTestObj.cpp: Ditto.
  • bindings/scripts/test/GObject/WebKitDOMTestObj.h: Ditto.
  • bindings/scripts/test/JS/JSTestObj.cpp: Ditto.
  • bindings/scripts/test/JS/JSTestObj.h: Ditto.
  • bindings/scripts/test/ObjC/DOMTestObj.h: Ditto.
  • bindings/scripts/test/ObjC/DOMTestObj.mm: Ditto.
  • bindings/scripts/test/V8/V8TestObj.cpp: Ditto.
  • dom/Element.cpp: (WebCore::Element::getIntegralAttribute): Added. (WebCore::Element::setIntegralAttribute): Added. (WebCore::Element::getUnsignedIntegralAttribute): Added. (WebCore::Element::setUnsignedIntegralAttribute): Added.
  • dom/Element.h: Added new attribute get/set functions for bindings.
  • html/HTMLAnchorElement.idl:
  • html/HTMLAppletElement.idl:
  • html/HTMLAreaElement.idl:
  • html/HTMLBRElement.idl:
  • html/HTMLBaseElement.idl:
  • html/HTMLBaseFontElement.idl:
  • html/HTMLBlockquoteElement.idl:
  • html/HTMLBodyElement.idl:
  • html/HTMLButtonElement.idl:
  • html/HTMLDListElement.idl:
  • html/HTMLDirectoryElement.idl:
  • html/HTMLDivElement.idl:
  • html/HTMLElement.idl:
  • html/HTMLEmbedElement.idl:
  • html/HTMLFontElement.idl:
  • html/HTMLFormElement.idl:
  • html/HTMLFrameElement.idl:
  • html/HTMLFrameSetElement.idl:
  • html/HTMLHRElement.idl:
  • html/HTMLHeadElement.idl:
  • html/HTMLHeadingElement.idl:
  • html/HTMLHtmlElement.idl:
  • html/HTMLIFrameElement.idl:
  • html/HTMLImageElement.idl:
  • html/HTMLInputElement.idl:
  • html/HTMLIsIndexElement.idl:
  • html/HTMLLIElement.idl:
  • html/HTMLLabelElement.idl:
  • html/HTMLLegendElement.idl:
  • html/HTMLLinkElement.idl:
  • html/HTMLMapElement.idl:
  • html/HTMLMediaElement.idl:
  • html/HTMLMenuElement.idl:
  • html/HTMLMetaElement.idl:
  • html/HTMLModElement.idl:
  • html/HTMLOListElement.idl:
  • html/HTMLObjectElement.idl:
  • html/HTMLOptGroupElement.idl:
  • html/HTMLOptionElement.idl:
  • html/HTMLParagraphElement.idl:
  • html/HTMLParamElement.idl:
  • html/HTMLPreElement.idl:
  • html/HTMLQuoteElement.idl:
  • html/HTMLScriptElement.idl:
  • html/HTMLStyleElement.idl:
  • html/HTMLTableCaptionElement.idl:
  • html/HTMLTableCellElement.idl:
  • html/HTMLTableColElement.idl:
  • html/HTMLTableElement.idl:
  • html/HTMLTableRowElement.idl:
  • html/HTMLTableSectionElement.idl:
  • html/HTMLTextAreaElement.idl:
  • html/HTMLUListElement.idl:
  • html/HTMLVideoElement.idl:
  • svg/SVGElement.idl: Added more uses of [Reflect]. Got rid of uses of [ConvertNullToNullString] that are now unneeded since [Reflect] now implies that. Changed formatting to be simpler and consistent without all the lining up and multiple lines.
10:48 PM Changeset in webkit [61378] by morrita@google.com
  • 2 edits in trunk/LayoutTests

2010-06-17 MORITA Hajime <​morrita@google.com>

Unreviewed. Disabled meter-element.html temporally.
We need to rebaseline it.

  • platform/qt/Skipped:
10:35 PM Changeset in webkit [61377] by morrita@google.com
  • 2 edits in trunk/WebCore

2010-06-17 MORITA Hajime <​morrita@google.com>

Unreviewd, fixed a build break.

  • css/CSSSelector.cpp: (WebCore::CSSSelector::pseudoId):
10:13 PM Changeset in webkit [61376] by morrita@google.com
  • 31 edits
    2 copies
    8 adds in trunk

2010-06-15 MORITA Hajime <​morrita@google.com>

Reviewed by Kent Tamura.

<meter> should allow styling for each gauge-level and component
​https://bugs.webkit.org/show_bug.cgi?id=40280

  • Updated expectations because both rendering result, render tree structure, html.css was changed.
  • fast/dom/HTMLMeterElement/meter-styles-changing-pseudo.html: Added.
  • fast/dom/HTMLMeterElement/meter-styles.html: Added.
  • platform/chromium/test_expectations.txt:
  • platform/gtk/Skipped:
  • platform/mac/fast/dom/HTMLMeterElement/meter-appearances-capacity-expected.checksum:
  • platform/mac/fast/dom/HTMLMeterElement/meter-element-expected.checksum:
  • platform/mac/fast/dom/HTMLMeterElement/meter-element-expected.png:
  • platform/mac/fast/dom/HTMLMeterElement/meter-element-expected.txt:
  • platform/mac/fast/dom/HTMLMeterElement/meter-optimums-expected.checksum:
  • platform/mac/fast/dom/HTMLMeterElement/meter-optimums-expected.png:
  • platform/mac/fast/dom/HTMLMeterElement/meter-styles-changing-pseudo-expected.checksum: Added.
  • platform/mac/fast/dom/HTMLMeterElement/meter-styles-changing-pseudo-expected.png: Added.
  • platform/mac/fast/dom/HTMLMeterElement/meter-styles-changing-pseudo-expected.txt: Added.
  • platform/mac/fast/dom/HTMLMeterElement/meter-styles-expected.checksum: Added.
  • platform/mac/fast/dom/HTMLMeterElement/meter-styles-expected.png: Added.
  • platform/mac/fast/dom/HTMLMeterElement/meter-styles-expected.txt: Added.
  • platform/win/Skipped:

2010-06-16 MORITA Hajime <​morrita@google.com>

Reviewed by Kent Tamura.

<meter> should allow styling for each gauge-level and component
​https://bugs.webkit.org/show_bug.cgi?id=40280

  • Introduced following new pseudo classes for <meter> element.
  • -webkit-meter-horizontal-bar
  • -webkit-meter-vertical-bar
  • -webkit-meter-horizontal-optimum-value
  • -webkit-meter-vertical-optimum-value
  • -webkit-meter-horizontal-suboptimal-value
  • -webkit-meter-vertical-suboptimal-value
  • -webkit-meter-horizontal-even-less-good-value
  • -webkit-meter-vertical-even-less-good-value
  • Introduced 2 shadow nodes for RenderMeter to handle CSS styling. one for bar part and another for value part.
  • Removed RenderTheme::paintMeter() implementation because it can be handled by styled painting without RenderTheme.
  • Pulled RenderIndicator up to super class from RenderProgress, then make RenderMeter a subclass of it.
  • Moved shadow related methods from RenderProgress to ShadowBlockElement to share it with RenderMeter.
  • Added rules for html.css for new pseudo classes.

Tests: fast/dom/HTMLMeterElement/meter-styles-changing-pseudo.html

fast/dom/HTMLMeterElement/meter-styles.html

  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • css/CSSSelector.cpp: (WebCore::CSSSelector::pseudoId): (WebCore::nameToPseudoTypeMap): (WebCore::CSSSelector::extractPseudoType):
  • css/CSSSelector.h: (WebCore::CSSSelector::):
  • css/html.css: (meter::-webkit-meter-horizontal-bar): (meter::-webkit-meter-vertical-bar): (meter::-webkit-meter-horizontal-optimum-value): (meter::-webkit-meter-horizontal-suboptimal-value): (meter::-webkit-meter-horizontal-even-less-good-value): (meter::-webkit-meter-vertical-optimum-value): (meter::-webkit-meter-vertical-suboptimal-value): (meter::-webkit-meter-vertical-even-less-good-value):
  • rendering/RenderIndicator.cpp: Added. (WebCore::RenderIndicator::RenderIndicator): (WebCore::RenderIndicator::~RenderIndicator): (WebCore::RenderIndicator::layout): (WebCore::RenderIndicator::styleDidChange): (WebCore::RenderIndicator::updateFromElement): (WebCore::RenderIndicator::hasParts): (WebCore::RenderIndicator::requestLayoutForParts):
  • rendering/RenderIndicator.h: Added. (WebCore::RenderIndicator::requiresForcedStyleRecalcPropagation):
  • rendering/RenderMeter.cpp: (WebCore::RenderMeter::RenderMeter): (WebCore::RenderMeter::~RenderMeter): (WebCore::RenderMeter::layoutParts): Added. (WebCore::RenderMeter::shouldHaveParts): Added. (WebCore::RenderMeter::valueRatio): Added. (WebCore::RenderMeter::barPartRect): Added. (WebCore::RenderMeter::valuePartRect): Added. (WebCore::RenderMeter::isHorizontal): Added. (WebCore::RenderMeter::valuePseudoId): Added. (WebCore::RenderMeter::barPseudoId): Added. (WebCore::RenderMeter::updatePartsState): Added.
  • rendering/RenderMeter.h:
  • rendering/RenderProgress.cpp: (WebCore::RenderProgress::RenderProgress): (WebCore::RenderProgress::updateFromElement): (WebCore::RenderProgress::paint): (WebCore::RenderProgress::layoutParts): Added. (WebCore::RenderProgress::shouldHaveParts): Added. (WebCore::RenderProgress::updatePartsState): (WebCore::RenderProgress::valuePartRect):
  • rendering/RenderProgress.h:
  • rendering/RenderTheme.cpp: (WebCore::RenderTheme::isControlStyled): (WebCore::RenderTheme::paintMeter):
  • rendering/RenderTheme.h: (WebCore::RenderTheme::supportsMeter): Added.
  • rendering/RenderThemeMac.h:
  • rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::supportsMeter): Added.
  • rendering/ShadowElement.cpp: (WebCore::ShadowBlockElement::layoutAsPart): Added. (WebCore::ShadowBlockElement::updateStyleForPart): Added. (WebCore::ShadowBlockElement::createForPart): Added. (WebCore::ShadowBlockElement::createStyleForPart): Added. (WebCore::ShadowBlockElement::partShouldHaveStyle): Added.
  • rendering/ShadowElement.h:
  • rendering/style/RenderStyleConstants.h: (WebCore::):
9:30 PM Changeset in webkit [61375] by ukai@chromium.org
  • 5 edits
    4 adds in trunk

2010-06-17 Fumitoshi Ukai <​ukai@chromium.org>

Reviewed by Alexey Proskuryakov.

WebSocket: resume should not process buffer if already processing.
​https://bugs.webkit.org/show_bug.cgi?id=39340

Reviewed by Alexey Proskuryakov.

  • websocket/tests/alert-in-event-handler-expected.txt: Added.
  • websocket/tests/alert-in-event-handler.html: Added.
  • websocket/tests/script-tests/alert-in-event-handler.js: Added.
  • websocket/tests/send2_wsh.py: Added.

2010-06-17 Fumitoshi Ukai <​ukai@chromium.org>

Reviewed by Alexey Proskuryakov.

WebSocket: resume should not process buffer if already processing.
​https://bugs.webkit.org/show_bug.cgi?id=39340

Test: websocket/tests/alert-in-event-handler.html

While running an event handler of WebSocket object, it may be suspended
and resumed in various reason. e.g. alert() will suspend/resume
ActiveDOM objects. In chromium, sending IPC message would also
suspend/resume ActiveDOM objects.
If resume process pending buffer in this case, another event might
be fired while running the initial event handler.
Thus, resume should not process pending buffer immediately.
Pending buffer would be processed after the current task has been
finished.

  • websockets/ThreadableWebSocketChannelClientWrapper.h:
  • websockets/WebSocketChannel.cpp: (WebCore::WebSocketChannel::WebSocketChannel): (WebCore::WebSocketChannel::resume): Just set one shot timer for resumeTimerFired() if not yet set. (WebCore::WebSocketChannel::resumeTimerFired): Process pending event after resume was called.
  • websockets/WebSocketChannel.h:
9:14 PM Changeset in webkit [61374] by eric@webkit.org
  • 6 edits in trunk/WebCore

2010-06-17 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

REGRESSION(HTML5 parser): editing/selection/leave-requested-block.html can fail or crash
​https://bugs.webkit.org/show_bug.cgi?id=40764

HTML5ScriptRunner was careful to only call CachedResource::addClient
for cases where the resource was not already loaded. This was to
avoid getting synchronous notifyFinished callbacks from inside
addClient. (The old HTMLDocumentParser also has hacks to work around
addClient's synchronous notifyFinished behavior for already-loaded
resources as well.)

It turns out that CachedResource will mark itself as purgeable if it
has no clients, thus it could have its data cleared (but itself not
deleted) in the case where we yield back to the runloop to wait for
CSS to load before executing the loaded script.

The fix is to act more like the old parser and always call addClient
on every CachedScript we load. But unlike the old parser, we're
careful not to re-enter from addClient -> notifyFinished
using guards in HTML5DocumentParser::watchForLoad.

I do not know how to make a CachedResource purge itself
from a LayoutTest, so this is not currently testable.
If anyone knows how I'm happy to make a test.

  • html/HTML5DocumentParser.cpp: (WebCore::HTML5DocumentParser::watchForLoad):
    • It is now expected to call watchForLoad with a loaded script.

(WebCore::HTML5DocumentParser::notifyFinished):

  • Now that watchForLoad is called with loaded scripts, notifyFinished may be be called from addClient, thus we may be in the middle of script execution when it's called. It's OK. We pass the call along to HTML5ScriptRunner::executeScriptsWaitingForLoad and it knows how to ignore the call in that case.
  • html/HTML5DocumentParser.h:
    • Document these member variables more.
  • html/HTML5ScriptRunner.cpp: (WebCore::HTML5ScriptRunner::~HTML5ScriptRunner): (WebCore::HTML5ScriptRunner::executePendingScript): (WebCore::HTML5ScriptRunner::hasScriptsWaitingForLoad): (WebCore::HTML5ScriptRunner::watchForLoad):
    • Set the pending script to RegisteringForWatch state before watching and WatchingForLoad after.

(WebCore::HTML5ScriptRunner::stopWatchingForLoad):

  • Set the pending script to NotWatchingForLoad.

(WebCore::HTML5ScriptRunner::executeScriptsWaitingForLoad):

  • Assert that callers checked hasScriptsWaitingForLoad()

(WebCore::HTML5ScriptRunner::requestScript):

  • html/HTML5ScriptRunner.h: (WebCore::HTML5ScriptRunner::PendingScript::): (WebCore::HTML5ScriptRunner::PendingScript::PendingScript): (WebCore::HTML5ScriptRunner::PendingScript::watchingForLoad):
  • html/HTML5ScriptRunnerHost.h:
    • Document the new expectations of watchForLoad
9:02 PM Changeset in webkit [61373] by tkent@chromium.org
  • 2 edits in trunk/LayoutTests

2010-06-17 Kent Tamura <​tkent@chromium.org>

Unreviewed, test expectation update.

  • platform/chromium/test_expectations.txt: Some tests in fast/repaint/ work fine on Mac.
8:40 PM Changeset in webkit [61372] by abarth@webkit.org
  • 4 edits in trunk/WebCore

2010-06-17 Tony Gentilcore <​tonyg@chromium.org>

Reviewed by Eric Seidel.

Prevent HTML5PreloadScanner from loading resources in <noscript> tags.
​https://bugs.webkit.org/show_bug.cgi?id=40779

No new tests. Will create a layout test in a subsequent patch.

  • html/HTML5PreloadScanner.cpp: (WebCore::HTML5PreloadScanner::processToken):
  • html/HTML5TreeBuilder.cpp: (WebCore::HTML5TreeBuilder::adjustedLexerState): (WebCore::HTML5TreeBuilder::passTokenToLegacyParser): (WebCore::HTML5TreeBuilder::isScriptingFlagEnabled):
  • html/HTML5TreeBuilder.h:
7:53 PM Changeset in webkit [61371] by eric@webkit.org
  • 2 edits in trunk/LayoutTests

2010-06-17 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r61368.
​http://trac.webkit.org/changeset/61368
​https://bugs.webkit.org/show_bug.cgi?id=40806

Well, actually, it still fails :( (Requested by abarth on
#webkit).

  • platform/qt/Skipped:
7:48 PM Changeset in webkit [61370] by abarth@webkit.org
  • 7 edits in trunk

2010-06-17 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

HTML5PreloadScanner parses <script> in DataState
​https://bugs.webkit.org/show_bug.cgi?id=40804

The ScriptDataState is handled separately from the rest of the lexer
state changes because it's more complicted in the tree builder. The
easiest thing is to just handle it separately in the preloader too.

  • html/HTML5PreloadScanner.cpp: (WebCore::HTML5PreloadScanner::processToken):

2010-06-17 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

HTML5PreloadScanner parses <script> in DataState
​https://bugs.webkit.org/show_bug.cgi?id=40804

Remove the aforementioned hack that was working around this bug. As a
nice side effect, we get test coverage for this bug. :)

  • fast/preloader/image.html:
  • fast/preloader/link.html:
  • fast/preloader/script.html:
  • fast/preloader/style.html:
7:39 PM Changeset in webkit [61369] by tkent@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed, test expectation fix.

  • platform/chromium/test_expectations.txt: fast/preloader/*.html

fail because of no dumpResourceResponseMIMETypes(),
stripNullFromTextNodes.html have not failed recently.

7:31 PM Changeset in webkit [61368] by abarth@webkit.org
  • 2 edits in trunk/LayoutTests

2010-06-17 Adam Barth <​abarth@webkit.org>

Unreviewed.

I bet this test passes now. :)

  • platform/qt/Skipped:
7:21 PM Changeset in webkit [61367] by abarth@webkit.org
  • 3 edits in trunk/LayoutTests

2010-06-17 Adam Barth <​abarth@webkit.org>

Unreviewed.

Skip fast/preloader tests on GTK and Qt because they don't implement
dumpResourceResponseMIMETypes.

  • platform/gtk/Skipped:
  • platform/qt/Skipped:
7:01 PM Changeset in webkit [61366] by abarth@webkit.org
  • 10 edits
    16 adds in trunk

2010-06-17 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Add CSS scanning to HTML5PreloadScanner
​https://bugs.webkit.org/show_bug.cgi?id=40802

This patch just cribs the CSS preload scanning algorithm from the old
preload scanner. We also invented a way of testing the preload
scanner.

Tests: fast/preloader/image.html

fast/preloader/link.html
fast/preloader/script.html
fast/preloader/style.html

  • Android.mk:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • html/CSSPreloadScanner.cpp: Added. (WebCore::isWhitespace): (WebCore::CSSPreloadScanner::CSSPreloadScanner): (WebCore::CSSPreloadScanner::reset): (WebCore::CSSPreloadScanner::scan): (WebCore::CSSPreloadScanner::tokenize): (WebCore::CSSPreloadScanner::emitRule):
  • html/CSSPreloadScanner.h: Added. (WebCore::CSSPreloadScanner::):
  • html/HTML5PreloadScanner.cpp: (WebCore::HTML5PreloadScanner::HTML5PreloadScanner): (WebCore::HTML5PreloadScanner::processToken): (WebCore::HTML5PreloadScanner::scanningBody):
  • html/HTML5PreloadScanner.h:

2010-06-17 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Add CSS scanning to HTML5PreloadScanner
​https://bugs.webkit.org/show_bug.cgi?id=40802

Add a testing framework for the preload scanner. These test cover
basic preloader behavior. They have a small hack to work around a bug
in the preload scanner discovered while writing the tests. I'll fix
the bug and remove the hack in a followup patch.

  • fast/preloader/image-expected.txt: Added.
  • fast/preloader/image.html: Added.
  • fast/preloader/link-expected.txt: Added.
  • fast/preloader/link.html: Added.
  • fast/preloader/resources/image1.png: Added.
  • fast/preloader/resources/link1.css: Added.
  • fast/preloader/resources/script1.js: Added.
  • fast/preloader/resources/style1.css: Added.
  • fast/preloader/script-expected.txt: Added.
  • fast/preloader/script.html: Added.
  • fast/preloader/style-expected.txt: Added.
  • fast/preloader/style.html: Added.
6:24 PM Changeset in webkit [61365] by dpranke@chromium.org
  • 2 edits in trunk/WebCore

2010-06-17 Abhishek Arya <​inferno@chromium.org>

Reviewed by David Kilzer.

(Landed by Dirk Pranke).

Check for a null frame before setting drag selection.
​https://bugs.webkit.org/show_bug.cgi?id=38893
Same Layout test as ​https://bugs.webkit.org/show_bug.cgi?id=37168.

Test: editing/pasteboard/drag-drop-iframe-refresh-crash.html

Note that you need to run the test manually 20-30 times for the crash
to reproduce.

  • editing/SelectionController.cpp: (WebCore::SelectionController::setSelection):
5:53 PM Changeset in webkit [61364] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-06-17 Benjamin Poulain <​benjamin.poulain@nokia.com>

Reviewed by Simon Hausmann.

[Qt] Get rid of the the unused imageSize of ImageDecoderQt::internalHandleCurrentImage()
​https://bugs.webkit.org/show_bug.cgi?id=40620

Remove an unused variable.

  • platform/graphics/qt/ImageDecoderQt.cpp: (WebCore::ImageDecoderQt::internalHandleCurrentImage):
5:39 PM Changeset in webkit [61363] by eric@webkit.org
  • 4 edits in trunk

2010-06-17 Tony Chang <​tony@chromium.org>

Reviewed by Kent Tamura.

[chromium] cleanup redundant DEPS value and remove buildbot cleanup code
​https://bugs.webkit.org/show_bug.cgi?id=40615

  • DEPS: tools/data_pack was listed twice for linux (harmless, but unnecessary)

2010-06-17 Tony Chang <​tony@chromium.org>

Reviewed by Kent Tamura.

[chromium] cleanup redundant DEPS value and remove buildbot cleanup code
​https://bugs.webkit.org/show_bug.cgi?id=40615

  • Scripts/update-webkit-chromium: remove directory removal of third_party in old checkouts
5:29 PM Changeset in webkit [61362] by andersca@apple.com
  • 2 edits in trunk/WebKit2

Fix a race condition during startup where we would never send the InitializeConnection message to the server.

Reviewed by Sam Weinig.

  • Platform/CoreIPC/mac/ConnectionMac.cpp:

(CoreIPC::Connection::open):

5:24 PM Changeset in webkit [61361] by eric@webkit.org
  • 5 edits
    1 add in trunk

2010-06-17 Jeremy Moskovich <​jeremy@chromium.org>

Reviewed by Darin Fisher.

[Chromium API] Implement WebSandboxSupport on OS X and add stubs to allow
OOP loading of fonts.

​https://bugs.webkit.org/show_bug.cgi?id=40544

  • platform/chromium/ChromiumBridge.h: Add prototype for loadFont()

2010-06-17 Jeremy Moskovich <​jeremy@chromium.org>

Reviewed by Darin Fisher.

[Chromium API] Implement WebSandboxSupport on OS X and add stubs to allow
OOP loading of fonts.

​https://bugs.webkit.org/show_bug.cgi?id=40544

  • WebKit.gyp: Add mac WebSandboxSupport.h
  • public/mac/WebSandboxSupport.h: Added.
  • src/ChromiumBridge.cpp: (WebCore::ChromiumBridge::loadFont):
5:00 PM Changeset in webkit [61360] by eric@webkit.org
  • 18 edits in trunk/WebCore

2010-06-17 Nicolas Weber <​thakis@chromium.org>

Reviewed by Eric Seidel.

Fix various warnings that are reported when building with clang
​https://bugs.webkit.org/show_bug.cgi?id=40503

  • accessibility/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::labelElementContainer):
  • accessibility/AccessibilityTableCell.cpp: (WebCore::AccessibilityTableCell::parentTable):
  • bindings/v8/NPV8Object.cpp: (WebCore::npObjectTypeInfo):
  • bindings/v8/custom/V8HTMLAudioElementConstructor.cpp: (WebCore::):
  • bindings/v8/custom/V8HTMLImageElementConstructor.cpp: (WebCore::):
  • bindings/v8/custom/V8HTMLOptionElementConstructor.cpp: (WebCore::):
  • css/CSSStyleSheet.h:
  • html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::getNamedElements):
  • inspector/InspectorValues.cpp: (WebCore::InspectorObject::getObject): (WebCore::InspectorObject::getArray):
  • page/animation/AnimationBase.h:
  • platform/graphics/BitmapImage.h: (WTF::):
  • platform/graphics/mac/FontPlatformData.h:
  • rendering/RenderBlock.h:
  • rendering/RootInlineBox.cpp: (WebCore::RootInlineBox::ellipsisBox):
  • storage/StorageNamespaceImpl.cpp: (WebCore::StorageNamespaceImpl::storageArea):
4:39 PM Changeset in webkit [61359] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-06-17 Kwang Yul Seo <​skyul@company100.net>

Reviewed by Pavel Feldman.

Add ENABLE(INSPECTOR) guard for m_sessionSettings
​https://bugs.webkit.org/show_bug.cgi?id=40611

Build fix.

  • inspector/InspectorController.h:
4:28 PM Changeset in webkit [61358] by adachan@apple.com
  • 9 edits
    1 copy
    5 deletes in trunk

WebKit2:

Rolling out ​http://trac.webkit.org/changeset/61297 due to build errors.

  • WebKit2.xcodeproj/project.pbxproj:
  • WebProcess/InjectedBundle/API/c/WKBundlePage.cpp: Removed.
  • WebProcess/InjectedBundle/API/c/WKBundlePage.h: Removed.
  • WebProcess/InjectedBundle/InjectedBundlePageClient.cpp: Removed.
  • WebProcess/InjectedBundle/InjectedBundlePageClient.h: Removed.
  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp: (WebKit::WebFrameLoaderClient::dispatchDidClearWindowObjectInWorld):
  • WebProcess/WebPage/WebPage.cpp:
  • WebProcess/WebPage/WebPage.h:
  • mac/WebKit2.exp:
  • win/WebKit2.vcproj:

WebKitTools:

Rolling out ​http://trac.webkit.org/changeset/61297 due to build errors.

  • MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
  • MiniBrowser/mac/WebBundle/WebBundleMain.c: Copied from MiniBrowser/mac/WebBundle/WebBundleMain.c.
  • MiniBrowser/mac/WebBundle/WebBundleMain.m: Removed.
4:25 PM Changeset in webkit [61357] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-06-17 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Add FIXME to explain HTMLDocumentParser's forceSynchronous bool
​https://bugs.webkit.org/show_bug.cgi?id=40609

No functional change, just adding comment.

  • dom/Document.cpp: (WebCore::Document::write):
4:25 PM Changeset in webkit [61356] by Dimitri Glazkov
  • 2 edits
    2 adds
    1 delete in trunk/LayoutTests

2010-06-17 Dimitri Glazkov <Dimitri Glazkov>

Unreviewed, Chromium expectations update.

  • platform/chromium-mac/fast/js/missing-title-end-tag-js-expected.checksum: Added.
  • platform/chromium-mac/fast/js/missing-title-end-tag-js-expected.png: Added.
  • platform/chromium-win-xp/fast/text/atsui-spacing-features-expected.checksum: Changed
  • platform/chromium-win-xp/fast/text/atsui-spacing-features-expected.png: Removed.
4:04 PM Changeset in webkit [61355] by senorblanco@chromium.org
  • 394 edits
    3 adds
    36 deletes in trunk/LayoutTests

2010-06-17 Stephen White <​senorblanco@chromium.org>

Unreviewed; expectations fix.

This updates the pixel test baselines after r61341, and removes them
from test_expectations.

  • platform/chromium-linux/css2.1/t090501-c414-flt-03-b-g-expected.checksum:
  • platform/chromium-linux/css2.1/t090501-c414-flt-03-b-g-expected.png:
  • platform/chromium-linux/css2.1/t090501-c5525-flt-l-00-b-g-expected.checksum:
  • platform/chromium-linux/css2.1/t090501-c5525-flt-l-00-b-g-expected.png:
  • platform/chromium-linux/css2.1/t090501-c5525-flt-r-00-b-g-expected.checksum:
  • platform/chromium-linux/css2.1/t090501-c5525-flt-r-00-b-g-expected.png:
  • platform/chromium-linux/fast/backgrounds/size/backgroundSize11-expected.checksum: Added.
  • platform/chromium-linux/fast/backgrounds/size/backgroundSize15-expected.checksum:
  • platform/chromium-linux/fast/backgrounds/size/backgroundSize15-expected.png:
  • platform/chromium-linux/fast/backgrounds/size/backgroundSize16-expected.checksum:
  • platform/chromium-linux/fast/backgrounds/size/backgroundSize16-expected.png:
  • platform/chromium-linux/fast/backgrounds/size/backgroundSize19-expected.checksum: Added.
  • platform/chromium-linux/fast/backgrounds/size/backgroundSize22-expected.checksum: Added.
  • platform/chromium-linux/fast/block/positioning/replaced-inside-fixed-top-bottom-expected.checksum: Removed.
  • platform/chromium-linux/fast/block/positioning/replaced-inside-fixed-top-bottom-expected.png: Removed.
  • platform/chromium-linux/fast/css/value-list-out-of-bounds-crash-expected.checksum:
  • platform/chromium-linux/fast/css/value-list-out-of-bounds-crash-expected.png: Removed.
  • platform/chromium-linux/fast/events/pointer-events-2-expected.checksum:
  • platform/chromium-linux/fast/events/pointer-events-2-expected.png:
  • platform/chromium-linux/fast/forms/input-type-change-expected.checksum:
  • platform/chromium-linux/fast/forms/input-type-change-expected.png:
  • platform/chromium-linux/fast/replaced/absolute-image-sizing-expected.checksum:
  • platform/chromium-linux/fast/replaced/absolute-image-sizing-expected.png:
  • platform/chromium-linux/fast/replaced/image-sizing-expected.checksum:
  • platform/chromium-linux/fast/replaced/image-sizing-expected.png: Removed.
  • platform/chromium-linux/tables/mozilla/bugs/bug101674-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug101674-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug11026-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug11026-expected.png: Removed.
  • platform/chromium-linux/tables/mozilla/bugs/bug1188-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug1188-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug1296-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug1430-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug1430-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug14929-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug14929-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug15544-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug15544-expected.png: Removed.
  • platform/chromium-linux/tables/mozilla/bugs/bug2981-2-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug2981-2-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug4093-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug4093-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug4284-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug4284-expected.png: Removed.
  • platform/chromium-linux/tables/mozilla/bugs/bug4427-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug4427-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug56563-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug56563-expected.png: Removed.
  • platform/chromium-linux/tables/mozilla/bugs/bug625-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug625-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug6404-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug6404-expected.png:
  • platform/chromium-linux/tables/mozilla/core/bloomberg-expected.checksum:
  • platform/chromium-linux/tables/mozilla/core/bloomberg-expected.png:
  • platform/chromium-linux/tables/mozilla/core/col_widths_auto_autoFix-expected.checksum:
  • platform/chromium-linux/tables/mozilla/core/col_widths_auto_autoFix-expected.png: Removed.
  • platform/chromium-linux/tables/mozilla/core/misc-expected.checksum:
  • platform/chromium-linux/tables/mozilla/core/misc-expected.png: Removed.
  • platform/chromium-linux/tables/mozilla/marvin/tbody_valign_baseline-expected.checksum:
  • platform/chromium-linux/tables/mozilla/marvin/tbody_valign_baseline-expected.png: Removed.
  • platform/chromium-linux/tables/mozilla/marvin/tbody_valign_bottom-expected.checksum:
  • platform/chromium-linux/tables/mozilla/marvin/tbody_valign_bottom-expected.png: Removed.
  • platform/chromium-linux/tables/mozilla/marvin/tbody_valign_middle-expected.checksum:
  • platform/chromium-linux/tables/mozilla/marvin/tbody_valign_middle-expected.png: Removed.
  • platform/chromium-linux/tables/mozilla/marvin/tbody_valign_top-expected.checksum:
  • platform/chromium-linux/tables/mozilla/marvin/tbody_valign_top-expected.png: Removed.
  • platform/chromium-linux/tables/mozilla/marvin/td_valign_baseline-expected.checksum:
  • platform/chromium-linux/tables/mozilla/marvin/td_valign_baseline-expected.png: Removed.
  • platform/chromium-linux/tables/mozilla/marvin/td_valign_bottom-expected.checksum:
  • platform/chromium-linux/tables/mozilla/marvin/td_valign_bottom-expected.png: Removed.
  • platform/chromium-linux/tables/mozilla/marvin/td_valign_middle-expected.checksum:
  • platform/chromium-linux/tables/mozilla/marvin/td_valign_middle-expected.png: Removed.
  • platform/chromium-linux/tables/mozilla/marvin/td_valign_top-expected.checksum:
  • platform/chromium-linux/tables/mozilla/marvin/td_valign_top-expected.png: Removed.
  • platform/chromium-linux/tables/mozilla/marvin/tfoot_valign_baseline-expected.checksum:
  • platform/chromium-linux/tables/mozilla/marvin/tfoot_valign_baseline-expected.png: Removed.
  • platform/chromium-linux/tables/mozilla/marvin/tfoot_valign_bottom-expected.checksum:
  • platform/chromium-linux/tables/mozilla/marvin/tfoot_valign_bottom-expected.png: Removed.
  • platform/chromium-linux/tables/mozilla/marvin/tfoot_valign_middle-expected.checksum:
  • platform/chromium-linux/tables/mozilla/marvin/tfoot_valign_middle-expected.png: Removed.
  • platform/chromium-linux/tables/mozilla/marvin/tfoot_valign_top-expected.checksum:
  • platform/chromium-linux/tables/mozilla/marvin/tfoot_valign_top-expected.png: Removed.
  • platform/chromium-linux/tables/mozilla/marvin/th_valign_baseline-expected.checksum:
  • platform/chromium-linux/tables/mozilla/marvin/th_valign_baseline-expected.png: Removed.
  • platform/chromium-linux/tables/mozilla/marvin/th_valign_bottom-expected.checksum:
  • platform/chromium-linux/tables/mozilla/marvin/th_valign_bottom-expected.png: Removed.
  • platform/chromium-linux/tables/mozilla/marvin/th_valign_middle-expected.checksum:
  • platform/chromium-linux/tables/mozilla/marvin/th_valign_middle-expected.png: Removed.
  • platform/chromium-linux/tables/mozilla/marvin/th_valign_top-expected.checksum:
  • platform/chromium-linux/tables/mozilla/marvin/th_valign_top-expected.png: Removed.
  • platform/chromium-linux/tables/mozilla/marvin/thead_valign_baseline-expected.checksum:
  • platform/chromium-linux/tables/mozilla/marvin/thead_valign_baseline-expected.png: Removed.
  • platform/chromium-linux/tables/mozilla/marvin/thead_valign_bottom-expected.checksum:
  • platform/chromium-linux/tables/mozilla/marvin/thead_valign_bottom-expected.png: Removed.
  • platform/chromium-linux/tables/mozilla/marvin/thead_valign_middle-expected.checksum:
  • platform/chromium-linux/tables/mozilla/marvin/thead_valign_middle-expected.png: Removed.
  • platform/chromium-linux/tables/mozilla/marvin/thead_valign_top-expected.checksum:
  • platform/chromium-linux/tables/mozilla/marvin/thead_valign_top-expected.png: Removed.
  • platform/chromium-linux/tables/mozilla/marvin/tr_valign_baseline-expected.checksum:
  • platform/chromium-linux/tables/mozilla/marvin/tr_valign_baseline-expected.png: Removed.
  • platform/chromium-linux/tables/mozilla/marvin/tr_valign_bottom-expected.checksum:
  • platform/chromium-linux/tables/mozilla/marvin/tr_valign_bottom-expected.png: Removed.
  • platform/chromium-linux/tables/mozilla/marvin/tr_valign_middle-expected.checksum:
  • platform/chromium-linux/tables/mozilla/marvin/tr_valign_middle-expected.png: Removed.
  • platform/chromium-linux/tables/mozilla/marvin/tr_valign_top-expected.checksum:
  • platform/chromium-linux/tables/mozilla/marvin/tr_valign_top-expected.png: Removed.
  • platform/chromium-linux/tables/mozilla/other/cell_widths-expected.checksum:
  • platform/chromium-linux/tables/mozilla/other/cell_widths-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/97619-expected.checksum:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/97619-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug6933-expected.checksum:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug6933-expected.png: Removed.
  • platform/chromium-mac/fast/backgrounds/size/backgroundSize16-expected.checksum: Removed.
  • platform/chromium-win/css2.1/t090501-c414-flt-03-b-g-expected.checksum:
  • platform/chromium-win/css2.1/t090501-c414-flt-03-b-g-expected.png:
  • platform/chromium-win/css2.1/t090501-c5525-flt-l-00-b-g-expected.checksum:
  • platform/chromium-win/css2.1/t090501-c5525-flt-l-00-b-g-expected.png:
  • platform/chromium-win/css2.1/t090501-c5525-flt-r-00-b-g-expected.checksum:
  • platform/chromium-win/css2.1/t090501-c5525-flt-r-00-b-g-expected.png:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize01-expected.checksum:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize01-expected.png:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize02-expected.checksum:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize02-expected.png:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize04-expected.checksum:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize04-expected.png:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize05-expected.checksum:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize05-expected.png:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize06-expected.checksum:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize06-expected.png:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize07-expected.checksum:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize07-expected.png:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize08-expected.checksum:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize08-expected.png:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize09-expected.checksum:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize09-expected.png:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize10-expected.checksum:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize10-expected.png:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize11-expected.checksum:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize11-expected.png:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize12-expected.checksum:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize12-expected.png:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize13-expected.checksum:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize13-expected.png:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize14-expected.checksum:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize14-expected.png:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize15-expected.checksum:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize15-expected.png:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize16-expected.checksum:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize16-expected.png:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize17-expected.checksum:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize17-expected.png:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize18-expected.checksum:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize18-expected.png:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize19-expected.checksum:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize19-expected.png:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize20-expected.checksum:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize20-expected.png:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize21-expected.checksum:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize21-expected.png:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize22-expected.checksum:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize22-expected.png:
  • platform/chromium-win/fast/block/positioning/replaced-inside-fixed-top-bottom-expected.checksum:
  • platform/chromium-win/fast/block/positioning/replaced-inside-fixed-top-bottom-expected.png:
  • platform/chromium-win/fast/css/value-list-out-of-bounds-crash-expected.checksum:
  • platform/chromium-win/fast/css/value-list-out-of-bounds-crash-expected.png:
  • platform/chromium-win/fast/events/pointer-events-2-expected.checksum:
  • platform/chromium-win/fast/events/pointer-events-2-expected.png:
  • platform/chromium-win/fast/forms/input-type-change-expected.checksum:
  • platform/chromium-win/fast/forms/input-type-change-expected.png:
  • platform/chromium-win/fast/replaced/absolute-image-sizing-expected.checksum:
  • platform/chromium-win/fast/replaced/absolute-image-sizing-expected.png:
  • platform/chromium-win/fast/replaced/image-sizing-expected.checksum:
  • platform/chromium-win/fast/replaced/image-sizing-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug101674-expected.checksum:
  • platform/chromium-win/tables/mozilla/bugs/bug101674-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug11026-expected.checksum:
  • platform/chromium-win/tables/mozilla/bugs/bug11026-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug1188-expected.checksum:
  • platform/chromium-win/tables/mozilla/bugs/bug1188-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug1296-expected.checksum:
  • platform/chromium-win/tables/mozilla/bugs/bug1296-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug1430-expected.checksum:
  • platform/chromium-win/tables/mozilla/bugs/bug1430-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug14929-expected.checksum:
  • platform/chromium-win/tables/mozilla/bugs/bug14929-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug15544-expected.checksum:
  • platform/chromium-win/tables/mozilla/bugs/bug15544-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug2981-2-expected.checksum:
  • platform/chromium-win/tables/mozilla/bugs/bug2981-2-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug4093-expected.checksum:
  • platform/chromium-win/tables/mozilla/bugs/bug4093-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug4284-expected.checksum:
  • platform/chromium-win/tables/mozilla/bugs/bug4284-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug4427-expected.checksum:
  • platform/chromium-win/tables/mozilla/bugs/bug4427-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug56563-expected.checksum:
  • platform/chromium-win/tables/mozilla/bugs/bug56563-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug625-expected.checksum:
  • platform/chromium-win/tables/mozilla/bugs/bug625-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug6404-expected.checksum:
  • platform/chromium-win/tables/mozilla/bugs/bug6404-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug97383-expected.checksum:
  • platform/chromium-win/tables/mozilla/bugs/bug97383-expected.png:
  • platform/chromium-win/tables/mozilla/core/bloomberg-expected.checksum:
  • platform/chromium-win/tables/mozilla/core/bloomberg-expected.png:
  • platform/chromium-win/tables/mozilla/core/col_widths_auto_autoFix-expected.checksum:
  • platform/chromium-win/tables/mozilla/core/col_widths_auto_autoFix-expected.png:
  • platform/chromium-win/tables/mozilla/core/misc-expected.checksum:
  • platform/chromium-win/tables/mozilla/core/misc-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tbody_valign_baseline-expected.checksum:
  • platform/chromium-win/tables/mozilla/marvin/tbody_valign_baseline-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tbody_valign_bottom-expected.checksum:
  • platform/chromium-win/tables/mozilla/marvin/tbody_valign_bottom-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tbody_valign_middle-expected.checksum:
  • platform/chromium-win/tables/mozilla/marvin/tbody_valign_middle-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tbody_valign_top-expected.checksum:
  • platform/chromium-win/tables/mozilla/marvin/tbody_valign_top-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/td_valign_baseline-expected.checksum:
  • platform/chromium-win/tables/mozilla/marvin/td_valign_baseline-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/td_valign_bottom-expected.checksum:
  • platform/chromium-win/tables/mozilla/marvin/td_valign_bottom-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/td_valign_middle-expected.checksum:
  • platform/chromium-win/tables/mozilla/marvin/td_valign_middle-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/td_valign_top-expected.checksum:
  • platform/chromium-win/tables/mozilla/marvin/td_valign_top-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tfoot_valign_baseline-expected.checksum:
  • platform/chromium-win/tables/mozilla/marvin/tfoot_valign_baseline-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tfoot_valign_bottom-expected.checksum:
  • platform/chromium-win/tables/mozilla/marvin/tfoot_valign_bottom-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tfoot_valign_middle-expected.checksum:
  • platform/chromium-win/tables/mozilla/marvin/tfoot_valign_middle-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tfoot_valign_top-expected.checksum:
  • platform/chromium-win/tables/mozilla/marvin/tfoot_valign_top-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/th_valign_baseline-expected.checksum:
  • platform/chromium-win/tables/mozilla/marvin/th_valign_baseline-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/th_valign_bottom-expected.checksum:
  • platform/chromium-win/tables/mozilla/marvin/th_valign_bottom-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/th_valign_middle-expected.checksum:
  • platform/chromium-win/tables/mozilla/marvin/th_valign_middle-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/th_valign_top-expected.checksum:
  • platform/chromium-win/tables/mozilla/marvin/th_valign_top-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/thead_valign_baseline-expected.checksum:
  • platform/chromium-win/tables/mozilla/marvin/thead_valign_baseline-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/thead_valign_bottom-expected.checksum:
  • platform/chromium-win/tables/mozilla/marvin/thead_valign_bottom-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/thead_valign_middle-expected.checksum:
  • platform/chromium-win/tables/mozilla/marvin/thead_valign_middle-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/thead_valign_top-expected.checksum:
  • platform/chromium-win/tables/mozilla/marvin/thead_valign_top-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tr_valign_baseline-expected.checksum:
  • platform/chromium-win/tables/mozilla/marvin/tr_valign_baseline-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tr_valign_bottom-expected.checksum:
  • platform/chromium-win/tables/mozilla/marvin/tr_valign_bottom-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tr_valign_middle-expected.checksum:
  • platform/chromium-win/tables/mozilla/marvin/tr_valign_middle-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tr_valign_top-expected.checksum:
  • platform/chromium-win/tables/mozilla/marvin/tr_valign_top-expected.png:
  • platform/chromium-win/tables/mozilla/other/cell_widths-expected.checksum:
  • platform/chromium-win/tables/mozilla/other/cell_widths-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/97619-expected.checksum:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/97619-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug6933-expected.checksum:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug6933-expected.png:
  • platform/chromium/test_expectations.txt:
  • platform/mac-leopard/css2.1/t0804-c5510-padn-00-b-ag-expected.checksum:
  • platform/mac-leopard/css2.1/t0804-c5510-padn-00-b-ag-expected.png:
  • platform/mac-leopard/tables/mozilla/bugs/bug1430-expected.checksum:
  • platform/mac-leopard/tables/mozilla/bugs/bug1430-expected.png:
  • platform/mac-leopard/tables/mozilla/bugs/bug14929-expected.checksum:
  • platform/mac-leopard/tables/mozilla/bugs/bug14929-expected.png:
  • platform/mac-leopard/tables/mozilla/bugs/bug23235-expected.checksum:
  • platform/mac-leopard/tables/mozilla/bugs/bug23235-expected.png:
  • platform/mac-leopard/tables/mozilla/bugs/bug2981-2-expected.checksum:
  • platform/mac-leopard/tables/mozilla/bugs/bug2981-2-expected.png:
  • platform/mac-leopard/tables/mozilla/bugs/bug4427-expected.checksum:
  • platform/mac-leopard/tables/mozilla/bugs/bug4427-expected.png:
  • platform/mac-leopard/tables/mozilla/bugs/bug6404-expected.checksum:
  • platform/mac-leopard/tables/mozilla/bugs/bug6404-expected.png:
  • platform/mac-leopard/tables/mozilla/core/col_widths_auto_autoFix-expected.checksum:
  • platform/mac-leopard/tables/mozilla/core/col_widths_auto_autoFix-expected.png:
  • platform/mac-leopard/tables/mozilla/marvin/tbody_valign_baseline-expected.checksum:
  • platform/mac-leopard/tables/mozilla/marvin/tbody_valign_baseline-expected.png:
  • platform/mac-leopard/tables/mozilla/marvin/tbody_valign_bottom-expected.checksum:
  • platform/mac-leopard/tables/mozilla/marvin/tbody_valign_bottom-expected.png:
  • platform/mac-leopard/tables/mozilla/marvin/tbody_valign_middle-expected.checksum:
  • platform/mac-leopard/tables/mozilla/marvin/tbody_valign_middle-expected.png:
  • platform/mac-leopard/tables/mozilla/marvin/tbody_valign_top-expected.checksum:
  • platform/mac-leopard/tables/mozilla/marvin/tbody_valign_top-expected.png:
  • platform/mac-leopard/tables/mozilla/marvin/td_valign_baseline-expected.checksum:
  • platform/mac-leopard/tables/mozilla/marvin/td_valign_baseline-expected.png:
  • platform/mac-leopard/tables/mozilla/marvin/tfoot_valign_baseline-expected.checksum:
  • platform/mac-leopard/tables/mozilla/marvin/tfoot_valign_baseline-expected.png:
  • platform/mac-leopard/tables/mozilla/marvin/tfoot_valign_bottom-expected.checksum:
  • platform/mac-leopard/tables/mozilla/marvin/tfoot_valign_bottom-expected.png:
  • platform/mac-leopard/tables/mozilla/marvin/tfoot_valign_middle-expected.checksum:
  • platform/mac-leopard/tables/mozilla/marvin/tfoot_valign_middle-expected.png:
  • platform/mac-leopard/tables/mozilla/marvin/tfoot_valign_top-expected.checksum:
  • platform/mac-leopard/tables/mozilla/marvin/tfoot_valign_top-expected.png:
  • platform/mac-leopard/tables/mozilla/marvin/thead_valign_baseline-expected.checksum:
  • platform/mac-leopard/tables/mozilla/marvin/thead_valign_baseline-expected.png:
  • platform/mac-leopard/tables/mozilla/marvin/thead_valign_bottom-expected.checksum:
  • platform/mac-leopard/tables/mozilla/marvin/thead_valign_bottom-expected.png:
  • platform/mac-leopard/tables/mozilla/marvin/thead_valign_middle-expected.checksum:
  • platform/mac-leopard/tables/mozilla/marvin/thead_valign_middle-expected.png:
  • platform/mac-leopard/tables/mozilla/marvin/thead_valign_top-expected.checksum:
  • platform/mac-leopard/tables/mozilla/marvin/thead_valign_top-expected.png:
  • platform/mac-leopard/tables/mozilla/marvin/tr_valign_baseline-expected.checksum:
  • platform/mac-leopard/tables/mozilla/marvin/tr_valign_baseline-expected.png:
  • platform/mac-leopard/tables/mozilla_expected_failures/bugs/97619-expected.checksum:
  • platform/mac-leopard/tables/mozilla_expected_failures/bugs/97619-expected.png:
  • platform/mac/css2.1/t0905-c414-flt-01-d-g-expected.checksum:
  • platform/mac/css2.1/t0905-c414-flt-01-d-g-expected.png:
  • platform/mac/css2.1/t090501-c414-flt-02-d-g-expected.checksum:
  • platform/mac/css2.1/t090501-c414-flt-02-d-g-expected.png:
  • platform/mac/css2.1/t090501-c414-flt-03-b-g-expected.checksum:
  • platform/mac/css2.1/t090501-c414-flt-03-b-g-expected.png:
  • platform/mac/css2.1/t090501-c414-flt-ln-01-d-g-expected.checksum:
  • platform/mac/css2.1/t090501-c414-flt-ln-01-d-g-expected.png:
  • platform/mac/css2.1/t090501-c5525-flt-l-00-b-g-expected.checksum:
  • platform/mac/css2.1/t090501-c5525-flt-l-00-b-g-expected.png:
  • platform/mac/css2.1/t090501-c5525-flt-r-00-b-g-expected.checksum:
  • platform/mac/css2.1/t090501-c5525-flt-r-00-b-g-expected.png:
  • platform/mac/css2.1/t100304-c43-rpl-bbx-00-d-g-expected.checksum:
  • platform/mac/css2.1/t100304-c43-rpl-bbx-00-d-g-expected.png:
  • platform/mac/css2.1/t100304-c43-rpl-bbx-01-d-g-expected.checksum:
  • platform/mac/css2.1/t100304-c43-rpl-bbx-01-d-g-expected.png:
  • platform/mac/css2.1/t1004-c5524-width-00-b-g-expected.checksum:
  • platform/mac/css2.1/t1004-c5524-width-00-b-g-expected.png:
  • platform/mac/css2.1/t100801-c544-valgn-02-d-agi-expected.checksum:
  • platform/mac/css2.1/t100801-c544-valgn-02-d-agi-expected.png:
  • platform/mac/css2.1/t100801-c544-valgn-03-d-agi-expected.checksum:
  • platform/mac/css2.1/t100801-c544-valgn-03-d-agi-expected.png:
  • platform/mac/css2.1/t100801-c544-valgn-04-d-agi-expected.checksum:
  • platform/mac/css2.1/t100801-c544-valgn-04-d-agi-expected.png:
  • platform/mac/fast/backgrounds/repeat/mask-negative-offset-repeat-expected.checksum:
  • platform/mac/fast/backgrounds/repeat/mask-negative-offset-repeat-expected.png:
  • platform/mac/fast/backgrounds/size/backgroundSize01-expected.checksum:
  • platform/mac/fast/backgrounds/size/backgroundSize01-expected.png:
  • platform/mac/fast/backgrounds/size/backgroundSize05-expected.checksum:
  • platform/mac/fast/backgrounds/size/backgroundSize05-expected.png:
  • platform/mac/fast/backgrounds/size/backgroundSize06-expected.checksum:
  • platform/mac/fast/backgrounds/size/backgroundSize06-expected.png:
  • platform/mac/fast/backgrounds/size/backgroundSize07-expected.checksum:
  • platform/mac/fast/backgrounds/size/backgroundSize07-expected.png:
  • platform/mac/fast/backgrounds/size/backgroundSize08-expected.checksum:
  • platform/mac/fast/backgrounds/size/backgroundSize08-expected.png:
  • platform/mac/fast/backgrounds/size/backgroundSize09-expected.checksum:
  • platform/mac/fast/backgrounds/size/backgroundSize09-expected.png:
  • platform/mac/fast/backgrounds/size/backgroundSize10-expected.checksum:
  • platform/mac/fast/backgrounds/size/backgroundSize10-expected.png:
  • platform/mac/fast/backgrounds/size/backgroundSize11-expected.checksum:
  • platform/mac/fast/backgrounds/size/backgroundSize11-expected.png:
  • platform/mac/fast/backgrounds/size/backgroundSize12-expected.checksum:
  • platform/mac/fast/backgrounds/size/backgroundSize12-expected.png:
  • platform/mac/fast/backgrounds/size/backgroundSize16-expected.checksum:
  • platform/mac/fast/backgrounds/size/backgroundSize16-expected.png:
  • platform/mac/fast/backgrounds/size/backgroundSize17-expected.checksum:
  • platform/mac/fast/backgrounds/size/backgroundSize17-expected.png:
  • platform/mac/fast/backgrounds/size/backgroundSize18-expected.checksum:
  • platform/mac/fast/backgrounds/size/backgroundSize18-expected.png:
  • platform/mac/fast/backgrounds/size/backgroundSize19-expected.checksum:
  • platform/mac/fast/backgrounds/size/backgroundSize19-expected.png:
  • platform/mac/fast/backgrounds/size/backgroundSize20-expected.checksum:
  • platform/mac/fast/backgrounds/size/backgroundSize20-expected.png:
  • platform/mac/fast/backgrounds/size/backgroundSize21-expected.checksum:
  • platform/mac/fast/backgrounds/size/backgroundSize21-expected.png:
  • platform/mac/fast/backgrounds/size/backgroundSize22-expected.checksum:
  • platform/mac/fast/backgrounds/size/backgroundSize22-expected.png:
  • platform/mac/fast/backgrounds/size/zero-expected.checksum:
  • platform/mac/fast/backgrounds/size/zero-expected.png:
  • platform/mac/fast/block/positioning/replaced-inside-fixed-top-bottom-expected.checksum:
  • platform/mac/fast/block/positioning/replaced-inside-fixed-top-bottom-expected.png:
  • platform/mac/fast/canvas/canvas-as-image-expected.checksum:
  • platform/mac/fast/canvas/canvas-as-image-expected.png:
  • platform/mac/fast/css/value-list-out-of-bounds-crash-expected.checksum:
  • platform/mac/fast/css/value-list-out-of-bounds-crash-expected.png:
  • platform/mac/fast/forms/input-type-change-expected.checksum:
  • platform/mac/fast/forms/input-type-change-expected.png:
  • platform/mac/fast/replaced/001-expected.checksum:
  • platform/mac/fast/replaced/001-expected.png:
  • platform/mac/fast/replaced/002-expected.checksum:
  • platform/mac/fast/replaced/002-expected.png:
  • platform/mac/fast/replaced/003-expected.checksum:
  • platform/mac/fast/replaced/003-expected.png:
  • platform/mac/fast/replaced/absolute-image-sizing-expected.checksum:
  • platform/mac/fast/replaced/absolute-image-sizing-expected.png:
  • platform/mac/fast/replaced/image-sizing-expected.checksum:
  • platform/mac/fast/replaced/image-sizing-expected.png:
  • platform/mac/tables/mozilla/bugs/bug11026-expected.checksum:
  • platform/mac/tables/mozilla/bugs/bug11026-expected.png:
  • platform/mac/tables/mozilla/bugs/bug1188-expected.checksum:
  • platform/mac/tables/mozilla/bugs/bug1188-expected.png:
  • platform/mac/tables/mozilla/bugs/bug1296-expected.checksum:
  • platform/mac/tables/mozilla/bugs/bug1296-expected.png:
  • platform/mac/tables/mozilla/bugs/bug15544-expected.checksum:
  • platform/mac/tables/mozilla/bugs/bug15544-expected.png:
  • platform/mac/tables/mozilla/bugs/bug4093-expected.checksum:
  • platform/mac/tables/mozilla/bugs/bug4093-expected.png:
  • platform/mac/tables/mozilla/bugs/bug4284-expected.checksum:
  • platform/mac/tables/mozilla/bugs/bug4284-expected.png:
  • platform/mac/tables/mozilla/bugs/bug4523-expected.checksum:
  • platform/mac/tables/mozilla/bugs/bug4523-expected.png:
  • platform/mac/tables/mozilla/bugs/bug56563-expected.checksum:
  • platform/mac/tables/mozilla/bugs/bug56563-expected.png:
  • platform/mac/tables/mozilla/bugs/bug86708-expected.checksum:
  • platform/mac/tables/mozilla/bugs/bug86708-expected.png:
  • platform/mac/tables/mozilla/bugs/bug97383-expected.checksum:
  • platform/mac/tables/mozilla/bugs/bug97383-expected.png:
  • platform/mac/tables/mozilla/core/misc-expected.checksum:
  • platform/mac/tables/mozilla/core/misc-expected.png:
  • platform/mac/tables/mozilla/marvin/td_valign_bottom-expected.checksum:
  • platform/mac/tables/mozilla/marvin/td_valign_bottom-expected.png:
  • platform/mac/tables/mozilla/marvin/td_valign_middle-expected.checksum:
  • platform/mac/tables/mozilla/marvin/td_valign_middle-expected.png:
  • platform/mac/tables/mozilla/marvin/td_valign_top-expected.checksum:
  • platform/mac/tables/mozilla/marvin/td_valign_top-expected.png:
  • platform/mac/tables/mozilla/marvin/th_valign_baseline-expected.checksum:
  • platform/mac/tables/mozilla/marvin/th_valign_baseline-expected.png:
  • platform/mac/tables/mozilla/marvin/th_valign_bottom-expected.checksum:
  • platform/mac/tables/mozilla/marvin/th_valign_bottom-expected.png:
  • platform/mac/tables/mozilla/marvin/th_valign_middle-expected.checksum:
  • platform/mac/tables/mozilla/marvin/th_valign_middle-expected.png:
  • platform/mac/tables/mozilla/marvin/th_valign_top-expected.checksum:
  • platform/mac/tables/mozilla/marvin/th_valign_top-expected.png:
  • platform/mac/tables/mozilla/marvin/tr_valign_bottom-expected.checksum:
  • platform/mac/tables/mozilla/marvin/tr_valign_bottom-expected.png:
  • platform/mac/tables/mozilla/marvin/tr_valign_middle-expected.checksum:
  • platform/mac/tables/mozilla/marvin/tr_valign_middle-expected.png:
  • platform/mac/tables/mozilla/marvin/tr_valign_top-expected.checksum:
  • platform/mac/tables/mozilla/marvin/tr_valign_top-expected.png:
  • platform/mac/tables/mozilla_expected_failures/bugs/bug6933-expected.checksum:
  • platform/mac/tables/mozilla_expected_failures/bugs/bug6933-expected.png:
3:25 PM Changeset in webkit [61354] by Dimitri Glazkov
  • 2 edits
    2 adds in trunk/LayoutTests

2010-06-17 Dimitri Glazkov <Dimitri Glazkov>

Unreviewed, expectations update.

Added pixel results for Chromium.

  • platform/chromium-win/fast/js/missing-title-end-tag-js-expected.checksum: Added.
  • platform/chromium-win/fast/js/missing-title-end-tag-js-expected.png: Added.
  • platform/chromium/test_expectations.txt:
3:19 PM Changeset in webkit [61353] by robert@webkit.org
  • 4 edits in trunk

2010-06-13 Robert Hogan <​robert@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

WebCore EventHandler needs to take account of onLoad events fired
before layout() complete

​https://bugs.webkit.org/show_bug.cgi?id=40102

WebCore 'cheats' by firing onLoad events before the frame's layout
has been performed. This can result in event listeners performing
operations that depend on the document's final layout, such as
scrolling operations.

When scrolling a frameview in eventhandler ensure the layout is complete.

  • platform/qt/Skipped: Unskip editing/input/page-up-down-scrolls.html

2010-06-13 Robert Hogan <​robert@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

WebCore EventHandler needs to take account of onLoad events
fired before layout() complete

​https://bugs.webkit.org/show_bug.cgi?id=40102

WebCore 'cheats' by firing onLoad events before the frame's layout
has been performed. This can result in event listeners performing
operations that depend on the document's final layout, such as
scrolling operations.

When scrolling a frameview in eventhandler ensure the layout is complete.

  • page/EventHandler.cpp: (WebCore::EventHandler::scrollRecursively):
3:06 PM Changeset in webkit [61352] by dumi@chromium.org
  • 6 edits
    4 adds in trunk

Add the error codes defined in the async DB spec to SQLError.idl and SQLError.h.
​https://bugs.webkit.org/show_bug.cgi?id=40748

Reviewed by Dimitri Glazkov.

WebCore:

Test: storage/sql-error-codes.html

  • storage/SQLError.h:

(WebCore::SQLError::):

  • storage/SQLError.idl:
  • storage/SQLStatement.cpp:

(WebCore::SQLStatement::execute):
(WebCore::SQLStatement::setDatabaseDeletedError):
(WebCore::SQLStatement::setVersionMismatchedError):
(WebCore::SQLStatement::setFailureDueToQuota):
(WebCore::SQLStatement::lastExecutionFailedDueToQuota):

  • storage/SQLTransaction.cpp:

(WebCore::SQLTransaction::openTransactionAndPreflight):
(WebCore::SQLTransaction::deliverTransactionCallback):
(WebCore::SQLTransaction::handleCurrentStatementError):
(WebCore::SQLTransaction::deliverStatementCallback):
(WebCore::SQLTransaction::postflightAndCommit):

LayoutTests:

  • platform/chromium/storage/sql-error-codes-expected.txt: Added.
  • storage/sql-error-codes-expected.txt: Added.
  • storage/sql-error-codes.html: Added.
  • storage/sql-error-codes.js: Added.

(finishTest):
(transactionErrorCallback):
(transactionSuccessCallback):
(testTransaction):
(testTransactionThrowsException):
(testTransactionFailureBecauseOfStatementFailure):
(testInvalidStatement):
(testIncorrectNumberOfBindParameters):
(testBindParameterOfWrongType.badString.toString):
(testBindParameterOfWrongType):
(testQuotaExceeded):
(testVersionMismatch.db.transaction):
(testVersionMismatch):
(runTest):

2:41 PM Changeset in webkit [61351] by robert@webkit.org
  • 3 edits in trunk/WebKit/qt

2010-06-17 Robert Hogan <​robert@webkit.org>

[Qt] Build fix

Unreviewed.

Remove includes in qdeclarativewebview*.* that rely on an installation
of QtWebKit.

  • declarative/qdeclarativewebview.cpp:
  • declarative/qdeclarativewebview_p.h:
2:32 PM Changeset in webkit [61350] by Dimitri Glazkov
  • 125 edits
    48 adds
    1 delete in trunk/LayoutTests

2010-06-17 Dimitri Glazkov <Dimitri Glazkov>

Unreviewed, expectations update.

Updating Chromium expectations after ​http://trac.webkit.org/changeset/61128.

2:15 PM Changeset in webkit [61349] by kinuko@chromium.org
  • 2 edits in trunk/WebCore

2010-06-17 Kinuko Yasuda <​kinuko@chromium.org>

Reviewed by Jian Li.

Fix CRLF ending conversion in StringBlobItem.
​https://bugs.webkit.org/show_bug.cgi?id=40736
Also: fix referencing uninitialized member bug and slice length bug
in hybrid blob case.

Tests will be added when we add BlobBuilder jsc bindings.

  • platform/BlobItem.cpp: (WebCore::StringBlobItem::convertToCString): (WebCore::DataRangeBlobItem::DataRangeBlobItem):
1:59 PM Changeset in webkit [61348] by robert@webkit.org
  • 4 edits in trunk

2010-06-17 Robert Hogan <​robert@webkit.org>

Unreviewed, rolling out r61346.
​http://trac.webkit.org/changeset/61346
​https://bugs.webkit.org/show_bug.cgi?id=33333

Broke inspector tests on Qt

  • platform/qt/Skipped:

2010-06-17 Robert Hogan <​robert@webkit.org>

Unreviewed, rolling out r61346.
​http://trac.webkit.org/changeset/61346
​https://bugs.webkit.org/show_bug.cgi?id=33333

Broke inspector tests on Qt

  • Api/qwebpage.cpp: (QWebPage::javaScriptConsoleMessage):
1:44 PM Changeset in webkit [61347] by Dimitri Glazkov
  • 1 edit
    2 deletes in trunk/LayoutTests

2010-06-17 Dimitri Glazkov <Dimitri Glazkov>

Unreviewed, expectations update.

Removed obsolete Win XP expectations.

  • platform/chromium-win-xp/fast/text/international/hindi-whitespace-expected.checksum: Removed.
  • platform/chromium-win-xp/fast/text/international/hindi-whitespace-expected.png: Removed.
1:39 PM Changeset in webkit [61346] by robert@webkit.org
  • 4 edits in trunk

2010-06-17 Robert Hogan <​robert@webkit.org>

Reviewed by Simon Hausmann.

[Qt] pass plugins/open-and-close-window-with-plugin.html on Qt

Capture logDestroy messages from the test plugin. DRT's WebPage
is already destroyed by the time they are emitted.

​https://bugs.webkit.org/show_bug.cgi?id=33333

Unskip:
plugins/open-and-close-window-with-plugin.html
plugins/geturlnotify-during-document-teardown.html

  • platform/qt/Skipped:

2010-06-17 Robert Hogan <​robert@webkit.org>

Reviewed by Simon Hausmann.

[Qt] pass plugins/open-and-close-window-with-plugin.html on Qt

Capture logDestroy messages from the test plugin. DRT's WebPage
is already destroyed by the time they are emitted.

​https://bugs.webkit.org/show_bug.cgi?id=33333

Unskip:
plugins/open-and-close-window-with-plugin.html
plugins/geturlnotify-during-document-teardown.html

  • Api/qwebpage.cpp: (QWebPage::javaScriptConsoleMessage):
1:28 PM Changeset in webkit [61345] by Dimitri Glazkov
  • 5 edits
    2 deletes in trunk

2010-06-17 Dimitri Glazkov <Dimitri Glazkov>

Unreviewed, rolling out r61340.
​http://trac.webkit.org/changeset/61340
​https://bugs.webkit.org/show_bug.cgi?id=36282

Broke several editing tests.

  • fast/css/duplicate-property-in-rule-expected.txt: Removed.
  • fast/css/duplicate-property-in-rule.html: Removed.

2010-06-17 Dimitri Glazkov <Dimitri Glazkov>

Unreviewed, rolling out r61340.
​http://trac.webkit.org/changeset/61340
​https://bugs.webkit.org/show_bug.cgi?id=36282

Broke several editing tests.

  • css/CSSMutableStyleDeclaration.cpp: (WebCore::CSSMutableStyleDeclaration::CSSMutableStyleDeclaration):
  • css/CSSParser.cpp: (WebCore::CSSParser::parseValue):
  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty):
1:25 PM Changeset in webkit [61344] by Dimitri Glazkov
  • 4 edits
    1 delete in trunk/LayoutTests

2010-06-17 Dimitri Glazkov <Dimitri Glazkov>

Unreviewed, expectations update.

More clean up from the HTML5 parser spin-up.

  • platform/chromium-linux/fast/dom/stripNullFromTextNodes-expected.txt: Removed.
  • platform/chromium-mac/css1/box_properties/float_elements_in_series-expected.checksum:
  • platform/chromium-mac/css1/box_properties/float_elements_in_series-expected.png:
  • platform/chromium/test_expectations.txt:
1:14 PM Changeset in webkit [61343] by jianli@chromium.org
  • 7 edits in trunk

Add optional contentType parameter to Blob.slice per latest File API spec.
​https://bugs.webkit.org/show_bug.cgi?id=40647

Reviewed by David Levin.

WebCore:

Tested by http/tests/local/resources/send-sliced-dragged-file.html.

  • html/Blob.cpp:

(WebCore::Blob::slice):

  • html/Blob.h:
  • html/Blob.idl:

LayoutTests:

Updated the test for the optional parameter.

  • http/tests/local/resources/send-sliced-dragged-file.js:
  • http/tests/local/send-sliced-dragged-file-expected.txt:
1:02 PM Changeset in webkit [61342] by jesus@webkit.org
  • 12 edits in trunk

Add viewport meta tag support to QtWebKit API layer

[Qt] QtWebKit does not support viewport meta tag
​https://bugs.webkit.org/show_bug.cgi?id=39902

Patch by Jesus Sanchez-Palencia <​jesus@webkit.org>, Kenneth Rohde Christiansen <​kenneth@webkit.org> on 2010-06-01
Reviewed by Simon Hausmann.

WebCore:

Add windowRect() to page client.

  • platform/qt/QWebPageClient.h:

WebKit/qt:

This implements didReceiveViewportArguments in our ChromeClientQt
which is hooked up with QWebPage::viewportChangeRequested().
This signal does not affect the current default behavior.
The documentation of the signal explains how to make use of this new feature.

  • Api/qwebframe_p.h:

(QWebFramePrivate::QWebFramePrivate):
Store information about whether the page has been laid out or not.

  • Api/qwebpage.cpp:

(QWebPage::viewportChangeRequested):

  • Api/qwebpage_p.h:

Added class QtViewportHintsPrivate.

  • Api/qwebpage.h:

(QWebPage::setPreferredContentsSize):
Improved documentation and now only layout if the page had already
passed layout phase.
Added class QWebPage::ViewportHints.

  • WebCoreSupport/ChromeClientQt.cpp:

(WebCore::ChromeClientQt::windowRect):
Modified to work as intended by the DOM, for both QWebView
and QGraphicsWebView.
(WebCore::ChromeClientQt::didReceiveViewportArguments):
Emits the signal QWebPage::viewportChangeRequested.

  • WebCoreSupport/ChromeClientQt.h:
  • WebCoreSupport/FrameLoaderClientQt.cpp:

(WebCore::FrameLoaderClientQt::dispatchDidCommitLoad):
(WebCore::FrameLoaderClientQt::dispatchDidFirstLayout):
Update information about whether the page has been laid out or not.
If the page has been laid out we ignore any further viewport meta data.

  • WebCoreSupport/PageClientQt.cpp:

(WebCore::PageClientQWidget::windowRect):
(WebCore::PageClientQGraphicsWidget::windowRect):
(WebCore::PageClientQGraphicsWidget::graphicsItemVisibleRect):

  • WebCoreSupport/PageClientQt.h:

The PageClient is now responsible for providing the right window rect.

12:50 PM Changeset in webkit [61341] by senorblanco@chromium.org
  • 6 edits in trunk

2010-06-17 Stephen White <​senorblanco@chromium.org>

Reviewed by David Levin.

Fix for slow multiple animated resize issue.
​https://bugs.webkit.org/show_bug.cgi?id=38233

The timer-based resize quality approach implemented in
​http://trac.webkit.org/changeset/34210 is a good idea, but doesn't
scale to multiple images with animated resizes. This fix unifies all
outstanding resize timers into a single timer, and removes the "use
last quality" check (which doesn't work when images are overlapping).
It also refactors the copy of this code implemented in
RenderBoxModelObject in ​http://trac.webkit.org/changeset/53949.

This improves Safari performance for the following IE9 platform demos on my C2D MacPro (10.5):
​http://ie.microsoft.com/testdrive/Performance/01FlyingImages/Default.html (4->60fps)
​http://ie.microsoft.com/testdrive/Performance/10FlickrExplorer/Default.html (3->16fps)
​http://ie.microsoft.com/testdrive/Performance/11BrowserFlip/Default.html (9->60fps)

  • rendering/RenderBoxModelObject.cpp: (WebCore::ImageQualityController::ImageQualityController): Unify all timers into a single timer, rename RenderBoxModelScaleObserver to ImageQualityController, and remove the resize quality "stickness", since it doesn't work with multiple outstanding resizes. (WebCore::ImageQualityController::objectDestroyed): gImages global is now m_lastPaintTimeMap member. (WebCore::ImageQualityController::highQualityRepaintTimerFired): Function made non-static; repaint all pending resizes (not just one). (WebCore::ImageQualityController::restartTimer): Added function to restart timer at 1.05x threshold. (WebCore::imageQualityController): Static function to return singleton. (WebCore::ImageQualityController::shouldPaintAtLowQuality): Use m_lastPaintTimeMap, not gImages global. Implement new timer algorithm. Remove resize "stickiness". (WebCore::RenderBoxModelObject::shouldPaintAtLowQuality): Implement shouldPaintAtLowQuality, which pulls out "this" and passes the call to the ImageQualityController. (WebCore::RenderBoxModelObject::~RenderBoxModelObject): Call ImageQualityController singleton's objectDestroyed() instead of old static function. (WebCore::RenderBoxModelObject::paintFillLayerExtended): Modify shouldPaintAtLowQuality() call to match new class name and function signature.
  • rendering/RenderBoxModelObject.h: Expose shouldPaintAtLowQuality as a member function.
  • rendering/RenderImage.cpp: (WebCore::RenderImage::~RenderImage): No need to call objectDestroyed() here anymore, since the RenderBoxModelObject destructor will do this for us. (WebCore::RenderImage::paintIntoRect): Rip out RenderImageScaleObserver, and call RenderBoxModelObject::shouldPaintAtLowQuality() instead.

2010-06-17 Stephen White <​senorblanco@chromium.org>

Reviewed by David Levin.

Temporarily modify test_expectations.txt to add tests broken by
​https://bugs.webkit.org/show_bug.cgi?id=38233

  • platform/chromium/test_expectations.txt:
12:32 PM Changeset in webkit [61340] by rwlbuis@webkit.org
  • 5 edits
    2 adds in trunk

2010-06-17 Rob Buis <​rwlbuis@gmail.com>

Reviewed by Dave Hyatt.

CSS3 "Property is declared twice in rule" test fails
​https://bugs.webkit.org/show_bug.cgi?id=36282

Filter out duplicate properties in style declaration.

Test: fast/css/duplicate-property-in-rule.html

  • css/CSSMutableStyleDeclaration.cpp: Filter out duplicate properties (WebCore::CSSMutableStyleDeclaration::CSSMutableStyleDeclaration):
  • css/CSSParser.cpp: (WebCore::CSSParser::parseValue): Discard negative padding values
  • css/CSSStyleSelector.cpp: Remove negative padding check (WebCore::CSSStyleSelector::applyProperty):
11:14 AM Changeset in webkit [61339] by kbr@google.com
  • 16 edits in trunk

2010-06-17 Kenneth Russell <​kbr@google.com>

Reviewed by Dimitri Glazkov.

Clean up error conditions for Typed Arrays
​https://bugs.webkit.org/show_bug.cgi?id=40755

  • bindings/js/JSArrayBufferCustom.cpp: (WebCore::JSArrayBufferConstructor::constructJSArrayBuffer):
    • Fixed handling of NaN/+inf/-inf lengths. Throw RangeError for too-large or negative lengths.
  • bindings/js/JSArrayBufferViewHelper.h: (WebCore::constructArrayBufferView):
    • Changed all error code paths to throw exceptions. Clarified exception types.
  • bindings/js/JSFloat32ArrayCustom.cpp: (WebCore::JSFloat32ArrayConstructor::constructJSFloat32Array):
    • Removed throwing of INDEX_SIZE_ERROR, delegating responsibility to constructArrayBufferView.
  • bindings/js/JSInt16ArrayCustom.cpp: (WebCore::JSInt16ArrayConstructor::constructJSInt16Array):
    • Removed throwing of INDEX_SIZE_ERROR, delegating responsibility to constructArrayBufferView.
  • bindings/js/JSInt32ArrayCustom.cpp: (WebCore::JSInt32ArrayConstructor::constructJSInt32Array):
    • Removed throwing of INDEX_SIZE_ERROR, delegating responsibility to constructArrayBufferView.
  • bindings/js/JSInt8ArrayCustom.cpp: (WebCore::JSInt8ArrayConstructor::constructJSInt8Array):
    • Removed throwing of INDEX_SIZE_ERROR, delegating responsibility to constructArrayBufferView.
  • bindings/js/JSUint16ArrayCustom.cpp: (WebCore::JSUint16ArrayConstructor::constructJSUint16Array):
    • Removed throwing of INDEX_SIZE_ERROR, delegating responsibility to constructArrayBufferView.
  • bindings/js/JSUint32ArrayCustom.cpp: (WebCore::JSUint32ArrayConstructor::constructJSUint32Array):
    • Removed throwing of INDEX_SIZE_ERROR, delegating responsibility to constructArrayBufferView.
  • bindings/js/JSUint8ArrayCustom.cpp: (WebCore::JSUint8ArrayConstructor::constructJSUint8Array):
    • Removed throwing of INDEX_SIZE_ERROR, delegating responsibility to constructArrayBufferView.
  • bindings/v8/custom/V8ArrayBufferCustom.cpp: (WebCore::V8ArrayBuffer::constructorCallback):
    • Fixed handling of NaN/+inf/-inf lengths. Throw RangeError for too-large or negative lengths. Clarified exception types.
  • bindings/v8/custom/V8ArrayBufferViewCustom.h: (WebCore::constructWebGLArray):
    • Clarified exception types and throwing of exceptions along all error code paths.
  • html/canvas/TypedArrayBase.h: (WebCore::TypedArrayBase::create):
    • Added necessary null checks during allocation.

2010-06-17 Kenneth Russell <​kbr@google.com>

Reviewed by Dimitri Glazkov.

Clean up error conditions for Typed Arrays
​https://bugs.webkit.org/show_bug.cgi?id=40755

  • fast/canvas/webgl/array-unit-tests-expected.txt:
    • Updated test expectations.
  • fast/canvas/webgl/array-unit-tests.html:
    • Added tests for overloaded ArrayBufferView constructors taking null, and improperly aligned offsets. Improved precision of tests causing INDEX_SIZE_ERR to be thrown.
10:46 AM Changeset in webkit [61338] by chang.shu@nokia.com
  • 6 edits
    1 add in trunk

2010-06-17 Shu Chang <​chang.shu@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Fix the link error on symbian with ENABLE_JIT=0.

  1. Add "#if ENABLE(JIT)" in the header file;
  2. Put feature enable/disable logic to a common.pri so that both JavaScriptCore.pri and WebCore.pri can share.

​https://bugs.webkit.org/show_bug.cgi?id=40780

2010-06-17 Shu Chang <​chang.shu@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Fix the link error on symbian with ENABLE_JIT=0.

  1. Add "#if ENABLE(JIT)" in the header file;
  2. Put feature enable/disable logic to a common.pri so that both JavaScriptCore.pri and WebCore.pri can share.

​https://bugs.webkit.org/show_bug.cgi?id=40780

  • common.pri: Added.

2010-06-17 Shu Chang <​chang.shu@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Fix the link error on symbian with ENABLE_JIT=0.

  1. Add "#if ENABLE(JIT)" in the header file;
  2. Put feature enable/disable logic to a common.pri so that both JavaScriptCore.pri and WebCore.pri can share.

​https://bugs.webkit.org/show_bug.cgi?id=40780

  • WebCore.pri:
10:39 AM Changeset in webkit [61337] by kbr@google.com
  • 7 edits
    1 delete in trunk

2010-06-17 Kenneth Russell <​kbr@google.com>

Reviewed by Oliver Hunt.

Differences in error reporting for overloaded methods causing fast/canvas/webgl/texImageTest.html to fail
​https://bugs.webkit.org/show_bug.cgi?id=40750

Added V8Proxy::throwTypeError() and throwSyntaxError for parity
with JSC::throwTypeError() and throwSyntaxError. Changed
CodeGeneratorV8.pm to use throwTypeError for overload resolution
failures. Revised CodeGeneratorJS.pm to use throwVMTypeError
instead of manual call to JSValue::encode. Deleted now-unnecessary
Chromium expectations for fast/canvas/webgl/texImageTest.html.

  • bindings/scripts/CodeGeneratorJS.pm:
  • bindings/scripts/CodeGeneratorV8.pm:
  • bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::throwTypeError): (WebCore::V8Proxy::throwSyntaxError):
  • bindings/v8/V8Proxy.h:

2010-06-17 Kenneth Russell <​kbr@google.com>

Reviewed by Oliver Hunt.

Differences in error reporting for overloaded methods causing fast/canvas/webgl/texImageTest.html to fail
​https://bugs.webkit.org/show_bug.cgi?id=40750

Added V8Proxy::throwTypeError() and throwSyntaxError for parity
with JSC::throwTypeError() and throwSyntaxError. Changed
CodeGeneratorV8.pm to use throwTypeError for overload resolution
failures. Revised CodeGeneratorJS.pm to use throwVMTypeError
instead of manual call to JSValue::encode. Deleted now-unnecessary
Chromium expectations for fast/canvas/webgl/texImageTest.html.

  • platform/chromium-mac/fast/canvas/webgl/texImageTest-expected.txt: Removed.
  • platform/chromium/test_expectations.txt:
10:24 AM Changeset in webkit [61336] by Martin Robinson
  • 2 edits in trunk/LayoutTests

2010-06-17 Martin Robinson <​mrobinson@igalia.com>

Unreviewed.

tables/mozilla/images/adforce_imgis_com.html was removed after r61289. Remove
it from the GTK+ skipped list.

  • platform/gtk/Skipped: Remove a defunct test.
10:23 AM Changeset in webkit [61335] by darin@chromium.org
  • 2 edits in trunk/WebCore

2010-06-17 Darin Fisher <​darin@chromium.org>

Reviewed by Brady Eidson.

If Page::goToItem is passed a HistoryItem that is the current item,
then the page should be loaded again.

​https://bugs.webkit.org/show_bug.cgi?id=40660

  • loader/HistoryController.cpp: (WebCore::HistoryController::recursiveGoToItem): Add a check to recursiveGoToItem that matches the one in FrameLoader::loadItem.
10:06 AM Changeset in webkit [61334] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-06-17 Kwang Yul Seo <​skyul@company100.net>

Reviewed by Kent Tamura.

[BREWMP] Build fix for DragDataBrew
​https://bugs.webkit.org/show_bug.cgi?id=40610

​http://trac.webkit.org/changeset/60957 was not applied to DragDataBrew.cpp.
Add FilenameConversionPolicy argument to DragData::containsURL and DragData::asURL.

  • platform/brew/DragDataBrew.cpp: (WebCore::DragData::containsURL): (WebCore::DragData::asURL):
9:53 AM Changeset in webkit [61333] by eric@webkit.org
  • 8 edits in trunk/WebCore

2010-06-17 Zhenyao Mo <​zmo@google.com>

Reviewed by David Levin.

Rename internalformat to internalFormat
​https://bugs.webkit.org/show_bug.cgi?id=40149

  • html/canvas/WebGLFramebuffer.cpp: Rename internalformat to internalFormat. (WebCore::WebGLFramebuffer::getColorBufferFormat):
  • html/canvas/WebGLRenderbuffer.cpp: Ditto. (WebCore::WebGLRenderbuffer::WebGLRenderbuffer):
  • html/canvas/WebGLRenderbuffer.h: Ditto. (WebCore::WebGLRenderbuffer::setInternalFormat): (WebCore::WebGLRenderbuffer::getInternalFormat):
  • html/canvas/WebGLRenderingContext.cpp: Ditto. (WebCore::WebGLRenderingContext::copyTexImage2D): (WebCore::WebGLRenderingContext::copyTexSubImage2D): (WebCore::WebGLRenderingContext::framebufferRenderbuffer): (WebCore::WebGLRenderingContext::getRenderbufferParameter): (WebCore::WebGLRenderingContext::renderbufferStorage): (WebCore::WebGLRenderingContext::texImage2DBase): (WebCore::WebGLRenderingContext::isTexInternalFormatColorBufferCombinationValid):
  • html/canvas/WebGLRenderingContext.h: Ditto.
  • html/canvas/WebGLTexture.cpp: Ditto. (WebCore::WebGLTexture::WebGLTexture):
  • html/canvas/WebGLTexture.h: Ditto. (WebCore::WebGLTexture::setInternalFormat): (WebCore::WebGLTexture::getInternalFormat):
9:39 AM Changeset in webkit [61332] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-06-17 Zhenyao Mo <​zmo@google.com>

Reviewed by David Levin.

Remove input parameter validation for "level" upper limit in *tex* functions
​https://bugs.webkit.org/show_bug.cgi?id=40603

  • html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::validateTexFuncParameters): Don't check for "level" upper limit.
9:26 AM Changeset in webkit [61331] by eric@webkit.org
  • 21 edits
    2 deletes in trunk

2010-06-17 Lucas De Marchi <​lucas.demarchi@profusion.mobi>

Reviewed by Eric Seidel.

Clean EFL header files in order to diminish the compilation time with
EFL from subversion. We remove the EFL includes from header files and use
forward declarations, including the headers in correspondent source
files when needed. This causes only the needed source files to be
recompiled in case a new version of EFL is installed instead of
triggering a recompilation of almost all WebCore/WebKit.
​https://bugs.webkit.org/show_bug.cgi?id=40575

No new functionalities, so no new tests.

  • CMakeListsEfl.txt:
  • platform/PlatformKeyboardEvent.h: forward declaration.
  • platform/PlatformMouseEvent.h: forward declaration and change method signature to not require enum.
  • platform/PlatformWheelEvent.h: forward declaration.
  • platform/Widget.h: forward declaration.
  • platform/efl/PlatformKeyboardEventEfl.cpp: include needed header.
  • platform/efl/PlatformMouseEventEfl.cpp: (WebCore::PlatformMouseEvent::setClickCount): change method signature as mentioned above.
  • platform/efl/PlatformWheelEventEfl.cpp: include needed header.
  • platform/efl/RenderThemeEfl.cpp: include needed header
  • platform/efl/RenderThemeEfl.h: forward declaration.
  • platform/efl/ScrollbarEfl.cpp: include needed header.
  • platform/efl/ScrollbarEfl.h: forward declaration.
  • platform/efl/WidgetEfl.cpp: include needed header.
  • platform/graphics/FloatRect.h: remove unused method.
  • platform/graphics/Icon.h: forward declaration.
  • platform/graphics/IntRect.h: remove unused method.
  • platform/graphics/efl/FloatRectEfl.cpp: Removed. This file was implementing an unused method.
  • platform/graphics/efl/IntRectEfl.cpp: Removed. This file was implementing an unused method.

2010-06-17 Lucas De Marchi <​lucas.demarchi@profusion.mobi>

Reviewed by Eric Seidel.

Clean EFL header files in order to diminish the compilation time with
EFL from subversion. We remove the EFL includes from header files and use
forward declarations, including the headers in correspondent source
files when needed. This causes only the needed source files to be
recompiled in case a new version of EFL is installed instead of
triggering a recompilation of almost all WebCore/WebKit.
​https://bugs.webkit.org/show_bug.cgi?id=40575

  • efl/WebCoreSupport/ChromeClientEfl.cpp: include needed header.
  • efl/WebCoreSupport/ChromeClientEfl.h: forward declaration.
  • efl/WebCoreSupport/EditorClientEfl.h: forward declaration.
9:25 AM Changeset in webkit [61330] by Dimitri Glazkov
  • 3 edits in trunk/LayoutTests

2010-06-17 Dimitri Glazkov <Dimitri Glazkov>

Unreviewed, test expectations update.

  • platform/chromium-mac/fast/dom/wrapper-classes-expected.txt:
  • platform/chromium-win/fast/dom/wrapper-classes-expected.txt: Updated results after r61322.
8:51 AM Changeset in webkit [61329] by Darin Adler
  • 2 edits in trunk/WebKitTools

One more try at fix for Chromium build.

  • DumpRenderTree/chromium/TestShell.cpp:

(TestShell::TestShell): Use set again instead of =.

8:45 AM Changeset in webkit [61328] by Darin Adler
  • 3 edits in trunk/WebKitTools

Fix Chromium build.

I didn't realize that neither Chromium nor Qt share the DumpRenderTree

code with all the other platforms! Wow, that should be fixed at some point.

  • DumpRenderTree/chromium/TestShell.cpp:

(TestShell::TestShell): Changed back to using "new".

  • DumpRenderTree/chromium/TestShell.h: Changed back to OwnPtr.
8:16 AM Changeset in webkit [61327] by Simon Hausmann
  • 2 edits in trunk/WebKitTools

Unreviewed Qt build fix.

LayoutTestController in the Qt DRT is not using refs :)

  • DumpRenderTree/qt/DumpRenderTreeQt.cpp:

(WebCore::DumpRenderTree::DumpRenderTree):

8:11 AM Changeset in webkit [61326] by Darin Adler
  • 3 edits in trunk/WebCore

2010-06-17 Alex Milowski <​alex@milowski.com>

Reviewed by Darin Adler.

Fixed a compile error in the paint() methods by making them use the
new visitedDependentColor() method.
​https://bugs.webkit.org/show_bug.cgi?id=40327

  • mathml/RenderMathMLRoot.cpp: (WebCore::RenderMathMLRoot::paint): (WebCore::RenderMathMLRoot::layout): Fixed a crash where every child was assumed to be a RenderMathMLBlock instance when that isn't the case. Also, layout() needed to mark the index for layout before calling layout() on the index.
  • mathml/RenderMathMLSquareRoot.cpp: (WebCore::RenderMathMLSquareRoot::paint):
8:06 AM QtWebKitTiling edited by kenneth@webkit.org
(diff)
8:03 AM Changeset in webkit [61325] by Simon Hausmann
  • 4 edits
    6 adds in trunk

[Qt] Upstream the WebKit QML integration plugin
​https://bugs.webkit.org/show_bug.cgi?id=40050

Patch by Alexis Menard <​alexis.menard@nokia.com> on 2010-06-17
Reviewed by Kenneth Rohde Christiansen.

.:

Add to the build the QML WebKit integration plugin.

  • WebKit.pro:

WebKit/qt:

Add to the Qt port the QML WebKit integration plugin.
QDeclarativeWebView is creating the item and expose
properties. The C++ API is not public, only the
properties are.

  • declarative/declarative.pro: Added.
  • declarative/plugin.cpp: Added.

(WebKitQmlPlugin::registerTypes):

  • declarative/qdeclarativewebview.cpp: Added.

(QDeclarativeWebViewPrivate::QDeclarativeWebViewPrivate):
(QDeclarativeWebViewPrivate::):
(QDeclarativeWebViewPrivate::windowObjectsAppend):
(GraphicsWebView::GraphicsWebView):
(GraphicsWebView::mousePressEvent):
(GraphicsWebView::mouseReleaseEvent):
(GraphicsWebView::mouseDoubleClickEvent):
(GraphicsWebView::timerEvent):
(GraphicsWebView::mouseMoveEvent):
(QDeclarativeWebView::QDeclarativeWebView):
(QDeclarativeWebView::~QDeclarativeWebView):
(QDeclarativeWebView::init):
(QDeclarativeWebView::componentComplete):
(QDeclarativeWebView::status):
(QDeclarativeWebView::progress):
(QDeclarativeWebView::doLoadStarted):
(QDeclarativeWebView::doLoadProgress):
(QDeclarativeWebView::pageUrlChanged):
(QDeclarativeWebView::doLoadFinished):
(QDeclarativeWebView::url):
(QDeclarativeWebView::setUrl):
(QDeclarativeWebView::preferredWidth):
(QDeclarativeWebView::setPreferredWidth):
(QDeclarativeWebView::preferredHeight):
(QDeclarativeWebView::setPreferredHeight):
(QDeclarativeWebView::evaluateJavaScript):
(QDeclarativeWebView::updateDeclarativeWebViewSize):
(QDeclarativeWebView::initialLayout):
(QDeclarativeWebView::updateContentsSize):
(QDeclarativeWebView::geometryChanged):
(QDeclarativeWebView::javaScriptWindowObjects):
(QDeclarativeWebView::qmlAttachedProperties):
(QDeclarativeWebViewPrivate::updateWindowObjects):
(QDeclarativeWebView::renderingEnabled):
(QDeclarativeWebView::setRenderingEnabled):
(QDeclarativeWebView::heuristicZoom):
(QDeclarativeWebView::pressGrabTime):
(QDeclarativeWebView::setPressGrabTime):
(QDeclarativeWebView::backAction):
(QDeclarativeWebView::forwardAction):
(QDeclarativeWebView::reloadAction):
(QDeclarativeWebView::stopAction):
(QDeclarativeWebView::title):
(QDeclarativeWebView::icon):
(QDeclarativeWebView::setStatusText):
(QDeclarativeWebView::windowObjectCleared):
(QDeclarativeWebView::statusText):
(QDeclarativeWebView::page):
(QDeclarativeWebView::settingsObject):
(QDeclarativeWebView::setPage):
(QDeclarativeWebView::load):
(QDeclarativeWebView::html):
(QDeclarativeWebView::setHtml):
(QDeclarativeWebView::setContent):
(QDeclarativeWebView::history):
(QDeclarativeWebView::settings):
(QDeclarativeWebView::createWindow):
(QDeclarativeWebView::newWindowComponent):
(QDeclarativeWebView::setNewWindowComponent):
(QDeclarativeWebView::newWindowParent):
(QDeclarativeWebView::setNewWindowParent):
(QDeclarativeWebView::contentsSize):
(QDeclarativeWebView::contentsScale):
(QDeclarativeWebView::setContentsScale):
(QDeclarativeWebView::elementAreaAt):
(QDeclarativeWebPage::QDeclarativeWebPage):
(QDeclarativeWebPage::~QDeclarativeWebPage):
(QDeclarativeWebPage::chooseFile):
(QDeclarativeWebPage::javaScriptAlert):
(QDeclarativeWebPage::javaScriptConfirm):
(QDeclarativeWebPage::javaScriptPrompt):
(QDeclarativeWebPage::viewItem):
(QDeclarativeWebPage::createWindow):

  • declarative/qdeclarativewebview_p.h: Added.

(QDeclarativeWebView::):
(QDeclarativeWebView::isComponentCompletePublic):
(QDeclarativeWebViewAttached::QDeclarativeWebViewAttached):
(QDeclarativeWebViewAttached::windowObjectName):
(QDeclarativeWebViewAttached::setWindowObjectName):
(QDeclarativeWebSettings::QDeclarativeWebSettings):
(QDeclarativeWebSettings::standardFontFamily):
(QDeclarativeWebSettings::setStandardFontFamily):
(QDeclarativeWebSettings::fixedFontFamily):
(QDeclarativeWebSettings::setFixedFontFamily):
(QDeclarativeWebSettings::serifFontFamily):
(QDeclarativeWebSettings::setSerifFontFamily):
(QDeclarativeWebSettings::sansSerifFontFamily):
(QDeclarativeWebSettings::setSansSerifFontFamily):
(QDeclarativeWebSettings::cursiveFontFamily):
(QDeclarativeWebSettings::setCursiveFontFamily):
(QDeclarativeWebSettings::fantasyFontFamily):
(QDeclarativeWebSettings::setFantasyFontFamily):
(QDeclarativeWebSettings::minimumFontSize):
(QDeclarativeWebSettings::setMinimumFontSize):
(QDeclarativeWebSettings::minimumLogicalFontSize):
(QDeclarativeWebSettings::setMinimumLogicalFontSize):
(QDeclarativeWebSettings::defaultFontSize):
(QDeclarativeWebSettings::setDefaultFontSize):
(QDeclarativeWebSettings::defaultFixedFontSize):
(QDeclarativeWebSettings::setDefaultFixedFontSize):
(QDeclarativeWebSettings::autoLoadImages):
(QDeclarativeWebSettings::setAutoLoadImages):
(QDeclarativeWebSettings::javascriptEnabled):
(QDeclarativeWebSettings::setJavascriptEnabled):
(QDeclarativeWebSettings::javaEnabled):
(QDeclarativeWebSettings::setJavaEnabled):
(QDeclarativeWebSettings::pluginsEnabled):
(QDeclarativeWebSettings::setPluginsEnabled):
(QDeclarativeWebSettings::privateBrowsingEnabled):
(QDeclarativeWebSettings::setPrivateBrowsingEnabled):
(QDeclarativeWebSettings::javascriptCanOpenWindows):
(QDeclarativeWebSettings::setJavascriptCanOpenWindows):
(QDeclarativeWebSettings::javascriptCanAccessClipboard):
(QDeclarativeWebSettings::setJavascriptCanAccessClipboard):
(QDeclarativeWebSettings::developerExtrasEnabled):
(QDeclarativeWebSettings::setDeveloperExtrasEnabled):
(QDeclarativeWebSettings::linksIncludedInFocusChain):
(QDeclarativeWebSettings::setLinksIncludedInFocusChain):
(QDeclarativeWebSettings::zoomTextOnly):
(QDeclarativeWebSettings::setZoomTextOnly):
(QDeclarativeWebSettings::printElementBackgrounds):
(QDeclarativeWebSettings::setPrintElementBackgrounds):
(QDeclarativeWebSettings::offlineStorageDatabaseEnabled):
(QDeclarativeWebSettings::setOfflineStorageDatabaseEnabled):
(QDeclarativeWebSettings::offlineWebApplicationCacheEnabled):
(QDeclarativeWebSettings::setOfflineWebApplicationCacheEnabled):
(QDeclarativeWebSettings::localStorageDatabaseEnabled):
(QDeclarativeWebSettings::setLocalStorageDatabaseEnabled):
(QDeclarativeWebSettings::localContentCanAccessRemoteUrls):
(QDeclarativeWebSettings::setLocalContentCanAccessRemoteUrls):

  • declarative/qmldir: Added.
  • docs/qtwebkit.qdocconf:
8:03 AM QtWebKitTiling edited by kenneth@webkit.org
(diff)
8:00 AM QtWebKitTiling created by kenneth@webkit.org
7:58 AM Changeset in webkit [61324] by Darin Adler
  • 36 edits in trunk

2010-06-17 Darin Adler <Darin Adler>

Reviewed by Sam Weinig.

Use adoptRef and create functions in more code paths
​https://bugs.webkit.org/show_bug.cgi?id=40760

  • API/JSClassRef.h: Removed unneeded include of RefCounted.h.
  • API/JSWeakObjectMapRefPrivate.cpp: Ditto.
  • bytecode/CodeBlock.h: (JSC::FunctionCodeBlock::FunctionCodeBlock): Use the SharedSymbolTable::create function instead of calling new directly.
  • runtime/SymbolTable.h: Added a create function to the SharedSymbolTable class and made the constructor private.

2010-06-17 Darin Adler <Darin Adler>

Reviewed by Sam Weinig.

Use adoptRef and create functions in more code paths
​https://bugs.webkit.org/show_bug.cgi?id=40760

  • Plugins/Hosted/NetscapePluginInstanceProxy.h: Made create no longer be an inline function.
  • Plugins/Hosted/NetscapePluginInstanceProxy.mm: (WebKit::NetscapePluginInstanceProxy::NetscapePluginInstanceProxy): Moved the call to addPluginInstance out of here. (WebKit::NetscapePluginInstanceProxy::create): Move it in here. This makes sure we call adoptRef on the new proxy before any caller calls ref on it.

2010-06-17 Darin Adler <Darin Adler>

Reviewed by Sam Weinig.

Use adoptRef and create functions in more code paths
​https://bugs.webkit.org/show_bug.cgi?id=40760

This helps prepare for an assertion that fires if you ref or destroy an
object before calling adoptRef on it. That will help us catch mistakes
that can lead to storage leaks.

  • WebCore.base.exp: Updated export now that Frame::create is not an inline function.
  • css/CSSInitialValue.h: (WebCore::CSSInitialValue::createExplicit): Use create. (WebCore::CSSInitialValue::createImplicit): Ditto. (WebCore::CSSInitialValue::create): Added.
  • css/CSSPrimitiveValue.cpp: (WebCore::CSSPrimitiveValue::createUncachedIdentifier): Added. (WebCore::CSSPrimitiveValue::createUncachedColor): Added. (WebCore::CSSPrimitiveValue::createUncached): Added. (WebCore::CSSPrimitiveValue::createIdentifier): Use createUncachedIdentifier instead of using new directly. (WebCore::CSSPrimitiveValue::createColor): Use createUncachedColor instead of using new directly. (WebCore::CSSPrimitiveValue::create): Use createdUncached instead of using new directly.
  • css/CSSPrimitiveValue.h: Declare the new functions above.
  • css/CSSStyleSelector.cpp: (WebCore::loadFullDefaultStyle): Deref simpleDefaultStyleSheet instead of explicitly deleting it.
  • loader/SubresourceLoader.cpp: (WebCore::SubresourceLoader::SubresourceLoader): Move the call to addSubresourceLoader out of here. (WebCore::SubresourceLoader::create): Move it in here. This makes it so we don't ref the loader before finishing its creation and calling adoptRef.
  • page/Frame.cpp: (WebCore::Frame::Frame): Move the call to setMainFrame out of here. Also refactor the code so an assertion is easier to read. (WebCore::Frame::create): Move the call to setMainFrame in here. This makes it so we don't ref the frame before finishing its creation and calling adoptRef.
  • page/Frame.h: Made the create function non-inline.
  • platform/text/BidiContext.cpp: (WebCore::BidiContext::createUncached): Added. (WebCore::BidiContext::create): Call createUncached instead of callling new directly.
  • platform/text/BidiContext.h: Declare createUncached.
  • rendering/RenderSVGResourceFilter.cpp: (WebCore::RenderSVGResourceFilter::buildPrimitives): Use PassRefPtr and RefPtr instead of OwnPtr. And use the create function instead of new.
  • rendering/RenderSVGResourceFilter.h: Ditto.
  • rendering/SVGRenderTreeAsText.cpp: (WebCore::writeSVGResourceContainer): Ditto.
  • storage/StorageAreaImpl.cpp: (WebCore::StorageAreaImpl::StorageAreaImpl): Move the code that calls StorageAreaSync::create out of here. (WebCore::StorageAreaImpl::create): Move it in here. This makes it so we don't ref the storage area before finishing its creation and calling adoptRef.
  • svg/SVGPaint.cpp: (WebCore::SVGPaint::defaultFill): Use create instead of new. (WebCore::SVGPaint::defaultStroke): Ditto.
  • svg/graphics/filters/SVGFilterBuilder.h: Made the constructor private and added a create function since this is a reference counted object and should not be constructed directly.

2010-06-17 Darin Adler <Darin Adler>

Reviewed by Sam Weinig.

Use adoptRef and create functions in more code paths
​https://bugs.webkit.org/show_bug.cgi?id=40760

  • DumpRenderTree/DumpRenderTree.h: Change gLayoutTestController to a RefPtr.
  • DumpRenderTree/LayoutTestController.cpp: (LayoutTestController::create): Added.
  • DumpRenderTree/LayoutTestController.h: Declare the create function.
  • DumpRenderTree/chromium/TestShell.cpp: (TestShell::TestShell): Use create instead of new.
  • DumpRenderTree/chromium/TestShell.h: Use RefPtr instead of OwnPtr.
  • DumpRenderTree/gtk/DumpRenderTree.cpp: (runTest): Use RefPtr and create instead of OwnPtr and new.
  • DumpRenderTree/mac/DumpRenderTree.mm: (runTest): Use RefPtr and create instead of OwnPtr and new.
  • DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::DumpRenderTree::DumpRenderTree): Use create and releaseRef instead of new.
  • DumpRenderTree/win/DumpRenderTree.cpp: (runTest): Use RefPtr and create instead of OwnPtr and new.
  • DumpRenderTree/wx/DumpRenderTreeWx.cpp: (runTest): Use RefPtr and create instead of OwnPtr and new. (MyApp::OnInit): Removed unneeded code to delete the layout test controller. This is done during each test.
7:47 AM Changeset in webkit [61323] by abecsi@webkit.org
  • 4 edits in trunk

Update CMake build system to use new script for generating source files
with gperf (r61091).
​https://bugs.webkit.org/show_bug.cgi?id=40628

Patch by Lucas De Marchi <​lucas.demarchi@profusion.mobi> on 2010-06-17
Reviewed by Gustavo Noronha.

  • cmake/WebKitGenerators.cmake:

WebCore: Update CMake build system to use new script for generating source files
with gperf (r61091).
This updates also the build system to cope with recent changes to
source files list.
​https://bugs.webkit.org/show_bug.cgi?id=40628

Patch by Lucas De Marchi <​lucas.demarchi@profusion.mobi> on 2010-06-17
Reviewed by Gustavo Noronha.

No new tests since it's just compilation fixes.

  • CMakeLists.txt:
7:24 AM Changeset in webkit [61322] by Darin Adler
  • 9 edits
    3 adds in trunk

2010-06-17 Darin Adler <Darin Adler>

Reviewed by Sam Weinig.

Fix boolean reflected attributes to use empty string consistently for the content attribute value
​https://bugs.webkit.org/show_bug.cgi?id=40758

Test: fast/dom/boolean-attribute-reflection.html

The HTML5 specification and other browsers are all consistent:
When setting a boolean IDL attribute to true, the attribute value
gets set to the empty string. The guidelines for authors allow either
the empty string or the name of the attribute, but for implementers
of the DOM, the reflected attribute gets empty string.

  • dom/Element.cpp: (WebCore::Element::setBooleanAttribute): Use emptyAtom to set the attribute to the empty string.
  • html/HTMLFormControlElement.cpp: (WebCore::HTMLFormControlElement::setAutofocus): Use the empty string, not "autofocus". (WebCore::HTMLFormControlElement::setRequired): Use the empty string, not "required".

2010-06-17 Darin Adler <Darin Adler>

Reviewed by Sam Weinig.

Fix boolean reflected attributes to use empty string consistently for the content attribute value
​https://bugs.webkit.org/show_bug.cgi?id=40758

  • fast/dom/boolean-attribute-reflection-expected.txt: Added.
  • fast/dom/boolean-attribute-reflection.html: Added.
  • fast/dom/script-tests/boolean-attribute-reflection.js: Added.
  • fast/dom/wrapper-classes-expected.txt: Regenerated.
  • fast/dom/wrapper-classes.html: Added some classes.
  • media/video-controls-expected.txt: Regenerated.
  • media/video-controls.html: Changed to expect the new correct results. Removed unnecessary use of offsetTop to force layout. This test covers only the DOM and has nothing to do with layout.
  • svg/dom/svgpath-getPathSegAtLength.html: Let the make-script-test-wrappers script regenerate this file.
6:19 AM Changeset in webkit [61321] by pfeldman@chromium.org
  • 4 edits in trunk

2010-06-17 Pavel Feldman <​pfeldman@chromium.org>

Unreviewed: chromium tests fix. Added InspectorBackend delegates for new inspector methods.

  • inspector/front-end/InspectorBackendStub.js: (.WebInspector.InspectorBackendStub.prototype.clearConsoleMessages): (.WebInspector.InspectorBackendStub.prototype.getOuterHTML): (.WebInspector.InspectorBackendStub.prototype.setOuterHTML): (.WebInspector.InspectorBackendStub.prototype.addInspectedNode):

2010-06-17 Pavel Feldman <​pfeldman@chromium.org>

Unreviewed: chromium tests fix. Added InspectorBackend delegates for new inspector methods.

  • src/js/InspectorControllerImpl.js: (devtools.InspectorBackendImpl):
5:19 AM Changeset in webkit [61320] by mnaganov@chromium.org
  • 4 edits in trunk/WebKit/chromium

2010-06-17 Mikhail Naganov <​mnaganov@chromium.org>

Reviewed by Pavel Feldman.

[Chromium] Prepare to making WebDevToolsAgentClient::sendMessageToFrontendOnIOThread virtual

​https://bugs.webkit.org/show_bug.cgi?id=39302

  • public/WebDevToolsAgent.h:
  • public/WebDevToolsAgentClient.h: (WebKit::WebDevToolsMessageTransport::~WebDevToolsMessageTransport):
  • src/WebDevToolsAgentImpl.cpp: (WebKit::): (WebKit::WebDevToolsAgent::dispatchMessageFromFrontendOnIOThread):
3:23 AM Changeset in webkit [61319] by Simon Hausmann
  • 8 edits in trunk

[Qt] use "win32-g++*" scope to match all MinGW makespecs

Patch by Mark Brand <​mabrand@mabrand.nl> on 2010-06-17
Reviewed by Simon Hausmann.

The scope "win32-g++" comes from the name of the makespec. However, it
is frequently used to check for MinGW. This works fine as long as
win32-g++ is the only makespec for MinGW. Now we need the wildcard
to cover "win32-g++-cross" as well.

.:

  • WebKit.pri:

JavaScriptCore:

WebCore:

  • WebCore.pro:

WebKit/qt:

  • Api/DerivedSources.pro:
3:20 AM Changeset in webkit [61318] by pfeldman@chromium.org
  • 2 edits in trunk/LayoutTests

2010-06-17 Pavel Feldman <​pfeldman@chromium.org>

Unreviewed, tests fix.

  • inspector/elements-panel-search.html:
2:43 AM Changeset in webkit [61317] by pfeldman@chromium.org
  • 17 edits in trunk/WebCore

2010-06-16 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Joe Pecoraro.

Web Inspector: move get/setOuterHTML, addInspectedNode and
clearConsole to native InspectorDOMAgent. This is done to allow
inspected nodes array to store nodes from different domains,
also moves outerhtml manipulation closer to the rest of the DOM
operations. In addition to that, we are slowly getting rid of
InjectedScriptAccess in favor of IDL-defined InspectorBackend
interface for clearer remote debugging API.

​https://bugs.webkit.org/show_bug.cgi?id=40733

  • inspector/InjectedScriptHost.cpp: (WebCore::InjectedScriptHost::inspectedNode):
  • inspector/InjectedScriptHost.h:
  • inspector/InspectorBackend.cpp: (WebCore::InspectorBackend::changeTagName): (WebCore::InspectorBackend::getOuterHTML): (WebCore::InspectorBackend::setOuterHTML): (WebCore::InspectorBackend::addInspectedNode): (WebCore::InspectorBackend::clearConsoleMessages):
  • inspector/InspectorBackend.h:
  • inspector/InspectorBackend.idl:
  • inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::inspectedNode): (WebCore::InspectorDOMAgent::changeTagName): (WebCore::InspectorDOMAgent::getOuterHTML): (WebCore::InspectorDOMAgent::setOuterHTML): (WebCore::InspectorDOMAgent::addInspectedNode):
  • inspector/InspectorDOMAgent.h:
  • inspector/InspectorFrontend.cpp: (WebCore::InspectorFrontend::didGetOuterHTML): (WebCore::InspectorFrontend::didSetOuterHTML):
  • inspector/InspectorFrontend.h:
  • inspector/front-end/ConsoleView.js: (WebInspector.ConsoleView.prototype.requestClearMessages):
  • inspector/front-end/DOMAgent.js:
  • inspector/front-end/ElementsPanel.js: (WebInspector.ElementsPanel.this.treeOutline.focusedNodeChanged): (WebInspector.ElementsPanel):
  • inspector/front-end/ElementsTreeOutline.js: (WebInspector.ElementsTreeElement.prototype._tagNameEditingCommitted.changeTagNameCallback): (WebInspector.ElementsTreeElement.prototype._tagNameEditingCommitted): ():
  • inspector/front-end/InjectedScript.js: (injectedScriptConstructor):
  • inspector/front-end/InjectedScriptAccess.js:
2:29 AM Changeset in webkit [61316] by eric@webkit.org
  • 6 edits in trunk

2010-06-17 John Gregg <​johnnyg@google.com>

Reviewed by David Levin.

Move the call to the notification presenter that a Notification is being
destroyed from the destructor (not safe) to the ActiveDOMObject::contextDestroyed
method.

Also fix up an incorrect reference loss in the V8 bindings code for Notifications.
​https://bugs.webkit.org/show_bug.cgi?id=40097

No new tests; code paths are well-covered by existing tests.

  • bindings/v8/custom/V8NotificationCenterCustom.cpp: (WebCore::V8NotificationCenter::createHTMLNotificationCallback): (WebCore::V8NotificationCenter::createNotificationCallback):
  • notifications/Notification.cpp: (WebCore::Notification::~Notification): (WebCore::Notification::contextDestroyed):
  • notifications/Notification.h:

2010-06-17 John Gregg <​johnnyg@google.com>

Reviewed by David Levin.

Undo the build fix with the correct patch: Chromium NotificationPresenter
is now informed of the destruction before it actually happens, so this
use of the Notification object is correct.
​https://bugs.webkit.org/show_bug.cgi?id=40097

  • src/NotificationPresenterImpl.cpp: (WebKit::NotificationPresenterImpl::notificationObjectDestroyed):
2:00 AM Changeset in webkit [61315] by Csaba Osztrogonác
  • 4 edits in trunk

Unreviewed rollout r61311, because it made 2 tests fail on Qt bot.

[Qt] NPP_SetWindow seems to not be called when TestNetscapePlugin is moved
​https://bugs.webkit.org/show_bug.cgi?id=36702

WebCore:

  • plugins/qt/PluginViewQt.cpp:

(WebCore::PluginView::updatePluginWidget):

LayoutTests:

  • platform/qt/Skipped:
1:31 AM Changeset in webkit [61314] by tkent@chromium.org
  • 2 edits in trunk/WebKitTools

2010-06-17 Kent Tamura <​tkent@chromium.org>

Reviewed by Shinichiro Hamaji.

[DRT/Chromium] Fix a bug of Windows pixel tests
​https://bugs.webkit.org/show_bug.cgi?id=40763

  • DumpRenderTree/chromium/TestEventPrinter.cpp: (TestShellPrinter::handleImage):
1:23 AM Changeset in webkit [61313] by Nikolas Zimmermann
  • 5 edits in trunk/LayoutTests

2010-06-17 Nikolas Zimmermann <​nzimmermann@rim.com>

Not reviewed.

Land new expected baselines for fill-opacity-(hsl|rgba).png
DRT showed a mysterious error, and the baseline obviously had a problem.

  • platform/mac/svg/custom/fill-opacity-hsl-expected.checksum:
  • platform/mac/svg/custom/fill-opacity-hsl-expected.png:
  • platform/mac/svg/custom/fill-opacity-rgba-expected.checksum:
  • platform/mac/svg/custom/fill-opacity-rgba-expected.png:
12:48 AM Changeset in webkit [61312] by Simon Hausmann
  • 5 edits in trunk

WebCore: Make repaint throttling parameters runtime configurable.
​https://bugs.webkit.org/show_bug.cgi?id=38401

Patch by Viatcheslav Ostapenko <​ostapenko.viatcheslav@nokia.com> on 2010-05-28
Reviewed by Simon Hausmann, Antti Koivisto

REPAINT_THROTTLING now chooses default values for throttling parameters.
Should be removed when applications start using runtime configuration.

  • page/FrameView.cpp:

(WebCore::FrameView::reset):
(WebCore::FrameView::updateDeferredRepaintDelay):
(WebCore::FrameView::setRepaintThrottlingDeferredRepaintDelay):
(WebCore::FrameView::setRepaintThrottlingnInitialDeferredRepaintDelayDuringLoading):
(WebCore::FrameView::setRepaintThrottlingMaxDeferredRepaintDelayDuringLoading):
(WebCore::FrameView::setRepaintThrottlingDeferredRepaintDelayIncrementDuringLoading):

  • page/FrameView.h:

WebKit/qt: [Qt] Add internal Qt Api to configure repaint throttling parameters.
​https://bugs.webkit.org/show_bug.cgi?id=38401

Patch by Viatcheslav Ostapenko <​ostapenko.viatcheslav@nokia.com> on 2010-05-28
Reviewed by Simon Hausmann, Antti Koivisto

  • Api/qwebpage.cpp:

(QWebPagePrivate::dynamicPropertyChangeEvent):

12:33 AM Changeset in webkit [61311] by eric@webkit.org
  • 4 edits in trunk

2010-06-17 Robert Hogan <​robert@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] NPP_SetWindow seems to not be called when TestNetscapePlugin is moved

​https://bugs.webkit.org/show_bug.cgi?id=36702

setNPWindowIfNeeded() is called on paint() in PluginViewQt, which doesn't
work for DRT. So call it if we are in DRT mode and the window geometry
has changed.

Unskips plugins/reentrant-update-widget-positions.html

  • platform/qt/Skipped:

2010-06-17 Robert Hogan <​robert@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] NPP_SetWindow seems to not be called when TestNetscapePlugin is moved

​https://bugs.webkit.org/show_bug.cgi?id=36702

setNPWindowIfNeeded() is called on paint() in PluginViewQt, which doesn't
work for DRT. So call it if we are in DRT mode and the window geometry
has changed.

Unskips plugins/reentrant-update-widget-positions.html

  • plugins/qt/PluginViewQt.cpp: (WebCore::PluginView::updatePluginWidget):
12:15 AM Changeset in webkit [61310] by Simon Hausmann
  • 4 edits in trunk/WebCore

[Qt] Avoid unnecessary calls to save() and restore() when drawing images

Reviewed by Kenneth Christiansen.

Avoid calling the expensive save() and restore() on the GraphicsContext just
for changing the composition mode. Instead save and restore it manually
on QPainter.

Change fac227f609e544f8f55aca8447b4328d6534407a in Qt makes sure that the
call to QPainter::setCompositionMode doesn't do anything if the mode hasn't
changed.

  • platform/graphics/GraphicsContext.h:
  • platform/graphics/qt/GraphicsContextQt.cpp:

(WebCore::GraphicsContext::toQtCompositionMode):

  • platform/graphics/qt/ImageQt.cpp:

(WebCore::BitmapImage::draw):

Note: See TracTimeline for information about the timeline view.