Context Navigation

Change API for WKContext to no longer take a WKProcessModel type and instead
have explicit Create/Get functions for the different kind of contexts. Added
two shared contexts, one threaded, one process, and made the threaded on private
for now.

UIProcess/API/mac/WKView.mm:

(-[WKView initWithFrame:]):
Make WKViews that don't have an explicit context use the shared process
context by default.

UIProcess/Launcher/WebProcessLauncher.h:
UIProcess/Launcher/mac/WebProcessLauncher.mm:

(WebKit::launchWebProcess):

UIProcess/Launcher/win/WebProcessLauncher.cpp:

(WebKit::launchWebProcess):
Use a boolean argument to note whether we are using a thread or a process
instead of using the process model enum.

UIProcess/ProcessModel.h:

(WebKit::):
Convert to using explicit Shared modifier for shared contexts.

UIProcess/WebContext.cpp:

(WebKit::WebContext::sharedProcessContext):
(WebKit::WebContext::sharedThreadContext):
(WebKit::WebContext::ensureWebProcess):
(WebKit::WebContext::createWebPage):
(WebKit::WebContext::reviveIfNecessary):

UIProcess/WebContext.h:

(WebKit::WebContext::create):
(WebKit::WebContext::process):

UIProcess/WebPageNamespace.cpp:

(WebKit::WebPageNamespace::createWebPage):
(WebKit::WebPageNamespace::preferencesDidChange):
(WebKit::WebPageNamespace::getStatistics):

UIProcess/WebPageNamespace.h:

(WebKit::WebPageNamespace::process):
(WebKit::WebPageNamespace::reviveIfNecessary):
Move WebProcessProxy creation logic up into WebContext.

UIProcess/WebProcessManager.cpp:

(WebKit::WebProcessManager::getWebProcess):
(WebKit::WebProcessManager::processDidClose):

UIProcess/WebProcessManager.h:

Keep a map of WebContexts to WebProcessProxies in addition to the two
shared processes.

UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::create):
(WebKit::WebProcessProxy::WebProcessProxy):
(WebKit::WebProcessProxy::connect):
(WebKit::WebProcessProxy::didClose):

UIProcess/WebProcessProxy.h:

Store a WebContext instead of the process model.

mac/WebKit2.exp:

Add new functions.

WebKitTools:

Move to use new shared contexts API.

MiniBrowser/mac/AppDelegate.h:
MiniBrowser/mac/AppDelegate.m:

(-[BrowserAppDelegate init]):
(-[BrowserAppDelegate getCurrentPageNamespace]):
(-[BrowserAppDelegate validateMenuItem:]):
(-[BrowserAppDelegate _setProcessModel:]):
(-[BrowserAppDelegate setSharedProcessProcessModel:]):
(-[BrowserAppDelegate setSharedThreadProcessModel:]):

MiniBrowser/win/BrowserView.cpp:

(BrowserView::create):

5:38 PM Changeset in webkit [61499] by eric@webkit.org

5 edits
3 adds in trunk

2010-06-19 Tony Gentilcore <tonyg@chromium.org>

Reviewed by Adam Barth.

Persist V8's ScriptData to the memory cache.
https://bugs.webkit.org/show_bug.cgi?id=38661

When V8 ScriptData caching was originally submitted it causes crashes
in external scripts with high-byte characters. This new test crashes on
the original code, but now passes.

fast/js/parser-high-byte-character-expected.txt: Added.
fast/js/parser-high-byte-character.html: Added.
fast/js/script-tests/parser-high-byte-character.js: Added. (runTest):

2010-06-19 Tony Gentilcore <tonyg@chromium.org>

Reviewed by Adam Barth.

Persist V8's ScriptData to the memory cache.
https://bugs.webkit.org/show_bug.cgi?id=38661

This stores V8's ScriptData in the memory cache and also causes the
network platform layer to be notified of the available cacheable
metadata.

Chromium's morejs benchmark showed a ~7% improvement when this was
originally submitted (before it had to be rolled back).

Test: fast/js/parser-high-byte-character.html

bindings/v8/ScriptSourceCode.h: (WebCore::ScriptSourceCode::ScriptSourceCode): (WebCore::ScriptSourceCode::cachedScript):
bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::compileScript): (WebCore::V8Proxy::precompileScript): (WebCore::V8Proxy::evaluate):
bindings/v8/V8Proxy.h:

2:48 PM Changeset in webkit [61498] by Dimitri Glazkov

2 edits in trunk/LayoutTests

2010-06-19 Dimitri Glazkov <Dimitri Glazkov>

Unreviewed, expectations update.

platform/chromium/test_expectations.txt: Tuned expectations according to the bot result runs.

1:39 PM Changeset in webkit [61497] by abarth@webkit.org

1 edit
4 adds in trunk/LayoutTests

2010-06-19 Tony Gentilcore <tonyg@chromium.org>

Reviewed by Eric Seidel.

Add LayoutTest to ensure resources within <noscript> are not preloaded
https://bugs.webkit.org/show_bug.cgi?id=40849

fast/preloader/noscript-expected.txt: Added.
fast/preloader/noscript.html: Added.
fast/preloader/resources/noscript-image1.png: Copied from BugsSite/data/mail.
fast/preloader/resources/noscript-image2.png: Copied from BugsSite/data/mail.

10:24 AM Changeset in webkit [61496] by eric@webkit.org

1 edit
4 adds in trunk/WebCore

2010-06-19 Kwang Yul Seo <skyul@company100.net>

Reviewed by Kent Tamura.

[BREWMP] Port SocketStream
https://bugs.webkit.org/show_bug.cgi?id=39671

Port SocketStream with BREW MP's ISocket interface.

platform/network/brew/SocketStreamError.h: Added. (WebCore::SocketStreamError::SocketStreamError):
platform/network/brew/SocketStreamHandle.h: Added. (WebCore::SocketStreamHandle::create):
platform/network/brew/SocketStreamHandleBrew.cpp: Added. (WebCore::socketStreamConnectCallback): (WebCore::getHostByNameCallback): (WebCore::socketReadableCallback): (WebCore::networkManager): (WebCore::SocketStreamHandlePrivate::SocketStreamHandlePrivate): (WebCore::SocketStreamHandlePrivate::~SocketStreamHandlePrivate): (WebCore::SocketStreamHandlePrivate::socketConnected): (WebCore::SocketStreamHandlePrivate::socketReadyRead): (WebCore::SocketStreamHandlePrivate::connect): (WebCore::SocketStreamHandlePrivate::send): (WebCore::SocketStreamHandlePrivate::close): (WebCore::SocketStreamHandlePrivate::socketClosed): (WebCore::SocketStreamHandlePrivate::socketError): (WebCore::SocketStreamHandle::SocketStreamHandle): (WebCore::SocketStreamHandle::~SocketStreamHandle): (WebCore::SocketStreamHandle::platformSend): (WebCore::SocketStreamHandle::platformClose): (WebCore::SocketStreamHandle::didReceiveAuthenticationChallenge): (WebCore::SocketStreamHandle::receivedCredential): (WebCore::SocketStreamHandle::receivedRequestToContinueWithoutCredential): (WebCore::SocketStreamHandle::receivedCancellation):
platform/network/brew/SocketStreamHandlePrivate.h: Added.

10:11 AM Changeset in webkit [61495] by eric@webkit.org

4 edits in trunk/WebKit/chromium

2010-06-19 Jay Civelli <jcivelli@chromium.org>

Reviewed by David Levin.

Adding a < operator to WebURLs so they can be used in std::maps.
https://bugs.webkit.org/show_bug.cgi?id=40632

public/WebCString.h: (WebKit::operator<):
public/WebURL.h: (WebKit::operator<):
src/WebCString.cpp: (WebKit::WebCString::compare):

9:47 AM Changeset in webkit [61494] by eric@webkit.org

6 edits in trunk

2010-06-19 Nikita Vasilyev <me@elv1s.ru>

Reviewed by Pavel Feldman.

Web Inspector: subtitleElement.textContent is always empty. Use subtitleAsText method instead.
https://bugs.webkit.org/show_bug.cgi?id=40420

inspector/elements-tests.js: (frontend_getSelectedElementStyles):

2010-06-19 Nikita Vasilyev <me@elv1s.ru>

Reviewed by Pavel Feldman.

Web Inspector: Prevent from copying "filename.css" in Styles pane
https://bugs.webkit.org/show_bug.cgi?id=40420

inspector/front-end/Section.js: (WebInspector.Section.prototype.set subtitle): (WebInspector.Section.prototype.get subtitleAsText):
inspector/front-end/StylesSidebarPane.js: (WebInspector.StylePropertiesSection):
inspector/front-end/inspector.css: (.styles-section .subtitle::before, .styles-section .subtitle a::before):

9:35 AM Changeset in webkit [61493] by eric@webkit.org

2 edits in trunk/WebCore

2010-06-19 Alex Milowski <alex@milowski.com>

Reviewed by Darin Adler.

A fix for a change in https://bugs.webkit.org/show_bug.cgi?id=39941
that caused a compile error in MathML.
https://bugs.webkit.org/show_bug.cgi?id=40827

mathml/MathMLElement.cpp: (WebCore::MathMLElement::MathMLElement):

9:21 AM Changeset in webkit [61492] by eric@webkit.org

6 edits
3 copies
3 adds in trunk/WebCore

2010-06-19 Kartikaya Gupta <kagupta@rim.com>

Reviewed by Nikolas Zimmermann.

CPP bindings missing some APIs
https://bugs.webkit.org/show_bug.cgi?id=40570

Add missing C++ DOM API bindings. Specifically:

NodeFilter callback support
Missing custom method implementations in HTMLCollection and HTMLOptionsCollection
Missing EventTarget static type-determination methods
Fix CPP binding generator to not generate d-ptrs for classes that extend EventTarget and just use the parent's d-ptr instead
Switch binding generator to use DOMWindow instead of AbstractView so that necessary W3C-defined methods (e.g. getComputedStyle) are accessible.

bindings/cpp/WebDOMDOMWindowCustom.cpp: Added. (WebDOMDOMWindow::addEventListener): (WebDOMDOMWindow::removeEventListener):
bindings/cpp/WebDOMEventTarget.cpp: (toWebKit):
bindings/cpp/WebDOMEventTarget.h:
bindings/cpp/WebDOMHTMLCollectionCustom.cpp: Added. (WebDOMHTMLCollection::item): (WebDOMHTMLCollection::namedItem):
bindings/cpp/WebDOMHTMLOptionsCollectionCustom.cpp: Added. (WebDOMHTMLOptionsCollection::length): (WebDOMHTMLOptionsCollection::setLength):
bindings/cpp/WebDOMNodeFilterCustom.cpp: Added. (WebDOMNodeFilter::acceptNode): (toWebKit):
bindings/cpp/WebNativeNodeFilterCondition.cpp: Added. (WebNativeNodeFilterCondition::WebNativeNodeFilterCondition): (WebNativeNodeFilterCondition::~WebNativeNodeFilterCondition): (WebNativeNodeFilterCondition::acceptNode):
bindings/cpp/WebNativeNodeFilterCondition.h: Added. (WebNativeNodeFilterCondition::create):
bindings/scripts/CodeGeneratorCPP.pm:
dom/NodeFilter.idl:
page/DOMWindow.idl:

8:22 AM Changeset in webkit [61491] by Dimitri Glazkov

2 edits in trunk/LayoutTests

2010-06-19 Dimitri Glazkov <Dimitri Glazkov>

Unreviewed, expectations update

platform/chromium/test_expectations.txt: Added a flaky crash.

8:13 AM Changeset in webkit [61490] by tkent@chromium.org

2 edits in trunk/WebKit/chromium

2010-06-19 Kent Tamura <tkent@chromium.org>

Unreviewed. Build fix for r61488.

features.gypi: Define use_accelerated_compositing.

8:05 AM Changeset in webkit [61489] by eric@webkit.org

2 edits in trunk/JavaScriptCore

2010-06-19 Kwang Yul Seo <skyul@company100.net>

Reviewed by Darin Adler.

Include <string.h> in StringExtras.h
https://bugs.webkit.org/show_bug.cgi?id=40808

Without string.h, RVCT 2.2 can't compile StringExtras.h.
It can't find strlen and strncmp.

wtf/StringExtras.h:

7:53 AM Changeset in webkit [61488] by eric@webkit.org

2 edits in trunk/WebCore

2010-06-19 Vangelis Kokkevis <vangelis@chromium.org>

Reviewed by Dimitri Glazkov.

[chromium] Adding a conditional gyp dependency for the WebCore target to
the gles2_c_lib which is required by the gpu compositor. The dependency will
only kick in if the accelerated_compositing path is enabled.
https://bugs.webkit.org/show_bug.cgi?id=40801

WebCore.gyp/WebCore.gyp:

7:19 AM Changeset in webkit [61487] by eric@webkit.org

10 edits in trunk

2010-06-19 Yael Aharon <yael.aharon@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Platform plugin's multi-select does not take OptGroup into account
https://bugs.webkit.org/show_bug.cgi?id=40718

In multi-select elements, optgroup elements are counted in the index calculation,
but in single-select they are not. Keep the same logic even when NO_LISTBOX_RENDERING
is enabled.
Added tests to the existing manual test, as testing this requires a special build, in which
NO_LISTBOX_RENDERING is enabled.

html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::listBoxSelectItem):
manual-tests/no-listbox-rendering.html:
rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::listBoxSelectItem):

2010-06-19 Yael Aharon <yael.aharon@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Platform plugin's multi-select does not take OptGroup into account
https://bugs.webkit.org/show_bug.cgi?id=40718

Make sure that SelectData is valid throughout the lifetime of the dialog.
This is mostly important for the Orbt based plugin.
Added virtual desctructors where they were missing.

Api/qwebkitplatformplugin.h: (QWebSelectData::~QWebSelectData): (QWebSelectMethod::~QWebSelectMethod): (QWebNotificationData::~QWebNotificationData):
WebCoreSupport/QtPlatformPlugin.cpp: (WebCore::SelectInputMethodWrapper::SelectInputMethodWrapper): (WebCore::SelectInputMethodWrapper::~SelectInputMethodWrapper): (WebCore::SelectInputMethodWrapper::show):
WebCoreSupport/QtPlatformPlugin.h:
examples/platformplugin/WebPlugin.cpp:
examples/platformplugin/qwebkitplatformplugin.h: (QWebSelectData::~QWebSelectData): (QWebSelectMethod::~QWebSelectMethod): (QWebNotificationData::~QWebNotificationData):

7:07 AM Changeset in webkit [61486] by eric@webkit.org

7 edits in trunk

2010-06-19 Thomas Van Lenten <thomasvl@chromium.org>

Reviewed by David Levin.

Warnings from -Wextra in a Chromium Mac build

checks of unsigned >= 0
enumeral and non-enumeral type in conditional expression
copy ctors that don't call the super copy ctor or ctor No functionality change so no new tests.

https://bugs.webkit.org/show_bug.cgi?id=40791

platform/chromium/ChromiumDataObject.cpp: (WebCore::ChromiumDataObject::ChromiumDataObject):
platform/chromium/ThemeChromiumMac.mm: (WebCore::updateStates):
rendering/RenderThemeChromiumMac.mm: (WebCore::RenderThemeChromiumMac::updateActiveState):

2010-06-19 Thomas Van Lenten <thomasvl@chromium.org>

Reviewed by David Levin.

Warnings from -Wextra in a Chromium Mac build

checks of unsigned >= 0
enumeral and non-enumeral type in conditional expression
copy ctors that don't call the super copy ctor or ctor

https://bugs.webkit.org/show_bug.cgi?id=40791

src/AutoFillPopupMenuClient.cpp: (WebKit::AutoFillPopupMenuClient::getSuggestion): (WebKit::AutoFillPopupMenuClient::removeSuggestionAtIndex): (WebKit::AutoFillPopupMenuClient::valueChanged): (WebKit::AutoFillPopupMenuClient::selectionChanged):
src/AutocompletePopupMenuClient.cpp: (WebKit::AutocompletePopupMenuClient::getSuggestion): (WebKit::AutocompletePopupMenuClient::removeSuggestionAtIndex):

6:54 AM Changeset in webkit [61485] by eric@webkit.org

2 edits in trunk/WebCore

2010-06-19 Ben Murdoch <benm@google.com>

Reviewed by Pavel Feldman.

Fix build break with inspector disabled.
https://bugs.webkit.org/show_bug.cgi?id=40790

Replace a #include with a forward declaration.

Fixing a build break so no new tests required.

inspector/InspectorController.h: Forward declare InspectorValue

rather than #including its header which has its content guarded
out.

6:32 AM Changeset in webkit [61484] by eric@webkit.org

13 edits
5 copies in trunk

2010-06-19 Zhe Su <suzhe@chromium.org>

Reviewed by Darin Fisher.

[chromium]Refactor input method related APIs.
https://bugs.webkit.org/show_bug.cgi?id=40608

No new tests are needed, because there is no new functionality.

page/FocusController.cpp: (WebCore::FocusController::setFocusedNode):

2010-06-19 Zhe Su <suzhe@chromium.org>

Reviewed by Darin Fisher.

[chromium]Refactor input method related APIs.
https://bugs.webkit.org/show_bug.cgi?id=40608

WebKit.gyp:
public/WebCompositionCommand.h:
public/WebCompositionUnderline.h: Added. (WebKit::WebCompositionUnderline::WebCompositionUnderline):
public/WebTextInputType.h: Added. (WebKit::):
public/WebViewClient.h:
public/WebWidget.h:
public/WebWidgetClient.h: (WebKit::WebWidgetClient::resetInputMethod):
src/CompositionUnderlineBuilder.h: Added. (WebKit::CompositionUnderlineBuilder::CompositionUnderlineBuilder):
src/CompositionUnderlineVectorBuilder.cpp: Added. (WebKit::CompositionUnderlineVectorBuilder::CompositionUnderlineVectorBuilder):
src/CompositionUnderlineVectorBuilder.h: Added.
src/EditorClientImpl.cpp: (WebKit::EditorClientImpl::setInputMethodState):
src/WebPopupMenuImpl.cpp: (WebKit::WebPopupMenuImpl::setComposition): (WebKit::WebPopupMenuImpl::confirmComposition): (WebKit::WebPopupMenuImpl::textInputType): (WebKit::WebPopupMenuImpl::caretOrSelectionBounds):
src/WebPopupMenuImpl.h:
src/WebViewImpl.cpp: (WebKit::WebViewImpl::handleCompositionEvent): (WebKit::WebViewImpl::setComposition): (WebKit::WebViewImpl::confirmComposition): (WebKit::WebViewImpl::textInputType): (WebKit::WebViewImpl::caretOrSelectionBounds):
src/WebViewImpl.h:

6:05 AM Changeset in webkit [61483] by eric@webkit.org

2 edits in trunk/WebKit/chromium

2010-06-19 Victoria Kirst <vrk@google.com>

Reviewed by David Levin.

Modifying the WebMediaPlayer interface to be compatible with
a change in chrome.
This is a part 2 of 3 one-sided changes to chrome and WebKit. Chrome
has been updated, so this commit should NOT break chromium anymore,
nor should it cause any test failures.
https://bugs.webkit.org/show_bug.cgi?id=39445

public/WebMediaPlayer.h: Changed buffered() to be non-const.

5:32 AM Changeset in webkit [61482] by eric@webkit.org

2 edits in trunk/WebCore

2010-06-19 George Wright <gwright@rim.com>

Reviewed by George Staikos.

https://bugs.webkit.org/show_bug.cgi?id=40720

Make setWapInputFormat() public again as CSSStyleSelector.cpp calls this when WCSS is enabled.

html/HTMLInputElement.h: (WebCore::HTMLInputElement::data):

5:31 AM Changeset in webkit [61481] by tkent@chromium.org

2 edits in trunk/LayoutTests

2010-06-19 Kent Tamura <tkent@chromium.org>

Unreviewed, test expectation update.

platform/chromium/test_expectations.txt:
- progress-element.html is essentially flaky on Mac.
- use-clipped-hit.svg passes recently.

4:58 AM Changeset in webkit [61480] by eric@webkit.org

2 edits in trunk/WebKit/qt

2010-06-19 No'am Rosenthal <noam.rosenthal@nokia.com>

Reviewed by Simon Hausmann.

Bridge documentation: some snippets have the wrong indentation
https://bugs.webkit.org/show_bug.cgi?id=40717

Fixed code snippets

docs/webkitsnippets/qtwebkit_bridge_snippets.cpp: (wrapInFunction):

4:43 AM Changeset in webkit [61479] by tkent@chromium.org

3 edits
53 adds in trunk/LayoutTests

2010-06-19 Kent Tamura <tkent@chromium.org>

Unreviewed, test expectation update.

Add expectations for <meter> and <progress>.

platform/chromium-linux/fast/dom/HTMLMeterElement: Added.
platform/chromium-linux/fast/dom/HTMLMeterElement/meter-appearances-capacity-expected.checksum: Added.
platform/chromium-linux/fast/dom/HTMLMeterElement/meter-appearances-capacity-expected.png: Added.
platform/chromium-linux/fast/dom/HTMLMeterElement/meter-appearances-rating-relevancy-expected.checksum: Added.
platform/chromium-linux/fast/dom/HTMLMeterElement/meter-appearances-rating-relevancy-expected.png: Added.
platform/chromium-linux/fast/dom/HTMLMeterElement/meter-optimums-expected.checksum: Added.
platform/chromium-linux/fast/dom/HTMLMeterElement/meter-optimums-expected.png: Added.
platform/chromium-linux/fast/dom/HTMLMeterElement/meter-styles-changing-pseudo-expected.checksum: Added.
platform/chromium-linux/fast/dom/HTMLMeterElement/meter-styles-changing-pseudo-expected.png: Added.
platform/chromium-linux/fast/dom/HTMLMeterElement/meter-styles-expected.checksum: Added.
platform/chromium-linux/fast/dom/HTMLMeterElement/meter-styles-expected.png: Added.
platform/chromium-linux/fast/dom/HTMLProgressElement: Added.
platform/chromium-linux/fast/dom/HTMLProgressElement/progress-element-expected.checksum: Added.
platform/chromium-linux/fast/dom/HTMLProgressElement/progress-element-expected.png: Added.
platform/chromium-mac/fast/dom/HTMLMeterElement: Added.
platform/chromium-mac/fast/dom/HTMLMeterElement/meter-appearances-capacity-expected.checksum: Added.
platform/chromium-mac/fast/dom/HTMLMeterElement/meter-appearances-capacity-expected.png: Added.
platform/chromium-mac/fast/dom/HTMLMeterElement/meter-appearances-rating-relevancy-expected.checksum: Added.
platform/chromium-mac/fast/dom/HTMLMeterElement/meter-appearances-rating-relevancy-expected.png: Added.
platform/chromium-mac/fast/dom/HTMLMeterElement/meter-element-expected.checksum: Added.
platform/chromium-mac/fast/dom/HTMLMeterElement/meter-optimums-expected.checksum: Added.
platform/chromium-mac/fast/dom/HTMLMeterElement/meter-optimums-expected.png: Added.
platform/chromium-mac/fast/dom/HTMLMeterElement/meter-styles-changing-pseudo-expected.checksum: Added.
platform/chromium-mac/fast/dom/HTMLMeterElement/meter-styles-expected.checksum: Added.
platform/chromium-mac/fast/dom/HTMLProgressElement: Added.
platform/chromium-mac/fast/dom/HTMLProgressElement/progress-element-expected.checksum: Added.
platform/chromium-mac/fast/dom/HTMLProgressElement/progress-element-expected.png: Added.
platform/chromium-mac/fast/dom/HTMLProgressElement/progress-element-expected.txt: Added.
platform/chromium-win/fast/dom/HTMLMeterElement: Added.
platform/chromium-win/fast/dom/HTMLMeterElement/meter-appearances-capacity-expected.checksum: Added.
platform/chromium-win/fast/dom/HTMLMeterElement/meter-appearances-capacity-expected.png: Added.
platform/chromium-win/fast/dom/HTMLMeterElement/meter-appearances-capacity-expected.txt: Added.
platform/chromium-win/fast/dom/HTMLMeterElement/meter-appearances-rating-relevancy-expected.checksum: Added.
platform/chromium-win/fast/dom/HTMLMeterElement/meter-appearances-rating-relevancy-expected.png: Added.
platform/chromium-win/fast/dom/HTMLMeterElement/meter-appearances-rating-relevancy-expected.txt: Added.
platform/chromium-win/fast/dom/HTMLMeterElement/meter-element-expected.checksum: Added.
platform/chromium-win/fast/dom/HTMLMeterElement/meter-element-expected.png: Added.
platform/chromium-win/fast/dom/HTMLMeterElement/meter-element-expected.txt: Added.
platform/chromium-win/fast/dom/HTMLMeterElement/meter-optimums-expected.checksum: Added.
platform/chromium-win/fast/dom/HTMLMeterElement/meter-optimums-expected.png: Added.
platform/chromium-win/fast/dom/HTMLMeterElement/meter-optimums-expected.txt: Added.
platform/chromium-win/fast/dom/HTMLMeterElement/meter-styles-changing-pseudo-expected.checksum: Added.
platform/chromium-win/fast/dom/HTMLMeterElement/meter-styles-changing-pseudo-expected.png: Added.
platform/chromium-win/fast/dom/HTMLMeterElement/meter-styles-changing-pseudo-expected.txt: Added.
platform/chromium-win/fast/dom/HTMLMeterElement/meter-styles-expected.checksum: Added.
platform/chromium-win/fast/dom/HTMLMeterElement/meter-styles-expected.png: Added.
platform/chromium-win/fast/dom/HTMLMeterElement/meter-styles-expected.txt: Added.
platform/chromium-win/fast/dom/HTMLProgressElement: Added.
platform/chromium-win/fast/dom/HTMLProgressElement/progress-bar-value-pseudo-element-expected.checksum: Added.
platform/chromium-win/fast/dom/HTMLProgressElement/progress-bar-value-pseudo-element-expected.png: Added.
platform/chromium-win/fast/dom/HTMLProgressElement/progress-element-expected.checksum: Added.
platform/chromium-win/fast/dom/HTMLProgressElement/progress-element-expected.png: Added.
platform/chromium-win/fast/dom/HTMLProgressElement/progress-element-expected.txt: Added.
platform/chromium/fast/dom/prototype-inheritance-expected.txt:
platform/chromium/test_expectations.txt:

4:02 AM Changeset in webkit [61478] by robert@webkit.org

14 edits
3 adds in trunk

2010-06-02 Robert Hogan <robert@webkit.org>

Reviewed by Adam Barth.

[Qt] Support evaluateScriptInIsolatedWorld()

https://bugs.webkit.org/show_bug.cgi?id=40079

This initial implementation passes 25 of the 27 tests in
http/tests/isolatedworld as well as four others that use the
call in LayoutTests.

Further work/investigation is required to support the two
remaining tests.

platform/qt/Skipped:

2010-06-02 Robert Hogan <robert@webkit.org>

Reviewed by Adam Barth.

[Qt] Support evaluateScriptInIsolatedWorld()

https://bugs.webkit.org/show_bug.cgi?id=40079

getOwnPropertyNames() crashes if PropertyNameArray is size 0. This change allows
http/tests/world-reuse.html and didClearWindowObject.html to fail instead of crash.

WebCore.pro: Add qwebscriptworld.*
bridge/qt/qt_runtime.cpp: (JSC::Bindings::convertValueToQVariant):

2010-06-02 Robert Hogan <robert@webkit.org>

Reviewed by Adam Barth.

[Qt] Support evaluateScriptInIsolatedWorld()

https://bugs.webkit.org/show_bug.cgi?id=40079

Api/headers.pri:
Api/qwebframe.cpp: (QWebFrame::evaluateScriptInIsolatedWorld):
Api/qwebframe.h:
Api/qwebscriptworld.cpp: Added. (QWebScriptWorld::QWebScriptWorld): (QWebScriptWorld::world): (QWebScriptWorld::~QWebScriptWorld):
Api/qwebscriptworld.h: Added.
Api/qwebscriptworld_p.h: Added. (QWebScriptWorldPrivate::QWebScriptWorldPrivate): (QWebScriptWorldPrivate::~QWebScriptWorldPrivate):
WebCoreSupport/DumpRenderTreeSupportQt.cpp:
WebCoreSupport/DumpRenderTreeSupportQt.h:

2010-06-02 Robert Hogan <robert@webkit.org>

Reviewed by Adam Barth.

[Qt] Support evaluateScriptInIsolatedWorld()

https://bugs.webkit.org/show_bug.cgi?id=40079

DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::evaluateScriptInIsolatedWorld):
DumpRenderTree/qt/LayoutTestControllerQt.h:

3:18 AM Changeset in webkit [61477] by tkent@chromium.org

2 edits
5 adds in trunk/LayoutTests

2010-06-19 Kent Tamura <tkent@chromium.org>

Unreviewed, test expectation update.

Rebaseline for tetDecoration.svg.

platform/chromium-linux/svg/batik/text/textDecoration-expected.checksum: Added.
platform/chromium-linux/svg/batik/text/textDecoration-expected.png: Added.
platform/chromium-win/svg/batik/text/textDecoration-expected.checksum: Added.
platform/chromium-win/svg/batik/text/textDecoration-expected.png: Added.
platform/chromium-win/svg/batik/text/textDecoration-expected.txt: Added.
platform/chromium/test_expectations.txt:

3:04 AM Changeset in webkit [61476] by eric@webkit.org

2 edits in trunk/WebKit/qt

2010-06-19 Olivier Goffart <olivier.goffart@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Compilation in QWebPagePrivate::timerEvent with clang
https://bugs.webkit.org/show_bug.cgi?id=40714

QObject::timerEvent is protected and cannot be accessed by QWebPagePrivate
with clang

QWebPagePrivate is a friend of QWebPage and then should have access to
all protected members of parents of QWebPage, including QObject.
But the clang team do not want to conform to this aspect of the specification
because "It is either a drafting error or a horrible mistake."
See http://llvm.org/bugs/show_bug.cgi?id=6840

This change is better because QWebPage does not reimplement the timerEvent
(QWebPagePrivate::timerEvent is called from QWebPage::event)
So customers that would reimplement their own timerEvent
for their own timer now get a chance to catch them.

Api/qwebpage.cpp: (QWebPagePrivate::timerEvent):

2:45 AM Changeset in webkit [61475] by eric@webkit.org

2 edits in trunk/JavaScriptCore

2010-06-19 Thiago Macieira <thiago.macieira@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

Don't use attribute((may_alias)) with the Intel compiler,
as it doesn't understand it.

wtf/Vector.h:

2:23 AM Changeset in webkit [61474] by eric@webkit.org

2 edits in trunk/JavaScriptCore

2010-06-19 Thiago Macieira <thiago.macieira@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

Fix compilation with the Intel C++ compiler (11.1.072).

Like RVCT, label pointers must be void*, not const void*.

bytecode/Opcode.h:

2:09 AM Changeset in webkit [61473] by eric@webkit.org

2 edits in trunk/JavaScriptCore

2010-06-19 Thiago Macieira <thiago.macieira@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

Add the WTF_COMPILER_INTEL for when the Intel compiler is used
for building. Usually, the Intel compiler masquerades as
another compiler in the system and gets away with it, but some
times specific fixes are required (such as when using language
extensions).

wtf/Platform.h:

1:45 AM Changeset in webkit [61472] by eric@webkit.org

2 edits in trunk/WebKit/qt

2010-06-19 Mirko Damiani <mirko@develer.com>

Reviewed by Simon Hausmann.

[Qt] Avoid truncation of zoom factor in QWebFrame's print function.
https://bugs.webkit.org/show_bug.cgi?id=40662

The zoom factor is a qreal number but its value is truncated to an
integer. So a cast to qreal is needed to avoid this issue.

Api/qwebframe.cpp: (QWebFrame::print):

1:31 AM Changeset in webkit [61471] by eric@webkit.org

5 edits in trunk

2010-06-19 Zhenyao Mo <zmo@google.com>

Reviewed by Dimitri Glazkov.

fast/canvas/webgl/get-active-test.html failed in Chrome Mac
https://bugs.webkit.org/show_bug.cgi?id=40496

fast/canvas/webgl/get-active-test-expected.txt: Test of two contexts and two programs, also test the uniform array name ends with "[0]".
fast/canvas/webgl/script-tests/get-active-test.js: Ditto.

2010-06-19 Zhenyao Mo <zmo@google.com>

Reviewed by Dimitri Glazkov.

fast/canvas/webgl/get-active-test.html failed in Chrome Mac
https://bugs.webkit.org/show_bug.cgi?id=40496

src/WebGraphicsContext3DDefaultImpl.cpp: Call makeContextCurrent(). (WebKit::WebGraphicsContext3DDefaultImpl::getActiveAttrib): (WebKit::WebGraphicsContext3DDefaultImpl::getActiveUniform): (WebKit::WebGraphicsContext3DDefaultImpl::readPixels):

12:26 AM Changeset in webkit [61470] by eric@webkit.org

6 edits in trunk/WebCore

2010-06-19 Tony Gentilcore <tonyg@chromium.org>

Reviewed by Eric Seidel.

Some very minor cleanups for HTML5 Parser
https://bugs.webkit.org/show_bug.cgi?id=40638

No new tests because no new functionality.

html/HTML5DocumentParser.cpp: (WebCore::): Make ctor explicit.
html/HTML5DocumentParser.h: (WebCore::HTML5DocumentParser::InsertionPointRecord::InsertionPointRecord): Make ctor explicit.
html/HTML5Lexer.cpp: (WebCore::HTMLNames::isEndTagBufferingState): Use switch to generate an efficient table with single branch.
html/HTML5Token.h: (WebCore::HTML5Token::forceQuirks): Add const.
html/HTML5TreeBuilder.h: (WebCore::HTML5TreeBuilder::isPaused): Add const.

12:12 AM Changeset in webkit [61469] by eric@webkit.org

2 edits in trunk/WebKitTools

2010-06-18 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Darin Adler.

Add three more non-core Chromium builders to start testing DumpRenderTree.
https://bugs.webkit.org/show_bug.cgi?id=40335

BuildSlaveSupport/build.webkit.org-config/config.json: Added 3 builders.

12:08 AM Changeset in webkit [61468] by aa@chromium.org

2 edits in trunk

2010-06-18 Aaron Boodman <aa@chromium.org>

Remove WebKit::WebDocument::isXHTMLDocument.
https://bugs.webkit.org/show_bug.cgi?id=40815

dom/Document.h: remove isXHTML() getter.

2010-06-18 Aaron Boodman <aa@chromium.org>

Remove WebKit::WebDocument::isXHTMLDocument.
https://bugs.webkit.org/show_bug.cgi?id=40815

public/WebDocument.h: Remove isXHTMLDocument().
src/WebDocument.cpp: Ditto.

12:05 AM Changeset in webkit [61467] by aa@chromium.org

5 edits in trunk

2010-06-19 Aaron Boodman <aa@chromium.org>

Unreviewed, rolling out r61466.
http://trac.webkit.org/changeset/61466
https://bugs.webkit.org/show_bug.cgi?id=40816

Landed wrong change

bindings/v8/V8DOMWindowShell.cpp: (WebCore::V8DOMWindowShell::initContextIfNeeded):
bindings/v8/V8DOMWindowShell.h:

2010-06-19 Aaron Boodman <aa@chromium.org>

Unreviewed, rolling out r61466.
http://trac.webkit.org/changeset/61466
https://bugs.webkit.org/show_bug.cgi?id=40816

Landed wrong change

src/WebKit.cpp: (WebKit::shutdown):

Jun 18, 2010:

11:54 PM Changeset in webkit [61466] by aa@chromium.org

5 edits in trunk

2010-06-18 Aaron Boodman <aa@chromium.org>

WebKit API: Undo static hooks into V8 when WebKit is shut down.
https://bugs.webkit.org/show_bug.cgi?id=40816

bindings/v8/V8DOMWindowShell.cpp: (WebCore::V8DOMWindowShell::initContextIfNeeded): (WebCore::V8DOMWindowShell::initializeV8IfNeeded): (WebCore::V8DOMWindowShell::uninitializeV8IfNeeded):
bindings/v8/V8DOMWindowShell.h:

2010-06-18 Aaron Boodman <aa@chromium.org>

WebKit API: Undo static hooks into V8 when WebKit is shut downm
https://bugs.webkit.org/show_bug.cgi?id=40816

src/WebKit.cpp: (WebKit::shutdown): Call new WebCore::V8DOMWindowShell::uninitializeV8IfNeeded().

9:33 PM Changeset in webkit [61465] by rwlbuis@webkit.org

1 edit
1 move
3 adds in trunk/LayoutTests

2010-06-18 Rob Buis <rwlbuis@gmail.com>

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=19575
layout test svg/batik/text/textDecoration.svg hangs

Reenable this test since crash is gone (tested on OS X 10.5.8).

platform/mac/svg/batik/text/textDecoration-expected.checksum: Added.
platform/mac/svg/batik/text/textDecoration-expected.png: Added.
platform/mac/svg/batik/text/textDecoration-expected.txt: Added.
svg/batik/text/textDecoration.svg: Renamed from LayoutTests/svg/batik/text/textDecoration.svg-disabled.

8:35 PM Changeset in webkit [61464] by abarth@webkit.org

6 edits in trunk/WebKit/mac

2010-06-18 Adam Barth <abarth@webkit.org>

Unreviewed, rolling out r61459.
http://trac.webkit.org/changeset/61459
https://bugs.webkit.org/show_bug.cgi?id=40869

Seems to have broken two tests on the Tiger buildbot:

dom/html/level2/html/AppletsCollection.html
plugins/qt-qwidget-plugin.html

Anders wasn't on #webkit...

Plugins/Hosted/NetscapePluginHostManager.mm: (WebKit::NetscapePluginHostManager::spawnPluginHost):
Plugins/WebBasePluginPackage.h:
Plugins/WebBasePluginPackage.mm: (-[WebBasePluginPackage initWithPath:]): (-[WebBasePluginPackage getPluginInfoFromPLists]): (-[WebBasePluginPackage dealloc]): (-[WebBasePluginPackage name]): (-[WebBasePluginPackage path]): (-[WebBasePluginPackage filename]): (-[WebBasePluginPackage pluginDescription]): (-[WebBasePluginPackage setName:]): (-[WebBasePluginPackage setPath:]): (-[WebBasePluginPackage setPluginDescription:]): (-[WebBasePluginPackage description]): (-[WebBasePluginPackage isJavaPlugIn]):
Plugins/WebNetscapePluginPackage.mm: (-[WebNetscapePluginPackage getPluginInfoFromResources]): (-[WebNetscapePluginPackage _tryLoad]): (-[WebNetscapePluginPackage _unloadWithShutdown:]):
Plugins/WebPluginPackage.mm: (-[WebPluginPackage load]):

8:23 PM Changeset in webkit [61463] by jberlin@webkit.org

2 edits in trunk/WebCore

Bug 19509 - Database Tables in the Inspector should be sortable
https://bugs.webkit.org/show_bug.cgi?id=19509

Reviewed by Darin Adler.

inspector/front-end/StoragePanel.js:

(WebInspector.StoragePanel.prototype.dataGridForResult):
Make each column in the DataGrid sortable.
(WebInspector.StoragePanel.prototype._sortDataGrid.comparator):
Make sure to sort numeric columns by their numeric values, instead of lexicographically.
(WebInspector.StoragePanel.prototype._sortDataGrid):
Sort the entries in the DataGrid based on the selected column.

8:18 PM Changeset in webkit [61462] by Dimitri Glazkov

2 edits in trunk/WebCore

2010-06-18 Dimitri Glazkov <Dimitri Glazkov>

Unreviewed, build fix.

WebCore.gyp/WebCore.gyp: Modified inclusion rule in to actually add WebSystemInterface.mm.

6:15 PM Changeset in webkit [61461] by andersca@apple.com

2 edits in trunk/WebKit/mac

Fix Tiger build.

Plugins/WebBasePluginPackage.mm:

(-[WebBasePluginPackage isJavaPlugIn]):

6:07 PM Changeset in webkit [61460] by andersca@apple.com

4 edits in trunk/WebCore

More clang++ warning fixes.

Reviewed by Oliver Hunt.

inspector/InspectorFrontendClientLocal.cpp:

(WebCore::InspectorFrontendClientLocal::restoreAttachedWindowHeight):

platform/graphics/mac/FontPlatformData.h:
platform/graphics/mac/WebLayer.mm:

(-[CALayer _descriptionWithPrefix:]):

5:35 PM Changeset in webkit [61459] by andersca@apple.com

6 edits in trunk/WebKit/mac

2010-06-18 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Change some WebPluginDabase ivars to use WebCore::String instead of NSString.
https://bugs.webkit.org/show_bug.cgi?id=40869

Plugins/Hosted/NetscapePluginHostManager.mm: (WebKit::NetscapePluginHostManager::spawnPluginHost):
Plugins/WebBasePluginPackage.h:
Plugins/WebBasePluginPackage.mm: (-[WebBasePluginPackage initWithPath:]): (-[WebBasePluginPackage getPluginInfoFromPLists]): (-[WebBasePluginPackage dealloc]): (-[WebBasePluginPackage name]): (-[WebBasePluginPackage path]): (-[WebBasePluginPackage filename]): (-[WebBasePluginPackage pluginDescription]): (-[WebBasePluginPackage description]): (-[WebBasePluginPackage isJavaPlugIn]):
Plugins/WebNetscapePluginPackage.mm: (-[WebNetscapePluginPackage getPluginInfoFromResources]): (-[WebNetscapePluginPackage _tryLoad]): (-[WebNetscapePluginPackage _unloadWithShutdown:]):
Plugins/WebPluginPackage.mm: (-[WebPluginPackage load]):

5:15 PM Changeset in webkit [61458] by atwilson@chromium.org

6 edits in trunk

[Chromium] Plumbing for top-level frame names
https://bugs.webkit.org/show_bug.cgi?id=40430

Reviewed by Darin Fisher.

WebKit/chromium:

public/WebFrame.h:

Removed obsolete clearName() API and added better documentation for
setName().

src/WebFrameImpl.cpp:

Removed clearName() API.

src/WebFrameImpl.h:

Removed clearName() API.

WebKitTools:

DumpRenderTree/chromium/WebViewHost.cpp:

(WebViewHost::reset):
Changed obsolete call to clearName() to use setName(WebString()) instead.

5:15 PM Changeset in webkit [61457] by ap@apple.com

1 edit
2 adds in trunk/LayoutTests

Test by Chris Brichford.

https://bugs.webkit.org/show_bug.cgi?id=19759
ChildNodeList for an attribute node is not properly invalidated after appending a child

This issue has been fixed in another bug, just landing an additional test.

fast/dom/Attr/child-nodes-length-cache-expected.txt: Added.
fast/dom/Attr/child-nodes-length-cache.html: Added.

5:01 PM Changeset in webkit [61456] by andersca@apple.com

3 edits
1 move in trunk/WebKit

WebKit: Rename WebPluginPackage.m to make it an Objective-C++ file.

Reviewed by Sam Weinig.

WebKit.xcodeproj/project.pbxproj:

WebKit/mac: Rename WebPluginPackage.m to make it an Objective-C++ file.

Reviewed by Sam Weinig.

Plugins/WebPluginPackage.m: Removed.
Plugins/WebPluginPackage.mm: Copied from Plugins/WebPluginPackage.m.

4:56 PM Changeset in webkit [61455] by Dimitri Glazkov

2 edits in trunk/WebCore

2010-06-18 Dimitri Glazkov <Dimitri Glazkov>

Unreviewed, build fix.

WebCore.gyp/WebCore.gyp: Renamed WebSystemInterface.m to WebSystemInterface.mm.

4:51 PM Changeset in webkit [61454] by andersca@apple.com

5 edits in trunk/WebKit/mac

2010-06-18 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Get rid of the NSEnumerators from WebBasePluginPackage
https://bugs.webkit.org/show_bug.cgi?id=40868

Plugins/WebBasePluginPackage.h:
Plugins/WebBasePluginPackage.mm: (-[WebBasePluginPackage MIMETypes]): (-[WebBasePluginPackage supportsExtension:]): (-[WebBasePluginPackage supportsMIMEType:]):
Plugins/WebPluginDatabase.mm: (-[WebPluginDatabase pluginForMIMEType:]): (-[WebPluginDatabase pluginForExtension:]): (-[WebPluginDatabase refresh]): (-[WebPluginDatabase _removePlugin:]):
WebCoreSupport/WebPlatformStrategies.mm: (WebPlatformStrategies::getPluginInfo):

4:23 PM Changeset in webkit [61453] by andersca@apple.com

10 edits
2 moves in trunk

2010-06-18 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Make WebCoreSystemInterface.h a C++ only header
https://bugs.webkit.org/show_bug.cgi?id=40867

WebKit.xcodeproj/project.pbxproj:

2010-06-18 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Make WebCoreSystemInterface.h a C++ only header
https://bugs.webkit.org/show_bug.cgi?id=40867

WebCoreSupport/WebSystemInterface.h:
WebCoreSupport/WebSystemInterface.m: Removed.
WebCoreSupport/WebSystemInterface.mm: Copied from WebKit/mac/WebCoreSupport/WebSystemInterface.m.

2010-06-18 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Make WebCoreSystemInterface.h a C++ only header
https://bugs.webkit.org/show_bug.cgi?id=40867

platform/mac/WebCoreSystemInterface.h:

2010-06-18 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Make WebCoreSystemInterface.h a C++ only header
https://bugs.webkit.org/show_bug.cgi?id=40867

WebKit2.xcodeproj/project.pbxproj:
WebProcess/WebCoreSupport/mac/WebSystemInterface.h:
WebProcess/WebCoreSupport/mac/WebSystemInterface.m: Removed.
WebProcess/WebCoreSupport/mac/WebSystemInterface.mm: Copied from WebKit2/WebProcess/WebCoreSupport/mac/WebSystemInterface.m.
mac/WebKit2.exp:

4:17 PM Changeset in webkit [61452] by andersca@apple.com

4 edits in trunk/WebKit/mac

2010-06-18 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Clean up WebPluginDatabase.mm
https://bugs.webkit.org/show_bug.cgi?id=40866

Plugins/WebBasePluginPackage.h:
Plugins/WebBasePluginPackage.mm: (pathByResolvingSymlinksAndAliases): (-[WebBasePluginPackage initWithPath:]): Change an instance method into a static function.

Plugins/WebPluginDatabase.mm: (PluginPackageCandidates::PluginPackageCandidates): (PluginPackageCandidates::update): (PluginPackageCandidates::bestCandidate): Add a new PluginPackageCandidates class.

(-[WebPluginDatabase pluginForKey:withEnumeratorSelector:]):
Use PluginPackageCandidates here.

4:13 PM Changeset in webkit [61451] by levin@chromium.org

4 edits
2 adds in trunk

WebCore: Convert column span from an unsigned short type to an unsigned int
type. Fixes a divide-by-zero crash arising from using a zero colspan
value coming from a narrow cast of an int to an unsigned short.
https://bugs.webkit.org/show_bug.cgi?id=40812

Patch by Abhishek Arya <inferno@chromium.org> on 2010-06-18
Reviewed by Adam Barth.

Test: fast/table/zero-colspan-crash.html

rendering/RenderTable.h: Change span from unsigned short to unsigned int.
rendering/RenderTableSection.cpp: Fix a compiler warning with comparing unsigned int with signed int. Value of an unsigned int here cannot be greater than maximum positive value of a signed int.

(WebCore::RenderTableSection::addCell):

LayoutTests: Tests that we do not crash while rendering a fixed table layout.
https://bugs.webkit.org/show_bug.cgi?id=40812

Patch by Abhishek Arya <inferno@chromium.org> on 2010-06-18
Reviewed by Adam Barth.

fast/table/zero-colspan-crash-expected.txt: Added.
fast/table/zero-colspan-crash.html: Added.

4:09 PM Changeset in webkit [61450] by oliver@apple.com

4 edits in trunk

2010-06-18 Oliver Hunt <oliver@apple.com>

Reviewed by Geoffrey Garen.

Incorrect handling of multiple BOMs scattered through a file.
https://bugs.webkit.org/show_bug.cgi?id=40865

When determining the offset of open and close braces in a source
with BOMs we were finishing our count early as we failed to account
for BOMs prior to the open/close brace positions effecting those
positions.

parser/Lexer.cpp: (JSC::Lexer::sourceCode):

2010-06-18 Oliver Hunt <oliver@apple.com>

Reviewed by Geoffrey Garen.

Incorrect handling of multiple BOMs scattered through a file.
https://bugs.webkit.org/show_bug.cgi?id=40865

Put a few more BOMs into this testcase so that it hits the other cases
that were missed before.

fast/js/resources/bom-in-file-retains-correct-offset.js: (g.f): (g):

4:01 PM Changeset in webkit [61449] by andersca@apple.com

2 edits in trunk/WebKit/mac

Fix Tiger build.

WebCoreSupport/WebPlatformStrategies.mm:

3:30 PM Changeset in webkit [61448] by Dimitri Glazkov

11 edits
2 deletes in trunk/LayoutTests

2010-06-18 Dimitri Glazkov <Dimitri Glazkov>

Unreviewed, expectations update.

Update a few more chromium-win baselines after http://trac.webkit.org/changeset/61393.

3:20 PM Changeset in webkit [61447] by andersca@apple.com

3 edits
2 adds in trunk/WebKit2

2010-06-18 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Add platform strategies for WebKit2.
https://bugs.webkit.org/show_bug.cgi?id=40863

WebKit2.xcodeproj/project.pbxproj:
WebProcess/WebCoreSupport/WebPlatformStrategies.cpp: Added. (WebKit::WebPlatformStrategies::initialize): (WebKit::WebPlatformStrategies::WebPlatformStrategies): (WebKit::WebPlatformStrategies::createPluginStrategy): (WebKit::WebPlatformStrategies::refreshPlugins): (WebKit::WebPlatformStrategies::getPluginInfo):
WebProcess/WebCoreSupport/WebPlatformStrategies.h: Added.
WebProcess/WebProcess.cpp: (WebKit::WebProcess::WebProcess):

3:16 PM Changeset in webkit [61446] by Dimitri Glazkov

3 edits
1 add
1 delete in trunk/LayoutTests

2010-06-18 Dimitri Glazkov <Dimitri Glazkov>

Unreviewed, expectations update.

Update a few more chromium-mac baselines after http://trac.webkit.org/changeset/61393.

3:11 PM Changeset in webkit [61445] by Simon Hausmann

2 edits in trunk/WebCore

[Qt] Text spacing miscalculation when using wordSpacing.
https://bugs.webkit.org/show_bug.cgi?id=40483

Patch by Ananth Jasty <ext-ananth.jasty@nokia.com> on 2010-06-18
Reviewed by Simon Hausmann.

Removed wordSpacing compensation in FontQt whitespace width
calculation. The QFontMetrics::width() overload that takes
a character does not take QFont's word spacing into account.

platform/graphics/qt/FontQt.cpp:

(WebCore::Font::floatWidthForComplexText):

3:08 PM Changeset in webkit [61444] by andersca@apple.com

10 edits
1 delete in trunk

2010-06-18 Anders Carlsson <andersca@apple.com>

Reviewed by Darin Adler.

Get rid of PluginDataMac.mm and use the plug-in strategy instead
https://bugs.webkit.org/show_bug.cgi?id=40860

Plugins/WebBasePluginPackage.h:
WebCoreSupport/WebPlatformStrategies.h:
WebCoreSupport/WebPlatformStrategies.mm: (WebPlatformStrategies::createPluginStrategy): (WebPlatformStrategies::refreshPlugins): (WebPlatformStrategies::getPluginInfo):
WebCoreSupport/WebViewFactory.mm:

2010-06-18 Anders Carlsson <andersca@apple.com>

Reviewed by Darin Adler.

Get rid of PluginDataMac.mm and use the plug-in strategy instead
https://bugs.webkit.org/show_bug.cgi?id=40860

WebCore.xcodeproj/project.pbxproj:
page/mac/WebCoreViewFactory.h:
plugins/PluginData.cpp: (WebCore::PluginData::refresh): (WebCore::PluginData::initPlugins):
plugins/PluginStrategy.h:
plugins/mac/PluginDataMac.mm: Removed.

2:52 PM Changeset in webkit [61443] by weinig@apple.com

9 edits
5 adds
1 delete in trunk

2:50 PM Changeset in webkit [61442] by Dimitri Glazkov

18 edits in trunk/LayoutTests

2010-06-18 Dimitri Glazkov <Dimitri Glazkov>

Unreviewed, expectations update.

Update chromium baselines after http://trac.webkit.org/changeset/61418.

2:48 PM Changeset in webkit [61441] by andersca@apple.com

7 edits in trunk/WebCore

Fix some (not all) clang++ warnings.

Reviewed by Dan Bernstein.

dom/Position.h:

(WebCore::lastOffsetInNode):

editing/CompositeEditCommand.cpp:

(WebCore::CompositeEditCommand::deleteInsignificantText):

loader/appcache/ApplicationCache.cpp:

(WebCore::ApplicationCache::resourceForRequest):

platform/graphics/mac/ComplexTextController.cpp:

(WebCore::ComplexTextController::offsetForPosition):
(WebCore::ComplexTextController::collectComplexTextRuns):

platform/network/CredentialStorage.cpp:

(WebCore::protectionSpaceMapKeyFromURL):

rendering/style/StyleRareNonInheritedData.h:

2:44 PM Changeset in webkit [61440] by Martin Robinson

2 edits in trunk/LayoutTests

2010-06-18 Martin Robinson <mrobinson@igalia.com>

Unreviewed.

Skipped some failing tests and conglomerated a skipped test into another group.

platform/gtk/Skipped: Cleanups and three more skipped tests.

2:40 PM Changeset in webkit [61439] by Dimitri Glazkov

285 edits
58 adds
44 deletes in trunk/LayoutTests

2010-06-18 Dimitri Glazkov <Dimitri Glazkov>

Unreviewed, expectations update.

Update chromium-linux baselines after http://trac.webkit.org/changeset/61393.

2:23 PM Changeset in webkit [61438] by andersca@apple.com

8 edits
2 adds in trunk

2010-06-18 Anders Carlsson <andersca@apple.com>

Reviewed by Dan Bernstein.

Add stubbed out WebPlatformStrategies class to WebKit.
https://bugs.webkit.org/show_bug.cgi?id=40851

WebKit.xcodeproj/project.pbxproj:

2010-06-18 Anders Carlsson <andersca@apple.com>

Reviewed by Dan Bernstein.

Add stubbed out WebPlatformStrategies class to WebKit.
https://bugs.webkit.org/show_bug.cgi?id=40851

WebCoreSupport/WebPlatformStrategies.h: Added.
WebCoreSupport/WebPlatformStrategies.mm: Added. (WebPlatformStrategies::initialize): (WebPlatformStrategies::WebPlatformStrategies): (WebPlatformStrategies::createPluginStrategy):
WebView/WebView.mm: (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]):

2010-06-18 Anders Carlsson <andersca@apple.com>

Reviewed by Dan Bernstein.

Add stubbed out WebPlatformStrategies class to WebKit.
https://bugs.webkit.org/show_bug.cgi?id=40851

WebCore.base.exp:
platform/PlatformStrategies.cpp:
platform/PlatformStrategies.h: (WebCore::PlatformStrategies::~PlatformStrategies):

2:19 PM Changeset in webkit [61437] by Dimitri Glazkov

798 edits
73 adds in trunk/LayoutTests

2010-06-18 Dimitri Glazkov <Dimitri Glazkov>

Unreviewed, expectations update.

Update chromium-win baselines after http://trac.webkit.org/changeset/61393.

2:09 PM Changeset in webkit [61436] by andersca@apple.com

4 edits in trunk/WebCore

Fix build errors when building with clang++.

Reviewed by Darin Adler.

loader/archive/cf/LegacyWebArchiveMac.mm:

Move the const qualifier to the right place.

page/EditorClient.h:
platform/Pasteboard.h:

Use @class when forward declaring Objective-C classes in Objective-C.

2:05 PM Changeset in webkit [61435] by ap@apple.com

2 edits in trunk/WebCore

Reviewed by Geoff Garen.

https://bugs.webkit.org/show_bug.cgi?id=40852
<rdar://problem/8105498> Limit simultaneous DNS prefetch request number (40852)

No change in functionality, so no tests.

We still queue up to 64 names, but only make up to 8 requests at once. If there are names
remaining in queue, we retry after a short timeout (which is easier than posting
notifications from client callback).

platform/network/cf/DNSCFNet.cpp: (WebCore::DNSResolveQueue::add): (WebCore::DNSResolveQueue::fired):

2:03 PM Changeset in webkit [61434] by Martin Robinson

2 edits
27 adds in trunk/LayoutTests

2010-06-18 Martin Robinson <mrobinson@igalia.com>

Unreviewed.

Adding baselines for new tests and correcting one incorrect baseline.

platform/gtk/media/video-replaces-poster-expected.txt: Correting this incorrect baseline.
platform/gtk/svg/hixie/text/001-expected.txt: Added.
platform/gtk/svg/text/select-textLength-spacing-squeeze-1-expected.txt: Added.
platform/gtk/svg/text/select-textLength-spacing-squeeze-2-expected.txt: Added.
platform/gtk/svg/text/select-textLength-spacing-squeeze-3-expected.txt: Added.
platform/gtk/svg/text/select-textLength-spacing-squeeze-4-expected.txt: Added.
platform/gtk/svg/text/select-textLength-spacing-stretch-1-expected.txt: Added.
platform/gtk/svg/text/select-textLength-spacing-stretch-2-expected.txt: Added.
platform/gtk/svg/text/select-textLength-spacing-stretch-3-expected.txt: Added.
platform/gtk/svg/text/select-textLength-spacing-stretch-4-expected.txt: Added.
platform/gtk/svg/text/select-textLength-spacingAndGlyphs-squeeze-1-expected.txt: Added.
platform/gtk/svg/text/select-textLength-spacingAndGlyphs-squeeze-2-expected.txt: Added.
platform/gtk/svg/text/select-textLength-spacingAndGlyphs-squeeze-3-expected.txt: Added.
platform/gtk/svg/text/select-textLength-spacingAndGlyphs-squeeze-4-expected.txt: Added.
platform/gtk/svg/text/select-textLength-spacingAndGlyphs-stretch-1-expected.txt: Added.
platform/gtk/svg/text/select-textLength-spacingAndGlyphs-stretch-2-expected.txt: Added.
platform/gtk/svg/text/select-textLength-spacingAndGlyphs-stretch-3-expected.txt: Added.
platform/gtk/svg/text/select-textLength-spacingAndGlyphs-stretch-4-expected.txt: Added.
platform/gtk/svg/text/select-x-list-1-expected.txt: Added.
platform/gtk/svg/text/select-x-list-2-expected.txt: Added.
platform/gtk/svg/text/select-x-list-3-expected.txt: Added.
platform/gtk/svg/text/select-x-list-4-expected.txt: Added.
platform/gtk/svg/text/select-x-list-with-tspans-1-expected.txt: Added.
platform/gtk/svg/text/select-x-list-with-tspans-2-expected.txt: Added.
platform/gtk/svg/text/select-x-list-with-tspans-3-expected.txt: Added.
platform/gtk/svg/text/select-x-list-with-tspans-4-expected.txt: Added.

2:01 PM Changeset in webkit [61433] by robert@webkit.org

4 edits in trunk

2010-06-18 Robert Hogan <robert@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] pass plugins/open-and-close-window-with-plugin.html on Qt

Capture logDestroy messages from the test plugin. DRT's WebPage
is already destroyed by the time they are emitted.

https://bugs.webkit.org/show_bug.cgi?id=33333

Unskip:
plugins/open-and-close-window-with-plugin.html
plugins/geturlnotify-during-document-teardown.html

platform/qt/Skipped:

2010-06-18 Robert Hogan <robert@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] pass plugins/open-and-close-window-with-plugin.html on Qt

Capture logDestroy messages from the test plugin. DRT's WebPage
is already destroyed by the time they are emitted.

https://bugs.webkit.org/show_bug.cgi?id=33333

Unskip:
plugins/open-and-close-window-with-plugin.html
plugins/geturlnotify-during-document-teardown.html

Api/qwebpage.cpp: (QWebPage::javaScriptConsoleMessage):

1:44 PM Changeset in webkit [61432] by zmo@google.com

2 edits in trunk/WebCore

WebGL demos show bad flicker
https://bugs.webkit.org/show_bug.cgi?id=38560

1:41 PM Changeset in webkit [61431] by Martin Robinson

2 edits
74 adds in trunk/LayoutTests

2010-06-18 Martin Robinson <mrobinson@igalia.com>

Unreviewed.

Adding baselines for new tests. Some tests that fail have been labeled
with bug numbers. Also removed a newly defunct test from the skipped list.

platform/gtk/Skipped: Removed newly baselined tests and one defunct test.
platform/gtk/editing/selection/select-text-overflow-ellipsis-expected.txt: Added.
platform/gtk/fast/backgrounds/quirks-mode-line-box-backgrounds-expected.txt: Added.
platform/gtk/fast/css/css3-space-in-nth-and-lang-expected.txt: Added.
platform/gtk/fast/css/inline-element-line-break-expected.txt: Added.
platform/gtk/fast/css/non-standard-checkbox-size-expected.txt: Added.
platform/gtk/fast/css/pseudo-element-line-break-expected.txt: Added.
platform/gtk/fast/lists/w3-css3-list-styles-alphabetic-expected.txt: Added.
platform/gtk/fast/multicol/single-line-expected.txt: Added.
platform/gtk/fast/repaint/block-no-inflow-children-expected.txt: Added.
platform/gtk/fast/repaint/moving-shadow-on-container-expected.txt: Added.
platform/gtk/fast/repaint/moving-shadow-on-path-expected.txt: Added.
platform/gtk/fast/table/fixed-table-with-percent-inside-percent-table-expected.txt: Added.
platform/gtk/fast/table/fixed-table-with-percent-width-inside-auto-table-expected.txt: Added.
platform/gtk/fast/table/fixed-table-with-percent-width-inside-div-expected.txt: Added.
platform/gtk/fast/table/fixed-table-with-percent-width-inside-extra-large-div-expected.txt: Added.
platform/gtk/fast/table/fixed-table-with-percent-width-inside-fixed-width-table-expected.txt: Added.
platform/gtk/fast/table/fixed-table-with-small-percent-width-expected.txt: Added.
platform/gtk/media/video-replaces-poster-expected.txt: Added.
platform/gtk/svg/css/shadow-and-opacity-expected.txt: Copied from LayoutTests/platform/mac/svg/css/shadow-and-opacity-expected.txt.
platform/gtk/svg/custom/empty-mask-expected.txt: Added.
platform/gtk/svg/custom/js-repaint-rect-on-path-with-stroke-expected.txt: Copied from LayoutTests/platform/mac/svg/custom/js-repaint-rect-on-path-with-stroke-expected.txt.
platform/gtk/svg/custom/marker-opacity-expected.txt: Added.
platform/gtk/svg/custom/marker-referencePoint-expected.txt: Copied from LayoutTests/platform/mac/svg/custom/marker-referencePoint-expected.txt.
platform/gtk/svg/custom/mask-invalidation-expected.txt: Added.
platform/gtk/svg/custom/pattern-excessive-malloc-expected.txt: Added.
platform/gtk/svg/custom/pattern-size-bigger-than-target-size-expected.txt: Copied from LayoutTests/platform/mac/svg/custom/pattern-size-bigger-than-target-size-expected.txt.
platform/gtk/svg/custom/pattern-skew-transformed-expected.txt: Copied from LayoutTests/platform/mac/svg/custom/pattern-skew-transformed-expected.txt.
platform/gtk/svg/custom/relative-sized-content-expected.txt: Added.
platform/gtk/svg/custom/relative-sized-deep-shadow-tree-content-expected.txt: Added.
platform/gtk/svg/custom/relative-sized-shadow-tree-content-expected.txt: Added.
platform/gtk/svg/custom/stroke-width-large-expected.txt: Added.
platform/gtk/svg/custom/text-xy-updates-SVGList-expected.txt: Added.
platform/gtk/svg/filters/feDisplacementMap-expected.txt: Copied from LayoutTests/platform/mac/svg/filters/feDisplacementMap-expected.txt.
platform/gtk/svg/overflow/overflow-on-foreignObject-expected.txt: Copied from LayoutTests/platform/mac/svg/overflow/overflow-on-foreignObject-expected.txt.
platform/gtk/svg/overflow/overflow-on-inner-svg-element-defaults-expected.txt: Copied from LayoutTests/platform/mac/svg/overflow/overflow-on-inner-svg-element-defaults-expected.txt.
platform/gtk/svg/overflow/overflow-on-inner-svg-element-expected.txt: Copied from LayoutTests/platform/mac/svg/overflow/overflow-on-inner-svg-element-expected.txt.
platform/gtk/svg/overflow/overflow-on-outermost-svg-element-defaults-expected.txt: Added.
platform/gtk/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-1-expected.txt: Added.
platform/gtk/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-2-expected.txt: Added.
platform/gtk/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-3-expected.txt: Added.
platform/gtk/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-auto-expected.txt: Added.
platform/gtk/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-defaults-expected.txt: Added.
platform/gtk/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-hidden-expected.txt: Added.
platform/gtk/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-scroll-expected.txt: Added.
platform/gtk/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-visible-expected.txt: Added.
platform/gtk/svg/text/foreignObject-text-clipping-bug-expected.txt: Added.
platform/gtk/svg/text/selection-background-color-expected.txt: Added.
platform/gtk/svg/text/selection-doubleclick-expected.txt: Added.
platform/gtk/svg/text/selection-styles-expected.txt: Added.
platform/gtk/svg/text/selection-tripleclick-expected.txt: Added.
platform/gtk/svg/zoom/page/absolute-sized-document-no-scrollbars-expected.txt: Copied from LayoutTests/platform/mac/svg/zoom/page/absolute-sized-document-no-scrollbars-expected.txt.
platform/gtk/svg/zoom/page/absolute-sized-document-scrollbars-expected.txt: Added.
platform/gtk/svg/zoom/page/relative-sized-document-scrollbars-expected.txt: Added.
platform/gtk/svg/zoom/page/zoom-coords-viewattr-01-b-expected.txt: Added.
platform/gtk/svg/zoom/page/zoom-foreignObject-expected.txt: Added.
platform/gtk/svg/zoom/page/zoom-hixie-mixed-008-expected.txt: Added.
platform/gtk/svg/zoom/page/zoom-hixie-mixed-009-expected.txt: Added.
platform/gtk/svg/zoom/page/zoom-hixie-rendering-model-004-expected.txt: Added.
platform/gtk/svg/zoom/page/zoom-svg-float-border-padding-expected.txt: Added.
platform/gtk/svg/zoom/text/absolute-sized-document-no-scrollbars-expected.txt: Copied from LayoutTests/platform/mac/svg/zoom/text/absolute-sized-document-no-scrollbars-expected.txt.
platform/gtk/svg/zoom/text/absolute-sized-document-scrollbars-expected.txt: Copied from LayoutTests/platform/mac/svg/zoom/text/absolute-sized-document-scrollbars-expected.txt.
platform/gtk/svg/zoom/text/relative-sized-document-scrollbars-expected.txt: Copied from LayoutTests/platform/mac/svg/zoom/text/relative-sized-document-scrollbars-expected.txt.
platform/gtk/svg/zoom/text/zoom-coords-viewattr-01-b-expected.txt: Added.
platform/gtk/svg/zoom/text/zoom-foreignObject-expected.txt: Added.
platform/gtk/svg/zoom/text/zoom-hixie-mixed-008-expected.txt: Added.
platform/gtk/svg/zoom/text/zoom-hixie-rendering-model-004-expected.txt: Added.
platform/gtk/svg/zoom/text/zoom-svg-float-border-padding-expected.txt: Added.
platform/gtk/transforms/2d/hindi-rotated-expected.txt: Added.

1:14 PM Changeset in webkit [61430] by oliver@apple.com

4 edits in trunk/JavaScriptCore

2010-06-17 Oliver Hunt <oliver@apple.com>

Reviewed by Sam Weinig.

Don't throw away exception information for functions that use exceptions
https://bugs.webkit.org/show_bug.cgi?id=40786

Simple patch to stop JSC from throwing away the exception information
of a function that uses "exceptiony" features like try and throw. This
is a speed up for catching expressions but it's difficult to quantify as
the old cost of reparsing is amortised over all exceptions caught in the
effected function.

bytecode/CodeBlock.cpp: (JSC::CodeBlock::reparseForExceptionInfoIfNecessary):
bytecompiler/BytecodeGenerator.cpp: (JSC::BytecodeGenerator::generate): (JSC::BytecodeGenerator::emitCatch):
bytecompiler/BytecodeGenerator.h: (JSC::BytecodeGenerator::emitThrow):

1:08 PM Changeset in webkit [61429] by andersca@apple.com

5 edits
3 adds in trunk

2010-06-18 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Add PlatformStrategies and PluginStrategy classes.
https://bugs.webkit.org/show_bug.cgi?id=40850

wtf/Platform.h:

2010-06-18 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Add PlatformStrategies and PluginStrategy classes.
https://bugs.webkit.org/show_bug.cgi?id=40850

WebCore.xcodeproj/project.pbxproj:
platform/PlatformStrategies.cpp: Added. (WebCore::PlatformStrategies::~PlatformStrategies): (WebCore::platformStrategies): (WebCore::setPlatformStrategies):
platform/PlatformStrategies.h: Added. (WebCore::PlatformStrategies::pluginStrategy): (WebCore::PlatformStrategies::PlatformStrategies):
plugins/PluginData.cpp:
plugins/PluginStrategy.h: Added. (WebCore::PluginStrategy::~PluginStrategy):

1:01 PM Changeset in webkit [61428] by Martin Robinson

3 edits in trunk/WebCore

2010-06-18 Martin Robinson <mrobinson@igalia.com>

Unreviewed.

Fix the GTK+ build after r61413 and 61379.

bindings/scripts/CodeGeneratorGObject.pm: Produce a g_value_set that uses getterExpressionPrefix instead of the raw getter.
bindings/scripts/test/GObject/WebKitDOMTestObj.cpp: (webkit_dom_test_obj_get_property): Update expected test results.

12:45 PM Changeset in webkit [61427] by Chris Fleizach

3 edits in trunk/LayoutTests

No review. Fix Tiger and Leopards tests.

AX: presentational role needs to be inherited by required elements
https://bugs.webkit.org/show_bug.cgi?id=40132

platform/mac-leopard/Skipped:
platform/mac-tiger/Skipped:

12:16 PM Changeset in webkit [61426] by leandro@webkit.org

4 edits in trunk

2010-06-18 Leandro Pereira <leandro@profusion.mobi>

[EFL] Unreviewed build fix.

wtf/CMakeLists.txt: Add MD5.cpp.

2010-06-18 Leandro Pereira <leandro@profusion.mobi>

[EFL] Unreviewed build fix.

CMakeLists.txt: Add inspector/ScriptBreakpoint.cpp.

12:11 PM Changeset in webkit [61425] by aestes@apple.com

2 edits in trunk/WebCore

Update copyright header.

Rubber-stamped by Sam Weinig.

html/HTMLLinkElement.h:

12:03 PM Changeset in webkit [61424] by aestes@apple.com

4 edits
2 adds in trunk

WebCore: <rdar://problem/8091385> Prevent a crash in WebCore when removing a stylesheet link element in
in a listener to its beforeload event.
https://bugs.webkit.org/show_bug.cgi?id=40742

Reviewed by Dan Bernstein.

Postpone loading of link elements until after they have been inserted into the DOM and
attached. This prevents DOM mutations triggered by beforeload handlers from firing in the
midst of DOM insertion, which can lead to assertion failures and crashes.

Test: fast/dom/beforeload/remove-link-in-beforeload-listener.html

html/HTMLLinkElement.cpp:

(WebCore::HTMLLinkElement::HTMLLinkElement): Initialize m_shouldProcessAfterAttach to false.
(WebCore::HTMLLinkElement::processCallback): Add a static callback function which calls
HTMLLinkElement::process().
(WebCore::HTMLLinkElement::insertedIntoDocument): Instead of calling process() directly, set
m_shouldProcessAfterAttach to true to indicate that process() should be called after attach().
(WebCore::HTMLLinkElement::removedFromDocument): Set m_shouldProcessAfterAttach to false.
(WebCore::HTMLLinkElement::attach): If m_shouldProcessAfterAttach is true, register
HTMLLinkElement::processCallback() as a post-attach callback.

html/HTMLLinkElement.h: Add m_shouldProcessAfterAttach.

(WebCore::HTMLLinkElement::canLazyAttach): Override canLazyAttach() to return false to
indicate that a full attach should be performed. This ensures the post-attach callbacks are
fired.

LayoutTests: <rdar://problem/8091385> Test that removing a stylesheet link element in a listener to its
beforeload event does not crash WebCore.
https://bugs.webkit.org/show_bug.cgi?id=40742

Reviewed by Dan Bernstein.

fast/dom/beforeload/remove-link-in-beforeload-listener-expected.txt: Added.
fast/dom/beforeload/remove-link-in-beforeload-listener.html: Added.

11:40 AM Changeset in webkit [61423] by Csaba Osztrogonác

5 edits in trunk/LayoutTests

Unreviewed. Update Qt specific expected files after r61418.

platform/qt/editing/pasteboard/paste-text-005-expected.txt:
platform/qt/editing/pasteboard/paste-text-006-expected.txt:
platform/qt/editing/pasteboard/paste-text-007-expected.txt:
platform/qt/editing/pasteboard/paste-text-014-expected.txt:

11:20 AM WebKit Team edited by luiz@webkit.org

(diff)

11:18 AM Changeset in webkit [61422] by Chris Fleizach

2 edits in trunk/WebCore

Unreviewed. Windows build fix.

AX: presentational role needs to be inherited by required elements
https://bugs.webkit.org/show_bug.cgi?id=40132

accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::inheritsPresentationalRole):

10:58 AM Changeset in webkit [61421] by Chris Fleizach

4 edits
2 adds in trunk

AX: presentational role needs to be inherited by required elements
https://bugs.webkit.org/show_bug.cgi?id=40132

Reviewed by David Kilzer.

WebCore:

Test: platform/mac/accessibility/inherited-presentational-lists.html

accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::accessibilityIsIgnored):
(WebCore::AccessibilityRenderObject::inheritsPresentationalRole):

accessibility/AccessibilityRenderObject.h:

(WebCore::AccessibilityRenderObject::node):

LayoutTests:

platform/mac/accessibility/inherited-presentational-lists-expected.txt: Added.
platform/mac/accessibility/inherited-presentational-lists.html: Added.

10:54 AM Changeset in webkit [61420] by Darin Adler

3 edits in trunk/WebCore

Fix GTK build after reflection change.

bindings/scripts/CodeGeneratorGObject.pm: Changed code

that emits setters to convey the correct type of the attribute.
The GObject code generator takes a different approach to attributes
than the others, so it's hacked a bit to make it more like them.
We should find a way to share more code between the different generators.

bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:

Updated to expect correct results.

10:42 AM Changeset in webkit [61419] by yurys@chromium.org

2 edits in trunk/WebCore

2010-06-18 Yury Semikhatsky <yurys@chromium.org>

Unreviewed: Qt build fix.

inspector/InspectorController.cpp:

10:35 AM Changeset in webkit [61418] by justin.garcia@apple.com

21 edits in trunk

https://bugs.webkit.org/show_bug.cgi?id=39798
No selection change notification for editing operation that doesn't change the selection's DOM position

Reviewed by Ojan Vafai.

WebCore:

Some editing operations change the selection visually without affecting its position within
the DOM. This was previously known to occur for certain typing commands, but it can also
occur for some Pastes and changes to block style.

editing/Editor.cpp:

(WebCore::Editor::appliedEditing):
(WebCore::Editor::unappliedEditing):
(WebCore::Editor::reappliedEditing):
(WebCore::Editor::changeSelectionAfterCommand):

editing/Editor.h:

LayoutTests:

block-style-001.html demonstrated the bug, so no new tests have been added.

platform/mac/editing/execCommand/format-block-expected.txt:
platform/mac/editing/execCommand/outdent-selection-expected.txt:
platform/mac/editing/pasteboard/paste-text-005-expected.txt:
platform/mac/editing/pasteboard/paste-text-006-expected.txt:
platform/mac/editing/pasteboard/paste-text-007-expected.txt:
platform/mac/editing/pasteboard/paste-text-014-expected.txt:
platform/mac/editing/style/apple-style-editable-mix-expected.txt:
platform/mac/editing/style/block-style-001-expected.txt:
platform/mac/editing/style/block-style-002-expected.txt:
platform/mac/editing/style/block-style-003-expected.txt:
platform/mac/editing/style/create-block-for-style-005-expected.txt:
platform/mac/editing/style/create-block-for-style-006-expected.txt:
platform/mac/editing/style/create-block-for-style-008-expected.txt:
platform/mac/editing/style/relative-font-size-change-002-expected.txt:
platform/mac/editing/style/relative-font-size-change-003-expected.txt:
platform/mac/editing/style/relative-font-size-change-004-expected.txt:
platform/mac/editing/style/table-selection-expected.txt:

10:22 AM Changeset in webkit [61417] by atwilson@chromium.org

2 edits in trunk/WebKit/chromium

Roll chromium DEPS 50089:50171
https://bugs.webkit.org/show_bug.cgi?id=40842

Reviewed by Dumitru Daniliuc.

DEPS:

Update chromium_rev to r50171 to remove downstream reference to WebFrame::clearName().

10:12 AM Changeset in webkit [61416] by leandro@webkit.org

2 edits in trunk/WebCore

2010-06-18 Gyuyoung Kim <gyuyoung.kim@samsung.com>

Unreviewed build fix.

[EFL] Build break on Debug build.
https://bugs.webkit.org/show_bug.cgi?id=40810

CMakeLists.txt: Add CSSPreloadScanner.cpp

9:59 AM Changeset in webkit [61415] by ap@apple.com

3 edits
2 adds in trunk

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=40803
TestNetscapePlugin has an incorrect implementation of "property" property

DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: (pluginGetProperty): Don't pass a static string back, it's going to be released by NPAPI implementation.

9:51 AM Changeset in webkit [61414] by yurys@chromium.org

13 edits
1 add in trunk/WebCore

2010-06-18 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: persist breakpoints in inspector settings.
https://bugs.webkit.org/show_bug.cgi?id=14190

GNUmakefile.am:
WebCore.gypi:
WebCore.pro:
WebCore.vcproj/WebCore.vcproj:
WebCore.xcodeproj/project.pbxproj:
inspector/InspectorController.cpp: (WebCore::InspectorController::InspectorController): (WebCore::InspectorController::setSessionSettings): (WebCore::InspectorController::didCommitLoad): (WebCore::InspectorController::setBreakpoint): (WebCore::InspectorController::removeBreakpoint): (WebCore::InspectorController::didParseSource): (WebCore::InspectorController::breakpointsSettingKey): (WebCore::InspectorController::loadBreakpoints): (WebCore::InspectorController::saveBreakpoints):
inspector/InspectorController.h:
inspector/InspectorValues.cpp: (WebCore::InspectorValue::parseJSON):
inspector/InspectorValues.h:
inspector/ScriptBreakpoint.cpp: Added. (WebCore::ScriptBreakpoint::sourceBreakpointsFromInspectorObject): (WebCore::ScriptBreakpoint::inspectorObjectFromSourceBreakpoints):
inspector/ScriptBreakpoint.h:
inspector/front-end/BreakpointManager.js: (WebInspector.BreakpointManager.prototype.addBreakpoint): (WebInspector.BreakpointManager.prototype.restoredBreakpoint): (WebInspector.BreakpointManager.prototype.breakpointsForSourceID): (WebInspector.BreakpointManager.prototype.breakpointsForURL): (WebInspector.BreakpointManager.prototype._addBreakpoint):
inspector/front-end/inspector.js: (WebInspector.restoredBreakpoint):

9:47 AM Changeset in webkit [61413] by Darin Adler

78 edits in trunk/WebCore

2010-06-18 Darin Adler <Darin Adler>

Reviewed by Sam Weinig.

Implement additional DOM attribute reflection for bindings
https://bugs.webkit.org/show_bug.cgi?id=39936

Added support for [Reflect] for long, unsigned long, and boolean attributes.
Fixed code that set attributes like this: <video controls="controls"> to instead set them like this: <video controls>.
Added lots more uses of [Reflect].
Removed now-unneeded [ConvertFromString].
Made [Reflect] imply [ConvertNullToNullString] so we can get rid of most uses of the latter.
Made [Reflect] automatically lowercase the name of the reflected content attribute to minimize the need to specify a custom content attribute name.

One thing this patch does *not* do is remove the unneeded functions
in the various DOM classes that are no longer used by the bindings.
We should do that in a followup.

bindings/scripts/CodeGenerator.pm: Added new functions so code can be shared across bindings, GetterExpressionPrefix and SetterExpressionPrefix. We can do a lot more refactoring like this in the future.

bindings/scripts/CodeGeneratorCPP.pm: Removed unneeded ConvertFromString handling, changed to use the new GetterExpressionPrefix and SetterExpressionPrefix functions to better handle reflected DOM attributes.

bindings/scripts/CodeGeneratorGObject.pm: Removed unneeded ConvertFromString handling, changed to use the new GetterExpressionPrefix and SetterExpressionPrefix functions to better handle reflected DOM attributes. Fixed a few things in the output so the .cpp file will have more WebKit style. The .h file should be GTK style, but the .cpp file can be the standard WebKit style eventually.

bindings/scripts/CodeGeneratorJS.pm: Changed to use the new GetterExpressionPrefix and SetterExpressionPrefix functions and removed a now-unneeded IsSVGAnimatedType special case since the new functions take care of it. Made reflected attributes automatically convert null to the null string without a separate ConvertNullToNullString attribute.

bindings/scripts/CodeGeneratorObjC.pm: Changed to use the new GetterExpressionPrefix and SetterExpressionPrefix functions and removed a now-unneeded IsSVGAnimatedType special case since the new functions take care of it. Redid the special cases for ownerDocument and for operator to fit better with the new code paths. Removed unneeded ConvertFromString handling.

bindings/scripts/CodeGeneratorV8.pm: Changed to use the new GetterExpressionPrefix and SetterExpressionPrefix functions and removed a now-unneeded IsSVGAnimatedType special case since the new functions take care of it. Made reflected attributes automatically convert null to the null string without a separate ConvertNullToNullString attribute.

bindings/scripts/test/TestObj.idl: Added some test cases for content attribute reflection and for exceptions in string-typed attributes.

bindings/scripts/test/CPP/WebKitDOMTestObj.cpp: Updated.
bindings/scripts/test/CPP/WebKitDOMTestObj.h: Ditto.
bindings/scripts/test/GObject/WebKitDOMTestObj.cpp: Ditto.
bindings/scripts/test/GObject/WebKitDOMTestObj.h: Ditto.
bindings/scripts/test/JS/JSTestObj.cpp: Ditto.
bindings/scripts/test/JS/JSTestObj.h: Ditto.
bindings/scripts/test/ObjC/DOMTestObj.h: Ditto.
bindings/scripts/test/ObjC/DOMTestObj.mm: Ditto.
bindings/scripts/test/V8/V8TestObj.cpp: Ditto.

dom/Element.cpp: (WebCore::Element::getIntegralAttribute): Added. (WebCore::Element::setIntegralAttribute): Added. (WebCore::Element::getUnsignedIntegralAttribute): Added. (WebCore::Element::setUnsignedIntegralAttribute): Added.
dom/Element.h: Added new attribute get/set functions for bindings.

html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::isURLAttribute): Added. Returns true for srcAttr.
html/HTMLMediaElement.h: Added isURLAttribute.

html/HTMLVideoElement.cpp: (WebCore::HTMLVideoElement::isURLAttribute): Changed to call HTMLMediaElement::isURLAttribute before checking for posterAttr.

html/HTMLAnchorElement.idl:
html/HTMLAppletElement.idl:
html/HTMLAreaElement.idl:
html/HTMLBRElement.idl:
html/HTMLBaseElement.idl:
html/HTMLBaseFontElement.idl:
html/HTMLBlockquoteElement.idl:
html/HTMLBodyElement.idl:
html/HTMLButtonElement.idl:
html/HTMLDListElement.idl:
html/HTMLDirectoryElement.idl:
html/HTMLDivElement.idl:
html/HTMLElement.idl:
html/HTMLEmbedElement.idl:
html/HTMLFontElement.idl:
html/HTMLFormElement.idl:
html/HTMLFrameElement.idl:
html/HTMLFrameSetElement.idl:
html/HTMLHRElement.idl:
html/HTMLHeadElement.idl:
html/HTMLHeadingElement.idl:
html/HTMLHtmlElement.idl:
html/HTMLIFrameElement.idl:
html/HTMLImageElement.idl:
html/HTMLInputElement.idl:
html/HTMLIsIndexElement.idl:
html/HTMLLIElement.idl:
html/HTMLLabelElement.idl:
html/HTMLLegendElement.idl:
html/HTMLLinkElement.idl:
html/HTMLMapElement.idl:
html/HTMLMediaElement.idl:
html/HTMLMenuElement.idl:
html/HTMLMetaElement.idl:
html/HTMLModElement.idl:
html/HTMLOListElement.idl:
html/HTMLObjectElement.idl:
html/HTMLOptGroupElement.idl:
html/HTMLOptionElement.idl:
html/HTMLParagraphElement.idl:
html/HTMLParamElement.idl:
html/HTMLPreElement.idl:
html/HTMLQuoteElement.idl:
html/HTMLScriptElement.idl:
html/HTMLStyleElement.idl:
html/HTMLTableCaptionElement.idl:
html/HTMLTableCellElement.idl:
html/HTMLTableColElement.idl:
html/HTMLTableElement.idl:
html/HTMLTableRowElement.idl:
html/HTMLTableSectionElement.idl:
html/HTMLTextAreaElement.idl:
html/HTMLUListElement.idl:
html/HTMLVideoElement.idl:
svg/SVGElement.idl: Added more uses of [Reflect]. Got rid of uses of [ConvertNullToNullString] that are now unneeded since [Reflect] now implies that. Changed formatting to be simpler and consistent without all the lining up and multiple lines.

9:39 AM Changeset in webkit [61412] by dumi@chromium.org

3 edits in trunk/WebCore

Remove some unnecessary checks that cause compiler warnings.
https://bugs.webkit.org/show_bug.cgi?id=40772

Reviewed by Dimitri Glazkov.

bindings/v8/custom/V8SQLResultSetRowListCustom.cpp:

(WebCore::V8SQLResultSetRowList::itemCallback):

bindings/v8/npruntime.cpp:

9:11 AM Changeset in webkit [61411] by mnaganov@chromium.org

13 edits in trunk

2010-06-18 Mikhail Naganov <mnaganov@chromium.org>

Reviewed by Yury Semikhatsky.

WebInspector: Implement 'takeHeapSnapshot' in InspectorController.

https://bugs.webkit.org/show_bug.cgi?id=40834

bindings/js/ScriptProfiler.h: (WebCore::ScriptProfiler::takeHeapSnapshot):
bindings/v8/ScriptProfiler.cpp: (WebCore::ScriptProfiler::takeHeapSnapshot):
bindings/v8/ScriptProfiler.h:
inspector/InspectorBackend.cpp: (WebCore::InspectorBackend::takeHeapSnapshot):
inspector/InspectorBackend.h:
inspector/InspectorBackend.idl:
inspector/InspectorController.cpp: (WebCore::InspectorController::takeHeapSnapshot):
inspector/InspectorController.h:

src/js/HeapProfilerPanel.js: (WebInspector.HeapSnapshotProfileType.prototype.buttonClicked):
src/js/InspectorControllerImpl.js: (devtools.InspectorBackendImpl):
src/js/ProfilerAgent.js: (devtools.ProfilerAgent.prototype.startProfiling):

8:55 AM Changeset in webkit [61410] by mitz@apple.com

3 edits
2 adds in trunk

REGRESSION (r61379?): Assertion failure in Element::getURLAttribute() when accessing the src attribute of a script element
https://bugs.webkit.org/show_bug.cgi?id=40831

Reviewed by Anders Carlsson.

WebCore:

Test: fast/dom/HTMLScriptElement/isURLAttribute.html

html/HTMLScriptElement.cpp:

(WebCore::HTMLScriptElement::isURLAttribute): Check for the 'src' attribute.

LayoutTests:

fast/dom/HTMLScriptElement/isURLAttribute-expected.txt: Added.
fast/dom/HTMLScriptElement/isURLAttribute.html: Added.

8:54 AM Changeset in webkit [61409] by Dimitri Glazkov

33 edits
29 adds
23 deletes in trunk/LayoutTests

2010-06-18 Dimitri Glazkov <Dimitri Glazkov>

Unreviewed, expectations update.

New baselines after http://trac.webkit.org/changeset/61393.

8:46 AM Changeset in webkit [61408] by eric@webkit.org

5 edits
3 deletes in trunk

2010-06-18 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r61405.
http://trac.webkit.org/changeset/61405
https://bugs.webkit.org/show_bug.cgi?id=40838

broke chromium mac compile (Requested by tonyg-cr1 on
#webkit).

fast/js/parser-high-byte-character-expected.txt: Removed.
fast/js/parser-high-byte-character.html: Removed.
fast/js/script-tests/parser-high-byte-character.js: Removed.

2010-06-18 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r61405.
http://trac.webkit.org/changeset/61405
https://bugs.webkit.org/show_bug.cgi?id=40838

broke chromium mac compile (Requested by tonyg-cr1 on
#webkit).

bindings/v8/ScriptSourceCode.h: (WebCore::ScriptSourceCode::ScriptSourceCode):
bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::compileScript): (WebCore::V8Proxy::evaluate):
bindings/v8/V8Proxy.h:

8:44 AM Changeset in webkit [61407] by leandro@webkit.org

2 edits in trunk/WebKitTools

2010-06-18 Leandro Pereira <leandro@profusion.mobi>

Unreviewed.

Adding myself to the committers list.

Scripts/webkitpy/common/config/committers.py:

8:40 AM QtWebKitJournal edited by Simon Hausmann

(diff)

8:14 AM Changeset in webkit [61406] by eric@webkit.org

8 edits in trunk

2010-06-18 Zhenyao Mo <zmo@google.com>

Reviewed by Dimitri Glazkov.

Fix WebGLRenderingContext helper functions find{Texture/Renderbuffer/Buffer}
https://bugs.webkit.org/show_bug.cgi?id=40176

fast/canvas/webgl/gl-object-get-calls-expected.txt: Test name == 0 cases, and test getVertexAttrib return original WebGLBuffer object.
fast/canvas/webgl/script-tests/gl-object-get-calls.js: Ditto.

2010-06-18 Zhenyao Mo <zmo@google.com>

Reviewed by Dimitri Glazkov.

Fix WebGLRenderingContext helper functions find{Texture/Renderbuffer/Buffer}
https://bugs.webkit.org/show_bug.cgi?id=40176

html/canvas/WebGLBuffer.cpp: Remove constructor with existing name.
html/canvas/WebGLBuffer.h: Ditto.
html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::getVertexAttrib): Use findBuffer instead of creating a new WebGLBuffer. (WebCore::WebGLRenderingContext::findTexture): Deal with name == 0 case and return raw pointer. (WebCore::WebGLRenderingContext::findRenderbuffer): Ditto. (WebCore::WebGLRenderingContext::findBuffer): Find WebGLBuffer object using given name.
html/canvas/WebGLRenderingContext.h: Add findBuffer function declaration, change return type to raw pointer.

8:00 AM Changeset in webkit [61405] by eric@webkit.org

5 edits
3 adds in trunk

2010-06-18 Tony Gentilcore <tonyg@chromium.org>

Reviewed by David Levin.

Persist V8's ScriptData to the memory cache.
https://bugs.webkit.org/show_bug.cgi?id=38661

When V8 ScriptData caching was originally submitted it causes crashes
in external scripts with high-byte characters. This new test crashes on
the original code, but now passes.

fast/js/parser-high-byte-character-expected.txt: Added.
fast/js/parser-high-byte-character.html: Added.
fast/js/script-tests/parser-high-byte-character.js: Added. (runTest):

2010-06-18 Tony Gentilcore <tonyg@chromium.org>

Reviewed by David Levin.

Persist V8's ScriptData to the memory cache.
https://bugs.webkit.org/show_bug.cgi?id=38661

This stores V8's ScriptData in the memory cache and also causes the
network platform layer to be notified of the available cacheable
metadata.

Chromium's morejs benchmark showed a ~7% improvement when this was
originally submitted (before it had to be rolled back).

Test: fast/js/parser-high-byte-character.html

bindings/v8/ScriptSourceCode.h: (WebCore::ScriptSourceCode::ScriptSourceCode): (WebCore::ScriptSourceCode::cachedScript):
bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::compileScript): (WebCore::V8Proxy::precompileScript): (WebCore::V8Proxy::evaluate):
bindings/v8/V8Proxy.h:

6:35 AM Changeset in webkit [61404] by Simon Hausmann

2 edits in trunk/WebKit/qt

[Qt] Fix documentation for the declarative module import.

Patch by Alexis Menard <alexis.menard@nokia.com> on 2010-06-18
Reviewed by Simon Hausmann.

declarative/qdeclarativewebview.cpp:

6:09 AM Changeset in webkit [61403] by krit@webkit.org

9 edits in trunk/LayoutTests

2010-06-18 Dirk Schulze <krit@webkit.org>

Not reviewed. Rebaseline gtk results.

platform/gtk/Skipped:
platform/gtk/svg/custom/broken-internal-references-expected.txt:
platform/gtk/svg/filters/filter-on-filter-for-text-expected.txt:
platform/gtk/svg/filters/filter-on-tspan-expected.txt:
platform/gtk/svg/text/text-hkern-expected.txt:
platform/gtk/svg/text/text-hkern-on-vertical-text-expected.txt:
platform/gtk/svg/text/text-vkern-expected.txt:
platform/gtk/svg/text/text-vkern-on-horizontal-text-expected.txt:

5:50 AM Changeset in webkit [61402] by antonm@chromium.org

4 edits in trunk

2010-06-18 Anton Muhin <antonm@chromium.org>

Reviewed by Dimitri Glazkov.

[v8] Finish migration to new named property query API
https://bugs.webkit.org/show_bug.cgi?id=40771
Remove definition which allowed gradual transition to new API.
See https://bugs.webkit.org/show_bug.cgi?id=40303 for first phase.
Requires V8 roll.

DEPS:

2010-06-18 Anton Muhin <antonm@chromium.org>

Reviewed by Dimitri Glazkov.

[v8] Finish migration to new named property query API
https://bugs.webkit.org/show_bug.cgi?id=40771
Remove definition which allowed gradual transition to new API.
See https://bugs.webkit.org/show_bug.cgi?id=40303 for first phase.

config.h:

5:50 AM Changeset in webkit [61401] by Nikolas Zimmermann

6 edits
3 adds in trunk/LayoutTests

2010-06-18 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed. Rebaseline win results.

platform/win/svg/W3C-SVG-1.1/animate-elem-82-t-expected.txt: Added.
platform/win/svg/W3C-SVG-1.1/coords-trans-01-b-expected.txt:
platform/win/svg/custom/broken-internal-references-expected.txt:
platform/win/svg/custom/clip-path-referencing-use2-expected.txt:
platform/win/svg/custom/image-with-transform-clip-filter-expected.txt:
platform/win/svg/custom/junk-data-expected.txt: Added.
platform/win/svg/custom/missing-xlink-expected.txt: Added.
platform/win/svg/filters/feColorMatrix-values-expected.txt:

5:38 AM Changeset in webkit [61400] by Simon Hausmann

3 edits in trunk/WebKit/qt

Fix documentation issue on the onAlert handler.
Fix compilation issue with QT_NO_ACTION.

Patch by Alexis Menard <alexis.menard@nokia.com> on 2010-06-18
Reviewed by Simon Hausmann.

declarative/qdeclarativewebview.cpp:
declarative/qdeclarativewebview_p.h:

5:34 AM Changeset in webkit [61399] by Nikolas Zimmermann

5 edits in trunk/LayoutTests

2010-06-18 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed. Rebaseline mac-snowleopard results.

platform/mac/svg/W3C-SVG-1.1/text-intro-05-t-expected.txt:
platform/mac/svg/custom/junk-data-expected.txt:
platform/mac/svg/custom/missing-xlink-expected.txt:
platform/mac/svg/text/text-intro-05-t-expected.txt:

5:28 AM Changeset in webkit [61398] by Nikolas Zimmermann

6 edits in trunk/LayoutTests

2010-06-18 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed. Rebaseline mac-tiger test results.

platform/mac-tiger/svg/W3C-SVG-1.1/metadata-example-01-b-expected.txt:
platform/mac-tiger/svg/hixie/text/003-expected.txt:
platform/mac-tiger/svg/hixie/text/003a-expected.txt:
platform/mac-tiger/svg/hixie/viewbox/preserveAspectRatio/001-expected.txt:
platform/mac-tiger/svg/hixie/viewbox/preserveAspectRatio/002-expected.txt:

5:27 AM QtWebKitBackportingFixes edited by Simon Hausmann

(diff)

5:27 AM Changeset in webkit [61397] by pfeldman@chromium.org

15 edits in trunk

2010-06-17 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: bring XHR console records back.

adds "Enable XHR Monitor" / "Disable XHR Monitor" actions to the console's context menu
make the chosen option persist in the settings.

https://bugs.webkit.org/show_bug.cgi?id=40799

English.lproj/localizedStrings.js:
inspector/InspectorBackend.cpp: (WebCore::InspectorBackend::disableSearchingForNode): (WebCore::InspectorBackend::enableMonitoringXHR): (WebCore::InspectorBackend::disableMonitoringXHR):
inspector/InspectorBackend.h:
inspector/InspectorBackend.idl:
inspector/InspectorController.cpp: (WebCore::InspectorController::InspectorController): (WebCore::InspectorController::setMonitoringXHR): (WebCore::InspectorController::didLoadResourceFromMemoryCache): (WebCore::InspectorController::identifierForInitialRequest): (WebCore::InspectorController::resourceRetrievedByXMLHttpRequest): (WebCore::InspectorController::ensureSettingsLoaded):
inspector/InspectorController.h:
inspector/InspectorFrontend.cpp: (WebCore::InspectorFrontend::monitoringXHRWasEnabled): (WebCore::InspectorFrontend::monitoringXHRWasDisabled):
inspector/InspectorFrontend.h:
inspector/front-end/ConsoleView.js: (WebInspector.ConsoleView.prototype._handleContextMenuEvent): (WebInspector.ConsoleView.prototype._registerShortcuts):
inspector/front-end/InjectedScript.js: (injectedScriptConstructor.):
inspector/front-end/InspectorBackendStub.js: (.WebInspector.InspectorBackendStub): (.WebInspector.InspectorBackendStub.prototype.enableMonitoringXHR): (.WebInspector.InspectorBackendStub.prototype.disableMonitoringXHR):
inspector/front-end/inspector.js: (WebInspector.monitoringXHRWasEnabled): (WebInspector.monitoringXHRWasDisabled):
xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::didFinishLoading):

5:25 AM Changeset in webkit [61396] by Nikolas Zimmermann

17 edits
2 adds in trunk/LayoutTests

2010-06-18 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed. Rebaselined Qt test results.

platform/qt/svg/custom/broken-internal-references-expected.txt:
platform/qt/svg/custom/empty-mask-expected.txt:
platform/qt/svg/custom/mask-invalidation-expected.txt:
platform/qt/svg/custom/stroke-width-large-expected.txt:
platform/qt/svg/custom/text-xy-updates-SVGList-expected.txt:
platform/qt/svg/custom/use-on-symbol-inside-pattern-expected.txt:
platform/qt/svg/dom/altGlyph-dom-expected.txt: Added.
platform/qt/svg/filters/feColorMatrix-values-expected.txt:
platform/qt/svg/filters/feComposite-expected.txt:
platform/qt/svg/filters/filter-on-tspan-expected.txt:
platform/qt/svg/filters/sourceAlpha-expected.txt:
platform/qt/svg/text/lengthAdjust-text-metrics-expected.txt: Added.
platform/qt/svg/text/selection-background-color-expected.txt:
platform/qt/svg/text/selection-doubleclick-expected.txt:
platform/qt/svg/text/selection-styles-expected.txt:
platform/qt/svg/text/selection-tripleclick-expected.txt:
platform/qt/svg/zoom/page/zoom-coords-viewattr-01-b-expected.txt:
platform/qt/svg/zoom/text/zoom-coords-viewattr-01-b-expected.txt:

5:23 AM Changeset in webkit [61395] by Simon Hausmann

2 edits in trunk/WebKit/qt

REGRESSION(r60958) [Qt] qwebpage::inputMethods auto-test fails
https://bugs.webkit.org/show_bug.cgi?id=40830

Reviewed by Antti Koivisto.

When activating a regular input method field, always set or unset the ImhHiddenText
input method hint.

WebCoreSupport/EditorClientQt.cpp:

(WebCore::EditorClientQt::setInputMethodState):

4:37 AM Changeset in webkit [61394] by tkent@chromium.org

2 edits in trunk/LayoutTests

2010-06-18 Kent Tamura <tkent@chromium.org>

Unreviewed, test expectation update.

platform/chromium/test_expectations.txt: Merge text_expectations.txt of Chromium tree. Mainly for <progress> and <meter>.

4:18 AM Changeset in webkit [61393] by Nikolas Zimmermann

759 edits
4 moves
102 adds in trunk

2010-06-18 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Dirk Schulze.

Modernize SVG Text code, following the HTML design
https://bugs.webkit.org/show_bug.cgi?id=40663

SVG Text does not support subpixel positioning
https://bugs.webkit.org/show_bug.cgi?id=12172

RenderSVGText can't do partial repaints
https://bugs.webkit.org/show_bug.cgi?id=15386

HTML and SVG need to share more text painting code
https://bugs.webkit.org/show_bug.cgi?id=15644

Rewrite SVG Text rendering, only keeping the layout of the actual characters/chunks as it was.
We're now drawing SVG Text very similar to HTML Text, utilizing the SVGInlineFlowBox/SVGInlineTextBox structure,
instead of painting all text content of a <text> element from the SVGRootInlineBox, as it was the last years.

Rough overview of the changes:

Partial repainting support for text selections (startPos/endPos are respected), no more redrawing of the whole <text> content while selecting
Subpixel positioning (near pixel-perfect rendering for all W3C tests that contain text, finally!) -> much better textPath results, characters now align as expected, as all rounding hacks are disabled for SVG text runs, and subpixel precision is used while painting
No more custom handling of selection, the standard methods offsetFromPosition() / selectionRectForText() are used instead.
Selection works as expected on stretched/squeezed text (lengthAdjust="spacingAndGlyphs"), takes 'includePartialGlyphs' into account - just like HTML text
Correct text decoration drawing (proper with and positions and rendering-order, underline/overline before text, strike-through afterwards)
Proper sizing of all InlineBoxes, starting from the SVGRootInlineBox, down to every single flow & text box -> correct DRT results, no more weird negative offsets of text runs, etc. Looks exactly like the HTML text test results.
Rewritten SVGTextContentElement API to take per-character / per-chunk transformations into account.
Speeeeeed! Drawing is much faster now.

Add 24 new testcases covering basic selection features and the SVGTextContentElement API. Each test draws a half-opaque red rectangle, calculated using
SVGTextContentElement API to highlight the area that is supposed to be selected. Then eventSender API is utilized to move the mouse to the calculated
start origin, holding it down and moving it to the end position.

A detailed list of tests that show progression, can be found in the corresponding LayoutTests/ChangeLog.
Note that this requires a rebaselining of all SVG tests containing text elements.

Tests: svg/hixie/text/001.xml (moved from svg/hixie/text/001-broken.xml)

svg/text/lengthAdjust-text-metrics.html
svg/text/select-textLength-spacing-squeeze-1.svg
svg/text/select-textLength-spacing-squeeze-2.svg
svg/text/select-textLength-spacing-squeeze-3.svg
svg/text/select-textLength-spacing-squeeze-4.svg
svg/text/select-textLength-spacing-stretch-1.svg
svg/text/select-textLength-spacing-stretch-2.svg
svg/text/select-textLength-spacing-stretch-3.svg
svg/text/select-textLength-spacing-stretch-4.svg
svg/text/select-textLength-spacingAndGlyphs-squeeze-1.svg
svg/text/select-textLength-spacingAndGlyphs-squeeze-2.svg
svg/text/select-textLength-spacingAndGlyphs-squeeze-3.svg
svg/text/select-textLength-spacingAndGlyphs-squeeze-4.svg
svg/text/select-textLength-spacingAndGlyphs-stretch-1.svg
svg/text/select-textLength-spacingAndGlyphs-stretch-2.svg
svg/text/select-textLength-spacingAndGlyphs-stretch-3.svg
svg/text/select-textLength-spacingAndGlyphs-stretch-4.svg
svg/text/select-x-list-1.svg
svg/text/select-x-list-2.svg
svg/text/select-x-list-3.svg
svg/text/select-x-list-4.svg
svg/text/select-x-list-with-tspans-1.svg
svg/text/select-x-list-with-tspans-2.svg
svg/text/select-x-list-with-tspans-3.svg
svg/text/select-x-list-with-tspans-4.svg

rendering/InlineBox.h: Remove not needed isInlineBox() method. (WebCore::InlineBox::isInlineTextBox): Constify this method. (WebCore::InlineBox::isSVGInlineTextBox): Added, with ENABLE(SVG) guards, just like the existing isSVGRootInlineBox(). (WebCore::InlineBox::isSVGRootInlineBox): Constify this method. (WebCore::InlineBox::calculateBoundaries): Added, with ENABLE(SVG) guards, used to calculate the whole boundaries of a InlineText/FlowBox, only used in SVG text.
rendering/InlineFlowBox.h: Devirtualize placeBoxesHorizontally(), SVG no more overrides it.
rendering/InlineTextBox.h: Virtualize selectionStartEnd() - SVGInlineTextBox needs to change start/endPositions based on the current text chunk part that it's rendering.

SVGTextChunkLayoutInfo.h contains a detailed documentation what a SVGTextChunk/SVGTextChunkPart is, and why they are necessary.

(WebCore::InlineTextBox::isInlineTextBox): Constify this method.

rendering/RenderBlock.h: (WebCore::RenderBlock::forceLayoutInlineChildren): Add helper method, used only by RenderSVGText, to use a simplified layout strategy, which is a big speed win.
rendering/RenderBlockLineLayout.cpp: (WebCore::RenderBlock::computeHorizontalPositionsForLine): Remove all isSVGText() special cases, as this function is not called anymore for SVG text. (WebCore::RenderBlock::layoutInlineChildren): Don't call computeHorizontalPositionsForLine() for SVG text. computePerCharacterLayoutInformation() overrides it anyway.
rendering/RenderSVGInline.cpp: Remove custom absoluteRects/absoluteQuads code, all shared with RenderInline now. (WebCore::RenderSVGInline::clippedOverflowRectForRepaint): Added, forward to SVGRenderBase, just like all other non-text SVG renderers do. (WebCore::RenderSVGInline::computeRectForRepaint): Ditto. (WebCore::RenderSVGInline::mapLocalToContainer): Ditto
rendering/RenderSVGInline.h:
rendering/RenderSVGInlineText.cpp: Remove destroy() hack, which called setNeedsLayoutAndPrefWidthsRecalc/repaint on destruction.

As repaint rects work properly now, this hack is no longer necessary, it was only hiding the real problem.

(WebCore::RenderSVGInlineText::styleDidChange): Don't skip RenderText::styleDidChange() anymore, which automatically schedules layout changes for us.
(WebCore::RenderSVGInlineText::localCaretRect): Remove outdated comment, localCaretRect() is not yet needed in SVG text code.

rendering/RenderSVGInlineText.h: Remove custom absoluteRects/absoluteQuads/selectionRectForRepaint/positionForPoint/destroy/computeRectForRepaint* code, all shared with RenderText now.
rendering/RenderSVGText.cpp: (WebCore::RenderSVGText::mapLocalToContainer): Take x/y translation into account, but do NOT include in localToParentTransform(), as that would affect rendering. (WebCore::RenderSVGText::layout): Use super-simplified layout strategy, removing a lot of uncessary stuff done by RenderBlock, that SVG does not need. (WebCore::RenderSVGText::absoluteRects): Remove dead-code, retreving the RenderSVGRoot* object, not necessary since a longer time. (WebCore::RenderSVGText::absoluteQuads): Ditto. (WebCore::RenderSVGText::paint): Early exit if we're not in PaintPhaseForeground/PaintPhaseSelfOutline. We're not interessted in other phases. (WebCore::RenderSVGText::strokeBoundingBox): Fix stroke width calculation, no need to special case SVGFonts.
rendering/RenderSVGText.h: Remove updateFirstLineBlock/updateFirstLetter overrides, the new RenderSVGText::layout() code, doesn't use these methods at all.

We asked RenderBlock to layout before, which was calling updateFirstLetter & co, this is gone now, as it was all not needed.

(WebCore::RenderSVGText::objectBoundingBox): Directly return the frameRect here, inlined for speed.

rendering/RootInlineBox.cpp: (WebCore::RootInlineBox::verticallyAlignBoxes): Early-exit if we're a SVGRootInlineBox. SVG handles this on its own.
rendering/RootInlineBox.h: Devirtualize verticallyAlignBoxes(), SVG no longer overrides it. Remove virtual computePerCharacterLayoutInformation() method, only lives in SVGRootInlineBox now.
rendering/SVGCharacterData.h: Remove no longer needed SVGTextDecorationInfo.
rendering/SVGCharacterLayoutInfo.cpp: Don't pass a reference to a Vector<SVGChar> to SVGCharacterLayoutInfo, let it create it. (WebCore::SVGCharacterLayoutInfo::SVGCharacterLayoutInfo):
rendering/SVGCharacterLayoutInfo.h:
rendering/SVGInlineFlowBox.cpp: (WebCore::SVGInlineFlowBox::paint): Ask children to paint. (WebCore::SVGInlineFlowBox::calculateBoundaries): Calculate boundaries by uniting all direct children boundaries.
rendering/SVGInlineFlowBox.h: Remove placeBoxesHorizontally, which does not get called anymore, and does not need to be overriden.
rendering/SVGInlineTextBox.cpp: (WebCore::SVGInlineTextBox::SVGInlineTextBox): Don't use abbrevations for variable names, initialize new member variables. (WebCore::SVGInlineTextBox::measureCharacter): New helper function extracted from buildLayoutInformation, replacing calculateGlyphWidth/Height. (WebCore::SVGInlineTextBox::offsetForPosition): Implement this method by utilizing Font::offsetForPosition(), but respecting the text chunk parts. (WebCore::SVGInlineTextBox::positionForOffset): No change here, still not used. (WebCore::SVGInlineTextBox::selectionRect): Rewritten, utilizing Font::selectionRectForText(), taking text chunk parts into account, and the supplied startPos/endPos. (WebCore::SVGInlineTextBox::paint): Rewritten, to handle paint servers much more elegant, than the old solution. See code for details, too much to explain here. (WebCore::SVGInlineTextBox::acquirePaintingResource): Helper function, used from paint(). (WebCore::SVGInlineTextBox::releasePaintingResource): Ditto. (WebCore::SVGInlineTextBox::prepareGraphicsContextForTextPainting): Ditto. (WebCore::SVGInlineTextBox::restoreGraphicsContextAfterTextPainting): Ditto. (WebCore::SVGInlineTextBox::constructTextRun): Helper function centralizing the creation of a TextRun object, used to draw/measure SVG text. (WebCore::SVGInlineTextBox::mapStartEndPositionsIntoChunkPartCoordinates): Important helper function, mapping a startPos/endPos from InlineTextBox

coordinate space to the SVGInlineTextBox, respecting the current text chunk part.

(WebCore::SVGInlineTextBox::selectionStartEnd): Call InlineTextBox::selectionStartEnd(), and apply post fixes when m_currentChunkPart is set. (called when painting a selected chunk part)
(WebCore::positionOffsetForDecoration): Refactored from old paintDecoration() code.
(WebCore::thicknessForDecoration): Ditto.
(WebCore::findRenderObjectDefininingTextDecoration): Ditto.
(WebCore::SVGInlineTextBox::paintDecoration): Ditto. (Can not share the code with HTML, as we need floating point precision, and directly call fillRect, instead of drawHighlightForText.)
(WebCore::SVGInlineTextBox::paintDecorationWithStyle): Ditto.
(WebCore::SVGInlineTextBox::paintSelection): New method, painting text selections with floating-point precision.
(WebCore::SVGInlineTextBox::paintText): New method, painting text with floating-point precision, correctly handling selected text, removing the need for special SVG text sub-paint phases.

(GlyphFill/StrokeSelectionPhase, GlyphFill/StrokePhase)

(WebCore::SVGInlineTextBox::buildLayoutInformation): Use new measureCharacter() helper function, renamed some variables, to avoid abbrevations.
(WebCore::SVGInlineTextBox::calculateGlyphBoundaries): Rewritten to use new measureCharacter() helper function.
(WebCore::SVGInlineTextBox::calculateBoundaries): Rewritten to take text chunk parts into account, serves as central method used to layout InlineBoxes (see SVGRootInlineBox.)

rendering/SVGInlineTextBox.h: (WebCore::SVGInlineTextBox::isSVGInlineTextBox): Added. (WebCore::SVGInlineTextBox::setHeight): Rename variable, to avoid abbrevations. (WebCore::SVGInlineTextBox::chunkTransformation): New helper function, returning the transformation, that gets applied to the complete text chunk, if any. (WebCore::SVGInlineTextBox::setChunkTransformation): New helper function used by SVGRrootInlineBox, to set the chunk transformation, during text chunk part propagation phase. (WebCore::SVGInlineTextBox::addChunkPartInformation): Ditto. (WebCore::SVGInlineTextBox::svgTextChunkParts): Ditto.
rendering/SVGRootInlineBox.cpp: Virtually rewritten, to be designed more like HTMLs RootInlineBox, diving into children for painting. (WebCore::SVGRootInlineBox::paint): Ask children to paint, nothing more. No more traversing through the SVGTextChunks, figuring out which part to render, this is done in layout phase now. (WebCore::SVGRootInlineBox::computePerCharacterLayoutInformation): Completly redesigned, see SVGTextChunkLayoutInfo.h for a high-level overview. (WebCore::SVGRootInlineBox::buildLayoutInformation): Just small cleanups, nothing changed here. (WebCore::SVGRootInlineBox::layoutChildBoxes): New helper function, extracted from old layoutInlineBoxes(). (WebCore::SVGRootInlineBox::layoutRootBox): Ditto. (WebCore::SVGRootInlineBox::propagateTextChunkPartInformation): Key-concept of the new design, builds "text chunk parts" and propagates that knownledge to all child SVGInlineTextBoxes.
rendering/SVGRootInlineBox.h: (WebCore::SVGRootInlineBox::isSVGRootInlineBox): Constified method. (WebCore::SVGRootInlineBox::setHeight): Change variable name, to avoid abbrevations.
rendering/SVGTextChunkLayoutInfo.cpp: Remove if 0, enable compilation.
rendering/SVGTextChunkLayoutInfo.h: Add large comment explaining text chunk parts, the key concept of the new design. Remove SVGTextChunkWalker & friends, no longer used. (WebCore::SVGTextChunkPart::SVGTextChunkPart): (WebCore::SVGTextChunkPart::isValid): (WebCore::SVGTextChunk::SVGTextChunk): (WebCore::SVGTextChunkLayoutInfo::SVGTextChunkLayoutInfo): (WebCore::SVGTextChunkLayoutInfo::textChunks):
rendering/SVGTextLayoutUtilities.cpp: (WebCore::cummulatedWidthOfInlineBoxCharacterRange): (WebCore::cummulatedHeightOfInlineBoxCharacterRange): (WebCore::svgTextRunForInlineTextBox): Disable rounding hacks, explain parameters with comments, why they have which values.
rendering/SVGTextLayoutUtilities.h: Remove SVGTextPaintSubphase and SVGTextPaintInfo.
rendering/SVGTextQuery.cpp: Remove if 0, enable compilation.
rendering/SVGTextQuery.h: Ditto.
svg/SVGStyledElement.cpp: Very important change! Do not treat CSS attributes as recognized attributes, that would lead to setNeedsLayout() calls, reducing performance!

This hack existed, as we were not dealing with text updates correctly, now that RenderSVGInlineText::styleDidChange is fixed, it's no longer necessary.

(WebCore::SVGStyledElement::isKnownAttribute):

svg/SVGTextContentElement.cpp: Completely remove the SVGTextContentElement API, that manually traversed all text chunks, instead use the new SVGTextQuery API. (WebCore::SVGTextContentElement::getNumberOfChars): (WebCore::SVGTextContentElement::getComputedTextLength): (WebCore::SVGTextContentElement::getSubStringLength): (WebCore::SVGTextContentElement::getStartPositionOfChar): (WebCore::SVGTextContentElement::getEndPositionOfChar): (WebCore::SVGTextContentElement::getExtentOfChar): (WebCore::SVGTextContentElement::getRotationOfChar): (WebCore::SVGTextContentElement::getCharNumAtPosition):
svg/SVGTextElement.cpp: Very important change! Do not calls setNeedsLayout() on RenderSVGText, if childrenChanged() has been called.
svg/SVGTextElement.h: Completly remove childrenChanged() - no longer necessary, updates work as expected without it now.

3:41 AM Changeset in webkit [61392] by eric@webkit.org

2 edits in trunk/WebCore

2010-06-18 Lucas De Marchi <lucas.demarchi@profusion.mobi>

Reviewed by David Levin.

Fix compilation when filters are disabled. Revision r60689
changed the signature of SVGRenderBase::prepareToRenderSVGContent()
but didn't change the unsused parameters when filters are disabled.
https://bugs.webkit.org/show_bug.cgi?id=40625

No new tests. Compilation fix.

rendering/SVGRenderSupport.cpp: (WebCore::SVGRenderBase::prepareToRenderSVGContent):

3:28 AM Changeset in webkit [61391] by eric@webkit.org

3 edits
2 adds in trunk

2010-06-18 Adam Barth <abarth@webkit.org>

Reviewed by Darin Adler.

noAccess url schemes block access to inline stylesheets
https://bugs.webkit.org/show_bug.cgi?id=32309

Test that data URLs can access their inline style sheets.

http/tests/security/data-url-inline.css-expected.txt: Added.
http/tests/security/data-url-inline.css.html: Added.

2010-06-18 Adam Barth <abarth@webkit.org>

Reviewed by Darin Adler.

noAccess url schemes block access to inline stylesheets
https://bugs.webkit.org/show_bug.cgi?id=32309

Instead of using baseURL() to grab the security context we should just
use finalURL directly. When I wrote the original patch that added this
security check, finalURL didn't exist yet.

If finalURL is an empty URL, that means we generated the style sheet
from text that didn't have a URL. It would be slightly safer to store
a bit on CSSStyleSheet indicating whether it came from an inline style
sheet, but I think this check is fairly accurate.

Test: http/tests/security/data-url-inline.css.html

css/CSSStyleSheet.cpp: (WebCore::CSSStyleSheet::cssRules):

3:04 AM QtWebKitBackportingFixes edited by Simon Hausmann

(diff)

2:31 AM Changeset in webkit [61390] by abarth@webkit.org

5 edits
3 adds in trunk

2010-06-18 Adam Barth <abarth@webkit.org>

Reviewed by Darin Adler.

Remove unneeded custom code for WebSocket.send
https://bugs.webkit.org/show_bug.cgi?id=38180

We don't appear to require a custom binding here. The old function was
wacky in two ways:

1) It required all of its arguments.

2) If the toString of its argument threw, it would catch the exception

and re-throw a different exception.

I've kept the first behavior but changed the second (and documented it
with a test).

Test: websocket/tests/send-throw.html

bindings/js/JSWebSocketCustom.cpp:
bindings/v8/custom/V8WebSocketCustom.cpp:
websockets/WebSocket.idl:

2010-06-18 Adam Barth <abarth@webkit.org>

Reviewed by Darin Adler.

Remove unneeded custom code for WebSocket.send
https://bugs.webkit.org/show_bug.cgi?id=38180

Test what happens when you pass an object to WebSocket.send that throws
when you convert it to a string.

websocket/tests/script-tests/send-throw.js: Added. (endTest): (FIRST_MESSAGE_TO_SEND.toString): (ws.onopen): (ws.onclose): (timeOutCallback):
websocket/tests/send-throw-expected.txt: Added.
websocket/tests/send-throw.html: Added.

2:18 AM Changeset in webkit [61389] by Simon Hausmann

4 edits in trunk

WebKit: [qt] Better check for the declarative plugin inclusion.

Patch by Alexis Menard <alexis.menard@nokia.com> on 2010-06-18
Reviewed by Simon Hausmann.

WebKit.pro:

WebKit/qt: [Qt] Change the target path to QtWebKit.

Patch by Alexis Menard <alexis.menard@nokia.com> on 2010-06-18
Reviewed by Simon Hausmann.

declarative/declarative.pro:

2:16 AM Changeset in webkit [61388] by dumi@chromium.org

25 edits in trunk

Move isAvailable()/setIsAvailable() from Database/DatabaseSync to AbstractDatabase.
https://bugs.webkit.org/show_bug.cgi?id=39041

Reviewed by Adam Barth.

WebCore:

WebCore.base.exp
bindings/generic/RuntimeEnabledFeatures.cpp:

(WebCore::RuntimeEnabledFeatures::openDatabaseEnabled):
(WebCore::RuntimeEnabledFeatures::openDatabaseSyncEnabled):

page/DOMWindow.cpp:

(WebCore::DOMWindow::openDatabase):

storage/AbstractDatabase.cpp:

(WebCore::AbstractDatabase::isAvailable):
(WebCore::AbstractDatabase::setIsAvailable):

storage/AbstractDatabase.h:
storage/Database.cpp:
storage/Database.h:
storage/DatabaseSync.cpp:
storage/DatabaseSync.h:
workers/WorkerContext.cpp:

(WebCore::WorkerContext::openDatabase):
(WebCore::WorkerContext::openDatabaseSync):

workers/WorkerContext.h:

WebKit/chromium:

src/WebRuntimeFeatures.cpp:

(WebKit::WebRuntimeFeatures::enableDatabase):
(WebKit::WebRuntimeFeatures::isDatabaseEnabled):

WebKit/gtk:

webkit/webkitwebview.cpp:

(webkit_web_view_update_settings):
(webkit_web_view_settings_notify):
(webkit_get_cache_model):

WebKit/mac:

WebView/WebView.mm:

(-[WebView _preferencesChangedNotification:]):

WebKit/qt:

Api/qwebsettings.cpp:

(QWebSettingsPrivate::apply):

WebKit/win:

WebView.cpp:

(WebView::notifyPreferencesChanged):

WebKit/wx:

WebView.cpp:

(wxWebView::SetDatabasesEnabled):
(wxWebView::AreDatabasesEnabled):

2:01 AM Changeset in webkit [61387] by Nikolas Zimmermann

2 edits in trunk/LayoutTests

2010-06-18 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed. Try to turn Gtk 32-bit Linux Debug green again.

platform/gtk/Skipped:

1:58 AM Changeset in webkit [61386] by abarth@webkit.org

2 edits in trunk/WebCore

2010-06-18 Adam Barth <abarth@webkit.org>

Rubber-stamped by Eric Seidel.

Fix the namespace indent for HTML5Lexer. This patch changes
white-space only.

html/HTML5Lexer.h: (WebCore::HTML5Lexer::): (WebCore::HTML5Lexer::lineNumber): (WebCore::HTML5Lexer::columnNumber): (WebCore::HTML5Lexer::state): (WebCore::HTML5Lexer::setState): (WebCore::HTML5Lexer::skipLeadingNewLineForListing): (WebCore::HTML5Lexer::InputStreamPreprocessor::InputStreamPreprocessor): (WebCore::HTML5Lexer::InputStreamPreprocessor::nextInputCharacter): (WebCore::HTML5Lexer::InputStreamPreprocessor::peek): (WebCore::HTML5Lexer::InputStreamPreprocessor::advance):

1:28 AM Changeset in webkit [61385] by ukai@chromium.org

2 edits in trunk/WebCore

Unreviewed test breakage fix.

WebSocket: resume should not process buffer if already processing.
https://bugs.webkit.org/show_bug.cgi?id=39340

MessageLoop runs in main thread, so we don't need to use timer in worker thread.
Also, we should not use Timer in worker thread.

websockets/ThreadableWebSocketChannelClientWrapper.h:

(WebCore::ThreadableWebSocketChannelClientWrapper::resume):
(WebCore::ThreadableWebSocketChannelClientWrapper::ThreadableWebSocketChannelClientWrapper):

12:22 AM QtWebKitWebGL edited by jarkko.j.sakkinen@gmail.com

(diff)

Note: See TracTimeline for information about the timeline view.

Download in other formats:

RSS Feed