⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Jun 20, 2010:

11:44 PM Changeset in webkit [61529] by yurys@chromium.org
  • 5 edits in trunk

2010-06-20 Yury Semikhatsky <​yurys@chromium.org>

Reviewed by Pavel Feldman.

[v8] Web Inspector: don't add ScriptDebugServer as v8 listener if browser exposes
v8 debugging protocol.
​https://bugs.webkit.org/show_bug.cgi?id=40844

  • bindings/v8/ScriptDebugServer.cpp: (WebCore::ScriptDebugServer::ScriptDebugServer): (WebCore::ScriptDebugServer::addListener): (WebCore::ScriptDebugServer::setEnabled): (WebCore::ScriptDebugServer::isDebuggerAlwaysEnabled):
  • bindings/v8/ScriptDebugServer.h:

2010-06-20 Yury Semikhatsky <​yurys@chromium.org>

Reviewed by Pavel Feldman.

[v8] Web Inspector: don't add ScriptDebugServer as v8 listener if browser exposes
v8 debugging protocol.

  • src/DebuggerAgentManager.cpp: (WebKit::DebuggerAgentManager::setExposeV8DebuggerProtocol):
10:28 PM Changeset in webkit [61528] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-06-20 Gyuyoung Kim <​gyuyoung.kim@samsung.com>

Unreviewed build fix.

[EFL] Build break for r61527
​https://bugs.webkit.org/post_bug.cgi

  • CMakeLists.txt: Add loader/FormSubmission.cpp
9:38 PM Changeset in webkit [61527] by tkent@chromium.org
  • 5 edits in trunk/WebKitTools

2010-06-20 Kent Tamura <​tkent@chromium.org>

Reviewed by Dimitri Glazkov.

[DRT/Chromium] Add --allow-external-pages option
​https://bugs.webkit.org/show_bug.cgi?id=40762

Add --allow-external-pages introduced by Chromium r45403.
​http://src.chromium.org/viewvc/chrome?view=rev&revision=45403

  • DumpRenderTree/chromium/DumpRenderTree.cpp: (main):
  • DumpRenderTree/chromium/TestShell.cpp: (TestShell::TestShell):
  • DumpRenderTree/chromium/TestShell.h: (TestShell::allowExternalPages): (TestShell::setAllowExternalPages):
  • DumpRenderTree/chromium/WebViewHost.cpp: (WebViewHost::willSendRequest):
8:35 PM Changeset in webkit [61526] by andersca@apple.com
  • 2 edits in trunk/WebKit/mac

Fix Tiger build.

  • Plugins/WebNetscapePluginPackage.mm:
8:20 PM Changeset in webkit [61525] by andersca@apple.com
  • 4 edits in trunk/WebKit/mac

2010-06-20 Anders Carlsson <​andersca@apple.com>

Reviewed by Dan Bernstein.

Get rid of the old MIMETypes getter method
​https://bugs.webkit.org/show_bug.cgi?id=40898

  • Plugins/WebBasePluginPackage.h:
  • Plugins/WebBasePluginPackage.mm: (-[WebBasePluginPackage supportsExtension:]): (-[WebBasePluginPackage supportsMIMEType:WebCore::]): (-[WebBasePluginPackage MIMETypeForExtension:]):
  • Plugins/WebPluginDatabase.mm: (-[WebPluginDatabase refresh]): (-[WebPluginDatabase _removePlugin:]):
7:58 PM Changeset in webkit [61524] by andersca@apple.com
  • 5 edits in trunk

Remove bogus const qualifiers.

Reviewed by Dan Bernstein.

WebCore:

  • platform/mac/PasteboardHelper.h:

WebKit/mac:

  • WebCoreSupport/WebPasteboardHelper.h:
  • WebCoreSupport/WebPasteboardHelper.mm:

(WebPasteboardHelper::urlFromPasteboard):
(WebPasteboardHelper::plainTextFromPasteboard):
(WebPasteboardHelper::fragmentFromPasteboard):

7:34 PM Changeset in webkit [61523] by andersca@apple.com
  • 3 edits in trunk/WebKit/mac

2010-06-20 Anders Carlsson <​andersca@apple.com>

Reviewed by Dan Bernstein.

Get rid of the extensionToMIME mapping in WebBasePluginPackage
​https://bugs.webkit.org/show_bug.cgi?id=40897

Instead of using the extensionToMIME mutable dictionary, use the MIME types vector.
While this makes lookup of MIME types based on extensions linear instead of constant,
the number of extensions per plug-in is too small for it to matter.

  • Plugins/WebBasePluginPackage.h:
  • Plugins/WebBasePluginPackage.mm: (-[WebBasePluginPackage initWithPath:]): (-[WebBasePluginPackage dealloc]): (-[WebBasePluginPackage supportsExtension:]): (-[WebBasePluginPackage MIMETypeForExtension:]): (-[WebBasePluginPackage setMIMEToExtensionsDictionary:]):
7:13 PM Changeset in webkit [61522] by andersca@apple.com
  • 5 edits in trunk/WebKit/mac

2010-06-20 Anders Carlsson <​andersca@apple.com>

Reviewed by Dan Bernstein.

Add a MimeClassInfo Vector to WebBasePluginPackage
​https://bugs.webkit.org/show_bug.cgi?id=40896

  • Plugins/WebBasePluginPackage.h:
  • Plugins/WebBasePluginPackage.mm: (-[WebBasePluginPackage getPluginInfoFromPLists]): (-[WebBasePluginPackage WebCore::]):
  • Plugins/WebNetscapePluginPackage.mm: (-[WebNetscapePluginPackage getPluginInfoFromResources]):
  • WebCoreSupport/WebPlatformStrategies.mm: (WebPlatformStrategies::getPluginInfo):
7:12 PM Changeset in webkit [61521] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-06-20 Patrick Gansterer <​paroga@paroga.com>

Reviewed by Kent Tamura.

Buildfix for NotificationCenter.h.
​https://bugs.webkit.org/show_bug.cgi?id=40890

ScriptExecutionContext::completeURL is used in header,
but ScriptExecutionContext.h wasn't included.

  • notifications/NotificationCenter.h:
6:38 PM Changeset in webkit [61520] by tkent@chromium.org
  • 2 edits in trunk/LayoutTests

2010-06-20 Kent Tamura <​tkent@chromium.org>

Unreviewed, test expectation update.

  • platform/chromium/test_expectations.txt: Update for other <meter> tests and flaky/slow tests
6:30 PM Changeset in webkit [61519] by andersca@apple.com
  • 6 edits in trunk/WebKit/mac

2010-06-20 Anders Carlsson <​andersca@apple.com>

Reviewed by Dan Bernstein.

Move the NSBundle ivar to WebPluginPackage
​https://bugs.webkit.org/show_bug.cgi?id=40894

  • Plugins/WebBasePluginPackage.h:
  • Plugins/WebBasePluginPackage.mm: (-[WebBasePluginPackage initWithPath:]): (-[WebBasePluginPackage _objectForInfoDictionaryKey:]): (-[WebBasePluginPackage getPluginInfoFromPLists]): (-[WebBasePluginPackage load]): (-[WebBasePluginPackage dealloc]):
  • Plugins/WebNetscapePluginPackage.mm: (-[WebNetscapePluginPackage _initWithPath:]):
  • Plugins/WebPluginPackage.h:
  • Plugins/WebPluginPackage.mm: (-[WebPluginPackage initWithPath:]): (-[WebPluginPackage dealloc]): (-[WebPluginPackage viewFactory]): (-[WebPluginPackage load]):
6:05 PM Changeset in webkit [61518] by eric@webkit.org
  • 10 edits
    4 adds in trunk

2010-06-20 Tony Gentilcore <​tonyg@chromium.org>

Reviewed by Eric Seidel.

Test to make sure parsing of async attribute works for HTML script tags
and test to make sure that async is not parsed for SVG script tags.
​https://bugs.webkit.org/show_bug.cgi?id=39026

  • fast/dom/HTMLScriptElement/script-async-attr-expected.txt: Added.
  • fast/dom/HTMLScriptElement/script-async-attr.html: Added.
  • svg/dom/SVGScriptElement/script-async-attr-expected.txt: Added.
  • svg/dom/SVGScriptElement/script-async-attr.svg: Added.

2010-06-20 Tony Gentilcore <​tonyg@chromium.org>

Reviewed by Eric Seidel.

Recognize async attribute on HTML script tags.
​https://bugs.webkit.org/show_bug.cgi?id=39026

This does not implement async behavior, it only parses the async
attribute for HTML script tags. SVG script tags continue to not
support the async attribute.

Tests: fast/dom/HTMLScriptElement/script-async-attr.html

svg/dom/SVGScriptElement/script-async-attr.svg

  • dom/ScriptElement.cpp: (WebCore::ScriptElementData::isAsynchronous): (WebCore::ScriptElementData::isDeferred):
  • dom/ScriptElement.h:
  • html/HTMLAttributeNames.in:
  • html/HTMLScriptElement.cpp: (WebCore::HTMLScriptElement::async): (WebCore::HTMLScriptElement::setAsync): (WebCore::HTMLScriptElement::defer): (WebCore::HTMLScriptElement::asyncAttributeValue): (WebCore::HTMLScriptElement::deferAttributeValue):
  • html/HTMLScriptElement.h:
  • html/HTMLScriptElement.idl:
  • svg/SVGScriptElement.cpp: (WebCore::SVGScriptElement::asyncAttributeValue): (WebCore::SVGScriptElement::deferAttributeValue):
  • svg/SVGScriptElement.h:
5:44 PM Changeset in webkit [61517] by tony@chromium.org
  • 1 edit
    1 delete in trunk/LayoutTests

2010-06-20 Tony Chang <​tony@chromium.org>

Not reviewed, just cleaning up svn.

Removing platform/mac-snowleopard/editing since it's empty. The test
results were moved in r60693.

  • platform/mac-snowleopard/editing: Removed.
  • platform/mac-snowleopard/editing/spelling: Removed.
4:15 PM Changeset in webkit [61516] by jberlin@webkit.org
  • 4 edits in trunk/WebKit2

2010-06-20 Jessie Berlin <​jberlin@apple.com>

Reviewed by Dan Bernstein.

Add #if USE(PLATFORM_STRATEGIES) where WebPlatformStrategies is being used.

  • WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:
  • WebProcess/WebCoreSupport/WebPlatformStrategies.h:
  • WebProcess/WebProcess.cpp: (WebKit::WebProcess::WebProcess): Only initialize the web platform strategies if PLATFORM_STRATEGIES is being used.
3:51 PM Changeset in webkit [61515] by eric@webkit.org
  • 3 edits in trunk/WebKitTools

2010-06-20 Joseph Pecoraro <Joseph Pecoraro>

Reviewed by Adam Barth.

Sheriffbot: Should allow "r" in SVN_REVISION
​https://bugs.webkit.org/show_bug.cgi?id=40889

  • Scripts/webkitpy/tool/bot/irc_command.py: remove a leading "r" from SVN_REVISION if it exists
  • Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py: test an SVN_REVISION with a leading r.
3:32 PM Changeset in webkit [61514] by eric@webkit.org
  • 6 edits
    1 add in trunk/WebCore

2010-06-20 Nikita Vasilyev <​me@elv1s.ru>

Reviewed by Joseph Pecoraro.

Web Inspector: Auto-completion for CSS property names in Styles pane
​https://bugs.webkit.org/show_bug.cgi?id=17374

Added autocompletion for CSS properties. A suggestion for a property
shows when you type. You can also cycle through known property names
using the Up and Down arrow keys.

  • WebCore.gypi:
  • inspector/front-end/CSSCompletions.js: Added. (WebInspector.CSSCompletions): (WebInspector.CSSCompletions.startsWith): (WebInspector.CSSCompletions.firstStartsWith): (WebInspector.CSSCompletions._firstIndexOfPrefix): (WebInspector.CSSCompletions.next): (WebInspector.CSSCompletions.previous): (WebInspector.CSSCompletions._closest):
  • inspector/front-end/StylesSidebarPane.js: (WebInspector.StylePropertyTreeElement.prototype):
  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/inspector.html:
  • inspector/front-end/utilities.js: (Text.prototype.select): ():
2:30 PM Changeset in webkit [61513] by Joseph Pecoraro
  • 2 edits in trunk/WebKitTools

2010-06-20 Joseph Pecoraro <Joseph Pecoraro>

Reviewed by Dimitri Glazkov.

Python Tests Fail after r61508
​https://bugs.webkit.org/show_bug.cgi?id=40891

Test's regex list needed to be updated to match the new
regex list in the source code. Added new bots to the
example_buildbots list.

Regex list fixed in r61512. Updated bot list.

  • Scripts/webkitpy/common/net/buildbot_unittest.py:
2:14 PM Changeset in webkit [61512] by Dimitri Glazkov
  • 2 edits in trunk/WebKitTools

2010-06-20 Dimitri Glazkov <Dimitri Glazkov>

Unreviewed, build fix.

Tweak test regexp list to match the change in ​http://trac.webkit.org/changeset/61508.

  • Scripts/webkitpy/common/net/buildbot_unittest.py: Tweaked regexp.
2:00 PM Changeset in webkit [61511] by Dimitri Glazkov
  • 11 edits
    2 adds in trunk/WebCore

2010-06-14 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Darin Adler.

Introduce FormSubmission, the structure representing a form submission.
​https://bugs.webkit.org/show_bug.cgi?id=40084

No change in functionality, covered by existing tests.

  • GNUmakefile.am: Added FormSubmission.h/cpp.
  • WebCore.gypi: Ditto.
  • WebCore.pro: Ditto.
  • WebCore.vcproj/WebCore.vcproj: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::prepareFormSubmission): Renamed prepareFormData to prepareFormSubmission,

added code for populating a FormSubmission instance, moved the loop of accumulating text input
values into this functions (it belongs here logically).

(WebCore::HTMLFormElement::submit): Modified to use prepareFormSubmission.

  • html/HTMLFormElement.h:
  • loader/FormSubmission.cpp: Added.
  • loader/FormSubmission.h: Added.
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::submitForm): Modified to use FormSubmission. Stopped plumbing further to keep

the patch size down.

  • loader/FrameLoader.h: Modified submitForm signature.
1:53 PM Changeset in webkit [61510] by andersca@apple.com
  • 9 edits in trunk/WebKit/mac

2010-06-20 Anders Carlsson <​andersca@apple.com>

Reviewed by Sam Weinig.

Remove -[WebBasePluginPackage bundle]
​https://bugs.webkit.org/show_bug.cgi?id=40892

Add -[WebBasePluginPackage bundleIdentifier] and switch clients over to it.


Move the supportsSnapshotting method over to the plug-in package.


  • Plugins/Hosted/NetscapePluginHostManager.mm: (WebKit::NetscapePluginHostManager::hostForPackage):
  • Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView initWithFrame:pluginPackage:URL:baseURL:MIMEType:attributeKeys:attributeValues:loadManually:element:WebCore::]): (-[WebBaseNetscapePluginView supportsSnapshotting]):
  • Plugins/WebBasePluginPackage.h:
  • Plugins/WebBasePluginPackage.mm: (-[WebBasePluginPackage isQuickTimePlugIn]): (-[WebBasePluginPackage isJavaPlugIn]): (-[WebBasePluginPackage WebCore::]): Call bundleIdentifier directly instead of asking the bundle
  • Plugins/WebNetscapePluginPackage.h:
  • Plugins/WebNetscapePluginPackage.mm: (-[WebNetscapePluginPackage supportsSnapshotting]):
  • Plugins/WebNetscapePluginView.mm: (-[WebNetscapePluginView setAttributeKeys:andValues:]): (-[WebNetscapePluginView _createPlugin]):
  • Plugins/WebPluginDatabase.mm: (checkCandidate):
1:27 PM Changeset in webkit [61509] by andersca@apple.com
  • 7 edits in trunk/WebKit/mac

2010-06-20 Anders Carlsson <​andersca@apple.com>

Reviewed by Dan Bernstein.

Change some WebPluginDabase ivars to use WebCore::String instead of NSString.
​https://bugs.webkit.org/show_bug.cgi?id=40869


Re-land r61459, with extra null-checks in WebFrameLoaderClient.

  • Plugins/Hosted/NetscapePluginHostManager.mm: (WebKit::NetscapePluginHostManager::spawnPluginHost):
  • Plugins/WebBasePluginPackage.h:
  • Plugins/WebBasePluginPackage.mm: (-[WebBasePluginPackage initWithPath:]): (-[WebBasePluginPackage getPluginInfoFromPLists]): (-[WebBasePluginPackage dealloc]): (-[WebBasePluginPackage name]): (-[WebBasePluginPackage path]): (-[WebBasePluginPackage filename]): (-[WebBasePluginPackage pluginDescription]): (-[WebBasePluginPackage description]): (-[WebBasePluginPackage isJavaPlugIn]):
  • Plugins/WebNetscapePluginPackage.mm: (-[WebNetscapePluginPackage getPluginInfoFromResources]): (-[WebNetscapePluginPackage _tryLoad]): (-[WebNetscapePluginPackage _unloadWithShutdown:]):
  • Plugins/WebPluginPackage.mm: (-[WebPluginPackage load]):
  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::createPlugin):
11:58 AM Changeset in webkit [61508] by wsiegrist@apple.com
  • 1 edit in trunk/WebKitTools/Scripts/webkitpy/common/net/buildbot.py

2010-06-20 William Siegrist <​wsiegrist@apple.com>

Unreviewed. Make core builder regexp more specific so new Chromium test slaves do not get core builder status.

11:55 AM Changeset in webkit [61507] by Joseph Pecoraro
  • 2 edits in trunk/WebCore

2010-06-20 Joseph Pecoraro <Joseph Pecoraro>

Unreviewed rollout r61506, because it made 1 test crash.

Causes crash. Will approach the solution in a different way.

10:02 AM Changeset in webkit [61506] by Joseph Pecoraro
  • 2 edits in trunk/WebCore

2010-06-20 Joseph Pecoraro <Joseph Pecoraro>

Reviewed by Timothy Hatcher.

Web Inspector: Should Autocomplete Style Properties
​https://bugs.webkit.org/show_bug.cgi?id=38448

This Autocompletes style properties when in the console.

  • inspector/front-end/InjectedScript.js: (injectedScriptConstructor):
5:54 AM Changeset in webkit [61505] by robert@webkit.org
  • 5 edits in trunk

2010-06-20 Robert Hogan <​robert@webkit.org>

Reviewed by Simon Hausmann.

[Qt] NPP_SetWindow seems to not be called when TestNetscapePlugin is moved

​https://bugs.webkit.org/show_bug.cgi?id=36702

setNPWindowIfNeeded() is called on paint() in PluginViewQt, which doesn't
work for DRT. So call it if we are in DRT mode and the window geometry
has changed.

Unskips plugins/reentrant-update-widget-positions.html

  • platform/qt/Skipped:

2010-06-20 Robert Hogan <​robert@webkit.org>

Reviewed by Simon Hausmann.

[Qt] NPP_SetWindow seems to not be called when TestNetscapePlugin is moved

​https://bugs.webkit.org/show_bug.cgi?id=36702

setNPWindowIfNeeded() is called on paint() in PluginViewQt, which doesn't
work for DRT. So call it if we are in DRT mode and the window geometry
has changed.

Unskips plugins/reentrant-update-widget-positions.html

  • plugins/qt/PluginViewQt.cpp: (WebCore::PluginView::updatePluginWidget):
4:46 AM Changeset in webkit [61504] by eric@webkit.org
  • 3 edits in trunk/WebKit/qt

2010-06-20 Jedrzej Nowacki <​jedrzej.nowacki@nokia.com>

Reviewed by Simon Hausmann.

The QWebHistory regression fix.

After change r51629 and r61207 QWebHistory's function back(),
forward(), goToItem() got broken.

Use page->goToItem() instead of direct actions on the BackForwardList.

[Qt] REGRESSION(r61207): qwebhistory unit test hangs
​https://bugs.webkit.org/show_bug.cgi?id=40672

  • Api/qwebhistory.cpp: (QWebHistory::back): (QWebHistory::forward): (QWebHistory::goToItem):
  • tests/qwebhistory/tst_qwebhistory.cpp: (tst_QWebHistory::init): (tst_QWebHistory::back): (tst_QWebHistory::forward):

Jun 19, 2010:

8:37 PM Changeset in webkit [61503] by jschuh@chromium.org
  • 2 edits in trunk/WebKitTools

2010-06-19 Justin Schuh <​jschuh@chromium.org>

Unreviewed.

Adding myself to the committers list.

  • Scripts/webkitpy/common/config/committers.py:
6:03 PM Changeset in webkit [61502] by eric@webkit.org
  • 1 edit
    9 adds in trunk/LayoutTests

2010-06-19 Hayato Ito <​hayato@chromium.org>

Reviewed by Adam Barth.

Add tests for CSS 'orphans' and 'widows' properties.
All tests are expected to fail due to lack of implementations.

​https://bugs.webkit.org/show_bug.cgi?id=40821

  • printing/page-break-orphans-and-widows-expected.txt: Added.
  • printing/page-break-orphans-and-widows.html: Added.
  • printing/page-break-orphans-expected.txt: Added.
  • printing/page-break-orphans.html: Added.
  • printing/page-break-widows-expected.txt: Added.
  • printing/page-break-widows.html: Added.
  • printing/script-tests/page-break-orphans-and-widows.js: Added. (test):
  • printing/script-tests/page-break-orphans.js: Added. (test):
  • printing/script-tests/page-break-widows.js: Added. (test):
5:50 PM Changeset in webkit [61501] by eric@webkit.org
  • 1 edit
    9 adds in trunk/LayoutTests

2010-06-19 Hayato Ito <​hayato@chromium.org>

Reviewed by Adam Barth.

Add tests for 'page-break-{before,after}: avoid'.
All tests are expected to fail due to lack of implementations.

​https://bugs.webkit.org/show_bug.cgi?id=40814

  • printing/page-break-after-avoid-expected.txt: Added.
  • printing/page-break-after-avoid.html: Added.
  • printing/page-break-avoid-expected.txt: Added.
  • printing/page-break-avoid.html: Added.
  • printing/page-break-before-avoid-expected.txt: Added.
  • printing/page-break-before-avoid.html: Added.
  • printing/script-tests/page-break-after-avoid.js: Added. (test):
  • printing/script-tests/page-break-avoid.js: Added. (test):
  • printing/script-tests/page-break-before-avoid.js: Added. (test):
5:39 PM Changeset in webkit [61500] by weinig@apple.com
  • 23 edits in trunk

Fix for ​https://bugs.webkit.org/show_bug.cgi?id=40882
Add ability to have a WebProcess per WebContext.

Reviewed by Anders Carlsson.

WebKit2:

  • Move to a one-to-one correspondence of WebContexts to WebProcessProxies.
  • Add explicit shared contexts for general use.
  • Only non-shared contexts can use injected bundles.
  • UIProcess/API/C/WKContext.cpp:

(WKContextCreate):
(WKContextCreateWithInjectedBundlePath):
(WKContextGetSharedProcessContext):
(WKContextGetSharedThreadContext):

  • UIProcess/API/C/WKContext.h:
  • UIProcess/API/C/WKContextPrivate.h:

Change API for WKContext to no longer take a WKProcessModel type and instead
have explicit Create/Get functions for the different kind of contexts. Added
two shared contexts, one threaded, one process, and made the threaded on private
for now.

  • UIProcess/API/mac/WKView.mm:

(-[WKView initWithFrame:]):
Make WKViews that don't have an explicit context use the shared process
context by default.

  • UIProcess/Launcher/WebProcessLauncher.h:
  • UIProcess/Launcher/mac/WebProcessLauncher.mm:

(WebKit::launchWebProcess):

  • UIProcess/Launcher/win/WebProcessLauncher.cpp:

(WebKit::launchWebProcess):
Use a boolean argument to note whether we are using a thread or a process
instead of using the process model enum.

  • UIProcess/ProcessModel.h:

(WebKit::):
Convert to using explicit Shared modifier for shared contexts.

  • UIProcess/WebContext.cpp:

(WebKit::WebContext::sharedProcessContext):
(WebKit::WebContext::sharedThreadContext):
(WebKit::WebContext::ensureWebProcess):
(WebKit::WebContext::createWebPage):
(WebKit::WebContext::reviveIfNecessary):

  • UIProcess/WebContext.h:

(WebKit::WebContext::create):
(WebKit::WebContext::process):

  • UIProcess/WebPageNamespace.cpp:

(WebKit::WebPageNamespace::createWebPage):
(WebKit::WebPageNamespace::preferencesDidChange):
(WebKit::WebPageNamespace::getStatistics):

  • UIProcess/WebPageNamespace.h:

(WebKit::WebPageNamespace::process):
(WebKit::WebPageNamespace::reviveIfNecessary):
Move WebProcessProxy creation logic up into WebContext.

  • UIProcess/WebProcessManager.cpp:

(WebKit::WebProcessManager::getWebProcess):
(WebKit::WebProcessManager::processDidClose):

  • UIProcess/WebProcessManager.h:

Keep a map of WebContexts to WebProcessProxies in addition to the two
shared processes.

  • UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::create):
(WebKit::WebProcessProxy::WebProcessProxy):
(WebKit::WebProcessProxy::connect):
(WebKit::WebProcessProxy::didClose):

  • UIProcess/WebProcessProxy.h:

Store a WebContext instead of the process model.

  • mac/WebKit2.exp:

Add new functions.

WebKitTools:

Move to use new shared contexts API.

  • MiniBrowser/mac/AppDelegate.h:
  • MiniBrowser/mac/AppDelegate.m:

(-[BrowserAppDelegate init]):
(-[BrowserAppDelegate getCurrentPageNamespace]):
(-[BrowserAppDelegate validateMenuItem:]):
(-[BrowserAppDelegate _setProcessModel:]):
(-[BrowserAppDelegate setSharedProcessProcessModel:]):
(-[BrowserAppDelegate setSharedThreadProcessModel:]):

  • MiniBrowser/win/BrowserView.cpp:

(BrowserView::create):

5:38 PM Changeset in webkit [61499] by eric@webkit.org
  • 5 edits
    3 adds in trunk

2010-06-19 Tony Gentilcore <​tonyg@chromium.org>

Reviewed by Adam Barth.

Persist V8's ScriptData to the memory cache.
​https://bugs.webkit.org/show_bug.cgi?id=38661

When V8 ScriptData caching was originally submitted it causes crashes
in external scripts with high-byte characters. This new test crashes on
the original code, but now passes.

  • fast/js/parser-high-byte-character-expected.txt: Added.
  • fast/js/parser-high-byte-character.html: Added.
  • fast/js/script-tests/parser-high-byte-character.js: Added. (runTest):

2010-06-19 Tony Gentilcore <​tonyg@chromium.org>

Reviewed by Adam Barth.

Persist V8's ScriptData to the memory cache.
​https://bugs.webkit.org/show_bug.cgi?id=38661

This stores V8's ScriptData in the memory cache and also causes the
network platform layer to be notified of the available cacheable
metadata.

Chromium's morejs benchmark showed a ~7% improvement when this was
originally submitted (before it had to be rolled back).

Test: fast/js/parser-high-byte-character.html

  • bindings/v8/ScriptSourceCode.h: (WebCore::ScriptSourceCode::ScriptSourceCode): (WebCore::ScriptSourceCode::cachedScript):
  • bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::compileScript): (WebCore::V8Proxy::precompileScript): (WebCore::V8Proxy::evaluate):
  • bindings/v8/V8Proxy.h:
2:48 PM Changeset in webkit [61498] by Dimitri Glazkov
  • 2 edits in trunk/LayoutTests

2010-06-19 Dimitri Glazkov <Dimitri Glazkov>

Unreviewed, expectations update.

  • platform/chromium/test_expectations.txt: Tuned expectations according to the bot result runs.
1:39 PM Changeset in webkit [61497] by abarth@webkit.org
  • 1 edit
    4 adds in trunk/LayoutTests

2010-06-19 Tony Gentilcore <​tonyg@chromium.org>

Reviewed by Eric Seidel.

Add LayoutTest to ensure resources within <noscript> are not preloaded
​https://bugs.webkit.org/show_bug.cgi?id=40849

  • fast/preloader/noscript-expected.txt: Added.
  • fast/preloader/noscript.html: Added.
  • fast/preloader/resources/noscript-image1.png: Copied from BugsSite/data/mail.
  • fast/preloader/resources/noscript-image2.png: Copied from BugsSite/data/mail.
10:24 AM Changeset in webkit [61496] by eric@webkit.org
  • 1 edit
    4 adds in trunk/WebCore

2010-06-19 Kwang Yul Seo <​skyul@company100.net>

Reviewed by Kent Tamura.

[BREWMP] Port SocketStream
​https://bugs.webkit.org/show_bug.cgi?id=39671

Port SocketStream with BREW MP's ISocket interface.

  • platform/network/brew/SocketStreamError.h: Added. (WebCore::SocketStreamError::SocketStreamError):
  • platform/network/brew/SocketStreamHandle.h: Added. (WebCore::SocketStreamHandle::create):
  • platform/network/brew/SocketStreamHandleBrew.cpp: Added. (WebCore::socketStreamConnectCallback): (WebCore::getHostByNameCallback): (WebCore::socketReadableCallback): (WebCore::networkManager): (WebCore::SocketStreamHandlePrivate::SocketStreamHandlePrivate): (WebCore::SocketStreamHandlePrivate::~SocketStreamHandlePrivate): (WebCore::SocketStreamHandlePrivate::socketConnected): (WebCore::SocketStreamHandlePrivate::socketReadyRead): (WebCore::SocketStreamHandlePrivate::connect): (WebCore::SocketStreamHandlePrivate::send): (WebCore::SocketStreamHandlePrivate::close): (WebCore::SocketStreamHandlePrivate::socketClosed): (WebCore::SocketStreamHandlePrivate::socketError): (WebCore::SocketStreamHandle::SocketStreamHandle): (WebCore::SocketStreamHandle::~SocketStreamHandle): (WebCore::SocketStreamHandle::platformSend): (WebCore::SocketStreamHandle::platformClose): (WebCore::SocketStreamHandle::didReceiveAuthenticationChallenge): (WebCore::SocketStreamHandle::receivedCredential): (WebCore::SocketStreamHandle::receivedRequestToContinueWithoutCredential): (WebCore::SocketStreamHandle::receivedCancellation):
  • platform/network/brew/SocketStreamHandlePrivate.h: Added.
10:11 AM Changeset in webkit [61495] by eric@webkit.org
  • 4 edits in trunk/WebKit/chromium

2010-06-19 Jay Civelli <​jcivelli@chromium.org>

Reviewed by David Levin.

Adding a < operator to WebURLs so they can be used in std::maps.
​https://bugs.webkit.org/show_bug.cgi?id=40632

  • public/WebCString.h: (WebKit::operator<):
  • public/WebURL.h: (WebKit::operator<):
  • src/WebCString.cpp: (WebKit::WebCString::compare):
9:47 AM Changeset in webkit [61494] by eric@webkit.org
  • 6 edits in trunk

2010-06-19 Nikita Vasilyev <​me@elv1s.ru>

Reviewed by Pavel Feldman.

Web Inspector: subtitleElement.textContent is always empty. Use subtitleAsText method instead.
​https://bugs.webkit.org/show_bug.cgi?id=40420

  • inspector/elements-tests.js: (frontend_getSelectedElementStyles):

2010-06-19 Nikita Vasilyev <​me@elv1s.ru>

Reviewed by Pavel Feldman.

Web Inspector: Prevent from copying "filename.css" in Styles pane
​https://bugs.webkit.org/show_bug.cgi?id=40420

  • inspector/front-end/Section.js: (WebInspector.Section.prototype.set subtitle): (WebInspector.Section.prototype.get subtitleAsText):
  • inspector/front-end/StylesSidebarPane.js: (WebInspector.StylePropertiesSection):
  • inspector/front-end/inspector.css: (.styles-section .subtitle::before, .styles-section .subtitle a::before):
9:35 AM Changeset in webkit [61493] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-06-19 Alex Milowski <​alex@milowski.com>

Reviewed by Darin Adler.

A fix for a change in ​https://bugs.webkit.org/show_bug.cgi?id=39941
that caused a compile error in MathML.
​https://bugs.webkit.org/show_bug.cgi?id=40827

  • mathml/MathMLElement.cpp: (WebCore::MathMLElement::MathMLElement):
9:21 AM Changeset in webkit [61492] by eric@webkit.org
  • 6 edits
    3 copies
    3 adds in trunk/WebCore

2010-06-19 Kartikaya Gupta <​kagupta@rim.com>

Reviewed by Nikolas Zimmermann.

CPP bindings missing some APIs
​https://bugs.webkit.org/show_bug.cgi?id=40570

Add missing C++ DOM API bindings. Specifically:

  • NodeFilter callback support
  • Missing custom method implementations in HTMLCollection and HTMLOptionsCollection
  • Missing EventTarget static type-determination methods
  • Fix CPP binding generator to not generate d-ptrs for classes that extend EventTarget and just use the parent's d-ptr instead
  • Switch binding generator to use DOMWindow instead of AbstractView so that necessary W3C-defined methods (e.g. getComputedStyle) are accessible.
  • bindings/cpp/WebDOMDOMWindowCustom.cpp: Added. (WebDOMDOMWindow::addEventListener): (WebDOMDOMWindow::removeEventListener):
  • bindings/cpp/WebDOMEventTarget.cpp: (toWebKit):
  • bindings/cpp/WebDOMEventTarget.h:
  • bindings/cpp/WebDOMHTMLCollectionCustom.cpp: Added. (WebDOMHTMLCollection::item): (WebDOMHTMLCollection::namedItem):
  • bindings/cpp/WebDOMHTMLOptionsCollectionCustom.cpp: Added. (WebDOMHTMLOptionsCollection::length): (WebDOMHTMLOptionsCollection::setLength):
  • bindings/cpp/WebDOMNodeFilterCustom.cpp: Added. (WebDOMNodeFilter::acceptNode): (toWebKit):
  • bindings/cpp/WebNativeNodeFilterCondition.cpp: Added. (WebNativeNodeFilterCondition::WebNativeNodeFilterCondition): (WebNativeNodeFilterCondition::~WebNativeNodeFilterCondition): (WebNativeNodeFilterCondition::acceptNode):
  • bindings/cpp/WebNativeNodeFilterCondition.h: Added. (WebNativeNodeFilterCondition::create):
  • bindings/scripts/CodeGeneratorCPP.pm:
  • dom/NodeFilter.idl:
  • page/DOMWindow.idl:
8:22 AM Changeset in webkit [61491] by Dimitri Glazkov
  • 2 edits in trunk/LayoutTests

2010-06-19 Dimitri Glazkov <Dimitri Glazkov>

Unreviewed, expectations update

  • platform/chromium/test_expectations.txt: Added a flaky crash.
8:13 AM Changeset in webkit [61490] by tkent@chromium.org
  • 2 edits in trunk/WebKit/chromium

2010-06-19 Kent Tamura <​tkent@chromium.org>

Unreviewed. Build fix for r61488.

  • features.gypi: Define use_accelerated_compositing.
8:05 AM Changeset in webkit [61489] by eric@webkit.org
  • 2 edits in trunk/JavaScriptCore

2010-06-19 Kwang Yul Seo <​skyul@company100.net>

Reviewed by Darin Adler.

Include <string.h> in StringExtras.h
​https://bugs.webkit.org/show_bug.cgi?id=40808

Without string.h, RVCT 2.2 can't compile StringExtras.h.
It can't find strlen and strncmp.

  • wtf/StringExtras.h:
7:53 AM Changeset in webkit [61488] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-06-19 Vangelis Kokkevis <​vangelis@chromium.org>

Reviewed by Dimitri Glazkov.

[chromium] Adding a conditional gyp dependency for the WebCore target to
the gles2_c_lib which is required by the gpu compositor. The dependency will
only kick in if the accelerated_compositing path is enabled.
​https://bugs.webkit.org/show_bug.cgi?id=40801

  • WebCore.gyp/WebCore.gyp:
7:19 AM Changeset in webkit [61487] by eric@webkit.org
  • 10 edits in trunk

2010-06-19 Yael Aharon <​yael.aharon@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Platform plugin's multi-select does not take OptGroup into account
​https://bugs.webkit.org/show_bug.cgi?id=40718

In multi-select elements, optgroup elements are counted in the index calculation,
but in single-select they are not. Keep the same logic even when NO_LISTBOX_RENDERING
is enabled.
Added tests to the existing manual test, as testing this requires a special build, in which
NO_LISTBOX_RENDERING is enabled.

  • html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::listBoxSelectItem):
  • manual-tests/no-listbox-rendering.html:
  • rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::listBoxSelectItem):

2010-06-19 Yael Aharon <​yael.aharon@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Platform plugin's multi-select does not take OptGroup into account
​https://bugs.webkit.org/show_bug.cgi?id=40718

Make sure that SelectData is valid throughout the lifetime of the dialog.
This is mostly important for the Orbt based plugin.
Added virtual desctructors where they were missing.

  • Api/qwebkitplatformplugin.h: (QWebSelectData::~QWebSelectData): (QWebSelectMethod::~QWebSelectMethod): (QWebNotificationData::~QWebNotificationData):
  • WebCoreSupport/QtPlatformPlugin.cpp: (WebCore::SelectInputMethodWrapper::SelectInputMethodWrapper): (WebCore::SelectInputMethodWrapper::~SelectInputMethodWrapper): (WebCore::SelectInputMethodWrapper::show):
  • WebCoreSupport/QtPlatformPlugin.h:
  • examples/platformplugin/WebPlugin.cpp:
  • examples/platformplugin/qwebkitplatformplugin.h: (QWebSelectData::~QWebSelectData): (QWebSelectMethod::~QWebSelectMethod): (QWebNotificationData::~QWebNotificationData):
7:07 AM Changeset in webkit [61486] by eric@webkit.org
  • 7 edits in trunk

2010-06-19 Thomas Van Lenten <​thomasvl@chromium.org>

Reviewed by David Levin.

Warnings from -Wextra in a Chromium Mac build

  1. checks of unsigned >= 0
  2. enumeral and non-enumeral type in conditional expression
  3. copy ctors that don't call the super copy ctor or ctor No functionality change so no new tests.

​https://bugs.webkit.org/show_bug.cgi?id=40791

  • platform/chromium/ChromiumDataObject.cpp: (WebCore::ChromiumDataObject::ChromiumDataObject):
  • platform/chromium/ThemeChromiumMac.mm: (WebCore::updateStates):
  • rendering/RenderThemeChromiumMac.mm: (WebCore::RenderThemeChromiumMac::updateActiveState):

2010-06-19 Thomas Van Lenten <​thomasvl@chromium.org>

Reviewed by David Levin.

Warnings from -Wextra in a Chromium Mac build

  1. checks of unsigned >= 0
  2. enumeral and non-enumeral type in conditional expression
  3. copy ctors that don't call the super copy ctor or ctor

​https://bugs.webkit.org/show_bug.cgi?id=40791

  • src/AutoFillPopupMenuClient.cpp: (WebKit::AutoFillPopupMenuClient::getSuggestion): (WebKit::AutoFillPopupMenuClient::removeSuggestionAtIndex): (WebKit::AutoFillPopupMenuClient::valueChanged): (WebKit::AutoFillPopupMenuClient::selectionChanged):
  • src/AutocompletePopupMenuClient.cpp: (WebKit::AutocompletePopupMenuClient::getSuggestion): (WebKit::AutocompletePopupMenuClient::removeSuggestionAtIndex):
6:54 AM Changeset in webkit [61485] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-06-19 Ben Murdoch <​benm@google.com>

Reviewed by Pavel Feldman.

Fix build break with inspector disabled.
​https://bugs.webkit.org/show_bug.cgi?id=40790

Replace a #include with a forward declaration.

Fixing a build break so no new tests required.

  • inspector/InspectorController.h: Forward declare InspectorValue

rather than #including its header which has its content guarded
out.

6:32 AM Changeset in webkit [61484] by eric@webkit.org
  • 13 edits
    5 copies in trunk

2010-06-19 Zhe Su <​suzhe@chromium.org>

Reviewed by Darin Fisher.

[chromium]Refactor input method related APIs.
​https://bugs.webkit.org/show_bug.cgi?id=40608

No new tests are needed, because there is no new functionality.

  • page/FocusController.cpp: (WebCore::FocusController::setFocusedNode):

2010-06-19 Zhe Su <​suzhe@chromium.org>

Reviewed by Darin Fisher.

[chromium]Refactor input method related APIs.
​https://bugs.webkit.org/show_bug.cgi?id=40608

  • WebKit.gyp:
  • public/WebCompositionCommand.h:
  • public/WebCompositionUnderline.h: Added. (WebKit::WebCompositionUnderline::WebCompositionUnderline):
  • public/WebTextInputType.h: Added. (WebKit::):
  • public/WebViewClient.h:
  • public/WebWidget.h:
  • public/WebWidgetClient.h: (WebKit::WebWidgetClient::resetInputMethod):
  • src/CompositionUnderlineBuilder.h: Added. (WebKit::CompositionUnderlineBuilder::CompositionUnderlineBuilder):
  • src/CompositionUnderlineVectorBuilder.cpp: Added. (WebKit::CompositionUnderlineVectorBuilder::CompositionUnderlineVectorBuilder):
  • src/CompositionUnderlineVectorBuilder.h: Added.
  • src/EditorClientImpl.cpp: (WebKit::EditorClientImpl::setInputMethodState):
  • src/WebPopupMenuImpl.cpp: (WebKit::WebPopupMenuImpl::setComposition): (WebKit::WebPopupMenuImpl::confirmComposition): (WebKit::WebPopupMenuImpl::textInputType): (WebKit::WebPopupMenuImpl::caretOrSelectionBounds):
  • src/WebPopupMenuImpl.h:
  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::handleCompositionEvent): (WebKit::WebViewImpl::setComposition): (WebKit::WebViewImpl::confirmComposition): (WebKit::WebViewImpl::textInputType): (WebKit::WebViewImpl::caretOrSelectionBounds):
  • src/WebViewImpl.h:
6:05 AM Changeset in webkit [61483] by eric@webkit.org
  • 2 edits in trunk/WebKit/chromium

2010-06-19 Victoria Kirst <​vrk@google.com>

Reviewed by David Levin.

Modifying the WebMediaPlayer interface to be compatible with
a change in chrome.
This is a part 2 of 3 one-sided changes to chrome and WebKit. Chrome
has been updated, so this commit should NOT break chromium anymore,
nor should it cause any test failures.
​https://bugs.webkit.org/show_bug.cgi?id=39445

  • public/WebMediaPlayer.h: Changed buffered() to be non-const.
5:32 AM Changeset in webkit [61482] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-06-19 George Wright <​gwright@rim.com>

Reviewed by George Staikos.

​https://bugs.webkit.org/show_bug.cgi?id=40720

Make setWapInputFormat() public again as CSSStyleSelector.cpp calls this when WCSS is enabled.

  • html/HTMLInputElement.h: (WebCore::HTMLInputElement::data):
5:31 AM Changeset in webkit [61481] by tkent@chromium.org
  • 2 edits in trunk/LayoutTests

2010-06-19 Kent Tamura <​tkent@chromium.org>

Unreviewed, test expectation update.

  • platform/chromium/test_expectations.txt:
    • progress-element.html is essentially flaky on Mac.
    • use-clipped-hit.svg passes recently.
4:58 AM Changeset in webkit [61480] by eric@webkit.org
  • 2 edits in trunk/WebKit/qt

2010-06-19 No'am Rosenthal <​noam.rosenthal@nokia.com>

Reviewed by Simon Hausmann.

Bridge documentation: some snippets have the wrong indentation
​https://bugs.webkit.org/show_bug.cgi?id=40717

Fixed code snippets

  • docs/webkitsnippets/qtwebkit_bridge_snippets.cpp: (wrapInFunction):
4:43 AM Changeset in webkit [61479] by tkent@chromium.org
  • 3 edits
    53 adds in trunk/LayoutTests

2010-06-19 Kent Tamura <​tkent@chromium.org>

Unreviewed, test expectation update.

Add expectations for <meter> and <progress>.

  • platform/chromium-linux/fast/dom/HTMLMeterElement: Added.
  • platform/chromium-linux/fast/dom/HTMLMeterElement/meter-appearances-capacity-expected.checksum: Added.
  • platform/chromium-linux/fast/dom/HTMLMeterElement/meter-appearances-capacity-expected.png: Added.
  • platform/chromium-linux/fast/dom/HTMLMeterElement/meter-appearances-rating-relevancy-expected.checksum: Added.
  • platform/chromium-linux/fast/dom/HTMLMeterElement/meter-appearances-rating-relevancy-expected.png: Added.
  • platform/chromium-linux/fast/dom/HTMLMeterElement/meter-optimums-expected.checksum: Added.
  • platform/chromium-linux/fast/dom/HTMLMeterElement/meter-optimums-expected.png: Added.
  • platform/chromium-linux/fast/dom/HTMLMeterElement/meter-styles-changing-pseudo-expected.checksum: Added.
  • platform/chromium-linux/fast/dom/HTMLMeterElement/meter-styles-changing-pseudo-expected.png: Added.
  • platform/chromium-linux/fast/dom/HTMLMeterElement/meter-styles-expected.checksum: Added.
  • platform/chromium-linux/fast/dom/HTMLMeterElement/meter-styles-expected.png: Added.
  • platform/chromium-linux/fast/dom/HTMLProgressElement: Added.
  • platform/chromium-linux/fast/dom/HTMLProgressElement/progress-element-expected.checksum: Added.
  • platform/chromium-linux/fast/dom/HTMLProgressElement/progress-element-expected.png: Added.
  • platform/chromium-mac/fast/dom/HTMLMeterElement: Added.
  • platform/chromium-mac/fast/dom/HTMLMeterElement/meter-appearances-capacity-expected.checksum: Added.
  • platform/chromium-mac/fast/dom/HTMLMeterElement/meter-appearances-capacity-expected.png: Added.
  • platform/chromium-mac/fast/dom/HTMLMeterElement/meter-appearances-rating-relevancy-expected.checksum: Added.
  • platform/chromium-mac/fast/dom/HTMLMeterElement/meter-appearances-rating-relevancy-expected.png: Added.
  • platform/chromium-mac/fast/dom/HTMLMeterElement/meter-element-expected.checksum: Added.
  • platform/chromium-mac/fast/dom/HTMLMeterElement/meter-optimums-expected.checksum: Added.
  • platform/chromium-mac/fast/dom/HTMLMeterElement/meter-optimums-expected.png: Added.
  • platform/chromium-mac/fast/dom/HTMLMeterElement/meter-styles-changing-pseudo-expected.checksum: Added.
  • platform/chromium-mac/fast/dom/HTMLMeterElement/meter-styles-expected.checksum: Added.
  • platform/chromium-mac/fast/dom/HTMLProgressElement: Added.
  • platform/chromium-mac/fast/dom/HTMLProgressElement/progress-element-expected.checksum: Added.
  • platform/chromium-mac/fast/dom/HTMLProgressElement/progress-element-expected.png: Added.
  • platform/chromium-mac/fast/dom/HTMLProgressElement/progress-element-expected.txt: Added.
  • platform/chromium-win/fast/dom/HTMLMeterElement: Added.
  • platform/chromium-win/fast/dom/HTMLMeterElement/meter-appearances-capacity-expected.checksum: Added.
  • platform/chromium-win/fast/dom/HTMLMeterElement/meter-appearances-capacity-expected.png: Added.
  • platform/chromium-win/fast/dom/HTMLMeterElement/meter-appearances-capacity-expected.txt: Added.
  • platform/chromium-win/fast/dom/HTMLMeterElement/meter-appearances-rating-relevancy-expected.checksum: Added.
  • platform/chromium-win/fast/dom/HTMLMeterElement/meter-appearances-rating-relevancy-expected.png: Added.
  • platform/chromium-win/fast/dom/HTMLMeterElement/meter-appearances-rating-relevancy-expected.txt: Added.
  • platform/chromium-win/fast/dom/HTMLMeterElement/meter-element-expected.checksum: Added.
  • platform/chromium-win/fast/dom/HTMLMeterElement/meter-element-expected.png: Added.
  • platform/chromium-win/fast/dom/HTMLMeterElement/meter-element-expected.txt: Added.
  • platform/chromium-win/fast/dom/HTMLMeterElement/meter-optimums-expected.checksum: Added.
  • platform/chromium-win/fast/dom/HTMLMeterElement/meter-optimums-expected.png: Added.
  • platform/chromium-win/fast/dom/HTMLMeterElement/meter-optimums-expected.txt: Added.
  • platform/chromium-win/fast/dom/HTMLMeterElement/meter-styles-changing-pseudo-expected.checksum: Added.
  • platform/chromium-win/fast/dom/HTMLMeterElement/meter-styles-changing-pseudo-expected.png: Added.
  • platform/chromium-win/fast/dom/HTMLMeterElement/meter-styles-changing-pseudo-expected.txt: Added.
  • platform/chromium-win/fast/dom/HTMLMeterElement/meter-styles-expected.checksum: Added.
  • platform/chromium-win/fast/dom/HTMLMeterElement/meter-styles-expected.png: Added.
  • platform/chromium-win/fast/dom/HTMLMeterElement/meter-styles-expected.txt: Added.
  • platform/chromium-win/fast/dom/HTMLProgressElement: Added.
  • platform/chromium-win/fast/dom/HTMLProgressElement/progress-bar-value-pseudo-element-expected.checksum: Added.
  • platform/chromium-win/fast/dom/HTMLProgressElement/progress-bar-value-pseudo-element-expected.png: Added.
  • platform/chromium-win/fast/dom/HTMLProgressElement/progress-element-expected.checksum: Added.
  • platform/chromium-win/fast/dom/HTMLProgressElement/progress-element-expected.png: Added.
  • platform/chromium-win/fast/dom/HTMLProgressElement/progress-element-expected.txt: Added.
  • platform/chromium/fast/dom/prototype-inheritance-expected.txt:
  • platform/chromium/test_expectations.txt:
4:02 AM Changeset in webkit [61478] by robert@webkit.org
  • 14 edits
    3 adds in trunk

2010-06-02 Robert Hogan <​robert@webkit.org>

Reviewed by Adam Barth.

[Qt] Support evaluateScriptInIsolatedWorld()

​https://bugs.webkit.org/show_bug.cgi?id=40079

This initial implementation passes 25 of the 27 tests in
http/tests/isolatedworld as well as four others that use the
call in LayoutTests.

Further work/investigation is required to support the two
remaining tests.

  • platform/qt/Skipped:

2010-06-02 Robert Hogan <​robert@webkit.org>

Reviewed by Adam Barth.

[Qt] Support evaluateScriptInIsolatedWorld()

​https://bugs.webkit.org/show_bug.cgi?id=40079

getOwnPropertyNames() crashes if PropertyNameArray is size 0. This change allows
http/tests/world-reuse.html and didClearWindowObject.html to fail instead of crash.

  • WebCore.pro: Add qwebscriptworld.*
  • bridge/qt/qt_runtime.cpp: (JSC::Bindings::convertValueToQVariant):

2010-06-02 Robert Hogan <​robert@webkit.org>

Reviewed by Adam Barth.

[Qt] Support evaluateScriptInIsolatedWorld()

​https://bugs.webkit.org/show_bug.cgi?id=40079

  • Api/headers.pri:
  • Api/qwebframe.cpp: (QWebFrame::evaluateScriptInIsolatedWorld):
  • Api/qwebframe.h:
  • Api/qwebscriptworld.cpp: Added. (QWebScriptWorld::QWebScriptWorld): (QWebScriptWorld::world): (QWebScriptWorld::~QWebScriptWorld):
  • Api/qwebscriptworld.h: Added.
  • Api/qwebscriptworld_p.h: Added. (QWebScriptWorldPrivate::QWebScriptWorldPrivate): (QWebScriptWorldPrivate::~QWebScriptWorldPrivate):
  • WebCoreSupport/DumpRenderTreeSupportQt.cpp:
  • WebCoreSupport/DumpRenderTreeSupportQt.h:

2010-06-02 Robert Hogan <​robert@webkit.org>

Reviewed by Adam Barth.

[Qt] Support evaluateScriptInIsolatedWorld()

​https://bugs.webkit.org/show_bug.cgi?id=40079

  • DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::evaluateScriptInIsolatedWorld):
  • DumpRenderTree/qt/LayoutTestControllerQt.h:
3:18 AM Changeset in webkit [61477] by tkent@chromium.org
  • 2 edits
    5 adds in trunk/LayoutTests

2010-06-19 Kent Tamura <​tkent@chromium.org>

Unreviewed, test expectation update.

Rebaseline for tetDecoration.svg.

  • platform/chromium-linux/svg/batik/text/textDecoration-expected.checksum: Added.
  • platform/chromium-linux/svg/batik/text/textDecoration-expected.png: Added.
  • platform/chromium-win/svg/batik/text/textDecoration-expected.checksum: Added.
  • platform/chromium-win/svg/batik/text/textDecoration-expected.png: Added.
  • platform/chromium-win/svg/batik/text/textDecoration-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
3:04 AM Changeset in webkit [61476] by eric@webkit.org
  • 2 edits in trunk/WebKit/qt

2010-06-19 Olivier Goffart <​olivier.goffart@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Compilation in QWebPagePrivate::timerEvent with clang
​https://bugs.webkit.org/show_bug.cgi?id=40714

QObject::timerEvent is protected and cannot be accessed by QWebPagePrivate
with clang

QWebPagePrivate is a friend of QWebPage and then should have access to
all protected members of parents of QWebPage, including QObject.
But the clang team do not want to conform to this aspect of the specification
because "It is either a drafting error or a horrible mistake."
See ​http://llvm.org/bugs/show_bug.cgi?id=6840

This change is better because QWebPage does not reimplement the timerEvent
(QWebPagePrivate::timerEvent is called from QWebPage::event)
So customers that would reimplement their own timerEvent
for their own timer now get a chance to catch them.

  • Api/qwebpage.cpp: (QWebPagePrivate::timerEvent):
2:45 AM Changeset in webkit [61475] by eric@webkit.org
  • 2 edits in trunk/JavaScriptCore

2010-06-19 Thiago Macieira <​thiago.macieira@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

Don't use attribute((may_alias)) with the Intel compiler,
as it doesn't understand it.

  • wtf/Vector.h:
2:23 AM Changeset in webkit [61474] by eric@webkit.org
  • 2 edits in trunk/JavaScriptCore

2010-06-19 Thiago Macieira <​thiago.macieira@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

Fix compilation with the Intel C++ compiler (11.1.072).

Like RVCT, label pointers must be void*, not const void*.

  • bytecode/Opcode.h:
2:09 AM Changeset in webkit [61473] by eric@webkit.org
  • 2 edits in trunk/JavaScriptCore

2010-06-19 Thiago Macieira <​thiago.macieira@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

Add the WTF_COMPILER_INTEL for when the Intel compiler is used
for building. Usually, the Intel compiler masquerades as
another compiler in the system and gets away with it, but some
times specific fixes are required (such as when using language
extensions).

  • wtf/Platform.h:
1:45 AM Changeset in webkit [61472] by eric@webkit.org
  • 2 edits in trunk/WebKit/qt

2010-06-19 Mirko Damiani <​mirko@develer.com>

Reviewed by Simon Hausmann.

[Qt] Avoid truncation of zoom factor in QWebFrame's print function.
​https://bugs.webkit.org/show_bug.cgi?id=40662

The zoom factor is a qreal number but its value is truncated to an
integer. So a cast to qreal is needed to avoid this issue.

  • Api/qwebframe.cpp: (QWebFrame::print):
1:31 AM Changeset in webkit [61471] by eric@webkit.org
  • 5 edits in trunk

2010-06-19 Zhenyao Mo <​zmo@google.com>

Reviewed by Dimitri Glazkov.

fast/canvas/webgl/get-active-test.html failed in Chrome Mac
​https://bugs.webkit.org/show_bug.cgi?id=40496

  • fast/canvas/webgl/get-active-test-expected.txt: Test of two contexts and two programs, also test the uniform array name ends with "[0]".
  • fast/canvas/webgl/script-tests/get-active-test.js: Ditto.

2010-06-19 Zhenyao Mo <​zmo@google.com>

Reviewed by Dimitri Glazkov.

fast/canvas/webgl/get-active-test.html failed in Chrome Mac
​https://bugs.webkit.org/show_bug.cgi?id=40496

  • src/WebGraphicsContext3DDefaultImpl.cpp: Call makeContextCurrent(). (WebKit::WebGraphicsContext3DDefaultImpl::getActiveAttrib): (WebKit::WebGraphicsContext3DDefaultImpl::getActiveUniform): (WebKit::WebGraphicsContext3DDefaultImpl::readPixels):
12:26 AM Changeset in webkit [61470] by eric@webkit.org
  • 6 edits in trunk/WebCore

2010-06-19 Tony Gentilcore <​tonyg@chromium.org>

Reviewed by Eric Seidel.

Some very minor cleanups for HTML5 Parser
​https://bugs.webkit.org/show_bug.cgi?id=40638

No new tests because no new functionality.

  • html/HTML5DocumentParser.cpp: (WebCore::): Make ctor explicit.
  • html/HTML5DocumentParser.h: (WebCore::HTML5DocumentParser::InsertionPointRecord::InsertionPointRecord): Make ctor explicit.
  • html/HTML5Lexer.cpp: (WebCore::HTMLNames::isEndTagBufferingState): Use switch to generate an efficient table with single branch.
  • html/HTML5Token.h: (WebCore::HTML5Token::forceQuirks): Add const.
  • html/HTML5TreeBuilder.h: (WebCore::HTML5TreeBuilder::isPaused): Add const.
12:12 AM Changeset in webkit [61469] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2010-06-18 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Darin Adler.

Add three more non-core Chromium builders to start testing DumpRenderTree.
​https://bugs.webkit.org/show_bug.cgi?id=40335

  • BuildSlaveSupport/build.webkit.org-config/config.json: Added 3 builders.
12:08 AM Changeset in webkit [61468] by aa@chromium.org
  • 2 edits in trunk

2010-06-18 Aaron Boodman <​aa@chromium.org>

Remove WebKit::WebDocument::isXHTMLDocument.
​https://bugs.webkit.org/show_bug.cgi?id=40815

  • dom/Document.h: remove isXHTML() getter.

2010-06-18 Aaron Boodman <​aa@chromium.org>

Remove WebKit::WebDocument::isXHTMLDocument.
​https://bugs.webkit.org/show_bug.cgi?id=40815

  • public/WebDocument.h: Remove isXHTMLDocument().
  • src/WebDocument.cpp: Ditto.
12:05 AM Changeset in webkit [61467] by aa@chromium.org
  • 5 edits in trunk

2010-06-19 Aaron Boodman <​aa@chromium.org>

Unreviewed, rolling out r61466.
​http://trac.webkit.org/changeset/61466
​https://bugs.webkit.org/show_bug.cgi?id=40816

Landed wrong change

  • bindings/v8/V8DOMWindowShell.cpp: (WebCore::V8DOMWindowShell::initContextIfNeeded):
  • bindings/v8/V8DOMWindowShell.h:

2010-06-19 Aaron Boodman <​aa@chromium.org>

Unreviewed, rolling out r61466.
​http://trac.webkit.org/changeset/61466
​https://bugs.webkit.org/show_bug.cgi?id=40816

Landed wrong change

  • src/WebKit.cpp: (WebKit::shutdown):
Note: See TracTimeline for information about the timeline view.