⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Jun 21, 2010:

11:25 PM Changeset in webkit [61602] by abarth@webkit.org
  • 3 edits
    2 adds in trunk

2010-06-21 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

document.write from BeforeLoad should not assert
​https://bugs.webkit.org/show_bug.cgi?id=40971

Test what happens when we document.write from a beforeload event.
Notice that the order is wrong. I'll fix that in a followup patch.

  • fast/tokenizer/write-before-load-expected.txt: Added.
  • fast/tokenizer/write-before-load.html: Added.

2010-06-21 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

document.write from BeforeLoad should not assert
​https://bugs.webkit.org/show_bug.cgi?id=40971

We're setting the parse blocking script too early. It's not actually
blocking parsing yet.

Test: fast/tokenizer/write-before-load.html

  • html/HTML5ScriptRunner.cpp: (WebCore::HTML5ScriptRunner::requestScript):
9:59 PM Changeset in webkit [61601] by dimich@chromium.org
  • 3 edits in trunk/LayoutTests

Unreviewed, skip new modal tests on Tiger and update expected result for Chromium.

  • platform/chromium/fast/dom/prototype-inheritance-expected.txt:
  • platform/mac-tiger/Skipped:
9:41 PM Changeset in webkit [61600] by dimich@chromium.org
  • 3 edits in trunk/LayoutTests

Unreviewed, fixing qt-specific expected results for r61599

  • platform/qt/fast/dom/Window/window-properties-expected.txt:
  • platform/qt/fast/dom/prototype-inheritance-expected.txt:
9:24 PM Changeset in webkit [61599] by dimich@chromium.org
  • 54 edits
    6 adds
    7 deletes in trunk

DumpRenderTree should allow tests with modal dialogs
​https://bugs.webkit.org/show_bug.cgi?id=35350

Patch by Prasad Tammana <​prasadt@chromium.org> on 2010-06-21
Reviewed by Darin Adler, Dmitry Titov.

WebKitTools:

  • DumpRenderTree/LayoutTestController.cpp:

(abortModalCallback):
(LayoutTestController::staticFunctions):

  • DumpRenderTree/LayoutTestController.h:
  • DumpRenderTree/mac/LayoutTestControllerMac.mm:

(LayoutTestController::abortModal):
Add abortModal method to LayoutTestController and make it available from script.

  • DumpRenderTree/mac/UIDelegate.mm: Add support for showModalDialog.

(-[UIDelegate modalWindowWillClose:]): Observer for NSWindowWillCloseNotifications to call
abortModal from when modal window closes.
(-[UIDelegate webViewRunModal:]): Delegate method for showModalDialog to run the modal loop.

LayoutTests:

Added a new test show-modal-dialog.html to harness tests to verify that showModalDialog works.

Added a new test, show-modal-dialog-onblur-onfocus.html, that takes advantage of the showModalDialog
functionality added to UIDelegate.mm. The test is only enabled on mac for now. This test will catch
regressions on the bug fix for ​https://bugs.webkit.org/show_bug.cgi?id=33962.

Support for showModalDialog affected the expected output for many tests that operate under the assumption
that the method is undefined. Modified the tests accordingly, in some cases disabled showModalDialog (not
currently tested anyway. Opened a bug to add showModalDialog specific tests where appropriate - Bug# 39897.

  • fast/dom/Window/window-function-frame-getter-precedence-expected.txt:
  • fast/dom/Window/window-function-frame-getter-precedence.html:
  • fast/dom/Window/window-function-name-getter-precedence-expected.txt:
  • fast/dom/Window/window-function-name-getter-precedence.html:
  • fast/dom/Window/window-lookup-precedence-expected.txt:
  • fast/dom/Window/window-lookup-precedence.html:
  • fast/dom/Window/window-properties-expected.txt:
  • fast/dom/Window/window-properties.html:
  • fast/dom/script-tests/prototype-inheritance.js:

Tweak tests so that showModalDialog part gets exercised only if its defined to keep output consistent across platforms.
Where its not possible, skip the test for showModalDialog, which is not currently exercised anyway.

  • fast/events/resources/modal-dialog.html: Added.
  • fast/events/show-modal-dialog-onblur-onfocus-expected.txt: Added.
  • fast/events/show-modal-dialog-onblur-onfocus.html: Added.
  • fast/harness/resources/modal-dialog.html: Added.
  • fast/harness/show-modal-dialog-expected.txt: Added.
  • fast/harness/show-modal-dialog.html: Added.

New tests that take advantage of showModalDialog in DRT.

  • fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.1_T1-expected.txt:
  • fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.1_T10-expected.txt:
  • fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.1_T11-expected.txt:
  • fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.1_T2-expected.txt:
  • fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.1_T3-expected.txt:
  • fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.1_T4-expected.txt:
  • fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.1_T5-expected.txt:
  • fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.1_T6-expected.txt:
  • fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.1_T7-expected.txt:
  • fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.1_T8-expected.txt:
  • fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.1_T9-expected.txt:
  • fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.2_T1-expected.txt:
  • fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.2_T10-expected.txt:
  • fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.2_T11-expected.txt:
  • fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.2_T2-expected.txt:
  • fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.2_T3-expected.txt:
  • fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.2_T4-expected.txt:
  • fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.2_T5-expected.txt:
  • fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.2_T6-expected.txt:
  • fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.2_T7-expected.txt:
  • fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.2_T8-expected.txt:
  • fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.2_T9-expected.txt:

Update the expected output to reflect the fact that these tests pass now. Skip the tests on gtk, qt and win. They were all expected
to fail anyway. So no coverage lost.

  • http/tests/security/cross-frame-access-call-expected.txt:
  • http/tests/security/cross-frame-access-call.html:
  • http/tests/security/cross-frame-access-get-expected.txt:
  • http/tests/security/cross-frame-access-get.html:
  • http/tests/security/cross-frame-access-put-expected.txt:

Skip showModalDialog to make test pass for all platforms. Added a FIXME with bug # to add a test specifically for showModalDialog.

  • http/tests/security/resources/cross-frame-iframe-for-put-test.html:
  • platform/chromium-mac/fast/dom/Window/window-function-frame-getter-precedence-expected.txt: Removed.
  • platform/chromium-mac/fast/dom/Window/window-function-name-getter-precedence-expected.txt: Removed.
  • platform/chromium-mac/http/tests/security/cross-frame-access-get-expected.txt:
  • platform/chromium-win/fast/dom/Window/window-function-frame-getter-precedence-expected.txt: Removed.
  • platform/chromium-win/fast/dom/Window/window-function-name-getter-precedence-expected.txt: Removed.
  • platform/chromium-win/fast/dom/Window/window-lookup-precedence-expected.txt:
  • platform/chromium-win/http/tests/security/cross-frame-access-get-expected.txt:
  • platform/chromium-win/http/tests/security/cross-frame-access-put-expected.txt:
  • platform/chromium/http/tests/security/cross-frame-access-call-expected.txt:
  • platform/chromium/test_expectations.txt:
  • platform/gtk/Skipped:
  • platform/qt/Skipped:
  • platform/qt/fast/dom/Window/window-function-frame-getter-precedence-expected.txt: Removed.
  • platform/qt/fast/dom/Window/window-function-name-getter-precedence-expected.txt: Removed.
  • platform/qt/fast/dom/Window/window-lookup-precedence-expected.txt: Removed.

Updaate expected output to reflect test changes. Removed some platform specific files where the only reason they're different is
because of showModalDialog.

  • platform/qt/http/tests/security/cross-frame-access-call-expected.txt:
  • platform/qt/http/tests/security/cross-frame-access-get-expected.txt:
  • platform/win/Skipped:

Skip failing tests. Note that there is no test functionality lost. These are either new tests or tests that were dysfunctional anyway
in the absence of showModalDialog in DRT.

7:28 PM Changeset in webkit [61598] by morrita@google.com
  • 4 edits
    2 adds in trunk/WebKit/chromium

2010-06-21 MORITA Hajime <​morrita@google.com>

Reviewed by Darin Fisher.

[Chromium] Dragging outside the frame immediately causes page to scroll
​http://webkit.org/b/40461

This is regression that was introduced at ​http://webkit.org/b/39725.

There are 2 problems:

  1. It starts auto-scrolling immediately. We should have some delay.
  2. The scroll continues even after a mouse cursor goes outside a frame. The scroll should be stopped when the curosr has left.

This change introduced DragScrollTimer to handle 1.
At the same time, it fixed DragScrollTimer::scrollDistanceFor() to
handle 2, We now stop scrolling when the cursor gone.

  • WebKit.gyp:
  • src/DragScrollTimer.cpp: Added. (WebKit::distanceToRect): (WebKit::DragScrollTimer::DragScrollTimer): (WebKit::DragScrollTimer::~DragScrollTimer): (WebKit::DragScrollTimer::stop): (WebKit::DragScrollTimer::scroll): (WebKit::DragScrollTimer::update): (WebKit::DragScrollTimer::triggerScroll): (WebKit::DragScrollTimer::scrollDistanceFor):
  • src/DragScrollTimer.h: Added. (WebKit::DragScrollTimer::fired): (WebKit::DragScrollTimer::shouldScroll):
  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::WebViewImpl): (WebKit::WebViewImpl::dragSourceEndedAt): (WebKit::WebViewImpl::dragSourceMovedTo): (WebKit::WebViewImpl::dragTargetDrop): (WebKit::WebViewImpl::dragTargetDragEnterOrOver):
  • src/WebViewImpl.h:
6:36 PM Changeset in webkit [61597] by Chris Fleizach
  • 2 edits in trunk/WebCore

No review. QT build fix again.

AX: VoiceOver does not announce WAI-ARIA state change of aria-expanded
​https://bugs.webkit.org/show_bug.cgi?id=40927

  • accessibility/AXObjectCache.h:

(WebCore::AXObjectCache::postNotification):

6:27 PM Changeset in webkit [61596] by Chris Fleizach
  • 2 edits in trunk/WebCore

No review. QT build fix.

AX: VoiceOver does not announce WAI-ARIA state change of aria-expanded
​https://bugs.webkit.org/show_bug.cgi?id=40927

  • accessibility/AXObjectCache.h:

(WebCore::AXObjectCache::postNotification):

6:07 PM Changeset in webkit [61595] by Chris Fleizach
  • 11 edits
    2 adds in trunk

AX: VoiceOver does not announce WAI-ARIA state change of aria-expanded
​https://bugs.webkit.org/show_bug.cgi?id=40927

Reviewed by Beth Dakin.

WebCore:

Test: platform/mac/accessibility/aria-expanded-notifications.html

  • accessibility/AXObjectCache.cpp:

(WebCore::AXObjectCache::handleAriaExpandedChange):

  • accessibility/AXObjectCache.h:

(WebCore::AXObjectCache::handleAriaExpandedChange):

  • accessibility/AccessibilityObject.h:

(WebCore::AccessibilityObject::handleAriaExpandedChanged):

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::handleAriaExpandedChanged):

  • accessibility/AccessibilityRenderObject.h:
  • accessibility/mac/AXObjectCacheMac.mm:

(WebCore::AXObjectCache::postPlatformNotification):

  • dom/Element.cpp:

(WebCore::Element::updateAfterAttributeChanged):

LayoutTests:

  • platform/mac-leopard/Skipped:
  • platform/mac-tiger/Skipped:
  • platform/mac/accessibility/aria-expanded-notifications-expected.txt: Added.
  • platform/mac/accessibility/aria-expanded-notifications.html: Added.
5:33 PM Changeset in webkit [61594] by andersca@apple.com
  • 2 edits in trunk/WebKit2

2010-06-21 Anders Carlsson <​andersca@apple.com>

Reviewed by Sam Weinig.

Support reading plug-in info from Carbon resources
​https://bugs.webkit.org/show_bug.cgi?id=40959

  • UIProcess/Plugins/mac/PluginInfoStoreMac.mm: (WebKit::ResourceMap::ResourceMap): (WebKit::ResourceMap::~ResourceMap): (WebKit::ResourceMap::isValid): (WebKit::getStringListResource): (WebKit::getPluginInfoFromCarbonResources): (WebKit::PluginInfoStore::getPluginInfo):
5:23 PM Changeset in webkit [61593] by andersca@apple.com
  • 2 edits in trunk/WebKit2

Build fix.

  • UIProcess/Plugins/mac/PluginInfoStoreMac.mm:

(WebKit::PluginInfoStore::getPluginInfo):

5:07 PM Changeset in webkit [61592] by andersca@apple.com
  • 2 edits in trunk/WebKit/mac

Fix an off-by-one bug I introduced.

Reviewed by Sam Weinig.

  • Plugins/WebNetscapePluginPackage.mm:

(-[WebNetscapePluginPackage getPluginInfoFromResources]):

5:00 PM Changeset in webkit [61591] by andersca@apple.com
  • 4 edits
    1 add in trunk/WebKit2

2010-06-21 Anders Carlsson <​andersca@apple.com>

Reviewed by Sam Weinig.

Have PluginInfoStoreMac actually get plug-in info and populate the plug-in list
​https://bugs.webkit.org/show_bug.cgi?id=40957

  • UIProcess/Plugins/PluginInfoStore.cpp: (WebKit::PluginInfoStore::loadPluginsIfNecessary): (WebKit::PluginInfoStore::loadPluginsInDirectory): (WebKit::PluginInfoStore::loadPlugin): (WebKit::PluginInfoStore::getPlugins):
  • UIProcess/Plugins/PluginInfoStore.h:
  • UIProcess/Plugins/mac/PluginInfoStoreMac.mm: Added. (WebKit::PluginInfoStore::pluginDirectories): (WebKit::PluginInfoStore::pluginPathsInDirectory): (WebKit::getPluginArchitecture): (WebKit::getPluginInfoFromPropertyLists): (WebKit::PluginInfoStore::getPluginInfo): (WebKit::PluginInfoStore::shouldUsePlugin):
  • WebKit2.xcodeproj/project.pbxproj:
4:42 PM Changeset in webkit [61590] by weinig@apple.com
  • 5 edits in trunk/WebKitLibraries

Update WebKitSystemInterface.

Reviewed by Anders Carlsson.

  • WebKitSystemInterface.h:
  • libWebKitSystemInterfaceLeopard.a:
  • libWebKitSystemInterfaceSnowLeopard.a:
  • libWebKitSystemInterfaceTiger.a:
4:29 PM Changeset in webkit [61589] by Simon Fraser
  • 8 edits
    8 moves in trunk/WebKit2

2010-06-21 Simon Fraser <Simon Fraser>

Reviewed by Anders Carlsson.

Rename DrawingAreaProxyUpdateChunk to ChunkedUpdateDrawingArea
​https://bugs.webkit.org/show_bug.cgi?id=40948

Rename UIProcess version of DrawingAreaUpdateChunk to ChunkedUpdateDrawingAreaProxy,
and rename the Mac/Win versions of the various DrawingArea files too.

Also rename the DrawingAreaUpdateChunkType enum to ChunkedUpdateDrawingAreaType.

4:17 PM Changeset in webkit [61588] by oliver@apple.com
  • 11 edits in trunk/JavaScriptCore

2010-06-21 Oliver Hunt <​oliver@apple.com>

Reviewed by Geoffrey Garen.

Make JSC more resilient in the face of parse failures
​https://bugs.webkit.org/show_bug.cgi?id=40951

A number of recent bugs have occurred due to issues like miscounting
BOMs, etc which lead to interesting crashes later on. Adding this
logic hardens JSC in the face of these errors, and has no impact on
performance (32bit jit actually gets 0.7% faster but I put that down
to cache effects).

  • bytecode/CodeBlock.cpp: (JSC::CodeBlock::reparseForExceptionInfoIfNecessary): (JSC::CodeBlock::lineNumberForBytecodeOffset): (JSC::CodeBlock::expressionRangeForBytecodeOffset): (JSC::CodeBlock::getByIdExceptionInfoForBytecodeOffset):
  • bytecode/CodeBlock.h: (JSC::CodeBlock::bytecodeOffset):
  • interpreter/Interpreter.cpp: (JSC::Interpreter::execute): (JSC::Interpreter::executeCall): (JSC::Interpreter::executeConstruct): (JSC::Interpreter::prepareForRepeatCall): (JSC::Interpreter::privateExecute):
  • jit/JITOpcodes.cpp: (JSC::JIT::privateCompileCTIMachineTrampolines):
  • jit/JITOpcodes32_64.cpp: (JSC::JIT::privateCompileCTIMachineTrampolines):
  • jit/JITStubs.cpp: (JSC::DEFINE_STUB_FUNCTION):
  • runtime/ArrayPrototype.cpp: (JSC::isNumericCompareFunction):
  • runtime/Executable.cpp: (JSC::FunctionExecutable::compileForCall): (JSC::FunctionExecutable::compileForConstruct): (JSC::FunctionExecutable::generateJITCodeForCall): (JSC::FunctionExecutable::generateJITCodeForConstruct): (JSC::FunctionExecutable::reparseExceptionInfo): (JSC::EvalExecutable::reparseExceptionInfo):
  • runtime/Executable.h: (JSC::FunctionExecutable::bytecodeForCall): (JSC::FunctionExecutable::bytecodeForConstruct):
  • runtime/JSGlobalData.cpp: (JSC::JSGlobalData::numericCompareFunction):
4:00 PM Changeset in webkit [61587] by andersca@apple.com
  • 6 edits
    4 adds in trunk/WebKit2

2010-06-21 Anders Carlsson <​andersca@apple.com>

Reviewed by Sam Weinig.

Add PluginInfoStore class
​https://bugs.webkit.org/show_bug.cgi?id=40949

  • Shared/WebPreferencesStore.cpp: (WebKit::WebPreferencesStore::WebPreferencesStore):
  • Shared/WebPreferencesStore.h: (WebKit::WebPreferencesStore::encode): (WebKit::WebPreferencesStore::decode): Add plugInsEnabled to the preferences store.
  • UIProcess/Plugins: Added.
  • UIProcess/Plugins/PluginInfoStore.cpp: Added. (WebKit::PluginInfoStore::shared): (WebKit::PluginInfoStore::PluginInfoStore): (WebKit::PluginInfoStore::refresh): (WebKit::PluginInfoStore::getPlugins):
  • UIProcess/Plugins/PluginInfoStore.h: Added.
  • UIProcess/Plugins/mac: Added.
  • WebKit2.xcodeproj/project.pbxproj:
  • WebProcess/WebCoreSupport/WebPlatformStrategies.cpp: (WebKit::WebPlatformStrategies::refreshPlugins): (WebKit::WebPlatformStrategies::getPluginInfo):
  • WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::WebPage):
3:57 PM Changeset in webkit [61586] by kinuko@chromium.org
  • 34 edits in trunk

2010-06-21 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r61585.
​http://trac.webkit.org/changeset/61585
​https://bugs.webkit.org/show_bug.cgi?id=40950

It broke builds (Requested by kinuko on #webkit).

  • Android.derived.jscbindings.mk:
  • Android.derived.v8bindings.mk:
  • CMakeLists.txt:
  • DerivedSources.cpp:
  • DerivedSources.make:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pri:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • html/BlobBuilder.cpp: (WebCore::BlobBuilder::appendString): (WebCore::BlobBuilder::appendBlob):
  • html/BlobBuilder.h:
  • page/DOMWindow.idl:

2010-06-21 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r61585.
​http://trac.webkit.org/changeset/61585
​https://bugs.webkit.org/show_bug.cgi?id=40950

It broke builds (Requested by kinuko on #webkit).

  • fast/dom/Window/window-properties-expected.txt:
  • fast/dom/Window/window-property-descriptors-expected.txt:
  • fast/dom/constructed-objects-prototypes-expected.txt:
  • fast/dom/prototype-inheritance-2-expected.txt:
  • fast/dom/prototype-inheritance-expected.txt:
  • fast/js/global-constructors-expected.txt:
  • platform/chromium/fast/dom/prototype-inheritance-expected.txt:
  • platform/gtk/Skipped:
  • platform/gtk/fast/dom/Window/window-properties-expected.txt:
  • platform/gtk/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/gtk/fast/dom/prototype-inheritance-expected.txt:
  • platform/qt/Skipped:
  • platform/qt/fast/dom/Window/window-properties-expected.txt:
  • platform/qt/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/qt/fast/dom/prototype-inheritance-expected.txt:
  • platform/win/Skipped:
  • platform/win/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/win/fast/dom/prototype-inheritance-2-expected.txt:
  • platform/win/fast/dom/prototype-inheritance-expected.txt:
3:41 PM Changeset in webkit [61585] by kinuko@chromium.org
  • 34 edits in trunk

2010-06-21 Kinuko Yasuda <​kinuko@chromium.org>

Reviewed by Adam Barth.

Add BlobBuilder.idl to expose BlobBuilder interface
​https://bugs.webkit.org/show_bug.cgi?id=40593

BlobBuilder is defined in FileAPI's FileWriter spec.
(​http://dev.w3.org/2009/dap/file-system/file-writer.html)

Also removes the ENABLE_FILE_WRITER ifdef guard for BlobBuilder.

Tests: http/tests/local/blob/send-data-blob.html

http/tests/local/blob/send-hybrid-blob.html
http/tests/local/blob/send-sliced-data-blob.html

  • Android.derived.jscbindings.mk:
  • Android.derived.v8bindings.mk:
  • CMakeLists.txt:
  • DerivedSources.cpp:
  • DerivedSources.make:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pri:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • html/BlobBuilder.cpp: (WebCore::BlobBuilder::append):
  • html/BlobBuilder.h:
  • html/BlobBuilder.idl: Added.
  • page/DOMWindow.idl:

2010-06-21 Kinuko Yasuda <​kinuko@chromium.org>

Reviewed by Adam Barth.

Add BlobBuilder.idl to expose BlobBuilder interface
​https://bugs.webkit.org/show_bug.cgi?id=40593

Add new layout tests to test BlobBuilder interface.
Also update test expectations affected by adding the constructors to DOMWindow.

  • fast/dom/Window/window-properties-expected.txt:
  • fast/dom/Window/window-property-descriptors-expected.txt:
  • fast/dom/constructed-objects-prototypes-expected.txt:
  • fast/dom/prototype-inheritance-2-expected.txt:
  • fast/dom/prototype-inheritance-expected.txt:
  • fast/js/global-constructors-expected.txt:
  • http/tests/local/blob/resources/hybrid-blob-util.js: Added.
  • http/tests/local/blob/script-tests/TEMPLATE.html: Added.
  • http/tests/local/blob/script-tests/send-data-blob.js: Added.
  • http/tests/local/blob/script-tests/send-hybrid-blob.js: Added.
  • http/tests/local/blob/script-tests/send-sliced-data-blob.js: Added.
  • http/tests/local/blob/send-data-blob-expected.txt: Added.
  • http/tests/local/blob/send-data-blob.html: Added.
  • http/tests/local/blob/send-hybrid-blob-expected.txt: Added.
  • http/tests/local/blob/send-hybrid-blob.html: Added.
  • http/tests/local/blob/send-sliced-data-blob-expected.txt: Added.
  • http/tests/local/blob/send-sliced-data-blob.html: Added.
  • http/tests/local/resources/file-for-drag-to-send2.txt: Added.
  • http/tests/resources/post-and-verify-hybrid.cgi: Added.
  • platform/chromium/fast/dom/prototype-inheritance-expected.txt:
  • platform/gtk/Skipped: Added send-hybrid-blob.html and send-sliced-data-blob.html because they need eventSender.beginDragWithFiles Blob.slice.
  • platform/gtk/fast/dom/Window/window-properties-expected.txt:
  • platform/gtk/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/gtk/fast/dom/prototype-inheritance-expected.txt:
  • platform/qt/Skipped: Added send-hybrid-blob.html and send-sliced-data-blob.html because they need eventSender.beginDragWithFiles Blob.slice.
  • platform/qt/fast/dom/Window/window-properties-expected.txt:
  • platform/qt/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/qt/fast/dom/prototype-inheritance-expected.txt:
  • platform/win/Skipped: Added send-hybrid-blob.html and send-sliced-data-blob.html because they need eventSender.beginDragWithFiles Blob.slice.
  • platform/win/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/win/fast/dom/prototype-inheritance-2-expected.txt:
  • platform/win/fast/dom/prototype-inheritance-expected.txt:
3:33 PM Changeset in webkit [61584] by Nate Chapin
  • 25 edits
    2 adds in trunk

2010-06-21 Nate Chapin <Nate Chapin>

Reviewed by Adam Barth.

FrameLoader cleanup: Split high level subframe and plugin
loading functions into a separate class.
​https://bugs.webkit.org/show_bug.cgi?id=40453

Refactor only, no new tests.

  • Android.mk:
  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.base.exp:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/DOMImplementation.cpp:
  • history/PageCache.cpp:
  • html/HTMLFrameElementBase.cpp:
  • html/HTMLMediaElement.cpp:
  • loader/FrameLoader.cpp:
  • loader/FrameLoader.h: (WebCore::FrameLoader::subframeLoader):
  • loader/PluginDocument.cpp:
  • loader/SubframeLoader.cpp: Added. (WebCore::SubframeLoader::SubframeLoader): (WebCore::toPlugInElement): (WebCore::SubframeLoader::clear): (WebCore::SubframeLoader::requestFrame): (WebCore::SubframeLoader::requestObject): (WebCore::FrameLoader::loadMediaPlayerProxyPlugin): (WebCore::SubframeLoader::createJavaAppletWidget): (WebCore::SubframeLoader::loadSubframe): (WebCore::SubframeLoader::allowPlugins): (WebCore::SubframeLoader::shouldUsePlugin): (WebCore::SubframeLoader::loadPlugin): (WebCore::SubframeLoader::completeURL):
  • loader/SubframeLoader.h: Added. (WebCore::SubframeLoader::containsPlugins):
  • page/Page.cpp:
  • page/XSSAuditor.h:
  • platform/graphics/wince/MediaPlayerProxy.cpp:
  • plugins/MimeType.cpp:
  • rendering/RenderApplet.cpp:
  • rendering/RenderEmbeddedObject.cpp:
3:22 PM Changeset in webkit [61583] by Simon Fraser
  • 9 edits
    2 moves in trunk

2010-06-21 Simon Fraser <Simon Fraser>

Reviewed by Anders Carlsson.

Rename DrawingAreaProxyUpdateChunk to ChunkedUpdateDrawingArea
​https://bugs.webkit.org/show_bug.cgi?id=40948

Rename DrawingAreaUpdateChunk to ChunkedUpdateDrawingArea.

  • UIProcess/API/mac/WKView.mm: (-[WKView initWithFrame:pageNamespaceRef:]):
  • UIProcess/ChunkedUpdateDrawingArea.cpp: Added. (WebKit::ChunkedUpdateDrawingArea::ChunkedUpdateDrawingArea): (WebKit::ChunkedUpdateDrawingArea::~ChunkedUpdateDrawingArea): (WebKit::ChunkedUpdateDrawingArea::paint): (WebKit::ChunkedUpdateDrawingArea::setSize): (WebKit::ChunkedUpdateDrawingArea::setPageIsVisible): (WebKit::ChunkedUpdateDrawingArea::didSetSize): (WebKit::ChunkedUpdateDrawingArea::update): (WebKit::ChunkedUpdateDrawingArea::didReceiveMessage):
  • UIProcess/ChunkedUpdateDrawingArea.h: Added. (WebKit::ChunkedUpdateDrawingArea::encode):
  • UIProcess/DrawingAreaProxyUpdateChunk.cpp: Removed.
  • UIProcess/DrawingAreaProxyUpdateChunk.h: Removed.
  • UIProcess/mac/DrawingAreaProxyUpdateChunkMac.mm: (WebKit::ChunkedUpdateDrawingArea::page): (WebKit::ChunkedUpdateDrawingArea::ensureBackingStore): (WebKit::ChunkedUpdateDrawingArea::invalidateBackingStore): (WebKit::ChunkedUpdateDrawingArea::platformPaint): (WebKit::ChunkedUpdateDrawingArea::drawUpdateChunkIntoBackingStore):
  • UIProcess/win/DrawingAreaProxyUpdateChunkWin.cpp: (WebKit::ChunkedUpdateDrawingArea::page): (WebKit::ChunkedUpdateDrawingArea::ensureBackingStore): (WebKit::ChunkedUpdateDrawingArea::invalidateBackingStore): (WebKit::ChunkedUpdateDrawingArea::platformPaint): (WebKit::ChunkedUpdateDrawingArea::drawUpdateChunkIntoBackingStore):
  • UIProcess/win/WebView.cpp: (WebKit::WebView::WebView):
  • WebKit2.xcodeproj/project.pbxproj:
  • win/WebKit2.vcproj:
3:09 PM Changeset in webkit [61582] by andersca@apple.com
  • 2 edits in trunk/WebKit/mac

Another Tiger build fix.

  • Plugins/WebNetscapePluginPackage.mm:

(-[WebNetscapePluginPackage _tryLoad]):

2:40 PM Changeset in webkit [61581] by andersca@apple.com
  • 12 edits in trunk/WebKit/mac

2010-06-21 Anders Carlsson <​andersca@apple.com>

Reviewed by Sam Weinig.

More WebBasePluginPackage cleanup
​https://bugs.webkit.org/show_bug.cgi?id=40944

  • Plugins/Hosted/HostedNetscapePluginStream.mm: (WebKit::HostedNetscapePluginStream::pluginCancelledConnectionError):
  • Plugins/Hosted/NetscapePluginHostManager.mm: (WebKit::NetscapePluginHostManager::spawnPluginHost):
  • Plugins/WebBaseNetscapePluginStream.mm: (WebNetscapePluginStream::pluginCancelledConnectionError):
  • Plugins/WebBaseNetscapePluginView.mm: (WebHaltablePlugin::pluginName):
  • Plugins/WebBasePluginPackage.h:
  • Plugins/WebBasePluginPackage.mm: (-[WebBasePluginPackage initWithPath:]): (-[WebBasePluginPackage _objectForInfoDictionaryKey:]): (-[WebBasePluginPackage getPluginInfoFromPLists]): (-[WebBasePluginPackage load]): (-[WebBasePluginPackage dealloc]): (-[WebBasePluginPackage finalize]): (-[WebBasePluginPackage pluginInfo]): (-[WebBasePluginPackage supportsExtension:]): (-[WebBasePluginPackage supportsMIMEType:WebCore::]): (-[WebBasePluginPackage MIMETypeForExtension:]): (-[WebBasePluginPackage isJavaPlugIn]): (-[WebBasePluginPackage versionNumber]): (-[WebBasePluginPackage WebCore::]):
  • Plugins/WebNetscapePluginPackage.mm: (-[WebNetscapePluginPackage openResourceFile]): (-[WebNetscapePluginPackage closeResourceFile:]): (-[WebNetscapePluginPackage getPluginInfoFromResources]): (-[WebNetscapePluginPackage _initWithPath:]): (-[WebNetscapePluginPackage _applyDjVuWorkaround]): (-[WebNetscapePluginPackage _tryLoad]): (-[WebNetscapePluginPackage supportsSnapshotting]): (-[WebNetscapePluginPackage _unloadWithShutdown:]):
  • Plugins/WebPluginDatabase.mm: (-[WebPluginDatabase refresh]): (-[WebPluginDatabase _removePlugin:]):
  • Plugins/WebPluginPackage.mm: (-[WebPluginPackage initWithPath:]): (-[WebPluginPackage load]):
  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::createPlugin):
  • WebCoreSupport/WebPlatformStrategies.mm: (WebPlatformStrategies::getPluginInfo):
2:39 PM Changeset in webkit [61580] by robert@webkit.org
  • 4 edits in trunk

2010-06-21 Robert Hogan <​robert@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Unskip plugins/get-url-that-the-resource-load-delegate-will-disallow.html

It's a Mac-specific test so just add the required LayoutTestController
function as a no-op to avoid failing. Similar approach adopted by other
ports.

​https://bugs.webkit.org/show_bug.cgi?id=33344

  • platform/qt/Skipped:

2010-06-21 Robert Hogan <​robert@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Unskip plugins/get-url-that-the-resource-load-delegate-will-disallow.html

It's a Mac-specific test so just add the required LayoutTestController
function as a no-op to avoid failing. Similar approach adopted by other
ports.

​https://bugs.webkit.org/show_bug.cgi?id=33344

  • DumpRenderTree/qt/LayoutTestControllerQt.h: (LayoutTestController::addDisallowedURL):
2:36 PM Changeset in webkit [61579] by weinig@apple.com
  • 21 edits
    3 adds in trunk

Patch for ​https://bugs.webkit.org/show_bug.cgi?id=40940
Add message passing support to the WebKit2 API.

Reviewed by Anders Carlsson.

WebKit2:

Adds message passing for both InjectedBundle -> WebContext
and WebContext -> InjectedBundle.

  • Shared/CoreIPCSupport/WebProcessMessageKinds.h:

(WebProcessMessage::):

  • Shared/CoreIPCSupport/WebProcessProxyMessageKinds.h: Added.

(WebProcessProxyMessage::):
(CoreIPC::):

  • UIProcess/API/C/WKContext.cpp:

(WKContextSetInjectedBundleClient):
(WKContextPostMessageToInjectedBundle):

  • UIProcess/API/C/WKContext.h:
  • UIProcess/WebContext.cpp:

(WebKit::WebContext::initializeInjectedBundleClient):
(WebKit::WebContext::forwardMessageToWebContext):
(WebKit::WebContext::postMessageToInjectedBundle):

  • UIProcess/WebContext.h:
  • UIProcess/WebContextInjectedBundleClient.cpp: Added.

(WebKit::WebContextInjectedBundleClient::WebContextInjectedBundleClient):
(WebKit::WebContextInjectedBundleClient::initialize):
(WebKit::WebContextInjectedBundleClient::didRecieveMessageFromInjectedBundle):

  • UIProcess/WebContextInjectedBundleClient.h: Added.
  • UIProcess/WebProcessManager.cpp:

(WebKit::WebProcessManager::processDidClose):

  • UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::didReceiveInjectedBundleMessage):
(WebKit::WebProcessProxy::didReceiveMessage):

  • UIProcess/WebProcessProxy.h:
  • WebKit2.xcodeproj/project.pbxproj:
  • WebProcess/InjectedBundle/API/c/WKBundle.cpp:

(WKBundlePostMessage):

  • WebProcess/InjectedBundle/API/c/WKBundle.h:
  • WebProcess/InjectedBundle/InjectedBundle.cpp:

(WebKit::InjectedBundle::postMessage):
(WebKit::InjectedBundle::didCreatePage):
(WebKit::InjectedBundle::didRecieveMessage):

  • WebProcess/InjectedBundle/InjectedBundle.h:
  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::loadInjectedBundle):
(WebKit::WebProcess::forwardMessageToInjectedBundle):
(WebKit::WebProcess::didReceiveMessage):

  • WebProcess/WebProcess.h:
  • mac/WebKit2.exp:
  • win/WebKit2.vcproj:

WebKitTools:

  • Add some test messages.
  • MiniBrowser/mac/AppDelegate.m:

(_didRecieveMessageFromInjectedBundle):
(-[BrowserAppDelegate init]):

  • MiniBrowser/mac/WebBundle/WebBundleMain.m:

(_didClearWindow):
(_didCreatePage):
(_didRecieveMessage):
(WKBundleInitialize):

2:07 PM Changeset in webkit [61578] by robert@webkit.org
  • 2 edits in trunk/LayoutTests

2010-06-21 Robert Hogan <​robert@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Missing forward entries when dumping back/forward list

These now pass.
​https://bugs.webkit.org/show_bug.cgi?id=32470

http/tests/navigation/dynamic-iframe-dynamic-form-back-entry.html
http/tests/navigation/parsed-iframe-dynamic-form-back-entry.html

  • platform/qt/Skipped:
2:01 PM Changeset in webkit [61577] by sullivan@apple.com
  • 1 edit in trunk/JavaScriptCore/ChangeLog

Fixed bugzilla URL in previous checkin.

1:59 PM Changeset in webkit [61576] by sullivan@apple.com
  • 2 edits in trunk/JavaScriptCore

RetainPtr can't be used in HashMaps or HashSets
<​https://bugs.webkit.org/post_bug.cgi>

Reviewed by Adam Roben.

Added hashing knowledge similar to that in COMPtr.h.

  • wtf/RetainPtr.h:

(WTF::RetainPtr::RetainPtr):
New function, copied from COMPtr.h but for the type change.
(WTF::RetainPtr::isHashTableDeletedValue):
Ditto.
(WTF::RetainPtr::hashTableDeletedValue):
Ditto.
Added template code for HashTraits and PtrHash copied from COMPtr.h but for the type change.
The only difference is that constructDeletedValue() matches the RefPtr implementation (in HashTraits.h)
rather than the COMPtr implementation.

1:59 PM Changeset in webkit [61575] by robert@webkit.org
  • 2 edits in trunk/WebKit/qt

2010-06-21 Robert Hogan <​robert@webkit.org>

[Qt] Build fix for Qt on Windows MSVC2008

Unreviewed, build fix.

Fix by Jocelyn Turcotte.

  • Api/qwebframe.cpp:
1:50 PM Changeset in webkit [61574] by andersca@apple.com
  • 2 edits in trunk/WebKit/mac

Another PowerPC build fix.

  • Plugins/WebNetscapePluginPackage.mm:

(-[WebNetscapePluginPackage openResourceFile]):
(-[WebNetscapePluginPackage _tryLoad]):

1:48 PM Changeset in webkit [61573] by Dimitri Glazkov
  • 2 edits in trunk/LayoutTests

2010-06-21 Dimitri Glazkov <Dimitri Glazkov>

Unreviewed, expectations update.

Mark hyphenation tests as failing on Chromium
Hyphenation landed in ​http://trac.webkit.org/changeset/61548.

  • platform/chromium/test_expectations.txt: Added failing tests.
1:40 PM Changeset in webkit [61572] by Nate Chapin
  • 2 edits in trunk/WebKit/win

2010-06-21 Nate Chapin <Nate Chapin>

Unreviewed, Windows build fix.

Update WebFrame to use FrameLoaderStateMachine in

firstLayoutDone().

  • WebFrame.cpp: (WebFrame::firstLayoutDone):
1:32 PM Changeset in webkit [61571] by andersca@apple.com
  • 2 edits in trunk/WebKit/mac

Try to fix the PowerPC build.

  • Plugins/WebNetscapePluginPackage.mm:

(-[WebNetscapePluginPackage _tryLoad]):

1:26 PM Changeset in webkit [61570] by dumi@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed, fixing a test expectations on Windows.

  • platform/win/fast/dom/prototype-inheritance-expected.txt:
1:20 PM Changeset in webkit [61569] by Nate Chapin
  • 2 edits in trunk/WebCore

2010-06-21 Nate Chapin <Nate Chapin>

Unreviewed, build fix.

Bad merge, left a reference to m_committedFirstRealDocumentLoad in
​http://trac.webkit.org/changeset/61568.

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::transitionToCommitted):
1:06 PM Changeset in webkit [61568] by Nate Chapin
  • 19 edits
    2 adds in trunk

2010-06-21 Nate Chapin <Nate Chapin>

Reviewed by Adam Barth.

Remove a couple of FrameLoader's unused boolean members
(m_receivedData, m_cancellingWithLoadInProcess) and merge
several more into a single state machine called FrameLoaderStateMachine
(m_firstLayoutDone, m_creatingInitialEmptyDocument,
m_isDisplayingInitialEmptyDocument, m_committedFirstRealDocumentLoad).

​https://bugs.webkit.org/show_bug.cgi?id=39695

Refactor only, so no new tests.

  • WebCore.base.exp:
  • WebCore.xcodeproj/project.pbxproj:
  • loader/DocumentWriter.cpp: (WebCore::DocumentWriter::createDocument): (WebCore::DocumentWriter::begin):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::FrameLoader): (WebCore::FrameLoader::init): (WebCore::FrameLoader::stopLoading): (WebCore::FrameLoader::didOpenURL): (WebCore::FrameLoader::didExplicitOpen): (WebCore::FrameLoader::clear): (WebCore::FrameLoader::didBeginDocument): (WebCore::FrameLoader::finishedParsing): (WebCore::FrameLoader::provisionalLoadStarted): (WebCore::FrameLoader::logCanCachePageDecision): (WebCore::FrameLoader::logCanCacheFrameDecision): (WebCore::FrameLoader::frameHasLoaded): (WebCore::FrameLoader::commitProvisionalLoad): (WebCore::FrameLoader::transitionToCommitted): (WebCore::FrameLoader::finishedLoadingDocument): (WebCore::FrameLoader::checkLoadCompleteForThisFrame): (WebCore::FrameLoader::didFirstLayout): (WebCore::FrameLoader::frameLoadCompleted): (WebCore::FrameLoader::dispatchDidCommitLoad):
  • loader/FrameLoader.h: (WebCore::FrameLoader::stateMachine):
  • loader/FrameLoaderStateMachine.cpp: Added.
  • loader/FrameLoaderStateMachine.h: Added.
  • loader/HistoryController.cpp: (WebCore::HistoryController::restoreScrollPositionAndViewState): (WebCore::HistoryController::saveDocumentState):
  • loader/ProgressTracker.cpp: (WebCore::ProgressTracker::incrementProgress):
  • loader/RedirectScheduler.cpp: (WebCore::RedirectScheduler::scheduleLocationChange): (WebCore::RedirectScheduler::scheduleFormSubmission):
12:58 PM Changeset in webkit [61567] by kevino@webkit.org
  • 3 edits in trunk/WebKit/wx

Build fix after conversion of WebInterfaceSystem to Obj-C++.

12:57 PM Changeset in webkit [61566] by kevino@webkit.org
  • 2 edits in trunk/WebCore

[wx] Build fix. Fix header includes for ENABLE(DATABASE)

12:22 PM Changeset in webkit [61565] by Dimitri Glazkov
  • 2 edits in trunk/WebKit/mac

2010-06-21 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Dan Bernstein.

Chromium/Mac build fix.

  • WebCoreSupport/WebSystemInterface.mm: Change the order of wtf/Platform.h include to let other

headers smell it.

12:11 PM Changeset in webkit [61564] by atwilson@chromium.org
  • 47 edits
    6 deletes in trunk

WebKitTools: Unreviewed.

Rolling back 61551 and 61555 due to test failures.

  • DumpRenderTree/LayoutTestController.cpp:

(LayoutTestController::staticFunctions):

  • DumpRenderTree/LayoutTestController.h:
  • DumpRenderTree/mac/LayoutTestControllerMac.mm:

(LayoutTestController::setEditingBehavior):

  • DumpRenderTree/mac/UIDelegate.mm:

LayoutTests: Unreviewed rollback.

Rolling back 61551 and 61555 due to test failures on Linux/Win.

  • fast/dom/Window/window-function-frame-getter-precedence-expected.txt:
  • fast/dom/Window/window-function-frame-getter-precedence.html:
  • fast/dom/Window/window-function-name-getter-precedence-expected.txt:
  • fast/dom/Window/window-function-name-getter-precedence.html:
  • fast/dom/Window/window-lookup-precedence-expected.txt:
  • fast/dom/Window/window-lookup-precedence.html:
  • fast/dom/Window/window-properties-expected.txt:
  • fast/dom/Window/window-properties.html:
  • fast/dom/script-tests/prototype-inheritance.js:
  • fast/events/resources/modal-dialog.html: Removed.
  • fast/events/show-modal-dialog-onblur-onfocus-expected.txt: Removed.
  • fast/events/show-modal-dialog-onblur-onfocus.html: Removed.
  • fast/harness/resources/modal-dialog.html: Removed.
  • fast/harness/show-modal-dialog-expected.txt: Removed.
  • fast/harness/show-modal-dialog.html: Removed.
  • fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.1_T1-expected.txt:
  • fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.1_T10-expected.txt:
  • fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.1_T11-expected.txt:
  • fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.1_T2-expected.txt:
  • fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.1_T3-expected.txt:
  • fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.1_T4-expected.txt:
  • fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.1_T5-expected.txt:
  • fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.1_T6-expected.txt:
  • fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.1_T7-expected.txt:
  • fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.1_T8-expected.txt:
  • fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.1_T9-expected.txt:
  • fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.2_T1-expected.txt:
  • fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.2_T10-expected.txt:
  • fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.2_T11-expected.txt:
  • fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.2_T2-expected.txt:
  • fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.2_T3-expected.txt:
  • fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.2_T4-expected.txt:
  • fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.2_T5-expected.txt:
  • fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.2_T6-expected.txt:
  • fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.2_T7-expected.txt:
  • fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.2_T8-expected.txt:
  • fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.2_T9-expected.txt:
  • http/tests/security/cross-frame-access-call-expected.txt:
  • http/tests/security/cross-frame-access-call.html:
  • http/tests/security/cross-frame-access-get-expected.txt:
  • http/tests/security/cross-frame-access-get.html:
  • http/tests/security/cross-frame-access-put-expected.txt:
  • http/tests/security/resources/cross-frame-iframe-for-put-test.html:
  • platform/chromium/test_expectations.txt:
  • platform/gtk/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:
11:57 AM Changeset in webkit [61563] by andersca@apple.com
  • 11 edits in trunk

WebKit2: Make WebKit2 build with clang++

Reviewed by Sam Weinig.

  • Platform/CoreIPC/Connection.h:
  • UIProcess/API/mac/WKView.mm:

(-[WKView keyUp:]):
(-[WKView keyDown:]):

  • UIProcess/WebHistoryClient.h:
  • UIProcess/WebPageProxy.h:
  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebProcess.h:

WebKitTools: Make DumpRenderTree build with clang++

Reviewed by Sam Weinig.

  • DumpRenderTree/mac/DumpRenderTreePasteboard.m:

(-[LocalPasteboard setPropertyList:forType:]):

  • DumpRenderTree/mac/DumpRenderTreeWindow.mm:

(-[DumpRenderTreeWindow keyDown:]):

  • DumpRenderTree/mac/LayoutTestControllerMac.mm:

(LayoutTestController::elementDoesAutoCompleteForElementWithId):
(LayoutTestController::isCommandEnabled):

11:41 AM Changeset in webkit [61562] by andersca@apple.com
  • 12 edits in trunk/WebKit/mac

Make all of WebKit build with clang++

Reviewed by Dan Bernstein.

  • DefaultDelegates/WebDefaultPolicyDelegate.m:

(-[WebDefaultPolicyDelegate webView:decidePolicyForMIMEType:request:frame:decisionListener:]):

  • Plugins/Hosted/NetscapePluginHostManager.mm:
  • Plugins/WebBaseNetscapePluginView.mm:

(-[WebBaseNetscapePluginView resolvedURLStringForURL:target:]):

  • WebView/WebDynamicScrollBarsView.mm:

(-[WebDynamicScrollBarsView setSuppressLayout:]):

  • WebView/WebHTMLRepresentation.mm:
  • WebView/WebNavigationData.mm:

(-[WebNavigationData initWithURLString:title:originalRequest:response:hasSubstituteData:clientRedirectSource:]):

  • WebView/WebPDFRepresentation.mm:

(-[WebPDFRepresentation setDataSource:]):
(-[WebPDFRepresentation receivedData:withDataSource:]):
(-[WebPDFRepresentation receivedError:withDataSource:]):

  • WebView/WebResource.mm:

(-[WebResource description]):

  • WebView/WebSerializedJSValue.mm:

(-[WebSerializedJSValue initWithValue:context:exception:]):

  • WebView/WebVideoFullscreenController.mm:

(-[WebVideoFullscreenController WebCore::]):
(-[WebVideoFullscreenController setMediaElement:WebCore::]):
(-[WebVideoFullscreenController setDelegate:]):
(-[WebVideoFullscreenController enterFullscreen:]):

  • WebView/WebView.mm:

(-[WebView _openFrameInNewWindowFromMenu:]):
(-[WebView _geolocationDidChangePosition:]):

11:38 AM Changeset in webkit [61561] by mitz@apple.com
  • 2 edits in trunk/WebKitLibraries

Speculative build fix.

  • WebKitSystemInterface.h:
11:29 AM Changeset in webkit [61560] by andersca@apple.com
  • 2 edits in trunk/WebCore

Fix clang++ build.

  • loader/FormSubmission.h:
11:19 AM Changeset in webkit [61559] by Dimitri Glazkov
  • 2 edits in trunk/WebCore

2010-06-21 Dimitri Glazkov <Dimitri Glazkov>

Unreviewed, build fix.

Add a missing include in AsyncImageResizer.h

  • html/AsyncImageResizer.h: Added the IntSize include.
11:02 AM Changeset in webkit [61558] by andersca@apple.com
  • 4 edits in trunk/WebKit/mac

2010-06-21 Anders Carlsson <​andersca@apple.com>

Reviewed by Sam Weinig.

Remove unused dictionary ivars from WebBasePluginPackage
​https://bugs.webkit.org/show_bug.cgi?id=40928

  • Plugins/WebBasePluginPackage.h:
  • Plugins/WebBasePluginPackage.mm: (-[WebBasePluginPackage getPluginInfoFromPLists]): (-[WebBasePluginPackage dealloc]):
  • Plugins/WebNetscapePluginPackage.mm: (-[WebNetscapePluginPackage getPluginInfoFromResources]):
10:51 AM Changeset in webkit [61557] by Dimitri Glazkov
  • 2 edits in trunk/LayoutTests

2010-06-21 Dimitri Glazkov <Dimitri Glazkov>

Unreviewed, expectations tweak.

Use C++-style comments rather than Python-style.

  • platform/chromium/test_expectations.txt: Tweaked comment style.
10:46 AM Changeset in webkit [61556] by mitz@apple.com
  • 2 edits in trunk/WebKit/mac

Build fix

  • WebCoreSupport/WebSystemInterface.mm:

(InitWebCoreSystemInterface):

10:44 AM Changeset in webkit [61555] by atwilson@chromium.org
  • 6 adds in trunk/LayoutTests/fast

2010-06-21 Drew Wilson <​atwilson@chromium.org>

Unreviewed.

Missing files from r61551.

  • fast/events/resources/modal-dialog.html: Added.
  • fast/events/show-modal-dialog-onblur-onfocus-expected.txt: Added.
  • fast/events/show-modal-dialog-onblur-onfocus.html: Added.
  • fast/harness/resources/modal-dialog.html: Added.
  • fast/harness/show-modal-dialog-expected.txt: Added.
  • fast/harness/show-modal-dialog.html: Added.
10:43 AM Changeset in webkit [61554] by Adam Roben
  • 2 edits in trunk/WebCore

Call NotifyAddrChange again each time we are notified of a change

NotifyAddrChange only notifies you of a single change. If you want to
listen for subsequent changes, you have to call it again.

Fixes <​http://webkit.org/b/33004> NetworkStateNotifier ignores all
state changes after the first.

No test possible, as we don't have a way to modify the system's
network adapters when running tests.

Reviewed by Anders Carlsson.

  • platform/network/win/NetworkStateNotifierWin.cpp:

(WebCore::NetworkStateNotifier::addrChangeCallback): Call
registerForAddressChange as soon as we're notified of an address
change, so we'll also get notified of the *next* address change. I
added the call here instead of in addressChanged (which is called
later on the main thread) to minimize the time between the callback
and registering again (so that we won't miss changes that happen in
rapid succession).

10:43 AM Changeset in webkit [61553] by oliver@apple.com
  • 5 edits in trunk/JavaScriptCore

2010-06-19 Oliver Hunt <​oliver@apple.com>

Reviewed by Geoffrey Garen.

Need to ensure that we grow the RegisterFile when creating a callframe for host code
​https://bugs.webkit.org/show_bug.cgi?id=40858
<rdar://problem/8108986>

In the past the use of the callframe in hostcode was much more
limited. Now that we expect the callframe to always be valid
we need to grow the RegisterFile so that this is actually the
case. In this particular case the problem was failing to grow
the registerfile could lead to a callframe that extended beyond
RegisterFiler::end(), so vm re-entry would clobber the callframe
other scenarios could also lead to badness.

I was unable to construct a simple testcase to trigger badness,
and any such testcase would be so dependent on exact vm stack
layout that it would be unlikely to work as a testcase following
any callframe or register allocation changes anyway.

Thankfully the new assertion I added should help to catch these
failures in future, and triggers on a couple of tests currently.

  • interpreter/CallFrame.cpp: (JSC::CallFrame::registerFile):
  • interpreter/CallFrame.h: (JSC::ExecState::init):
  • interpreter/Interpreter.cpp: (JSC::Interpreter::privateExecute):
  • jit/JITStubs.cpp: (JSC::DEFINE_STUB_FUNCTION):
10:21 AM Changeset in webkit [61552] by mitz@apple.com
  • 2 edits in trunk/WebCore

Release build fix

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::tryHyphenating):

10:17 AM Changeset in webkit [61551] by atwilson@chromium.org
  • 47 edits in trunk

DumpRenderTree should allow tests with modal dialogs
​https://bugs.webkit.org/show_bug.cgi?id=35350

Patch by Prasad Tammana <​prasadt@chromium.org> on 2010-06-21
Reviewed by Darin Adler.

  • DumpRenderTree/LayoutTestController.cpp:

(abortModalCallback):
(LayoutTestController::staticFunctions):

  • DumpRenderTree/LayoutTestController.h:
  • DumpRenderTree/mac/LayoutTestControllerMac.mm:

(LayoutTestController::abortModal):
Add abortModal method to LayoutTestController and make it available from script.

.:

  • DumpRenderTree/mac/UIDelegate.mm: Add support for showModalDialog.

(-[UIDelegate modalWindowWillClose:]): Observer for NSWindowWillCloseNotifications to call
abortModal from when modal window closes.
(-[UIDelegate webViewRunModal:]): Delegate method for showModalDialog to run the modal loop.

WebKitTools:

  • DumpRenderTree/mac/UIDelegate.mm: Add support for showModalDialog.

(-[UIDelegate modalWindowWillClose:]): Observer for NSWindowWillCloseNotifications to call
abortModal from when modal window closes.
(-[UIDelegate webViewRunModal:]): Delegate method for showModalDialog to run the modal loop.

10:14 AM Changeset in webkit [61550] by leandro@webkit.org
  • 2 edits in trunk

2010-06-21 Lucas De Marchi <​lucas.demarchi@profusion.mobi>

Unreviewed debug build fix.

[CMake] Do not force build type to Release
​https://bugs.webkit.org/show_bug.cgi?id=40566

  • CMakeLists.txt:
10:07 AM Changeset in webkit [61549] by mitz@apple.com
  • 2 edits in trunk/WebCore

Windows build fix

  • WebCore.vcproj/WebCore.vcproj: Fixed a typo.
9:54 AM Changeset in webkit [61548] by mitz@apple.com
  • 42 edits
    12 adds in trunk

WebCore: CSS3: Implement the 'hyphens' and 'hyphenate-character' properties
​https://bugs.webkit.org/show_bug.cgi?id=10228

Reviewed by Darin Adler.

Tests: fast/text/hyphenate-character.html

fast/text/hyphens.html

Added -webkit-hyphens and -webkit-hyphenate-character as specified in
<​http://www.w3.org/TR/2010/WD-css3-gcpm-20100608/#hyphenation>.

  • Android.mk: Added Hyphenation.cpp.
  • CMakeLists.txt: Ditto.
  • GNUmakefile.am: Added Hyphenation.{cpp,h}.
  • WebCore.base.exp: Exported wkGetHyphenationLocationBeforeIndex().
  • WebCore.gypi: Added Hyphenation.{cpp,h}.
  • WebCore.pro: Added Hyphenation.{cpp,h}.
  • WebCore.vcproj/WebCore.vcproj: Added Hyphenation.{cpp,h}.
  • WebCore.xcodeproj/project.pbxproj: Added Hyphenation.{cpp,h}.
  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Added the -webkit-hyphenate-character
and -webkit-hyphens cases.

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseValue): Validate values for the new properties.

  • css/CSSPrimitiveValueMappings.h:

(WebCore::CSSPrimitiveValue::CSSPrimitiveValue): Added. Maps from a Hyphens value to an identifier.
(WebCore::CSSPrimitiveValue::operator Hyphens): Added. Maps from an identifier to a Hyphens value.

  • css/CSSPropertyNames.in: Added -webkit-hyphenate-character and -webkit-hyphens.
  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyProperty): Apply the new properties to the RenderStyle.

  • css/CSSValueKeywords.in:
  • platform/mac/WebCoreSystemInterface.h: Added wkGetHyphenationLocationBeforeIndex.
  • platform/mac/WebCoreSystemInterface.mm: Ditto.
  • platform/text/CharacterNames.h: Added the hyphen character.
  • platform/text/Hyphenation.cpp: Added.

(WebCore::lastHyphenLocation): Added this default implementation for platforms that do not implement
hyphenation yet. It calls notImplemented() and returns 0.

  • platform/text/Hyphenation.h: Added.
  • platform/text/cf/HyphenationCF.cpp: Added.

(WebCore::lastHyphenLocation): Returns the last hyphenation location occurring in the given string before
the given index. Uses the current search locale (which is based on the top language preference of the user)
for hyphenation.

  • platform/text/mac/HyphenationMac.mm: Added.

(WebCore::lastHyphenLocation): Returns the last hyphenation location occurring in the given string before
the given index. Returns 0 if the current search locale is not "en", because the platform only knows how to
hyphenate English.

  • rendering/BidiRun.h:

(WebCore::BidiRun::BidiRun): Added a boolean member, m_hasHyphen, and initialized it to false in the constructor.

  • rendering/InlineBox.h:

(WebCore::InlineBox::InlineBox): Renamed m_hasEllipsisBox to m_hasEllipsisBoxOrHyphen, because this bit is now
shared by two subclass: RootInlineBox uses it for hasEllipsisBox(), while InlineTextBox uses it for hasHyphen().

  • rendering/InlineTextBox.cpp:

(WebCore::adjustCharactersAndLengthForHyphen): Added this helper function to get the hyphen string from the style
and return a UChar* and length for the concatenation of the given text with the hyphen string.
(WebCore::InlineTextBox::selectionRect): If the selected range touches the end and the box has a hyphen,
compute the width of the text with the hyphen string concatenated to it.
(WebCore::InlineTextBox::paint): If the box has a hyphen, draw the text with the hyphen string concatenated to it.
(WebCore::InlineTextBox::paintSelection): Similarly concatenate the hyphen string.

  • rendering/InlineTextBox.h:

(WebCore::InlineTextBox::hasHyphen): Added this accessor.
(WebCore::InlineTextBox::setHasHyphen): Ditto.

  • rendering/RenderBlock.h:
  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::constructLine): Copy the m_hasHyphen flag from the run to its text box.
(WebCore::RenderBlock::computeHorizontalPositionsForLine): Add the width of the hyphen string when computing the
width of a box that has a hyphen.
(WebCore::RenderBlock::layoutInlineChildren): If the line was hyphenated, set the m_hasHyphen flag on the
logically last run.
(WebCore::tryHyphenating): Added this helper function which checks if a piece of text that does not fit on the
line could be hyphenated such that the part before the hyphen, including the hyphen, would fit. Given the amount
of space remaining on the line, it finds the longest prefix that can fit in the remaining space (which leaving room for
the hyphen), and then checks for a hyphenation location within that prefix.
(WebCore::RenderBlock::findNextLineBreak): In the 'hyphens: none' case, prevent line breaks at soft hyphens.
In the 'hyphens: auto' case, try hyphenating when a word will not fit in the remaining space on the line.

  • rendering/RootInlineBox.cpp:

(WebCore::RootInlineBox::detachEllipsisBox): Changed to use hasEllipsisBox() and setHasEllipsisBox().
(WebCore::RootInlineBox::clearTruncation): Ditto.
(WebCore::RootInlineBox::placeEllipsis): Ditto.
(WebCore::RootInlineBox::paintEllipsisBox): Ditto.
(WebCore::RootInlineBox::nodeAtPoint): Ditto.
(WebCore::RootInlineBox::ellipsisBox): Ditto.

  • rendering/RootInlineBox.h:

(WebCore::RootInlineBox::hasEllipsisBox): Added this accessor.
(WebCore::RootInlineBox::setHasEllipsisBox): Ditto.

  • rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::diff): Return a layout hint if the hyphens setting or hyphenate-character differs.
(WebCore::RenderStyle::hyphenString): Added. For hyphenate-character: auto, returns the hyphen character.

  • rendering/style/RenderStyle.h:

(WebCore::InheritedFlags::hyphens): Added this accessor.
(WebCore::InheritedFlags::hyphenateCharacter): Ditto.
(WebCore::InheritedFlags::setHyphens): Ditto.
(WebCore::InheritedFlags::setHyphenateCharacter): Ditto.
(WebCore::InheritedFlags::initialHyphens): Added. Returns HyphensManual.
(WebCore::InheritedFlags::initialHyphenateCharacter): Added. Returns the null string, corresponding to
a value of 'auto'.

  • rendering/style/RenderStyleConstants.h:

Added a Hyphens enum.

  • rendering/style/StyleRareInheritedData.cpp:

(WebCore::StyleRareInheritedData::StyleRareInheritedData): Initialize and copy the new members.
(WebCore::StyleRareInheritedData::operator==): Compare the new members.

  • rendering/style/StyleRareInheritedData.h: Added two new members: hyphens and hyphenateCharacter.

WebKit/mac: WebKit part of implementing the 'hyphens' and 'hyphenate-character' properties
​https://bugs.webkit.org/show_bug.cgi?id=10228

Reviewed by Darin Adler.

  • WebCoreSupport/WebSystemInterface.mm:

(InitWebCoreSystemInterface): Initialize wkGetHyphenationLocationBeforeIndex.

WebKitLibraries: WebKitSystemInterface part of CSS3: Implement the 'hyphens' and 'hyphenate-character' properties
​https://bugs.webkit.org/show_bug.cgi?id=10228

Reviewed by Darin Adler.

  • WebKitSystemInterface.h: Added WKGetHyphenationLocationBeforeIndex().
  • libWebKitSystemInterfaceLeopard.a:
  • libWebKitSystemInterfaceSnowLeopard.a:
  • libWebKitSystemInterfaceTiger.a:

LayoutTests: Added tests for the 'hyphens' and 'hyphenate-character' properties
​https://bugs.webkit.org/show_bug.cgi?id=10228

Reviewed by Darin Adler.

  • fast/text/hyphenate-character.html: Added.
  • fast/text/hyphens.html: Added.
  • platform/gtk/Skipped:
  • platform/mac/fast/text/hyphenate-character-expected.checksum: Added.
  • platform/mac/fast/text/hyphenate-character-expected.png: Added.
  • platform/mac/fast/text/hyphenate-character-expected.txt: Added.
  • platform/mac/fast/text/hyphens-expected.checksum: Added.
  • platform/mac/fast/text/hyphens-expected.png: Added.
  • platform/mac/fast/text/hyphens-expected.txt: Added.
  • platform/qt/Skipped:
  • platform/win/Skipped:
9:39 AM Changeset in webkit [61547] by Dimitri Glazkov
  • 2 edits in trunk/WebKit/chromium

2010-06-21 Kent Tamura <​tkent@chromium.org>

Reviewed by Dimitri Glazkov.

[Chromium] Enable EVENTSOURCE, FILE_WRITER, and IMAGE_RESIZER
​https://bugs.webkit.org/show_bug.cgi?id=40905

EVENTSOURCE: It is already enabled in Chromium browser. This fixes
some tests with Chromium DRT.

FILE_WRITER and IMAGE_RESIZER: Enable experimental features in
order to test them before enabling them in Chromium browser.

  • features.gypi:
9:36 AM Changeset in webkit [61546] by Dimitri Glazkov
  • 7 edits in trunk/WebCore

2010-06-03 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Darin Adler.

Plumb FormSubmission through to ScheduledFormSubmission.
​https://bugs.webkit.org/show_bug.cgi?id=40137

No behavior change, covered by existing tests.

  • html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::prepareFormSubmission): Moved creation of action URL

instance here from FrameLoader::submit, because it makes more sense here,
also added a FIXME to investigate existing code later.

  • loader/FormSubmission.cpp: (WebCore::FormSubmission::FormSubmission): Changed action to be a KURL, not a String. (WebCore::FormSubmission::create): Ditto. (WebCore::FormSubmission::populateFrameLoadRequest): Added, moving the logic from

FrameLoader::submit closer to the data.

  • loader/FormSubmission.h: (WebCore::FormSubmission::action): Changed type to KURL. (WebCore::FormSubmission::clearTarget): Added. (WebCore::FormSubmission::referrer): Added. (WebCore::FormSubmission::setReferrer): Added. (WebCore::FormSubmission::origin): Added. (WebCore::FormSubmission::setOrigin): Added.
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::submitForm): Cleaned up to make it more about decision-making,

not data manipulation.

  • loader/RedirectScheduler.cpp: (WebCore::ScheduledFormSubmission::ScheduledFormSubmission): Changed to accept FormSubmission as argument. (WebCore::ScheduledFormSubmission::fire): Changed to use FormSubmission. (WebCore::RedirectScheduler::scheduleFormSubmission): Removed assert that no longer makes sense,

changed to use FormSubmission.

  • loader/RedirectScheduler.h: Updated ScheduledFormSubmission decl to hold FormSubmission ref.
9:02 AM Changeset in webkit [61545] by eric@webkit.org
  • 19 edits in trunk

2010-06-21 Satish Sampath <​satish@chromium.org>

Reviewed by Steve Block.

Speech Input Patch 0: Added compilation argument to conditionally compile pending patches.
​https://bugs.webkit.org/show_bug.cgi?id=40878

  • configure.ac:

2010-06-21 Satish Sampath <​satish@chromium.org>

Reviewed by Steve Block.

Speech Input Patch 0: Added compilation argument to conditionally compile pending patches.
​https://bugs.webkit.org/show_bug.cgi?id=40878

  • Configurations/FeatureDefines.xcconfig:

2010-06-21 Satish Sampath <​satish@chromium.org>

Reviewed by Steve Block.

Speech Input Patch 0: Added compilation argument to conditionally compile pending patches.
​https://bugs.webkit.org/show_bug.cgi?id=40878

No new tests are needed, because there is no new functionality.

  • Configurations/FeatureDefines.xcconfig:
  • GNUmakefile.am:
  • WebCore.pri:

2010-06-21 Satish Sampath <​satish@chromium.org>

Reviewed by Steve Block.

Speech Input Patch 0: Added compilation argument to conditionally compile pending patches.
​https://bugs.webkit.org/show_bug.cgi?id=40878

  • features.gypi:

2010-06-21 Satish Sampath <​satish@chromium.org>

Reviewed by Steve Block.

Speech Input Patch 0: Added compilation argument to conditionally compile pending patches.
​https://bugs.webkit.org/show_bug.cgi?id=40878

  • Configurations/FeatureDefines.xcconfig:

2010-06-21 Satish Sampath <​satish@chromium.org>

Reviewed by Steve Block.

Speech Input Patch 0: Added compilation argument to conditionally compile pending patches.

Speech Input Patch 0: Added compilation argument to conditionally compile pending patches.
​https://bugs.webkit.org/show_bug.cgi?id=40878

  • Configurations/FeatureDefines.xcconfig:

2010-06-21 Satish Sampath <​satish@chromium.org>

Reviewed by Steve Block.

Speech Input Patch 0: Added compilation argument to conditionally compile pending patches.
​https://bugs.webkit.org/show_bug.cgi?id=40878

  • win/tools/vsprops/FeatureDefines.vsprops:
  • win/tools/vsprops/FeatureDefinesCairo.vsprops:

2010-06-21 Satish Sampath <​satish@chromium.org>

Reviewed by Steve Block.

Speech Input Patch 0: Added compilation argument to conditionally compile pending patches.
​https://bugs.webkit.org/show_bug.cgi?id=40878

  • Scripts/build-webkit:
8:50 AM Changeset in webkit [61544] by eric@webkit.org
  • 2 edits in trunk/JavaScriptCore

2010-06-21 Kwang Yul Seo <​skyul@company100.net>

Reviewed by Kent Tamura.

[BREWMP] Use global new/delete operator overloading with USE_SYSTEM_MALLOC=1
​https://bugs.webkit.org/show_bug.cgi?id=40653

Currently, other ports do not use global new/delete operator overloading
when USE_SYSTEM_MALLOC=1. Brew MP uses system malloc, but it needs to enable
"global fastMalloc new" because the default new/delete causes crash on device.
We need to replace them with Brew MP's MALLOC/FREE.

  • wtf/FastMalloc.h:
8:50 AM Changeset in webkit [61543] by jocelyn.turcotte@nokia.com
  • 2 edits in trunk/WebKit/qt

[Qt] Fix MSVC build.

Reviewed by nobody, build fix.

The max macro was replacing the max function used in StringImpl.h
when compiling moc_NotificationPresenterClientQt.cpp.

  • WebCoreSupport/NotificationPresenterClientQt.cpp:
7:50 AM Changeset in webkit [61542] by eric@webkit.org
  • 8 edits in trunk/WebCore

2010-06-21 Hans Wennborg <​hans@chromium.org>

Reviewed by Jeremy Orlow.

Delete DOM storage databases when they are empty.
​https://bugs.webkit.org/show_bug.cgi?id=40767

Even if a page clears its local storage, the database file for it stays around,
and there is currently no mechanism that deletes them.

After doing the "final sync" of a storage area, the StorageAreaSyncMaster should
see if the database is empty, and in that case delete it.

Tests:

manual-tests/localstorage-empty-database.html

  • manual-tests/localstorage-empty-database.html: Added link to clear local storage for testing that the file is removed.
  • storage/LocalStorageTask.cpp: (WebCore::LocalStorageTask::LocalStorageTask): Added local storage task type DeleteEmptyDatabase. (WebCore::LocalStorageTask::performTask): Ditto.
  • storage/LocalStorageTask.h: (WebCore::LocalStorageTask::): Ditto. (WebCore::LocalStorageTask::createDeleteEmptyDatabase): Ditto.
  • storage/StorageAreaSync.cpp: (WebCore::StorageAreaSync::scheduleFinalSync): When scheduling final sync, also schedule DeleteEmptyDatabase. (WebCore::StorageAreaSync::sync): Return early if final sync has nothing to sync. (WebCore::StorageAreaSync::deleteEmptyDatabase): Added function to check if a database is empty and in that case delete it.
  • storage/StorageAreaSync.h: Ditto.
  • storage/StorageSyncManager.cpp: (WebCore::StorageSyncManager::scheduleDeleteEmptyDatabase): Added function for scheduling DeleteEmptyDatabase task.
  • storage/StorageSyncManager.h: Ditto.
7:36 AM Changeset in webkit [61541] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2010-06-21 Kent Tamura <​tkent@chromium.org>

Reviewed by Dimitri Glazkov.

[DRT/Chromium] Initialization for http/tests/loading/
​https://bugs.webkit.org/show_bug.cgi?id=40902

  • DumpRenderTree/chromium/TestShell.cpp: (TestShell::runFileTest):
7:08 AM Changeset in webkit [61540] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-06-21 Balazs Kelemen <​kb@inf.u-szeged.hu>

Reviewed by Simon Hausmann.

[Qt] Avoid unnecessary image conversion in RGBA32Buffer::zeroFill()
​https://bugs.webkit.org/show_bug.cgi?id=40910

  • platform/image-decoders/qt/RGBA32BufferQt.cpp: (WebCore::RGBA32Buffer::zeroFill):
6:37 AM Changeset in webkit [61539] by mnaganov@chromium.org
  • 6 edits
    1 add in trunk/WebKit/chromium

2010-06-21 Mikhail Naganov <​mnaganov@chromium.org>

Reviewed by NOBODY (OOPS!).

[Chromium] Remove usage of static WebDevToolsAgentClient::sendMessageToFrontendOnIOThread.

Also, move WebDevToolsMessageTransport to its own header file.

​https://bugs.webkit.org/show_bug.cgi?id=40913

  • DEPS:
  • WebKit.gyp:
  • public/WebDevToolsAgent.h:
  • public/WebDevToolsAgentClient.h:
  • public/WebDevToolsMessageTransport.h: Added. (WebKit::WebDevToolsMessageTransport::~WebDevToolsMessageTransport):
  • src/WebDevToolsAgentImpl.cpp: (WebKit::):
5:14 AM Changeset in webkit [61538] by Laszlo Gombos
  • 2 edits in trunk/WebKit/qt

2010-06-21 Laszlo Gombos <Laszlo Gombos>

Unreviewed, Symbian build fix.

[Qt] Update the def file with recent new exports.

  • symbian/eabi/QtWebKitu.def:
4:43 AM Changeset in webkit [61537] by Simon Hausmann
  • 2 edits in trunk/WebKit/qt

Unreviewed build fix.

[Qt] Fix package builds

Don't use rpath unless we're building inside the trunk.

  • declarative/declarative.pro:
2:40 AM Changeset in webkit [61536] by jocelyn.turcotte@nokia.com
  • 2 edits in trunk/JavaScriptCore

[Qt] Work around a build problem with libjscore on Symbian.
​https://bugs.webkit.org/show_bug.cgi?id=40840

Reviewed by Simon Hausmann.

Sbsv2 sometimes have problems with debug/release configuration
determination causing QtWebKit in release to try linking with the debug
JavaScriptCore static library. This patch limit the jscore/jscored
r58306 fix necessary for mac builds only to the mac platform to prevent the
different name problem.

The real fix would be to fix qmake or the toolchain, this patch might
help meanwhile.

2:33 AM Changeset in webkit [61535] by jocelyn.turcotte@nokia.com
  • 2 edits in trunk/WebKitTools

Adding myself to the committers list.

Unreviewed.

  • Scripts/webkitpy/common/config/committers.py:
1:30 AM Changeset in webkit [61534] by eric@webkit.org
  • 4 edits in trunk/WebCore

2010-06-21 Benjamin Poulain <​benjamin.poulain@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Decode images directly to QPixmap
​https://bugs.webkit.org/show_bug.cgi?id=40797

Decode images to QPixmap directly instead of QImage when possible.
RGBA32Buffer transforms the pixmap back to image if
necessary.

This improve the performance with certain graphic system, and
can reduce memory usage.

  • platform/graphics/qt/ImageDecoderQt.cpp: (WebCore::ImageDecoderQt::setData): (WebCore::ImageDecoderQt::internalHandleCurrentImage):
  • platform/image-decoders/ImageDecoder.h: (WebCore::RGBA32Buffer::getAddr):
  • platform/image-decoders/qt/RGBA32BufferQt.cpp: (WebCore::RGBA32Buffer::clear): (WebCore::RGBA32Buffer::zeroFill): (WebCore::RGBA32Buffer::copyBitmapData): (WebCore::RGBA32Buffer::setSize): (WebCore::RGBA32Buffer::asNewNativeImage): (WebCore::RGBA32Buffer::setPixmap):
1:10 AM Changeset in webkit [61533] by eric@webkit.org
  • 2 edits in trunk/JavaScriptCore

2010-06-21 Patrick Gansterer <​paroga@paroga.com>

Reviewed by Kent Tamura.

Buildfix after r61338.
​https://bugs.webkit.org/show_bug.cgi?id=40888

roundUpAllocationSize is needed in RegisterFile.h.

  • jit/ExecutableAllocator.h:
12:59 AM Changeset in webkit [61532] by dumi@chromium.org
  • 3 edits in trunk/LayoutTests

Unreviewed, fixing expectations.

  • platform/gtk/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/gtk/fast/js/global-constructors-expected.txt:
12:10 AM Changeset in webkit [61531] by dumi@chromium.org
  • 32 edits
    2 adds in trunk

Adding the SQLException class which will be used to report sync DB errors.
​https://bugs.webkit.org/show_bug.cgi?id=40607

Reviewed by Adam Barth.

WebCore:

  • Android.derived.jscbindings.mk:
  • Android.derived.v8bindings.mk:
  • CMakeLists.txt:
  • DerivedSources.cpp:
  • DerivedSources.make:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pri:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSDOMBinding.cpp:

(WebCore::setDOMException):

  • bindings/js/JSExceptionBase.cpp:

(WebCore::toExceptionBase):

  • bindings/v8/V8Proxy.cpp:

(WebCore::V8Proxy::setDOMException):

  • bindings/v8/V8Proxy.h:
  • dom/ExceptionCode.cpp:

(WebCore::):
(WebCore::getExceptionCodeDescription):

  • dom/ExceptionCode.h:

(WebCore::):

  • page/DOMWindow.idl:
  • storage/SQLException.h: Added.

(WebCore::SQLException::create):
(WebCore::SQLException::):
(WebCore::SQLException::SQLException):

  • storage/SQLException.idl: Added.

LayoutTests:

  • fast/dom/Window/window-properties-expected.txt:
  • fast/dom/Window/window-property-descriptors-expected.txt:
  • fast/dom/prototype-inheritance-expected.txt:
  • fast/js/global-constructors-expected.txt:
  • platform/chromium/fast/dom/prototype-inheritance-expected.txt:
  • platform/gtk/fast/dom/Window/window-properties-expected.txt:
  • platform/gtk/fast/dom/prototype-inheritance-expected.txt:
  • platform/qt/fast/dom/Window/window-properties-expected.txt:
  • platform/qt/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/qt/fast/dom/prototype-inheritance-expected.txt:
  • platform/qt/fast/js/global-constructors-expected.txt:
  • platform/win/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/win/fast/js/global-constructors-expected.txt:
12:06 AM Changeset in webkit [61530] by eric@webkit.org
  • 1 edit
    12 adds in trunk/LayoutTests

2010-06-20 Hayato Ito <​hayato@chromium.org>

Reviewed by Kent Tamura.

Add tests for CSS3 Paged Media to make sure page breaks should happen at right places.
Two tests (allowed-page-break and page-break-margin-collapsed) are expected to fail
due to lack of support.

​https://bugs.webkit.org/show_bug.cgi?id=40770

  • printing/allowed-page-breaks-expected.txt: Added.
  • printing/allowed-page-breaks.html: Added.
  • printing/no-content-empty-pages-expected.txt: Added.
  • printing/no-content-empty-pages.html: Added.
  • printing/page-break-display-none-expected.txt: Added.
  • printing/page-break-display-none.html: Added.
  • printing/page-break-margin-collapsed-expected.txt: Added.
  • printing/page-break-margin-collapsed.html: Added.
  • printing/script-tests/allowed-page-breaks.js: Added. (test):
  • printing/script-tests/no-content-empty-pages.js: Added. (test):
  • printing/script-tests/page-break-display-none.js: Added. (test):
  • printing/script-tests/page-break-margin-collapsed.js: Added. (test):

Jun 20, 2010:

11:44 PM Changeset in webkit [61529] by yurys@chromium.org
  • 5 edits in trunk

2010-06-20 Yury Semikhatsky <​yurys@chromium.org>

Reviewed by Pavel Feldman.

[v8] Web Inspector: don't add ScriptDebugServer as v8 listener if browser exposes
v8 debugging protocol.
​https://bugs.webkit.org/show_bug.cgi?id=40844

  • bindings/v8/ScriptDebugServer.cpp: (WebCore::ScriptDebugServer::ScriptDebugServer): (WebCore::ScriptDebugServer::addListener): (WebCore::ScriptDebugServer::setEnabled): (WebCore::ScriptDebugServer::isDebuggerAlwaysEnabled):
  • bindings/v8/ScriptDebugServer.h:

2010-06-20 Yury Semikhatsky <​yurys@chromium.org>

Reviewed by Pavel Feldman.

[v8] Web Inspector: don't add ScriptDebugServer as v8 listener if browser exposes
v8 debugging protocol.

  • src/DebuggerAgentManager.cpp: (WebKit::DebuggerAgentManager::setExposeV8DebuggerProtocol):
10:28 PM Changeset in webkit [61528] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-06-20 Gyuyoung Kim <​gyuyoung.kim@samsung.com>

Unreviewed build fix.

[EFL] Build break for r61527
​https://bugs.webkit.org/post_bug.cgi

  • CMakeLists.txt: Add loader/FormSubmission.cpp
9:38 PM Changeset in webkit [61527] by tkent@chromium.org
  • 5 edits in trunk/WebKitTools

2010-06-20 Kent Tamura <​tkent@chromium.org>

Reviewed by Dimitri Glazkov.

[DRT/Chromium] Add --allow-external-pages option
​https://bugs.webkit.org/show_bug.cgi?id=40762

Add --allow-external-pages introduced by Chromium r45403.
​http://src.chromium.org/viewvc/chrome?view=rev&revision=45403

  • DumpRenderTree/chromium/DumpRenderTree.cpp: (main):
  • DumpRenderTree/chromium/TestShell.cpp: (TestShell::TestShell):
  • DumpRenderTree/chromium/TestShell.h: (TestShell::allowExternalPages): (TestShell::setAllowExternalPages):
  • DumpRenderTree/chromium/WebViewHost.cpp: (WebViewHost::willSendRequest):
8:35 PM Changeset in webkit [61526] by andersca@apple.com
  • 2 edits in trunk/WebKit/mac

Fix Tiger build.

  • Plugins/WebNetscapePluginPackage.mm:
8:20 PM Changeset in webkit [61525] by andersca@apple.com
  • 4 edits in trunk/WebKit/mac

2010-06-20 Anders Carlsson <​andersca@apple.com>

Reviewed by Dan Bernstein.

Get rid of the old MIMETypes getter method
​https://bugs.webkit.org/show_bug.cgi?id=40898

  • Plugins/WebBasePluginPackage.h:
  • Plugins/WebBasePluginPackage.mm: (-[WebBasePluginPackage supportsExtension:]): (-[WebBasePluginPackage supportsMIMEType:WebCore::]): (-[WebBasePluginPackage MIMETypeForExtension:]):
  • Plugins/WebPluginDatabase.mm: (-[WebPluginDatabase refresh]): (-[WebPluginDatabase _removePlugin:]):
7:58 PM Changeset in webkit [61524] by andersca@apple.com
  • 5 edits in trunk

Remove bogus const qualifiers.

Reviewed by Dan Bernstein.

WebCore:

  • platform/mac/PasteboardHelper.h:

WebKit/mac:

  • WebCoreSupport/WebPasteboardHelper.h:
  • WebCoreSupport/WebPasteboardHelper.mm:

(WebPasteboardHelper::urlFromPasteboard):
(WebPasteboardHelper::plainTextFromPasteboard):
(WebPasteboardHelper::fragmentFromPasteboard):

7:34 PM Changeset in webkit [61523] by andersca@apple.com
  • 3 edits in trunk/WebKit/mac

2010-06-20 Anders Carlsson <​andersca@apple.com>

Reviewed by Dan Bernstein.

Get rid of the extensionToMIME mapping in WebBasePluginPackage
​https://bugs.webkit.org/show_bug.cgi?id=40897

Instead of using the extensionToMIME mutable dictionary, use the MIME types vector.
While this makes lookup of MIME types based on extensions linear instead of constant,
the number of extensions per plug-in is too small for it to matter.

  • Plugins/WebBasePluginPackage.h:
  • Plugins/WebBasePluginPackage.mm: (-[WebBasePluginPackage initWithPath:]): (-[WebBasePluginPackage dealloc]): (-[WebBasePluginPackage supportsExtension:]): (-[WebBasePluginPackage MIMETypeForExtension:]): (-[WebBasePluginPackage setMIMEToExtensionsDictionary:]):
7:13 PM Changeset in webkit [61522] by andersca@apple.com
  • 5 edits in trunk/WebKit/mac

2010-06-20 Anders Carlsson <​andersca@apple.com>

Reviewed by Dan Bernstein.

Add a MimeClassInfo Vector to WebBasePluginPackage
​https://bugs.webkit.org/show_bug.cgi?id=40896

  • Plugins/WebBasePluginPackage.h:
  • Plugins/WebBasePluginPackage.mm: (-[WebBasePluginPackage getPluginInfoFromPLists]): (-[WebBasePluginPackage WebCore::]):
  • Plugins/WebNetscapePluginPackage.mm: (-[WebNetscapePluginPackage getPluginInfoFromResources]):
  • WebCoreSupport/WebPlatformStrategies.mm: (WebPlatformStrategies::getPluginInfo):
7:12 PM Changeset in webkit [61521] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-06-20 Patrick Gansterer <​paroga@paroga.com>

Reviewed by Kent Tamura.

Buildfix for NotificationCenter.h.
​https://bugs.webkit.org/show_bug.cgi?id=40890

ScriptExecutionContext::completeURL is used in header,
but ScriptExecutionContext.h wasn't included.

  • notifications/NotificationCenter.h:
6:38 PM Changeset in webkit [61520] by tkent@chromium.org
  • 2 edits in trunk/LayoutTests

2010-06-20 Kent Tamura <​tkent@chromium.org>

Unreviewed, test expectation update.

  • platform/chromium/test_expectations.txt: Update for other <meter> tests and flaky/slow tests
6:30 PM Changeset in webkit [61519] by andersca@apple.com
  • 6 edits in trunk/WebKit/mac

2010-06-20 Anders Carlsson <​andersca@apple.com>

Reviewed by Dan Bernstein.

Move the NSBundle ivar to WebPluginPackage
​https://bugs.webkit.org/show_bug.cgi?id=40894

  • Plugins/WebBasePluginPackage.h:
  • Plugins/WebBasePluginPackage.mm: (-[WebBasePluginPackage initWithPath:]): (-[WebBasePluginPackage _objectForInfoDictionaryKey:]): (-[WebBasePluginPackage getPluginInfoFromPLists]): (-[WebBasePluginPackage load]): (-[WebBasePluginPackage dealloc]):
  • Plugins/WebNetscapePluginPackage.mm: (-[WebNetscapePluginPackage _initWithPath:]):
  • Plugins/WebPluginPackage.h:
  • Plugins/WebPluginPackage.mm: (-[WebPluginPackage initWithPath:]): (-[WebPluginPackage dealloc]): (-[WebPluginPackage viewFactory]): (-[WebPluginPackage load]):
6:05 PM Changeset in webkit [61518] by eric@webkit.org
  • 10 edits
    4 adds in trunk

2010-06-20 Tony Gentilcore <​tonyg@chromium.org>

Reviewed by Eric Seidel.

Test to make sure parsing of async attribute works for HTML script tags
and test to make sure that async is not parsed for SVG script tags.
​https://bugs.webkit.org/show_bug.cgi?id=39026

  • fast/dom/HTMLScriptElement/script-async-attr-expected.txt: Added.
  • fast/dom/HTMLScriptElement/script-async-attr.html: Added.
  • svg/dom/SVGScriptElement/script-async-attr-expected.txt: Added.
  • svg/dom/SVGScriptElement/script-async-attr.svg: Added.

2010-06-20 Tony Gentilcore <​tonyg@chromium.org>

Reviewed by Eric Seidel.

Recognize async attribute on HTML script tags.
​https://bugs.webkit.org/show_bug.cgi?id=39026

This does not implement async behavior, it only parses the async
attribute for HTML script tags. SVG script tags continue to not
support the async attribute.

Tests: fast/dom/HTMLScriptElement/script-async-attr.html

svg/dom/SVGScriptElement/script-async-attr.svg

  • dom/ScriptElement.cpp: (WebCore::ScriptElementData::isAsynchronous): (WebCore::ScriptElementData::isDeferred):
  • dom/ScriptElement.h:
  • html/HTMLAttributeNames.in:
  • html/HTMLScriptElement.cpp: (WebCore::HTMLScriptElement::async): (WebCore::HTMLScriptElement::setAsync): (WebCore::HTMLScriptElement::defer): (WebCore::HTMLScriptElement::asyncAttributeValue): (WebCore::HTMLScriptElement::deferAttributeValue):
  • html/HTMLScriptElement.h:
  • html/HTMLScriptElement.idl:
  • svg/SVGScriptElement.cpp: (WebCore::SVGScriptElement::asyncAttributeValue): (WebCore::SVGScriptElement::deferAttributeValue):
  • svg/SVGScriptElement.h:
5:44 PM Changeset in webkit [61517] by tony@chromium.org
  • 1 edit
    1 delete in trunk/LayoutTests

2010-06-20 Tony Chang <​tony@chromium.org>

Not reviewed, just cleaning up svn.

Removing platform/mac-snowleopard/editing since it's empty. The test
results were moved in r60693.

  • platform/mac-snowleopard/editing: Removed.
  • platform/mac-snowleopard/editing/spelling: Removed.
4:15 PM Changeset in webkit [61516] by jberlin@webkit.org
  • 4 edits in trunk/WebKit2

2010-06-20 Jessie Berlin <​jberlin@apple.com>

Reviewed by Dan Bernstein.

Add #if USE(PLATFORM_STRATEGIES) where WebPlatformStrategies is being used.

  • WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:
  • WebProcess/WebCoreSupport/WebPlatformStrategies.h:
  • WebProcess/WebProcess.cpp: (WebKit::WebProcess::WebProcess): Only initialize the web platform strategies if PLATFORM_STRATEGIES is being used.
3:51 PM Changeset in webkit [61515] by eric@webkit.org
  • 3 edits in trunk/WebKitTools

2010-06-20 Joseph Pecoraro <Joseph Pecoraro>

Reviewed by Adam Barth.

Sheriffbot: Should allow "r" in SVN_REVISION
​https://bugs.webkit.org/show_bug.cgi?id=40889

  • Scripts/webkitpy/tool/bot/irc_command.py: remove a leading "r" from SVN_REVISION if it exists
  • Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py: test an SVN_REVISION with a leading r.
3:32 PM Changeset in webkit [61514] by eric@webkit.org
  • 6 edits
    1 add in trunk/WebCore

2010-06-20 Nikita Vasilyev <​me@elv1s.ru>

Reviewed by Joseph Pecoraro.

Web Inspector: Auto-completion for CSS property names in Styles pane
​https://bugs.webkit.org/show_bug.cgi?id=17374

Added autocompletion for CSS properties. A suggestion for a property
shows when you type. You can also cycle through known property names
using the Up and Down arrow keys.

  • WebCore.gypi:
  • inspector/front-end/CSSCompletions.js: Added. (WebInspector.CSSCompletions): (WebInspector.CSSCompletions.startsWith): (WebInspector.CSSCompletions.firstStartsWith): (WebInspector.CSSCompletions._firstIndexOfPrefix): (WebInspector.CSSCompletions.next): (WebInspector.CSSCompletions.previous): (WebInspector.CSSCompletions._closest):
  • inspector/front-end/StylesSidebarPane.js: (WebInspector.StylePropertyTreeElement.prototype):
  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/inspector.html:
  • inspector/front-end/utilities.js: (Text.prototype.select): ():
2:30 PM Changeset in webkit [61513] by Joseph Pecoraro
  • 2 edits in trunk/WebKitTools

2010-06-20 Joseph Pecoraro <Joseph Pecoraro>

Reviewed by Dimitri Glazkov.

Python Tests Fail after r61508
​https://bugs.webkit.org/show_bug.cgi?id=40891

Test's regex list needed to be updated to match the new
regex list in the source code. Added new bots to the
example_buildbots list.

Regex list fixed in r61512. Updated bot list.

  • Scripts/webkitpy/common/net/buildbot_unittest.py:
2:14 PM Changeset in webkit [61512] by Dimitri Glazkov
  • 2 edits in trunk/WebKitTools

2010-06-20 Dimitri Glazkov <Dimitri Glazkov>

Unreviewed, build fix.

Tweak test regexp list to match the change in ​http://trac.webkit.org/changeset/61508.

  • Scripts/webkitpy/common/net/buildbot_unittest.py: Tweaked regexp.
2:00 PM Changeset in webkit [61511] by Dimitri Glazkov
  • 11 edits
    2 adds in trunk/WebCore

2010-06-14 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Darin Adler.

Introduce FormSubmission, the structure representing a form submission.
​https://bugs.webkit.org/show_bug.cgi?id=40084

No change in functionality, covered by existing tests.

  • GNUmakefile.am: Added FormSubmission.h/cpp.
  • WebCore.gypi: Ditto.
  • WebCore.pro: Ditto.
  • WebCore.vcproj/WebCore.vcproj: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::prepareFormSubmission): Renamed prepareFormData to prepareFormSubmission,

added code for populating a FormSubmission instance, moved the loop of accumulating text input
values into this functions (it belongs here logically).

(WebCore::HTMLFormElement::submit): Modified to use prepareFormSubmission.

  • html/HTMLFormElement.h:
  • loader/FormSubmission.cpp: Added.
  • loader/FormSubmission.h: Added.
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::submitForm): Modified to use FormSubmission. Stopped plumbing further to keep

the patch size down.

  • loader/FrameLoader.h: Modified submitForm signature.
1:53 PM Changeset in webkit [61510] by andersca@apple.com
  • 9 edits in trunk/WebKit/mac

2010-06-20 Anders Carlsson <​andersca@apple.com>

Reviewed by Sam Weinig.

Remove -[WebBasePluginPackage bundle]
​https://bugs.webkit.org/show_bug.cgi?id=40892

Add -[WebBasePluginPackage bundleIdentifier] and switch clients over to it.


Move the supportsSnapshotting method over to the plug-in package.


  • Plugins/Hosted/NetscapePluginHostManager.mm: (WebKit::NetscapePluginHostManager::hostForPackage):
  • Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView initWithFrame:pluginPackage:URL:baseURL:MIMEType:attributeKeys:attributeValues:loadManually:element:WebCore::]): (-[WebBaseNetscapePluginView supportsSnapshotting]):
  • Plugins/WebBasePluginPackage.h:
  • Plugins/WebBasePluginPackage.mm: (-[WebBasePluginPackage isQuickTimePlugIn]): (-[WebBasePluginPackage isJavaPlugIn]): (-[WebBasePluginPackage WebCore::]): Call bundleIdentifier directly instead of asking the bundle
  • Plugins/WebNetscapePluginPackage.h:
  • Plugins/WebNetscapePluginPackage.mm: (-[WebNetscapePluginPackage supportsSnapshotting]):
  • Plugins/WebNetscapePluginView.mm: (-[WebNetscapePluginView setAttributeKeys:andValues:]): (-[WebNetscapePluginView _createPlugin]):
  • Plugins/WebPluginDatabase.mm: (checkCandidate):
1:27 PM Changeset in webkit [61509] by andersca@apple.com
  • 7 edits in trunk/WebKit/mac

2010-06-20 Anders Carlsson <​andersca@apple.com>

Reviewed by Dan Bernstein.

Change some WebPluginDabase ivars to use WebCore::String instead of NSString.
​https://bugs.webkit.org/show_bug.cgi?id=40869


Re-land r61459, with extra null-checks in WebFrameLoaderClient.

  • Plugins/Hosted/NetscapePluginHostManager.mm: (WebKit::NetscapePluginHostManager::spawnPluginHost):
  • Plugins/WebBasePluginPackage.h:
  • Plugins/WebBasePluginPackage.mm: (-[WebBasePluginPackage initWithPath:]): (-[WebBasePluginPackage getPluginInfoFromPLists]): (-[WebBasePluginPackage dealloc]): (-[WebBasePluginPackage name]): (-[WebBasePluginPackage path]): (-[WebBasePluginPackage filename]): (-[WebBasePluginPackage pluginDescription]): (-[WebBasePluginPackage description]): (-[WebBasePluginPackage isJavaPlugIn]):
  • Plugins/WebNetscapePluginPackage.mm: (-[WebNetscapePluginPackage getPluginInfoFromResources]): (-[WebNetscapePluginPackage _tryLoad]): (-[WebNetscapePluginPackage _unloadWithShutdown:]):
  • Plugins/WebPluginPackage.mm: (-[WebPluginPackage load]):
  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::createPlugin):
11:58 AM Changeset in webkit [61508] by wsiegrist@apple.com
  • 1 edit in trunk/WebKitTools/Scripts/webkitpy/common/net/buildbot.py

2010-06-20 William Siegrist <​wsiegrist@apple.com>

Unreviewed. Make core builder regexp more specific so new Chromium test slaves do not get core builder status.

11:55 AM Changeset in webkit [61507] by Joseph Pecoraro
  • 2 edits in trunk/WebCore

2010-06-20 Joseph Pecoraro <Joseph Pecoraro>

Unreviewed rollout r61506, because it made 1 test crash.

Causes crash. Will approach the solution in a different way.

10:02 AM Changeset in webkit [61506] by Joseph Pecoraro
  • 2 edits in trunk/WebCore

2010-06-20 Joseph Pecoraro <Joseph Pecoraro>

Reviewed by Timothy Hatcher.

Web Inspector: Should Autocomplete Style Properties
​https://bugs.webkit.org/show_bug.cgi?id=38448

This Autocompletes style properties when in the console.

  • inspector/front-end/InjectedScript.js: (injectedScriptConstructor):
5:54 AM Changeset in webkit [61505] by robert@webkit.org
  • 5 edits in trunk

2010-06-20 Robert Hogan <​robert@webkit.org>

Reviewed by Simon Hausmann.

[Qt] NPP_SetWindow seems to not be called when TestNetscapePlugin is moved

​https://bugs.webkit.org/show_bug.cgi?id=36702

setNPWindowIfNeeded() is called on paint() in PluginViewQt, which doesn't
work for DRT. So call it if we are in DRT mode and the window geometry
has changed.

Unskips plugins/reentrant-update-widget-positions.html

  • platform/qt/Skipped:

2010-06-20 Robert Hogan <​robert@webkit.org>

Reviewed by Simon Hausmann.

[Qt] NPP_SetWindow seems to not be called when TestNetscapePlugin is moved

​https://bugs.webkit.org/show_bug.cgi?id=36702

setNPWindowIfNeeded() is called on paint() in PluginViewQt, which doesn't
work for DRT. So call it if we are in DRT mode and the window geometry
has changed.

Unskips plugins/reentrant-update-widget-positions.html

  • plugins/qt/PluginViewQt.cpp: (WebCore::PluginView::updatePluginWidget):
4:46 AM Changeset in webkit [61504] by eric@webkit.org
  • 3 edits in trunk/WebKit/qt

2010-06-20 Jedrzej Nowacki <​jedrzej.nowacki@nokia.com>

Reviewed by Simon Hausmann.

The QWebHistory regression fix.

After change r51629 and r61207 QWebHistory's function back(),
forward(), goToItem() got broken.

Use page->goToItem() instead of direct actions on the BackForwardList.

[Qt] REGRESSION(r61207): qwebhistory unit test hangs
​https://bugs.webkit.org/show_bug.cgi?id=40672

  • Api/qwebhistory.cpp: (QWebHistory::back): (QWebHistory::forward): (QWebHistory::goToItem):
  • tests/qwebhistory/tst_qwebhistory.cpp: (tst_QWebHistory::init): (tst_QWebHistory::back): (tst_QWebHistory::forward):
Note: See TracTimeline for information about the timeline view.