⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Jun 24, 2010:

11:33 PM Changeset in webkit [61833] by zherczeg@webkit.org
  • 5 edits in trunk/JavaScriptCore

Merge RegExp constructor and RegExp::create methods into one.
Both of function are called with tree parameters and check whether
flags (the third param) is given or not.
Simplify hash lookups in RegExpCache::create with giving them an extra
iterator parameter.
​https://bugs.webkit.org/show_bug.cgi?id=41055

Patch by Renata Hodovan <​reni@inf.u-szeged.hu> on 2010-06-24
Reviewed by Geoffrey Garen.

  • runtime/RegExp.cpp:

(JSC::RegExp::RegExp):

  • runtime/RegExp.h:
  • runtime/RegExpCache.cpp:

(JSC::RegExpCache::lookupOrCreate):
(JSC::RegExpCache::create):

  • runtime/RegExpCache.h:
11:26 PM Changeset in webkit [61832] by hclam@chromium.org
  • 2 edits
    3 adds in trunk/LayoutTests

Unreviewed. Build fix.

Update test expectations for chromium.

  • platform/chromium-mac/fast/history/timed-refresh-in-cached-frame-expected.txt: Added.
  • platform/chromium-win/fast/history/timed-refresh-in-cached-frame-expected.txt: Added.
  • platform/chromium-win/fast/images/icon-decoding-expected.txt:
11:22 PM Changeset in webkit [61831] by abarth@webkit.org
  • 3 edits in trunk/WebKitTools

2010-06-24 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

commit-queue is taking too long to land patches because of red trees
​https://bugs.webkit.org/show_bug.cgi?id=41194

Instead of checking for the tree to be green, we'll just spin hot
trying to land patches. This is probably too extreme in ignoring the
tree, but I think we should try it for a while to see if we have
trouble. That will help us find the right balance.

  • Scripts/webkitpy/tool/commands/queues.py:
  • Scripts/webkitpy/tool/commands/queues_unittest.py:
11:18 PM Changeset in webkit [61830] by oliver@apple.com
  • 3 edits in trunk/JavaScriptCore

2010-06-24 Oliver Hunt <​oliver@apple.com>

Reviewed by Maciej Stachowiak.

Incorrect use of '+ 4' and 0 instead of tag and payload offsets in JSValue32_64
​https://bugs.webkit.org/show_bug.cgi?id=41193

I noticed a use of '+ 4' in some of the 32_64 code paths and realised there
were a few places where endianness was being hardcoded. This patch fixes
the errors i could find through code inspection.

  • jit/JITOpcodes32_64.cpp: (JSC::JIT::emit_op_resolve_global):
  • jit/JITPropertyAccess32_64.cpp: (JSC::JIT::emit_op_get_by_val): (JSC::JIT::emit_op_put_by_val): (JSC::JIT::compileGetDirectOffset): (JSC::JIT::privateCompilePutByIdTransition): (JSC::JIT::patchGetByIdSelf): (JSC::JIT::patchPutByIdReplace):
10:45 PM Changeset in webkit [61829] by mrowe@apple.com
  • 5 edits in tags/Safari-534.1.2/WebCore

Roll out r61638 to address <rdar://problem/8122799>.

10:45 PM Changeset in webkit [61828] by mrowe@apple.com
  • 1 edit
    2 adds in tags/Safari-534.1.2/WebKit2

Merge r61820.

10:45 PM Changeset in webkit [61827] by mrowe@apple.com
  • 5 edits in tags/Safari-534.1.2

Versioning.

10:37 PM Changeset in webkit [61826] by mrowe@apple.com
  • 1 copy in tags/Safari-534.1.2

New tag.

10:36 PM Changeset in webkit [61825] by abarth@webkit.org
  • 3 edits in trunk/WebCore

2010-06-24 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Sketch out AfterHeadMode for tree builder
​https://bugs.webkit.org/show_bug.cgi?id=41191

This mode is fairly similar to the others. I needed to change some of
the types around w.r.t. Nodes/Elements.

  • html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::HTMLTreeBuilder): (WebCore::HTMLTreeBuilder::processToken): (WebCore::HTMLTreeBuilder::insertElement):
  • html/HTMLTreeBuilder.h: (WebCore::HTMLTreeBuilder::ElementStack::push): (WebCore::HTMLTreeBuilder::ElementStack::remove):
10:35 PM Changeset in webkit [61824] by abarth@webkit.org
  • 2 edits in trunk/WebCore

2010-06-24 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Sketch out InHeadNoscriptMode for tree builder
​https://bugs.webkit.org/show_bug.cgi?id=41189

Lots of notImplemented() calls in this state. I need to figure how to
delegate handling of a token from one state to another.

  • html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processToken):
10:33 PM Changeset in webkit [61823] by abarth@webkit.org
  • 3 edits in trunk/WebCore

2010-06-24 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Sketch out InHeadMode for tree builder
​https://bugs.webkit.org/show_bug.cgi?id=41184

This state is relatively straightforward. We introduce the stack of
open elements to track that notion in the spec. The old tree builder
has a nice data structure for that, which we'll probably steal, but I'd
like to see what the full API is first.

  • html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processToken): (WebCore::HTMLTreeBuilder::insertCharacter): (WebCore::HTMLTreeBuilder::insertGenericRCDATAElement): (WebCore::HTMLTreeBuilder::insertGenericRawTextElement): (WebCore::HTMLTreeBuilder::insertScriptElement):
  • html/HTMLTreeBuilder.h: (WebCore::HTMLTreeBuilder::ElementStack::pop): (WebCore::HTMLTreeBuilder::ElementStack::top):
10:31 PM Changeset in webkit [61822] by abarth@webkit.org
  • 4 edits in trunk/WebCore

2010-06-24 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Sketch out BeforeHeadMode tree builder state
​https://bugs.webkit.org/show_bug.cgi?id=41183

This makes procesToken recursive, which might not be the best idea.
Also, we can now make fake AtomicHTMLTokens for use by the algorithm.

  • html/HTMLToken.h: (WebCore::AtomicHTMLToken::AtomicHTMLToken):
  • html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processToken): (WebCore::HTMLTreeBuilder::insertElement):
  • html/HTMLTreeBuilder.h:
10:24 PM Changeset in webkit [61821] by abarth@webkit.org
  • 2 edits in trunk/LayoutTests

2010-06-24 Adam Barth <​abarth@webkit.org>

Unreviewed.

Update GTK expectations for fast/images/icon-decoding.html because
Peter is lazy. :)

  • platform/gtk/fast/images/icon-decoding-expected.txt:
9:49 PM Changeset in webkit [61820] by sfalken@apple.com
  • 1 edit
    2 adds in trunk/WebKit2

Windows build fix.

  • win/WebKit2.make: Added.
  • win/WebKit2.submit.sln: Added.
9:45 PM Changeset in webkit [61819] by tonikitoo@webkit.org
  • 17 edits in trunk/LayoutTests

2010-06-24 Antonio Gomes <​tonikitoo@webkit.org>

Reviewed by Kenneth Christiansen.

Spatial Navigation: refactor spatial-navigation-utils.js to support testing nested frames deeper than one level
​https://bugs.webkit.org/show_bug.cgi?id=41157

As is today, we can not test focused nodes in inner frames nested more than one level
deep, due to spatial-navigation-utils.js limitations. Patch addresses this problem:
any time before any focus check, it retrieves the proper focused frame in any level deep.

All spatial navigation test results changed output because the parameter passed in to
shouldBeEqualToString (from js-pre-test.js) changed in spatial-navigation-utils.js.

  • fast/events/spatial-navigation/resources/spatial-navigation-utils.js: (initTest): (verifyAndAdvance): (findFocusedDocument):
  • fast/events/spatial-navigation/snav-clipped-overflowed-content-expected.txt:
  • fast/events/spatial-navigation/snav-div-scrollable-but-without-focusable-content-expected.txt:
  • fast/events/spatial-navigation/snav-fully-aligned-horizontally-expected.txt:
  • fast/events/spatial-navigation/snav-fully-aligned-vertically-expected.txt:
  • fast/events/spatial-navigation/snav-iframe-flattening-simple-expected.txt:
  • fast/events/spatial-navigation/snav-iframe-no-focusable-content-expected.txt:
  • fast/events/spatial-navigation/snav-iframe-no-scrollable-content-expected.txt:
  • fast/events/spatial-navigation/snav-iframe-recursive-offset-parent-expected.txt:
  • fast/events/spatial-navigation/snav-iframe-with-offscreen-focusable-element-expected.txt:
  • fast/events/spatial-navigation/snav-offscreen-content-expected.txt:
  • fast/events/spatial-navigation/snav-only-clipped-overflow-content-expected.txt:
  • fast/events/spatial-navigation/snav-simple-content-overflow-expected.txt:
  • fast/events/spatial-navigation/snav-table-traversal-expected.txt:
  • fast/events/spatial-navigation/snav-tiny-table-traversal-expected.txt:
  • fast/events/spatial-navigation/snav-unit-overflow-and-scroll-in-direction-expected.txt:
9:30 PM Changeset in webkit [61818] by tonikitoo@webkit.org
  • 7 edits
    2 adds in trunk/WebCore

2010-06-22 Antonio Gomes <​tonikitoo@webkit.org>

Reviewed by David Hyatt.

Add a NodeList-derivated wrapper class for a ListHashSet.
​https://bugs.webkit.org/show_bug.cgi?id=41081

StaticHashSetList will work as a wrapper to ListHashSet objects that are
aimed to be exposed to the DOM.

As a use case, the rect based HitTest (bug 40197) will store the retrieved nodes
in a ListHashSet. It is going to be exposed to the DOM through are nodesFromRect
of Document returning a NodeList (i.e. StatisHashSetList) wrapping a ListHashSet.

No new tests.

8:18 PM Changeset in webkit [61817] by oliver@apple.com
  • 2 edits in trunk/JavaScriptCore

Build fix

Temporarily get the tiger bot working again by disabling the
new JS parser. GCC on tiger is miscompiling the parser and
I don't have access to a tiger machine right now.

8:06 PM Changeset in webkit [61816] by jschuh@chromium.org
  • 3 edits
    3 adds in trunk

2010-06-24 Cris Neckar <​cdn@chromium.org>

Reviewed by Darin Fisher.

[Chromium] Out of bounds write in WebCore::PNGImageDecoder::rowAvailable
​https://bugs.webkit.org/show_bug.cgi?id=40798

Catches error in row callback for libPNG when extra rows are returned.

Test: fast/images/png-extra-row-crash.html

  • platform/image-decoders/png/PNGImageDecoder.cpp: (WebCore::PNGImageDecoder::rowAvailable):

2010-06-24 Cris Neckar <​cdn@chromium.org>

Reviewed by Darin Fisher.

[Chromium] Out of bounds write in WebCore::PNGImageDecoder::rowAvailable
​https://bugs.webkit.org/show_bug.cgi?id=40798

Tests a PNG with an extra row.

  • fast/images/png-extra-row-crash-expected.txt: Added.
  • fast/images/png-extra-row-crash.html: Added.
  • fast/images/resources/png-extra-row-crash.png: Added.
6:34 PM Changeset in webkit [61815] by eric@webkit.org
  • 4 edits in trunk

2010-06-24 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Clean up and document DocumentWriter::replaceDocument code path
​https://bugs.webkit.org/show_bug.cgi?id=41182

No functional changes, thus no tests.

  • loader/DocumentWriter.cpp: (WebCore::DocumentWriter::replaceDocument):
    • Remove comment which could be misleading.

2010-06-24 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Clean up and document DocumentWriter::replaceDocument code path
​https://bugs.webkit.org/show_bug.cgi?id=41182

  • src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::loadJavaScriptURL):
    • Make Chromium use DocumentWriter like it should.
6:28 PM Changeset in webkit [61814] by jamesr@google.com
  • 4 edits in trunk/LayoutTests

2010-06-24 James Robinson <​jamesr@chromium.org>

Unreviewed. Add mac pixel baselines for fast/images/icon-decoding and fix EOLs for text baseline.

  • platform/mac/fast/images/icon-decoding-expected.checksum:
  • platform/mac/fast/images/icon-decoding-expected.png:
  • platform/mac/fast/images/icon-decoding-expected.txt:
6:08 PM Changeset in webkit [61813] by pkasting@chromium.org
  • 2 edits in trunk/LayoutTests

Not reviewed, updating test baseline for changed test.

Update mac text baseline. Don't have a way to get an updated pixel diff
at the moment.
​https://bugs.webkit.org/show_bug.cgi?id=41107

  • platform/mac/fast/images/icon-decoding-expected.txt:
6:00 PM Changeset in webkit [61812] by dumi@chromium.org
  • 14 edits in trunk

WebCore: Implementing DatabaseSync::openDatabaseSync().
​https://bugs.webkit.org/show_bug.cgi?id=40607

Reviewed by Adam Barth.

Moved some common code from Database to AbstractDatabase. Made
performOpenAndVerify() virtual, since DatabaseSync doesn't need to
interact with DatabaseThread. Removed the m_creationCallback
field, since it's only needed in the openDatabase{Sync} methods.

  • storage/AbstractDatabase.cpp:

(WebCore::retrieveTextResultFromDatabase):
(WebCore::setTextValueInDatabase):
(WebCore::guidMutex):
(WebCore::guidToVersionMap):
(WebCore::updateGuidVersionMap):
(WebCore::guidToDatabaseMap):
(WebCore::guidForOriginAndName):
(WebCore::AbstractDatabase::databaseInfoTableName):
(WebCore::AbstractDatabase::AbstractDatabase):
(WebCore::AbstractDatabase::closeDatabase):
(WebCore::AbstractDatabase::version):
(WebCore::AbstractDatabase::performOpenAndVerify):
(WebCore::AbstractDatabase::scriptExecutionContext):
(WebCore::AbstractDatabase::securityOrigin):
(WebCore::AbstractDatabase::stringIdentifier):
(WebCore::AbstractDatabase::displayName):
(WebCore::AbstractDatabase::estimatedSize):
(WebCore::AbstractDatabase::fileName):
(WebCore::AbstractDatabase::databaseVersionKey):
(WebCore::AbstractDatabase::getVersionFromDatabase):
(WebCore::AbstractDatabase::setVersionInDatabase):
(WebCore::AbstractDatabase::versionMatchesExpected):
(WebCore::AbstractDatabase::setExpectedVersion):
(WebCore::AbstractDatabase::disableAuthorizer):
(WebCore::AbstractDatabase::enableAuthorizer):
(WebCore::AbstractDatabase::setAuthorizerReadOnly):
(WebCore::AbstractDatabase::lastActionChangedDatabase):
(WebCore::AbstractDatabase::lastActionWasInsert):
(WebCore::AbstractDatabase::resetDeletes):
(WebCore::AbstractDatabase::hadDeletes):
(WebCore::AbstractDatabase::resetAuthorizer):

  • storage/AbstractDatabase.h:

(WebCore::AbstractDatabase::opened):
(WebCore::AbstractDatabase::isNew):
(WebCore::AbstractDatabase::databaseDebugName):

  • storage/Database.cpp:

(WebCore::DatabaseCreationCallbackTask::create):
(WebCore::DatabaseCreationCallbackTask::performTask):
(WebCore::DatabaseCreationCallbackTask::DatabaseCreationCallbackTask):
(WebCore::Database::openDatabase):
(WebCore::Database::Database):
(WebCore::Database::version):
(WebCore::Database::openAndVerifyVersion):
(WebCore::Database::close):
(WebCore::Database::stop):
(WebCore::Database::performOpenAndVerify):

  • storage/Database.h:

(WebCore::Database::sqliteDatabase):

  • storage/DatabaseAuthorizer.cpp:

(WebCore::DatabaseAuthorizer::create):
(WebCore::DatabaseAuthorizer::DatabaseAuthorizer):
(WebCore::DatabaseAuthorizer::denyBasedOnTableName):

  • storage/DatabaseAuthorizer.h:
  • storage/DatabaseSync.cpp:

(WebCore::DatabaseSync::openDatabaseSync):
(WebCore::DatabaseSync::DatabaseSync):
(WebCore::DatabaseSync::changeVersion):
(WebCore::DatabaseSync::transaction):
(WebCore::DatabaseSync::markAsDeletedAndClose):
(WebCore::CloseSyncDatabaseOnContextThreadTask::create):
(WebCore::CloseSyncDatabaseOnContextThreadTask::performTask):
(WebCore::CloseSyncDatabaseOnContextThreadTask::CloseSyncDatabaseOnContextThreadTask):
(WebCore::DatabaseSync::closeImmediately):

  • storage/DatabaseSync.h:
  • storage/DatabaseTask.cpp:

(WebCore::DatabaseOpenTask::DatabaseOpenTask):
(WebCore::DatabaseOpenTask::doPerformTask):

  • storage/DatabaseTask.h:

(WebCore::DatabaseOpenTask::create):

LayoutTests: Uncomment all test cases in open-database-sync-inputs.
​https://bugs.webkit.org/show_bug.cgi?id=40607

Reviewed by Adam Barth.

  • fast/workers/storage/open-database-sync-inputs-expected.txt:
  • fast/workers/storage/resources/open-database-sync-inputs.js:

(catch):

5:50 PM Changeset in webkit [61811] by Martin Robinson
  • 2 edits
    2 adds in trunk/LayoutTests

2010-06-24 Martin Robinson <​mrobinson@igalia.com>

Unreviewed.

Adding GTK+-specific results for these tests.

  • platform/gtk/Skipped: Unskipping tests that now have baselines.
  • platform/gtk/fast/block/positioning/relative-positioned-inline-container-expected.txt: Added.
  • platform/gtk/fast/repaint/inline-relative-positioned-expected.txt: Added.
5:37 PM Changeset in webkit [61810] by mrowe@apple.com
  • 4 edits in tags/Safari-534.1.1

Merge r61806.

5:37 PM Changeset in webkit [61809] by mrowe@apple.com
  • 5 edits in tags/Safari-534.1.1

Versioning.

5:29 PM Changeset in webkit [61808] by Martin Robinson
  • 4 edits in trunk

2010-06-24 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] Cannot change the selection via the keyboard
​https://bugs.webkit.org/show_bug.cgi?id=41162

  • platform/gtk/Skipped: Unskip a test which is now passing.

2010-06-24 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] Cannot change the selection via the keyboard
​https://bugs.webkit.org/show_bug.cgi?id=41162

Fix issue where the selection could not be extended via the keyboard by
adjusting the logic guarding against inserting text in non-editable nodes.

  • WebCoreSupport/EditorClientGtk.cpp: (WebKit::EditorClient::handleKeyboardEvent): Allow editor commands that do not insert text in non-editable nodes. This fixes keyboard selection extension in non-editable nodes. Move the existing check to after the execution of any editor commands.
5:28 PM Changeset in webkit [61807] by mrowe@apple.com
  • 1 copy in tags/Safari-534.1.1

New tag.

5:24 PM Changeset in webkit [61806] by sfalken@apple.com
  • 4 edits in trunk

Windows build fix.

WebCore:

  • platform/network/cf/AuthenticationCF.h:

WebKit2:

  • win/WebKit2WebProcess.vcproj:
5:22 PM Changeset in webkit [61805] by Martin Robinson
  • 2 edits in trunk/WebKitTools

2010-06-24 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] Clean up the use of gdk_window_get_root_coords in EventSender
​https://bugs.webkit.org/show_bug.cgi?id=40843

Define the version for old GTK+s in a way that is forward-compatible
and clean up the logic a bit.

  • DumpRenderTree/gtk/EventSender.cpp: (gdk_window_get_root_coords): Renamed and cleaned up. (prepareMouseButtonEvent): Remove #ifdefs. (mouseMoveToCallback): Remove #ifdefs.
5:22 PM Changeset in webkit [61804] by tony@chromium.org
  • 2 edits in trunk/LayoutTests

2010-06-24 Tony Chang <​tony@chromium.org>

Not reviewed, just updating a comment.

include a bug link in skipped mac test
​https://bugs.webkit.org/show_bug.cgi?id=41185

  • platform/mac/Skipped: Updating a comment to include a bug link.
5:11 PM Changeset in webkit [61803] by weinig@apple.com
  • 7 edits
    1 add in trunk/WebKit2

Add WKBundlePageRenderTreeExternalRepresentation for WebKitTestRunner.

Reviewed by Brady Eidson.

  • WebKit2.xcodeproj/project.pbxproj:
  • WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:

(WKBundlePageRenderTreeExternalRepresentation):

  • WebProcess/InjectedBundle/API/c/WKBundlePagePrivate.h: Added.
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::renderTreeExternalRepresentation):
(WebKit::WebPage::getRenderTreeExternalRepresentation):

  • WebProcess/WebPage/WebPage.h:
  • mac/WebKit2.exp:
  • win/WebKit2.vcproj:
5:05 PM Changeset in webkit [61802] by Martin Robinson
  • 2 edits in trunk/WebCore

2010-06-24 Martin Robinson <​mrobinson@igalia.com>

Unreviewed. Build fix.

Fix the build after r61798.

  • platform/gtk/PasteboardHelper.cpp: (WebCore::PasteboardHelper::getClipboardContents):
4:58 PM Changeset in webkit [61801] by ap@apple.com
  • 5 edits
    2 adds in trunk

Reviewed by Brady Eidson.

​https://bugs.webkit.org/show_bug.cgi?id=41178
Timed refresh in subframes isn't stopped when going into b/f cache

Test: fast/history/timed-refresh-in-cached-frame.html

  • history/CachedFrame.cpp: (WebCore::CachedFrame::CachedFrame): Top frame's stopLoading() won't help cached subframes; stop loading from here.
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::stopLoading): Don't stop loading in child frames. This didn't work for cached frames due to frame tree having been already desonstructed, and it's not necessary in non-cached case because stopLoading() will be called for subframes via FrameLoader::detachFromParent() and closeURL(). (WebCore::FrameLoader::pageHidden): This was a second code path that dispatched pagehide event - it's no longer needed, because everything goes through FrameLoader::stopLoading(). (WebCore::FrameLoader::commitProvisionalLoad): Don't call pageHidden(), the code for adding frame to b/f cache will do everything.
  • loader/FrameLoader.h: Removed pageHidden().
4:57 PM Changeset in webkit [61800] by pkasting@chromium.org
  • 2 edits in trunk/LayoutTests

Not reviewed.

Fix earlier test change so it actually tests anything.
​https://bugs.webkit.org/show_bug.cgi?id=41107

  • fast/images/icon-decoding.html:
4:41 PM Changeset in webkit [61799] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-06-24 Eric Seidel <​eric@webkit.org>

Unreviewed. Fix the build. I am a bad man.

  • loader/DocumentWriter.cpp: (WebCore::DocumentWriter::replaceDocument):
4:34 PM Changeset in webkit [61798] by Martin Robinson
  • 3 edits in trunk/WebCore

2010-06-24 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Xan Lopez.

Build fix for building against GTK+ 3.x.

No new tests as functionality has not changed.

  • platform/gtk/GtkVersioning.h:
  • platform/gtk/PasteboardHelper.cpp: (WebCore::PasteboardHelper::getClipboardContents): (WebCore::PasteboardHelper::fillSelectionData):
4:28 PM Changeset in webkit [61797] by eric@webkit.org
  • 3 edits in trunk/WebCore

2010-06-24 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Clean up and document DocumentWriter::replaceDocument code path
​https://bugs.webkit.org/show_bug.cgi?id=41182

No functional change, thus no test.

  • loader/DocumentWriter.cpp: (WebCore::DocumentWriter::replaceDocument):
  • loader/DocumentWriter.h:
4:25 PM Changeset in webkit [61796] by jer.noble@apple.com
  • 7 edits in trunk

2010-06-24 Jer Noble <​jer.noble@apple.com>

Reviewed by Eric Carlson.

Full-screened content doesn't keep the display on: Safari not grabbing a power assertion?
​https://bugs.webkit.org/show_bug.cgi?id=40939
rdar://problem/7996172


Add IOKit.framework to the list of linked frameworks.

  • WebKit.xcodeproj/project.pbxproj:

2010-06-24 Jer Noble <​jer.noble@apple.com>

Reviewed by Eric Carlson.

Full-screened content doesn't keep the display on: Safari not grabbing a power assertion?
​https://bugs.webkit.org/show_bug.cgi?id=40939
rdar://problem/7996172


Take a IOKit power assertion when playing video in fullscreen mode. Release the
assertion when paused in fullscreen mode, and when exiting fullscreen mode.

  • WebView/WebVideoFullscreenController.h:
  • WebView/WebVideoFullscreenController.mm: (-[WebVideoFullscreenController windowDidExitFullscreen]): Call updatePowerAssertions. (-[WebVideoFullscreenController windowDidEnterFullscreen]): Call updatePowerAssertions. (-[WebVideoFullscreenController _disableIdleDisplaySleep]): (-[WebVideoFullscreenController _enableIdleDisplaySleep]): (-[WebVideoFullscreenController _disableIdleSystemSleep]): (-[WebVideoFullscreenController _enableIdleSystemSleep]): (-[WebVideoFullscreenController updatePowerAssertions]): Call _(enable|disable)Idle(System|Display)sleep depending on current playback rate and fullscreen status. (-[WebVideoFullscreenController rateChanged:]): Call updatePowerAssertions.

2010-06-24 Jer Noble <​jer.noble@apple.com>

Reviewed by Eric Carlson.

Full-screened content doesn't keep the display on: Safari not grabbing a power assertion?
​https://bugs.webkit.org/show_bug.cgi?id=40939
rdar://problem/7996172


Export -[MediaElement playbackRate];


  • WebCore.Video.exp:
4:12 PM Changeset in webkit [61795] by evan@chromium.org
  • 7 edits in trunk

2010-06-21 Evan Martin <​evan@chromium.org>

Reviewed by Adam Barth.

[chromium] overlapping characters in complex text
​https://bugs.webkit.org/show_bug.cgi?id=40966

New baselines, now that bug is fixed (e.g. the /M at the end was previously overlapping).

  • platform/chromium-linux/fast/text/international/thai-baht-space-expected.checksum:
  • platform/chromium-linux/fast/text/international/thai-baht-space-expected.png:
  • platform/chromium-linux/fast/text/atsui-spacing-features-expected.checksum:
  • platform/chromium-linux/fast/text/atsui-spacing-features-expected.png:

2010-06-21 Evan Martin <​evan@chromium.org>

Reviewed by Adam Barth.

[chromium] overlapping characters in complex text
​https://bugs.webkit.org/show_bug.cgi?id=40966

We need to clear all the buffers we hand to Harfbuzz before we use them.
While I'm here, refactor the code slightly to make its behavior more
clear and correct (previously, we would repeatedly double our buffer
size when we could have just sized it correctly on the second try).

  • platform/graphics/chromium/FontLinux.cpp: (WebCore::TextRunWalker::TextRunWalker): (WebCore::TextRunWalker::nextScriptRun): (WebCore::TextRunWalker::createGlyphArrays): (WebCore::TextRunWalker::shapeGlyphs):
3:49 PM Changeset in webkit [61794] by adele@apple.com
  • 4 edits in trunk

Updated fix for <rdar://problem/8093680> "Paste and Match Style" should fire paste events
​https://bugs.webkit.org/show_bug.cgi?id=41085

Reviewed by Sam Weinig.

WebCore:

Covered by existing tests.

  • editing/EditorCommand.cpp:

(WebCore::executePasteAsPlainText): Added.
(WebCore::createCommandMap): Added pasteAsPlainText command.

WebKit/mac:

  • WebView/WebHTMLView.mm: Use the WebCore command system for the pasteAsPlainText selector.

Also remove internal methods that no one is using.

3:39 PM Changeset in webkit [61793] by abarth@webkit.org
  • 3 edits in trunk/WebCore

2010-06-24 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Sketch out BeforeHTMLMode state
​https://bugs.webkit.org/show_bug.cgi?id=41133

In this patch, we switch the TreeBuidler over to using AtomicHTMLTokens
and sketch out another state. These states don't actually do anything
yet, I'm still just getting the structure of the spec into the code so
we can implement the details incrementally.

  • html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::constructTreeFromToken): (WebCore::HTMLTreeBuilder::processToken): (WebCore::HTMLTreeBuilder::insertDoctype): (WebCore::HTMLTreeBuilder::insertComment):
  • html/HTMLTreeBuilder.h: (WebCore::HTMLTreeBuilder::parseError):
3:31 PM Changeset in webkit [61792] by Dimitri Glazkov
  • 2 edits in trunk/WebKitTools

2010-06-24 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Eric Seidel.

Fix NewRunWebKitTests to work on Windows.
​https://bugs.webkit.org/show_bug.cgi?id=41180

  • BuildSlaveSupport/build.webkit.org-config/master.cfg: Added "perl" as first arguments,

because Windows fails to understand what we're asking of it.

3:07 PM Changeset in webkit [61791] by abarth@webkit.org
  • 3 edits in trunk/WebCore

2010-06-24 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Add AtomicHTMLToken
​https://bugs.webkit.org/show_bug.cgi?id=41131

We need an atomized version of the token for use in the tree builder.
Eventually, we should make the existing HTMLToken an internal detail of
the HTMLTokenizer. This new AtomicHTMLToken should be also be more
easily cached between the preload scanner and the tree builder.

  • html/HTMLToken.h: (WebCore::AtomicHTMLToken::AtomicHTMLToken): (WebCore::AtomicHTMLToken::type): (WebCore::AtomicHTMLToken::name): (WebCore::AtomicHTMLToken::selfClosing): (WebCore::AtomicHTMLToken::attributes): (WebCore::AtomicHTMLToken::characters): (WebCore::AtomicHTMLToken::comment): (WebCore::AtomicHTMLToken::publicIdentifier): (WebCore::AtomicHTMLToken::systemIdentifier): (WebCore::AtomicHTMLToken::forceQuirks):
  • html/HTMLTreeBuilder.cpp: (WebCore::convertToOldStyle): (WebCore::HTMLTreeBuilder::passTokenToLegacyParser):
3:07 PM Changeset in webkit [61790] by Martin Robinson
  • 2 edits in trunk/WebKitTools

2010-06-24 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] The url passed to the WebView during layout tests is invalid
​https://bugs.webkit.org/show_bug.cgi?id=40832

Set the test URL to the full real file URL and do a small cleanup.
Previously a URL like ​file://relative/path/to/test.html was passed
to the WebView. This malformed file URL would be returned by
webkit_web_view_get_url and webkit_web_frame_get_url.

  • DumpRenderTree/gtk/DumpRenderTree.cpp: (shouldLogFrameLoadDelegates): Change to take a const string& as the argument. (shouldOpenWebInspector): Change to take a const string& as the argument. (shouldEnableDeveloperExtras): Change to take a const string& as the argument. (runTest): Pass the full ​file:// URL to the view. Remove the superfluous url variable.
3:03 PM Changeset in webkit [61789] by eric@webkit.org
  • 10 edits
    1 copy in trunk/WebCore

2010-06-24 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Add RawDataDocumentParser to get rid of a bunch of copy/paste code in DocumentParser subclasses
​https://bugs.webkit.org/show_bug.cgi?id=41136

I think this is likely far from the final design,
however this is almost entirely minus lines which is a
good thing.

The original authors of these DocumentParser subclasses
seem to have just copied the files whole, as they all
had the same includes, many of which were unnecessary for
some of the files.

I think eventually the FrameLoader will call a virtual
DocumentParser::appendData which will in turn decode
and call another write/appendData call. In the case
of these RawDataDocumentParsers, they will just override
the low-level appendData call instead of needing
DocumentWriter to have a special if based on
DocumentParser::wantsRawData.

No functional change, thus no tests.

  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/DocumentParser.h: (WebCore::DocumentParser::writeRawData):
  • loader/ImageDocument.cpp: (WebCore::ImageDocumentParser::ImageDocumentParser): (WebCore::ImageDocumentParser::finish):
  • loader/MediaDocument.cpp: (WebCore::MediaDocumentParser::MediaDocumentParser): (WebCore::MediaDocumentParser::writeRawData):
  • loader/PluginDocument.cpp: (WebCore::PluginDocumentParser::PluginDocumentParser):
  • loader/SinkDocument.cpp: (WebCore::SinkDocument::createParser):
3:01 PM Changeset in webkit [61788] by pkasting@chromium.org
  • 5 edits
    1 add in trunk

WebCore: REGRESSION (r61619): Memory corruption in open-source ICO decoder
​https://bugs.webkit.org/show_bug.cgi?id=41107

Reviewed by Adam Barth.

  • platform/image-decoders/bmp/BMPImageReader.cpp:

(WebCore::BMPImageReader::processInfoHeader): Fix memory corruption.

  • platform/image-decoders/ico/ICOImageDecoder.cpp:

(WebCore::ICOImageDecoder::processDirectoryEntries): Handle sizing failure correctly (though failure should be impossible).

LayoutTests: REGRESSION (r61619): Memory corruption in open-source ICO decoder
​https://bugs.webkit.org/show_bug.cgi?id=41107

Reviewed by Adam Barth.

This doesn't contain the updated test results -- I'll get that off the
bots after checkin.

  • fast/images/icon-decoding.html: Add test for memory corruption while decoding broken .ico.
  • fast/images/resources/bad.ico: Added.
2:57 PM Changeset in webkit [61787] by commit-queue@webkit.org
  • 30 edits in trunk/WebCore

2010-06-24 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r61783.
​http://trac.webkit.org/changeset/61783
​https://bugs.webkit.org/show_bug.cgi?id=41179

Caused a couple of test failures (Requested by japhet on
#webkit).

  • dom/DOMImplementation.cpp: (WebCore::DOMImplementation::createDocument): (WebCore::DOMImplementation::createHTMLDocument):
  • dom/DOMImplementation.h:
  • dom/Document.cpp: (WebCore::Document::Document): (WebCore::Document::initSecurityContext):
  • dom/Document.h: (WebCore::Document::create): (WebCore::Document::createXHTML):
  • html/HTMLDocument.cpp: (WebCore::HTMLDocument::HTMLDocument):
  • html/HTMLDocument.h: (WebCore::HTMLDocument::create):
  • html/HTMLViewSourceDocument.cpp: (WebCore::HTMLViewSourceDocument::HTMLViewSourceDocument):
  • html/HTMLViewSourceDocument.h: (WebCore::HTMLViewSourceDocument::create):
  • loader/CachedFont.cpp: (WebCore::CachedFont::ensureSVGFontData):
  • loader/DocumentWriter.cpp: (WebCore::DocumentWriter::createDocument): (WebCore::DocumentWriter::begin):
  • loader/DocumentWriter.h:
  • loader/FTPDirectoryDocument.cpp: (WebCore::FTPDirectoryDocument::FTPDirectoryDocument):
  • loader/FTPDirectoryDocument.h: (WebCore::FTPDirectoryDocument::create):
  • loader/ImageDocument.cpp: (WebCore::ImageDocument::ImageDocument):
  • loader/ImageDocument.h: (WebCore::ImageDocument::create):
  • loader/MediaDocument.cpp: (WebCore::MediaDocument::MediaDocument):
  • loader/MediaDocument.h: (WebCore::MediaDocument::create):
  • loader/PlaceholderDocument.h: (WebCore::PlaceholderDocument::create): (WebCore::PlaceholderDocument::PlaceholderDocument):
  • loader/PluginDocument.cpp: (WebCore::PluginDocument::PluginDocument):
  • loader/PluginDocument.h: (WebCore::PluginDocument::create):
  • loader/SinkDocument.cpp: (WebCore::SinkDocument::SinkDocument):
  • loader/SinkDocument.h: (WebCore::SinkDocument::create):
  • loader/TextDocument.cpp: (WebCore::TextDocument::TextDocument):
  • loader/TextDocument.h: (WebCore::TextDocument::create):
  • svg/SVGDocument.cpp: (WebCore::SVGDocument::SVGDocument):
  • svg/SVGDocument.h: (WebCore::SVGDocument::create):
  • xml/DOMParser.cpp: (WebCore::DOMParser::parseFromString):
  • xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::responseXML):
  • xml/XSLTProcessor.cpp: (WebCore::XSLTProcessor::createDocumentFromSource):
2:50 PM Changeset in webkit [61786] by sullivan@apple.com
  • 2 edits in trunk/WebKit2
  • mac/WebKit2.exp:

Added _WKNavigationDataRelease and _WKNavigationDataRetain.

Rubber-stamped by Ada Chan.

2:29 PM Changeset in webkit [61785] by Martin Robinson
  • 2 edits in trunk/WebCore

2010-06-24 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] Small code cleanup in RenderThemeGtk
​https://bugs.webkit.org/show_bug.cgi?id=40989

Reduce the amount of duplicated code slightly and prepare this section for
future improvements, such as sharing the clipping rectangle calculation with
the slow path.

No new tests as functionality has not changed.

  • platform/gtk/RenderThemeGtk.cpp: (WebCore::paintMozillaGtkWidget): Small code cleanup.
2:27 PM Changeset in webkit [61784] by Martin Robinson
  • 2 edits in trunk/LayoutTests

2010-06-24 Martin Robinson <​mrobinson@igalia.com>

Unreviewed.

Updated expected results for a test that differs on the bots.

  • platform/gtk/scrollbars/overflow-scrollbar-combinations-expected.txt:
1:13 PM Changeset in webkit [61783] by Nate Chapin
  • 30 edits in trunk/WebCore

2010-06-24 Nate Chapin <Nate Chapin>

Reviewed by Adam Barth.

Take a KURL parameter in Document's constructor.
This will remove the one case where Document::url()
and FrameLoader::url() are not equal, allowing us to
remove FrameLoader::url().

​https://bugs.webkit.org/show_bug.cgi?id=41166

Refactor only, no new tests.

  • dom/DOMImplementation.cpp: (WebCore::DOMImplementation::createDocument): Take a KURL and pass it through to Document. (WebCore::DOMImplementation::createHTMLDocument):
  • dom/DOMImplementation.h:
  • dom/Document.cpp: (WebCore::Document::Document): Call setURL() for non-empty KURL input parameters. (WebCore::Document::initSecurityContext): m_url is now initialized, so use it instead

of m_frame->loader()->url() for initializing the SecurityOrigin.

  • dom/Document.h: (WebCore::Document::create): (WebCore::Document::createXHTML):
  • html/HTMLDocument.cpp:
  • html/HTMLDocument.h: Add KURL parameter to create() and constructor.
  • html/HTMLViewSourceDocument.cpp:
  • html/HTMLViewSourceDocument.h: Add KURL parameter to create() and constructor.
  • loader/CachedFont.cpp: (WebCore::CachedFont::ensureSVGFontData):
  • loader/DocumentWriter.cpp: (WebCore::DocumentWriter::createDocument): Take a KURL and pass it through to Document. (WebCore::DocumentWriter::begin): Pass existing url parameter to constructors, and remove

redundant Document::setURL() call.

  • loader/DocumentWriter.h:
  • loader/FTPDirectoryDocument.cpp:
  • loader/FTPDirectoryDocument.h: Add KURL parameter to create() and constructor.
  • loader/ImageDocument.cpp:
  • loader/ImageDocument.h: Add KURL parameter to create() and constructor.
  • loader/MediaDocument.cpp:
  • loader/MediaDocument.h: Add KURL parameter to create() and constructor.
  • loader/PlaceholderDocument.h: Add KURL parameter to create() and constructor.
  • loader/PluginDocument.cpp:
  • loader/PluginDocument.h: Add KURL parameter to create() and constructor.
  • loader/SinkDocument.cpp:
  • loader/SinkDocument.h: Add KURL parameter to create() and constructor.
  • loader/TextDocument.cpp:
  • loader/TextDocument.h: Add KURL parameter to create() and constructor.
  • svg/SVGDocument.cpp:
  • svg/SVGDocument.h: Add KURL parameter to create() and constructor.
  • xml/DOMParser.cpp: (WebCore::DOMParser::parseFromString):
  • xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::responseXML):
  • xml/XSLTProcessor.cpp: (WebCore::XSLTProcessor::createDocumentFromSource):
1:04 PM Changeset in webkit [61782] by Martin Robinson
  • 2 edits
    83 adds in trunk/LayoutTests

2010-06-24 Martin Robinson <​mrobinson@igalia.com>

Unreviewed.

Skip a failing test. Clean up skipped list stragglers. Conglomerate all tests which
are timing out and don't have attached bugs. Add expected results for some tests and
unskip them.

  • platform/gtk/Skipped: Clean up skipped list stragglers.
  • platform/gtk/animations/3d/change-transform-in-end-event-expected.txt: Added.
  • platform/gtk/animations/3d/state-at-end-event-transform-expected.txt: Added.
  • platform/gtk/animations/state-at-end-event-expected.txt: Added.
  • platform/gtk/fast/backgrounds/001-expected.txt: Added.
  • platform/gtk/fast/backgrounds/animated-gif-as-background-expected.txt: Added.
  • platform/gtk/fast/backgrounds/animated-svg-as-background-expected.txt: Copied from LayoutTests/platform/qt/fast/backgrounds/animated-svg-as-background-expected.txt.
  • platform/gtk/fast/backgrounds/background-inherit-color-bug-expected.txt: Added.
  • platform/gtk/fast/backgrounds/background-origin-root-element-expected.txt: Added.
  • platform/gtk/fast/backgrounds/background-position-1-expected.txt: Added.
  • platform/gtk/fast/backgrounds/background-position-rounding-expected.txt: Added.
  • platform/gtk/fast/backgrounds/bgCompositeCopy-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/backgrounds/bgCompositeCopy-expected.txt.
  • platform/gtk/fast/backgrounds/body-generated-image-propagated-to-root-expected.txt: Added.
  • platform/gtk/fast/backgrounds/mask-composite-expected.txt: Added.
  • platform/gtk/fast/backgrounds/opacity-on-document-element-expected.txt: Added.
  • platform/gtk/fast/backgrounds/repeat/mask-negative-offset-repeat-expected.txt: Added.
  • platform/gtk/fast/backgrounds/repeat/negative-offset-repeat-expected.txt: Added.
  • platform/gtk/fast/backgrounds/repeat/negative-offset-repeat-transformed-expected.txt: Added.
  • platform/gtk/fast/backgrounds/repeat/noRepeatCorrectClip-expected.txt: Copied from LayoutTests/platform/qt/fast/backgrounds/repeat/noRepeatCorrectClip-expected.txt.
  • platform/gtk/fast/backgrounds/size/backgroundSize01-expected.txt: Copied from LayoutTests/platform/mac/fast/backgrounds/size/backgroundSize01-expected.txt.
  • platform/gtk/fast/backgrounds/size/backgroundSize02-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/backgrounds/size/backgroundSize02-expected.txt.
  • platform/gtk/fast/backgrounds/size/backgroundSize03-expected.txt: Copied from LayoutTests/platform/mac/fast/backgrounds/size/backgroundSize03-expected.txt.
  • platform/gtk/fast/backgrounds/size/backgroundSize04-expected.txt: Copied from LayoutTests/platform/mac/fast/backgrounds/size/backgroundSize04-expected.txt.
  • platform/gtk/fast/backgrounds/size/backgroundSize05-expected.txt: Copied from LayoutTests/platform/mac/fast/backgrounds/size/backgroundSize05-expected.txt.
  • platform/gtk/fast/backgrounds/size/backgroundSize06-expected.txt: Copied from LayoutTests/platform/mac/fast/backgrounds/size/backgroundSize06-expected.txt.
  • platform/gtk/fast/backgrounds/size/backgroundSize07-expected.txt: Copied from LayoutTests/platform/mac/fast/backgrounds/size/backgroundSize07-expected.txt.
  • platform/gtk/fast/backgrounds/size/backgroundSize08-expected.txt: Copied from LayoutTests/platform/mac/fast/backgrounds/size/backgroundSize08-expected.txt.
  • platform/gtk/fast/backgrounds/size/backgroundSize09-expected.txt: Copied from LayoutTests/platform/mac/fast/backgrounds/size/backgroundSize09-expected.txt.
  • platform/gtk/fast/backgrounds/size/backgroundSize10-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/backgrounds/size/backgroundSize10-expected.txt.
  • platform/gtk/fast/backgrounds/size/backgroundSize11-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/backgrounds/size/backgroundSize11-expected.txt.
  • platform/gtk/fast/backgrounds/size/backgroundSize12-expected.txt: Copied from LayoutTests/platform/mac/fast/backgrounds/size/backgroundSize12-expected.txt.
  • platform/gtk/fast/backgrounds/size/backgroundSize13-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/backgrounds/size/backgroundSize13-expected.txt.
  • platform/gtk/fast/backgrounds/size/backgroundSize14-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/backgrounds/size/backgroundSize14-expected.txt.
  • platform/gtk/fast/backgrounds/size/backgroundSize15-expected.txt: Added.
  • platform/gtk/fast/backgrounds/size/backgroundSize16-expected.txt: Added.
  • platform/gtk/fast/backgrounds/size/backgroundSize17-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/backgrounds/size/backgroundSize17-expected.txt.
  • platform/gtk/fast/backgrounds/size/backgroundSize18-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/backgrounds/size/backgroundSize18-expected.txt.
  • platform/gtk/fast/backgrounds/size/backgroundSize19-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/backgrounds/size/backgroundSize19-expected.txt.
  • platform/gtk/fast/backgrounds/size/zero-expected.txt: Added.
  • platform/gtk/fast/backgrounds/solid-color-context-restore-expected.txt: Added.
  • platform/gtk/fast/backgrounds/svg-as-background-1-expected.txt: Copied from LayoutTests/platform/qt/fast/backgrounds/svg-as-background-1-expected.txt.
  • platform/gtk/fast/backgrounds/svg-as-background-2-expected.txt: Copied from LayoutTests/platform/qt/fast/backgrounds/svg-as-background-2-expected.txt.
  • platform/gtk/fast/backgrounds/svg-as-background-3-expected.txt: Copied from LayoutTests/platform/qt/fast/backgrounds/svg-as-background-3-expected.txt.
  • platform/gtk/fast/backgrounds/svg-as-background-4-expected.txt: Copied from LayoutTests/platform/qt/fast/backgrounds/svg-as-background-4-expected.txt.
  • platform/gtk/fast/backgrounds/svg-as-background-5-expected.txt: Copied from LayoutTests/platform/qt/fast/backgrounds/svg-as-background-5-expected.txt.
  • platform/gtk/fast/backgrounds/svg-as-background-6-expected.txt: Copied from LayoutTests/platform/qt/fast/backgrounds/svg-as-background-6-expected.txt.
  • platform/gtk/fast/block/margin-collapse/block-inside-inline/001-expected.txt: Added.
  • platform/gtk/fast/block/margin-collapse/block-inside-inline/002-expected.txt: Added.
  • platform/gtk/fast/block/margin-collapse/block-inside-inline/003-expected.txt: Added.
  • platform/gtk/fast/block/margin-collapse/block-inside-inline/004-expected.txt: Added.
  • platform/gtk/fast/block/margin-collapse/block-inside-inline/005-expected.txt: Added.
  • platform/gtk/fast/block/margin-collapse/block-inside-inline/006-expected.txt: Added.
  • platform/gtk/fast/block/margin-collapse/block-inside-inline/010-expected.txt: Added.
  • platform/gtk/fast/block/margin-collapse/block-inside-inline/011-expected.txt: Added.
  • platform/gtk/fast/block/margin-collapse/block-inside-inline/012-expected.txt: Added.
  • platform/gtk/fast/block/margin-collapse/block-inside-inline/015-expected.txt: Added.
  • platform/gtk/fast/block/margin-collapse/block-inside-inline/016-expected.txt: Added.
  • platform/gtk/fast/block/margin-collapse/block-inside-inline/017-expected.txt: Added.
  • platform/gtk/fast/block/margin-collapse/block-inside-inline/018-expected.txt: Added.
  • platform/gtk/fast/block/margin-collapse/block-inside-inline/019-expected.txt: Added.
  • platform/gtk/fast/block/margin-collapse/block-inside-inline/020-expected.txt: Added.
  • platform/gtk/fast/block/margin-collapse/block-inside-inline/021-expected.txt: Added.
  • platform/gtk/fast/block/margin-collapse/block-inside-inline/022-expected.txt: Added.
  • platform/gtk/fast/block/margin-collapse/block-inside-inline/025-expected.txt: Added.
  • platform/gtk/fast/css/getComputedStyle/marginComputedStyle-expected.txt: Added.
  • platform/gtk/printing/compositing-layer-printing-expected.txt: Added.
  • platform/gtk/printing/media-queries-print-expected.txt: Added.
  • platform/gtk/printing/return-from-printing-mode-expected.txt: Added.
  • platform/gtk/scrollbars/disabled-scrollbar-expected.txt: Added.
  • platform/gtk/scrollbars/listbox-scrollbar-combinations-expected.txt: Added.
  • platform/gtk/scrollbars/overflow-scrollbar-combinations-expected.txt: Added.
  • platform/gtk/scrollbars/scrollbar-buttons-expected.txt: Added.
  • platform/gtk/scrollbars/scrollbar-orientation-expected.txt: Added.
  • platform/gtk/transforms/2d/transform-fixed-container-expected.txt: Added.
  • platform/gtk/transforms/2d/zoom-menulist-expected.txt: Added.
  • platform/gtk/transitions/move-after-transition-expected.txt: Added.
  • platform/gtk/transitions/transition-end-event-rendering-expected.txt: Copied from LayoutTests/platform/mac/transitions/transition-end-event-rendering-expected.txt.
11:38 AM Changeset in webkit [61781] by beidson@apple.com
  • 3 edits
    3 adds in trunk

<rdar://problem/8044645> and ​https://bugs.webkit.org/show_bug.cgi?id=41082

Reviewed by Sam Weinig.

Webarchives will null main resource cause a repro crash.

WebCore:

Test: webarchive/loading/mainresource-null-mimetype-crash.html

  • loader/archive/cf/LegacyWebArchive.cpp:

(WebCore::LegacyWebArchive::createResource): Fail to create the archive resource if the main resource's

mime type is null.

LayoutTests:

  • webarchive/loading/mainresource-null-mimetype-crash-expected.txt: Added.
  • webarchive/loading/mainresource-null-mimetype-crash.html: Added.
  • webarchive/loading/resources/mainresource-null-mimetype.webarchive: Added.
11:29 AM Changeset in webkit [61780] by weinig@apple.com
  • 2 edits in trunk/WebKitTools

Fix WebKitTestRunner Makefile typos.

Reviewed by Anders Carlsson.

  • WebKitTestRunner/Makefile:
11:29 AM Changeset in webkit [61779] by sullivan@apple.com
  • 2 edits in trunk/WebKit2
  • mac/WebKit2.exp:

Added _WKPageReloadFromOrigin.

Rubber-stamped by Anders Carlsson.

11:28 AM Changeset in webkit [61778] by sfalken@apple.com
  • 5 edits in trunk/JavaScriptCore

2010-06-21 Nathan Lawrence <​nlawrence@apple.com>

Reviewed by Geoff Garen.

​https://bugs.webkit.org/show_bug.cgi?id=40128
Fixed broken debug functionality.

  • interpreter/Interpreter.cpp: (JSC::Interpreter::dumpRegisters):

Fixed to work with updated call frame.

  • runtime/JSImmediate.h: (JSC::JSValue::isCell):

Added assert for aligned cell.

  • runtime/JSValue.cpp: (JSC::JSValue::description):

Fixed to work with current JSValue implementation.

  • runtime/JSZombie.cpp: (JSC::JSZombie::leakedZombieStructure):

JSombies compile again.

11:14 AM Changeset in webkit [61777] by kdecker@apple.com
  • 7 edits in trunk

2010-06-24 Damian Kaleta <​dkaleta@apple.com>

Reviewed by Sam Weinig.

Provide a way to obtain the rendered rectangle for box elements.

  • WebCore.base.exp: Export the symbol so we can see it in WebKit.
  • dom/Node.cpp: (WebCore::Node::renderRect): Added new ethod that will return a rendered rectangle for box elements.
  • dom/Node.h: Ditto.

2010-06-24 Damian Kaleta <​dkaleta@apple.com>

Reviewed by Sam Weinig.

Added an ObjC wrapper to Node::renderRect(bool&).

  • DOM/WebDOMOperations.mm: (-[DOMNode _renderRect:]):
  • DOM/WebDOMOperationsPrivate.h:
11:11 AM Changeset in webkit [61776] by weinig@apple.com
  • 7 edits in trunk/WebKit2

Fix for ​https://bugs.webkit.org/show_bug.cgi?id=41168
<rdar://problem/8124605>
Webkit2: Add WKPageReloadFromOrigin() to match old-WebKit functionality

Reviewed by Anders Carlsson.

  • UIProcess/API/C/WKPage.cpp:

(WKPageReload):
(WKPageReloadFromOrigin):

  • UIProcess/API/C/WKPage.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::reload):

  • UIProcess/WebPageProxy.h:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::reload):
(WebKit::WebPage::didReceiveMessage):

  • WebProcess/WebPage/WebPage.h:
11:11 AM Changeset in webkit [61775] by darin@chromium.org
  • 8 edits
    6 adds in trunk/WebCore

2010-06-24 Vangelis Kokkevis <​vangelis@chromium.org>

Reviewed by Darin Fisher.

[Chromium] Create specialized classes for Transform,
Image and WebGL layers to replace the rather monolithic LayerChromium class.
Layers can now own the GL texture they use for backing store and a different
shading program can be used by the compositor for each layer type. WebGL layers
are not yet hooked up to GraphicsContext3D.
​https://bugs.webkit.org/show_bug.cgi?id=41106

  • WebCore.gypi:
  • platform/graphics/chromium/GraphicsLayerChromium.cpp: (WebCore::GraphicsLayerChromium::GraphicsLayerChromium): (WebCore::GraphicsLayerChromium::setContentsToImage): (WebCore::GraphicsLayerChromium::updateLayerPreserves3D):
  • platform/graphics/chromium/GraphicsLayerChromium.h: (WebCore::GraphicsLayerChromium::):
  • platform/graphics/chromium/ImageLayerChromium.cpp: Added. (WebCore::ImageLayerChromium::create): (WebCore::ImageLayerChromium::ImageLayerChromium): (WebCore::ImageLayerChromium::setContents): (WebCore::ImageLayerChromium::updateTextureContents):
  • platform/graphics/chromium/ImageLayerChromium.h: Added. (WebCore::ImageLayerChromium::drawsContent):
  • platform/graphics/chromium/LayerChromium.cpp: (WebCore::LayerChromium::create): (WebCore::LayerChromium::LayerChromium): (WebCore::LayerChromium::updateTextureContents): (WebCore::LayerChromium::updateTextureRect):
  • platform/graphics/chromium/LayerChromium.h: (WebCore::LayerChromium::drawsContent): (WebCore::LayerChromium::ownsTexture): (WebCore::LayerChromium::textureId): (WebCore::LayerChromium::setShaderProgramId): (WebCore::LayerChromium::shaderProgramId):
  • platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::createLayerShader): (WebCore::ShaderProgram::ShaderProgram): (WebCore::LayerRendererChromium::LayerRendererChromium): (WebCore::LayerRendererChromium::~LayerRendererChromium): (WebCore::LayerRendererChromium::useShaderProgram): (WebCore::LayerRendererChromium::drawTexturedQuad): (WebCore::LayerRendererChromium::drawLayers): (WebCore::LayerRendererChromium::drawDebugBorder): (WebCore::LayerRendererChromium::updateLayersRecursive): (WebCore::LayerRendererChromium::drawLayer): (WebCore::LayerRendererChromium::bindCommonAttribLocations): (WebCore::LayerRendererChromium::initializeSharedGLObjects):
  • platform/graphics/chromium/LayerRendererChromium.h: (WebCore::LayerRendererChromium::):
  • platform/graphics/chromium/TransformLayerChromium.cpp: Added. (WebCore::TransformLayerChromium::create): (WebCore::TransformLayerChromium::TransformLayerChromium):
  • platform/graphics/chromium/TransformLayerChromium.h: Added. (WebCore::TransformLayerChromium::drawsContent):
  • platform/graphics/chromium/WebGLLayerChromium.cpp: Added. (WebCore::WebGLLayerChromium::WebGLLayerChromium): (WebCore::WebGLLayerChromium::textureId): (WebCore::WebGLLayerChromium::updateTextureContents): (WebCore::WebGLLayerChromium::setContext):
  • platform/graphics/chromium/WebGLLayerChromium.h: Added. (WebCore::WebGLLayerChromium::drawsContent): (WebCore::WebGLLayerChromium::ownsTexture): (WebCore::WebGLLayerChromium::shaderProgramId): (WebCore::WebGLLayerChromium::setShaderProgramId):
11:08 AM Changeset in webkit [61774] by darin@chromium.org
  • 5 edits in trunk/WebKit/chromium

2010-06-24 Vangelis Kokkevis <​vangelis@chromium.org>

Reviewed by Darin Fisher.

[Chromium] A WebView can now own a GLES2Context which gets created on
demand. This context will typically be created for the gpu compositor
and used as a parent context for any elements on the page that use the
gpu for rendering (e.g. WebGL) and need to pass their backbuffer directly
to the compositor.
​https://bugs.webkit.org/show_bug.cgi?id=41010

  • public/WebGLES2Context.h:
  • src/GLES2Context.cpp: (WebCore::GLES2ContextInternal::getWebGLES2Context): (WebCore::GLES2ContextInternal::initialize):
  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::WebViewImpl): (WebKit::WebViewImpl::gles2Context):
  • src/WebViewImpl.h:
11:07 AM Changeset in webkit [61773] by mnaganov@chromium.org
  • 1 edit
    2 adds in trunk/LayoutTests

2010-06-24 Mikhail Naganov <​mnaganov@chromium.org>

Unreviewed test expectations update.

  • platform/chromium-mac/css2.1/t0804-c5510-padn-00-b-ag-expected.checksum: Copied from LayoutTests/platform/mac/css2.1/t0804-c5510-padn-00-b-ag-expected.checksum.
  • platform/chromium-mac/css2.1/t0804-c5510-padn-00-b-ag-expected.png: Added.
10:52 AM Changeset in webkit [61772] by pfeldman@chromium.org
  • 23 edits in trunk

2010-06-24 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.


Web Inspector: Inspector cleanup + better DevTools alignment with Inspector.

​https://bugs.webkit.org/show_bug.cgi?id=41094

  • Removed a bunch of unused methods from all over the place
  • Added client callbacks for states surviving navigation
  • Implemented more user-friendly stub for InspectorFrontendHost.platform
  • inspector/InspectorClient.h: (WebCore::InspectorClient::resourceTrackingWasEnabled): (WebCore::InspectorClient::resourceTrackingWasDisabled): (WebCore::InspectorClient::timelineProfilerWasStarted): (WebCore::InspectorClient::timelineProfilerWasStopped):
  • inspector/InspectorController.cpp: (WebCore::InspectorController::enableResourceTracking): (WebCore::InspectorController::disableResourceTracking): (WebCore::InspectorController::ensureSettingsLoaded): (WebCore::InspectorController::startTimelineProfiler): (WebCore::InspectorController::stopTimelineProfiler):
  • inspector/InspectorFrontend.cpp:
  • inspector/InspectorFrontend.h:
  • inspector/front-end/InspectorBackendStub.js:
  • inspector/front-end/InspectorFrontendHostStub.js: (.WebInspector.InspectorFrontendHostStub.prototype.platform):

2010-06-24 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.


Web Inspector: Inspector cleanup + better DevTools alignment with Inspector.

​https://bugs.webkit.org/show_bug.cgi?id=41094

  • Merged InspectorClient implementation into WebDevToolsAgent
  • Changed the way WebDevToolsAgent is initialized (will break chromium bot, needs coordinated landing)
  • Removed a lot of legacy code from WebDevToolsAgentImpl
  • Removed a lot of overrides from DevTools.js
  • Simplified devtools stubs
  • Got rid of all logic from within InjectDispatch.js
  • public/WebView.h:
  • src/FrameLoaderClientImpl.cpp: (WebKit::FrameLoaderClientImpl::dispatchDidCommitLoad):
  • src/InspectorClientImpl.cpp: (WebKit::InspectorClientImpl::inspectorDestroyed): (WebKit::InspectorClientImpl::openInspectorFrontend): (WebKit::InspectorClientImpl::highlight): (WebKit::InspectorClientImpl::hideHighlight): (WebKit::InspectorClientImpl::populateSetting): (WebKit::InspectorClientImpl::storeSetting): (WebKit::InspectorClientImpl::sendMessageToFrontend): (WebKit::InspectorClientImpl::resourceTrackingWasEnabled): (WebKit::InspectorClientImpl::resourceTrackingWasDisabled): (WebKit::InspectorClientImpl::timelineProfilerWasStarted): (WebKit::InspectorClientImpl::timelineProfilerWasStopped): (WebKit::InspectorClientImpl::devToolsAgent):
  • src/InspectorClientImpl.h:
  • src/InspectorFrontendClientImpl.cpp: (WebKit::InspectorFrontendClientImpl::inspectedURLChanged):
  • src/ToolsAgent.h:
  • src/WebDevToolsAgentImpl.cpp: (WebKit::): (WebKit::WebDevToolsAgentImpl::initDevToolsAgentHost): (WebKit::WebDevToolsAgentImpl::setApuAgentEnabled): (WebKit::WebDevToolsAgentImpl::jsDispatchOnClient): (WebKit::WebDevToolsAgentImpl::inspectorDestroyed): (WebKit::WebDevToolsAgentImpl::openInspectorFrontend): (WebKit::WebDevToolsAgentImpl::highlight): (WebKit::WebDevToolsAgentImpl::hideHighlight): (WebKit::WebDevToolsAgentImpl::populateSetting): (WebKit::WebDevToolsAgentImpl::storeSetting): (WebKit::WebDevToolsAgentImpl::sendMessageToFrontend): (WebKit::WebDevToolsAgentImpl::resourceTrackingWasEnabled): (WebKit::WebDevToolsAgentImpl::resourceTrackingWasDisabled): (WebKit::WebDevToolsAgentImpl::timelineProfilerWasStarted): (WebKit::WebDevToolsAgentImpl::timelineProfilerWasStopped):
  • src/WebDevToolsAgentImpl.h:
  • src/WebDevToolsAgentPrivate.h:
  • src/WebViewImpl.cpp: (WebKit::WebView::create): (WebKit::WebViewImpl::WebViewImpl):
  • src/WebViewImpl.h:
  • src/js/DevTools.js: (devtools.ToolsAgent): (): (devtools):
  • src/js/DevToolsHostStub.js: (.window.setDebuggerScriptSource): (.window.dispatchOnInjectedScript):
  • src/js/InjectDispatch.js: (dispatch):
  • src/js/InspectorControllerImpl.js:
10:38 AM Changeset in webkit [61771] by adele@apple.com
  • 5 edits
    2 adds in trunk

WebKit/mac: Fix for <rdar://problem/8093680> "Paste and Match Style" should fire paste events
​https://bugs.webkit.org/show_bug.cgi?id=41085

Reviewed by Eric Carlson.

  • WebView/WebHTMLView.mm: (-[WebHTMLView pasteAsPlainText:]): Reuse code in WebCore

which does everything done here and also fires paste events.

WebKitTools: DumpRenderTree part of testing <rdar://problem/8093680> "Paste and Match Style" should fire paste events
​https://bugs.webkit.org/show_bug.cgi?id=41085

Reviewed by Eric Carlson.

  • DumpRenderTree/mac/DumpRenderTree.mm: (resetWebViewToConsistentStateBeforeTesting):

Clear the general pasteboard in between tests so Cut,Copy, and setData on ClipboardData won't have lasting effects.

LayoutTests: Test for <rdar://problem/8093680> "Paste and Match Style" should fire paste events
​https://bugs.webkit.org/show_bug.cgi?id=41085

Reviewed by Eric Carlson.

  • platform/mac/editing/pasteboard/paste-and-match-style-selector-event-expected.txt: Added.
  • platform/mac/editing/pasteboard/paste-and-match-style-selector-event.html: Added.
10:17 AM Changeset in webkit [61770] by mnaganov@chromium.org
  • 3 edits in trunk/LayoutTests

2010-06-24 Mikhail Naganov <​mnaganov@chromium.org>

Unreviewed test expectations update.

  • platform/chromium-win/svg/text/text-text-05-t-expected.checksum:
  • platform/chromium-win/svg/text/text-text-05-t-expected.png:
10:04 AM Changeset in webkit [61769] by weinig@apple.com
  • 1 edit
    23 adds in trunk/WebKitTools

Patch for ​https://bugs.webkit.org/show_bug.cgi?id=41086
Add new WebKitTestRunner project (ie. DRT for WebKit2).

Reviewed by Anders Carlsson.

  • Mac only.
  • run-webkit-tests has not been modified to call it yet.
  • Only dumps the render tree at this time.
  • WebKitTestRunner: Added.
  • WebKitTestRunner/Configurations: Added.
  • WebKitTestRunner/Configurations/Base.xcconfig: Added.
  • WebKitTestRunner/Configurations/DebugRelease.xcconfig: Added.
  • WebKitTestRunner/Configurations/InjectedBundle.xcconfig: Added.
  • WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig: Added.
  • WebKitTestRunner/InjectedBundle: Added.
  • WebKitTestRunner/InjectedBundle-Info.plist: Added.
  • WebKitTestRunner/InjectedBundle/InjectedBundleMain.cpp: Added.

(_didStartProvisionalLoadForFrame):
(_didReceiveServerRedirectForProvisionalLoadForFrame):
(_didFailProvisionalLoadWithErrorForFrame):
(_didCommitLoadForFrame):
(_didFinishLoadForFrame):
(_didFailLoadWithErrorForFrame):
(_didReceiveTitleForFrame):
(_didClearWindow):
(_didCreatePage):
(_willDestroyPage):
(_didRecieveMessage):
(WKBundleInitialize):

  • WebKitTestRunner/Makefile: Added.
  • WebKitTestRunner/PlatformWebView.h: Added.

(WTR::PlatformWebView::platformView):

  • WebKitTestRunner/TestController.cpp: Added.

(WTR::TestController::shared):
(WTR::TestController::TestController):
(WTR::TestController::initialize):
(WTR::TestController::runTest):
(WTR::TestController::runTestingServerLoop):
(WTR::TestController::run):

  • WebKitTestRunner/TestController.h: Added.

(WTR::TestController::verbose):
(WTR::TestController::injectedBundlePath):

  • WebKitTestRunner/TestInvocation.cpp: Added.

(WTR::createWKURL):
(WTR::TestInvocation::TestInvocation):
(WTR::TestInvocation::~TestInvocation):
(WTR::TestInvocation::invoke):
(WTR::TestInvocation::dump):
(WTR::TestInvocation::initializeMainWebView):
(WTR::TestInvocation::didStartProvisionalLoadForFrame):
(WTR::TestInvocation::didReceiveServerRedirectForProvisionalLoadForFrame):
(WTR::TestInvocation::didFailProvisionalLoadWithErrorForFrame):
(WTR::TestInvocation::didCommitLoadForFrame):
(WTR::TestInvocation::didFinishLoadForFrame):
(WTR::TestInvocation::didFailLoadForFrame):
(WTR::TestInvocation::renderTreeExternalRepresentationFunction):
(WTR::TestInvocation::renderTreeExternalRepresentationDisposeFunction):

  • WebKitTestRunner/TestInvocation.h: Added.
  • WebKitTestRunner/WebKitTestRunner.xcodeproj: Added.
  • WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Added.
  • WebKitTestRunner/WebKitTestRunnerPrefix.h: Added.
  • WebKitTestRunner/mac: Added.
  • WebKitTestRunner/mac/PlatformWebViewMac.mm: Added.

(WTR::PlatformWebView::PlatformWebView):
(WTR::PlatformWebView::~PlatformWebView):
(WTR::PlatformWebView::page):

  • WebKitTestRunner/mac/TestInvocationMac.mm: Added.

(WTR::TestInvocation::runUntil):

  • WebKitTestRunner/mac/main.mm: Added.

(main):

10:01 AM Changeset in webkit [61768] by ap@apple.com
  • 10 edits
    1 add in trunk/WebCore

Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=41099
Assertion failure: !m_suspended when XMLHttpRequest fails

This was a general problem with load failure timer not being deferred.

Test: manual-tests/xhr-failure-behind-alert.html

  • manual-tests/xhr-failure-behind-alert.html: Added.
  • platform/network/ResourceHandle.cpp: (WebCore::ResourceHandle::fireFailure): Added an empty case for NoFailure. Reset m_scheduledFailureType to NoFailure when firing. (WebCore::ResourceHandle::setDefersLoading): Stop failure timer when deferring, restart when un-deferring loads.
  • platform/network/ResourceHandle.h: Renamed m_failureType to m_scheduledFailureType to make it clear that it is only set when a timer is scheduled.
  • platform/network/ResourceHandleInternal.h: (WebCore::ResourceHandleInternal::ResourceHandleInternal): Initialize m_scheduledFailureType to NoFailure, so that we can look at it when un-deferring loads.
  • platform/network/android/ResourceHandleAndroid.cpp: (WebCore::ResourceHandle::platformSetDefersLoading):
  • platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::ResourceHandle::platformSetDefersLoading):
  • platform/network/curl/ResourceHandleCurl.cpp: (WebCore::ResourceHandle::platformSetDefersLoading):
  • platform/network/mac/ResourceHandleMac.mm: (WebCore::ResourceHandle::platformSetDefersLoading):
  • platform/network/qt/ResourceHandleQt.cpp: (WebCore::ResourceHandle::platformSetDefersLoading):
  • platform/network/soup/ResourceHandleSoup.cpp: Platform specific parts of setDefersLoading() are now in a separate function.
9:30 AM Changeset in webkit [61767] by pfeldman@chromium.org
  • 23 edits
    1 copy
    1 add in trunk

2010-06-24 Pavel Feldman <​pfeldman@chromium.org>

Not reviewed: revert 61766.

9:02 AM Changeset in webkit [61766] by pfeldman@chromium.org
  • 23 edits
    2 deletes in trunk

2010-06-23 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: Inspector cleanup + better DevTools alignment with Inspector.


​https://bugs.webkit.org/show_bug.cgi?id=41094

  • Removed a bunch of unused methods from all over the place
  • Added client callbacks for states surviving navigation
  • Implemented more user-friendly stub for InspectorFrontendHost.platform
  • inspector/InspectorClient.h: (WebCore::InspectorClient::resourceTrackingWasEnabled): (WebCore::InspectorClient::resourceTrackingWasDisabled): (WebCore::InspectorClient::timelineProfilerWasStarted): (WebCore::InspectorClient::timelineProfilerWasStopped):
  • inspector/InspectorController.cpp: (WebCore::InspectorController::enableResourceTracking): (WebCore::InspectorController::disableResourceTracking): (WebCore::InspectorController::ensureSettingsLoaded): (WebCore::InspectorController::startTimelineProfiler): (WebCore::InspectorController::stopTimelineProfiler):
  • inspector/InspectorFrontend.cpp:
  • inspector/InspectorFrontend.h:
  • inspector/front-end/InspectorBackendStub.js:
  • inspector/front-end/InspectorFrontendHostStub.js: (.WebInspector.InspectorFrontendHostStub.prototype.platform):

2010-06-23 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: Inspector cleanup + better DevTools alignment with Inspector.


​https://bugs.webkit.org/show_bug.cgi?id=41094

  • Merged InspectorClient implementation into WebDevToolsAgent
  • Changed the way WebDevToolsAgent is initialized (will break chromium bot, needs coordinated landing)
  • Removed a lot of legacy code from WebDevToolsAgentImpl
  • Removed a lot of overrides from DevTools.js
  • Simplified devtools stubs
  • Got rid of all logic from within InjectDispatch.js
  • WebKit.gyp:
  • public/WebDevToolsAgent.h:
  • public/WebView.h:
  • src/FrameLoaderClientImpl.cpp: (WebKit::FrameLoaderClientImpl::dispatchDidCommitLoad):
  • src/InspectorFrontendClientImpl.cpp: (WebKit::InspectorFrontendClientImpl::inspectedURLChanged):
  • src/ToolsAgent.h:
  • src/WebDevToolsAgentImpl.cpp: (WebKit::): (WebKit::WebDevToolsAgentImpl::initDevToolsAgentHost): (WebKit::WebDevToolsAgentImpl::setApuAgentEnabled): (WebKit::WebDevToolsAgentImpl::jsDispatchOnClient): (WebKit::WebDevToolsAgentImpl::inspectorDestroyed): (WebKit::WebDevToolsAgentImpl::openInspectorFrontend): (WebKit::WebDevToolsAgentImpl::highlight): (WebKit::WebDevToolsAgentImpl::hideHighlight): (WebKit::WebDevToolsAgentImpl::populateSetting): (WebKit::WebDevToolsAgentImpl::storeSetting): (WebKit::WebDevToolsAgentImpl::sendMessageToFrontend): (WebKit::WebDevToolsAgentImpl::resourceTrackingWasEnabled): (WebKit::WebDevToolsAgentImpl::resourceTrackingWasDisabled): (WebKit::WebDevToolsAgentImpl::timelineProfilerWasStarted): (WebKit::WebDevToolsAgentImpl::timelineProfilerWasStopped):
  • src/WebDevToolsAgentImpl.h:
  • src/WebDevToolsAgentPrivate.h:
  • src/WebViewImpl.cpp: (WebKit::WebView::create): (WebKit::WebViewImpl::WebViewImpl):
  • src/WebViewImpl.h:
  • src/WebWorkerBase.cpp: (WebKit::WebWorkerBase::initializeLoader):
  • src/js/DevTools.js: (devtools.ToolsAgent): (): (devtools):
  • src/js/DevToolsHostStub.js: (.window.setDebuggerScriptSource): (.window.dispatchOnInjectedScript):
  • src/js/InjectDispatch.js: (dispatch):
  • src/js/InspectorControllerImpl.js:
9:00 AM Changeset in webkit [61765] by luiz@webkit.org
  • 2 edits in trunk/WebKitTools

Unreviewed. Adding myself to the committers list.

  • Scripts/webkitpy/common/config/committers.py:
8:46 AM Changeset in webkit [61764] by pfeldman@chromium.org
  • 145 edits
    26 adds
    24 deletes in trunk/LayoutTests

2010-06-24 Pavel Feldman <​pfeldman@chromium.org>

Not reviewed: rebaseline images for r61759 and r61762.

  • platform/chromium-linux/svg/text/selection-doubleclick-expected.checksum:
  • platform/chromium-linux/svg/text/selection-doubleclick-expected.png:
  • platform/chromium-linux/svg/text/selection-tripleclick-expected.checksum:
  • platform/chromium-linux/svg/text/selection-tripleclick-expected.png:
  • platform/chromium-linux/svg/text/text-align-01-b-expected.checksum:
  • platform/chromium-linux/svg/text/text-align-01-b-expected.png:
  • platform/chromium-linux/svg/text/text-align-02-b-expected.checksum:
  • platform/chromium-linux/svg/text/text-align-02-b-expected.png:
  • platform/chromium-linux/svg/text/text-align-03-b-expected.checksum:
  • platform/chromium-linux/svg/text/text-align-03-b-expected.png:
  • platform/chromium-linux/svg/text/text-align-04-b-expected.checksum:
  • platform/chromium-linux/svg/text/text-align-04-b-expected.png:
  • platform/chromium-linux/svg/text/text-align-05-b-expected.checksum:
  • platform/chromium-linux/svg/text/text-align-05-b-expected.png:
  • platform/chromium-linux/svg/text/text-align-06-b-expected.checksum:
  • platform/chromium-linux/svg/text/text-align-06-b-expected.png:
  • platform/chromium-linux/svg/text/text-altglyph-01-b-expected.checksum:
  • platform/chromium-linux/svg/text/text-altglyph-01-b-expected.png:
  • platform/chromium-linux/svg/text/text-deco-01-b-expected.checksum:
  • platform/chromium-linux/svg/text/text-deco-01-b-expected.png:
  • platform/chromium-linux/svg/text/text-fonts-01-t-expected.checksum:
  • platform/chromium-linux/svg/text/text-fonts-01-t-expected.png:
  • platform/chromium-linux/svg/text/text-fonts-02-t-expected.checksum:
  • platform/chromium-linux/svg/text/text-fonts-02-t-expected.png:
  • platform/chromium-linux/svg/text/text-intro-05-t-expected.checksum:
  • platform/chromium-linux/svg/text/text-intro-05-t-expected.png:
  • platform/chromium-linux/svg/text/text-path-01-b-expected.checksum:
  • platform/chromium-linux/svg/text/text-path-01-b-expected.png:
  • platform/chromium-linux/svg/text/text-spacing-01-b-expected.checksum:
  • platform/chromium-linux/svg/text/text-spacing-01-b-expected.png:
  • platform/chromium-linux/svg/text/text-text-01-b-expected.checksum:
  • platform/chromium-linux/svg/text/text-text-01-b-expected.png:
  • platform/chromium-linux/svg/text/text-text-03-b-expected.checksum:
  • platform/chromium-linux/svg/text/text-text-03-b-expected.png:
  • platform/chromium-linux/svg/text/text-text-04-t-expected.checksum:
  • platform/chromium-linux/svg/text/text-text-04-t-expected.png:
  • platform/chromium-linux/svg/text/text-text-05-t-expected.checksum:
  • platform/chromium-linux/svg/text/text-text-05-t-expected.png:
  • platform/chromium-linux/svg/text/text-text-06-t-expected.checksum:
  • platform/chromium-linux/svg/text/text-text-06-t-expected.png:
  • platform/chromium-linux/svg/text/text-text-07-t-expected.checksum:
  • platform/chromium-linux/svg/text/text-text-07-t-expected.png:
  • platform/chromium-linux/svg/text/text-text-08-b-expected.checksum:
  • platform/chromium-linux/svg/text/text-text-08-b-expected.png:
  • platform/chromium-linux/svg/text/text-tref-01-b-expected.checksum:
  • platform/chromium-linux/svg/text/text-tref-01-b-expected.png:
  • platform/chromium-linux/svg/text/text-tselect-01-b-expected.checksum:
  • platform/chromium-linux/svg/text/text-tselect-01-b-expected.png:
  • platform/chromium-linux/svg/text/text-tselect-02-f-expected.checksum:
  • platform/chromium-linux/svg/text/text-tselect-02-f-expected.png:
  • platform/chromium-linux/svg/text/text-tspan-01-b-expected.checksum:
  • platform/chromium-linux/svg/text/text-tspan-01-b-expected.png:
  • platform/chromium-linux/svg/text/text-ws-01-t-expected.checksum:
  • platform/chromium-linux/svg/text/text-ws-01-t-expected.png:
  • platform/chromium-linux/svg/text/text-ws-02-t-expected.checksum:
  • platform/chromium-linux/svg/text/text-ws-02-t-expected.png:
  • platform/chromium-linux/svg/text/textPathBoundsBug-expected.checksum:
  • platform/chromium-mac/svg/text/selection-doubleclick-expected.checksum:
  • platform/chromium-mac/svg/text/selection-doubleclick-expected.png: Removed.
  • platform/chromium-mac/svg/text/selection-tripleclick-expected.checksum:
  • platform/chromium-mac/svg/text/selection-tripleclick-expected.png: Removed.
  • platform/chromium-mac/svg/text/text-align-01-b-expected.checksum:
  • platform/chromium-mac/svg/text/text-align-01-b-expected.png: Removed.
  • platform/chromium-mac/svg/text/text-align-02-b-expected.checksum:
  • platform/chromium-mac/svg/text/text-align-02-b-expected.png: Removed.
  • platform/chromium-mac/svg/text/text-align-03-b-expected.checksum:
  • platform/chromium-mac/svg/text/text-align-03-b-expected.png: Removed.
  • platform/chromium-mac/svg/text/text-align-04-b-expected.checksum:
  • platform/chromium-mac/svg/text/text-align-04-b-expected.png:
  • platform/chromium-mac/svg/text/text-align-05-b-expected.checksum:
  • platform/chromium-mac/svg/text/text-align-05-b-expected.png: Removed.
  • platform/chromium-mac/svg/text/text-align-06-b-expected.checksum:
  • platform/chromium-mac/svg/text/text-align-06-b-expected.png: Removed.
  • platform/chromium-mac/svg/text/text-altglyph-01-b-expected.checksum:
  • platform/chromium-mac/svg/text/text-altglyph-01-b-expected.png: Removed.
  • platform/chromium-mac/svg/text/text-deco-01-b-expected.checksum:
  • platform/chromium-mac/svg/text/text-deco-01-b-expected.png: Removed.
  • platform/chromium-mac/svg/text/text-fonts-01-t-expected.checksum:
  • platform/chromium-mac/svg/text/text-fonts-01-t-expected.png: Removed.
  • platform/chromium-mac/svg/text/text-fonts-02-t-expected.checksum:
  • platform/chromium-mac/svg/text/text-fonts-02-t-expected.png: Removed.
  • platform/chromium-mac/svg/text/text-path-01-b-expected.checksum:
  • platform/chromium-mac/svg/text/text-path-01-b-expected.png:
  • platform/chromium-mac/svg/text/text-spacing-01-b-expected.checksum:
  • platform/chromium-mac/svg/text/text-spacing-01-b-expected.png: Removed.
  • platform/chromium-mac/svg/text/text-text-01-b-expected.checksum:
  • platform/chromium-mac/svg/text/text-text-01-b-expected.png: Removed.
  • platform/chromium-mac/svg/text/text-text-03-b-expected.checksum:
  • platform/chromium-mac/svg/text/text-text-03-b-expected.png: Removed.
  • platform/chromium-mac/svg/text/text-text-04-t-expected.checksum:
  • platform/chromium-mac/svg/text/text-text-04-t-expected.png: Removed.
  • platform/chromium-mac/svg/text/text-text-06-t-expected.checksum:
  • platform/chromium-mac/svg/text/text-text-06-t-expected.png: Removed.
  • platform/chromium-mac/svg/text/text-text-07-t-expected.checksum:
  • platform/chromium-mac/svg/text/text-text-07-t-expected.png: Removed.
  • platform/chromium-mac/svg/text/text-text-08-b-expected.checksum:
  • platform/chromium-mac/svg/text/text-text-08-b-expected.png:
  • platform/chromium-mac/svg/text/text-tref-01-b-expected.checksum:
  • platform/chromium-mac/svg/text/text-tref-01-b-expected.png: Removed.
  • platform/chromium-mac/svg/text/text-tselect-01-b-expected.checksum:
  • platform/chromium-mac/svg/text/text-tselect-01-b-expected.png: Removed.
  • platform/chromium-mac/svg/text/text-tselect-02-f-expected.checksum:
  • platform/chromium-mac/svg/text/text-tselect-02-f-expected.png: Removed.
  • platform/chromium-mac/svg/text/text-tspan-01-b-expected.checksum:
  • platform/chromium-mac/svg/text/text-tspan-01-b-expected.png: Removed.
  • platform/chromium-mac/svg/text/text-ws-01-t-expected.checksum:
  • platform/chromium-mac/svg/text/text-ws-01-t-expected.png: Removed.
  • platform/chromium-mac/svg/text/text-ws-02-t-expected.checksum:
  • platform/chromium-mac/svg/text/text-ws-02-t-expected.png: Removed.
  • platform/chromium-mac/svg/text/textPathBoundsBug-expected.checksum:
  • platform/chromium-mac/tables/mozilla/bugs/bug1430-expected.checksum: Copied from LayoutTests/platform/mac/tables/mozilla/bugs/bug1430-expected.checksum.
  • platform/chromium-mac/tables/mozilla/bugs/bug1430-expected.png: Added.
  • platform/chromium-mac/tables/mozilla/bugs/bug14929-expected.checksum: Copied from LayoutTests/platform/mac/tables/mozilla/bugs/bug14929-expected.checksum.
  • platform/chromium-mac/tables/mozilla/bugs/bug23235-expected.checksum: Copied from LayoutTests/platform/mac/tables/mozilla/bugs/bug23235-expected.checksum.
  • platform/chromium-mac/tables/mozilla/bugs/bug23235-expected.png: Added.
  • platform/chromium-mac/tables/mozilla/bugs/bug2981-2-expected.checksum: Copied from LayoutTests/platform/mac/tables/mozilla/bugs/bug2981-2-expected.checksum.
  • platform/chromium-mac/tables/mozilla/bugs/bug4427-expected.checksum: Copied from LayoutTests/platform/mac/tables/mozilla/bugs/bug4427-expected.checksum.
  • platform/chromium-mac/tables/mozilla/bugs/bug6404-expected.checksum: Copied from LayoutTests/platform/mac/tables/mozilla/bugs/bug6404-expected.checksum.
  • platform/chromium-mac/tables/mozilla/core/col_widths_auto_autoFix-expected.checksum: Copied from LayoutTests/platform/mac/tables/mozilla/core/col_widths_auto_autoFix-expected.checksum.
  • platform/chromium-mac/tables/mozilla/core/col_widths_auto_autoFix-expected.png: Added.
  • platform/chromium-mac/tables/mozilla/marvin/tbody_valign_baseline-expected.checksum: Copied from LayoutTests/platform/mac/tables/mozilla/marvin/tbody_valign_baseline-expected.checksum.
  • platform/chromium-mac/tables/mozilla/marvin/tbody_valign_bottom-expected.checksum: Copied from LayoutTests/platform/mac/tables/mozilla/marvin/tbody_valign_bottom-expected.checksum.
  • platform/chromium-mac/tables/mozilla/marvin/tbody_valign_middle-expected.checksum: Copied from LayoutTests/platform/mac/tables/mozilla/marvin/tbody_valign_middle-expected.checksum.
  • platform/chromium-mac/tables/mozilla/marvin/tbody_valign_top-expected.checksum: Copied from LayoutTests/platform/mac/tables/mozilla/marvin/tbody_valign_top-expected.checksum.
  • platform/chromium-mac/tables/mozilla/marvin/td_valign_baseline-expected.checksum: Copied from LayoutTests/platform/mac/tables/mozilla/marvin/td_valign_baseline-expected.checksum.
  • platform/chromium-mac/tables/mozilla/marvin/tfoot_valign_baseline-expected.checksum: Copied from LayoutTests/platform/mac/tables/mozilla/marvin/tfoot_valign_baseline-expected.checksum.
  • platform/chromium-mac/tables/mozilla/marvin/tfoot_valign_bottom-expected.checksum: Copied from LayoutTests/platform/mac/tables/mozilla/marvin/tfoot_valign_bottom-expected.checksum.
  • platform/chromium-mac/tables/mozilla/marvin/tfoot_valign_middle-expected.checksum: Copied from LayoutTests/platform/mac/tables/mozilla/marvin/tfoot_valign_middle-expected.checksum.
  • platform/chromium-mac/tables/mozilla/marvin/tfoot_valign_top-expected.checksum: Copied from LayoutTests/platform/mac/tables/mozilla/marvin/tfoot_valign_top-expected.checksum.
  • platform/chromium-mac/tables/mozilla/marvin/thead_valign_baseline-expected.checksum: Copied from LayoutTests/platform/mac/tables/mozilla/marvin/thead_valign_baseline-expected.checksum.
  • platform/chromium-mac/tables/mozilla/marvin/thead_valign_bottom-expected.checksum: Copied from LayoutTests/platform/mac/tables/mozilla/marvin/thead_valign_bottom-expected.checksum.
  • platform/chromium-mac/tables/mozilla/marvin/thead_valign_middle-expected.checksum: Copied from LayoutTests/platform/mac/tables/mozilla/marvin/thead_valign_middle-expected.checksum.
  • platform/chromium-mac/tables/mozilla/marvin/thead_valign_top-expected.checksum: Copied from LayoutTests/platform/mac/tables/mozilla/marvin/thead_valign_top-expected.checksum.
  • platform/chromium-mac/tables/mozilla/marvin/tr_valign_baseline-expected.checksum: Copied from LayoutTests/platform/mac/tables/mozilla/marvin/tr_valign_baseline-expected.checksum.
  • platform/chromium-mac/tables/mozilla_expected_failures/bugs/97619-expected.checksum: Copied from LayoutTests/platform/mac/tables/mozilla_expected_failures/bugs/97619-expected.checksum.
  • platform/chromium-win-xp/svg/text/text-fonts-01-t-expected.checksum:
  • platform/chromium-win-xp/svg/text/text-fonts-01-t-expected.png: Removed.
  • platform/chromium-win/svg/text/selection-doubleclick-expected.checksum:
  • platform/chromium-win/svg/text/selection-doubleclick-expected.png:
  • platform/chromium-win/svg/text/selection-tripleclick-expected.checksum:
  • platform/chromium-win/svg/text/selection-tripleclick-expected.png:
  • platform/chromium-win/svg/text/text-align-01-b-expected.checksum:
  • platform/chromium-win/svg/text/text-align-01-b-expected.png:
  • platform/chromium-win/svg/text/text-align-02-b-expected.checksum:
  • platform/chromium-win/svg/text/text-align-02-b-expected.png:
  • platform/chromium-win/svg/text/text-align-03-b-expected.checksum:
  • platform/chromium-win/svg/text/text-align-03-b-expected.png:
  • platform/chromium-win/svg/text/text-align-04-b-expected.checksum:
  • platform/chromium-win/svg/text/text-align-04-b-expected.png:
  • platform/chromium-win/svg/text/text-align-05-b-expected.checksum:
  • platform/chromium-win/svg/text/text-align-05-b-expected.png:
  • platform/chromium-win/svg/text/text-align-06-b-expected.checksum:
  • platform/chromium-win/svg/text/text-align-06-b-expected.png:
  • platform/chromium-win/svg/text/text-altglyph-01-b-expected.checksum:
  • platform/chromium-win/svg/text/text-altglyph-01-b-expected.png:
  • platform/chromium-win/svg/text/text-deco-01-b-expected.checksum:
  • platform/chromium-win/svg/text/text-deco-01-b-expected.png:
  • platform/chromium-win/svg/text/text-fonts-01-t-expected.checksum:
  • platform/chromium-win/svg/text/text-fonts-01-t-expected.png:
  • platform/chromium-win/svg/text/text-fonts-02-t-expected.checksum:
  • platform/chromium-win/svg/text/text-fonts-02-t-expected.png:
  • platform/chromium-win/svg/text/text-intro-05-t-expected.checksum:
  • platform/chromium-win/svg/text/text-intro-05-t-expected.png:
  • platform/chromium-win/svg/text/text-path-01-b-expected.checksum:
  • platform/chromium-win/svg/text/text-path-01-b-expected.png:
  • platform/chromium-win/svg/text/text-spacing-01-b-expected.checksum:
  • platform/chromium-win/svg/text/text-spacing-01-b-expected.png:
  • platform/chromium-win/svg/text/text-text-01-b-expected.checksum:
  • platform/chromium-win/svg/text/text-text-01-b-expected.png:
  • platform/chromium-win/svg/text/text-text-03-b-expected.checksum:
  • platform/chromium-win/svg/text/text-text-03-b-expected.png:
  • platform/chromium-win/svg/text/text-text-04-t-expected.checksum:
  • platform/chromium-win/svg/text/text-text-04-t-expected.png:
  • platform/chromium-win/svg/text/text-text-06-t-expected.checksum:
  • platform/chromium-win/svg/text/text-text-06-t-expected.png:
  • platform/chromium-win/svg/text/text-text-07-t-expected.checksum:
  • platform/chromium-win/svg/text/text-text-07-t-expected.png:
  • platform/chromium-win/svg/text/text-text-08-b-expected.checksum:
  • platform/chromium-win/svg/text/text-text-08-b-expected.png:
  • platform/chromium-win/svg/text/text-tref-01-b-expected.checksum:
  • platform/chromium-win/svg/text/text-tref-01-b-expected.png:
  • platform/chromium-win/svg/text/text-tselect-01-b-expected.checksum:
  • platform/chromium-win/svg/text/text-tselect-01-b-expected.png:
  • platform/chromium-win/svg/text/text-tselect-02-f-expected.checksum:
  • platform/chromium-win/svg/text/text-tselect-02-f-expected.png:
  • platform/chromium-win/svg/text/text-tspan-01-b-expected.checksum:
  • platform/chromium-win/svg/text/text-tspan-01-b-expected.png:
  • platform/chromium-win/svg/text/text-ws-01-t-expected.checksum:
  • platform/chromium-win/svg/text/text-ws-01-t-expected.png:
  • platform/chromium-win/svg/text/text-ws-02-t-expected.checksum:
  • platform/chromium-win/svg/text/text-ws-02-t-expected.png:
  • platform/chromium-win/svg/text/textPathBoundsBug-expected.checksum:
  • platform/chromium-win/svg/text/textPathBoundsBug-expected.png:
8:09 AM Changeset in webkit [61763] by leandro@webkit.org
  • 2 edits in trunk/JavaScriptCore

2010-06-24 Leandro Pereira <​leandro@profusion.mobi>

Unreviewed build fix.

  • CMakeLists.txt: Add JSParser.cpp.
7:41 AM Changeset in webkit [61762] by Adam Roben
  • 3 edits
    1 copy
    1 add in trunk/WebKit2

Windows build fix

Fixes <​http://webkit.org/b/41158>.

Reviewed by Anders Carlsson.

  • Shared/win/UpdateChunk.cpp: Updated header name.
  • UIProcess/Plugins/win/PluginInfoStoreWin.cpp: Added.

(WebKit::PluginInfoStore::pluginDirectories):
(WebKit::PluginInfoStore::pluginPathsInDirectory):
(WebKit::PluginInfoStore::getPluginInfo):
(WebKit::PluginInfoStore::shouldUsePlugin):
Stubbed these out.

  • win/WebKit2.vcproj: Added UIProcess/Plugins to the include path for

all configurations. Added UIProcess/Plugins files to the project.

6:46 AM Changeset in webkit [61761] by senorblanco@chromium.org
  • 394 edits
    1 add
    3 deletes in trunk/LayoutTests

2010-06-23 Stephen White <​senorblanco@chromium.org>

Unreviewed; expectations fix.

This updates the pixel test baselines after r61710, and removes
them from test_expectations.txt.

  • platform/chromium-linux/css2.1/t090501-c414-flt-03-b-g-expected.checksum:
  • platform/chromium-linux/css2.1/t090501-c414-flt-03-b-g-expected.png:
  • platform/chromium-linux/css2.1/t090501-c5525-flt-l-00-b-g-expected.checksum:
  • platform/chromium-linux/css2.1/t090501-c5525-flt-l-00-b-g-expected.png:
  • platform/chromium-linux/css2.1/t090501-c5525-flt-r-00-b-g-expected.checksum:
  • platform/chromium-linux/css2.1/t090501-c5525-flt-r-00-b-g-expected.png:
  • platform/chromium-linux/fast/backgrounds/size/backgroundSize11-expected.checksum: Removed.
  • platform/chromium-linux/fast/backgrounds/size/backgroundSize15-expected.checksum:
  • platform/chromium-linux/fast/backgrounds/size/backgroundSize15-expected.png:
  • platform/chromium-linux/fast/backgrounds/size/backgroundSize16-expected.checksum:
  • platform/chromium-linux/fast/backgrounds/size/backgroundSize16-expected.png:
  • platform/chromium-linux/fast/backgrounds/size/backgroundSize19-expected.checksum: Removed.
  • platform/chromium-linux/fast/backgrounds/size/backgroundSize22-expected.checksum: Removed.
  • platform/chromium-linux/fast/block/positioning/replaced-inside-fixed-top-bottom-expected.checksum: Added.
  • platform/chromium-linux/fast/css/value-list-out-of-bounds-crash-expected.checksum:
  • platform/chromium-linux/fast/events/pointer-events-2-expected.checksum:
  • platform/chromium-linux/fast/events/pointer-events-2-expected.png:
  • platform/chromium-linux/fast/forms/input-type-change-expected.checksum:
  • platform/chromium-linux/fast/forms/input-type-change-expected.png:
  • platform/chromium-linux/fast/replaced/absolute-image-sizing-expected.checksum:
  • platform/chromium-linux/fast/replaced/absolute-image-sizing-expected.png:
  • platform/chromium-linux/fast/replaced/image-sizing-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug101674-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug101674-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug11026-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug1188-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug1188-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug1296-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug1430-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug1430-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug14929-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug14929-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug15544-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug2981-2-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug2981-2-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug4093-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug4093-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug4284-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug4427-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug4427-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug56563-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug625-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug625-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug6404-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug6404-expected.png:
  • platform/chromium-linux/tables/mozilla/core/bloomberg-expected.checksum:
  • platform/chromium-linux/tables/mozilla/core/bloomberg-expected.png:
  • platform/chromium-linux/tables/mozilla/core/col_widths_auto_autoFix-expected.checksum:
  • platform/chromium-linux/tables/mozilla/core/misc-expected.checksum:
  • platform/chromium-linux/tables/mozilla/marvin/tbody_valign_baseline-expected.checksum:
  • platform/chromium-linux/tables/mozilla/marvin/tbody_valign_bottom-expected.checksum:
  • platform/chromium-linux/tables/mozilla/marvin/tbody_valign_middle-expected.checksum:
  • platform/chromium-linux/tables/mozilla/marvin/tbody_valign_top-expected.checksum:
  • platform/chromium-linux/tables/mozilla/marvin/td_valign_baseline-expected.checksum:
  • platform/chromium-linux/tables/mozilla/marvin/td_valign_bottom-expected.checksum:
  • platform/chromium-linux/tables/mozilla/marvin/td_valign_middle-expected.checksum:
  • platform/chromium-linux/tables/mozilla/marvin/td_valign_top-expected.checksum:
  • platform/chromium-linux/tables/mozilla/marvin/tfoot_valign_baseline-expected.checksum:
  • platform/chromium-linux/tables/mozilla/marvin/tfoot_valign_bottom-expected.checksum:
  • platform/chromium-linux/tables/mozilla/marvin/tfoot_valign_middle-expected.checksum:
  • platform/chromium-linux/tables/mozilla/marvin/tfoot_valign_top-expected.checksum:
  • platform/chromium-linux/tables/mozilla/marvin/th_valign_baseline-expected.checksum:
  • platform/chromium-linux/tables/mozilla/marvin/th_valign_bottom-expected.checksum:
  • platform/chromium-linux/tables/mozilla/marvin/th_valign_middle-expected.checksum:
  • platform/chromium-linux/tables/mozilla/marvin/th_valign_top-expected.checksum:
  • platform/chromium-linux/tables/mozilla/marvin/thead_valign_baseline-expected.checksum:
  • platform/chromium-linux/tables/mozilla/marvin/thead_valign_bottom-expected.checksum:
  • platform/chromium-linux/tables/mozilla/marvin/thead_valign_middle-expected.checksum:
  • platform/chromium-linux/tables/mozilla/marvin/thead_valign_top-expected.checksum:
  • platform/chromium-linux/tables/mozilla/marvin/tr_valign_baseline-expected.checksum:
  • platform/chromium-linux/tables/mozilla/marvin/tr_valign_bottom-expected.checksum:
  • platform/chromium-linux/tables/mozilla/marvin/tr_valign_middle-expected.checksum:
  • platform/chromium-linux/tables/mozilla/marvin/tr_valign_top-expected.checksum:
  • platform/chromium-linux/tables/mozilla/other/cell_widths-expected.checksum:
  • platform/chromium-linux/tables/mozilla/other/cell_widths-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/97619-expected.checksum:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/97619-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug6933-expected.checksum:
  • platform/chromium-win/css2.1/t090501-c414-flt-03-b-g-expected.checksum:
  • platform/chromium-win/css2.1/t090501-c414-flt-03-b-g-expected.png:
  • platform/chromium-win/css2.1/t090501-c5525-flt-l-00-b-g-expected.checksum:
  • platform/chromium-win/css2.1/t090501-c5525-flt-l-00-b-g-expected.png:
  • platform/chromium-win/css2.1/t090501-c5525-flt-r-00-b-g-expected.checksum:
  • platform/chromium-win/css2.1/t090501-c5525-flt-r-00-b-g-expected.png:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize01-expected.checksum:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize01-expected.png:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize02-expected.checksum:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize02-expected.png:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize04-expected.checksum:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize04-expected.png:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize05-expected.checksum:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize05-expected.png:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize06-expected.checksum:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize06-expected.png:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize07-expected.checksum:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize07-expected.png:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize08-expected.checksum:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize08-expected.png:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize09-expected.checksum:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize09-expected.png:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize10-expected.checksum:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize10-expected.png:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize11-expected.checksum:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize11-expected.png:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize12-expected.checksum:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize12-expected.png:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize13-expected.checksum:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize13-expected.png:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize14-expected.checksum:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize14-expected.png:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize15-expected.checksum:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize15-expected.png:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize16-expected.checksum:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize16-expected.png:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize17-expected.checksum:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize17-expected.png:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize18-expected.checksum:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize18-expected.png:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize19-expected.checksum:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize19-expected.png:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize20-expected.checksum:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize20-expected.png:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize21-expected.checksum:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize21-expected.png:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize22-expected.checksum:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize22-expected.png:
  • platform/chromium-win/fast/block/positioning/replaced-inside-fixed-top-bottom-expected.checksum:
  • platform/chromium-win/fast/block/positioning/replaced-inside-fixed-top-bottom-expected.png:
  • platform/chromium-win/fast/css/value-list-out-of-bounds-crash-expected.checksum:
  • platform/chromium-win/fast/css/value-list-out-of-bounds-crash-expected.png:
  • platform/chromium-win/fast/events/pointer-events-2-expected.checksum:
  • platform/chromium-win/fast/events/pointer-events-2-expected.png:
  • platform/chromium-win/fast/forms/input-type-change-expected.checksum:
  • platform/chromium-win/fast/forms/input-type-change-expected.png:
  • platform/chromium-win/fast/replaced/absolute-image-sizing-expected.checksum:
  • platform/chromium-win/fast/replaced/absolute-image-sizing-expected.png:
  • platform/chromium-win/fast/replaced/image-sizing-expected.checksum:
  • platform/chromium-win/fast/replaced/image-sizing-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug101674-expected.checksum:
  • platform/chromium-win/tables/mozilla/bugs/bug101674-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug11026-expected.checksum:
  • platform/chromium-win/tables/mozilla/bugs/bug11026-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug1188-expected.checksum:
  • platform/chromium-win/tables/mozilla/bugs/bug1188-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug1296-expected.checksum:
  • platform/chromium-win/tables/mozilla/bugs/bug1296-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug1430-expected.checksum:
  • platform/chromium-win/tables/mozilla/bugs/bug1430-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug14929-expected.checksum:
  • platform/chromium-win/tables/mozilla/bugs/bug14929-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug15544-expected.checksum:
  • platform/chromium-win/tables/mozilla/bugs/bug15544-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug2981-2-expected.checksum:
  • platform/chromium-win/tables/mozilla/bugs/bug2981-2-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug4093-expected.checksum:
  • platform/chromium-win/tables/mozilla/bugs/bug4093-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug4284-expected.checksum:
  • platform/chromium-win/tables/mozilla/bugs/bug4284-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug4427-expected.checksum:
  • platform/chromium-win/tables/mozilla/bugs/bug4427-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug56563-expected.checksum:
  • platform/chromium-win/tables/mozilla/bugs/bug56563-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug625-expected.checksum:
  • platform/chromium-win/tables/mozilla/bugs/bug625-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug6404-expected.checksum:
  • platform/chromium-win/tables/mozilla/bugs/bug6404-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug97383-expected.checksum:
  • platform/chromium-win/tables/mozilla/bugs/bug97383-expected.png:
  • platform/chromium-win/tables/mozilla/core/bloomberg-expected.checksum:
  • platform/chromium-win/tables/mozilla/core/bloomberg-expected.png:
  • platform/chromium-win/tables/mozilla/core/col_widths_auto_autoFix-expected.checksum:
  • platform/chromium-win/tables/mozilla/core/col_widths_auto_autoFix-expected.png:
  • platform/chromium-win/tables/mozilla/core/misc-expected.checksum:
  • platform/chromium-win/tables/mozilla/core/misc-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tbody_valign_baseline-expected.checksum:
  • platform/chromium-win/tables/mozilla/marvin/tbody_valign_baseline-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tbody_valign_bottom-expected.checksum:
  • platform/chromium-win/tables/mozilla/marvin/tbody_valign_bottom-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tbody_valign_middle-expected.checksum:
  • platform/chromium-win/tables/mozilla/marvin/tbody_valign_middle-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tbody_valign_top-expected.checksum:
  • platform/chromium-win/tables/mozilla/marvin/tbody_valign_top-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/td_valign_baseline-expected.checksum:
  • platform/chromium-win/tables/mozilla/marvin/td_valign_baseline-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/td_valign_bottom-expected.checksum:
  • platform/chromium-win/tables/mozilla/marvin/td_valign_bottom-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/td_valign_middle-expected.checksum:
  • platform/chromium-win/tables/mozilla/marvin/td_valign_middle-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/td_valign_top-expected.checksum:
  • platform/chromium-win/tables/mozilla/marvin/td_valign_top-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tfoot_valign_baseline-expected.checksum:
  • platform/chromium-win/tables/mozilla/marvin/tfoot_valign_baseline-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tfoot_valign_bottom-expected.checksum:
  • platform/chromium-win/tables/mozilla/marvin/tfoot_valign_bottom-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tfoot_valign_middle-expected.checksum:
  • platform/chromium-win/tables/mozilla/marvin/tfoot_valign_middle-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tfoot_valign_top-expected.checksum:
  • platform/chromium-win/tables/mozilla/marvin/tfoot_valign_top-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/th_valign_baseline-expected.checksum:
  • platform/chromium-win/tables/mozilla/marvin/th_valign_baseline-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/th_valign_bottom-expected.checksum:
  • platform/chromium-win/tables/mozilla/marvin/th_valign_bottom-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/th_valign_middle-expected.checksum:
  • platform/chromium-win/tables/mozilla/marvin/th_valign_middle-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/th_valign_top-expected.checksum:
  • platform/chromium-win/tables/mozilla/marvin/th_valign_top-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/thead_valign_baseline-expected.checksum:
  • platform/chromium-win/tables/mozilla/marvin/thead_valign_baseline-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/thead_valign_bottom-expected.checksum:
  • platform/chromium-win/tables/mozilla/marvin/thead_valign_bottom-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/thead_valign_middle-expected.checksum:
  • platform/chromium-win/tables/mozilla/marvin/thead_valign_middle-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/thead_valign_top-expected.checksum:
  • platform/chromium-win/tables/mozilla/marvin/thead_valign_top-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tr_valign_baseline-expected.checksum:
  • platform/chromium-win/tables/mozilla/marvin/tr_valign_baseline-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tr_valign_bottom-expected.checksum:
  • platform/chromium-win/tables/mozilla/marvin/tr_valign_bottom-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tr_valign_middle-expected.checksum:
  • platform/chromium-win/tables/mozilla/marvin/tr_valign_middle-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tr_valign_top-expected.checksum:
  • platform/chromium-win/tables/mozilla/marvin/tr_valign_top-expected.png:
  • platform/chromium-win/tables/mozilla/other/cell_widths-expected.checksum:
  • platform/chromium-win/tables/mozilla/other/cell_widths-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/97619-expected.checksum:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/97619-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug6933-expected.checksum:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug6933-expected.png:
  • platform/chromium/test_expectations.txt:
  • platform/mac/css2.1/t0804-c5510-padn-00-b-ag-expected.checksum:
  • platform/mac/css2.1/t0804-c5510-padn-00-b-ag-expected.png:
  • platform/mac/css2.1/t0905-c414-flt-01-d-g-expected.checksum:
  • platform/mac/css2.1/t0905-c414-flt-01-d-g-expected.png:
  • platform/mac/css2.1/t090501-c414-flt-02-d-g-expected.checksum:
  • platform/mac/css2.1/t090501-c414-flt-02-d-g-expected.png:
  • platform/mac/css2.1/t090501-c414-flt-03-b-g-expected.checksum:
  • platform/mac/css2.1/t090501-c414-flt-03-b-g-expected.png:
  • platform/mac/css2.1/t090501-c414-flt-ln-01-d-g-expected.checksum:
  • platform/mac/css2.1/t090501-c414-flt-ln-01-d-g-expected.png:
  • platform/mac/css2.1/t090501-c5525-flt-l-00-b-g-expected.checksum:
  • platform/mac/css2.1/t090501-c5525-flt-l-00-b-g-expected.png:
  • platform/mac/css2.1/t090501-c5525-flt-r-00-b-g-expected.checksum:
  • platform/mac/css2.1/t090501-c5525-flt-r-00-b-g-expected.png:
  • platform/mac/css2.1/t100304-c43-rpl-bbx-00-d-g-expected.checksum:
  • platform/mac/css2.1/t100304-c43-rpl-bbx-00-d-g-expected.png:
  • platform/mac/css2.1/t100304-c43-rpl-bbx-01-d-g-expected.checksum:
  • platform/mac/css2.1/t100304-c43-rpl-bbx-01-d-g-expected.png:
  • platform/mac/css2.1/t1004-c5524-width-00-b-g-expected.checksum:
  • platform/mac/css2.1/t1004-c5524-width-00-b-g-expected.png:
  • platform/mac/css2.1/t100801-c544-valgn-02-d-agi-expected.checksum:
  • platform/mac/css2.1/t100801-c544-valgn-02-d-agi-expected.png:
  • platform/mac/css2.1/t100801-c544-valgn-03-d-agi-expected.checksum:
  • platform/mac/css2.1/t100801-c544-valgn-03-d-agi-expected.png:
  • platform/mac/css2.1/t100801-c544-valgn-04-d-agi-expected.checksum:
  • platform/mac/css2.1/t100801-c544-valgn-04-d-agi-expected.png:
  • platform/mac/fast/backgrounds/repeat/mask-negative-offset-repeat-expected.checksum:
  • platform/mac/fast/backgrounds/repeat/mask-negative-offset-repeat-expected.png:
  • platform/mac/fast/backgrounds/size/backgroundSize01-expected.checksum:
  • platform/mac/fast/backgrounds/size/backgroundSize01-expected.png:
  • platform/mac/fast/backgrounds/size/backgroundSize05-expected.checksum:
  • platform/mac/fast/backgrounds/size/backgroundSize05-expected.png:
  • platform/mac/fast/backgrounds/size/backgroundSize06-expected.checksum:
  • platform/mac/fast/backgrounds/size/backgroundSize06-expected.png:
  • platform/mac/fast/backgrounds/size/backgroundSize07-expected.checksum:
  • platform/mac/fast/backgrounds/size/backgroundSize07-expected.png:
  • platform/mac/fast/backgrounds/size/backgroundSize08-expected.checksum:
  • platform/mac/fast/backgrounds/size/backgroundSize08-expected.png:
  • platform/mac/fast/backgrounds/size/backgroundSize09-expected.checksum:
  • platform/mac/fast/backgrounds/size/backgroundSize09-expected.png:
  • platform/mac/fast/backgrounds/size/backgroundSize10-expected.checksum:
  • platform/mac/fast/backgrounds/size/backgroundSize10-expected.png:
  • platform/mac/fast/backgrounds/size/backgroundSize11-expected.checksum:
  • platform/mac/fast/backgrounds/size/backgroundSize11-expected.png:
  • platform/mac/fast/backgrounds/size/backgroundSize12-expected.checksum:
  • platform/mac/fast/backgrounds/size/backgroundSize12-expected.png:
  • platform/mac/fast/backgrounds/size/backgroundSize16-expected.checksum:
  • platform/mac/fast/backgrounds/size/backgroundSize16-expected.png:
  • platform/mac/fast/backgrounds/size/backgroundSize17-expected.checksum:
  • platform/mac/fast/backgrounds/size/backgroundSize17-expected.png:
  • platform/mac/fast/backgrounds/size/backgroundSize18-expected.checksum:
  • platform/mac/fast/backgrounds/size/backgroundSize18-expected.png:
  • platform/mac/fast/backgrounds/size/backgroundSize19-expected.checksum:
  • platform/mac/fast/backgrounds/size/backgroundSize19-expected.png:
  • platform/mac/fast/backgrounds/size/backgroundSize20-expected.checksum:
  • platform/mac/fast/backgrounds/size/backgroundSize20-expected.png:
  • platform/mac/fast/backgrounds/size/backgroundSize21-expected.checksum:
  • platform/mac/fast/backgrounds/size/backgroundSize21-expected.png:
  • platform/mac/fast/backgrounds/size/backgroundSize22-expected.checksum:
  • platform/mac/fast/backgrounds/size/backgroundSize22-expected.png:
  • platform/mac/fast/backgrounds/size/zero-expected.checksum:
  • platform/mac/fast/backgrounds/size/zero-expected.png:
  • platform/mac/fast/block/positioning/replaced-inside-fixed-top-bottom-expected.checksum:
  • platform/mac/fast/block/positioning/replaced-inside-fixed-top-bottom-expected.png:
  • platform/mac/fast/canvas/canvas-as-image-expected.checksum:
  • platform/mac/fast/canvas/canvas-as-image-expected.png:
  • platform/mac/fast/css/value-list-out-of-bounds-crash-expected.checksum:
  • platform/mac/fast/css/value-list-out-of-bounds-crash-expected.png:
  • platform/mac/fast/forms/input-type-change-expected.checksum:
  • platform/mac/fast/forms/input-type-change-expected.png:
  • platform/mac/fast/replaced/001-expected.checksum:
  • platform/mac/fast/replaced/001-expected.png:
  • platform/mac/fast/replaced/002-expected.checksum:
  • platform/mac/fast/replaced/002-expected.png:
  • platform/mac/fast/replaced/003-expected.checksum:
  • platform/mac/fast/replaced/003-expected.png:
  • platform/mac/fast/replaced/absolute-image-sizing-expected.checksum:
  • platform/mac/fast/replaced/absolute-image-sizing-expected.png:
  • platform/mac/fast/replaced/image-sizing-expected.checksum:
  • platform/mac/fast/replaced/image-sizing-expected.png:
  • platform/mac/tables/mozilla/bugs/bug11026-expected.checksum:
  • platform/mac/tables/mozilla/bugs/bug11026-expected.png:
  • platform/mac/tables/mozilla/bugs/bug1188-expected.checksum:
  • platform/mac/tables/mozilla/bugs/bug1188-expected.png:
  • platform/mac/tables/mozilla/bugs/bug1296-expected.checksum:
  • platform/mac/tables/mozilla/bugs/bug1296-expected.png:
  • platform/mac/tables/mozilla/bugs/bug1430-expected.checksum:
  • platform/mac/tables/mozilla/bugs/bug1430-expected.png:
  • platform/mac/tables/mozilla/bugs/bug14929-expected.checksum:
  • platform/mac/tables/mozilla/bugs/bug14929-expected.png:
  • platform/mac/tables/mozilla/bugs/bug15544-expected.checksum:
  • platform/mac/tables/mozilla/bugs/bug15544-expected.png:
  • platform/mac/tables/mozilla/bugs/bug23235-expected.checksum:
  • platform/mac/tables/mozilla/bugs/bug23235-expected.png:
  • platform/mac/tables/mozilla/bugs/bug2981-2-expected.checksum:
  • platform/mac/tables/mozilla/bugs/bug2981-2-expected.png:
  • platform/mac/tables/mozilla/bugs/bug4093-expected.checksum:
  • platform/mac/tables/mozilla/bugs/bug4093-expected.png:
  • platform/mac/tables/mozilla/bugs/bug4284-expected.checksum:
  • platform/mac/tables/mozilla/bugs/bug4284-expected.png:
  • platform/mac/tables/mozilla/bugs/bug4427-expected.checksum:
  • platform/mac/tables/mozilla/bugs/bug4427-expected.png:
  • platform/mac/tables/mozilla/bugs/bug4523-expected.checksum:
  • platform/mac/tables/mozilla/bugs/bug4523-expected.png:
  • platform/mac/tables/mozilla/bugs/bug56563-expected.checksum:
  • platform/mac/tables/mozilla/bugs/bug56563-expected.png:
  • platform/mac/tables/mozilla/bugs/bug6404-expected.checksum:
  • platform/mac/tables/mozilla/bugs/bug6404-expected.png:
  • platform/mac/tables/mozilla/bugs/bug86708-expected.checksum:
  • platform/mac/tables/mozilla/bugs/bug86708-expected.png:
  • platform/mac/tables/mozilla/bugs/bug97383-expected.checksum:
  • platform/mac/tables/mozilla/bugs/bug97383-expected.png:
  • platform/mac/tables/mozilla/core/col_widths_auto_autoFix-expected.checksum:
  • platform/mac/tables/mozilla/core/col_widths_auto_autoFix-expected.png:
  • platform/mac/tables/mozilla/core/misc-expected.checksum:
  • platform/mac/tables/mozilla/core/misc-expected.png:
  • platform/mac/tables/mozilla/marvin/tbody_valign_baseline-expected.checksum:
  • platform/mac/tables/mozilla/marvin/tbody_valign_baseline-expected.png:
  • platform/mac/tables/mozilla/marvin/tbody_valign_bottom-expected.checksum:
  • platform/mac/tables/mozilla/marvin/tbody_valign_bottom-expected.png:
  • platform/mac/tables/mozilla/marvin/tbody_valign_middle-expected.checksum:
  • platform/mac/tables/mozilla/marvin/tbody_valign_middle-expected.png:
  • platform/mac/tables/mozilla/marvin/tbody_valign_top-expected.checksum:
  • platform/mac/tables/mozilla/marvin/tbody_valign_top-expected.png:
  • platform/mac/tables/mozilla/marvin/td_valign_baseline-expected.checksum:
  • platform/mac/tables/mozilla/marvin/td_valign_baseline-expected.png:
  • platform/mac/tables/mozilla/marvin/td_valign_bottom-expected.checksum:
  • platform/mac/tables/mozilla/marvin/td_valign_bottom-expected.png:
  • platform/mac/tables/mozilla/marvin/td_valign_middle-expected.checksum:
  • platform/mac/tables/mozilla/marvin/td_valign_middle-expected.png:
  • platform/mac/tables/mozilla/marvin/td_valign_top-expected.checksum:
  • platform/mac/tables/mozilla/marvin/td_valign_top-expected.png:
  • platform/mac/tables/mozilla/marvin/tfoot_valign_baseline-expected.checksum:
  • platform/mac/tables/mozilla/marvin/tfoot_valign_baseline-expected.png:
  • platform/mac/tables/mozilla/marvin/tfoot_valign_bottom-expected.checksum:
  • platform/mac/tables/mozilla/marvin/tfoot_valign_bottom-expected.png:
  • platform/mac/tables/mozilla/marvin/tfoot_valign_middle-expected.checksum:
  • platform/mac/tables/mozilla/marvin/tfoot_valign_middle-expected.png:
  • platform/mac/tables/mozilla/marvin/tfoot_valign_top-expected.checksum:
  • platform/mac/tables/mozilla/marvin/tfoot_valign_top-expected.png:
  • platform/mac/tables/mozilla/marvin/th_valign_baseline-expected.checksum:
  • platform/mac/tables/mozilla/marvin/th_valign_baseline-expected.png:
  • platform/mac/tables/mozilla/marvin/th_valign_bottom-expected.checksum:
  • platform/mac/tables/mozilla/marvin/th_valign_bottom-expected.png:
  • platform/mac/tables/mozilla/marvin/th_valign_middle-expected.checksum:
  • platform/mac/tables/mozilla/marvin/th_valign_middle-expected.png:
  • platform/mac/tables/mozilla/marvin/th_valign_top-expected.checksum:
  • platform/mac/tables/mozilla/marvin/th_valign_top-expected.png:
  • platform/mac/tables/mozilla/marvin/thead_valign_baseline-expected.checksum:
  • platform/mac/tables/mozilla/marvin/thead_valign_baseline-expected.png:
  • platform/mac/tables/mozilla/marvin/thead_valign_bottom-expected.checksum:
  • platform/mac/tables/mozilla/marvin/thead_valign_bottom-expected.png:
  • platform/mac/tables/mozilla/marvin/thead_valign_middle-expected.checksum:
  • platform/mac/tables/mozilla/marvin/thead_valign_middle-expected.png:
  • platform/mac/tables/mozilla/marvin/thead_valign_top-expected.checksum:
  • platform/mac/tables/mozilla/marvin/thead_valign_top-expected.png:
  • platform/mac/tables/mozilla/marvin/tr_valign_baseline-expected.checksum:
  • platform/mac/tables/mozilla/marvin/tr_valign_baseline-expected.png:
  • platform/mac/tables/mozilla/marvin/tr_valign_bottom-expected.checksum:
  • platform/mac/tables/mozilla/marvin/tr_valign_bottom-expected.png:
  • platform/mac/tables/mozilla/marvin/tr_valign_middle-expected.checksum:
  • platform/mac/tables/mozilla/marvin/tr_valign_middle-expected.png:
  • platform/mac/tables/mozilla/marvin/tr_valign_top-expected.checksum:
  • platform/mac/tables/mozilla/marvin/tr_valign_top-expected.png:
  • platform/mac/tables/mozilla_expected_failures/bugs/97619-expected.checksum:
  • platform/mac/tables/mozilla_expected_failures/bugs/97619-expected.png:
  • platform/mac/tables/mozilla_expected_failures/bugs/bug6933-expected.checksum:
  • platform/mac/tables/mozilla_expected_failures/bugs/bug6933-expected.png:
5:57 AM Changeset in webkit [61760] by tkent@chromium.org
  • 2 edits in trunk/WebCore

Unreviewed. Build fix for Tiger.

  • platform/mac/ThemeMac.mm:

(WebCore::setControlSize):

5:38 AM Changeset in webkit [61759] by Nikolas Zimmermann
  • 15 edits in trunk/WebCore

2010-06-24 Nikolas Zimmermann <​nzimmermann@rim.com>

Reviewed by Dirk Schulze.

Inspector & SVG Text have problems, kids of RenderSVGText are not properly placed.
​https://bugs.webkit.org/show_bug.cgi?id=41143

Simplify code path taken for SVG text in InspectorController, take the code path currently only used for RenderInline,
that just calls absoluteQuads(), and displays the result. Refactored code that all SVG renderers (except RenderSVGRoot)
take this code path -> highlighting now works as expected.

Don't use absoluteClippedOverlowRect() in the various RenderSVG*::absoluteQuads() methods, as we're loosing floating-point precision.
Instead use localToAbsoluteQuad(strokeBoundingBox()) in order to highlight the unclipped, unfiltered, etc.. region that this renderer would paint.

No new tests, as this is only manual testable - at least I didn't find any Inspector-Highlighting tests, if someone knows please mail me.

  • inspector/InspectorController.cpp: (WebCore::drawHighlightForLineBoxesOrSVGRenderer): (WebCore::InspectorController::drawNodeHighlight):
  • rendering/RenderSVGBlock.cpp: (WebCore::RenderSVGBlock::absoluteRects): ASSERT_NOT_REACHED() here. SVG should only be inspected through absoluteQuads().
  • rendering/RenderSVGBlock.h: Add absoluteRects() in this base class for RenderForeignObject/RenderSVGText.
  • rendering/RenderSVGHiddenContainer.cpp: Remove absoluteRects() - RenderSVGModelObject already has it.
  • rendering/RenderSVGHiddenContainer.h: Ditto.
  • rendering/RenderSVGImage.cpp: (WebCore::RenderSVGImage::absoluteRects): ASSERT_NOT_REACHED() here. (WebCore::RenderSVGImage::absoluteQuads): Don't use absoluteClippedOverlowRect() but localToAbsoluteQuad(repaintRectInLocalCoordinates()).
  • rendering/RenderSVGImage.h: (WebCore::RenderSVGImage::objectBoundingBox): Inlined
  • rendering/RenderSVGInline.cpp: (WebCore::RenderSVGInline::absoluteQuads): Take RenderSVGText translation into account, allows inspecting <tspan>/<tref> etc.
  • rendering/RenderSVGInline.h:
  • rendering/RenderSVGModelObject.cpp: (WebCore::RenderSVGModelObject::absoluteRects): ASSERT_NOT_REACHED() here. (WebCore::RenderSVGModelObject::absoluteQuads): Don't use absoluteClippedOverlowRect() but localToAbsoluteQuad(repaintRectInLocalCoordinates()).
  • rendering/RenderSVGModelObject.h:
  • rendering/RenderSVGRoot.cpp: Fix typo in license s/aint/along. Need to touch this file in order to let Mac build.
  • rendering/RenderSVGText.cpp: (WebCore::RenderSVGText::mapLocalToContainer): Remove hack, which moved the transformState by x()/y(). Not needed anymore. (WebCore::RenderSVGText::absoluteQuads): Proper implementation, respecting x/y translation.
  • rendering/RenderSVGText.h: Reorder some functions.
  • rendering/SVGRenderSupport.h: Removed last virtual function strokeBoundingBox().
5:36 AM Changeset in webkit [61758] by tkent@chromium.org
  • 2 edits in trunk/WebCore

2010-06-24 Kent Tamura <​tkent@chromium.org>

Unreviewed. Build fix for Tiger.

  • platform/mac/ThemeMac.mm: (WebCore::setControlSize): (WebCore::ThemeMac::inflateControlPaintRect):
5:24 AM Changeset in webkit [61757] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

Unreviewed typo fix after r61754.

  • platform/qt/Skipped:
5:02 AM Changeset in webkit [61756] by tkent@chromium.org
  • 2 edits in trunk/WebCore

2010-06-24 Kent Tamura <​tkent@chromium.org>

Unreviewed. Build fix for Chromium Mac.

  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::isSpeechEnabled):
5:00 AM Changeset in webkit [61755] by Simon Hausmann
  • 4 edits in trunk

Unreviewed Symbian build fix.

The QML WebKit integration needs to be part of QtWebKit.sis

WebCore:

  • WebCore.pro: Deploy qmlwebkitplugin.dll.

WebKit/qt:

  • declarative/declarative.pro: Removed non-working deployment.
4:46 AM Changeset in webkit [61754] by Csaba Osztrogonác
  • 3 edits in trunk/LayoutTests

[Qt] Regression(r61749): inspector/debugger-pause-on-debugger-statement.html fails
​https://bugs.webkit.org/show_bug.cgi?id=41147

  • platform/qt/Skipped: inspector/debugger-pause-on-debugger-statement.html skipped.
  • platform/qt-linux/Skipped: revert last change, because we only use the general platform/qt/Skipped list.
4:32 AM Changeset in webkit [61753] by yurys@chromium.org
  • 2 edits in trunk/LayoutTests

2010-06-24 Yury Semikhatsky <​yurys@chromium.org>

Unreviewed: disable new inspector test on Qt linux.

  • platform/qt-linux/Skipped:
3:40 AM Changeset in webkit [61752] by jorlow@chromium.org
  • 17 edits in trunk/WebCore

2010-06-24 Satish Sampath <​satish@chromium.org>

Reviewed by Kent Tamura.

Add a speech button to input elements, no rendering or actions yet.

Speech Input: Add a speech button to text input element (no rendering or actions yet)
​https://bugs.webkit.org/show_bug.cgi?id=40925

No new tests. Will create a layout test in a subsequent patch.

  • css/CSSPrimitiveValueMappings.h: (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
  • css/CSSSelector.cpp: (WebCore::CSSSelector::pseudoId): (WebCore::nameToPseudoTypeMap): (WebCore::CSSSelector::extractPseudoType):
  • css/CSSSelector.h: (WebCore::CSSSelector::):
  • css/CSSValueKeywords.in:
  • css/html.css: (input::-webkit-input-speech-button):
  • dom/InputElement.h:
  • html/HTMLAttributeNames.in:
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::isSpeechEnabled):
  • html/HTMLInputElement.h:
  • platform/ThemeTypes.h: (WebCore::):
  • rendering/RenderTextControlSingleLine.cpp: (WebCore::RenderTextControlSingleLine::nodeAtPoint): (WebCore::RenderTextControlSingleLine::forwardEvent): (WebCore::RenderTextControlSingleLine::styleDidChange): (WebCore::RenderTextControlSingleLine::hasControlClip): (WebCore::RenderTextControlSingleLine::controlClipRect): (WebCore::RenderTextControlSingleLine::textBlockWidth): (WebCore::RenderTextControlSingleLine::preferredContentWidth): (WebCore::RenderTextControlSingleLine::adjustControlHeightBasedOnLineHeight): (WebCore::RenderTextControlSingleLine::createSubtreeIfNeeded): (WebCore::RenderTextControlSingleLine::createSpeechButtonStyle): (WebCore::RenderTextControlSingleLine::clientPaddingRight):
  • rendering/RenderTextControlSingleLine.h:
  • rendering/RenderTheme.cpp: (WebCore::RenderTheme::adjustStyle): (WebCore::RenderTheme::paint): (WebCore::RenderTheme::paintBorderOnly): (WebCore::RenderTheme::paintDecorations):
  • rendering/TextControlInnerElements.cpp: (WebCore::InputFieldSpeechButtonElement::InputFieldSpeechButtonElement): (WebCore::InputFieldSpeechButtonElement::create): (WebCore::InputFieldSpeechButtonElement::defaultEventHandler):
  • rendering/TextControlInnerElements.h:
  • rendering/style/RenderStyleConstants.h: (WebCore::):
3:07 AM Changeset in webkit [61751] by tkent@chromium.org
  • 5 edits
    4 adds in trunk

[Mac] The upper button of <input type=number> has no visual effect on click
​https://bugs.webkit.org/show_bug.cgi?id=38380

Reviewed by Adam Barth.

WebCore:

Because we have no ways to draw an NSStepperCell with its up button
highlighted, use HIThemeDrawButton() instead.

Test: platform/mac/fast/forms/input-appearance-spinbutton-up.html

  • platform/mac/ThemeMac.mm:

(WebCore::controlSizeFromPixelSize):

New function. Made from a part of setControlSize().

(WebCore::setControlSize):
(WebCore::convertControlStatesToThemeDrawState):
(WebCore::paintStepper): Use HITheme API instead of NSStepperCell.
(WebCore::ThemeMac::inflateControlPaintRect):

Use controlSizeFromPixelSize().

LayoutTests:

  • platform/mac/fast/forms/input-appearance-spinbutton-expected.checksum:
  • platform/mac/fast/forms/input-appearance-spinbutton-expected.png:
  • platform/mac/fast/forms/input-appearance-spinbutton-up-expected.checksum: Added.
  • platform/mac/fast/forms/input-appearance-spinbutton-up-expected.png: Added.
  • platform/mac/fast/forms/input-appearance-spinbutton-up-expected.txt: Added.
  • platform/mac/fast/forms/input-appearance-spinbutton-up.html: Added.
2:11 AM Changeset in webkit [61750] by oliver@apple.com
  • 5 edits in trunk

Single character string replacement may replace too many characters
​https://bugs.webkit.org/show_bug.cgi?id=41138
<rdar://problem/8097496>

Reviewed by Maciej Stachowiak.

Simple fix to stop the rope path of single character replacement
once the first replacement occurs.

  • runtime/JSString.cpp:

(JSC::JSString::replaceCharacter):

2:01 AM Changeset in webkit [61749] by yurys@chromium.org
  • 8 edits
    2 adds in trunk

2010-06-24 Yury Semikhatsky <​yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: implement layout tests for debugger
​https://bugs.webkit.org/show_bug.cgi?id=40774

  • http/tests/inspector/inspector-test.js: (notifyDone): (frontend_showPanel): (frontend_addSniffer.receiver.methodName): (frontend_addSniffer): (frontend_createKeyEvent): (frontend_evaluateInConsole):
  • inspector/debugger-pause-on-debugger-statement-expected.txt: Added.
  • inspector/debugger-pause-on-debugger-statement.html: Added.

2010-06-24 Yury Semikhatsky <​yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: implement layout tests for debugger
​https://bugs.webkit.org/show_bug.cgi?id=40774

Test: inspector/debugger-pause-on-debugger-statement.html

  • bindings/js/ScriptDebugServer.cpp: remove unused obsolete code that deals with global listeners. (WebCore::ScriptDebugServer::ScriptDebugServer): (WebCore::ScriptDebugServer::removeListener): (WebCore::ScriptDebugServer::dispatchFunctionToListeners): (WebCore::ScriptDebugServer::pauseIfNeeded): (WebCore::ScriptDebugServer::didAddListener): (WebCore::ScriptDebugServer::didRemoveListener):
  • bindings/js/ScriptDebugServer.h:
  • platform/mac/EventLoopMac.mm: (WebCore::EventLoop::cycle): wait at most 10ms for new event, otherwise layout tests would hang because in their case there may be no events ever.

2010-06-24 Yury Semikhatsky <​yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: implement layout tests for debugger
​https://bugs.webkit.org/show_bug.cgi?id=40774

  • src/WebDevToolsFrontendImpl.cpp: (WebKit::WebDevToolsFrontendImpl::WebDevToolsFrontendImpl):
1:57 AM Changeset in webkit [61748] by yurys@chromium.org
  • 6 edits
    3 adds in trunk

2010-06-24 Andrey Kosyakov <​caseq@chromium.org>

Reviewed by Yury Semikhatsky.

Added tests for representation of various JS values in console log.
​https://bugs.webkit.org/show_bug.cgi?id=40980

  • inspector/console-log-native-funcs-expected.txt: Added.
  • inspector/console-tests-expected.txt:
  • inspector/console-tests.html:
  • platform/chromium/inspector: Added.
  • platform/chromium/inspector/console-log-native-funcs-expected.txt: Added.

2010-06-24 Andrey Kosyakov <​caseq@chromium.org>

Reviewed by Yury Semikhatsky.

Fixed evaluation & logging of null values in console.
Changed handling of null and undefined in ScriptValue::toString()
to match JSC bindings (i.e. "null" and "undefined" instead of "").
​https://bugs.webkit.org/show_bug.cgi?id=40980

  • bindings/v8/ScriptValue.cpp: (WebCore::ScriptValue::toString):
  • inspector/front-end/InjectedScript.js: (injectedScriptConstructor):
1:52 AM Changeset in webkit [61747] by yurys@chromium.org
  • 2 edits in trunk/WebCore

2010-06-24 Yury Semikhatsky <​yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: live edit doesn't work when resource tracking is off
​https://bugs.webkit.org/show_bug.cgi?id=41076

  • inspector/front-end/ScriptView.js: (WebInspector.ScriptView.prototype._sourceIDForLine): implement this method for ScriptView, it's needed for editLine to work.
12:51 AM Changeset in webkit [61746] by mjs@apple.com
  • 3 edits in trunk/LayoutTests

Update test results for IDL hidden attribute
(added for ​https://bugs.webkit.org/show_bug.cgi?id=41039)

Reviewed by Oliver.

  • fast/dom/domListEnumeration.html: Update some counts since the HTMLFormElement

and HTMLSelectElement interfaces now inherit the new hidden IDL attribute.

  • fast/dom/domListEnumeration-expected.txt:
12:48 AM Changeset in webkit [61745] by loki@webkit.org
  • 2 edits in trunk/JavaScriptCore

Fix the length of instruction stream controlled by constant pool
​https://bugs.webkit.org/show_bug.cgi?id=40293

Reviewed by Gavin Barraclough.

The initial/maximum length of instruction stream (m_maxDistance) should
be set when the first constant arrives to the constant pool. Otherwise
the constant pool could be placed into an uninterrupted sequence.

  • assembler/AssemblerBufferWithConstantPool.h:

(JSC::):

12:31 AM Changeset in webkit [61744] by aestes@apple.com
  • 1 edit
    10 adds in trunk/LayoutTests

Add additional tests for beforeload events.
​https://bugs.webkit.org/show_bug.cgi?id=41132

Reviewed by Alexey Proskuryakov.

Add tests to verify that the following elements can be removed from the
DOM during beforeload:

  • <object type="application/x-shockwave-flash">
  • <iframe>
  • <img>
  • <script src=""> (non-inline)
  • <video>
  • fast/dom/beforeload/remove-flash-in-beforeload-listener-expected.txt: Added.
  • fast/dom/beforeload/remove-flash-in-beforeload-listener.html: Added.
  • fast/dom/beforeload/remove-frame-in-beforeload-listener-expected.txt: Added.
  • fast/dom/beforeload/remove-frame-in-beforeload-listener.html: Added.
  • fast/dom/beforeload/remove-image-in-beforeload-listener-expected.txt: Added.
  • fast/dom/beforeload/remove-image-in-beforeload-listener.html: Added.
  • fast/dom/beforeload/remove-script-in-beforeload-listener-expected.txt: Added.
  • fast/dom/beforeload/remove-script-in-beforeload-listener.html: Added.
  • fast/dom/beforeload/remove-video-in-beforeload-listener-expected.txt: Added.
  • fast/dom/beforeload/remove-video-in-beforeload-listener.html: Added.
12:24 AM Changeset in webkit [61743] by oliver@apple.com
  • 2 edits in trunk/JavaScriptCore

Fix layout test failure

Reviewed by Gavin Barraclough.

We assume bytecodeOffset will always return a value > 1,
so we adjust the failure case to return 1 instead of 0.

  • bytecode/CodeBlock.h:

(JSC::CodeBlock::bytecodeOffset):

Jun 23, 2010:

11:52 PM Changeset in webkit [61742] by abarth@webkit.org
  • 3 edits in trunk/WebCore

2010-06-23 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Sketch out InitialMode of HTML5 tree builder
​https://bugs.webkit.org/show_bug.cgi?id=41126

Transliterated from the spec. Currently doesn't do anything. Mostly
an experiment to see where this goes.

  • html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processToken): (WebCore::HTMLTreeBuilder::insertDoctype): (WebCore::HTMLTreeBuilder::insertComment):
  • html/HTMLTreeBuilder.h:
11:50 PM Changeset in webkit [61741] by aestes@apple.com
  • 11 edits in trunk/LayoutTests

Refactor beforeload layout tests to share a common implementation of
print() located in fast/dom/beforeload/resources/.
​https://bugs.webkit.org/show_bug.cgi?id=41127

Reviewed by Joseph Pecoraro.

  • fast/dom/beforeload/flash-before-load.html:
  • fast/dom/beforeload/frame-before-load.html:
  • fast/dom/beforeload/image-before-load.html:
  • fast/dom/beforeload/link-before-load.html:
  • fast/dom/beforeload/pi-before-load.xhtml:
  • fast/dom/beforeload/remove-link-in-beforeload-listener.html:
  • fast/dom/beforeload/script-before-load-dynamic.html:
  • fast/dom/beforeload/script-before-load-xhtml.xhtml:
  • fast/dom/beforeload/script-before-load.html:
  • fast/dom/beforeload/video-before-load.html:
11:41 PM Changeset in webkit [61740] by abarth@webkit.org
  • 3 edits in trunk/WebCore

2010-06-23 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Add all the HTML5 tree builder insertion modes
​https://bugs.webkit.org/show_bug.cgi?id=41124

These are just copied verbatim from the spec. No tests because these
don't do anything yet.

  • html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::HTMLTreeBuilder): (WebCore::HTMLTreeBuilder::passTokenToLegacyParser):
  • html/HTMLTreeBuilder.h: (WebCore::HTMLTreeBuilder::):
11:30 PM Changeset in webkit [61739] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-06-23 Eric Seidel <​eric@webkit.org>

Unreviewed. Fix namespace indent. Just whitespace changes.

  • dom/DocumentParser.h: (WebCore::DocumentParser::~DocumentParser): (WebCore::DocumentParser::isExecutingScript): (WebCore::DocumentParser::stopParsing): (WebCore::DocumentParser::processingData): (WebCore::DocumentParser::wantsRawData): (WebCore::DocumentParser::writeRawData): (WebCore::DocumentParser::wellFormed): (WebCore::DocumentParser::lineNumber): (WebCore::DocumentParser::columnNumber): (WebCore::DocumentParser::executeScriptsWaitingForStylesheets): (WebCore::DocumentParser::htmlTreeBuilder): (WebCore::DocumentParser::asHTMLDocumentParser): (WebCore::DocumentParser::inViewSourceMode): (WebCore::DocumentParser::setInViewSourceMode): (WebCore::DocumentParser::document): (WebCore::DocumentParser::xssAuditor): (WebCore::DocumentParser::setXSSAuditor): (WebCore::DocumentParser::DocumentParser):
11:27 PM Changeset in webkit [61738] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-06-23 Eric Seidel <​eric@webkit.org>

Unreviewed. Speculative build fix for Qt.

Move Document* down onto DocumentParser, since every DocumentParser needs one.
​https://bugs.webkit.org/show_bug.cgi?id=41117

XMLDocumentParserQt is a huge pile of donkey barf.
I can't believe I ever r+'d the creation of this pile of
copy/paste code.

I clearly missed removing m_doc from this code as well and thus
broke Qt.

We really need to fix both XMLDocumentParserLibxml2 and
XMLDocumentParserQt not to be so poorly abstracted so
that if we're going to have two of them they can at least
share some code.

  • dom/XMLDocumentParserQt.cpp: (WebCore::XMLDocumentParser::XMLDocumentParser): (WebCore::XMLDocumentParser::~XMLDocumentParser): (WebCore::XMLDocumentParser::doWrite): (WebCore::XMLDocumentParser::doEnd): (WebCore::XMLDocumentParser::parse): (WebCore::XMLDocumentParser::startDocument): (WebCore::XMLDocumentParser::parseStartElement): (WebCore::XMLDocumentParser::parseEndElement): (WebCore::XMLDocumentParser::parseProcessingInstruction): (WebCore::XMLDocumentParser::parseCdata): (WebCore::XMLDocumentParser::parseComment): (WebCore::XMLDocumentParser::parseDtd):
11:17 PM Changeset in webkit [61737] by eric@webkit.org
  • 15 edits in trunk/WebCore

2010-06-23 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Move Document* down onto DocumentParser, since every DocumentParser needs one.
​https://bugs.webkit.org/show_bug.cgi?id=41117

This eliminated the need for document() on HTMLDocumentParser.
This paves the way for more code sharing between various
DocumentParser subclasses.

  • dom/DocumentParser.h: (WebCore::DocumentParser::inViewSourceMode): (WebCore::DocumentParser::setInViewSourceMode): (WebCore::DocumentParser::document): (WebCore::DocumentParser::DocumentParser):
  • dom/XMLDocumentParser.cpp: (WebCore::XMLDocumentParser::isWMLDocument): (WebCore::XMLDocumentParser::pushCurrentNode): (WebCore::XMLDocumentParser::popCurrentNode): (WebCore::XMLDocumentParser::clearCurrentNodeStack): (WebCore::XMLDocumentParser::enterText): (WebCore::XMLDocumentParser::end): (WebCore::XMLDocumentParser::insertErrorMessageBlock):
  • dom/XMLDocumentParser.h:
  • dom/XMLDocumentParserLibxml2.cpp: (WebCore::XMLDocumentParser::XMLDocumentParser): (WebCore::XMLDocumentParser::~XMLDocumentParser): (WebCore::XMLDocumentParser::doWrite): (WebCore::XMLDocumentParser::startElementNs): (WebCore::XMLDocumentParser::endElementNs): (WebCore::XMLDocumentParser::processingInstruction): (WebCore::XMLDocumentParser::cdataBlock): (WebCore::XMLDocumentParser::comment): (WebCore::XMLDocumentParser::startDocument): (WebCore::XMLDocumentParser::internalSubset): (WebCore::XMLDocumentParser::initializeParserContext): (WebCore::XMLDocumentParser::doEnd):
  • html/HTMLDocumentParser.cpp: (WebCore::HTMLDocumentParser::HTMLDocumentParser):
  • html/HTMLDocumentParser.h:
  • html/LegacyHTMLDocumentParser.cpp: (WebCore::LegacyHTMLDocumentParser::LegacyHTMLDocumentParser): (WebCore::LegacyHTMLDocumentParser::begin): (WebCore::LegacyHTMLDocumentParser::scriptHandler): (WebCore::LegacyHTMLDocumentParser::scriptExecution): (WebCore::LegacyHTMLDocumentParser::parseTag): (WebCore::LegacyHTMLDocumentParser::continueProcessing): (WebCore::LegacyHTMLDocumentParser::willWriteHTML): (WebCore::LegacyHTMLDocumentParser::didWriteHTML): (WebCore::LegacyHTMLDocumentParser::write): (WebCore::LegacyHTMLDocumentParser::stopParsing): (WebCore::LegacyHTMLDocumentParser::timerFired): (WebCore::LegacyHTMLDocumentParser::end): (WebCore::LegacyHTMLDocumentParser::processToken): (WebCore::LegacyHTMLDocumentParser::processDoctypeToken): (WebCore::LegacyHTMLDocumentParser::executeScriptsWaitingForStylesheets): (WebCore::LegacyHTMLDocumentParser::executeExternalScriptsIfReady): (WebCore::LegacyHTMLDocumentParser::executeExternalScriptsTimerFired):
  • html/LegacyHTMLDocumentParser.h:
  • loader/ImageDocument.cpp: (WebCore::ImageDocumentParser::ImageDocumentParser): (WebCore::ImageDocumentParser::imageDocument): (WebCore::ImageDocumentParser::write): (WebCore::ImageDocumentParser::writeRawData): (WebCore::ImageDocumentParser::finish): (WebCore::ImageDocumentParser::finishWasCalled): (WebCore::ImageDocumentParser::isWaitingForScripts): (WebCore::ImageDocument::createParser):
  • loader/MediaDocument.cpp: (WebCore::MediaDocumentParser::MediaDocumentParser): (WebCore::MediaDocumentParser::createDocumentStructure): (WebCore::MediaDocumentParser::finish): (WebCore::MediaDocumentParser::finishWasCalled):
  • loader/PluginDocument.cpp: (WebCore::PluginDocumentParser::PluginDocumentParser): (WebCore::PluginDocumentParser::createDocumentStructure): (WebCore::PluginDocumentParser::writeRawData): (WebCore::PluginDocumentParser::finish): (WebCore::PluginDocumentParser::finishWasCalled):
  • loader/SinkDocument.cpp: (WebCore::SinkDocumentParser::SinkDocumentParser):
  • loader/TextDocument.cpp: (WebCore::TextDocumentParser::TextDocumentParser): (WebCore::TextDocumentParser::write): (WebCore::TextDocumentParser::finish): (WebCore::TextDocumentParser::finishWasCalled):
11:14 PM Changeset in webkit [61736] by eric@webkit.org
  • 7 edits in trunk/WebCore

2010-06-23 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Start to clean up DocumentParser interface
​https://bugs.webkit.org/show_bug.cgi?id=41114

The first of many cleanups needed to the DocumentParser
interface. Rename executingScript() to isExecutingScript()
and make it return a bool instead of an int. Also added a
FIXME to XMLDocumentParser about implementing it and did
some minor other cleanup to the XMLDocumentParser header.

No functional change, thus no tests.

  • dom/Document.cpp: (WebCore::Document::open):
  • dom/DocumentParser.h: (WebCore::DocumentParser::isExecutingScript):
  • dom/XMLDocumentParser.h: (WebCore::XMLDocumentParser::wellFormed):
  • html/HTMLDocumentParser.cpp: (WebCore::HTMLDocumentParser::attemptToEnd): (WebCore::HTMLDocumentParser::endIfDelayed): (WebCore::HTMLDocumentParser::isExecutingScript):
  • html/HTMLDocumentParser.h:
  • html/LegacyHTMLDocumentParser.h: (WebCore::LegacyHTMLDocumentParser::isExecutingScript):
10:50 PM Changeset in webkit [61735] by oliver@apple.com
  • 2 edits in trunk/LayoutTests

Fix testcase.

Reviewed by Maciej Stachowiak.

Make the reparsing test use syntax that is actually valid.
The old parser had a bug that would lead to it accepting
invalid code in some cases.

  • fast/js/script-tests/reparsing-semicolon-insertion.js:

(commaTest):
(varCommaTest):
(constCommaTest):
(commaParenTest):
(commaParenThrowTest):

10:43 PM Changeset in webkit [61734] by mjs@apple.com
  • 3 edits
    3 adds in trunk

2010-06-22 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Simon Fraser.

Implement IDL attribute for HTML5 hidden
​https://bugs.webkit.org/show_bug.cgi?id=41039

Test: fast/html/hidden-attr-dom.html

  • html/HTMLElement.idl: Just add to the IDL file. [Reflect] takes care of the rest.

2010-06-22 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Simon Fraser.

Implement IDL attribute for HTML5 hidden
​https://bugs.webkit.org/show_bug.cgi?id=41039

Test cases.


  • fast/html/hidden-attr-dom.html: Added.
  • fast/html/hidden-attr-dom-expected.txt: Added.
  • fast/html/script-tests/hidden-attr-dom.js: Added.
9:22 PM Changeset in webkit [61733] by commit-queue@webkit.org
  • 3 edits in trunk/WebKit

2010-06-23 Leandro Pereira <​leandro@profusion.mobi>

Reviewed by Gustavo Noronha Silva.

[EFL] Add Libs.private to ewebkit.pc when building with SHARED_CORE.
​https://bugs.webkit.org/show_bug.cgi?id=40862

  • CMakeListsEfl.txt:
  • efl/ewebkit.pc.in:
9:19 PM Changeset in webkit [61732] by oliver@apple.com
  • 13 edits
    4 adds in trunk/JavaScriptCore

2010-06-23 Oliver Hunt <​oliver@apple.com>

Reviewed by Gavin Barraclough.

Custom-written JavaScript parser
​https://bugs.webkit.org/show_bug.cgi?id=34019

Implement a recursive descent parser similar to that used by V8 and
SpiderMonkey. Greater than 2x improvement in SunSpider parsing tests.

The parser consists of a JSParser class that uses a TreeBuilder to actually
build the AST. There are currently two builders -- the ASTBuilder and
SyntaxChecker which separate the job of building an AST for code generation
and simply checking syntactic correctness.

There's still some less than ideal code remaining in the parser to allow
us to retain the existing lexing code with minimal changes. We'll tidy
this up at a later date.

  • GNUmakefile.am:
  • JavaScriptCore.gypi:
  • JavaScriptCore.pro:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • parser/ASTBuilder.h: Added. (JSC::ASTBuilder::BinaryOpInfo::BinaryOpInfo): (JSC::ASTBuilder::AssignmentInfo::AssignmentInfo): (JSC::ASTBuilder::ASTBuilder): (JSC::ASTBuilder::createSourceElements): (JSC::ASTBuilder::varDeclarations): (JSC::ASTBuilder::funcDeclarations): (JSC::ASTBuilder::features): (JSC::ASTBuilder::numConstants): (JSC::ASTBuilder::appendToComma): (JSC::ASTBuilder::createCommaExpr): (JSC::ASTBuilder::createLogicalNot): (JSC::ASTBuilder::createUnaryPlus): (JSC::ASTBuilder::createVoid): (JSC::ASTBuilder::thisExpr): (JSC::ASTBuilder::createResolve): (JSC::ASTBuilder::createObjectLiteral): (JSC::ASTBuilder::createArray): (JSC::ASTBuilder::createNumberExpr): (JSC::ASTBuilder::createString): (JSC::ASTBuilder::createBoolean): (JSC::ASTBuilder::createNull): (JSC::ASTBuilder::createBracketAccess): (JSC::ASTBuilder::createDotAccess): (JSC::ASTBuilder::createRegex): (JSC::ASTBuilder::createNewExpr): (JSC::ASTBuilder::createConditionalExpr): (JSC::ASTBuilder::createAssignResolve): (JSC::ASTBuilder::createFunctionExpr): (JSC::ASTBuilder::createFunctionBody): (JSC::ASTBuilder::createGetterOrSetterProperty): (JSC::ASTBuilder::createArguments): (JSC::ASTBuilder::createArgumentsList): (JSC::ASTBuilder::createProperty): (JSC::ASTBuilder::createPropertyList): (JSC::ASTBuilder::createElementList): (JSC::ASTBuilder::createFormalParameterList): (JSC::ASTBuilder::createClause): (JSC::ASTBuilder::createClauseList): (JSC::ASTBuilder::setUsesArguments): (JSC::ASTBuilder::createFuncDeclStatement): (JSC::ASTBuilder::createBlockStatement): (JSC::ASTBuilder::createExprStatement): (JSC::ASTBuilder::createIfStatement): (JSC::ASTBuilder::createForLoop): (JSC::ASTBuilder::createForInLoop): (JSC::ASTBuilder::createEmptyStatement): (JSC::ASTBuilder::createVarStatement): (JSC::ASTBuilder::createReturnStatement): (JSC::ASTBuilder::createBreakStatement): (JSC::ASTBuilder::createContinueStatement): (JSC::ASTBuilder::createTryStatement): (JSC::ASTBuilder::createSwitchStatement): (JSC::ASTBuilder::createWhileStatement): (JSC::ASTBuilder::createDoWhileStatement): (JSC::ASTBuilder::createLabelStatement): (JSC::ASTBuilder::createWithStatement): (JSC::ASTBuilder::createThrowStatement): (JSC::ASTBuilder::createDebugger): (JSC::ASTBuilder::createConstStatement): (JSC::ASTBuilder::appendConstDecl): (JSC::ASTBuilder::appendStatement): (JSC::ASTBuilder::addVar): (JSC::ASTBuilder::combineCommaNodes): (JSC::ASTBuilder::evalCount): (JSC::ASTBuilder::appendBinaryExpressionInfo): (JSC::ASTBuilder::operatorStackPop): (JSC::ASTBuilder::operatorStackHasHigherPrecedence): (JSC::ASTBuilder::getFromOperandStack): (JSC::ASTBuilder::shrinkOperandStackBy): (JSC::ASTBuilder::appendBinaryOperation): (JSC::ASTBuilder::operatorStackAppend): (JSC::ASTBuilder::popOperandStack): (JSC::ASTBuilder::appendUnaryToken): (JSC::ASTBuilder::unaryTokenStackLastType): (JSC::ASTBuilder::unaryTokenStackLastStart): (JSC::ASTBuilder::unaryTokenStackRemoveLast): (JSC::ASTBuilder::assignmentStackAppend): (JSC::ASTBuilder::createAssignment): (JSC::ASTBuilder::Scope::Scope): (JSC::ASTBuilder::setExceptionLocation): (JSC::ASTBuilder::incConstants): (JSC::ASTBuilder::usesThis): (JSC::ASTBuilder::usesCatch): (JSC::ASTBuilder::usesClosures): (JSC::ASTBuilder::usesArguments): (JSC::ASTBuilder::usesAssignment): (JSC::ASTBuilder::usesWith): (JSC::ASTBuilder::usesEval): (JSC::ASTBuilder::createNumber): (JSC::ASTBuilder::makeTypeOfNode): (JSC::ASTBuilder::makeDeleteNode): (JSC::ASTBuilder::makeNegateNode): (JSC::ASTBuilder::makeBitwiseNotNode): (JSC::ASTBuilder::makeMultNode): (JSC::ASTBuilder::makeDivNode): (JSC::ASTBuilder::makeAddNode): (JSC::ASTBuilder::makeSubNode): (JSC::ASTBuilder::makeLeftShiftNode): (JSC::ASTBuilder::makeRightShiftNode): (JSC::ASTBuilder::makeFunctionCallNode): (JSC::ASTBuilder::makeBinaryNode): (JSC::ASTBuilder::makeAssignNode): (JSC::ASTBuilder::makePrefixNode): (JSC::ASTBuilder::makePostfixNode):
  • parser/JSParser.cpp: Added. (JSC::JSParser::AllowInOverride::AllowInOverride): (JSC::JSParser::AllowInOverride::~AllowInOverride): (JSC::JSParser::token): (JSC::JSParser::next): (JSC::JSParser::consume): (JSC::JSParser::match): (JSC::JSParser::tokenStart): (JSC::JSParser::tokenLine): (JSC::JSParser::tokenEnd): (JSC::JSParser::): (JSC::JSParser::autoSemiColon): (JSC::JSParser::canRecurse): (JSC::JSParser::lastTokenEnd): (JSC::jsParse): (JSC::JSParser::JSParser): (JSC::JSParser::parseProgram): (JSC::JSParser::allowAutomaticSemicolon): (JSC::JSParser::parseSourceElements): (JSC::JSParser::parseVarDeclaration): (JSC::JSParser::parseConstDeclaration): (JSC::JSParser::parseDoWhileStatement): (JSC::JSParser::parseWhileStatement): (JSC::JSParser::parseVarDeclarationList): (JSC::JSParser::parseConstDeclarationList): (JSC::JSParser::parseForStatement): (JSC::JSParser::parseBreakStatement): (JSC::JSParser::parseContinueStatement): (JSC::JSParser::parseReturnStatement): (JSC::JSParser::parseThrowStatement): (JSC::JSParser::parseWithStatement): (JSC::JSParser::parseSwitchStatement): (JSC::JSParser::parseSwitchClauses): (JSC::JSParser::parseSwitchDefaultClause): (JSC::JSParser::parseTryStatement): (JSC::JSParser::parseDebuggerStatement): (JSC::JSParser::parseBlockStatement): (JSC::JSParser::parseStatement): (JSC::JSParser::parseFormalParameters): (JSC::JSParser::parseFunctionBody): (JSC::JSParser::parseFunctionInfo): (JSC::JSParser::parseFunctionDeclaration): (JSC::JSParser::parseExpressionOrLabelStatement): (JSC::JSParser::parseExpressionStatement): (JSC::JSParser::parseIfStatement): (JSC::JSParser::parseExpression): (JSC::JSParser::parseAssignmentExpression): (JSC::JSParser::parseConditionalExpression): (JSC::isUnaryOp): (JSC::JSParser::isBinaryOperator): (JSC::JSParser::parseBinaryExpression): (JSC::JSParser::parseProperty): (JSC::JSParser::parseObjectLiteral): (JSC::JSParser::parseArrayLiteral): (JSC::JSParser::parsePrimaryExpression): (JSC::JSParser::parseArguments): (JSC::JSParser::parseMemberExpression): (JSC::JSParser::parseUnaryExpression):
  • parser/JSParser.h: Added. (JSC::): (JSC::JSTokenInfo::JSTokenInfo):
  • parser/Lexer.cpp: (JSC::Lexer::lex):
  • parser/Lexer.h: (JSC::Lexer::setLastLineNumber): (JSC::Lexer::lastLineNumber):
  • parser/NodeConstructors.h: (JSC::Node::Node):
  • parser/Parser.cpp: (JSC::Parser::parse):
  • parser/SyntaxChecker.h: Added. (JSC::SyntaxChecker::SyntaxChecker): (JSC::SyntaxChecker::createSourceElements): (JSC::SyntaxChecker::makeFunctionCallNode): (JSC::SyntaxChecker::appendToComma): (JSC::SyntaxChecker::createCommaExpr): (JSC::SyntaxChecker::makeAssignNode): (JSC::SyntaxChecker::makePrefixNode): (JSC::SyntaxChecker::makePostfixNode): (JSC::SyntaxChecker::makeTypeOfNode): (JSC::SyntaxChecker::makeDeleteNode): (JSC::SyntaxChecker::makeNegateNode): (JSC::SyntaxChecker::makeBitwiseNotNode): (JSC::SyntaxChecker::createLogicalNot): (JSC::SyntaxChecker::createUnaryPlus): (JSC::SyntaxChecker::createVoid): (JSC::SyntaxChecker::thisExpr): (JSC::SyntaxChecker::createResolve): (JSC::SyntaxChecker::createObjectLiteral): (JSC::SyntaxChecker::createArray): (JSC::SyntaxChecker::createNumberExpr): (JSC::SyntaxChecker::createString): (JSC::SyntaxChecker::createBoolean): (JSC::SyntaxChecker::createNull): (JSC::SyntaxChecker::createBracketAccess): (JSC::SyntaxChecker::createDotAccess): (JSC::SyntaxChecker::createRegex): (JSC::SyntaxChecker::createNewExpr): (JSC::SyntaxChecker::createConditionalExpr): (JSC::SyntaxChecker::createAssignResolve): (JSC::SyntaxChecker::createFunctionExpr): (JSC::SyntaxChecker::createFunctionBody): (JSC::SyntaxChecker::createArguments): (JSC::SyntaxChecker::createArgumentsList): (JSC::SyntaxChecker::createProperty): (JSC::SyntaxChecker::createPropertyList): (JSC::SyntaxChecker::createElementList): (JSC::SyntaxChecker::createFormalParameterList): (JSC::SyntaxChecker::createClause): (JSC::SyntaxChecker::createClauseList): (JSC::SyntaxChecker::setUsesArguments): (JSC::SyntaxChecker::createFuncDeclStatement): (JSC::SyntaxChecker::createBlockStatement): (JSC::SyntaxChecker::createExprStatement): (JSC::SyntaxChecker::createIfStatement): (JSC::SyntaxChecker::createForLoop): (JSC::SyntaxChecker::createForInLoop): (JSC::SyntaxChecker::createEmptyStatement): (JSC::SyntaxChecker::createVarStatement): (JSC::SyntaxChecker::createReturnStatement): (JSC::SyntaxChecker::createBreakStatement): (JSC::SyntaxChecker::createContinueStatement): (JSC::SyntaxChecker::createTryStatement): (JSC::SyntaxChecker::createSwitchStatement): (JSC::SyntaxChecker::createWhileStatement): (JSC::SyntaxChecker::createWithStatement): (JSC::SyntaxChecker::createDoWhileStatement): (JSC::SyntaxChecker::createLabelStatement): (JSC::SyntaxChecker::createThrowStatement): (JSC::SyntaxChecker::createDebugger): (JSC::SyntaxChecker::createConstStatement): (JSC::SyntaxChecker::appendConstDecl): (JSC::SyntaxChecker::createGetterOrSetterProperty): (JSC::SyntaxChecker::appendStatement): (JSC::SyntaxChecker::addVar): (JSC::SyntaxChecker::combineCommaNodes): (JSC::SyntaxChecker::evalCount): (JSC::SyntaxChecker::appendBinaryExpressionInfo): (JSC::SyntaxChecker::operatorStackPop):
  • runtime/JSGlobalData.h:
  • wtf/Platform.h:
  • wtf/ThreadSpecific.h: (WTF::T):
8:25 PM Changeset in webkit [61731] by tony@chromium.org
  • 3 edits in trunk/LayoutTests

2010-06-23 Tony Chang <​tony@chromium.org>

Not reviewed, fixing gtk/qt tests

skip http/tests/multipart/policy-ignore-crash.php on qt and gtk
​https://bugs.webkit.org/show_bug.cgi?id=41128

Their network libraries appear to be more strict about identifying
multipart boundaries.

  • platform/gtk/Skipped:
  • platform/qt/Skipped:
8:18 PM Changeset in webkit [61730] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

2010-06-23 Mario Sanchez Prada <​msanchez@igalia.com>

Reviewed by Chris Fleizach.

[Gtk] nameFromChildren is obsolete
​https://bugs.webkit.org/show_bug.cgi?id=36128

Added new tests, based on a previous patch by Joanmarie Diggs.

  • platform/gtk/accessibility/name-from-label-expected.txt: Added.
  • platform/gtk/accessibility/name-from-label.html: Added.

2010-06-23 Joanmarie Diggs <​joanmarie.diggs@gmail.com>

Reviewed by Chris Fleizach.

[Gtk] nameFromChildren is obsolete
​https://bugs.webkit.org/show_bug.cgi?id=36128

Look to the AtkText interface implemented by the objects in
question.

Test: platform/gtk/accessibility/name-from-label.html

  • accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (webkit_accessible_get_name): (webkit_accessible_table_get_column_description): (webkit_accessible_table_get_row_description):
7:55 PM Changeset in webkit [61729] by commit-queue@webkit.org
  • 2 edits
    1 add in trunk/WebCore

2010-06-23 Kwang Yul Seo <​skyul@company100.net>

Reviewed by Kent Tamura.

[BREWMP] Port FileSystem
​https://bugs.webkit.org/show_bug.cgi?id=34323

Port FileSystem with IFileMgr interface.

  • platform/FileSystem.h:
  • platform/brew/FileSystemBrew.cpp: Added. (WebCore::getFileSize): (WebCore::getFileModificationTime): (WebCore::fileExists): (WebCore::deleteFile): (WebCore::deleteEmptyDirectory): (WebCore::pathByAppendingComponent): (WebCore::fileSystemRepresentation): (WebCore::canonicalPath): (WebCore::makeAllDirectories): (WebCore::homeDirectoryPath): (WebCore::pathGetFileName): (WebCore::directoryName): (WebCore::openTemporaryFile): (WebCore::closeFile): (WebCore::writeToFile): (WebCore::unloadModule): (WebCore::listDirectory):
7:54 PM Changeset in webkit [61728] by tony@chromium.org
  • 4 edits
    2 adds in trunk

2010-06-23 Tony Chang <​tony@chromium.org>

Reviewed by Darin Fisher.

layout test for a crash in chromium multipart request handling
​https://bugs.webkit.org/show_bug.cgi?id=41050

  • http/tests/multipart/policy-ignore-crash-expected.txt: Copied from LayoutTests/editing/pasteboard/copy-crash-with-extraneous-attribute-expected.txt.
  • http/tests/multipart/policy-ignore-crash.php: Added.
  • platform/mac/Skipped:

2010-06-23 Tony Chang <​tony@chromium.org>

Reviewed by Darin Fisher.

layout test for a crash in chromium multipart request handling
​https://bugs.webkit.org/show_bug.cgi?id=41050

Also roll DEPS to pick up the crash fix.

  • DEPS:
7:21 PM Changeset in webkit [61727] by Laszlo Gombos
  • 2 edits in trunk/WebKit/qt

2010-06-23 Laszlo Gombos <Laszlo Gombos>

Unreviewed, Symbian build fix.

[Qt] Update the def file after r61478.

  • symbian/eabi/QtWebKitu.def:
6:49 PM Changeset in webkit [61726] by commit-queue@webkit.org
  • 3 edits in trunk/JavaScriptCore

2010-06-23 Jedrzej Nowacki <​jedrzej.nowacki@nokia.com>

Reviewed by Simon Hausmann.

Optimization of the QScriptValuePrivate.

Patch change only internals of the QScriptValuePrivate.
Most of the QScriptValuePrivate's attributes were moved
into an union.

[Qt] Optimization of the QScriptVAluePrivate.
​https://bugs.webkit.org/show_bug.cgi?id=40415

  • qt/api/qscriptengine_p.cpp: (QScriptEnginePrivate::globalObject):
  • qt/api/qscriptvalue_p.h: (QScriptValuePrivate::): (QScriptValuePrivate::~QScriptValuePrivate): (QScriptValuePrivate::QScriptValuePrivate): (QScriptValuePrivate::toString): (QScriptValuePrivate::toNumber): (QScriptValuePrivate::toBool): (QScriptValuePrivate::toObject): (QScriptValuePrivate::equals): (QScriptValuePrivate::strictlyEquals): (QScriptValuePrivate::assignEngine): (QScriptValuePrivate::operator JSValueRef): (QScriptValuePrivate::operator JSObjectRef): (QScriptValuePrivate::refinedJSValue):
6:39 PM Changeset in webkit [61725] by andersca@apple.com
  • 8 edits in trunk/WebKit2

2010-06-23 Anders Carlsson <​andersca@apple.com>

Reviewed by Sam Weinig.

Have the UI process compute the plug-in data
​https://bugs.webkit.org/show_bug.cgi?id=41118

  • Shared/CoreIPCSupport/WebProcessProxyMessageKinds.h: (WebProcessProxyMessage::): Add GetPlugin message kind.
  • Shared/WebCoreArgumentCoders.h: Add argument coders for PluginInfo and MimeClassInfo.


  • UIProcess/Plugins/mac/PluginInfoStoreMac.mm: (WebKit::safeCreateCFString): (WebKit::PluginInfoStore::pluginPathsInDirectory): (WebKit::PluginInfoStore::getPluginInfo): Use safeCreateCFString.


  • UIProcess/WebProcessProxy.cpp: (WebKit::WebProcessProxy::getPlugins): Ask the plug-in info store for the plug-in list.

(WebKit::WebProcessProxy::didReceiveSyncMessage):
Handle GetPlugins.

  • UIProcess/WebProcessProxy.h:
  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp: (WebKit::WebFrameLoaderClient::objectContentType): Implement.
  • WebProcess/WebCoreSupport/WebPlatformStrategies.cpp: (WebKit::WebPlatformStrategies::populatePluginCache): Send a sync GetPlugins message.
6:33 PM Changeset in webkit [61724] by commit-queue@webkit.org
  • 3 edits in trunk/WebCore

2010-06-23 Alexendar Pavlov <​apavlov@chromium.org>

Reviewed by David Hyatt.

Swap checks in Position::isCandidate so that the less expensive
nodeIsUserSelectNode (node && node->renderer() &&
node->renderer()->style()->userSelect() == SELECT_NONE) came first.

(Was Web Inspector: Hangup when expanding elements with enormous
text node content in Elements panel).

​https://bugs.webkit.org/show_bug.cgi?id=35926

  • dom/Position.cpp: (WebCore::Position::isCandidate):
  • dom/PositionIterator.cpp: (WebCore::PositionIterator::isCandidate):
6:02 PM Changeset in webkit [61723] by kevino@webkit.org
  • 3 edits in trunk/WebKitTools

[wx] Build fix, adding new LayoutTestController methods and enabling SVG_FOREIGN_OBJECT.

5:33 PM Changeset in webkit [61722] by commit-queue@webkit.org
  • 2 edits
    2 adds in trunk/WebCore

2010-06-23 Kwang Yul Seo <​skyul@company100.net>

Reviewed by Kent Tamura.

[BREWMP] Add PopupMenu implementation
​https://bugs.webkit.org/show_bug.cgi?id=40226

Delegate PopupMenu handling to ChromeClientBrew.

  • page/brew/ChromeClientBrew.h: Added.
  • platform/PopupMenu.h:
  • platform/brew/PopupMenuBrew.cpp: Added. (WebCore::PopupMenu::PopupMenu): (WebCore::PopupMenu::~PopupMenu): (WebCore::PopupMenu::show): (WebCore::PopupMenu::hide): (WebCore::PopupMenu::updateFromElement): (WebCore::PopupMenu::itemWritingDirectionIsNatural):
5:29 PM Changeset in webkit [61721] by aestes@apple.com
  • 2 edits
    1 add in trunk/LayoutTests

<rdar://problem/8107855> Test that removing an object element with an
invalid data URL in a listener to its beforeload event does not crash
WebCore.
​https://bugs.webkit.org/show_bug.cgi?id=41054

Reviewed by Alexey Proskuryakov.

  • fast/dom/beforeload/remove-bad-object-in-beforeload-listener-expected.txt: Added.
  • fast/dom/beforeload/remove-bad-object-in-beforeload-listener.html: Added.
  • fast/dom/beforeload/resources/print.js: Added.

(print):

5:23 PM Changeset in webkit [61720] by andersca@apple.com
  • 2 edits in trunk/WebKit2

Add ArgumentCoder for vectors.

Reviewed by Dan Bernstein.

  • Platform/CoreIPC/ArgumentCoders.h:

(CoreIPC::):

5:18 PM Changeset in webkit [61719] by andersca@apple.com
  • 15 edits
    1 move in trunk/WebKit2

Rename WebCoreTypeArgumentMarshalling.h to WebCoreArgumentCoders.h

Reviewed by Dan Bernstein.

  • Shared/WebCoreArgumentCoders.h: Copied from Shared/WebCoreTypeArgumentMarshalling.h.
  • Shared/WebCoreTypeArgumentMarshalling.h: Removed.
  • Shared/WebEvent.h:
  • Shared/WebNavigationDataStore.h:
  • Shared/WebPreferencesStore.h:
  • Shared/mac/UpdateChunk.cpp:
  • UIProcess/ChunkedUpdateDrawingAreaProxy.cpp:
  • UIProcess/WebContext.cpp:
  • UIProcess/WebPageProxy.cpp:
  • WebKit2.xcodeproj/project.pbxproj:
  • WebProcess/InjectedBundle/InjectedBundle.cpp:
  • WebProcess/WebCoreSupport/WebChromeClient.cpp:
  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
  • WebProcess/WebPage/ChunkedUpdateDrawingArea.cpp:
  • WebProcess/WebPage/WebPage.cpp:
  • WebProcess/WebProcess.cpp:
5:12 PM Changeset in webkit [61718] by andersca@apple.com
  • 4 edits in trunk/WebKit2

2010-06-23 Anders Carlsson <​andersca@apple.com>

Reviewed by Dan Bernstein.

MessageIDs should always have the most significant bit zeroed out
​https://bugs.webkit.org/show_bug.cgi?id=41112

The most significant bit is used by the Mac implementation of CoreIPC, and
should always be zero in MessageID objects.

  • Platform/CoreIPC/Connection.cpp: (CoreIPC::Connection::waitForMessage):
  • Platform/CoreIPC/MessageID.h: (CoreIPC::MessageID::): (CoreIPC::MessageID::MessageID): (CoreIPC::MessageID::operator==): (CoreIPC::MessageID::fromInt): (CoreIPC::MessageID::isSync): (CoreIPC::MessageID::stripMostSignificantBit):
  • Platform/CoreIPC/mac/ConnectionMac.cpp: (CoreIPC::Connection::sendOutgoingMessage): (CoreIPC::createArgumentDecoder):
4:29 PM Changeset in webkit [61717] by sullivan@apple.com
  • 2 edits in trunk/WebKit2
  • mac/WebKit2.exp:

Added yet another symbol needed by Mac clients.

Rubber-stamped by Anders Carlsson.

4:25 PM Changeset in webkit [61716] by sullivan@apple.com
  • 2 edits in trunk/WebKit2
  • mac/WebKit2.exp:

Added another symbol needed by Mac clients.

Rubber-stamped by Anders Carlsson.

4:22 PM Changeset in webkit [61715] by kbr@google.com
  • 8 edits
    3 adds in trunk

2010-06-23 Kenneth Russell <​kbr@google.com>

Reviewed by Dimitri Glazkov.

Implement format conversions in texImage2D and texSubImage2D taking HTML data
​https://bugs.webkit.org/show_bug.cgi?id=40319

Generalized code supporting premultiplication of alpha and
vertical flip to pack texture data into requested format and type.
Handled incoming image data of various formats, RGBA and BGRA in
particular, both to reduce the number of temporary copies during
texture upload and to support premultiplying alpha for the
texImage2D and texSubImage2D entry points taking ArrayBufferView
in a subsequent bug. Added test case exercising all combinations
of format/type combinations, premultiplication of alpha, and
Image/ImageData upload. (Incorporated pnglib.js under
fast/canvas/webgl/resources/ to be able to generate Image elements
programmatically.) Tested in Safari on Mac OS X and in Chromium on
Mac OS X, Windows and Linux.

Test: fast/canvas/webgl/tex-image-with-format-and-type.html

  • html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::readPixels): (WebCore::WebGLRenderingContext::texImage2DImpl): (WebCore::WebGLRenderingContext::texImage2D): (WebCore::WebGLRenderingContext::texSubImage2DImpl): (WebCore::WebGLRenderingContext::texSubImage2D): (WebCore::WebGLRenderingContext::validateTexFuncFormatAndType): (WebCore::WebGLRenderingContext::validateTexFuncParameters):
  • platform/graphics/GraphicsContext3D.cpp: (WebCore::GraphicsContext3D::computeFormatAndTypeParameters): (WebCore::GraphicsContext3D::extractImageData): (WebCore::GraphicsContext3D::flipVertically): (WebCore::doUnpackingAndPacking): (WebCore::doPacking): (WebCore::GraphicsContext3D::packPixels):
  • platform/graphics/GraphicsContext3D.h: (WebCore::GraphicsContext3D::):
  • platform/graphics/cg/GraphicsContext3DCG.cpp: (WebCore::GraphicsContext3D::getImageData):
  • platform/graphics/mac/GraphicsContext3DMac.mm: (WebCore::narrowInternalFormat): (WebCore::GraphicsContext3D::texImage2D):
  • platform/graphics/qt/GraphicsContext3DQt.cpp: (WebCore::GraphicsContext3D::getImageData):
  • platform/graphics/skia/GraphicsContext3DSkia.cpp: (WebCore::GraphicsContext3D::getImageData):

2010-06-23 Kenneth Russell <​kbr@google.com>

Reviewed by Dimitri Glazkov.

Implement format conversions in texImage2D and texSubImage2D taking HTML data
​https://bugs.webkit.org/show_bug.cgi?id=40319

Generalized code supporting premultiplication of alpha and
vertical flip to pack texture data into requested format and type.
Handled incoming image data of various formats, RGBA and BGRA in
particular, both to reduce the number of temporary copies during
texture upload and to support premultiplying alpha for the
texImage2D and texSubImage2D entry points taking ArrayBufferView
in a subsequent bug. Added test case exercising all combinations
of format/type combinations, premultiplication of alpha, and
Image/ImageData upload. (Incorporated pnglib.js under
fast/canvas/webgl/resources/ to be able to generate Image elements
programmatically.) Tested in Safari on Mac OS X and in Chromium on
Mac OS X, Windows and Linux.

Test: fast/canvas/webgl/tex-image-with-format-and-type.html

  • fast/canvas/webgl/resources/pnglib.js: Added. (): (.):
  • fast/canvas/webgl/tex-image-with-format-and-type-expected.txt: Added.
  • fast/canvas/webgl/tex-image-with-format-and-type.html: Added.
4:19 PM Changeset in webkit [61714] by senorblanco@chromium.org
  • 2 edits in trunk/WebCore

2010-06-23 Stephen White <​senorblanco@chromium.org>

Unreviewed; correcting bad patch.

In my haste to land r61710, I mistakenly landed the wrong version, in
which a chunk of code was moved. This patch moves that chunk of code
to where it was in the patch that was reviewed. Mea culpa.

  • rendering/RenderBoxModelObject.cpp: (WebCore::ImageQualityController::shouldPaintAtLowQuality):
4:14 PM Changeset in webkit [61713] by hclam@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed. Build fix.

Adding test expectation since a test introduced r61607 has not test results.

  • platform/chromium/test_expectations.txt:
3:27 PM Changeset in webkit [61712] by commit-queue@webkit.org
  • 2 edits in trunk/JavaScriptCore

2010-06-23 Kwang Yul Seo <​skyul@company100.net>

Reviewed by Oliver Hunt.

[GTK] Implement ThreadSpecific with glib
​https://bugs.webkit.org/show_bug.cgi?id=39829

Implement ThreadSpecific with glib's GStaticPrivate.
This patch makes it possible to build GTK port without pthread.

  • wtf/ThreadSpecific.h: (WTF::::ThreadSpecific): (WTF::::~ThreadSpecific): (WTF::::get): (WTF::::set): (WTF::::destroy):
3:18 PM Changeset in webkit [61711] by jschuh@chromium.org
  • 1 edit in trunk/WebCore/ChangeLog

Unreviewed, fixing ChangeLog entry for ​http://trac.webkit.org/changeset/61709

2:52 PM Changeset in webkit [61710] by senorblanco@chromium.org
  • 4 edits in trunk

2010-06-23 Stephen White <​senorblanco@chromium.org>

Reviewed by David Hyatt.

This is a tweak to the resize algorithm introduced in r61341, and
is a fix for the regression described in
​https://bugs.webkit.org/show_bug.cgi?id=41036

The goal is to bring back the some of old behaviour, without regressing
too much of the performance gains in r61341.

The old algorithm was:

  • on first resize, draw in high quality and record the paint time
  • if we've already drawn at this size, use the same quality as last time
  • on subsequent resizes, if the resize occurs within X ms of the previous one, draw at low quality and set a timer (one timer per image).
  • when each timer expires, draw that image at high quality

The r61341 algorithm was:

  • on first resize, draw the image in low quality, add it to a list of resized images, and set a timer (one timer for all images)
  • when the timer expires, redraw all resized images in high quality

The new algorithm is:

  • on first resize, if no other animated resizes are outstanding, draw in high quality and set the timer (one timer for all images)
  • if any images have been resized to two different sizes in the last X ms, draw all resized images in low quality and kick the timer forward
  • when the timer expires, if any animated resizes occured, redraw all resized images in high quality, and reset the flag

This should cause GUIMark and the IE9 demos to have good performance
after the first frame, while other pages with only static resizes
should be unaffected.

  • rendering/RenderBoxModelObject.cpp: Change the LastPaintTimeMap to a LastPaintSizeMap: we now record the last size an image was resized to, rather than the time it was painted (the time actually became redundant in r61341 when I added the check for m_timer.isActive(): we only care if anything is resizing while the timer is active). (WebCore::ImageQualityController::ImageQualityController): Add an initializer for the m_animatedResizeIsActive flag. (WebCore::ImageQualityController::objectDestroyed): Reset the m_animatedResizeIsActive flag if this was the last object in the list. (WebCore::ImageQualityController::highQualityRepaintTimerFired): Only repaint all the images if there was an animated resize (otherwise, everything is already high quality). (WebCore::ImageQualityController::shouldPaintAtLowQuality): Implement the above algorithm.

2010-06-23 Stephen White <​senorblanco@chromium.org>

Reviewed by David Hyatt.

Temporarily put the tests broken by the resize change into
test_expectations.txt.
​https://bugs.webkit.org/show_bug.cgi?id=41036

  • platform/chromium/test_expectations.txt:
2:34 PM Changeset in webkit [61709] by jschuh@chromium.org
  • 3 edits
    2 adds in trunk

2010-06-23 Abhishek Arya <​inferno@chromium.org>

Reviewed by Kenneth Rohde Christiansen.

Firing the onchange event on select which changes its size > 1 causes the select
object to change from a menulist to a listbox. However, when propogating the events,
we do a bad cast assuming the object will remain a menulist. Added proper checks to
make sure we check the renderer after the onchange is fired and propogate the event
based on correct object type.
​https://bugs.webkit.org/show_bug.cgi?id=40828

Test: fast/events/select-onchange-crash.html

  • dom/SelectElement.cpp: (WebCore::SelectElement::setSelectedIndex):

2010-06-23 Abhishek Arya <​inferno@chromium.org>

Reviewed by Kenneth Rohde Christiansen.

Tests that we do not crash when onchange handler changes the select from a menu list to a list box.
​https://bugs.webkit.org/show_bug.cgi?id=40828

  • fast/events/select-onchange-crash-expected.txt: Added.
  • fast/events/select-onchange-crash.html: Added.
2:25 PM BuildingQtOnSymbian edited by Laszlo Gombos
CONFIG-=def_files should be used for trunk builds (diff)
1:07 PM Changeset in webkit [61708] by leandro@webkit.org
  • 3 edits
    1 add in trunk

2010-06-23 Leandro Pereira <​leandro@profusion.mobi>

Reviewed by Kenneth Rohde Christiansen.

[EFL] Add support to CPack (to generate source tarballs)
​https://bugs.webkit.org/show_bug.cgi?id=41009


  • CMakeLists.txt:
  • cmake/OptionsEfl.cmake: Define the default source generator for the EFL port.
  • cmake/WebKitPackaging.cmake: Added. This file filters the source files so that only files relevant to the selected port are included in the source tarball. See comments for details.
1:03 PM Changeset in webkit [61707] by aestes@apple.com
  • 3 edits
    2 adds in trunk

<rdar://problem/8107855> Prevent a crash in WebCore when removing an
object element with an invalid data URL in in a listener to its
beforeload event.
​https://bugs.webkit.org/show_bug.cgi?id=41054

Reviewed by Alexey Proskuryakov.

Tests: fast/dom/beforeload/remove-bad-object-in-beforeload-listener.html

  • html/HTMLObjectElement.cpp:

(WebCore::HTMLObjectElement::renderFallbackContent): Exit early if the
object element is not in the document.

  • rendering/RenderEmbeddedObject.cpp:

(WebCore::RenderEmbeddedObject::updateWidget): If RenderWidget::destroy()
was called during processing of onbeforeload, do not proceed with loading
the object.

12:39 PM Changeset in webkit [61706] by leandro@webkit.org
  • 8 edits
    2 adds in trunk/WebKit

2010-06-23 Lucas De Marchi <​lucas.demarchi@profusion.mobi>

Reviewed by Gustavo Noronha Silva.

Add implementaion of new windows for EFL port. Both cases of a link
with target="_blank" and a javascript that does window.open() are
treated, delegating to browser the role of actually creating the
window (or blocking it).
​https://bugs.webkit.org/show_bug.cgi?id=40930

  • CMakeListsEfl.txt: add new file that wraps the WindowFeatures struct
  • efl/WebCoreSupport/ChromeClientEfl.cpp: (WebCore::ChromeClientEfl::createWindow): implement method for creating new window by delegating to browser its creation. Browser might decide to continue on the same window by returning the same view object.
  • efl/WebCoreSupport/FrameLoaderClientEfl.cpp: (WebCore::FrameLoaderClientEfl::dispatchCreatePage): implement method for creating new window when its creation is done by a javascript script.
  • efl/ewk/EWebKit.h: new header for WindowFeatures.
  • efl/ewk/ewk_private.h:
  • efl/ewk/ewk_view.cpp: (ewk_view_window_create): call the method implemented by browser.
  • efl/ewk/ewk_view.h:
  • efl/ewk/ewk_window_features.cpp: Added. (ewk_window_features_unref): (ewk_window_features_ref): (ewk_window_features_bool_property_get): (ewk_window_features_int_property_get): (ewk_window_features_new_from_core): create and wrapped struct containing the core struct.
  • efl/ewk/ewk_window_features.h: Added.
12:32 PM Changeset in webkit [61705] by andersca@apple.com
  • 3 edits
    1 move in trunk/WebKit2

Rename SimpleArgumentCoder.h to ArgumentCoders.h

Reviewed by Sam Weinig.

  • Platform/CoreIPC/ArgumentCoders.h: Copied from Platform/CoreIPC/SimpleArgumentCoder.h.
  • Platform/CoreIPC/SimpleArgumentCoder.h: Removed.
  • Shared/WebCoreTypeArgumentMarshalling.h:
  • WebKit2.xcodeproj/project.pbxproj:
12:08 PM Changeset in webkit [61704] by ap@apple.com
  • 2 edits in trunk/LayoutTests

Reviewed by Eric Seidel.

​https://bugs.webkit.org/show_bug.cgi?id=41083
fast/parser/broken-comments-vs-parsing mode no linger tests for what it used to test

  • fast/parser/broken-comments-vs-parsing-mode.html: Moved broken comment to a place where it doesn't affect output.
11:42 AM Changeset in webkit [61703] by kov@webkit.org
  • 2 edits in trunk/WebCore

2010-06-23 Gustavo Noronha Silva <​gustavo.noronha@collabora.co.uk>

Reviewed by Xan Lopez.

[gtk] web fonts not loaded properly in scribd html5 reader
​https://bugs.webkit.org/show_bug.cgi?id=38758

Drop filling the pattern with default values, because this
restricts the matching more than we want.

  • platform/graphics/cairo/FontCacheCairo.cpp: (WebCore::FontCache::createFontPlatformData):
11:41 AM Changeset in webkit [61702] by andersca@apple.com
  • 3 edits in trunk/WebKit2

2010-06-23 Anders Carlsson <​andersca@apple.com>

Reviewed by Sam Weinig.

Add a plug-in info cache to WebPlatformStrategies
​https://bugs.webkit.org/show_bug.cgi?id=41087

This is in preparation for proxying the getPlugins call over to the UI process.

  • WebProcess/WebCoreSupport/WebPlatformStrategies.cpp: (WebKit::WebPlatformStrategies::WebPlatformStrategies): (WebKit::WebPlatformStrategies::populatePluginCache): (WebKit::WebPlatformStrategies::refreshPlugins): (WebKit::WebPlatformStrategies::getPluginInfo):
  • WebProcess/WebCoreSupport/WebPlatformStrategies.h:
11:23 AM Changeset in webkit [61701] by kov@webkit.org
  • 2 edits in trunk/WebCore

2010-06-23 Gustavo Noronha Silva <​gustavo.noronha@collabora.co.uk>

Reviewed by Xan Lopez.

[gtk] web fonts not loaded properly in scribd html5 reader
​https://bugs.webkit.org/show_bug.cgi?id=38758

Also special-case sans' amd mono', which are aliases commonly
used in GTK+ applications.

  • platform/graphics/cairo/FontCacheCairo.cpp: (WebCore::isWellKnownFontName):
11:17 AM Changeset in webkit [61700] by weinig@apple.com
  • 2 edits in trunk/WebKit2

Stop silently ignoring crashes.

Reviewed by John Sullivan.

  • WebProcess/Launching/mac/WebProcessMain.mm:
10:58 AM Changeset in webkit [61699] by jschuh@chromium.org
  • 3 edits
    3 deletes in trunk

2010-06-23 Justin Schuh <​jschuh@chromium.org>

Unreviewed, rolling out r61695.
​http://trac.webkit.org/changeset/61695
​https://bugs.webkit.org/show_bug.cgi?id=40798

61695 broke all the Linux builds.

  • platform/image-decoders/png/PNGImageDecoder.cpp: (WebCore::PNGImageDecoder::rowAvailable):

2010-06-23 Justin Schuh <​jschuh@chromium.org>

Unreviewed, rolling out r61695.
​http://trac.webkit.org/changeset/61695
​https://bugs.webkit.org/show_bug.cgi?id=40798

61695 broke all the Linux builds

  • fast/images/png-extra-row-crash-expected.txt: Removed.
  • fast/images/png-extra-row-crash.html: Removed.
  • fast/images/resources/png-extra-row-crash.png: Removed.
10:53 AM Changeset in webkit [61698] by weinig@apple.com
  • 2 edits in trunk/WebKit2

Add missing include to WKRetainPtr.

Reviewed by Anders Carlsson.

  • UIProcess/API/cpp/WKRetainPtr.h:
10:52 AM Changeset in webkit [61697] by kevino@webkit.org
  • 2 edits in trunk/WebCore

Reviewed by Darin Adler.

Fix PluginViewNone.cpp compilation for ports that also compile PluginView.cpp
​https://bugs.webkit.org/show_bug.cgi?id=37939

10:51 AM Changeset in webkit [61696] by jamesr@google.com
  • 1 edit
    1 add in trunk/LayoutTests

2010-06-23 James Robinson <​jamesr@chromium.org>

Unreviewed. Add qt baseline due to port specific formatting differences for SVG rects
​https://bugs.webkit.org/show_bug.cgi?id=40366

  • platform/qt/fast/repaint/svg-layout-root-style-attr-update-expected.txt: Added.
10:25 AM Changeset in webkit [61695] by jschuh@chromium.org
  • 3 edits
    3 adds in trunk

2010-06-23 Cris Neckar <​cdn@chromium.org>

Reviewed by Darin Fisher.

[Chromium] Out of bounds write in WebCore::PNGImageDecoder::rowAvailable
​https://bugs.webkit.org/show_bug.cgi?id=40798

Catches error in row callback for libPNG when extra rows are returned.

Test: fast/images/png-extra-row-crash.html

  • platform/image-decoders/png/PNGImageDecoder.cpp: (WebCore::PNGImageDecoder::rowAvailable):

2010-06-23 Cris Neckar <​cdn@chromium.org>

Reviewed by Darin Fisher.

[Chromium] Out of bounds write in WebCore::PNGImageDecoder::rowAvailable
​https://bugs.webkit.org/show_bug.cgi?id=40798

Tests a PNG with an extra row.

  • fast/images/png-extra-row-crash-expected.txt: Added.
  • fast/images/png-extra-row-crash.html: Added.
  • fast/images/resources/png-extra-row-crash.png: Added.
10:21 AM Changeset in webkit [61694] by jamesr@google.com
  • 2 edits in trunk/WebKitTools

2010-06-23 James Robinson <​jamesr@chromium.org>

Unreviewed. Add my IRC handle to committers.py so the sheriffbot can yell at me.

  • Scripts/webkitpy/common/config/committers.py:
9:56 AM Changeset in webkit [61693] by jamesr@google.com
  • 3 edits
    4 adds in trunk

2010-06-23 James Robinson <​jamesr@chromium.org>

Reviewed by Dan Bernstein.

Do not set needsLayout when the style attribute changes on an SVG element
​https://bugs.webkit.org/show_bug.cgi?id=40366

SVGSVGElement::svgAttributeChanged was incorrectly calling renderer()->setNeedsLayout(true)
whenever the styleAttr changed on its element. This could happen during layout in some
circumstances due to lazy style attribute synchronization. When it did, it could cause the
layout flags to become inconsistent. See the test case for details.

Changes to an element's style attribute always mark an element as needing layout anyway so
this call was redundant.

Test: fast/repaint/svg-layout-root-style-attr-update.html

  • svg/SVGStyledElement.cpp: (WebCore::SVGStyledElement::isKnownAttribute):

2010-06-23 James Robinson <​jamesr@chromium.org>

Reviewed by Dan Bernstein.

Do not set needsLayout when the style attribute changes on an SVG element
​https://bugs.webkit.org/show_bug.cgi?id=40366

Tests that setting the style attribute on an SVG element does not cause
the render tree's layout flags to go haywire. The details are involved,
please see the bug and test case for details.

  • fast/repaint/svg-layout-root-style-attr-update-expected.checksum: Added.
  • fast/repaint/svg-layout-root-style-attr-update-expected.png: Added.
  • fast/repaint/svg-layout-root-style-attr-update-expected.txt: Added.
  • fast/repaint/svg-layout-root-style-attr-update.html: Added.
9:18 AM Changeset in webkit [61692] by Simon Fraser
  • 3 edits
    5 adds in trunk

2010-06-23 Simon Fraser <Simon Fraser>

Reviewed by Dan Bernstein.

r61215 broke Acid3
​https://bugs.webkit.org/show_bug.cgi?id=41034

The code added in r61215, which tests whether the root renderer will fill
the entire viewport, should not run for subframes. So bail from
RenderView::paintBoxDecorations() if document()->ownerElement() is not null.
The old code was trying to do this by checking 'elt', but that ends up as
null after the for loop above.

We can also bail early if the is no FrameView().

Test: fast/frames/paint-iframe-background.html

  • rendering/RenderView.cpp: (WebCore::RenderView::paintBoxDecorations):
9:17 AM Changeset in webkit [61691] by pfeldman@chromium.org
  • 6 edits in trunk/WebCore

2010-06-23 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: do not reset profiles panel on navigation.

​https://bugs.webkit.org/show_bug.cgi?id=41068

  • inspector/InspectorController.cpp: (WebCore::InspectorController::didCommitLoad):
  • inspector/InspectorFrontend.cpp: (WebCore::InspectorFrontend::resetProfilesPanel):
  • inspector/InspectorFrontend.h:
  • inspector/front-end/ProfilesPanel.js: (WebInspector.ProfilesPanel): (WebInspector.ProfilesPanel.prototype.populateInterface): (WebInspector.ProfilesPanel.prototype.profilerWasDisabled): (WebInspector.ProfilesPanel.prototype._reset): (WebInspector.ProfilesPanel.prototype._clearProfiles):
  • inspector/front-end/inspector.js: (WebInspector.resetProfilesPanel):
9:11 AM Changeset in webkit [61690] by tkent@chromium.org
  • 3 edits in trunk/WebKitTools

2010-06-23 Kent Tamura <​tkent@chromium.org>

Reviewed by Dimitri Glazkov.

Correct Chromium test configuration
​https://bugs.webkit.org/show_bug.cgi?id=41057

  • BuildSlaveSupport/build.webkit.org-config/master.cfg:
    • Add "--use-drt" option for NRWT. It is required for Chromium and ignored for other platforms.
    • Skip JSC test on Chromium
  • BuildSlaveSupport/test-result-archive: Add Chromium support.
9:06 AM Changeset in webkit [61689] by weinig@apple.com
  • 13 edits in trunk

Fix for ​https://bugs.webkit.org/show_bug.cgi?id=41073
WebKit2: Flesh out more of the InjectedBundle client API

Reviewed by Anders Carlsson.

WebKit2:

  • WebProcess/InjectedBundle/API/c/WKBundle.h:
  • WebProcess/InjectedBundle/API/c/WKBundlePage.h:
  • WebProcess/InjectedBundle/InjectedBundle.cpp:

(WebKit::InjectedBundle::willDestroyPage):

  • WebProcess/InjectedBundle/InjectedBundle.h:
  • WebProcess/InjectedBundle/InjectedBundlePageClient.cpp:

(WebKit::InjectedBundlePageClient::didStartProvisionalLoadForFrame):
(WebKit::InjectedBundlePageClient::didReceiveServerRedirectForProvisionalLoadForFrame):
(WebKit::InjectedBundlePageClient::didFailProvisionalLoadWithErrorForFrame):
(WebKit::InjectedBundlePageClient::didCommitLoadForFrame):
(WebKit::InjectedBundlePageClient::didFinishLoadForFrame):
(WebKit::InjectedBundlePageClient::didFailLoadWithErrorForFrame):
(WebKit::InjectedBundlePageClient::didReceiveTitleForFrame):

  • WebProcess/InjectedBundle/InjectedBundlePageClient.h:
  • WebProcess/InjectedBundle/mac/InjectedBundleMac.cpp:

(WebKit::InjectedBundle::load): Add some error logging on failure to load the bundle.

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::dispatchDidReceiveServerRedirectForProvisionalLoad):
(WebKit::WebFrameLoaderClient::dispatchDidStartProvisionalLoad):
(WebKit::WebFrameLoaderClient::dispatchDidReceiveTitle):
(WebKit::WebFrameLoaderClient::dispatchDidCommitLoad):
(WebKit::WebFrameLoaderClient::dispatchDidFailProvisionalLoad):
(WebKit::WebFrameLoaderClient::dispatchDidFailLoad):
(WebKit::WebFrameLoaderClient::dispatchDidFinishLoad):

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::close):

  • mac/WebKit2.exp:

WebKitTools:

  • MiniBrowser/mac/WebBundle/WebBundleMain.m:

(_didStartProvisionalLoadForFrame):
(_didReceiveServerRedirectForProvisionalLoadForFrame):
(_didFailProvisionalLoadWithErrorForFrame):
(_didCommitLoadForFrame):
(_didFinishLoadForFrame):
(_didFailLoadWithErrorForFrame):
(_didReceiveTitleForFrame):
(_didClearWindowForFrame):
(_didCreatePage):
(_willDestroyPage):
(WKBundleInitialize):

8:34 AM Changeset in webkit [61688] by yurys@chromium.org
  • 3 edits in trunk/WebCore

2010-06-23 Yury Semikhatsky <​yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: InspectorController should be added only once as ScriptDebugListener to
ScriptDebugServer.
​https://bugs.webkit.org/show_bug.cgi?id=41070

  • inspector/InspectorController.cpp: (WebCore::InspectorController::connectFrontend): (WebCore::InspectorController::disconnectFrontend): (WebCore::InspectorController::enableDebuggerFromFrontend):
  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel): don't call InspectorBackend.enableDebugger if debugger is always enabled, InspectorController will do this on its side when the front end is connected.
8:01 AM Changeset in webkit [61687] by yurys@chromium.org
  • 2 edits in trunk/WebCore

2010-06-23 Pavel Podivilov <​podivilov@chromium.org>

Reviewed by Yury Semikhatsky.

Clear breakpoints before restoring them, not after.
​https://bugs.webkit.org/show_bug.cgi?id=41071

  • inspector/InspectorController.cpp: (WebCore::InspectorController::enableDebuggerFromFrontend):
7:11 AM Changeset in webkit [61686] by benjamin.poulain@nokia.com
  • 8 edits in trunk/WebCore

Do not render the full frame when there is some elements with fixed positioning
​https://bugs.webkit.org/show_bug.cgi?id=33150

Reviewed by Kenneth Rohde Christiansen.

Do not render the full frame when there is some elements with fixed positioning
​https://bugs.webkit.org/show_bug.cgi?id=33150

The frame view take into acount the list of fixed object when scrolling
the view. If the number of object is lower than a certain threshold, the pixel
are blitted, and the invalidated area updated.

  • page/FrameView.cpp:

(WebCore::FrameView::addFixedObject):
(WebCore::FrameView::removeFixedObject):
(WebCore::FrameView::scrollContentsFastPath):

  • page/FrameView.h:
  • platform/ScrollView.cpp:

(WebCore::ScrollView::scrollContents):
(WebCore::ScrollView::scrollContentsFastPath):

  • platform/ScrollView.h:
  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::repaintRectIncludingDescendants):

  • rendering/RenderLayer.h:
  • rendering/RenderObject.cpp:

(WebCore::RenderObject::styleWillChange):

7:01 AM Changeset in webkit [61685] by leandro@webkit.org
  • 2 edits in trunk/JavaScriptCore

2010-06-23 Leandro Pereira <​leandro@profusion.mobi>

Unreviewed build fix.

  • CMakeLists.txt: Add runtime/RegExpCache.cpp.
6:33 AM Changeset in webkit [61684] by Simon Hausmann
  • 2 edits in trunk/WebKit/qt

[Qt] Doc: Fixed documentation errors.

Patch by David Boddie <​dboddie@trolltech.com> on 2010-06-23
Reviewed by Simon Hausmann.

  • docs/qtwebkit-bridge.qdoc:
6:19 AM Changeset in webkit [61683] by Simon Hausmann
  • 2 edits in trunk/WebKit/qt

[Qt] Provide the Webkit Qml plugin with a UID3 on Symbian

Patch by Alessandro Portale <​alessandro.portale@nokia.com> on 2010-06-23
Reviewed by Simon Hausmann.

...otherwise we cannot Symbian sign it.

  • declarative/declarative.pro:
5:14 AM Changeset in webkit [61682] by mnaganov@chromium.org
  • 2 edits in trunk/WebCore

2010-06-23 Mikhail Naganov <​mnaganov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Fix displaying of several CPU profiles with the same name.

​https://bugs.webkit.org/show_bug.cgi?id=40992

  • inspector/front-end/ProfilesPanel.js: (WebInspector.ProfileGroupSidebarTreeElement.prototype.onselect):
3:36 AM Changeset in webkit [61681] by Simon Hausmann
  • 2 edits in trunk/WebKit/qt

Unreviewed Qt package build fix.

When building without build-webkit, set OUTPUT_DIR if necessary, like
in the other .pro files.

  • declarative/declarative.pro:
3:29 AM Changeset in webkit [61680] by yuzo@google.com
  • 4 edits in trunk/WebKit/chromium

2010-06-23 Yuzo Fujishima <​yuzo@google.com>

Reviewed by Shinichiro Hamaji.

Make page format data methods accessible from Chromium
​https://bugs.webkit.org/show_bug.cgi?id=41056

  • public/WebFrame.h:
  • src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::isPageBoxVisible): (WebKit::WebFrameImpl::pageAreaRectInPixels): (WebKit::WebFrameImpl::preferredPageSizeInPixels):
  • src/WebFrameImpl.h:
2:37 AM Changeset in webkit [61679] by Nikolas Zimmermann
  • 2 edits in trunk/LayoutTests

2010-06-23 Nikolas Zimmermann <​nzimmermann@rim.com>

Not reviewed. Forgot to update result of fast/xpath/namespace-vs-predicate.html after the SVG renderer creation changes.

  • fast/xpath/namespace-vs-predicate-expected.txt:
2:21 AM Changeset in webkit [61678] by abarth@webkit.org
  • 8 edits in trunk/WebCore

2010-06-23 Adam Barth <​abarth@webkit.org>

Unreviewed. clean-header-guards that were made dirty by recent
renames.

  • html/HTMLDocumentParser.h:
  • html/HTMLPreloadScanner.h:
  • html/HTMLTokenizer.h:
  • html/HTMLTreeBuilder.h:
  • html/LegacyHTMLDocumentParser.h:
  • html/LegacyHTMLTreeBuilder.h:
  • html/LegacyPreloadScanner.h:
2:03 AM Changeset in webkit [61677] by abarth@webkit.org
  • 23 edits
    2 moves in trunk/WebCore

2010-06-23 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Rename LegacyHTMLTreeConstructor to LegacyHTMLTreeBuilder
​https://bugs.webkit.org/show_bug.cgi?id=41053

There was some debate about whether to call this class (and the
non-legacy version) "tree builder" or "tree constructor". Maciej
pointed out that other implementations (including Mozilla and HTML5Lib)
call it a tree builder. The path of least resistance seems to be call
it that for now.

  • Android.mk:
  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/Document.cpp:
  • dom/DocumentParser.h: (WebCore::DocumentParser::htmlTreeConstructor):
  • html/HTMLDocumentParser.cpp: (WebCore::HTMLDocumentParser::htmlTreeConstructor):
  • html/HTMLDocumentParser.h:
  • html/HTMLFormControlElement.cpp: (WebCore::HTMLFormControlElement::removedFromTree):
  • html/HTMLInputElement.cpp:
  • html/HTMLMeterElement.cpp:
  • html/HTMLProgressElement.cpp:
  • html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::HTMLTreeBuilder):
  • html/HTMLTreeBuilder.h: (WebCore::HTMLTreeBuilder::legacyTreeConstructor):
  • html/LegacyHTMLDocumentParser.cpp: (WebCore::LegacyHTMLDocumentParser::LegacyHTMLDocumentParser):
  • html/LegacyHTMLDocumentParser.h: (WebCore::LegacyHTMLDocumentParser::htmlTreeConstructor):
  • html/LegacyHTMLTreeBuilder.cpp: Copied from WebCore/html/LegacyHTMLTreeConstructor.cpp. (WebCore::LegacyHTMLTreeBuilder::LegacyHTMLTreeBuilder): (WebCore::LegacyHTMLTreeBuilder::~LegacyHTMLTreeBuilder): (WebCore::LegacyHTMLTreeBuilder::reset): (WebCore::LegacyHTMLTreeBuilder::setCurrent): (WebCore::LegacyHTMLTreeBuilder::limitDepth): (WebCore::LegacyHTMLTreeBuilder::insertNodeAfterLimitDepth): (WebCore::LegacyHTMLTreeBuilder::parseToken): (WebCore::LegacyHTMLTreeBuilder::parseDoctypeToken): (WebCore::LegacyHTMLTreeBuilder::insertNode): (WebCore::LegacyHTMLTreeBuilder::handleError): (WebCore::LegacyHTMLTreeBuilder::textCreateErrorCheck): (WebCore::LegacyHTMLTreeBuilder::commentCreateErrorCheck): (WebCore::LegacyHTMLTreeBuilder::headCreateErrorCheck): (WebCore::LegacyHTMLTreeBuilder::bodyCreateErrorCheck): (WebCore::LegacyHTMLTreeBuilder::framesetCreateErrorCheck): (WebCore::LegacyHTMLTreeBuilder::formCreateErrorCheck): (WebCore::LegacyHTMLTreeBuilder::isindexCreateErrorCheck): (WebCore::LegacyHTMLTreeBuilder::selectCreateErrorCheck): (WebCore::LegacyHTMLTreeBuilder::ddCreateErrorCheck): (WebCore::LegacyHTMLTreeBuilder::dtCreateErrorCheck): (WebCore::LegacyHTMLTreeBuilder::rpCreateErrorCheck): (WebCore::LegacyHTMLTreeBuilder::rtCreateErrorCheck): (WebCore::LegacyHTMLTreeBuilder::nestedCreateErrorCheck): (WebCore::LegacyHTMLTreeBuilder::nestedPCloserCreateErrorCheck): (WebCore::LegacyHTMLTreeBuilder::nestedStyleCreateErrorCheck): (WebCore::LegacyHTMLTreeBuilder::tableCellCreateErrorCheck): (WebCore::LegacyHTMLTreeBuilder::tableSectionCreateErrorCheck): (WebCore::LegacyHTMLTreeBuilder::noembedCreateErrorCheck): (WebCore::LegacyHTMLTreeBuilder::noframesCreateErrorCheck): (WebCore::LegacyHTMLTreeBuilder::noscriptCreateErrorCheck): (WebCore::LegacyHTMLTreeBuilder::pCloserCreateErrorCheck): (WebCore::LegacyHTMLTreeBuilder::pCloserStrictCreateErrorCheck): (WebCore::LegacyHTMLTreeBuilder::mapCreateErrorCheck): (WebCore::LegacyHTMLTreeBuilder::getNode): (WebCore::LegacyHTMLTreeBuilder::allowNestedRedundantTag): (WebCore::LegacyHTMLTreeBuilder::processCloseTag): (WebCore::LegacyHTMLTreeBuilder::isHeadingTag): (WebCore::LegacyHTMLTreeBuilder::isInline): (WebCore::LegacyHTMLTreeBuilder::isResidualStyleTag): (WebCore::LegacyHTMLTreeBuilder::isAffectedByResidualStyle): (WebCore::LegacyHTMLTreeBuilder::handleResidualStyleCloseTagAcrossBlocks): (WebCore::LegacyHTMLTreeBuilder::reopenResidualStyleTags): (WebCore::LegacyHTMLTreeBuilder::pushBlock): (WebCore::LegacyHTMLTreeBuilder::popBlock): (WebCore::LegacyHTMLTreeBuilder::popOneBlockCommon): (WebCore::LegacyHTMLTreeBuilder::popOneBlock): (WebCore::LegacyHTMLTreeBuilder::moveOneBlockToStack): (WebCore::LegacyHTMLTreeBuilder::checkIfHasPElementInScope): (WebCore::LegacyHTMLTreeBuilder::popInlineBlocks): (WebCore::LegacyHTMLTreeBuilder::freeBlock): (WebCore::LegacyHTMLTreeBuilder::createHead): (WebCore::LegacyHTMLTreeBuilder::handleIsindex): (WebCore::LegacyHTMLTreeBuilder::startBody): (WebCore::LegacyHTMLTreeBuilder::finished): (WebCore::LegacyHTMLTreeBuilder::reportErrorToConsole):
  • html/LegacyHTMLTreeBuilder.h: Copied from WebCore/html/LegacyHTMLTreeConstructor.h.
  • html/LegacyHTMLTreeConstructor.cpp: Removed.
  • html/LegacyHTMLTreeConstructor.h: Removed.
  • html/StepRange.cpp:
  • html/ValidityState.cpp:
  • rendering/RenderSlider.cpp:
1:50 AM Changeset in webkit [61676] by tkent@chromium.org
  • 1 edit
    23 adds in trunk/LayoutTests

2010-06-23 Kent Tamura <​tkent@chromium.org>

Unreviewed, test expectation update.

Add expectations for r61667 and r61669.

  • platform/chromium-linux/svg/custom/bug45331-expected.checksum: Added.
  • platform/chromium-linux/svg/foreignObject: Added.
  • platform/chromium-linux/svg/foreignObject/no-crash-with-svg-content-in-html-document-expected.checksum: Added.
  • platform/chromium-linux/svg/foreignObject/svg-document-as-direct-child-expected.checksum: Added.
  • platform/chromium-linux/svg/foreignObject/svg-document-in-html-document-expected.checksum: Added.
  • platform/chromium-linux/svg/foreignObject/text-tref-02-b-expected.checksum: Added.
  • platform/chromium-linux/svg/foreignObject/text-tref-02-b-expected.png: Added.
  • platform/chromium-win/svg/custom/bug45331-expected.checksum: Added.
  • platform/chromium-win/svg/custom/bug45331-expected.png: Added.
  • platform/chromium-win/svg/custom/bug45331-expected.txt: Added.
  • platform/chromium-win/svg/foreignObject: Added.
  • platform/chromium-win/svg/foreignObject/no-crash-with-svg-content-in-html-document-expected.checksum: Added.
  • platform/chromium-win/svg/foreignObject/no-crash-with-svg-content-in-html-document-expected.png: Added.
  • platform/chromium-win/svg/foreignObject/no-crash-with-svg-content-in-html-document-expected.txt: Added.
  • platform/chromium-win/svg/foreignObject/svg-document-as-direct-child-expected.checksum: Added.
  • platform/chromium-win/svg/foreignObject/svg-document-as-direct-child-expected.png: Added.
  • platform/chromium-win/svg/foreignObject/svg-document-as-direct-child-expected.txt: Added.
  • platform/chromium-win/svg/foreignObject/svg-document-in-html-document-expected.checksum: Added.
  • platform/chromium-win/svg/foreignObject/svg-document-in-html-document-expected.png: Added.
  • platform/chromium-win/svg/foreignObject/svg-document-in-html-document-expected.txt: Added.
  • platform/chromium-win/svg/foreignObject/text-tref-02-b-expected.checksum: Added.
  • platform/chromium-win/svg/foreignObject/text-tref-02-b-expected.png: Added.
  • platform/chromium-win/svg/foreignObject/text-tref-02-b-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
1:44 AM Changeset in webkit [61675] by abarth@webkit.org
  • 13 edits
    4 moves in trunk/WebCore

2010-06-23 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Rename the preload scanners
​https://bugs.webkit.org/show_bug.cgi?id=41052

Renames PreloadScanner to LegacyPreloadScanner because this code is now
off by default. Also, rename HTML5PreloadScanner to
HTMLPreloadScanner. We're not calling it PreloadScanner because we've
factored out the CSSPreloadScanner and the HTMLPreloadScanner from the
original PreloadScanner.

  • Android.mk:
  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • html/HTML5PreloadScanner.cpp: Removed.
  • html/HTML5PreloadScanner.h: Removed.
  • html/HTMLDocumentParser.cpp: (WebCore::HTMLDocumentParser::pumpTokenizer):
  • html/HTMLDocumentParser.h:
  • html/HTMLPreloadScanner.cpp: Copied from WebCore/html/HTML5PreloadScanner.cpp. (WebCore::HTMLPreloadScanner::HTMLPreloadScanner): (WebCore::HTMLPreloadScanner::appendToEnd): (WebCore::HTMLPreloadScanner::scan): (WebCore::HTMLPreloadScanner::processToken): (WebCore::HTMLPreloadScanner::scanningBody):
  • html/HTMLPreloadScanner.h: Copied from WebCore/html/HTML5PreloadScanner.h.
  • html/LegacyHTMLDocumentParser.cpp: (WebCore::LegacyHTMLDocumentParser::scriptHandler): (WebCore::LegacyHTMLDocumentParser::scriptExecution):
  • html/LegacyHTMLDocumentParser.h:
  • html/LegacyPreloadScanner.cpp: Copied from WebCore/html/PreloadScanner.cpp. (WebCore::LegacyPreloadScanner::LegacyPreloadScanner): (WebCore::LegacyPreloadScanner::~LegacyPreloadScanner): (WebCore::LegacyPreloadScanner::begin): (WebCore::LegacyPreloadScanner::end): (WebCore::LegacyPreloadScanner::reset): (WebCore::LegacyPreloadScanner::scanningBody): (WebCore::LegacyPreloadScanner::write): (WebCore::LegacyPreloadScanner::clearLastCharacters): (WebCore::LegacyPreloadScanner::rememberCharacter): (WebCore::LegacyPreloadScanner::lastCharactersMatch): (WebCore::LegacyPreloadScanner::consumeEntity): (WebCore::LegacyPreloadScanner::tokenize): (WebCore::LegacyPreloadScanner::processAttribute): (WebCore::LegacyPreloadScanner::emitCharacter): (WebCore::LegacyPreloadScanner::tokenizeCSS): (WebCore::LegacyPreloadScanner::emitTag): (WebCore::LegacyPreloadScanner::emitCSSRule):
  • html/LegacyPreloadScanner.h: Copied from WebCore/html/PreloadScanner.h.
  • html/PreloadScanner.cpp: Removed.
  • html/PreloadScanner.h: Removed.
  • page/XSSAuditor.cpp: (WebCore::XSSAuditor::decodeHTMLEntities):
1:33 AM Changeset in webkit [61674] by abarth@webkit.org
  • 13 edits
    4 moves in trunk/WebCore

2010-06-23 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Yet more HTML5 => HTML renames
​https://bugs.webkit.org/show_bug.cgi?id=41051

This patch renames HTML5DocumentParser to HTMLDocumentParser and
HTML5TreeBuilder to HTMLTreeBuilder. There was some discussion about
whether to use the name HTMLTreeBuilder or HTMLTreeConstructor, but
tree builder seems to be the dominate name in other implementations.

  • Android.mk:
  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/DocumentFragment.cpp: (WebCore::DocumentFragment::parseHTML):
  • html/HTML5DocumentParser.cpp: Removed.
  • html/HTML5DocumentParser.h: Removed.
  • html/HTML5PreloadScanner.cpp: (WebCore::HTML5PreloadScanner::scan): (WebCore::HTML5PreloadScanner::processToken):
  • html/HTML5TreeBuilder.cpp: Removed.
  • html/HTML5TreeBuilder.h: Removed.
  • html/HTMLDocument.cpp: (WebCore::HTMLDocument::createParser):
  • html/HTMLDocumentParser.cpp: Copied from WebCore/html/HTML5DocumentParser.cpp. (WebCore::HTMLDocumentParser::HTMLDocumentParser): (WebCore::HTMLDocumentParser::~HTMLDocumentParser): (WebCore::HTMLDocumentParser::begin): (WebCore::HTMLDocumentParser::stopParsing): (WebCore::HTMLDocumentParser::processingData): (WebCore::HTMLDocumentParser::pumpTokenizerIfPossible): (WebCore::HTMLDocumentParser::isScheduledForResume): (WebCore::HTMLDocumentParser::resumeParsingAfterYield): (WebCore::HTMLDocumentParser::runScriptsForPausedTreeConstructor): (WebCore::HTMLDocumentParser::pumpTokenizer): (WebCore::HTMLDocumentParser::willPumpLexer): (WebCore::HTMLDocumentParser::didPumpLexer): (WebCore::HTMLDocumentParser::write): (WebCore::HTMLDocumentParser::end): (WebCore::HTMLDocumentParser::attemptToEnd): (WebCore::HTMLDocumentParser::endIfDelayed): (WebCore::HTMLDocumentParser::finish): (WebCore::HTMLDocumentParser::finishWasCalled): (WebCore::HTMLDocumentParser::executingScript): (WebCore::HTMLDocumentParser::inScriptExecution): (WebCore::HTMLDocumentParser::lineNumber): (WebCore::HTMLDocumentParser::columnNumber): (WebCore::HTMLDocumentParser::htmlTreeConstructor): (WebCore::HTMLDocumentParser::isWaitingForScripts): (WebCore::HTMLDocumentParser::resumeParsingAfterScriptExecution): (WebCore::HTMLDocumentParser::watchForLoad): (WebCore::HTMLDocumentParser::stopWatchingForLoad): (WebCore::HTMLDocumentParser::shouldLoadExternalScriptFromSrc): (WebCore::HTMLDocumentParser::notifyFinished): (WebCore::HTMLDocumentParser::executeScriptsWaitingForStylesheets): (WebCore::HTMLDocumentParser::script):
  • html/HTMLDocumentParser.h: Copied from WebCore/html/HTML5DocumentParser.h.
  • html/HTMLParserScheduler.cpp: (WebCore::HTMLParserScheduler::HTMLParserScheduler):
  • html/HTMLParserScheduler.h:
  • html/HTMLTreeBuilder.cpp: Copied from WebCore/html/HTML5TreeBuilder.cpp. (WebCore::HTMLTreeBuilder::HTMLTreeBuilder): (WebCore::HTMLTreeBuilder::~HTMLTreeBuilder): (WebCore::HTMLTreeBuilder::handleScriptStartTag): (WebCore::HTMLTreeBuilder::handleScriptEndTag): (WebCore::HTMLTreeBuilder::takeScriptToProcess): (WebCore::HTMLTreeBuilder::adjustedLexerState): (WebCore::HTMLTreeBuilder::passTokenToLegacyParser): (WebCore::HTMLTreeBuilder::constructTreeFromToken): (WebCore::HTMLTreeBuilder::processToken): (WebCore::HTMLTreeBuilder::finished): (WebCore::HTMLTreeBuilder::isScriptingFlagEnabled):
  • html/HTMLTreeBuilder.h: Copied from WebCore/html/HTML5TreeBuilder.h.
1:18 AM Changeset in webkit [61673] by abarth@webkit.org
  • 18 edits
    4 moves in trunk/WebCore

2010-06-23 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

More HTML5 => HTML renames
​https://bugs.webkit.org/show_bug.cgi?id=41049

This patch renames HTML5ScriptRunner, HTML5ScriptRunnerHost, and
HTML5Token to remove the "5" from their names. These clases aren't
specific to HTML5 and will be used going forward.

  • Android.mk:
  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • html/CSSPreloadScanner.cpp: (WebCore::CSSPreloadScanner::scan):
  • html/CSSPreloadScanner.h:
  • html/HTML5DocumentParser.cpp: (WebCore::HTML5DocumentParser::HTML5DocumentParser): (WebCore::HTML5DocumentParser::notifyFinished):
  • html/HTML5DocumentParser.h:
  • html/HTML5PreloadScanner.cpp: (WebCore::HTMLNames::PreloadTask::PreloadTask): (WebCore::HTMLNames::PreloadTask::processAttributes): (WebCore::HTML5PreloadScanner::processToken):
  • html/HTML5PreloadScanner.h:
  • html/HTML5ScriptRunner.cpp: Removed.
  • html/HTML5ScriptRunner.h: Removed.
  • html/HTML5ScriptRunnerHost.h: Removed.
  • html/HTML5Token.h: Removed.
  • html/HTML5TreeBuilder.cpp: (WebCore::convertToOldStyle): (WebCore::HTML5TreeBuilder::handleScriptEndTag): (WebCore::HTML5TreeBuilder::passTokenToLegacyParser): (WebCore::HTML5TreeBuilder::constructTreeFromToken): (WebCore::HTML5TreeBuilder::processToken):
  • html/HTML5TreeBuilder.h:
  • html/HTMLScriptRunner.cpp: Copied from WebCore/html/HTML5ScriptRunner.cpp. (WebCore::HTMLScriptRunner::HTMLScriptRunner): (WebCore::HTMLScriptRunner::~HTMLScriptRunner): (WebCore::HTMLScriptRunner::sourceFromPendingScript): (WebCore::HTMLScriptRunner::isPendingScriptReady): (WebCore::HTMLScriptRunner::executePendingScript): (WebCore::HTMLScriptRunner::executeScript): (WebCore::HTMLScriptRunner::hasScriptsWaitingForLoad): (WebCore::HTMLScriptRunner::watchForLoad): (WebCore::HTMLScriptRunner::stopWatchingForLoad): (WebCore::HTMLScriptRunner::execute): (WebCore::HTMLScriptRunner::haveParsingBlockingScript): (WebCore::HTMLScriptRunner::executeParsingBlockingScripts): (WebCore::HTMLScriptRunner::executeScriptsWaitingForLoad): (WebCore::HTMLScriptRunner::executeScriptsWaitingForStylesheets): (WebCore::HTMLScriptRunner::requestScript): (WebCore::HTMLScriptRunner::runScript):
  • html/HTMLScriptRunner.h: Copied from WebCore/html/HTML5ScriptRunner.h.
  • html/HTMLScriptRunnerHost.h: Copied from WebCore/html/HTML5ScriptRunnerHost.h. (WebCore::HTMLScriptRunnerHost::~HTMLScriptRunnerHost):
  • html/HTMLToken.h: Copied from WebCore/html/HTML5Token.h. (WebCore::HTMLToken::HTMLToken):
  • html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::nextToken): (WebCore::HTMLTokenizer::emitCharacter): (WebCore::HTMLTokenizer::emitCurrentToken): (WebCore::HTMLTokenizer::shouldEmitBufferedCharacterToken):
  • html/HTMLTokenizer.h:
12:49 AM Changeset in webkit [61672] by abarth@webkit.org
  • 9 edits
    2 moves in trunk/WebCore

2010-06-23 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Rename HTML5EntityParser to HTMLEntityParser
​https://bugs.webkit.org/show_bug.cgi?id=41048

Mostly the result of do-webcore-rename, but I tweaked the header guard
and the name of the free function.

  • Android.mk:
  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • html/HTML5EntityParser.cpp: Removed.
  • html/HTML5EntityParser.h: Removed.
  • html/HTMLEntityParser.cpp: Copied from WebCore/html/HTML5EntityParser.cpp. (WebCore::consumeHTMLEntity):
  • html/HTMLEntityParser.h: Copied from WebCore/html/HTML5EntityParser.h.
  • html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::processEntity): (WebCore::HTMLTokenizer::nextToken):
12:37 AM Changeset in webkit [61671] by morrita@google.com
  • 9 edits
    6 adds in trunk

2010-06-22 Yuta Kitamura <​yutak@chromium.org>

Reviewed by Alexey Proskuryakov.

Add a new class that stores information about WebSocket handshake response.

In the future, instances of the new class will be passed to the Web Inspector
so that it will be able to display information about WebSocket handshake
response.

WebSocket: Add WebSocketHandshakeResponse
​https://bugs.webkit.org/show_bug.cgi?id=38728

Test: websocket/tests/handshake-fail-by-no-cr.html

  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • websockets/WebSocketHandshake.cpp: (WebCore::trimConsoleMessage): (WebCore::WebSocketHandshake::readServerHandshake): (WebCore::WebSocketHandshake::serverHandshakeResponse): (WebCore::WebSocketHandshake::readStatusLine): Moved from extractResponseCode. Add more error checks and make error messages more descriptive. (WebCore::WebSocketHandshake::readHTTPHeaders): (WebCore::WebSocketHandshake::processHeaders):
  • websockets/WebSocketHandshake.h:
  • websockets/WebSocketHandshakeResponse.cpp: Added. (WebCore::WebSocketHandshakeResponse::ChallengeResponse::ChallengeResponse): (WebCore::WebSocketHandshakeResponse::ChallengeResponse::set): (WebCore::WebSocketHandshakeResponse::WebSocketHandshakeResponse): (WebCore::WebSocketHandshakeResponse::~WebSocketHandshakeResponse): (WebCore::WebSocketHandshakeResponse::statusCode): (WebCore::WebSocketHandshakeResponse::setStatusCode): (WebCore::WebSocketHandshakeResponse::statusText): (WebCore::WebSocketHandshakeResponse::setStatusText): (WebCore::WebSocketHandshakeResponse::headerFields): (WebCore::WebSocketHandshakeResponse::addHeaderField): (WebCore::WebSocketHandshakeResponse::clearHeaderFields): (WebCore::WebSocketHandshakeResponse::challengeResponse): (WebCore::WebSocketHandshakeResponse::setChallengeResponse):
  • websockets/WebSocketHandshakeResponse.h: Added.
12:30 AM Changeset in webkit [61670] by yuzo@google.com
  • 26 edits
    2 adds in trunk

2010-06-23 Yuzo Fujishima <​yuzo@google.com>

Reviewed by Shinichiro Hamaji.

Implement page format data programming interface.
​https://bugs.webkit.org/show_bug.cgi?id=37538

  • platform/chromium/test_expectations.txt:
  • platform/gtk/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:
  • printing/page-format-data-expected.txt: Added.
  • printing/page-format-data.html: Added.

2010-06-23 Yuzo Fujishima <​yuzo@google.com>

Reviewed by Shinichiro Hamaji.

Implement page format data programming interface.
The final goal is to implement CSS Paged Media Module Level 3 (​http://dev.w3.org/csswg/css3-page/).
To begin with, this change adds methods to know:

  • if page box is visible,
  • the page area rectangle, and
  • preferred page size.

​https://bugs.webkit.org/show_bug.cgi?id=37538

Test: printing/page-format-data.html

  • WebCore.base.exp:
  • css/CSSParser.cpp: (WebCore::CSSParser::parseSizeParameter):
  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty): (WebCore::CSSStyleSelector::applyPageSizeProperty): (WebCore::CSSStyleSelector::pageSizeFromName): (WebCore::CSSStyleSelector::mmLength): (WebCore::CSSStyleSelector::inchLength):
  • css/CSSStyleSelector.h:
  • css/html.css: (@page):
  • dom/Document.cpp: (WebCore::Document::isPageBoxVisible): (WebCore::Document::pageAreaRectInPixels): (WebCore::Document::preferredPageSizeInPixels):
  • dom/Document.h:
  • page/PrintContext.cpp: (WebCore::PrintContext::isPageBoxVisible): (WebCore::PrintContext::pageAreaRectInPixels): (WebCore::PrintContext::preferredPageSizeInPixels):
  • page/PrintContext.h:
  • rendering/style/RenderStyle.h: (WebCore::InheritedFlags::pageSize): (WebCore::InheritedFlags::setPageSize):
  • rendering/style/StyleRareNonInheritedData.h:

2010-06-23 Yuzo Fujishima <​yuzo@google.com>

Reviewed by Shinichiro Hamaji.

Implement page format data programming interface.
Add methods for testing.
​https://bugs.webkit.org/show_bug.cgi?id=37538

  • Misc/WebCoreStatistics.h:
  • Misc/WebCoreStatistics.mm: (-[WebFrame isPageBoxVisible:]): (-[WebFrame pageAreaRectInPixels:]): (-[WebFrame preferredPageSizeInPixels:]):

2010-06-23 Yuzo Fujishima <​yuzo@google.com>

Reviewed by Shinichiro Hamaji.

Implement page format data programming interface.
Add methods for testing.
​https://bugs.webkit.org/show_bug.cgi?id=37538

  • DumpRenderTree/LayoutTestController.cpp: (parsePageNumber): (isPageBoxVisibleCallback): (pageAreaRectInPixelsCallback): (preferredPageSizeInPixelsCallback): (LayoutTestController::staticFunctions):
  • DumpRenderTree/LayoutTestController.h:
  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::isPageBoxVisible): (LayoutTestController::pageAreaRectInPixels): (LayoutTestController::preferredPageSizeInPixels):
  • DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::isPageBoxVisible): (LayoutTestController::pageAreaRectInPixels): (LayoutTestController::preferredPageSizeInPixels):
  • DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::isPageBoxVisible): (LayoutTestController::pageAreaRectInPixels): (LayoutTestController::preferredPageSizeInPixels):
12:19 AM Changeset in webkit [61669] by Nikolas Zimmermann
  • 1 edit
    4 adds in trunk/LayoutTests

2010-06-23 Nikolas Zimmermann <​nzimmermann@rim.com>

Not reviewed. Forgot to include four files in the last commit.

  • platform/mac/svg/custom/bug45331-expected.checksum: Added.
  • platform/mac/svg/custom/bug45331-expected.png: Added.
  • platform/mac/svg/custom/bug45331-expected.txt: Added.
  • svg/custom/bug45331.svg: Added.
12:16 AM Changeset in webkit [61668] by abarth@webkit.org
  • 9 edits in trunk/WebCore

2010-06-23 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Rename lexer and m_lexer to tokenizer and m_tokenizer, respectively
​https://bugs.webkit.org/show_bug.cgi?id=41046

This is a follow up to the recent HTML5Lexer => HTMLTokenizer rename.

  • html/HTML5DocumentParser.cpp: (WebCore::HTML5DocumentParser::HTML5DocumentParser): (WebCore::HTML5DocumentParser::begin): (WebCore::HTML5DocumentParser::pumpLexer): (WebCore::HTML5DocumentParser::willPumpLexer): (WebCore::HTML5DocumentParser::didPumpLexer): (WebCore::HTML5DocumentParser::lineNumber): (WebCore::HTML5DocumentParser::columnNumber):
  • html/HTML5DocumentParser.h:
  • html/HTML5PreloadScanner.cpp: (WebCore::HTML5PreloadScanner::scan): (WebCore::HTML5PreloadScanner::processToken):
  • html/HTML5PreloadScanner.h:
  • html/HTML5TreeBuilder.cpp: (WebCore::HTML5TreeBuilder::HTML5TreeBuilder): (WebCore::HTML5TreeBuilder::handleScriptStartTag): (WebCore::HTML5TreeBuilder::passTokenToLegacyParser):
  • html/HTML5TreeBuilder.h:
  • html/HTMLTokenizer.h:
  • html/LegacyHTMLDocumentParser.h:
12:11 AM Changeset in webkit [61667] by Nikolas Zimmermann
  • 6 edits
    22 adds in trunk

2010-06-23 Nikolas Zimmermann <​nzimmermann@rim.com>

Reviewed by Eric Seidel.

Reproducible crash in com.apple.WebCore 0x01ed3784 WebCore::RenderLineBoxList::appendLineBox(WebCore::InlineFlowBox*) + 36
​https://bugs.webkit.org/show_bug.cgi?id=40953

REGRESSION (r58209-58231): Memory corruption with invalid SVG
​https://bugs.webkit.org/show_bug.cgi?id=40173

Fix several crashes, all related to <foreignObject> and/or invalid SVG documents.

  • Only allow <svg> nodes, as direct children of a <foreignObject>, not any other "partial" SVG content.
  • Assure to create RenderSVGRoot objects for <svg> nodes in <foreignObject>, treat them as "outermost SVG elements".
  • Never allow any partial SVG content to appear in any document. Only <svg> elements are allowed.

Tests: svg/custom/bug45331.svg

svg/foreignObject/disallowed-svg-nodes-as-direct-children.svg
svg/foreignObject/no-crash-with-svg-content-in-html-document.svg
svg/foreignObject/svg-document-as-direct-child.svg
svg/foreignObject/svg-document-in-html-document.svg
svg/foreignObject/text-tref-02-b.svg

  • dom/Element.cpp: Added childShouldCreateRenderer, with ENABLE(SVG) guards. (WebCore::Element::childShouldCreateRenderer): Only create a renderer for a SVG child, if we're a SVG element, or if the child is a <svg> element.
  • dom/Element.h: Added childShouldCreateRenderer, with ENABLE(SVG) guards.
  • svg/SVGForeignObjectElement.cpp: (WebCore::SVGForeignObjectElement::childShouldCreateRenderer): Disallow arbitary SVG content, only <svg> elements are allowed as direct children of a <foreignObject>
  • svg/SVGSVGElement.cpp: (WebCore::SVGSVGElement::isOutermostSVG): Be sure to create RenderSVGRoot objects for <svg> elements inside <foreignObject>

2010-06-23 Nikolas Zimmermann <​nzimmermann@rim.com>

Reviewed by Eric Seidel.

Reproducible crash in com.apple.WebCore 0x01ed3784 WebCore::RenderLineBoxList::appendLineBox(WebCore::InlineFlowBox*) + 36
​https://bugs.webkit.org/show_bug.cgi?id=40953

REGRESSION (r58209-58231): Memory corruption with invalid SVG
​https://bugs.webkit.org/show_bug.cgi?id=40173

Added several new layout tests covering the crashes with <foreignObject> and/or invalid SVG documents.

  • platform/mac/svg/custom/bug45331-expected.checksum: Added.
  • platform/mac/svg/custom/bug45331-expected.png: Added.
  • platform/mac/svg/custom/bug45331-expected.txt: Added.
  • platform/mac/svg/foreignObject: Added.
  • platform/mac/svg/foreignObject/disallowed-svg-nodes-as-direct-children-expected.checksum: Added.
  • platform/mac/svg/foreignObject/disallowed-svg-nodes-as-direct-children-expected.png: Added.
  • platform/mac/svg/foreignObject/disallowed-svg-nodes-as-direct-children-expected.txt: Added.
  • platform/mac/svg/foreignObject/no-crash-with-svg-content-in-html-document-expected.checksum: Added.
  • platform/mac/svg/foreignObject/no-crash-with-svg-content-in-html-document-expected.png: Added.
  • platform/mac/svg/foreignObject/no-crash-with-svg-content-in-html-document-expected.txt: Added.
  • platform/mac/svg/foreignObject/svg-document-as-direct-child-expected.checksum: Added.
  • platform/mac/svg/foreignObject/svg-document-as-direct-child-expected.png: Added.
  • platform/mac/svg/foreignObject/svg-document-as-direct-child-expected.txt: Added.
  • platform/mac/svg/foreignObject/svg-document-in-html-document-expected.checksum: Added.
  • platform/mac/svg/foreignObject/svg-document-in-html-document-expected.png: Added.
  • platform/mac/svg/foreignObject/svg-document-in-html-document-expected.txt: Added.
  • platform/mac/svg/foreignObject/text-tref-02-b-expected.checksum: Added.
  • platform/mac/svg/foreignObject/text-tref-02-b-expected.png: Added.
  • platform/mac/svg/foreignObject/text-tref-02-b-expected.txt: Added.
  • svg/custom/bug45331.svg: Added.
  • svg/foreignObject: Added.
  • svg/foreignObject/disallowed-svg-nodes-as-direct-children.svg: Added.
  • svg/foreignObject/no-crash-with-svg-content-in-html-document.svg: Added.
  • svg/foreignObject/svg-document-as-direct-child.svg: Added.
  • svg/foreignObject/svg-document-in-html-document.svg: Added.
  • svg/foreignObject/text-tref-02-b.svg: Added.
12:11 AM Changeset in webkit [61666] by hamaji@chromium.org
  • 3 edits in trunk/WebKitTools

2010-06-23 Sam Magnuson <​smagnuson@netflix.com>

Reviewed by Shinichiro Hamaji.

Follow proper convention for if/switch/while as I've discovered
them to be through my review processes.
​https://bugs.webkit.org/show_bug.cgi?id=40723

Modified test so that if( foo ) is not allowed as it appears not
to be the accepted convention.

  • Scripts/webkitpy/style/checkers/cpp.py:
  • Scripts/webkitpy/style/checkers/cpp_unittest.py:
12:02 AM Changeset in webkit [61665] by abarth@webkit.org
  • 14 edits
    2 moves in trunk/WebCore

2010-06-22 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Rename HTML5Lexer to HTMLTokenizer
​https://bugs.webkit.org/show_bug.cgi?id=41045

This might be slightly confusing given that the old class was called
HTMLTokenizer, but it matches the terminology in the HTML5 spec.

  • Android.mk:
  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • html/HTML5DocumentParser.cpp: (WebCore::HTML5DocumentParser::HTML5DocumentParser): (WebCore::HTML5DocumentParser::pumpLexer):
  • html/HTML5DocumentParser.h:
  • html/HTML5Lexer.cpp: Removed.
  • html/HTML5Lexer.h: Removed.
  • html/HTML5PreloadScanner.cpp: (WebCore::HTML5PreloadScanner::processToken):
  • html/HTML5PreloadScanner.h:
  • html/HTML5TreeBuilder.cpp: (WebCore::HTML5TreeBuilder::HTML5TreeBuilder): (WebCore::HTML5TreeBuilder::handleScriptStartTag): (WebCore::HTML5TreeBuilder::adjustedLexerState):
  • html/HTML5TreeBuilder.h:
  • html/HTMLTokenizer.cpp: Copied from WebCore/html/HTML5Lexer.cpp. (WebCore::HTMLNames::isEndTagBufferingState): (WebCore::HTMLTokenizer::HTMLTokenizer): (WebCore::HTMLTokenizer::~HTMLTokenizer): (WebCore::HTMLTokenizer::reset): (WebCore::HTMLTokenizer::processEntity): (WebCore::HTMLTokenizer::nextToken): (WebCore::HTMLTokenizer::temporaryBufferIs): (WebCore::HTMLTokenizer::addToPossibleEndTag): (WebCore::HTMLTokenizer::isAppropriateEndTag): (WebCore::HTMLTokenizer::emitCharacter): (WebCore::HTMLTokenizer::emitCodePoint): (WebCore::HTMLTokenizer::emitParseError): (WebCore::HTMLTokenizer::emitCurrentToken): (WebCore::HTMLTokenizer::shouldEmitBufferedCharacterToken):
  • html/HTMLTokenizer.h: Copied from WebCore/html/HTML5Lexer.h.
Note: See TracTimeline for information about the timeline view.